[Qemu-devel] [PATCH] hw/qdev-core: Fix description of instance_init

2018-09-10 Thread Thomas Huth
The part of the documentation of DeviceClass that talks about instance_init is partly wrong: instance_init() functions must not abort or exit, since the function is also called during introspection of the device already. So if a device calls exit() during its instance_init() function, QEMU terminat

Re: [Qemu-devel] [PATCH] qemu-img.c: add help for each command

2018-09-10 Thread Kevin Wolf
Am 08.09.2018 um 05:16 hat Programmingkid geschrieben: > > > On Sep 7, 2018, at 11:13 PM, Peter Maydell wrote: > > > > On 8 September 2018 at 04:01, John Arbuckle > > wrote: > > > >> +/* print the help for this command */ > >> +if (strcmp("--help", argv[optind + 1]) == 0) { > >> +

Re: [Qemu-devel] [PATCH V12 00/19] COLO: integrate colo frame with block replication and COLO proxy

2018-09-10 Thread Zhang Chen
Hi All. Have any comments? Ping... Thanks Zhang Chen On Mon, Sep 3, 2018 at 12:39 PM Zhang Chen wrote: > Hi~ All~ > > COLO Frame, block replication and COLO proxy(colo-compare,filter-mirror, > filter-redirector,filter-rewriter) have been exist in qemu > for long time, it's time to integrate th

Re: [Qemu-devel] [PATCH v4 00/29] postcopy+vhost-user/shared ram

2018-09-10 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Thu, Mar 08, 2018 at 07:57:42PM +, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > This set enables postcopy migration with shared memory to a vhost user > > process. > > It's based off current head. > > > >

Re: [Qemu-devel] [PATCH] pc: acpi: revert back to 1 SRAT entry for hotpluggable area

2018-09-10 Thread Igor Mammedov
On Fri, 7 Sep 2018 16:44:34 -0400 "Michael S. Tsirkin" wrote: > On Wed, Aug 22, 2018 at 11:46:44AM +0200, Igor Mammedov wrote: > > Commit > > 10efd7e108 "pc: acpi: fix memory hotplug regression by reducing stub SRAT > > entry size" > > attemped to fix hotplug regression introduced by > > 848

Re: [Qemu-devel] [PATCH] pc: make sure that guest isn't able to unplug the first cpu

2018-09-10 Thread Igor Mammedov
On Fri, 7 Sep 2018 16:52:17 -0400 "Michael S. Tsirkin" wrote: > On Wed, Aug 29, 2018 at 03:51:38PM +0200, Igor Mammedov wrote: > > On Wed, 29 Aug 2018 09:15:53 -0400 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, Aug 29, 2018 at 10:43:11AM +0200, Igor Mammedov wrote: > > > > On Wed, 29 A

Re: [Qemu-devel] [PATCH] seccomp: check TSYNC host capability

2018-09-10 Thread Eduardo Otubo
On 30/08/2018 - 16:33:48, Marc-André Lureau wrote: > Remove -sandbox option if the host is not capable of TSYNC, since the > sandbox will fail at setup time otherwise. This will help libvirt, for > ex, to figure out if -sandbox will work. > > Signed-off-by: Marc-André Lureau > --- > qemu-seccomp

[Qemu-devel] [PATCH v12 6/6] tpm: add ACPI memory clear interface

2018-09-10 Thread Marc-André Lureau
This allows to pass the last failing test from the Windows HLK TPM 2.0 TCG PPI 1.3 tests. The interface is described in the "TCG Platform Reset Attack Mitigation Specification", chapter 6 "ACPI _DSM Function". According to Laszlo, it's not so easy to implement in OVMF, he suggested to do it in qem

Re: [Qemu-devel] [PATCH] block: Fix use after free error in bdrv_open_inherit()

2018-09-10 Thread Kevin Wolf
Am 06.09.2018 um 16:25 hat Alberto Garcia geschrieben: > When a block device is opened with BDRV_O_SNAPSHOT and the > bdrv_append_temp_snapshot() call fails then the error code path tries > to unref the already destroyed 'options' QDict. > > This can be reproduced easily by setting TMPDIR to a loc

[Qemu-devel] [PATCH v12 1/6] hw/i386: add pc-i440fx-3.1 & pc-q35-3.1

2018-09-10 Thread Marc-André Lureau
The following patch is going to add compatiblity parameters. Signed-off-by: Marc-André Lureau --- include/hw/i386/pc.h | 5 - hw/i386/pc_piix.c| 15 --- hw/i386/pc_q35.c | 13 +++-- 3 files changed, 27 insertions(+), 6 deletions(-) diff --git a/include/hw/i386/p

[Qemu-devel] [PATCH v12 0/6] Add support for TPM Physical Presence interface

2018-09-10 Thread Marc-André Lureau
Hi, The following patches implement the TPM Physical Presence Interface that allows a user to set a command via ACPI (sysfs entry in Linux) that, upon the next reboot, the firmware looks for and acts upon by sending sequences of commands to the TPM. A dedicated memory region is added to the TPM C

[Qemu-devel] [PATCH v12 4/6] acpi: expose TPM/PPI configuration parameters to firmware via fw_cfg

2018-09-10 Thread Marc-André Lureau
From: Stefan Berger To avoid having to hard code the base address of the PPI virtual memory device we introduce a fw_cfg file etc/tpm/config that holds the base address of the PPI device, the version of the PPI interface and the version of the attached TPM. Signed-off-by: Stefan Berger [ Marc-A

Re: [Qemu-devel] [RFC PATCH v2 2/7] Add plugin support

2018-09-10 Thread Pavel Dovgalyuk
> From: Alex Bennée [mailto:alex.ben...@linaro.org] > Pavel Dovgalyuk writes: > > > This patch adds support for dynamically loaded plugins. > > Every plugin is a dynamic library with a set of optional exported > > functions that will be called from QEMU. > > > > Signed-off-by: Pavel Dovgalyuk >

[Qemu-devel] [PATCH v12 5/6] acpi: build TPM Physical Presence interface

2018-09-10 Thread Marc-André Lureau
From: Stefan Berger The TPM Physical Presence interface consists of an ACPI part, a shared memory part, and code in the firmware. Users can send messages to the firmware by writing a code into the shared memory through invoking the ACPI code. When a reboot happens, the firmware looks for the code

[Qemu-devel] [PATCH v12 3/6] tpm: allocate/map buffer for TPM Physical Presence interface

2018-09-10 Thread Marc-André Lureau
From: Stefan Berger Implement a virtual memory device for the TPM Physical Presence interface. The memory is located at 0xFED45000 and used by ACPI to send messages to the firmware (BIOS) and by the firmware to provide parameters for each one of the supported codes. This interface should be used

[Qemu-devel] [PATCH v12 2/6] tpm: add a "ppi" boolean property

2018-09-10 Thread Marc-André Lureau
The following patches implement the TPM Physical Presence Interface, make use of a new memory region and a fw_cfg entry. Enable PPI by default with >3.0 machine type, to avoid migration issues. Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov --- include/hw/compat.h | 11 ++-

Re: [Qemu-devel] [RFC PATCH v2 0/7] QEMU binary instrumentation prototype

2018-09-10 Thread Alex Bennée
Peter Maydell writes: >> Now I can see arguments against it from an interface complexity point of >> view but I think plugins should get access to the TCG functions so they >> can generate their own op sequences if need be and not have to call a >> helper at all if they don't need to. > > I st

Re: [Qemu-devel] [PATCH 3/6] atomic: fix comment s/x64_64/x86_64/

2018-09-10 Thread Alex Bennée
Emilio G. Cota writes: > Signed-off-by: Emilio G. Cota > --- > include/qemu/atomic.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/qemu/atomic.h b/include/qemu/atomic.h > index 9ed39effd3..de3e36f400 100644 > --- a/include/qemu/atomic.h > +++ b/include/qemu/

Re: [Qemu-devel] [PATCH 4/6] cpus: initialize timers_state.vm_clock_lock

2018-09-10 Thread Alex Bennée
Emilio G. Cota writes: > We forgot to initialize the spinlock introduced in 94377115b2 > ("cpus: protect TimerState writes with a spinlock", 2018-08-23). > Fix it. > > Signed-off-by: Emilio G. Cota > --- > cpus.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/cpus.c b/cpus.c > index

Re: [Qemu-devel] [RFC PATCH v2 7/7] plugins: add syscall logging plugin sample

2018-09-10 Thread Pavel Dovgalyuk
> From: Alex Bennée [mailto:alex.ben...@linaro.org] > Pavel Dovgalyuk writes: > > > This is an example of plugin which instruments only specific instructions: > > sysenter and sysexit. When executing them, it prints system call id > > and return code to the QEMU log. > > Again I'm not sure this

Re: [Qemu-devel] [PATCH 5/6] target/i386/translate: use thread-local storage in !user-mode

2018-09-10 Thread Alex Bennée
Emilio G. Cota writes: > Needed for MTTCG. > > Signed-off-by: Emilio G. Cota > --- > target/i386/translate.c | 24 > 1 file changed, 16 insertions(+), 8 deletions(-) > > diff --git a/target/i386/translate.c b/target/i386/translate.c > index 1f9d1d9b24..9a6a72e205 1006

Re: [Qemu-devel] [PATCH] block: Fix use after free error in bdrv_open_inherit()

2018-09-10 Thread Alberto Garcia
On Mon 10 Sep 2018 10:34:20 AM CEST, Kevin Wolf wrote: > Am 06.09.2018 um 16:25 hat Alberto Garcia geschrieben: >> When a block device is opened with BDRV_O_SNAPSHOT and the >> bdrv_append_temp_snapshot() call fails then the error code path tries >> to unref the already destroyed 'options' QDict.

Re: [Qemu-devel] [PATCH v2 1/2] gitmodules: add berkeley's softfloat + testfloat version 3

2018-09-10 Thread Alex Bennée
Emilio G. Cota writes: > These are BSD-licensed so we can add them as submodules. > > Signed-off-by: Emilio G. Cota > --- > .gitmodules | 6 ++ > tests/fp/berkeley-softfloat-3 | 1 + > tests/fp/berkeley-testfloat-3 | 1 + > 3 files changed, 8 insertions(+) > create mode

[Qemu-devel] [PATCH] qemu-iotests: Test snapshot=on with nonexistent TMPDIR

2018-09-10 Thread Alberto Garcia
We just fixed a bug that was causing a use-after-free when QEMU was unable to create a temporary snapshot. This is a test case for this scenario. Signed-off-by: Alberto Garcia --- tests/qemu-iotests/051| 3 +++ tests/qemu-iotests/051.out| 3 +++ tests/qemu-iotests/051.pc.out | 3 +++

Re: [Qemu-devel] [Qemu-block] [PATCH v0 0/2] Postponed actions

2018-09-10 Thread Denis Plotnikov
PING PING! On 28.08.2018 13:23, Denis Plotnikov wrote: On 27.08.2018 19:05, John Snow wrote: On 08/27/2018 03:05 AM, Denis Plotnikov wrote: PING! PING! Sorry, Kevin and Stefan are both on PTO right now, I think. I can't promise I have the time to look soon, but you at least deserve an a

Re: [Qemu-devel] [PATCH] qemu-iotests: Test snapshot=on with nonexistent TMPDIR

2018-09-10 Thread Kevin Wolf
Am 10.09.2018 um 11:29 hat Alberto Garcia geschrieben: > We just fixed a bug that was causing a use-after-free when QEMU was > unable to create a temporary snapshot. This is a test case for this > scenario. > > Signed-off-by: Alberto Garcia Hm, it actually doesn't crash for me even without the f

Re: [Qemu-devel] [PATCH v10 6/6] tpm: add ACPI memory clear interface

2018-09-10 Thread Dr. David Alan Gilbert
* Laszlo Ersek (ler...@redhat.com) wrote: > On 09/06/18 19:23, Dr. David Alan Gilbert wrote: > > * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > >> Hi > >> > >> On Thu, Sep 6, 2018 at 1:42 PM Dr. David Alan Gilbert > >> wrote: > >>> > >>> * Marc-André Lureau (marcandre.lur...@gmail.com)

Re: [Qemu-devel] [PATCH] qemu-iotests: Test snapshot=on with nonexistent TMPDIR

2018-09-10 Thread Alberto Garcia
On Mon 10 Sep 2018 11:57:48 AM CEST, Kevin Wolf wrote: > Am 10.09.2018 um 11:29 hat Alberto Garcia geschrieben: >> We just fixed a bug that was causing a use-after-free when QEMU was >> unable to create a temporary snapshot. This is a test case for this >> scenario. >> >> Signed-off-by: Alberto Ga

Re: [Qemu-devel] [PATCH v2 2/2] tests: add floating point tests

2018-09-10 Thread Alex Bennée
Emilio G. Cota writes: > By leveraging berkeley's softfloat and testfloat. > > fp-test.c is derived from testfloat's testsoftfloat.c. To ease > the tracking of upstream changes to the latter file, fp-test.c > keeps the original camel-case variable naming, and includes > most new code via wrap.i

[Qemu-devel] [PATCH 0/3] spapr: introduce a new sPAPRIrq backend

2018-09-10 Thread Cédric Le Goater
Hello, This series adds a new sPAPRIrq backend increasing the number of available IRQ numbers in pseries-3.1 machines. This change is an opportunity to also fix the "ibm,pe-total-#msi" and remove the old XICS_IRQS_SPAPR definition. Thanks, C. Cédric Le Goater (3): spapr: introduce a spapr_irq

[Qemu-devel] [PATCH 1/3] spapr: introduce a spapr_irq class 'nr_msis' attribute

2018-09-10 Thread Cédric Le Goater
The number of MSI interrupts a sPAPR machine can allocate is in direct relation with the number of interrupts of the sPAPRIrq backend. Define statically this value at the sPAPRIrq class level. Signed-off-by: Cédric Le Goater --- include/hw/ppc/spapr_irq.h | 1 + hw/ppc/spapr_irq.c | 9 ++

[Qemu-devel] [PATCH 2/3] spapr: increase the size of the IRQ number space

2018-09-10 Thread Cédric Le Goater
The new layout using static IRQ number does not leave much space to the dynamic MSI range, only 0x100 IRQ numbers. Increase the total number of IRQS for newer machines and introduce a legacy XICS backend for pre-3.1 machines to maintain compatibility. For the old backend, provide a 'nr_msis' value

[Qemu-devel] [PATCH 3/3] spapr_pci: fix "ibm,pe-total-#msi" value

2018-09-10 Thread Cédric Le Goater
The "ibm,pe-total-#msi" property of the sPAPR PHB defines the number of allocatable MSI interrupts. This is currently set to XICS_IRQS_SPAPR which covers the full IRQ number space of the machine. This is wrong. Fix the definition by using the 'nr_msis' attribute of the sPAPRIrq class and remove XI

Re: [Qemu-devel] [PATCH v2 0/2] softfloat tests based on berkeley's testfloat

2018-09-10 Thread Alex Bennée
Emilio G. Cota writes: > A few fixes since yesterday's v1: > https://lists.gnu.org/archive/html/qemu-devel/2018-09/msg00884.html > > - Convert copy_qemu_to_soft80 to qemu_to_soft80, just like the other > conversion functions > - Set fp-test as the program name as reported by itself > - Fix

[Qemu-devel] [PATCH v2] target/ppc: add external PID support

2018-09-10 Thread Roman Kapl
External PID is a mechanism present on BookE 2.06 that enables application to store/load data from different address spaces. There are special version of some instructions, which operate on alternate address space, which is described in the EPLC/EPSC regiser. This implementation uses two additiona

Re: [Qemu-devel] [RFC PATCH v2 0/7] QEMU binary instrumentation prototype

2018-09-10 Thread Pavel Dovgalyuk
> From: Alex Bennée [mailto:alex.ben...@linaro.org] > Peter Maydell writes: > > > >> Now I can see arguments against it from an interface complexity point of > >> view but I think plugins should get access to the TCG functions so they > >> can generate their own op sequences if need be and not h

Re: [Qemu-devel] [RFC PATCH v2 2/7] Add plugin support

2018-09-10 Thread Pavel Dovgalyuk
> From: Alex Bennée [mailto:alex.ben...@linaro.org] > Pavel Dovgalyuk writes: > > > This patch adds support for dynamically loaded plugins. > > Every plugin is a dynamic library with a set of optional exported > > functions that will be called from QEMU. > > > > > + > > +static QLIST_HEAD(, Qemu

Re: [Qemu-devel] [PATCH] hw/qdev-core: Fix description of instance_init

2018-09-10 Thread Andreas Färber
Am 10.09.18 um 10:09 schrieb Thomas Huth: > The part of the documentation of DeviceClass that talks about instance_init > is partly wrong: instance_init() functions must not abort or exit, since > the function is also called during introspection of the device already. > So if a device calls exit()

Re: [Qemu-devel] [PATCH] RISC-V - Dynamic parameterization of RISC-V memory map

2018-09-10 Thread Paolo Bonzini
On 06/09/2018 17:44, Peter Maydell wrote: > On 6 September 2018 at 16:07, Michael Eager wrote: >> Any comments? > I'd quite like to hear from somebody more familiar with the > readconfig/writeconfig stuff than me about whether this > very riscv-centric approach makes sense and fits with how > the

Re: [Qemu-devel] [PATCH] RISC-V - Dynamic parameterization of RISC-V memory map

2018-09-10 Thread Paolo Bonzini
On 07/09/2018 02:21, Michael Eager wrote: > It could also be extended to describe other processor features, for > example, the number of cores. The number of cores is already described via -smp, isn't it? Paolo

Re: [Qemu-devel] [PATCH 5/6] target/i386/translate: use thread-local storage in !user-mode

2018-09-10 Thread Emilio G. Cota
On Mon, Sep 10, 2018 at 10:17:53 +0100, Alex Bennée wrote: > > Emilio G. Cota writes: > > > Needed for MTTCG. > > > > Signed-off-by: Emilio G. Cota > > --- > > target/i386/translate.c | 24 > > 1 file changed, 16 insertions(+), 8 deletions(-) > > > > diff --git a/targe

Re: [Qemu-devel] [PATCH v0 2/2] block: postpone the coroutine executing if the BDS's is drained

2018-09-10 Thread Kevin Wolf
Am 29.06.2018 um 14:40 hat Denis Plotnikov geschrieben: > Fixes the problem of ide request appearing when the BDS is in > the "drained section". > > Without the patch the request can come and be processed by the main > event loop, as the ide requests are processed by the main event loop > and the

Re: [Qemu-devel] [3/4] cpus: protect TimerState writes with a spinlock

2018-09-10 Thread Paolo Bonzini
On 10/09/2018 07:36, Pavel Dovgalyuk wrote: > After locking here, > >> if (runstate_is_running()) { >> int64_t clock = REPLAY_CLOCK(REPLAY_CLOCK_VIRTUAL_RT, >> cpu_get_clock_locked()); > REPLAY_CLOCK can't request icount with cpu_get_icount_raw,

Re: [Qemu-devel] [PATCH] replay: wake up vCPU when replaying

2018-09-10 Thread Paolo Bonzini
On 09/07/2018 13:24, Pavel Dovgalyuk wrote: > static void qemu_tcg_rr_wait_io_event(CPUState *cpu) > { > while (all_cpu_threads_idle()) { > stop_tcg_kick_timer(); > qemu_cond_wait(cpu->halt_cond, &qemu_global_mutex); > } > > start_tcg_kick_timer(); > > qemu_wait_io

[Qemu-devel] [RESEND PATCH v2 4/4] wdt_z069: Add support for MEN 16z069 Watchdog

2018-09-10 Thread Johannes Thumshirn
Add 16z069 Watchdog over MEN Chameleon BUS emulation. Signed-off-by: Johannes Thumshirn --- hw/watchdog/Makefile.objs | 1 + hw/watchdog/wdt_z069.c| 215 ++ 2 files changed, 216 insertions(+) create mode 100644 hw/watchdog/wdt_z069.c diff --git

[Qemu-devel] [RESEND PATCH v2 1/4] Add MEN Chameleon Bus emulation

2018-09-10 Thread Johannes Thumshirn
The MEN Chameleon Bus (MCB) is an on-chip bus system exposing IP Cores of an FPGA to a outside bus system like PCIe. Signed-off-by: Johannes Thumshirn --- default-configs/pci.mak | 1 + hw/Makefile.objs| 1 + hw/mcb/Makefile.objs| 1 + hw/mcb/mcb.c| 180

Re: [Qemu-devel] [PATCH v10 6/6] tpm: add ACPI memory clear interface

2018-09-10 Thread Marc-André Lureau
Hi On Mon, Sep 10, 2018 at 2:44 PM Dr. David Alan Gilbert wrote: > (I didn't know about guest_phys_block* and would have probably just used > qemu_ram_foreach_block ) > guest_phys_block*() seems to fit, as it lists only the blocks actually used, and already skip the device RAM. Laszlo, you wrot

[Qemu-devel] [RESEND PATCH v2 2/4] Add MEN Chameleon Bus via PCI carrier

2018-09-10 Thread Johannes Thumshirn
Signed-off-by: Johannes Thumshirn --- hw/mcb/Makefile.objs | 1 + hw/mcb/mcb-pci.c | 305 +++ 2 files changed, 306 insertions(+) create mode 100644 hw/mcb/mcb-pci.c diff --git a/hw/mcb/Makefile.objs b/hw/mcb/Makefile.objs index 32427c987c44.

[Qemu-devel] [RESEND PATCH v2 0/4] Add support for Men Chameleon Bus emulation

2018-09-10 Thread Johannes Thumshirn
This is a re-send of the last version from 9 Aug 2018 13:40:13 +0200. This series adds support for emulating FPGAs by Men Mikroelektronik Nürnberg and expose the FPGA itself as a bus. The IP-Cores implemented in the FPGA are represented as devices hanging off that bus. This is the same aproach tha

[Qemu-devel] [RESEND PATCH v2 3/4] serial-mcb: Add serial via MEN chameleon bus

2018-09-10 Thread Johannes Thumshirn
Add MEN z125 UART over MEN Chameleon Bus emulation. Signed-off-by: Johannes Thumshirn --- hw/char/Makefile.objs | 1 + hw/char/serial-mcb.c | 100 ++ 2 files changed, 101 insertions(+) create mode 100644 hw/char/serial-mcb.c diff --git a/hw/ch

Re: [Qemu-devel] [RFC PATCH v2 7/7] plugins: add syscall logging plugin sample

2018-09-10 Thread Alex Bennée
Pavel Dovgalyuk writes: >> From: Alex Bennée [mailto:alex.ben...@linaro.org] >> Pavel Dovgalyuk writes: >> >> > This is an example of plugin which instruments only specific instructions: >> > sysenter and sysexit. When executing them, it prints system call id >> > and return code to the QEMU l

Re: [Qemu-devel] [PATCH 5/6] target/i386/translate: use thread-local storage in !user-mode

2018-09-10 Thread Alex Bennée
Emilio G. Cota writes: > On Mon, Sep 10, 2018 at 10:17:53 +0100, Alex Bennée wrote: >> >> Emilio G. Cota writes: >> >> > Needed for MTTCG. >> > >> > Signed-off-by: Emilio G. Cota >> > --- >> > target/i386/translate.c | 24 >> > 1 file changed, 16 insertions(+), 8 del

[Qemu-devel] [PATCH v2] hostmem: no need to check for host_memory_backend_mr_inited() in alloc()

2018-09-10 Thread Marc-André Lureau
memfd_backend_memory_alloc/file_backend_memory_alloc both needlessly are are calling host_memory_backend_mr_inited() which creates an illusion that alloc could be called multiple times but it isn't, it's called once from UserCreatable complete(). Suggested-by: Igor Mammedov Signed-off-by: Marc-An

[Qemu-devel] [Bug 1791680] [NEW] network bridge does not work

2018-09-10 Thread Jan Marti
Public bug reported: hi there the network bridge does not seem to work described as here: https://en.wikibooks.org/wiki/QEMU/Networking When i add that parameters in a 192.168.80.x subnet, my emulated raspbian ARM gets the IP 10.0.2.15 While all other computers get 192.168.80.x The command

Re: [Qemu-devel] [PATCH v2] qga: ignore non present cpus when handling qmp_guest_get_vcpus()

2018-09-10 Thread Marc-André Lureau
On Thu, Sep 6, 2018 at 5:00 PM Igor Mammedov wrote: > > If VM has VCPUs plugged sparselly (for example a VM started with > 3 VCPUs (cpu0, cpu1 and cpu2) and then cpu1 was hotunplugged so > only cpu0 and cpu2 are present), QGA will rise a error > error: internal error: unable to execute QEMU agen

Re: [Qemu-devel] [qemu-s390x] [RFC 08/15] s390-bios: Map low core memory

2018-09-10 Thread Jason J. Herne
On 07/17/2018 02:10 PM, Thomas Huth wrote: On 05.07.2018 19:25, Jason J. Herne wrote: From: "Jason J. Herne" Create a new header for basic architecture specific definitions and add a mapping of low core memory. This mapping will be used by the real dasd boot process. Signed-off-by: Jason J. H

[Qemu-devel] [Bug 1791680] Re: network bridge does not work

2018-09-10 Thread Jan Marti
10.0.2.15 is neither a ip in our dhcp range nor an apipa address - strange -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1791680 Title: network bridge does not work Status in QEMU: New Bug desc

Re: [Qemu-devel] [PATCH] qemu-img.c: add help for each command

2018-09-10 Thread Programmingkid
> On Sep 10, 2018, at 4:16 AM, Kevin Wolf wrote: > > Am 08.09.2018 um 05:16 hat Programmingkid geschrieben: >> >>> On Sep 7, 2018, at 11:13 PM, Peter Maydell wrote: >>> >>> On 8 September 2018 at 04:01, John Arbuckle >>> wrote: >>> +/* print the help for this command */ +

[Qemu-devel] [Bug 1791680] Re: network bridge does not work

2018-09-10 Thread Jan Marti
J:\Tools\qemu>qemu-system-arm.exe -M versatilepb -cpu arm1176 -hda 2018-09-03_stretch_inkl_phalcon.img -kernel kernel-qe mu-4.4.34-jessie -m 192 -append "root=/dev/sda2 panic=1 rootfstype=ext4 rw" -no-reboot -net nic -net user -device e1000, mac=52:54:00:12:34:56 WARNING: Image format was not spe

[Qemu-devel] [Bug 1791680] Re: network bridge does not work

2018-09-10 Thread Jan Marti
Yes, looks like nat - 10.10.2.15 is not pingable from 192.168.80.x but vice versa... but wqhat they write here is not nat: "If no network options are specified, QEMU will default to emulating a single Intel e1000 PCI card with a user-mode network stack that bridges to the host's network. The follo

[Qemu-devel] [Bug 1791680] Re: network bridge does not work

2018-09-10 Thread Jan Marti
but google is pingable, so i have internet. must be nat, right?? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1791680 Title: network bridge does not work Status in QEMU: New Bug description:

Re: [Qemu-devel] [PATCH v8 0/8] Take the image size into account when allocating the L2 cache

2018-09-10 Thread Kevin Wolf
Hi Leonid, Am 13.08.2018 um 03:07 hat Leonid Bloch geschrieben: > This series makes the qcow2 L2 cache assignment aware of the image size, > with the intention for it to cover the entire image. The importance of > this change is in noticeable performance improvement, especially with > heavy random

Re: [Qemu-devel] [PATCH v2 2/2] tests: add floating point tests

2018-09-10 Thread Emilio G. Cota
On Mon, Sep 10, 2018 at 12:00:56 +0100, Alex Bennée wrote: > Emilio G. Cota writes: > > diff --git a/tests/Makefile.include b/tests/Makefile.include > > index 87c81d1dcc..363f133101 100644 > > --- a/tests/Makefile.include > > +++ b/tests/Makefile.include > > @@ -657,6 +657,9 @@ tests/qht-bench$(EX

[Qemu-devel] [PATCH 0/2] virtio-scsi: Fix QEMU hang with vIOMMU and ATS

2018-09-10 Thread Fam Zheng
The first patch describes the bug and the reproducer. The VQ poll handler that is called by mistake within virtio_scsi_dataplane_stop enters a dead loop because it fails to detect an error state. Fix both sides of the problem: the handler should break out from the loop if no progress can be made d

[Qemu-devel] [Bug 1791680] Re: network bridge does not work

2018-09-10 Thread Thomas Huth
That comment about e1000 is only true for qemu-system-i386. For ARM machines, there are other default NICs. You should also not mix "-net" and "-device", see https://www.qemu.org/2018/05/31/nic-parameter/ for some details. And concerning NAT, yes the "user" backend is using NAT, see https://wiki.qe

Re: [Qemu-devel] [PATCH v3 1/8] dirty-bitmap: improve bdrv_dirty_bitmap_next_zero

2018-09-10 Thread Eric Blake
On 9/7/18 4:49 PM, John Snow wrote: On 08/14/2018 08:14 AM, Vladimir Sementsov-Ogievskiy wrote: Add bytes parameter to the function, to limit searched range. I'm going to assume that Eric Blake has been through here and commented on the interface itself. Actually, I haven't had time to lo

[Qemu-devel] [PATCH 2/2] virtio-scsi/virtio-blk: Disable poll handlers when stopping vq handler

2018-09-10 Thread Fam Zheng
We have this unwanted call stack: > ... > #13 0x5586602b7793 in virtio_scsi_handle_cmd_vq > #14 0x5586602b8d66 in virtio_scsi_data_plane_handle_cmd > #15 0x5586602ddab7 in virtio_queue_notify_aio_vq > #16 0x5586602dfc9f in virtio_queue_host_notifier_aio_poll > #17 0x000

[Qemu-devel] [PATCH 1/2] virtio: Return true from virtio_queue_empty if broken

2018-09-10 Thread Fam Zheng
Both virtio-blk and virtio-scsi use virtio_queue_empty() as the loop condition in VQ handlers (virtio_blk_handle_vq, virtio_scsi_handle_cmd_vq). When a device is marked broken in virtqueue_pop, for example if a vIOMMU address translation failed, we want to break out of the loop. This fixes a hangi

Re: [Qemu-devel] [PATCH 0/3] spapr: introduce a new sPAPRIrq backend

2018-09-10 Thread Greg Kurz
On Mon, 10 Sep 2018 13:02:19 +0200 Cédric Le Goater wrote: > Hello, > > This series adds a new sPAPRIrq backend increasing the number of > available IRQ numbers in pseries-3.1 machines. This change is an > opportunity to also fix the "ibm,pe-total-#msi" and remove the old > XICS_IRQS_SPAPR defin

Re: [Qemu-devel] backend for blk or fs with guaranteed blocking/synchronous I/O

2018-09-10 Thread Artem Pisarenko
It looks like things are even worse. Guest demonstrates strange timings even without access to anything external to machine. I've added Paolo Bonzini to CC, because issue looks related to cpu/tcg/memory stuff. I've written simple test script running parallel 'dd' utility processes operating on fil

Re: [Qemu-devel] [PATCH] block/file-posix: fix the wrong result of find_allocation() in macOS.

2018-09-10 Thread Eric Blake
On 9/8/18 10:34 AM, Peter Maydell wrote: On 8 September 2018 at 15:15, Yan-Jie Wang wrote: In macOS, lseek with SEEK_DATA behaves differently. It seeks to the next data region even though offset is in the middle of a data region. In addition, there may be many data regions without any hole amon

[Qemu-devel] [Bug 1791680] Re: network bridge does not work

2018-09-10 Thread Jan Marti
"That comment about e1000 is only true for qemu-system-i386. For ARM machines, there are other default NICs." but why im able to ping google with that config?? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.ne

[Qemu-devel] [Bug 1791680] Re: network bridge does not work

2018-09-10 Thread Jan Marti
"-nic tap,model=e1000" -> "Device 'tap' colud not be found -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1791680 Title: network bridge does not work Status in QEMU: Invalid Bug description:

[Qemu-devel] [Bug 1791680] Re: network bridge does not work

2018-09-10 Thread Jan Marti
currently, only one nic adapter is enabled on my win10 host: the ethernet controller. the other 2, 1x internal wlan and 1x usb wlan is disabled.. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1791680

[Qemu-devel] [Bug 1791680] Re: network bridge does not work

2018-09-10 Thread Jan Marti
when i only use "-net nic", i get an apipa address -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1791680 Title: network bridge does not work Status in QEMU: Invalid Bug description: hi there

[Qemu-devel] [Bug 1791680] Re: network bridge does not work

2018-09-10 Thread Jan Marti
OK thx. "The -device option can only be used for pluggable NICs. Boards (e.g. embedded boards) which feature an on-board NIC cannot be configured with -device yet, so -net nic,netdev= must be used here instead." -- You received this bug notification because you are a member of qemu- devel-ml, wh

[Qemu-devel] [Bug 1791680] Re: network bridge does not work

2018-09-10 Thread Jan Marti
what do i need for netdev id? n1 as described in your links does not work. messsage: "netdev 'n1' not found" -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1791680 Title: network bridge does not wor

Re: [Qemu-devel] [PATCH v2 0/2] softfloat tests based on berkeley's testfloat

2018-09-10 Thread Emilio G. Cota
On Mon, Sep 10, 2018 at 12:26:58 +0100, Alex Bennée wrote: > > Emilio G. Cota writes: > > > A few fixes since yesterday's v1: > > https://lists.gnu.org/archive/html/qemu-devel/2018-09/msg00884.html > > > > - Convert copy_qemu_to_soft80 to qemu_to_soft80, just like the other > > conversion fu

[Qemu-devel] [Bug 1791680] Re: network bridge does not work

2018-09-10 Thread Jan Marti
incompatible with windows, right? so i need a linux machine with ethx?? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1791680 Title: network bridge does not work Status in QEMU: Invalid Bug des

Re: [Qemu-devel] [PATCH v2] job: Fix nested aio_poll() hanging in job_txn_apply

2018-09-10 Thread Kevin Wolf
Am 24.08.2018 um 04:43 hat Fam Zheng geschrieben: > All callers have acquired ctx already. Doing that again results in > aio_poll() hang. This fixes the problem that a BDRV_POLL_WHILE() in the > callback cannot make progress because ctx is recursively locked, for > example, when drive-backup finish

Re: [Qemu-devel] [PATCH for-3.1 v10 00/31] block: Fix some filename generation issues

2018-09-10 Thread Kevin Wolf
Am 09.08.2018 um 23:34 hat Max Reitz geschrieben: > Once more, I’ll spare both me and you another iteration of the cover > letter, so see here: > > http://lists.nongnu.org/archive/html/qemu-block/2017-09/msg01030.html > > (Although this series no longer includes a @base-directory option.) > > In

Re: [Qemu-devel] [PATCH v2 0/2] softfloat tests based on berkeley's testfloat

2018-09-10 Thread Alex Bennée
Emilio G. Cota writes: > On Mon, Sep 10, 2018 at 12:26:58 +0100, Alex Bennée wrote: >> >> Emilio G. Cota writes: >> >> > A few fixes since yesterday's v1: >> > https://lists.gnu.org/archive/html/qemu-devel/2018-09/msg00884.html >> > >> > - Convert copy_qemu_to_soft80 to qemu_to_soft80, just

Re: [Qemu-devel] [PATCH 1/6] qsp: drop atomics when using the seqlock

2018-09-10 Thread Emilio G. Cota
On Mon, Sep 10, 2018 at 01:32:15 +0200, Paolo Bonzini wrote: > On 03/09/2018 19:18, Emilio G. Cota wrote: > > Using atomics here is a mistake since they're not guaranteed > > to compile. > > But isn't it technically a C11 data race if you don't use atomics? Yes, it's undefined behaviour. > Could

Re: [Qemu-devel] [PATCH] qemu-iotests: Test snapshot=on with nonexistent TMPDIR

2018-09-10 Thread Eric Blake
On 9/10/18 4:57 AM, Kevin Wolf wrote: Am 10.09.2018 um 11:29 hat Alberto Garcia geschrieben: We just fixed a bug that was causing a use-after-free when QEMU was unable to create a temporary snapshot. This is a test case for this scenario. Signed-off-by: Alberto Garcia Hm, it actually doesn't

[Qemu-devel] [Bug 1791680] Re: network bridge does not work

2018-09-10 Thread Jan Marti
https://bugs.launchpad.net/qemu/+bug/1404278 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1791680 Title: network bridge does not work Status in QEMU: Invalid Bug description: hi there the

Re: [Qemu-devel] [PATCH v3 1/8] dirty-bitmap: improve bdrv_dirty_bitmap_next_zero

2018-09-10 Thread John Snow
On 09/10/2018 10:59 AM, Eric Blake wrote: > On 9/7/18 4:49 PM, John Snow wrote: >> >> >> On 08/14/2018 08:14 AM, Vladimir Sementsov-Ogievskiy wrote: >>> Add bytes parameter to the function, to limit searched range. >>> >> >> I'm going to assume that Eric Blake has been through here and commented

Re: [Qemu-devel] [PATCH for-3.1 v10 04/31] block: Add BDS.auto_backing_file

2018-09-10 Thread Alberto Garcia
On Fri 07 Sep 2018 02:42:53 PM CEST, Max Reitz wrote: > The whole purpose of bs->auto_backing_file is so you can compare it > with bs->backing->bs->filename, see when it differs, and then you know > that the user has changed the backing file from what it would be based > on the image header alone (

Re: [Qemu-devel] [PATCH V9 2/4] tests/migration: Support cross compilation in generating boot header file

2018-09-10 Thread Alex Bennée
Wei Huang writes: > Recently a new configure option, CROSS_CC_GUEST, was added to > $(TARGET)-softmmu/config-target.mak to support TCG-related tests. This > patch tries to leverage this option to support cross compilation when the > migration boot block file is being re-generated: > > * The x8

[Qemu-devel] [Bug 1404278] Re: tap connections not working on windows host

2018-09-10 Thread Jan Marti
"it works with qemu-w64-setup-20180519.exe" not really: J:\Tools\qemu>.\run.bat J:\Tools\qemu>qemu-system-arm.exe -M versatilepb -cpu arm1176 -hda 2018-09-03_stretch_inkl_phalcon.img -kernel kernel-qe mu-4.4.34-jessie -m 512 -append "root=/dev/sda2 panic=1 rootfstype=ext4 rw init=/bin/bash" -no

Re: [Qemu-devel] [PATCH v2 0/2] softfloat tests based on berkeley's testfloat

2018-09-10 Thread Emilio G. Cota
On Mon, Sep 10, 2018 at 16:41:21 +0100, Alex Bennée wrote: > > Emilio G. Cota writes: > > > On Mon, Sep 10, 2018 at 12:26:58 +0100, Alex Bennée wrote: > >> > >> Emilio G. Cota writes: > >> > >> > A few fixes since yesterday's v1: > >> > https://lists.gnu.org/archive/html/qemu-devel/2018-09/ms

[Qemu-devel] [Bug 1404278] Re: tap connections not working on windows host

2018-09-10 Thread Jan Marti
when i install tap driver from https://openvpn.net/index.php/open- source/downloads.html im able to start with tap01 (when i rename the tap interface to "tap01"..) but on start i get an apipa address with that config: qemu-system-arm.exe -M versatilepb -cpu arm1176 -hda 2018-09-03_stretch_inkl_ph

Re: [Qemu-devel] [PATCH] qemu-iotests: Test snapshot=on with nonexistent TMPDIR

2018-09-10 Thread Alberto Garcia
On Mon 10 Sep 2018 05:55:15 PM CEST, Eric Blake wrote: >> Hm, it actually doesn't crash for me even without the fix. Anyway, I >> don't have a good idea to make it more likely to crash and it's >> certainly better than nothing. > > Does running the test under valgrind reliably see the use-after-fre

Re: [Qemu-devel] [PATCH v3 1/8] dirty-bitmap: improve bdrv_dirty_bitmap_next_zero

2018-09-10 Thread Vladimir Sementsov-Ogievskiy
08.09.2018 00:49, John Snow wrote: On 08/14/2018 08:14 AM, Vladimir Sementsov-Ogievskiy wrote: Add bytes parameter to the function, to limit searched range. I'm going to assume that Eric Blake has been through here and commented on the interface itself. Signed-off-by: Vladimir Sementsov-Ogi

Re: [Qemu-devel] [PATCH for-3.1 v10 00/31] block: Fix some filename generation issues

2018-09-10 Thread Max Reitz
On 10.09.18 17:18, Kevin Wolf wrote: > Am 09.08.2018 um 23:34 hat Max Reitz geschrieben: >> Once more, I’ll spare both me and you another iteration of the cover >> letter, so see here: >> >> http://lists.nongnu.org/archive/html/qemu-block/2017-09/msg01030.html >> >> (Although this series no longer

Re: [Qemu-devel] [PATCH V9 2/4] tests/migration: Support cross compilation in generating boot header file

2018-09-10 Thread Juan Quintela
Alex Bennée wrote: D> Wei Huang writes: > >> Recently a new configure option, CROSS_CC_GUEST, was added to >> $(TARGET)-softmmu/config-target.mak to support TCG-related tests. This >> patch tries to leverage this option to support cross compilation when the >> migration boot block file is being r

Re: [Qemu-devel] [PATCH v3 1/8] dirty-bitmap: improve bdrv_dirty_bitmap_next_zero

2018-09-10 Thread Eric Blake
On 9/10/18 11:49 AM, Vladimir Sementsov-Ogievskiy wrote: -int64_t hbitmap_next_zero(const HBitmap *hb, uint64_t start); +int64_t hbitmap_next_zero(const HBitmap *hb, uint64_t start, int64_t end); The interface looks weird because we can define a 'start' that's beyond the 'end'. I realize that

Re: [Qemu-devel] [PATCH v3 1/8] dirty-bitmap: improve bdrv_dirty_bitmap_next_zero

2018-09-10 Thread Vladimir Sementsov-Ogievskiy
10.09.2018 19:55, Eric Blake wrote: On 9/10/18 11:49 AM, Vladimir Sementsov-Ogievskiy wrote: -int64_t hbitmap_next_zero(const HBitmap *hb, uint64_t start); +int64_t hbitmap_next_zero(const HBitmap *hb, uint64_t start, int64_t end); The interface looks weird because we can define a 'start' tha

[Qemu-devel] [Bug 1404278] Re: tap connections not working on windows host

2018-09-10 Thread Jan Marti
static ip does also not work, can't reach other machines in my own subnet: qemu-system-arm.exe -M versatilepb -cpu arm1176 -hda 2018-09-03_stretch_inkl_phalcon.img -kernel kernel-qemu-4.4.34-jessie -m 512 -append "root=/dev/sda2 panic=1 rootfstype=ext4 rw ip=192.168.80.252::192.168.80.1:255.255.25

Re: [Qemu-devel] [PATCH V9 2/4] tests/migration: Support cross compilation in generating boot header file

2018-09-10 Thread Wei Huang
On 09/10/2018 11:18 AM, Alex Bennée wrote: > > Wei Huang writes: > >> Recently a new configure option, CROSS_CC_GUEST, was added to >> $(TARGET)-softmmu/config-target.mak to support TCG-related tests. This >> patch tries to leverage this option to support cross compilation when the >> migrati

[Qemu-devel] [Bug 1791763] [NEW] broken signal handling in nios2 user-mode emulation

2018-09-10 Thread Sandra Loosemore
Public bug reported: This bug is against the 3.0 release. It appears that the signal handling parts of the nios2 user-mode emulation have never really been completed or tested. Some examples of failing tests from the GCC testsuite are gcc.dg/pr78185.c and gcc.dg/cleanup-10.c. Some problems I've

  1   2   >