On Tue, Sep 04, 2018 at 08:17:54AM +0200, Markus Armbruster wrote:
> Peter Xu writes:
>
> > On Mon, Sep 03, 2018 at 03:16:55PM +0200, Markus Armbruster wrote:
> >> Peter Xu writes:
> >>
> >> > On Mon, Sep 03, 2018 at 09:38:00AM +0200, Markus Armbruster wrote:
> >> >> Peter Xu writes:
> >> >>
The files have a json suffix but look terrible with json syntax
hilighting enabled. Add a magic modeline for vim to switch to python
file format for hilighting similarly to the emacs modeline already
present.
Signed-off-by: Peter Krempa
---
qapi/block-core.json | 1 +
qapi/block.json | 1
When cross-compiling QEMU for a target that significantly differs from
the host, the current information in config.status is not enough to
properly re-create the configuration. For example when I try to test
my build with the mingw32 cross-compiler, I regularly get this error
after the build system
Peter Xu writes:
> On Mon, Sep 03, 2018 at 03:41:16PM +0100, Daniel P. Berrangé wrote:
>> On Mon, Sep 03, 2018 at 09:30:52AM -0500, Eric Blake wrote:
>> > On 09/03/2018 08:31 AM, Markus Armbruster wrote:
>> >
>> > > Example:
>> > >
>> > > client sends in-band command #1
>> > > QEMU re
On Tue, Sep 04, 2018 at 11:07:38AM +0800, Jason Wang wrote:
>
>
> On 2018年09月03日 19:54, Daniel P. Berrangé wrote:
> > > + *
> > > + * This work is licensed under the terms of the GNU GPL, version 2 or
> > > later.
> > > + * See the COPYING file in the top-level directory.
> > > + *
> > > + */
>
On Tue, Sep 04, 2018 at 08:39:27AM +0200, Markus Armbruster wrote:
> Daniel P. Berrangé writes:
>
> > On Mon, Sep 03, 2018 at 09:30:52AM -0500, Eric Blake wrote:
> >> On 09/03/2018 08:31 AM, Markus Armbruster wrote:
> >>
> >> > Example:
> >> >
> >> > client sends in-band command #1
> >> >
after coalesced pio series patches, the patch is a supplement to
q35 pci-host config port.
Signed-off-by: Peng Hao
---
hw/pci-host/q35.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c
index 02f9576..8ce1e09 100644
--- a/hw/pci-host/q35.c
+++ b/hw/pc
* Quan Xu (quan@gmail.com) wrote:
> From 8dbf7370e7ea1caab0b769d0d4dcdd072d14d421 Mon Sep 17 00:00:00 2001
> From: Quan Xu
> Date: Wed, 29 Aug 2018 21:33:14 +0800
> Subject: [PATCH RFC] migration: make sure to run iterate precopy during the
> bulk stage
>
> Since the bulk stage assumes in (m
Quan Xu wrote:
> From 8dbf7370e7ea1caab0b769d0d4dcdd072d14d421 Mon Sep 17 00:00:00 2001
> From: Quan Xu
> Date: Wed, 29 Aug 2018 21:33:14 +0800
> Subject: [PATCH RFC] migration: make sure to run iterate precopy during the
> bulk stage
>
> Since the bulk stage assumes in (migration_bitmap_find_di
Common function measurement block is used to report counters of
successfully issued pcilg/stg/stb and rpcit instructions. This patch
introduces a new struct ZpciFmb and schedules a timer callback to
copy fmb to the guest memory at a interval time which is set to
4s by default. While attemping to up
> On 31-Aug-2018, at 4:41 PM, Andrew Jones wrote:
>
> External Email
>
> Manish,
>
> Your mail reader doesn't appear to be providing any quoting, so I'm not
> sure I found all your replies. I've tried to fix up the quoting in order
> to reply here, but you should look into fixing your reader.
Xiao Guangrong wrote:
> On 09/04/2018 12:38 AM, Juan Quintela wrote:
>> guangrong.x...@gmail.com wrote:
>>> From: Xiao Guangrong
>>>
>>> flush_compressed_data() needs to wait all compression threads to
>>> finish their work, after that all threads are free until the
>>> migration feeds new reques
On Tue, Sep 04, 2018 at 09:16:58AM +, Jaggi, Manish wrote:
> > On 31-Aug-2018, at 4:41 PM, Andrew Jones wrote:
> > I think the sequence should look something like this:
> >
> > 1) Guest running on Host A with processor a
> > 2) Stop guest and save its state for migration
> > 3) Migrate gue
Andrew Jones wrote:
> On Tue, Sep 04, 2018 at 09:16:58AM +, Jaggi, Manish wrote:
>> So which approach should be taken here, whats your take...
>>
[ Remoning Anthony form CC. Address don't exist anymore ]
> Inventing a base-AArch64 cpu model that can then be extended with optional
> feature
* Andrew Jones (drjo...@redhat.com) wrote:
> On Tue, Sep 04, 2018 at 09:16:58AM +, Jaggi, Manish wrote:
> > > On 31-Aug-2018, at 4:41 PM, Andrew Jones wrote:
> > > I think the sequence should look something like this:
> > >
> > > 1) Guest running on Host A with processor a
> > > 2) Stop gue
On 4 September 2018 at 08:02, Thomas Huth wrote:
> When cross-compiling QEMU for a target that significantly differs from
> the host, the current information in config.status is not enough to
> properly re-create the configuration. For example when I try to test
> my build with the mingw32 cross-c
Public bug reported:
OS: Fedora (64 bits) – Linux –. Last available component: qemu-
img.x86_64 2:2.11.2-2.fc28
Description: version of disk image format not exhibited using the 'qemu-
img info' command.
Command 'qemu-img info qcow2 [image-file-name.img]' produces this stderr
message:
qemu-img:
On Tue, Sep 04, 2018 at 09:02:18AM +0200, Thomas Huth wrote:
> When cross-compiling QEMU for a target that significantly differs from
> the host, the current information in config.status is not enough to
> properly re-create the configuration. For example when I try to test
> my build with the ming
On 2018-09-04 12:35, Peter Maydell wrote:
> On 4 September 2018 at 08:02, Thomas Huth wrote:
>> When cross-compiling QEMU for a target that significantly differs from
>> the host, the current information in config.status is not enough to
>> properly re-create the configuration. For example when I
On 2018-09-04 12:43, Daniel P. Berrangé wrote:
> On Tue, Sep 04, 2018 at 09:02:18AM +0200, Thomas Huth wrote:
>> When cross-compiling QEMU for a target that significantly differs from
>> the host, the current information in config.status is not enough to
>> properly re-create the configuration. For
There's no concept of versions for "raw" images as there's no metadata
at all - its just raw disk content.
For the qcow2 format, the version 2 vs version 3 distinction is not
something that is intended to be exposed externally. A version 3 format
file is still handled by the qcow2 format driver, a
Currently, when qemu_signal_init() fails it only returns a non-zero
value but without propagating any Error. But its callers need a
non-null err when runs error_report_err(err), or else 0->msg occurs.
To avoid such segmentation fault, add a new Error parameter to make
the call trace to propagate t
Add a new Error paramater for qemu_thread_create() to indicate if it
succeeds rather than failing with an error. And propagate the error
to let the callers check it.
Besides, directly return if thread->data is NULL to avoid the
segmentation fault in qemu_thread_join in qemu-thread-win32.c.
Signed
Hi,
This idea comes from BiteSizedTasks, and this patch series implement
the error checking of qemu_thread_create: make qemu_thread_create
return a flag to indicate if it succeeded rather than failing with an
error; make all callers check it.
The first three patches apply to those call traces who
The caller of qemu_init_vcpu() already passed the **errp to handle
errors. In view of this, add a new Error parameter to the following
call trace to propagate the error and let the final caller check it.
Signed-off-by: Fei Li
---
cpus.c | 32 +++--
Add a new Error parameter to vnc_display_init() and handle the Error
in its caller: vnc_init_func() just like vnc_display_open() does. And
let the call trace propagate the Error.
Signed-off-by: Fei Li
---
include/ui/console.h | 2 +-
ui/vnc-jobs.c| 2 +-
ui/vnc-jobs.h| 2 +-
u
Let's propagate qemu_thread_create's error to make all callers check
it. For those critical callers, just pass the &error_abort.
Signed-off-by: Fei Li
---
cpus.c | 48 ++---
dump.c | 6 +-
hw/misc/edu.c
On Tue, Sep 04, 2018 at 07:08:21PM +0800, Fei Li wrote:
> Add a new Error paramater for qemu_thread_create() to indicate if it
> succeeds rather than failing with an error. And propagate the error
> to let the callers check it.
>
> Besides, directly return if thread->data is NULL to avoid the
> se
On Tue, Sep 04, 2018 at 07:08:22PM +0800, Fei Li wrote:
> Let's propagate qemu_thread_create's error to make all callers check
> it. For those critical callers, just pass the &error_abort.
>
> Signed-off-by: Fei Li
> ---
> cpus.c | 48
> +
So many useful information that would be worth to be part of the
documentation associated to the above mentioned link.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1790617
Title:
Version of disk i
On Tue, Sep 04, 2018 at 07:08:20PM +0800, Fei Li wrote:
> The caller of qemu_init_vcpu() already passed the **errp to handle
> errors. In view of this, add a new Error parameter to the following
> call trace to propagate the error and let the final caller check it.
>
> Signed-off-by: Fei Li
> ---
On Tue, Sep 04, 2018 at 07:08:18PM +0800, Fei Li wrote:
> Currently, when qemu_signal_init() fails it only returns a non-zero
> value but without propagating any Error. But its callers need a
> non-null err when runs error_report_err(err), or else 0->msg occurs.
>
> To avoid such segmentation faul
Daniel P. Berrangé writes:
> On Tue, Sep 04, 2018 at 08:39:27AM +0200, Markus Armbruster wrote:
>> Daniel P. Berrangé writes:
>>
>> > On Mon, Sep 03, 2018 at 09:30:52AM -0500, Eric Blake wrote:
>> >> On 09/03/2018 08:31 AM, Markus Armbruster wrote:
>> >>
>> >> > Example:
>> >> >
>> >> >
On 4 September 2018 at 11:53, Thomas Huth wrote:
> But still, I think at least the PKG_CONFIG_LIBDIR part could be useful,
> since the same problem e.g. also occurs when trying do a 32-bit build on
> a 64-bit host, i.e. when running configure with "--extra-cflags=-m32".
> Or is there also another
On 4 September 2018 at 11:32, Dr. David Alan Gilbert
wrote:
> * Andrew Jones (drjo...@redhat.com) wrote:
>> Simply, users that migrate '-cpu host' VMs need to know what they're
>> doing.
>
> The problem here is that in the x86 world we've said:
> 'don't use -cpu host
>if you're using it be
This modification also fixes issue:
https://git.greensocs.com/qemu/qbox/commit/a8ed106032e375e715a531d6e93e4d9ec295dbdb
Although I tested it only on v2.12.0 and didn't noticed performance improvement.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subsc
The config.status script is auto-generated by configure upon
completion. The intention is that config.status can be later invoked by
the developer directly, or by make indirectly, to re-detect the same
environment that configure originally used.
The current config.status script, however, only cont
if MemoryRegion intialization fails it's left in semi-initialized state,
where it's size is not 0 and attached as child to owner object.
And this leds to crash in following use-case:
(monitor) object_add
memory-backend-file,id=mem1,size=9G,mem-path=/tmp/foo,discard-data=yes
memory.c:20
on 2018/9/4 17:12, Juan Quintela wrote:
Quan Xu wrote:
From 8dbf7370e7ea1caab0b769d0d4dcdd072d14d421 Mon Sep 17 00:00:00 2001
From: Quan Xu
Date: Wed, 29 Aug 2018 21:33:14 +0800
Subject: [PATCH RFC] migration: make sure to run iterate precopy during the
bulk stage
Since the bulk stage assu
Set the newly added register(KVM_REG_PPC_ONLINE) to indicate if the vcpu is
online(1) or offline(0)
KVM will use this information to set the RWMR register, which controls the PURR
and SPURR accumulation.
CC: pau...@samba.org
Signed-off-by: Nikunj A Dadhania
---
hw/ppc/spapr_cpu_core.c | 1 +
hw
Set the newly added register(KVM_REG_PPC_ONLINE) to indicate if the vcpu is
online(1) or offline(0)
KVM will use this information to set the RWMR register, which controls the PURR
and SPURR accumulation.
CC: pau...@samba.org
Signed-off-by: Nikunj A Dadhania
---
hw/ppc/spapr_cpu_core.c | 1 +
hw
David Gibson writes:
> On Tue, Sep 04, 2018 at 11:00:39AM +0530, Nikunj A Dadhania wrote:
>> Set the newly added register(KVM_REG_PPC_ONLINE) to indicate if the vcpu is
>> online(1) or offline(0)
>>
>> KVM will use this information to set the RWMR register, which controls the
>> PURR
>> and SPU
Hi Peter
I moved the code to the repository
https://github.com/denis-plotnikov/qemu/tree/background-snapshot-kvm.
the current version includes fixes with respect to your comments for
version 1.
I moved KVM related patches to the end of the branch (formerly patch
series).
Since, the KVM patches
On Mon 03 Sep 2018 05:03:11 PM CEST, Kevin Wolf wrote:
>> libvirt-3-format is read-write and all other node names are readonly in
>> the above example.
>>
>> The same also happens when using filenames:
>>
>> {"execute":"block-commit",
>> "arguments" : {"device":"libvirt-3-format",
>>
commit
(5cdc9b76e3 vl.c: Remove dead assignment)
removed sockets calculation when 'sockets' weren't provided on CLI
since there wasn't any users for it back then. Exiting checks
are neither reachable
} else if (sockets * cores * threads < cpus) {
or nor triggable
if (sockets * cores * threa
Changelog since v4:
* extend deprication doc, adding that maxcpus should be multiple of
present on CLI [sockets/cores/threads] options
(Eduardo Habkost )
series bundles together 2 related patches posted separately earlier:
vl.c deprecate incorrect CPUs topology
vl:c: make s
-smp [cpus],sockets/cores/threads[,maxcpus] should describe topology
so that total number of logical CPUs [sockets * cores * threads]
would be equal to [maxcpus], however historically we didn't have
such check in QEMU and it is possible to start VM with an invalid
topology.
Deprecate invalid option
on 2018/9/4 17:09, Dr. David Alan Gilbert wrote:
* Quan Xu (quan@gmail.com) wrote:
From 8dbf7370e7ea1caab0b769d0d4dcdd072d14d421 Mon Sep 17 00:00:00 2001
From: Quan Xu
Date: Wed, 29 Aug 2018 21:33:14 +0800
Subject: [PATCH RFC] migration: make sure to run iterate precopy during the
bulk s
On 8/29/18 4:07 PM, Eduardo Habkost wrote:
Hi,
Thanks for the patch.
On Tue, Aug 28, 2018 at 10:24:26AM +0300, Yoni Bettan wrote:
- this is a simple example of how to write a pci device that supports
portio, mmio, irq and dma
Can we have some documentation on what are the goals
On Wed 29 Aug 2018 11:44:52 AM CEST, Max Reitz wrote:
> On 2018-08-28 15:26, Alberto Garcia wrote:
>> On Thu 09 Aug 2018 11:35:02 PM CEST, Max Reitz wrote:
>>> +backing_overridden = bdrv_backing_overridden(bs);
>>> +
>>> +if (bs->open_flags & BDRV_O_NO_IO) {
>>> +/* Without I/O, the
On Tue, Sep 04, 2018 at 15:13:44 +0200, Alberto Garcia wrote:
> On Mon 03 Sep 2018 05:03:11 PM CEST, Kevin Wolf wrote:
> >> libvirt-3-format is read-write and all other node names are readonly in
> >> the above example.
> >>
> >> The same also happens when using filenames:
> >>
> >> {"execute":"b
On Mon, Sep 03, 2018 at 17:03:11 +0200, Kevin Wolf wrote:
> Am 28.08.2018 um 16:26 hat Peter Krempa geschrieben:
> > On Fri, Aug 10, 2018 at 18:26:57 +0200, Kevin Wolf wrote:
> > > The block-commit QMP command required specifying the top and base nodes
> > > of the commit jobs using the file name o
On Tue 04 Sep 2018 04:17:30 PM CEST, Peter Krempa wrote:
>> >> libvirt-3-format is read-write and all other node names are
>> >> readonly in the above example.
>> >>
>> >> The same also happens when using filenames:
>> >>
>> >> {"execute":"block-commit",
>> >> "arguments" : {"device":"libvirt-3-
To clarify the OPC_MUL here is not an MXU instruction, this is the original
OPC_MUL that was in the special2 instruction set. The inclusion of this
instruction in this switch statement is due to the suggested method of
splitting up the mxu commands instruction handling switch statement from the
Am 24.08.2018 um 09:22 hat Fam Zheng geschrieben:
> On Fri, 08/17 19:02, Kevin Wolf wrote:
> > Simimlar to AIO_WAIT_WHILE(), job_finish_sync() needs to release the
> > AioContext lock of the job before calling aio_poll(). Otherwise,
> > callbacks called by aio_poll() would possibly take the lock a
Am 24.08.2018 um 09:24 hat Fam Zheng geschrieben:
> On Fri, 08/17 19:02, Kevin Wolf wrote:
> > Simimlar to AIO_WAIT_WHILE(), bdrv_drain_poll_top_level() needs to
> > release the AioContext lock of the node to be drained before calling
> > aio_poll(). Otherwise, callbacks called by aio_poll() would
It is possible but due to the non-uniform nature of the bit fields which
indicate the instructions the mask used might end up being instruction
specific. This would lead to a tiered approach where the current enum would be
the top level, then each group under there might have its own enum, mask
On Tue, Sep 04, 2018 at 16:42:17 +0200, Alberto Garcia wrote:
> On Tue 04 Sep 2018 04:17:30 PM CEST, Peter Krempa wrote:
> >> >> libvirt-3-format is read-write and all other node names are
> >> >> readonly in the above example.
> >> >>
> >> >> The same also happens when using filenames:
> >> >>
>
Hi Pankaj,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linux-nvdimm/libnvdimm-for-next]
[also build test ERROR on v4.19-rc2 next-20180903]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.
On Tue, Sep 04, 2018 at 03:22:35PM +0200, Igor Mammedov wrote:
> -smp [cpus],sockets/cores/threads[,maxcpus] should describe topology
> so that total number of logical CPUs [sockets * cores * threads]
> would be equal to [maxcpus], however historically we didn't have
> such check in QEMU and it is
On Tue, Sep 04, 2018 at 03:22:36PM +0200, Igor Mammedov wrote:
> commit
> (5cdc9b76e3 vl.c: Remove dead assignment)
> removed sockets calculation when 'sockets' weren't provided on CLI
> since there wasn't any users for it back then. Exiting checks
> are neither reachable
>} else if (sockets
Hi Pankaj,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linux-nvdimm/libnvdimm-for-next]
[also build test WARNING on v4.19-rc2 next-20180831]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https:/
Am 04.09.2018 um 17:00 hat Peter Krempa geschrieben:
> On Tue, Sep 04, 2018 at 16:42:17 +0200, Alberto Garcia wrote:
> > On Tue 04 Sep 2018 04:17:30 PM CEST, Peter Krempa wrote:
> > >> >> libvirt-3-format is read-write and all other node names are
> > >> >> readonly in the above example.
> > >> >>
-smp [cpus],sockets/cores/threads[,maxcpus] should describe topology
so that total number of logical CPUs [sockets * cores * threads]
would be equal to [maxcpus], however historically we didn't have
such check in QEMU and it is possible to start VM with an invalid
topology.
Deprecate invalid option
On 09/03/2018 06:08 AM, Andrew Jones wrote:
> On Sat, Sep 01, 2018 at 01:11:12AM -0400, Wei Huang wrote:
>> The x86 boot block header currently is generated with a shell script.
>> To better support other CPUs (e.g. aarch64), we convert the script
>> into Makefile. This allows us to 1) support c
On 09/03/2018 10:11 AM, Markus Armbruster wrote:
> Kevin Wolf writes:
>
>> Am 01.09.2018 um 09:54 hat Markus Armbruster geschrieben:
>>> John Snow writes:
>>>
On 08/31/2018 02:08 AM, Markus Armbruster wrote:
> Eric Blake writes:
>
>> On 08/29/2018 08:57 PM, John Snow wrote:
On 09/03/2018 05:32 AM, Max Reitz wrote:
> On 2018-09-01 00:28, John Snow wrote:
>> For purposes of minimum code movement, refactor the mirror_exit
>> callback to use the post-finalization callbacks in a trivial way.
>>
>> Signed-off-by: John Snow
>> ---
>> block/mirror.c | 31
On 09/04/2018 07:36 AM, Daniel P. Berrangé wrote:
The config.status script is auto-generated by configure upon
completion. The intention is that config.status can be later invoked by
the developer directly, or by make indirectly, to re-detect the same
environment that configure originally used.
Add support for taking and passing forward job creation flags.
Signed-off-by: John Snow
Reviewed-by: Max Reitz
Reviewed-by: Jeff Cody
---
block/commit.c| 5 +++--
blockdev.c| 7 ---
include/block/block_int.h | 5 -
3 files changed, 11 insertions(+), 6 deleti
Use the component callbacks; prepare, abort, and clean.
NB: prepare is only called when the job has not yet failed;
and abort can be called after prepare.
complete -> prepare -> abort -> clean
complete -> abort -> clean
Signed-off-by: John Snow
Reviewed-by: Max Reitz
---
block/commit.c | 90 +
Add support for taking and passing forward job creation flags.
Signed-off-by: John Snow
Reviewed-by: Max Reitz
Reviewed-by: Jeff Cody
---
block/stream.c| 5 +++--
blockdev.c| 3 ++-
include/block/block_int.h | 5 -
3 files changed, 9 insertions(+), 4 deletions(-
Signed-off-by: John Snow
Reviewed-by: Max Reitz
---
block/stream.c | 23 +++
1 file changed, 15 insertions(+), 8 deletions(-)
diff --git a/block/stream.c b/block/stream.c
index 700eb239e4..81a7ec8ece 100644
--- a/block/stream.c
+++ b/block/stream.c
@@ -54,16 +54,16 @@ static
Add support for taking and passing forward job creation flags.
Signed-off-by: John Snow
Reviewed-by: Max Reitz
Reviewed-by: Jeff Cody
---
block/mirror.c| 5 +++--
blockdev.c| 3 ++-
include/block/block_int.h | 5 -
3 files changed, 9 insertions(+), 4 deletions(-
In cases where we abort the block/mirror job, there's no point in
installing the new backing chain before we finish aborting.
Move this to the "success" portion of mirror_exit.
Signed-off-by: John Snow
---
block/mirror.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a
For purposes of minimum code movement, refactor the mirror_exit
callback to use the post-finalization callbacks in a trivial way.
Signed-off-by: John Snow
---
block/mirror.c | 34 +++---
1 file changed, 27 insertions(+), 7 deletions(-)
diff --git a/block/mirror.c b/b
This is part two of a two part series that refactors the exit logic
of jobs.
This series forces all jobs to use the "finalize" semantics that were
introduced previously, but only exposed via the backup jobs.
Patches 1-3 add plumbing for the auto-dismiss and auto-finalize flags
but do not expose t
Signed-off-by: John Snow
Reviewed-by: Max Reitz
---
blockdev.c | 14 ++
qapi/block-core.json | 30 --
2 files changed, 42 insertions(+), 2 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 98b91e75a7..429cdf9901 100644
--- a/blockdev.c
+++
We remove the exit callback and the completed boolean along with it.
We can simulate it just fine by waiting for the job to defer to the
main loop, and then giving it one final kick to get the main loop
portion to run.
Signed-off-by: John Snow
Reviewed-by: Max Reitz
---
tests/test-blockjob.c |
Signed-off-by: John Snow
Reviewed-by: Max Reitz
---
blockdev.c | 8
qapi/block-core.json | 16 +++-
2 files changed, 23 insertions(+), 1 deletion(-)
diff --git a/blockdev.c b/blockdev.c
index ec90eb1cf9..98b91e75a7 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -320
The exit callback in this test actually only performs cleanup.
Signed-off-by: John Snow
---
tests/test-blockjob-txn.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/test-blockjob-txn.c b/tests/test-blockjob-txn.c
index ef29f35e44..86606f92b3 100644
--- a/tests/test
Signed-off-by: John Snow
Reviewed-by: Max Reitz
---
blockdev.c | 9 +
hmp.c| 5 +++--
qapi/block-core.json | 16 +++-
3 files changed, 27 insertions(+), 3 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 429cdf9901..0cf8febe6c 100644
--- a/
Fix documentation to match the other jobs amended for 3.1.
Signed-off-by: John Snow
Reviewed-by: Max Reitz
---
qapi/block-core.json | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index f877e9e414..c0b3d33dbb 10
These tests don't actually test blockjobs anymore, they test
generic Job lifetimes. Change the types accordingly.
Signed-off-by: John Snow
Reviewed-by: Max Reitz
---
tests/test-blockjob.c | 98 ++-
1 file changed, 50 insertions(+), 48 deletions(-)
Now that all of the jobs use the component finalization callbacks,
there's no use for the heavy-hammer .exit callback anymore.
job_exit becomes a glorified type shim so that we can call
job_completed from aio_bh_schedule_oneshot.
Move these three functions down into job.c to eliminate a
forward r
Hi, Emilio.
On Mon, Sep 03, 2018 at 01:18:27PM -0400, Emilio G. Cota wrote:
> Signed-off-by: Emilio G. Cota
> ---
> tests/test-rcu-list.c | 67 +--
> 1 file changed, 59 insertions(+), 8 deletions(-)
>
> diff --git a/tests/test-rcu-list.c b/tests/test-rcu-l
- Original Message -
> From: "Andrew Jones"
> To: "Wei Huang"
> Cc: qemu-devel@nongnu.org, lviv...@redhat.com, "peter maydell"
> , quint...@redhat.com,
> dgilb...@redhat.com
> Sent: Monday, September 3, 2018 6:53:35 AM
> Subject: Re: [Qemu-devel] [PATCH V8 4/4] tests: Add migration te
- Original Message -
> From: "Andrew Jones"
> To: "Wei Huang"
> Cc: qemu-devel@nongnu.org, lviv...@redhat.com, "peter maydell"
> , quint...@redhat.com,
> dgilb...@redhat.com
> Sent: Monday, September 3, 2018 6:26:39 AM
> Subject: Re: [Qemu-devel] [PATCH V8 2/4] tests/migration: Suppor
On Tue, Sep 04, 2018 at 01:07:56PM -0400, Wei Huang wrote:
>
>
> - Original Message -
> > From: "Andrew Jones"
> > To: "Wei Huang"
> > Cc: qemu-devel@nongnu.org, lviv...@redhat.com, "peter maydell"
> > , quint...@redhat.com,
> > dgilb...@redhat.com
> > Sent: Monday, September 3, 2018 6
On Tue, Sep 04, 2018 at 01:04:31PM -0400, Wei Huang wrote:
> > > +parse-cross-prefix = $(subst gcc,,$(patsubst cc,gcc,$(patsubst
> > > CROSS_CC_GUEST="%",%,$(shell grep "CROSS_CC_GUEST="
> > > $(SRC_PATH)/$(1)-softmmu/config-target.mak
> > > +gen-cross-prefix = $(patsubst %-,CROSS_PREFIX=%-,$(c
On 2018-09-04 14:36, Daniel P. Berrangé wrote:
> The config.status script is auto-generated by configure upon
> completion. The intention is that config.status can be later invoked by
> the developer directly, or by make indirectly, to re-detect the same
> environment that configure originally used
On Tue, Sep 04, 2018 at 01:09:19PM -0400, John Snow wrote:
> Use the component callbacks; prepare, abort, and clean.
>
> NB: prepare is only called when the job has not yet failed;
> and abort can be called after prepare.
>
> complete -> prepare -> abort -> clean
> complete -> abort -> clean
>
>
On 09/03/2018 05:24 AM, Max Reitz wrote:
> On 2018-09-01 00:28, John Snow wrote:
>> In cases where we abort the block/mirror job, there's no point in
>> installing the new backing chain before we finish aborting.
>>
>> Move this to the "success" portion of mirror_exit.
>>
>> Signed-off-by: John
On 09/04/2018 02:15 PM, John Snow wrote:
post-script: I really, really hate the "fake cancel" we've implemented
for mirror. It makes the job logic so much worse.
Mirror really does have a tri-state way to end the job (and accessible
only after the job has moved into the sync state):
cancel
On Tue, Sep 04, 2018 at 14:37:34 -0300, Murilo Opsfelder Araujo wrote:
> Hi, Emilio.
>
> On Mon, Sep 03, 2018 at 01:18:27PM -0400, Emilio G. Cota wrote:
> > Signed-off-by: Emilio G. Cota
> > ---
> > tests/test-rcu-list.c | 67 +--
> > 1 file changed, 59 in
On 09/02/2018 12:53 PM, Yoni Bettan wrote:
This patch make INFO files (e.g. README, CODING_STYLE and HACKING) much more
readable when watched from GitHub GUI.
./VERSION, ./MAINTAINERS were leave untouched otherwise
./scripts/get_maintainer.pl breaks.
./COPYING, ./LICENSE ./COPYING.LIB were leav
OpenBIOS gained 40p support in 5b20e4cacecb62fb2bdc6867c11d44cddd77c4ff
Use it, instead of relying on an unmaintained and very limited firmware.
Signed-off-by: Hervé Poussineau
---
hw/ppc/prep.c| 2 +-
tests/boot-serial-test.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-
On 09/04/2018 03:30 PM, Eric Blake wrote:
> On 09/04/2018 02:15 PM, John Snow wrote:
>
>>
>> post-script: I really, really hate the "fake cancel" we've implemented
>> for mirror. It makes the job logic so much worse.
>
> Mirror really does have a tri-state way to end the job (and accessible
>
On 08/30/2018 09:27 AM, Sameeh Jubran wrote:
From: Sameeh Jubran
Signed-off-by: Sameeh Jubran
---
hw/net/rss_bpf_insns.h | 3992 ++
hw/net/rss_tap_bpf.h | 40 +
hw/net/rss_tap_bpf_program.c | 175 ++
hw/net/virtio-net.c |
On Fri, Aug 31, 2018 at 3:22 PM, Emilio G. Cota wrote:
> On Fri, Aug 10, 2018 at 13:39:38 -0400, Emilio G. Cota wrote:
>> Changes wrt v1: changed patch 3 as suggested by Richard. Also
>> added his R-b's.
>>
>> You can fetch this series from:
>> https://github.com/cota/qemu/tree/riscv-lookup_ptr-
Le 31/08/2018 à 16:16, Mark Cave-Ayland a écrit :
On 20/08/18 04:16, David Gibson wrote:
On Fri, Aug 10, 2018 at 04:41:54PM +1000, David Gibson wrote:
On Fri, Aug 10, 2018 at 07:37:12AM +0200, Hervé Poussineau wrote:
OpenBIOS gained 40p support in 5b20e4cacecb62fb2bdc6867c11d44cddd77c4ff
Use
1 - 100 of 167 matches
Mail list logo
