Re: [Qemu-devel] [PATCH] pc: make sure that guest isn't able to unplug the first cpu

2018-08-29 Thread David Gibson
On Tue, Aug 28, 2018 at 03:18:48PM +0200, Igor Mammedov wrote: > On Tue, 28 Aug 2018 10:52:37 +1000 > David Gibson wrote: > > > On Mon, Aug 27, 2018 at 04:02:39PM +0200, Greg Kurz wrote: > > > On Mon, 27 Aug 2018 13:07:10 +0200 > > > Igor Mammedov wrote: > > > > > > > The first cpu unplug was

Re: [Qemu-devel] [PATCH v4 21/29] util: use fcntl() for qemu_write_pidfile() locking

2018-08-29 Thread Daniel P . Berrangé
On Wed, Aug 29, 2018 at 01:41:14AM +0200, Marc-André Lureau wrote: > Hi > > On Tue, Aug 28, 2018 at 6:01 PM Daniel P. Berrangé > wrote: > > > > On Fri, Jul 13, 2018 at 03:09:08PM +0200, Marc-André Lureau wrote: > > > According to Daniel Berrange, fcntl() locks have better portable > > > semantic

Re: [Qemu-devel] [PATCH 3/7] jobs: add exit shim

2018-08-29 Thread Max Reitz
On 2018-08-27 17:54, John Snow wrote: > > > On 08/25/2018 09:05 AM, Max Reitz wrote: >> On 2018-08-22 23:52, John Snow wrote: >>> >>> >>> On 08/22/2018 07:43 AM, Max Reitz wrote: On 2018-08-17 21:04, John Snow wrote: > All jobs do the same thing when they leave their running loop: >

Re: [Qemu-devel] [PATCH 5/7] block/mirror: utilize job_exit shim

2018-08-29 Thread Max Reitz
On 2018-08-28 22:25, John Snow wrote: > > > On 08/25/2018 11:02 AM, Max Reitz wrote: >> If you say so... I have to admit I don't really understand. The >> comment doesn't explain why it's so important to keep src around until >> job_completed(), so I don't know. I thought AioContexts are recur

Re: [Qemu-devel] [PATCH v3 4/9] monitor: no need to save need_resume

2018-08-29 Thread Markus Armbruster
Peter Xu writes: > On Tue, Aug 28, 2018 at 05:46:29PM +0200, Markus Armbruster wrote: >> Peter Xu writes: >> >> > On Sat, Aug 25, 2018 at 03:57:19PM +0200, Marc-André Lureau wrote: >> >> There is no need for per-command need_resume granularity, it should >> >> resume after running an non-oob co

Re: [Qemu-devel] [PATCH] hostmem-memfd: honour share=on/off property

2018-08-29 Thread Igor Mammedov
On Tue, 28 Aug 2018 18:55:35 +0200 Marc-André Lureau wrote: > On Tue, Aug 28, 2018 at 6:54 PM Marc-André Lureau > wrote: > > > > Hi > > > > On Tue, Aug 28, 2018 at 6:49 PM Igor Mammedov wrote: > > > > > > On Tue, 28 Aug 2018 17:38:40 +0200 > > > Marc-André Lureau wrote: > > > > > > > The s

Re: [Qemu-devel] [PATCH] pc: make sure that guest isn't able to unplug the first cpu

2018-08-29 Thread Igor Mammedov
On Wed, 29 Aug 2018 12:54:40 +1000 David Gibson wrote: > On Tue, Aug 28, 2018 at 03:18:48PM +0200, Igor Mammedov wrote: > > On Tue, 28 Aug 2018 10:52:37 +1000 > > David Gibson wrote: > > > > > On Mon, Aug 27, 2018 at 04:02:39PM +0200, Greg Kurz wrote: > > > > On Mon, 27 Aug 2018 13:07:10 +0

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-08-29 Thread Hongbo Zhang
On 17 August 2018 at 21:37, Peter Maydell wrote: > On 25 July 2018 at 06:30, Hongbo Zhang wrote: >> For the Aarch64, there is one machine 'virt', it is primarily meant to >> run on KVM and execute virtualization workloads, but we need an >> environment as faithful as possible to physical hardware

Re: [Qemu-devel] [PATCH v4 29/29] hw/display: add vhost-user-vga & gpu-pci

2018-08-29 Thread Daniel P . Berrangé
On Fri, Jul 13, 2018 at 03:09:16PM +0200, Marc-André Lureau wrote: > Add new virtio-gpu devices with a "vhost-user" property. Tthe > associated vhost-user backend is used to handle the virtio rings and > provide rendering results thanks to the vhost-user-gpu protocol. > > Example usage: > -object

[Qemu-devel] [PATCH v3] linux-user: elf: mmap all the target-pages of hostpage for data segment

2018-08-29 Thread Shivaprasad G Bhat
If the hostpage size is greater than the TARGET_PAGESIZE, the target-pages of size TARGET_PAGESIZE are marked valid only till the length requested during the elfload. The glibc attempts to consume unused space in the last page of data segment(__libc_memalign() in elf/dl-minimal.c). If PT_LOAD p_ali

Re: [Qemu-devel] [PATCH v3] linux-user: elf: mmap all the target-pages of hostpage for data segment

2018-08-29 Thread Laurent Vivier
Le 29/08/2018 à 11:23, Shivaprasad G Bhat a écrit : > If the hostpage size is greater than the TARGET_PAGESIZE, the > target-pages of size TARGET_PAGESIZE are marked valid only till the > length requested during the elfload. The glibc attempts to consume unused > space in the last page of data segm

Re: [Qemu-devel] [PATCH v4 00/29] vhost-user for input & GPU

2018-08-29 Thread Daniel P . Berrangé
On Fri, Jul 13, 2018 at 03:08:47PM +0200, Marc-André Lureau wrote: > Hi, > > vhost-user allows to drive a virtio device in a seperate > process. After vhost-user-net, we have seen > vhost-user-{scsi,blk,crypto} added more recently. > > This series, initially proposed 2 years ago > (https://lists.

[Qemu-devel] [PULL 16/19] hw/s390x: Move virtio-ccw-input code to a separate file

2018-08-29 Thread Cornelia Huck
From: Thomas Huth The code should only be enabled if CONFIG_VIRTIO_INPUT has been set. This can be done best if the code resides in a separate file. Signed-off-by: Thomas Huth Message-Id: <1532521224-27235-11-git-send-email-th...@redhat.com> Signed-off-by: Cornelia Huck --- hw/s390x/Makefile.

Re: [Qemu-devel] [PATCH for-3.1 v10 05/31] block: Respect backing bs in bdrv_refresh_filename

2018-08-29 Thread Max Reitz
On 2018-08-28 15:26, Alberto Garcia wrote: > On Thu 09 Aug 2018 11:35:02 PM CEST, Max Reitz wrote: >> +backing_overridden = bdrv_backing_overridden(bs); >> + >> +if (bs->open_flags & BDRV_O_NO_IO) { >> +/* Without I/O, the backing file does not change anything. >> + * Theref

[Qemu-devel] [PULL 18/19] hw/s390x: Move virtio-ccw-blk code to a separate file

2018-08-29 Thread Cornelia Huck
From: Thomas Huth The code should only be enabled if CONFIG_VIRTIO_BLK has been set. This can be done best if the code resides in a separate file. Signed-off-by: Thomas Huth Message-Id: <1532542110-9017-1-git-send-email-th...@redhat.com> Signed-off-by: Cornelia Huck --- hw/s390x/Makefile.objs

[Qemu-devel] [PULL 17/19] hw/s390x: Move virtio-ccw-net code to a separate file

2018-08-29 Thread Cornelia Huck
From: Thomas Huth The code should only be enabled if CONFIG_VIRTIO_NET has been set. This can be done best if the code resides in a separate file. Signed-off-by: Thomas Huth Message-Id: <1532542056-8927-1-git-send-email-th...@redhat.com> Signed-off-by: Cornelia Huck --- hw/s390x/Makefile.objs

Re: [Qemu-devel] [PATCH for-3.1 v10 29/31] block/null: Generate filename even with latency-ns

2018-08-29 Thread Max Reitz
On 2018-08-28 15:33, Alberto Garcia wrote: > On Thu 09 Aug 2018 11:35:26 PM CEST, Max Reitz wrote: >> While we cannot represent the latency-ns option in a filename, it is not >> a strong option so not being able to should not stop us from generating >> a filename nonetheless. >> >> Signed-off-by: M

[Qemu-devel] [PULL 13/19] hw/s390x: Move virtio-ccw-crypto code to a separate file

2018-08-29 Thread Cornelia Huck
From: Thomas Huth The code should only be enabled if CONFIG_VIRTIO_CRYPTO has been set. This can be done best if the code resides in a separate file. Signed-off-by: Thomas Huth Message-Id: <1532521224-27235-8-git-send-email-th...@redhat.com> Signed-off-by: Cornelia Huck --- hw/s390x/Makefile.

[Qemu-devel] [PULL 08/19] hw/s390x: Move virtio-ccw-serial code to a separate file

2018-08-29 Thread Cornelia Huck
From: Thomas Huth The code should only be enabled if CONFIG_VIRTIO_SERIAL has been set. This can be done best if the code resides in a separate file. Signed-off-by: Thomas Huth Message-Id: <1532521224-27235-3-git-send-email-th...@redhat.com> Signed-off-by: Cornelia Huck --- MAINTAINERS

[Qemu-devel] [PULL 19/19] target/s390x: use regular spaces in translate.c

2018-08-29 Thread Cornelia Huck
From: Pavel Zbitskiy In a few places translate.c contains non-breaking spaces (0xc2 0xa0) instead of regular ones (0x20): 7c 7c c2 a0 63 63 7c 7c 2063 63 | |c c This confuses some text editors. Signed-off-by: Pavel Zbitskiy Message-Id: <20180822144039.5796-2-pavel.zbits...

[Qemu-devel] [PULL 10/19] hw/s390x: Move virtio-ccw-scsi code to a separate file

2018-08-29 Thread Cornelia Huck
From: Thomas Huth The code should only be enabled if CONFIG_VIRTIO_SCSI has been set. This can be done best if the code resides in a separate file. Signed-off-by: Thomas Huth Message-Id: <1532521224-27235-5-git-send-email-th...@redhat.com> Signed-off-by: Cornelia Huck --- hw/s390x/Makefile.ob

Re: [Qemu-devel] [PATCH for-3.1 v10 07/31] iotests.py: Add node_info()

2018-08-29 Thread Max Reitz
On 2018-08-28 14:48, Alberto Garcia wrote: > On Thu 09 Aug 2018 11:35:04 PM CEST, Max Reitz wrote: >> This function queries a node; since we cannot do that right now, it >> executes query-named-block-nodes and returns the matching node's object. >> >> Signed-off-by: Max Reitz >> --- >> tests/qemu

[Qemu-devel] [PULL 14/19] hw/s390x: Move vhost-vsock-ccw code to a separate file

2018-08-29 Thread Cornelia Huck
From: Thomas Huth The code should only be enabled if CONFIG_VHOST_VSOCK has been set. This can be done best if the code resides in a separate file. Signed-off-by: Thomas Huth Message-Id: <1532521224-27235-9-git-send-email-th...@redhat.com> [CH: updated MAINTAINERS] Signed-off-by: Cornelia Huck

[Qemu-devel] [PULL 06/19] target/s390x: fix PACK reading 1 byte less and writing 1 byte more

2018-08-29 Thread Cornelia Huck
From: Pavel Zbitskiy PACK fails on the test from the Principles of Operation: F1F2F3F4 becomes 234C instead of 0001234C due to an off-by-one error. Furthermore, it overwrites one extra byte to the left of F1. If len_dest is 0, then we only want to flip the 1st byte and never loop over the re

[Qemu-devel] [PULL 15/19] hw/s390x: Move virtio-ccw-gpu code to a separate file

2018-08-29 Thread Cornelia Huck
From: Thomas Huth The code should only be enabled if CONFIG_VIRTIO_GPU has been set. This can be done best if the code resides in a separate file. Signed-off-by: Thomas Huth Message-Id: <1532521224-27235-10-git-send-email-th...@redhat.com> Signed-off-by: Cornelia Huck --- hw/s390x/Makefile.ob

[Qemu-devel] [PULL 12/19] hw/s390x: Move virtio-ccw-9p code to a separate file

2018-08-29 Thread Cornelia Huck
From: Thomas Huth The code should only be enabled if CONFIG_VIRTIO_9P and CONFIG_VIRTFS have been set. This can be done best if the code resides in a separate file. Signed-off-by: Thomas Huth Message-Id: <1532521224-27235-7-git-send-email-th...@redhat.com> Signed-off-by: Cornelia Huck --- hw/

[Qemu-devel] [PULL 04/19] target/s390x: fix IPM polluting irrelevant bits

2018-08-29 Thread Cornelia Huck
From: Pavel Zbitskiy Suppose psw.mask=0x8000, cc=2, r1=0 and we do "ipm 1". This command must touch only bits 32-39, so the expected output is r1=0x2000. However, currently qemu yields r1=0x20008000, because irrelevant parts of PSW leak into r1 during program mask transfer. Signe

[Qemu-devel] [PULL 11/19] hw/s390x: Move virtio-ccw-rng code to a separate file

2018-08-29 Thread Cornelia Huck
From: Thomas Huth The code should only be enabled if CONFIG_VIRTIO_RNG has been set. This can be done best if the code resides in a separate file. Signed-off-by: Thomas Huth Message-Id: <1532521224-27235-6-git-send-email-th...@redhat.com> Signed-off-by: Cornelia Huck --- hw/s390x/Makefile.obj

[Qemu-devel] [PULL 01/19] tests/tcg: add a simple s390x test

2018-08-29 Thread Cornelia Huck
From: Pavel Zbitskiy Copied from alpha. Signed-off-by: Pavel Zbitskiy Message-Id: <20180821025104.19604-2-pavel.zbits...@gmail.com> Reviewed-by: Thomas Huth Reviewed-by: David Hildenbrand Signed-off-by: Cornelia Huck --- MAINTAINERS | 1 + tests/tcg/s390x/Makefile.target

[Qemu-devel] [PULL 09/19] hw/s390x: Move virtio-ccw-balloon code to a separate file

2018-08-29 Thread Cornelia Huck
From: Thomas Huth The code should only be enabled if CONFIG_VIRTIO_BALLOON has been set. This can be done best if the code resides in a separate file. Signed-off-by: Thomas Huth Message-Id: <1532521224-27235-4-git-send-email-th...@redhat.com> Signed-off-by: Cornelia Huck --- hw/s390x/Makefile

[Qemu-devel] [PULL 03/19] target/s390x: fix CSST decoding and runtime alignment check

2018-08-29 Thread Cornelia Huck
From: Pavel Zbitskiy CSST is defined as: C(0xc802, CSST,SSF, CASS, la1, a2, 0, 0, csst, 0) It means that the first parameter is handled by in1_la1(). in1_la1() fills addr1 field, and not in1. Furthermore, when extract32() is used for the alignment check, the third parameter should sp

[Qemu-devel] [PULL 07/19] hw/s390x/virtio-ccw: Consolidate calls to virtio_ccw_unrealize()

2018-08-29 Thread Cornelia Huck
From: Thomas Huth Currently, every virtio-ccw device explicitely sets its unrealize function to virtio_ccw_unrealize() in its class_init function. We can simplify this by using a common unrealize function, just like it is already done for the realize functions. Signed-off-by: Thomas Huth Messag

[Qemu-devel] [PULL 00/19] next batch of s390x changes

2018-08-29 Thread Cornelia Huck
The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452: Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2' into staging (2018-08-27 16:44:20 +0100) are available in the Git repository at: git://github.com/cohuck/qemu tags/s390x-201

[Qemu-devel] [PULL 05/19] target/s390x: add EX support for TRT and TRTR

2018-08-29 Thread Cornelia Huck
From: Pavel Zbitskiy Improves "b213c9f5: target/s390x: Implement TRTR" by introducing the intermediate functions, which are compatible with dx_helper type. Signed-off-by: Pavel Zbitskiy Message-Id: <20180821025104.19604-6-pavel.zbits...@gmail.com> Reviewed-by: David Hildenbrand Signed-off-by:

[Qemu-devel] [PULL 02/19] target/s390x: add BAL and BALR instructions

2018-08-29 Thread Cornelia Huck
From: Pavel Zbitskiy These instructions are provided for compatibility purposes and are used only by old software, in the new code BAS and BASR are preferred. The difference between the old and new instruction exists only in the 24-bit mode. In addition, fix BAS polluting high 32 bits of the fir

Re: [Qemu-devel] [PATCH v3 4/9] monitor: no need to save need_resume

2018-08-29 Thread Peter Xu
On Wed, Aug 29, 2018 at 10:55:51AM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > On Tue, Aug 28, 2018 at 05:46:29PM +0200, Markus Armbruster wrote: > >> Peter Xu writes: > >> > >> > On Sat, Aug 25, 2018 at 03:57:19PM +0200, Marc-André Lureau wrote: > >> >> There is no need for per-co

Re: [Qemu-devel] [PATCH 2/9] file-posix: x-check-cache-dropped should default to false on reopen

2018-08-29 Thread Max Reitz
On 2018-08-26 16:09, Alberto Garcia wrote: > The default value of x-check-cache-dropped is false. There's no reason > to use the previous value as a default in raw_reopen_prepare() because > bdrv_reopen_queue_child() already takes care of putting the old > options in the BDRVReopenState.options QDi

Re: [Qemu-devel] [PATCH v4 00/29] vhost-user for input & GPU

2018-08-29 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Fri, Jul 13, 2018 at 03:08:47PM +0200, Marc-André Lureau wrote: > > Hi, > > > > vhost-user allows to drive a virtio device in a seperate > > process. After vhost-user-net, we have seen > > vhost-user-{scsi,blk,crypto} added more recently. > >

Re: [Qemu-devel] [PATCH 1/9] qemu-io: Fix writethrough check in reopen

2018-08-29 Thread Max Reitz
On 2018-08-26 16:09, Alberto Garcia wrote: > "qemu-io reopen" doesn't allow changing the writethrough setting of > the cache, but the check is wrong, causing an error even on a simple > reopen with the default parameters: > >$ qemu-img create -f qcow2 hd.qcow2 1M >$ qemu-system-x86_64 -mon

Re: [Qemu-devel] [PATCH v4 00/29] vhost-user for input & GPU

2018-08-29 Thread Daniel P . Berrangé
On Wed, Aug 29, 2018 at 11:22:01AM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > On Fri, Jul 13, 2018 at 03:08:47PM +0200, Marc-André Lureau wrote: > > > Hi, > > > > > > vhost-user allows to drive a virtio device in a seperate > > > process. After vho

Re: [Qemu-devel] [PATCH 3/9] block: Remove child references from bs->{options, explicit_options}

2018-08-29 Thread Max Reitz
On 2018-08-26 16:09, Alberto Garcia wrote: > Block drivers allow opening their children using a reference to an > existing BlockDriverState. These references remain stored in the > 'options' and 'explicit_options' QDicts, but we don't need to keep > them once everything is open. > > What is more i

Re: [Qemu-devel] [PATCH 4/9] block: Don't look for child references in append_open_options()

2018-08-29 Thread Max Reitz
On 2018-08-26 16:09, Alberto Garcia wrote: > In the previous patch we removed child references from bs->options, so > there's no need to look for them here anymore. > > Signed-off-by: Alberto Garcia > --- > block.c | 13 + > 1 file changed, 1 insertion(+), 12 deletions(-) Reviewed-b

Re: [Qemu-devel] qemu 2.12.0 crash during install windows 10 with vga.

2018-08-29 Thread Dr. David Alan Gilbert
* Changlimin (changli...@h3c.com) wrote: > Hi, > I have the same issue as https://www.qubes-os.org/doc/windows-vm/ , it's not > easy to reproduce. > cpu_physical_memory_snapshot_get_dirty: Assertion `start + length <= > snap->end' failed > > Qemu version is 2.12.0. > (gdb) bt > #0 0x7f504e

Re: [Qemu-devel] [PATCH 7/9] block: Allow changing 'discard' on reopen

2018-08-29 Thread Max Reitz
On 2018-08-26 16:09, Alberto Garcia wrote: > 'discard' is one of the basic BlockdevOptions available for all > drivers, but it's silently ignored by bdrv_reopen_prepare/commit(), so > the user cannot change it and doesn't get an error explaining that it > can't be changed. > > This should update t

Re: [Qemu-devel] [RFC V1] hw/pci/pci_example.c : Added a new pci device

2018-08-29 Thread Cornelia Huck
On Tue, 28 Aug 2018 10:24:26 +0300 Yoni Bettan wrote: > - this is a simple example of how to write a pci device that supports > portio, mmio, irq and dma Do you also plan to add example code for MSI(-X)? [Not just asking because s390 only supports MSI-X. Honestly :)] > > Signed-off-

[Qemu-devel] [PATCH 14/16] virtio: split virtio gpu bits rom virtio-pci.h

2018-08-29 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/display/virtio-gpu-pci.c | 14 ++ hw/display/virtio-vga.c | 1 + hw/virtio/virtio-pci.h | 14 -- tests/Makefile.include | 4 ++-- 4 files changed, 17 insertions(+), 16 deletions(-) diff --git a/hw/display/virtio-gpu-pci.

[Qemu-devel] [PATCH 03/16] virtio: split virtio input bits from virtio-pci

2018-08-29 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/virtio/Makefile.objs | 1 + hw/virtio/virtio-input-pci.c | 154 +++ hw/virtio/virtio-pci.c | 113 - hw/virtio/virtio-pci.h | 22 - 4 files changed, 155 insertions(+), 135 deletions(

[Qemu-devel] [PATCH 16/16] virtio: virtio 9p really requires CONFIG_VIRTFS to work

2018-08-29 Thread Juan Quintela
Otherwise, it has no implementation. Signed-off-by: Juan Quintela --- default-configs/virtio.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/default-configs/virtio.mak b/default-configs/virtio.mak index 5ae4a61018..ecb4420e74 100644 --- a/default-configs/virtio.mak +++ b/

[Qemu-devel] [PATCH 15/16] virtio: split virtio crypto bits rom virtio-pci.h

2018-08-29 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/virtio/virtio-crypto-pci.c | 14 ++ hw/virtio/virtio-pci.h| 14 -- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/hw/virtio/virtio-crypto-pci.c b/hw/virtio/virtio-crypto-pci.c index bf64996e48..1b242d3037 100644

[Qemu-devel] [PATCH 06/16] virtio: split virtio 9p bits from virtio-pci

2018-08-29 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/virtio/Makefile.objs | 1 + hw/virtio/virtio-9p-pci.c | 86 +++ hw/virtio/virtio-pci.c| 52 --- hw/virtio/virtio-pci.h| 20 - 4 files changed, 87 insertions(+), 72 deletions(-) create m

[Qemu-devel] [PATCH 10/16] virtio: split virtio scsi bits from virtio-pci

2018-08-29 Thread Juan Quintela
Notice that we can't still run tests with it disabled. Both cdrom-test and drive_del-test use virtio-scsi without checking if it is enabled. Reviewed-by: Thomas Huth Signed-off-by: Juan Quintela --- hw/virtio/Makefile.objs | 1 + hw/virtio/virtio-pci.c | 69 ---

[Qemu-devel] [PATCH 11/16] virtio: split virtio blk bits rom virtio-pci

2018-08-29 Thread Juan Quintela
Reviewed-by: Thomas Huth Signed-off-by: Juan Quintela --- hw/virtio/Makefile.objs| 1 + hw/virtio/virtio-blk-pci.c | 97 ++ hw/virtio/virtio-pci.c | 59 --- hw/virtio/virtio-pci.h | 14 -- tests/Makefile.include | 4 +-

[Qemu-devel] [PATCH 12/16] virtio: split virtio net bits rom virtio-pci

2018-08-29 Thread Juan Quintela
Reviewed-by: Thomas Huth Signed-off-by: Juan Quintela --- hw/virtio/Makefile.objs| 1 + hw/virtio/virtio-net-pci.c | 96 ++ hw/virtio/virtio-pci.c | 57 -- hw/virtio/virtio-pci.h | 14 -- tests/Makefile.include | 4 +-

[Qemu-devel] [PATCH 02/16] virtio: split virtio input host bits from virtio-pci

2018-08-29 Thread Juan Quintela
Signed-off-by: Juan Quintela --- default-configs/virtio.mak| 1 + hw/virtio/Makefile.objs | 1 + hw/virtio/virtio-input-host-pci.c | 45 +++ hw/virtio/virtio-pci.c| 20 -- hw/virtio/virtio-pci.h| 14 -- 5

[Qemu-devel] [PATCH 08/16] virtio: split vhost user scsi bits from virtio-pci

2018-08-29 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/virtio/Makefile.objs | 1 + hw/virtio/vhost-user-scsi-pci.c | 101 hw/virtio/virtio-pci.c | 58 -- hw/virtio/virtio-pci.h | 11 4 files changed, 102 insertions(+), 69 deletions(

[Qemu-devel] [PATCH 13/16] virtio: split virtio serial bits rom virtio-pci

2018-08-29 Thread Juan Quintela
Virtio console and qga tests also depend on CONFIG_VIRTIO_SERIAL. Reviewed-by: Thomas Huth Signed-off-by: Juan Quintela --- hw/virtio/Makefile.objs | 1 + hw/virtio/virtio-pci.c| 75 --- hw/virtio/virtio-pci.h| 14 - hw/virtio/virtio-serial-pci.

[Qemu-devel] [PATCH 07/16] virtio: split vhost user blk bits from virtio-pci

2018-08-29 Thread Juan Quintela
Reviewed-by: Thomas Huth Signed-off-by: Juan Quintela --- hw/virtio/Makefile.objs| 1 + hw/virtio/vhost-user-blk-pci.c | 101 + hw/virtio/virtio-pci.c | 60 hw/virtio/virtio-pci.h | 18 -- 4 files changed, 102 i

Re: [Qemu-devel] [PATCH v2 10/10] i2c: Add vmstate handling to the smbus eeprom

2018-08-29 Thread Dr. David Alan Gilbert
* miny...@acm.org (miny...@acm.org) wrote: > From: Corey Minyard > > Signed-off-by: Corey Minyard > Cc: Paolo Bonzini > Cc: "Michael S . Tsirkin" > Cc: Dr. David Alan Gilbert > --- > hw/i2c/smbus_eeprom.c | 16 +++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --gi

Re: [Qemu-devel] [libvirt] clean/simple Q35 support in libvirt+QEMU for guest OSes that don't support virtio-1.0

2018-08-29 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Fri, Aug 17, 2018 at 03:13:22PM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > On Fri, Aug 17, 2018 at 12:35:11PM +0200, Andrea Bolognani wrote: >> >> On Fri, 2018-08-17 at 10:29 +0100, Daniel P. Berrangé wrote: >> >> > On Thu, Aug 16, 2018

[Qemu-devel] [PATCH 09/16] virtio: split vhost scsi bits from virtio-pci

2018-08-29 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/virtio/Makefile.objs| 1 + hw/virtio/vhost-scsi-pci.c | 95 ++ hw/virtio/virtio-pci.c | 59 --- hw/virtio/virtio-pci.h | 19 4 files changed, 96 insertions(+), 78 deletions(-) create

Re: [Qemu-devel] [PATCH 8/9] block: Allow changing 'detect-zeroes' on reopen

2018-08-29 Thread Max Reitz
On 2018-08-26 16:09, Alberto Garcia wrote: > 'detect-zeroes' is one of the basic BlockdevOptions available for all > drivers, but it's silently ignored by bdrv_reopen_prepare/commit(), so > the user cannot change it and doesn't get an error explaining that it > can't be changed. > > This should up

Re: [Qemu-devel] [PATCH 6/9] file-posix: Forbid trying to change unsupported options during reopen

2018-08-29 Thread Max Reitz
On 2018-08-26 16:09, Alberto Garcia wrote: > The file-posix code is used for the "file", "host_device" and > "host_cdrom" drivers, and it allows reopening images. However the only > option that is actually processed is "x-check-cache-dropped", and > changes in all other options (e.g. "filename") ar

[Qemu-devel] [PATCH 05/16] virtio: split virtio balloon bits from virtio-pci

2018-08-29 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth Signed-off-by: Juan Quintela --- hw/virtio/Makefile.objs| 1 + hw/virtio/virtio-balloon-pci.c | 94 ++ hw/virtio/virtio-pci.c | 58 - hw/virtio/virtio-pci.h | 14 --

Re: [Qemu-devel] [PATCH 5/9] block: Allow child references on reopen

2018-08-29 Thread Max Reitz
On 2018-08-26 16:09, Alberto Garcia wrote: > In the previous patches we removed all child references from > bs->{options,explicit_options} because keeping them is useless and > wrong. > > Because of this, any attempt to reopen a BlockDriverState using a > child reference as one of its options woul

[Qemu-devel] [PATCH 01/16] virtio: split vhost vsock bits from virtio-pci

2018-08-29 Thread Juan Quintela
Signed-off-by: Juan Quintela --- Updated copyright info Also split virtio-pci.h bits --- hw/virtio/Makefile.objs | 2 +- hw/virtio/vhost-vsock-pci.c | 82 + hw/virtio/virtio-pci.c | 51 --- hw/virtio/virtio-pci.h | 18 --

Re: [Qemu-devel] [PATCH v4 00/29] vhost-user for input & GPU

2018-08-29 Thread Marc-André Lureau
Hi On Wed, Aug 29, 2018 at 11:50 AM, Daniel P. Berrangé wrote: > On Fri, Jul 13, 2018 at 03:08:47PM +0200, Marc-André Lureau wrote: >> Hi, >> >> vhost-user allows to drive a virtio device in a seperate >> process. After vhost-user-net, we have seen >> vhost-user-{scsi,blk,crypto} added more recen

[Qemu-devel] [PATCH 04/16] virtio: split virtio rng bits from virtio-pci

2018-08-29 Thread Juan Quintela
Signed-off-by: Juan Quintela --- Remove the "contributions after" clause. This is based on commit 59ccd20a9ac719cff82180429458728f03ec612f Author: KONRAD Frederic Date: Wed Apr 24 10:07:56 2013 +0200 --- hw/virtio/Makefile.objs| 1 + hw/virtio/virtio-pci.c | 52 ---

Re: [Qemu-devel] [PATCH 7/9] block: Allow changing 'discard' on reopen

2018-08-29 Thread Max Reitz
On 2018-08-26 16:09, Alberto Garcia wrote: > 'discard' is one of the basic BlockdevOptions available for all > drivers, but it's silently ignored by bdrv_reopen_prepare/commit(), so > the user cannot change it and doesn't get an error explaining that it > can't be changed. > > This should update t

[Qemu-devel] [PATCH 00/16] Virtio devices split from virtio-pci

2018-08-29 Thread Juan Quintela
>From previous verision (in the middle of make check tests): - split also the bits of virtio-pci.h (mst suggestion) - add gpu, crypt and gpg bits - more cleanups - fix all the copyrights (the ones not changed have been there foverever) - be consistent with naming, vhost-* or virtio-* Please revi

Re: [Qemu-devel] [PATCH 3/9] block: Remove child references from bs->{options, explicit_options}

2018-08-29 Thread Alberto Garcia
On Wed 29 Aug 2018 12:43:06 PM CEST, Max Reitz wrote: > On 2018-08-26 16:09, Alberto Garcia wrote: >> Block drivers allow opening their children using a reference to an >> existing BlockDriverState. These references remain stored in the >> 'options' and 'explicit_options' QDicts, but we don't need

Re: [Qemu-devel] [PATCH v2 05/10] i2c:pm_smbus: Fix state transfer

2018-08-29 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > On 20/08/2018 22:26, miny...@acm.org wrote: > > From: Corey Minyard > > > > Transfer the state information for the SMBus registers and > > internal data so it will work on a VM transfer. > > Since the device is mostly unused, I would rather have thi

Re: [Qemu-devel] [PATCH 9/9] block: Allow changing 'force-share' on reopen

2018-08-29 Thread Max Reitz
On 2018-08-26 16:09, Alberto Garcia wrote: > 'force-share' is one of the basic BlockdevOptions available for all > drivers, but it's silently ignored by bdrv_reopen_prepare/commit(), so > the user cannot change it and doesn't get an error explaining that it > can't be changed. > > One example of h

Re: [Qemu-devel] [PATCH v4 00/11] Add a standard authorization framework

2018-08-29 Thread Daniel P . Berrangé
Ping, is anyone able to review this series ? On Thu, Aug 16, 2018 at 02:01:07PM +0100, Daniel P. Berrangé wrote: > An update to > > v2: https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg04469.html > v3: https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg05660.html > > The current

Re: [Qemu-devel] [PATCH v2 10/10] i2c: Add vmstate handling to the smbus eeprom

2018-08-29 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > * miny...@acm.org (miny...@acm.org) wrote: > > From: Corey Minyard > > > > Signed-off-by: Corey Minyard > > Cc: Paolo Bonzini > > Cc: "Michael S . Tsirkin" > > Cc: Dr. David Alan Gilbert > > --- > > hw/i2c/smbus_eeprom.c | 16 ++

Re: [Qemu-devel] [PATCH v2 09/10] i2c: Add an SMBus vmstate structure

2018-08-29 Thread Dr. David Alan Gilbert
* miny...@acm.org (miny...@acm.org) wrote: > From: Corey Minyard > > Signed-off-by: Corey Minyard > Cc: Paolo Bonzini > Cc: "Michael S . Tsirkin" > Cc: Dr. David Alan Gilbert > --- > hw/i2c/smbus.c | 14 ++ > include/hw/i2c/smbus.h | 18 +++--- > 2 files chang

Re: [Qemu-devel] [PATCH 3/9] block: Remove child references from bs->{options, explicit_options}

2018-08-29 Thread Max Reitz
On 2018-08-29 13:53, Alberto Garcia wrote: > On Wed 29 Aug 2018 12:43:06 PM CEST, Max Reitz wrote: >> On 2018-08-26 16:09, Alberto Garcia wrote: >>> Block drivers allow opening their children using a reference to an >>> existing BlockDriverState. These references remain stored in the >>> 'options'

[Qemu-devel] [PATCH 0/2] virtio-gpu: add iommu support

2018-08-29 Thread Gerd Hoffmann
Gerd Hoffmann (2): virtio-gpu: pass down VirtIOGPU pointer to a bunch of functions virtio-gpu: add iommu support include/hw/virtio/virtio-gpu.h | 6 +++-- hw/display/virtio-gpu-3d.c | 8 +++ hw/display/virtio-gpu.c| 50 -- 3 files c

[Qemu-devel] [PATCH 2/2] virtio-gpu: add iommu support

2018-08-29 Thread Gerd Hoffmann
Switch from cpu_physical_memory_map to dma_memory_map, so iommu mappings for virtio-gpu objects work properly. Signed-off-by: Gerd Hoffmann --- hw/display/virtio-gpu.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/hw/display/virtio-gpu.c b/hw/dis

[Qemu-devel] [PATCH 1/2] virtio-gpu: pass down VirtIOGPU pointer to a bunch of functions

2018-08-29 Thread Gerd Hoffmann
No functional change, just preparation for a followup patch which needs a VirtIOGPU pointer. Signed-off-by: Gerd Hoffmann --- include/hw/virtio/virtio-gpu.h | 6 -- hw/display/virtio-gpu-3d.c | 8 hw/display/virtio-gpu.c| 25 +++-- 3 files changed,

[Qemu-devel] [PATCH 0/5] contrib: add elf2dmp tool

2018-08-29 Thread Viktor Prutyanov
elf2dmp is a converter from ELF dump (produced by 'dump-guest-memory') to Windows MEMORY.DMP format (also know as 'Complete Memory Dump') which can be opened in WinDbg. This tool can help if VMCoreInfo device/driver is absent in Windows VM and 'dump-guest-memory -w' is not available but dump can b

[Qemu-devel] [PATCH 5/5] contrib/elf2dmp: add 1GB and 2MB pages support

2018-08-29 Thread Viktor Prutyanov
After this patch 1GB and 2MB pages are being correctly processed during virtual address resolving. Signed-off-by: Viktor Prutyanov --- contrib/elf2dmp/addrspace.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/contrib/elf2dmp/addrspace.c b/contrib/elf2dmp/addrspace.

[Qemu-devel] [PATCH 3/5] contrib/elf2dmp: improve paging root selection

2018-08-29 Thread Viktor Prutyanov
Even if KERNEL_GS_BASEs are absent in QEMU CPU states, there is a chance to find suitable CR3 value from CPU which runs kernel task. Signed-off-by: Viktor Prutyanov --- contrib/elf2dmp/main.c | 56 +++--- contrib/elf2dmp/qemu_elf.c | 16 +++--

Re: [Qemu-devel] [PATCH 5/9] block: Allow child references on reopen

2018-08-29 Thread Alberto Garcia
On Wed 29 Aug 2018 01:26:46 PM CEST, Max Reitz wrote: > On 2018-08-26 16:09, Alberto Garcia wrote: >> In the previous patches we removed all child references from >> bs->{options,explicit_options} because keeping them is useless and >> wrong. >> >> Because of this, any attempt to reopen a BlockDri

[Qemu-devel] [PATCH 4/5] contrib/elf2dmp: add DMP file name as 2nd argument

2018-08-29 Thread Viktor Prutyanov
Before this patch output DMP file name was strictly 'memory.dmp'. Signed-off-by: Viktor Prutyanov --- contrib/elf2dmp/main.c | 34 +++--- 1 file changed, 23 insertions(+), 11 deletions(-) diff --git a/contrib/elf2dmp/main.c b/contrib/elf2dmp/main.c index 62f08e0..647

Re: [Qemu-devel] [PATCH 6/9] file-posix: Forbid trying to change unsupported options during reopen

2018-08-29 Thread Alberto Garcia
On Wed 29 Aug 2018 01:33:13 PM CEST, Max Reitz wrote: > On 2018-08-26 16:09, Alberto Garcia wrote: >> The file-posix code is used for the "file", "host_device" and >> "host_cdrom" drivers, and it allows reopening images. However the only >> option that is actually processed is "x-check-cache-droppe

[Qemu-devel] [PATCH 1/5] dump: move Windows dump structures definitions

2018-08-29 Thread Viktor Prutyanov
This patch moves definitions of Windows dump structures to include/qemu/win_dump_defs.h to keep create_win_dump() prototype separate. Signed-off-by: Viktor Prutyanov --- include/qemu/win_dump_defs.h | 179 +++ win_dump.h | 166 +--

Re: [Qemu-devel] [Query] Live Migration between machines with different processor ids

2018-08-29 Thread Jaggi, Manish
> On 28-Aug-2018, at 10:57 PM, Dr. David Alan Gilbert > wrote: > > External Email > > (Cc'ing in Eric, Drew, and Peter for ARM stuff) > Thanks, > * Jaggi, Manish (manish.ja...@cavium.com) wrote: >> >> >>> On 23-Aug-2018, at 7:59 PM, Juan Quintela wrote: >>> >>> External Email >>> >>> "J

Re: [Qemu-devel] [PATCH v3 4/9] monitor: no need to save need_resume

2018-08-29 Thread Markus Armbruster
Peter Xu writes: > On Wed, Aug 29, 2018 at 10:55:51AM +0200, Markus Armbruster wrote: >> Peter Xu writes: >> >> > On Tue, Aug 28, 2018 at 05:46:29PM +0200, Markus Armbruster wrote: >> >> Peter Xu writes: >> >> >> >> > On Sat, Aug 25, 2018 at 03:57:19PM +0200, Marc-André Lureau wrote: >> >> >>

Re: [Qemu-devel] [PATCH] hostmem-memfd: honour share=on/off property

2018-08-29 Thread Marc-André Lureau
Hi On Wed, Aug 29, 2018 at 10:50 AM Igor Mammedov wrote: > > On Tue, 28 Aug 2018 18:55:35 +0200 > Marc-André Lureau wrote: > > > On Tue, Aug 28, 2018 at 6:54 PM Marc-André Lureau > > wrote: > > > > > > Hi > > > > > > On Tue, Aug 28, 2018 at 6:49 PM Igor Mammedov wrote: > > > > > > > > On Tue,

Re: [Qemu-devel] [PATCH 5/9] block: Allow child references on reopen

2018-08-29 Thread Max Reitz
On 2018-08-29 14:29, Alberto Garcia wrote: > On Wed 29 Aug 2018 01:26:46 PM CEST, Max Reitz wrote: >> On 2018-08-26 16:09, Alberto Garcia wrote: >>> In the previous patches we removed all child references from >>> bs->{options,explicit_options} because keeping them is useless and >>> wrong. >>> >>>

Re: [Qemu-devel] [PATCH 5/9] block: Allow child references on reopen

2018-08-29 Thread Max Reitz
On 2018-08-29 14:59, Max Reitz wrote: > On 2018-08-29 14:29, Alberto Garcia wrote: >> On Wed 29 Aug 2018 01:26:46 PM CEST, Max Reitz wrote: [...] >>> So why isn't it mandatory to re-specify all children for now? >> >> It is > Is it? Why does > > $ qemu-io -c 'reopen -o lazy-refcounts=on' foo.qc

Re: [Qemu-devel] [PATCH 6/9] file-posix: Forbid trying to change unsupported options during reopen

2018-08-29 Thread Max Reitz
On 2018-08-29 14:33, Alberto Garcia wrote: > On Wed 29 Aug 2018 01:33:13 PM CEST, Max Reitz wrote: >> On 2018-08-26 16:09, Alberto Garcia wrote: >>> The file-posix code is used for the "file", "host_device" and >>> "host_cdrom" drivers, and it allows reopening images. However the only >>> option th

Re: [Qemu-devel] [RFC V1] hw/pci/pci_example.c : Added a new pci device

2018-08-29 Thread Eduardo Habkost
Hi, Thanks for the patch. On Tue, Aug 28, 2018 at 10:24:26AM +0300, Yoni Bettan wrote: > - this is a simple example of how to write a pci device that supports > portio, mmio, irq and dma Can we have some documentation on what are the goals of the example device, and what exactly it doe

Re: [Qemu-devel] [PATCH] pc: make sure that guest isn't able to unplug the first cpu

2018-08-29 Thread Michael S. Tsirkin
On Wed, Aug 29, 2018 at 10:43:11AM +0200, Igor Mammedov wrote: > On Wed, 29 Aug 2018 12:54:40 +1000 > David Gibson wrote: > > > On Tue, Aug 28, 2018 at 03:18:48PM +0200, Igor Mammedov wrote: > > > On Tue, 28 Aug 2018 10:52:37 +1000 > > > David Gibson wrote: > > > > > > > On Mon, Aug 27, 2018

Re: [Qemu-devel] [Query] Live Migration between machines with different processor ids

2018-08-29 Thread Andrew Jones
On Wed, Aug 29, 2018 at 12:40:08PM +, Jaggi, Manish wrote: > > > > On 28-Aug-2018, at 10:57 PM, Dr. David Alan Gilbert > > wrote: > > > > External Email > > > > (Cc'ing in Eric, Drew, and Peter for ARM stuff) > > > Thanks, > > * Jaggi, Manish (manish.ja...@cavium.com) wrote: > >> > >>

Re: [Qemu-devel] blkdebug get_status bug [was: [Qemu-block] NBD structured reads vs. block size]

2018-08-29 Thread Max Reitz
On 2018-08-28 23:59, Eric Blake wrote: > [following up to a different set of emails] > > On 08/28/2018 03:41 PM, Eric Blake wrote: >> Revisiting this: >> >> On 08/01/2018 09:41 AM, Eric Blake wrote: >>> Rich Jones pointed me to questionable behavior in qemu's NBD server >>> implementation today: q

Re: [Qemu-devel] [PATCH v2 00/11] block: Deal with filters

2018-08-29 Thread Max Reitz
Eric inadvertently pointed me to the fact that qemu-img needs some additional work. Its get_block_status() should completely skip R/W filters (just adding a "bs = bdrv_skip_rw_filters()" at the top of the loop is enough -- in turn, I can probably drop the bdrv_skip_implicit_filters() at the bottom

Re: [Qemu-devel] [PATCH v3 4/9] monitor: no need to save need_resume

2018-08-29 Thread Marc-André Lureau
Hi On Wed, Aug 29, 2018 at 2:51 PM Markus Armbruster wrote: > > > So I think now I agree with you that the response queue is not > > required if we think the first solution is okay for us. > > Cool. Can you explore that and post patches? > As we agree to drop the response queue, I am sending re

[Qemu-devel] [PATCH v4 01/10] monitor: consitify qmp_send_response() QDict argument

2018-08-29 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- monitor.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/monitor.c b/monitor.c index 021c11b1bf..a1db4db487 100644 --- a/monitor.c +++ b/monitor.c @@ -503,9 +503,9 @@ int monitor_fprintf(FILE *stream, co

[Qemu-devel] [PATCH v4 04/10] monitor: no need to save need_resume

2018-08-29 Thread Marc-André Lureau
There is no need for per-command need_resume granularity, it should resume after running an non-oob command on oob-disabled monitor. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- monitor.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/mo

  1   2   3   >