Re: [Qemu-devel] [PATCH v5 2/3] arm: Add Nordic Semiconductor nRF51 SoC

2018-08-26 Thread Peter Maydell
On 26 August 2018 at 01:48, Joel Stanley wrote: > I agree that it would be neater to do this. I didn't as the flash is > part of the NRF51822 SoC, opposed to some external flash that is on > the microbit board and connected to the SoC. This is mentioned in the > comment at the start of the file: >

[Qemu-devel] [PATCH 1/1] vga: honor blink attribute in text modes

2018-08-26 Thread Michael Slade
Signed-off-by: Michael Slade --- hw/display/vga.c | 50 +--- hw/display/vga_int.h | 2 ++ 2 files changed, 40 insertions(+), 12 deletions(-) diff --git a/hw/display/vga.c b/hw/display/vga.c index 72181330b8..03d9181d58 100644 --- a/hw/display/vga.c ++

[Qemu-devel] [PATCH 1/9] qemu-io: Fix writethrough check in reopen

2018-08-26 Thread Alberto Garcia
"qemu-io reopen" doesn't allow changing the writethrough setting of the cache, but the check is wrong, causing an error even on a simple reopen with the default parameters: $ qemu-img create -f qcow2 hd.qcow2 1M $ qemu-system-x86_64 -monitor stdio -drive if=virtio,file=hd.qcow2 (qemu) qem

[Qemu-devel] [PATCH 2/9] file-posix: x-check-cache-dropped should default to false on reopen

2018-08-26 Thread Alberto Garcia
The default value of x-check-cache-dropped is false. There's no reason to use the previous value as a default in raw_reopen_prepare() because bdrv_reopen_queue_child() already takes care of putting the old options in the BDRVReopenState.options QDict. If x-check-cache-dropped was previously set bu

[Qemu-devel] [PATCH 9/9] block: Allow changing 'force-share' on reopen

2018-08-26 Thread Alberto Garcia
'force-share' is one of the basic BlockdevOptions available for all drivers, but it's silently ignored by bdrv_reopen_prepare/commit(), so the user cannot change it and doesn't get an error explaining that it can't be changed. One example of how this option is being ignored is that on a read-write

[Qemu-devel] [PATCH 6/9] file-posix: Forbid trying to change unsupported options during reopen

2018-08-26 Thread Alberto Garcia
The file-posix code is used for the "file", "host_device" and "host_cdrom" drivers, and it allows reopening images. However the only option that is actually processed is "x-check-cache-dropped", and changes in all other options (e.g. "filename") are silently ignored: (qemu) qemu-io virtio0 "reo

[Qemu-devel] [PATCH 5/9] block: Allow child references on reopen

2018-08-26 Thread Alberto Garcia
In the previous patches we removed all child references from bs->{options,explicit_options} because keeping them is useless and wrong. Because of this, any attempt to reopen a BlockDriverState using a child reference as one of its options would result in a failure, because bdrv_reopen_prepare() wo

[Qemu-devel] [PATCH 4/9] block: Don't look for child references in append_open_options()

2018-08-26 Thread Alberto Garcia
In the previous patch we removed child references from bs->options, so there's no need to look for them here anymore. Signed-off-by: Alberto Garcia --- block.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/block.c b/block.c index 2f2484965d..92afb3dcce 100644

[Qemu-devel] [PATCH 7/9] block: Allow changing 'discard' on reopen

2018-08-26 Thread Alberto Garcia
'discard' is one of the basic BlockdevOptions available for all drivers, but it's silently ignored by bdrv_reopen_prepare/commit(), so the user cannot change it and doesn't get an error explaining that it can't be changed. This should update the discard setting, but does nothing: (qemu) qemu-i

[Qemu-devel] [PATCH 0/9] Misc reopen-related patches

2018-08-26 Thread Alberto Garcia
Hi, as part of my blockdev-reopen work here's a new set of patches. This doesn't implement yet the core functionality of the new reopen command, but it does fix a few things that help us pave the way. I believe that the next series after this one will be the last. The main change is the removal o

[Qemu-devel] [PATCH 8/9] block: Allow changing 'detect-zeroes' on reopen

2018-08-26 Thread Alberto Garcia
'detect-zeroes' is one of the basic BlockdevOptions available for all drivers, but it's silently ignored by bdrv_reopen_prepare/commit(), so the user cannot change it and doesn't get an error explaining that it can't be changed. This should update the detect-zeroes setting, but does nothing: (

[Qemu-devel] [PATCH 3/9] block: Remove child references from bs->{options, explicit_options}

2018-08-26 Thread Alberto Garcia
Block drivers allow opening their children using a reference to an existing BlockDriverState. These references remain stored in the 'options' and 'explicit_options' QDicts, but we don't need to keep them once everything is open. What is more important, these values can become wrong if the children

Re: [Qemu-devel] [PATCH] Fix ARM v7m gen_intermediate_code()

2018-08-26 Thread Christopher Friedt
In the end it was just incorrect alignment for my vector table

Re: [Qemu-devel] [PATCH 1/5] nvme: PCI/e configuration from specification

2018-08-26 Thread Gersner
Hi Daniel, Thanks for taking a look. Comments are inline. Gersner. On Sun, Jul 15, 2018 at 9:21 AM Daniel Verkamp wrote: > On Fri, Jun 22, 2018 at 4:22 AM, Shimi Gersner wrote: > > PCI/e configuration currently does not meets specifications. > > > > Patch includes various configuration changes

Re: [Qemu-devel] [PATCH] spapr: fix leak of rev array

2018-08-26 Thread David Gibson
On Fri, Aug 24, 2018 at 04:31:01PM -0400, Emilio G. Cota wrote: > Introduced in 04d595b300 ("spapr: do not use CPU_FOREACH_REVERSE", > 2018-08-23) > > Fixes: CID1395181 > Reported-by: Peter Maydell > Signed-off-by: Emilio G. Cota > --- > hw/ppc/spapr.c | 1 + > 1 file changed, 1 insertion(+) >

Re: [Qemu-devel] [PATCH] spapr_pci: fix potential NULL pointer dereference

2018-08-26 Thread David Gibson
On Fri, Aug 24, 2018 at 05:30:04PM +0200, Greg Kurz wrote: > Commit 2c88b098e76fd added a call to SPAPR_MACHINE_GET_CLASS(spapr) in > spapr_phb_realize() before we check spapr isn't NULL. This causes QEMU > to crash when starting a non-pseries machine with a sPAPR PHB. > > This could be fixed by s

Re: [Qemu-devel] [RFC v4 1/6] pci_expander_bridge: add type TYPE_PXB_PCIE_HOST

2018-08-26 Thread Zihan Yang
Marcel Apfelbaum 于2018年8月25日周六 下午8:08写道: > > Hi Zihan, > > On 08/19/2018 04:51 AM, Zihan Yang wrote: > > Hi Marcel, > > > > Marcel Apfelbaum 于2018年8月18日周六 上午1:14写道: > >> Hi Zihan, > >> > >> On 08/09/2018 09:33 AM, Zihan Yang wrote: > >>> The inner host bridge created by pxb-pcie is TYPE_PXB_PCI_H

Re: [Qemu-devel] [RFC v4 3/6] i386/acpi-build: describe new pci domain in AML

2018-08-26 Thread Zihan Yang
Marcel Apfelbaum 于2018年8月25日周六 下午7:58写道: > > > > On 08/19/2018 05:00 AM, Zihan Yang wrote: > > Marcel Apfelbaum 于2018年8月18日周六 上午1:49写道: > >> > >> > >> On 08/09/2018 09:34 AM, Zihan Yang wrote: > >>> Describe new pci segments of host bridges in AML as new pci devices, > >>> with _SEG and _BBN to l

Re: [Qemu-devel] [PATCH] slirp: Implement RFC2132 TFTP server name

2018-08-26 Thread Fam Zheng
On Fri, 08/24 11:21, Eric Blake wrote: > On 08/24/2018 08:53 AM, Fam Zheng wrote: > > This new usernet option can be used to add data for option 66 (tftp > > server name) in the BOOTP reply, which is useful in PXE based automatic > > OS install such as OpenBSD. > > > > Signed-off-by: Fam Zheng >

Re: [Qemu-devel] [PATCH] slirp: Implement RFC2132 TFTP server name

2018-08-26 Thread Fam Zheng
On Sat, 08/25 18:53, Samuel Thibault wrote: > Hello, > > Fam Zheng, le ven. 24 août 2018 21:53:12 +0800, a ecrit: > >const char *vnameserver, const char > > *vnameserver6, > >const char *smb_export, const char *vsmbserver, > >

[Qemu-devel] [PATCH v2] slirp: Implement RFC2132 TFTP server name

2018-08-26 Thread Fam Zheng
This new usernet option can be used to add data for option 66 (tftp server name) in the BOOTP reply, which is useful in PXE based automatic OS install such as OpenBSD. Signed-off-by: Fam Zheng --- v2: - Adjust parameter order and field placement to be closer to other tftp options. [Samuel] -

Re: [Qemu-devel] [RFC 0/3] chardev: introduce chardev contexts

2018-08-26 Thread Peter Xu
On Fri, Aug 24, 2018 at 03:46:03PM +0200, Marc-André Lureau wrote: > Hi, > > On Fri, Aug 24, 2018 at 11:10 AM Peter Xu wrote: > > > > This is a RFC series. It majorly did these things: > > > > (1) move the monitor iothread management from monitor code to chardev > > code somehow, > > > > (2)

Re: [Qemu-devel] [PATCH v3 2/2] hw/pci: add PCI resource reserve capability to legacy PCI bridge

2018-08-26 Thread Liu, Jing2
Hi Marcel, On 8/25/2018 12:51 AM, Marcel Apfelbaum wrote: On 08/21/2018 06:18 AM, Jing Liu wrote: Add hint to firmware (e.g. SeaBIOS) to reserve addtional BUS/IO/MEM/PREF resource for legacy pci-pci bridge. Add the resource reserve capability deleting in pci_bridge_dev_exitfn. Signed-off-by: J

Re: [Qemu-devel] [PULL 12/25] tests: Clean up string interpolation into QMP input (simple cases)

2018-08-26 Thread Markus Armbruster
Eric Blake writes: > On 08/16/2018 03:36 AM, Markus Armbruster wrote: >> When you build QMP input manually like this >> >> cmd = g_strdup_printf("{ 'execute': 'migrate'," >>"'arguments': { 'uri': '%s' } }", >>uri); >> rsp = qmp(cmd

[Qemu-devel] [Bug 474968] Re: kvm smb server hogs cpu guest freeze

2018-08-26 Thread Launchpad Bug Tracker
[Expired for qemu-kvm (Ubuntu) because there has been no activity for 60 days.] ** Changed in: qemu-kvm (Ubuntu) Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/474

[Qemu-devel] [Bug 1129571] Re: libreoffice armhf FTBFS

2018-08-26 Thread Launchpad Bug Tracker
[Expired for qemu (Ubuntu) because there has been no activity for 60 days.] ** Changed in: qemu (Ubuntu) Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1129571 Ti

Re: [Qemu-devel] [PATCH v2] gtk: add zoom-to-fit to gtk options.

2018-08-26 Thread Markus Armbruster
Gerd Hoffmann writes: > This allows to set the option on the command line, i.e. "-display > gtk,zoom-to-fit={on,off}", overriding the default choosen by qemu. chosen > > Signed-off-by: Gerd Hoffmann > --- > ui/gtk.c | 8 > qapi/ui.json | 6 +- > 2 files changed, 13 insertions

Re: [Qemu-devel] [PATCH v3 4/9] monitor: no need to save need_resume

2018-08-26 Thread Peter Xu
On Sat, Aug 25, 2018 at 03:57:19PM +0200, Marc-André Lureau wrote: > There is no need for per-command need_resume granularity, it should > resume after running an non-oob command on oob-disabled monitor. > > Signed-off-by: Marc-André Lureau > Reviewed-by: Markus Armbruster Note that this series

[Qemu-devel] [PULL 2/3] intel-iommu: start to use error_report_once

2018-08-26 Thread Markus Armbruster
From: Peter Xu Replace existing trace_vtd_err() with error_report_once() then stderr will capture something if any of the error happens, meanwhile we don't suffer from any DDOS. Then remove the trace point. Since at it, provide more information where proper (now we can pass parameters into the

[Qemu-devel] [PULL 0/3] Error reporting patches for 2018-08-27

2018-08-26 Thread Markus Armbruster
The following changes since commit 235c82acca0491465e94be3cae2583b42d37c859: Merge remote-tracking branch 'remotes/otubo/tags/pull-seccomp-20180823' into staging (2018-08-25 13:08:57 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-error-2018-08-27

[Qemu-devel] [PULL 1/3] qemu-error: introduce {error|warn}_report_once

2018-08-26 Thread Markus Armbruster
From: Peter Xu There are many error_report()s that can be used in frequently called functions, especially on IO paths. That can be unideal in that malicious guest can try to trigger the error tons of time which might use up the log space on the host (e.g., libvirt can capture the stderr of QEMU

[Qemu-devel] [PULL 3/3] intel-iommu: replace more vtd_err_* traces

2018-08-26 Thread Markus Armbruster
From: Peter Xu Replace all the trace_vtd_err_*() hooks with the new error_report_once() since they are similar to trace_vtd_err() - dumping the first error would be mostly enough, then we have them on by default too. Signed-off-by: Peter Xu Message-Id: <20180815095328.32414-4-pet...@redhat.com>

Re: [Qemu-devel] [Qemu-ppc] [PULL 25/26] spapr_pci: factorize the use of SPAPR_MACHINE_GET_CLASS()

2018-08-26 Thread Thomas Huth
On 2018-08-24 18:43, Cédric Le Goater wrote: > On 08/24/2018 05:38 PM, Greg Kurz wrote: >> On Fri, 24 Aug 2018 17:30:12 +0200 >> Cédric Le Goater wrote: >> >>> On 08/24/2018 05:09 PM, Peter Maydell wrote: On 21 August 2018 at 05:33, David Gibson wrote: > From: Cédric Le Goater [

[Qemu-devel] [Bug 1485180] Re: Ctrl Alt G -- Multiple Virtual Machines

2018-08-26 Thread Thomas Huth
Looking through old bug tickets... can you still reproduce this issue with the latest version of QEMU (version 3.0)? Which window manager were you using here? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, wh

[Qemu-devel] [Bug 1493033] Re: memory leak/high memory usage with spice webdav feature

2018-08-26 Thread Thomas Huth
Looking through old bug tickets... can you still reproduce this issue with the latest version of QEMU and spice? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [Qemu-devel] [PATCH v2] slirp: Implement RFC2132 TFTP server name

2018-08-26 Thread Thomas Huth
On 2018-08-27 04:22, Fam Zheng wrote: > This new usernet option can be used to add data for option 66 (tftp > server name) in the BOOTP reply, which is useful in PXE based automatic > OS install such as OpenBSD. > > Signed-off-by: Fam Zheng > --- > > v2: - Adjust parameter order and field placem