[Qemu-devel] [Bug 1180777] Re: RDP traffic freeze on quiet network

2018-08-21 Thread Thomas Huth
** Changed in: qemu-kvm (Ubuntu) Status: Confirmed => Incomplete ** Changed in: debian Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1180777 Title: RDP traf

[Qemu-devel] [Bug 1297487] Re: MTU not honored in virtio vnet

2018-08-21 Thread Thomas Huth
Closing for QEMU since there hasn't been any response within a year. ** Changed in: qemu Status: Incomplete => Won't Fix -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1297487 Title: MTU not

[Qemu-devel] [Bug 965867] Re: 9p virtual file system on qemu slow

2018-08-21 Thread Thomas Huth
** Changed in: qemu-kvm (Ubuntu) Status: Confirmed => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/965867 Title: 9p virtual file system on qemu slow Status in QEMU: Incomplete

Re: [Qemu-devel] [PATCH 1/7] tests/tcg: add a simple s390x test

2018-08-21 Thread David Hildenbrand
On 21.08.2018 04:50, Pavel Zbitskiy wrote: > Copied from alpha. > > Signed-off-by: Pavel Zbitskiy > --- > MAINTAINERS | 1 + > tests/tcg/s390x/Makefile.target | 3 +++ > tests/tcg/s390x/hello-s390x.c | 7 +++ > 3 files changed, 11 insertions(+) > create mode 100644 tes

Re: [Qemu-devel] [PATCH 5/7] target/s390x: add EX support for TRT and TRTR

2018-08-21 Thread David Hildenbrand
On 21.08.2018 04:51, Pavel Zbitskiy wrote: > Improves "b213c9f5: target/s390x: Implement TRTR" by introducing the > intermediate functions, which are compatible with dx_helper type. > > Signed-off-by: Pavel Zbitskiy > --- > target/s390x/mem_helper.c | 16 +++ > tests/tcg/s390x/Make

Re: [Qemu-devel] [PATCH 2/7] target/s390x: add BAL and BALR instructions

2018-08-21 Thread David Hildenbrand
On 21.08.2018 04:50, Pavel Zbitskiy wrote: > These instructions are provided for compatibility purposes and are > used only by old software, in the new code BAS and BASR are preferred. > The difference between the old and new instruction exists only in the > 24-bit mode. > > In addition, fix BAS p

Re: [Qemu-devel] [PATCH 4/7] target/s390x: fix IPM polluting irrelevant bits

2018-08-21 Thread David Hildenbrand
On 21.08.2018 04:51, Pavel Zbitskiy wrote: > Suppose psw.mask=0x8000, cc=2, r1=0 and we do "ipm 1". > This command must touch only bits 32-39, so the expected output > is r1=0x2000. However, currently qemu yields r1=0x20008000, > because irrelevant parts of PSW leak into r1 during p

Re: [Qemu-devel] [PATCH 6/7] target/s390x: fix PACK reading 1 byte less and writing 1 byte more

2018-08-21 Thread David Hildenbrand
On 21.08.2018 04:51, Pavel Zbitskiy wrote: > PACK fails on the test from the Principles of Operation: F1F2F3F4 > becomes 234C instead of 0001234C due to an off-by-one error. > Furthermore, it overwrites one extra byte to the left of F1. > > If len_dest is 0, then we only want to flip the 1st b

Re: [Qemu-devel] [PATCH 3/7] target/s390x: fix CSST decoding and runtime alignment check

2018-08-21 Thread David Hildenbrand
On 21.08.2018 04:51, Pavel Zbitskiy wrote: > CSST is defined as: > > C(0xc802, CSST,SSF, CASS, la1, a2, 0, 0, csst, 0) > > It means that the first parameter is handled by in1_la1(). > in1_la1() fills addr1 field, and not in1. > > Furthermore, when extract32() is used for the alignment

[Qemu-devel] [Bug 1788098] Re: Avoid migration issues with aligned 2MB THB

2018-08-21 Thread Andrew Cloke
** Also affects: qemu Importance: Undecided Status: New ** No longer affects: qemu ** Also affects: ubuntu-power-systems Importance: Undecided Status: New ** Changed in: ubuntu-power-systems Assignee: (unassigned) => Canonical Kernel Team (canonical-kernel-team) ** Chan

[Qemu-devel] What does VM SIZE means when entering qemu-img info xx.qcow2

2018-08-21 Thread lampahome
I have an qcow2 image and I mount it to /dev/nbd then write somethin. Then I take internal snapshot in the qcow2. I enter the command qemu-img info qcow2 It shows: image: qcow2 file format: qcow2 virtual size: 30G disk size:4M x Snapshot list: ID, TAG, VM SIZE, DATE, VM CLOCK 1, snap1, 0, xxx

[Qemu-devel] [PULL 07/12] spice-display: access ptr_x/ptr_y under Mutex

2018-08-21 Thread Gerd Hoffmann
From: Paolo Bonzini The OpenGL-enabled SPICE code was not accessing the cursor position under the SimpleSpiceDisplay lock. Fix this. Signed-off-by: Paolo Bonzini Reviewed-by: Marc-André Lureau Message-id: 20180720063109.4631-2-pbonz...@redhat.com Signed-off-by: Gerd Hoffmann --- ui/spice-di

[Qemu-devel] [PULL 06/12] vnc: remove support for deprecated tls, x509, x509verify options

2018-08-21 Thread Gerd Hoffmann
From: Daniel P. Berrangé The 'tls-creds' option accepts the name of a TLS credentials object. This replaced the usage of 'tls', 'x509' and 'x509verify' options in 2.5.0. These deprecated options were grandfathered in when the deprecation policy was introduded in 2.10.0, so can now finally be remo

[Qemu-devel] [PULL 10/12] ui/vnc: Remove useless parenthesis around DIV_ROUND_UP macro

2018-08-21 Thread Gerd Hoffmann
From: Philippe Mathieu-Daudé Patch created mechanically by rerunning: $ spatch --sp-file scripts/coccinelle/round.cocci \ --macro-file scripts/cocci-macro-file.h \ --dir . --in-place Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20180704153919.12432-7-f4...@amsa

[Qemu-devel] [PULL 08/12] spice-display: fix qemu_spice_cursor_refresh_bh locking

2018-08-21 Thread Gerd Hoffmann
From: Paolo Bonzini spice-display should not call the ui/console.c functions dpy_cursor_define and dpy_moues_set with the SimpleSpiceDisplay lock taken. That will cause a deadlock, because the DisplayChangeListener callbacks will take the lock again. It is also in general a bad idea to invoke g

[Qemu-devel] [PULL 09/12] ui/sdl2: Fix broken -full-screen CLI option

2018-08-21 Thread Gerd Hoffmann
From: Thomas Huth We've got to set the gui_fullscreen variable before creating the SDL2 window, otherwise the initial window will not be created in fullscreen mode. Buglink: https://bugs.launchpad.net/bugs/1780812 Signed-off-by: Thomas Huth Message-id: 1531161850-6860-1-git-send-email-th...@red

[Qemu-devel] [PULL 11/12] dmabuf: add y0_top, pass it to spice

2018-08-21 Thread Gerd Hoffmann
From: Marc-André Lureau Some scanouts during boot are top-down without it. y0_top is set from VHOST_USER_GPU_DMABUF_SCANOUT code path in the last patch of this series. In current QEMU code base, only vfio/display uses dmabuf API. But the VFIO query interface doesn't provide or need that detail

[Qemu-devel] [PULL 00/12] Ui 20180821 patches

2018-08-21 Thread Gerd Hoffmann
The following changes since commit d0092d90eb546a8bbe9e9120426c189474123797: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20180820' into staging (2018-08-20 17:41:18 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/ui-20180821-pull-reques

[Qemu-devel] [PULL 05/12] doc: switch to modern syntax for VNC TLS setup

2018-08-21 Thread Gerd Hoffmann
From: Daniel P. Berrangé The use of 'tls', 'x509' and 'x509verify' properties is the deprecated backcompat syntax, replaced by use of TLS creds objects. Signed-off-by: Daniel P. Berrangé Message-id: 20180725092751.21767-2-berra...@redhat.com Signed-off-by: Gerd Hoffmann --- qemu-doc.texi | 20

[Qemu-devel] [PULL 01/12] ui/sdl2: Remove the obsolete SDL_INIT_NOPARACHUTE flag

2018-08-21 Thread Gerd Hoffmann
From: Thomas Huth SDL_INIT_NOPARACHUTE is not used in SDL2 anymore, and the define is just a dummy (see https://wiki.libsdl.org/MigrationGuide#Some_general_truths for example). So we can remove it and get rid of the "flags" variable nowadays. Signed-off-by: Thomas Huth Message-id: 1533721602-15

[Qemu-devel] [PULL 04/12] sdl2: redraw correctly when scanout_mode enabled.

2018-08-21 Thread Gerd Hoffmann
From: Tao Wu via Qemu-devel When scanout_mode enabled, surface is out of sync with actual screen. In such case, we just call sdl2_gl_scanout_flush to do redraw. This fixes bug reported in https://lists.freedesktop.org/archives/virglrenderer-devel/2018-July/001330.html Signed-off-by: Tao Wu Mess

Re: [Qemu-devel] [PATCH 0/3] ui: remove deprecated UI frontends

2018-08-21 Thread Gerd Hoffmann
On Wed, Aug 08, 2018 at 11:49:27AM +0100, Daniel P. Berrangé wrote: > We deprecated GTK2 and SDL1.2 in the 2.12.0 release, so they are able to > be removed entirely in the 3.1.0 release. The min GTK3 version can also > be bumped up based the distros we aim to support. Doesn't apply any more. Can y

[Qemu-devel] [PULL 02/12] vnc: fix memleak of the "vnc-worker-output" name

2018-08-21 Thread Gerd Hoffmann
From: Peter Wu Fixes repeated memory leaks of 18 bytes when using VNC: Direct leak of 831024 byte(s) in 46168 object(s) allocated from: ... #4 0x7f6d2f919bdd in g_strdup_vprintf glib/gstrfuncs.c:514 #5 0x56085cdcf660 in buffer_init util/buffer.c:59 #6 0x56085c

Re: [Qemu-devel] [PATCH 7/7] target/s390x: implement CVB, CVBY and CVBG

2018-08-21 Thread David Hildenbrand
On 21.08.2018 04:51, Pavel Zbitskiy wrote: > Convert to Binary - counterparts of the already implemented Convert > to Decimal (CVD*) instructions. > Example from the Principles of Operation: 25594C becomes 63FA. > > Signed-off-by: Pavel Zbitskiy > --- > target/s390x/helper.h | 1 + >

Re: [Qemu-devel] [PATCH] hw/display/ramfb: Compile the ramfb code only when CONFIG_FW_CFG_DMA is set

2018-08-21 Thread Gerd Hoffmann
On Mon, Aug 20, 2018 at 07:28:03PM +0200, Thomas Huth wrote: > According to the ramfb_setup() function, the ramfb device needs fw_cfg > with DMA, so we should also only compile and link it into those targets > which support it, to avoid that the device shows up on systems where it > can not be used

[Qemu-devel] [PULL 12/12] util: promote qemu_egl_rendernode_open() to libqemuutil

2018-08-21 Thread Gerd Hoffmann
From: Marc-André Lureau vhost-user-gpu will share the same code to open a DRM node. Signed-off-by: Marc-André Lureau Message-Id: <20180713130916.4153-20-marcandre.lur...@redhat.com> Signed-off-by: Gerd Hoffmann --- include/qemu/drm.h | 6 + ui/egl-helpers.c | 51 ++-

Re: [Qemu-devel] [PATCH v4 00/29] vhost-user for input & GPU

2018-08-21 Thread Gerd Hoffmann
Hi, > > Feedback welcome, > > ping Cherry-picked two patches for the ui pull request. What is the plan for the command line handling, specifically the patch tagged with HACK? cheers, Gerd

Re: [Qemu-devel] [PATCH 0/2] mips: convert devices away from old_mmio

2018-08-21 Thread Gerd Hoffmann
On Thu, Aug 02, 2018 at 04:51:45PM +0100, Peter Maydell wrote: > These patches convert a couple of devices used only by MIPS > boards from using the old_mmio MemoryRegionOps accessor functions. > > * vga-isa-mm: used by the MIPS 'jazz' boards "magnum" and "pica61" > * bonito pci controller: used

[Qemu-devel] [PULL 03/12] ui: use enum to string helpers

2018-08-21 Thread Gerd Hoffmann
From: Marc-André Lureau Minor code simplification. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster Message-id: 20180801092508.4927-1-marcandre.lur...@redhat.com Signed-off-by: Gerd Hoffmann --- qemu-keymap.c | 2 +- ui/console.c | 6 +++--- 2 files changed, 4 insertions(+),

Re: [Qemu-devel] [PATCH 0/7] Some improvements in z/Arch instructions support

2018-08-21 Thread David Hildenbrand
On 21.08.2018 04:50, Pavel Zbitskiy wrote: > Found while attempting to run an old tool in qemu. > > * BAL and BALR:Added. > * CSST:Qemu crashed after an accidental jump to garbage. > * IPM: A tool produced an incorrect output. > * EX TRT/TRTR: A tool ran quite slow.

[Qemu-devel] [PATCH v4 00/10] migration: compression optimization

2018-08-21 Thread guangrong . xiao
From: Xiao Guangrong Changelog in v4: These changes are based on the suggestion from Peter Eric. 1) improve qapi's grammar 2) move calling flush_compressed_data to migration_bitmap_sync() 3) rename 'handle_pages' to 'target_page_count' Note: there is still no clear way to fix handling the error

[Qemu-devel] [PATCH v4 02/10] migration: fix counting normal page for compression

2018-08-21 Thread guangrong . xiao
From: Xiao Guangrong The compressed page is not normal page Reviewed-by: Peter Xu Signed-off-by: Xiao Guangrong --- migration/ram.c | 1 - 1 file changed, 1 deletion(-) diff --git a/migration/ram.c b/migration/ram.c index ae9e83c2b6..d631b9a6fe 100644 --- a/migration/ram.c +++ b/migration/ra

[Qemu-devel] [PATCH v4 04/10] migration: drop the return value of do_compress_ram_page

2018-08-21 Thread guangrong . xiao
From: Xiao Guangrong It is not used and cleans the code up a little Reviewed-by: Peter Xu Signed-off-by: Xiao Guangrong --- migration/ram.c | 26 +++--- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 49ace30614..e463

[Qemu-devel] [PATCH v4 01/10] migration: do not wait for free thread

2018-08-21 Thread guangrong . xiao
From: Xiao Guangrong Instead of putting the main thread to sleep state to wait for free compression thread, we can directly post it out as normal page that reduces the latency and uses CPUs more efficiently A parameter, compress-wait-thread, is introduced, it can be enabled if the user really wa

[Qemu-devel] [PATCH v4 07/10] migration: do not flush_compressed_data at the end of each iteration

2018-08-21 Thread guangrong . xiao
From: Xiao Guangrong flush_compressed_data() needs to wait all compression threads to finish their work, after that all threads are free until the migration feeds new request to them, reducing its call can improve the throughput and use CPU resource more effectively We do not need to flush all t

[Qemu-devel] [PATCH v4 03/10] migration: introduce save_zero_page_to_file

2018-08-21 Thread guangrong . xiao
From: Xiao Guangrong It will be used by the compression threads Reviewed-by: Peter Xu Signed-off-by: Xiao Guangrong --- migration/ram.c | 40 ++-- 1 file changed, 30 insertions(+), 10 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index d631b9

[Qemu-devel] [PATCH v4 06/10] migration: hold the lock only if it is really needed

2018-08-21 Thread guangrong . xiao
From: Xiao Guangrong Try to hold src_page_req_mutex only if the queue is not empty Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu Signed-off-by: Xiao Guangrong --- include/qemu/queue.h | 1 + migration/ram.c | 4 2 files changed, 5 insertions(+) diff --git a/include/qem

[Qemu-devel] [PATCH v4 08/10] migration: fix calculating xbzrle_counters.cache_miss_rate

2018-08-21 Thread guangrong . xiao
From: Xiao Guangrong As Peter pointed out: | - xbzrle_counters.cache_miss is done in save_xbzrle_page(), so it's | per-guest-page granularity | | - RAMState.iterations is done for each ram_find_and_save_block(), so | it's per-host-page granularity | | An example is that when we migrate a 2M h

[Qemu-devel] [PATCH v4 05/10] migration: move handle of zero page to the thread

2018-08-21 Thread guangrong . xiao
From: Xiao Guangrong Detecting zero page is not a light work, moving it to the thread to speed the main thread up, btw, handling ram_release_pages() for the zero page is moved to the thread as well Reviewed-by: Peter Xu Signed-off-by: Xiao Guangrong --- migration/ram.c | 96 ++

[Qemu-devel] [PULL 2/4] qxl: drop unused generation variable

2018-08-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Peter Maydell Message-id: 20180810132236.25908-1-kra...@redhat.com --- hw/display/qxl.h | 1 - hw/display/qxl.c | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/display/qxl.h b/hw/display/qxl.h index 089696ef62..6eacba080d 100644 --- a/hw/display/

[Qemu-devel] [PATCH v4 09/10] migration: show the statistics of compression

2018-08-21 Thread guangrong . xiao
From: Xiao Guangrong Currently, it includes: pages: amount of pages compressed and transferred to the target VM busy: amount of count that no free thread to compress data busy-rate: rate of thread busy compressed-size: amount of bytes after compression compression-rate: rate of compressed size R

[Qemu-devel] [PULL 0/4] Vga 20180821 patches

2018-08-21 Thread Gerd Hoffmann
The following changes since commit d0092d90eb546a8bbe9e9120426c189474123797: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20180820' into staging (2018-08-20 17:41:18 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/vga-20180821-pull-reques

[Qemu-devel] [PATCH v4 10/10] migration: handle the error condition properly

2018-08-21 Thread guangrong . xiao
From: Xiao Guangrong ram_find_and_save_block() can return negative if any error hanppens, however, it is completely ignored in current code Signed-off-by: Xiao Guangrong --- migration/ram.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/migration/ram.c

[Qemu-devel] [PULL 4/4] hw/pci-host/bonito: Move away from old_mmio accessors

2018-08-21 Thread Gerd Hoffmann
From: Peter Maydell Move away from the old_mmio MemoryRegion accessors in the bonito pci controller. This device is used only in the MIPS "fulong2e" machine. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Message-id: 20180802155147.1863-3-peter.mayd...@linaro.org Signed-off-by: G

[Qemu-devel] [PULL 3/4] hw/display/vga-isa-mm: Convert away from old_mmio

2018-08-21 Thread Gerd Hoffmann
From: Peter Maydell Convert the vga-isa-mm device away from the old_mmio MemoryRegion accessors. This device is only used by the MIPS 'jazz' boards "magnum" and "pica61". Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Hervé Poussineau Tested-by: Hervé Poussinea

[Qemu-devel] [PULL 1/4] hw/display/ramfb: Compile the ramfb code only when CONFIG_FW_CFG_DMA is set

2018-08-21 Thread Gerd Hoffmann
From: Thomas Huth According to the ramfb_setup() function, the ramfb device needs fw_cfg with DMA, so we should also only compile and link it into those targets which support it, to avoid that the device shows up on systems where it can not be used at all (e.g. s390x). Signed-off-by: Thomas Huth

Re: [Qemu-devel] [PATCH] docs/usb2.txt: ehci has six ports

2018-08-21 Thread Gerd Hoffmann
On Wed, Aug 01, 2018 at 08:24:10PM +0800, npes87184 wrote: > In commit 5cc194caeb019cf1dae7f74ccbdf0401a56c2ac6, > the number of ehci ports is corrected to six. Fix docs > related to it. Added to usb queue. > Signed-off-by: npes87184 Please use your real name here next time. Try 'git config --

Re: [Qemu-devel] [PATCH] ohci: Clear the interrupt counter for erroneous transfers

2018-08-21 Thread Gerd Hoffmann
On Sun, Jul 29, 2018 at 09:19:28PM +0200, Sebastian Bauer wrote: > This is mandated by the ohci specification. It tells at 6.4.4 on page 104 > that for transfer descriptors that are retired with an error the done > queue interrupt counter is cleared as if the interrupt delay field of the > descript

Re: [Qemu-devel] [PATCH 0/7] Some improvements in z/Arch instructions support

2018-08-21 Thread Cornelia Huck
On Tue, 21 Aug 2018 09:56:33 +0200 David Hildenbrand wrote: > On 21.08.2018 04:50, Pavel Zbitskiy wrote: > > Found while attempting to run an old tool in qemu. > > > > * BAL and BALR:Added. > > * CSST:Qemu crashed after an accidental jump to garbage. > > * IPM: A tool

Re: [Qemu-devel] Simulating a composite machine

2018-08-21 Thread Peter Maydell
On 20 August 2018 at 19:29, Martin Schroeder wrote: > Ok so FPU support is not there. What would it take for me to add it? I > would very much like to add it if I get some guidance as to what needs > to be done and where I can find information on how to do it. I see > there is some code in fpu/sof

[Qemu-devel] [PULL 0/7] Usb 20180821 patches

2018-08-21 Thread Gerd Hoffmann
The following changes since commit d0092d90eb546a8bbe9e9120426c189474123797: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20180820' into staging (2018-08-20 17:41:18 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/usb-20180821-pull-reques

[Qemu-devel] [PULL 7/7] dev-mtp: rename x-root to rootdir

2018-08-21 Thread Gerd Hoffmann
From: Bandan Das x-root was renamed as such owing to the experimental nature of the property; the underlying filesystem semantics were undecided Signed-off-by: Bandan Das Message-id: 20180720214020.22897-6-...@redhat.com Signed-off-by: Gerd Hoffmann --- hw/usb/dev-mtp.c | 4 ++-- 1 file chang

[Qemu-devel] [PULL 2/7] ohci: Clear the interrupt counter for erroneous transfers

2018-08-21 Thread Gerd Hoffmann
From: Sebastian Bauer This is mandated by the ohci specification. It tells at 6.4.4 on page 104 that for transfer descriptors that are retired with an error the done queue interrupt counter is cleared as if the interrupt delay field of the descriptions were zero. Before this change, error condit

[Qemu-devel] [PULL 3/7] dev-mtp: add support for canceling transaction

2018-08-21 Thread Gerd Hoffmann
From: Bandan Das The initiator can choose to cancel an ongoing request which is specified by bRequest=0x64. If such a request arrives, free up any pending state Signed-off-by: Bandan Das Message-id: 20180720214020.22897-2-...@redhat.com Signed-off-by: Gerd Hoffmann --- hw/usb/dev-mtp.c | 30 +

[Qemu-devel] [PULL 5/7] dev-mtp: retry write for incomplete transfers

2018-08-21 Thread Gerd Hoffmann
From: Bandan Das For large buffers, write may not copy the full buffer. For example, on Linux, write imposes a limit of 0x7000. Note that this does not fix >4G transfers but ~>2G files will transfer successfully. Signed-off-by: Bandan Das Message-id: 20180720214020.22897-4-...@redhat.com Si

[Qemu-devel] [PULL 1/7] docs/usb2.txt: ehci has six ports

2018-08-21 Thread Gerd Hoffmann
From: npes87184 In commit 5cc194caeb019cf1dae7f74ccbdf0401a56c2ac6, the number of ehci ports is corrected to six. Fix docs related to it. Signed-off-by: npes87184 Message-id: 20180801122410.10343-1-npes87...@gmail.com Signed-off-by: Gerd Hoffmann --- docs/usb2.txt | 4 ++-- 1 file changed, 2

[Qemu-devel] [PULL 6/7] dev-mtp: Add support for > 4GB file transfers

2018-08-21 Thread Gerd Hoffmann
From: Bandan Das To support larger file transfers, rely on a short packet to detect end of the data phase and rewrite d->length to the size received Signed-off-by: Bandan Das Message-id: 20180720214020.22897-5-...@redhat.com Signed-off-by: Gerd Hoffmann --- hw/usb/dev-mtp.c | 31 +

[Qemu-devel] [PULL 4/7] dev-mtp: fix buffer allocation for writing file contents

2018-08-21 Thread Gerd Hoffmann
From: Bandan Das usb_mtp_realloc() was being incorrectly used when allocating buffer for incoming data. Set d->length only after resizing the buffer. Signed-off-by: Bandan Das Message-id: 20180720214020.22897-3-...@redhat.com Signed-off-by: Gerd Hoffmann --- hw/usb/dev-mtp.c | 6 -- 1 fil

Re: [Qemu-devel] [RFC v2] new, node-graph-based fleecing and backup

2018-08-21 Thread Vladimir Sementsov-Ogievskiy
20.08.2018 21:30, Vladimir Sementsov-Ogievskiy wrote: 20.08.2018 20:25, Max Reitz wrote: On 2018-08-20 16:49, Vladimir Sementsov-Ogievskiy wrote: 20.08.2018 16:32, Max Reitz wrote: On 2018-08-20 11:42, Vladimir Sementsov-Ogievskiy wrote: 18.08.2018 00:50, Max Reitz wrote: On 2018-08-14 19:01

Re: [Qemu-devel] [PATCH V11 16/20] filter: Add handle_event method for NetFilterClass

2018-08-21 Thread Zhang Chen
On Tue, Aug 21, 2018 at 11:30 AM Jason Wang wrote: > > > On 2018年08月12日 04:59, Zhang Chen wrote: > > Filter needs to process the event of checkpoint/failover or > > other event passed by COLO frame. > > > > Signed-off-by: zhanghailiang > > --- > > include/net/filter.h | 5 + > > net/filt

Re: [Qemu-devel] [PATCH V11 15/20] net/net.c: Add net client type check function for COLO

2018-08-21 Thread Zhang Chen
On Tue, Aug 21, 2018 at 11:27 AM Jason Wang wrote: > > > On 2018年08月12日 04:59, Zhang Chen wrote: > > From: Zhang Chen > > > > We add is_colo_support_client_type() to check the net client type for > > COLO-compare. Currently we just support TAP. > > Suggested by Jason. > > > > Signed-off-by: Zhan

Re: [Qemu-devel] [PULL 0/2] qemu-sparc.for-upstream queue 20180820

2018-08-21 Thread Peter Maydell
On 20 August 2018 at 20:47, Mark Cave-Ayland wrote: > The following changes since commit d0092d90eb546a8bbe9e9120426c189474123797: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20180820' into > staging (2018-08-20 17:41:18 +0100) > > are available in the git repository at: > > g

Re: [Qemu-devel] Qemu and Spectre_V4 + l1tf + IBRS_FW

2018-08-21 Thread Stefan Priebe - Profihost AG
Am 17.08.2018 um 11:41 schrieb Daniel P. Berrangé: > On Fri, Aug 17, 2018 at 08:44:38AM +0200, Stefan Priebe - Profihost AG wrote: >> Hello, >> >> i haven't found anything on the web regarding qemu and mentioned variants. >> >> While my host says: >> l1tf:Mitigation: PTE Inversion; VMX: SMT vulne

Re: [Qemu-devel] vTPM 2.0 is recognized as vTPM 1.2 on the Win 10 virtual machine

2018-08-21 Thread Marc-André Lureau
Hi On Sun, Aug 19, 2018 at 9:47 AM 汤福 wrote: > > I tried it according to your method, but I have some problems. My host is > centos 7.2 with the TPM 2.0 hardware and qemu v2.10.2. The driver for the TPM > 2.0 hardware is crb device,Execute lsmod to view the tpm 2.0 driver > information as follo

Re: [Qemu-devel] [PATCH] migration: Replace strncpy() by g_strlcpy()

2018-08-21 Thread Paolo Bonzini
On 21/08/2018 08:03, Thomas Huth wrote: >>> gcc is not necessarily wrong, as it CAN catch real erroneous uses of >>> strncpy(). It's just that 99% of the time, strncpy() is the WRONG >>> function to use, and so the remaining few cases where it actually does >>> what you want are so rare that yo

Re: [Qemu-devel] [PULL 08/12] spice-display: fix qemu_spice_cursor_refresh_bh locking

2018-08-21 Thread Paolo Bonzini
On 21/08/2018 09:45, Gerd Hoffmann wrote: > +qemu_mutex_lock(&ssd->lock); > if (ssd->cursor) { > +QEMUCursor *c = ssd->cursor; > assert(ssd->dcl.con); > +cursor_get(c); > +qemu_mutex_unlock(&ssd->lock); > dpy_cursor_define(ssd->dcl.con, ssd->cursor

[Qemu-devel] [PATCH v4 6/8] scsi: account unmap operations

2018-08-21 Thread Anton Nefedov
Signed-off-by: Anton Nefedov Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia --- hw/scsi/scsi-disk.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 9d10daf..0aac137 100644 --- a/hw/scsi/scsi-disk.

[Qemu-devel] [PATCH v4 3/8] ide: account UNMAP (TRIM) operations

2018-08-21 Thread Anton Nefedov
Signed-off-by: Anton Nefedov Reviewed-by: Alberto Garcia --- hw/ide/core.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/ide/core.c b/hw/ide/core.c index 2c62efc..352429b 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -440,6 +440,14 @@ static void ide_issue_trim_cb(void

[Qemu-devel] [PATCH v4 0/8] discard blockstats

2018-08-21 Thread Anton Nefedov
new in v4: - patch 7: discard and write-zeroes code paths had been separated in 34fa110e: file-posix: Fix write_zeroes with unmap on block devices. This patch now only accounts discards that come explicitly through .bdrv_co_pdiscard handler. - qapi 'Since' clauses changed

[Qemu-devel] [PATCH v4 2/8] qapi: add unmap to BlockDeviceStats

2018-08-21 Thread Anton Nefedov
Signed-off-by: Anton Nefedov Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia Reviewed-by: Eric Blake --- qapi/block-core.json | 29 +++-- include/block/accounting.h | 1 + block/qapi.c | 6 ++ 3 files changed, 30 insertion

[Qemu-devel] [PATCH v4 1/8] qapi: group BlockDeviceStats fields

2018-08-21 Thread Anton Nefedov
Make the stat fields definition slightly more readable. Also reorder total_time_ns stats read-write-flush as done elsewhere. Cosmetic change only. Signed-off-by: Anton Nefedov --- qapi/block-core.json | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git

Re: [Qemu-devel] [PATCH V11 17/20] filter-rewriter: handle checkpoint and failover event

2018-08-21 Thread Zhang Chen
On Tue, Aug 21, 2018 at 11:40 AM Jason Wang wrote: > > > On 2018年08月12日 04:59, Zhang Chen wrote: > > After one round of checkpoint, the states between PVM and SVM > > become consistent, so it is unnecessary to adjust the sequence > > of net packets for old connections, besides, while failover > >

[Qemu-devel] [Bug 1755912] Re: qemu-system-x86_64 crashed with SIGABRT when using option -vga qxl

2018-08-21 Thread  Christian Ehrhardt 
Working on Bionic SRu prep in https://launchpad.net/~ci-train-ppa- service/+archive/ubuntu/3367/+packages -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1755912 Title: qemu-system-x86_64 crashed wit

[Qemu-devel] [PATCH v4 4/8] scsi: store unmap offset and nb_sectors in request struct

2018-08-21 Thread Anton Nefedov
it allows to report it in the error handler Signed-off-by: Anton Nefedov Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia --- hw/scsi/scsi-disk.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c inde

[Qemu-devel] [PATCH v4 5/8] scsi: move unmap error checking to the complete callback

2018-08-21 Thread Anton Nefedov
This will help to account the operation in the following commit. The difference is that we don't call scsi_disk_req_check_error() before the 1st discard iteration anymore. That function also checks if the request is cancelled, however it shouldn't get canceled until it yields in blk_aio() function

[Qemu-devel] [PATCH v4 7/8] file-posix: account discard operations

2018-08-21 Thread Anton Nefedov
This will help to identify how many of the user-issued discard operations (accounted on a device level) have actually suceeded down on the host file (even though the numbers will not be exactly the same if non-raw format driver is used (e.g. qcow2 sending metadata discards)). Note that these numbe

Re: [Qemu-devel] [PATCH v3 1/2] hw/pci: factor PCI reserve resources to a separate structure

2018-08-21 Thread Marcel Apfelbaum
On 08/21/2018 06:18 AM, Jing Liu wrote: Factor "bus_reserve", "io_reserve", "mem_reserve", "pref32_reserve" and "pref64_reserve" fields of the "GenPCIERootPort" structure out to "PCIResReserve" structure, so that other PCI bridges can reuse it to add resource reserve capability. Signed-off-by

[Qemu-devel] [PATCH v4 8/8] qapi: query-blockstat: add driver specific file-posix stats

2018-08-21 Thread Anton Nefedov
A block driver can provide a callback to report driver-specific statistics. file-posix driver now reports discard statistics Signed-off-by: Anton Nefedov --- qapi/block-core.json | 39 +++ include/block/block.h | 1 + include/block/block_int.h |

Re: [Qemu-devel] [PATCH v3 2/2] hw/pci: add PCI resource reserve capability to legacy PCI bridge

2018-08-21 Thread Marcel Apfelbaum
On 08/21/2018 06:18 AM, Jing Liu wrote: Add hint to firmware (e.g. SeaBIOS) to reserve addtional BUS/IO/MEM/PREF resource for legacy pci-pci bridge. Add the resource reserve capability deleting in pci_bridge_dev_exitfn. Signed-off-by: Jing Liu --- hw/pci-bridge/pci_bridge_dev.c | 24 ++

[Qemu-devel] [PATCH] Remove deprecated -balloon option

2018-08-21 Thread Thomas Huth
The "-balloon" option has been replaced by "-device virtio-balloon". It's been marked as deprecated since two releases, and nobody complained, so let's remove it now. Signed-off-by: Thomas Huth --- docs/virtio-balloon-stats.txt | 6 +++--- qemu-deprecated.texi | 5 - qemu-options.

[Qemu-devel] [PATCH] iothread: fix crash with invalid properties

2018-08-21 Thread Marc-André Lureau
-object iothread,id=foo,? will crash qemu: qemu-system-x86_64:qemu-thread-posix.c:128: qemu_cond_destroy: Assertion `cond->initialized' failed. Use thread_id != -1 to check if iothread_complete() finished successfully and the mutex/cond have been initialized. Signed-off-by: Marc-André Lureau -

Re: [Qemu-devel] [libvirt] [PATCH] Remove deprecated -balloon option

2018-08-21 Thread Daniel P . Berrangé
On Tue, Aug 21, 2018 at 12:05:30PM +0200, Thomas Huth wrote: > The "-balloon" option has been replaced by "-device virtio-balloon". > It's been marked as deprecated since two releases, and nobody > complained, so let's remove it now. > > Signed-off-by: Thomas Huth > --- > docs/virtio-balloon-sta

Re: [Qemu-devel] [PATCH v4 00/29] vhost-user for input & GPU

2018-08-21 Thread Marc-André Lureau
Hi On Tue, Aug 21, 2018 at 9:51 AM Gerd Hoffmann wrote: > > Hi, > > > > Feedback welcome, > > > > ping > > Cherry-picked two patches for the ui pull request. thanks > > What is the plan for the command line handling, specifically the patch > tagged with HACK? The RFC libvirt series doesn't u

Re: [Qemu-devel] [PATCH] Remove deprecated -balloon option

2018-08-21 Thread Paolo Bonzini
On 21/08/2018 12:05, Thomas Huth wrote: > The "-balloon" option has been replaced by "-device virtio-balloon". > It's been marked as deprecated since two releases, and nobody > complained, so let's remove it now. > > Signed-off-by: Thomas Huth > --- > docs/virtio-balloon-stats.txt | 6 +++--- >

Re: [Qemu-devel] [PATCH v4 00/29] vhost-user for input & GPU

2018-08-21 Thread Daniel P . Berrangé
On Tue, Aug 21, 2018 at 12:10:46PM +0200, Marc-André Lureau wrote: > Hi > > On Tue, Aug 21, 2018 at 9:51 AM Gerd Hoffmann wrote: > > > > Hi, > > > > > > Feedback welcome, > > > > > > ping > > > > Cherry-picked two patches for the ui pull request. > > thanks > > > > > What is the plan for the

Re: [Qemu-devel] [PATCH] Remove deprecated -balloon option

2018-08-21 Thread Cornelia Huck
On Tue, 21 Aug 2018 12:05:30 +0200 Thomas Huth wrote: > The "-balloon" option has been replaced by "-device virtio-balloon". > It's been marked as deprecated since two releases, and nobody > complained, so let's remove it now. > > Signed-off-by: Thomas Huth > --- > docs/virtio-balloon-stats.tx

Re: [Qemu-devel] [PATCH] Remove deprecated -balloon option

2018-08-21 Thread Michael S. Tsirkin
On Tue, Aug 21, 2018 at 12:05:30PM +0200, Thomas Huth wrote: > The "-balloon" option has been replaced by "-device virtio-balloon". > It's been marked as deprecated since two releases, and nobody > complained, so let's remove it now. > > Signed-off-by: Thomas Huth Reviewed-by: Michael S. Tsirkin

Re: [Qemu-devel] [PULL 0/7] pc: fixes

2018-08-21 Thread Peter Maydell
On 20 August 2018 at 21:24, Michael S. Tsirkin wrote: > The following changes since commit f7502360397d291be04bc040e9f96c92ff2d8030: > > Update version for v3.0.0-rc3 release (2018-07-31 19:30:17 +0100) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/virt/kvm/mst/q

[Qemu-devel] [PATCH v2] editorconfig: set emacs mode

2018-08-21 Thread Marc-André Lureau
Some time ago, I proposed to use an (eval) in .dir-locals.el to set the mode for all json files and Makefile. Unfortunately, this isn't safe, and emacs will prompt the user, which isn't very friendly. Fortunately, editorconfig provides a special config key which does allow to set the emacs mode. A

Re: [Qemu-devel] [PATCH v11 24/46] target/mips: Add CP0 Config3 and Config5 fields to DisasContext structure

2018-08-21 Thread Aleksandar Markovic
> From: Aleksandar Markovic > Sent: Monday, August 20, 2018 8:16 PM > > Subject: [PATCH v11 24/46] target/mips: Add CP0 Config3 and Config5 fields to > DisasContext structure > > From: Dimitrije Nikolic > > Add CP0_Config3 and CP0_Config5 to DisasContext structure. This is > needed for implem

Re: [Qemu-devel] [PATCH v2] ipmi: Use proper struct reference for BT vmstate

2018-08-21 Thread Paolo Bonzini
On 20/08/2018 22:57, miny...@acm.org wrote: > From: Corey Minyard > > The vmstate for isa_ipmi_bt was referencing into the bt structure, > instead create a bt structure separate and use that. > > The version 1 of the BT transfer was fairly broken, if a migration > occured during an IPMI operatio

Re: [Qemu-devel] [PATCH v11 35/46] target/mips: Add availability control via bit NMS

2018-08-21 Thread Aleksandar Markovic
> From: Aleksandar Markovic > Sent: Monday, August 20, 2018 8:16 PM > > Subject: [PATCH v11 35/46] target/mips: Add availability control via bit NMS > > From: Dimitrije Nikolic > > A set of nanoMIPS instructions is not available if Config5 bit NMS > is set. > > Signed-off-by: Aleksandar Marko

Re: [Qemu-devel] [PATCH v11 04/46] target/mips: Prevent switching mode related to Config3 ISA bit for nanoMIPS

2018-08-21 Thread Aleksandar Markovic
> From: Aleksandar Markovic > Sent: Monday, August 20, 2018 8:16 PM > > Subject: [PATCH v11 04/46] target/mips: Prevent switching mode related to > Config3 ISA bit for nanoMIPS > > From: Stefan Markovic > > Only if Config3.ISA is 3 (microMIPS), the mode should be switched in > cpu_state_reset

Re: [Qemu-devel] [PATCH v4 0/4] pc-dimm: pre_plug "slot" and "addr" assignment

2018-08-21 Thread Paolo Bonzini
On 20/08/2018 18:15, David Hildenbrand wrote: > On 01.08.2018 15:34, David Hildenbrand wrote: >> This is basically a resend of v3 with commit message changes. >> >> Paolo, if there are no further comments, can you please pick this up for >> 3.1? Thanks! > > Paolo, > > can you please pick this up?

[Qemu-devel] [PATCH 0/2] virtio-vga: fix reset

2018-08-21 Thread Gerd Hoffmann
Gerd Hoffmann (2): virtio-vga: fix reset Revert "virtio-gpu: fix crashes upon warm reboot with vga mode" include/hw/virtio/virtio-gpu.h | 2 +- hw/display/virtio-gpu.c| 7 +-- hw/display/virtio-vga.c| 17 + 3 files changed, 7 insertions(+), 19 deletion

[Qemu-devel] [PATCH 2/2] Revert "virtio-gpu: fix crashes upon warm reboot with vga mode"

2018-08-21 Thread Gerd Hoffmann
This reverts commit 93f874fe9dbe0b997b5a9459840957efd13d7191. Now with virtio-vga being resetted properly the crash workaround is not needed any more. Signed-off-by: Gerd Hoffmann --- include/hw/virtio/virtio-gpu.h | 1 - hw/display/virtio-gpu.c| 5 - hw/display/virtio-vga.c

[Qemu-devel] [PATCH 1/2] virtio-vga: fix reset

2018-08-21 Thread Gerd Hoffmann
We must call the reset functions for both virtio-gpu and vga to properly reset the combo device. Signed-off-by: Gerd Hoffmann --- include/hw/virtio/virtio-gpu.h | 1 + hw/display/virtio-gpu.c| 2 +- hw/display/virtio-vga.c| 6 +- 3 files changed, 7 insertions(+), 2 deletions(

Re: [Qemu-devel] [PATCH v11 00/46] Add nanoMIPS support - core functionality and system mode

2018-08-21 Thread Aleksandar Markovic
> From: Aleksandar Markovic > Sent: Monday, August 20, 2018 8:16 PM > > Subject: [PATCH v11 00/46] Add nanoMIPS support - core functionality and > system mode > > From: Aleksandar Markovic > Hello, I feel the patches in this series should be submitted in a pull request. Please let me know

Re: [Qemu-devel] [PATCH 1/2] virtio-vga: fix reset

2018-08-21 Thread Marc-André Lureau
Hi On Tue, Aug 21, 2018 at 1:13 PM Gerd Hoffmann wrote: > > We must call the reset functions for both virtio-gpu > and vga to properly reset the combo device. > > Signed-off-by: Gerd Hoffmann > --- > include/hw/virtio/virtio-gpu.h | 1 + > hw/display/virtio-gpu.c| 2 +- > hw/display/vir

Re: [Qemu-devel] [PATCH 1/2] virtio-vga: fix reset

2018-08-21 Thread Gerd Hoffmann
> > @@ -179,8 +179,12 @@ static void virtio_vga_realize(VirtIOPCIProxy > > *vpci_dev, Error **errp) > > static void virtio_vga_reset(DeviceState *dev) > > { > > VirtIOVGA *vvga = VIRTIO_VGA(dev); > > -vvga->vdev.enable = 0; > > > > +/* reset virtio-gpu */ > > +virtio_gpu_reset(V

  1   2   3   4   5   >