Re: [Qemu-devel] [PATCH v2 20/22] virtio: split virtio-blk bits rom virtio-pci

2018-08-16 Thread Thomas Huth
On 08/08/2018 01:48 PM, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > hw/virtio/Makefile.objs| 1 + > hw/virtio/virtio-blk-pci.c | 82 ++ > hw/virtio/virtio-pci.c | 58 --- > tests/Makefile.include | 4 +- > 4

Re: [Qemu-devel] [PATCH v2 21/22] virtio: split virtio-net bits rom virtio-pci

2018-08-16 Thread Thomas Huth
On 08/08/2018 01:48 PM, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > hw/virtio/Makefile.objs| 1 + > hw/virtio/virtio-net-pci.c | 81 ++ > hw/virtio/virtio-pci.c | 56 -- > tests/Makefile.include | 4 +- > 4

Re: [Qemu-devel] [PATCH 2/2] qemu-img: Add dd seek= option

2018-08-16 Thread Kevin Wolf
Am 16.08.2018 um 04:49 hat Max Reitz geschrieben: > On 2018-08-16 04:39, Eric Blake wrote: > > If convert were more powerful, I'd be fine dropping 'qemu-img dd' after > > a proper deprecation period. > > Technically it has those features already, with the raw block driver's > offset and size param

Re: [Qemu-devel] [PATCH 1/2] qemu-option: add help fallback to print the list of options

2018-08-16 Thread Markus Armbruster
Marc-André Lureau writes: > QDev options accept '?' or 'help' in the list of parameters, which is > really handy to list the available options. > > Unfortunately, this isn't built in QemuOpts. qemu_opts_parse_noisily() > seems to be the common path for command line options, so place a > fallback

Re: [Qemu-devel] [PATCH v6 11/13] tests: remove "0.15" prefix for test-qmp-cmds

2018-08-16 Thread Markus Armbruster
Peter Xu writes: > On Wed, Aug 15, 2018 at 08:11:22PM +0200, Marc-André Lureau wrote: >> On Wed, Aug 15, 2018 at 3:37 PM, Peter Xu wrote: >> > The "0.15" prefix seems useless. Remove them. >> > >> > Signed-off-by: Peter Xu >> >> I sent a similar patch long ago, and it is finally queued by Mar

Re: [Qemu-devel] [RFC PATCH] vl: fix migration when watchdog expires

2018-08-16 Thread Zhoujian (jay)
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Tuesday, August 14, 2018 9:07 PM > To: Zhoujian (jay) ; Dr. David Alan Gilbert > > Cc: qemu-devel@nongnu.org; quint...@redhat.com; wangxin (U) > > Subject: Re: [RFC PATCH] vl: fix migration when watchdog expir

Re: [Qemu-devel] [PATCH v2 22/22] virtio: split virtio-serial bits rom virtio-pci

2018-08-16 Thread Thomas Huth
On 08/08/2018 01:48 PM, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > hw/virtio/Makefile.objs | 1 + > hw/virtio/virtio-pci.c| 74 -- > hw/virtio/virtio-serial-pci.c | 97 +++ > tests/Makefile.include| 12

Re: [Qemu-devel] [PATCH v3 0/8] dirty-bitmap: rewrite bdrv_dirty_iter_next_area

2018-08-16 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180814121443.33114-1-vsement...@virtuozzo.com Subject: [Qemu-devel] [PATCH v3 0/8] dirty-bitmap: rewrite bdrv_dirty_iter_next_area === TEST SCRIPT BEGIN === #!/bin/bash B

Re: [Qemu-devel] [PATCH 08/10] target/arm: Permit accesses to ELR_Hyp from Hyp mode via MSR/MRS (banked)

2018-08-16 Thread Luc Michel
On 8/14/18 2:42 PM, Peter Maydell wrote: > The MSR (banked) and MRS (banked) instructions allow accesses to ELR_Hyp > from either Monitor or Hyp mode. Our translate time check > was overly strict and only permitted access from Monitor mode. > > The runtime check wo do in msr_mrs_banked_exc_checks(

Re: [Qemu-devel] [PATCH 0/7] Some improvements in z/Arch instructions support

2018-08-16 Thread Cornelia Huck
On Wed, 15 Aug 2018 11:25:26 -0700 (PDT) no-re...@patchew.org wrote: > === OUTPUT BEGIN === > Checking PATCH 1/7: tests/tcg: add a simple s390x test... > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #13: > new file mode 100644 tests/tcg/s390x/ does not seem to have

Re: [Qemu-devel] [PATCH 09/10] target/arm: Implement AArch32 ERET instruction

2018-08-16 Thread Luc Michel
On 8/14/18 2:42 PM, Peter Maydell wrote: > ARMv7VE introduced the ERET instruction, which is necessary to > return from an exception taken to Hyp mode. Implement this. > In A32 encoding it is a completely new encoding; in T32 it > is an adjustment of the behaviour of the existing > "SUBS PC, LR, #"

Re: [Qemu-devel] [PATCH v3 5/5] qmp: add pmemload command

2018-08-16 Thread Simon Ruderich
On Thu, Aug 16, 2018 at 07:43:41AM +0200, Markus Armbruster wrote: >> On Fri, Aug 10, 2018 at 11:36:51AM +0100, Dr. David Alan Gilbert wrote: >>> Also, had you considered rearranging and making them optional, >>> for example if you do: >>> >>> val:l,filename:F,offset:i?,size:i? >>> >>> I think that

[Qemu-devel] [Bug 1787012] Re: Solaris build error: Bad string

2018-08-16 Thread Daniel Berrange
** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1787012 Title: Solaris build error: Bad string Status in QEMU: Invalid Bug description: While b

Re: [Qemu-devel] How do you do when write more than 16TB data to qcow2 on ext4?

2018-08-16 Thread Daniel P . Berrangé
On Thu, Aug 16, 2018 at 09:35:52AM +0800, lampahome wrote: > We all know there's a file size limit 16TB in ext4 and other fs has their > limit,too. > > If I create an qcow2 20TB on ext4 and write to it more than 16TB. Data more > than 16TB can't be written to qcow2. > > So, is there any better wa

Re: [Qemu-devel] [PATCH v3 5/5] qmp: add pmemload command

2018-08-16 Thread Markus Armbruster
Simon Ruderich writes: > On Thu, Aug 16, 2018 at 07:43:41AM +0200, Markus Armbruster wrote: >>> On Fri, Aug 10, 2018 at 11:36:51AM +0100, Dr. David Alan Gilbert wrote: Also, had you considered rearranging and making them optional, for example if you do: val:l,filename:F,offset

[Qemu-devel] [PULL 07/25] qobject: New qobject_from_vjsonf_nofail(), qdict_from_vjsonf_nofail()

2018-08-16 Thread Markus Armbruster
Every printf()-like function sooner or later needs its vprintf()-like buddy. The next commit will need qobject_from_jsonf_nofail()'s buddy, and qdict_from_jsonf_nofail()'s buddy will be used later in this series. Add both. Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé Re

[Qemu-devel] [PULL 08/25] libqtest: Simplify qmp_fd_vsend() a bit

2018-08-16 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Eric Blake Message-Id: <20180806065344.7103-9-arm...@redhat.com> --- tests/libqtest.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/tests/libqtest.c b/tests/libqtest.c ind

[Qemu-devel] [PULL 02/25] libqtest: Clean up how we read device_del messages

2018-08-16 Thread Markus Armbruster
qtest_qmp_device_del() still uses the qmp("") hack to receive a message, even though we have qmp_receive() since commit 66e0c7b187e. Put it to use. Bonus: gets rid of empty format strings. A step towards compile-time format string checking without triggering -Wformat-zero-length. Signed-off-by:

[Qemu-devel] [PULL 01/25] libqtest: Rename functions to send QMP messages

2018-08-16 Thread Markus Armbruster
The functions to receive messages are called qtest_qmp_receive() and qmp_receive(), qmp_fd_receive(). The ones to send messages are called qtest_async_qmp(), qtest_async_qmpv(), qmp_async(), qmp_fd_send(), qmp_fd_sendv(). Inconsistent. Rename the *_async* ones to qmp_send(), qtest_qmp_send(), qt

[Qemu-devel] [PULL 03/25] libqtest: Clean up how we read the QMP greeting

2018-08-16 Thread Markus Armbruster
qtest_init() still uses the qtest_qmp_discard_response(s, "") hack to receive the greeting, even though we have qtest_qmp_receive() since commit 66e0c7b187e. Put it to use. Bonus: gets rid of an empty format string. A step towards compile-time format string checking without triggering -Wformat-z

[Qemu-devel] [PULL 00/25] Testing patches for 2018-08-16

2018-08-16 Thread Markus Armbruster
The following changes since commit c146b54c7fdbd926ee8fc4369699e3480d54f6fa: Merge remote-tracking branch 'remotes/armbru/tags/pull-misc-2018-08-15' into staging (2018-08-15 20:20:34 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-tests-2018-08-16

[Qemu-devel] [PULL 25/25] libqtest: Improve error reporting for bad read from QEMU

2018-08-16 Thread Markus Armbruster
When read() from the qtest socket or the QMP socket fails or EOFs, we report "Broken pipe" and exit(1). This commonly happens when QEMU crashes. It also happens when QEMU refuses to run because the test passed it bad arguments. Sadly, we neglect to report either. Improve this by calling abort()

[Qemu-devel] [PULL 10/25] qobject: qobject_from_jsonv() is dangerous, hide it away

2018-08-16 Thread Markus Armbruster
qobject_from_jsonv() takes ownership of %p arguments. On failure, we can't generally know whether we failed before or after %p, so ownership becomes indeterminate. To avoid leaks, callers passing %p must terminate on error, e.g. by passing &error_abort. Trap for the unwary; document and give the

[Qemu-devel] [PULL 22/25] libqtest: Replace qtest_startf() by qtest_initf()

2018-08-16 Thread Markus Armbruster
qtest_init() creates a new QTestState, and leaves @global_qtest alone. qtest_start() additionally assigns it to @global_qtest, but qtest_startf() additionally assigns NULL to @global_qtest. This makes no sense. Replace it by qtest_initf() that works like qtest_init(), i.e. leaves @global_qtest al

[Qemu-devel] [PULL 04/25] libqtest: Remove qtest_qmp_discard_response() & friends

2018-08-16 Thread Markus Armbruster
qtest_qmp_discard_response(...) is shorthand for qobject_unref(qtest_qmp(...), except it's not actually shorter. Moreover, the presence of these functions encourage sloppy testing. Remove them from libqtest. Add them as macros to the tests that use them, with a TODO comment asking for cleanup. Si

[Qemu-devel] [PULL 06/25] qobject: Replace qobject_from_jsonf() by qobject_from_jsonf_nofail()

2018-08-16 Thread Markus Armbruster
Commit ab45015a968 "qobject: Let qobject_from_jsonf() fail instead of abort" fails to accomplish its stated aim: the function can still abort due to its use of &error_abort. Its rationale for letting it fail is that all remaining users cope fine with failure. Well, they're just fine with aborting

[Qemu-devel] [PULL 13/25] cpu-plug-test: Don't pass integers as strings to device_add

2018-08-16 Thread Markus Armbruster
test_plug_with_device_add_x86() plugs Haswell-i386-cpu and Haswell-x86_64-cpu with device_add. It passes socket-id, core-id, thread-id as JSON strings. The properties are actually integers. test_plug_with_device_add_coreid() plugs power8_v2.0-spapr-cpu-core and qemu-s390x-cpu with device_add. I

[Qemu-devel] [PULL 23/25] libqtest: Rename qtest_FOOv() to qtest_vFOO() for consistency

2018-08-16 Thread Markus Armbruster
13 of 13 C99 library function pairs taking ... or a va_list parameter are called FOO() and vFOO(). In QEMU, we sometimes call the one taking a va_list FOOv() instead. Bad taste. libqtest.h uses both spellings. Normalize it to the standard spelling. Signed-off-by: Markus Armbruster Reviewed-by

[Qemu-devel] [PULL 18/25] migration-test: Clean up string interpolation into QMP, part 1

2018-08-16 Thread Markus Armbruster
Leaving interpolation into JSON to qmp() is more robust than building QMP input manually, as explained in the recent commit "tests: Clean up string interpolation into QMP input (simple cases)". migrate_recover() builds QMP input manually because wait_command() can't interpolate. Well, it can sinc

[Qemu-devel] [PULL 15/25] migration-test: Make wait_command() return the "return" member

2018-08-16 Thread Markus Armbruster
All callers of wait_command() are only interested in the success response's "return" member. Lift its extraction into wait_command(). Cc: Juan Quintela Cc: Dr. David Alan Gilbert Signed-off-by: Markus Armbruster Reviewed-by: Juan Quintela Reviewed-by: Eric Blake Message-Id: <20180806065344.7

Re: [Qemu-devel] [PATCH] hw/pci: add pci capability to pci-pci bridge

2018-08-16 Thread Liu, Jing2
On 8/14/2018 9:27 PM, Laszlo Ersek wrote: [...]   +cap_error: +    msi_uninit(dev); (4) This error handler doesn't look entirely correct; we can reach it without having initialized MSI. (MSI setup is conditional; and even if we attempt it, it is permitted to fail with "msi=auto".) Therefore

[Qemu-devel] [PULL 05/25] libqtest: Document calling conventions

2018-08-16 Thread Markus Armbruster
From: Eric Blake We have two flavors of vararg usage in qtest: qtest_hmp() etc. work like sprintf(), and qtest_qmp() etc. work like qobject_from_jsonf(). Spell that out in the comments. Also add GCC_FMT_ATTR() to qtest_hmp() etc. so that the compiler can flag incorrect use. We have some cleanup

[Qemu-devel] [PULL 09/25] test-qobject-input-visitor: Avoid format string ambiguity

2018-08-16 Thread Markus Armbruster
When visitor_input_test_init_internal()'s argument @ap is null, then @json_string is interpreted literally, else it's gets %-escapes interpolated. This is awkward. One caller always passes null @ap, and the others never do. Lift the building of the QObject into the callers, where it can be done

[Qemu-devel] [PULL 21/25] libqtest: Enable compile-time format string checking

2018-08-16 Thread Markus Armbruster
qtest_qmp() & friends pass their format string and variable arguments to qobject_from_vjsonf_nofail(). Unlike qobject_from_jsonv(), they aren't decorated with GCC_FMT_ATTR(). Fix that to get compile-time format string checking. Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daud

[Qemu-devel] [PULL 19/25] migration-test: Clean up string interpolation into QMP, part 2

2018-08-16 Thread Markus Armbruster
Leaving interpolation into JSON to qmp() is more robust than building QMP input manually, as explained in the recent commit "tests: Clean up string interpolation into QMP input (simple cases)". migrate() interpolates members into a JSON object. Change it to take its extra QMP arguments as argumen

[Qemu-devel] [PULL 17/25] migration-test: Make wait_command() cope with '%'

2018-08-16 Thread Markus Armbruster
wait_command() passes its argument @command to qtest_qmp_send(). Falls apart if @command contain '%'. Two ways to disarm this trap: suppress interpretation of '%' by passing @command as argument to format string "%s", or fix it by having wait_command() take the variable arguments to go with @comma

[Qemu-devel] [PULL 12/25] tests: Clean up string interpolation into QMP input (simple cases)

2018-08-16 Thread Markus Armbruster
When you build QMP input manually like this cmd = g_strdup_printf("{ 'execute': 'migrate'," "'arguments': { 'uri': '%s' } }", uri); rsp = qmp(cmd); g_free(cmd); you're responsible for escaping the interpolated values for JSON. Not d

[Qemu-devel] [PULL 20/25] migration-test: Clean up string interpolation into QMP, part 3

2018-08-16 Thread Markus Armbruster
Leaving interpolation into JSON to qmp() is more robust than building QMP input manually, as explained in the recent commit "tests: Clean up string interpolation into QMP input (simple cases)". migration-test.c interpolates strings into JSON in a few places: * migrate_set_parameter() interpolates

[Qemu-devel] [PULL 11/25] tests: Pass literal format strings directly to qmp_FOO()

2018-08-16 Thread Markus Armbruster
The qmp_FOO() take a printf-like format string. In a few places, we assign a string literal to a variable and pass that instead of simply passing the literal. Clean that up. Bonus: gets rid of non-literal format strings. A step towards compile-time format string checking without triggering -Wfo

Re: [Qemu-devel] RDMA wrongly detected as being supported on FreeBSD

2018-08-16 Thread Marcel Apfelbaum
On 08/15/2018 04:37 PM, Kamil Rytarowski wrote: On 06.08.2018 10:51, Thomas Huth wrote: On 07/28/2018 05:50 AM, Rebecca Cran wrote: On 7/25/18 5:14 AM, Thomas Huth wrote: Note that the error has been reported to happen on FreeBSD - so I doubt that this header should be here. Anyway, our

[Qemu-devel] [PULL 14/25] tests: Clean up string interpolation around qtest_qmp_device_add()

2018-08-16 Thread Markus Armbruster
Leaving interpolation into JSON to qmp() is more robust than building QMP input manually, as explained in the commit before previous. qtest_qmp_device_add() and its wrappers interpolate into JSON as follows: * qtest_qmp_device_add() interpolates members into a JSON object. * So do its wrappers q

[Qemu-devel] [PULL 16/25] tests: New helper qtest_qmp_receive_success()

2018-08-16 Thread Markus Armbruster
Commit b21373d0713 copied wait_command() from tests/migration-test.c to tests/tpm-util.c. Replace both copies by new libqtest helper qtest_qmp_receive_success(). Also use it to simplify qtest_qmp_device_del(). Bonus: gets rid of a non-literal format string. A step towards compile-time format st

Re: [Qemu-devel] [PATCH v3 5/5] qmp: add pmemload command

2018-08-16 Thread Simon Ruderich
On Thu, Aug 16, 2018 at 10:26:18AM +0200, Markus Armbruster wrote: >> On Thu, Aug 16, 2018 at 07:43:41AM +0200, Markus Armbruster wrote: On Fri, Aug 10, 2018 at 11:36:51AM +0100, Dr. David Alan Gilbert wrote: > Also, had you considered rearranging and making them optional, > for exampl

Re: [Qemu-devel] vTPM 2.0 is recognized as vTPM 1.2 on the Win 10 virtual machine

2018-08-16 Thread Marc-André Lureau
Hi On Thu, Aug 16, 2018 at 3:29 AM 汤福 wrote: > > Hi, > > I want to use the vTPM in a qemu Windows image. Unfortunately, it didn't work. > First, the equipment: > TPM 2.0 hardware > CentOS 7.2 > Qemu v2.10.2 > SeaBIOS 1.11.0 > libtpm and so on > > My host is centos 7.2 with the TPM 2.0 hardware and

[Qemu-devel] [PULL 24/25] tests/libqtest: Improve kill_qemu()

2018-08-16 Thread Markus Armbruster
From: Eric Blake In kill_qemu() we have an assert that checks that the QEMU process didn't dump core: assert(!WCOREDUMP(wstatus)); Unfortunately the WCOREDUMP macro here means the resulting message is not very easy to comprehend on at least some systems: ahci-test: tests/libqtest.c:

Re: [Qemu-devel] [PULL 00/21] Block layer patches

2018-08-16 Thread Peter Maydell
On 15 August 2018 at 13:55, Kevin Wolf wrote: > The following changes since commit 38441756b70eec5807b5f60dad11a93a91199866: > > Update version for v3.0.0 release (2018-08-14 16:38:43 +0100) > > are available in the git repository at: > > git://repo.or.cz/qemu/kevin.git tags/for-upstream > > f

Re: [Qemu-devel] [PATCH 05/10] target/arm: Implement AArch32 HCR and HCR2

2018-08-16 Thread Luc Michel
On 8/14/18 2:42 PM, Peter Maydell wrote: > The AArch32 HCR and HCR2 registers alias HCR_EL2 > bits [31:0] and [63:32]; implement them. > > Signed-off-by: Peter Maydell > --- > target/arm/helper.c | 39 +++ > 1 file changed, 35 insertions(+), 4 deletions(-) >

Re: [Qemu-devel] [PATCH 0/4] target/arm: Fix int64_to_float16 double-rounding

2018-08-16 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180814002653.12828-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PATCH 0/4] target/arm: Fix int64_to_float16 double-rounding === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [PATCH 06/10] target/arm: Implement AArch32 Hyp FARs

2018-08-16 Thread Luc Michel
On 8/14/18 2:42 PM, Peter Maydell wrote: > The AArch32 virtualization extensions support these fault address > registers: > * HDFAR: aliased with AArch64 FAR_EL2[31:0] and AArch32 DFAR(S) > * HIFAR: aliased with AArch64 FAR_EL2[63:32] and AArch32 IFAR(S) > > Implement the accessors for these. Th

[Qemu-devel] [PATCH v4 4/7] hmp: use l for size argument in memsave/pmemsave

2018-08-16 Thread Simon Ruderich
i is only 32-bit. To prevent possible truncation when dumping large memory regions use l which is target long. Suggested-by: Dr. David Alan Gilbert Signed-off-by: Simon Ruderich --- hmp-commands.hx | 4 ++-- hmp.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] hw/rdma: Abort send-op if fail to create addr handler

2018-08-16 Thread Marcel Apfelbaum
On 08/14/2018 01:00 PM, Yuval Shaia wrote: Function create_ah might return NULL, let's exit with an error. Signed-off-by: Yuval Shaia --- hw/rdma/rdma_backend.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c index 35726bda2e..59d02e

Re: [Qemu-devel] [PATCH] hw/rdma: Abort send-op if fail to create addr handler

2018-08-16 Thread Yuval Shaia
On Tue, Aug 14, 2018 at 01:00:10PM +0300, Yuval Shaia wrote: > Function create_ah might return NULL, let's exit with an error. > > Signed-off-by: Yuval Shaia > --- > hw/rdma/rdma_backend.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend

[Qemu-devel] [PATCH v4 0/7] qmp/hmp: add pmemload command

2018-08-16 Thread Simon Ruderich
Hello, Revised patch series rebased on current master which should incorporate all comments mentioned in the review. I've decided to make size and offset optional for QMP, but keep it required for HMP to make pmemload consistent with memsave/pmemsave. Regards Simon Simon Ruderich (7): cpus: co

[Qemu-devel] [PATCH v4 3/7] cpus: use size_t in qmp_memsave/qmp_pmemsave

2018-08-16 Thread Simon Ruderich
It's the natural type for object sizes and matches the return value of sizeof(buf). Signed-off-by: Simon Ruderich --- cpus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cpus.c b/cpus.c index dd8ba36d2f..243f2c0d2e 100644 --- a/cpus.c +++ b/cpus.c @@ -2294,7 +2294,7 @@

Re: [Qemu-devel] [PATCH 5/6] net: Silence 'has no peer' messages in testing mode

2018-08-16 Thread Thomas Huth
On 08/14/2018 07:10 PM, Paolo Bonzini wrote: > On 14/08/2018 18:11, Thomas Huth wrote: >> On 08/14/2018 06:03 PM, Paolo Bonzini wrote: >>> On 14/08/2018 18:01, Thomas Huth wrote: On 08/14/2018 05:57 PM, Paolo Bonzini wrote: > On 14/08/2018 17:43, Thomas Huth wrote: >> The machines whic

[Qemu-devel] [PATCH v4 6/7] qmp: add pmemload command

2018-08-16 Thread Simon Ruderich
Adapted patch from Baojun Wang [1] with the following commit message: I found this could be useful to have qemu-softmmu as a cross debugger (launch with -s -S command line option), then if we can have a command to load guest physical memory, we can use cross gdb to do some target d

[Qemu-devel] [PATCH v4 1/7] cpus: correct coding style in qmp_memsave/qmp_pmemsave

2018-08-16 Thread Simon Ruderich
Signed-off-by: Simon Ruderich --- cpus.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/cpus.c b/cpus.c index b5844b7103..125adc4da4 100644 --- a/cpus.c +++ b/cpus.c @@ -2318,8 +2318,9 @@ void qmp_memsave(int64_t addr, int64_t size, const char *filename, while (

Re: [Qemu-devel] [PATCH 05/10] target/arm: Implement AArch32 HCR and HCR2

2018-08-16 Thread Peter Maydell
On 16 August 2018 at 09:55, Luc Michel wrote: > On 8/14/18 2:42 PM, Peter Maydell wrote: >> The AArch32 HCR and HCR2 registers alias HCR_EL2 >> bits [31:0] and [63:32]; implement them. >> >> Signed-off-by: Peter Maydell >> --- >> target/arm/helper.c | 39 +++ >

[Qemu-devel] [PATCH v4 5/7] hmp: use F for filename arguments in memsave/pmemsave

2018-08-16 Thread Simon Ruderich
This enables completion for the filename arguments. Suggested-by: Dr. David Alan Gilbert Signed-off-by: Simon Ruderich --- hmp-commands.hx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 79c158a140..5715bd7b51 100644 --- a/hmp-comm

Re: [Qemu-devel] RDMA wrongly detected as being supported on FreeBSD

2018-08-16 Thread Thomas Huth
On 08/16/2018 10:55 AM, Marcel Apfelbaum wrote: > > > On 08/15/2018 04:37 PM, Kamil Rytarowski wrote: >> On 06.08.2018 10:51, Thomas Huth wrote: >>> On 07/28/2018 05:50 AM, Rebecca Cran wrote: On 7/25/18 5:14 AM, Thomas Huth wrote: > Note that the error has been reported to happen o

[Qemu-devel] [PATCH v4 2/7] cpus: convert qmp_memsave/qmp_pmemsave to use qemu_open

2018-08-16 Thread Simon Ruderich
qemu_open() allow passing file descriptors to qemu which is used in restricted environments like libvirt where open() is prohibited. Suggested-by: Eric Blake Signed-off-by: Simon Ruderich --- cpus.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/cpus.

[Qemu-devel] [PATCH] config: split PVRDMA from RDMA

2018-08-16 Thread Marcel Apfelbaum
In some BSD systems RDMA migration is possible while the pvrdma device can't be compiled because the mremap system call is missing. Reported-by: Rebecca Cran Signed-off-by: Marcel Apfelbaum --- configure | 41 - hw/rdma/Makefile.objs | 2 +-

[Qemu-devel] [PATCH v4 7/7] hmp: add pmemload command

2018-08-16 Thread Simon Ruderich
Adapted patch from Baojun Wang [1] with the following commit message: I found this could be useful to have qemu-softmmu as a cross debugger (launch with -s -S command line option), then if we can have a command to load guest physical memory, we can use cross gdb to do some target d

Re: [Qemu-devel] RDMA wrongly detected as being supported on FreeBSD

2018-08-16 Thread Marcel Apfelbaum
On 08/16/2018 12:02 PM, Thomas Huth wrote: On 08/16/2018 10:55 AM, Marcel Apfelbaum wrote: On 08/15/2018 04:37 PM, Kamil Rytarowski wrote: On 06.08.2018 10:51, Thomas Huth wrote: On 07/28/2018 05:50 AM, Rebecca Cran wrote: On 7/25/18 5:14 AM, Thomas Huth wrote: Note that the error has b

Re: [Qemu-devel] [PATCH 07/10] target/arm: Implement ESR_EL2/HSR for AArch32 and no-EL2

2018-08-16 Thread Luc Michel
On 8/14/18 2:42 PM, Peter Maydell wrote: > The AArch32 HSR is the equivalent of AArch64 ESR_EL2; > we can implement it by marking our existing ESR_EL2 regdef > as STATE_BOTH. It also needs to be "RES0 from EL3 if > EL2 not implemented", so add the missing stanza to > el3_no_el2_cp_reginfo. > > Sig

Re: [Qemu-devel] [PATCH] config: split PVRDMA from RDMA

2018-08-16 Thread Thomas Huth
On 08/16/2018 11:06 AM, Marcel Apfelbaum wrote: > In some BSD systems RDMA migration is possible while > the pvrdma device can't be compiled because the mremap > system call is missing. > > Reported-by: Rebecca Cran > Signed-off-by: Marcel Apfelbaum > --- > configure | 41 ++

Re: [Qemu-devel] [PATCH] config: split PVRDMA from RDMA

2018-08-16 Thread Peter Maydell
On 16 August 2018 at 10:06, Marcel Apfelbaum wrote: > In some BSD systems RDMA migration is possible while > the pvrdma device can't be compiled because the mremap > system call is missing. > > Reported-by: Rebecca Cran > Signed-off-by: Marcel Apfelbaum > +##

[Qemu-devel] [PATCH v2 2/3] hw/pci: add teardown function for PCI resource reserve capability

2018-08-16 Thread Jing Liu
Clean up the PCI config space of resource reserve capability. Signed-off-by: Jing Liu --- hw/pci/pci_bridge.c | 9 + include/hw/pci/pci_bridge.h | 1 + 2 files changed, 10 insertions(+) diff --git a/hw/pci/pci_bridge.c b/hw/pci/pci_bridge.c index 15b055e..dbcee90 100644 --- a/hw

[Qemu-devel] [PATCH v2 3/3] hw/pci: add PCI resource reserve capability to legacy PCI bridge

2018-08-16 Thread Jing Liu
Add hint to firmware (e.g. SeaBIOS) to reserve addtional BUS/IO/MEM/PREF resource for legacy pci-pci bridge. Signed-off-by: Jing Liu --- hw/pci-bridge/pci_bridge_dev.c | 25 + 1 file changed, 25 insertions(+) diff --git a/hw/pci-bridge/pci_bridge_dev.c b/hw/pci-bridge/pc

[Qemu-devel] [PATCH v2 1/3] hw/pci: factor PCI reserve resources to a separate structure

2018-08-16 Thread Jing Liu
Factor "bus_reserve", "io_reserve", "mem_reserve", "pref32_reserve" and "pref64_reserve" fields of the "GenPCIERootPort" structure out to "PCIResReserve" structure, so that other PCI bridges can reuse it to add resource reserve capability. Signed-off-by: Jing Liu --- hw/pci-bridge/gen_pcie_root_

[Qemu-devel] [PATCH v2 0/3] hw/pci: PCI resource reserve capability

2018-08-16 Thread Jing Liu
This patch serial is about PCI resource reserve capability. First patch refactors the resource reserve fields in GenPCIERoorPort structure out to another new structure, called "PCIResReserve". Modify the parameter list of pci_bridge_qemu_reserve_cap_init(). Then we add the teardown function calle

[Qemu-devel] [PATCH] usb-host: insert usb device into hostdevs to be scaned

2018-08-16 Thread linzhecheng
According to the comment of usb_host_post_load_bh, after removing the usb device passed through, we will kick host to scan it again, but the emulated usb device is not added to global list hostdevs, so it can never be discovered then. So just do it before usb_host_auto_check. What's more, it's fut

Re: [Qemu-devel] [PULL 00/25] Testing patches for 2018-08-16

2018-08-16 Thread Peter Maydell
On 16 August 2018 at 09:36, Markus Armbruster wrote: > The following changes since commit c146b54c7fdbd926ee8fc4369699e3480d54f6fa: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-misc-2018-08-15' > into staging (2018-08-15 20:20:34 +0100) > > are available in the Git repository at:

Re: [Qemu-devel] [PATCH 1/2] qemu-option: add help fallback to print the list of options

2018-08-16 Thread Marc-André Lureau
Hi On Thu, Aug 16, 2018 at 9:19 AM Markus Armbruster wrote: > > Marc-André Lureau writes: > > > QDev options accept '?' or 'help' in the list of parameters, which is > > really handy to list the available options. > > > > Unfortunately, this isn't built in QemuOpts. qemu_opts_parse_noisily() > >

Re: [Qemu-devel] [PATCH v8 00/87] Add nanoMIPS support to QEMU

2018-08-16 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1534182832-554-1-git-send-email-aleksandar.marko...@rt-rk.com Subject: [Qemu-devel] [PATCH v8 00/87] Add nanoMIPS support to QEMU === TEST SCRIPT BEGIN === #!/bin/bash BASE=

[Qemu-devel] [Bug 1787070] Re: Guests using the qxl-vga are freezing

2018-08-16 Thread Gerd Hoffmann
Hmm, nothing obvious in the stack trace. Also doesn't reproduce here. What qemu version is this? If older than 3.0: Does it still happen for you with qemu 3.0? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.ne

Re: [Qemu-devel] [PATCH 1/2] qemu-option: add help fallback to print the list of options

2018-08-16 Thread Marc-André Lureau
On Thu, Aug 16, 2018 at 12:01 PM Marc-André Lureau wrote: > > Hi > > On Thu, Aug 16, 2018 at 9:19 AM Markus Armbruster wrote: > > > > Marc-André Lureau writes: > > > > > QDev options accept '?' or 'help' in the list of parameters, which is > > > really handy to list the available options. > > >

Re: [Qemu-devel] [PATCH] usb-host: insert usb device into hostdevs to be scaned

2018-08-16 Thread Gerd Hoffmann
On Thu, Aug 16, 2018 at 05:43:56PM +0800, linzhecheng wrote: > According to the comment of usb_host_post_load_bh, after removing the > usb device passed through, we will kick host to scan it again, but the > emulated > usb device is not added to global list hostdevs, so it can never be > discover

Re: [Qemu-devel] [PATCH] usb-host: insert usb device into hostdevs to be scaned

2018-08-16 Thread linzhecheng
> -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Thursday, August 16, 2018 6:46 PM > To: linzhecheng > Cc: qemu-devel@nongnu.org; wangxin (U) > Subject: Re: [PATCH] usb-host: insert usb device into hostdevs to be scaned > > On Thu, Aug 16, 2018 at 05:43:56P

Re: [Qemu-devel] [PATCH 6/6] tests/device-introspect: Test with all machines, not only with "none"

2018-08-16 Thread Thomas Huth
On 08/14/2018 05:32 PM, Paolo Bonzini wrote: > On 14/08/2018 16:46, Thomas Huth wrote: >> To be able to catch these problems, let's extend the device-introspect >> test to check the devices on all machine types. Since this is a rather >> slow operation, and most of the problems are already handled

Re: [Qemu-devel] [PATCH for-3.1 v10 00/31] block: Fix some filename generation issues

2018-08-16 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180809213528.14738-1-mre...@redhat.com Subject: [Qemu-devel] [PATCH for-3.1 v10 00/31] block: Fix some filename generation issues === TEST SCRIPT BEGIN === #!/bin/bash BA

[Qemu-devel] [PATCH v2 0/8] Various qtest-related patches and a mc146818rtc fix

2018-08-16 Thread Thomas Huth
The basic idea for this patch series are the two patches that improve the device-inrospection test: We now check that the qom-tree and the qtree do not change during introspection, and the we also turn on the device introspection test with all machines when running in SPEED=slow mode. The other pat

[Qemu-devel] [PATCH v2 4/8] hw/timer/mc146818rtc: Fix introspection problem

2018-08-16 Thread Thomas Huth
There is currently a funny problem with the "mc146818rtc" device: 1) Start QEMU like this: qemu-system-ppc64 -M pseries -S 2) At the HMP monitor, enter "info qom-tree". Note that there is an entry for "/rtc (spapr-rtc)". 3) Introspect the mc146818rtc device like this: device_add mc146818rt

[Qemu-devel] [PATCH v2 2/8] net: Silence 'has no peer' messages in testing mode

2018-08-16 Thread Thomas Huth
When running qtests with -nodefaults, we are not interested in these 'XYZ has no peer' messages. Signed-off-by: Thomas Huth --- vl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/vl.c b/vl.c index 16b913f..7055df3 100644 --- a/vl.c +++ b/vl.c @@ -4559,11 +4559,10 @@ int m

[Qemu-devel] [PATCH v2 5/8] tests: Skip old versioned machine types in quick testing mode

2018-08-16 Thread Thomas Huth
The tests that check something for all machine types currently spend a lot of time checking old machine types (like "pc-i440fx-2.0" for example). The chances that we find something new there in addition to checking the latest version of a machine type are pretty low, so we should not waste the time

[Qemu-devel] [PATCH v2 1/8] tests/migration-test: Silence the kvm_hv message by default

2018-08-16 Thread Thomas Huth
When running "make check" on a non-POWER host, the output is quite distorted like this: [...] GTESTER check-qtest-nios2 GTESTER check-qtest-or1k GTESTER check-qtest-ppc64 Skipping test: kvm_hv not available Skipping test: kvm_hv not available Skipping test: kvm_hv not available Skipping t

[Qemu-devel] [PATCH v2 7/8] tests/device-introspect: Test with all machines, not only with "none"

2018-08-16 Thread Thomas Huth
Certain device introspection crashes used to only happen if you were using a certain machine, e.g. if the machine was using serial_hd() or nd_table[], and a device was trying to use these in its instance_init function, too. To be able to catch these problems, let's extend the device-introspect tes

[Qemu-devel] [PATCH v2 3/8] hw/timer/mc146818rtc: White space clean-up

2018-08-16 Thread Thomas Huth
mc146818rtc.c still contains some TABs. Replace them with spaces. And while we're at it, also delete trailing whitespace in this file. Reviewed-by: Markus Armbruster Signed-off-by: Thomas Huth --- hw/timer/mc146818rtc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a

[Qemu-devel] [PATCH v2 8/8] MAINTAINERS: add maintainers for qtest

2018-08-16 Thread Thomas Huth
From: Paolo Bonzini Thomas has been doing a lot of work on qom-test and device-introspection-test, and Laurent has ported libqos to sPAPR and co-mentored Emanuele on the upcoming qtest device framework. They deserve recognition. :) Signed-off-by: Paolo Bonzini Reviewed-by: Laurent Vivier Revi

[Qemu-devel] [PATCH v2 6/8] tests/device-introspection: Check that the qom-tree and qtree do not change

2018-08-16 Thread Thomas Huth
Introspection should not change the qom-tree / qtree, so we should check this in the device-introspect-test, too. This patch helped to find lots of instrospection bugs during the QEMU v3.0 soft/hard-freeze period in the last two months. Signed-off-by: Thomas Huth --- tests/device-introspect-test

Re: [Qemu-devel] [PATCH v8 00/87] Add nanoMIPS support to QEMU

2018-08-16 Thread Aleksandar Markovic
> From: no-re...@patchew.org > Sent: Thursday, August 16, 2018 10:16 AM > > Subject: Re: [Qemu-devel] [PATCH v8 00/87] Add nanoMIPS support to QEMU > > Hi, > > This series seems to have some coding style problems. See output below for more information: > > ... > We are aware of all these warni

Re: [Qemu-devel] How do you do when write more than 16TB data to qcow2 on ext4?

2018-08-16 Thread Eric Blake
On 08/16/2018 03:22 AM, Daniel P. Berrangé wrote: On Thu, Aug 16, 2018 at 09:35:52AM +0800, lampahome wrote: We all know there's a file size limit 16TB in ext4 and other fs has their limit,too. If I create an qcow2 20TB on ext4 and write to it more than 16TB. Data more than 16TB can't be writte

[Qemu-devel] [PATCH] hw/arm/mps2-tz: Replace init_sysbus_child() with sysbus_init_child_obj()

2018-08-16 Thread Thomas Huth
Now that we've got the common sysbus_init_child_obj() function, we do not need the local init_sysbus_child() anymore. Signed-off-by: Thomas Huth --- hw/arm/mps2-tz.c | 32 +++- 1 file changed, 11 insertions(+), 21 deletions(-) diff --git a/hw/arm/mps2-tz.c b/hw/arm/m

Re: [Qemu-devel] [PATCH v8 62/87] mips_malta: Add basic nanoMIPS boot code for Malta board

2018-08-16 Thread Aleksandar Markovic
> From: Aleksandar Markovic > Sent: Monday, August 13, 2018 7:53 PM > > Subject: [PATCH v8 62/87] mips_malta: Add basic nanoMIPS boot code for Malta > board > > From: Matthew Fortune > > Add basic nanoMIPS boot code for Malta. > > Signed-off-by: Yongbok Kim > Signed-off-by: Aleksandar Marko

Re: [Qemu-devel] [PATCH v2 01/16] qom/object: Add a new function object_initialize_child()

2018-08-16 Thread Thomas Huth
On 07/14/2018 12:57 AM, Eduardo Habkost wrote: > On Fri, Jul 13, 2018 at 10:27:29AM +0200, Thomas Huth wrote: >> A lot of code is using the object_initialize() function followed by a call >> to object_property_add_child() to add the newly initialized object as a child >> of the current object. Both

Re: [Qemu-devel] [PATCH v8 55/87] target/mips: Adjust set_hflags_for_handler() for nanoMIPS

2018-08-16 Thread Aleksandar Markovic
> From: Aleksandar Markovic > Sent: Monday, August 13, 2018 7:53 PM > > Subject: [PATCH v8 55/87] target/mips: Adjust set_hflags_for_handler() for > nanoMIPS > > From: James Hogan > > We shouldn't clear M16 mode when entering an interrupt on nanoMIPS, > otherwise we'll start interpreting the

[Qemu-devel] [PATCH v2] target/arm: crash on conditional instr in it block

2018-08-16 Thread Roman Kapl
If an instruction is conditional (like CBZ) and it is executed conditionally (using the ITx instruction), a jump to undefined label is generated. CBZ in IT block is an unpredictable behavior, and honouring the condition code is allowed by the spec in this case (constrained unpredictable, ARMv8, sec

Re: [Qemu-devel] [PATCH 00/11] target/arm: sve linux-user patches

2018-08-16 Thread Peter Maydell
On 9 August 2018 at 04:40, Richard Henderson wrote: > I posted a few of these before, and I thought Peter had applied them > to his target-arm.for-3-1 branch, but I don't see them there now. I did indeed have patches 1-4 in my for-3.1 branch and they're now in master. I must have forgotten to pus

Re: [Qemu-devel] [PATCH 0/5] mps2: Implement FPGAIO counters and dual-timer

2018-08-16 Thread Peter Maydell
Ping? Patch 2 has been reviewed but the rest are still waiting. thanks -- PMM On 30 July 2018 at 17:24, Peter Maydell wrote: > This patchset adds some missing timer and counter devices > to the MPS2 boards: > > * the MPS2 "fpgaio" register bank includes some registers >which provide various

Re: [Qemu-devel] [PATCH v8 65/87] target/mips: Add definition of nanoMIPS I7200 CPU

2018-08-16 Thread Aleksandar Markovic
> From: Aleksandar Markovic > Sent: Monday, August 13, 2018 7:53 PM > To: qemu-devel@nongnu.org > > Subject: [PATCH v8 65/87] target/mips: Add definition of nanoMIPS I7200 CPU > > From: Stefan Markovic > > Add definition of the first nanoMIPS processor in QEMU. > > Signed-off-by: Yongbok Kim

  1   2   3   4   5   >