On Wed, 08/15 00:53, Emilio G. Cota wrote:
> > > +#define QSP_GEN_VOID(type_, qsp_t_, func_, impl_) \
> > > +void func_(type_ *obj, const char *file, unsigned line) \
> > > +{ \
> > > +
Fix the following issues:
common.py:873:13: E129 visually indented line with same indent as next
logical line
common.py:1766:5: E741 ambiguous variable name 'l'
common.py:1784:1: E305 expected 2 blank lines after class or function
definition, found 1
common.py:1833:1: E305 expect
From: Marc-André Lureau
Use shlex to split the CLI command, respecting quoted arguments, and
also comments. This allows to call for ex:
(QEMU) human-monitor-command command-line="screendump /dev/null"
{"execute": "human-monitor-command", "arguments": {"command-line": "screendump
/dev/null"}}
S
From: Marc-André Lureau
Spotted by ASAN, during make check...
Direct leak of 40 byte(s) in 1 object(s) allocated from:
#0 0x7f8e27262c48 in malloc (/lib64/libasan.so.5+0xeec48)
#1 0x7f8e26a5f3c5 in g_malloc (/lib64/libglib-2.0.so.0+0x523c5)
#2 0x555ab67078a8 in qstring_from_str
/hom
From: Marc-André Lureau
Presumably 0.15 was the version it was first introduced, but
qmp keeps evolving. There is no point in having that version
as test prefix, 'qmp' makes more sense here.
Signed-off-by: Marc-André Lureau
Reviewed-by: Eric Blake
Message-Id: <20180326150916.9602-12-marcandre.
The following changes since commit 38441756b70eec5807b5f60dad11a93a91199866:
Update version for v3.0.0 release (2018-08-14 16:38:43 +0100)
are available in the Git repository at:
git://repo.or.cz/qemu/armbru.git tags/pull-misc-2018-08-15
for you to fetch changes up to cb9ec42f33c07cd07d2e29
From: Marc-André Lureau
Spotted by ASAN:
=
==27907==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 4120 byte(s) in 1 object(s) allocated from:
#0 0x7f913458ce50 in calloc (/lib64/libasan.so.5+0xeee50)
#1 0x7f913
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1772086
Title:
malformed serial data being sent from guest
Status in QEMU:
Fix Rele
... and it has been fixed again for 3.0:
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=eeaa6715050ed3f9cbedd32
** Changed in: qemu
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://b
Fix has been included here:
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=09b94ac0f29db3b022a77
** Changed in: qemu
Status: Confirmed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1769189
Title:
Issue with qemu 2.12.0 + SATA
Status in QEMU:
Fix Released
Bug desc
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=95f875654ae8b433b5
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1766896
Title:
qem
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1753437
Title:
pc-bios/s390-ccw/libc: size_t should be unsigned
Status in QEMU:
Fix
Patch has been merged here:
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=122f9c83f2ef1cd90152
** Changed in: qemu
Status: Confirmed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1768295
Title:
VLLDM/VLSTM trigger UsageFault in the Secure Mode
Status in QEMU:
Fi
Fixed here:
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=230ff73904e72dde2d7718c2
** Changed in: qemu
Status: Confirmed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1739304
Fix has been added here:
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=93f874fe9dbe0b997b5a94
** Changed in: qemu
Status: New => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/17
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1407813
Title:
QEMU wrongly translates newlines on serial output
Status in QEMU:
Fi
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1715296
Title:
qemu: invalid serial port configuration
Status in QEMU:
Fix Released
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/658904
Title:
QEMU refers to VLAN, but doesn't mean 802.1Q
Status in QEMU:
Fix Rele
Patch has been included here:
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=677b490501823c1cb6946d8
** Changed in: qemu
Status: New => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/b
It sounds more like a bug / limited featureset in the Solaris 'tr'
binary.
What is your $PATH ? Make sure /usr/xpg4/bin directory appears
*before* /usr/bin in $PATH to get a more functional version of 'tr',
though I'm not sure if that'll fix it or not.
--
You received this bug notification bec
Max Reitz writes:
> On 2018-07-28 06:32, Jeff Cody wrote:
>> On Wed, Jul 25, 2018 at 05:01:44PM +0100, Daniel P. Berrangé wrote:
>>> On Wed, Jul 25, 2018 at 10:56:48AM -0500, Eric Blake wrote:
On 07/25/2018 10:10 AM, Markus Armbruster wrote:
> qemu_rbd_parse_filename() builds a keypairs
On 8/14/18 2:42 PM, Peter Maydell wrote:
> We implement the HAMAIR1 register as RAZ/WI; we had a typo in the
> regdef, though, and were incorrectly naming it HMAIR1 (which is
> a different register which we also implement as RAZ/WI).
>
> Signed-off-by: Peter Maydell
Reviewed-By: Luc Michel
On 8/14/18 2:42 PM, Peter Maydell wrote:
> ARMCPRegInfo structs will not default to .cp = 15 if they
"will default" as suggested by Edgar.
> are ARM_CP_STATE_BOTH, but not if they are ARM_CP_STATE_AA32
> (because a coprocessor number of 0 is valid for AArch32).
> We forgot to explicitly set .cp = 1
ping.
Finally, Qemu 3.0 released, and it is incompatible with current NBD
protocol. Please, commit this patch.
13.08.2018 15:02, Vladimir Sementsov-Ogievskiy wrote:
ping
Qemu 3.0 is near to release, and it is not correspond to current
version of spec, it corresponds to this patch. Can we pu
v5:
- rebase to master, especially fix up the last one trace_vtd_err()
introduced in commit 63b88968f13 [Markus]
- add one more patch to replace the rest of trace_vtd_err*() hooks too
v4:
- patch 2: pick r-b from Philippe
- patch 1: replace all __* variables into *_ [Eric]
- patch 1: enhance the
Replace all the trace_vtd_err_*() hooks with the new error_report_once()
since they are similar to trace_vtd_err() - dumping the first error
would be mostly enough, then we have them on by default too.
Signed-off-by: Peter Xu
---
hw/i386/intel_iommu.c | 63 ++-
There are many error_report()s that can be used in frequently called
functions, especially on IO paths. That can be unideal in that
malicious guest can try to trigger the error tons of time which might
use up the log space on the host (e.g., libvirt can capture the stderr
of QEMU and put it persis
Replace existing trace_vtd_err() with error_report_once() then stderr
will capture something if any of the error happens, meanwhile we don't
suffer from any DDOS. Then remove the trace point. Since at it,
provide more information where proper (now we can pass parameters into
the report function).
Andrew Oates, le mar. 14 août 2018 22:35:21 -0400, a ecrit:
> On Linux, SOCK_DGRAM+IPPROTO_ICMP sockets give only the ICMP packet when
> read from. On macOS, however, the socket acts like a SOCK_RAW socket
> and includes the IP header as well.
>
> This change strips the extra IP header from the r
Most of the various error classes were removed prior to the 1.2 release.
Remove mentions of the error classes which did not make it.
Signed-off-by: Peter Krempa
---
qapi/block-core.json | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/qapi/block-core.json b/qapi/block-core
Am 15.08.2018 um 12:26 hat Peter Krempa geschrieben:
> Most of the various error classes were removed prior to the 1.2 release.
> Remove mentions of the error classes which did not make it.
>
> Signed-off-by: Peter Krempa
Thanks, applied to the block branch.
Kevin
On Tue, Aug 14, 2018 at 01:42:54PM +0100, Peter Maydell wrote:
> Implement the necessary support code for taking exceptions
> to Hyp mode in AArch32.
Hi Peter,
A general comment that I think this would be a little easier
to look at if it was split into two patches, one non-functional
change to br
On 15 August 2018 at 09:30, Roman Kapl wrote:
> Hi and thanks for review,
>
> On 08/14/2018 08:12 PM, Peter Maydell wrote:
>>
>> On 14 August 2018 at 17:54, Roman Kapl wrote:
>>>
>>> If an instruction is conditional (like CBZ) and it is executed
>>> conditionally
>>> (using the ITx instruction),
On 15 August 2018 at 03:35, Andrew Oates wrote:
> On Linux, SOCK_DGRAM+IPPROTO_ICMP sockets give only the ICMP packet when
> read from. On macOS, however, the socket acts like a SOCK_RAW socket
> and includes the IP header as well.
>
> This change strips the extra IP header from the received pack
On 15 August 2018 at 11:54, Edgar E. Iglesias wrote:
> On Tue, Aug 14, 2018 at 01:42:54PM +0100, Peter Maydell wrote:
>> Implement the necessary support code for taking exceptions
>> to Hyp mode in AArch32.
>
> Hi Peter,
>
> A general comment that I think this would be a little easier
> to look at
On Tue, Aug 14, 2018 at 01:42:53PM +0100, Peter Maydell wrote:
> ARMv7VE introduced the ERET instruction, which is necessary to
> return from an exception taken to Hyp mode. Implement this.
> In A32 encoding it is a completely new encoding; in T32 it
> is an adjustment of the behaviour of the exist
The executables are created in the subdirectories for each target, so
x86_64-softmmu/qemu-system-x86_64 and so on.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1785698
Title:
Solaris build error:
Andrew Oates, le mar. 14 août 2018 22:35:21 -0400, a ecrit:
> On Linux, SOCK_DGRAM+IPPROTO_ICMP sockets give only the ICMP packet when
> read from. On macOS, however, the socket acts like a SOCK_RAW socket
> and includes the IP header as well.
>
> This change strips the extra IP header from the r
On Tue, Aug 14, 2018 at 01:42:44PM +0100, Peter Maydell wrote:
> Now we have virtualization support in the GICv2 emulation,
> I thought I'd have a look at how much we were still missing
> for being able to enable EL2 support for AArch32.
> This set of patches fixes some minor missing pieces:
> * v
On 15 August 2018 at 12:04, Edgar E. Iglesias wrote:
> On Tue, Aug 14, 2018 at 01:42:44PM +0100, Peter Maydell wrote:
>> I also noticed that we fail to implement really quite a lot
>> of the HCR_EL2 trap semantics for either AArch64 or AArch32,
>> to the extent that I'm surprised that nested guest
Peter Xu writes:
> There are many error_report()s that can be used in frequently called
> functions, especially on IO paths. That can be unideal in that
> malicious guest can try to trigger the error tons of time which might
> use up the log space on the host (e.g., libvirt can capture the stder
Peter Xu writes:
> Replace existing trace_vtd_err() with error_report_once() then stderr
> will capture something if any of the error happens, meanwhile we don't
> suffer from any DDOS. Then remove the trace point. Since at it,
> provide more information where proper (now we can pass parameters
An ACK from Michael Tsirkin would be nice. But silence won't keep this
series out for long.
On Wed, 25 Jul 2018 14:20:14 +0200
Thomas Huth wrote:
> For more fine-grained control over the build process, it would be good
> to have the possibility to disable single virtio devices, too. We already
> have CONFIG_VIRTIO_* switches in the Makefiles, but currently all
> virtio-ccw devices are c
On Thu, 5 Jul 2018 13:25:28 -0400
"Jason J. Herne" wrote:
> This is to support booting from vfio-ccw dasd devices. We basically implement
> the real hardware ipl procedure. This allows for booting Linux guests on
> vfio-ccw devices.
>
> vfio-ccw's channel program prefetch algorithm complicates
On 8/14/18 2:42 PM, Peter Maydell wrote:
> The AArch32 HACTLR2 register maps to bits [63:32] of ACTLR_EL2.
> We implement ACTLR_EL2 as RAZ/WI, so make HACTLR2 also RAZ/WI.
> (We put the regdef next to ACTLR_EL2 as a reminder in case we
> ever make ACTLR_EL2 something other than RAZ/WI).
Putting thi
On Wed, Aug 15, 2018 at 01:37:04PM +0200, Markus Armbruster wrote:
> Peter Xu writes:
>
> > Replace existing trace_vtd_err() with error_report_once() then stderr
> > will capture something if any of the error happens, meanwhile we don't
> > suffer from any DDOS. Then remove the trace point. Sin
Thomas Huth writes:
> Certain device introspection crashes used to only happen if you were
> using a certain machine, e.g. if the machine was using serial_hd() or
> nd_table[], and a device was trying to use these in its instance_init
> function, too.
>
> To be able to catch these problems, let's
On 8/14/18 2:42 PM, Peter Maydell wrote:
> Implement the AArch32 HVBAR register; we can do this just by
> making the existing VBAR_EL2 regdefs be STATE_BOTH.
>
> Signed-off-by: Peter Maydell
Reviewed-By: Luc Michel
> ---
> target/arm/helper.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 d
On 14 August 2018 at 19:17, Peter Maydell wrote:
> First pullreq of the 3.1 release cycle, with lots of
> Arm related patches accumulated during freeze. Most
> notable here is Luc's GICv2 virtualization support and
> my execute-from-MMIO patches.
>
> I stopped looking at my to-review queue towards
Emanuele Giuseppe Esposito writes:
> Qgraph API for the qtest driver framework
>
> This series of patches introduce a different qtest driver
> organization, viewing machines, drivers and tests as node in a
> graph, each having one or multiple edges relations.
>
> The idea is to have a framework w
On Wed, Aug 15, 2018 at 06:22:51AM +0200, Markus Armbruster wrote:
>> My initial patch didn't have the offset. It was suggested by Eric
>> Blake in <0a960aa8-2a3f-8667-3d46-cecf8e65e...@redhat.com>:
>>
>> On Tue, Apr 10, 2018 at 04:33:03PM -0500, Eric Blake wrote:
>>> Do you additionally need an of
On Tue, 14 Aug 2018 12:02:06 +0200
Marc-André Lureau wrote:
> Hi
> On Mon, Aug 13, 2018 at 11:09 AM Igor Mammedov wrote:
> >
> > On Fri, 10 Aug 2018 17:32:23 +0200
> > Marc-André Lureau wrote:
> >
> > > This allows to pass the last failing test from the Windows HLK TPM 2.0
> > > TCG PPI 1.3 t
From: Alberto Garcia
In the throttling code after an I/O request has been completed the
next one is selected from a different member using a round-robin
algorithm. This ensures that all members get a chance to finish their
pending I/O requests.
However, if a group member has its I/O limits disab
For BlockBackends that are skipped in query-blockstats, we would leak
info since commit 567dcb31. Allocate info only later to avoid the memory
leak.
Fixes: CID 1394727
Cc: qemu-sta...@nongnu.org
Signed-off-by: Kevin Wolf
Reviewed-by: Alberto Garcia
---
block/qapi.c | 3 ++-
1 file changed, 2 in
From: Fam Zheng
Format drivers such as qcow2 don't allow sharing the same image between
two QEMU instances in order to prevent image corruptions, because of
metadata cache. LUKS driver don't modify metadata except for when
creating image, so it is safe to relax the permission. This makes
share-rw
From: Alberto Garcia
The previous patch fixes a problem in which draining a block device
with more than one throttled request can make it wait first for the
completion of requests in other members of the same group.
This patch updates test_remove_group_member() in iotest 093 to
reproduce that sc
The following changes since commit 38441756b70eec5807b5f60dad11a93a91199866:
Update version for v3.0.0 release (2018-08-14 16:38:43 +0100)
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-upstream
for you to fetch changes up to b5fc2d306664c0c1c6c5cf8e164ffa7
From: Alberto Garcia
A throttle group can have several members, and each one of them can
have several pending requests in the queue.
The requests are processed in a round-robin fashion, so the algorithm
decides the drive that is going to run the next request and sets a
timer in it. Once the time
blockdev-mirror with the same node for source and target segfaults
today: A node is in its own backing chain, so mirror_start_job() decides
that this is an active commit. When adding the intermediate nodes with
block_job_add_bdrv(), it starts the iteration through the subchain with
the backing file
This reinstates commit a7aff6dd10b16b67e8b142d0c94c5d92c3fe88f6,
which was temporarily reverted for the 3.0 release so that libvirt gets
some extra time to update their command lines.
The -drive options cyls, heads, secs and trans were deprecated in
QEMU 2.10. It's time to remove them.
hd-geo-tes
From: Alberto Garcia
Commit 6fccbb475bc6effc313ee9481726a1748b6dae57 fixed a bug caused by
QEMU attempting to remove a throttle group member with no pending
requests but an active timer set. This was the result of a previous
bdrv_drained_begin() call processing the throttled requests but
leaving
From: Daniel P. Berrangé
When the convert command is creating an output file that needs
secrets, we need to ensure those secrets are passed to both the
blk_new_open and bdrv_create API calls.
This is done by qemu-img extracting all opts matching the name
suffix "key-secret". Unfortunately the co
From: Vladimir Sementsov-Ogievskiy
.bdrv_close handler is optional after previous commit, no needs to keep
empty functions more.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Kevin Wolf
---
block/blkreplay.c| 5 -
block/commit.c | 5 -
block/copy-on-read.c | 6 -
From: Peter Krempa
Most of the various error classes were removed prior to the 1.2 release.
Remove mentions of the error classes which did not make it.
Signed-off-by: Peter Krempa
Signed-off-by: Kevin Wolf
---
qapi/block-core.json | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
dif
From: Alberto Garcia
If bdrv_reopen() succeeds then bs->explicit_options is updated with
the new values, but bs->options never changes.
Here's an example:
{ "execute": "blockdev-add",
"arguments": {
"driver": "qcow2",
"node-name": "hd0",
"overlap-check": "all",
This reinstates commit b0083267444a5e0f28391f6c2831a539f878d424,
which was temporarily reverted for the 3.0 release so that libvirt gets
some extra time to update their command lines.
The -drive option serial was deprecated in QEMU 2.10. It's time to
remove it.
Tests need to be updated to set the
From: Alberto Garcia
If a bdrv_reopen_multiple() call fails, then the explicit_options
QDict has to be deleted for every entry in the reopen queue. This must
happen regardless of whether that entry's bdrv_reopen_prepare() call
succeeded or not.
This patch simplifies the cleanup code a bit.
Sign
This reinstates commit eae3bd1eb7c6b105d30ec06008b3bc3dfc5f45bb,
which was temporarily reverted for the 3.0 release so that libvirt gets
some extra time to update their command lines.
The -drive option addr was deprecated in QEMU 2.10. It's time to remove
it.
Signed-off-by: Kevin Wolf
Reviewed-b
From: Alberto Garcia
When bdrv_open_inherit() opens a BlockDriverState the options QDict
can contain options for some of its children, passed in the form of
child-name.option=value
So while each child is opened with that subset of options, those same
options remain stored in the parent BDS, leav
blockdev-add fails if an invalid node name is given, so we should
document what a valid node name even is.
Reported-by: Cong Li
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
Reviewed-by: Cong Li
Reviewed-by: Alberto Garcia
---
qapi/block-core.json | 3 +++
1 file changed, 3 insertions(+)
From: Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Kevin Wolf
---
block.c | 4 +++-
block/snapshot.c | 4 +++-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/block.c b/block.c
index 39f373e035..9694018a68 100644
--- a/block.c
This reinstates commit 6266e900b8083945cb766b45c124fb3c42932cb3,
which was temporarily reverted for the 3.0 release so that libvirt gets
some extra time to update their command lines.
We removed all options from the 'deprecated' array, so the code is dead
and can be removed as well.
Signed-off-by
From: Alberto Garcia
This function extracts all options from a QDict starting with a
certain prefix and puts them in a new QDict.
We'll have a couple of cases where we simply want to discard those
options instead of copying them, and that's what this patch does.
Signed-off-by: Alberto Garcia
S
From: Alberto Garcia
This function returns a BDS's driver-specific options, excluding also
those from its children. Since we have just removed all children
options from bs->options there's no need to do this last step.
We allow references to children, though ("backing": "node0"), so those
we sti
On Fri, 10 Aug 2018 02:09:58 +0300
"Michael S. Tsirkin" wrote:
> On Thu, Aug 09, 2018 at 12:13:24PM +0200, Igor Mammedov wrote:
> > On Wed, 8 Aug 2018 23:20:25 +0300
> > "Michael S. Tsirkin" wrote:
> >
> > > On Wed, Aug 08, 2018 at 05:15:45PM +0200, Igor Mammedov wrote:
> > > > It's an alte
> I think perhaps all of your branching code, utilizing the existing expanders,
> needs a re-think.
We re-thought handling of nanoMIPS branch instructions, and a new approach will
be integrated in the next version.
We plan ()for nanoMIPS branches) not to rely on pre-nanoMIPS branch-related
fun
On Fri, 10 Aug 2018 02:01:00 +0300
"Michael S. Tsirkin" wrote:
> On Thu, Aug 09, 2018 at 12:00:11PM +0200, Igor Mammedov wrote:
> > On Wed, 8 Aug 2018 23:17:48 +0300
> > "Michael S. Tsirkin" wrote:
> >
> > > On Wed, Aug 08, 2018 at 05:15:48PM +0200, Igor Mammedov wrote:
> > > > Reuse CPU ho
Reuse CPU hotplug IO registers for passing a CST entry
containing package for shalowest C1 using mwait and
read it out in guest with new CCST AML method.
The CState support is optional and could be turned on
with '-global PIIX4_PM.cstate-count=X' CLI option.
Signed-off-by: Igor Mammedov
---
V2:
Eric Blake writes:
> On 08/13/2018 02:17 AM, Markus Armbruster wrote:
>> Eric Blake writes:
>>
>>> On 08/10/2018 08:28 AM, Eric Blake wrote:
Instead of using a raw assert, print the information in an
easier to understand way:
/i386/ahci/sanity: tests/libqtest.c:119: kill_qemu
On 06.08.2018 10:51, Thomas Huth wrote:
> On 07/28/2018 05:50 AM, Rebecca Cran wrote:
>> On 7/25/18 5:14 AM, Thomas Huth wrote:
>>
>>>
>>> Note that the error has been reported to happen on FreeBSD - so I doubt
>>> that this header should be here.
>>>
>>> Anyway, our include/standard-headers/linux
In the whole QAPI event emission code we're passing in an Error* object
along the whole stack. That's never useful since it never fails after
all. Remove that.
Then, remove that parameter from all the callers to send an event.
Suggested-by: Eric Blake
Suggested-by: Markus Armbruster
Signed-of
When we reach monitor_qmp_setup_handlers_bh() we must be using the
IOThread then, so no need to check against it any more. Instead, we
assert.
Reviewed-by: Markus Armbruster
Signed-off-by: Peter Xu
---
monitor.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/
Hi, Markus, Marc-Andre,
I didn't follow up the latest discussions on the response queue or
monitor changes. For now this series still makes sense to me, so I'm
just rebasing the series to master and repost (with some additional
changes/patches to address Markus's concerns). Please let me know if
This can help us to track QMP monitor flow controls.
Signed-off-by: Peter Xu
---
monitor.c| 8
trace-events | 4
2 files changed, 12 insertions(+)
diff --git a/monitor.c b/monitor.c
index 10ed853de9..b24a934437 100644
--- a/monitor.c
+++ b/monitor.c
@@ -376,6 +376,7 @@ static
From: Markus Armbruster
build_params() returns '' instead of 'void' when there are no
parameters. Can't happen now, but the next commit will change that.
Signed-off-by: Markus Armbruster
[peterx: compose the patch from email replies]
Signed-off-by: Peter Xu
---
scripts/qapi/common.py | 10 ++
It was put into the request object to show whether we'll need to resume
the monitor after dispatching the command. Now we move that into the
monitor struct so that it might be even used in other places in the
future, e.g., out-of-band message flow controls.
One thing to mention is that there is n
When we received too many qmp commands, previously we'll send
COMMAND_DROPPED events to monitors, then we'll drop the requests. It
can only solve the flow control of the request queue, however it'll not
really work since we might queue unlimited events in the response queue
which is a potential ri
Markus suggests that we should reduce special code paths for out-of-band
if possible, so that QMP logic can be simplified. Apply this rule to
two places where use_io_thread is used but not completely necessary.
Signed-off-by: Peter Xu
---
monitor.c | 33 +++--
1 file
On Wed, Aug 15, 2018 at 10:12:12AM +0200, Markus Armbruster wrote:
> Max Reitz writes:
>
> > On 2018-07-28 06:32, Jeff Cody wrote:
> >> On Wed, Jul 25, 2018 at 05:01:44PM +0100, Daniel P. Berrangé wrote:
> >>> On Wed, Jul 25, 2018 at 10:56:48AM -0500, Eric Blake wrote:
> On 07/25/2018 10:10
The "0.15" prefix seems useless. Remove them.
Signed-off-by: Peter Xu
---
tests/test-qmp-cmds.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tests/test-qmp-cmds.c b/tests/test-qmp-cmds.c
index ba41a6161e..989819b26d 100644
--- a/tests/test-qmp-cmds.c
+++ b/test
Now it was not used any more. Drop it, especially if we can do that
before we release QEMU 3.0.
Signed-off-by: Peter Xu
---
docs/interop/qmp-spec.txt | 5 +++--
qapi/misc.json| 40 ---
2 files changed, 3 insertions(+), 42 deletions(-)
diff --git
Before this patch we were only monitoring the request queue, but it's
still possible that a client only sends requests but it never eats any
reply from us. In that case our response queue might grow with
unlimited responses and put us at risk.
Now we play the similar trick as we have done to the
OOB commands were introduced in commit cf869d53172. Unfortunately, we
ran into a regression, and had to disable them by default for 2.12
(commit be933ffc23).
http://lists.gnu.org/archive/html/qemu-devel/2018-03/msg06231.html
The regression has since been fixed (commit 951702f39c7 "monitor: bin
On 08/15/2018 03:37 PM, Peter Xu wrote:
> The "0.15" prefix seems useless. Remove them.
>
> Signed-off-by: Peter Xu
> ---
> tests/test-qmp-cmds.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tests/test-qmp-cmds.c b/tests/test-qmp-cmds.c
> index ba41a6161e
I have run the openSUSE guest again, the output of the gdb command can
be seen at https://paste.ubuntu.com/p/mCRMvkNWYq/
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1787070
Title:
Guests using th
This reverts commit ddee57e0176f6ab53b13c6c97605b62737a8fd7a.
Meanwhile, revert one line from fa198ad9bdef to make sure
qtest_init_without_qmp_handshake() will only pass in one parameter.
Reviewed-by: Markus Armbruster
Signed-off-by: Peter Xu
---
tests/libqtest.c | 10 --
tests/libqtes
Straightforward test just to let the test-qmp-cmds be complete.
Signed-off-by: Peter Xu
---
tests/test-qmp-cmds.c | 16
1 file changed, 16 insertions(+)
diff --git a/tests/test-qmp-cmds.c b/tests/test-qmp-cmds.c
index 989819b26d..a51432f09d 100644
--- a/tests/test-qmp-cmds.c
++
1 - 100 of 193 matches
Mail list logo
