Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-25 Thread Shannon Zhao
Hi Hongbo, On 2018/7/25 13:30, Hongbo Zhang wrote: > For the Aarch64, there is one machine 'virt', it is primarily meant to > run on KVM and execute virtualization workloads, but we need an > environment as faithful as possible to physical hardware, for supporting > firmware and OS development for

Re: [Qemu-devel] RDMA wrongly detected as being supported on FreeBSD

2018-07-25 Thread Thomas Huth
On 25.07.2018 06:47, Rebecca Cran wrote: > In commit 18a398f6a39df4b08ff86ac0d38384193ca5f4cc, ./configure on > FreeBSD incorrectly detects RDMA support, with the build subsequently > failing with: > > /home/bcran/workspace/qemu/hw/rdma/vmw/pvrdma_cmd.c:19:10: fatal error: > 'linux/types.h' file n

[Qemu-devel] tb_flush during softreset

2018-07-25 Thread Sai Pavan Boddu
Hi, We are seeing issue when fetching tb cache, any suggestions for debug would be helpful. Issue: Post soft reset of the core, bootloader(running over different cpu) reloads the program memory and releases the reset. At that point CPU crashes after first tb cache fetch. Note: cpu's have mmu

Re: [Qemu-devel] [PATCH v3 3/5] qcow2: Introduce an option for sufficient L2 cache for the entire image

2018-07-25 Thread Kevin Wolf
Am 24.07.2018 um 22:03 hat Leonid Bloch geschrieben: > An option "l2-cache-full" is introduced to automatically set the qcow2 > L2 cache to a sufficient value for covering the entire image. The memory > overhead when using this option is not big (1 MB for each 8 GB of > virtual image size with the

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-25 Thread Hongbo Zhang
On 25 July 2018 at 15:20, Shannon Zhao wrote: > Hi Hongbo, > Hi Shannon, > On 2018/7/25 13:30, Hongbo Zhang wrote: >> For the Aarch64, there is one machine 'virt', it is primarily meant to >> run on KVM and execute virtualization workloads, but we need an >> environment as faithful as possible to

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-25 Thread Daniel P . Berrangé
On Wed, Jul 25, 2018 at 01:30:52PM +0800, Hongbo Zhang wrote: > For the Aarch64, there is one machine 'virt', it is primarily meant to > run on KVM and execute virtualization workloads, but we need an > environment as faithful as possible to physical hardware, for supporting > firmware and OS devel

Re: [Qemu-devel] [PATCH v3 1/5 for-3.0] A grammar fix

2018-07-25 Thread Kevin Wolf
Am 24.07.2018 um 23:00 hat Eric Blake geschrieben: > On 07/24/2018 03:03 PM, Leonid Bloch wrote: > > Subject line is rather vague; at a bare minimum, mentioning 'qcow2:' might > be helpful. But the maintainer can improve that. My suggestion: > > qcow2: grammar fix for conflicting cache sizing Ho

[Qemu-devel] [PATCH v3 1/7] hw/arm: rename armv7m_load_kernel()

2018-07-25 Thread Stefan Hajnoczi
ARMv6-M and ARMv8-M need the same kernel loading functionality as ARMv7-M. Rename armv7m_load_kernel() to arm_m_profile_load_kernel() so it's clear that this function isn't specific to ARMv7-M. Signed-off-by: Stefan Hajnoczi --- hw/arm/Makefile.objs| 1 + include/hw/arm/arm.h

[Qemu-devel] [PATCH v3 3/7] hw/arm: make bitbanded IO optional on ARM M Profile

2018-07-25 Thread Stefan Hajnoczi
Some ARM CPUs have bitbanded IO, a memory region that allows convenient bit access via 32-bit memory loads/stores. This eliminates the need for read-modify-update instruction sequences. This patch makes this optional feature a ARMMProfile qdev property, allowing boards to choose whether they want

[Qemu-devel] [PATCH v3 0/7] arm: add Cortex M0 CPU model and hex file loader

2018-07-25 Thread Stefan Hajnoczi
v3: * Rename ARMv7MState to ARMMProfileState so a single class can cater for ARMv6-M, ARMv7-M, and ARMv8-M [Peter] * Make bitbanding optional via a qdev property [Peter] * Add hex file loader patches to reduce dependencies in upcoming patch series * Implement rollback if hex file loader fail

[Qemu-devel] [PATCH v3 4/7] target/arm: add "cortex-m0" CPU model

2018-07-25 Thread Stefan Hajnoczi
Define a "cortex-m0" ARMv6-M CPU model. Most of the register reset values set by other CPU models are not relevant for the cut-down ARMv6-M architecture. Signed-off-by: Stefan Hajnoczi --- target/arm/cpu.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/target/arm/cpu.c b/targe

[Qemu-devel] [PATCH v3 5/7] loader: add rom transaction API

2018-07-25 Thread Stefan Hajnoczi
Image file loaders may add a series of roms. If an error occurs partway through loading there is no easy way to drop previously added roms. This patch adds a transaction mechanism that works like this: rom_transaction_begin(); ...call rom_add_*()... rom_transaction_end(ok); If ok is false

[Qemu-devel] [PATCH v3 6/7] loader: Implement .hex file loader

2018-07-25 Thread Stefan Hajnoczi
From: Su Hang This patch adds Intel Hexadecimal Object File format support to the loader. The file format specification is available here: http://www.piclist.com/techref/fileext/hex/intel.htm This file format is often used with microcontrollers such as the micro:bit, Arduino, STM32, etc. Users

[Qemu-devel] [PATCH v3 2/7] hw/arm: rename TYPE_ARMV7M to TYPE_ARM_M_PROFILE

2018-07-25 Thread Stefan Hajnoczi
The TYPE_ARMV7M class is really a container for an ARM M Profile CPU, NVIC, and related pieces. It can also be used for ARMv6-M and ARMv8-M. Rename the class since it is not exclusive to ARMv7-M. Signed-off-by: Stefan Hajnoczi --- hw/arm/Makefile.objs | 1 - include/hw

[Qemu-devel] [PATCH v3 7/7] Add QTest testcase for the Intel Hexadecimal

2018-07-25 Thread Stefan Hajnoczi
From: Su Hang 'test.hex' file is a bare metal ARM software stored in Hexadecimal Object Format. When it's loaded by QEMU, it will print "Hello world!\n" on console. `pre_store` array in 'hexloader-test.c' file, stores the binary format of 'test.hex' file, which is used to verify correctness. Re

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-25 Thread Hongbo Zhang
On 25 July 2018 at 16:48, Daniel P. Berrangé wrote: > On Wed, Jul 25, 2018 at 01:30:52PM +0800, Hongbo Zhang wrote: >> For the Aarch64, there is one machine 'virt', it is primarily meant to >> run on KVM and execute virtualization workloads, but we need an >> environment as faithful as possible to

Re: [Qemu-devel] [PATCH v2 1/2] hw/arm: check fw_cfg return value before using it

2018-07-25 Thread Peter Maydell
On 25 July 2018 at 06:30, Hongbo Zhang wrote: > The fw_cfg value returned from fw_cfg_find() may be NULL, so check it > before using. > > Signed-off-by: Hongbo Zhang Hi -- this patch series seems to be missing its cover letter. Please could you include a cover letter for any patchset with more t

Re: [Qemu-devel] [PATCH v3 1/5 for-3.0] A grammar fix

2018-07-25 Thread Leonid Bloch
On 07/25/2018 11:49 AM, Kevin Wolf wrote: Am 24.07.2018 um 23:00 hat Eric Blake geschrieben: On 07/24/2018 03:03 PM, Leonid Bloch wrote: Subject line is rather vague; at a bare minimum, mentioning 'qcow2:' might be helpful. But the maintainer can improve that. My suggestion: qcow2: grammar f

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-25 Thread Ard Biesheuvel
On 25 July 2018 at 10:48, Daniel P. Berrangé wrote: > On Wed, Jul 25, 2018 at 01:30:52PM +0800, Hongbo Zhang wrote: >> For the Aarch64, there is one machine 'virt', it is primarily meant to >> run on KVM and execute virtualization workloads, but we need an >> environment as faithful as possible to

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-25 Thread Hongbo Zhang
On 25 July 2018 at 17:01, Ard Biesheuvel wrote: > On 25 July 2018 at 10:48, Daniel P. Berrangé wrote: >> On Wed, Jul 25, 2018 at 01:30:52PM +0800, Hongbo Zhang wrote: >>> For the Aarch64, there is one machine 'virt', it is primarily meant to >>> run on KVM and execute virtualization workloads, bu

Re: [Qemu-devel] [PATCH v3 0/7] arm: add Cortex M0 CPU model and hex file loader

2018-07-25 Thread Stefan Hajnoczi
Based-on: https://git.linaro.org/people/pmaydell/qemu-arm.git target-arm.for-3.1

[Qemu-devel] [PATCH v1] s390x/cpu_models: Add "-cpu max" support

2018-07-25 Thread David Hildenbrand
The "max" CPU model behaves like "-cpu host" when KVM is enabled, and like a CPU with the maximum possible feature set when TCG is enabled. While the "host" model can not be used under TCG ("kvm_required"), the "max" model can and "Enables all features supported by the accelerator in the current h

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-25 Thread Ard Biesheuvel
On 25 July 2018 at 11:09, Hongbo Zhang wrote: > On 25 July 2018 at 17:01, Ard Biesheuvel wrote: >> On 25 July 2018 at 10:48, Daniel P. Berrangé wrote: >>> On Wed, Jul 25, 2018 at 01:30:52PM +0800, Hongbo Zhang wrote: For the Aarch64, there is one machine 'virt', it is primarily meant to >>>

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-25 Thread Hongbo Zhang
On 25 July 2018 at 17:13, Ard Biesheuvel wrote: > On 25 July 2018 at 11:09, Hongbo Zhang wrote: >> On 25 July 2018 at 17:01, Ard Biesheuvel wrote: >>> On 25 July 2018 at 10:48, Daniel P. Berrangé wrote: On Wed, Jul 25, 2018 at 01:30:52PM +0800, Hongbo Zhang wrote: > For the Aarch64, th

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-25 Thread Daniel P . Berrangé
On Wed, Jul 25, 2018 at 05:05:06PM +0800, Hongbo Zhang wrote: > On 25 July 2018 at 16:48, Daniel P. Berrangé wrote: > > On Wed, Jul 25, 2018 at 01:30:52PM +0800, Hongbo Zhang wrote: > >> For the Aarch64, there is one machine 'virt', it is primarily meant to > >> run on KVM and execute virtualizati

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-25 Thread Ard Biesheuvel
On 25 July 2018 at 11:17, Hongbo Zhang wrote: > On 25 July 2018 at 17:13, Ard Biesheuvel wrote: >> On 25 July 2018 at 11:09, Hongbo Zhang wrote: >>> On 25 July 2018 at 17:01, Ard Biesheuvel wrote: On 25 July 2018 at 10:48, Daniel P. Berrangé wrote: > On Wed, Jul 25, 2018 at 01:30:52PM

Re: [Qemu-devel] [PATCH] qstring: Fix qstring_from_substr() not to provoke int overflow

2018-07-25 Thread Markus Armbruster
liujunjie writes: > qstring_from_substr() parameters @start and @end are of type int. > blkdebug_parse_filename(), blkverify_parse_filename(), nbd_parse_uri(), > and qstring_from_str() pass @end values of type size_t or ptrdiff_t. > Values exceeding INT_MAX get truncated, with possibly disastrous

Re: [Qemu-devel] [PATCH v2 1/2] hw/arm: check fw_cfg return value before using it

2018-07-25 Thread Hongbo Zhang
On 25 July 2018 at 17:00, Peter Maydell wrote: > On 25 July 2018 at 06:30, Hongbo Zhang wrote: >> The fw_cfg value returned from fw_cfg_find() may be NULL, so check it >> before using. >> >> Signed-off-by: Hongbo Zhang > > Hi -- this patch series seems to be missing its cover letter. > Please co

[Qemu-devel] [PATCH 1/2] doc: switch to modern syntax for VNC TLS setup

2018-07-25 Thread Daniel P . Berrangé
The use of 'tls', 'x509' and 'x509verify' properties is the deprecated backcompat syntax, replaced by use of TLS creds objects. Signed-off-by: Daniel P. Berrangé --- qemu-doc.texi | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/qemu-doc.texi b/qemu-doc.t

[Qemu-devel] [PATCH 2/2] vnc: remove support for deprecated tls, x509, x509verify options

2018-07-25 Thread Daniel P . Berrangé
The 'tls-creds' option accepts the name of a TLS credentials object. This replaced the usage of 'tls', 'x509' and 'x509verify' options in 2.5.0. These deprecated options were grandfathered in when the deprecation policy was introduded in 2.10.0, so can now finally be removed. Signed-off-by: Daniel

[Qemu-devel] [PATCH 0/2] vnc: remove deprecated TLS related features

2018-07-25 Thread Daniel P . Berrangé
Daniel P. Berrangé (2): doc: switch to modern syntax for VNC TLS setup vnc: remove support for deprecated tls, x509, x509verify options qemu-deprecated.texi | 20 -- qemu-doc.texi| 20 +++--- qemu-options.hx | 43 - ui/vnc.c | 91 ---

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-25 Thread Andrew Jones
On Wed, Jul 25, 2018 at 11:20:03AM +0200, Ard Biesheuvel wrote: > On 25 July 2018 at 11:17, Hongbo Zhang wrote: > > On 25 July 2018 at 17:13, Ard Biesheuvel wrote: > >> On 25 July 2018 at 11:09, Hongbo Zhang wrote: > >>> On 25 July 2018 at 17:01, Ard Biesheuvel > >>> wrote: > On 25 July 2

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-25 Thread Hongbo Zhang
On 25 July 2018 at 17:18, Daniel P. Berrangé wrote: > On Wed, Jul 25, 2018 at 05:05:06PM +0800, Hongbo Zhang wrote: >> On 25 July 2018 at 16:48, Daniel P. Berrangé wrote: >> > On Wed, Jul 25, 2018 at 01:30:52PM +0800, Hongbo Zhang wrote: >> >> For the Aarch64, there is one machine 'virt', it is p

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-25 Thread Ard Biesheuvel
On 25 July 2018 at 11:40, Andrew Jones wrote: > On Wed, Jul 25, 2018 at 11:20:03AM +0200, Ard Biesheuvel wrote: >> On 25 July 2018 at 11:17, Hongbo Zhang wrote: >> > On 25 July 2018 at 17:13, Ard Biesheuvel wrote: >> >> On 25 July 2018 at 11:09, Hongbo Zhang wrote: >> >>> On 25 July 2018 at 17:

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-25 Thread Andrew Jones
On Wed, Jul 25, 2018 at 01:30:52PM +0800, Hongbo Zhang wrote: > For the Aarch64, there is one machine 'virt', it is primarily meant to > run on KVM and execute virtualization workloads, but we need an > environment as faithful as possible to physical hardware, for supporting > firmware and OS devel

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-25 Thread Andrew Jones
On Wed, Jul 25, 2018 at 11:47:39AM +0200, Ard Biesheuvel wrote: > On 25 July 2018 at 11:40, Andrew Jones wrote: > > On Wed, Jul 25, 2018 at 11:20:03AM +0200, Ard Biesheuvel wrote: > >> On 25 July 2018 at 11:17, Hongbo Zhang wrote: > >> > On 25 July 2018 at 17:13, Ard Biesheuvel > >> > wrote: >

Re: [Qemu-devel] [PATCH v0 0/7] Background snapshots

2018-07-25 Thread Peter Xu
On Fri, Jun 29, 2018 at 12:53:59PM +0100, Dr. David Alan Gilbert wrote: > * Denis Plotnikov (dplotni...@virtuozzo.com) wrote: > > The patch set adds the ability to make external snapshots while VM is > > running. > > cc'ing in Andrea since this uses sigsegv's to avoid userfault-wp that > isn't th

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-25 Thread Hongbo Zhang
On 25 July 2018 at 17:54, Andrew Jones wrote: > On Wed, Jul 25, 2018 at 01:30:52PM +0800, Hongbo Zhang wrote: >> For the Aarch64, there is one machine 'virt', it is primarily meant to >> run on KVM and execute virtualization workloads, but we need an >> environment as faithful as possible to physi

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-25 Thread Hongbo Zhang
On 25 July 2018 at 17:40, Andrew Jones wrote: > On Wed, Jul 25, 2018 at 11:20:03AM +0200, Ard Biesheuvel wrote: >> On 25 July 2018 at 11:17, Hongbo Zhang wrote: >> > On 25 July 2018 at 17:13, Ard Biesheuvel wrote: >> >> On 25 July 2018 at 11:09, Hongbo Zhang wrote: >> >>> On 25 July 2018 at 17:

Re: [Qemu-devel] VCPU hotplug on KVM/ARM

2018-07-25 Thread Marc Zyngier
On 24/07/18 19:35, Maran Wilson wrote: > It's been a few months since this email thread died off. Has anyone > started working on a potential solution that would allow VCPU hotplug on > KVM/ARM ? Or is this a project that is still waiting for an owner who > has the time and inclination to get st

Re: [Qemu-devel] [PATCH 1/2] seccomp: use SIGSYS signal instead of killing the thread

2018-07-25 Thread Eduardo Otubo
On 20/07/2018 - 17:00:39, Daniel P. Berrange wrote: > On Fri, Jul 20, 2018 at 05:44:24PM +0200, Marc-André Lureau wrote: > > The seccomp action SCMP_ACT_KILL results in immediate termination of > > the thread that made the bad system call. However, qemu being > > multi-threaded, it keeps running. T

Re: [Qemu-devel] [PATCH 2/2] RFC: seccomp: prefer SCMP_ACT_KILL_PROCESS if available

2018-07-25 Thread Eduardo Otubo
On 20/07/2018 - 17:44:25, Marc-André Lureau wrote: > The upcoming libseccomp release should have SCMP_ACT_KILL_PROCESS > action (https://github.com/seccomp/libseccomp/issues/96). > > SCMP_ACT_KILL_PROCESS is preferable to immediately terminate the > offending process, rather than having the SIGSYS

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-25 Thread Hongbo Zhang
On 25 July 2018 at 17:54, Andrew Jones wrote: > On Wed, Jul 25, 2018 at 01:30:52PM +0800, Hongbo Zhang wrote: >> For the Aarch64, there is one machine 'virt', it is primarily meant to >> run on KVM and execute virtualization workloads, but we need an >> environment as faithful as possible to physi

Re: [Qemu-devel] RDMA wrongly detected as being supported on FreeBSD

2018-07-25 Thread Marcel Apfelbaum
Hi, On 07/25/2018 10:32 AM, Thomas Huth wrote: On 25.07.2018 06:47, Rebecca Cran wrote: In commit 18a398f6a39df4b08ff86ac0d38384193ca5f4cc, ./configure on FreeBSD incorrectly detects RDMA support, configure is looking for the rdma related libraries,  if they are there, the rdma code will be c

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-25 Thread Dr. David Alan Gilbert
* Andrew Jones (drjo...@redhat.com) wrote: > On Wed, Jul 25, 2018 at 01:30:52PM +0800, Hongbo Zhang wrote: > > For the Aarch64, there is one machine 'virt', it is primarily meant to > > run on KVM and execute virtualization workloads, but we need an > > environment as faithful as possible to physic

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-25 Thread Dr. David Alan Gilbert
* Hongbo Zhang (hongbo.zh...@linaro.org) wrote: > On 25 July 2018 at 17:54, Andrew Jones wrote: > > On Wed, Jul 25, 2018 at 01:30:52PM +0800, Hongbo Zhang wrote: > >> For the Aarch64, there is one machine 'virt', it is primarily meant to > >> run on KVM and execute virtualization workloads, but we

Re: [Qemu-devel] RDMA wrongly detected as being supported on FreeBSD

2018-07-25 Thread Dr. David Alan Gilbert
* Marcel Apfelbaum (marcel.apfelb...@gmail.com) wrote: > Hi, > > On 07/25/2018 10:32 AM, Thomas Huth wrote: > > On 25.07.2018 06:47, Rebecca Cran wrote: > > > In commit 18a398f6a39df4b08ff86ac0d38384193ca5f4cc, ./configure on > > > FreeBSD incorrectly detects RDMA support, > > configure is lookin

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-25 Thread Andrew Jones
On Wed, Jul 25, 2018 at 06:33:01PM +0800, Hongbo Zhang wrote: > On 25 July 2018 at 17:40, Andrew Jones wrote: > > On Wed, Jul 25, 2018 at 11:20:03AM +0200, Ard Biesheuvel wrote: > >> On 25 July 2018 at 11:17, Hongbo Zhang wrote: > >> > On 25 July 2018 at 17:13, Ard Biesheuvel > >> > wrote: > >>

Re: [Qemu-devel] RDMA wrongly detected as being supported on FreeBSD

2018-07-25 Thread Thomas Huth
On 25.07.2018 12:48, Marcel Apfelbaum wrote: > Hi, > > On 07/25/2018 10:32 AM, Thomas Huth wrote: >> On 25.07.2018 06:47, Rebecca Cran wrote: >>> In commit 18a398f6a39df4b08ff86ac0d38384193ca5f4cc, ./configure on >>> FreeBSD incorrectly detects RDMA support, > > configure is looking for the rdma

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-25 Thread Andrew Jones
On Wed, Jul 25, 2018 at 06:22:17PM +0800, Hongbo Zhang wrote: > On 25 July 2018 at 17:54, Andrew Jones wrote: > > On Wed, Jul 25, 2018 at 01:30:52PM +0800, Hongbo Zhang wrote: > >> For the Aarch64, there is one machine 'virt', it is primarily meant to > >> run on KVM and execute virtualization wor

[Qemu-devel] [PATCH] hw/arm/sysbus-fdt: Fix assertion in copy_properties_from_host()

2018-07-25 Thread Geert Uytterhoeven
When copy_properties_from_host() ignores the error for an optional property, it frees the error, but fails to reset it. Hence if two or more optional properties are missing, an assertion is triggered: util/error.c:57: error_setv: Assertion `*errp == NULL' failed. Fis this by resetting err to

Re: [Qemu-devel] [PATCH v1] s390x/cpu_models: Add "-cpu max" support

2018-07-25 Thread Cornelia Huck
On Wed, 25 Jul 2018 11:12:33 +0200 David Hildenbrand wrote: > The "max" CPU model behaves like "-cpu host" when KVM is enabled, and like > a CPU with the maximum possible feature set when TCG is enabled. > > While the "host" model can not be used under TCG ("kvm_required"), the > "max" model can

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-25 Thread Andrew Jones
On Wed, Jul 25, 2018 at 11:50:41AM +0100, Dr. David Alan Gilbert wrote: > * Andrew Jones (drjo...@redhat.com) wrote: > > On Wed, Jul 25, 2018 at 01:30:52PM +0800, Hongbo Zhang wrote: > > > For the Aarch64, there is one machine 'virt', it is primarily meant to > > > run on KVM and execute virtualiza

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-25 Thread Andrew Jones
On Wed, Jul 25, 2018 at 06:46:59PM +0800, Hongbo Zhang wrote: > On 25 July 2018 at 17:54, Andrew Jones wrote: > > On Wed, Jul 25, 2018 at 01:30:52PM +0800, Hongbo Zhang wrote: > >> For the Aarch64, there is one machine 'virt', it is primarily meant to > >> run on KVM and execute virtualization wor

Re: [Qemu-devel] [PATCH v1] s390x/cpu_models: Add "-cpu max" support

2018-07-25 Thread David Hildenbrand
On 25.07.2018 13:36, Cornelia Huck wrote: > On Wed, 25 Jul 2018 11:12:33 +0200 > David Hildenbrand wrote: > >> The "max" CPU model behaves like "-cpu host" when KVM is enabled, and like >> a CPU with the maximum possible feature set when TCG is enabled. >> >> While the "host" model can not be use

Re: [Qemu-devel] [PATCH v1] s390x/cpu_models: Add "-cpu max" support

2018-07-25 Thread Cornelia Huck
On Wed, 25 Jul 2018 13:58:16 +0200 David Hildenbrand wrote: > On 25.07.2018 13:36, Cornelia Huck wrote: > > On Wed, 25 Jul 2018 11:12:33 +0200 > > David Hildenbrand wrote: > > > >> The "max" CPU model behaves like "-cpu host" when KVM is enabled, and like > >> a CPU with the maximum possible

[Qemu-devel] [PATCH v5 00/24] Fixing record/replay and adding reverse debugging

2018-07-25 Thread Pavel Dovgalyuk
GDB remote protocol supports reverse debugging of the targets. It includes 'reverse step' and 'reverse continue' operations. The first one finds the previous step of the execution, and the second one is intended to stop at the last breakpoint that would happen when the program is executed normally.

[Qemu-devel] [PATCH v5 01/24] block: implement bdrv_snapshot_goto for blkreplay

2018-07-25 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch enables making snapshots with blkreplay used in block devices. This function is required to make bdrv_snapshot_goto without calling .bdrv_open which is not implemented. Signed-off-by: Pavel Dovgalyuk --- block/blkreplay.c |8 1 file changed, 8 inse

[Qemu-devel] [PATCH v5 02/24] replay: disable default snapshot for record/replay

2018-07-25 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch disables setting '-snapshot' option on by default in record/replay mode. This is needed for creating vmstates in record and replay modes. Signed-off-by: Pavel Dovgalyuk --- vl.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/vl

[Qemu-devel] [PATCH v5 03/24] replay: update docs for record/replay with block devices

2018-07-25 Thread Pavel Dovgalyuk
This patch updates the description of the command lines for using record/replay with attached block devices. Signed-off-by: Pavel Dovgalyuk --- docs/replay.txt | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/docs/replay.txt b/docs/replay.txt index 2e21e9c..f7de

[Qemu-devel] [PATCH v5 04/24] replay: don't drain/flush bdrv queue while RR is working

2018-07-25 Thread Pavel Dovgalyuk
In record/replay mode bdrv queue is controlled by replay mechanism. It does not allow saving or loading the snapshots when bdrv queue is not empty. Stopping the VM is not blocked by nonempty queue, but flushing the queue is still impossible there, because it may cause deadlocks in replay mode. This

[Qemu-devel] [PATCH v5 05/24] replay: finish record/replay before closing the disks

2018-07-25 Thread Pavel Dovgalyuk
After recent updates block devices cannot be closed on qemu exit. This happens due to the block request polling when replay is not finished. Therefore now we stop execution recording before closing the block devices. Signed-off-by: Pavel Dovgalyuk --- replay/replay.c |2 ++ vl.c|

[Qemu-devel] [PATCH v5 13/24] replay: refine replay-time module

2018-07-25 Thread Pavel Dovgalyuk
This patch removes refactoring artifacts from the replay/replay-time.c Signed-off-by: Pavel Dovgalyuk --- replay/replay-time.c | 27 ++- 1 file changed, 10 insertions(+), 17 deletions(-) diff --git a/replay/replay-time.c b/replay/replay-time.c index 6a7565e..40030b8 10

[Qemu-devel] [PATCH v5 07/24] migration: introduce icount field for snapshots

2018-07-25 Thread Pavel Dovgalyuk
Saving icount as a parameters of the snapshot allows navigation between them in the execution replay scenario. This information can be used for finding a specific snapshot for rewinding the recorded execution to the specific moment of the time. E.g., 'reverse step' action needs to load the nearest

[Qemu-devel] [PATCH v5 06/24] qcow2: introduce icount field for snapshots

2018-07-25 Thread Pavel Dovgalyuk
This patch introduces the icount field for saving within the snapshot. It is required for navigation between the snapshots in record/replay mode. Signed-off-by: Pavel Dovgalyuk -- v2: - documented format changes in docs/interop/qcow2.txt (suggested by Eric Blake) --- block/qcow2-snapshot.c

[Qemu-devel] [PATCH v5 14/24] translator: fix breakpoint processing

2018-07-25 Thread Pavel Dovgalyuk
QEMU cannot pass through the breakpoints when 'si' command is used in remote gdb. This patch disables inserting the breakpoints when we are already single stepping though the gdb remote protocol. This patch also fixes icount calculation for the blocks that include breakpoints - instruction with bre

[Qemu-devel] [PATCH v5 10/24] replay: implement replay-seek command to proceed to the desired step

2018-07-25 Thread Pavel Dovgalyuk
This patch adds hmp/qmp commands replay_seek/replay-seek that proceed the execution to the specified step. The commands automatically loads nearest snapshot and replay the execution to find the desired step. Signed-off-by: Pavel Dovgalyuk -- v2: - renamed replay_seek qmp command into replay-se

[Qemu-devel] [PATCH v5 15/24] replay: flush rr queue before loading the vmstate

2018-07-25 Thread Pavel Dovgalyuk
Non-empty record/replay queue prevents saving and loading the VM state, because it includes pending bottom halves and block coroutines. But when the new VM state is loaded, we don't have to preserve the consistency of the current state anymore. Therefore this patch just flushes the queue allowing t

[Qemu-devel] [PATCH v5 08/24] replay: introduce info hmp/qmp command

2018-07-25 Thread Pavel Dovgalyuk
This patch introduces 'info replay' monitor command and corresponding qmp request. These commands request the current record/replay mode, replay log file name, and the execution step (number or recorded/replayed instructions). Signed-off-by: Pavel Dovgalyuk -- v2: - renamed info_replay qmp int

[Qemu-devel] [PATCH v5 19/24] replay: allow loading any snapshots before recording

2018-07-25 Thread Pavel Dovgalyuk
This patch enables using -loadvm in recording mode to allow starting the execution recording from any of the available snapshots. It also fixes loading of the record/replay state, therefore snapshots created in replay mode may also be used for starting the new recording. Signed-off-by: Pavel Dovga

[Qemu-devel] [PATCH v5 12/24] timer: remove replay clock probe in deadline calculation

2018-07-25 Thread Pavel Dovgalyuk
Ciro Santilli reported that commit a5ed352596a8b7eb2f9acce34371b944ac3056c4 breaks the execution replay. It happens due to the probing the clock for the new instances of iothread. However, this probing was made in replay mode for the timer lists that are empty. This patch removes clock probing in r

[Qemu-devel] [PATCH v5 18/24] replay: describe reverse debugging in docs/replay.txt

2018-07-25 Thread Pavel Dovgalyuk
This patch updates the documentation and describes usage of the reverse debugging in QEMU+GDB. Signed-off-by: Pavel Dovgalyuk --- docs/replay.txt | 33 + 1 file changed, 33 insertions(+) diff --git a/docs/replay.txt b/docs/replay.txt index f7def53..086d3f8 1006

[Qemu-devel] [PATCH v5 09/24] replay: introduce breakpoint at the specified step

2018-07-25 Thread Pavel Dovgalyuk
This patch introduces replay_break qmp and hmp commands. These commands allow stopping at the specified instruction. It may be useful for debugging when there are some known events that should be investigated. The commands have one argument - number of instructions executed since the start of the r

[Qemu-devel] [PATCH v5 16/24] gdbstub: add reverse step support in replay mode

2018-07-25 Thread Pavel Dovgalyuk
GDB remote protocol supports two reverse debugging commands: reverse step and reverse continue. This patch adds support of the first one to the gdbstub. Reverse step is intended to step one instruction in the backwards direction. This is not possible in regular execution. But replayed execution is

[Qemu-devel] [PATCH v5 22/24] replay: replay BH for IDE trim operation

2018-07-25 Thread Pavel Dovgalyuk
This patch makes IDE trim BH deterministic, because it affects the device state. Therefore its invocation should be replayed instead of running at the random moment. Signed-off-by: Pavel Dovgalyuk --- hw/ide/core.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/ide/c

Re: [Qemu-devel] [RFC v3] qemu: Add virtio pmem device

2018-07-25 Thread Eric Blake
On 07/25/2018 12:01 AM, Pankaj Gupta wrote: This patch has no n/M in the subject line; but is included in a thread that also has a 0/2 cover letter, as well as 1/2 and 2/2 patches in separate mails. Is that intentional? Yes, kernel series has 0-2 patches and Qemu has this one. I thought its

[Qemu-devel] [PATCH v5 20/24] ps2: prevent changing irq state on save and load

2018-07-25 Thread Pavel Dovgalyuk
Commit 2858ab09e6f708e381fc1a1cc87e747a690c4884 changed PS/2 keyboard/mouse buffers to the standard size. However, its state may change when migrating from the old buffer size and therefore irq needs updating. But this change made wrong, because it throws the whole queue if there are too much data

[Qemu-devel] [PATCH for-3.1 05/10] hw/s390x: Move virtio-ccw-rng code to a separate file

2018-07-25 Thread Thomas Huth
The code should only be enabled if CONFIG_VIRTIO_RNG has been set. This can be done best if the code resides in a separate file. Signed-off-by: Thomas Huth --- hw/s390x/Makefile.objs| 1 + hw/s390x/virtio-ccw-rng.c | 74 +++ hw/s390x/virtio-ccw.c

[Qemu-devel] [PATCH for-3.1 03/10] hw/s390x: Move virtio-ccw-balloon code to a separate file

2018-07-25 Thread Thomas Huth
The code should only be enabled if CONFIG_VIRTIO_BALLOON has been set. This can be done best if the code resides in a separate file. Signed-off-by: Thomas Huth --- hw/s390x/Makefile.objs| 1 + hw/s390x/virtio-ccw-balloon.c | 70 +++ hw/s390x/virti

[Qemu-devel] [PATCH v5 11/24] replay: flush events when exiting

2018-07-25 Thread Pavel Dovgalyuk
This patch adds events processing when emulation finishes instead of just cleaning the queue. Now the bdrv coroutines will be in consistent state when emulator closes. It allows correct polling of the block layer at exit. Signed-off-by: Pavel Dovgalyuk --- replay/replay-events.c | 14 +--

[Qemu-devel] [PATCH v5 21/24] replay: wake up vCPU when replaying

2018-07-25 Thread Pavel Dovgalyuk
In record/replay icount mode vCPU thread and iothread synchronize the execution using the checkpoints. vCPU thread processes the virtual timers and iothread processes all others. When iothread wants to wake up sleeping vCPU thread, it sends dummy queued work. Therefore it could be the following seq

[Qemu-devel] [PATCH for-3.1 08/10] hw/s390x: Move vhost-vsock-ccw code to a separate file

2018-07-25 Thread Thomas Huth
The code should only be enabled if CONFIG_VHOST_VSOCK has been set. This can be done best if the code resides in a separate file. Signed-off-by: Thomas Huth --- hw/s390x/Makefile.objs | 1 + hw/s390x/vhost-vsock-ccw.c | 60 ++ hw/s390x/virtio-ccw.

[Qemu-devel] [PATCH for-3.1 10/10] hw/s390x: Move virtio-ccw-input code to a separate file

2018-07-25 Thread Thomas Huth
The code should only be enabled if CONFIG_VIRTIO_INPUT has been set. This can be done best if the code resides in a separate file. Signed-off-by: Thomas Huth --- hw/s390x/Makefile.objs | 1 + hw/s390x/virtio-ccw-input.c | 118 hw/s390x/virtio-c

[Qemu-devel] [PATCH v5 17/24] gdbstub: add reverse continue support in replay mode

2018-07-25 Thread Pavel Dovgalyuk
This patch adds support of the reverse continue operation for gdbstub. Reverse continue finds the last breakpoint that would happen in normal execution from the beginning to the current moment. Implementation of the reverse continue replays the execution twice: to find the breakpoints that were hit

[Qemu-devel] [PATCH v5 24/24] slirp: fix ipv6 timers

2018-07-25 Thread Pavel Dovgalyuk
ICMP implementation for IPv6 uses timers based on virtual clock. This is incorrect because this service is not related to the guest state. This patch changes using virtual clock to the realtime. Signed-off-by: Pavel Dovgalyuk --- slirp/ip6_icmp.c |6 +++--- 1 file changed, 3 insertions(+), 3

Re: [Qemu-devel] [PATCH v5 22/24] replay: replay BH for IDE trim operation

2018-07-25 Thread Paolo Bonzini
On 25/07/2018 14:16, Pavel Dovgalyuk wrote: > This patch makes IDE trim BH deterministic, because it affects > the device state. Therefore its invocation should be replayed > instead of running at the random moment. > > Signed-off-by: Pavel Dovgalyuk > --- > hw/ide/core.c |3 ++- > 1 file ch

Re: [Qemu-devel] [PATCH v3 3/5] qcow2: Introduce an option for sufficient L2 cache for the entire image

2018-07-25 Thread Eric Blake
On 07/25/2018 03:26 AM, Kevin Wolf wrote: @@ -2840,6 +2845,7 @@ '*overlap-check': 'Qcow2OverlapChecks', '*cache-size': 'int', '*l2-cache-size': 'int', +'*l2-cache-full': 'bool', '*l2-cache-entry-size': 'int', '*ref

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-25 Thread Peter Maydell
On 25 July 2018 at 12:44, Andrew Jones wrote: > On Wed, Jul 25, 2018 at 06:46:59PM +0800, Hongbo Zhang wrote: >> For Armv7, there is one typical platform 'vexpress', but for Armv8, no > > Wasn't the vexpress model designed for a specific machine? Yes. > Namely for > Arm's simulator? No. > Is t

Re: [Qemu-devel] [PATCH hack dontapply v2 0/7] Dynamic _CST generation

2018-07-25 Thread Igor Mammedov
On Tue, 10 Jul 2018 03:01:30 +0300 "Michael S. Tsirkin" wrote: > Now that basic support for guest CPU PM is upstream, I started looking > for making it migrateable. Since a VM can be migrated between different > hosts, PM info needs to change each time with move the VM to a different > host. Con

[Qemu-devel] [PATCH v5 23/24] replay: add BH oneshot event for block layer

2018-07-25 Thread Pavel Dovgalyuk
Replay is capable of recording normal BH events, but sometimes there are single use callbacks scheduled with aio_bh_schedule_oneshot function. This patch enables recording and replaying such callbacks. Block layer uses these events for calling the completion function. Replaying these calls makes th

[Qemu-devel] [PATCH for-3.1 00/10] Move virtio-ccw devices to separate files

2018-07-25 Thread Thomas Huth
For more fine-grained control over the build process, it would be good to have the possibility to disable single virtio devices, too. We already have CONFIG_VIRTIO_* switches in the Makefiles, but currently all virtio-ccw devices are compiled in anyway. Move them to separate files so we can disable

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-07-25 Thread Ard Biesheuvel
On 25 July 2018 at 14:19, Peter Maydell wrote: > On 25 July 2018 at 12:44, Andrew Jones wrote: >> On Wed, Jul 25, 2018 at 06:46:59PM +0800, Hongbo Zhang wrote: >>> For Armv7, there is one typical platform 'vexpress', but for Armv8, no >> >> Wasn't the vexpress model designed for a specific machin

Re: [Qemu-devel] [PATCH hack dontapply v2 0/7] Dynamic _CST generation

2018-07-25 Thread Michael S. Tsirkin
On Wed, Jul 25, 2018 at 02:32:11PM +0200, Igor Mammedov wrote: > On Tue, 10 Jul 2018 03:01:30 +0300 > "Michael S. Tsirkin" wrote: > > > Now that basic support for guest CPU PM is upstream, I started looking > > for making it migrateable. Since a VM can be migrated between different > > hosts, PM

[Qemu-devel] [PATCH for-3.1 06/10] hw/s390x: Move virtio-ccw-9p code to a separate file

2018-07-25 Thread Thomas Huth
The code should only be enabled if CONFIG_VIRTIO_9P and CONFIG_VIRTFS have been set. This can be done best if the code resides in a separate file. Signed-off-by: Thomas Huth --- hw/s390x/Makefile.objs | 1 + hw/s390x/virtio-ccw-9p.c | 65 hw/s3

Re: [Qemu-devel] [PATCH v3 3/5] qcow2: Introduce an option for sufficient L2 cache for the entire image

2018-07-25 Thread Leonid Bloch
On 07/25/2018 03:22 PM, Eric Blake wrote: On 07/25/2018 03:26 AM, Kevin Wolf wrote: Only looking at the external interface for now, I wonder whether it would be nicer not to have two mutually exclusive options, but to make l2-cache-size an alternate that can take eithe

Re: [Qemu-devel] [RFC v3] qemu: Add virtio pmem device

2018-07-25 Thread Pankaj Gupta
> > >> > >> This patch has no n/M in the subject line; but is included in a thread > >> that also has a 0/2 cover letter, as well as 1/2 and 2/2 patches in > >> separate mails. Is that intentional? > > > > Yes, kernel series has 0-2 patches and Qemu has this one. I thought its > > good to ke

[Qemu-devel] [PATCH for-3.1 02/10] hw/s390x: Move virtio-ccw-serial code to a separate file

2018-07-25 Thread Thomas Huth
The code should only be enabled if CONFIG_VIRTIO_SERIAL has been set. This can be done best if the code resides in a separate file. Signed-off-by: Thomas Huth --- MAINTAINERS | 2 +- hw/s390x/Makefile.objs | 1 + hw/s390x/virtio-ccw-serial.c | 78

[Qemu-devel] [PATCH for-3.1 09/10] hw/s390x: Move virtio-ccw-gpu code to a separate file

2018-07-25 Thread Thomas Huth
The code should only be enabled if CONFIG_VIRTIO_GPU has been set. This can be done best if the code resides in a separate file. Signed-off-by: Thomas Huth --- hw/s390x/Makefile.objs| 1 + hw/s390x/virtio-ccw-gpu.c | 67 +++ hw/s390x/virtio-ccw.c

Re: [Qemu-devel] [PATCH hack dontapply v2 7/7] pc: HACK: acpi: tie in _CST object to Processor

2018-07-25 Thread Michael S. Tsirkin
On Wed, Jul 25, 2018 at 02:37:24PM +0200, Igor Mammedov wrote: > On Tue, 10 Jul 2018 03:01:34 +0300 > "Michael S. Tsirkin" wrote: > > > Based on patch by Igor Mammedov. > > > > This is a hack: we definitely shouldn't do it > > unconditionally, and initialization should be handled > > differently

[Qemu-devel] [PATCH for-3.1 01/10] hw/s390x/virtio-ccw: Consolidate calls to virtio_ccw_unrealize()

2018-07-25 Thread Thomas Huth
Currently, every virtio-ccw device explicitely sets its unrealize function to virtio_ccw_unrealize() in its class_init function. We can simplify this by using a common unrealize function, just like it is already done for the realize functions. Signed-off-by: Thomas Huth --- hw/s390x/virtio-ccw.c

  1   2   3   >