This bug was fixed in the package qemu - 1:2.12+dfsg-3ubuntu3
---
qemu (1:2.12+dfsg-3ubuntu3) cosmic; urgency=medium
* d/p/lp-1755912-qxl-fix-local-renderer-crash.patch: Fix an issue triggered
by migrations with UI frontends or frequent guest resolution changes
(LP: #1755912
On Wed, Jul 18, 2018 at 06:41:49PM +0300, Denis Plotnikov wrote:
> The VM ramblock list may be changed during the snapshotting.
> We want to make sure that we have the same ramblock list as it
> was at the time of snapshot beginning.
> So, we create a copy of the list at the beginning of the snapsh
On Wed, Jul 18, 2018 at 06:41:48PM +0300, Denis Plotnikov wrote:
> Signed-off-by: Denis Plotnikov
> ---
> include/exec/ram_addr.h | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/include/exec/ram_addr.h b/include/exec/ram_addr.h
> index 6cbc02aa0f..5b403d537d 100644
> --- a/includ
On 19.07.2018 19:25, Peter Maydell wrote:
On 19 July 2018 at 13:16, Julia Suvorova wrote:
The differences from ARMv7-M NVIC are:
* ARMv6-M only supports up to 32 external interrupts
(configurable feature already). The ICTR is reserved.
* Active Bit Register is reserved.
* ARMv6-M s
From: "Remy Noel"
When removing a secondary-vga device and then adding it back (or adding
an other one), qemu aborts with:
"RAMBlock ":00:02.0/vga.vram" already registered, abort!".
It is caused by the vram staying registered, preventing vga replugging.
Signed-off-by: Remy Noel
---
hw
On Thu, 07/19 13:57, John Snow wrote:
> Should we instead modify the test in this case to not attempt to take a
> lock on a device we know cannot meaningfully store state, or is it your
> preference to attempt to maintain such a list in the raw driver itself?
>
> I guess we never want QEMU to try
Check region type first before casting the memory region
to IOMMUMemoryRegion. Otherwise QEMU will abort with below
error message when casting non-IOMMU memory region:
vhost_iommu_region_add: Object 0x561f28bce4f0 is not an
instance of type qemu:iommu-memory-region
Fixes: cb1efcf462a2 ("iommu: Ad
Peter Xu wrote:
> I would guess it won't happen normally, but this should ease Coverity.
>
CID 1394385: Integer handling issues (OVERFLOW_BEFORE_WIDEN)
Potentially overflowing expression "pages->used * 8192U" with
type "unsigned int" (32 bits, unsigned) is evaluated using
On Wed, Jul 18, 2018 at 06:41:53PM +0300, Denis Plotnikov wrote:
> The background snapshot uses memeory page copying to seal the page
> memory content. The patch adapts the migration infrastructure to save
> copies of the pages.
Again, since previous page only defined some fields that are firstly
Marc-André Lureau writes:
> qobject_from_jsonv() returns a single object. Let's make sure that
> during parsing we don't leak an intermediary object. Instead of
> returning the last object, set a parsing error.
>
> Also, the lexer/parser keeps consuming all the data. There might be an
> error set
On 19 July 2018 at 17:25, Stefan Hajnoczi wrote:
> The following changes since commit ea6abffa8a08d832feb759d359d5b935e3087cf7:
>
> Update version for v3.0.0-rc1 release (2018-07-17 18:15:19 +0100)
>
> are available in the Git repository at:
>
> git://github.com/stefanha/qemu.git tags/tracing-
On 20 July 2018 at 02:22, Jia He wrote:
> Hi Peter。 Thanks for the comments
>
> On 7/19/2018 8:41 PM, Peter Maydell Wrote:
>> On 19 July 2018 at 04:11, Jia He wrote:
>>> In scripts/arch-run.bash of kvm-unit-tests, it will check the qemu
>>> output log with:
>>> if [ -z "$(echo "$errors" | grep -v
On 20 July 2018 at 09:09, Julia Suvorova wrote:
> On 19.07.2018 19:25, Peter Maydell wrote:
>>
>> On 19 July 2018 at 13:16, Julia Suvorova wrote:
>>>
>>> The differences from ARMv7-M NVIC are:
>>>* ARMv6-M only supports up to 32 external interrupts
>>> (configurable feature already). The
On 20 July 2018 at 09:36, Tiwei Bie wrote:
> Check region type first before casting the memory region
> to IOMMUMemoryRegion. Otherwise QEMU will abort with below
> error message when casting non-IOMMU memory region:
>
> vhost_iommu_region_add: Object 0x561f28bce4f0 is not an
> instance of type qe
On Wed, Jul 18, 2018 at 06:41:50PM +0300, Denis Plotnikov wrote:
> To limit the amount of memory used by the background snapshot
> a memory limiter is used which called "page buffer".
> In fact, it's a memory page counter limiting the page allocation.
> Currently, the limit of pages is hardcoded bu
On Wed, Jul 18, 2018 at 06:41:43PM +0300, Denis Plotnikov wrote:
> The workflow to make a snapshot is the following:
> 1. Pause the vm
> 2. Make a snapshot of block devices using the scheme of your choice
> 3. Turn on background-snapshot migration capability
> 4. Start the migration using the desti
On Wed, Jul 18, 2018 at 06:41:58PM +0300, Denis Plotnikov wrote:
> Is done with support of the KVM patch returning the faulting address.
>
> Signed-off-by: Denis Plotnikov
I feel like these two kvm-related patches can be put at the end of the
series as an extension to kvm support. E.g., without
On 20 July 2018 at 01:45, Jason Wang wrote:
> The following changes since commit 9f2b67e1ca43c84ed37ebd027e7e77a0f2f8ef65:
>
> Merge remote-tracking branch
> 'remotes/alistair/tags/pull-riscv-pull-20180719' into staging (2018-07-19
> 17:21:43 +0100)
>
> are available in the git repository at:
On 18/07/2018 17:41, Denis Plotnikov wrote:
> +static void ram_page_buffer_decrease_used(void)
> +{
> +qemu_event_reset(&ram_state->page_buffer.used_decreased);
> +atomic_dec(&ram_state->page_buffer.used);
> +qemu_event_set(&ram_state->page_buffer.used_decreased);
As Peter noted, only
Hi
On Fri, Jul 20, 2018 at 10:49 AM, Markus Armbruster wrote:
> Marc-André Lureau writes:
>
>> qobject_from_jsonv() returns a single object. Let's make sure that
>> during parsing we don't leak an intermediary object. Instead of
>> returning the last object, set a parsing error.
>>
>> Also, the
On 20 July 2018 at 05:03, Richard Henderson
wrote:
> Just one patch for rc2, fixing a bug with an aarch64 host
> emulating sve instructions.
>
>
> r~
>
>
> The following changes since commit e1ea55668ffe6ce558a063f3a9621b761738e1f2:
>
> Merge remote-tracking branch 'remotes/stefanha/tags/block-p
* Denis Plotnikov (dplotni...@virtuozzo.com) wrote:
> Signed-off-by: Denis Plotnikov
> ---
> migration/ram.c | 54 +
> migration/ram.h | 3 +++
> 2 files changed, 57 insertions(+)
>
> diff --git a/migration/ram.c b/migration/ram.c
> index 27d34034
On Wed, Jul 18, 2018 at 06:41:53PM +0300, Denis Plotnikov wrote:
[...]
> @@ -1003,13 +1008,18 @@ static int ram_save_page(RAMState *rs,
> PageSearchStatus *pss, bool last_stage)
> } else {
> pages = save_zero_page(rs, block, offset, p);
Now save_zero_page() is not called by ram_sa
On 2018/1/10 1:05, Halil Pasic wrote:
>
>
> On 12/30/2017 10:35 AM, Longpeng(Mike) wrote:
>> From: Gonglei
>>
>> The virtio crypto device is a virtual crypto device (ie. hardware
>> crypto accelerator card). Currently, the virtio crypto device provides
>> the following crypto services: CIPHE
> /*
> * virtio-balloon-pci: This extends VirtioPCIProxy.
> */
> diff --git a/hw/virtio/virtio-pmem.c b/hw/virtio/virtio-pmem.c
> new file mode 100644
> index 00..08c96d7e80
> --- /dev/null
> +++ b/hw/virtio/virtio-pmem.c
> @@ -0,0 +1,241
> > > > > +
> > > > > +typedef struct VirtIOPMEMresp {
> > > > > +int ret;
> > > > > +} VirtIOPMEMResp;
> > > > > +
> > > > > +typedef struct VirtIODeviceRequest {
> > > > > +VirtQueueElement elem;
> > > > > +int fd;
> > > > > +VirtIOPMEM *pmem;
> > > > > +VirtIOPMEMResp resp;
From: l00425170
The incoming parameters "start" and "end" is int type in
qstring_from_substr(), but this function can be called by
qstring_from_str, which is size_t type in strlen(str).
It may result in coredump when called g_malloc later.
One scene to triger is to call hmp "into tlb", which may
On 18 July 2018 at 14:22, Luc Michel wrote:
>
>
> On 07/17/2018 03:32 PM, Peter Maydell wrote:
>> On 14 July 2018 at 18:15, Luc Michel wrote:
>>> Implement virtualization extensions in the gic_deactivate_irq() and
>>> gic_complete_irq() functions. When a guest tries to deactivat or end an
>>
>>
> > From: Aleksandar Rikalo
> >
> > Signed-off-by: Aleksandar Markovic
> > Signed-off-by: Stefan Markovic
> > ---
> > linux-user/strace.c | 14 +-
> > linux-user/syscall.c | 25 +
> > 2 files changed, 38 insertions(+), 1 deletion(-)
If this patch gets a pro
Tailchaining is an optimization in handling of exception return
for M-profile cores: if we are about to pop the exception stack
for an exception return, but there is a pending exception which
is higher priority than the priority we are returning to, then
instead of unstacking and then immediately t
In do_v7m_exception_exit(), we use the exc_secure variable to track
whether the exception we're returning from is secure or non-secure.
Unfortunately the statement initializing this was accidentally
inside an "if (env->v7m.exception != ARMV7M_EXCP_NMI)" conditional,
which meant that we were using t
On exception return for M-profile, we must restore the CONTROL.SPSEL
bit from the EXCRET value before we do any kind of tailchaining,
including for the derived exceptions on integrity check failures.
Otherwise we will give the guest an incorrect EXCRET.SPSEL value on
exception entry for the tailcha
Improve the exception-taken logging by logging in
v7m_exception_taken() the exception we're going to take
and whether it is secure/nonsecure.
This requires us to move logging at many callsites from after the
call to before it, so that the logging appears in a sensible order.
(This will make tail-
Tailchaining is an optimization in handling of exception return
for M-profile cores: if we are about to pop the exception stack
for an exception return, but there is a pending exception which
is higher priority than the priority we are returning to, then
instead of unstacking and then immediately t
On 19 July 2018 at 14:15, Thomas Huth wrote:
> nand_init() does not only create the NAND device, it also realizes
> the device with qdev_init_nofail() already. So we must not call
> nand_init() from an instance_init function like sl_nand_init(),
> otherwise we get superfluous NAND devices in the Q
On 18 July 2018 at 07:10, Stefan Weil wrote:
> Those comments change often when ui/gtk.c is changed and are not
> really useful.
>
> Add also a new translation for German (still to be done for all other
> languages).
>
> Signed-off-by: Stefan Weil
> ---
I think I agree with Philippe that we shou
In kill_qemu() we have an assert that checks that the QEMU process
didn't dump core:
assert(!WCOREDUMP(wstatus));
Unfortunately the WCOREDUMP macro here means the resulting message
is not very easy to comprehend on at least some systems:
ahci-test: tests/libqtest.c:113: kill_qemu: Ass
I found this in one my branches: this is an updated version of what I sent
end of 2016 [1]. I tried to address all comments that Drew and Eric had at
the time.
Please have a look whether this makes sense.
Changelog v1..v2:
- made many functions void
- use symbolic name for first SPI being number 3
This adds an MMIO subtest to the GIC test.
It accesses some generic GICv2 registers and does some sanity tests,
like checking for some of them being read-only.
Signed-off-by: Andre Przywara
---
arm/gic.c | 91 +++
arm/unittests.cfg | 18
exit() and abort() are functions that never return, and (at least)
GCC has an attribute to flag those functions accordingly. This allows
the compiler to do further optimizations and to omit various warnings
about uninitialized variables, for instance.
Since the actual "play-dead" function is in (in
Some tests for the IPRIORITY registers. The significant number of bits
is IMPLEMENTATION DEFINED, but should be the same for every IRQ.
Also these registers must be byte-accessible.
Check that accesses beyond the implemented IRQ limit are actually
read-as-zero/write-ignore.
Signed-off-by: Andre Pr
Some tests for the ITARGETS registers.
Bits corresponding to non-existent CPUs must be RAZ/WI.
These registers must be byte-accessible, also check that accesses beyond
the implemented IRQ limit are actually read-as-zero/write-ignore.
Signed-off-by: Andre Przywara
---
arm/gic.c | 43 +
The upcoming libseccomp release should have SCMP_ACT_KILL_PROCESS
action (https://github.com/seccomp/libseccomp/issues/96).
SCMP_ACT_KILL_PROCESS is preferable to immediately terminate the
offending process, rather than having the SIGSYS handler running.
Use SECCOMP_GET_ACTION_AVAIL to check avai
On 20 July 2018 at 16:39, Andre Przywara wrote:
> I found this in one my branches: this is an updated version of what I sent
> end of 2016 [1]. I tried to address all comments that Drew and Eric had at
> the time.
> Please have a look whether this makes sense.
>
> Changelog v1..v2:
> - made many f
The seccomp action SCMP_ACT_KILL results in immediate termination of
the thread that made the bad system call. However, qemu being
multi-threaded, it keeps running. There is no easy way for parent
process / management layer (libvirt) to know about that situation.
Instead, the default SIGSYS handle
Hi,
The seccomp action SCMP_ACT_KILL results in immediate termination of
the thread that made the bad system call. However, qemu being
multi-threaded, it keeps running. There is no easy way for parent
process / management layer (libvirt) to know about that situation.
Instead, the default SIGSYS h
On 07/20/2018 12:39 PM, Peter Maydell wrote:
> In kill_qemu() we have an assert that checks that the QEMU process
> didn't dump core:
> assert(!WCOREDUMP(wstatus));
>
> Unfortunately the WCOREDUMP macro here means the resulting message
> is not very easy to comprehend on at least some
On 20 July 2018 at 16:48, Philippe Mathieu-Daudé wrote:
> On 07/20/2018 12:39 PM, Peter Maydell wrote:
>> In kill_qemu() we have an assert that checks that the QEMU process
>> didn't dump core:
>> assert(!WCOREDUMP(wstatus));
>>
>> Unfortunately the WCOREDUMP macro here means the resul
On Fri, Jul 20, 2018 at 05:44:24PM +0200, Marc-André Lureau wrote:
> The seccomp action SCMP_ACT_KILL results in immediate termination of
> the thread that made the bad system call. However, qemu being
> multi-threaded, it keeps running. There is no easy way for parent
> process / management layer
On 07/20/2018 08:49 AM, Peter Maydell wrote:
> On 20 July 2018 at 16:48, Philippe Mathieu-Daudé wrote:
>> On 07/20/2018 12:39 PM, Peter Maydell wrote:
>>> In kill_qemu() we have an assert that checks that the QEMU process
>>> didn't dump core:
>>> assert(!WCOREDUMP(wstatus));
>>>
>>> U
> From: Richard Henderson
> Sent: Thursday, July 19, 2018 9:13 PM
>
> > case NM_POOL32A7:
> > +{
> > +switch ((ctx->opcode >> 3) & 0x07) {
> > +case NM_POOL32AXF:
> > +gen_pool32axf_nanomips_insn(env, ctx);
> > +break;
> > +
On 07/20/2018 07:56 AM, Peter Maydell wrote:
> Improve the exception-taken logging by logging in
> v7m_exception_taken() the exception we're going to take
> and whether it is secure/nonsecure.
>
> This requires us to move logging at many callsites from after the
> call to before it, so that the lo
On 07/20/2018 07:56 AM, Peter Maydell wrote:
> In do_v7m_exception_exit(), we use the exc_secure variable to track
> whether the exception we're returning from is secure or non-secure.
> Unfortunately the statement initializing this was accidentally
> inside an "if (env->v7m.exception != ARMV7M_EXC
On 07/20/2018 07:56 AM, Peter Maydell wrote:
> On exception return for M-profile, we must restore the CONTROL.SPSEL
> bit from the EXCRET value before we do any kind of tailchaining,
> including for the derived exceptions on integrity check failures.
> Otherwise we will give the guest an incorrect
On 07/20/2018 07:56 AM, Peter Maydell wrote:
> Tailchaining is an optimization in handling of exception return
> for M-profile cores: if we are about to pop the exception stack
> for an exception return, but there is a pending exception which
> is higher priority than the priority we are returning
On 20 July 2018 at 17:14, Richard Henderson
wrote:
> You already print the file, just include the line. Perhaps
>
> fprintf(stderr,
> "%s:%d: kill_qemu tried to terminate QEMU "
> "process but it dumped core with signal %s\n",
> __FILE__, __LINE__, strsignal(WTERMS
On 07/19/2018 12:57 PM, John Snow wrote:
Should we instead modify the test in this case to not attempt to take a
lock on a device we know cannot meaningfully store state, or is it your
preference to attempt to maintain such a list in the raw driver itself?
I guess we never want QEMU to try to l
On 07/20/2018 03:24 AM, Fam Zheng wrote:
On Thu, 07/19 13:57, John Snow wrote:
Should we instead modify the test in this case to not attempt to take a
lock on a device we know cannot meaningfully store state, or is it your
preference to attempt to maintain such a list in the raw driver itself?
On 07/20/2018 09:25 AM, Peter Maydell wrote:
> On 20 July 2018 at 17:14, Richard Henderson
> wrote:
>> You already print the file, just include the line. Perhaps
>>
>> fprintf(stderr,
>> "%s:%d: kill_qemu tried to terminate QEMU "
>> "process but it dumped core with signal %
Hi,
This series failed docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 20180720083644.1431-1-tiwei@intel.com
Subject: [Qemu-devel] [PATCH] vhost: check regio
On 07/19/2018 11:39 AM, Collin Walling wrote:
On 07/19/2018 12:31 PM, Markus Armbruster wrote:
You neglected to cc: maintainers. Cc'ing them increases the odds your
patch will be noticed and picked up. You can use
scripts/get_maintainer.pl to find maintainers. You don't have to do
anything fo
On 20 July 2018 at 17:36, Richard Henderson
wrote:
> On 07/20/2018 09:25 AM, Peter Maydell wrote:
>> On 20 July 2018 at 17:14, Richard Henderson
>> wrote:
>>> You already print the file, just include the line. Perhaps
>>>
>>> fprintf(stderr,
>>> "%s:%d: kill_qemu tried to terminate Q
On 07/20/2018 09:45 AM, Peter Maydell wrote:
>> For non-linux, I peeked at the OpenBSD man page, which says
>>
>> The strsignal() function first appeared in AT&T System V
>> Release 4 UNIX and was reimplemented for NetBSD 1.0.
>>
>> That suggests all of the extant BSDs should have it.
>>
>> Min
* Collin Walling (wall...@linux.ibm.com) wrote:
> On 07/19/2018 03:18 PM, Dr. David Alan Gilbert wrote:
> > * Collin Walling (wall...@linux.ibm.com) wrote:
> >> When typing 'help' followed by an unknown command, QEMU will
> >> not print anything to the command line to let the user know
> >> they ty
On 07/20/2018 04:24 AM, Fam Zheng wrote:
> On Thu, 07/19 13:57, John Snow wrote:
>> Should we instead modify the test in this case to not attempt to take a
>> lock on a device we know cannot meaningfully store state, or is it your
>> preference to attempt to maintain such a list in the raw drive
I am seeing another issue pop up, in a different test. Even though it's
a different assertion, it might be related based on the call trace.
Stack trace of thread 276199:
#0 0x03ff8473e274 raise (libc.so.6)
#1 0x03ff847239a8 abort (libc.so.6)
#2 0x03ff847362ce __assert_fail_base (l
On 20.07.2018 [15:11:14 -0400], Farhan Ali wrote:
> I am seeing another issue pop up, in a different test. Even though it's a
> different assertion, it might be related based on the call trace.
Just to be clear, this does not happen if you revert the original patch
(i.e., the one you bisected to b
On 07/20/2018 12:40 PM, Eric Blake wrote:
> On 07/19/2018 11:39 AM, Collin Walling wrote:
>> On 07/19/2018 12:31 PM, Markus Armbruster wrote:
>>> You neglected to cc: maintainers. Cc'ing them increases the odds your
>>> patch will be noticed and picked up. You can use
>>> scripts/get_maintainer.p
When typing 'help' followed by an unknown command, QEMU will
not print anything to the command line to let the user know
they typed a bad command. Let's fix this by printing a message
to the monitor when this happens. For example:
(qemu) help xyz
unknown command: 'xyz'
Reported-by: Stefan
On 07/20/2018 03:32 PM, Nishanth Aravamudan wrote:
On 20.07.2018 [15:11:14 -0400], Farhan Ali wrote:
I am seeing another issue pop up, in a different test. Even though it's a
different assertion, it might be related based on the call trace.
Just to be clear, this does not happen if you reve
Hi,
On Thu, Jul 19, 2018 at 09:21:36AM +, linzhecheng wrote:
> Hi, all
> I found that qemu has a constraint in function numa_node_parse now:
> If (node->has_memdev != have_memdevs) {
> Error_setg(errp, "qemu: memdev option must be specified for either "
> "all
On Wed, Jul 18, 2018 at 07:36:28PM -0300, Philippe Mathieu-Daudé wrote:
> Both Python 2.7 and 3 support the same io.StringIO to
> handle unicode strings.
>
> Python 2.6 requires special care, but since 7f2b55443a his
> support was removed. Stop caring, drop the ImportError check.
>
> Use the comm
On 06/09/2018 10:32 AM, Vladimir Sementsov-Ogievskiy wrote:
To implement nbd reconnect in further patches, we need to distinguish
error codes, returned by nbd server, from channel errors, to reconnect
only in the latter case.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/nbd-client.c
On 07/09/2018 04:32 AM, Kevin Wolf wrote:
Am 06.07.2018 um 23:20 hat Eric Blake geschrieben:
On 07/06/2018 11:45 AM, Kevin Wolf wrote:
If the virtual disk size isn't aligned to full clusters,
bdrv_co_do_copy_on_readv() may get pnum == 0 before having the full
cluster completed, which will let i
On 07/10/2018 09:33 AM, Vladimir Sementsov-Ogievskiy wrote:
04.07.2018 14:23, Vladimir Sementsov-Ogievskiy wrote:
This is necessary for efficient block-status export, for clients which
support it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
+static int blockstatus_to_extents(BlockDriver
On 07/12/2018 03:32 PM, John Snow wrote:
+++ b/block/gluster.c
@@ -1326,7 +1326,7 @@ static int qemu_gluster_has_zero_init(BlockDriverState
*bs)
* If @start is in a trailing hole or beyond EOF, return -ENXIO.
* If we can't find out, return a negative errno other than -ENXIO.
*
- * (Sha
On 07/13/2018 06:14 AM, Max Reitz wrote:
Past the end of the source backing file, we memset() buf_old to zero, so
it is clearly easy to use blk_pwrite_zeroes() instead of blk_pwrite()
then.
Signed-off-by: Max Reitz
---
qemu-img.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions
Those comments change often when ui/gtk.c is changed and are not
really useful.
Signed-off-by: Stefan Weil
---
CC'ing all translators because of the new string which still needs
translations.
v2: Only automatically created content, no new German translation.
Regards
Stefan
po/Makefile|
The initiator can choose to cancel an ongoing request which
is specified by bRequest=0x64. If such a request arrives,
free up any pending state
Signed-off-by: Bandan Das
---
hw/usb/dev-mtp.c | 30 ++
1 file changed, 26 insertions(+), 4 deletions(-)
diff --git a/hw/us
To support larger file transfers, rely on a short packet
to detect end of the data phase and rewrite d->length to
the size received
Signed-off-by: Bandan Das
---
hw/usb/dev-mtp.c | 31 +++
1 file changed, 27 insertions(+), 4 deletions(-)
diff --git a/hw/usb/dev-mtp.c
For large buffers, write may not copy the full buffer. For example,
on Linux, write imposes a limit of 0x7000. Note that this does
not fix >4G transfers but ~>2G files will transfer successfully.
Signed-off-by: Bandan Das
---
hw/usb/dev-mtp.c | 22 --
1 file changed, 20 i
Patch 1 adds support for canceling an ongoing transaction.
2,3 and 4 fix writes for large transfers. For > 4G file transfers,
the logic has been modified to check for the end of the data phase
by checking for a short packet. Patch 5 renames x-root to a more
meaningful rootdir.
Bandan Das (5):
de
usb_mtp_realloc() was being incorrectly used when allocating
buffer for incoming data. Set d->length only after resizing
the buffer.
Signed-off-by: Bandan Das
---
hw/usb/dev-mtp.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index
x-root was renamed as such owing to the experimental nature of the
property; the underlying filesystem semantics were undecided
Signed-off-by: Bandan Das
---
hw/usb/dev-mtp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index 2e3ea58
On 07/20/2018 06:25 PM, Stefan Weil wrote:
> Those comments change often when ui/gtk.c is changed and are not
> really useful.
>
> Signed-off-by: Stefan Weil
Thanks for splitting this.
Reviewed-by: Philippe Mathieu-Daudé
> ---
>
> CC'ing all translators because of the new string which still
On 06/26/2018 09:50 AM, Vladimir Sementsov-Ogievskiy wrote:
> This patch aims to bring the following behavior:
Just as a primer for anyone else reading this email (nobody) who might
not understand the terminology (less than nobody), it might be helpful
to remember that:
-INACTIVATE occurs eithe
On Sat, Jul 21, 2018 at 12:35 AM Eric Blake wrote:
>
> On 07/20/2018 03:24 AM, Fam Zheng wrote:
> I'm not familiar with /dev/nullb* - is that a typo?
>
> $ ll /dev/nullb*
> ls: cannot access '/dev/nullb*': No such file or directory
You probably have figured out already but just in case: it's kern
From: Chen Hanxiao
This patch add support for freeze specified fs.
The valid mountpoints list member are [1]:
The path of a mounted folder, for example, Y:\MountX\
A drive letter, for example, D:\
A volume GUID path of the form \\?\Volume{GUID}\,
where GUID identifies the volume
A
88 matches
Mail list logo
