Re: [Qemu-devel] [PATCH 07/12] json-parser: always set an error if return NULL

2018-07-17 Thread Markus Armbruster
Marc-André Lureau writes: > Let's make json_parser_parse_err() suck less, and simplify caller > error handling. Missing: * monitor.c handle_qmp_command(): drop workaround > * qga/main.c process_event() doesn't need further changes after >previous cleanup. "Doesn't need further changes

Re: [Qemu-devel] [PATCH 08/12] json-lexer: make it safe to call multiple times

2018-07-17 Thread Markus Armbruster
Marc-André Lureau writes: > We can easily avoid the burden of checking if the lexer was > initialized prior to calling destroy by the caller, let's do it. > > This allows simplification in state tracking in later patches of the > qmp-async RFC series. > > Signed-off-by: Marc-André Lureau > --- >

Re: [Qemu-devel] [PATCH] Document command line options with single dash

2018-07-17 Thread Thomas Huth
On 16.07.2018 21:12, BALATON Zoltan wrote: > QEMU options have a single dash (but also work as double dash for > convenience and compatibility). Most options are listed with single > dash in command line help but some were listed with two dashes. > Normalize these to have the same format as the oth

Re: [Qemu-devel] [PATCH v8 5/5] PoC: tpm: add ACPI memory clear interface

2018-07-17 Thread Igor Mammedov
On Mon, 16 Jul 2018 14:59:48 +0200 Marc-André Lureau wrote: > This allows to pass the last failing test from the Windows HLK TPM 2.0 > TCG PPI 1.3 tests. > > The interface is described in the "TCG Platform Reset Attack > Mitigation Specification", chapter 6 "ACPI _DSM Function". According > to L

Re: [Qemu-devel] [PATCH 2/2] qga-win: fsinfo: pci-info: allow partial info

2018-07-17 Thread Sameeh Jubran
On Mon, Jul 16, 2018 at 11:04 PM, Michael Roth wrote: > Quoting Sameeh Jubran (2018-06-26 10:10:38) > > From: Sameeh Jubran > > > > The call to SetupDiGetDeviceRegistryProperty might fail because the > > value doesn't exist in the registry, in this case we shouldn't exit from > > the loop but in

Re: [Qemu-devel] [PATCH v8 2/5] tpm: implement virtual memory device for TPM PPI

2018-07-17 Thread Igor Mammedov
On Mon, 16 Jul 2018 16:56:36 +0200 Marc-André Lureau wrote: > Hi > > On Mon, Jul 16, 2018 at 4:44 PM, Igor Mammedov wrote: > > On Mon, 16 Jul 2018 14:59:45 +0200 > > Marc-André Lureau wrote: > > > >> From: Stefan Berger > >> > >> Implement a virtual memory device for the TPM Physical Presen

Re: [Qemu-devel] [PATCH 09/12] tests: add a few qemu-qmp tests

2018-07-17 Thread Markus Armbruster
Marc-André Lureau writes: > These 2 tests exhibited two qmp bugs that were fixed in 2.7 > (series from commit e64c75a9752c5d0fd64eb2e684c656a5ea7d03c6 to > commit 1382d4abdf9619985e4078e37e49e487cea9935e) > > Signed-off-by: Marc-André Lureau > --- > tests/qmp-test.c | 38 +++

Re: [Qemu-devel] [Qemu-block] [PATCH] throttle-groups: fix hang when group member leaves

2018-07-17 Thread Stefan Hajnoczi
On Wed, Jul 04, 2018 at 03:54:10PM +0100, Stefan Hajnoczi wrote: > Throttle groups consist of members sharing one throttling state > (including bps/iops limits). Round-robin scheduling is used to ensure > fairness. If a group member already has a timer pending then other > groups members do not s

Re: [Qemu-devel] [PULL 0/8] target-arm queue

2018-07-17 Thread Peter Maydell
On 16 July 2018 at 17:42, Peter Maydell wrote: > target-arm queue: a smallish set of patches for rc1 tomorrow. > I've included the tcg patches because RTH has no others that > would merit a pullreq. > > I haven't included Thomas Huth's 17-patch set to deal with > the introspection crashes, to give

Re: [Qemu-devel] [PATCH for 3.1 1/4] scsi/migration: Allow bus load request to fail

2018-07-17 Thread Cornelia Huck
On Mon, 16 Jul 2018 18:37:40 +0100 "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Allow the load_request method on a bus to fail and error > the migration cleanly. > > Signed-off-by: Dr. David Alan Gilbert > --- > hw/scsi/scsi-bus.c | 5 + > 1 file changed, 5

Re: [Qemu-devel] [PATCH for 3.1 2/4] virtio: Check qemu_get_virtqueue_element returns

2018-07-17 Thread Cornelia Huck
On Mon, 16 Jul 2018 18:37:41 +0100 "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Check calls to qemu_get_virtqueue_element for NULL and pass > up the chain. > > Signed-off-by: Dr. David Alan Gilbert > --- > hw/block/virtio-blk.c | 4 > hw/char/virtio-s

Re: [Qemu-devel] [PATCH for 3.1 3/4] virtio-scsi/migration: Allow load_request to fail

2018-07-17 Thread Cornelia Huck
On Mon, 16 Jul 2018 18:37:42 +0100 "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Rather than asserting, check values and return NULL > on failure. > > Signed-off-by: Dr. David Alan Gilbert > --- > hw/scsi/virtio-scsi.c | 15 --- > 1 file changed, 12 i

Re: [Qemu-devel] [PATCH for 3.1 4/4] virtio: qemu_get_virtqueue_element fail rather than assert

2018-07-17 Thread Cornelia Huck
On Mon, 16 Jul 2018 18:37:43 +0100 "Dr. David Alan Gilbert (git)" wrote: $SUBJECT reads a bit odd without a 'make', but it is already long... > From: "Dr. David Alan Gilbert" > > Make it return NULL rather than assert. > > Signed-off-by: Dr. David Alan Gilbert > --- > hw/virtio/virtio.c | 1

Re: [Qemu-devel] [PATCH 06/12] qga: process_event() simplification and leak fix

2018-07-17 Thread Marc-André Lureau
Hi On Tue, Jul 17, 2018 at 7:53 AM, Markus Armbruster wrote: > Marc-André Lureau writes: > >> json_parser_parse_err() may return something else than a QDict, in >> which case we loose the object. Let's keep track of the original >> object to avoid leaks. > > Should this leak fix go into 3.0? It

Re: [Qemu-devel] [PATCH] qga-win: Handle fstrim for OSes lower than Win8

2018-07-17 Thread Daniel P . Berrangé
On Mon, Jul 16, 2018 at 03:10:38PM -0500, Michael Roth wrote: > Quoting Sameeh Jubran (2018-06-24 07:45:40) > > From: Sameeh Jubran > > > > The defrag.exe tool which is used for executing the fstrim command > > on Windows doesn't support retrim for OSes lower than Win8. This > > commit handles th

Re: [Qemu-devel] [PATCH] Do not enable QOM debugging by default

2018-07-17 Thread Daniel P . Berrangé
On Mon, Jul 16, 2018 at 09:41:12PM +0100, Peter Maydell wrote: > On 16 July 2018 at 20:47, BALATON Zoltan wrote: > > Commit 3556c233d 5 years ago added an option to disable QOM debugging, > > noting that it can have high performance cost but left the default to on. > > Change the default to off an

[Qemu-devel] [Bug 1782107] [NEW] Random errors when emulating armv7 and using dh

2018-07-17 Thread Nadav Ruskin
Public bug reported: Howdy, I'm encountering random errors when using qemu to cross-package my project using dh. In previous iterations of my project it would only fail once every two attempts. Now it fails every time. Example error included. If you'd like to try and replicate this error, a v

Re: [Qemu-devel] [PULL for-3.0 0/2] qemu-ga patch queue for hard-freeze

2018-07-17 Thread Peter Maydell
On 16 July 2018 at 22:44, Michael Roth wrote: > The following changes since commit 102ad0a80f5110483efd06877c29c4236be267f9: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-misc-2018-07-16' > into staging (2018-07-16 15:34:38 +0100) > > are available in the git repository at: > > g

Re: [Qemu-devel] [PATCH 09/12] tests: add a few qemu-qmp tests

2018-07-17 Thread Marc-André Lureau
Hi On Tue, Jul 17, 2018 at 10:01 AM, Markus Armbruster wrote: > Marc-André Lureau writes: > >> These 2 tests exhibited two qmp bugs that were fixed in 2.7 >> (series from commit e64c75a9752c5d0fd64eb2e684c656a5ea7d03c6 to >> commit 1382d4abdf9619985e4078e37e49e487cea9935e) >> >> Signed-off-by: M

Re: [Qemu-devel] [PATCH v2 for 3.0 06/16] docker: move make check into check_qemu helper

2018-07-17 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 07/13/2018 09:17 AM, Alex Bennée wrote: >> Not all docker images can run the check step. Let's move everything >> into a common helper so we don't need to replicate checks in the >> future. >> >> Signed-off-by: Alex Bennée >> >> --- >> v2 >> - add "move" t

[Qemu-devel] [Bug 1782107] Re: Random errors when emulating armv7 and using dh

2018-07-17 Thread Peter Maydell
The ioctl warnings are I think for BTRFS_IOC_CLONE, which are probably harmless (the calling program ought to cope with it not working and fall back to something else). Which version of QEMU are you using ? (Unfortunately the log is not very revealing about what has gone wrong: it says "Running s

Re: [Qemu-devel] [RFC 10/15] s390-bios: Support for running format-0/1 channel programs

2018-07-17 Thread Cornelia Huck
On Fri, 6 Jul 2018 10:35:06 -0400 "Jason J. Herne" wrote: > On 07/06/2018 04:03 AM, Cornelia Huck wrote: > > On Thu, 5 Jul 2018 13:25:38 -0400 > > "Jason J. Herne" wrote: > >> +senseIdCcw.count = sizeof(senseData); > >> + > >> +if (do_cio(schid, ptr2u32(&senseIdCcw), CCW_FMT1)) { > >>

[Qemu-devel] [Bug 1755912] Re: qemu-system-x86_64 crashed with SIGABRT when using option -vga qxl

2018-07-17 Thread  Christian Ehrhardt 
Nice, thanks Leonardo for the Bisect - lets call upstream Fixed Committed then (as there is no 2.13 released yet). For the separate gl discussion feel free to subscribe/chime in on bug 1657409 Currently 2.12 is on its way into Cosmic. I'll add and test that patch afterwards, it looks small and sa

Re: [Qemu-devel] [PATCH v8 2/5] tpm: implement virtual memory device for TPM PPI

2018-07-17 Thread Igor Mammedov
On Mon, 16 Jul 2018 14:59:45 +0200 Marc-André Lureau wrote: > From: Stefan Berger > > Implement a virtual memory device for the TPM Physical Presence interface. > The memory is located at 0xFED45000 and used by ACPI to send messages to the > firmware (BIOS) and by the firmware to provide parame

[Qemu-devel] [PATCH v3] trace/simple: fix hang in child after fork(2)

2018-07-17 Thread Stefan Hajnoczi
The simple trace backend spawns a write-out thread which is used to asynchronously flush the in-memory ring buffer to disk. fork(2) does not clone all threads, only the thread that invoked fork(2). As a result there is no write-out thread in the child process! This causes a hang during shutdown

Re: [Qemu-devel] [PATCH v2 for 3.0 07/16] docker: gracefully skip check_qemu

2018-07-17 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 07/13/2018 09:17 AM, Alex Bennée wrote: >> Not all our images are able to run the tests. Rather than use features >> we can just check for the existence and run-ability of gtester. If the >> image has been setup for binfmt_misc it will be able to run anyway.

Re: [Qemu-devel] [PATCH v8 2/5] tpm: implement virtual memory device for TPM PPI

2018-07-17 Thread Marc-André Lureau
On Tue, Jul 17, 2018 at 9:59 AM, Igor Mammedov wrote: > On Mon, 16 Jul 2018 16:56:36 +0200 > Marc-André Lureau wrote: > >> Hi >> >> On Mon, Jul 16, 2018 at 4:44 PM, Igor Mammedov wrote: >> > On Mon, 16 Jul 2018 14:59:45 +0200 >> > Marc-André Lureau wrote: >> > >> >> From: Stefan Berger >> >> >

Re: [Qemu-devel] [PATCH for 3.1 2/4] virtio: Check qemu_get_virtqueue_element returns

2018-07-17 Thread Stefan Hajnoczi
On Mon, Jul 16, 2018 at 06:37:41PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Check calls to qemu_get_virtqueue_element for NULL and pass > up the chain. What happens to the device state that has been partially deserialized (e.g. virtio-blk's s->rq linked lis

Re: [Qemu-devel] [PATCH] opts: fix NULL pointer derefernce in get_opt_value

2018-07-17 Thread Paolo Bonzini
On 16/07/2018 20:47, Daniel P. Berrange wrote: > On Mon, Jul 16, 2018 at 06:41:46PM +0100, Mike Krinkin wrote: >> The value argument can be NULL, for example, in hw/i386/multiboot.c >> in the load_multiboot function get_opt_value is explicitly called >> with NULL as the second argument. >> >> The p

Re: [Qemu-devel] [PATCH v8 2/5] tpm: implement virtual memory device for TPM PPI

2018-07-17 Thread Marc-André Lureau
Hi On Tue, Jul 17, 2018 at 12:03 PM, Igor Mammedov wrote: > On Mon, 16 Jul 2018 14:59:45 +0200 > Marc-André Lureau wrote: > >> From: Stefan Berger >> >> Implement a virtual memory device for the TPM Physical Presence interface. >> The memory is located at 0xFED45000 and used by ACPI to send mes

Re: [Qemu-devel] [PATCH v2 for-2.11.2] spapr: make pseries-2.11 the default machine type

2018-07-17 Thread David Gibson
On Thu, Jun 21, 2018 at 03:23:21PM +0200, Greg Kurz wrote: > On Thu, 21 Jun 2018 11:18:09 +1000 > David Gibson wrote: > > > On Wed, Jun 20, 2018 at 02:54:15PM +0200, Greg Kurz wrote: > > > The spapr capability framework was introduced in QEMU 2.12. It allows > > > to have an explicit control on h

[Qemu-devel] [Bug 1587065] Re: btrfs qemu-ga - multiple mounts block fsfreeze

2018-07-17 Thread  Christian Ehrhardt 
Tests are all ok, MP review was acked and case confirmed. No Security Update since then in between, so sponsoring into SRU queue now ... -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1587065 Title:

Re: [Qemu-devel] [kvm-unit-tests PATCH 1/2] arm64: timer: add TVAL accessors

2018-07-17 Thread Andrew Jones
On Mon, Jul 16, 2018 at 04:14:37PM +0100, Andre Przywara wrote: > The ARM arch timer features the CVAL register, which holds an absolute > value that is compared against the counter value. > But there is also the TVAL register, which is defined as (CVAL - counter), > and can be used to program or r

Re: [Qemu-devel] [kvm-unit-tests PATCH 2/2] arm64: timer: Add TVAL timeout IRQ trigger test

2018-07-17 Thread Andrew Jones
On Mon, Jul 16, 2018 at 04:14:38PM +0100, Andre Przywara wrote: > So far we were only testing the CVAL register. Add a test which programs > a (relative) TVAL value to check this functionality as well. > Also we go into WFI and wait for the interrupt to release us from it. > The timer tests are run

Re: [Qemu-devel] [PATCH] Document command line options with single dash

2018-07-17 Thread Paolo Bonzini
On 17/07/2018 09:43, Thomas Huth wrote: > On 16.07.2018 21:12, BALATON Zoltan wrote: >> QEMU options have a single dash (but also work as double dash for >> convenience and compatibility). Most options are listed with single >> dash in command line help but some were listed with two dashes. >> Norm

[Qemu-devel] [PATCH 05/25] check: Only test ne2000 when it is compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index e9dd3e8928..ae77d26932 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -220,8 +220,8 @@ gcov-fi

[Qemu-devel] [PATCH 01/25] configure: We don't want to clean configuration files

2018-07-17 Thread Juan Quintela
If you don't want to compile everything, you configure config-devices.mak. And then make clean remove it, and make will create a default one without your configuration. Fix it by not removing it. Signed-off-by: Juan Quintela --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

[Qemu-devel] [PATCH 03/25] check: Use land/lor when possible

2018-07-17 Thread Juan Quintela
So everythig is (a bit) more consistent Signed-off-by: Juan Quintela --- tests/Makefile.include | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index a49282704e..47aea32193 100644 --- a/tests/Makefile.include +++ b/

[Qemu-devel] [PATCH 02/25] config: CONFIG_SERIAL* is already in pci.mak

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- default-configs/alpha-softmmu.mak | 2 -- default-configs/arm-softmmu.mak | 2 -- default-configs/hppa-softmmu.mak| 3 --- default-configs/i386-softmmu.mak| 2 -- default-configs/mips-softmmu-common.mak | 2 -- default-configs/ppc-sof

[Qemu-devel] [PATCH 00/25] Don't "check" disabled drivers

2018-07-17 Thread Juan Quintela
Hi We can disable drivers with "-softmmu/config-devices.mak". But if we remove drivers there and do "make check", we still try to test that devices (that are compiled in). This is a list with the removal of the ovbious ones. While I was doing this I fonund: - we remove -softmmu/config-devices.m

[Qemu-devel] [PATCH 04/25] check: Only test vmxnet3 when it is compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 47aea32193..e9dd3e8928 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -270,8 +270,8 @@ check-q

[Qemu-devel] [PATCH 07/25] check: Only test pcnet when it is compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/Makefile.include | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 560f486416..a039b70f9b 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -215,9 +215,9 @@ check

[Qemu-devel] [PATCH 08/25] check: Only test rtl8139 when it is compiled in

2018-07-17 Thread Juan Quintela
test-file-redirector uses rtl8139 in everything except s390. Signed-off-by: Juan Quintela --- tests/Makefile.include | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index a039b70f9b..c6156fe105 100644 --- a/tests/Makefil

[Qemu-devel] [PATCH 16/25] check: Only test sdhci when it is compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/Makefile.include | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index b0aa79909b..868a41986b 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -307,7 +307,7 @@ check

[Qemu-devel] [PATCH 06/25] check: Only test eepro100 when it is compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index ae77d26932..560f486416 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -218,8 +218,8 @@ gcov-fi

[Qemu-devel] [PATCH 10/25] check: Only test ac97 when it is compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 3d146310f0..af395b5f22 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -224,8 +224,8 @@ check-q

[Qemu-devel] [PATCH 11/25] check: Only test hda when it is compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index af395b5f22..691f853ab6 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -241,8 +241,8 @@ gcov-fi

[Qemu-devel] [PATCH 09/25] check: Only test es1370 when it is compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index c6156fe105..3d146310f0 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -226,8 +226,8 @@ check-q

[Qemu-devel] [PATCH 17/25] check: Only test wdt_ib700 when it is compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 868a41986b..f635517a68 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -265,9 +265,9 @@ check-q

[Qemu-devel] [PATCH 14/25] check: Only test ioh3420 when it is compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index a56d423303..3b555660bd 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -278,8 +278,8 @@ check-q

[Qemu-devel] [PATCH 12/25] check: Only test ipack when it is compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/Makefile.include | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 691f853ab6..5a3943c81c 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -230,10 +230,10 @@ c

[Qemu-devel] [PATCH 13/25] check: Only test isa-testdev when it is compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/Makefile.include | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 5a3943c81c..a56d423303 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -248,7 +2

[Qemu-devel] [PATCH 18/25] check: Only test pvpanic when it is compiled in

2018-07-17 Thread Juan Quintela
There was not possible to compile out pvpanic. Use the same trick that applesmc. Signed-off-by: Juan Quintela --- hw/misc/pvpanic.c | 11 --- include/hw/misc/pvpanic.h | 11 ++- tests/Makefile.include| 4 ++-- 3 files changed, 12 insertions(+), 14 deletions(-) diff

[Qemu-devel] [PATCH 15/25] check: Only test i82801b11 when it is compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 3b555660bd..b0aa79909b 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -276,8 +276,8 @@ gcov-fi

[Qemu-devel] [PATCH 20/25] check: Only test usb-xhci-nec when it is compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/Makefile.include | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index b3e707e8c3..ccf71bddcc 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -288,8 +288,8 @@ che

[Qemu-devel] [PATCH 19/25] check: Only test nvme when it is compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 31d124ee44..b3e707e8c3 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -222,8 +222,8 @@ check-q

[Qemu-devel] [PATCH 21/25] check: Only test usb-ohci when it is compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/Makefile.include | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index ccf71bddcc..3a78ada070 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -280,8 +280,8 @@ che

[Qemu-devel] [PATCH 25/25] check: Only test tpm devices when they are compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/Makefile.include | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 188f555600..0ac4b960bc 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -296,10 +296,10 @@ c

[Qemu-devel] [PATCH 22/25] check: Only test usb-uhci devices when they are compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/Makefile.include | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 3a78ada070..27f50e3231 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -282,8 +282,8 @@ che

Re: [Qemu-devel] [PATCH 16/25] check: Only test sdhci when it is compiled in

2018-07-17 Thread Thomas Huth
On 17.07.2018 13:33, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > tests/Makefile.include | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index b0aa79909b..868a41986b 100644 > --- a/tests/Makefile.incl

[Qemu-devel] [PATCH 23/25] check: Only test usb-ehci when it is compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 27f50e3231..731443387d 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -284,8 +284,8 @@ check-q

[Qemu-devel] [PATCH 24/25] check: Only test ivshm when it is compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/Makefile.include | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 731443387d..188f555600 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -243,8 +243,8 @@ gcov-

Re: [Qemu-devel] [PATCH 08/25] check: Only test rtl8139 when it is compiled in

2018-07-17 Thread Thomas Huth
On 17.07.2018 13:33, Juan Quintela wrote: > test-file-redirector uses rtl8139 in everything except s390. > > Signed-off-by: Juan Quintela > --- > tests/Makefile.include | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.inclu

Re: [Qemu-devel] [PATCH 10/25] check: Only test ac97 when it is compiled in

2018-07-17 Thread Thomas Huth
On 17.07.2018 13:33, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > tests/Makefile.include | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index 3d146310f0..af395b5f22 100644 > --- a/tests/Makefile.includ

Re: [Qemu-devel] [PATCH 04/25] check: Only test vmxnet3 when it is compiled in

2018-07-17 Thread Thomas Huth
On 17.07.2018 13:33, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > tests/Makefile.include | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index 47aea32193..e9dd3e8928 100644 > --- a/tests/Makefile.includ

Re: [Qemu-devel] [PATCH 17/25] check: Only test wdt_ib700 when it is compiled in

2018-07-17 Thread Thomas Huth
On 17.07.2018 13:33, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > tests/Makefile.include | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index 868a41986b..f635517a68 100644 > --- a/tests/Makefile.includ

Re: [Qemu-devel] [PATCH 09/25] check: Only test es1370 when it is compiled in

2018-07-17 Thread Thomas Huth
On 17.07.2018 13:33, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > tests/Makefile.include | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index c6156fe105..3d146310f0 100644 > --- a/tests/Makefile.includ

Re: [Qemu-devel] [PATCH 05/25] check: Only test ne2000 when it is compiled in

2018-07-17 Thread Thomas Huth
On 17.07.2018 13:33, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > tests/Makefile.include | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index e9dd3e8928..ae77d26932 100644 > --- a/tests/Makefile.includ

Re: [Qemu-devel] [PATCH 07/25] check: Only test pcnet when it is compiled in

2018-07-17 Thread Thomas Huth
On 17.07.2018 13:33, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > tests/Makefile.include | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index 560f486416..a039b70f9b 100644 > --- a/tests/Makefile.incl

Re: [Qemu-devel] [PATCH 06/25] check: Only test eepro100 when it is compiled in

2018-07-17 Thread Thomas Huth
On 17.07.2018 13:33, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > tests/Makefile.include | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index ae77d26932..560f486416 100644 > --- a/tests/Makefile.includ

Re: [Qemu-devel] [PATCH 11/25] check: Only test hda when it is compiled in

2018-07-17 Thread Thomas Huth
On 17.07.2018 13:33, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > tests/Makefile.include | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index af395b5f22..691f853ab6 100644 > --- a/tests/Makefile.includ

[Qemu-devel] [PATCH 02/14] check: Only test megasas when it is compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/Makefile.include | 4 ++-- tests/cdrom-test.c | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index bb1080ecb5..6565206a78 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.inc

[Qemu-devel] [RFC 00/14] More patches to disable stuff

2018-07-17 Thread Juan Quintela
Hi Notice that this is an RFC because they don't work. As said on my previous submmision, we need -softmmu/config-devices.h to make this work. This series just allow us to disable the devices, but not to enable it back O:-) Notice: - scsi stuff: we are testing they in cdrom-test.c, so we need

[Qemu-devel] [PATCH 03/14] check: Only test lsi when it is compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/cdrom-test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/cdrom-test.c b/tests/cdrom-test.c index 42c29524b8..bab2ecc306 100644 --- a/tests/cdrom-test.c +++ b/tests/cdrom-test.c @@ -140,9 +140,11 @@ static void add_x86_tests(void) qtest_a

[Qemu-devel] [PATCH 04/14] check: Only test esp when it is compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/cdrom-test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/cdrom-test.c b/tests/cdrom-test.c index bab2ecc306..0d7dff6da5 100644 --- a/tests/cdrom-test.c +++ b/tests/cdrom-test.c @@ -134,12 +134,14 @@ static void add_x86_tests(void)

[Qemu-devel] [PATCH 05/14] check: Only test sga when it is compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/boot-serial-test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/boot-serial-test.c b/tests/boot-serial-test.c index 952a2e7ead..3f7c46fdf7 100644 --- a/tests/boot-serial-test.c +++ b/tests/boot-serial-test.c @@ -87,11 +87,13 @@ static testdef_

[Qemu-devel] [PATCH 01/14] check: Only test ipmi when it is compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/Makefile.include | 4 ++-- tests/bios-tables-test.c | 4 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 0ac4b960bc..bb1080ecb5 100644 --- a/tests/Makefile.include +++ b/tests/Makefi

[Qemu-devel] [PATCH 09/14] check: Only test virtio-balloon when it is compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/virtio/virtio-pci.c | 5 - tests/Makefile.include | 6 +++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index 3a01fe90f0..bdbc7ab78d 100644 --- a/hw/virtio/virtio-pci.c +++ b/hw/virtio/vir

[Qemu-devel] [PATCH 08/14] check: Only test nvdim_acpi when it is compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/bios-tables-test.c | 4 1 file changed, 4 insertions(+) diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c index fd59c7f9a2..1de6e3d58c 100644 --- a/tests/bios-tables-test.c +++ b/tests/bios-tables-test.c @@ -825,6 +825,7 @@ static void t

[Qemu-devel] [PATCH 06/14] check: Only test usb smartcard when it is compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/usb-hcd-xhci-test.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/usb-hcd-xhci-test.c b/tests/usb-hcd-xhci-test.c index 5b1b681bf2..be80c5f032 100644 --- a/tests/usb-hcd-xhci-test.c +++ b/tests/usb-hcd-xhci-test.c @@ -35,6 +35

[Qemu-devel] [PATCH 13/14] check: Only test virtio-input when it is compiled in

2018-07-17 Thread Juan Quintela
The full of it. Introspection is able to search for drivers that you aren't there, so just disable it. Signed-off-by: Juan Quintela --- hw/virtio/virtio-pci.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index 75c96990c0..987d7c0a5a 100

[Qemu-devel] [PATCH 07/14] check: Only test usb storage when it is compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/Makefile.include| 2 +- tests/usb-hcd-uhci-test.c | 5 - tests/usb-hcd-xhci-test.c | 4 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 6565206a78..9193945c24 100644 --- a/test

[Qemu-devel] [PATCH 12/14] check: Only test virtio-gpu when it is compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/Makefile.include | 4 ++-- tests/display-vga-test.c | 4 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index a9cb5e926b..c4d68061e5 100644 --- a/tests/Makefile.include +++ b/tests/Makefi

Re: [Qemu-devel] [PATCH 0/9] monitor: enable OOB by default

2018-07-17 Thread Peter Xu
On Mon, Jul 16, 2018 at 07:18:28PM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > Based-on: <20180703085358.13941-1-arm...@redhat.com> > > Now in master. > > > This work is based on Markus's latest out-of-band fixes: > > "[PATCH v2 00/32] ] qmp: Fixes and cleanups around OOB command

Re: [Qemu-devel] [PATCH 14/25] check: Only test ioh3420 when it is compiled in

2018-07-17 Thread Thomas Huth
On 17.07.2018 13:33, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > tests/Makefile.include | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index a56d423303..3b555660bd 100644 > --- a/tests/Makefile.includ

[Qemu-devel] [PATCH 10/14] check: Only test virtio-serial when it is compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/Makefile.include | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index bb30c56795..7feda20577 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -204,10 +204,10 @@ c

Re: [Qemu-devel] [PATCH 12/25] check: Only test ipack when it is compiled in

2018-07-17 Thread Thomas Huth
On 17.07.2018 13:33, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > tests/Makefile.include | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index 691f853ab6..5a3943c81c 100644 > --- a/tests/Makefile.in

Re: [Qemu-devel] [PATCH 06/12] qga: process_event() simplification and leak fix

2018-07-17 Thread Markus Armbruster
Mike, I got a bug fix for you to consider for 3.0. Marc-André, there's one remark for you inline. Marc-André Lureau writes: > Hi > > On Tue, Jul 17, 2018 at 7:53 AM, Markus Armbruster wrote: >> Marc-André Lureau writes: >> >>> json_parser_parse_err() may return something else than a QDict, in

[Qemu-devel] [PATCH 11/14] check: Only test virtio-rng when it is compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/virtio/virtio-pci.c | 6 -- tests/Makefile.include | 4 ++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index bdbc7ab78d..75c96990c0 100644 --- a/hw/virtio/virtio-pci.c +++ b/hw/virtio/virt

Re: [Qemu-devel] [PATCH 13/25] check: Only test isa-testdev when it is compiled in

2018-07-17 Thread Thomas Huth
On 17.07.2018 13:33, Juan Quintela wrote: [...] > @@ -319,15 +319,15 @@ check-qtest-m68k-y = tests/boot-serial-test$(EXESUF) > > check-qtest-microblaze-y = tests/boot-serial-test$(EXESUF) > > -check-qtest-mips-y = tests/endianness-test$(EXESUF) > +check-qtest-mips-$(CONFIG_ISA_TESTDEV) = tests

[Qemu-devel] [PATCH 14/14] check: Only test virtio-scsi when it is compiled in

2018-07-17 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/Makefile.include | 4 ++-- tests/cdrom-test.c | 4 tests/drive_del-test.c | 6 ++ 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index c4d68061e5..74ee02348c 100644 --- a/tests/Mak

Re: [Qemu-devel] [PATCH 15/25] check: Only test i82801b11 when it is compiled in

2018-07-17 Thread Thomas Huth
On 17.07.2018 13:33, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > tests/Makefile.include | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index 3b555660bd..b0aa79909b 100644 > --- a/tests/Makefile.includ

Re: [Qemu-devel] [PATCH 09/14] check: Only test virtio-balloon when it is compiled in

2018-07-17 Thread Cornelia Huck
On Tue, 17 Jul 2018 14:04:09 +0200 Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > hw/virtio/virtio-pci.c | 5 - > tests/Makefile.include | 6 +++--- > 2 files changed, 7 insertions(+), 4 deletions(-) > > diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c > index 3a01

Re: [Qemu-devel] [PATCH v8 4/5] acpi: build TPM Physical Presence interface

2018-07-17 Thread Igor Mammedov
On Mon, 16 Jul 2018 14:59:47 +0200 Marc-André Lureau wrote: > From: Stefan Berger > > The TPM Physical Presence interface consists of an ACPI part, a shared > memory part, and code in the firmware. Users can send messages to the > firmware by writing a code into the shared memory through invoki

Re: [Qemu-devel] [PATCH v3 00/17] Fix crashes with introspection of ARM devices

2018-07-17 Thread Peter Maydell
On 16 July 2018 at 13:59, Thomas Huth wrote: > As discovered recently, you can crash QEMU with a lot of devices > that do not get the reference counting of child objects right. > You just have to run 'device-list-properties' and call 'info qtree' > afterwards. > This patch series fixes these probl

Re: [Qemu-devel] [RFC 00/14] More patches to disable stuff

2018-07-17 Thread Thomas Huth
On 17.07.2018 14:04, Juan Quintela wrote: > Hi > > Notice that this is an RFC because they don't work. As said on my > previous submmision, we need -softmmu/config-devices.h to make > this work. This series just allow us to disable the devices, but not > to enable it back O:-) > > Notice: > >

[Qemu-devel] [Bug 1782107] Re: Random errors when emulating armv7 and using dh

2018-07-17 Thread Nadav Ruskin
Thank you for the quick reply. Version: nadav@DESKTOP-4DUIS04:/mnt/c/Git/configsite$ dpkg -s qemu-user-static | grep Version Version: 1:2.11+dfsg-1ubuntu7.4 A log with verbose mode enabled is attached. ** Attachment added: "myerror3.txt" https://bugs.launchpad.net/qemu/+bug/1782107/+attach

Re: [Qemu-devel] [PATCH 18/25] check: Only test pvpanic when it is compiled in

2018-07-17 Thread Thomas Huth
On 17.07.2018 13:33, Juan Quintela wrote: > There was not possible to compile out pvpanic. Use the same trick > that applesmc. Either "It is not possible" or "There is no possibility" ? And that "that" in the second sentence also sounds wrong. Apart from that: Reviewed-by: Thomas Huth

Re: [Qemu-devel] [PATCH 01/25] configure: We don't want to clean configuration files

2018-07-17 Thread Daniel P . Berrangé
On Tue, Jul 17, 2018 at 01:33:38PM +0200, Juan Quintela wrote: > If you don't want to compile everything, you configure > config-devices.mak. And then make clean remove it, and make will > create a default one without your configuration. Fix it by not > removing it. > > Signed-off-by: Juan Quint

[Qemu-devel] [PATCH 1/3] char-socket: correctly set has_reconnect when parsing QemuOpts

2018-07-17 Thread Marc-André Lureau
qemu_chr_parse_socket() fills all ChardevSocket fields, but that doesn't reflect correctly the arguments given with the options / on the command line. "reconnect" takes a number as argument, and the default value is 0, which doesn't help to identify the missing option. The other arguments have defa

  1   2   3   >