Re: [Qemu-devel] [PATCH for 3.0 05/10] docker: move make check into check_qemu helper

2018-07-10 Thread Fam Zheng
On Mon, 07/09 16:21, Alex Bennée wrote: > Not all docker images can run the check step. Let's everything into a "move everything"? > common helper so we don't need to replicate checks in the future. > > Signed-off-by: Alex Bennée > --- > tests/docker/common.rc | 10 ++ > tests/docker/

Re: [Qemu-devel] [PULL for-3.0 0/1] target/sh4: Fix translator.c assertion failure for gUSA

2018-07-10 Thread Peter Maydell
On 9 July 2018 at 18:56, Richard Henderson wrote: > This patch got lost, and represents a regression from 2.12. > > Running check-tcg with all of the docker bells and whistles > will show this up, and is what reminded me. > > > r~ > > > The following changes since commit ec7eb2ae77cc207064e17ace04

[Qemu-devel] [Bug 1780814] Re: lib/raid6/neon4.c:118:1: internal compiler error

2018-07-10 Thread siva krishna
Hi Peter Maydell , is that GCC compiler error or cross-compiler error ? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1780814 Title: lib/raid6/neon4.c:118:1: internal compiler error Status in QEM

Re: [Qemu-devel] [PATCH for 3.0 09/10] docker: add test-unit runner

2018-07-10 Thread Fam Zheng
On Mon, 07/09 16:21, Alex Bennée wrote: > This test doesn't even build QEMU, it just runs all the unit tests. > Intended to make checking unit tests on all docker images easier. > > Signed-off-by: Alex Bennée > --- > tests/docker/test-unit | 19 +++ > 1 file changed, 19 insertion

Re: [Qemu-devel] [PATCH for 3.0 00/10] various docker fixes

2018-07-10 Thread Fam Zheng
On Mon, 07/09 16:21, Alex Bennée wrote: > Hi, > > The addition of the cross compilers for check-tcg broke the ability to > run "make docker-test". In truth this was probably already broken as > it attempts to run every single test with every single docker image > which isn't something that gets d

Re: [Qemu-devel] [GIT PULL for qemu-pseries] pseries: Update SLOF firmware image

2018-07-10 Thread Alexey Kardashevskiy
On Tue, 10 Jul 2018 16:42:48 +1000 David Gibson wrote: > On Tue, Jul 10, 2018 at 12:22:44PM +1000, Alexey Kardashevskiy wrote: > > On Mon, 2 Jul 2018 16:26:44 +1000 > > Alexey Kardashevskiy wrote: > > > > > The following changes since commit > > > edb1fb337f65f82fe32b989c4f018efe85c1dddb: >

[Qemu-devel] [Bug 1780814] Re: lib/raid6/neon4.c:118:1: internal compiler error

2018-07-10 Thread Peter Maydell
It must be the cross compiler. (Why did you report this against QEMU anyway?) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1780814 Title: lib/raid6/neon4.c:118:1: internal compiler error Status i

Re: [Qemu-devel] [PULL v4 0/7] riscv-pull queue

2018-07-10 Thread Andreas Schwab
On Jul 09 2018, Alistair Francis wrote: > On Mon, Jul 9, 2018 at 3:00 AM, Andreas Schwab wrote: >> What is the state of the sifive_u emulation? When I tried to boot a bbl >> with an included kernel I get these errors: >> >> qemu-system-riscv64: plic: invalid register write: 2090 >> qemu-sys

Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr: Correct inverted test in spapr_pc_dimm_node()

2018-07-10 Thread Greg Kurz
On Tue, 10 Jul 2018 11:52:57 +1000 David Gibson wrote: > This function was introduced between v2.11 and v2.12 to replace obsolete > ways of specifying the NUMA nodes for DIMMs. It's used to find the correct > node for an LMB, by locating which DIMM object it lies within. > > Unfortunately, one

Re: [Qemu-devel] [PATCH v2] hw/machine: Remove the Zero check of nb_numa_nodes for numa_complete_configuration()

2018-07-10 Thread Igor Mammedov
On Wed, 4 Jul 2018 21:22:39 +0800 Dou Liyang wrote: > Commit 7a3099fc9c5c("numa: postpone options post-processing till > machine_run_board_init()") > broke the commit 7b8be49d36fc("NUMA: Enable adding NUMA node implicitly"). > > The machine_run_board_init() doesn't do NUMA setup if nb_numa_node

Re: [Qemu-devel] [PATCH 3/6] bloc/qcow2: drop dirty_bitmaps_loaded state variable

2018-07-10 Thread Vladimir Sementsov-Ogievskiy
10.07.2018 02:25, John Snow wrote: On 06/26/2018 09:50 AM, Vladimir Sementsov-Ogievskiy wrote: This variable doesn't work as it should, because it is actually cleared in qcow2_co_invalidate_cache() by memset(). Drop it, as the following patch will introduce new behavior. Signed-off-by: Vladimi

Re: [Qemu-devel] [PATCH] hw/acpi-build: Add a check for non-memory NUMA nodes.

2018-07-10 Thread Igor Mammedov
On Thu, 5 Jul 2018 10:10:38 +0800 Dou Liyang wrote: > Currently, Qemu ACPI builder doesn't consider the non-memory NUMA nodes, eg: s/non-memory/memory-less/ throughout subj/commit message > -m 4G,slots=4,maxmem=8G \ > -numa node,nodeid=0 \ > -numa node,nodeid=1,mem=2G \ > -numa node,nod

Re: [Qemu-devel] [PATCH for 3.0 01/10] tests/.gitignore: don't ignore docker tests

2018-07-10 Thread Alex Bennée
Fam Zheng writes: > On Mon, 07/09 16:21, Alex Bennée wrote: >> This was being a little over enthusiastic hiding files. > > What is "this" that hides test-* and calls for this patch? I thought that was implicit from the first line, this is the .gitignore. > >> >> Signed-off-by: Alex Bennée >>

Re: [Qemu-devel] [PATCH] acpi: generalize aml_package / aml_varpackage

2018-07-10 Thread Igor Mammedov
On Tue, 10 Jul 2018 02:26:35 +0300 "Michael S. Tsirkin" wrote: > On Mon, Jul 09, 2018 at 08:19:17PM +0300, Michael S. Tsirkin wrote: > > On Mon, Jul 09, 2018 at 05:52:32PM +0200, Igor Mammedov wrote: > > > On Fri, 6 Jul 2018 02:53:09 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > Var

Re: [Qemu-devel] [PATCH] spapr: Correct inverted test in spapr_pc_dimm_node()

2018-07-10 Thread Igor Mammedov
On Tue, 10 Jul 2018 11:52:57 +1000 David Gibson wrote: > This function was introduced between v2.11 and v2.12 to replace obsolete > ways of specifying the NUMA nodes for DIMMs. It's used to find the correct > node for an LMB, by locating which DIMM object it lies within. > > Unfortunately, one

Re: [Qemu-devel] [PATCH v2] hw/machine: Remove the Zero check of nb_numa_nodes for numa_complete_configuration()

2018-07-10 Thread Dou Liyang
Hi Igor, At 07/10/2018 03:42 PM, Igor Mammedov wrote: On Wed, 4 Jul 2018 21:22:39 +0800 Dou Liyang wrote: Commit 7a3099fc9c5c("numa: postpone options post-processing till machine_run_board_init()") broke the commit 7b8be49d36fc("NUMA: Enable adding NUMA node implicitly"). The machine_run_bo

Re: [Qemu-devel] [PATCH] hw/acpi-build: Add a check for non-memory NUMA nodes.

2018-07-10 Thread Dou Liyang
Hi Igor, At 07/10/2018 03:52 PM, Igor Mammedov wrote: On Thu, 5 Jul 2018 10:10:38 +0800 Dou Liyang wrote: Currently, Qemu ACPI builder doesn't consider the non-memory NUMA nodes, eg: s/non-memory/memory-less/ throughout subj/commit message Yes, I will do it. -m 4G,slots=4,maxmem=8G

Re: [Qemu-devel] [PATCH for 3.0 01/10] tests/.gitignore: don't ignore docker tests

2018-07-10 Thread Fam Zheng
On Tue, 07/10 08:54, Alex Bennée wrote: > > Fam Zheng writes: > > > On Mon, 07/09 16:21, Alex Bennée wrote: > >> This was being a little over enthusiastic hiding files. > > > > What is "this" that hides test-* and calls for this patch? > > I thought that was implicit from the first line, this i

Re: [Qemu-devel] [PATCH 0/2] block: Fix attaching drained child node

2018-07-10 Thread Kevin Wolf
Am 03.07.2018 um 19:50 hat Kevin Wolf geschrieben: > This fixes the following case that was reported by Max and was caused by > not correctly waiting for activity to cease on the parent node before > attaching a drained child node: > > $ ./qemu-img create -f qed foo.qed 64M > Formatting 'foo.qed',

[Qemu-devel] [Bug 1780814] Re: lib/raid6/neon4.c:118:1: internal compiler error

2018-07-10 Thread siva krishna
I thought it was QEMU issue. Sorry for that. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1780814 Title: lib/raid6/neon4.c:118:1: internal compiler error Status in QEMU: Invalid Bug descriptio

Re: [Qemu-devel] [PATCH 3/7 V8] hostmem-file: add the 'pmem' option

2018-07-10 Thread Igor Mammedov
On Tue, 10 Jul 2018 14:06:25 +0800 junyan...@gmx.com wrote: > From: Junyan He > > When QEMU emulates vNVDIMM labels and migrates vNVDIMM devices, it > needs to know whether the backend storage is a real persistent memory, > in order to decide whether special operations should be performed to > e

Re: [Qemu-devel] [PATCH 4/7 V8] configure: add libpmem support

2018-07-10 Thread Igor Mammedov
On Tue, 10 Jul 2018 14:06:26 +0800 junyan...@gmx.com wrote: > From: Junyan He > > Add a pair of configure options --{enable,disable}-libpmem to control > whether QEMU is compiled with PMDK libpmem [1]. > > QEMU may write to the host persistent memory (e.g. in vNVDIMM label > emulation and live

Re: [Qemu-devel] [PATCH for-3.0 0/9] migration: postcopy recovery unit test, bug fixes

2018-07-10 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Fri, Jul 06, 2018 at 11:56:59AM +0100, Dr. David Alan Gilbert wrote: > > * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > > > * Peter Xu (pet...@redhat.com) wrote: > > > > Based-on: <20180627132246.5576-1-pet...@redhat.com> > > > > > > > > Based on

[Qemu-devel] [PATCH 1/3] x86/cpu: Enable UMONITOR/UMWAIT/TPAUSE cpu features

2018-07-10 Thread Jingqi Liu
UMONITOR, UMWAIT, and TPAUSE are a set of user wait instructions. UMONITOR arms address monitoring hardware using an address. A store to an address within the specified address range triggers the monitoring hardware to wake up the processor waiting in umwait. UMWAIT instructs the processor to ent

[Qemu-devel] [PATCH 2/3] x86/cpu: Enable MOVDIRI cpu feature

2018-07-10 Thread Jingqi Liu
MOVDIRI moves doubleword or quadword from register to memory through direct store which is implemented by using write combining (WC) for writing data directly into memory without caching the data. The bit definition: CPUID.(EAX=7,ECX=0):ECX[bit 27] MOVDIRI The release document ref below link: htt

[Qemu-devel] [PATCH 3/3] x86/cpu: Enable MOVDIR64B cpu feature

2018-07-10 Thread Jingqi Liu
MOVDIR64B moves 64-bytes as direct-store with 64-bytes write atomicity. Direct store is implemented by using write combining (WC) for writing data directly into memory without caching the data. The bit definition: CPUID.(EAX=7,ECX=0):ECX[bit 28] MOVDIR64B The release document ref below link: http

[Qemu-devel] [PATCH 0/3] x86/cpu: Enable a few new cpu features

2018-07-10 Thread Jingqi Liu
Enable a few new cpu features including UMONITOR, UMWAIT, TPAUSE, MOVDIRI and MOVDIR64B. UMONITOR, UMWAIT, and TPAUSE are a set of user wait instructions. MOVDIRI moves doubleword or quadword from register to memory through direct store. MOVDIR64B moves 64-bytes as direct-store with 64-bytes write

[Qemu-devel] [PATCH v2 2/2][DO NOT APPLY] tests/acpi-test: update ACPI tables test blobs

2018-07-10 Thread Dou Liyang
Now, QEmu adds a new check for memory-less NUMA nodes in build_srat(). It effects the ACPI test. So, Update ACPI tables test blobs. Signed-off-by: Dou Liyang --- tests/acpi-test-data/pc/SRAT.numamem | Bin 224 -> 224 bytes tests/acpi-test-data/q35/SRAT.numamem | Bin 224 -> 224 bytes 2 files

[Qemu-devel] [PATCH v2 1/2] hw/acpi-build: Add a check for memory-less NUMA nodes

2018-07-10 Thread Dou Liyang
Currently, Qemu ACPI builder doesn't consider the memory-less NUMA nodes, eg: -m 4G,slots=4,maxmem=8G \ -numa node,nodeid=0 \ -numa node,nodeid=1,mem=2G \ -numa node,nodeid=2,mem=2G \ -numa node,nodeid=3\ Guest Linux will report [0.00] ACPI: SRAT: Node 0 PXM 0 [mem 0x

Re: [Qemu-devel] [PULL 0/7] Block patches for 3.0-rc0

2018-07-10 Thread Peter Maydell
On 9 July 2018 at 19:58, Max Reitz wrote: > The following changes since commit ec7eb2ae77cc207064e17ace048f7ec0c4b85d6f: > > translate-all: honour CF_NOCACHE in tb_gen_code (2018-07-09 16:14:36 +0100) > > are available in the Git repository at: > > https://git.xanclic.moe/XanClic/qemu.git tags

[Qemu-devel] [Bug 1780928] [NEW] v2.12.0-2321-gb34181056c: vcpu hotplug crashes qemu-kvm with segfault

2018-07-10 Thread Satheesh Rajendran
Public bug reported: vcpu hotplug crashes upstream qemu(v2.12.0-2321-gb34181056c), vcpu hotplug works fine in v2.12.0-rc4. Host: Power8, kernel: 4.18.0-rc2-00037-g6f0d349d922b Guest: Power8, kernel: 4.18.0-rc3-00183-gc42c12a90545 (base image: fedora27 ppc64le) /usr/share/avocado-plugins-vt/buil

Re: [Qemu-devel] [PATCH for-3.0] pc: Use "3.0+" constant as default SMBIOS version

2018-07-10 Thread Daniel P . Berrangé
On Mon, Jul 09, 2018 at 05:37:31PM -0300, Eduardo Habkost wrote: > Every time we create new PC machine-types in QEMU, the defaults > for SMBIOS fields change unnecessarily because the version field > defaults to MachineClass::name. > > This can cause unexpected side-effects, like triggering licens

[Qemu-devel] [PATCH for-3.0 v2 01/10] migration: simplify check to use qemu file buffer

2018-07-10 Thread Peter Xu
Firstly, renaming the old matching_page_sizes variable to matches_target_page_size, which suites more to what it did (it only checks against target page size rather than multiple page sizes). Meanwhile, simplify the check logic a bit, and enhance the comments. Should have no functional change. Rev

[Qemu-devel] [PATCH for-3.0 v2 03/10] migration: fix incorrect bitmap size calculation

2018-07-10 Thread Peter Xu
The calculation on size of received bitmap is incorrect for postcopy recovery. Here we wanted to let the size to cover all the valid bits in the bitmap, we should use DIV_ROUND_UP() instead of a division. For example, a RAMBlock with size=4K (which contains only one single 4K page) will have nbit

[Qemu-devel] [PATCH for-3.0 v2 00/10] migration: postcopy recovery unit test, bug fixes

2018-07-10 Thread Peter Xu
Based-on: <20180627132246.5576-1-pet...@redhat.com> Based on the series to unbreak postcopy: Subject: [PATCH v3 0/4] migation: unbreak postcopy recovery Message-Id: <20180627132246.5576-1-pet...@redhat.com> v2: - collect r-bs, and t-b for Balamuruhan - rename matching_target_page_size to matc

[Qemu-devel] [PATCH for-3.0 v2 05/10] tests: introduce migrate_postcopy_* helpers

2018-07-10 Thread Peter Xu
Separate the old postcopy UNIX socket test into three steps, provide a helper for each step. With these helpers, we can do more compliated tests like postcopy recovery, while keep the codes shared. Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela Reviewed-by: Balamuruhan S Signed

[Qemu-devel] [PATCH for-3.0 v2 02/10] migration: loosen recovery check when load vm

2018-07-10 Thread Peter Xu
We were checking against -EIO, assuming that it will cover all IO failures. But actually it is not. One example is that in qemu_loadvm_section_start_full() we can have tons of places that will return -EINVAL even if the error is caused by IO failures on the network. Let's loosen the recovery che

[Qemu-devel] [PATCH for-3.0 v2 04/10] migration: show pause/recover state on dst host

2018-07-10 Thread Peter Xu
These two states will be missing when doing "query-migrate" on destination VM. Add these states so that we can get the query results as expected. Signed-off-by: Peter Xu --- migration/migration.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/migration/migration.c b/migration/migration.c

[Qemu-devel] [PATCH for-3.0 v2 09/10] tests: add postcopy recovery test

2018-07-10 Thread Peter Xu
Test the postcopy recovery procedure by emulating a network failure using migrate-pause command. Tested-by: Balamuruhan S Signed-off-by: Peter Xu --- tests/migration-test.c | 78 ++ 1 file changed, 78 insertions(+) diff --git a/tests/migration-test.c b/t

[Qemu-devel] [PATCH for-3.0 v2 06/10] tests: allow migrate() to take extra flags

2018-07-10 Thread Peter Xu
For example, we can pass in '"resume": true' to resume a migration. Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela Reviewed-by: Balamuruhan S Signed-off-by: Peter Xu --- tests/migration-test.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tes

[Qemu-devel] [PATCH for-3.0 v2 07/10] tests: introduce migrate_query*() helpers

2018-07-10 Thread Peter Xu
Introduce helpers to query migration states and use it. Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela Reviewed-by: Balamuruhan S Signed-off-by: Peter Xu --- tests/migration-test.c | 64 -- 1 file changed, 43 insertions(+), 21 deletions(

[Qemu-devel] [PATCH for-3.0 v2 10/10] tests: hide stderr for postcopy recovery test

2018-07-10 Thread Peter Xu
We dumped something when network failure happens. We should avoid those messages to be dumped when running the tests: $ ./tests/migration-test -p /x86_64/migration/postcopy/recovery /x86_64/migration/postcopy/recovery: qemu-system-x86_64: check_section_footer: Read section footer failed: -5

[Qemu-devel] [PATCH for-3.0 v2 08/10] tests: introduce wait_for_migration_status()

2018-07-10 Thread Peter Xu
It's generalized from wait_for_migration_complete() to allow us to wait for any migration status besides failure. Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela Reviewed-by: Balamuruhan S Signed-off-by: Peter Xu --- tests/migration-test.c | 10 -- 1 file changed, 8 ins

[Qemu-devel] [Bug 1780928] Re: v2.12.0-2321-gb34181056c: vcpu hotplug crashes qemu-kvm with segfault

2018-07-10 Thread Bharata B Rao
Reverting the below comment makes CPU hotplug work again: commit a028dd423ee6dfd091a8c63028240832bf10f671 ppc/xics: introduce ICP DeviceRealize and DeviceReset handlers This changes the ICP realize and reset handlers in DeviceRealize and DeviceReset handlers. parent handlers are

[Qemu-devel] [PATCH] iotests: 222: Don't run with luks

2018-07-10 Thread Fam Zheng
Luks needs special parameters to operate the image. Since this test is focusing on image fleecing, skip skip that format. Signed-off-by: Fam Zheng --- tests/qemu-iotests/222 | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/qemu-iotests/222 b/tests/qemu-iotests/222 index ff3bfc1470..0e

[Qemu-devel] [Bug 1780928] Re: v2.12.0-2321-gb34181056c: vcpu hotplug crashes qemu-kvm with segfault

2018-07-10 Thread Satheesh Rajendran
** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1780928 Title: v2.12.0-2321-gb34181056c: vcpu hotplug crashes qemu-kvm with segfault Status in QEM

[Qemu-devel] [PATCH for-3.0] migration: reorder MIG_CMD_POSTCOPY_RESUME

2018-07-10 Thread Peter Xu
It was accidently added before MIG_CMD_PACKAGED so it might break command compatibility when we run postcopy migration between old/new QEMUs. Fix that up quickly before the QEMU 3.0 release. Reported-by: Lukáš Doktor Suggested-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu --- migration/s

Re: [Qemu-devel] [PATCH] linux-user: Fix shmat emulation by honoring host SHMLBA

2018-07-10 Thread Laurent Vivier
Le 09/07/2018 à 21:15, Richard Henderson a écrit : > For those hosts with SHMLBA > getpagesize, we don't automatically > select a guest address that is compatible with the host. We can > achieve this by boosting the alignment of guest_base and by adding > an extra alignment argument to mmap_find_v

Re: [Qemu-devel] [PULL 0/3] Linux user for 3.0 patches

2018-07-10 Thread Peter Maydell
On 10 July 2018 at 07:23, Laurent Vivier wrote: > The following changes since commit 43a473993fd9378bf850dcafa68eb6dee8c300f8: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2018-07-06 18:18:08 +0100) > > are available in the Git repository at: > > git://

[Qemu-devel] [PATCH] target-i386: coalesced PIO support for RTC

2018-07-10 Thread Wanpeng Li
Windows I/O, such as the real-time clock. The address register (port 0x70 in the RTC case) can use coalesced I/O, cutting the number of userspace exits by half when reading or writing the RTC. Guest access rtc like this: write register index to 0x70, then write or read data from 0x71. writing 0x7

Re: [Qemu-devel] [PATCH for-3.0] migration: reorder MIG_CMD_POSTCOPY_RESUME

2018-07-10 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > It was accidently added before MIG_CMD_PACKAGED so it might break > command compatibility when we run postcopy migration between old/new > QEMUs. Fix that up quickly before the QEMU 3.0 release. > > Reported-by: Lukáš Doktor > Suggested-by: Dr. David Alan

Re: [Qemu-devel] [PATCH] iotests: 222: Don't run with luks

2018-07-10 Thread Kevin Wolf
Am 10.07.2018 um 11:38 hat Fam Zheng geschrieben: > Luks needs special parameters to operate the image. Since this test is > focusing on image fleecing, skip skip that format. > > Signed-off-by: Fam Zheng Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [RFC 5/6] hw/arm/virt: support kvm_type property

2018-07-10 Thread Auger Eric
Hi Thomas, On 07/09/2018 07:26 PM, Thomas Huth wrote: > On 03.07.2018 14:31, Auger Eric wrote: >> Hi Drew, >> >> On 07/03/2018 01:55 PM, Andrew Jones wrote: >>> On Wed, Jun 20, 2018 at 03:07:32PM +0200, Eric Auger wrote: The kvm-type property currently is used to pass a user parameter to

Re: [Qemu-devel] [PATCH v2] hw/machine: Remove the Zero check of nb_numa_nodes for numa_complete_configuration()

2018-07-10 Thread Eduardo Habkost
On Tue, Jul 10, 2018 at 04:15:30PM +0800, Dou Liyang wrote: [...] > > > +if (nb_numa_nodes) > > > machine_numa_finish_cpu_init(machine); > > > -} > > missing curly brackets, should look like: > > if (nb_numa_nodes) { > > machine_numa_finish_cpu_init(machine); >

[Qemu-devel] [PATCH 1/7 V9] memory, exec: Expose all memory block related flags.

2018-07-10 Thread junyan . he
From: Junyan He We need to use these flags in other files rather than just in exec.c, For example, RAM_SHARED should be used when create a ram block from file. We expose them the exec/memory.h Signed-off-by: Junyan He Reviewed-by: Stefan Hajnoczi Reviewed-by: Igor Mammedov --- exec.c

[Qemu-devel] [PATCH 2/7 V9] memory, exec: switch file ram allocation functions to 'flags' parameters

2018-07-10 Thread junyan . he
From: Junyan He As more flag parameters besides the existing 'share' are going to be added to following functions memory_region_init_ram_from_file qemu_ram_alloc_from_fd qemu_ram_alloc_from_file let's switch them to use the 'flags' parameters so as to ease future flag additions. The existing 'sh

[Qemu-devel] [PATCH 3/7 V9] configure: add libpmem support

2018-07-10 Thread junyan . he
From: Junyan He Add a pair of configure options --{enable,disable}-libpmem to control whether QEMU is compiled with PMDK libpmem [1]. QEMU may write to the host persistent memory (e.g. in vNVDIMM label emulation and live migration), so it must take the proper operations to ensure the persistence

[Qemu-devel] [PATCH 0/7 V9] nvdimm: guarantee persistence of QEMU writes to persistent memory

2018-07-10 Thread junyan . he
From: Junyan He QEMU writes to vNVDIMM backends in the vNVDIMM label emulation and live migration. If the backend is on the persistent memory, QEMU needs to take proper operations to ensure its writes persistent on the persistent memory. Otherwise, a host power failure may result in the loss t

[Qemu-devel] [PATCH 5/7 V9] mem/nvdimm: ensure write persistence to PMEM in label emulation

2018-07-10 Thread junyan . he
From: Junyan He Guest writes to vNVDIMM labels are intercepted and performed on the backend by QEMU. When the backend is a real persistent memort, QEMU needs to take proper operations to ensure its write persistence on the persistent memory. Otherwise, a host power failure may result in the loss

[Qemu-devel] [PATCH 7/7 V9] migration/ram: ensure write persistence on loading all data to PMEM.

2018-07-10 Thread junyan . he
From: Junyan He Because we need to make sure the pmem kind memory data is synced after migration, we choose to call pmem_persist() when the migration finish. This will make sure the data of pmem is safe and will not lose if power is off. Signed-off-by: Junyan He Reviewed-by: Stefan Hajnoczi Re

[Qemu-devel] [PATCH 4/7 V9] hostmem-file: add the 'pmem' option

2018-07-10 Thread junyan . he
From: Junyan He When QEMU emulates vNVDIMM labels and migrates vNVDIMM devices, it needs to know whether the backend storage is a real persistent memory, in order to decide whether special operations should be performed to ensure the data persistence. This boolean option 'pmem' allows users to s

[Qemu-devel] [PATCH 6/7 V9] migration/ram: Add check and info message to nvdimm post copy.

2018-07-10 Thread junyan . he
From: Junyan He The nvdimm kind memory does not support post copy now. We disable post copy if we have nvdimm memory and print some log hint to user. Signed-off-by: Junyan He Reviewed-by: Stefan Hajnoczi Reviewed-by: Igor Mammedov --- migration/ram.c | 9 + 1 file changed, 9 insertio

Re: [Qemu-devel] [PATCH v2] hw/machine: Remove the Zero check of nb_numa_nodes for numa_complete_configuration()

2018-07-10 Thread Dou Liyang
Hi Eduardo, At 07/10/2018 06:27 PM, Eduardo Habkost wrote: On Tue, Jul 10, 2018 at 04:15:30PM +0800, Dou Liyang wrote: [...] +if (nb_numa_nodes) machine_numa_finish_cpu_init(machine); -} missing curly brackets, should look like: if (nb_numa_nodes) { mac

[Qemu-devel] [PATCH] hw/machine: Remove the Zero check of nb_numa_nodes for numa_complete_configuration() follow-up

2018-07-10 Thread Dou Liyang
This Commit 7747abf11487 misses the curly brackets. Follow Igor's and Eduardo's suggestion, Add a follow-up patch for it. Signed-off-by: Dou Liyang --- hw/core/machine.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/core/machine.c b/hw/core/machine.c index a9aeb22f03

Re: [Qemu-devel] [PATCH] exec.c: Replace memory_region_is_unassigned() with memory_region_is_ram_backed()

2018-07-10 Thread Peter Maydell
On 9 July 2018 at 18:50, Richard Henderson wrote: > On 07/09/2018 10:33 AM, Peter Maydell wrote: >>> Well... ok. We should document that this, surprisingly, does not include >>> actual ram. Just things that are ram with caveats. >> >> I think it must include actual RAM, or we would not be able t

Re: [Qemu-devel] [PATCH v5 0/4] fix image fleecing

2018-07-10 Thread Kevin Wolf
Am 09.07.2018 um 18:37 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi all. > > This fixes image fleecing scheme for 3.0, details are in 04 patch. > 01 is a significant fix too. > > v5: - keep one _internal recursive function like in original code [Fam] > - grammar and rewording [Eric] (a

Re: [Qemu-devel] [PATCH] block/blklogwrites: Make sure the log sector size is not too small

2018-07-10 Thread Kevin Wolf
Am 09.07.2018 um 17:01 hat Ari Sundholm geschrieben: > Would there be a chance of getting this included in 3.0? Sure, this is clearly a bug fix. Thanks, applied to the block branch. Kevin > On 07/06/2018 03:00 PM, Ari Sundholm wrote: > > The sector size needs to be large enough to accommodate t

Re: [Qemu-devel] [PATCH for-3.0 v2 04/10] migration: show pause/recover state on dst host

2018-07-10 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > These two states will be missing when doing "query-migrate" on > destination VM. Add these states so that we can get the query results > as expected. > > Signed-off-by: Peter Xu Reviewed-by: Dr. David Alan Gilbert > --- > migration/migration.c | 2 ++ >

Re: [Qemu-devel] [PATCH for-3.0] target/arm: Use correct mmu_idx for exception-return unstacking

2018-07-10 Thread Peter Maydell
On 9 July 2018 at 15:30, Richard Henderson wrote: > On 07/09/2018 05:45 AM, Peter Maydell wrote: >> For M-profile exception returns, the mmu index to use for exception >> return unstacking is supposed to be that of wherever we are returning to: >> * if returning to handler mode, privileged >> *

Re: [Qemu-devel] [PATCH for-3.0 v2 09/10] tests: add postcopy recovery test

2018-07-10 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Test the postcopy recovery procedure by emulating a network failure > using migrate-pause command. > > Tested-by: Balamuruhan S > Signed-off-by: Peter Xu Reviewed-by: Dr. David Alan Gilbert > --- > tests/migration-test.c | 78 ++

[Qemu-devel] [Bug 1780928] Re: v2.12.0-2321-gb34181056c: vcpu hotplug crashes qemu-kvm with segfault

2018-07-10 Thread Greg Kurz
** Changed in: qemu Assignee: (unassigned) => Greg Kurz (gkurz) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1780928 Title: v2.12.0-2321-gb34181056c: vcpu hotplug crashes qemu-kvm with segfau

Re: [Qemu-devel] [PATCH] fix gdbserver_state pointer validation

2018-07-10 Thread stephane duverger
Hi Alex, There don't seem to be any other patches attached? I would NACK a patch > that isn't actually used in-tree. No there isn't ! I should have not been so prolix. Actually the patch corrects a possible null pointer dereference in the gdbserver code. That's all folks. Below is how I discove

Re: [Qemu-devel] [PATCH] hw/machine: Remove the Zero check of nb_numa_nodes for numa_complete_configuration() follow-up

2018-07-10 Thread Igor Mammedov
On Tue, 10 Jul 2018 18:51:29 +0800 Dou Liyang wrote: > This Commit 7747abf11487 misses the curly brackets. Follow Igor's and > Eduardo's suggestion, > > Add a follow-up patch for it. > > Signed-off-by: Dou Liyang > --- > hw/core/machine.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletio

Re: [Qemu-devel] [PATCH for-3.0 v2 00/10] migration: postcopy recovery unit test, bug fixes

2018-07-10 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Based-on: <20180627132246.5576-1-pet...@redhat.com> > > Based on the series to unbreak postcopy: > Subject: [PATCH v3 0/4] migation: unbreak postcopy recovery > Message-Id: <20180627132246.5576-1-pet...@redhat.com> Queued (Took a bit of manual merging

Re: [Qemu-devel] [PATCH for-3.0] migration: reorder MIG_CMD_POSTCOPY_RESUME

2018-07-10 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > It was accidently added before MIG_CMD_PACKAGED so it might break > command compatibility when we run postcopy migration between old/new > QEMUs. Fix that up quickly before the QEMU 3.0 release. > > Reported-by: Lukáš Doktor > Suggested-by: Dr. David Alan

Re: [Qemu-devel] [PATCH for-3.0] migration: reorder MIG_CMD_POSTCOPY_RESUME

2018-07-10 Thread Juan Quintela
Peter Xu wrote: > It was accidently added before MIG_CMD_PACKAGED so it might break > command compatibility when we run postcopy migration between old/new > QEMUs. Fix that up quickly before the QEMU 3.0 release. > > Reported-by: Lukáš Doktor > Suggested-by: Dr. David Alan Gilbert > Signed-off-

Re: [Qemu-devel] [PATCH for-3.0 v2 09/10] tests: add postcopy recovery test

2018-07-10 Thread Juan Quintela
Peter Xu wrote: > Test the postcopy recovery procedure by emulating a network failure > using migrate-pause command. > > Tested-by: Balamuruhan S > Signed-off-by: Peter Xu Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH V4] qemu-img: align result of is_allocated_sectors

2018-07-10 Thread Kevin Wolf
Am 07.07.2018 um 13:42 hat Peter Lieven geschrieben: > We currently don't enforce that the sparse segments we detect during convert > are > aligned. This leads to unnecessary and costly read-modify-write cycles either > internally in Qemu or in the background on the storage device as nearly all >

Re: [Qemu-devel] [PATCH V4] qemu-img: align result of is_allocated_sectors

2018-07-10 Thread Peter Lieven
Am 10.07.2018 um 14:28 schrieb Kevin Wolf: Am 07.07.2018 um 13:42 hat Peter Lieven geschrieben: We currently don't enforce that the sparse segments we detect during convert are aligned. This leads to unnecessary and costly read-modify-write cycles either internally in Qemu or in the background o

Re: [Qemu-devel] [PATCH v2 01/33] target/mips: Add nanoMIPS OPCODE table

2018-07-10 Thread Aleksandar Markovic
> Subject: [PATCH v2 01/33] target/mips: Add nanoMIPS OPCODE table > > From: Yongbok Kim > > nanoMIPS opcodes are organized by so-called instruction pools. > > Reviewed-by: Richard Henderson > Signed-off-by: Yongbok Kim > Signed-off-by: Aleksandar Markovic > Signed-off-by: Stefan Markovic > --

Re: [Qemu-devel] [PATCH v2 02/33] target/mips: Add decode_nanomips_opc() function

2018-07-10 Thread Aleksandar Markovic
Subject: [PATCH v2 02/33] target/mips: Add decode_nanomips_opc() function From: Yongbok Kim Add body and invocation of decode_nanomips_opc() if bit ISA_NANOMIPS32 is set in env->insn_flags. Signed-off-by: Yongbok Kim Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic --- targ

Re: [Qemu-devel] [PATCH v2 03/33] target/mips: Add emulation of nanoMIPS 16-bit load and store instructions

2018-07-10 Thread Aleksandar Markovic
> Subject: [PATCH v2 03/33] target/mips: Add emulation of nanoMIPS 16-bit load > and store > instructions > > From: Yongbok Kim > > Add emulation of LWXS16, LB16, SB16, LBU16, LH16, SH16, LHU16, LW16, LWSP16, > LW4X4, SW4X4, LWGP16, SWSP16, SW16, and SWGP16 instructions. > > Signed-off-by: Yongbo

Re: [Qemu-devel] [PATCH v2 04/33] target/mips: Add emulation of nanoMIPS 16-bit logic instructions

2018-07-10 Thread Aleksandar Markovic
> Subject: [PATCH v2 04/33] target/mips: Add emulation of nanoMIPS 16-bit logic > instructions > > From: Yongbok Kim > > Add emulation of NOT16, AND16, XOR16, OR16 instructions. > > Reviewed-by: Richard Henderson > Signed-off-by: Yongbok Kim > Signed-off-by: Aleksandar Markovic > Signed-off-by

Re: [Qemu-devel] [PATCH v2 05/33] target/mips: Add emulation of nanoMIPS 16-bit save and restore instructions

2018-07-10 Thread Aleksandar Markovic
> Subject: [PATCH v2 05/33] target/mips: Add emulation of nanoMIPS 16-bit save > and restore > instructions > > From: Matthew Fortune > > Add emulation of SAVE16 and RESTORE.JRC16 instructions. Routines > gen_save(), gen_restore(), and gen_adjust_sp() are provided for this > purpose. > > Signed-o

Re: [Qemu-devel] [PATCH for-3.0 0/4] block: revert removal of deprecated options

2018-07-10 Thread Kevin Wolf
Am 06.07.2018 um 15:06 hat Cornelia Huck geschrieben: > Several -drive options had been marked as deprecated for two releases > and had therefore been removed; unfortunately, libvirt still used at > least two of them (serial number and disk geometry) and the patch > switching away from it is not ye

Re: [Qemu-devel] [RFC PATCH v2 0/7] QEMU binary instrumentation prototype

2018-07-10 Thread Stefan Hajnoczi
On Tue, Jun 05, 2018 at 02:56:29PM +0300, Pavel Dovgalyuk wrote: > > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > > > > This series doesn't seem to add anything to Documentation/ that > > describes the API we make available to plugins. I'm a lot more > > interested in reviewing the API

Re: [Qemu-devel] [PATCH V4] qemu-img: align result of is_allocated_sectors

2018-07-10 Thread Kevin Wolf
Am 10.07.2018 um 14:36 hat Peter Lieven geschrieben: > Am 10.07.2018 um 14:28 schrieb Kevin Wolf: > > Am 07.07.2018 um 13:42 hat Peter Lieven geschrieben: > > > We currently don't enforce that the sparse segments we detect during > > > convert are > > > aligned. This leads to unnecessary and costl

Re: [Qemu-devel] [PULL v2 18/32] qmp: Don't let JSON errors jump the queue

2018-07-10 Thread Kevin Wolf
Am 03.07.2018 um 23:35 hat Markus Armbruster geschrieben: > handle_qmp_command() reports JSON syntax errors right away. This is > wrong when OOB is enabled, because the errors can "jump the queue" > then. > > The previous commit fixed the same bug for semantic errors, by > delaying the checking u

Re: [Qemu-devel] [PATCH] migration: add capability to bypass the shared memory

2018-07-10 Thread Stefan Hajnoczi
On Tue, Jul 03, 2018 at 11:10:12PM +0800, Peng Tao wrote: > On Tue, Jul 3, 2018 at 6:05 PM, Stefan Hajnoczi wrote: > > On Mon, Jul 02, 2018 at 09:52:08PM +0800, Peng Tao wrote: > >> On Mon, Jul 2, 2018 at 9:10 PM, Stefan Hajnoczi wrote: > >> > On Sat, Mar 31, 2018 at 04:45:00PM +0800, Lai Jiangsh

Re: [Qemu-devel] [PATCH v2 06/33] target/mips: Add emulation of some common nanoMIPS 32-bit instructions

2018-07-10 Thread Aleksandar Markovic
Subject: [PATCH v2 06/33] target/mips: Add emulation of some common nanoMIPS 32-bit instructions From: Yongbok Kim Add emulation of SIGRIE, SYSCALL, BREAK, SDBBP, ADDIU, ADDIUPC, ADDIUGP.W, LWGP, SWGP, ORI, XORI, ANDI, and other instructions. Signed-off-by: Yongbok Kim Signed-off-by: Aleksand

Re: [Qemu-devel] [PATCH v2 07/33] target/mips: Add emulation of nanoMIPS 48-bit instructions

2018-07-10 Thread Aleksandar Markovic
> Subject: [PATCH v2 07/33] target/mips: Add emulation of nanoMIPS 48-bit > instructions > > From: Yongbok Kim > > Add emulation of LI48, ADDIU48, ADDIUGP48, ADDIUPC48, LWPC48, and > SWPC48 instructions. > > Signed-off-by: Yongbok Kim > Signed-off-by: Aleksandar Markovic > Signed-off-by: Stefan

Re: [Qemu-devel] [PATCH] hw/char/serial: Only retry if qemu_chr_fe_write returns 0

2018-07-10 Thread Igor Mammedov
On Tue, 5 Jun 2018 11:18:35 +0200 Paolo Bonzini wrote: > On 05/06/2018 09:54, Sergio Lopez wrote: > > Only retry on serial_xmit if qemu_chr_fe_write returns 0, as this is the > > only recoverable error. > > > > Retrying with any other scenario, in addition to being a waste of CPU > > cycles, can

Re: [Qemu-devel] [PATCH] linux-user: Fix shmat emulation by honoring host SHMLBA

2018-07-10 Thread Richard Henderson
On 07/10/2018 02:47 AM, Laurent Vivier wrote: >> -addr &= TARGET_PAGE_MASK; >> +addr &= align - 1; > > and here TARGET_PAGE_MASK is also (align - 1)... > > So I think it should be "addr &= -align". Whoops, yes indeed. r~

[Qemu-devel] [Bug 1780928] Re: v2.12.0-2321-gb34181056c: vcpu hotplug crashes qemu-kvm with segfault

2018-07-10 Thread Greg Kurz
The parent class (ie, TYPE_ICP) doesn't implement DeviceClass::reset(). It directly registers a reset handler with qemu_register_reset() instead. This is needed for cold plugged ICPs to be reset during machine reset since they're not SysBus devices. Cedric's patch missed that, but rather than reve

Re: [Qemu-devel] [PATCH v2 08/33] target/mips: Add emulation of nanoMIPS FP instructions

2018-07-10 Thread Aleksandar Markovic
> Subject: [PATCH v2 08/33] target/mips: Add emulation of nanoMIPS FP > instructions > > From: Yongbok Kim > > Add emulation of basic floating point arithmetic for nanoMIPS. > > Signed-off-by: Yongbok Kim > Signed-off-by: Aleksandar Markovic > Signed-off-by: Stefan Markovic > --- > target/mip

Re: [Qemu-devel] [PULL v2 18/32] qmp: Don't let JSON errors jump the queue

2018-07-10 Thread Marc-André Lureau
Hi On Tue, Jul 10, 2018 at 3:20 PM, Kevin Wolf wrote: > Am 03.07.2018 um 23:35 hat Markus Armbruster geschrieben: >> handle_qmp_command() reports JSON syntax errors right away. This is >> wrong when OOB is enabled, because the errors can "jump the queue" >> then. >> >> The previous commit fixed

Re: [Qemu-devel] [PATCH v2] tracing: Use double-dash spelling for trace option

2018-07-10 Thread Stefan Hajnoczi
On Wed, Jul 04, 2018 at 11:17:27AM +0800, Yaowei Bai wrote: > The '-trace' and '--trace' spellings are only both supported in qemu > binary, while for qemu-nbd or qemu-img only '--trace' spelling is > supported. So for the consistency of trace option invocation, we > should use double-dash spelling

Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-10 Thread Cornelia Huck
On Tue, 10 Jul 2018 07:59:15 +0200 Markus Armbruster wrote: > In addition to actively pulling libvirt developers into review of > deprecation patches, we should pursue the idea to optionally let QEMU > fail on use of deprecated features, then have libvirt run its test suite > that way. What abou

Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-10 Thread Venu Busireddy
On 2018-07-10 05:11:18 +0300, Michael S. Tsirkin wrote: > On Fri, Jun 29, 2018 at 05:19:03PM -0500, Venu Busireddy wrote: > > The current patch set includes all the feedback received for proposals [3] > > and [4]. For the sake of completeness, patch for the virtio specification > > is also included

Re: [Qemu-devel] [PATCH 2/2] nbd/server: send more than one extent of base:allocation context

2018-07-10 Thread Vladimir Sementsov-Ogievskiy
04.07.2018 14:23, Vladimir Sementsov-Ogievskiy wrote: This is necessary for efficient block-status export, for clients which support it. Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/server.c | 77 +--- 1 file changed, 58 insertio

  1   2   3   >