Re: [Qemu-devel] monitor: enable OOB by default

2018-07-04 Thread Markus Armbruster
Peter Xu writes: > On Mon, Jul 02, 2018 at 07:43:06AM +0200, Markus Armbruster wrote: >> More lose ends: >> >> * scripts/qmp/ doesn't support OOB, yet. qmp-shell.py in particular >> >> * test-qmp-cmds neglects to cover the OOB additions to qmp-dispatch.c > > Would you mind I put these aside fo

Re: [Qemu-devel] [PATCH 1/2] hw/net: Add support for Intel pch_gbe ethernet

2018-07-04 Thread Jason Wang
On 2018年02月18日 03:22, Paul Burton wrote: This patch introduces support for emulating the ethernet controller found in the Intel EG20T Platform Controller Hub, referred to as pch_gbe for consistency with both Linux & U-Boot. Documentation for the hardware can be found here: https://www.in

Re: [Qemu-devel] [PATCH 1/2] block: Fix dst total_sectors after copy offloading

2018-07-04 Thread Kevin Wolf
Am 04.07.2018 um 08:13 hat Fam Zheng geschrieben: > This was noticed by the new image fleecing tests case 222. The issue is > apparent and we should just do the same right things as in > bdrv_aligned_pwritev. > > Reported-by: John Snow > Signed-off-by: Fam Zheng > --- a/block/io.c > +++ b/block

[Qemu-devel] [Bug 1779634] Re: qemu-x86_64 on aarch64 reports "Synchronous External Abort"

2018-07-04 Thread He Yi
** Changed in: qemu Status: New => Confirmed ** Changed in: qemu Status: Confirmed => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1779634 Title: qemu-x86_64 on aarch64 repo

Re: [Qemu-devel] [PATCH v3 17/20] vgic: Add support for 52bit guest physical address

2018-07-04 Thread Auger Eric
Hi Suzuki, On 06/29/2018 01:15 PM, Suzuki K Poulose wrote: > From: Kristina Martsenko > > Add support for handling 52bit guest physical address to the > VGIC layer. So far we have limited the guest physical address > to 48bits, by explicitly masking the upper bits. This patch > removes the restr

Re: [Qemu-devel] [PATCH v3 1/3] spapr: introduce a fixed IRQ number space

2018-07-04 Thread Greg Kurz
On Tue, 3 Jul 2018 17:19:56 +0200 Cédric Le Goater wrote: > On 07/02/2018 01:11 PM, Cédric Le Goater wrote: > > On 07/02/2018 12:03 PM, Cédric Le Goater wrote: > >>> --- a/hw/ppc/spapr_vio.c > >>> +++ b/hw/ppc/spapr_vio.c > >>> @@ -436,6 +436,9 @@ static void spapr_vio_busdev_reset(DeviceState

Re: [Qemu-devel] [PATCH v3 10/20] kvm: arm64: Dynamic configuration of VTTBR mask

2018-07-04 Thread Auger Eric
Hi Suzuki, On 07/03/2018 01:54 PM, Suzuki K Poulose wrote: > Hi Eric, > > On 02/07/18 15:41, Auger Eric wrote: >> Hi Suzuki, >> >> On 06/29/2018 01:15 PM, Suzuki K Poulose wrote: >>> On arm64 VTTBR_EL2:BADDR holds the base address for the stage2 >>> translation table. The Arm ARM mandates that th

Re: [Qemu-devel] [PATCH] scripts/qemu-binfmt-conf.sh: allow clearing of entries

2018-07-04 Thread Alex Bennée
Laurent Vivier writes: > Le 03/07/2018 à 18:00, Alex Bennée a écrit: >> Currently running the script twice will fail with "sh: echo: I/O >> error" as the registration is already complete. Add a new option >> --clear to reset the entries to save the user doing it by hand. >> >> Signed-off-by: Al

Re: [Qemu-devel] [PATCH v3 10/20] kvm: arm64: Dynamic configuration of VTTBR mask

2018-07-04 Thread Suzuki K Poulose
On 07/04/2018 09:24 AM, Auger Eric wrote: + * + * We have a magic formula for the Magic_N below. + * + * Magic_N(PAGE_SIZE, Entry_Level) = 64 - ((PAGE_SHIFT - 3) * Number of levels) [0] ^^^ + * + * where number of levels = (4 - Entry_Level). ^^^ Doesn't this help make it clear ? Using th

Re: [Qemu-devel] [PATCH 1/2] block: Fix dst total_sectors after copy offloading

2018-07-04 Thread Fam Zheng
On Wed, 07/04 09:44, Kevin Wolf wrote: > Am 04.07.2018 um 08:13 hat Fam Zheng geschrieben: > > This was noticed by the new image fleecing tests case 222. The issue is > > apparent and we should just do the same right things as in > > bdrv_aligned_pwritev. > > > > Reported-by: John Snow > > Signed

[Qemu-devel] [PATCH 1/9] monitor: simplify monitor_qmp_setup_handlers_bh

2018-07-04 Thread Peter Xu
When we reach monitor_qmp_setup_handlers_bh() we must be using the IOThread then, so no need to check against it any more. Instead, we assert. Signed-off-by: Peter Xu --- monitor.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/monitor.c b/monitor.c index 14af

[Qemu-devel] [PATCH 0/9] monitor: enable OOB by default

2018-07-04 Thread Peter Xu
Based-on: <20180703085358.13941-1-arm...@redhat.com> This work is based on Markus's latest out-of-band fixes: "[PATCH v2 00/32] ] qmp: Fixes and cleanups around OOB commands" Major stuff: some cleanups that were previously suggested by Markus or Eric. Meanwhile fix up the flow control issue.

[Qemu-devel] [PATCH 4/9] monitor: move need_resume flag into monitor struct

2018-07-04 Thread Peter Xu
It was put into the request object to show whether we'll need to resume the monitor after dispatching the command. Now we move that into the monitor struct so that it might be even used in other places in the future, e.g., out-of-band message flow controls. One thing to mention is that there is n

[Qemu-devel] [PATCH 3/9] qapi: remove error checks for event emission

2018-07-04 Thread Peter Xu
In the whole QAPI event emission code we're passing in an Error* object along the whole stack. That's never useful since it never fails after all. Remove that. Then, remove that parameter from all the callers to send an event. Suggested-by: Eric Blake Suggested-by: Markus Armbruster Signed-of

[Qemu-devel] [PATCH 5/9] monitor: suspend monitor instead of send CMD_DROP

2018-07-04 Thread Peter Xu
When we received too many qmp commands, previously we'll send COMMAND_DROPPED events to monitors, then we'll drop the requests. It can only solve the flow control of the request queue, however it'll not really work since we might queue unlimited events in the response queue which is a potential ri

[Qemu-devel] [PATCH 2/9] qapi: allow build_params to return "void"

2018-07-04 Thread Peter Xu
When there is no parameter at all for a function prototype, return "void" for the parameter list. This will happen after the next patch where we removed the Error* for some of the emit functions. Signed-off-by: Peter Xu --- scripts/qapi/common.py | 4 ++-- 1 file changed, 2 insertions(+), 2 del

[Qemu-devel] [PATCH 7/9] monitor: restrict response queue length too

2018-07-04 Thread Peter Xu
Before this patch we were only monitoring the request queue, but it's still possible that a client only sends requests but it never eats any reply from us. In that case our response queue might grow with unlimited responses and put us at risk. Now we play the similar trick as we have done to the

[Qemu-devel] [PATCH 8/9] monitor: remove "x-oob", turn oob on by default

2018-07-04 Thread Peter Xu
OOB commands were introduced in commit cf869d53172. Unfortunately, we ran into a regression, and had to disable them by default for 2.12 (commit be933ffc23). http://lists.gnu.org/archive/html/qemu-devel/2018-03/msg06231.html The regression has since been fixed (commit 951702f39c7 "monitor: bin

[Qemu-devel] [PATCH 6/9] qapi: remove COMMAND_DROPPED event

2018-07-04 Thread Peter Xu
Now it was not used any more. Drop it, especially if we can do that before we release QEMU 3.0. Signed-off-by: Peter Xu --- qapi/misc.json | 40 1 file changed, 40 deletions(-) diff --git a/qapi/misc.json b/qapi/misc.json index f1860418e8..ceda21746b 10

[Qemu-devel] [PATCH 9/9] Revert "tests: Add parameter to qtest_init_without_qmp_handshake"

2018-07-04 Thread Peter Xu
This reverts commit ddee57e0176f6ab53b13c6c97605b62737a8fd7a. Meanwhile, revert one line from fa198ad9bdef to make sure qtest_init_without_qmp_handshake() will only pass in one parameter. Reviewed-by: Markus Armbruster Signed-off-by: Peter Xu --- tests/libqtest.h | 4 +--- tests/libqtest.c |

[Qemu-devel] [PULL v2 00/20] Travis, Code Coverage and Cross Build updates

2018-07-04 Thread Alex Bennée
The following changes since commit 2a018f6e98782a4931b936a3087404ed81685bac: Merge remote-tracking branch 'remotes/berrange/tags/qcrypto-next-pull-request' into staging (2018-07-03 23:06:18 +0100) are available in the Git repository at: https://github.com/stsquad/qemu.git tags/pull-code-c

[Qemu-devel] [PATCH v3 3/5] i386: Add CPUID bit for PCONFIG

2018-07-04 Thread Robert Hoo
PCONFIG: Platform configuration, enumerated by CPUID.(EAX=07H, ECX=0): EDX[bit18]. Signed-off-by: Robert Hoo --- target/i386/cpu.c | 2 +- target/i386/cpu.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 7f787ef..9407071 100644 --

[Qemu-devel] [PATCH v3 2/5] i386: Add CPUID bit and feature words for IA32_ARCH_CAPABILITIES MSR

2018-07-04 Thread Robert Hoo
Support of IA32_PRED_CMD MSR already be enumerated by same CPUID bit as SPEC_CTRL. Signed-off-by: Robert Hoo --- target/i386/cpu.c | 2 +- target/i386/cpu.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index b0b87c3..7f787ef 100644 --

[Qemu-devel] [PATCH v3 5/5] i386: Add new CPU model Icelake-{Server, Client}

2018-07-04 Thread Robert Hoo
New CPU models mostly inherit features from ancestor Skylake, while addin new features: UMIP, New Instructions ( PCONIFIG (server only), WBNOINVD, AVX512_VBMI2, GFNI, AVX512_VNNI, VPCLMULQDQ, VAES, AVX512_BITALG), Intel PT and 5-level paging (Server only). As well as IA32_PRED_CMD, SSBD support for

[Qemu-devel] [PATCH v3 4/5] i386: Add CPUID bit for WBNOINVD

2018-07-04 Thread Robert Hoo
WBNOINVD: Write back and do not invalidate cache, enumerated by CPUID.(EAX=8008H, ECX=0):EBX[bit 9]. Signed-off-by: Robert Hoo --- target/i386/cpu.c | 2 +- target/i386/cpu.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 940

[Qemu-devel] [RFC 1/3] monitor: allow monitor_qapi_event_emit specify mon

2018-07-04 Thread Peter Xu
This is an internal change to allow monitor_qapi_event_emit() to pass in specific monitor to send the event. No functional change. Signed-off-by: Peter Xu --- monitor.c| 37 ++--- trace-events | 2 +- 2 files changed, 27 insertions(+), 12 deletions(-) diff

[Qemu-devel] [RFC 3/3] qapi: provide send/bcast interface for events

2018-07-04 Thread Peter Xu
In the past we were always sending events to all the monitors. In this patch we introduce a new interface to send an event to a specific monitor instance, meanwhile renaming the old function from "send" to "bcast". So for each event, now we have: - qapi_event_send_xxx(Monitor *mon, ...) to send

[Qemu-devel] [PATCH v3 1/5] i386: Add new MSR indices for IA32_PRED_CMD and IA32_ARCH_CAPABILITIES

2018-07-04 Thread Robert Hoo
IA32_PRED_CMD MSR gives software a way to issue commands that affect the state of indirect branch predictors. Enumerated by CPUID.(EAX=7H,ECX=0):EDX[26]. IA32_ARCH_CAPABILITIES MSR enumerates architectural features of RDCL_NO, IBRS_ALL, RSBA, SSB_NO. Enumerated by CPUID.(EAX=07H, ECX=0):EDX[29]. h

[Qemu-devel] [PATCH v3 0/5] Add Icelake CPU model

2018-07-04 Thread Robert Hoo
This patch set defines the new guest CPU models of Icelake. The first patch defines new indices for IA32_PRED_CMD MSR (IBPB) and IA32_ARCH_CAPABILITIES MSR. Other patches add CPUID bits feature words for new features, like PCONFIG, WBNOINVD. The final patch defines Icelake-{Server,Client} CPU mod

[Qemu-devel] [RFC 2/3] monitor: let QMPEventFuncEmit take a monitor arg

2018-07-04 Thread Peter Xu
Let the QMPEventFuncEmit to take an extra Monitor* argument to allow send events to specific monitor in follow-up patches. Now we make the throttling of the events be per-monitor too. There will be a relatively complex scenario where we have an event for both per-monitor and to-all-monitors, plea

[Qemu-devel] [RFC 0/3] monitor: allow per-monitor events

2018-07-04 Thread Peter Xu
This series tries to allow QEMU to send events to specific monitor. Markus told me to send this out before I threw the code away, so I did. Testing only covered compilation and qtest to make sure the broadcast way should be working at least. No real user, no nice testing, no idea on whether it co

Re: [Qemu-devel] [RFC 0/3] monitor: allow per-monitor events

2018-07-04 Thread Peter Xu
On Wed, Jul 04, 2018 at 05:10:35PM +0800, Peter Xu wrote: > This series tries to allow QEMU to send events to specific monitor. > Markus told me to send this out before I threw the code away, so I > did. Testing only covered compilation and qtest to make sure the > broadcast way should be working

Re: [Qemu-devel] [PATCH] qemu-char: check errno together with ret < 0

2018-07-04 Thread Daniel P . Berrangé
On Wed, Jul 04, 2018 at 11:36:42AM +0800, xinhua.Cao wrote: > In the tcp_chr_write function, we checked errno, > but errno was not reset before a read or write operation. > Therefore, this check of errno's actions is often > incorrect after EAGAIN has occurred. > we need check errno together with r

Re: [Qemu-devel] [PULL 35/35] ppc: Include vga cirrus card into the compiling process

2018-07-04 Thread Sebastian Bauer
Hi, Am 2018-07-04 07:56, schrieb Mark Cave-Ayland: Right, but as the patch submitter it's your responsibility to ensure that your patch doesn't break other people's machines and/or follow up with the appropriate patches. If you're not willing to do that then we should revert the patch in its cur

Re: [Qemu-devel] [PATCH] exec.c: check RAMBlock validity before changing its flag

2018-07-04 Thread Paolo Bonzini
On 04/07/2018 08:42, Cédric Le Goater wrote: > On 07/04/2018 04:26 AM, Peter Xu wrote: >> On Tue, Jul 03, 2018 at 02:45:24PM +0200, Cédric Le Goater wrote: >>> On 07/02/2018 05:57 AM, Peter Xu wrote: On Sun, Jul 01, 2018 at 07:19:53PM +0200, Cédric Le Goater wrote: > When a PCI device is u

Re: [Qemu-devel] [PATCH] qemu-char: check errno together with ret < 0

2018-07-04 Thread Marc-André Lureau
On Wed, Jul 4, 2018 at 5:36 AM, xinhua.Cao wrote: > In the tcp_chr_write function, we checked errno, > but errno was not reset before a read or write operation. > Therefore, this check of errno's actions is often > incorrect after EAGAIN has occurred. > we need check errno together with ret < 0. >

Re: [Qemu-devel] [PATCH] qemu-char: check errno together with ret < 0

2018-07-04 Thread Paolo Bonzini
On 04/07/2018 11:36, Marc-André Lureau wrote: > On Wed, Jul 4, 2018 at 5:36 AM, xinhua.Cao wrote: >> In the tcp_chr_write function, we checked errno, >> but errno was not reset before a read or write operation. >> Therefore, this check of errno's actions is often >> incorrect after EAGAIN has occu

Re: [Qemu-devel] [PATCH v2 1/5] i386: Add support for IA32_PRED_CMD and IA32_ARCH_CAPABILITIES MSRs

2018-07-04 Thread Paolo Bonzini
On 04/07/2018 08:33, Robert Hoo wrote: >>> And, if I implemented ARCH_CAPABILITIES-bits features in > FeatureWord, >>> then no necessity of having it in kvm_msr_entries, right? > Hi Paolo, would you confirm this? I mean your previous patch "KVM: VMX: > support MSR_IA32_ARCH_CAPABILITIES as a featur

Re: [Qemu-devel] [PATCH v3 2/5] i386: Add CPUID bit and feature words for IA32_ARCH_CAPABILITIES MSR

2018-07-04 Thread Paolo Bonzini
On 04/07/2018 11:06, Robert Hoo wrote: > Support of IA32_PRED_CMD MSR already be enumerated by same CPUID bit as > SPEC_CTRL. > > Signed-off-by: Robert Hoo > --- > target/i386/cpu.c | 2 +- > target/i386/cpu.h | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/target/i386

[Qemu-devel] [PATCH v3 6/7] sm501: Fix support for non-zero frame buffer start address

2018-07-04 Thread BALATON Zoltan
Display updates and drawing hardware cursor did not work when frame buffer address was non-zero. Fix this by taking the frame buffer address into account in these cases. This fixes screen dragging on AmigaOS. Based on patch by Sebastian Bauer. Signed-off-by: Sebastian Bauer Signed-off-by: BALATON

[Qemu-devel] [PATCH v3 0/7] Misc sm501 improvements

2018-07-04 Thread BALATON Zoltan
Version 3 with changes to 1/7 suggested by Philippe Mathieu-Daudé. Hopefully this haven't missed 3.0 yet. BALATON Zoltan (3): sm501: Implement i2c part for reading monitor EDID sm501: Fix support for non-zero frame buffer start address sm501: Set updated region dirty after 2D operation Seb

[Qemu-devel] [PATCH v3 2/7] sm501: Perform a full update after palette change

2018-07-04 Thread Sebastian Bauer
From: Sebastian Bauer Changing the palette of a color index has as an immediate effect on all pixels with the corresponding index on real hardware. Performing a full update after a palette change is a simple way to emulate this effect. Signed-off-by: Sebastian Bauer Signed-off-by: BALATON Zolta

[Qemu-devel] [PATCH v3 1/7] sm501: Implement i2c part for reading monitor EDID

2018-07-04 Thread BALATON Zoltan
Emulate the i2c part of SM501 which is used to access the EDID info from a monitor. The vmstate structure is changed and its version is increased but SM501 is only used on SH and PPC sam460ex machines that don't support cross-version migration. Signed-off-by: BALATON Zoltan Reviewed-by: Philippe

[Qemu-devel] [PATCH v3 4/7] sm501: Implement negated destination raster operation mode

2018-07-04 Thread Sebastian Bauer
Add support for the negated destination operation mode. This is used e.g. by AmigaOS for the INVERSEVID drawing mode. With this change, the cursor in the shell and non-immediate window adjustment are working now. Signed-off-by: BALATON Zoltan --- hw/display/sm501.c | 12 +++- 1 file chan

[Qemu-devel] [PATCH v3 5/7] sm501: Log unimplemented raster operation modes

2018-07-04 Thread Sebastian Bauer
The sm501 currently implements only a very limited set of raster operation modes. After this change, unknown raster operation modes are logged so these can be easily spotted. Signed-off-by: BALATON Zoltan --- hw/display/sm501.c | 23 +++ 1 file changed, 23 insertions(+) diff

[Qemu-devel] [PATCH v3 3/7] sm501: Use values from the pitch register for 2D operations

2018-07-04 Thread Sebastian Bauer
Before, crt_h_total was used for src_width and dst_width. This is a property of the current display setting and not relevant for the 2D operation that also can be done off-screen. The pitch register's purpose is to describe line pitch relevant of the 2D operation. Signed-off-by: Sebastian Bauer S

Re: [Qemu-devel] [PATCH] exec.c: check RAMBlock validity before changing its flag

2018-07-04 Thread Peter Xu
On Wed, Jul 04, 2018 at 11:34:55AM +0200, Paolo Bonzini wrote: > On 04/07/2018 08:42, Cédric Le Goater wrote: > > On 07/04/2018 04:26 AM, Peter Xu wrote: > >> On Tue, Jul 03, 2018 at 02:45:24PM +0200, Cédric Le Goater wrote: > >>> On 07/02/2018 05:57 AM, Peter Xu wrote: > On Sun, Jul 01, 2018

[Qemu-devel] [PATCH v3 7/7] sm501: Set updated region dirty after 2D operation

2018-07-04 Thread BALATON Zoltan
Set the changed memory region dirty after performed a 2D operation to ensure that the screen is updated properly. Signed-off-by: BALATON Zoltan --- v2: fixed to work with non-zero fb_addr hw/display/sm501.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/h

Re: [Qemu-devel] [PATCH v6 3/5] s390x/ap: base Adjunct Processor (AP) object model

2018-07-04 Thread Cornelia Huck
On Fri, 29 Jun 2018 18:48:01 -0400 Tony Krowiak wrote: > From: Tony Krowiak You may want to switch your sending address to this one as well. > > Introduces the base object model for virtualizing AP devices. > > Signed-off-by: Tony Krowiak > --- > MAINTAINERS | 12 +++

Re: [Qemu-devel] [PATCH v3 0/7] Misc sm501 improvements

2018-07-04 Thread David Gibson
On Wed, Jul 04, 2018 at 11:40:58AM +0200, BALATON Zoltan wrote: > Version 3 with changes to 1/7 suggested by Philippe Mathieu-Daudé. > Hopefully this haven't missed 3.0 yet. It has, sorry. Applied to ppc-for-3.1. > > BALATON Zoltan (3): > sm501: Implement i2c part for reading monitor EDID >

Re: [Qemu-devel] [PULL 00/20] Travis, Code Coverage and Cross Build updates

2018-07-04 Thread Alex Bennée
Alex Bennée writes: > The following changes since commit 46d0885adff9b99622d72f23a8b04c298a8bf91d: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2018-07-03 09:49:20 +0100) > > are available in the Git repository at: > > https://github.com/stsquad/qemu.git

Re: [Qemu-devel] [PATCH v2 0/7] Misc sm501 improvements

2018-07-04 Thread BALATON Zoltan
On Wed, 4 Jul 2018, Philippe Mathieu-Daudé wrote: Hi David, I'll reply to you using Peter mail :) Thanks a lot for this summary and your review spotting an error. I forgot about Gerd's OK as he did not send formal Reviewed or Acked but you're right that's also counts to show that the series s

Re: [Qemu-devel] [Qemu-ppc] [PULL 35/35] ppc: Include vga cirrus card into the compiling process

2018-07-04 Thread BALATON Zoltan
On Wed, 4 Jul 2018, Sebastian Bauer wrote: Am 2018-07-04 06:50, schrieb Mark Cave-Ayland: Either to give up the vga cirrus preference or to apply the same as was done with the spapr machine. I would prefer the first variant but it would also cause some differences on other machines. I underst

Re: [Qemu-devel] [PATCH 2/2] block/backup: fix fleecing scheme: use serialized writes

2018-07-04 Thread Kevin Wolf
Am 03.07.2018 um 20:07 hat Vladimir Sementsov-Ogievskiy geschrieben: > Fleecing scheme works as follows: we want a kind of temporary snapshot > of active drive A. We create temporary image B, with B->backing = A. > Then we start backup(sync=none) from A to B. From this point, B reads > as point-in-

[Qemu-devel] [Bug 1191326] Re: QNX 4 doesn't boot on qemu >= 1.3

2018-07-04 Thread Gerd Hoffmann
qemu git master has a prebuilt seabios with CONFIG_ATA_DMA=y now. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1191326 Title: QNX 4 doesn't boot on qemu >= 1.3 Status in QEMU: Confirmed Bug de

Re: [Qemu-devel] [PATCH] qemu-char: check errno together with ret < 0

2018-07-04 Thread Markus Armbruster
xinhua.Cao writes: > In the tcp_chr_write function, we checked errno, > but errno was not reset before a read or write operation. > Therefore, this check of errno's actions is often > incorrect after EAGAIN has occurred. > we need check errno together with ret < 0. > > Signed-off-by: xinhua.Cao

[Qemu-devel] [PATCH] chardev: unconditionally set FD_PASS feature for socket type=fd

2018-07-04 Thread Daniel P . Berrangé
The vhostuser network backend requires the chardev it is using to have the FD passing feature. It checks this upfront when initializing the network backend and reports an error if not set. The socket chardev has to set the FD_PASS feature during early initialization to satisfy the vhostuser backen

[Qemu-devel] [PATCH 1/2] nbd/server: fix nbd_co_send_block_status

2018-07-04 Thread Vladimir Sementsov-Ogievskiy
Call nbd_co_send_extents() with correct length parameter (extent.length may be smaller than original length). Also, switch length parameter type to uint32_t, to correspond with request->len and similar nbd_co_send_bitmap(). Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/server.c | 5 +++--

[Qemu-devel] [PATCH 2/2] nbd/server: send more than one extent of base:allocation context

2018-07-04 Thread Vladimir Sementsov-Ogievskiy
This is necessary for efficient block-status export, for clients which support it. Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/server.c | 77 +--- 1 file changed, 58 insertions(+), 19 deletions(-) diff --git a/nbd/server.c b/nbd/se

[Qemu-devel] [PATCH 0/2] nbd base:allocation several extents

2018-07-04 Thread Vladimir Sementsov-Ogievskiy
Hi all! Patch 01 is a fix an should definitely go to 3.0. Patch 02 is an improvement, so as you want, 3.1 is ok. The idea is send more than one extent of base:allocation context, if possible, which is necessary for efficient block-status export, for clients which support it. Vladimir Sementsov-O

Re: [Qemu-devel] [PATCH v6 4/5] s390x/vfio: ap: Introduce VFIO AP device

2018-07-04 Thread Cornelia Huck
On Fri, 29 Jun 2018 18:48:02 -0400 Tony Krowiak wrote: > Introduces a VFIO based AP device. The device is defined via > the QEMU command line by specifying: > > -device vfio-ap,sysfsdev= > > There may be only one vfio-ap device configured for a guest. > > The mediated matrix device is crea

[Qemu-devel] [PATCH] vga: make stdvga the global default

2018-07-04 Thread Gerd Hoffmann
This reverts the stdvga vs. cirrus selection logic. Current state is that "cirrus" is the default and MachineClass->default_display is set to "std" by some machine types to override that. The patch makes "std" the default. Setting default_display to "std" is dropped. Machine types which likely

[Qemu-devel] [PATCH] block: Don't silently truncate node names

2018-07-04 Thread Kevin Wolf
If the user passes a too long node name string, we silently truncate it to fit into BlockDriverState.node_name, i.e. to 31 characters. Apart from surprising the user when the node has a different name than requested, this also bypasses the check for duplicate names, so that the same name can be ass

Re: [Qemu-devel] [RFC v3 07/15] hw/arm/virt: Add memory hotplug framework

2018-07-04 Thread David Hildenbrand
On 03.07.2018 21:34, Auger Eric wrote: > Hi David, > > On 07/03/2018 08:44 PM, David Hildenbrand wrote: >> On 03.07.2018 09:19, Eric Auger wrote: >>> From: Shameer Kolothum >>> >>> This patch adds the the memory hot-plug/hot-unplug infrastructure >>> in machvirt. >>> >>> Signed-off-by: Eric Auger

[Qemu-devel] [PATCH] hw/machine: Remove the Zero check of nb_numa_nodes

2018-07-04 Thread Dou Liyang
Commit 7a3099fc9c5c("numa: postpone options post-processing till machine_run_board_init()") broke the commit 7b8be49d36fc("NUMA: Enable adding NUMA node implicitly"). The machine_run_board_init() doesn't do NUMA setup if nb_numa_nodes=0. Due to the NUMA setup will also check the value of nb_numa

Re: [Qemu-devel] [PATCH] chardev: unconditionally set FD_PASS feature for socket type=fd

2018-07-04 Thread Paolo Bonzini
On 04/07/2018 13:11, Daniel P. Berrangé wrote: > The vhostuser network backend requires the chardev it is using to have > the FD passing feature. It checks this upfront when initializing the > network backend and reports an error if not set. > > The socket chardev has to set the FD_PASS feature du

Re: [Qemu-devel] [RFC v3 05/15] hw/arm/virt: handle max_vm_phys_shift conflicts on migration

2018-07-04 Thread David Hildenbrand
On 03.07.2018 21:32, Auger Eric wrote: > Hi David, > On 07/03/2018 08:41 PM, David Hildenbrand wrote: >> On 03.07.2018 09:19, Eric Auger wrote: >>> When migrating a VM, we must make sure the destination host >>> supports as many IPA bits as the source. Otherwise the migration >>> must fail. >>> >>>

[Qemu-devel] [PATCH] ioapic: remove useless lower bounds check

2018-07-04 Thread Paolo Bonzini
The vector cannot be negative. Coverity now reports this because it sees an array access before the check, in ioapic_stat_update_irq. Signed-off-by: Paolo Bonzini --- hw/intc/ioapic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c index b

[Qemu-devel] [PATCH] pr-manager-helper: fix memory leak on event

2018-07-04 Thread Paolo Bonzini
Reported by Coverity. Signed-off-by: Paolo Bonzini --- scsi/pr-manager-helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/scsi/pr-manager-helper.c b/scsi/pr-manager-helper.c index 519a296905..3027dde60d 100644 --- a/scsi/pr-manager-helper.c +++ b/scsi/pr-manager-helper.c @@ -46,6 +46,7

Re: [Qemu-devel] [RFC v3 06/15] hw/arm/virt: Allocate device_memory

2018-07-04 Thread David Hildenbrand
On 03.07.2018 21:27, Auger Eric wrote: > Hi David, > On 07/03/2018 08:25 PM, David Hildenbrand wrote: >> On 03.07.2018 09:19, Eric Auger wrote: >>> We define a new hotpluggable RAM region (aka. device memory). >>> Its base is 2TB GPA. This obviously requires 42b IPA support >>> in KVM/ARM, FW and g

Re: [Qemu-devel] [PATCH] chardev: unconditionally set FD_PASS feature for socket type=fd

2018-07-04 Thread Daniel P . Berrangé
On Wed, Jul 04, 2018 at 01:53:03PM +0200, Paolo Bonzini wrote: > On 04/07/2018 13:11, Daniel P. Berrangé wrote: > > The vhostuser network backend requires the chardev it is using to have > > the FD passing feature. It checks this upfront when initializing the > > network backend and reports an erro

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-04 Thread Cornelia Huck
On Tue, 3 Jul 2018 16:31:03 -0700 Siwei Liu wrote: > On Tue, Jul 3, 2018 at 7:52 AM, Cornelia Huck wrote: > > From my point of view, there are several concerns: > > - This approach assumes a homogeneous pairing (same transport), and > > even more, it assumes that this transport is pci. > >

Re: [Qemu-devel] [PATCH] exec.c: check RAMBlock validity before changing its flag

2018-07-04 Thread Paolo Bonzini
On 04/07/2018 11:55, Peter Xu wrote: >> commit b0e56e0b63f350691b52d3e75e89bb64143fbeff >> Author: Hu Tao >> Date: Wed Apr 2 15:13:27 2014 +0800 >> >> unset RAMBlock idstr when unregister MemoryRegion >> >> Signed-off-by: Hu Tao >> Signed-off-by: Paolo Bonzini >> >> who

Re: [Qemu-devel] [PATCH V9 12/20] qapi: Add new command to query colo status

2018-07-04 Thread Zhang Chen
On Tue, Jul 3, 2018 at 7:09 PM, Markus Armbruster wrote: > Zhang Chen writes: > > > Libvirt or other high level software can use this command query colo > status. > > You can test this command like that: > > {'execute':'query-colo-status'} > > > > Signed-off-by: Zhang Chen > > --- > > migratio

Re: [Qemu-devel] [PATCH 2/2] block/backup: fix fleecing scheme: use serialized writes

2018-07-04 Thread Vladimir Sementsov-Ogievskiy
04.07.2018 13:39, Kevin Wolf wrote: Am 03.07.2018 um 20:07 hat Vladimir Sementsov-Ogievskiy geschrieben: Fleecing scheme works as follows: we want a kind of temporary snapshot of active drive A. We create temporary image B, with B->backing = A. Then we start backup(sync=none) from A to B. From t

[Qemu-devel] 32-bit “qemu-system-i386 -enable-kvm” segfaults on x86_64

2018-07-04 Thread Ludovic Courtès
Hello, (I’m reporting the issue here because for some reason the launchpad.net login page redirects me to an “oops” page and fails to log me in.) On a Linux 4.17 x86_64 host, “qemu-system-i386 -enable-kvm”, where qemu-system-i386 is a 32-bit binary, crashes (it works fine without ‘-enable-kvm’):

[Qemu-devel] [RFC PATCH 1/6] hw/arm/virt: Add virt-3.1 machine type

2018-07-04 Thread Andrew Jones
Signed-off-by: Andrew Jones --- hw/arm/virt.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 281ddcdf6e26..880441275031 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -1757,10 +1757,7 @@ static void machvirt_machin

[Qemu-devel] [RFC PATCH 5/6] virt-acpi-build: add PPTT table

2018-07-04 Thread Andrew Jones
The ACPI PPTT table supports topology descriptions for ACPI guests. Note, while a DT boot Linux guest with a non-flat CPU topology will see socket and core IDs being sequential integers starting from zero, e.g. with -smp 4,sockets=2,cores=2,threads=1 a DT boot produces cpu: 0 package_id: 0 cor

[Qemu-devel] [RFC PATCH 2/6] device_tree: add qemu_fdt_add_path

2018-07-04 Thread Andrew Jones
qemu_fdt_add_path works like qemu_fdt_add_subnode, except it also recursively adds any missing parent nodes. Cc: Peter Crosthwaite Cc: Alexander Graf Signed-off-by: Andrew Jones --- device_tree.c| 24 include/sysemu/device_tree.h | 1 + 2 files changed

[Qemu-devel] [RFC PATCH 0/6] hw/arm/virt: Introduce cpu topology support

2018-07-04 Thread Andrew Jones
This series provides support for booting mach-virt machines with non-flat cpu topology, i.e. enabling the extended options of the '-smp' command line parameter (sockets,cores,threads). Both DT and ACPI description generators are added. We only apply the new feature to 3.1 and later machine types, a

Re: [Qemu-devel] [RFC v3 05/15] hw/arm/virt: handle max_vm_phys_shift conflicts on migration

2018-07-04 Thread Auger Eric
Hi David, On 07/04/2018 01:53 PM, David Hildenbrand wrote: > On 03.07.2018 21:32, Auger Eric wrote: >> Hi David, >> On 07/03/2018 08:41 PM, David Hildenbrand wrote: >>> On 03.07.2018 09:19, Eric Auger wrote: When migrating a VM, we must make sure the destination host supports as many IPA

[Qemu-devel] [RFC PATCH 6/6] hw/arm/virt: cpu topology: don't allow threads

2018-07-04 Thread Andrew Jones
None of the cpu models supported by mach-virt support threads. Furthermore when running with KVM and cpu=host, while the host processor may support threads, we don't yet support telling KVM that we want the guest to see that. So if the user tries to select more than one thread for the cpu topology,

[Qemu-devel] [RFC PATCH 3/6] hw/arm/virt: DT: add cpu-map

2018-07-04 Thread Andrew Jones
Support devicetree CPU topology descriptions. Signed-off-by: Andrew Jones --- hw/arm/virt.c | 35 +++ include/hw/arm/virt.h | 1 + 2 files changed, 36 insertions(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 880441275031..6c5fecdd61df 100644 --- a/

[Qemu-devel] [RFC PATCH 4/6] hw/arm/virt-acpi-build: distinguish possible and present cpus

2018-07-04 Thread Andrew Jones
When building ACPI tables regarding CPUs we should always build them for the number of possible CPUs, not the number of present CPUs. We then ensure only the present CPUs are enabled. Signed-off-by: Andrew Jones --- hw/arm/virt-acpi-build.c | 20 +++- 1 file changed, 15 insertion

Re: [Qemu-devel] question: disk missing in the guest contingently when hotplug several virtio scsi disks consecutively.

2018-07-04 Thread Paolo Bonzini
On 03/07/2018 15:30, l00284672 wrote: > I got a solution, the patch is below: > > diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c > index 608fb18..4cdc2bb 100644 > --- a/hw/scsi/scsi-disk.c > +++ b/hw/scsi/scsi-disk.c > @@ -2184,7 +2184,9 @@ static void scsi_disk_reset(DeviceState *dev) >  

Re: [Qemu-devel] [PATCH] hw/machine: Remove the Zero check of nb_numa_nodes

2018-07-04 Thread Dou Liyang
At 07/04/2018 07:52 PM, Dou Liyang wrote: Commit 7a3099fc9c5c("numa: postpone options post-processing till machine_run_board_init()") broke the commit 7b8be49d36fc("NUMA: Enable adding NUMA node implicitly"). The machine_run_board_init() doesn't do NUMA setup if nb_numa_nodes=0. Due to the

[Qemu-devel] [PATCH] block/crypto: Fix memory leak in create error path

2018-07-04 Thread Kevin Wolf
Fixes: Coverity CID 1393782 Signed-off-by: Kevin Wolf --- block/crypto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/crypto.c b/block/crypto.c index 994172a3de..146d81c90a 100644 --- a/block/crypto.c +++ b/block/crypto.c @@ -551,7 +551,7 @@ static int coroutine_fn b

Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-04 Thread Cornelia Huck
On Tue, 3 Jul 2018 13:32:29 +0200 Kevin Wolf wrote: > > > > Has serial/gemoetry been fixed meanwhile and will it make it into the > > > > next release? > > > > > > I cannot find an archive that has it, but it is on the libvirt mailing > > > list as "[libvirt] [PATCH v3] qemu: format serial and

Re: [Qemu-devel] 32-bit “qemu-system-i386 -enable-kvm” segfaults on x86_64

2018-07-04 Thread Daniel P . Berrangé
On Wed, Jul 04, 2018 at 02:34:07PM +0200, Ludovic Courtès wrote: > Hello, > > (I’m reporting the issue here because for some reason the launchpad.net > login page redirects me to an “oops” page and fails to log me in.) > > On a Linux 4.17 x86_64 host, “qemu-system-i386 -enable-kvm”, where > qemu-

Re: [Qemu-devel] [PATCH] block/crypto: Fix memory leak in create error path

2018-07-04 Thread Daniel P . Berrangé
On Wed, Jul 04, 2018 at 02:58:02PM +0200, Kevin Wolf wrote: > Fixes: Coverity CID 1393782 > Signed-off-by: Kevin Wolf > --- > block/crypto.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/crypto.c b/block/crypto.c > index 994172a3de..146d81c90a 100644 > --- a/bloc

[Qemu-devel] [PATCH] kvm: x86: Add support for -machine split-lock-ac

2018-07-04 Thread Jingqi Liu
Add the option split-lock-ac to control whether the #AC exception is generated for split locked accesses, which is introduced for the machine, there is an example to enable it: -machine split-lock-ac=on It is disabled on default. When bit 29 of the MSR (33H) is set, the processor causes an #AC exc

Re: [Qemu-devel] [PATCH 2/2] block/backup: fix fleecing scheme: use serialized writes

2018-07-04 Thread Vladimir Sementsov-Ogievskiy
04.07.2018 13:39, Kevin Wolf wrote: Am 03.07.2018 um 20:07 hat Vladimir Sementsov-Ogievskiy geschrieben: Fleecing scheme works as follows: we want a kind of temporary snapshot of active drive A. We create temporary image B, with B->backing = A. Then we start backup(sync=none) from A to B. From t

[Qemu-devel] [PATCH] i386: Add support to get/set/migrate MSR (33H)

2018-07-04 Thread Jingqi Liu
The MSR (33H) controls support for #AC exception for split locked accesses. When bit 29 of the MSR (33H) is set, the processor causes an #AC exception to be issued instead of suppressing LOCK on bus (during split lock access). Signed-off-by: Jingqi Liu --- target/i386/cpu.h | 2 ++ target/i

[Qemu-devel] [PATCH v2] hw/machine: Remove the Zero check of nb_numa_nodes for numa_complete_configuration()

2018-07-04 Thread Dou Liyang
Commit 7a3099fc9c5c("numa: postpone options post-processing till machine_run_board_init()") broke the commit 7b8be49d36fc("NUMA: Enable adding NUMA node implicitly"). The machine_run_board_init() doesn't do NUMA setup if nb_numa_nodes=0, but the numa_complete_configuration need add a new node if

Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-04 Thread Kevin Wolf
Am 04.07.2018 um 15:02 hat Cornelia Huck geschrieben: > On Tue, 3 Jul 2018 13:32:29 +0200 > Kevin Wolf wrote: > > > > > > Has serial/gemoetry been fixed meanwhile and will it make it into the > > > > > next release? > > > > > > > > I cannot find an archive that has it, but it is on the libvirt

Re: [Qemu-devel] [PATCH] kvm: x86: Add support for -machine split-lock-ac

2018-07-04 Thread Paolo Bonzini
On 04/07/2018 15:12, Jingqi Liu wrote: > Add the option split-lock-ac to control whether the #AC > exception is generated for split locked accesses, which > is introduced for the machine, there is an example to enable it: > -machine split-lock-ac=on > It is disabled on default. > > When bit 29 of

Re: [Qemu-devel] [PATCH] i386: Add support to get/set/migrate MSR (33H)

2018-07-04 Thread Paolo Bonzini
On 04/07/2018 15:21, Jingqi Liu wrote: > The MSR (33H) controls support for #AC exception > for split locked accesses. When bit 29 of the MSR (33H) > is set, the processor causes an #AC exception to > be issued instead of suppressing LOCK on bus > (during split lock access). > > Signed-off-by: Jin

Re: [Qemu-devel] [PATCH for-3.1 0/7] target/ppc fp cleanups

2018-07-04 Thread Programmingkid
> On Jul 3, 2018, at 11:31 PM, David Gibson wrote: > > On Tue, Jul 03, 2018 at 08:17:25AM -0700, Richard Henderson wrote: >> Beginning with John Arbuckle's fdiv test case, clean up some >> of the fp helpers. As with fdiv, fre and fresqrt are missing >> divide-by-zero exceptions. >> >> I've al

Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-04 Thread Daniel P . Berrangé
On Wed, Jul 04, 2018 at 03:34:40PM +0200, Kevin Wolf wrote: > Am 04.07.2018 um 15:02 hat Cornelia Huck geschrieben: > > On Tue, 3 Jul 2018 13:32:29 +0200 > > Kevin Wolf wrote: > > > > > > > > Has serial/gemoetry been fixed meanwhile and will it make it into > > > > > > the > > > > > > next relea

Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-04 Thread Christian Borntraeger
On 07/04/2018 03:34 PM, Kevin Wolf wrote: > Am 04.07.2018 um 15:02 hat Cornelia Huck geschrieben: >> On Tue, 3 Jul 2018 13:32:29 +0200 >> Kevin Wolf wrote: >> >> Has serial/gemoetry been fixed meanwhile and will it make it into the >> next release? > > I cannot find an archive

  1   2   3   >