Re: [Qemu-devel] [PATCH v2 3/4] ppc/pnv: introduce Pnv8Chip and Pnv9Chip models

2018-06-25 Thread Cédric Le Goater
On 06/25/2018 08:36 AM, David Gibson wrote: > On Wed, Jun 20, 2018 at 07:29:37AM +0200, Cédric Le Goater wrote: >> On 06/20/2018 02:56 AM, David Gibson wrote: >>> On Tue, Jun 19, 2018 at 07:24:44AM +0200, Cédric Le Goater wrote: >>> typedef struct PnvChipClass { >>> /*< private >

Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-25 Thread Peter Krempa
On Fri, Jun 22, 2018 at 14:55:02 +0200, Kevin Wolf wrote: > Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: > > > > On 06/15/2018 04:21 PM, Kevin Wolf wrote: > > > The -drive option serial was deprecated in QEMU 2.10. It's time to > > > remove it. > > > > > > Tests need to be update

Re: [Qemu-devel] s390 qemu boot failure in -next

2018-06-25 Thread Christian Borntraeger
Also adding QEMU. On 06/25/2018 09:10 AM, Christian Borntraeger wrote: > > > On 06/22/2018 09:47 PM, Guenter Roeck wrote: >> Hi, >> >> starting with commit 's390/boot: make head.S and als.c be part of the >> decompressor only' in -next, s390 immages no longer boot in qemu. >> As far as I can see

Re: [Qemu-devel] [PATCH 1/2] sysbus: always allow explicit_ofw_unit_address() to override address generation

2018-06-25 Thread Laszlo Ersek
Hi Mark, On 06/23/18 10:50, Mark Cave-Ayland wrote: > Some SysBusDevices either use sysbus_init_mmio() without sysbus_mmio_map() or > the first MMIO memory region doesn't represent the bus address, causing an > invalid > firmware device path to be generated. > > SysBusDeviceClass does provide a

Re: [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-25 Thread Thomas Huth
On 22.06.2018 16:25, Kevin Wolf wrote: > Am 22.06.2018 um 15:36 hat Christian Borntraeger geschrieben: >> >> >> On 06/22/2018 02:55 PM, Kevin Wolf wrote: >>> Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: On 06/15/2018 04:21 PM, Kevin Wolf wrote: > The -drive option ser

[Qemu-devel] [Bug 1778473] [NEW] [Crash] qemu-system-x86_64: mov_ss_trap_64 PANIC: double fault, error_code: 0x0

2018-06-25 Thread Naresh Kamboju
Public bug reported: Kselftest test case mov_ss_trap_64 is causing kernel panic on qemu-system-x86_64 and PASS on real x86_64 hardware. qemu-system-x86_64 version is 2.12.0 host architecture: amd64 Test failed on recent stable rc kernel, 4.17.3-rc1, 4.16.18-rc1 and 4.14.52-rc1. Test code snipp

Re: [Qemu-devel] [qemu-s390x] s390 qemu boot failure in -next

2018-06-25 Thread Christian Borntraeger
On 06/25/2018 09:27 AM, Christian Borntraeger wrote: > Also adding QEMU. > > On 06/25/2018 09:10 AM, Christian Borntraeger wrote: >> >> >> On 06/22/2018 09:47 PM, Guenter Roeck wrote: >>> Hi, >>> >>> starting with commit 's390/boot: make head.S and als.c be part of the >>> decompressor only' in

Re: [Qemu-devel] s390 qemu boot failure in -next

2018-06-25 Thread Cornelia Huck
On Mon, 25 Jun 2018 09:27:59 +0200 Christian Borntraeger wrote: > Also adding QEMU. > > On 06/25/2018 09:10 AM, Christian Borntraeger wrote: > > > > > > On 06/22/2018 09:47 PM, Guenter Roeck wrote: > >> Hi, > >> > >> starting with commit 's390/boot: make head.S and als.c be part of the > >>

Re: [Qemu-devel] [qemu-s390x] s390 qemu boot failure in -next

2018-06-25 Thread Cornelia Huck
On Mon, 25 Jun 2018 10:02:28 +0200 Christian Borntraeger wrote: > On 06/25/2018 09:27 AM, Christian Borntraeger wrote: > > Also adding QEMU. > > > > On 06/25/2018 09:10 AM, Christian Borntraeger wrote: > >> > >> > >> On 06/22/2018 09:47 PM, Guenter Roeck wrote: > >>> Hi, > >>> > >>> starting

Re: [Qemu-devel] [PATCH] docs: add guidance on configuring CPU models for x86

2018-06-25 Thread Kashyap Chamarthy
On Mon, Jun 18, 2018 at 08:03:32AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Fri, Jun 15, 2018 at 03:16:09PM +0100, Daniel P. Berrangé wrote: > >> With the recent set of CPU hardware vulnerabilities on x86, it is > >> increasingly difficult to understand which CPU configu

Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-25 Thread Thomas Huth
On 25.06.2018 09:16, Peter Krempa wrote: > On Fri, Jun 22, 2018 at 14:55:02 +0200, Kevin Wolf wrote: >> Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: >>> >>> On 06/15/2018 04:21 PM, Kevin Wolf wrote: The -drive option serial was deprecated in QEMU 2.10. It's time to remove

Re: [Qemu-devel] [PATCH] docs: add guidance on configuring CPU models for x86

2018-06-25 Thread Kashyap Chamarthy
On Mon, Jun 25, 2018 at 10:18:59AM +0200, Kashyap Chamarthy wrote: > On Mon, Jun 18, 2018 at 08:03:32AM +0200, Markus Armbruster wrote: > > Eduardo Habkost writes: [...] > > Texinfo is simple. > > > > If all else fails, ask for my help after soft freeze. > > If someone already hasn't done it,

Re: [Qemu-devel] [qemu-s390x] s390 qemu boot failure in -next

2018-06-25 Thread Thomas Huth
On 25.06.2018 10:02, Christian Borntraeger wrote: > > > On 06/25/2018 09:27 AM, Christian Borntraeger wrote: >> Also adding QEMU. >> >> On 06/25/2018 09:10 AM, Christian Borntraeger wrote: >>> >>> >>> On 06/22/2018 09:47 PM, Guenter Roeck wrote: Hi, starting with commit 's390/boot:

Re: [Qemu-devel] s390 qemu boot failure in -next

2018-06-25 Thread Christian Borntraeger
On 06/25/2018 10:05 AM, Cornelia Huck wrote: > On Mon, 25 Jun 2018 09:27:59 +0200 > Christian Borntraeger wrote: > >> Also adding QEMU. >> >> On 06/25/2018 09:10 AM, Christian Borntraeger wrote: >>> >>> >>> On 06/22/2018 09:47 PM, Guenter Roeck wrote: Hi, starting with commit

Re: [Qemu-devel] [PATCH v3] loader: Check access size when calling rom_ptr() to avoid crashes

2018-06-25 Thread Thomas Huth
On 15.06.2018 11:49, Thomas Huth wrote: > The rom_ptr() function allows direct access to the ROM blobs that we > load during startup. However, there are currently no checks for the > size of the accesses, so it's currently possible to crash QEMU for > example with: > > $ echo "Insane in the mainfr

Re: [Qemu-devel] [PATCH v5 1/2] kvm: support -overcommit cpu-pm=on|off

2018-06-25 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > With this flag, kvm allows guest to control host CPU power state. This > increases latency for other processes using same host CPU in an > unpredictable way, but if decreases idle entry/exit times for the > running VCPU, so to use it QEMU needs a hint about whether h

Re: [Qemu-devel] s390 qemu boot failure in -next

2018-06-25 Thread Cornelia Huck
On Mon, 25 Jun 2018 10:36:33 +0200 Vasily Gorbik wrote: > This change has been done on purpose. Uncompressed image is not going > to be bootable any more. In future the decompressor phase would get > more function (early memory detection as an example) and there is no > chance to duplicate that c

Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] file-posix: Make .bdrv_co_truncate asynchronous

2018-06-25 Thread Stefan Hajnoczi
On Thu, Jun 21, 2018 at 07:06:57PM +0200, Kevin Wolf wrote: > +RawPosixAIOData *acb = g_new(RawPosixAIOData, 1); > +ThreadPool *pool; > > -out: > -if (result < 0) { > -if (ftruncate(fd, current_length) < 0) { > -error_report("Failed to restore old file length: %s",

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] block: Convert .bdrv_truncate callback to coroutine_fn

2018-06-25 Thread Stefan Hajnoczi
On Thu, Jun 21, 2018 at 07:06:56PM +0200, Kevin Wolf wrote: > bdrv_truncate() is an operation that can block (even for a quite long > time, depending on the PreallocMode) in I/O paths that shouldn't block. > Convert it to a coroutine_fn so that we have the infrastructure for > drivers to make their

Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-25 Thread Daniel P . Berrangé
On Mon, Jun 25, 2018 at 10:23:03AM +0200, Thomas Huth wrote: > On 25.06.2018 09:16, Peter Krempa wrote: > > On Fri, Jun 22, 2018 at 14:55:02 +0200, Kevin Wolf wrote: > >> Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: > >>> > >>> On 06/15/2018 04:21 PM, Kevin Wolf wrote: > The -

[Qemu-devel] [PATCH v4] hw/i386: Deprecate the machine types pc-0.10 and pc-0.11

2018-06-25 Thread Thomas Huth
The oldest machine type which is still used in a still maintained distro is a pc-0.12 based machine type in RHEL6, so everything that is older than pc-0.12 should not be used anymore. Thus let's deprecate pc-0.10 and pc-0.11 so that we can finally remove them in a future release. Reviewed-by: Edua

Re: [Qemu-devel] [PATCH] hw/arm/virt: fix psci conduit in acpi when el3 enabled

2018-06-25 Thread Peter Maydell
On 25 June 2018 at 05:06, Hongbo Zhang wrote: > Hi Peter, > Yes, your considerations reasonable. > But in practice of hardware platforms, programmer checks that Arm TF > is using SMC for PSCI call conduit, then fix it manually in the ACPI > table, reason may be that Arm TF is lack of ACPI support,

Re: [Qemu-devel] [RFC PATCH v2 0/7] QEMU binary instrumentation prototype

2018-06-25 Thread Peter Maydell
On 25 June 2018 at 06:46, Pavel Dovgalyuk wrote: > Peter, what about this one? Yeah, sorry about this. It's on my queue of things to look at, but more immediate work and review has taken precedence :-( thanks -- PMM

[Qemu-devel] [PATCH v2 1/5] ppc/xics: introduce a parent_realize in ICSStateClass

2018-06-25 Thread Cédric Le Goater
This makes possible to move the common ICSState code of the realize handlers in the ics-base class. Signed-off-by: Cédric Le Goater --- include/hw/ppc/xics.h | 3 ++- hw/intc/xics.c| 37 ++--- hw/intc/xics_kvm.c| 20 +++- 3 files chang

[Qemu-devel] [PATCH v2 0/5] rework the ICS classes inheritance tree

2018-06-25 Thread Cédric Le Goater
Hello, It makes the class hierarchy much cleaner and removes duplicated code. As we are touching the location of the objects states, migration compatibility was checked and the following tests were performed under KVM : qemu-3.0 (pseries-3.0) -> qemu-3.0 (pseries-3.0) OK qemu-3.0 (pserie

[Qemu-devel] [PATCH v2 2/5] ppc/xics: move the instance_init handler under the ics-base class

2018-06-25 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/intc/xics.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/intc/xics.c b/hw/intc/xics.c index d6066d561fdc..83340770f7c0 100644 --- a/hw/intc/xics.c +++ b/hw/intc/xics.c @@ -611,13 +611,6 @@ static const VMStateDescri

Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] file-posix: Make .bdrv_co_truncate asynchronous

2018-06-25 Thread Kevin Wolf
Am 25.06.2018 um 10:56 hat Stefan Hajnoczi geschrieben: > On Thu, Jun 21, 2018 at 07:06:57PM +0200, Kevin Wolf wrote: > > +RawPosixAIOData *acb = g_new(RawPosixAIOData, 1); > > +ThreadPool *pool; > > > > -out: > > -if (result < 0) { > > -if (ftruncate(fd, current_length) < 0)

[Qemu-devel] [PATCH v2 4/5] ppc/xics: move the vmstate structures under the ics-base class

2018-06-25 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/intc/xics.c | 112 - 1 file changed, 56 insertions(+), 56 deletions(-) diff --git a/hw/intc/xics.c b/hw/intc/xics.c index 8cfe2231531e..b9f1a3c97214 100644 --- a/hw/intc/xics.c +++ b/hw/intc/xics.c @@

[Qemu-devel] [PATCH v2 5/5] ppc/xics: rework the ICS classes inheritance tree

2018-06-25 Thread Cédric Le Goater
With the previous changes, we can now let the ICS_KVM class inherit directly from ICS_BASE class and not from the intermediate ICS_SIMPLE. It makes the class hierarchy much cleaner. What is left in the top classes is the low level interface to access the KVM XICS device in ICS_KVM and the XICS emu

[Qemu-devel] [PATCH v2 3/5] ppx/xics: introduce a parent_reset in ICSStateClass

2018-06-25 Thread Cédric Le Goater
Just like for the realize handlers, this makes possible to move the common ICSState code of the reset handlers in the ics-base class. Signed-off-by: Cédric Le Goater --- include/hw/ppc/xics.h | 1 + hw/intc/xics.c| 45 ++--- hw/intc/xics_kvm.c

[Qemu-devel] Why qom-get is not available in qemu monitor

2018-06-25 Thread Dongli Zhang
Hi, Would you mind help confirm why qom-get command is not supported by qemu monitor, but only qapi? Is this a feature (qom-get in monitor) totally useless for some reason, or it is still not implemented yet? Thank you very much! Dongli Zhang

Re: [Qemu-devel] [PATCH v4] hw/i386: Deprecate the machine types pc-0.10 and pc-0.11

2018-06-25 Thread Markus Armbruster
Thomas Huth writes: > The oldest machine type which is still used in a still maintained distro > is a pc-0.12 based machine type in RHEL6, so everything that is older > than pc-0.12 should not be used anymore. Thus let's deprecate pc-0.10 > and pc-0.11 so that we can finally remove them in a futu

Re: [Qemu-devel] [Qemu-ppc] [PATCH v5 1/4] ppc4xx_i2c: Rewrite to model hardware more closely

2018-06-25 Thread Cédric Le Goater
On 06/24/2018 10:37 PM, BALATON Zoltan wrote: > Hello, > > On Sun, 24 Jun 2018, Cédric Le Goater wrote: >> On 06/24/2018 01:20 PM, BALATON Zoltan wrote: >>> Rewrite to make it closer to how real device works so that guest OS >>> drivers can access I2C devices. Previously this was only a hack to >>

Re: [Qemu-devel] [PATCH v4 4/5] acpi: build TPM Physical Presence interface

2018-06-25 Thread Igor Mammedov
On Fri, 22 Jun 2018 10:23:05 -0400 Stefan Berger wrote: > On 06/22/2018 09:56 AM, Igor Mammedov wrote: > > On Fri, 22 Jun 2018 09:26:45 -0400 > > Stefan Berger wrote: > > > >> On 06/22/2018 05:03 AM, Igor Mammedov wrote: > >>> I'd prefer a table format to describe layout, like in > >>> docs/

Re: [Qemu-devel] Why qom-get is not available in qemu monitor

2018-06-25 Thread Dr. David Alan Gilbert
* Dongli Zhang (dongli.zh...@oracle.com) wrote: > Hi, > > Would you mind help confirm why qom-get command is not supported by qemu > monitor, but only qapi? > > Is this a feature (qom-get in monitor) totally useless for some reason, or it > is > still not implemented yet? Just because it's not

Re: [Qemu-devel] [PATCH v6 1/2] kvm: support -overcommit cpu-pm=on|off

2018-06-25 Thread Igor Mammedov
On Fri, 22 Jun 2018 22:22:05 +0300 "Michael S. Tsirkin" wrote: > With this flag, kvm allows guest to control host CPU power state. This > increases latency for other processes using same host CPU in an > unpredictable way, but if decreases idle entry/exit times for the > running VCPU, so to use

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] block: Convert .bdrv_truncate callback to coroutine_fn

2018-06-25 Thread Kevin Wolf
Am 25.06.2018 um 11:02 hat Stefan Hajnoczi geschrieben: > On Thu, Jun 21, 2018 at 07:06:56PM +0200, Kevin Wolf wrote: > > bdrv_truncate() is an operation that can block (even for a quite long > > time, depending on the PreallocMode) in I/O paths that shouldn't block. > > Convert it to a coroutine_f

Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-25 Thread Daniel P . Berrangé
On Fri, Jun 22, 2018 at 03:31:46PM +0100, Daniel P. Berrangé wrote: > On Fri, Jun 22, 2018 at 04:25:13PM +0200, Kevin Wolf wrote: > > Am 22.06.2018 um 15:36 hat Christian Borntraeger geschrieben: > > > > > > > > > On 06/22/2018 02:55 PM, Kevin Wolf wrote: > > > > Am 22.06.2018 um 13:38 hat Christ

Re: [Qemu-devel] [virtio-dev] Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-25 Thread Cornelia Huck
On Fri, 22 Jun 2018 22:05:50 +0300 "Michael S. Tsirkin" wrote: > On Fri, Jun 22, 2018 at 05:09:55PM +0200, Cornelia Huck wrote: > > On Thu, 21 Jun 2018 21:20:13 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Jun 21, 2018 at 04:59:13PM +0200, Cornelia Huck wrote: > > > > OK, so what

Re: [Qemu-devel] [PATCH] hw/arm/virt: fix psci conduit in acpi when el3 enabled

2018-06-25 Thread Hongbo Zhang
On 25 June 2018 at 17:06, Peter Maydell wrote: > On 25 June 2018 at 05:06, Hongbo Zhang wrote: >> Hi Peter, >> Yes, your considerations reasonable. >> But in practice of hardware platforms, programmer checks that Arm TF >> is using SMC for PSCI call conduit, then fix it manually in the ACPI >> ta

Re: [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-25 Thread Peter Maydell
On 22 June 2018 at 16:40, Daniel P. Berrangé wrote: > - SD card - requires -drive with if=sd, no -device support AFAICT Hmm? You can use -device if you want: -drive if=none,id=mydrive,... -device sd-card,...,drive=mydrive (the sd-card device then plugs into the sd controller device via the sd-

[Qemu-devel] RNG: Any reason QEMU doesn't default to `/dev/urandom`?

2018-06-25 Thread Kashyap Chamarthy
QEMU still defaults to /dev/random as entropy source. Any reason why not default to /dev/urandom? The other day Dan Berrangé explained elsewhere that /dev/urandom is recommended -- as it is non-blocking; and doesn't have the same limitations of /dev/random, which is a legacy interface. (And othe

Re: [Qemu-devel] [RFC PATCH 4/4] qemu-options: Do not show -enable-kvm and -enable-hax in the docs anymore

2018-06-25 Thread Paolo Bonzini
On 25/06/2018 08:50, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On 22/06/2018 21:35, Eduardo Habkost wrote: > Why is this better than using KVM by default if it's available? The answer is (as almost always): Compatibility with migration. Nobody dares to sacrifice that chi

Re: [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-25 Thread Peter Krempa
On Mon, Jun 25, 2018 at 11:01:46 +0100, Peter Maydell wrote: > On 22 June 2018 at 16:40, Daniel P. Berrangé wrote: > > - SD card - requires -drive with if=sd, no -device support AFAICT > > Hmm? You can use -device if you want: > -drive if=none,id=mydrive,... -device sd-card,...,drive=mydrive >

Re: [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-25 Thread Peter Maydell
On 25 June 2018 at 11:31, Peter Krempa wrote: > On Mon, Jun 25, 2018 at 11:01:46 +0100, Peter Maydell wrote: >> On 22 June 2018 at 16:40, Daniel P. Berrangé wrote: >> > - SD card - requires -drive with if=sd, no -device support AFAICT >> >> Hmm? You can use -device if you want: >> -drive if=no

Re: [Qemu-devel] [PATCH 0/3] aspeed/smc: small fixes

2018-06-25 Thread Peter Maydell
On 12 June 2018 at 07:57, Cédric Le Goater wrote: > Hello, > > Here is a short series of cleanups and fixes for issues in the Aspeed > SMC controller model discovered when experimenting with the MMIO exec > feature and also from tests under a QEMU PowerNV machine. > > Indeed, the OPAL/skiboot firm

Re: [Qemu-devel] [PATCH] MAINTAINERS: Adopt the Gumstix computers-on-module machines

2018-06-25 Thread Peter Maydell
On 22 June 2018 at 14:30, Philippe Mathieu-Daudé wrote: > Hi Peter, > > On 06/06/2018 12:02 PM, Philippe Mathieu-Daudé wrote: >> On 06/06/2018 11:53 AM, Thomas Huth wrote: >>> On 06.06.2018 16:47, Philippe Mathieu-Daudé wrote: These COMs are hard to find, and the companie dropped the support

Re: [Qemu-devel] [PATCH v4] xilinx_spips: Make dma transactions as per dma_burst_size

2018-06-25 Thread Peter Maydell
On 22 June 2018 at 10:47, Sai Pavan Boddu wrote: > From: Sai Pavan Boddu > > Qspi dma has a burst length of 64 bytes, So limit the transactions w.r.t > dma-burst-size property. > > Signed-off-by: Sai Pavan Boddu > Reviewed-by: Edgar E. Iglesias > --- > Changes for V2: >Remove dynamic alloca

[Qemu-devel] [Bug 1778350] Re: Android-x86 4.4-r5 won't boot on QEMU since v2.11.0-rc2

2018-06-25 Thread navicrej
After 'git bisect' -ing it I found the commit that is responsible for this: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=9fa99d2519cbf71f871e46871df12cb446dc1c3e -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchp

[Qemu-devel] [RFC v2 2/2] virtio-net: Example Patch for using BPF

2018-06-25 Thread Sameeh Jubran
From: Sameeh Jubran This commit is a sample only for using the libbpf in the code and shouldn't be committed. Signed-off-by: Sameeh Jubran --- hw/net/Makefile.objs | 4 hw/net/virtio-net.c | 4 2 files changed, 8 insertions(+) diff --git a/hw/net/Makefile.objs b/hw/net/Makefile.obj

[Qemu-devel] [RFC v2 0/2] Add BPF suuport to Qemu

2018-06-25 Thread Sameeh Jubran
From: Sameeh Jubran The Berkeley Packet Filter has been in the kernel for a while now and I think it is time that it is introduced to Qemu. This patch is an infrastructure for any future usage of the BPF in Qemu. It is important to note that the tun driver had started supporting using BPF progra

[Qemu-devel] [PATCH] MAINTAINERS: Add ASPEED BMCs

2018-06-25 Thread Joel Stanley
This adds Cedric as the maintainer, with Andrew and I as reviewers, for the ASPEED boards and the peripherals we use. Signed-off-by: Joel Stanley --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2874ddce6097..14bcf2ed3e3d 100644 ---

[Qemu-devel] [RFC v2 1/2] Add bpf support to qemu

2018-06-25 Thread Sameeh Jubran
From: Sameeh Jubran This commit adds the libbpf library provided by Linux to Qemu. Signed-off-by: Sameeh Jubran --- MAINTAINERS |6 + configure | 46 + include/standard-headers/linux/libbpf.h | 284 linux-headers/linux/bpf.h

Re: [Qemu-devel] [PATCH v2 0/7] arm_gic: add virtualization extensions support

2018-06-25 Thread Peter Maydell
On 25 June 2018 at 05:55, Jan Kiszka wrote: > On 2018-06-19 11:31, luc.mic...@greensocs.com wrote: >> From: Luc MICHEL >> >> This patch series add support for the virtualization extensions in the >> ARM GICv2 interrupt controller. >> >> The first two commits do some refactoring to prepare for the

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add ASPEED BMCs

2018-06-25 Thread Philippe Mathieu-Daudé
Hi Joel, On 06/25/2018 08:07 AM, Joel Stanley wrote: > This adds Cedric as the maintainer, with Andrew and I as reviewers, for > the ASPEED boards and the peripherals we use. Good idea, this should speed up ASPEED reviews. > > Signed-off-by: Joel Stanley > --- > MAINTAINERS | 11 +++ >

Re: [Qemu-devel] [RFC v2 0/2] Add BPF suuport to Qemu

2018-06-25 Thread Peter Maydell
On 25 June 2018 at 12:07, Sameeh Jubran wrote: > From: Sameeh Jubran > > The Berkeley Packet Filter has been in the kernel for a while now and I > think it is time that it is introduced to Qemu. This patch is an > infrastructure for any future usage of the BPF in Qemu. > > It is important to note

Re: [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-25 Thread Daniel P . Berrangé
On Fri, Jun 22, 2018 at 07:54:00PM +0200, Kevin Wolf wrote: > Am 22.06.2018 um 17:40 hat Daniel P. Berrangé geschrieben: > > On Fri, Jun 22, 2018 at 04:25:13PM +0200, Kevin Wolf wrote: > > > This was in fact one release longer than our deprecation policy says. > > > Are we serious about the depreca

[Qemu-devel] [PATCH v1 01/10] travis: do not waste time cloning unused submodules

2018-06-25 Thread Alex Bennée
From: Philippe Mathieu-Daudé Builds only require: - dtc - keycodemapdb - capstone Signed-off-by: Philippe Mathieu-Daudé [AJB: drop wget cache] Signed-off-by: Alex Bennée --- .travis.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index bd66c

[Qemu-devel] [PATCH v1 03/10] build-system: remove per-test GCOV reporting

2018-06-25 Thread Alex Bennée
I'm not entirely sure who's using this information and certainly in a CI environment it just washes over as additional noise. Later patches will provide new reporting options so a user who wants to analyse individual tests will be able to use that to get the information. Signed-off-by: Alex Bennée

[Qemu-devel] [PATCH v1 08/10] build-system: add coverage-report target

2018-06-25 Thread Alex Bennée
This will build a coverage report under the current directory in reports/coverage. At the users option a report can be generated by directly invoking something like: make foo/bar/coverage-report.html Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Da

[Qemu-devel] [PATCH v1 04/10] .gitignore: add .gcov files

2018-06-25 Thread Alex Bennée
These are temporary files generated on gcov runs and shouldn't be included in the source tree. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 9da3b

[Qemu-devel] [PATCH v1 10/10] linux-user: add gcov support to preexit_cleanup

2018-06-25 Thread Alex Bennée
As we don't always take the normal exit path when running a guest we can skip the normal exit destructors where gcov normally dumps it's info. The GCC manual suggests long running programs use __gcov_dump() to flush out the coverage state periodically so we use that here. Signed-off-by: Alex Benné

[Qemu-devel] [PATCH v1 00/10] Travis updates and code coverage tweaks

2018-06-25 Thread Alex Bennée
The main changes since last weeks RFC are that I ended up doing more furtling than I wanted to make the Travis coverage report sane. Rather than mess around with .travis.yml I pushed this all into a script. I also got to the bottom of the missing coverage reports under linux-user. It seems as thou

[Qemu-devel] [PATCH v1 02/10] travis: test out-of-tree builds

2018-06-25 Thread Alex Bennée
From: Philippe Mathieu-Daudé Force one config to build 'out-of-tree' (object files and executables are created in a tree outside the project source code). Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée --- .travis.yml | 8 +++- 1 file changed, 7 insertions(+), 1 deletion

[Qemu-devel] [PATCH v1 07/10] build-system: add clean-coverage target

2018-06-25 Thread Alex Bennée
This can be used to remove any stale coverage data before any particular test run. This is useful for analysing individual tests. Signed-off-by: Alex Bennée --- Makefile | 11 +++ docs/devel/testing.rst | 11 --- 2 files changed, 19 insertions(+), 3 deletions(-) di

[Qemu-devel] [PATCH v1 06/10] travis: add gcovr summary for GCOV build

2018-06-25 Thread Alex Bennée
This gives a more useful summary, sorted by descending % coverage, after the tests have run. The final numbers will give an idea if our coverage is getting better or worse. To keep the width sane we need to post process the file that the old gcovr tool generates. This is done with a mix of sed, aw

Re: [Qemu-devel] [RFC v2 0/2] Add BPF suuport to Qemu

2018-06-25 Thread Sameeh Jubran
On Mon, Jun 25, 2018 at 2:16 PM, Peter Maydell wrote: > On 25 June 2018 at 12:07, Sameeh Jubran wrote: > > From: Sameeh Jubran > > > > The Berkeley Packet Filter has been in the kernel for a while now and I > > think it is time that it is introduced to Qemu. This patch is an > > infrastructure

[Qemu-devel] [PATCH v1 05/10] docker: add gcovr to travis image

2018-06-25 Thread Alex Bennée
Useful for debugging if nothing else as the gcovr on the Travis images are a little old. Signed-off-by: Alex Bennée --- tests/docker/dockerfiles/travis.docker | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/docker/dockerfiles/travis.docker b/tests/docker/dockerfiles/tr

Re: [Qemu-devel] [RFC v2 2/2] virtio-net: Example Patch for using BPF

2018-06-25 Thread Daniel P . Berrangé
On Mon, Jun 25, 2018 at 02:07:06PM +0300, Sameeh Jubran wrote: > From: Sameeh Jubran > > This commit is a sample only for using the libbpf in the code and > shouldn't be committed. > > Signed-off-by: Sameeh Jubran > --- > hw/net/Makefile.objs | 4 > hw/net/virtio-net.c | 4 > 2 file

[Qemu-devel] [PATCH v1 09/10] linux-user: introduce preexit_cleanup

2018-06-25 Thread Alex Bennée
To avoid repeating ourselves move our preexit clean-up code into a helper function. I figured the continuing effort to split of the syscalls made it worthwhile creating a new file for it now. Signed-off-by: Alex Bennée --- linux-user/Makefile.objs | 2 +- linux-user/exit.c| 28 +

Re: [Qemu-devel] [PATCH v2] Show values and description when using "qom-list"

2018-06-25 Thread Markus Armbruster
Markus Armbruster writes: > Andreas Färber writes: > >> Am 08.06.2018 um 11:41 schrieb Dr. David Alan Gilbert: >>> * Andreas Färber (afaer...@suse.de) wrote: Am 01.06.2018 um 17:39 schrieb Ricardo Perez Blanco: > For debugging purposes it is very useful to: > - See the description

Re: [Qemu-devel] [PATCH v1 05/10] docker: add gcovr to travis image

2018-06-25 Thread Philippe Mathieu-Daudé
On 06/25/2018 08:19 AM, Alex Bennée wrote: > Useful for debugging if nothing else as the gcovr on the Travis images > are a little old. > > Signed-off-by: Alex Bennée > --- > tests/docker/dockerfiles/travis.docker | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/do

Re: [Qemu-devel] [PATCH v1 09/10] linux-user: introduce preexit_cleanup

2018-06-25 Thread Philippe Mathieu-Daudé
On 06/25/2018 08:19 AM, Alex Bennée wrote: > To avoid repeating ourselves move our preexit clean-up code into a > helper function. I figured the continuing effort to split of the > syscalls made it worthwhile creating a new file for it now. > > Signed-off-by: Alex Bennée Reviewed-by: Philippe Ma

Re: [Qemu-devel] [PATCH v1 10/10] linux-user: add gcov support to preexit_cleanup

2018-06-25 Thread Philippe Mathieu-Daudé
Hi Alex, On 06/25/2018 08:19 AM, Alex Bennée wrote: > As we don't always take the normal exit path when running a guest we > can skip the normal exit destructors where gcov normally dumps it's > info. The GCC manual suggests long running programs use __gcov_dump() > to flush out the coverage state

Re: [Qemu-devel] Why qom-get is not available in qemu monitor

2018-06-25 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Dongli Zhang (dongli.zh...@oracle.com) wrote: >> Hi, >> >> Would you mind help confirm why qom-get command is not supported by qemu >> monitor, but only qapi? >> >> Is this a feature (qom-get in monitor) totally useless for some reason, or >> it is >> still

Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-25 Thread Kevin Wolf
Am 25.06.2018 um 11:53 hat Daniel P. Berrangé geschrieben: > On Fri, Jun 22, 2018 at 03:31:46PM +0100, Daniel P. Berrangé wrote: > > On Fri, Jun 22, 2018 at 04:25:13PM +0200, Kevin Wolf wrote: > > > Am 22.06.2018 um 15:36 hat Christian Borntraeger geschrieben: > > > > > > > > > > > > On 06/22/201

Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-25 Thread Peter Krempa
On Mon, Jun 25, 2018 at 13:41:06 +0200, Kevin Wolf wrote: > Am 25.06.2018 um 11:53 hat Daniel P. Berrangé geschrieben: > > On Fri, Jun 22, 2018 at 03:31:46PM +0100, Daniel P. Berrangé wrote: > > > On Fri, Jun 22, 2018 at 04:25:13PM +0200, Kevin Wolf wrote: > > > > Am 22.06.2018 um 15:36 hat Christi

Re: [Qemu-devel] [PATCH v2 3/7] vmstate.h: Provide VMSTATE_UINT16_SUB_ARRAY

2018-06-25 Thread Peter Maydell
On 19 June 2018 at 10:31, wrote: > From: Luc MICHEL > > Provide a VMSTATE_UINT16_SUB_ARRAY macro to save a uint16_t sub-array in > a VMState. > > Signed-off-by: Luc MICHEL > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v2 6/7] intc/arm_gic: Improve traces

2018-06-25 Thread Peter Maydell
On 19 June 2018 at 10:31, wrote: > From: Luc MICHEL > > Add some traces to the ARM GIC to catch register accesses (distributor, > (v)cpu interface and virtual interface), and to take into account > virtualization extensions (print `vcpu` instead of `cpu` when needed). > > Also add some virtualiz

Re: [Qemu-devel] [PATCH 1/5] i386: Add support for IA32_PRED_CMD and IA32_ARCH_CAPABILITIES MSRs

2018-06-25 Thread Paolo Bonzini
On 25/06/2018 05:39, Robert Hoo wrote: > IA32_PRED_CMD MSR gives software a way to issue commands that affect the state > of indirect branch predictors. Enumerated by CPUID.(EAX=7H,ECX=0):EDX[26]. > IA32_ARCH_CAPABILITIES MSR enumerates architectural features of RDCL_NO and > IBRS_ALL. Enumerated b

[Qemu-devel] [PATCH v3 6/9] s390x/tcg: SET CLOCK COMPARATOR can clear CKC interrupts

2018-06-25 Thread David Hildenbrand
Let's stop the timer and delete any pending CKC IRQ before doing anything else. While at it, add a comment while the check for ckc == -1ULL is needed. Signed-off-by: David Hildenbrand --- target/s390x/misc_helper.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/target/s390x/misc_hel

[Qemu-devel] [PATCH v3 0/9] s390x: TOD refactoring + TCG CPU hotplug support

2018-06-25 Thread David Hildenbrand
The TOD in TCG is not handled correctly: - each CPU has its own TOD based on CPU creation time vs. a system TOD - TOD is not migrated - TOD timer is not restarted during migration - CKC interrupts/TOD timer is not cleared when resetting the CKC This (and a cpu creation problem for single threaded

[Qemu-devel] [PATCH v3 1/9] s390x/tcg: avoid overflows in time2tod/tod2time

2018-06-25 Thread David Hildenbrand
Big values for the TOD/ns clock can result in some overflows that can be avoided. Not all overflows can be handled however, as the conversion either multiplies by 4.096 or divided by 4.096. Apply the trick used in the Linux kernel in arch/s390/include/asm/timex.h for tod_to_ns() and use the same t

[Qemu-devel] [PATCH v3 4/9] s390x/tcg: drop tod_basetime

2018-06-25 Thread David Hildenbrand
Never set to anything but 0. Reviewed-by: Thomas Huth Signed-off-by: David Hildenbrand --- target/s390x/cpu.c | 1 - target/s390x/cpu.h | 1 - target/s390x/misc_helper.c | 4 ++-- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/target/s390x/cpu.c b/target/s390x/cp

Re: [Qemu-devel] [PATCH v3 01/16] hw/input/pckbd: Use qemu_log_mask(GUEST_ERROR) instead of fprintf

2018-06-25 Thread Thomas Huth
On 24.06.2018 06:05, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/input/pckbd.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/input/pckbd.c b/hw/input/pckbd.c > index f33e3fc63d..07c8801387 100644 > --- a/hw/input/pckbd.c > +++

[Qemu-devel] [PATCH v3 2/9] s390x/kvm: pass values instead of pointers to kvm_s390_set_clock_*()

2018-06-25 Thread David Hildenbrand
We are going to factor out the TOD into a separate device and use const pointers for device class functions where possible. We are passing right now ordinary pointers that should never be touched when setting the TOD. Let's just pass the values directly. Signed-off-by: David Hildenbrand --- targ

[Qemu-devel] [PATCH v3 7/9] s390x/tcg: implement SET CLOCK

2018-06-25 Thread David Hildenbrand
This allows a guest to change its TOD. We already take care of updating all CKC timers from within S390TODClass. Use MO_ALIGN to load the operand manually - this will properly trigger a SPECIFICATION exception. Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 1 + target/s390x

[Qemu-devel] [PATCH v3 9/9] s390x/tcg: fix CPU hotplug with single-threaded TCG

2018-06-25 Thread David Hildenbrand
run_on_cpu() doesn't seem to work reliably until the CPU has been fully created if the single-threaded TCG main loop is already running. Therefore, hotplugging a CPU under single-threaded TCG does currently not work. We should use the direct call instead of going via run_on_cpu(). So let's use ru

[Qemu-devel] [PATCH v3 3/9] s390x/tod: factor out TOD into separate device

2018-06-25 Thread David Hildenbrand
Let's treat this like a separate device. TCG will have to store the actual state/time later on. Include cpu-qom.h in kvm_s390x.h (due to S390CPU) to compile tod-kvm.c. Reviewed-by: Thomas Huth Signed-off-by: David Hildenbrand --- hw/s390x/Makefile.objs | 3 + hw/s390x/s390-virtio-ccw.c |

[Qemu-devel] [PATCH v3 8/9] s390x/tcg: rearm the CKC timer during migration

2018-06-25 Thread David Hildenbrand
If the CPU data is migrated after the TOD clock, the CKC timer of a CPU is not rearmed. Let's rearm it when loading the CPU state. Introduce tcg-stub.c just like kvm-stub.c for tcg specific stubs. Reviewed-by: Thomas Huth Signed-off-by: David Hildenbrand --- target/s390x/Makefile.objs | 1 +

[Qemu-devel] [PATCH v3 5/9] s390x/tcg: properly implement the TOD

2018-06-25 Thread David Hildenbrand
Right now, each CPU has its own TOD. Especially, the TOD will differ based on creation time of a CPU - e.g. when hotplugging a CPU the times will differ quite a lot, resulting in stall warnings in the guest. Let's use a single TOD by implementing our new TOD device. Prepare it for TOD-clock epoch

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add ASPEED BMCs

2018-06-25 Thread Andrew Jeffery
On Mon, 25 Jun 2018, at 20:43, Philippe Mathieu-Daudé wrote: > Hi Joel, > > On 06/25/2018 08:07 AM, Joel Stanley wrote: > > This adds Cedric as the maintainer, with Andrew and I as reviewers, for > > the ASPEED boards and the peripherals we use. > > Good idea, this should speed up ASPEED reviews.

Re: [Qemu-devel] [PATCH v3 09/16] hw/arm/omap: Use qemu_log_mask(GUEST_ERROR) instead of fprintf

2018-06-25 Thread Thomas Huth
On 24.06.2018 06:06, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/arm/omap.h | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/include/hw/arm/omap.h b/include/hw/arm/omap.h > index 39abba753d..e7fbd340f3 100644 > ---

Re: [Qemu-devel] [PATCH 2/5] i386: Add CPUID bit and feature words for IA32_ARCH_CAPABILITIES MSR

2018-06-25 Thread Paolo Bonzini
On 25/06/2018 05:39, Robert Hoo wrote: > Support of IA32_PRED_CMD MSR already be enumerated by same CPUID bit as > SPEC_CTRL. > > Signed-off-by: Robert Hoo > --- > target/i386/cpu.c | 2 +- > target/i386/cpu.h | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/target/i386

Re: [Qemu-devel] s390 qemu boot failure in -next

2018-06-25 Thread Christian Borntraeger
On 06/25/2018 10:49 AM, Cornelia Huck wrote: > On Mon, 25 Jun 2018 10:36:33 +0200 > Vasily Gorbik wrote: > >> This change has been done on purpose. Uncompressed image is not going >> to be bootable any more. In future the decompressor phase would get >> more function (early memory detection as

[Qemu-devel] [PATCH v5 01/46] include: Add IEC binary prefixes in "qemu/units.h"

2018-06-25 Thread Philippe Mathieu-Daudé
Loosely based on 076b35b5a56. Suggested-by: Stefan Weil Signed-off-by: Philippe Mathieu-Daudé --- include/qemu/units.h | 20 1 file changed, 20 insertions(+) create mode 100644 include/qemu/units.h diff --git a/include/qemu/units.h b/include/qemu/units.h new file mode 100

[Qemu-devel] [PATCH v5 02/46] vdi: Use definitions from "qemu/units.h"

2018-06-25 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Weil --- block/vdi.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/block/vdi.c b/block/vdi.c index 1d8ed67dbf..6555cffb88 100644 --- a/block/vdi.c +++ b/block/vdi.c @@ -50,6 +50,7 @@ */ #include "qemu/osd

[Qemu-devel] [PATCH v5 04/46] checkpatch: Recognize IEC binary prefix definitions

2018-06-25 Thread Philippe Mathieu-Daudé
Do not match the IEC binary prefix as camelcase typedefs. This fixes: ERROR: "foo * bar" should be "foo *bar" #310: FILE: hw/ppc/ppc440_uc.c:564: +size = 8 * MiB * sh; total: 1 errors, 0 warnings, 433 lines checked Signed-off-by: Philippe Mathieu-Daudé --- scripts/check

[Qemu-devel] [PATCH v5 03/46] x86/cpu: Use definitions from "qemu/units.h"

2018-06-25 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Acked-by: Eduardo Habkost --- target/i386/cpu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 1e69e68f25..a5c9200788 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -18,6 +18,7 @@

[Qemu-devel] [PATCH v5 11/46] hw/xen: Use the IEC binary prefix definitions

2018-06-25 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alan Robinson --- hw/block/xen_disk.c| 3 ++- hw/i386/xen/xen-mapcache

  1   2   3   4   >