Daniel Henrique Barboza writes:
> Hi,
>
> Sorry for the delay. I'll summarize what I've understood from the discussion
> so far:
>
> - query-target is the wrong place for this flag. query-machines is
> (less) wrong
> because it is not a static property of the machine object
>
> - a new "query-cur
Public bug reported:
We use virtio-gpu to accelerate Unigine Heaven Benchmark in VM. But we get only
5 FPS when we use AMD RX460 in our host.
We found that guest os spent a lot of time in waiting for the return of
glMapBufferRange/glUnmapBuffer commad. We suspected the host GPU was waiting
for
After the Out-Of-Band work, the monitor iothread may be accessing the
cur_mon as well (via monitor_qmp_dispatch_one()). Let's convert the
cur_mon variable to be a per-thread variable to make sure there won't be
a race between threads when accessing the variable.
Note that thread variables are not
On Tue, Jun 19, 2018 at 10:52:15AM +0200, BALATON Zoltan wrote:
> Rewrite to make it closer to how real device works so that guest OS
> drivers can access I2C devices. Previously this was only a hack to
> allow U-Boot to get past accessing SPD EEPROMs but to support other
> I2C devices and allow gu
On Tue, Jun 19, 2018 at 10:52:15AM +0200, BALATON Zoltan wrote:
> According to PPC440 User Manual PPC440 has multiple opcodes for icbt
> instruction: one for compatibility with older cores and two 440
> specific opcodes one of which is defined in BookE. QEMU only
> implements two of these, add the
Hi Laszlo,
On 06/19/2018 09:02 PM, Ard Biesheuvel wrote:
> On 19 June 2018 at 20:53, Laszlo Ersek wrote:
>> Hi Eric,
>>
>> sorry about the late followup. I have one question (mainly for Ard):
>>
>> On 06/15/18 16:28, Eric Auger wrote:
>>> This patch allows the creation of a GICv3 node with 1 or 2
On Tue, Jun 19, 2018 at 10:52:15AM +0200, BALATON Zoltan wrote:
> As well as being able to generate its own i2c transactions, the ppc4xx
> i2c controller has a DIRECTCNTL register which allows explicit control
> of the i2c lines.
>
> Using this register an OS can directly bitbang i2c operations. I
Peter Xu writes:
> On Tue, Jun 19, 2018 at 03:57:07PM +0200, Markus Armbruster wrote:
>> Peter Xu writes:
>>
>> > In my Out-Of-Band test, "check -qcow2 060" fail with this (the output is
>> > manually changed due to line width requirement):
>> >
>> > 060 5s ... - output mismatch (see 060.out.ba
Peter Xu writes:
> On Tue, Jun 19, 2018 at 03:53:11PM +0200, Markus Armbruster wrote:
>> Peter Xu writes:
>>
>> > Previously we clean up the queues when we got CLOSED event. It was used
>> > to make sure we won't send leftover replies/events of a old client to a
>> > new client which makes per
"Dr. David Alan Gilbert" wrote:
> * Juan Quintela (quint...@redhat.com) wrote:
>> We know quit closing the QIO.
>
> This patch does two different things; one of which I think I understand.
>
> The 'quit' has been removed - I think that makes sense because the
> multifd threads terminate when eithe
Peter Xu writes:
> On Tue, Jun 19, 2018 at 04:16:49PM +0200, Markus Armbruster wrote:
>> Peter Xu writes:
>>
>> > There was a regression reported by Eric Auger before with OOB:
>> >
>> > http://lists.gnu.org/archive/html/qemu-devel/2018-03/msg06231.html
>> >
>> > It is fixed in 951702f39c ("m
On Wed, Jun 20, 2018 at 09:12:57AM +0200, Markus Armbruster wrote:
> Peter Xu writes:
>
> > On Tue, Jun 19, 2018 at 03:57:07PM +0200, Markus Armbruster wrote:
> >> Peter Xu writes:
> >>
> >> > In my Out-Of-Band test, "check -qcow2 060" fail with this (the output is
> >> > manually changed due t
On Tue, Jun 19, 2018 at 10:52:15AM +0200, BALATON Zoltan wrote:
> Emulate the i2c part of SM501 which is used to access the EDID info
> from a monitor.
>
> The vmstate structure is changed and its version is increased but
> SM501 is only used on SH and PPC sam460ex machines that don't support
> cr
On Tue, Jun 19, 2018 at 10:52:15AM +0200, BALATON Zoltan wrote:
>
> Next spin of sam460ex pathces with changes according to review and
> some new patches.
So, the sm501 patches I don't really have the technical knowledge to
review, and I'm a little uncomfortable taking them through my tree,
since
On Wed, 20 Jun 2018 11:22:40 +1000
David Gibson wrote:
> On Tue, Jun 19, 2018 at 01:11:28PM +0200, Greg Kurz wrote:
> > On Mon, 18 Jun 2018 21:04:38 -0500
> > Michael Roth wrote:
> >
> > > Quoting Greg Kurz (2018-05-22 12:17:28)
> > > > The spapr capability framework was introduced in QEMU
On Wed, Jun 20, 2018 at 09:20:30AM +0200, Markus Armbruster wrote:
> Peter Xu writes:
>
> > On Tue, Jun 19, 2018 at 04:16:49PM +0200, Markus Armbruster wrote:
> >> Peter Xu writes:
> >>
> >> > There was a regression reported by Eric Auger before with OOB:
> >> >
> >> > http://lists.gnu.org/ar
v5:
- more r-bs are collected
- make sure no patch contains extra s-o-bs by doing proper indents for
diff quotes [Markus]
- misc commit message or comment changes [Markus]
v4:
- collect some r-bs
- remove one extra s-o-b of mine in one patch [Thomas, Markus]
- split the qmp response flush patch
It was unclear before on what does the CLOSED event mean. Meanwhile we
add a TODO to fix up the CLOSED event in the future when the in/out
ports are different for a chardev.
CC: Paolo Bonzini
CC: "Marc-André Lureau"
CC: Stefan Hajnoczi
CC: Markus Armbruster
Reviewed-by: Stefan Hajnoczi
Signe
In my Out-Of-Band test, "check -qcow2 060" fail with this (the output is
manually changed due to line width requirement):
--- /home/peterx/git/qemu/tests/qemu-iotests/060.out
+++ /home/peterx/git/qemu/bin/tests/qemu-iotests/060.out.bad
@@ -427,8 +427,8 @@
QMP_VERSION
{"return": {}}
qco
Out-Of-Band handlers need to protect shared state if there is any.
Mention it in the document. Meanwhile, touch up some other places too,
either with better English, or reordering of bullets.
Suggested-by: Markus Armbruster
Reviewed-by: Markus Armbruster
Signed-off-by: Peter Xu
---
docs/devel
The old names are confusing since both of the old functions are popping
an item from multiple queues rather than a single queue. In that
sense, *_pop_any() suites better than *_pop_one().
Since at it, touch up the function monitor_qmp_response_pop_any() a bit
to let the callers pass in a QMPRespo
This reverts commit ddee57e0176f6ab53b13c6c97605b62737a8fd7a.
Meanwhile, revert one line from fa198ad9bdef to make sure
qtest_init_without_qmp_handshake() will only pass in one parameter.
Reviewed-by: Markus Armbruster
Signed-off-by: Peter Xu
---
tests/libqtest.h | 4 +---
tests/libqtest.c |
Previously we clean up the queues when we got CLOSED event. It was used
to make sure we won't send leftover replies/events of a old client to a
new client which makes perfect sense. However this will also drop the
replies/events even if the output port of the previous chardev backend
is still open
OOB commands were introduced in commit cf869d53172. Unfortunately, we
ran into a regression, and had to disable them by default for 2.12
(commit be933ffc23).
http://lists.gnu.org/archive/html/qemu-devel/2018-03/msg06231.html
The regression has since been fixed (commit 951702f39c7 "monitor: bin
On 06/12/2018 12:13 PM, Zihan Yang wrote:
Allocate new segment for pxb-pcie host bridges in MCFG table, and reserve
corresponding MCFG space for them. This allows user-defined pxb-pcie
host bridges to be placed in different pci domain than q35 host
Signed-off-by: Zihan Yang
---
hw/i386/acp
On 06/12/2018 12:13 PM, Zihan Yang wrote:
Describe new pci segments of host bridges in AML. The host bridge list is
replaced by QTAILQ to let q35 host be processed first in every traverse
Signed-off-by: Zihan Yang
---
hw/i386/acpi-build.c | 69 ++---
On Wed, Jun 20, 2018 at 02:00:00AM +0530, Sai Pavan Boddu wrote:
> Qspi dma has a burst length of 64 bytes, So limit transaction length to
> 64 max.
>
> Signed-off-by: Sai Pavan Boddu
> ---
> hw/ssi/xilinx_spips.c | 20 +---
> include/hw/ssi/xilinx_spips.h | 5 -
> 2
On 2018年06月19日 21:21, Sameeh Jubran wrote:
From: Sameeh Jubran
The Berkeley Packet Filter has been in the kernel for a while now and I
think it is time that it is introduced to Qemu. This patch is an
infrastructure for any future usage of the BPF in Qemu.
It is important to note that the tu
We only create/destry the page list here. We will use it later.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
migration/ram.c | 57 +
1 file changed, 57 insertions(+)
diff --git a/migration/ram.c b/migration/ram.c
index cd
We want to know how many pages/packets each channel has sent. Add
counters for those.
Signed-off-by: Juan Quintela
Reviewed-by: Juan Quintela
--
sort trace-events (dave)
---
migration/ram.c| 22 ++
migration/trace-events | 4
2 files changed, 26 insertions(+)
We still don't put anything there.
Signed-off-by: Juan Quintela
Reviewed-by: Juan Quintela
--
fix magic (dave)
check offset/ramblock (dave)
s/seq/packet_num/ and make it 64bit
---
migration/ram.c | 145 +++-
1 file changed, 144 insertions(+), 1 dele
We synchronize all threads each RAM_SAVE_FLAG_EOS. Bitmap
synchronizations don't happen inside a ram section, so we are safe
about two channels trying to overwrite the same memory.
Signed-off-by: Juan Quintela
--
seq needs to be atomic now, will also be accessed from main thread.
Fix the if (tr
On multifd we send data from more places that main channel.
Signed-off-by: Juan Quintela
--
Add placeholder for packets size
---
migration/migration.c | 12 ++--
migration/ram.c | 7 +++
migration/ram.h | 1 +
3 files changed, 18 insertions(+), 2 deletions(-)
diff --gi
Hi
THis iv v14 multifd patches: Changes from previous submit:
- rename seq -> packet_num: make things easier to understand
- packet_num is now 64bit wide
- include the size of the packet headers in the transfer stats (dave noticed it)
- improve comments here and there.
All the patches except two
We have three conditions here:
- channel fails -> error
- we have to quit: we close the channel and reads fails
- normal read that success, we are in bussiness
So forget the complications of waiting in a semaphore.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
migration/
Either for quit, sync or packet, we first wake them.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
migration/ram.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index d7f8b0d989..617da76a2e 100644
---
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
migration/ram.c | 29 -
1 file changed, 24 insertions(+), 5 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 71a33b73e7..09df573441 100644
--- a/migration/ram.c
+++ b/migration/ram.
We have to flush() the QEMUFile because now we sent really few data
through that channel.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
migration/ram.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index
Once there add tracepoints.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
migration/ram.c| 49 +-
migration/trace-events | 2 ++
2 files changed, 46 insertions(+), 5 deletions(-)
diff --git a/migration/ram.c b/migration/ra
The function still don't use multifd, but we have simplified
ram_save_page, xbzrle and RDMA stuff is gone. We have added a new
counter.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
--
Add last_page parameter
Add commets for done and address
Remove multifd field, it is the s
On 2018年06月19日 21:49, Daniel P. Berrangé wrote:
On Tue, Jun 19, 2018 at 04:21:59PM +0300, Sameeh Jubran wrote:
From: Sameeh Jubran
The Berkeley Packet Filter has been in the kernel for a while now and I
think it is time that it is introduced to Qemu. This patch is an
infrastructure for any
We know quit closing the QIO.
Signed-off-by: Juan Quintela
--
Add comment
don't object_ref() twice.
---
migration/ram.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 2c3a452a7d..57d3ad1c45 100644
--- a/migration/ram
Peter Xu writes:
> Previously we clean up the queues when we got CLOSED event. It was used
> to make sure we won't send leftover replies/events of a old client to a
> new client which makes perfect sense. However this will also drop the
> replies/events even if the output port of the previous ch
Peter Xu writes:
> In my Out-Of-Band test, "check -qcow2 060" fail with this (the output is
> manually changed due to line width requirement):
I think the output is no longer wrapped. Can drop the parenthesis when
I apply.
> --- /home/peterx/git/qemu/tests/qemu-iotests/060.out
> +++ /home/
On Tue, Jun 19, 2018 at 05:37:10PM +0300, Sameeh Jubran wrote:
> This patch is actually a preparation for an upcoming patch set that I want
> to integrate into virtio-net which implements the RSS feature. (
> https://lists.oasis-open.org/archives/virtio-dev/201805/msg00024.html)
> So there is a use
On Wed, Jun 20, 2018 at 10:33:37AM +0200, Markus Armbruster wrote:
> Peter Xu writes:
>
> > Previously we clean up the queues when we got CLOSED event. It was used
> > to make sure we won't send leftover replies/events of a old client to a
> > new client which makes perfect sense. However this w
On 18 June 2018 at 19:44, Mark Cave-Ayland
wrote:
> The following changes since commit 2ef2f16781af9dee6ba6517755e9073ba5799fa2:
>
> Merge remote-tracking branch
> 'remotes/dgilbert/tags/pull-migration-20180615a' into staging (2018-06-15
> 18:13:35 +0100)
>
> are available in the git repositor
On Tue, Jun 19, 2018 at 03:06:06PM -0500, Eric Blake wrote:
> On 06/15/2018 10:50 AM, Daniel P. Berrangé wrote:
> > From: "Daniel P. Berrange"
> >
> > Currently any client which can complete the TLS handshake is able to use
> > the NBD server. The server admin can turn on the 'verify-peer' option
It's not a specific guest OS version that suffers from this bug, we
already had multiple incidents on Debian 7, Ubuntu 14.04 and CentOS 6. I
will try to reproduce it again.
The command line output from the destination host looks different
indeed, could it be possible that this is caused by a libvi
* Juan Quintela (quint...@redhat.com) wrote:
> "Dr. David Alan Gilbert" wrote:
> > * Juan Quintela (quint...@redhat.com) wrote:
> >> We know quit closing the QIO.
> >
> > This patch does two different things; one of which I think I understand.
> >
> > The 'quit' has been removed - I think that mak
At the moment the PPC64/pseries guest only supports 4K/64K/16M IOMMU
pages and POWER8 CPU supports the exact same set of page size so
so far things worked fine.
However POWER9 supports different set of sizes - 4K/64K/2M/1G and
the last two - 2M and 1G - are not even allowed in the paravirt interfa
Please don't use the bug tracker for providing patches, and send it to
the mailing list instead, see:
https://wiki.qemu.org/Contribute/SubmitAPatch
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/18
Right; even if you're getting the problem across multiple OS versions,
just pick one that fails; the most convenient one to debug/newest. Hmm
are all the ones that are failing old - that's an old Debian, an old
Ubuntu and an old CentOS? Do any more modern guests fail?
If the -cpu is different on
19.06.2018 21:54, Eric Blake wrote:
On 06/19/2018 01:34 PM, Vladimir Sementsov-Ogievskiy wrote:
Zero out corrupted L1 table entry, which reference L2 table out of
underlying file.
Zero L1 table entry means that "the L2 table and all clusters described
by this L2 table are unallocated."
Signed-o
I have qemu-img 1.4.1 included in Suse Linux Enterprise server version
11 SP3. I will see whether I can update it and then try the conversion
and post the results.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad
19.06.2018 21:50, Eric Blake wrote:
On 06/19/2018 01:34 PM, Vladimir Sementsov-Ogievskiy wrote:
Separate offset and size of compressed cluster.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2-refcount.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
Hmm
* Juan Quintela (quint...@redhat.com) wrote:
> We still don't put anything there.
>
> Signed-off-by: Juan Quintela
> Reviewed-by: Juan Quintela
Wrong r-b; that's:
Reviewed-by: Dr. David Alan Gilbert
> --
> fix magic (dave)
> check offset/ramblock (dave)
> s/seq/packet_num/ and make it 64bi
"Dr. David Alan Gilbert" wrote:
> * Juan Quintela (quint...@redhat.com) wrote:
>> We still don't put anything there.
>>
>> Signed-off-by: Juan Quintela
>> Reviewed-by: Juan Quintela
>
> Wrong r-b; that's:
>
>
> Reviewed-by: Dr. David Alan Gilbert
Fixed, thanks.
"Dr. David Alan Gilbert" wrote:
> * Juan Quintela (quint...@redhat.com) wrote:
>> "Dr. David Alan Gilbert" wrote:
>> > * Juan Quintela (quint...@redhat.com) wrote:
>> >> We know quit closing the QIO.
>> >
>> > This patch does two different things; one of which I think I understand.
>> >
>> > The
19.06.2018 23:24, Eric Blake wrote:
On 06/09/2018 10:17 AM, Vladimir Sementsov-Ogievskiy wrote:
Add nbd_meta_pattern() and nbd_meta_empty_or_pattern() helpers for
metadata query parsing. nbd_meta_pattern() will be reused for "qemu"
s/for/for the/
namespace in following patches.
Signed-off-b
* Juan Quintela (quint...@redhat.com) wrote:
> "Dr. David Alan Gilbert" wrote:
> > * Juan Quintela (quint...@redhat.com) wrote:
> >> "Dr. David Alan Gilbert" wrote:
> >> > * Juan Quintela (quint...@redhat.com) wrote:
> >> >> We know quit closing the QIO.
> >> >
> >> > This patch does two differen
13.06.2018 05:06, John Snow wrote:
We always call it with the same fields of the struct we always pass.
We can split this out later if we really wind up needing to.
Signed-off-by: John Snow
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On Tue, May 29, 2018 at 02:47:05PM +0200, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias"
>
> The ZynqMP actually has Cortex-R5Fs with the optional FPU enabled.
Hi Peter,
Any comments on this series?
Cheers,
Edgar
>
> Cheers,
> Edgar
>
> ChangeLog:
>
> v1 -> v2:
> * Update ZCU102 des
"Dr. David Alan Gilbert" wrote:
> * Juan Quintela (quint...@redhat.com) wrote:
>> "Dr. David Alan Gilbert" wrote:
>> > * Juan Quintela (quint...@redhat.com) wrote:
>> >> "Dr. David Alan Gilbert" wrote:
>> >> > * Juan Quintela (quint...@redhat.com) wrote:
>> >> >> We know quit closing the QIO.
.
* Juan Quintela (quint...@redhat.com) wrote:
> We want to know how many pages/packets each channel has sent. Add
> counters for those.
>
> Signed-off-by: Juan Quintela
> Reviewed-by: Juan Quintela
You mean
Reviewed-by: Dr. David Alan Gilbert
> --
> sort trace-events (dave)
> ---
> migratio
On 19 June 2018 at 13:04, Cornelia Huck wrote:
> The following changes since commit 2ef2f16781af9dee6ba6517755e9073ba5799fa2:
>
> Merge remote-tracking branch
> 'remotes/dgilbert/tags/pull-migration-20180615a' into staging (2018-06-15
> 18:13:35 +0100)
>
> are available in the Git repository a
Peter Xu writes:
> On Wed, Jun 20, 2018 at 10:33:37AM +0200, Markus Armbruster wrote:
>> Peter Xu writes:
>>
>> > Previously we clean up the queues when we got CLOSED event. It was used
>> > to make sure we won't send leftover replies/events of a old client to a
>> > new client which makes per
On Tue, 19 Jun 2018 23:32:06 +0300
"Michael S. Tsirkin" wrote:
> On Tue, Jun 19, 2018 at 12:54:53PM +0200, Cornelia Huck wrote:
> > Sorry about dragging mainframes into this, but this will only work for
> > homogenous device coupling, not for heterogenous. Consider my vfio-pci
> > + virtio-net-cc
Am 20.06.2018 um 00:54 hat Nishanth Aravamudan geschrieben:
> On 19.06.2018 [15:35:57 -0700], Nishanth Aravamudan wrote:
> > On 19.06.2018 [13:14:51 -0700], Nishanth Aravamudan wrote:
> > > On 19.06.2018 [14:35:33 -0500], Eric Blake wrote:
> > > > On 06/15/2018 12:47 PM, Nishanth Aravamudan via Qem
* Juan Quintela (quint...@redhat.com) wrote:
> On multifd we send data from more places that main channel.
>
> Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
> --
> Add placeholder for packets size
> ---
> migration/migration.c | 12 ++--
> migration/ram.c | 7
13.06.2018 05:06, John Snow wrote:
Instead of always setting IN_USE, do this conditionally based on
whether or not the bitmap is read-only. Eliminate the two-pass
processing and move the second loop to the failure case.
This will allow us to show the flags exactly as they appear
on-disk for bitm
On 20 June 2018 at 10:50, Edgar E. Iglesias wrote:
> On Tue, May 29, 2018 at 02:47:05PM +0200, Edgar E. Iglesias wrote:
>> From: "Edgar E. Iglesias"
>>
>> The ZynqMP actually has Cortex-R5Fs with the optional FPU enabled.
>
> Hi Peter,
>
> Any comments on this series?
Oops, looks like it didn't
Daniel P. Berrangé wrote:
> From: "Daniel P. Berrange"
.
It is not just the fault of this patch, but as you are the one doing the
tls bits on migration...
> @@ -1106,6 +1108,12 @@ static void migrate_params_apply(MigrateSetParameters
> *params, Error **errp)
> s->parameters.tls
Hi,
This series failed build test on s390x host. Please find the details below.
N/A. Internal error while reading log file
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
Never set to anything but 0.
Signed-off-by: David Hildenbrand
---
target/s390x/cpu.c | 1 -
target/s390x/cpu.h | 1 -
target/s390x/misc_helper.c | 4 ++--
3 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c
index 03ea6eafa7..a41b
Let's treat this like a separate device. TCG will have to store the
actual state/time later on.
Include cpu-qom.h in kvm_s390x.h (due to S390CPU) to compile tod-kvm.c.
Signed-off-by: David Hildenbrand
---
hw/s390x/Makefile.objs | 3 +
hw/s390x/s390-virtio-ccw.c | 57 +-
h
On Wed, Jun 20, 2018 at 12:03:45PM +0200, Juan Quintela wrote:
> Daniel P. Berrangé wrote:
> > From: "Daniel P. Berrange"
>
> .
>
>
> It is not just the fault of this patch, but as you are the one doing the
> tls bits on migration...
>
>
> > @@ -1106,6 +1108,12 @@ static void
> > migrat
Right now, each CPU has its own TOD. Especially, the TOD will differ
based on creation time of a CPU - e.g. when hotplugging a CPU the times
will differ quite a lot, resulting in stall warnings in the guest.
Let's use a single TOD by implementing our new TOD device. Prepare it
for TOD-clock epoch
The TOD in TCG is not handled correctly:
- each CPU has its own TOD based on CPU creation time vs. a system TOD
- TOD is not migrated
- TOD timer is not restarted during migration
- CKC interrupts/TOD timer is not cleared when resetting the CKC
This (and a cpu creation problem for single threaded
Let's stop the timer and delete any pending CKC IRQ before doing
anything else.
Signed-off-by: David Hildenbrand
---
target/s390x/misc_helper.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/target/s390x/misc_helper.c b/target/s390x/misc_helper.c
index 6ccbe1fe9a..d5f9f5e1d3 100644
--
run_on_cpu() doesn't seem to work reliably until the CPU has been fully
created if the single-threaded TCG main loop is already running.
Therefore, let's use run_on_cpu() for KVM only - KVM requires it due to
the initial CPU reset ioctl.
Signed-off-by: David Hildenbrand
---
target/s390x/cpu.c |
This allows a guest to change its TOD. We already take care of updating
all CKC timers from within S390TODClass.
Use MO_ALIGN to load the operand manually - this will properly trigger a
SPECIFICATION exception.
Signed-off-by: David Hildenbrand
---
target/s390x/helper.h | 1 +
target/s390x
Daniel P. Berrangé wrote:
> On Wed, Jun 20, 2018 at 12:03:45PM +0200, Juan Quintela wrote:
>> Daniel P. Berrangé wrote:
>> > From: "Daniel P. Berrange"
>>
>> .
>>
>>
>> It is not just the fault of this patch, but as you are the one doing the
>> tls bits on migration...
>>
>>
>> > @@ -11
If the CPU data is migrated after the TOD clock, the CKC timer of a CPU
is not rearmed. Let's rearm it when loading the CPU state.
Introduce tcg-stub.c just like kvm-stub.c for tcg specific stubs.
Signed-off-by: David Hildenbrand
---
target/s390x/Makefile.objs | 1 +
target/s390x/machine.c
This changes the IPC realize and reset handlers in DeviceRealize and
DeviceReset handlers. parent handlers are now called from the
inheriting classes which is a cleaner object pattern.
Signed-off-by: Cédric Le Goater
---
include/hw/ppc/xics.h | 5 +++--
hw/intc/xics.c| 10 --
hw
Hello,
First patch moves the common ICS code the ICS_BASE class. It makes the
class hierarchy much cleaner and removes duplicated code. Second patch
simply introduces ICP DeviceRealize and DeviceReset handler.
As we are touching the location of the objects states, migration
compatibilty needs to
This moves the common ICS code of the realize and reset handlers of
the ICS_SIMPLE class under the ICS_BASE class. The vmstate is also
moved down one class.
The benefits are that the ICS_KVM class can directly inherit from
ICS_BASE class and not from the intermediate ICS_SIMPLE. It makes the
class
* Juan Quintela (quint...@redhat.com) wrote:
> We synchronize all threads each RAM_SAVE_FLAG_EOS. Bitmap
> synchronizations don't happen inside a ram section, so we are safe
> about two channels trying to overwrite the same memory.
>
> Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan G
An update to
v1: https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg02179.html
v2: https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg04469.html
The current network services now support encryption via TLS and in some
cases support authentication via SASL. In cases where SASL is not
The inotify userspace API for reading events is quite horrible, so it is
useful to wrap it in a more friendly API to avoid duplicating code
across many users in QEMU. Wrapping it also allows introduction of a
platform portability layer, so that we can add impls for non-Linux based
equivalents in fu
When an object is in turn owned by another user object, it is not
desirable to expose this in the QOM object hierarchy, as it is
just an internal implementation detail, we should be free to change
without exposure.
Signed-off-by: Daniel P. Berrangé
---
qom/object.c| 12
The internal inotify APIs allow alot of conditional statements to be
cleared out, and provide a simpler callback for handling events.
Signed-off-by: Daniel P. Berrangé
---
hw/usb/dev-mtp.c| 250
hw/usb/trace-events | 2 +-
2 files changed, 93 in
IN_ISDIR is not a bit that one can request when registering a
watch with inotify_add_watch. Rather it is a bit that is set
automatically when reading events from the kernel.
Signed-off-by: Daniel P. Berrangé
---
hw/usb/dev-mtp.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
Various functions accepting 'char *' string parameters were missing
'const' qualifiers.
Signed-off-by: Daniel P. Berrangé
---
hw/usb/dev-mtp.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index 80f88e40fa..d5f570fb56 100644
--- a
Add a QAuthZListFile object type that implements the QAuthZ interface. This
built-in implementation is a proxy around the QAtuhZList object type,
initializing it from an external file, and optionally, automatically
reloading it whenever it changes.
To create an instance of this object via the QMP
In many cases a single VM will just need to whilelist a single identity
as the allowed user of network services. This is especially the case for
TLS live migration (optionally with NBD storage) where we just need to
whitelist the x509 certificate distinguished name of the source QEMU
host.
Via QMP
From: "Daniel P. Berrange"
The current qemu_acl module provides a simple access control list
facility inside QEMU, which is used via a set of monitor commands
acl_show, acl_policy, acl_add, acl_remove & acl_reset.
Note there is no ability to create ACLs - the network services (eg VNC
server) wer
From: "Daniel P. Berrange"
Add an authorization backend that talks to PAM to check whether the user
identity is allowed. This only uses the PAM account validation facility,
which is essentially just a check to see if the provided username is permitted
access. It doesn't use the authentication or
On 19 June 2018 at 16:43, Alex Bennée wrote:
> The following changes since commit 2ef2f16781af9dee6ba6517755e9073ba5799fa2:
>
> Merge remote-tracking branch
> 'remotes/dgilbert/tags/pull-migration-20180615a' into staging (2018-06-15
> 18:13:35 +0100)
>
> are available in the Git repository at:
From: "Daniel P. Berrange"
Add a QAuthZList object type that implements the QAuthZ interface. This
built-in implementation maintains a trivial access control list with a
sequence of match rules and a final default policy. This replicates the
functionality currently provided by the qemu_acl module
1 - 100 of 475 matches
Mail list logo
