Re: [Qemu-devel] [PATCH v2 08/13] hw/misc/tz_mpc.c: Honour the BLK_LUT settings in translate

2018-06-18 Thread Auger Eric
Hi Peter, On 06/15/2018 06:09 PM, Peter Maydell wrote: > On 15 June 2018 at 17:07, Peter Maydell wrote: >> On 15 June 2018 at 08:31, Auger Eric wrote: >>> Hi Peter, >>> >>> On 06/04/2018 05:29 PM, Peter Maydell wrote: The final part of the Memory Protection Controller we need to impleme

[Qemu-devel] [PATCH v5 2/2] qapi: remove empty flat union branches and types

2018-06-18 Thread Anton Nefedov
Flat unions may now have uncovered branches, so it is possible to get rid of empty types defined for that purpose only. Signed-off-by: Anton Nefedov Reviewed-by: Markus Armbruster --- qapi/block-core.json | 52 +++- qapi/crypto.json | 13 +

[Qemu-devel] [PATCH v5 0/2] qapi: allow empty branches in flat unions

2018-06-18 Thread Anton Nefedov
v5: remarks for patch 1 fixed v4: http://lists.nongnu.org/archive/html/qemu-devel/2018-06/msg03638.html Anton Nefedov (2): qapi: allow empty branches in flat unions qapi: remove empty flat union branches and types docs/devel/qapi-code-gen.txt | 8 ++-- qapi/block-core.

[Qemu-devel] [PATCH v5 1/2] qapi: allow empty branches in flat unions

2018-06-18 Thread Anton Nefedov
It often happens that just a few discriminator values imply extra data in a flat union. Existing checks did not make possible to leave other values uncovered. Such cases had to be worked around by either stating a dummy (empty) type or introducing another (subset) discriminator enumeration. Both o

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/3] spapr: introduce a fixed IRQ number space

2018-06-18 Thread Greg Kurz
On Fri, 15 Jun 2018 19:18:08 +0200 Cédric Le Goater wrote: > Hello, > > On 06/15/2018 06:03 PM, Greg Kurz wrote: > > On Fri, 15 Jun 2018 13:53:03 +0200 > > Cédric Le Goater wrote: > > > >> This proposal introduces a new IRQ number space layout using static > >> numbers for all devices and a

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/3] spapr: introduce a fixed IRQ number space

2018-06-18 Thread Cédric Le Goater
[ ... ] >>> This is 4 irqs per PHB, hence up to 32 PHBs. Cool, we're currently >>> limited to 31 PHBs. >>> +#define SPAPR_IRQ_MSI0x1100 /* Offset of the dynamic range covered >>> >>> We only support dynamic MSIs with PCI, maybe rename to SPAPR_IRQ_PCI_MSI ? >> >> hmm, no

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-2.13 01/10] spapr: Avoid redundant calls to spapr_cpu_reset()

2018-06-18 Thread Greg Kurz
On Mon, 18 Jun 2018 13:42:37 +1000 David Gibson wrote: > On Fri, Apr 20, 2018 at 05:39:42PM +0200, Greg Kurz wrote: > > On Fri, 20 Apr 2018 11:15:01 +0200 > > Greg Kurz wrote: > > > > > On Fri, 20 Apr 2018 16:34:37 +1000 > > > David Gibson wrote: > > > > > > > On Thu, Apr 19, 2018 at 03:4

[Qemu-devel] [PULL 2/3] Revert "usb: release the created buses"

2018-06-18 Thread Gerd Hoffmann
From: Marc-André Lureau The USB device don't hold the bus. There is no ASAN related reports anymore. This reverts commit cd7bc87868d534f95e928cad98e2a52df7695771. Signed-off-by: Marc-André Lureau Message-id: 20180613172815.32738-3-marcandre.lur...@redhat.com Signed-off-by: Gerd Hoffmann ---

[Qemu-devel] [PULL 1/3] Revert "usb-ccid: fix bus leak"

2018-06-18 Thread Gerd Hoffmann
From: Marc-André Lureau The bus is not owned by the device. This reverts commit 410a096adf991ce437d4d7dabc59b6557e6d488d. Signed-off-by: Marc-André Lureau Message-id: 20180613172815.32738-2-marcandre.lur...@redhat.com Signed-off-by: Gerd Hoffmann --- hw/usb/dev-smartcard-reader.c | 1 - 1 fi

[Qemu-devel] [PULL 3/3] Revert "bus: do not unref the added child bus on realize"

2018-06-18 Thread Gerd Hoffmann
From: Marc-André Lureau This is wrong. object_finalize_child_property()'s unref balances the ref in object_property_add_child(). qbus_realize's unref balances the ref that was initially placed by object_new/object_initialize. This reverts commit f3d58385a6d3d82f65db602c5506e2d3d8c82394. Repor

[Qemu-devel] [PULL 0/3] Usb 20180618 patches

2018-06-18 Thread Gerd Hoffmann
The following changes since commit 2ef2f16781af9dee6ba6517755e9073ba5799fa2: Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20180615a' into staging (2018-06-15 18:13:35 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/usb-201

Re: [Qemu-devel] [PATCH qemu v4] memory/hmp: Print owners/parents in "info mtree"

2018-06-18 Thread Alexey Kardashevskiy
On Mon, 4 Jun 2018 13:25:11 +1000 Alexey Kardashevskiy wrote: > This adds owners/parents (which are the same, just occasionally > owner==NULL) printing for memory regions; a new '-o' flag > enabled new output. > > Signed-off-by: Alexey Kardashevskiy Ping? Has this gone anywhere? > --- > >

Re: [Qemu-devel] [RFC v2 6/6] hw/arm: Populate non-contiguous memory regions

2018-06-18 Thread Shameerali Kolothum Thodi
> -Original Message- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: 15 June 2018 17:33 > To: Auger Eric > Cc: Andrew Jones ; Shameerali Kolothum Thodi > ; qemu-devel@nongnu.org; qemu- > a...@nongnu.org; Jonathan Cameron ; > Linuxarm ; alex.william...@redhat.com; > Zhaosh

Re: [Qemu-devel] [PATCH] Replaced git:// to https:// - resolved receiving sources behind some routers and HW-firewalls Fixed URLs to actual - replaced git.qemu-project.com to git.qemu.org Slightly fix

2018-06-18 Thread Daniel P . Berrangé
You need to trim the subject line so it is about 70 characters or less and then have a blank line On Mon, Jun 18, 2018 at 12:32:01PM +0300, Iliya Dyachenko wrote: > Signed-off-by: Iliya Dyachenko > --- > .gitmodules | 32 > 1 file changed, 16 insertions(+), 16 de

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/3] spapr: introduce a fixed IRQ number space

2018-06-18 Thread Greg Kurz
On Mon, 18 Jun 2018 10:56:55 +0200 Cédric Le Goater wrote: > [ ... ] > > >>> This is 4 irqs per PHB, hence up to 32 PHBs. Cool, we're currently > >>> limited to 31 PHBs. > >>> > +#define SPAPR_IRQ_MSI0x1100 /* Offset of the dynamic range > covered > >>> > >>> We only

[Qemu-devel] [PULL 0/4] Vga 20180618 patches

2018-06-18 Thread Gerd Hoffmann
The following changes since commit 2ef2f16781af9dee6ba6517755e9073ba5799fa2: Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20180615a' into staging (2018-06-15 18:13:35 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/vga-201

[Qemu-devel] [PULL 1/4] configure: print virglrenderer version

2018-06-18 Thread Gerd Hoffmann
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Ján Tomko Message-id: 20180525153609.13187-1-marcandre.lur...@redhat.com Signed-off-by: Gerd Hoffmann --- configure | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configure b/configure index a8c4094c8

[Qemu-devel] [PULL 2/4] hw/display: add ramfb, a simple boot framebuffer living in guest ram

2018-06-18 Thread Gerd Hoffmann
The boot framebuffer is expected to be configured by the firmware, so it uses fw_cfg as interface. Initialization goes as follows: (1) Check whenever etc/ramfb is present. (2) Allocate framebuffer from RAM. (3) Fill struct RAMFBCfg, write it to etc/ramfb. Done. You can write stuff to the

[Qemu-devel] [PULL 4/4] Add ramfb MAINTAINERS entry

2018-06-18 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Laszlo Ersek Message-id: 20180613122948.18149-5-kra...@redhat.com Signed-off-by: Gerd Hoffmann --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0fb5f38f9f..da91501c7a 100644 --- a/MAINTAINERS +++

[Qemu-devel] [PULL 3/4] hw/display: add standalone ramfb device

2018-06-18 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Tested-by: Laszlo Ersek Message-id: 20180613122948.18149-3-kra...@redhat.com Signed-off-by: Gerd Hoffmann --- include/hw/display/ramfb.h| 3 +++ hw/arm/sysbus-fdt.c | 7 + hw/arm/virt.c | 2 ++ hw/display/ramfb-standalone.c | 62

Re: [Qemu-devel] [PATCH] ps2: check PS2Queue wptr pointer in post_load routine

2018-06-18 Thread kra...@redhat.com
On Thu, Jun 14, 2018 at 10:50:47AM +, liujunjie (A) wrote: > ping Not much activity on input devices, so we have rare pull requests ... Preparing one now, with this patch added. cheers, Gerd

[Qemu-devel] [PULL 0/1] Input 20180618 patches

2018-06-18 Thread Gerd Hoffmann
The following changes since commit 2ef2f16781af9dee6ba6517755e9073ba5799fa2: Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20180615a' into staging (2018-06-15 18:13:35 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/input-201

[Qemu-devel] [PULL 1/1] ps2: check PS2Queue wptr pointer in post_load routine

2018-06-18 Thread Gerd Hoffmann
From: liujunjie In commit 802cbcb7300, most issues have been fixed when qemu guest migration. But the queue size still need to check whether is equal to PS2_QUEUE_SIZE. If yes, the wptr should set as 0. Or, wptr would larger than PS2_QUEUE_SIZE and never come back when ps2_queue_noirq is called.

[Qemu-devel] [PATCH v2] docs: add guidance on configuring CPU models for x86

2018-06-18 Thread Daniel P . Berrangé
With the recent set of CPU hardware vulnerabilities on x86, it is increasingly difficult to understand which CPU configurations are good to use and what flaws they might be vulnerable to. This doc attempts to help management applications and administrators in picking sensible CPU configuration on

Re: [Qemu-devel] [RFC v1 1/1] virtio-crypto: Allow disabling of cipher algorithms for virtio-crypto device

2018-06-18 Thread Viktor VM Mihajlovski
On 15.06.2018 17:10, Farhan Ali wrote: > > > On 06/15/2018 09:17 AM, Viktor VM Mihajlovski wrote: [...] >> >> With the current virtio-crypto backend functionality offered (CBC AES >> only) it may seem a bit over-engineered to offer a configuration option >> to remove the only supported algorithm.

Re: [Qemu-devel] [PATCH v2 3/4] ppc/pnv: introduce Pnv8Chip and Pnv9Chip models

2018-06-18 Thread David Gibson
On Fri, Jun 15, 2018 at 05:25:35PM +0200, Cédric Le Goater wrote: > This is a major reshuffle of the PowerNV machine and chip models to > introduce a machine type per processor. It is quite noisy but it > doesn't change much the code flow. > > It introduces a base PnvChip class from which the spec

Re: [Qemu-devel] [PATCH] target/arm: Allow ARMv6-M Thumb2 instructions

2018-06-18 Thread Peter Maydell
On 17 June 2018 at 19:48, Julia Suvorova wrote: > I can make it if you wish. > In addition, we can simplify following "if" by removing ARM_FEATURE_V6 > since V7M and V8M define V6: > > if (!arm_dc_feature(s, ARM_FEATURE_V7) && > !(arm_dc_feature(s, ARM_FEATURE_V6) && > arm_dc

Re: [Qemu-devel] [PATCH v3 11/13] nvdimm: allow setting the label-size to 0

2018-06-18 Thread David Hildenbrand
On 16.06.2018 04:05, Haozhong Zhang wrote: > On 06/15/18 16:04, David Hildenbrand wrote: >> It is inititally 0, so setting it to 0 should be allowed, too. > > I'm fine with this change and believe nothing is broken in practice, > but what is expected by the user who sets a zero label size? I'd sa

Re: [Qemu-devel] [PATCH v3 10/13] nvdimm: convert nvdimm_mr into a pointer

2018-06-18 Thread David Hildenbrand
On 18.06.2018 02:49, David Gibson wrote: > On Fri, Jun 15, 2018 at 04:04:45PM +0200, David Hildenbrand wrote: >> This way we can easily check if the region has already been inititalized >> without having to rely on the size of an uninitialized region being 0. >> >> Signed-off-by: David Hildenbrand

[Qemu-devel] enabling smart-http git protocol on git.qemu.org

2018-06-18 Thread Peter Maydell
On 18 June 2018 at 10:47, Daniel P. Berrangé wrote: > On Mon, Jun 18, 2018 at 12:32:01PM +0300, Iliya Dyachenko wrote: >> Signed-off-by: Iliya Dyachenko >> --- >> .gitmodules | 32 >> 1 file changed, 16 insertions(+), 16 deletions(-) >> >> diff --git a/.gitmodule

Re: [Qemu-devel] [PATCH v7 12/54] tests/tcg/multiarch: don't hard code paths/ports for linux-test

2018-06-18 Thread Alex Bennée
Thomas Huth writes: > On 15.06.2018 21:46, Alex Bennée wrote: >> The fixed path and ports get in the way of running our tests and >> builds in parallel. Instead of using TESTPATH we use mkdtemp() and >> instead of a fixed port we allow the kernel to assign one and query it >> afterwards. >> >>

Re: [Qemu-devel] [PATCH v7 12/54] tests/tcg/multiarch: don't hard code paths/ports for linux-test

2018-06-18 Thread Thomas Huth
On 18.06.2018 12:56, Alex Bennée wrote: > > Thomas Huth writes: > >> On 15.06.2018 21:46, Alex Bennée wrote: >>> The fixed path and ports get in the way of running our tests and >>> builds in parallel. Instead of using TESTPATH we use mkdtemp() and >>> instead of a fixed port we allow the kernel

Re: [Qemu-devel] [PATCH v7 12/54] tests/tcg/multiarch: don't hard code paths/ports for linux-test

2018-06-18 Thread Daniel P . Berrangé
On Mon, Jun 18, 2018 at 11:56:08AM +0100, Alex Bennée wrote: > > Thomas Huth writes: > > > On 15.06.2018 21:46, Alex Bennée wrote: > >> The fixed path and ports get in the way of running our tests and > >> builds in parallel. Instead of using TESTPATH we use mkdtemp() and > >> instead of a fixed

Re: [Qemu-devel] [PATCH v7 12/54] tests/tcg/multiarch: don't hard code paths/ports for linux-test

2018-06-18 Thread Thomas Huth
On 18.06.2018 13:08, Daniel P. Berrangé wrote: > On Mon, Jun 18, 2018 at 11:56:08AM +0100, Alex Bennée wrote: >> >> Thomas Huth writes: >> >>> On 15.06.2018 21:46, Alex Bennée wrote: The fixed path and ports get in the way of running our tests and builds in parallel. Instead of using TES

Re: [Qemu-devel] [PATCH v7 12/54] tests/tcg/multiarch: don't hard code paths/ports for linux-test

2018-06-18 Thread Daniel P . Berrangé
On Mon, Jun 18, 2018 at 01:09:54PM +0200, Thomas Huth wrote: > On 18.06.2018 13:08, Daniel P. Berrangé wrote: > > On Mon, Jun 18, 2018 at 11:56:08AM +0100, Alex Bennée wrote: > >> > >> Thomas Huth writes: > >> > >>> On 15.06.2018 21:46, Alex Bennée wrote: > The fixed path and ports get in the

Re: [Qemu-devel] [PATCH v5 1/2] qapi: allow empty branches in flat unions

2018-06-18 Thread Markus Armbruster
Anton Nefedov writes: > It often happens that just a few discriminator values imply extra data in > a flat union. Existing checks did not make possible to leave other values > uncovered. Such cases had to be worked around by either stating a dummy > (empty) type or introducing another (subset) di

Re: [Qemu-devel] [PATCH] ui/cocoa.m: fix absolute mode

2018-06-18 Thread Peter Maydell
On 8 June 2018 at 21:01, John Arbuckle wrote: > Fix the cocoa front-end to correctly be able to use absolute mode. > > Signed-off-by: John Arbuckle This commit message is insufficiently detailed, which makes it hard to review the patch. When you send patches, please can you provide commit messag

[Qemu-devel] [PATCH] Add gles support to egl-helpers, wire up in egl-headless and gtk.

2018-06-18 Thread Gerd Hoffmann
Add support for OpenGL ES to egl-helpers. Wire up the new option for egl-headless and gtk UIs. egl-headless actually works fine. gtk hits a not-yet implemented code path in libEGL when trying to use gles mode: libEGL warning: FIXME: egl/x11 doesn't support front buffer rendering. (This is me

Re: [Qemu-devel] enabling smart-http git protocol on git.qemu.org

2018-06-18 Thread Gerd Hoffmann
Hi, > > ScriptAliasMatch "^/git/(.*\.git/(HEAD|info/refs))$" \ > > /usr/libexec/git-core/git-http-backend/$1 > > ScriptAliasMatch "^/git/(.*\.git/git-(upload|receive)-pack)$" \ > > /usr/libexec/git-core/git-http-backend/$1 > > Sounds like a good idea -- I've cc'd Jeff and Stefan (wh

Re: [Qemu-devel] [PATCH v2 3/4] ppc/pnv: introduce Pnv8Chip and Pnv9Chip models

2018-06-18 Thread Cédric Le Goater
On 06/18/2018 12:38 PM, David Gibson wrote: > On Fri, Jun 15, 2018 at 05:25:35PM +0200, Cédric Le Goater wrote: >> This is a major reshuffle of the PowerNV machine and chip models to >> introduce a machine type per processor. It is quite noisy but it >> doesn't change much the code flow. >> >> It i

Re: [Qemu-devel] [PATCH] fpu_helper.c: fix helper_fpscr_clrbit() function

2018-06-18 Thread Peter Maydell
On 17 June 2018 at 16:53, John Arbuckle wrote: > Fix the helper_fpscr_clrbit() function so it correctly > sets the FEX and VX bits. > > Signed-off-by: John Arbuckle > --- > target/ppc/fpu_helper.c | 57 > + > 1 file changed, 57 insertions(+) > > d

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/3] spapr: introduce a fixed IRQ number space

2018-06-18 Thread Cédric Le Goater
On 06/18/2018 11:54 AM, Greg Kurz wrote: > On Mon, 18 Jun 2018 10:56:55 +0200 > Cédric Le Goater wrote: > >> [ ... ] >> > This is 4 irqs per PHB, hence up to 32 PHBs. Cool, we're currently > limited to 31 PHBs. > >> +#define SPAPR_IRQ_MSI0x1100 /* Offset of the dynam

Re: [Qemu-devel] [PATCH v3 08/13] pc-dimm: merge get_(vmstate_)memory_region()

2018-06-18 Thread Igor Mammedov
On Fri, 15 Jun 2018 16:04:43 +0200 David Hildenbrand wrote: > Importantly, get_vmstate_memory_region() should also fail with a proper > error if called before the device is realized. For a PCDIMM, both functions > are to return the same thing, so share the implementation. > > All current users a

Re: [Qemu-devel] [PATCH 3/6] intc/arm_gic: Add the virtualization extensions to the GIC state

2018-06-18 Thread Luc Michel
On 06/11/2018 03:38 PM, Peter Maydell wrote: > On 6 June 2018 at 10:30, wrote: >> From: Luc MICHEL >> >> Add the necessary parts of the virtualization extensions state to the >> GIC state. We choose to increase the size of the CPU interfaces state to >> add space for the vCPU interfaces (the GIC

Re: [Qemu-devel] [PATCH v3 11/13] nvdimm: allow setting the label-size to 0

2018-06-18 Thread Igor Mammedov
On Fri, 15 Jun 2018 16:04:46 +0200 David Hildenbrand wrote: > It is inititally 0, so setting it to 0 should be allowed, too. I'm not sure if we need to permit it. By default labels are disabled (label-size=0) and user are supposed to provide this option if labels should be enabled with a valid si

Re: [Qemu-devel] [PATCH v7 12/54] tests/tcg/multiarch: don't hard code paths/ports for linux-test

2018-06-18 Thread Alex Bennée
Daniel P. Berrangé writes: > On Mon, Jun 18, 2018 at 11:56:08AM +0100, Alex Bennée wrote: >> >> Thomas Huth writes: >> >> > On 15.06.2018 21:46, Alex Bennée wrote: >> >> The fixed path and ports get in the way of running our tests and >> >> builds in parallel. Instead of using TESTPATH we use

Re: [Qemu-devel] [PATCH v3 11/13] nvdimm: allow setting the label-size to 0

2018-06-18 Thread David Hildenbrand
On 18.06.2018 14:03, Igor Mammedov wrote: > On Fri, 15 Jun 2018 16:04:46 +0200 > David Hildenbrand wrote: > >> It is inititally 0, so setting it to 0 should be allowed, too. > I'm not sure if we need to permit it. > By default labels are disabled (label-size=0) and user are supposed to provide >

Re: [Qemu-devel] [PATCH 3/6] intc/arm_gic: Add the virtualization extensions to the GIC state

2018-06-18 Thread Peter Maydell
On 18 June 2018 at 12:50, Luc Michel wrote: > Indeed you are right, h_apr is a leftover that is not used in my > implementation. I use apr[0] of the vCPU interface to store the APR > value. If it's ok like this, I can simply remove h_apr from the struct > and from the virt VMState. > > The same go

[Qemu-devel] [PATCH 2/2] spapr_cpu_core: migrate VPA related state

2018-06-18 Thread Greg Kurz
QEMU implements the "Shared Processor LPAR" (SPLPAR) option, which allows the hypervisor to time-slice a physical processor into multiple virtual processor. The intent is to allow more guests to run, and to optimize processor utilization. The guest OS can cede idle VCPUs, so that their processing

[Qemu-devel] [PATCH 1/2] spapr_cpu_core: migrate per-CPU data

2018-06-18 Thread Greg Kurz
A per-CPU machine data pointer was recently added to PowerPCCPU. The motivation is to to hide platform specific details from the core CPU code. This per-CPU data can hold state which is revelant to the guest though, eg, Virtual Processor Areas, and we whould migrate this state. This patch adds the

Re: [Qemu-devel] [PATCH v2 3/4] ppc/pnv: introduce Pnv8Chip and Pnv9Chip models

2018-06-18 Thread David Gibson
On Mon, Jun 18, 2018 at 01:30:13PM +0200, Cédric Le Goater wrote: > On 06/18/2018 12:38 PM, David Gibson wrote: > > On Fri, Jun 15, 2018 at 05:25:35PM +0200, Cédric Le Goater wrote: > >> This is a major reshuffle of the PowerNV machine and chip models to > >> introduce a machine type per processor.

Re: [Qemu-devel] [PATCH 1/3] spapr: split the IRQ allocation sequence

2018-06-18 Thread David Gibson
On Mon, Jun 18, 2018 at 02:00:06PM +1000, David Gibson wrote: > On Fri, Jun 15, 2018 at 01:53:01PM +0200, Cédric Le Goater wrote: > > Today, when a device requests for IRQ number in a sPAPR machine, the > > spapr_irq_alloc() routine first scans the ICSState status array to > > find an empty slot an

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/3] spapr: introduce a fixed IRQ number space

2018-06-18 Thread David Gibson
On Fri, Jun 15, 2018 at 06:03:11PM +0200, Greg Kurz wrote: > On Fri, 15 Jun 2018 13:53:03 +0200 > Cédric Le Goater wrote: > > > This proposal introduces a new IRQ number space layout using static > > numbers for all devices and a bitmap allocator for the MSI numbers > > which are negotiated by th

Re: [Qemu-devel] [PATCH v3 00/13] pc-dimm: next bunch of cleanups

2018-06-18 Thread David Hildenbrand
On 15.06.2018 16:04, David Hildenbrand wrote: > This is another set of cleanups as the result from > [PATCH v4 00/14] MemoryDevice: use multi stage hotplug handlers > And is based on > [PATCH v1 0/2] memory: fix alignment checks/asserts > > These cleanup are the last step before > - 1. mov

Re: [Qemu-devel] [PATCH v7 12/54] tests/tcg/multiarch: don't hard code paths/ports for linux-test

2018-06-18 Thread Thomas Huth
On 18.06.2018 14:04, Alex Bennée wrote: > > Daniel P. Berrangé writes: > >> On Mon, Jun 18, 2018 at 11:56:08AM +0100, Alex Bennée wrote: >>> >>> Thomas Huth writes: >>> On 15.06.2018 21:46, Alex Bennée wrote: > The fixed path and ports get in the way of running our tests and > buil

Re: [Qemu-devel] [PATCH v3 10/13] nvdimm: convert nvdimm_mr into a pointer

2018-06-18 Thread Igor Mammedov
On Fri, 15 Jun 2018 16:04:45 +0200 David Hildenbrand wrote: > This way we can easily check if the region has already been inititalized > without having to rely on the size of an uninitialized region being 0. > > Signed-off-by: David Hildenbrand Reviewed-by: Igor Mammedov > --- > hw/mem/nvdi

Re: [Qemu-devel] [PATCH v3 12/13] nvdimm: make get_memory_region() perform checks and initialization

2018-06-18 Thread Igor Mammedov
On Fri, 15 Jun 2018 16:04:47 +0200 David Hildenbrand wrote: > We might get a call to get_memory_region() before the device has been > realized. We should return a consistent value, as the return value > will e.g. later on be used in the pre_plug handler. > > To avoid duplicating too much code, f

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/3] spapr: introduce a fixed IRQ number space

2018-06-18 Thread Greg Kurz
On Mon, 18 Jun 2018 13:31:26 +0200 Cédric Le Goater wrote: > On 06/18/2018 11:54 AM, Greg Kurz wrote: > > On Mon, 18 Jun 2018 10:56:55 +0200 > > Cédric Le Goater wrote: > > > >> [ ... ] > >> > > This is 4 irqs per PHB, hence up to 32 PHBs. Cool, we're currently > > limited to 31 PHB

[Qemu-devel] [PATCH v1 6/8] docker: docker.py don't conflate checksums for extra_files

2018-06-18 Thread Alex Bennée
This just gets confusing especially as the helper function doesn't even take into account any extra files (or the executable). Currently the actual check just ignores them and also passes the result through _dockerfile_preprocess so we fix that too. Signed-off-by: Alex Bennée --- tests/docker/do

[Qemu-devel] [PATCH v1 2/8] docker: extend "cc" command to accept compiler

2018-06-18 Thread Alex Bennée
When calling our cross-compilation images we want to call something other than the default cc. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Fam Zheng --- v2 - use arg.cc default to simplify logic --- tests/docker/docker.py | 4 +++- 1 file changed, 3 insertions

[Qemu-devel] [PATCH v1 5/8] docker: docker.py use "ps" to probe usage

2018-06-18 Thread Alex Bennée
The "images" command is a fairly heavyweight command to run as it involves searching the whole docker file-system inventory. On a machine with a lot of images this makes start-up fairly expensive. Signed-off-by: Alex Bennée --- tests/docker/docker.py | 2 +- 1 file changed, 1 insertion(+), 1 del

[Qemu-devel] [PATCH v1 0/8] Docker tweaks for TCG testing

2018-06-18 Thread Alex Bennée
Hi Fam, These are the docker specific changes from my current TCG testing branch: https://github.com/stsquad/qemu/tree/testing/tcg-tests-revival-v8 Once the CI tests have worked their way through I'm hoping to submit the pull-req to get this merged. However I've been hacking about in docker.py

[Qemu-devel] [PATCH v1 4/8] docker: Makefile.include introduce DOCKER_SCRIPT

2018-06-18 Thread Alex Bennée
Define this in one place to make it easy to re-use. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé --- tests/docker/Makefile.include | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index

[Qemu-devel] [PATCH v1 3/8] docker: allow "cc" command to run in user context

2018-06-18 Thread Alex Bennée
Signed-off-by: Alex Bennée Reviewed-by: Fam Zheng Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- tests/docker/docker.py | 4 1 file changed, 4 insertions(+) diff --git a/tests/docker/docker.py b/tests/docker/docker.py index 663dfcba4b..c83fd89985 100755 --- a/t

[Qemu-devel] [PATCH v1 1/8] docker: Add "cc" subcommand

2018-06-18 Thread Alex Bennée
Signed-off-by: Fam Zheng [AJB: add if args.paths check] Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- v2 - add if args.paths check to avoid iterating null argument --- tests/docker/docker.py | 25 + 1 file changed

[Qemu-devel] [PATCH v1 7/8] docker: docker.py add check sub-command

2018-06-18 Thread Alex Bennée
This command allows you to check if we need to re-build a docker image. If the image isn't in the repository or the checksums don't match then we return false and some text (for processing in makefiles). Signed-off-by: Alex Bennée --- - fix prints to be "modern" - PEP8 fixes - split inspec

[Qemu-devel] [PATCH v1 8/8] docker: docker.py adding age check command

2018-06-18 Thread Alex Bennée
This is useful for querying if an image is too old. Signed-off-by: Alex Bennée --- v7 - use cached info --- tests/docker/docker.py | 46 +- 1 file changed, 36 insertions(+), 10 deletions(-) diff --git a/tests/docker/docker.py b/tests/docker/docker.py i

Re: [Qemu-devel] [PATCH 1/9] target/ppc: Allow cpu compatiblity checks based on type, not instance

2018-06-18 Thread Greg Kurz
On Mon, 18 Jun 2018 16:35:58 +1000 David Gibson wrote: > ppc_check_compat() is used in a number of places to check if a cpu object > supports a certain compatiblity mode, subject to various constraints. > > It takes a PowerPCCPU *, however it really only depends on the cpu's class. > We have upc

Re: [Qemu-devel] [virtio-dev] Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-18 Thread Cornelia Huck
On Fri, 15 Jun 2018 15:31:43 +0300 "Michael S. Tsirkin" wrote: > On Fri, Jun 15, 2018 at 11:32:42AM +0200, Cornelia Huck wrote: > > On Fri, 15 Jun 2018 05:34:24 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Jun 14, 2018 at 12:02:31PM +0200, Cornelia Huck wrote: > > > > > > > >

Re: [Qemu-devel] [PATCH 2/9] spapr: Compute effective capability values earlier

2018-06-18 Thread Greg Kurz
On Mon, 18 Jun 2018 16:35:59 +1000 David Gibson wrote: > Previously, the effective values of the various spapr capability flags > were only determined at machine reset time. That was a lazy way of making > sure it was after cpu initialization so it could use the cpu object to > inform the defaul

Re: [Qemu-devel] [PATCH 3/6] migration: add support for a "tls-authz" migration parameter

2018-06-18 Thread Daniel P . Berrangé
On Fri, Jun 15, 2018 at 06:54:23PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > From: "Daniel P. Berrange" > > > > The QEMU instance that runs as the server for the migration data > > transport (ie the target QEMU) needs to be able to configure acce

Re: [Qemu-devel] [PATCH] compiler: add a sizeof_field() macro

2018-06-18 Thread Stefan Hajnoczi
On Thu, Jun 14, 2018 at 05:44:31PM +0100, Stefan Hajnoczi wrote: > Determining the size of a field is useful when you don't have a struct > variable handy. Open-coding this is ugly. > > This patch adds the sizeof_field() macro, which is similar to > typeof_field(). Existing instances are updated

Re: [Qemu-devel] enabling smart-http git protocol on git.qemu.org

2018-06-18 Thread Jeff Cody
On Mon, Jun 18, 2018 at 11:55:05AM +0100, Peter Maydell wrote: > On 18 June 2018 at 10:47, Daniel P. Berrangé wrote: > > On Mon, Jun 18, 2018 at 12:32:01PM +0300, Iliya Dyachenko wrote: > >> Signed-off-by: Iliya Dyachenko > >> --- > >> .gitmodules | 32 > >> 1 fi

Re: [Qemu-devel] enabling smart-http git protocol on git.qemu.org

2018-06-18 Thread Jeff Cody
On Mon, Jun 18, 2018 at 01:26:22PM +0200, Gerd Hoffmann wrote: > Hi, > > > > ScriptAliasMatch "^/git/(.*\.git/(HEAD|info/refs))$" \ > > > /usr/libexec/git-core/git-http-backend/$1 > > > ScriptAliasMatch "^/git/(.*\.git/git-(upload|receive)-pack)$" \ > > > /usr/libexec/git-core/git-ht

Re: [Qemu-devel] [PATCH v5 02/14] block/mirror: Convert to coroutines

2018-06-18 Thread Max Reitz
On 2018-06-14 17:22, Kevin Wolf wrote: > Am 13.06.2018 um 20:18 hat Max Reitz geschrieben: >> In order to talk to the source BDS (and maybe in the future to the >> target BDS as well) directly, we need to convert our existing AIO >> requests into coroutine I/O requests. >> >> Signed-off-by: Max Rei

Re: [Qemu-devel] enabling smart-http git protocol on git.qemu.org

2018-06-18 Thread Daniel P . Berrangé
On Mon, Jun 18, 2018 at 09:54:10AM -0400, Jeff Cody wrote: > On Mon, Jun 18, 2018 at 11:55:05AM +0100, Peter Maydell wrote: > > On 18 June 2018 at 10:47, Daniel P. Berrangé wrote: > > > On Mon, Jun 18, 2018 at 12:32:01PM +0300, Iliya Dyachenko wrote: > > >> Signed-off-by: Iliya Dyachenko > > >> -

[Qemu-devel] [PULL SUBSYSTEM s390x v2 7/7] pc-bios/s390-ccw: Update the s390-netboot.img binary

2018-06-18 Thread Thomas Huth
This binary now contains the support for pxelinux.cfg-style network booting. Signed-off-by: Thomas Huth --- pc-bios/s390-netboot.img | Bin 87872 -> 54944 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/pc-bios/s390-netboot.img b/pc-bios/s390-netboot.img index ef561efd2e222e

[Qemu-devel] [PULL 1/7] monitor: rename out_lock to mon_lock

2018-06-18 Thread Markus Armbruster
From: Peter Xu The out_lock is protecting a few Monitor fields. In the future the monitor code will start to run in multiple threads. We are going to turn it into a bigger lock to protect not only the out buffer but also most of the rest. Since at it, rearrange the Monitor struct a bit. Revie

[Qemu-devel] [PULL SUBSYSTEM s390x v2 0/7] pxelinux.cfg-style booting for the s390x bios

2018-06-18 Thread Thomas Huth
This PULL request is not for master. Hi Cornelia, the following changes since commit 2ab09bf2f9f55b9fb8d2de6eb2ba2a8570e268e2: Merge remote-tracking branch 'remotes/kraxel/tags/usb-20180612-pull-request' into staging (2018-06-12 15:34:34 +0100) are available in the git repository at: ht

[Qemu-devel] [PULL 5/7] monitor: remove event_clock_type

2018-06-18 Thread Markus Armbruster
From: Peter Xu Instead, use a dynamic function to detect which clock we'll use. The problem is that the old code will let monitor initialization depend on configure_accelerator() (that's where qtest_enabled() start to take effect). After this change, we don't have such a dependency any more. We

[Qemu-devel] [PULL 3/7] monitor: more comments on lock-free elements

2018-06-18 Thread Markus Armbruster
From: Peter Xu Add some explicit comments for both Readline and cpu_set/cpu_get helpers that they do not need the mon_lock protection. Reviewed-by: Stefan Hajnoczi Reviewed-by: Markus Armbruster Signed-off-by: Peter Xu Message-Id: <20180608035511.7439-4-pet...@redhat.com> Signed-off-by: Marku

[Qemu-devel] [PULL 4/7] monitor: fix comment for monitor_lock

2018-06-18 Thread Markus Armbruster
From: Peter Xu Fix typo in d622cb5879c. Meanwhile move these variables close to each other. monitor_qapi_event_state can be declared static, add that. Reported-by: Markus Armbruster Reviewed-by: Stefan Hajnoczi Reviewed-by: Markus Armbruster Signed-off-by: Peter Xu Message-Id: <20180608035

[Qemu-devel] [PULL 0/7] monitor: Thread safety improvements

2018-06-18 Thread Markus Armbruster
The following changes since commit 2ef2f16781af9dee6ba6517755e9073ba5799fa2: Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20180615a' into staging (2018-06-15 18:13:35 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-monitor-2018

[Qemu-devel] [PULL 6/7] monitor: move init global earlier

2018-06-18 Thread Markus Armbruster
From: Peter Xu Before this patch, monitor fd helpers might be called even earlier than monitor_init_globals(). This can be problematic. After previous work, now monitor_init_globals() does not depend on accelerator initialization any more. Call it earlier (before CLI parsing; that's where the

[Qemu-devel] [PULL 2/7] monitor: protect mon->fds with mon_lock

2018-06-18 Thread Markus Armbruster
From: Peter Xu mon->fds were protected by BQL. Now protect it by mon_lock so that it can even be used in monitor iothread. Reviewed-by: Stefan Hajnoczi Reviewed-by: Markus Armbruster Signed-off-by: Peter Xu Message-Id: <20180608035511.7439-3-pet...@redhat.com> Signed-off-by: Markus Armbruste

[Qemu-devel] [PULL 7/7] monitor: add lock to protect mon_fdsets

2018-06-18 Thread Markus Armbruster
From: Peter Xu Introduce a new global big lock for mon_fdsets. Take it where needed. The monitor_fdset_get_fd() handling is a bit tricky: now we need to call qemu_mutex_unlock() which might pollute errno, so we need to make sure the correct errno be passed up to the callers. To make things sim

Re: [Qemu-devel] [RFC PATCH 05/10] block: Add 'keep_old_opts' parameter to bdrv_reopen_queue()

2018-06-18 Thread Kevin Wolf
Am 14.06.2018 um 17:49 hat Alberto Garcia geschrieben: > The bdrv_reopen_queue() function is used to create a queue with the > BDSs that are going to be reopened and their new options. Once the > queue is ready bdrv_reopen_multiple() is called to perform the > operation. > > The original options f

[Qemu-devel] [PATCH v4 00/12] pc-dimm: next bunch of cleanups

2018-06-18 Thread David Hildenbrand
@Paolo I have r-b for all patches. If there are no further comments, can you pick it up, please? This is another set of cleanups as the result from [PATCH v4 00/14] MemoryDevice: use multi stage hotplug handlers And is based on [PATCH v1 0/2] memory: fix alignment checks/asserts These cl

[Qemu-devel] [PATCH v4 02/12] pc: rename pc_dimm_(plug|unplug|...)* into pc_memory_(plug|unplug|...)*

2018-06-18 Thread David Hildenbrand
Use a similar naming scheme as spapr. This way, we can go ahead and rename e.g. pc_dimm_memory_plug to pc_dimm_plug, which avoids confusion. Reviewed-by: Igor Mammedov Reviewed-by: David Gibson Signed-off-by: David Hildenbrand --- hw/i386/pc.c | 18 +- 1 file changed, 9 inserti

[Qemu-devel] [PATCH v4 07/12] hostmem: drop error variable from host_memory_backend_get_memory()

2018-06-18 Thread David Hildenbrand
Unused, so let's remove it. Reviewed-by: David Gibson Reviewed-by: Igor Mammedov Signed-off-by: David Hildenbrand --- backends/hostmem.c | 3 +-- hw/mem/nvdimm.c | 4 ++-- hw/mem/pc-dimm.c | 4 ++-- hw/misc/ivshmem.c| 3 +-- include/sysemu/hostmem.h | 3 +-- numa

[Qemu-devel] [PATCH v4 06/12] nvdimm: no need to overwrite get_vmstate_memory_region()

2018-06-18 Thread David Hildenbrand
Our parent class (PC_DIMM) provides exactly the same function. Reviewed-by: David Gibson Reviewed-by: Igor Mammedov Signed-off-by: David Hildenbrand --- hw/mem/nvdimm.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/hw/mem/nvdimm.c b/hw/mem/nvdimm.c index 4087aca25e..f974accbdd 10064

[Qemu-devel] [PATCH v4 03/12] pc-dimm: rename pc_dimm_memory_* to pc_dimm_*

2018-06-18 Thread David Hildenbrand
Let's rename it to make it look more consistent. Reviewed-by: Igor Mammedov Reviewed-by: David Gibson Signed-off-by: David Hildenbrand --- hw/i386/pc.c | 4 ++-- hw/mem/pc-dimm.c | 6 +++--- hw/ppc/spapr.c | 6 +++--- include/hw/mem/pc-dimm.h | 6 +++--- 4 files c

[Qemu-devel] [PATCH v4 01/12] pc-dimm: remove leftover "struct pc_dimms_capacity"

2018-06-18 Thread David Hildenbrand
Not needed anymore, let's drop it. Reviewed-by: David Gibson Reviewed-by: Igor Mammedov Signed-off-by: David Hildenbrand --- hw/mem/pc-dimm.c | 5 - 1 file changed, 5 deletions(-) diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c index 12da89d562..62b34a992e 100644 --- a/hw/mem/pc-dimm.c +

[Qemu-devel] [PATCH v4 12/12] pc-dimm: get_memory_region() will not fail after realize

2018-06-18 Thread David Hildenbrand
Let's try to reduce error handling a bit. In the plug/unplug case, the device was realized and therefore we can assume that getting access to the memory region will not fail. For get_vmstate_memory_region() this is already handled that way. Document both cases. Reviewed-by: Igor Mammedov Reviewe

[Qemu-devel] [PATCH v4 09/12] nvdimm: convert "unarmed" into a static property

2018-06-18 Thread David Hildenbrand
We don't allow to modify it after realization. So we can simply turn it into a static property. Reviewed-by: David Gibson Signed-off-by: David Hildenbrand --- hw/mem/nvdimm.c | 32 +++- 1 file changed, 7 insertions(+), 25 deletions(-) diff --git a/hw/mem/nvdimm.c b/

[Qemu-devel] [PATCH v4 05/12] pc: factor out pc specific dimm checks into pc_memory_pre_plug()

2018-06-18 Thread David Hildenbrand
We can perform these checks before the device is actually realized. Reviewed-by: David Gibson Reviewed-by: Igor Mammedov Signed-off-by: David Hildenbrand --- hw/i386/pc.c | 44 ++-- 1 file changed, 26 insertions(+), 18 deletions(-) diff --git a/hw/i386/

[Qemu-devel] [PATCH v4 04/12] pc-dimm: remove pc_dimm_get_free_slot() from header

2018-06-18 Thread David Hildenbrand
Not used outside of pc-dimm.c and there shouldn't be other users. If other devices (e.g. memory devices) ever have to also use slots, then we will have to factor this out. Reviewed-by: Igor Mammedov Reviewed-by: David Gibson Signed-off-by: David Hildenbrand --- hw/mem/pc-dimm.c | 4 +++

[Qemu-devel] [PATCH v4 08/12] pc-dimm: merge get_(vmstate_)memory_region()

2018-06-18 Thread David Hildenbrand
Importantly, get_vmstate_memory_region() should also fail with a proper error if called before the device is realized. For a PCDIMM, both functions are to return the same thing, so share the implementation. All current users are called after the device has been realized, so we can expect the calls

Re: [Qemu-devel] Design Decision for KVM based anti rootkit

2018-06-18 Thread David Hildenbrand
On 16.06.2018 13:49, Ahmed Soliman wrote: > Following up on these threads: > - https://marc.info/?l=kvm&m=151929803301378&w=2 > - http://www.openwall.com/lists/kernel-hardening/2018/02/22/18 > > I lost the original emails so I couldn't reply to them, and also sorry > for being late, it was the end

[Qemu-devel] [PATCH v4 10/12] nvdimm: convert nvdimm_mr into a pointer

2018-06-18 Thread David Hildenbrand
This way we can easily check if the region has already been inititalized without having to rely on the size of an uninitialized region being 0. Reviewed-by: David Gibson Reviewed-by: Igor Mammedov Signed-off-by: David Hildenbrand --- hw/mem/nvdimm.c | 9 + include/hw/mem/nvdimm

  1   2   3   4   5   >