Kevin Wolf writes:
> Am 14.06.2018 um 21:14 hat Markus Armbruster geschrieben:
>> Remaining uses of qobject_input_visitor_new_keyval() in the block
>> subsystem:
>>
>> * block_crypto_create_opts_init()
>
> Still the wrong function name. Will fix this while applying. (Should be
> block_crypto_ope
On 15.06.2018 14:46, Igor Mammedov wrote:
> On Fri, 15 Jun 2018 13:24:56 +0200
> David Hildenbrand wrote:
>
>> Our parent class (PC_DIMM) provides exactly the same function.
>>
>> Reviewed-by: David Gibson
>> Reviewed-by: Igor Mammedov
>> Signed-off-by: David Hildenbrand
>> ---
>> hw/mem/nvdi
Peter Xu writes:
> It was unclear before on what does the CLOSED event mean. Meanwhile we
> add a TODO to fix up the CLOSED event in the future when the in/out
> ports are different for a chardev.
>
> CC: Paolo Bonzini
> CC: "Marc-André Lureau"
> CC: Stefan Hajnoczi
> CC: Markus Armbruster
>
Am 14.06.2018 um 11:55 hat Kevin Wolf geschrieben:
> We deprecated a bunch of -drive options in 2.10, so let's remove them
> for 3.0.
>
> v2:
> - Simplified hd-geo-test code after removing test cases [Markus]
> - Split patch 3 and 4 so that the deprecation warning code can be easily
> restored i
On Fri, 15 Jun 2018 13:24:58 +0200
David Hildenbrand wrote:
> We don't allow to modify it after realization. So we can simply turn
> it into a static property. The value is now validated during realize().
>
> Signed-off-by: David Hildenbrand
> ---
> hw/mem/nvdimm.c | 53 ---
On Wed 13 Jun 2018 07:44:19 PM CEST, Anton Nefedov
wrote:
> Make the stat fields definition slightly more readable.
> Also reorder total_time_ns stats read-write-flush as done elsewhere.
> Cosmetic change only.
>
> Signed-off-by: Anton Nefedov
> ---
> qapi/block-core.json | 34 +
On Wed 13 Jun 2018 07:44:21 PM CEST, Anton Nefedov
wrote:
> Signed-off-by: Anton Nefedov
Reviewed-by: Alberto Garcia
Berto
On 06/13/2018 05:05 PM, Daniel P. Berrangé wrote:
> On Wed, Jun 13, 2018 at 11:01:05AM -0400, Farhan Ali wrote:
>> Hi Daniel
>>
>> On 06/13/2018 05:37 AM, Daniel P. Berrangé wrote:
>>> On Tue, Jun 12, 2018 at 03:48:34PM -0400, Farhan Ali wrote:
The virtio-crypto driver currently propagates
On Fri, 15 Jun 2018 13:24:59 +0200
David Hildenbrand wrote:
> We might get a call to get_memory_region() before the device has been
> realized. We should return a consistent value, as the return value
> will e.g. later on be used in the pre_plug handler.
>
> To avoid duplicating too much code, f
On 15 June 2018 at 13:26, Peter Maydell wrote:
> On 9 June 2018 at 15:23, Eric Auger wrote:
>> When running dtc on the guest /proc/device-tree we get the
>> following warning: Warning (unit_address_vs_reg): Node /memory
>> has a reg or ranges property, but no unit name".
>>
>> Let's fix that by a
On Fri, 15 Jun 2018 13:53:01 +0200
Cédric Le Goater wrote:
> Today, when a device requests for IRQ number in a sPAPR machine, the
> spapr_irq_alloc() routine first scans the ICSState status array to
> find an empty slot and then performs the assignement of the selected
> numbers. Split this seque
On 14.06.2018 18:12, Farhan Ali wrote:
>
>
> On 06/14/2018 11:10 AM, Daniel P. Berrangé wrote:
>> On Thu, Jun 14, 2018 at 10:50:40AM -0400, Farhan Ali wrote:
>>>
>>>
>>> On 06/14/2018 04:21 AM, Daniel P. Berrangé wrote:
On Wed, Jun 13, 2018 at 07:28:08PM +0200, Halil Pasic wrote:
>
>
On Fri, 15 Jun 2018 13:25:00 +0200
David Hildenbrand wrote:
> Let's try to reduce error handling a bit. In the plug/unplug case, the
> device was realized and therefore we can assume that getting access to
> the memory region will not fail.
>
> For get_vmstate_memory_region() this is already han
On Thu, Jun 14, 2018 at 20:39:35 -0300, Philippe Mathieu-Daudé wrote:
> As there is no particular reason to use this base address
> (introduced in 7bea0dd434e), change to 378H which is the
> default on PC machines.
Tested-by: Emilio G. Cota
Thanks,
Emilio
On Fri, Jun 15, 2018, at 04:42 CDT, Daniel P. Berrangé
wrote:
> On Thu, Jun 14, 2018 at 11:40:41PM -0500, Matthias Maier wrote:
>> This commit removes the PYTHON_UTF8 workaround. The problem with setting
>>
>> LC_ALL= LANG=C LC_CTYPE=en_US.UTF-8
>>
>> is that the en_US.UTF-8 locale might n
Hi Peter,
On 06/15/2018 10:53 AM, Peter Maydell wrote:
> On 15 June 2018 at 08:10, Auger Eric wrote:
>> after reading 8/13, I have a doubt here about the ret.perm value that
>> stays IOMMU_RW independently on the translation success. Usually if the
>> translation failn perm is set to IOMMU_NONE.
Hi Peter,
On 06/15/2018 11:04 AM, Peter Maydell wrote:
> On 14 June 2018 at 21:36, Auger Eric wrote:
>> Hi Peter,
>>
>> On 06/04/2018 05:29 PM, Peter Maydell wrote:
>>> Implement the missing registers for the TZ MPC.
>>>
>>> Signed-off-by: Peter Maydell
>
>>> +case A_INT_CLEAR:
>>> +
On Fri, 15 Jun 2018 22:32:44 +1000
David Gibson wrote:
> On Fri, Jun 15, 2018 at 10:01:47AM +0200, Greg Kurz wrote:
> > On Fri, 15 Jun 2018 09:07:24 +0200
> > Greg Kurz wrote:
> >
> > > On Fri, 15 Jun 2018 16:29:15 +1000
> > > David Gibson wrote:
> > >
> > > > On Fri, Jun 15, 2018 at 07:5
On Fri, 15 Jun 2018 13:53:02 +0200
Cédric Le Goater wrote:
> spapr_irq_alloc_block and spapr_irq_alloc() are now deprecated.
>
> Signed-off-by: Cédric Le Goater
> ---
Reviewed-by: Greg Kurz
> include/hw/ppc/spapr.h | 4 ---
> hw/ppc/spapr.c | 80
> +
On 15.06.2018 14:53, Igor Mammedov wrote:
> On Fri, 15 Jun 2018 13:24:58 +0200
> David Hildenbrand wrote:
>
>> We don't allow to modify it after realization. So we can simply turn
>> it into a static property. The value is now validated during realize().
>>
>> Signed-off-by: David Hildenbrand
>>
On 12 June 2018 at 21:46, Julia Suvorova wrote:
> @@ -10085,10 +10091,25 @@ static void disas_thumb2_insn(DisasContext *s,
> uint32_t insn)
> int conds;
> int logic_cc;
>
> -/* The only 32 bit insn that's allowed for Thumb1 is the combined
> - * BL/BLX prefix and suffix.
> +
On 15 June 2018 at 12:09, Alex Bennée wrote:
> The following changes since commit 409c241f887a38bb7a2ac12e34d3a8d73922a9a5:
>
> Merge remote-tracking branch 'remotes/kraxel/tags/ui-20180614-pull-request'
> into staging (2018-06-14 14:04:14 +0100)
>
> are available in the Git repository at:
>
>
Anton Nefedov writes:
> On 14/6/2018 10:19 AM, Markus Armbruster wrote:
>> Anton Nefedov writes:
>>
>>> It often happens that just a few discriminator values imply extra data in
>>> a flat union. Existing checks did not make possible to leave other values
>>> uncovered. Such cases had to be work
On 06/15/2018 04:38 AM, David Gibson wrote:
> On Thu, Jun 14, 2018 at 04:00:38PM +0200, Cédric Le Goater wrote:
>> When a PowerNV system is started, the firmware (skiboot) looks for a
>> "primary" property to determine which LPC bus is the default on a
>> multichip system. This property is currentl
On 15.06.2018 15:30, David Hildenbrand wrote:
> On 15.06.2018 14:53, Igor Mammedov wrote:
>> On Fri, 15 Jun 2018 13:24:58 +0200
>> David Hildenbrand wrote:
>>
>>> We don't allow to modify it after realization. So we can simply turn
>>> it into a static property. The value is now validated during r
On Thu, Jun 14, 2018 at 08:25:47PM -1000, Richard Henderson wrote:
> Also, assert that we don't overflow any of two different offsets into
> the TB. Both unwind and goto_tb both record a uint16_t for later use.
>
> Signed-off-by: Richard Henderson
> ---
>
> This fixes an arm-softmmu test case fo
On Thu, Jun 14, 2018 at 05:40:41PM +0200, Paolo Bonzini wrote:
> On 14/06/2018 10:18, Daniel P. Berrangé wrote:
> > I don't think
> > the -realtime flag should ever have been introduced, and we certainly
> > shouldn't add more stuff under it.
> >
> > "-realtime" is referring to a very specific use
On 06/15/2018 03:25 AM, Richard Henderson wrote:
> Also, assert that we don't overflow any of two different offsets into
> the TB. Both unwind and goto_tb both record a uint16_t for later use.
>
> Signed-off-by: Richard Henderson
> ---
>
> This fixes an arm-softmmu test case forwarded to me by M
On Fri, 15 Jun 2018 22:29:28 +1000
David Gibson wrote:
> CPUPPCState currently contains a number of fields containing the state of
> the VPA. The VPA is a PAPR specific concept covering several guest/host
> shared memory areas used to communicate some information with the
> hypervisor.
>
> As a
On Fri, Jun 15, 2018 at 11:41:28 +0100, Peter Maydell wrote:
> Hi; I get compile failures with clang I'm afraid
> (seen on x86-64 Linux, OSX and FreeBSD):
>
> /home/petmay01/linaro/qemu-for-merges/accel/tcg/translate-all.c:1800:44:
> error: incompatible integer to pointer conversion passing 'uintp
Not needed anymore, let's drop it.
Reviewed-by: David Gibson
Reviewed-by: Igor Mammedov
Signed-off-by: David Hildenbrand
---
hw/mem/pc-dimm.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c
index 12da89d562..62b34a992e 100644
--- a/hw/mem/pc-dimm.c
+
Let's rename it to make it look more consistent.
Reviewed-by: Igor Mammedov
Signed-off-by: David Hildenbrand
---
hw/i386/pc.c | 4 ++--
hw/mem/pc-dimm.c | 6 +++---
hw/ppc/spapr.c | 6 +++---
include/hw/mem/pc-dimm.h | 6 +++---
4 files changed, 11 insertions(+), 1
This is another set of cleanups as the result from
[PATCH v4 00/14] MemoryDevice: use multi stage hotplug handlers
And is based on
[PATCH v1 0/2] memory: fix alignment checks/asserts
These cleanup are the last step before
- 1. moving pc-dimm address and slot assignment into pc_dimm_pre_plu
Not used outside of pc-dimm.c and there shouldn't be other users. If
other devices (e.g. memory devices) ever have to also use slots, then we
will have to factor this out.
Reviewed-by: Igor Mammedov
Signed-off-by: David Hildenbrand
---
hw/mem/pc-dimm.c | 4 +++-
include/hw/mem/pc-dimm.h
Use a similar naming scheme as spapr. This way, we can go ahead and
rename e.g. pc_dimm_memory_plug to pc_dimm_plug, which avoids
confusion.
Reviewed-by: Igor Mammedov
Signed-off-by: David Hildenbrand
---
hw/i386/pc.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
dif
Our parent class (PC_DIMM) provides exactly the same function.
Reviewed-by: David Gibson
Reviewed-by: Igor Mammedov
Signed-off-by: David Hildenbrand
---
hw/mem/nvdimm.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/hw/mem/nvdimm.c b/hw/mem/nvdimm.c
index 4087aca25e..f974accbdd 10064
We can perform these checks before the device is actually realized.
Reviewed-by: David Gibson
Reviewed-by: Igor Mammedov
Signed-off-by: David Hildenbrand
---
hw/i386/pc.c | 44 ++--
1 file changed, 26 insertions(+), 18 deletions(-)
diff --git a/hw/i386/
We don't allow to modify it after realization. So we can simply turn
it into a static property.
Signed-off-by: David Hildenbrand
---
hw/mem/nvdimm.c | 32 +++-
1 file changed, 7 insertions(+), 25 deletions(-)
diff --git a/hw/mem/nvdimm.c b/hw/mem/nvdimm.c
index df971
Unused, so let's remove it.
Reviewed-by: David Gibson
Reviewed-by: Igor Mammedov
Signed-off-by: David Hildenbrand
---
backends/hostmem.c | 3 +--
hw/mem/nvdimm.c | 4 ++--
hw/mem/pc-dimm.c | 4 ++--
hw/misc/ivshmem.c| 3 +--
include/sysemu/hostmem.h | 3 +--
numa
We might get a call to get_memory_region() before the device has been
realized. We should return a consistent value, as the return value
will e.g. later on be used in the pre_plug handler.
To avoid duplicating too much code, factor the initialization and checks
out into a helper function.
Signed-
It is inititally 0, so setting it to 0 should be allowed, too.
Signed-off-by: David Hildenbrand
---
hw/mem/nvdimm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/mem/nvdimm.c b/hw/mem/nvdimm.c
index db7d8c3050..df7646488b 100644
--- a/hw/mem/nvdimm.c
+++ b/hw/mem/nvd
Importantly, get_vmstate_memory_region() should also fail with a proper
error if called before the device is realized. For a PCDIMM, both functions
are to return the same thing, so share the implementation.
All current users are called after the device has been realized, so we
can expect the calls
Let's try to reduce error handling a bit. In the plug/unplug case, the
device was realized and therefore we can assume that getting access to
the memory region will not fail.
For get_vmstate_memory_region() this is already handled that way.
Document both cases.
Reviewed-by: Igor Mammedov
Signed-
This way we can easily check if the region has already been inititalized
without having to rely on the size of an uninitialized region being 0.
Signed-off-by: David Hildenbrand
---
hw/mem/nvdimm.c | 9 +
include/hw/mem/nvdimm.h | 2 +-
2 files changed, 6 insertions(+), 5 deletion
With the recent set of CPU hardware vulnerabilities on x86, it is
increasingly difficult to understand which CPU configurations are
good to use and what flaws they might be vulnerable to.
This doc attempts to help management applications and administrators in
picking sensible CPU configuration on
> -Original Message-
> From: Moger, Babu
> Sent: Thursday, June 14, 2018 6:09 PM
> To: Moger, Babu ; Eduardo Habkost
>
> Cc: m...@redhat.com; marcel.apfelb...@gmail.com; pbonz...@redhat.com;
> r...@twiddle.net; mtosa...@redhat.com; qemu-devel@nongnu.org;
> k...@vger.kernel.org; k...@tri
From: John Snow
These point to the job versions now, not the blockjob versions which
don't really exist anymore.
Except set-speed, which does. It sticks out like a sore thumb. This
patch doesn't fix that, but it doesn't make it any worse, either.
Signed-off-by: John Snow
Reviewed-by: Jeff Cody
From: Eric Blake
Commit a290f085 exposed a latent bug in qemu-img map introduced
during the conversion of block status to be byte-based. Earlier in
commit 5e344dd8, the internal interface get_block_status() switched
to take byte-based parameters, but still called a sector-based
block layer funct
From: Markus Armbruster
Parameter "filename" is deprecated since commit 5c3ad1a6a8f, v2.10.0.
Time to get rid of it.
Signed-off-by: Markus Armbruster
Reviewed-by: Kevin Wolf
Signed-off-by: Kevin Wolf
---
block/iscsi.c | 23 ++-
1 file changed, 2 insertions(+), 21 deletion
On Thu, Jun 14, 2018 at 10:32:00PM +0200, Paolo Bonzini wrote:
> On 14/06/2018 17:44, Daniel P. Berrangé wrote:
> >> "-cpu" is certainly wrong for KVM_CAP_X86_DISABLE_EXITS. "-cpu" is a
> >> device option, while this is about host behavior. "-realtime"'s name is
> >> awful, but I still think it's
From: Markus Armbruster
qdict_flatten_qdict() skips copying scalars from @qdict to @target
when the two are the same. Fair enough, but it uses a non-obvious
test for "same". Replace it by the obvious one. While there, improve
comments.
Signed-off-by: Markus Armbruster
Reviewed-by: Kevin Wolf
The following changes since commit 91fe7a376ad46e3cc5e82d418aad22173c948a3c:
Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into
staging (2018-06-15 11:41:44 +0100)
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-upstream
for you to f
From: Markus Armbruster
Signed-off-by: Markus Armbruster
Reviewed-by: Kevin Wolf
Signed-off-by: Kevin Wolf
---
include/block/qdict.h | 3 ++-
block/nbd.c | 7 ++-
block/nfs.c | 7 ++-
block/parallels.c | 7 ++-
block/qcow.c | 7 ++-
block/
From: Eric Blake
Although qemu-img creates aligned files (by rounding up), it
must also gracefully handle files that are not sector-aligned.
Test that the bug fixed in the previous patch does not recur.
It's a bit annoying that we can see the (implicit) hole past
the end of the file on to the ne
From: Markus Armbruster
Remaining uses of qobject_input_visitor_new_keyval() in the block
subsystem:
* block_crypto_open_opts_init()
Currently doesn't visit any non-string scalars, thus safe. It's
called from
- block_crypto_open_luks()
Creates the QDict with qemu_opts_to_qdict_filtere
From: John Snow
During the design for manual completion, we decided not to use the
"manual" property as a shorthand for both auto-dismiss and auto-finalize.
Fix the wording.
Signed-off-by: John Snow
Reviewed-by: Jeff Cody
Reviewed-by: Markus Armbruster
Signed-off-by: Kevin Wolf
---
qapi/jo
From: Markus Armbruster
Signed-off-by: Markus Armbruster
Reviewed-by: Kevin Wolf
Signed-off-by: Kevin Wolf
---
qobject/block-qdict.c | 27 +++
1 file changed, 11 insertions(+), 16 deletions(-)
diff --git a/qobject/block-qdict.c b/qobject/block-qdict.c
index 36cf58acc8
From: Max Reitz
There are numerous QDict functions that have been introduced for and are
used only by the block layer. Move their declarations into an own
header file to reflect that.
While qdict_extract_subqdict() is in fact used outside of the block
layer (in util/qemu-config.c), it is still
From: Markus Armbruster
Configuration flows through the block subsystem in a rather peculiar
way. Configuration made with -drive enters it as QemuOpts.
Configuration made with -blockdev / blockdev-add enters it as QAPI
type BlockdevOptions. The block subsystem uses QDict, QemuOpts and
QAPI type
From: Markus Armbruster
Parameter "filename" is deprecated since commit 91589d9e5ca, v2.10.0.
Time to get rid of it.
Signed-off-by: Markus Armbruster
Reviewed-by: Kevin Wolf
Signed-off-by: Kevin Wolf
---
block/rbd.c | 16
1 file changed, 16 deletions(-)
diff --git a/block/r
From: Markus Armbruster
The previous commit fixed -blockdev breakage due to misuse of the
qobject input visitor's keyval flavor in bdrv_file_open(). The commit
message explain why using the plain flavor would be just as wrong; it
would break -drive. Turns out we break it in three places:
nbd_op
From: Markus Armbruster
-blockdev and blockdev-add silently ignore empty objects and arrays in
their argument. That's because qmp_blockdev_add() converts the
argument to a flat QDict, and qdict_flatten() eats empty QDict and
QList members. For instance, we ignore an empty BlockdevOptions
member
From: Markus Armbruster
Signed-off-by: Markus Armbruster
Reviewed-by: Kevin Wolf
Signed-off-by: Kevin Wolf
---
tests/check-block-qdict.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/tests/check-block-qdict.c b/tests/check-block-qdict.c
index 29f58a2d3d..2
From: Markus Armbruster
There's no need to restart the loop. We don't elsewhere, e.g. in
qdict_extract_subqdict(), qdict_join() and qemu_opts_absorb_qdict().
Simplify accordingly.
Signed-off-by: Markus Armbruster
Reviewed-by: Kevin Wolf
Signed-off-by: Kevin Wolf
---
qobject/block-qdict.c |
From: Markus Armbruster
Legacy -drive supports "password-secret" parameter that isn't
available with -blockdev / blockdev-add. That's because we backed out
our first try to provide it there due to interface design doubts, in
commit 577d8c9a811, v2.9.0.
This is the second try. It brings back th
l/qemu-arm.git
tags/pull-target-arm-20180615
for you to fetch changes up to 14120108f87b3f9e1beacdf0a6096e464e62bb65:
target/arm: Allow ARMv6-M Thumb2 instructions (2018-06-15 15:23:34 +0100)
target-arm and miscellaneous queue:
From: Markus Armbruster
When you mix scalar and non-scalar keys, whether you get an "already
set as scalar" or an "already set as dict" error depends on qdict
iteration order. Neither message makes much sense. Replace by
""Cannot mix scalar and non-scalar keys". This is similar to the
message
Convert the pckbd device away from using the old_mmio field
of MemoryRegionOps. This change only affects the memory-mapped
variant of the i8042, which is used by the Unicore32 'puv3'
board and the MIPS Jazz boards 'magnum' and 'pica61'.
Signed-off-by: Peter Maydell
Reviewed-by: Philippe Mathieu-D
The -drive options cyls, heads, secs and trans were deprecated in
QEMU 2.10. It's time to remove them.
hd-geo-test tested both the old version with geometry options in -drive
and the new one with -device. Therefore the code using -drive doesn't
have to be replaced there, we just need to remove the
From: Markus Armbruster
The following pattern occurs in the .bdrv_co_create_opts() methods of
parallels, qcow, qcow2, qed, vhdx and vpc:
qobj = qdict_crumple_for_keyval_qiv(qdict, errp);
qobject_unref(qdict);
qdict = qobject_to(QDict, qobj);
if (qdict == NULL) {
ret = -E
From: Markus Armbruster
Parameter auth-client-required lets you configure authentication
methods. We tried to provide that in v2.9.0, but backed out due to
interface design doubts (commit 46fcc16).
This commit is similar to what we backed out, but simpler: we use a
list of enumeration value
Convert the mcf5206 device away from using the old_mmio field
of MemoryRegionOps. This device is used by the an5206 board.
Signed-off-by: Peter Maydell
Acked-by: Thomas Huth
Message-id: 20180601141223.26630-3-peter.mayd...@linaro.org
---
hw/m68k/mcf5206.c | 48 ++
We removed all options from the 'deprecated' array, so the code is dead
and can be removed as well.
Signed-off-by: Kevin Wolf
Reviewed-by: Markus Armbruster
---
blockdev.c | 12
1 file changed, 12 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index d1ab425085..7f65cd7497 10064
From: Markus Armbruster
Signed-off-by: Markus Armbruster
Reviewed-by: Kevin Wolf
Signed-off-by: Kevin Wolf
---
tests/check-block-qdict.c | 57 ---
1 file changed, 29 insertions(+), 28 deletions(-)
diff --git a/tests/check-block-qdict.c b/tests/chec
The -drive option serial was deprecated in QEMU 2.10. It's time to
remove it.
Tests need to be updated to set the serial number with -global instead
of using the -drive option.
Signed-off-by: Kevin Wolf
Reviewed-by: Markus Armbruster
Reviewed-by: Jeff Cody
---
include/hw/block/block.h | 1 -
From: Shannon Zhao
While for_each_dist_irq_reg loop starts from GIC_INTERNAL, it forgot to
offset the date array and index. This will overlap the GICR registers
value and leave the last GIC_INTERNAL irq's registers out of update.
Fixes: 367b9f527becdd20ddf116e17a3c0c2bbc486920
Cc: qemu-sta...@no
The -drive option addr was deprecated in QEMU 2.10. It's time to remove
it.
Signed-off-by: Kevin Wolf
Reviewed-by: Markus Armbruster
Reviewed-by: Jeff Cody
---
include/sysemu/blockdev.h | 1 -
blockdev.c| 17 +
device-hotplug.c | 4
qemu-doc.texi
Convert the parallel device away from using the old_mmio field
of MemoryRegionOps. This change only affects the memory-mapped
variant, which is used by the MIPS Jazz boards 'magnum' and 'pica61'.
Signed-off-by: Peter Maydell
Reviewed-by: Philippe Mathieu-Daudé
Message-id: 20180601141223.26630-7-
The Cortex-M CPU and its NVIC are two intimately intertwined parts of
the same hardware; it is not possible to use one without the other.
Unfortunately a lot of our board models don't do any sanity checking
on the CPU type the user asks for, so a command line like
qemu-system-arm -M versatilepb
From: Richard Henderson
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
Message-id: 20180613015641.5667-3-richard.hender...@linaro.org
Signed-off-by: Peter Maydell
---
target/arm/helper-sve.h| 23 +++
target/arm/sve_helper.c| 114 +++
targe
From: Markus Armbruster
Pure code motion, except for two brace placements and a comment
tweaked to appease checkpatch.
Signed-off-by: Markus Armbruster
Reviewed-by: Kevin Wolf
Signed-off-by: Kevin Wolf
---
qobject/block-qdict.c | 640
qobject/
In subpage_read() we perform a load of the data into a local buffer
which we then access using ldub_p(), lduw_p(), ldl_p() or ldq_p()
depending on its size, storing the result into the uint64_t *data.
Since ldl_p() returns an 'int', this means that for the 4-byte
case we will sign-extend the data,
The 'addr' field in the CPUIOTLBEntry struct has a rather non-obvious
use; add a comment documenting it (reverse-engineered from what
the code that sets it is doing).
Signed-off-by: Peter Maydell
Reviewed-by: Paolo Bonzini
Reviewed-by: Richard Henderson
Message-id: 20180611125633.32755-2-peter.
From: Richard Henderson
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
Message-id: 20180613015641.5667-9-richard.hender...@linaro.org
Signed-off-by: Peter Maydell
---
target/arm/helper-sve.h| 14 +
target/arm/sve_helper.c| 41 +++---
Remove the now-unused armv7m_init() function. This was a legacy from
before we properly QOMified ARMv7M, and it has some flaws:
* it combines work that needs to be done by an SoC object (creating
and initializing the TYPE_ARMV7M object) with work that needs to
be done by the board model (se
There's a common pattern in QEMU where a function needs to perform
a data load or store of an N byte integer in a particular endianness.
At the moment this is handled by doing a switch() on the size and
calling the appropriate ld*_p or st*_p function for each size.
Provide a new family of function
The codebase has a bit of a mix of different multiline
comment styles. State a preference for the Linux kernel
style:
/*
* Star on the left for each line.
* Leading slash-star and trailing star-slash
* each go on a line of their own.
*/
Signed-off-by: Peter Maydell
Reviewe
From: Richard Henderson
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
Message-id: 20180613015641.5667-11-richard.hender...@linaro.org
Signed-off-by: Peter Maydell
---
target/arm/helper-sve.h| 9 +++
target/arm/sve_helper.c| 55 ++
The stellaris board is still using the legacy armv7m_init() function,
which predates conversion of the ARMv7M into a proper QOM container
object. Make the board code directly create the ARMv7M object instead.
Signed-off-by: Peter Maydell
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Stefan Ha
For the IoTKit MPC support, we need to wire together the
interrupt outputs of 17 MPCs; this exceeds the current
value of MAX_OR_LINES. Increase MAX_OR_LINES to 32 (which
should be enough for anyone).
The tricky part is retaining the migration compatibility for
existing OR gates; we add a subsectio
The API for cpu_transaction_failed() says that it takes the physical
address for the failed transaction. However we were actually passing
it the offset within the target MemoryRegion. We don't currently
have any target CPU implementations of this hook that require the
physical address; fix this bug
If an IOMMU supports mappings that care about the memory
transaction attributes, then it no longer has a unique
address -> output mapping, but more than one. We can
represent these using an IOMMU index, analogous to TCG's
mmu indexes.
Signed-off-by: Peter Maydell
Reviewed-by: Richard Henderson
R
The ethernet controller in the AN505 MPC FPGA image is behind
the same AHB Peripheral Protection Controller that handles
the graphics and GPIOs. (In the documentation this is clear
in the block diagram but the ethernet controller was omitted
from the table listing devices connected to the PPC.)
The
Convert the pflash_cfi02 device away from using the old_mmio field
of MemoryRegionOps.
Signed-off-by: Peter Maydell
Reviewed-by: Philippe Mathieu-Daudé
Acked-by: Max Reitz
Message-id: 20180601141223.26630-4-peter.mayd...@linaro.org
---
hw/block/pflash_cfi02.c | 97 -
From: Richard Henderson
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
Message-id: 20180613015641.5667-7-richard.hender...@linaro.org
Signed-off-by: Peter Maydell
---
target/arm/helper-sve.h| 2 +
target/arm/sve_helper.c| 12 ++
target/arm/translate-sve.c | 328 +++
From: Richard Henderson
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
Message-id: 20180613015641.5667-15-richard.hender...@linaro.org
Signed-off-by: Peter Maydell
---
target/arm/helper-sve.h| 2 +
target/arm/sve_helper.c| 14
target/arm/translate-sve.c | 133
Now we have stn_p() and ldn_p() we can use them in various
functions in exec.c that used to have their own switch-on-size code.
Signed-off-by: Peter Maydell
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-id: 20180611171007.4165-4-peter.mayd...@linaro.org
---
exec.c
From: Richard Henderson
Rearrange the arithmetic so that we are agnostic about the total size
of the vector and the size of the element. This will allow us to index
up to the 32nd byte and with 16-byte elements.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
Message-id: 201806130
From: Richard Henderson
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
Message-id: 20180613015641.5667-13-richard.hender...@linaro.org
Signed-off-by: Peter Maydell
---
target/arm/helper-sve.h| 44 +++
target/arm/sve_helper.c| 88 +++
Convert the sh7750 device away from using the old_mmio field
of MemoryRegionOps. This device is used by the sh4 r2d board.
Signed-off-by: Peter Maydell
Reviewed-by: Philippe Mathieu-Daudé
Message-id: 20180601141223.26630-2-peter.mayd...@linaro.org
---
hw/sh4/sh7750.c | 44 ++
1 - 100 of 446 matches
Mail list logo
