Re: [Qemu-devel] [PATCH v2 3/3] util: remove redundant include of glib.h

2018-06-07 Thread Markus Armbruster
Peter Xu writes: > On Wed, Jun 06, 2018 at 07:31:53PM +0100, Peter Maydell wrote: >> On 6 June 2018 at 18:32, Daniel P. Berrangé wrote: >> > Code must only ever include glib.h indirectly via the glib-compat.h >> > header file, because we will need some macros set before glib.h is >> > pulled in.

Re: [Qemu-devel] [PATCH 0/2] jobs: minor doc fixups

2018-06-07 Thread Markus Armbruster
John Snow writes: > One is from my manual completion series, > the other is from the recent refactor. Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v2 3/3] util: remove redundant include of glib.h

2018-06-07 Thread Peter Xu
On Thu, Jun 07, 2018 at 09:05:28AM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > On Wed, Jun 06, 2018 at 07:31:53PM +0100, Peter Maydell wrote: > >> On 6 June 2018 at 18:32, Daniel P. Berrangé wrote: > >> > Code must only ever include glib.h indirectly via the glib-compat.h > >> > hea

Re: [Qemu-devel] [PATCH v2] usb: update docs

2018-06-07 Thread Markus Armbruster
Gerd Hoffmann writes: > xhci is rock solid meanwhile. So move it up in the docs and feature it > as prefered usb host adapter, instead of the old shy version saying "you > might want try ...". > > While being at it rework the text on ehci and companion controllers too. > > Signed-off-by: Gerd Ho

Re: [Qemu-devel] [PATCH 03/17] iotests: ask qemu for supported formats

2018-06-07 Thread Thomas Huth
On 07.06.2018 08:57, Markus Armbruster wrote: > Thomas Huth writes: > >> On 05.06.2018 00:40, Eric Blake wrote: >>> On 06/04/2018 05:34 AM, Thomas Huth wrote: On 04.06.2018 09:18, Markus Armbruster wrote: > Roman Kagan writes: > >> Add helper functions to query the block drivers

Re: [Qemu-devel] [PULL 0/6] Some docker updates

2018-06-07 Thread Peter Maydell
On 5 June 2018 at 17:05, Alex Bennée wrote: > The following changes since commit 1d889f2a8baaa265939b339d2f52ec57f5b8a09c: > > Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into > staging (2018-06-05 15:22:07 +0100) > > are available in the Git repository at: > > https:/

Re: [Qemu-devel] [PATCH 6/6] linux-user: Use *at functions to implement interp_prefix

2018-06-07 Thread Laurent Vivier
Le 05/06/2018 à 07:27, Richard Henderson a écrit : > On 06/03/2018 06:04 PM, Laurent Vivier wrote: >> On 01/06/2018 00:49, Richard Henderson wrote: >>> If the interp_prefix is a complete chroot, it may have a *lot* of files. >>> Setting up the cache for this is quite expensive. >>> >>> For the most

Re: [Qemu-devel] [RFC v2 1/4] docs: mention shared state protect for OOB

2018-06-07 Thread Peter Xu
On Thu, May 31, 2018 at 09:06:05AM -0500, Eric Blake wrote: > On 05/31/2018 12:16 AM, Peter Xu wrote: > > Out-Of-Band handlers need to protect shared state if there is any. > > Mention it in the document. > > > > Suggested-by: Markus Armbruster > > Signed-off-by: Peter Xu > > --- > > docs/deve

Re: [Qemu-devel] [RFC v2 3/4] monitor: remove "x-oob", turn oob on by default

2018-06-07 Thread Peter Xu
On Thu, May 31, 2018 at 09:44:46AM -0500, Eric Blake wrote: > On 05/31/2018 12:16 AM, Peter Xu wrote: > > There was a regression reported by Eric Auger before with OOB: > > > >http://lists.gnu.org/archive/html/qemu-devel/2018-03/msg06231.html > > > > The fix is 951702f39c ("monitor: bind disp

Re: [Qemu-devel] [RFC v2 4/4] Revert "tests: Add parameter to qtest_init_without_qmp_handshake"

2018-06-07 Thread Peter Xu
On Thu, May 31, 2018 at 09:51:00AM -0500, Eric Blake wrote: > On 05/31/2018 12:16 AM, Peter Xu wrote: > > This reverts commit ddee57e0176f6ab53b13c6c97605b62737a8fd7a. > > > > Meanwhile, revert one line from fa198ad9bdef to make sure > > qtest_init_without_qmp_handshake() will only pass in one par

Re: [Qemu-devel] [PATCH v2 1/3] glib: bump min required glib library version to 2.40

2018-06-07 Thread Daniel P . Berrangé
On Wed, Jun 06, 2018 at 02:12:33PM -0400, John Snow wrote: > > > On 06/06/2018 01:32 PM, Daniel P. Berrangé wrote: > > Per supported platforms doc, the various min glib on relevant distros is: > > Which doc? The main QEMU doc https://qemu.weilnetz.de/doc/qemu-doc.html#Supported-build-platform

Re: [Qemu-devel] [PATCH v2 3/3] util: remove redundant include of glib.h

2018-06-07 Thread Daniel P . Berrangé
On Thu, Jun 07, 2018 at 03:44:56PM +0800, Peter Xu wrote: > On Thu, Jun 07, 2018 at 09:05:28AM +0200, Markus Armbruster wrote: > > Peter Xu writes: > > > > > On Wed, Jun 06, 2018 at 07:31:53PM +0100, Peter Maydell wrote: > > >> On 6 June 2018 at 18:32, Daniel P. Berrangé wrote: > > >> > Code mus

Re: [Qemu-devel] [PATCH] ps2: check PS2Queue wptr pointer in post_load routine

2018-06-07 Thread Gonglei (Arei)
> -Original Message- > From: liujunjie (A) > Sent: Thursday, June 07, 2018 4:03 PM > To: kra...@redhat.com; berra...@redhat.com > Cc: Gonglei (Arei) ; wangxin (U) > ; Huangweidong (C) > ; fangying ; > qemu-devel@nongnu.org; liujunjie (A) > Subject: [PATCH] ps2: check PS2Queue wptr point

Re: [Qemu-devel] [PATCH v2 1/3] glib: bump min required glib library version to 2.40

2018-06-07 Thread Olaf Hering
Am Thu, 7 Jun 2018 09:25:24 +0100 schrieb Daniel P. Berrangé : > https://qemu.weilnetz.de/doc/qemu-doc.html#Supported-build-platforms SLE12-SP2: 2.48.2 Olaf pgpzqS0yDN306.pgp Description: Digitale Signatur von OpenPGP

Re: [Qemu-devel] [PATCH v2 3/3] util: remove redundant include of glib.h

2018-06-07 Thread Peter Xu
On Thu, Jun 07, 2018 at 09:26:51AM +0100, Daniel P. Berrangé wrote: > On Thu, Jun 07, 2018 at 03:44:56PM +0800, Peter Xu wrote: > > On Thu, Jun 07, 2018 at 09:05:28AM +0200, Markus Armbruster wrote: > > > Peter Xu writes: > > > > > > > On Wed, Jun 06, 2018 at 07:31:53PM +0100, Peter Maydell wrote

Re: [Qemu-devel] [RFC PATCH qemu] qdev: Use "string" for QOM string properties

2018-06-07 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, Jun 05, 2018 at 07:15:08PM +1000, Alexey Kardashevskiy wrote: >> For QOM properties QEMU uses "string", for example: >> >> {"execute": "qom-list", "arguments": {"path": "/machine"}} >> [{'return': [{'type': 'string', 'name': 'append'}, {'type': 'string', >>

Re: [Qemu-devel] [PATCH v2 3/3] util: remove redundant include of glib.h

2018-06-07 Thread Thomas Huth
On 06.06.2018 19:32, Daniel P. Berrangé wrote: > Code must only ever include glib.h indirectly via the glib-compat.h > header file, because we will need some macros set before glib.h is > pulled in. Adding extra includes of glib.h will (soon) cause compile > failures such as: > > In file included

Re: [Qemu-devel] [PATCH 0/5] trace-mem fixes

2018-06-07 Thread Stefan Hajnoczi
On Tue, May 22, 2018 at 06:26:47PM -0400, Emilio G. Cota wrote: > This series fixes a few issues that I found while testing > the tracing of guest memory accesses in TCG. Please review! > > You can fetch these patches from: > https://github.com/cota/qemu/commits/trace-mem Doesn't look like anyo

Re: [Qemu-devel] [PATCH v2 3/3] util: remove redundant include of glib.h

2018-06-07 Thread Daniel P . Berrangé
On Thu, Jun 07, 2018 at 10:44:15AM +0200, Thomas Huth wrote: > On 06.06.2018 19:32, Daniel P. Berrangé wrote: > > Code must only ever include glib.h indirectly via the glib-compat.h > > header file, because we will need some macros set before glib.h is > > pulled in. Adding extra includes of glib.h

[Qemu-devel] [PATCH] ps2: check PS2Queue wptr pointer in post_load routine

2018-06-07 Thread liujunjie
In commit 802cbcb7300, most issues have been fixed when qemu guest migration. But the queue size still need to check whether is equal to PS2_QUEUE_SIZE. If yes, the wptr should set as 0. Or, wptr would larger than PS2_QUEUE_SIZE and never come back when ps2_queue_noirq is called. This could lead to

Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig

2018-06-07 Thread Peter Xu
On Tue, Jun 05, 2018 at 01:26:34PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Allow a bunch of the info commands to be used in preconfig. > Could probably add most of them. I guess some of them may not work yet during preconfig. E.g.: $ ./x86_64-softmmu/qem

Re: [Qemu-devel] [PATCH 1/6] hmp: Add flag for preconfig commands

2018-06-07 Thread Peter Xu
On Tue, Jun 05, 2018 at 01:26:31PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Add a flag to command definitions to allow them to be used in preconfig > and check it. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu -- Peter Xu

Re: [Qemu-devel] [PATCH 2/6] hmp: Allow help on preconfig commands

2018-06-07 Thread Peter Xu
On Tue, Jun 05, 2018 at 01:26:32PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Allow the 'help' command in preconfig state but > make it only list the preconfig commands. > > Signed-off-by: Dr. David Alan Gilbert > --- > hmp-commands.hx | 1 + > monitor.c

Re: [Qemu-devel] [PATCH 3/6] hmp: Restrict auto-complete in preconfig

2018-06-07 Thread Peter Xu
On Tue, Jun 05, 2018 at 01:26:33PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Don't show the commands that aren't available. > > Signed-off-by: Dr. David Alan Gilbert > --- > monitor.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > di

Re: [Qemu-devel] [PATCH 0/6] Reenable hmp for preconfig mode

2018-06-07 Thread Peter Xu
On Tue, Jun 05, 2018 at 01:26:30PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Reenable HMP in preconfig mode; it's pretty > easy and anyway I want to do a similar thing for OOB eventually. > We'll want to enable more commands in preconfig mode to make it > use

Re: [Qemu-devel] [PATCH 5/6] hmp: add exit_preconfig

2018-06-07 Thread Peter Xu
On Tue, Jun 05, 2018 at 01:26:35PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Add the exit_preconfig command to return to normality. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu -- Peter Xu

Re: [Qemu-devel] [PATCH v3b 17/18] target/arm: Implement SVE Integer Wide Immediate - Unpredicated Group

2018-06-07 Thread Peter Maydell
On 30 May 2018 at 19:01, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 25 +++ > target/arm/sve_helper.c| 41 +++ > target/arm/translate-sve.c | 144 + > target/arm/sve.decode | 26

Re: [Qemu-devel] [PULL 0/6] VFIO updates 2018-06-05

2018-06-07 Thread Peter Maydell
On 5 June 2018 at 21:06, Alex Williamson wrote: > The following changes since commit 41feb5b955f0d7c9d071b2c5adbc404ae2895c7a: > > Merge remote-tracking branch > 'remotes/vivier2/tags/linux-user-for-3.0-pull-request' into staging > (2018-06-05 10:38:33 +0100) > > are available in the Git repos

Re: [Qemu-devel] [PATCH v2 2/3] glib: enforce the minimum required version and warn about old APIs

2018-06-07 Thread Thomas Huth
On 06.06.2018 19:32, Daniel P. Berrangé wrote: > There are two useful macros that can be defined before including > glib.h that are related to the min required glib version > > - GLIB_VERSION_MIN_REQUIRED > >When this is defined, if code uses an API that was deprecated >in this version,

Re: [Qemu-devel] [PATCH 6/6] hmp: Allow HMP in preconfig state again

2018-06-07 Thread Peter Xu
On Tue, Jun 05, 2018 at 01:26:36PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Now we can cope with preconfig in HMP, reenable by reverting > commit 71dc578e116599ea73c8a2a4e693134702ec0e83. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu -

Re: [Qemu-devel] [PATCH 0/6] Reenable hmp for preconfig mode

2018-06-07 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Tue, Jun 05, 2018 at 01:26:30PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Reenable HMP in preconfig mode; it's pretty > > easy and anyway I want to do a similar thing for OOB eventually. > > We'll want to enabl

Re: [Qemu-devel] [PATCH 0/6] Reenable hmp for preconfig mode

2018-06-07 Thread Peter Xu
On Thu, Jun 07, 2018 at 10:00:30AM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Tue, Jun 05, 2018 at 01:26:30PM +0100, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > Reenable HMP in preconfig mode; it's pretty > > >

[Qemu-devel] [Bug 1775555] [NEW] guest migration 100% cpu freeze bug

2018-06-07 Thread Dion Bosschieter
Public bug reported: # Investigate migration cpu hog(100%) bug I have some issues when migrating from qemu 2.6.2 to qemu 2.11.1. The hypervisors are running kernel 4.9.92 on debian stretch with libvirt v4.0.0. Linux, libvirt and qemu are all custom compiled. I migrated around 21.000 vms from qem

Re: [Qemu-devel] [PATCH v2 2/3] glib: enforce the minimum required version and warn about old APIs

2018-06-07 Thread Daniel P . Berrangé
On Thu, Jun 07, 2018 at 10:57:56AM +0200, Thomas Huth wrote: > On 06.06.2018 19:32, Daniel P. Berrangé wrote: > > There are two useful macros that can be defined before including > > glib.h that are related to the min required glib version > > > > - GLIB_VERSION_MIN_REQUIRED > > > >When this

Re: [Qemu-devel] [PULL 0/6] VFIO updates 2018-06-05

2018-06-07 Thread Fam Zheng
On Wed, 06/06 03:29, no-re...@patchew.org wrote: > Hi, > > This series failed docker-mingw@fedora build test. Please find the testing > commands and > their output below. If you have Docker installed, you can probably reproduce > it > locally. > > Type: series > Message-id: 20180605200425.24323

Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig

2018-06-07 Thread Igor Mammedov
On Tue, 5 Jun 2018 13:26:34 +0100 "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Allow a bunch of the info commands to be used in preconfig. > Could probably add most of them. > > Signed-off-by: Dr. David Alan Gilbert > --- > hmp-commands-info.hx | 9 + >

[Qemu-devel] [Bug 1775555] Re: guest migration 100% cpu freeze bug

2018-06-07 Thread Daniel Berrange
I don't have any suggestions wrt the actual bug cause, but just want to suggest adding the XML config and corresponding CLI args used on both the source and dest hosts (see /var/log/libvirt/qemu/$GUEST.log) to this bug, for one of the VMs that sees the 100% CPU hang. -- You received this bug noti

Re: [Qemu-devel] [PATCH 0/6] Reenable hmp for preconfig mode

2018-06-07 Thread Igor Mammedov
On Thu, 7 Jun 2018 16:54:44 +0800 Peter Xu wrote: > On Tue, Jun 05, 2018 at 01:26:30PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Reenable HMP in preconfig mode; it's pretty > > easy and anyway I want to do a similar thing for OOB eventually. > > We'll

Re: [Qemu-devel] [PATCH 0/3] i386: fix handling of multiboot modules

2018-06-07 Thread Daniel P . Berrangé
ping... On Mon, May 14, 2018 at 06:19:10PM +0100, Daniel P. Berrangé wrote: > This short series fixes a flaw identified by coverity which broke the > handling of multiboot modules. > > Daniel P. Berrangé (3): > i386: fix regression parsing multiboot initrd modules > i386: only parse the initr

Re: [Qemu-devel] [PATCH 0/6] Reenable hmp for preconfig mode

2018-06-07 Thread Igor Mammedov
On Tue, 5 Jun 2018 13:26:30 +0100 "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Reenable HMP in preconfig mode; it's pretty > easy and anyway I want to do a similar thing for OOB eventually. > We'll want to enable more commands in preconfig mode to make it > useful

Re: [Qemu-devel] [PATCH RFC 2/2] vfio-ccw: support for halt/clear subchannel

2018-06-07 Thread Cornelia Huck
On Wed, 6 Jun 2018 16:15:31 +0200 Pierre Morel wrote: > On 06/06/2018 14:21, Cornelia Huck wrote: > > On Tue, 5 Jun 2018 17:23:02 +0200 > > Pierre Morel wrote: > > > >> On 05/06/2018 15:14, Cornelia Huck wrote: > >>> On Tue, 22 May 2018 17:10:44 +0200 > >>> Pierre Morel wrote: > >>> >

Re: [Qemu-devel] [PATCH 0/6] Reenable hmp for preconfig mode

2018-06-07 Thread Peter Xu
On Thu, Jun 07, 2018 at 11:45:17AM +0200, Igor Mammedov wrote: > On Thu, 7 Jun 2018 16:54:44 +0800 > Peter Xu wrote: > > > On Tue, Jun 05, 2018 at 01:26:30PM +0100, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > Reenable HMP in preconfig mode; it's pre

Re: [Qemu-devel] storing machine data in qcow images?

2018-06-07 Thread Andrea Bolognani
On Wed, 2018-06-06 at 17:32 +0100, Daniel P. Berrangé wrote: > On Wed, Jun 06, 2018 at 10:36:20AM -0500, Eric Blake wrote: > > But for the new config to be useful, you have to modify at least one tool in > > the path. At which point, it is just as easy to say: "libvirt is now smart > > enough to r

Re: [Qemu-devel] [Qemu-block] [RFC PATCH V4] qemu-img: make convert async

2018-06-07 Thread Stefan Hajnoczi
On Fri, Jun 01, 2018 at 07:16:14PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 20.02.2017 17:59, Peter Lieven wrote: > > Am 20.02.2017 um 15:50 schrieb Stefan Hajnoczi: > > > On Fri, Feb 17, 2017 at 05:00:24PM +0100, Peter Lieven wrote: > > > > this is something I have been thinking about for almo

[Qemu-devel] [PATCH] doc: switch to modern syntx for VNC TLS setup

2018-06-07 Thread Daniel P . Berrangé
The use of 'tls', 'x509' and 'x509verify' properties is the legacy backcompat syntx, replaced by use of TLS creds objects. Signed-off-by: Daniel P. Berrangé --- qemu-doc.texi | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/qemu-doc.texi b/qemu-doc.texi i

Re: [Qemu-devel] [Qemu-block] [RFC PATCH V4] qemu-img: make convert async

2018-06-07 Thread Vladimir Sementsov-Ogievskiy
07.06.2018 13:10, Stefan Hajnoczi wrote: On Fri, Jun 01, 2018 at 07:16:14PM +0300, Vladimir Sementsov-Ogievskiy wrote: 20.02.2017 17:59, Peter Lieven wrote: Am 20.02.2017 um 15:50 schrieb Stefan Hajnoczi: On Fri, Feb 17, 2017 at 05:00:24PM +0100, Peter Lieven wrote: this is something I have b

[Qemu-devel] [Bug 1775366] Re: [Feature request] qemu-ga - Allow unexpected parameter

2018-06-07 Thread Thomas Huth
I agree with John, accepting commands that have not fully been understood is just too dangerous. So closing this as Won't-Fix. ** Changed in: qemu Status: New => Won't Fix -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https:

[Qemu-devel] [Bug 1636217] Re: qemu-kvm 2.7 does not boot kvm VMs with virtio on top of VMware ESX

2018-06-07 Thread Mykola Ivanets
Well, it appeared that it is not enough to set "disable-modern=on" for virtio-blk-pci devices. You have to do the same for virtio-scsi-pci, and may be for other virtio devices you are using to disable virtio 1.0. But VM will hangs latter on during boot process if you use virtio-rng-pci. "-machine

[Qemu-devel] [PATCH v2 4/6] hmp: Add info commands for preconfig

2018-06-07 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Allow a bunch of the info commands to be used in preconfig. Could probably add most of them. Signed-off-by: Dr. David Alan Gilbert --- hmp-commands-info.hx | 12 hmp-commands.hx | 1 + 2 files changed, 13 insertions(+) diff --git a/hmp-command

Re: [Qemu-devel] storing machine data in qcow images?

2018-06-07 Thread Daniel P . Berrangé
On Thu, Jun 07, 2018 at 12:02:29PM +0200, Andrea Bolognani wrote: > On Wed, 2018-06-06 at 17:32 +0100, Daniel P. Berrangé wrote: > > On Wed, Jun 06, 2018 at 10:36:20AM -0500, Eric Blake wrote: > > > But for the new config to be useful, you have to modify at least one tool > > > in > > > the path.

Re: [Qemu-devel] [PULL v1 0/4] Merge tpm 2018/06/06

2018-06-07 Thread Peter Maydell
On 6 June 2018 at 20:58, Stefan Berger wrote: > This series of patches refactors existing TPM test code and adds another > TPM TIS test case testing TPM migration. > > Stefan > > The following changes since commit c1c2a435905ae76b159c573b0c0d6f095b45ebc6: > > Merge remote-tracking branch >

Re: [Qemu-devel] [RFC v3] qapi: command category to stimulate high-level machine devices

2018-06-07 Thread Stefan Hajnoczi
On Mon, Jun 04, 2018 at 12:12:21PM +0200, Gerd Hoffmann wrote: > On Mon, Jun 04, 2018 at 10:29:40AM +0100, Peter Maydell wrote: > > On 4 June 2018 at 10:20, Stefan Hajnoczi wrote: > > > Many of these inputs/outputs can be tied to an external UI. A degree of > > > timing precision is required so t

Re: [Qemu-devel] storing machine data in qcow images?

2018-06-07 Thread Richard W.M. Jones
On Thu, Jun 07, 2018 at 12:02:29PM +0200, Andrea Bolognani wrote: > Something that I haven't seen mentioned in the thread - and this > looks like as good a point as any to jump in - is that for q35 > guests using EFI as well as aarch64 guests the "one click import" > experience requires not only hi

Re: [Qemu-devel] [RFC v3] qapi: command category to stimulate high-level machine devices

2018-06-07 Thread Daniel P . Berrangé
On Thu, Jun 07, 2018 at 11:24:55AM +0100, Stefan Hajnoczi wrote: > On Mon, Jun 04, 2018 at 12:12:21PM +0200, Gerd Hoffmann wrote: > > On Mon, Jun 04, 2018 at 10:29:40AM +0100, Peter Maydell wrote: > > > On 4 June 2018 at 10:20, Stefan Hajnoczi wrote: > > > > Many of these inputs/outputs can be tie

Re: [Qemu-devel] storing machine data in qcow images?

2018-06-07 Thread Dr. David Alan Gilbert
* Richard W.M. Jones (rjo...@redhat.com) wrote: > On Thu, Jun 07, 2018 at 12:02:29PM +0200, Andrea Bolognani wrote: > > Something that I haven't seen mentioned in the thread - and this > > looks like as good a point as any to jump in - is that for q35 > > guests using EFI as well as aarch64 guests

Re: [Qemu-devel] storing machine data in qcow images?

2018-06-07 Thread Daniel P . Berrangé
On Thu, Jun 07, 2018 at 11:32:18AM +0100, Richard W.M. Jones wrote: > On Thu, Jun 07, 2018 at 12:02:29PM +0200, Andrea Bolognani wrote: > > Something that I haven't seen mentioned in the thread - and this > > looks like as good a point as any to jump in - is that for q35 > > guests using EFI as wel

Re: [Qemu-devel] Cortex M0 emulation tasks

2018-06-07 Thread Stefan Hajnoczi
On Mon, Jun 04, 2018 at 07:15:01AM -0400, Liviu Ionescu wrote: > On 4 June 2018 at 14:10:08, Stefan Hajnoczi (stefa...@gmail.com) wrote: > > > What is the status of the Cortex M0 in that source tree? Is it complete? > > all supported Cortex-M devices run blinky demos using the official > CMSIS in

Re: [Qemu-devel] An emulation failure occurs, if I hotplug vcpus immediately after the VM start

2018-06-07 Thread David Hildenbrand
On 06.06.2018 15:57, Paolo Bonzini wrote: > On 06/06/2018 15:28, Gonglei (Arei) wrote: >> gonglei: mem.slot: 3, mem.guest_phys_addr=0xc, >> mem.userspace_addr=0x7fc343ec, mem.flags=0, memory_size=0x0 >> gonglei: mem.slot: 3, mem.guest_phys_addr=0xc, >> mem.userspace_add

Re: [Qemu-devel] An emulation failure occurs, if I hotplug vcpus immediately after the VM start

2018-06-07 Thread David Hildenbrand
On 06.06.2018 15:57, Paolo Bonzini wrote: > On 06/06/2018 15:28, Gonglei (Arei) wrote: >> gonglei: mem.slot: 3, mem.guest_phys_addr=0xc, >> mem.userspace_addr=0x7fc343ec, mem.flags=0, memory_size=0x0 >> gonglei: mem.slot: 3, mem.guest_phys_addr=0xc, >> mem.userspace_add

Re: [Qemu-devel] [PATCH 1/6] console: add support for dmabufs

2018-06-07 Thread Marc-André Lureau
Hi Gerd On Tue, Oct 10, 2017 at 3:54 PM, Gerd Hoffmann wrote: > This patch adds support for dma-bufs to the qemu console interfaces. > It adds a new "struct QemuDmaBuf" to represent a dmabuf with accociated > metatdata (size, format). It adds three functions (and > DisplayChangeListenerOps opera

[Qemu-devel] [Bug 1775366] Re: [Feature request] qemu-ga - Allow unexpected parameter

2018-06-07 Thread Daniel Berrange
BTW, if you have any friendly contact with the your hosting provider, please encourage them to contribute any enhancements they have back to QEMU. It is highly desirable to *NOT* have hosting providers needing a fork of qemu-ga, as that ruins ability to run standard disk images, as you've found. -

Re: [Qemu-devel] [PATCH V6 7/7] migration/ram: ensure write persistence on loading all data to PMEM.

2018-06-07 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@gmail.com) wrote: > On Fri, Jun 01, 2018 at 04:10:29PM +0800, junyan...@gmx.com wrote: > > diff --git a/migration/ram.c b/migration/ram.c > > index aa0c6f0..09525b2 100644 > > --- a/migration/ram.c > > +++ b/migration/ram.c > > @@ -33,6 +33,7 @@ > > #include "qemu/bitop

Re: [Qemu-devel] Cortex M0 emulation tasks

2018-06-07 Thread Stefan Hajnoczi
Oops, I meant Outreachy internship instead of Google Summer of Code. Stefan signature.asc Description: PGP signature

Re: [Qemu-devel] [qemu-s390x] [PATCH v4 14/14] memory-device: factor out plug into hotplug handler

2018-06-07 Thread David Hildenbrand
On 04.06.2018 13:47, David Hildenbrand wrote: > On 01.06.2018 13:39, Igor Mammedov wrote: >> On Thu, 17 May 2018 10:15:27 +0200 >> David Hildenbrand wrote: >> >>> Let's move the plug logic into the applicable hotplug handler for pc and >>> spapr. >>> >>> Signed-off-by: David Hildenbrand >>> --- >

Re: [Qemu-devel] Cortex M0 emulation tasks

2018-06-07 Thread Liviu Ionescu
On 7 June 2018 at 13:36:30, Stefan Hajnoczi (stefa...@gmail.com) wrote: > If you do want to upstream the code you linked, please let us know > the > details of how you want to do it and how long it might take. Maybe > there is a way to work together on it... yes, I considered this, but I do not h

[Qemu-devel] [Bug 1101210] Re: qemu 1.4.2: usb keyboard not fully working

2018-06-07 Thread Thomas Huth
Looks like people report different issues here... if you report a keyboard mapping problem, please try to either make sure that it matches the bug, or open a new ticket. So the original problem (with the < > | not working at all) seems to be fixed nowadays, at least it works for me with a Linux gu

Re: [Qemu-devel] [PATCH v3b 18/18] target/arm: Implement SVE Floating Point Arithmetic - Unpredicated Group

2018-06-07 Thread Peter Maydell
On 30 May 2018 at 19:01, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 14 > target/arm/helper.h| 19 +++ > target/arm/translate-sve.c | 42 +++ > target/arm/vec_helper.c| 69 +

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 6/7] s390x/tcg: rearm the CKC timer during migration

2018-06-07 Thread David Hildenbrand
On 04.06.2018 14:09, Cornelia Huck wrote: > On Fri, 25 May 2018 13:37:07 +0200 > David Hildenbrand wrote: > >> If the CPU data is migrated after the TOD clock, the CKC timer of a CPU >> is not rearmed. Let's rearm it when loading the CPU state. >> >> Signed-off-by: David Hildenbrand >> --- >> t

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 1/7] s390x/tod: factor out TOD into separate device

2018-06-07 Thread David Hildenbrand
On 04.06.2018 14:14, Cornelia Huck wrote: > On Mon, 4 Jun 2018 14:00:43 +0200 > David Hildenbrand wrote: > >> On 04.06.2018 13:38, Cornelia Huck wrote: >>> On Fri, 25 May 2018 13:37:02 +0200 >>> David Hildenbrand wrote: >>> Let's treat this like a separate device. TCG will have to store

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 5/7] s390x/tcg: implement SET CLOCK

2018-06-07 Thread David Hildenbrand
On 04.06.2018 14:05, Cornelia Huck wrote: > On Fri, 25 May 2018 13:37:06 +0200 > David Hildenbrand wrote: > >> This allows a guest to change its TOD. We already take care of updating >> all CKC timers from within S390TODClass. >> >> Use MO_ALIGN to load the operand manually - this will properly t

Re: [Qemu-devel] storing machine data in qcow images?

2018-06-07 Thread Andrea Bolognani
On Thu, 2018-06-07 at 11:32 +0100, Richard W.M. Jones wrote: > On Thu, Jun 07, 2018 at 12:02:29PM +0200, Andrea Bolognani wrote: > > Something that I haven't seen mentioned in the thread - and this > > looks like as good a point as any to jump in - is that for q35 > > guests using EFI as well as aa

Re: [Qemu-devel] storing machine data in qcow images?

2018-06-07 Thread Andrea Bolognani
On Thu, 2018-06-07 at 11:36 +0100, Daniel P. Berrangé wrote: > On Thu, Jun 07, 2018 at 11:32:18AM +0100, Richard W.M. Jones wrote: > > Another problem which Laszlo mentioned is the varstore isn't portable > > between UEFI implementations, or if the UEFI is compiled with > > different options. You

Re: [Qemu-devel] [PATCH 1/8] sdcard: Update the Configuration Register (SCR) to Spec Version 1.10

2018-06-07 Thread Peter Maydell
On 3 June 2018 at 01:08, Philippe Mathieu-Daudé wrote: > This register now matches the description of the header: > > * SD Memory Card emulation as defined in the "SD Memory Card Physical > * layer specification, Version 1.10." Can you provide a brief justification in the commit message of why

Re: [Qemu-devel] An emulation failure occurs, if I hotplug vcpus immediately after the VM start

2018-06-07 Thread Paolo Bonzini
On 07/06/2018 12:37, David Hildenbrand wrote: > > I have a related requirement, which would be to atomically grow a > memory regions. So instead of region_del(old)+region_add(new), I would > have to do it in one shot (atomically). > > AFAICS an atomic replace of the memory map would work for this

Re: [Qemu-devel] [PATCH 03/17] iotests: ask qemu for supported formats

2018-06-07 Thread Paolo Bonzini
On 07/06/2018 09:50, Thomas Huth wrote: > >> There's no real need to kill off '?', unless it gets in the way of >> steering people towards 'help'. We should steer them toward 'help', >> because '?' is a trap for insufficiently sophisticated users of >> shell[*]. > ... and I agree with your points

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 1/7] s390x/tod: factor out TOD into separate device

2018-06-07 Thread Cornelia Huck
On Thu, 7 Jun 2018 12:49:23 +0200 David Hildenbrand wrote: > On 04.06.2018 14:14, Cornelia Huck wrote: > > On Mon, 4 Jun 2018 14:00:43 +0200 > > David Hildenbrand wrote: > > > >> On 04.06.2018 13:38, Cornelia Huck wrote: > >>> On Fri, 25 May 2018 13:37:02 +0200 > >>> David Hildenbrand wrot

Re: [Qemu-devel] [PATCH 03/17] iotests: ask qemu for supported formats

2018-06-07 Thread Thomas Huth
On 07.06.2018 13:07, Paolo Bonzini wrote: > On 07/06/2018 09:50, Thomas Huth wrote: >> >>> There's no real need to kill off '?', unless it gets in the way of >>> steering people towards 'help'. We should steer them toward 'help', >>> because '?' is a trap for insufficiently sophisticated users of

Re: [Qemu-devel] Stair step trace output since 12fb0ac05

2018-06-07 Thread Thomas Huth
On 06.06.2018 20:33, Peter Maydell wrote: > On 6 June 2018 at 18:15, BALATON Zoltan wrote: >> Hello, >> >> Since 12fb0ac05 (char: Remove unwanted crlf conversion) trace output is >> printed in stair steps when using -trace and -serial stdio together. E.g. >> $ qemu-system-i386 -trace 'pci*' -seria

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 5/7] s390x/tcg: implement SET CLOCK

2018-06-07 Thread Cornelia Huck
On Thu, 7 Jun 2018 12:48:21 +0200 David Hildenbrand wrote: > On 04.06.2018 14:05, Cornelia Huck wrote: > > On Fri, 25 May 2018 13:37:06 +0200 > > David Hildenbrand wrote: > > > >> This allows a guest to change its TOD. We already take care of updating > >> all CKC timers from within S390TODCl

Re: [Qemu-devel] storing machine data in qcow images?

2018-06-07 Thread Andrea Bolognani
On Thu, 2018-06-07 at 11:22 +0100, Daniel P. Berrangé wrote: > On Thu, Jun 07, 2018 at 12:02:29PM +0200, Andrea Bolognani wrote: > > While hints might be considered a reasonable fit for qcow2, I think > > it's pretty hard to argue for embedding the NVRAM file in there, > > which to me signals quite

Re: [Qemu-devel] [PATCH 03/17] iotests: ask qemu for supported formats

2018-06-07 Thread Paolo Bonzini
On 07/06/2018 13:10, Thomas Huth wrote: > On 07.06.2018 13:07, Paolo Bonzini wrote: >> On 07/06/2018 09:50, Thomas Huth wrote: >>> There's no real need to kill off '?', unless it gets in the way of steering people towards 'help'. We should steer them toward 'help', because '?' is a

[Qemu-devel] -enable-kvm and friens (was: Re: [PATCH 03/17] iotests: ask qemu for supported formats)

2018-06-07 Thread Thomas Huth
On 07.06.2018 13:18, Paolo Bonzini wrote: [...] > As to "-enable-kvm", I don't see anything wrong with users using it, or > even with occasionally adding more options like it. However, we should > warn developers that such simple options should be syntactic sugar for a > structured (i.e. QemuOpts-

Re: [Qemu-devel] [PATCH 03/17] iotests: ask qemu for supported formats

2018-06-07 Thread Markus Armbruster
Thomas Huth writes: > On 07.06.2018 08:57, Markus Armbruster wrote: >> Thomas Huth writes: >> >>> On 05.06.2018 00:40, Eric Blake wrote: On 06/04/2018 05:34 AM, Thomas Huth wrote: > On 04.06.2018 09:18, Markus Armbruster wrote: >> Roman Kagan writes: >> >>> Add helper func

Re: [Qemu-devel] An emulation failure occurs, if I hotplug vcpus immediately after the VM start

2018-06-07 Thread David Hildenbrand
On 07.06.2018 13:02, Paolo Bonzini wrote: > On 07/06/2018 12:37, David Hildenbrand wrote: >> >> I have a related requirement, which would be to atomically grow a >> memory regions. So instead of region_del(old)+region_add(new), I would >> have to do it in one shot (atomically). >> >> AFAICS an atom

Re: [Qemu-devel] [RFC v2 3/4] monitor: remove "x-oob", turn oob on by default

2018-06-07 Thread Markus Armbruster
Peter Xu writes: > There was a regression reported by Eric Auger before with OOB: > > http://lists.gnu.org/archive/html/qemu-devel/2018-03/msg06231.html > > The fix is 951702f39c ("monitor: bind dispatch bh to iohandler context", > 2018-04-10), which is in master already. > > For the bug, we tu

Re: [Qemu-devel] -enable-kvm and friens (was: Re: [PATCH 03/17] iotests: ask qemu for supported formats)

2018-06-07 Thread Paolo Bonzini
On 07/06/2018 13:27, Thomas Huth wrote: >> As to "-enable-kvm", I don't see anything wrong with users using it, or >> even with occasionally adding more options like it. However, we should >> warn developers that such simple options should be syntactic sugar for a >> structured (i.e. QemuOpts-base

Re: [Qemu-devel] An emulation failure occurs, if I hotplug vcpus immediately after the VM start

2018-06-07 Thread David Hildenbrand
On 07.06.2018 13:13, Gonglei (Arei) wrote: > >> -Original Message- >> From: David Hildenbrand [mailto:da...@redhat.com] >> Sent: Thursday, June 07, 2018 6:40 PM >> Subject: Re: An emulation failure occurs,if I hotplug vcpus immediately >> after the >> VM start >> >> On 06.06.2018 15:57, P

[Qemu-devel] [Bug 1775555] Re: guest migration 100% cpu freeze bug

2018-06-07 Thread Dr. David Alan Gilbert
hangs like this after migration are a pain to debug; especially with that really rare recurrence rate. The fact the RIP is changing and is moving in and out of the kernel suggests something is happening; so it might be that we've corrupted some memory, or got a device in a mess where the device

Re: [Qemu-devel] -enable-kvm and friens

2018-06-07 Thread Thomas Huth
On 07.06.2018 13:42, Paolo Bonzini wrote: > On 07/06/2018 13:27, Thomas Huth wrote: >>> As to "-enable-kvm", I don't see anything wrong with users using it, or >>> even with occasionally adding more options like it. However, we should >>> warn developers that such simple options should be syntacti

Re: [Qemu-devel] [PATCH] monitor: postpone monitor_qmp_cleanup_queues

2018-06-07 Thread Markus Armbruster
Peter Xu writes: > Previously we cleanup the queues when we got CLOSED event. It was used we clean up > to make sure we won't leftover replies/events of a old client to a new we won't send leftover replies/events of an old client > client. Now this patch postpones that until OPENED. What i

Re: [Qemu-devel] [PATCH v7 4/5] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-07 Thread Wei Wang
On 06/07/2018 02:32 PM, Peter Xu wrote: On Thu, Jun 07, 2018 at 01:24:29PM +0800, Wei Wang wrote: On 06/06/2018 07:02 PM, Peter Xu wrote: On Wed, Jun 06, 2018 at 06:04:23PM +0800, Wei Wang wrote: On 06/06/2018 01:42 PM, Peter Xu wrote: IMHO migration states do not suite here. IMHO bitmap syn

Re: [Qemu-devel] [PATCH v7 4/5] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-07 Thread Wei Wang
On 06/07/2018 02:58 PM, Peter Xu wrote: On Thu, Jun 07, 2018 at 01:29:22PM +0800, Wei Wang wrote: [...] +static const VMStateDescription vmstate_virtio_balloon_free_page_report = { +.name = "virtio-balloon-device/free-page-report", +.version_id = 1, +.minimum_version_id = 1, +.n

Re: [Qemu-devel] An emulation failure occurs, if I hotplug vcpus immediately after the VM start

2018-06-07 Thread Gonglei (Arei)
> -Original Message- > From: David Hildenbrand [mailto:da...@redhat.com] > Sent: Thursday, June 07, 2018 6:40 PM > Subject: Re: An emulation failure occurs,if I hotplug vcpus immediately after > the > VM start > > On 06.06.2018 15:57, Paolo Bonzini wrote: > > On 06/06/2018 15:28, Gonglei

[Qemu-devel] [PATCH v6 2/2] vl: fix use of --daemonize with --preconfig

2018-06-07 Thread Igor Mammedov
When using --daemonize, the initial lead process will fork a child and then wait to be notified that setup is complete via a pipe, before it exits. When using --preconfig there is an extra call to main_loop() before the notification is done from os_setup_post(). Thus the parent process won't exit

Re: [Qemu-devel] [PATCH] CODING_STYLE: Define our preferred form for multiline comments

2018-06-07 Thread Markus Armbruster
Peter Maydell writes: > On 5 June 2018 at 08:46, Cornelia Huck wrote: >> On Tue, 5 Jun 2018 06:33:22 +0200 >> Thomas Huth wrote: >>> On 05.06.2018 03:17, Alex Williamson wrote: >>> > On Mon, 4 Jun 2018 17:21:40 +0100 >>> > Peter Maydell wrote: >>> >> +Multiline comments blocks should have a r

Re: [Qemu-devel] [PATCH v2 4/6] hmp: Add info commands for preconfig

2018-06-07 Thread Igor Mammedov
On Thu, 7 Jun 2018 11:21:21 +0100 "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Allow a bunch of the info commands to be used in preconfig. > Could probably add most of them. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Igor Mammedov > --- > hmp-comm

Re: [Qemu-devel] [PATCH 1/6] hmp: Add flag for preconfig commands

2018-06-07 Thread Markus Armbruster
"Dr. David Alan Gilbert (git)" writes: > From: "Dr. David Alan Gilbert" > > Add a flag to command definitions to allow them to be used in preconfig > and check it. > > Signed-off-by: Dr. David Alan Gilbert > --- > monitor.c | 19 +++ > 1 file changed, 19 insertions(+) > > diff

Re: [Qemu-devel] [PATCH 1/6] hmp: Add flag for preconfig commands

2018-06-07 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" writes: > > > From: "Dr. David Alan Gilbert" > > > > Add a flag to command definitions to allow them to be used in preconfig > > and check it. > > > > Signed-off-by: Dr. David Alan Gilbert > > --- > > monitor.c | 1

[Qemu-devel] [Bug 1775555] Re: guest migration 100% cpu freeze bug

2018-06-07 Thread Dion Bosschieter
guest xml definition: vps25 0cf4666d-6855-b3a8-12da-2967563f 8388608 8388608 4 /machine hvm Westmere destroy restart restart /usr/bin/kvm 734003200 57

[Qemu-devel] [PATCH v2 1/4] roms: Update SLOF submodule to current status

2018-06-07 Thread Thomas Huth
We need the latest version of SLOF's libnet for adding pxelinux.cfg support in the s390-ccw bios, too. Signed-off-by: Thomas Huth --- I assume that Alexey will send a SLOF update soon, too, which supplies the SLOF.bin file for these changes. roms/SLOF | 2 +- 1 file changed, 1 insertion(+), 1

  1   2   3   4   5   >