From: Philippe Mathieu-Daudé
4c3119a6e3e and cd9526ab7c0 introduced an incorrect and inconsistent
use of Chardev->be. Also, this CharBackend member is private and is
not supposed to be accessible.
Fix it by removing the inconsistent check.
Cc: qemu-sta...@nongnu.org
Reported-by: Marc-André Lur
Mostly a rewrite, in order to keep the loop simple.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Paolo Bonzini
---
qom/object.c | 28
1 file changed, 16 insertions(+), 12 deletions(-)
diff --git a/qom/object.c b/qom/object.c
index 0fc972030e..cb7a8cd589 10064
From: Marc-André Lureau
Commit fb5e19d2e1472e96d72d5e4d89c20033f8ab345c originally fixed the
regression, but was inadvertently broken again in merge commit
2d6752d38d8acda.
Fixes:
https://bugs.launchpad.net/qemu/+bug/1654137
Cc: qemu-sta...@nongnu.org
Signed-off-by: Marc-André Lureau
Reviewed-
---
hw/virtio/virtio.c | 33 ++---
1 file changed, 18 insertions(+), 15 deletions(-)
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index 1debb0147b..d4e4d98b59 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -123,11 +123,22 @@ static void
virtio_fre
From: Philippe Mathieu-Daudé
Since no devices use it, we can safely remove it.
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20180419212727.26095-5-f4...@amsat.org>
Reviewed-by: Markus Armbruster
[Removal of DeviceClass::init() moved from previous patch, missing
documentation updates supp
From: Philippe Mathieu-Daudé
There is no need to include pci.h in this file.
(Continue f23c81073a cleanup).
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20180528232719.4721-21-f4...@amsat.org>
Acked-by: Michael S. Tsirkin
Signed-off-by: Paolo Bonzini
---
hw/ide/core.c | 1 -
1 file cha
From: Corey Minyard
The vmstate for isa_ipmi_kcs was referencing into the kcs structure,
instead create a kcs structure separate and use that.
There were also some issues in the state transfer. The inlen field
was not being transferred, so if a transaction was in process during
the transfer it
From: Peter Maydell
Signed-off-by: Peter Maydell
Message-Id: <20180515134835.3409-1-peter.mayd...@linaro.org>
Signed-off-by: Paolo Bonzini
---
include/exec/memory.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/exec/memory.h b/include/exec/memory.h
index 525619a5f
From: Philippe Mathieu-Daudé
Since 2f652224f7, we now check if socket_set_nodelay() errored,
but forgot to close the socket before reporting an error.
Fixes: Coverity CID 1391290 (RESOURCE_LEAK)
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20180524223458.5651-1-f4...@amsat.org>
Reviewed-b
From: Peter Maydell
The kernel has changed its license documentation, so instead of COPYING
being a stand-alone file that defines the license, it refers to various
other files under LICENSES/. This means we need to copy not just COPYING
but also these other files to our copy of the kernel headers
From: Lucian Petrut
This patch fixes a few compiler warnings, especially in case of
x86 targets, where the number of registers was not properly handled
and could cause an overflow.
Signed-off-by: Alessandro Pilotti
Signed-off-by: Justin Terry (VM)
Signed-off-by: Lucian Petrut
Message-Id: <152
From: Tristan Burgess
This changes the functions memory_region_ioeventfd_equal,
memory_region_ioeventfd_before, and their callers,
to pass the MemoryRegionIoeventfd struct via pointer, instead of directly
passing the struct. This saves on stack space
and is considered safe practice.
Signed-off
From: Laszlo Ersek
Add a schema that describes the different uses and properties of virtual
machine firmware.
Each firmware executable installed on a host system should come with at
least one JSON file that conforms to this schema. Each file informs the
management applications about
- the firmwa
From: Peter Maydell
Update our copy of the Linux headers to upstream 4.17-rc6
(kernel commit 771c577c23bac90597c68).
Signed-off-by: Peter Maydell
Message-Id: <20180525132755.21839-6-peter.mayd...@linaro.org>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Paolo Bonzini
---
include/standard-he
From: Corey Minyard
The VMS_STRUCT has no way to specify which version of a structure
to use. Add a type and a new field to allow the specific version
of a structure to be used.
Signed-off-by: Corey Minyard
Message-Id: <1524670052-28373-2-git-send-email-miny...@acm.org>
Signed-off-by: Paolo Bo
From: Philippe Mathieu-Daudé
I2CSlaveClass::init is no more used, remove it.
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20180419212727.26095-3-f4...@amsat.org>
Reviewed-by: Markus Armbruster
Signed-off-by: Markus Armbruster
Message-Id: <20180528144509.15812-3-arm...@redhat.com>
Signed
On Thu, 31 May 2018 12:14:30 -0400
Keno Fischer wrote:
> > I'm ok with this move, but if the functions need to have distinct
> > implementations, and they really do according to patch 10, then
> > I'd rather have distinct files and rely on conditional building in
> > the makefile. Maybe rename th
From: Philippe Mathieu-Daudé
Instead of using
SysBusDeviceClass::realize
-> DeviceClass::realize
-> DeviceClass::init
-> sysbus_device_init
-> SysBusDeviceClass::init
Simplify the path by directly calling SysBusDeviceClass::init
in SysBusDeviceClass::realize:
From: Patryk Olszewski
This patch fixes a bug in serial that made it almost impossible for guest
to communicate with devices through host's serial.
OPOST flag in c_oflag enables output processing letting other flags in
c_oflag take effect. Usually in c_oflag ONLCR flag is also set, which
causes
Please apply the following commit to QEMU 2.12:
commit 7647d5c6b5e3b3f36a6e0441c81ae3fe797eb233
Author: Marc-André Lureau
Date: Tue May 8 11:29:35 2018 -0400
tests: fix tpm-crb tpm-tis tests race
No need to close the TPM data socket on the emulator end, qemu will
close it after
Even though the presence of softfloat does not cause --disable-tcg builds to
fail,
it is the single largest .o file in them. Remove it, since TCG is the only
client.
Acked-by: Richard Henderson
Signed-off-by: Paolo Bonzini
---
Makefile.target | 2 +-
1 file changed, 1 insertion(+), 1 deletio
On Thu, May 31, 2018 at 10:27:00AM +0800, Wei Wang wrote:
> On 05/30/2018 08:47 PM, Michael S. Tsirkin wrote:
> > On Wed, May 30, 2018 at 05:12:09PM +0800, Wei Wang wrote:
> > > On 05/29/2018 11:24 PM, Michael S. Tsirkin wrote:
> > > > On Tue, Apr 24, 2018 at 02:13:47PM +0800, Wei Wang wrote:
> > >
Jake, can you try the fix I posted in
https://bugs.launchpad.net/qemu/+bug/1769189 ? I'm not actually
confident it's the same bug, but it might be worth a shot. It fixes a
bug that was made more prominent inbetween 2.11 and 2.12, so it fits the
timeline presented here.
--
You received this bug no
> Oops you're right... so we indeed need to handle this conflicting APIs,
> but fgetxattr_follow() is inapropriate, because fgetxattr() has nothing
> to follow since it already has an fd... The same goes with Darwin's
> version actually. The "nofollow" thingy only makes sense for those calls
> that
>> +elif test "$darwin" = yes; then
>>virtfs=yes
>> - tools="$tools fsdev/virtfs-proxy-helper\$(EXESUF)"
>
> So, no proxy helper on Darwin ? Why ? The limitation should be mentioned in
> the changelog at least.
I just had no use for it. I'll try to build it and see what happens.
On 31 May 2018 at 18:12, Paolo Bonzini wrote:
> The following changes since commit 5a5c383b1373aeb6c87a0d6060f6c3dc7c53082b:
>
> Merge remote-tracking branch
> 'remotes/vivier2/tags/linux-user-for-2.13-pull-request' into staging
> (2018-05-25 10:04:36 +0100)
>
> are available in the Git reposi
Hi Paolo, something messed with UTF-8...
On 05/31/2018 02:12 PM, Paolo Bonzini wrote:
> From: Philippe Mathieu-Daudé
>
> 4c3119a6e3e and cd9526ab7c0 introduced an incorrect and inconsistent
> use of Chardev->be. Also, this CharBackend member is private and is
> not supposed to be accessible.
>
Hello,
Cédric Le Goater, le mer. 30 mai 2018 08:10:32 +0200, a ecrit:
> Here is a couple of enhancements and fixes for the NC-SI backend used
> on the Aspeed SoC when soldered on OpenPOWER boards.
Applied to my tree, thanks!
(my train is 2h late, so I'll probably have the time to pull-request i
Hello,
Michael S. Tsirkin, le jeu. 03 mai 2018 22:51:01 +0300, a ecrit:
> +#include_next "../slirp/ip6.h"
Mmm, this is the first time #include_next would be used in qemu, and I
don't think this is a standard thing...
Samuel
@John Snow Thanks! After applying that patch, I couldn't reproduce this
anymore. At least for me it seems that these two issues refer to the
same bug.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/176
On 05/31/2018 12:15 PM, Paolo Bonzini wrote:
From: Laszlo Ersek
Add a schema that describes the different uses and properties of virtual
machine firmware.
Each firmware executable installed on a host system should come with at
least one JSON file that conforms to this schema. Each file informs
From: Igor Druzhinin
When global_log_dirty is enabled VRAM modification tracking never
worked correctly. The address that is passed to xen_hvm_modified_memory()
is not the effective PFN but RAM block address which is not the same
for VRAM.
We need to make a translation for this address into PFN
From: Paul Durrant
Xen 4.11 has a new API to directly map guest resources. Among the resources
that can be mapped using this API are ioreq pages.
This patch modifies QEMU to attempt to use the new API should it exist,
falling back to the previous mechanism if it is unavailable.
Signed-off-by: P
The following changes since commit c181ddaa176856b3cd2dfd12bbcf25fa9c884a97:
Merge remote-tracking branch
'remotes/pmaydell/tags/pull-target-arm-20180531-1' into staging (2018-05-31
17:00:55 +0100)
are available in the git repository at:
http://xenbits.xenproject.org/git-h
From: Paul Durrant
This patch removes the current hackery where IOREQ_TYPE_PCI_CONFIG
requests are handled by faking PIO to 0xcf8 and 0xcfc and replaces it
with direct calls to pci_host_config_read/write_common().
Doing so necessitates mapping BDFs to PCIDevices but maintaining a simple
QLIST in
*** This bug is a duplicate of bug 1769189 ***
https://bugs.launchpad.net/bugs/1769189
Great, thank you so much for helping!
** This bug has been marked a duplicate of bug 1769189
Issue with qemu 2.12.0 + SATA
--
You received this bug notification because you are a member of qemu-
devel-
** Changed in: qemu
Status: New => Confirmed
** Changed in: qemu
Assignee: (unassigned) => John Snow (jnsnow)
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1769189
Title:
Issue with qe
On Thu, 31 May 2018 12:20:28 -0400
Keno Fischer wrote:
> >> diff --git a/hw/9pfs/9p-synth.c b/hw/9pfs/9p-synth.c
> >> index eb68b42..3c0a6d8 100644
> >> --- a/hw/9pfs/9p-synth.c
> >> +++ b/hw/9pfs/9p-synth.c
> >> @@ -221,7 +221,11 @@ static void synth_direntry(V9fsSynthNode *node,
> >> {
> >>
From: James Clarke
If the receive window presented to the guest closes, slirp should send a
window update once the window reopens sufficiently, rather than forcing
the guest to send a window probe, which can take several seconds.
Signed-off-by: James Clarke
Signed-off-by: Samuel Thibault
---
From: Cédric Le Goater
Command 0x17 'Get Parameters' is used to get configuration parameter
values currently in effect on the controller and it is mandatory in
the NS-CI specification.
Provide a minimum response to exercise the kernel.
Signed-off-by: Cédric Le Goater
Reviewed-by: Philippe Math
From: Nia Alarie
Signed-off-by: Nia Alarie
Signed-off-by: Samuel Thibault
---
net/slirp.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/slirp.c b/net/slirp.c
index 005c2675e6..1e14318b4d 100644
--- a/net/slirp.c
+++ b/net/slirp.c
@@ -492,7 +492,9 @@ void hmp_hostfw
From: Alexey Kardashevskiy
Signed-off-by: Alexey Kardashevskiy
Signed-off-by: Samuel Thibault
---
slirp/arp_table.c | 4 ++--
slirp/socket.c| 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/slirp/arp_table.c b/slirp/arp_table.c
index bac608f97f..f81963bb88 100644
---
From: Cédric Le Goater
Signed-off-by: Cédric Le Goater
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Joel Stanley
Signed-off-by: Samuel Thibault
---
slirp/ncsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/slirp/ncsi.c b/slirp/ncsi.c
index d12ba3e494..02d0e9def3 1006
From: Benjamin Drung
This patch will allow the user to include the domainname option in
replies from the built-in DHCP server.
Signed-off-by: Benjamin Drung
Signed-off-by: Samuel Thibault
---
net/slirp.c | 12 +---
qapi/net.json| 4
qemu-options.hx | 7 +--
slirp/
From: Andreas Gustafsson
When setting up an outgoing user mode networking TCP connection,
disable the Nagle algorithm in the host-side connection. Either the
guest is already doing Nagle, in which case there is no point in doing
it twice, or it has chosen to disable it, in which case we should
r
The following changes since commit c181ddaa176856b3cd2dfd12bbcf25fa9c884a97:
Merge remote-tracking branch
'remotes/pmaydell/tags/pull-target-arm-20180531-1' into staging (2018-05-31
17:00:55 +0100)
are available in the Git repository at:
http://people.debian.org/~sthibault/qem
On Thu, 31 May 2018 12:27:35 -0400
Keno Fischer wrote:
> >> --- a/hw/9pfs/9p-local.c
> >> +++ b/hw/9pfs/9p-local.c
> >> @@ -67,7 +67,10 @@ int local_open_nofollow(FsContext *fs_ctx, const char
> >> *path, int flags,
> >> assert(*path != '/');
> >>
> >> head = g_strdup(path);
>
Well, I do have the patch already to switch this and the other patterns,
so let me know if you want it or not ;).
On Thu, May 31, 2018 at 3:22 PM, Greg Kurz wrote:
> On Thu, 31 May 2018 12:27:35 -0400
> Keno Fischer wrote:
>
>> >> --- a/hw/9pfs/9p-local.c
>> >> +++ b/hw/9pfs/9p-local.c
>> >> @@
This follows 3929766fb3e4 ('slirp: disable Nagle in outgoing connections'):
for the same reasons, ingoing connections should have the Nagle algorithm
disabled.
Signed-off-by: Samuel Thibault
Reviewed-by: Philippe Mathieu-Daudé
---
slirp/socket.c | 2 ++
1 file changed, 2 insertions(+)
diff --
When DEBUG is enabled, len needs to be updated.
Signed-off-by: Samuel Thibault
---
slirp/socket.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/slirp/socket.c b/slirp/socket.c
index e2a71c9b04..3182477ff5 100644
--- a/slirp/socket.c
+++ b/slirp/socket.c
@@ -351,7 +351,7 @@
From: Cédric Le Goater
The checksum field of a NC-SI packet contains a value that may be
included in each command and response. The verification is optional
but the Linux driver does so when a non-zero value is provided. Let's
extend the model to compute the checksum value and exercise a little
m
On Thu, May 31, 2018 at 08:50:32PM +0200, Samuel Thibault wrote:
> Hello,
>
> Michael S. Tsirkin, le jeu. 03 mai 2018 22:51:01 +0300, a ecrit:
> > +#include_next "../slirp/ip6.h"
>
> Mmm, this is the first time #include_next would be used in qemu, and I
> don't think this is a standard thing...
>
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180531192419.4592-1-samuel.thiba...@ens-lyon.org
Subject: [Qemu-devel] [PATCH] slirp: Fix spurious error report when sending
directly
=== TEST SCRIPT BEGIN ===
#!/bin/bash
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180531192237.3994-1-samuel.thiba...@ens-lyon.org
Subject: [Qemu-devel] [PULL 0/9] slirp updates
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneli
On 05/31/2018 02:22 PM, Samuel Thibault wrote:
From: Benjamin Drung
This patch will allow the user to include the domainname option in
replies from the built-in DHCP server.
Signed-off-by: Benjamin Drung
Signed-off-by: Samuel Thibault
---
net/slirp.c | 12 +---
qapi/net.json
On Thu, 31 May 2018 12:25:49 -0400
Keno Fischer wrote:
> >> +errno = EINVAL;
> >> +return -1;
> >
> > ... I'm more concerned about this new error path. How can this happen ?
> >
>
> As far as I can tell, the flags come from the client without any
> intermediate error
> checki
Signed-off-by: Samuel Thibault
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 41cd3736a9..8822ae9b70 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1675,6 +1675,7 @@ S: Maintained
F: slirp/
F: net/slirp.c
F: include/net/slirp.h
+T: git http:
On Thu, 31 May 2018 15:23:45 -0400
Keno Fischer wrote:
> Well, I do have the patch already to switch this and the other patterns,
> so let me know if you want it or not ;).
>
Post it then and we'll see if people are happy with that :)
> On Thu, May 31, 2018 at 3:22 PM, Greg Kurz wrote:
> > On
When the parent bus removes the child property, it takes care of
removing the added reference, in object_finalize_child_property().
Signed-off-by: Marc-André Lureau
---
hw/core/bus.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/core/bus.c b/hw/core/bus.c
index 4651f24486..ad0c9df335 100
A link property can be set during creation, with
object_property_add_link() and later with object_property_set_link().
add_link() doesn't add a reference to the target object, while
set_link() does.
Furthemore, OBJ_PROP_LINK_UNREF_ON_RELEASE flags, set during add_link,
says whether a reference mu
Hi,
The following series fixes the usb-ccid hotplug regression introduced
by commit 675f22c6d3b0: the plugged device is not completely removed
on device_del anymore, due to an extra reference added when doing
set_link(). It turns out the memory management of qdev bus/child is a
bit weird, this is
qbus_create_inplace() creates a new reference in realize(), it must be
released in unrealize().
Signed-off-by: Marc-André Lureau
---
hw/usb/dev-smartcard-reader.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-reader.c
index f7451923f4..a
Hi Samuel,
On 05/31/2018 04:24 PM, Samuel Thibault wrote:
> When DEBUG is enabled, len needs to be updated.
>
> Signed-off-by: Samuel Thibault
> ---
> slirp/socket.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/slirp/socket.c b/slirp/socket.c
> index e2a71c9b04..318
Signed-off-by: Marc-André Lureau
---
tests/usb-hcd-xhci-test.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/tests/usb-hcd-xhci-test.c b/tests/usb-hcd-xhci-test.c
index 9c14e3053a..5b1b681bf2 100644
--- a/tests/usb-hcd-xhci-test.c
+++ b/tests/usb-hcd-xhci-test.c
@@ -35,6 +35,15
On Thu, 31 May 2018 12:37:56 -0400
Keno Fischer wrote:
> >> +#ifdef CONFIG_DARWIN
> >> +/* Darwin doesn't have mknodat and it's unlikely to work anyway,
> >
> > What's unlikely to work ?
> >
>
> My concern was that allowing this would cause unexpected
> behavior, since the device numbers
The change missed the 2.12 deadline.
Signed-off-by: Samuel Thibault
---
qapi/net.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qapi/net.json b/qapi/net.json
index 32681a1af7..6b7d93cb59 100644
--- a/qapi/net.json
+++ b/qapi/net.json
@@ -161,7 +161,7 @@
# t
On Thu, 31 May 2018 13:46:29 -0400
Keno Fischer wrote:
> >> +elif test "$darwin" = yes; then
> >>virtfs=yes
> >> - tools="$tools fsdev/virtfs-proxy-helper\$(EXESUF)"
> >
> > So, no proxy helper on Darwin ? Why ? The limitation should be mentioned in
> > the changelog at least.
On 05/31/2018 02:52 PM, Samuel Thibault wrote:
The change missed the 2.12 deadline.
Signed-off-by: Samuel Thibault
---
qapi/net.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake
diff --git a/qapi/net.json b/qapi/net.json
index 32681a1af7..6b7d93cb59 100
Dear Pavel,
Thank you for your answer. I am not being able to understand the difference
between CPU I/Os and VM I/Os. Would any network packet that comes into the
Guest OS from the outside be a part of VM I/O or CPU I/O ? I am only
interested in "recording" and "replaying" those network packets th
Philippe Mathieu-Daudé writes:
> Hi Alex,
>
> On 05/30/2018 08:06 AM, Alex Bennée wrote:
>> This is still poorly documented by Travis but according to:
>>
>>
>> https://docs.travis-ci.com/user/common-build-problems/#Running-a-Container-Based-Docker-Image-Locally
>>
>> their reference images
Hi Shameer,
On 05/28/2018 07:02 PM, Andrew Jones wrote:
> On Wed, May 16, 2018 at 04:20:25PM +0100, Shameer Kolothum wrote:
>> This is in preparation for the next patch where initial ram is split
>> into a non-pluggable chunk and a pc-dimm modeled mem if the vaild
>> iova regions are non-contiguo
Daniel P. Berrange writes:
> Currently travis declares ancient python 2.4 is desired. Update that to
> 2.6 which is the oldest version any targetted distros still needs. If we
> just list a python 3 version at the top level this will double the
> number of travis jobs we run which is unreasonab
Move check to where it actually is useful, and reduce scope of 'len'
variable along the way.
Signed-off-by: Samuel Thibault
---
Difference from v1:
- move check instead of initializing len.
slirp/socket.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/slirp/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180531203110.17203-1-samuel.thiba...@ens-lyon.org
Subject: [Qemu-devel] [PATCHv2] slirp: Fix spurious error report when sending
directly
=== TEST SCRIPT BEGIN ===
#!/bin/b
On May 31 15:18, Peter Maydell wrote:
> On 17 May 2018 at 20:31, Aaron Lindsay wrote:
> > On Apr 17 16:00, Peter Maydell wrote:
> >> So, the underlying issue here is that there's a QEMU specific
> >> fudge going on. Architecturally, if the CPU implements the
> >> Virtualization Extensions, then:
>
On Thu, May 31, 2018 at 9:44 AM Peter Maydell wrote:
>
> On 31 May 2018 at 17:32, Richard Henderson
> wrote:
> > On 05/31/2018 08:26 AM, Peter Maydell wrote:
> >> On 30 May 2018 at 21:50, Richard Henderson
> >> wrote:
> >>> On 05/29/2018 04:44 PM, Evan Green wrote:
> When using -L with Li
We are gradually moving away from sector-based interfaces, towards
byte-based. The qcow driver is now ready to fully utilize the
byte-based callback interface, as long as we override the default
alignment to still be 512 (needed at least for asserts present
because of encryption, but easier to do
We are gradually moving away from sector-based interfaces, towards
byte-based. Make the change for the last few sector-based calls
into the block layer from the parallels driver.
Ideally, the parallels driver should switch to doing everything
byte-based, but that's a more invasive change that req
We are gradually moving away from sector-based interfaces, towards
byte-based. Make the change for the internal helper function
get_cluster_offset(), by changing n_start and n_end to by byte
offsets rather than sector indices within the cluster being
allocated. However, assert that these values a
My quest continues. I spent some time pruning sector-based usage
out of qcow as far as possible (and was dismayed at how long it
took to prove no iotests regressions); so for the other drivers, I
did the bare minimum to get rid of an interface, but will leave it
to those file owners if they want t
We are gradually moving away from sector-based interfaces, towards
byte-based. Make the change for the internals of the qcow
driver read function, by iterating over offset/bytes instead of
sector_num/nb_sectors, and with a rename of index_in_cluster and
repurposing of n to track bytes instead of s
We are gradually moving away from sector-based interfaces, towards
byte-based. Make the change for the last few sector-based calls
into the block layer from the replication driver.
Ideally, the replication driver should switch to doing everything
byte-based, but that's a more invasive change that
We are gradually moving away from sector-based interfaces, towards
byte-based. Make the change for the internals of the qcow
driver write function, by iterating over offset/bytes instead of
sector_num/nb_sectors, and with a rename of index_in_cluster and
repurposing of n to track bytes instead of
We are gradually moving away from sector-based interfaces, towards
byte-based. Now that all callers of vectored I/O have been converted
to use our preferred byte-based bdrv_co_p{read,write}v(), we can
delete the unused bdrv_co_{read,write}v().
Furthermore, this gets rid of the signature differenc
We are gradually moving away from sector-based interfaces, towards
byte-based. Make the change for the last few sector-based calls
into the block layer from the vhdx driver.
Ideally, the vhdx driver should switch to doing everything
byte-based, but that's a more invasive change that requires a
bi
This is an example of what all block devices should ideally do in their
realization functions to convey the block configuration to the block
driver.
Signed-off-by: Ari Sundholm
---
hw/scsi/scsi-disk.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
i
A block driver may need to know about the block configuration, most
critically the sector sizes, of a block backend for alignment purposes
or for some other reason. It doesn't seem like qemu has an existing
mechanism for a block backend to convey the required information to
the relevant block drive
This is to ensure that writes are aligned properly for logging writes
to the virtual block device. This is important because the
dm-log-writes log format has a granularity of one sector for both the
offset and the size of each write. By using the logical sector size
for alignment, the log records t
The guest OS may perform writes which are aligned to the logical
sector size instead of the physical one, so logging at this granularity
records the writes performed on the block device most faithfully.
Signed-off-by: Ari Sundholm
---
block/blklogwrites.c | 43 ++-
On 05/18/2018 08:21 AM, Kevin Wolf wrote:
This adds a separate schema file for all job-related definitions that
aren't tied to the block layer.
For a start, move the enums JobType, JobStatus and JobVerb.
Signed-off-by: Kevin Wolf
---
qapi/block-core.json | 90 +--
From: Aapo Vienamo
Implements a block device write logging system, similar to Linux kernel
device mapper dm-log-writes. The write operations that are performed
on a block device are logged to a file or another block device. The
write log format is identical to the dm-log-writes format. Currently,
Commit bf42508f introduced new generated files; make sure they
don't get accidentally committed from an in-tree build.
Signed-off-by: Eric Blake
---
.gitignore | 4
1 file changed, 4 insertions(+)
diff --git a/.gitignore b/.gitignore
index 81e1f2fb0f1..9da3b3e6267 100644
--- a/.gitignore
+
On 05/30/2018 05:16 AM, Thomas Huth wrote:
Since it is quite cumbersome to manually create a combined kernel with
initrd image for network booting, we now support loading via pxelinux
configuration files, too. In these files, the kernel, initrd and command
line parameters can be specified sepe
On Thu, May 31, 2018 at 04:24:35PM -0500, Eric Blake wrote:
> Commit bf42508f introduced new generated files; make sure they
> don't get accidentally committed from an in-tree build.
>
> Signed-off-by: Eric Blake
Reviewed-by: Jeff Cody
> ---
> .gitignore | 4
> 1 file changed, 4 insertio
On Fri, May 25, 2018 at 08:51:22PM +0300, Michael S. Tsirkin wrote:
> On Mon, May 21, 2018 at 10:31:59AM -0600, Ross Zwisler wrote:
> > Changes since v3:
> > * Updated the text in docs/nvdimm.txt to make it clear that the value
> >being passed in on the command line in an integer made up of va
Signed-off-by: John Snow
---
hw/ide/ahci.c | 32 +---
1 file changed, 17 insertions(+), 15 deletions(-)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index 476841df58..efecf849a9 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -282,30 +282,32 @@ static int ahci_cond_st
Signed-off-by: John Snow
---
hw/ide/ahci.c | 8 +++-
hw/ide/trace-events | 3 ++-
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index efecf849a9..01463f0f51 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -27,6 +27,7 @@
#include "hw/pci/
They're now unused.
Signed-off-by: John Snow
---
hw/ide/ahci_internal.h | 18 --
1 file changed, 18 deletions(-)
diff --git a/hw/ide/ahci_internal.h b/hw/ide/ahci_internal.h
index eb7e1eefc0..db00c9aa39 100644
--- a/hw/ide/ahci_internal.h
+++ b/hw/ide/ahci_internal.h
@@ -102,24
Signed-off-by: John Snow
---
hw/ide/ahci.c | 4
1 file changed, 4 deletions(-)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index 92780990a3..476841df58 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -330,11 +330,7 @@ static void ahci_port_write(AHCIState *s, int port, int
offset, uint32_
Churn.
Signed-off-by: John Snow
---
hw/ide/ahci.c | 142 +-
1 file changed, 71 insertions(+), 71 deletions(-)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index 5b5ab823f4..92780990a3 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -279,85
201 - 300 of 390 matches
Mail list logo
