Re: [Qemu-devel] [qemu-s390x] [PATCH] pc-bios/s390-ccw: define loadparm length

2018-05-29 Thread Thomas Huth
On 29.05.2018 06:40, Collin Walling wrote: > Loadparm is defined by the s390 architecture to be 8 bytes > in length. Let's define this size in the s390-ccw bios. > > Suggested-by: Laszlo Ersek > Signed-off-by: Collin Walling > --- > pc-bios/s390-ccw/iplb.h | 4 +++- > pc-bios/s390-ccw/main.c |

Re: [Qemu-devel] [PATCH] pc-bios/s390-ccw: define loadparm length

2018-05-29 Thread Laszlo Ersek
On 05/29/18 06:40, Collin Walling wrote: > Loadparm is defined by the s390 architecture to be 8 bytes > in length. Let's define this size in the s390-ccw bios. > > Suggested-by: Laszlo Ersek > Signed-off-by: Collin Walling > --- > pc-bios/s390-ccw/iplb.h | 4 +++- > pc-bios/s390-ccw/main.c | 8

[Qemu-devel] [Bug 1396052] Re: migration failed when running BurnInTest in guest

2018-05-29 Thread Kevin Wolf
So I think the primary problem is a user error: You can't start the destination VM while the source is still sending data. The mirror operation must have completed or the guest will see a corrupted disk. This means that the destination has to be started with -S, after migration has completed the mi

[Qemu-devel] [PATCH v3] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-29 Thread Yi Min Zhao
If CONFIG_SECCOMP is undefined, the option 'elevateprivileges' remains compiled. This would make libvirt set the corresponding capability and then trigger failure during guest startup. This patch moves the code regarding seccomp command line options to qemu-seccomp.c file and wraps qemu_opts_foreac

Re: [Qemu-devel] [PATCH v4 17/21] hw/misc/sga: Use the correct ISA include

2018-05-29 Thread Marcel Apfelbaum
On 05/29/2018 02:27 AM, Philippe Mathieu-Daudé wrote: The SGA BIOS loader is an ISA device, it does not require the PCI header. Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/sga.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/sga.c b/hw/misc/sga.c index 9

Re: [Qemu-devel] [PATCH v4 19/21] hw/i386/pc: Remove unused include

2018-05-29 Thread Marcel Apfelbaum
On 05/29/2018 02:27 AM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index d768930d02..8b0803cb83 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -64,7 +64,6 @@ #include

Re: [Qemu-devel] [PATCH v4 10/21] hw: Do not include "exec/ioport.h" if it is not necessary

2018-05-29 Thread Marcel Apfelbaum
On 05/29/2018 02:27 AM, Philippe Mathieu-Daudé wrote: Code change produced with: $ git grep '#include "exec/ioport.h"' hw | \ cut -d: -f-1 | \ xargs egrep -Li "(portio|cpu_(in|out).\()" | \ xargs sed -i.bak '/#include "exec\/ioport.h"/d' Signed-off-by: Philippe Mathi

Re: [Qemu-devel] [PATCH] spapr: don't call KVM_PPC_CONFIGURE_V3_MMU if HPT is in userspace

2018-05-29 Thread Laurent Vivier
On 25/05/2018 14:54, Greg Kurz wrote: > Since the kernel commit "dbfcf3cb9c68 powerpc/64: Call H_REGISTER_PROC_TBL > when running as a HPT guest on POWER9", a nested guest running with PR KVM > hangs at boot: > > Preparing to boot Linux version 4.16.0-kvm-pr-hang-gku+ > (greg@qemu.boston16) (

Re: [Qemu-devel] [PATCH v3] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-29 Thread Ján Tomko
On Tue, May 29, 2018 at 03:31:40PM +0800, Yi Min Zhao wrote: If CONFIG_SECCOMP is undefined, the option 'elevateprivileges' remains compiled. This would make libvirt set the corresponding capability and then trigger failure during guest startup. This patch moves the code regarding seccomp command

Re: [Qemu-devel] [PATCH] socket: dont't free msgfds if error equals EAGAIN

2018-05-29 Thread Gonglei (Arei)
Hi all, The issue is easy to reproduce when we confiugred multi-queue function for vhost-user nics. The main backtrace is as follows: vhost_user_write ==> 0) sets s->write_msgfds_num to 8 qemu_chr_fe_write_all qemu_chr_fe_write_buffer ==> 4) rewrite because (ret <0 &

Re: [Qemu-devel] [PULL 0/2] Migration pull

2018-05-29 Thread Peter Maydell
On 25 May 2018 at 14:32, Juan Quintela wrote: > Hi > > this pull: > - fix iotests problems > - add a fix for coverity. > > Apply, please. > > The following changes since commit 5a5c383b1373aeb6c87a0d6060f6c3dc7c53082b: > > Merge remote-tracking branch > 'remotes/vivier2/tags/linux-user-for-2.13

Re: [Qemu-devel] [PATCH v3] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-29 Thread Yi Min Zhao
在 2018/5/29 下午4:40, Ján Tomko 写道: On Tue, May 29, 2018 at 03:31:40PM +0800, Yi Min Zhao wrote: If CONFIG_SECCOMP is undefined, the option 'elevateprivileges' remains compiled. This would make libvirt set the corresponding capability and then trigger failure during guest startup. This patch mo

Re: [Qemu-devel] [PATCH] socket: dont't free msgfds if error equals EAGAIN

2018-05-29 Thread linzhecheng
CC'ing Daniel P. Berrangé , Peter Xu, Marc-André Lureau, Eric Blake, Gonglei > -邮件原件- > 发件人: linzhecheng > 发送时间: 2018年5月29日 10:53 > 收件人: qemu-devel@nongnu.org > 抄送: pbonz...@redhat.com; wangxin (U) ; > linzhecheng > 主题: [PATCH] socket: dont't free msgfds if error equals EAGAIN > > Signed

Re: [Qemu-devel] [RFC v2 3/7] hw/intc/arm_gicv3: Introduce redist-region-count array property

2018-05-29 Thread Auger Eric
Hi Peter, On 05/22/2018 02:27 PM, Peter Maydell wrote: > On 13 May 2018 at 15:35, Eric Auger wrote: >> To prepare for multiple redistributor regions, we introduce >> an array of uint32_t properties that stores the redistributor >> count of each redistributor region. >> >> Non accelerated VGICv3 on

Re: [Qemu-devel] [PATCH] socket: dont't free msgfds if error equals EAGAIN

2018-05-29 Thread Marc-André Lureau
Hi On Tue, May 29, 2018 at 4:52 AM, linzhecheng wrote: > Signed-off-by: linzhecheng > > diff --git a/chardev/char-socket.c b/chardev/char-socket.c > index 159e69c3b1..17519ec589 100644 > --- a/chardev/char-socket.c > +++ b/chardev/char-socket.c > @@ -134,8 +134,8 @@ static int tcp_chr_write(Char

Re: [Qemu-devel] [RFC v2 3/7] hw/intc/arm_gicv3: Introduce redist-region-count array property

2018-05-29 Thread Peter Maydell
On 29 May 2018 at 10:08, Auger Eric wrote: > Hi Peter, > On 05/22/2018 02:27 PM, Peter Maydell wrote: >> On 13 May 2018 at 15:35, Eric Auger wrote: >>> To prepare for multiple redistributor regions, we introduce >>> an array of uint32_t properties that stores the redistributor >>> count of each r

Re: [Qemu-devel] storing machine data in qcow images?

2018-05-29 Thread Max Reitz
On 2018-05-28 21:09, Kevin Wolf wrote: > Am 28.05.2018 um 20:44 hat Max Reitz geschrieben: >> On 2018-05-28 20:38, Kevin Wolf wrote: >>> Am 28.05.2018 um 20:30 hat Richard W.M. Jones geschrieben: On Mon, May 28, 2018 at 08:10:32PM +0200, Max Reitz wrote: > As someone who is just naive and

Re: [Qemu-devel] [PATCH] memory: bug 1720969: Make operations using MemoryRegionIoeventfd struct pass by pointer.

2018-05-29 Thread Paolo Bonzini
On 29/05/2018 05:04, Tristan Burgess wrote: > This changes the functions memory_region_ioeventfd_equal, > memory_region_ioeventfd_before, and their callers, > to pass the MemoryRegionIoeventfd struct via pointer, instead of directly > passing the struct. This saves on stack space > and is conside

Re: [Qemu-devel] [PATCH v4 1/2] qemu-error: introduce {error|warn}_report_once

2018-05-29 Thread Cornelia Huck
On Thu, 24 May 2018 12:44:53 +0800 Peter Xu wrote: > There are many error_report()s that can be used in frequently called > functions, especially on IO paths. That can be unideal in that > malicious guest can try to trigger the error tons of time which might > use up the log space on the host (e

Re: [Qemu-devel] [PATCH] socket: dont't free msgfds if error equals EAGAIN

2018-05-29 Thread linzhecheng
I think this patch doesn't fix my issue. For more details, please see Gonglei's reply. https://lists.gnu.org/archive/html/qemu-devel/2018-05/msg06296.html > -邮件原件- > 发件人: Marc-André Lureau [mailto:marcandre.lur...@gmail.com] > 发送时间: 2018年5月29日 17:11 > 收件人: linzhecheng > 抄送: QEMU ; Paolo

Re: [Qemu-devel] [PATCH v3] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-29 Thread Paolo Bonzini
On 29/05/2018 09:31, Yi Min Zhao wrote: > If CONFIG_SECCOMP is undefined, the option 'elevateprivileges' remains > compiled. This would make libvirt set the corresponding capability and > then trigger failure during guest startup. This patch moves the code > regarding seccomp command line options t

Re: [Qemu-devel] [PATCH v3] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-29 Thread Eduardo Otubo
On 29/05/2018 - 15:31:40, Yi Min Zhao wrote: > If CONFIG_SECCOMP is undefined, the option 'elevateprivileges' remains > compiled. This would make libvirt set the corresponding capability and > then trigger failure during guest startup. This patch moves the code > regarding seccomp command line opti

Re: [Qemu-devel] [PATCH v3] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-29 Thread Yi Min Zhao
在 2018/5/29 下午5:37, Paolo Bonzini 写道: On 29/05/2018 09:31, Yi Min Zhao wrote: If CONFIG_SECCOMP is undefined, the option 'elevateprivileges' remains compiled. This would make libvirt set the corresponding capability and then trigger failure during guest startup. This patch moves the code rega

Re: [Qemu-devel] [PATCH v4 01/21] vfio: Include "exec/address-spaces.h" directly in the source file

2018-05-29 Thread Cornelia Huck
On Mon, 28 May 2018 21:36:31 -0300 Philippe Mathieu-Daudé wrote: > On 05/28/2018 09:06 PM, Michael S. Tsirkin wrote: > > On Mon, May 28, 2018 at 05:48:05PM -0600, Alex Williamson wrote: > >> On Mon, 28 May 2018 20:26:59 -0300 > >> Philippe Mathieu-Daudé wrote: > >> > >> -ENOCOMMITLOG > > Oo

Re: [Qemu-devel] [PATCH v3] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-29 Thread Yi Min Zhao
在 2018/5/29 下午5:39, Eduardo Otubo 写道: On 29/05/2018 - 15:31:40, Yi Min Zhao wrote: If CONFIG_SECCOMP is undefined, the option 'elevateprivileges' remains compiled. This would make libvirt set the corresponding capability and then trigger failure during guest startup. This patch moves the code

Re: [Qemu-devel] [PATCH v3] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-29 Thread Yi Min Zhao
在 2018/5/29 下午5:37, Paolo Bonzini 写道: On 29/05/2018 09:31, Yi Min Zhao wrote: If CONFIG_SECCOMP is undefined, the option 'elevateprivileges' remains compiled. This would make libvirt set the corresponding capability and then trigger failure during guest startup. This patch moves the code rega

Re: [Qemu-devel] [PATCH v4 03/21] target: Do not include "exec/address-spaces.h" if it is not necessary

2018-05-29 Thread Cornelia Huck
On Mon, 28 May 2018 20:27:01 -0300 Philippe Mathieu-Daudé wrote: > Code change produced with: > $ git grep '#include "exec/address-spaces.h"' target | \ > cut -d: -f-1 | \ > xargs egrep -L "(get_system_|address_space_)" | \ > xargs sed -i.bak '/#include "exec\/address-spaces

Re: [Qemu-devel] storing machine data in qcow images?

2018-05-29 Thread Max Reitz
On 2018-05-29 08:44, Kevin Wolf wrote: > Am 28.05.2018 um 23:25 hat Richard W.M. Jones geschrieben: >> On Mon, May 28, 2018 at 10:20:54PM +0100, Richard W.M. Jones wrote: >>> On Mon, May 28, 2018 at 08:38:33PM +0200, Kevin Wolf wrote: Just accessing the image file within a tar archive is possi

Re: [Qemu-devel] storing machine data in qcow images?

2018-05-29 Thread Kevin Wolf
Am 29.05.2018 um 11:23 hat Max Reitz geschrieben: > On 2018-05-28 21:09, Kevin Wolf wrote: > > Am 28.05.2018 um 20:44 hat Max Reitz geschrieben: > >> On 2018-05-28 20:38, Kevin Wolf wrote: > >>> Am 28.05.2018 um 20:30 hat Richard W.M. Jones geschrieben: > On Mon, May 28, 2018 at 08:10:32PM +02

Re: [Qemu-devel] [PATCH v3] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-29 Thread Paolo Bonzini
On 29/05/2018 11:53, Yi Min Zhao wrote: >>> >>> Yi Min >>> >> Acked-by: Eduardo Otubo >> >> > Thanks! I have included Paolo's squashing code. I'm not sure what I > should do next, sending a new version? No need, thanks! Paolo

Re: [Qemu-devel] [PATCH v4 12/21] hw: Do not include "sysemu/block-backend.h" if it is not necessary

2018-05-29 Thread Cornelia Huck
On Mon, 28 May 2018 20:27:10 -0300 Philippe Mathieu-Daudé wrote: > Remove those unneeded includes to speed up the compilation > process a little bit. (Continue 7eceff5b5a1fa cleanup) > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/collie.c | 1 - > hw/arm/gums

Re: [Qemu-devel] [PULL v4 0/4] Merge tpm 2018/05/23

2018-05-29 Thread Peter Maydell
On 26 May 2018 at 03:55, Stefan Berger wrote: > This series of patches adds TPM emulator state migration support and a > test case for testing (local) migration. > >Stefan > > The following changes since commit 4f50c1673a89b07f376ce5c42d22d79a79cd466d: > > Merge remote-tracking branch 'remot

[Qemu-devel] [PATCH] target/i386: Fixed CR0.TS check in gen_sse

2018-05-29 Thread Alexandro Sanchez Bach
The function `gen_sse` assumes all of its instructions require CR0.TS=0. However, integer extensions at `0F 38 F[0-F]` and `0F 3A F[0-F]` such as CRC32, MOVBE, ADX, BMI1, BMI2 that are handled by `gen_sse` are not supposed to throw an exception in this scenario. This causes issues while booting som

Re: [Qemu-devel] [PATCH 01/14] vdi: Fix vdi_co_do_create() return value

2018-05-29 Thread Max Reitz
On 2018-05-25 18:33, Kevin Wolf wrote: > .bdrv_co_create() is supposed to return 0 on success, but vdi could > return a positive value instead. Fix this. > > Signed-off-by: Kevin Wolf > --- > block/vdi.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Max Reitz signature.asc Descriptio

Re: [Qemu-devel] [PATCH 02/14] vhdx: Fix vhdx_co_create() return value

2018-05-29 Thread Max Reitz
On 2018-05-25 18:33, Kevin Wolf wrote: > .bdrv_co_create() is supposed to return 0 on success, but vhdx could > return a positive value instead. Fix this. > > Signed-off-by: Kevin Wolf > --- > block/vhdx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Max Reitz signat

Re: [Qemu-devel] [PATCH v4 01/21] vfio: Include "exec/address-spaces.h" directly in the source file

2018-05-29 Thread Paolo Bonzini
On 29/05/2018 11:53, Cornelia Huck wrote: > On Mon, 28 May 2018 21:36:31 -0300 > Philippe Mathieu-Daudé wrote: > >> On 05/28/2018 09:06 PM, Michael S. Tsirkin wrote: >>> On Mon, May 28, 2018 at 05:48:05PM -0600, Alex Williamson wrote: On Mon, 28 May 2018 20:26:59 -0300 Philippe Mathie

[Qemu-devel] [PULL v1 00/38] Xilinx queue

2018-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" The following changes since commit 5a5c383b1373aeb6c87a0d6060f6c3dc7c53082b: Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-2.13-pull-request' into staging (2018-05-25 10:04:36 +0100) are available in the git repository at: g...@github.com:edg

[Qemu-devel] [PULL v1 01/38] target-microblaze: dec_load: Use bool instead of unsigned int

2018-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Use bool instead of unsigned int to represent flags. No functional change. Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) d

[Qemu-devel] [PULL v1 05/38] target-microblaze: Correct special register array sizes

2018-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Correct special register array sizes. Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.h | 4 ++-- target/microblaze/translate.c | 5 ++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/target/microblaze

[Qemu-devel] [PULL v1 02/38] target-microblaze: dec_store: Use bool instead of unsigned int

2018-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Use bool instead of unsigned int to represent flags. Also, use extract32 instead of open coding the bit extract. No functional change. Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c |

[Qemu-devel] [PULL v1 06/38] target-microblaze: Correct the PVR array size

2018-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Correct the PVR array size, there are 13 PVR registers. Reviewed-by: Alistair Francis Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/microblaze/cpu.h b/target/microblaze/cpu.h in

[Qemu-devel] [PULL v1 10/38] target-microblaze: Bypass MMU with MMU_NOMMU_IDX

2018-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Bypass MMU translation when mmu-index MMU_NOMMU_IDX is used. Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/mic

[Qemu-devel] [PULL v1 03/38] target-microblaze: compute_ldst_addr: Use bool instead of int

2018-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Use bool instead of int to represent flags. No functional change. Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff -

[Qemu-devel] [PULL v1 13/38] target-microblaze: Use TCGv for load/store addresses

2018-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Use TCGv for load/store addresses, allowing for future computation of 64-bit load/store address. No functional change. Acked-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.h | 2 +- target/micro

[Qemu-devel] [PULL v1 08/38] target-microblaze: Remove USE_MMU PVR checks

2018-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" We already have a CPU property to control if a core has an MMU or not. Remove USE_MMU PVR checks in favor of looking at the property. Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/helper.c | 12 +-

[Qemu-devel] [PULL v1 04/38] target-microblaze: Fallback to our latest CPU version

2018-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Today, when running QEMU in linux-user or with boards that don't select a specific CPU version, we treat it as an invalid version and log a message. Instead, if no specific version was selected, fallback to our latest CPU version. Reviewed-by: Alistair Francis Signed-

[Qemu-devel] [PULL v1 17/38] target-microblaze: dec_msr: Use bool and extract32

2018-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Use bool and extract32 to represent the to, clr and clrset flags. No functional change. Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 15 +-- 1 file changed, 9 insertion

[Qemu-devel] [PULL v1 20/38] target-microblaze: Make special registers 64-bit

2018-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Extend special registers to 64-bits. This is in preparation for MFSE/MTSE, moves to and from extended special registers. Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- linux-user/microblaze/cpu_loop.c | 4 +- target/microblaze/cpu.h |

[Qemu-devel] [PULL v1 09/38] target-microblaze: Conditionalize setting of PVR11_USE_MMU

2018-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Conditionalize setting of PVR11_USE_MMU on the use_mmu CPU property, otherwise we may incorrectly advertise an MMU via PVR when the core in fact has none. Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microb

[Qemu-devel] [PULL v1 23/38] target-microblaze: Implement MFSE EAR

2018-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Implement MFSE EAR to enable access to the upper part of EAR. Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/target/microblaze/translate.c b

[Qemu-devel] [PULL v1 12/38] target-microblaze: Remove pointer indirection for ld/st addresses

2018-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/target/microblaze/translate.c b/target/micro

[Qemu-devel] [PULL v1 26/38] target-microblaze: mmu: Prepare for 64-bit addresses

2018-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Prepare for 64-bit addresses. This makes no functional difference as the upper parts of the 64-bit addresses are not yet reachable. Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/mmu.c | 14 +++--- target/microblaze/mmu.

[Qemu-devel] [PULL v1 14/38] target-microblaze: Name special registers we support

2018-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Name special registers we support. Reviewed-by: Alistair Francis Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c i

[Qemu-devel] [PULL v1 30/38] target-microblaze: Allow address sizes between 32 and 64 bits

2018-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Allow address sizes between 32 and 64 bits. Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/target/microblaze/cpu.c b/t

[Qemu-devel] [PULL v1 11/38] target-microblaze: Make compute_ldst_addr always use a temp

2018-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Make compute_ldst_addr always use a temp. This simplifies the code a bit in preparation for adding support for 64bit addresses. No functional change. Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Edgar E. Iglesias --- target/micr

[Qemu-devel] [PULL v1 35/38] target-microblaze: Convert env_btarget to i64

2018-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Convert env_btarget to i64. No functional change. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.h | 2 +- target/microblaze/op_helper.c | 2 +- target/microblaze/translate.c | 36

[Qemu-devel] [PATCH resend v2] qga: unset frozen state if no mount points are frozen

2018-05-29 Thread Chen Hanxiao
From: Chen Hanxiao If we set mountpoints to qmp_guest_fsfreeze_freeze_list, we may got nothing to freeze as all mountpoints are not valid. So call ga_unset_frozen in this senario. Also, if we return 0 frozen fs, there is no need to call guest-fsfreeze-thaw. Cc: Michael Roth Signed-off-by: Chen

[Qemu-devel] [PULL v1 07/38] target-microblaze: Tighten up TCGv_i32 vs TCGv type usage

2018-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Tighten up TCGv_i32 vs TCGv type usage. Avoid using TCGv when TCGv_i32 should be used. This is in preparation for adding 64bit addressing support. No functional change. Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias ---

[Qemu-devel] [PULL v1 21/38] target-microblaze: Setup for 64bit addressing

2018-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Setup MicroBlaze builds for 64bit addressing. No functional change since the translator does not yet emit 64bit addresses. Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- configure | 1 + target/microblaze/cpu.h | 6 +++--- 2 files c

[Qemu-devel] [PULL v1 33/38] target-microblaze: Use table based condition-codes conversion

2018-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Use a table based conversion to map condition-codes between MicroBlaze ISA encoding and TCG. No functional change. Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 41 - 1 file

[Qemu-devel] [PULL v1 27/38] target-microblaze: mmu: Add a configurable output address mask

2018-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add a configurable output address mask, used to mimic the configurable physical address bit width. Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 1 + target/microblaze/mmu.c | 1 + target/

[Qemu-devel] [PULL v1 15/38] target-microblaze: Break out trap_userspace()

2018-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Break out trap_userspace() to avoid open coding it everywhere. For privileged insns, we now always stop translation of the current insn for cores without exceptions. Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Edgar E. Iglesias -

Re: [Qemu-devel] [Qemu-arm] [PATCH v1 2/2] xlnx-zynqmp: Swap Cortex-R5 for Cortex-R5F

2018-05-29 Thread Edgar E. Iglesias
On Thu, May 10, 2018 at 03:09:46PM -0300, Philippe Mathieu-Daudé wrote: > Hi Edgar, > > On 05/03/2018 08:56 AM, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > The ZynqMP has Cortex-R5Fs with the optional FPU enabled. > > What about updating the xlnx-zcu102 machine description to

[Qemu-devel] [PULL v1 16/38] target-microblaze: Break out trap_illegal()

2018-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Break out trap_illegal() to handle illegal operation traps. We now generally stop translation of the current insn if it's not valid. Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c

[Qemu-devel] [PULL v1 29/38] target-microblaze: Add support for extended access to TLBLO

2018-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add support for extended access to TLBLO's upper 32 bits. Reviewed-by: Alistair Francis Signed-off-by: Edgar E. Iglesias --- target/microblaze/helper.h| 4 ++-- target/microblaze/mmu.c | 18 ++ target/microblaze/mmu.h | 4 ++-- targe

[Qemu-devel] [PULL v1 18/38] target-microblaze: dec_msr: Reuse more code when reg-decoding

2018-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Reuse more code when decoding register numbers. No functional changes. Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 38 +- 1 file changed, 9 ins

[Qemu-devel] [PULL v1 31/38] target-microblaze: Simplify address computation using tcg_gen_addi_i32()

2018-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Simplify address computation using tcg_gen_addi_i32(). tcg_gen_addi_i32() already optimizes the case when the immediate is zero. No functional change. Suggested-by: Richard Henderson Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: E

[Qemu-devel] [PULL v1 36/38] target-microblaze: Use tcg_gen_movcond in eval_cond_jmp

2018-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Cleanup eval_cond_jmp to use tcg_gen_movcond_i64(). No functional change. Suggested-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 16 ++-- 1

[Qemu-devel] [PULL v1 19/38] target-microblaze: dec_msr: Fix MTS to FSR

2018-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Fix moves to FSR. Not only bit 31 is accessible. Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target/microblaze/

[Qemu-devel] [PULL v1 24/38] target-microblaze: mmu: Add R_TBLX_MISS macros

2018-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add a R_TBLX_MISS MASK and SHIFT macros. Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/mmu.c | 5 +++-- target/microblaze/mmu.h | 4 2 files changed, 7 insertions(+), 2 deletions(-) diff --g

[Qemu-devel] [PULL v1 38/38] target-microblaze: Consolidate MMU enabled checks

2018-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Consolidate MMU enabled checks to cpu_mmu_index(). No functional changes. Suggested-by: Richard Henderson Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.h| 4 +++- target/microblaze/helper

[Qemu-devel] [PULL v1 25/38] target-microblaze: mmu: Remove unused register state

2018-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add explicit handling for MMU_R_TLBX and log accesses to invalid MMU registers. We can now remove the state for all regs but PID, ZPR and TLBX (0 - 2). Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Edgar E. Iglesias --- target/mic

Re: [Qemu-devel] [PATCH v4 14/21] hw: Do not include "sysemu/blockdev.h" if it is not necessary

2018-05-29 Thread Cornelia Huck
On Mon, 28 May 2018 20:27:12 -0300 Philippe Mathieu-Daudé wrote: > Remove those unneeded includes to speed up the compilation > process a little bit. > > Code change produced with: > > $ git grep '#include "sysemu/blockdev.h"' | \ > cut -d: -f-1 | \ > xargs egrep -L > "(BlockIn

[Qemu-devel] [PULL v1 28/38] target-microblaze: dec_msr: Plug a temp leak

2018-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Plug a temp leak. Reported-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/target/microblaze/translate.c b/

[Qemu-devel] [PULL v1 32/38] target-microblaze: mmu: Cleanup debug log messages

2018-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Cleanup debug log messages: * Avoid long 80+ character lines. * Remove D() macro and use qemu_log_mask. * Remove logs that are not very useful Suggested-by: Alistair Francis Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Signed-off-by: Edgar E. Iglesias

[Qemu-devel] [PULL v1 34/38] target-microblaze: Remove argument b in eval_cc()

2018-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Remove argument b in eval_cc() as it is always set to zero. No functional change. Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/microb

[Qemu-devel] [PULL v1 37/38] target-microblaze: cpu_mmu_index: Fixup indentation

2018-05-29 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Fixup the indentation of cpu_mmu_index in preparation for future edits. No functional changes. Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.h | 16 +--- 1 file changed, 9 insertio

Re: [Qemu-devel] [PATCH 03/14] job: Add error message for failing jobs

2018-05-29 Thread Max Reitz
On 2018-05-25 18:33, Kevin Wolf wrote: > So far we relied on job->ret and strerror() to produce an error message > for failed jobs. Not surprisingly, this tends to result in completely > useless messages. > > This adds a Job.error field that can contain an error string for a > failing job, and a p

Re: [Qemu-devel] [PATCH v4 18/21] hw/hppa: Remove unused include

2018-05-29 Thread Thomas Huth
On 29.05.2018 01:27, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/hppa/hppa_sys.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/hppa/hppa_sys.h b/hw/hppa/hppa_sys.h > index a182d1f34e..3f6c145120 100644 > --- a/hw/hppa/hppa_sys.h > +++ b/hw/hppa/h

Re: [Qemu-devel] [PATCH v4 20/21] hw/ide: Remove unused include

2018-05-29 Thread Thomas Huth
On 29.05.2018 01:27, Philippe Mathieu-Daudé wrote: > There is no need to include pci.h in this file. > (Continue f23c81073a cleanup). > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/ide/core.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/ide/core.c b/hw/ide/core.c > index 866

Re: [Qemu-devel] [PATCH 04/14] block/create: Make x-blockdev-create a job

2018-05-29 Thread Max Reitz
On 2018-05-25 18:33, Kevin Wolf wrote: > This changes the x-blockdev-create QMP command so that it doesn't block > the monitor and the main loop any more, but starts a background job that > performs the image creation. > > The basic job as implemented here is all that is necessary to make image >

Re: [Qemu-devel] [PATCH v4 09/21] target: Do not include "exec/exec-all.h" if it is not necessary

2018-05-29 Thread Cornelia Huck
On Mon, 28 May 2018 20:27:07 -0300 Philippe Mathieu-Daudé wrote: > Code change produced with: > $ git grep '#include "exec/exec-all.h"' | \ > cut -d: -f-1 | \ > xargs egrep -L > "(cpu_address_space_init|cpu_loop_|tlb_|tb_|GETPC|singlestep|TranslationBlock)" > | \ Hm, does this

Re: [Qemu-devel] [PATCH 05/14] qemu-iotests: Add VM.get_qmp_events_filtered()

2018-05-29 Thread Max Reitz
On 2018-05-25 18:33, Kevin Wolf wrote: > This adds a helper function that returns a list of QMP events that are > already filtered through filter_qmp_event(). > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/iotests.py | 5 + > 1 file changed, 5 insertions(+) Reviewed-by: Max Reitz

Re: [Qemu-devel] [PATCH 06/14] qemu-iotests: Add VM.qmp_log()

2018-05-29 Thread Max Reitz
On 2018-05-25 18:33, Kevin Wolf wrote: > This adds a helper function that logs both the QMP request and the > received response before returning it. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/iotests.py | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/tests/qe

Re: [Qemu-devel] [PATCH 07/14] qemu-iotests: Add iotests.img_info_log()

2018-05-29 Thread Max Reitz
On 2018-05-25 18:33, Kevin Wolf wrote: > This adds a filter function to postprocess 'qemu-img info' input > (similar to what _img_info does), and an img_info_log() function that > calls 'qemu-img info' and logs the filtered output. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/iotests

Re: [Qemu-devel] [Qemu-block] [PATCH v2 21/40] job: Convert block_job_cancel_async() to Job

2018-05-29 Thread Kashyap Chamarthy
On Fri, May 25, 2018 at 10:00:35AM +0200, Kevin Wolf wrote: > Am 24.05.2018 um 19:42 hat John Snow geschrieben: [...] (Randomly chiming in for a small clarification.) > > >> or some other mechanism that accomplishes the same type of behavior. It > > >> would be nice if it did not have to be dete

Re: [Qemu-devel] [PATCH 0/5] Make the next release be 3.0

2018-05-29 Thread Peter Maydell
On 22 May 2018 at 11:39, Peter Maydell wrote: > I think that we should number the next release 3.0 > (3.0.0, in long form). We already have a few places that > have used "2.13", in machine-versions or in "feature > exists since release X" annotations; update those. > > thanks > -- PMM > > Peter Ma

Re: [Qemu-devel] [PATCH 06/14] qemu-iotests: Add VM.qmp_log()

2018-05-29 Thread Kevin Wolf
Am 29.05.2018 um 13:48 hat Max Reitz geschrieben: > On 2018-05-25 18:33, Kevin Wolf wrote: > > This adds a helper function that logs both the QMP request and the > > received response before returning it. > > > > Signed-off-by: Kevin Wolf > > --- > > tests/qemu-iotests/iotests.py | 11 ++

Re: [Qemu-devel] [PATCH 06/14] qemu-iotests: Add VM.qmp_log()

2018-05-29 Thread Max Reitz
On 2018-05-29 14:12, Kevin Wolf wrote: > Am 29.05.2018 um 13:48 hat Max Reitz geschrieben: >> On 2018-05-25 18:33, Kevin Wolf wrote: >>> This adds a helper function that logs both the QMP request and the >>> received response before returning it. >>> >>> Signed-off-by: Kevin Wolf >>> --- >>> test

Re: [Qemu-devel] [PATCH 08/14] qemu-iotests: Rewrite 206 for blockdev-create job

2018-05-29 Thread Max Reitz
On 2018-05-25 18:33, Kevin Wolf wrote: > This rewrites the test case 206 to work with the new x-blockdev-create > job rather than the old synchronous version of the command. > > All of the test cases stay the same as before, but in order to be able > to implement proper job handling, the test case

Re: [Qemu-devel] [Qemu-block] [PATCH v2 21/40] job: Convert block_job_cancel_async() to Job

2018-05-29 Thread Max Reitz
On 2018-05-29 13:59, Kashyap Chamarthy wrote: > On Fri, May 25, 2018 at 10:00:35AM +0200, Kevin Wolf wrote: >> Am 24.05.2018 um 19:42 hat John Snow geschrieben: > > [...] > > (Randomly chiming in for a small clarification.) > > or some other mechanism that accomplishes the same type of behav

[Qemu-devel] Live viewing qemu running image

2018-05-29 Thread Olga Levy
Hi, Nice to meet you. I'm a new security engineer and working on a prototype using QEMU. What I need is to collect running image internal data (like running processes, netstat, files modification, etc.) but without running any process inside. I mean, doing it from "outside" (I need Qemu support).

[Qemu-devel] [PATCH] qemu: Emit RESET event with -no-reboot option

2018-05-29 Thread Christian Ludwig
When -no-reboot is given on the command line, qemu quits when the guest finishes a system reboot operation. This is done by indicating that the system should shut down, rather than reset. A user who observes QMP events only sees a SHUTDOWN event and thus cannot distinguish whether the guest initiat

Re: [Qemu-devel] [Qemu-arm] [PATCH 0/6] ftgmac100 and NC-SI enhancements for the Aspeed SoC

2018-05-29 Thread Philippe Mathieu-Daudé
Hi Cédric, On 05/29/2018 03:28 AM, Cédric Le Goater wrote: > Hello, > > Here is a couple of enhancements and fixes for the ftgmac100 NIC used > on the Aspeed SoC. It includes VLAN and multicast support. > > Following is an assorted set of changes for the NC-SI backend also > used on the Aspeed S

Re: [Qemu-devel] [PATCH 3/6] net/ftgmac100: fix multicast hash routine

2018-05-29 Thread Philippe Mathieu-Daudé
On 05/29/2018 03:28 AM, Cédric Le Goater wrote: > Based on the multicast hash calculation of the FTGMAC100 Linux driver. > > Signed-off-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé > --- > hw/net/ftgmac100.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --g

Re: [Qemu-devel] [PATCH 06/14] qemu-iotests: Add VM.qmp_log()

2018-05-29 Thread Kevin Wolf
Am 29.05.2018 um 14:15 hat Max Reitz geschrieben: > On 2018-05-29 14:12, Kevin Wolf wrote: > > Am 29.05.2018 um 13:48 hat Max Reitz geschrieben: > >> On 2018-05-25 18:33, Kevin Wolf wrote: > >>> This adds a helper function that logs both the QMP request and the > >>> received response before return

Re: [Qemu-devel] [PATCH] qemu: Emit RESET event with -no-reboot option

2018-05-29 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180529055312.29633-1-christian_lud...@genua.de Subject: [Qemu-devel] [PATCH] qemu: Emit

Re: [Qemu-devel] [PATCH 06/14] qemu-iotests: Add VM.qmp_log()

2018-05-29 Thread Max Reitz
On 2018-05-29 14:39, Kevin Wolf wrote: > Am 29.05.2018 um 14:15 hat Max Reitz geschrieben: >> On 2018-05-29 14:12, Kevin Wolf wrote: >>> Am 29.05.2018 um 13:48 hat Max Reitz geschrieben: On 2018-05-25 18:33, Kevin Wolf wrote: > This adds a helper function that logs both the QMP request and

Re: [Qemu-devel] [PATCH 4/6] slirp/ncsi: fix "Get Version ID" payload length

2018-05-29 Thread Philippe Mathieu-Daudé
On 05/29/2018 03:28 AM, Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater > --- > slirp/ncsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/slirp/ncsi.c b/slirp/ncsi.c > index d12ba3e494b0..02d0e9def3e8 100644 > --- a/slirp/ncsi.c > +++ b/slirp/ncsi.c > @@ -60

Re: [Qemu-devel] [PATCH 09/14] qemu-iotests: Rewrite 207 for blockdev-create job

2018-05-29 Thread Max Reitz
On 2018-05-25 18:33, Kevin Wolf wrote: > This rewrites the test case 207 to work with the new x-blockdev-create > job rather than the old synchronous version of the command. > > Most of the test cases stay the same as before (the exception being some > improved 'size' options that allow distinguis

  1   2   3   4   >