[Qemu-devel] [PATCH v3 16/19] gdbstub: add reverse step support in replay mode

2018-05-23 Thread Pavel Dovgalyuk
GDB remote protocol supports two reverse debugging commands: reverse step and reverse continue. This patch adds support of the first one to the gdbstub. Reverse step is intended to step one instruction in the backwards direction. This is not possible in regular execution. But replayed execution is

[Qemu-devel] [PATCH v3 14/19] translator: fix breakpoint processing

2018-05-23 Thread Pavel Dovgalyuk
QEMU cannot pass through the breakpoints when 'si' command is used in remote gdb. This patch disables inserting the breakpoints when we are already single stepping though the gdb remote protocol. This patch also fixes icount calculation for the blocks that include breakpoints - instruction with bre

[Qemu-devel] [PATCH v3 13/19] replay: refine replay-time module

2018-05-23 Thread Pavel Dovgalyuk
This patch removes refactoring artifacts from the replay/replay-time.c Signed-off-by: Pavel Dovgalyuk --- replay/replay-time.c | 27 ++- 1 file changed, 10 insertions(+), 17 deletions(-) diff --git a/replay/replay-time.c b/replay/replay-time.c index 6a7565e..40030b8 10

[Qemu-devel] [PATCH v3 17/19] gdbstub: add reverse continue support in replay mode

2018-05-23 Thread Pavel Dovgalyuk
This patch adds support of the reverse continue operation for gdbstub. Reverse continue finds the last breakpoint that would happen in normal execution from the beginning to the current moment. Implementation of the reverse continue replays the execution twice: to find the breakpoints that were hit

[Qemu-devel] [PATCH v3 19/19] replay: allow loading any snapshots before recording

2018-05-23 Thread Pavel Dovgalyuk
This patch enables using -loadvm in recording mode to allow starting the execution recording from any of the available snapshots. It also fixes loading of the record/replay state, therefore snapshots created in replay mode may also be used for starting the new recording. Signed-off-by: Pavel Dovga

[Qemu-devel] [PATCH v3 15/19] replay: flush rr queue before loading the vmstate

2018-05-23 Thread Pavel Dovgalyuk
Non-empty record/replay queue prevents saving and loading the VM state, because it includes pending bottom halves and block coroutines. But when the new VM state is loaded, we don't have to preserve the consistency of the current state anymore. Therefore this patch just flushes the queue allowing t

[Qemu-devel] [PATCH v3 18/19] replay: describe reverse debugging in docs/replay.txt

2018-05-23 Thread Pavel Dovgalyuk
This patch updates the documentation and describes usage of the reverse debugging in QEMU+GDB. Signed-off-by: Pavel Dovgalyuk --- docs/replay.txt | 33 + 1 file changed, 33 insertions(+) diff --git a/docs/replay.txt b/docs/replay.txt index f7def53..086d3f8 1006

Re: [Qemu-devel] [RFC 3/3] acpi-build: allocate mcfg for multiple host bridges

2018-05-23 Thread Laszlo Ersek
On 05/23/18 01:40, Michael S. Tsirkin wrote: > On Wed, May 23, 2018 at 12:42:09AM +0200, Laszlo Ersek wrote: >> Hold on, >> >> On 05/22/18 21:51, Laszlo Ersek wrote: >> >>> It had taken years until the edk2 core gained a universal >>> PciHostBridgeDxe driver with a well-defined platform customizati

Re: [Qemu-devel] [PULL 05/21] arm/boot: split load_dtb() from arm_load_kernel()

2018-05-23 Thread Auger Eric
Hi, On 05/10/2018 07:45 PM, Peter Maydell wrote: > From: Igor Mammedov > > load_dtb() depends on arm_load_kernel() to figure out place > in RAM where it should be loaded, but it's not required for > arm_load_kernel() to work. Sometimes it's neccesary for > devices added with -device/device_add t

Re: [Qemu-devel] [PATCH v2 1/1] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-23 Thread Ján Tomko
On Sat, May 19, 2018 at 04:20:37PM +0800, Yi Min Zhao wrote: 在 2018/5/18 下午9:07, Ján Tomko 写道: On Fri, May 18, 2018 at 11:19:16AM +0200, Eduardo Otubo wrote: On 18/05/2018 - 09:52:12, Ján Tomko wrote: But now libvirt requires QEMU >= 1.5.0 which already supports query-command-line-options, s

Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread

2018-05-23 Thread Markus Armbruster
Peter Xu writes: > In the future the monitor iothread may be accessing the cur_mon as > well (via monitor_qmp_dispatch_one()). Before we introduce a real > Out-Of-Band command, Uh, inhowfar are the commands marked allow-oob: true now not real? These are migrate-recover, migrate-pause, x-oob-tes

Re: [Qemu-devel] [PATCH v5 3/4] monitor: more comments on lock-free fleids/funcs

2018-05-23 Thread Markus Armbruster
Peter Xu writes: > On Thu, May 17, 2018 at 02:46:36PM +0200, Markus Armbruster wrote: >> Peter Xu writes: >> >> > Add some explicit comment for both Readline and cpu_set/cpu_get helpers >> > that they do not need the mon_lock protection. >> >> Appreciated! >> >> > Signed-off-by: Peter Xu >>

Re: [Qemu-devel] [PATCH v2] tests/docker/Makefile.include: handle empty TARGET_LIST

2018-05-23 Thread Fam Zheng
On Mon, 05/21 11:35, Alex Bennée wrote: > If the user doesn't specify a TARGET_LIST they get the current > configuration but with spaces and hilarity ensues. This adds some make > magic to turn the TARGET_LIST back into a comma separated list. > > Signed-off-by: Alex Bennée Queued, thanks! Fam

Re: [Qemu-devel] [PATCH 0/4] target/xtensa: Convert to TranslatorOps

2018-05-23 Thread Max Filippov
On Tue, May 22, 2018 at 1:58 PM, Richard Henderson wrote: > On 05/22/2018 02:39 AM, Max Filippov wrote: >> Would you like to do that change and carry the series yourself >> or should I take it? > > Would you take it, please. Sure. -- Thanks. -- Max

Re: [Qemu-devel] [PATCH v5 4/4] monitor: add lock to protect mon_fdsets

2018-05-23 Thread Markus Armbruster
Peter Xu writes: > On Fri, May 18, 2018 at 02:27:00PM +0200, Markus Armbruster wrote: >> Peter Xu writes: >> >> > On Thu, May 17, 2018 at 03:03:02PM +0200, Markus Armbruster wrote: >> > >> > [...] >> > >> >> > @@ -2502,7 +2525,9 @@ int monitor_fdset_get_fd(int64_t fdset_id, int >> >> > flags)

Re: [Qemu-devel] [PATCH v5 3/4] monitor: more comments on lock-free fleids/funcs

2018-05-23 Thread Peter Xu
On Wed, May 23, 2018 at 10:29:37AM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > On Thu, May 17, 2018 at 02:46:36PM +0200, Markus Armbruster wrote: > >> Peter Xu writes: > >> > >> > Add some explicit comment for both Readline and cpu_set/cpu_get helpers > >> > that they do not need t

Re: [Qemu-devel] [PATCH v5 4/4] monitor: add lock to protect mon_fdsets

2018-05-23 Thread Peter Xu
On Wed, May 23, 2018 at 10:39:20AM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > On Fri, May 18, 2018 at 02:27:00PM +0200, Markus Armbruster wrote: > >> Peter Xu writes: > >> > >> > On Thu, May 17, 2018 at 03:03:02PM +0200, Markus Armbruster wrote: > >> > > >> > [...] > >> > > >> >>

Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread

2018-05-23 Thread Peter Xu
On Wed, May 23, 2018 at 10:23:22AM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > In the future the monitor iothread may be accessing the cur_mon as > > well (via monitor_qmp_dispatch_one()). Before we introduce a real > > Out-Of-Band command, > > Uh, inhowfar are the commands marked

Re: [Qemu-devel] [PATCH 15/27] iommu: Add IOMMU index argument to notifier APIs

2018-05-23 Thread Alex Bennée
Peter Maydell writes: > Add support for multiple IOMMU indexes to the IOMMU notifier APIs. > When initializing a notifier with iommu_notifier_init(), the caller > must pass the IOMMU index that it is interested in. When a change > happens, the IOMMU implementation must pass > memory_region_notif

Re: [Qemu-devel] [PATCH 16/27] iommu: Add IOMMU index argument to translate method

2018-05-23 Thread Alex Bennée
Peter Maydell writes: > Add an IOMMU index argument to the translate method of > IOMMUs. Since all of our current IOMMU implementations > support only a single IOMMU index, this has no effect > on the behaviour. > > Signed-off-by: Peter Maydell Modulo comment about signed indexes in previous c

Re: [Qemu-devel] [PATCH] Correct CPACR reset value for v7 cores

2018-05-23 Thread Cédric Le Goater
On 05/22/2018 09:26 PM, Peter Maydell wrote: > On 22 May 2018 at 20:06, Cédric Le Goater wrote: >> On 05/22/2018 07:37 PM, Peter Maydell wrote: >>> This is sufficient that a save-and-reload while the romulus-bmc >>> machine is in the bootloader will work. On the other hand if >>> I do a save-and-r

[Qemu-devel] [PATCH] migration: fix exec/fd migrations

2018-05-23 Thread Juan Quintela
Commit: commit 36c2f8be2c4eb0003ac77a14910842b7ddd7337e Author: Juan Quintela Date: Wed Mar 7 08:40:52 2018 +0100 migration: Delay start of migration main routines Missed tcp and fd transports. This fix its. Reported-by: Kevin Wolf Signed-off-by: Juan Quintela --- migration/exec.c |

Re: [Qemu-devel] storing machine data in qcow images?

2018-05-23 Thread Kevin Wolf
Am 23.05.2018 um 04:12 hat Fam Zheng geschrieben: > On Tue, 05/22 17:02, Kevin Wolf wrote: > > Am 22.05.2018 um 16:19 hat Michael S. Tsirkin geschrieben: > > > On Tue, May 22, 2018 at 09:35:55AM +0200, Gerd Hoffmann wrote: > > > > Hi, > > > > > > > > > You must /sometimes/ supply the correct mac

Re: [Qemu-devel] [PATCH v7 1/3] qmp: adding 'wakeup-suspend-support' in query-target

2018-05-23 Thread Markus Armbruster
Eduardo Habkost writes: > On Mon, May 21, 2018 at 04:46:36PM -0300, Daniel Henrique Barboza wrote: >> >> >> On 05/21/2018 03:14 PM, Eduardo Habkost wrote: >> > > Issue#2: the flag isn't a property of the target. Due to -no-acpi, it's >> > > not even a property of the machine type. If it was,

Re: [Qemu-devel] [PATCH v2 1/1] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-23 Thread Yi Min Zhao
在 2018/5/23 下午3:47, Ján Tomko 写道: On Sat, May 19, 2018 at 04:20:37PM +0800, Yi Min Zhao wrote: 在 2018/5/18 下午9:07, Ján Tomko 写道: On Fri, May 18, 2018 at 11:19:16AM +0200, Eduardo Otubo wrote: On 18/05/2018 - 09:52:12, Ján Tomko wrote: But now libvirt requires QEMU >= 1.5.0 which already s

Re: [Qemu-devel] [PATCH] nbd/server: fix trace

2018-05-23 Thread Vladimir Sementsov-Ogievskiy
will resend with "NBD export bitmaps" series v3 22.05.2018 16:41, Vladimir Sementsov-Ogievskiy wrote: Return code = 1 doesn't mean that we parsed base:allocation. Move trace point to appropriate place. Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/server.c | 7 +-- 1 file changed,

Re: [Qemu-devel] [PATCH v2 1/1] tests/docker: Add a Avocado Docker test

2018-05-23 Thread Lucas Meneghel Rodrigues
Me and Cleber were talking about running avocado in containers, and we verified there are some things we need to fix in avocado to make it work well under container environments. One of the main offenders is our service manager library, that was created to deal with sysvinit and systemd, but Docker

Re: [Qemu-devel] [PATCH v2 1/2] vfio-ccw: add force unlimited prefetch property

2018-05-23 Thread Cornelia Huck
On Wed, 23 May 2018 00:16:54 +0200 Halil Pasic wrote: > There is at least one guest (OS) such that although it does not rely on > the guarantees provided by ORB 1 word 9 bit (aka unlimited prefetch, aka > P bit) not being set, it fails to tell this to the machine. > > Usually this ain't a big de

Re: [Qemu-devel] [PATCH 17/27] exec.c: Handle IOMMUs in address_space_translate_for_iotlb()

2018-05-23 Thread Alex Bennée
Peter Maydell writes: > Currently we don't support board configurations that put an IOMMU > in the path of the CPU's memory transactions, and instead just > assert() if the memory region fonud in address_space_translate_for_iotlb() > is an IOMMUMemoryRegion. > > Remove this limitation by having

[Qemu-devel] [PATCH 2/2] qemu-iotests: Remove MIG_SOCKET from non-migration tests

2018-05-23 Thread Kevin Wolf
185 and 191 define a MIG_SOCKET even though they don't do anything with migration. Remove the useless variable. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/185 | 2 -- tests/qemu-iotests/191 | 2 -- 2 files changed, 4 deletions(-) diff --git a/tests/qemu-iotests/185 b/tests/qemu-iotests/18

[Qemu-devel] [PATCH 0/2] qemu-iotests: Add more tests to "migration" group

2018-05-23 Thread Kevin Wolf
Kevin Wolf (2): qemu-iotests: Add more tests to "migration" group qemu-iotests: Remove MIG_SOCKET from non-migration tests tests/qemu-iotests/185 | 2 -- tests/qemu-iotests/191 | 2 -- tests/qemu-iotests/group | 10 +- 3 files changed, 5 insertions(+), 9 deletions(-) -- 2.13.6

[Qemu-devel] [PATCH 1/2] qemu-iotests: Add more tests to "migration" group

2018-05-23 Thread Kevin Wolf
grep for "migrate" turns up a few test cases which use migration, but haven't been in the "migration" group so far. Add them to the group. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/group | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/qemu-iotests/grou

Re: [Qemu-devel] [PATCH] migration: fix exec/fd migrations

2018-05-23 Thread Kevin Wolf
Am 23.05.2018 um 11:14 hat Juan Quintela geschrieben: > Commit: > > commit 36c2f8be2c4eb0003ac77a14910842b7ddd7337e > Author: Juan Quintela > Date: Wed Mar 7 08:40:52 2018 +0100 > > migration: Delay start of migration main routines > > Missed tcp and fd transports. This fix its. > > Rep

Re: [Qemu-devel] [PATCH v3 03/35] ppc/xive: introduce the XiveFabric interface

2018-05-23 Thread Cédric Le Goater
On 05/03/2018 07:13 AM, David Gibson wrote: > On Wed, May 02, 2018 at 05:28:23PM +0200, Cédric Le Goater wrote: >> On 04/27/2018 08:32 AM, David Gibson wrote: >>> On Thu, Apr 26, 2018 at 12:30:42PM +0200, Cédric Le Goater wrote: On 04/26/2018 05:54 AM, David Gibson wrote: > On Tue, Apr 24,

Re: [Qemu-devel] [PATCH v2 1/1] tests/docker: Add a Avocado Docker test

2018-05-23 Thread Cleber Rosa
On 05/23/2018 05:35 AM, Lucas Meneghel Rodrigues wrote: > Me and Cleber were talking about running avocado in containers, and we > verified there are some things we need to fix in avocado to make it > work well under container environments. One of the main offenders is > our service manager library

[Qemu-devel] [PATCH] arm: fix qemu crash on startup with -bios option

2018-05-23 Thread Igor Mammedov
When QEMU is started with following CLI -machine virt,gic-version=3,accel=kvm -cpu host -bios AAVMF_CODE.fd it crashes with abort at accel/kvm/kvm-all.c:2164: KVM_SET_DEVICE_ATTR failed: Group 6 attr 0xc665: Invalid argument Which is caused by implicit dependecy of kvm_arm_gicv3_res

Re: [Qemu-devel] [PATCH 1/2] qemu-iotests: Add more tests to "migration" group

2018-05-23 Thread Juan Quintela
Kevin Wolf wrote: > grep for "migrate" turns up a few test cases which use migration, but > haven't been in the "migration" group so far. Add them to the group. > > Signed-off-by: Kevin Wolf Reviewed-by: Juan Quintela Thanks

Re: [Qemu-devel] [PULL 05/21] arm/boot: split load_dtb() from arm_load_kernel()

2018-05-23 Thread Igor Mammedov
On Wed, 23 May 2018 09:38:33 +0200 Auger Eric wrote: > Hi, > > On 05/10/2018 07:45 PM, Peter Maydell wrote: > > From: Igor Mammedov > > > > load_dtb() depends on arm_load_kernel() to figure out place > > in RAM where it should be loaded, but it's not required for > > arm_load_kernel() to work.

[Qemu-devel] [PATCH v3 1/5] nbd/server: fix trace

2018-05-23 Thread Vladimir Sementsov-Ogievskiy
Return code = 1 doesn't mean that we parsed base:allocation. Move trace point to appropriate place. Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/server.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/nbd/server.c b/nbd/server.c index 9e1f227178..7584ff7dcc 100

[Qemu-devel] [Bug 1353947] Re: Hypervisor with QEMU-2.0/libvirtd 1.2.2 stack when launching VM with CirrOS or Ubuntu 12.04

2018-05-23 Thread Thomas Huth
** Changed in: linux (Ubuntu) Status: Confirmed => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1353947 Title: Hypervisor with QEMU-2.0/libvirtd 1.2.2 stack when launching VM wit

[Qemu-devel] [PATCH v3 5/5] docs/interop: add nbd.txt

2018-05-23 Thread Vladimir Sementsov-Ogievskiy
Describe new metadata namespace: "qemu". Signed-off-by: Vladimir Sementsov-Ogievskiy --- docs/interop/nbd.txt | 37 + MAINTAINERS | 1 + 2 files changed, 38 insertions(+) create mode 100644 docs/interop/nbd.txt diff --git a/docs/interop/nbd.txt b/d

[Qemu-devel] [PATCH v3 2/5] nbd/server: add nbd_meta_empty_or_pattern helper

2018-05-23 Thread Vladimir Sementsov-Ogievskiy
Add nbd_meta_pattern() and nbd_meta_empty_or_pattern() helpers for metadata query parsing. nbd_meta_pattern() will be reused for "qemu" namespace in following patches. Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/server.c | 82 ++--

[Qemu-devel] [PATCH v3 0/5] NBD export bitmaps

2018-05-23 Thread Vladimir Sementsov-Ogievskiy
Hi all. This is a proposal and realization of new NBD meta context: qemu. (I hope to send corresponding proposal to NBD protocol soon) New possible queries will look like: qemu:dirty-bitmap: Mapping from export-bitmap-name to BdrvDirtyBitmap is done through qmp command nbd-server-add-bitmap. For

Re: [Qemu-devel] [PATCH v2 1/1] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-23 Thread Eduardo Otubo
On 05/23/2018 11:16 AM, Yi Min Zhao wrote: 在 2018/5/23 下午3:47, Ján Tomko 写道: On Sat, May 19, 2018 at 04:20:37PM +0800, Yi Min Zhao wrote: 在 2018/5/18 下午9:07, Ján Tomko 写道: On Fri, May 18, 2018 at 11:19:16AM +0200, Eduardo Otubo wrote: On 18/05/2018 - 09:52:12, Ján Tomko wrote: But now li

Re: [Qemu-devel] [PATCH 2/2] qemu-iotests: Remove MIG_SOCKET from non-migration tests

2018-05-23 Thread Juan Quintela
Kevin Wolf wrote: > 185 and 191 define a MIG_SOCKET even though they don't do anything with > migration. Remove the useless variable. > > Signed-off-by: Kevin Wolf Reviewed-by: Juan Quintela

[Qemu-devel] [PATCH v3 4/5] qapi: new qmp command nbd-server-add-bitmap

2018-05-23 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block.json | 23 +++ blockdev-nbd.c | 23 +++ 2 files changed, 46 insertions(+) diff --git a/qapi/block.json b/qapi/block.json index c694524002..ddbca2e286 100644 --- a/qapi/block.json +++ b/qapi/block.

[Qemu-devel] [PATCH v3 3/5] nbd/server: implement dirty bitmap export

2018-05-23 Thread Vladimir Sementsov-Ogievskiy
Handle new NBD meta namespace: "qemu", and corresponding queries: "qemu:dirty-bitmap:". With new metadata context negotiated, BLOCK_STATUS query will reply with dirty-bitmap data, converted to extents. New public function nbd_export_bitmap selects bitmap to export. For now, only one bitmap may be

[Qemu-devel] [Bug 1734810] Re: Windows guest virtual PC running abnormally slow

2018-05-23 Thread Thomas Huth
If you don't provide the CLI parameters, there's no way we can help here, sorry. So marking this as "invalid" for the QEMU project. ** Changed in: qemu Status: Incomplete => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QE

[Qemu-devel] [Qemu-ppc] [PPC64] P5020DS: Booting from img possible (-drive)?

2018-05-23 Thread Christian Zigotzky
Hi All, I would like to say thank you for your help. My virtual e5500 PowerPC machine works without any problems on my PC. I can use ubuntu MATE 16.04 LTS PowerPC with the RC6 of kernel 4.17 in a virtual e5500 QEMU 2.12.0 machine with a VirtIO graphics card and with a connection to the network

Re: [Qemu-devel] [PATCH 18/27] hw/misc/tz-mpc.c: Implement the Arm TrustZone Memory Protection Controller

2018-05-23 Thread Alex Bennée
Peter Maydell writes: > Implement the Arm TrustZone Memory Protection Controller, which sits > in front of RAM and allows secure software to configure it to either > pass through or reject transactions. > > We implement the MPC as a QEMU IOMMU, which will direct transactions > either through to

[Qemu-devel] [Bug 1257352] Re: kvm hangs occasionally when switching out of the qemu console

2018-05-23 Thread Thomas Huth
Could you please check with the latest version of QEMU (v2.12), and make sure that you're using SDL2 instead of SDL1.2 (since the latter is going to be removed soon)? ** Changed in: qemu (Ubuntu) Status: Confirmed => Incomplete -- You received this bug notification because you are a membe

Re: [Qemu-devel] [PATCH 19/27] hw/misc/tz-mpc.c: Implement registers

2018-05-23 Thread Alex Bennée
Peter Maydell writes: > Implement the missing registers for the TZ MPC. > > Signed-off-by: Peter Maydell > --- > include/hw/misc/tz-mpc.h | 10 +++ > hw/misc/tz-mpc.c | 137 ++- > 2 files changed, 144 insertions(+), 3 deletions(-) > > diff --git a/i

[Qemu-devel] Questions about the flow of interrupt simulation

2018-05-23 Thread Eva Chen
Hi, I have added a new virtual device under qemu/hw, and a device driver in the source code of guest OS (I use arm linux). Since I want to add an interrupt to the virtual device, I am tracing the flow of interrupt simulation of QEMU. However, I have some questions about the flow of interrupt, and

Re: [Qemu-devel] [PATCH 20/27] hw/misc/tz-mpc.c: Implement correct blocked-access behaviour

2018-05-23 Thread Alex Bennée
Peter Maydell writes: > The MPC is guest-configurable for whether blocked accesses: > * should be RAZ/WI or cause a bus error > * should generate an interrupt or not > > Implement this behaviour in the blocked-access handlers. > > Signed-off-by: Peter Maydell > --- > hw/misc/tz-mpc.c | 50 ++

Re: [Qemu-devel] [PATCH v12 18/21] migration: Start sending messages

2018-05-23 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> Signed-off-by: Juan Quintela >> --- >> migration/ram.c | 30 -- >> 1 file changed, 24 insertions(+), 6 deletions(-) >> >> diff --git a/migration/ram.c b/migration/ram.c >> index 862ec53

Re: [Qemu-devel] [PATCH v12 14/21] migration: Multifd channels always wait on the sem

2018-05-23 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> Either for quit, sync or packet, we first wake them. >> >> Signed-off-by: Juan Quintela >> --- >> migration/ram.c | 13 +++-- >> 1 file changed, 11 insertions(+), 2 deletions(-) >> >> diff --git a/migrati

Re: [Qemu-devel] [PATCH 22/27] vmstate.h: Provide VMSTATE_BOOL_SUB_ARRAY

2018-05-23 Thread Alex Bennée
Peter Maydell writes: > Provide a VMSTATE_BOOL_SUB_ARRAY to go with VMSTATE_UINT8_SUB_ARRAY > and friends. > > Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée > --- > include/migration/vmstate.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/migration/vmstate.h b/

Re: [Qemu-devel] [RFC 3/3] acpi-build: allocate mcfg for multiple host bridges

2018-05-23 Thread Zihan Yang
Hi all, Thanks for all your comments and suggestions, I wasn't expecting so many professional reviewers. Some of the things you mentioned are beyond my knowledge right now. Please correct me if I'm wrong below. The original purpose was just to support multiple segments in Intel Q35 archtecure for

Re: [Qemu-devel] [PATCH v12 17/21] migration: Create ram_multifd_page

2018-05-23 Thread Juan Quintela
Peter Xu wrote: > On Wed, Apr 25, 2018 at 01:27:19PM +0200, Juan Quintela wrote: >> The function still don't use multifd, but we have simplified >> ram_save_page, xbzrle and RDMA stuff is gone. We have added a new >> counter. >> >> Signed-off-by: Juan Quintela >> >> -- >> Add last_page paramet

[Qemu-devel] [PATCH v13 02/12] migration: Create multifd packet

2018-05-23 Thread Juan Quintela
We still don't put anything there. Signed-off-by: Juan Quintela -- fix magic (dave) check offset/ramblock (dave) --- migration/ram.c | 145 +++- 1 file changed, 144 insertions(+), 1 deletion(-) diff --git a/migration/ram.c b/migration/ram.c index 23

[Qemu-devel] [PATCH v13 00/12] Multifd

2018-05-23 Thread Juan Quintela
Hi This is v13 of multifd patches: - several patches already integrated - rebased to latests upstreams - addressed all the reviews comments around. Please review. Thanks, Juan. [v12] Big news, it is not RFC anymore, it works reliabely for me. Changes: - Locknig changed completely (several ti

[Qemu-devel] [PATCH v13 09/12] migration: Start sending messages

2018-05-23 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/ram.c | 29 - 1 file changed, 24 insertions(+), 5 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 28f5cea4d8..2584130c85 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -729,9 +729,6 @@ static int mult

[Qemu-devel] [PATCH v13 01/12] migration: Create multipage support

2018-05-23 Thread Juan Quintela
We only create/destry the page list here. We will use it later. Signed-off-by: Juan Quintela --- migration/ram.c | 57 + 1 file changed, 57 insertions(+) diff --git a/migration/ram.c b/migration/ram.c index 5bcbf7a9f9..23cc5625eb 100644 --- a/mig

[Qemu-devel] [PATCH v13 04/12] migration: Calculate transferred ram correctly

2018-05-23 Thread Juan Quintela
On multifd we send data from more places that main channel. Signed-off-by: Juan Quintela --- migration/migration.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 05aec2c905..55d7b64e24 100644 --- a/migration/mig

[Qemu-devel] [PATCH v13 05/12] migration: Multifd channels always wait on the sem

2018-05-23 Thread Juan Quintela
Either for quit, sync or packet, we first wake them. Signed-off-by: Juan Quintela --- migration/ram.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index ab715cc148..90f62144e2 100644 --- a/migration/ram.c +++ b/migration/ram

Re: [Qemu-devel] storing machine data in qcow images?

2018-05-23 Thread Markus Armbruster
Eduardo Habkost writes: > On Mon, May 21, 2018 at 07:44:40PM +0100, Daniel P. Berrangé wrote: >> On Mon, May 21, 2018 at 03:29:28PM -0300, Eduardo Habkost wrote: >> > On Sat, May 19, 2018 at 08:05:06AM +0200, Markus Armbruster wrote: >> > > Eduardo Habkost writes: >> > > >> > > [...] >> > > > A

[Qemu-devel] [PATCH v13 03/12] migration: Add multifd traces for start/end thread

2018-05-23 Thread Juan Quintela
We want to know how many pages/packets each channel has sent. Add counters for those. Signed-off-by: Juan Quintela -- sort trace-events (dave) --- migration/ram.c| 22 ++ migration/trace-events | 4 2 files changed, 26 insertions(+) diff --git a/migration/ram.

[Qemu-devel] [PATCH v13 06/12] migration: Add block where to send/receive packets

2018-05-23 Thread Juan Quintela
Once there add tracepoints. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c| 49 +- migration/trace-events | 2 ++ 2 files changed, 46 insertions(+), 5 deletions(-) diff --git a/migration/ram.c b/migration/ra

[Qemu-devel] [PATCH v13 07/12] migration: Synchronize multifd threads with main thread

2018-05-23 Thread Juan Quintela
We synchronize all threads each RAM_SAVE_FLAG_EOS. Bitmap synchronizations don't happen inside a ram section, so we are safe about two channels trying to overwrite the same memory. Signed-off-by: Juan Quintela --- migration/ram.c| 117 + migratio

[Qemu-devel] [PATCH v13 10/12] migration: Wait for blocking IO

2018-05-23 Thread Juan Quintela
We have three conditions here: - channel fails -> error - we have to quit: we close the channel and reads fails - normal read that success, we are in bussiness So forget the complications of waiting in a semaphore. Signed-off-by: Juan Quintela --- migration/ram.c | 81 ++

[Qemu-devel] [PATCH v13 12/12] migration: Stop sending whole pages through main channel

2018-05-23 Thread Juan Quintela
We have to flush() the QEMUFile because now we sent really few data through that channel. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index

[Qemu-devel] [PATCH v13 08/12] migration: Create ram_save_multifd_page

2018-05-23 Thread Juan Quintela
The function still don't use multifd, but we have simplified ram_save_page, xbzrle and RDMA stuff is gone. We have added a new counter. Signed-off-by: Juan Quintela -- Add last_page parameter Add commets for done and address Remove multifd field, it is the same than normal pages Merge next patc

[Qemu-devel] [PATCH v13 11/12] migration: Remove not needed semaphore and quit

2018-05-23 Thread Juan Quintela
We know quit closing the QIO. Signed-off-by: Juan Quintela --- migration/ram.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index a707d3ae80..62eea9e02f 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -587,14 +587,10 @@ t

Re: [Qemu-devel] [PATCH 25/27] hw/arm/iotkit: Instantiate MPC

2018-05-23 Thread Alex Bennée
Peter Maydell writes: > Wire up the one MPC that is part of the IoTKit itself. For the > moment we don't wire up its interrupt line. > > Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée > --- > include/hw/arm/iotkit.h | 2 ++ > hw/arm/iotkit.c | 38 +++-

Re: [Qemu-devel] [PATCH 26/27] hw/arm/iotkit: Wire up MPC interrupt lines

2018-05-23 Thread Alex Bennée
Peter Maydell writes: > The interrupt outputs from the MPC in the IoTKit and the expansion > MPCs in the board must be wired up to the security controller, and > also all ORed together to produce a single line to the NVIC. > > Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée > --- > in

Re: [Qemu-devel] [PATCH 27/27] hw/arm/mps2-tz.c: Instantiate MPCs

2018-05-23 Thread Alex Bennée
Peter Maydell writes: > Instantiate and wire up the Memory Protection Controllers > in the MPS2 board itself. > > Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée > --- > hw/arm/mps2-tz.c | 71 ++-- > 1 file changed, 44 insertions(+), 27 dele

Re: [Qemu-devel] [PULL 00/15] xen-20180521-tag

2018-05-23 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: alpine.DEB.2.10.1805211229070.4520@sstabellini-ThinkPad-X260 Subject: [Qemu-devel] [PULL 0

Re: [Qemu-devel] [PATCH 14/27] iommu: Add IOMMU index concept to IOMMU API

2018-05-23 Thread Peter Maydell
On 23 May 2018 at 02:06, Peter Xu wrote: > On Tue, May 22, 2018 at 12:11:38PM +0100, Peter Maydell wrote: >> On 22 May 2018 at 12:02, Peter Xu wrote: >> > On Tue, May 22, 2018 at 09:40:44AM +0100, Peter Maydell wrote: >> > And if we see current implementation for this (still, I copied code >> >

Re: [Qemu-devel] [PATCH] Correct CPACR reset value for v7 cores

2018-05-23 Thread Peter Maydell
On 23 May 2018 at 10:13, Cédric Le Goater wrote: > On 05/22/2018 09:26 PM, Peter Maydell wrote: >> (You're not using trustzone, are you? I know of a bug with >> migration of cpus with TZ enabled which I'm probably going to >> look at later this week) > > The PSR is : > > PSR=2093 --C-

Re: [Qemu-devel] [PATCH 17/27] exec.c: Handle IOMMUs in address_space_translate_for_iotlb()

2018-05-23 Thread Peter Maydell
On 23 May 2018 at 10:51, Alex Bennée wrote: > > Peter Maydell writes: > >> Currently we don't support board configurations that put an IOMMU >> in the path of the CPU's memory transactions, and instead just >> assert() if the memory region fonud in address_space_translate_for_iotlb() >> is an IOM

Re: [Qemu-devel] [PATCH 20/27] hw/misc/tz-mpc.c: Implement correct blocked-access behaviour

2018-05-23 Thread Peter Maydell
On 23 May 2018 at 11:49, Alex Bennée wrote: > > Peter Maydell writes: > >> The MPC is guest-configurable for whether blocked accesses: >> * should be RAZ/WI or cause a bus error >> * should generate an interrupt or not >> >> Implement this behaviour in the blocked-access handlers. >> >> Signed-

[Qemu-devel] [PATCH] tests: Allow GTESTER_OPTIONS variable expansion from command line

2018-05-23 Thread Philippe Mathieu-Daudé
The gtester utility offers the "-p=TESTPATH" option to "only run test cases matching TESTPATH". We already use a $GTESTER_OPTIONS variable. Use make variable expansion to allow qtest path matching from command line: $ time make check-qtest-arm GTESTER_OPTIONS="-p /arm/boot-serial" GTESTER c

Re: [Qemu-devel] [PATCH] arm: fix qemu crash on startup with -bios option

2018-05-23 Thread Auger Eric
Hi Igor, On 05/23/2018 12:22 PM, Igor Mammedov wrote: > When QEMU is started with following CLI > -machine virt,gic-version=3,accel=kvm -cpu host -bios AAVMF_CODE.fd > it crashes with abort at > accel/kvm/kvm-all.c:2164: > KVM_SET_DEVICE_ATTR failed: Group 6 attr 0xc665: Invalid arg

Re: [Qemu-devel] storing machine data in qcow images?

2018-05-23 Thread Eduardo Habkost
On Wed, May 23, 2018 at 01:19:46PM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Mon, May 21, 2018 at 07:44:40PM +0100, Daniel P. Berrangé wrote: > >> On Mon, May 21, 2018 at 03:29:28PM -0300, Eduardo Habkost wrote: > >> > On Sat, May 19, 2018 at 08:05:06AM +0200, Markus Armb

[Qemu-devel] [Bug 1425597] Re: moving window + changing screen resolution = bug

2018-05-23 Thread Askar Safin via Qemu-devel
The bug is not present in Qemu 2.12 (version reported by dpkg: qemu- system-x86 1:2.12+dfsg-1+b1). There is similar minor bug instead. The new bug doesn't harm me and I am not even sure is this a bug. So, this is info about new minor bug. Host is Debian Sid installed today (23 May MSK) with menti

Re: [Qemu-devel] [PATCH v2 1/1] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-23 Thread Yi Min Zhao
在 2018/5/23 下午6:33, Eduardo Otubo 写道: On 05/23/2018 11:16 AM, Yi Min Zhao wrote: 在 2018/5/23 下午3:47, Ján Tomko 写道: On Sat, May 19, 2018 at 04:20:37PM +0800, Yi Min Zhao wrote: 在 2018/5/18 下午9:07, Ján Tomko 写道: On Fri, May 18, 2018 at 11:19:16AM +0200, Eduardo Otubo wrote: On 18/05/2018

Re: [Qemu-devel] [PATCH v1 06/30] RISC-V: Move non-ops from op_helper to cpu_helper

2018-05-23 Thread Philippe Mathieu-Daudé
On 05/22/2018 09:14 PM, Michael Clark wrote: > This patch makes op_helper.c contain only instruction > operation helpers used by translate.c and moves any > unrelated cpu helpers into cpu_helper.c. No logic is > changed by this patch. > > Cc: Sagar Karandikar > Cc: Bastian Koppelmann > Cc: Palme

Re: [Qemu-devel] [PATCH v1 11/30] RISC-V: Split out mstatus_fs from tb_flags

2018-05-23 Thread Philippe Mathieu-Daudé
On 05/22/2018 09:14 PM, Michael Clark wrote: > From: Richard Henderson > > Cc: Sagar Karandikar > Cc: Bastian Koppelmann > Cc: Palmer Dabbelt > Cc: Alistair Francis > Cc: Richard Henderson > Signed-off-by: Michael Clark > Reviewed-by: Michael Clark Reviewed-by: Philippe Mathieu-Daudé >

Re: [Qemu-devel] [PATCH v1 13/30] RISC-V: Implement mstatus.TSR/TW/TVM

2018-05-23 Thread Philippe Mathieu-Daudé
Hi Michael, On 05/22/2018 09:15 PM, Michael Clark wrote: > This adds the necessary minimum to support S-mode > virtualization for priv ISA >= v1.10 > > Cc: Sagar Karandikar > Cc: Bastian Koppelmann > Cc: Palmer Dabbelt > Cc: Alistair Francis > Cc: Matthew Suozzo > Signed-off-by: Michael Clar

Re: [Qemu-devel] [PATCH v7 1/3] qmp: adding 'wakeup-suspend-support' in query-target

2018-05-23 Thread Eduardo Habkost
On Wed, May 23, 2018 at 11:17:55AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > On Mon, May 21, 2018 at 04:46:36PM -0300, Daniel Henrique Barboza wrote: [...] > >> Since no objection was made back then, this logic was put into query-target > >> starting > >> in v2. Still, I don't

Re: [Qemu-devel] [RFC 3/3] acpi-build: allocate mcfg for multiple host bridges

2018-05-23 Thread Laszlo Ersek
On 05/23/18 13:11, Zihan Yang wrote: > Hi all, > The original purpose was just to support multiple segments in Intel > Q35 archtecure for PCIe topology, which makes bus number a less scarce > resource. The patches are very primitive and many things are left for > firmware to finish(the initial pla

Re: [Qemu-devel] [PATCH 0/2] qemu-iotests: Add more tests to "migration" group

2018-05-23 Thread Kevin Wolf
Am 23.05.2018 um 11:58 hat Kevin Wolf geschrieben: > Kevin Wolf (2): > qemu-iotests: Add more tests to "migration" group > qemu-iotests: Remove MIG_SOCKET from non-migration tests Applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH v2 00/40] Generic background jobs

2018-05-23 Thread Kevin Wolf
Am 18.05.2018 um 15:20 hat Kevin Wolf geschrieben: > Before we can make x-blockdev-create a background job, we need to > generalise the job infrastructure so that it can be used without any > associated block node. > > This series extracts a Job object from the block job infrastructure, > which sh

Re: [Qemu-devel] [PATCH v1 15/30] RISC-V: Add hartid and \n to interrupt logging

2018-05-23 Thread Philippe Mathieu-Daudé
Hi Michael, On 05/22/2018 09:15 PM, Michael Clark wrote: > Add carriage return that was erroneously removed > when converting to qemu_log. Change hard coded > core number to the actual hartid. I think it makes more sens to move this patch before your 6/30 "Move non-ops from op_helper to cpu_helpe

Re: [Qemu-devel] [PATCH v1 16/30] RISC-V: Use riscv prefix consistently on cpu helpers

2018-05-23 Thread Philippe Mathieu-Daudé
On 05/22/2018 09:15 PM, Michael Clark wrote: > * Add riscv prefix to raise_exception function > * Add riscv prefix to CSR read/write functions > * Add riscv prefix to signal handler function > * Add riscv prefix to get fflags function > * Remove redundant declaration of riscv_cpu_init > and renam

Re: [Qemu-devel] [PATCH] pnv: add a physical mapping array describing MMIO ranges in each chip

2018-05-23 Thread Cédric Le Goater
On 05/18/2018 11:00 AM, Greg Kurz wrote: > On Thu, 17 May 2018 15:18:14 +0200 > Cédric Le Goater wrote: > >> Based on previous work done in skiboot, the physical mapping array >> helps in calculating the MMIO ranges of each controller depending on >> the chip id and the chip type. This is will be

Re: [Qemu-devel] [PATCH v1 17/30] RISC-V: Replace __builtin_popcount with ctpop8 in PLIC

2018-05-23 Thread Philippe Mathieu-Daudé
On 05/22/2018 09:15 PM, Michael Clark wrote: > The mode variable only uses the lower 4-bits (M,H,S,U) so > replace the GCC specific __builtin_popcount with ctpop8. > > Cc: Palmer Dabbelt > Cc: Sagar Karandikar > Cc: Bastian Koppelmann > Cc: Alistair Francis > Signed-off-by: Michael Clark Rev

Re: [Qemu-devel] [PATCH v1 18/30] RISC-V: Add missing free for plic_hart_config

2018-05-23 Thread Philippe Mathieu-Daudé
On 05/22/2018 09:15 PM, Michael Clark wrote: > Cc: Palmer Dabbelt > Cc: Sagar Karandikar > Cc: Bastian Koppelmann > Cc: Alistair Francis > Signed-off-by: Michael Clark Reviewed-by: Philippe Mathieu-Daudé > --- > hw/riscv/virt.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw

Re: [Qemu-devel] [PATCH v1 20/30] RISC-V: Add misa to DisasContext

2018-05-23 Thread Philippe Mathieu-Daudé
On 05/22/2018 09:15 PM, Michael Clark wrote: > gen methods should access state from DisasContext. Add misa > field to the DisasContext struct and remove CPURISCVState > argument from all gen methods. > > Cc: Palmer Dabbelt > Cc: Sagar Karandikar > Cc: Bastian Koppelmann > Cc: Alistair Francis

Re: [Qemu-devel] [PATCH v1 29/30] RISC-V: Don't add NULL bootargs to device-tree

2018-05-23 Thread Philippe Mathieu-Daudé
On 05/22/2018 09:15 PM, Michael Clark wrote: With your Signed-off-by: Reviewed-by: Philippe Mathieu-Daudé > --- > hw/riscv/sifive_u.c | 4 +++- > hw/riscv/spike.c| 6 -- > hw/riscv/virt.c | 4 +++- > 3 files changed, 10 insertions(+), 4 deletions(-) > > diff --git a/hw/riscv/sifive

  1   2   3   >