Hi Philippe,
On 05/16/2018 10:01 PM, Philippe Mathieu-Daudé wrote:
> On 05/16/2018 01:23 PM, Peter Maydell wrote:
>> On 16 May 2018 at 16:16, Philippe Mathieu-Daudé wrote:
>>> Hi Eric,
>>>
>>> On 05/16/2018 03:03 PM, Eric Auger wrote:
Coverity points out that this can overflow if n > 31,
Le 17/05/2018 à 01:17, Philippe Mathieu-Daudé a écrit :
> On 05/16/2018 05:55 PM, Laurent Vivier wrote:
>> No code change.
>>
>> Signed-off-by: Laurent Vivier
>> ---
>> linux-user/generic/sockbits.h | 9 +
>> linux-user/ppc/sockbits.h | 19 +++
>> 2 files changed, 20
On 5/17/2018 5:42 AM, 858585 jemmy wrote:
On Wed, May 16, 2018 at 11:11 PM, Aviad Yehezkel
wrote:
Hi Lidong and David,
Sorry for the late response, I had to ramp up on migration code and build a
setup on my side.
PSB my comments for this patch below.
For the RDMA post-copy patches I will com
Hi Peter,
On 05/16/2018 06:18 PM, Peter Maydell wrote:
> On 16 May 2018 at 15:33, Auger Eric wrote:
>> On 05/08/2018 06:25 PM, Peter Maydell wrote:
>>> This runs into something I found when I was implementing the Arm
>>> Memory Protection Controller -- at the point when the guest changes
>>> the c
On 05/16/18 11:29, Laszlo Ersek wrote:
> Hi Marc-André,
>
> On 05/15/18 14:30, marcandre.lur...@redhat.com wrote:
>> From: Marc-André Lureau
>>
>> Hi,
>>
>> The following series adds basic TPM PPI 1.3 support for OVMF-on-QEMU
>> with TPM2 (I haven't tested TPM1, for lack of interest).
Here's ano
On Thu, May 17, 2018 at 3:31 PM, Aviad Yehezkel
wrote:
>
>
> On 5/17/2018 5:42 AM, 858585 jemmy wrote:
>>
>> On Wed, May 16, 2018 at 11:11 PM, Aviad Yehezkel
>> wrote:
>>>
>>> Hi Lidong and David,
>>> Sorry for the late response, I had to ramp up on migration code and build
>>> a
>>> setup on my
On 5/17/2018 10:41 AM, 858585 jemmy wrote:
On Thu, May 17, 2018 at 3:31 PM, Aviad Yehezkel
wrote:
On 5/17/2018 5:42 AM, 858585 jemmy wrote:
On Wed, May 16, 2018 at 11:11 PM, Aviad Yehezkel
wrote:
Hi Lidong and David,
Sorry for the late response, I had to ramp up on migration code and buil
On Fri, 05/11 19:20, Eduardo Habkost wrote:
> TESTING NEEDED: Due to the amount of changes, I didn't test all
> scripts touched by this series. If you are responsible for any
> of the touched files, I would appreciate help on testing the
> series.
The tests/docker and tests/vm changes look good t
On 05/15/18 14:30, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Hi,
>
> The following series adds basic TPM PPI 1.3 support for OVMF-on-QEMU
> with TPM2 (I haven't tested TPM1, for lack of interest).
>
> PPI test runs successfully with Windows 10 WHLK, despite the limited
>
On 05/15/18 14:30, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> This NULL library will let us call
> Tcg2PhysicalPresenceLibProcessRequest() unconditionally from
> BdsPlatform when building without TPM2_ENABLE.
>
> Signed-off-by: Marc-André Lureau
> ---
> .../DxeTcg2Physica
On Wed, 16 May 2018 19:12:30 -0300
Eduardo Habkost wrote:
> On Fri, May 04, 2018 at 10:37:49AM +0200, Igor Mammedov wrote:
> > * start QEMU with 2 unmapped cpus,
> > * while in preconfig state
> > * add 2 numa nodes
> > * assign cpus to them
> > * exit preconfig and in running state ch
Anton Nefedov writes:
> On 15/5/2018 8:40 PM, Markus Armbruster wrote:
>> Eric Blake writes:
>>
>>> On 05/15/2018 02:01 AM, Markus Armbruster wrote:
>>>
>> QAPI language design alternatives:
>>
>> 1. Having unions cover all discriminator values explicitly is useful.
>>>
>> 2. Hav
On Tue, 8 May 2018 00:08:38 +0300
Antony Pavlov wrote:
Please comment this patch!
> The RISC-V Instruction Set Manual, Volume II:
> Privileged Architecture, Version 1.10 states
> that upon reset the pc is set to
> an implementation-defined reset vector
> (see chapter 3.3 Reset).
>
> This patch
On 05/15/18 14:30, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Add some common macros and type definitions corresponding to the QEMU
> TPM interface.
>
> Signed-off-by: Marc-André Lureau
> ---
> OvmfPkg/Include/IndustryStandard/QemuTpm.h | 67 ++
> 1 fi
We can have devices that need certain other resources that are e.g.
system resources managed by the machine. We need a clean way to assign
these resources (without violating layers as brought up by Igor).
One example is virtio-mem/virtio-pmem. Both device types need to be
assigned some region in g
For multi stage hotplug handlers, we'll have to do some error handling
in some hotplug functions, so let's use a local error variable (except
for unplug requests).
Also, add code to pass control to the final stage hotplug handler at the
parent bus.
Signed-off-by: David Hildenbrand
---
hw/i386/p
Let's handle it via hotplug_handler_unplug().
Signed-off-by: David Hildenbrand
---
hw/ppc/spapr.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 286c38c842..13d153b5a6 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -34
The start of the address space does not have to be aligned for the
search. Handle this case explicitly when starting the search for a new
address.
Signed-off-by: David Hildenbrand
---
hw/mem/memory-device.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/mem/memory-devic
Some architectures might support memory devices, while they don't
support DIMM/NVDIMM. So let's
- Rename CONFIG_MEM_HOTPLUG to CONFIG_MEM_DEVICE
- Introduce CONFIG_DIMM and use it similarly to CONFIG NVDIMM
CONFIG_DIMM and CONFIG_NVDIMM require CONFIG_MEM_DEVICE.
Signed-off-by: David Hildenbrand
Necessary to hotplug them cleanly later.
Signed-off-by: David Hildenbrand
---
hw/ppc/spapr.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index b7c5c95f7a..2f315f963b 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -3666,6 +3666,7 @@ static HotplugHandl
From: Igor Mammedov
it will allow to return another hotplug handler than the default
one for a specific bus based device type. Which is needed to handle
non trivial plug/unplug sequences that need the access to resources
configured outside of bus where device is attached.
That will allow for ret
Necessary to hotplug them cleanly later. We could drop the PC_DIMM
check, as PC_DIMM are just memory devices, but this approach is cleaner.
Signed-off-by: David Hildenbrand
---
hw/i386/pc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 510076e156..8bc41e
For multi stage hotplug handlers, we'll have to do some error handling
in some hotplug functions, so let's use a local error variable (except
for unplug requests).
Also, add code to pass control to the final stage hotplug handler at the
parent bus.
Signed-off-by: David Hildenbrand
---
hw/ppc/sp
We will need a handful of new functions:
- set_addr(): To set the calculated address
- get_memory_region(): To add it to the memory region container
- get_addr(): If the device has any specific alignment requirements
Using these and the existing functions, we can properly plug/unplug
memory device
Let's handle it via hotplug_handler_unplug(). E.g. necessary to hotplug/
unplug memory devices (which a pc-dimm is) later.
Signed-off-by: David Hildenbrand
---
hw/ppc/spapr.c | 23 +++
1 file changed, 19 insertions(+), 4 deletions(-)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spap
Implement the new functions, we don't have to care about alignment for
these DIMMs right now, so leave that function unimplemented.
Signed-off-by: David Hildenbrand
---
hw/mem/pc-dimm.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c
ind
Let's move the plug logic into the applicable hotplug handler for pc and
spapr.
Signed-off-by: David Hildenbrand
---
hw/i386/pc.c | 35 ---
hw/mem/memory-device.c | 40 ++--
hw/mem/pc-dimm.c
Let's move the unplug logic into the applicable hotplug handler for pc and
spapr.
We'll move the plug logic next, then this will look more symmetrical in
the hotplug handlers.
Signed-off-by: David Hildenbrand
---
hw/i386/pc.c | 17 -
hw/mem/memory-device.c
Let's move all pre-plug checks we can do without the device being
realized into the applicable hotplug handler for pc and spapr.
Signed-off-by: David Hildenbrand
---
hw/i386/pc.c | 11 +++
hw/mem/memory-device.c | 72 +++---
hw/pp
Zhang Chen writes:
> On Tue, May 15, 2018 at 10:29 PM, Markus Armbruster
> wrote:
>
>> Zhang Chen writes:
>>
>> > From: zhanghailiang
>> >
>> > If some errors happen during VM's COLO FT stage, it's important to
>> > notify the users of this event. Together with 'x-colo-lost-heartbeat',
>> > Us
Daniel Henrique Barboza writes:
> On 05/15/2018 12:35 PM, Markus Armbruster wrote:
>> Daniel Henrique Barboza writes:
>>
>>> This patch updates the descriptions of 'guest-suspend-ram' and
>>> 'guest-suspend-hybrid' to mention that both commands relies now
>>> on the existence of 'system_wakeup'
On 05/17/18 09:54, Laszlo Ersek wrote:
> On 05/15/18 14:30, marcandre.lur...@redhat.com wrote:
>> From: Marc-André Lureau
>>
>> Hi,
>>
>> The following series adds basic TPM PPI 1.3 support for OVMF-on-QEMU
>> with TPM2 (I haven't tested TPM1, for lack of interest).
>>
>> PPI test runs successfull
Daniel Henrique Barboza writes:
> On 05/15/2018 12:45 PM, Markus Armbruster wrote:
>> Daniel Henrique Barboza writes:
>>
>>> When issuing the qmp/hmp 'system_wakeup' command, what happens in a
>>> nutshell is:
>>>
>>> - qmp_system_wakeup_request set runstate to RUNNING, sets a wakeup_reason
>>>
(Hello, Jintack, Feel free to test this branch again against your scp
error case when you got free time)
I rewrote some of the patches in V3. Major changes:
- Dropped mergable interval tree, instead introduced IOVA tree, which
is even simpler.
- Fix the scp error issue that Jintack reported.
During IOVA page table walking, there is a special case when the PSI
covers one whole PDE (Page Directory Entry, which contains 512 Page
Table Entries) or more. In the past, we skip that entry and we don't
notify the IOMMU notifiers. This is not correct. We should send UNMAP
notification to regi
During the recursive page walking of IOVA page tables, some stack
variables are constant variables and never changed during the whole page
walking procedure. Isolate them into a struct so that we don't need to
pass those contants down the stack every time and multiple times.
Signed-off-by: Peter
Introduce a simplest iova tree implementation based on GTree.
Signed-off-by: Peter Xu
---
include/qemu/iova-tree.h | 134 +++
util/iova-tree.c | 114 +
MAINTAINERS | 6 ++
util/Makefile.objs | 1 +
Add a per-iommu big lock to protect IOMMU status. Currently the only
thing to be protected is the IOTLB/context cache, since that can be
accessed even without BQL, e.g., in IO dataplane.
Note that we don't need to protect device page tables since that's fully
controlled by the guest kernel. Howe
That is not really necessary. Removing that node struct and put the
list entry directly into VTDAddressSpace. It simplfies the code a lot.
Signed-off-by: Peter Xu
---
include/hw/i386/intel_iommu.h | 9 ++--
hw/i386/intel_iommu.c | 41 ++-
2 files ch
For each VTDAddressSpace, now we maintain what IOVA ranges we have
mapped and what we have not. With that information, now we only send
MAP or UNMAP when necessary. Say, we don't send MAP notifies if we know
we have already mapped the range, meanwhile we don't send UNMAP notifies
if we know we ne
We pass in the VTDAddressSpace too. It'll be used in the follow up
patches.
Signed-off-by: Peter Xu
---
hw/i386/intel_iommu.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index 4953d02ed0..fe5ee77d46 100644
--- a/hw/i386/intel_iommu.c
+++
For UNMAP-only IOMMU notifiers, we don't really need to walk the page
tables. Fasten that procedure by skipping the page table walk. That
should boost performance for UNMAP-only notifiers like vhost.
Signed-off-by: Peter Xu
---
include/hw/i386/intel_iommu.h | 2 ++
hw/i386/intel_iommu.c
This patch only modifies the trace points.
Previously we were tracing page walk levels. They are redundant since
we have page mask (size) already. Now we trace something much more
useful which is the domain ID of the page walking. That can be very
useful when we trace more than one devices on t
Let's move the notify_unmap check into the new vtd_page_walk_one()
function so that we can greatly simplify the vtd_page_walk_level()
logic.
No functional change at all.
Signed-off-by: Peter Xu
---
hw/i386/intel_iommu.c | 66 ---
hw/i386/trace-events |
Firstly, introduce the sync_shadow_page_table() helper to resync the
whole shadow page table of an IOMMU address space. Meanwhile, when we
receive domain invalidation or similar requests (for example, context
entry invalidations, global invalidations, ...), we should not really
run the replay logi
I pick part of the page walk implementation out into this single
function. It was only used now for PSIs, but actually it can be used
not only for invalidations but for any place that we want to synchronize
the shadow page table. No functional change at all.
Here I passed in context entry explic
Signed-off-by: Gerd Hoffmann
---
hw/display/bochs-display.c | 8
1 file changed, 8 insertions(+)
diff --git a/hw/display/bochs-display.c b/hw/display/bochs-display.c
index 9ea6f798f4..23dbf57b8f 100644
--- a/hw/display/bochs-display.c
+++ b/hw/display/bochs-display.c
@@ -254,6 +254,7 @@
Signed-off-by: Gerd Hoffmann
---
hw/display/bochs-display.c | 33 -
1 file changed, 32 insertions(+), 1 deletion(-)
diff --git a/hw/display/bochs-display.c b/hw/display/bochs-display.c
index beeda58475..9ea6f798f4 100644
--- a/hw/display/bochs-display.c
+++ b/hw/d
Gerd Hoffmann (4):
vga: move bochs vbe defines to header file
display: add new bochs-display device
bochs-display: add dirty tracking support
bochs-display: add pcie support
hw/display/vga_int.h | 35 +---
include/hw/display/bochs-vbe.h | 64
hw/display/bochs-displa
Create a new header file, move the bochs vbe dispi interface
defines to it, so they can be used outside vga code.
Signed-off-by: Gerd Hoffmann
---
hw/display/vga_int.h | 35 ++-
include/hw/display/bochs-vbe.h | 64 ++
hw/displ
After writing up the virtual mdev device emulating a display supporting
the bochs vbe dispi interface (mbochs.ko) and seeing how simple it
actually is I've figured that would be useful for qemu too.
So, here it is, -device bochs-display. It is basically -device VGA
without legacy vga emulation.
On Fri, May 11, 2018 at 08:08:14PM +0800, Fam Zheng wrote:
> Introduce the bdrv_co_copy_range() API for copy offloading. Block
> drivers implementing this API support efficient copy operations that
> avoid reading each block from the source device and writing it to the
> destination devices. Exam
Hi Peter,
On 05/16/2018 08:31 PM, Eric Auger wrote:
> Let's cache config data to avoid fetching and parsing STE/CD
> structures on each translation. We invalidate them on data structure
> invalidation commands.
You may remember that initially I was taking a QemuMutex to protect
IOTLB/cache struct
On Thu, May 17, 2018 at 04:59:24PM +0800, Peter Xu wrote:
[...]
> +/* Update local IOVA mapped ranges */
> +if (entry->perm) {
> +if (mapped) {
> +/* If it's exactly the same translation, skip */
> +if (!memcmp(mapped, &target, sizeof(target))) {
> +
Hi Peter,
On 05/04/2018 05:08 AM, Peter Xu wrote:
> That is not really necessary. Removing that node struct and put the
> list entry directly into VTDAddressSpace. It simplfies the code a lot.
>
> Signed-off-by: Peter Xu
> ---
> include/hw/i386/intel_iommu.h | 9 ++--
> hw/i386/intel_iom
* Zhang Chen (zhangc...@gmail.com) wrote:
> From: zhanghailiang
>
> Notify all net filters about the checkpoint and failover event.
>
> Signed-off-by: zhanghailiang
Reviewed-by: Dr. David Alan Gilbert
> ---
> migration/colo.c | 12
> 1 file changed, 12 insertions(+)
>
> diff -
Finally, what about this?
13.04.2018 17:31, Vladimir Sementsov-Ogievskiy wrote:
Handle nbd CACHE command. Just do read, without sending read data back.
Cache mechanism should be done by exported node driver chain.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/block/nbd.h | 3 ++-
* Zhang Chen (zhangc...@gmail.com) wrote:
> From: zhanghailiang
>
> COLO thread may sleep at qemu_sem_wait(&s->colo_checkpoint_sem),
> while failover works begin, It's better to wakeup it to quick
> the process.
>
> Signed-off-by: zhanghailiang
Reviewed-by: Dr. David Alan Gilbert
> ---
> mi
What about patches 1-4?
07.05.2018 18:44, Vladimir Sementsov-Ogievskiy wrote:
Hi all!
Here are some preliminary refactoring patches, before NBD reconnect
series.
Vladimir Sementsov-Ogievskiy (5):
block/nbd-client: split channel errors from export errors
block/nbd: move connection code fr
On Fri, May 11, 2018 at 08:08:17PM +0800, Fam Zheng wrote:
> +static int qcow2_handle_l2meta(BlockDriverState *bs, QCowL2Meta *l2meta)
> +{
> +int ret = 0;
> +
> +while (l2meta != NULL) {
> +QCowL2Meta *next;
> +
> +if (!ret) {
> +ret = qcow2_alloc_cluster_link_l
17.05.2018 00:15, John Snow wrote:
On 05/14/2018 10:30 AM, Vladimir Sementsov-Ogievskiy wrote:
12.05.2018 04:25, John Snow wrote:
Add some of the necessary scaffolding for reporting bitmap information.
Signed-off-by: John Snow
---
qapi/block-core.json | 60
On Fri, May 11, 2018 at 08:08:18PM +0800, Fam Zheng wrote:
> With copy_file_range(2), we can implement the bdrv_co_copy_range
> semantics.
>
> Signed-off-by: Fam Zheng
> ---
> block/file-posix.c | 96
> +++--
> include/block/raw-aio.h | 10 --
On Thu, May 17, 2018 at 11:46:22AM +0200, Auger Eric wrote:
> Hi Peter,
>
> On 05/04/2018 05:08 AM, Peter Xu wrote:
> > That is not really necessary. Removing that node struct and put the
> > list entry directly into VTDAddressSpace. It simplfies the code a lot.
> >
> > Signed-off-by: Peter Xu
17.05.2018 00:17, John Snow wrote:
On 05/14/2018 11:12 AM, Vladimir Sementsov-Ogievskiy wrote:
12.05.2018 04:25, John Snow wrote:
Add functions for querying the basic information inside of bitmaps.
Restructure the bitmaps flags masks to facilitate providing a list of
flags belonging to the bit
On 15 May 2018 at 22:54, Eduardo Habkost wrote:
> The following changes since commit ad1b4ec39caa5b3f17cbd8160283a03a3dcfe2ae:
>
> Merge remote-tracking branch
> 'remotes/kraxel/tags/input-20180515-pull-request' into staging (2018-05-15
> 12:50:06 +0100)
>
> are available in the Git repository
On Thu, May 17, 2018 at 12:10:41PM +0200, Auger Eric wrote:
> Hi Peter,
>
> On 05/17/2018 12:02 PM, Peter Xu wrote:
> > On Thu, May 17, 2018 at 11:46:22AM +0200, Auger Eric wrote:
> >> Hi Peter,
> >>
> >> On 05/04/2018 05:08 AM, Peter Xu wrote:
> >>> That is not really necessary. Removing that no
Hi Peter,
On 05/17/2018 12:02 PM, Peter Xu wrote:
> On Thu, May 17, 2018 at 11:46:22AM +0200, Auger Eric wrote:
>> Hi Peter,
>>
>> On 05/04/2018 05:08 AM, Peter Xu wrote:
>>> That is not really necessary. Removing that node struct and put the
>>> list entry directly into VTDAddressSpace. It simp
On 05/15/18 14:30, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Cloned "SecurityPkg/Library/DxeTcg2PhysicalPresenceLib" and:
>
> - removed all the functions that are unreachable from
> Tcg2PhysicalPresenceLibProcessRequest()
>
> - replaced everything that's related to the
On 16 May 2018 at 16:52, Richard Henderson wrote:
> diff --git a/target/arm/translate.c b/target/arm/translate.c
> index 731cf327a1..613598d090 100644
> --- a/target/arm/translate.c
> +++ b/target/arm/translate.c
Just noticed, but in the 32-bit translator where the argument to
get_fpstatus_ptr()
On 05/15/18 14:30, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Call Tcg2PhysicalPresenceLibProcessRequest() to process pending PPI
> requests from PlatformBootManagerAfterConsole().
>
> Laszlo understanding of edk2 is that the PPI operation processing was
> meant to occur *e
Looking through old bug tickets... can you still reproduce this issue
with the latest versions of QEMU, x11, kernel, spice, etc.? Or could we
close this ticket nowadays?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
d
Looking through old bug tickets... can you still reproduce this issue
with the latest version of QEMU? Or could we close this ticket nowadays?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribe
On Fri, May 04, 2018 at 08:26:04PM +0100, Paul Durrant wrote:
> Now that the (native or emulated) xen_be_copy_grant_refs() helper is
> always available, the xen_disk code can be significantly simplified by
> removing direct use of grant map and unmap operations.
>
> Signed-off-by: Paul Durrant
A
On Fri, May 04, 2018 at 08:26:05PM +0100, Paul Durrant wrote:
> There is no longer any use of this flag outside of the xen_backend code.
>
> Signed-off-by: Paul Durrant
Acked-by: Anthony PERARD
--
Anthony PERARD
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180516223007.10256-1-richard.hender...@linaro.org
Subject: [Qemu-devel] [PATCH v3-a 00/27] target/arm: Scalable Vector Extension
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE
On 15 May 2018 at 17:50, Paolo Bonzini wrote:
> On 15/05/2018 18:28, Peter Maydell wrote:
>>
>> Presumably we also want a way for notifier users like vfio to
>> detect "I'm dealing with an IOMMU that is txattrs aware in a
>> way I can't deal with" so they can usefully bail out rather than
>> not w
KVM Forum 2018: Call For Participation
October 24-26, 2018 - Edinburgh International Conference Centre - Edinburgh, UK
(All submissions must be received before midnight June 14, 2018)
On Fri, May 04, 2018 at 08:26:06PM +0100, Paul Durrant wrote:
> Since xen_disk now always copies data to and from a guest there is no need
> to maintain a vector entry corresponding to every page of a request.
> This means there is less per-request state to maintain so the ioreq
> structure can shr
On 16 May 2018 at 00:39, Juan Quintela wrote:
> Hi
>
> - dropped xbzrle test (have to check with slower systems)
> - fixed s/2.12/2.13/ detected by eric
>
> Please Apply.
>
> The following changes since commit c416eecea5f3aea863ab8fda5a36a24157b8f704:
>
> Merge remote-tracking branch 'remotes/ke
On Fri, May 04, 2018 at 08:26:07PM +0100, Paul Durrant wrote:
> Certain functions in xen_disk are called with a pointer to xendev
> (struct XenDevice *). They then use continer_of() to acces the surrounding
^ container_of
> blkdev (struct XenBlkDev) but then
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180517092513.735-1-kra...@redhat.com
Subject: [Qemu-devel] [PATCH 0/4] display: add new bochs-display device
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(gi
On Thu, 17 May 2018 10:01:34 +0200
Igor Mammedov wrote:
> On Wed, 16 May 2018 19:12:30 -0300
> Eduardo Habkost wrote:
>
> > On Fri, May 04, 2018 at 10:37:49AM +0200, Igor Mammedov wrote:
> > > * start QEMU with 2 unmapped cpus,
> > > * while in preconfig state
> > > * add 2 numa nodes
>
Add permission checks for commands at 'preconfig' stage.
Signed-off-by: Igor Mammedov
---
v8:
* there isn't QDECREF anymore use qobject_unref instead
* add negative test for exit-preconfig
v6:
* replace 'cont' with 'exit-preconfig' command
v5:
* s/-preconfig/--preconfig/
v4:
* s/is_err(
* start QEMU with 2 unmapped cpus,
* while in preconfig state
* add 2 numa nodes
* assign cpus to them
* exit preconfig and in running state check that cpus
are mapped correctly.
Signed-off-by: Igor Mammedov
---
v8:
* there isn't QDECREF/qobject_decref anymore use qobject_unref in
Add Paolo to CC list. @Paolo, expect your comment. Thanks very much!
在 2018/5/15 下午11:25, Eric Blake 写道:
On 05/15/2018 06:33 AM, Yi Min Zhao wrote:
If CONFIG_SECCOMP is undefined, the option 'elevateprivileges' remains
compiled. This would make libvirt set the corresponding capability and
then
cpu_init() was replaced by cpu_create() since 2.12 but comments
weren't updated. So update stale comments to point that page
sizes arei actually initialized by tcg_exec_init(). Also move
another qemu_host_page_size related comment before tcg_exec_init()
where it belongs.
Signed-off-by: Igor Mammed
Le 17/05/2018 à 13:51, Igor Mammedov a écrit :
> cpu_init() was replaced by cpu_create() since 2.12 but comments
> weren't updated. So update stale comments to point that page
> sizes arei actually initialized by tcg_exec_init(). Also move
> another qemu_host_page_size related comment before tcg_ex
On 16 May 2018 at 18:42, Jeff Cody wrote:
> The following changes since commit c416eecea5f3aea863ab8fda5a36a24157b8f704:
>
> Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging
> (2018-05-15 17:02:00 +0100)
>
> are available in the git repository at:
>
> git://github.c
Peter Xu writes:
> The out_lock was only protecting a few Monitor fields. In the future
"was protecting"? When? Or do you mean "is protecting"?
> the monitor code will start to run in multiple threads. We turn it into
> a bigger lock to protect not only the out buffer but also all the rest.
On 05/17/2018 05:44 AM, Markus Armbruster wrote:
Daniel Henrique Barboza writes:
On 05/15/2018 12:45 PM, Markus Armbruster wrote:
Daniel Henrique Barboza writes:
When issuing the qmp/hmp 'system_wakeup' command, what happens in a
nutshell is:
- qmp_system_wakeup_request set runstate to
x_keymap.o is common to the SDL and GTK+ modules, and it causes the
QEMU binary to link to the X11 libraries. Add it separately to the
modules to keep the main QEMU binary smaller.
Signed-off-by: Paolo Bonzini
---
ui/Makefile.objs | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-
On 15/05/2018 - 19:33:48, Yi Min Zhao wrote:
> If CONFIG_SECCOMP is undefined, the option 'elevateprivileges' remains
> compiled. This would make libvirt set the corresponding capability and
> then trigger the guest startup fails. So this patch excludes the code
> regarding seccomp staff if CONFIG_
On Thu, May 17, 2018 at 02:39:42PM +0200, Paolo Bonzini wrote:
> x_keymap.o is common to the SDL and GTK+ modules, and it causes the
> QEMU binary to link to the X11 libraries. Add it separately to the
> modules to keep the main QEMU binary smaller.
>
> Signed-off-by: Paolo Bonzini
> ---
> ui/M
On Thu, 17 May 2018 10:15:19 +0200
David Hildenbrand wrote:
> For multi stage hotplug handlers, we'll have to do some error handling
> in some hotplug functions, so let's use a local error variable (except
> for unplug requests).
>
> Also, add code to pass control to the final stage hotplug hand
Peter Xu writes:
> Add some explicit comment for both Readline and cpu_set/cpu_get helpers
> that they do not need the mon_lock protection.
Appreciated!
> Signed-off-by: Peter Xu
> ---
> monitor.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/monitor.c b/monito
Peter Xu writes:
> mon->fds were protected by BQL. Now protect it by mon_lock so that it
> can even be used in monitor iothread.
>
> Signed-off-by: Peter Xu
Reviewed-by: Markus Armbruster
On 17/05/2018 12:48, Peter Maydell wrote:
> So I had an idea this morning for a slightly different way to approach
> this, which is that we add a concept of an iommu_idx, analogous to
> our existing TCG mmu_idx. Basically an iommu_idx represents a
> page table (kind of like what Arm calls a "transl
On 17/05/2018 14:44, Daniel P. Berrangé wrote:
>> +ifeq ($(CONFIG_X11),y)
>> +sdl.mo-objs += x_keymap.o
>> +gtk.mo-objs += x_keymap.o
> Would this cause symbol clash if both sdl & gtk modules are loaded
> at the same time, or have we used linker scripts to limit what symbols
> each module exposes ?
Hi,
> > +ifeq ($(CONFIG_X11),y)
> > +sdl.mo-objs += x_keymap.o
> > +gtk.mo-objs += x_keymap.o
>
> Would this cause symbol clash if both sdl & gtk modules are loaded
> at the same time, or have we used linker scripts to limit what symbols
> each module exposes ?
Related: can modules depend on m
On Thu, May 17, 2018 at 02:51:10PM +0200, Gerd Hoffmann wrote:
> Hi,
>
> > > +ifeq ($(CONFIG_X11),y)
> > > +sdl.mo-objs += x_keymap.o
> > > +gtk.mo-objs += x_keymap.o
> >
> > Would this cause symbol clash if both sdl & gtk modules are loaded
> > at the same time, or have we used linker scripts
1 - 100 of 309 matches
Mail list logo
