Re: [Qemu-devel] [PATCH 0/3] spapr: fix backward migration from POWER9 to POWER8 hosts

2018-05-04 Thread Greg Kurz
On Fri, 4 May 2018 16:37:19 +1000 David Gibson wrote: > On Fri, May 04, 2018 at 07:58:21AM +0200, Greg Kurz wrote: > > On Fri, 4 May 2018 10:11:02 +1000 > > David Gibson wrote: > > > > > On Thu, May 03, 2018 at 11:16:10PM +0200, Greg Kurz wrote: > > > > Hi, > > > > > > > > It is expected t

Re: [Qemu-devel] [PATCH 60/67] hw/s390x: add include directory headers

2018-05-04 Thread Cornelia Huck
On Thu, 3 May 2018 22:51:40 +0300 "Michael S. Tsirkin" wrote: > This way they are easier to find using standard rules. > > Signed-off-by: Michael S. Tsirkin > --- > include/hw/s390x/ccw-device.h| 1 + > include/hw/s390x/ipl.h | 1 + > include/hw/s390x/s390-pci-bus.h

[Qemu-devel] [PULL 01/15] s390x: introduce 2.13 compat machine

2018-05-04 Thread Cornelia Huck
Reviewed-by: Thomas Huth Reviewed-by: David Hildenbrand Acked-by: Christian Borntraeger Signed-off-by: Cornelia Huck --- hw/s390x/s390-virtio-ccw.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c inde

[Qemu-devel] [PULL 02/15] s390x/sclp: extend SCLP event masks to 64 bits

2018-05-04 Thread Cornelia Huck
From: Claudio Imbrenda Extend the SCLP event masks to 64 bits. Notice that using any of the new bits results in a state that cannot be migrated to an older version. Signed-off-by: Claudio Imbrenda Message-Id: <1520507069-22179-1-git-send-email-imbre...@linux.vnet.ibm.com> Acked-by: Christian B

[Qemu-devel] [PULL 05/15] hw/s390x: Allow to configure the consoles with the "-serial" parameter

2018-05-04 Thread Cornelia Huck
From: Thomas Huth The consoles ("sclpconsole" and "sclplmconsole") can only be configured with "-device" and "-chardev" so far. Other machines use the convenience option "-serial" to configure the default consoles, even for virtual consoles like spapr-vty on the pseries machine. So let's support

[Qemu-devel] [PULL 03/15] vfio-ccw: introduce vfio_ccw_get_device()

2018-05-04 Thread Cornelia Huck
From: Greg Kurz A recent patch fixed leaks of the dynamically allocated vcdev->vdev.name field in vfio_ccw_realize(), but we now have three freeing sites for it. This is unfortunate and seems to indicate something is wrong with its life cycle. The root issue is that vcdev->vdev.name is set befor

[Qemu-devel] [PULL 06/15] pc-bios/s390-ccw: size_t should be unsigned

2018-05-04 Thread Cornelia Huck
From: Thomas Huth "size_t" should be an unsigned type according to the C standard. Thus we should also use this convention in the s390-ccw firmware to avoid confusion. I checked the sources, and apart from one spot in libc.c, the code should all be fine with this change. Buglink: https://bugs.la

[Qemu-devel] [PULL 00/15] first s390x update for 2.13

2018-05-04 Thread Cornelia Huck
The following changes since commit 6f0c4706b35dead265509115ddbd2a8d1af516c1: Merge remote-tracking branch 'remotes/kraxel/tags/usb-20180427-pull-request' into staging (2018-04-27 12:27:59 +0100) are available in the Git repository at: git://github.com/cohuck/qemu tags/s390x-201

[Qemu-devel] [PULL 08/15] pc-bios/s390-ccw: fix loadparm initialization and int conversion

2018-05-04 Thread Cornelia Huck
From: Collin Walling Rename the loadparm char array in main.c to loadparm_str and increased the size by one byte to account for a null termination when converting the loadparm string to an int via atoui. We also allow the boot menu to be enabled when loadparm is set to an empty string or a serie

[Qemu-devel] [PULL 13/15] pc-bios/s390-ccw/net: Add support for .INS config files

2018-05-04 Thread Cornelia Huck
From: Thomas Huth The .INS config files can normally be found on CD-ROM ISO images, so by supporting these files, it is now possible to boot directly when the TFTP server is set up with the contents of such an CD-ROM image. Acked-by: Christian Borntraeger Signed-off-by: Thomas Huth --- pc-bio

[Qemu-devel] [PULL 12/15] pc-bios/s390-ccw/net: Use diag308 to reset machine before jumping to the OS

2018-05-04 Thread Cornelia Huck
From: Thomas Huth The netboot firmware so far simply jumped directly into the OS kernel after the download has been completed. This, however, bears the risk that the virtio-net device still might be active in the background and incoming packets are still placed into the buffers - which could dest

[Qemu-devel] [PULL 04/15] s390x/kvm: cleanup calls to cpu_synchronize_state()

2018-05-04 Thread Cornelia Huck
From: David Hildenbrand We have a call to cpu_synchronize_state() on every kvm_arch_handle_exit(). Let's remove the ones that are no longer needed. Remaining places (for s390x) are in - target/s390x/sigp.c, on the target CPU - target/s390x/cpu.c:s390_cpu_get_crash_info() While at it, use kvm_c

[Qemu-devel] [Bug 1769067] [NEW] virtio-net ignores the absence of the VIRTIO_NET_F_CTRL_VQ feature bit

2018-05-04 Thread Jakub Jermar
Public bug reported: When negotiating virtio-net feature bits, the device ignores the absence of the VIRTIO_NET_F_CTRL_VQ bit in driver feature bits and provides three virtqueues, including the control virtqueue, even though the driver is expecting only the receive and transmit virtqueues. Looking

[Qemu-devel] [PULL 07/15] pc-bios/s390-ccw: rename MAX_TABLE_ENTRIES to MAX_BOOT_ENTRIES

2018-05-04 Thread Cornelia Huck
From: Collin Walling The MAX_TABLE_ENTRIES constant has a name that is too generic. As we want to declare a limit for boot menu entries, let's rename it to a more fitting MAX_BOOT_ENTRIES and set its value to 31 (30 boot entries and 1 default entry). Also we move it from bootmap.h to s390-ccw.h t

[Qemu-devel] [PULL 11/15] pc-bios/s390-ccw/net: Split up net_load() into init, load and release parts

2018-05-04 Thread Cornelia Huck
From: Thomas Huth When we want to support pxelinux-style network booting later, we've got to do several TFTP transfers - and we do not want to apply for a new IP address via DHCP each time. So split up net_load into three parts: 1. net_init(), which initializes virtio-net, gets an IP address via

[Qemu-devel] [PULL 14/15] s390-ccw: force diag 308 subcode to unsigned long

2018-05-04 Thread Cornelia Huck
We currently pass an integer as the subcode parameter. However, the upper bits of the register containing the subcode need to be 0, which is not guaranteed unless we explicitly specify the subcode to be an unsigned long value. Fixes: d046c51dad3 ("pc-bios/s390-ccw: Get device address via diag 308/

[Qemu-devel] [PULL 09/15] pc-bios/s390-ccw: fix non-sequential boot entries (eckd)

2018-05-04 Thread Cornelia Huck
From: Collin Walling zIPL boot menu entries can be non-sequential. Let's account for this issue for the s390 zIPL boot menu. Since this boot menu is actually an imitation and is not completely capable of everything the real zIPL menu can do, let's also print a different banner to the user. Signe

[Qemu-devel] [PULL 15/15] pc-bios/s390: Update firmware images

2018-05-04 Thread Cornelia Huck
From: Thomas Huth s390-ccw.img contains fixes for the boot menu, and s390-netboot.img contains the support for .INS files and the patch for resetting the machine with diag308. Signed-off-by: Thomas Huth --- pc-bios/s390-ccw.img | Bin 30520 -> 34568 bytes pc-bios/s390-netboot.img | Bin 838

Re: [Qemu-devel] [PATCH 3/4] exec: extract address_space_translate_iommu, fix page_mask corner case

2018-05-04 Thread Paolo Bonzini
- Original Message - > From: "Peter Xu" > To: "Paolo Bonzini" > Cc: qemu-devel@nongnu.org > Sent: Friday, May 4, 2018 6:22:31 AM > Subject: Re: [Qemu-devel] [PATCH 3/4] exec: extract > address_space_translate_iommu, fix page_mask corner case > > On Tue, Apr 17, 2018 at 04:08:01PM +020

[Qemu-devel] [PULL 10/15] pc-bios/s390-ccw: fix non-sequential boot entries (enum)

2018-05-04 Thread Cornelia Huck
From: Collin Walling zIPL boot menu entries can be non-sequential. Let's account for this issue for the s390 enumerated boot menu. Since we can no longer print a range of available entries to the user, we have to present a list of each available entry. An example of this menu: s390-ccw Enumer

Re: [Qemu-devel] [PATCH v2 4/4] vfio/quirks: Enable ioeventfd quirks to be handled by vfio directly

2018-05-04 Thread Auger Eric
Hi Alex, On 05/03/2018 06:29 PM, Alex Williamson wrote: > On Thu, 3 May 2018 12:56:03 +0800 > Peter Xu wrote: > >> On Tue, May 01, 2018 at 10:43:46AM -0600, Alex Williamson wrote: >> >> [...] >> >>> -static void vfio_ioeventfd_exit(VFIOIOEventFD *ioeventfd) >>> +static void vfio_ioeventfd_exit(V

[Qemu-devel] [PATCH v6 4/4] tests: Use query-usernet instead of 'info usernet'

2018-05-04 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: Eric Blake --- tests/vm/basevm.py | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py index 3a2d508c35..dcfa6597ad 100755 --- a/tests/vm/basevm.py +++ b/tests/vm/basevm.py @@ -101,7 +101,

[Qemu-devel] [PATCH v6 1/4] qapi: Introduce UsernetTcpState

2018-05-04 Thread Fam Zheng
This will be a drop-in replacement for the current TCPS_ macro/enum and what we will return to users in the coming qmp command. The next patch will drop TCPS_ to avoid duplication and keep further refactoring simple. Signed-off-by: Fam Zheng --- qapi/net.json | 34 ++

[Qemu-devel] [PATCH v6 3/4] slirp: Add "query-usernet" QMP command

2018-05-04 Thread Fam Zheng
HMP "info usernet" has been available but it isn't ideal for programmed use cases. This closes the gap in QMP by adding a counterpart "query-usernet" command. It is basically translated from the HMP slirp_connection_info() loop, which now calls the QMP implementation and prints the data, just like

[Qemu-devel] [PATCH v6 2/4] slirp: Use QAPI enum to replace TCPS_* macros

2018-05-04 Thread Fam Zheng
This is a mechanical patch that does search-and-replace and adding necessary "#include" for pulling in the QAPI enum definition. The string lookup could use the QAPI helper, and is left for the next patch. Signed-off-by: Fam Zheng --- slirp/misc.c | 23 ++-- slirp/tcp.h | 21

[Qemu-devel] [PATCH v6 0/4] slirp: Add query-usernet QMP command

2018-05-04 Thread Fam Zheng
v6: Rename QAPI enum: TCPS -> UsernetTcpState. [Daniel] v5: Fix QAPI example in comments. [Eric] v4: vlan -> hub. [Samuel] Free 'info. [Samuel] v3: - Add Eric's rev-by to patch 2. - Address Eric's comments on patch 1: * Fix spell/grammar: "programmed", "awaiting". * Fix includ

Re: [Qemu-devel] [PATCH v3 5/6] vfio/quirks: ioeventfd quirk acceleration

2018-05-04 Thread Auger Eric
Hi, On 05/03/2018 11:45 PM, Alex Williamson wrote: > The NVIDIA BAR0 quirks virtualize the PCI config space mirrors found > in device MMIO space. Normally PCI config space is considered a slow > path and further optimization is unnecessary, however NVIDIA uses a > register here to enable the MSI

Re: [Qemu-devel] [PATCH v3 6/6] vfio/quirks: Enable ioeventfd quirks to be handled by vfio directly

2018-05-04 Thread Auger Eric
Hi, On 05/03/2018 11:45 PM, Alex Williamson wrote: > With vfio ioeventfd support, we can program vfio-pci to perform a > specified BAR write when an eventfd is triggered. This allows the > KVM ioeventfd to be wired directly to vfio-pci, entirely avoiding > userspace handling for these events. On

[Qemu-devel] [Bug 1769053] Re: Cannot start a guest with more than 1TB of RAM

2018-05-04 Thread ChristianEhrhardt
Hi Daniel, might I ask what you expect now? The changes to seabios are not even upstream yet in git://git.seabios.org/seabios.git The changes to qemu are neither upstream in git://git.qemu.org/qemu.git The changes linked also are for a qemu way++ back in time (like pre trusty), so they just don

[Qemu-devel] [PULL 02/10] qobject: Ensure base is at offset 0

2018-05-04 Thread Markus Armbruster
From: Marc-André Lureau All QObject types have the base QObject as their first field. This allows the simplification of qobject_to(). Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake Message-Id: <20180419150145.24795-2-marcandre.lur...@redhat.com> Reviewed-by: Markus Armbruster [Commi

[Qemu-devel] [PULL 00/10] QAPI patches for 2018-05-04

2018-05-04 Thread Markus Armbruster
The following changes since commit 59255887e6cafeff747250d2613003a41d1d9dff: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20180502' into staging (2018-05-03 11:25:14 +0100) are available in the git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2018-05-04 for you

[Qemu-devel] [PULL 07/10] qapi: add SysEmuTarget to "common.json"

2018-05-04 Thread Markus Armbruster
From: Laszlo Ersek We'll soon need an enumeration type that lists all the softmmu targets that QEMU (the project) supports. Introduce @SysEmuTarget to "common.json". The enum constant @x86_64 doesn't match the QAPI convention of preferring hyphen ("-") over underscore ("_"). This is intentional;

[Qemu-devel] [PULL 08/10] qapi: change the type of TargetInfo.arch from string to enum SysEmuTarget

2018-05-04 Thread Markus Armbruster
From: Laszlo Ersek Now that we have @SysEmuTarget, it makes sense to restrict @TargetInfo.@arch to valid sysemu targets at the schema level. Cc: "Daniel P. Berrange" Cc: Eric Blake Cc: Markus Armbruster Signed-off-by: Laszlo Ersek Reviewed-by: Markus Armbruster Reviewed-by: Eric Blake Mess

[Qemu-devel] [PULL 09/10] qapi: discriminate CpuInfoFast on SysEmuTarget, not CpuInfoArch

2018-05-04 Thread Markus Armbruster
From: Laszlo Ersek Add a new field @target (of type @SysEmuTarget) to the output of the @query-cpus-fast command, which provides more information about the emulation target than the field @arch (of type @CpuInfoArch). Make @target the new discriminator for the @CpuInfoFast return structure. Keep

[Qemu-devel] [PULL 05/10] qobject: Modify qobject_ref() to return obj

2018-05-04 Thread Markus Armbruster
From: Marc-André Lureau For convenience and clarity, make it possible to call qobject_ref() at the time when the reference is associated with a variable, or argument, by making qobject_ref() return the same pointer as given. Use that to simplify the callers. Signed-off-by: Marc-André Lureau Rev

[Qemu-devel] [PULL 10/10] qapi: deprecate CpuInfoFast.arch

2018-05-04 Thread Markus Armbruster
From: Laszlo Ersek The TARGET_BASE_ARCH values from "configure" don't all map to the @CpuInfoArch enum constants; in particular "s390x" from the former does not match @s390 in the latter. Clients are known to rely on the @s390 constant specifically, so we can't change it silently. Instead, deprec

[Qemu-devel] [PULL 01/10] qobject: Use qobject_to() instead of type cast

2018-05-04 Thread Markus Armbruster
The proper way to convert from (abstract) QObject to a (concrete) subtype is qobject_to(). Look for offenders that type cast instead: $ git-grep '(Q[A-Z][a-z]* \*)' hmp.c:qmp_device_add((QDict *)qdict, NULL, &err); include/qapi/qmp/qobject.h:return (QObject *)obj; qobj

Re: [Qemu-devel] [PATCH 21/67] trace: use local path for local headers

2018-05-04 Thread Stefan Hajnoczi
On Thu, May 03, 2018 at 10:50:59PM +0300, Michael S. Tsirkin wrote: > When pulling in headers that are in the same directory as C file (as > opposed to one in include/), we should use its relative path, without a > directory. Directory based path works more or less by accident. > > Signed-off-by:

[Qemu-devel] [PULL 03/10] qobject: use a QObjectBase_ struct

2018-05-04 Thread Markus Armbruster
From: Marc-André Lureau By moving the base fields to a QObjectBase_, QObject can be a type which also has a 'base' field. This allows writing a generic QOBJECT() macro that will work with any QObject type, including QObject itself. The container_of() macro ensures that the object to cast has a QO

[Qemu-devel] [PULL 06/10] qapi: fill in CpuInfoFast.arch in query-cpus-fast

2018-05-04 Thread Markus Armbruster
From: Laszlo Ersek * Commit ca230ff33f89 added the @arch field to @CpuInfoFast, but it failed to set the new field in qmp_query_cpus_fast(), when TARGET_S390X was not defined. The updated @query-cpus-fast example in "qapi-schema.json" showed "arch":"x86" only because qmp_query_cpus_fast() c

Re: [Qemu-devel] [PATCH v6 0/3] target/arm: Add a dynamic XML-description of the cp-registers to GDB

2018-05-04 Thread Abdallah Bouassida
> Abdallah Bouassida writes: > >> The previous version: >> http://patchwork.ozlabs.org/project/qemu-devel/list/?series=33714 > I was trying to do some testing but I was finding it very hard to do at > gdb kept throwing up errors like: > > (gdb) x/10i $pc > => 0xff8008097760 : Cannot acc

Re: [Qemu-devel] [PATCH v4 4/5] arm: boot: set boot_info starting from first_cpu

2018-05-04 Thread Igor Mammedov
On Thu, 3 May 2018 16:03:09 +0100 Peter Maydell wrote: > On 1 May 2018 at 14:44, Igor Mammedov wrote: > > Even though nothing is currently broken (since all boards > > use first_cpu as boot cpu), make sure that boot_info is set > > on all CPUs. > > If some board would like support heterogenuos s

Re: [Qemu-devel] [PATCH 06/67] trace: use local path for local headers

2018-05-04 Thread Stefan Hajnoczi
On Thu, May 03, 2018 at 10:50:28PM +0300, Michael S. Tsirkin wrote: > When pulling in headers that are in the same directory as C file (as > opposed to one in include/), we should use its relative path, without a > directory. Directory based path works more or less by accident. > > Signed-off-by:

Re: [Qemu-devel] release retrospective, next release timing, numbering

2018-05-04 Thread Stefan Hajnoczi
On Fri, May 04, 2018 at 07:29:20AM +0200, Markus Armbruster wrote: > Stefan Hajnoczi writes: > > So to clarify, three separate steps: > > > > 1. Get rid of target-specific #ifdefs > > 1. can be incremental. Something for > ? Some conversions are

Re: [Qemu-devel] [PATCH v6 0/3] target/arm: Add a dynamic XML-description of the cp-registers to GDB

2018-05-04 Thread Peter Maydell
On 3 May 2018 at 20:48, Alex Bennée wrote: > > Abdallah Bouassida writes: > >> The previous version: >> http://patchwork.ozlabs.org/project/qemu-devel/list/?series=33714 > > I was trying to do some testing but I was finding it very hard to do at > gdb kept throwing up errors like: > > (gdb) x/10i

Re: [Qemu-devel] release retrospective, next release timing, numbering

2018-05-04 Thread Peter Maydell
On 4 May 2018 at 09:16, Stefan Hajnoczi wrote: > On Fri, May 04, 2018 at 07:29:20AM +0200, Markus Armbruster wrote: >> Stefan Hajnoczi writes: >> > So to clarify, three separate steps: >> > >> > 1. Get rid of target-specific #ifdefs >> >> 1. can be incremental. Something for >>

Re: [Qemu-devel] [PULL 0/8] RDMA queue

2018-05-04 Thread Peter Maydell
On 3 May 2018 at 19:21, Marcel Apfelbaum wrote: > The following changes since commit 59255887e6cafeff747250d2613003a41d1d9dff: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20180502' into > staging (2018-05-03 11:25:14 +0100) > > are available in the Git repository at: > > https

[Qemu-devel] [Bug 1769053] Re: Cannot start a guest with more than 1TB of RAM

2018-05-04 Thread ChristianEhrhardt
Thanks for your clarification Daniel, I'll mark both tasks incomplete then until you come back with that data. ** Changed in: qemu (Ubuntu) Status: New => Incomplete ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qem

Re: [Qemu-devel] release retrospective, next release timing, numbering

2018-05-04 Thread Stefan Hajnoczi
On Thu, May 03, 2018 at 07:50:41PM +0100, Dr. David Alan Gilbert wrote: > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > On Thu, May 03, 2018 at 04:16:41PM +0200, Cédric Le Goater wrote: > > > Coming back to the initial motivation that Peter pointed out, would > > > the goal to be able to run v

[Qemu-devel] [PATCH v7 01/11] numa: postpone options post-processing till machine_run_board_init()

2018-05-04 Thread Igor Mammedov
in preparation for numa options to being handled via QMP before machine_run_board_init(), move final numa configuration checks and processing to machine_run_board_init() so it could take into account both CLI (via parse_numa_opts()) and QMP input Signed-off-by: Igor Mammedov Reviewed-by: Eduardo

[Qemu-devel] [PATCH v7 04/11] hmp: disable monitor in preconfig state

2018-05-04 Thread Igor Mammedov
Ban it for now, if someone would need it to work early, one would have to implement checks if HMP command is valid at preconfig state. Signed-off-by: Igor Mammedov Reviewed-by: Eric Blake --- v5: * add 'use QMP instead" to error message, suggesting user the right interface to use v4: * v

[Qemu-devel] [PATCH v7 02/11] numa: split out NumaOptions parsing into set_numa_options()

2018-05-04 Thread Igor Mammedov
it will allow to reuse set_numa_options() for parsing configuration commands received via QMP interface Signed-off-by: Igor Mammedov --- v5: - (Eduardo Habkost ) * drop if (err) guard around error_propagate() * s/parse_NumaOptions/set_numa_options/ --- include/sysemu/numa.h | 1 + num

[Qemu-devel] [PATCH v7 06/11] tests: qapi-schema tests for allow-preconfig

2018-05-04 Thread Igor Mammedov
use new allow-preconfig parameter in tests and make sure that the QAPISchema can parse allow-preconfig correctly Signed-off-by: Igor Mammedov v7: * s/allowed_in_preconfig/allow_preconfig/ * squash in "tests: add allow-preconfig-test for qapi-schema" * reuse an-oob-command for allow-preconfi

[Qemu-devel] [PATCH v7 03/11] qapi: introduce preconfig runstate

2018-05-04 Thread Igor Mammedov
New preconfig runstate will be used in follow up patches related to introducing --preconfig CLI option and is intended to replace prelaunch runstate from QEMU start up to machine_init callback. Signed-off-by: Igor Mammedov --- qapi/run-state.json | 5 - 1 file changed, 4 insertions(+), 1 del

[Qemu-devel] [PATCH v7 00/11] enable numa configuration before machine_init() from QMP

2018-05-04 Thread Igor Mammedov
v6->v7: * fix up wording in documentation and left-overs of 'reusing' 'cont' command in v5 * split out preconfig runstate introduction into separate patch to make series more bisection friendly and put allow-preconfig patch before --preconfig CLI patch * merge qapi schema tests pat

[Qemu-devel] [PATCH v7 08/11] tests: extend qmp test with preconfig checks

2018-05-04 Thread Igor Mammedov
Add permission checks for commands at 'preconfig' stage. Signed-off-by: Igor Mammedov --- v6: * replace 'cont' with 'exit-preconfig' command v5: * s/-preconfig/--preconfig/ v4: * s/is_err()/qmp_rsp_is_err()/ * return true even if 'error' doesn't contain 'desc' (Eric Blake ) --- tests

[Qemu-devel] [PATCH v7 05/11] qapi: introduce new cmd option "allowed-in-preconfig"

2018-05-04 Thread Igor Mammedov
New option will be used to allow commands, which are prepared/need to run, during preconfig state. Other commands that should be able to run in preconfig state, should be amended to not expect machine in initialized state or deal with it. For compatibility reasons, commands that don't use new flag

[Qemu-devel] [PATCH v7 11/11] tests: functional tests for QMP command set-numa-node

2018-05-04 Thread Igor Mammedov
* start QEMU with 2 unmapped cpus, * while in preconfig state * add 2 numa nodes * assign cpus to them * exit preconfig and in running state check that cpus are mapped correctly. Signed-off-by: Igor Mammedov --- v6: * replace 'cont' with 'exit-preconfig' command v5: * s/qobject_

[Qemu-devel] [PATCH v7 07/11] cli: add --preconfig option

2018-05-04 Thread Igor Mammedov
This option allows pausing QEMU in the new RUN_STATE_PRECONFIG state, allowing the configuration of QEMU from QMP before the machine jumps into board initialization code of machine_run_board_init() The intent is to allow management to query machine state and additionally configure it using previou

[Qemu-devel] [PATCH v7 09/11] qmp: permit query-hotpluggable-cpus in preconfig state

2018-05-04 Thread Igor Mammedov
it will allow mgmt to query possible CPUs, which depends on used machine(version)/-smp options, without restarting QEMU and use results to configure numa mapping or adding CPUs with device_add* later. Signed-off-by: Igor Mammedov PS: *) device_add is not allowed to run at preconfig in this serie

[Qemu-devel] [PATCH v7 10/11] qmp: add set-numa-node command

2018-05-04 Thread Igor Mammedov
Command is allowed to run only in preconfig stage and will allow to configure numa mapping for CPUs depending on possible CPUs layout (query-hotpluggable-cpus) for given machine instance. Example of configuration session: $QEMU -smp 2 --preconfig ... QMP: -> {'execute': 'query-hotpluggable-cpus'

Re: [Qemu-devel] [PATCH v1 0/8] MemoryDevice: introduce and use ResourceHandler

2018-05-04 Thread Igor Mammedov
On Thu, 3 May 2018 17:49:28 +0200 David Hildenbrand wrote: > Hotplug handlers usually have the following tasks: > 1. Allocate some resources for a new device > 2. Make the new device visible for the guest > 3. Notify the guest about the new device > > Hotplug handlers have right now one limitat

Re: [Qemu-devel] release retrospective, next release timing, numbering

2018-05-04 Thread Stefan Hajnoczi
On Thu, May 03, 2018 at 11:52:20PM +0200, Laurent Vivier wrote: > Le 01/05/2018 à 14:24, Stefan Hajnoczi a écrit : > > On Fri, Apr 27, 2018 at 04:51:03PM +0100, Peter Maydell wrote: > >> (2) release timing: > >> * usual schedule would give us a next release mid-to-late August > >> * unless I can

Re: [Qemu-devel] [PATCH 1/3] nvdimm: fix typo in label-size definition

2018-05-04 Thread Stefan Hajnoczi
On Thu, May 03, 2018 at 04:20:13PM -0600, Ross Zwisler wrote: > On Mon, Apr 30, 2018 at 12:38:58PM +0100, Stefan Hajnoczi wrote: > > On Fri, Apr 27, 2018 at 03:53:12PM -0600, Ross Zwisler wrote: > > > Signed-off-by: Ross Zwisler > > > Fixes: commit da6789c27c2e ("nvdimm: add a macro for property

[Qemu-devel] [PATCH] ppc440_pcix: Fix a typo in setting a register (Coverity CID1390577)

2018-05-04 Thread BALATON Zoltan
Signed-off-by: BALATON Zoltan --- hw/ppc/ppc440_pcix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/ppc440_pcix.c b/hw/ppc/ppc440_pcix.c index b1307e6..d8af04b 100644 --- a/hw/ppc/ppc440_pcix.c +++ b/hw/ppc/ppc440_pcix.c @@ -257,7 +257,7 @@ static void ppc440_pcix_re

Re: [Qemu-devel] [PATCH v3 3/3] virtio-pmem: should we make it migratable???

2018-05-04 Thread Igor Mammedov
On Thu, 26 Apr 2018 03:37:51 -0400 (EDT) Pankaj Gupta wrote: trimming CC list to keep people that might be interested in the topic and renaming thread to reflect it. > > > > > > > >> + > > > > > > > >> +memory_region_add_subregion(&hpms->mr, addr - hpms->base, > > > > > > > >> mr); > > > >

Re: [Qemu-devel] [PULL 0/6] Linux user for 2.13 patches

2018-05-04 Thread Peter Maydell
On 3 May 2018 at 22:38, Laurent Vivier wrote: > The following changes since commit 59255887e6cafeff747250d2613003a41d1d9dff: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20180502' into > staging (2018-05-03 11:25:14 +0100) > > are available in the Git repository at: > > git://g

[Qemu-devel] [PATCH] configure: Add explanation for --enable-xen-pci-passthrough

2018-05-04 Thread Anthony PERARD
Signed-off-by: Anthony PERARD --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 1443422e83..e961473e76 100755 --- a/configure +++ b/configure @@ -1586,7 +1586,7 @@ disabled with --disable-FEATURE, default is enabled if available: vir

Re: [Qemu-devel] [PATCH v1 0/8] MemoryDevice: introduce and use ResourceHandler

2018-05-04 Thread David Hildenbrand
On 04.05.2018 10:49, Igor Mammedov wrote: > On Thu, 3 May 2018 17:49:28 +0200 > David Hildenbrand wrote: > >> Hotplug handlers usually have the following tasks: >> 1. Allocate some resources for a new device >> 2. Make the new device visible for the guest >> 3. Notify the guest about the new dev

Re: [Qemu-devel] [PATCH 27/67] replication: add include directory header

2018-05-04 Thread Daniel P . Berrangé
On Thu, May 03, 2018 at 10:51:05PM +0300, Michael S. Tsirkin wrote: > This way it is easier to find using standard rules. > > Signed-off-by: Michael S. Tsirkin > --- > include/replication.h | 1 + > 1 file changed, 1 insertion(+) > create mode 100644 include/replication.h > > diff --git a/incl

Re: [Qemu-devel] [PATCH v3 3/3] virtio-pmem: should we make it migratable???

2018-05-04 Thread David Hildenbrand
On 04.05.2018 11:13, Igor Mammedov wrote: > On Thu, 26 Apr 2018 03:37:51 -0400 (EDT) > Pankaj Gupta wrote: > > trimming CC list to keep people that might be interested in the topic > and renaming thread to reflect it. > >> + >> +memory_region_add_subregion(&hpms->mr, addr - h

Re: [Qemu-devel] [PATCH 01/67] block: use local path for local headers

2018-05-04 Thread Daniel P . Berrangé
On Thu, May 03, 2018 at 10:50:20PM +0300, Michael S. Tsirkin wrote: > When pulling in headers that are in the same directory as C file (as > opposed to one in include/), we should use its relative path, without a > directory. Directory based path works more or less by accident. This commit message

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target/ppc: only save guest timebase once after stopping

2018-05-04 Thread Greg Kurz
On Thu, 3 May 2018 23:20:44 -0500 Michael Roth wrote: > In some cases (e.g. spapr) we record guest timebase after qmp_stop() > via a runstate hook so we can restore it on qmp_cont(). If a migration > occurs in between those events we end up saving it again, this time > based on the current timeb

[Qemu-devel] [PATCH] libvhost-user: Send messages with no data

2018-05-04 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The response to a VHOST_USER_POSTCOPY_ADVISE contains a fd but doesn't actually contain any data. FIx vu_message_write so that it doesn't do a 0-byte write() call, since this was ending up with rc=0 that was confusing the error handling code. Signed-off-by: Dr. D

Re: [Qemu-devel] [PATCH] libvhost-user: Send messages with no data

2018-05-04 Thread Marc-André Lureau
On Fri, May 4, 2018 at 11:53 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The response to a VHOST_USER_POSTCOPY_ADVISE contains a fd but doesn't > actually contain any data. FIx vu_message_write so that it doesn't > do a 0-byte write() call, since this was ending

Re: [Qemu-devel] [PATCH v1 0/8] MemoryDevice: introduce and use ResourceHandler

2018-05-04 Thread Igor Mammedov
On Fri, 4 May 2018 11:19:25 +0200 David Hildenbrand wrote: > On 04.05.2018 10:49, Igor Mammedov wrote: > > On Thu, 3 May 2018 17:49:28 +0200 > > David Hildenbrand wrote: > > > >> Hotplug handlers usually have the following tasks: > >> 1. Allocate some resources for a new device > >> 2. Make

[Qemu-devel] [PATCH] softfloat: Handle default NaN mode after pickNaNMulAdd, not before

2018-05-04 Thread Peter Maydell
It is implementation defined whether a multiply-add of (0,inf,qnan) or (inf,0,qnan) raises InvalidaOperation or not, so we let the target-specific pickNaNMulAdd function handle this. This means that we must do the "return the default NaN in default NaN mode" check after the call, not before. Correc

Re: [Qemu-devel] [PATCH] nbd/client: Relax handling of large NBD_CMD_BLOCK_STATUS reply

2018-05-04 Thread Vladimir Sementsov-Ogievskiy
04.05.2018 01:26, Eric Blake wrote: The NBD spec is proposing a relaxation of NBD_CMD_BLOCK_STATUS where a server may have the final extent per context give a length beyond the original request, if it can easily prove that subsequent bytes have the same status, on the grounds that a client can ta

[Qemu-devel] [PATCH] rename included C files to foo.inc.c, remove osdep.h

2018-05-04 Thread Paolo Bonzini
osdep.h is only needed for files that are compiled directly. Remove it from included C source files, and rename them to *.inc.c so that scripts/clean-includes knows to skip them. Cc: Eric Blake Cc: Michael S. Tsirkin Signed-off-by: Paolo Bonzini --- target/cris/translate.c

Re: [Qemu-devel] [PULL 00/17] ppc-for-2.13 queue 20180504

2018-05-04 Thread Peter Maydell
Git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-2.13-20180504 > > for you to fetch changes up to 0550b1206a91d66051a21441a02c4ff126b531fe: > > spapr: don't advertise radix GTSE if ma

Re: [Qemu-devel] [PATCH] configure: Add explanation for --enable-xen-pci-passthrough

2018-05-04 Thread Markus Armbruster
Anthony PERARD writes: > Signed-off-by: Anthony PERARD > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 1443422e83..e961473e76 100755 > --- a/configure > +++ b/configure > @@ -1586,7 +1586,7 @@ disabled with --disable-FEATU

Re: [Qemu-devel] [PATCH v1 0/8] MemoryDevice: introduce and use ResourceHandler

2018-05-04 Thread David Hildenbrand
>> Note how virtio-mem implements the MemoryDevice interface and how >> resource assignments happens without any layer violations (and no >> modifications to any hotplug handler). > Thanks, that should be sufficient to get idea. > I'll look into it and come back here with concrete comments or > su

Re: [Qemu-devel] [PATCH v3 3/3] virtio-pmem: should we make it migratable???

2018-05-04 Thread Pankaj Gupta
> > > >> + > >> +memory_region_add_subregion(&hpms->mr, addr - hpms->base, > >> mr); > > missing vmstate registration? > > Missed this one: To be called by the caller. Important because e.g. > for > virtio-pmem we don't want

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target/ppc: only save guest timebase once after stopping

2018-05-04 Thread Michael Roth
Quoting Greg Kurz (2018-05-04 04:37:24) > On Thu, 3 May 2018 23:20:44 -0500 > Michael Roth wrote: > > > In some cases (e.g. spapr) we record guest timebase after qmp_stop() > > via a runstate hook so we can restore it on qmp_cont(). If a migration > > occurs in between those events we end up sav

Re: [Qemu-devel] [PATCH v2 2/3] fpu/softfloat: support ARM Alternative half-precision

2018-05-04 Thread Alex Bennée
Richard Henderson writes: > On 05/03/2018 11:17 AM, Peter Maydell wrote: >> (target/i386 notably does not do this, we should check how >> SSE and x87 handle NaNs in fp conversions first.) > > Hardware does silence NaNs. I tested that earlier: > > https://lists.gnu.org/archive/html/qemu-devel/20

Re: [Qemu-devel] [PATCH v3 3/3] virtio-pmem: should we make it migratable???

2018-05-04 Thread Dr. David Alan Gilbert
* Igor Mammedov (imamm...@redhat.com) wrote: > On Thu, 26 Apr 2018 03:37:51 -0400 (EDT) > Pankaj Gupta wrote: > > trimming CC list to keep people that might be interested in the topic > and renaming thread to reflect it. > > > > > > > > > >> + > > > > > > > > >> +memory_region_add_subregion(

Re: [Qemu-devel] [Bug 1769053] Re: Cannot start a guest with more than 1TB of RAM

2018-05-04 Thread Daniel Axtens
Hi Christian, Sorry, I should have been a *lot* more clear. I wanted to file the bug so that we have somewhere to figure out what needs to be done and track the progress - trying to avoid it becoming something we vaguely know about but don't ever do anything about. Thanks so much for your analys

[Qemu-devel] [Bug 1769053] Re: Cannot start a guest with more than 1TB of RAM

2018-05-04 Thread Daniel Axtens
** Also affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1769053 Title: Cannot start a guest with more than 1TB of RAM Status in QEMU: New

Re: [Qemu-devel] [PULL 00/15] first s390x update for 2.13

2018-05-04 Thread Peter Maydell
ilable in the Git repository at: > > git://github.com/cohuck/qemu tags/s390x-20180504 > > for you to fetch changes up to 532cd4b067d37b96496dbacbfab6c990c063d33d: > > Merge tag 'tags/s390x-2018-05-02' into staging (2018-05-03 16:33:01 +0200) > > -

Re: [Qemu-devel] [PATCH] Revert "Makefile: add target to print generated files"

2018-05-04 Thread Eric Blake
On 05/04/2018 12:42 AM, Markus Armbruster wrote: This reverts commit 9578f8cc3e8bd71de8e3f543dc7b95644d64824e. The patch snuck in by accident without having been posted to qemu-devel. It's entirely redundant: existing target print-% already serves the purpose. Cc: Michael S. Tsirkin Signed-of

Re: [Qemu-devel] [PATCH v3 04/35] spapr/xive: introduce a XIVE interrupt controller for sPAPR

2018-05-04 Thread Cédric Le Goater
On 05/04/2018 05:33 AM, David Gibson wrote: > On Thu, May 03, 2018 at 06:50:09PM +0200, Cédric Le Goater wrote: >> On 05/03/2018 07:22 AM, David Gibson wrote: >>> On Thu, Apr 26, 2018 at 12:43:29PM +0200, Cédric Le Goater wrote: On 04/26/2018 06:20 AM, David Gibson wrote: > On Tue, Apr 24,

[Qemu-devel] cover letter cc's [was: [PATCH 60/67] hw/s390x: add include directory headers]

2018-05-04 Thread Eric Blake
[adding a cross-post to the git mailing list] On 05/04/2018 02:10 AM, Cornelia Huck wrote: On Thu, 3 May 2018 22:51:40 +0300 "Michael S. Tsirkin" wrote: This way they are easier to find using standard rules. Signed-off-by: Michael S. Tsirkin --- ... [Goes to find cover letter to figure o

Re: [Qemu-devel] [PATCH] libvhost-user: Send messages with no data

2018-05-04 Thread Eric Blake
On 05/04/2018 04:53 AM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" The response to a VHOST_USER_POSTCOPY_ADVISE contains a fd but doesn't s/a fd/an fd/ ? Depends on whether you pronounce it "eff-dee" or "file-descriptor". actually contain any data. FIx vu_message

Re: [Qemu-devel] [PATCH v3 06/35] spapr/xive: introduce a XIVE interrupt presenter model

2018-05-04 Thread Cédric Le Goater
On 05/04/2018 06:51 AM, David Gibson wrote: > On Thu, May 03, 2018 at 06:06:14PM +0200, Cédric Le Goater wrote: >> On 05/03/2018 07:35 AM, David Gibson wrote: >>> On Thu, Apr 26, 2018 at 11:27:21AM +0200, Cédric Le Goater wrote: On 04/26/2018 09:11 AM, David Gibson wrote: > On Thu, Apr 19,

Re: [Qemu-devel] [PATCH] rename included C files to foo.inc.c, remove osdep.h

2018-05-04 Thread Eric Blake
On 05/04/2018 05:51 AM, Paolo Bonzini wrote: osdep.h is only needed for files that are compiled directly. Remove it from included C source files, and rename them to *.inc.c so that scripts/clean-includes knows to skip them. Cc: Eric Blake Cc: Michael S. Tsirkin Signed-off-by: Paolo Bonzini --

[Qemu-devel] [PATCH] s390x/css: disabled subchannels cannot be status pending

2018-05-04 Thread Cornelia Huck
The 3270 code will try to post an attention interrupt when the 3270 emulator (e.g. x3270) attaches. If the guest has not yet enabled the subchannel for the 3270 device, we will give it a spurious status during msch when it does so later. To fix this, just don't do anything in css_conditional_io_in

Re: [Qemu-devel] [PATCH] nbd/client: Relax handling of large NBD_CMD_BLOCK_STATUS reply

2018-05-04 Thread Eric Blake
On 05/04/2018 05:40 AM, Vladimir Sementsov-Ogievskiy wrote: 04.05.2018 01:26, Eric Blake wrote: The NBD spec is proposing a relaxation of NBD_CMD_BLOCK_STATUS where a server may have the final extent per context give a length beyond the original request, if it can easily prove that subsequent by

Re: [Qemu-devel] release retrospective, next release timing, numbering

2018-05-04 Thread Kevin Wolf
Am 03.05.2018 um 15:43 hat Gerd Hoffmann geschrieben: > On Thu, May 03, 2018 at 10:26:40AM +0100, Peter Maydell wrote: > > On 3 May 2018 at 10:07, Daniel P. Berrangé wrote: > > > On Thu, May 03, 2018 at 08:21:00AM +0100, Stefan Hajnoczi wrote: > > >> I don't see an issue with time-based numbering

Re: [Qemu-devel] cover letter cc's [was: [PATCH 60/67] hw/s390x: add include directory headers]

2018-05-04 Thread Cornelia Huck
On Fri, 4 May 2018 08:07:53 -0500 Eric Blake wrote: > [adding a cross-post to the git mailing list] > > On 05/04/2018 02:10 AM, Cornelia Huck wrote: > > On Thu, 3 May 2018 22:51:40 +0300 > > "Michael S. Tsirkin" wrote: > > > >> This way they are easier to find using standard rules. > >> > >>

Re: [Qemu-devel] [PATCH v3 07/35] spapr/xive: introduce the XIVE Event Queues

2018-05-04 Thread Cédric Le Goater
On 05/04/2018 07:19 AM, David Gibson wrote: > On Thu, May 03, 2018 at 04:37:29PM +0200, Cédric Le Goater wrote: >> On 05/03/2018 08:25 AM, David Gibson wrote: >>> On Thu, May 03, 2018 at 08:07:54AM +0200, Cédric Le Goater wrote: On 05/03/2018 07:45 AM, David Gibson wrote: > On Thu, Apr 26,

  1   2   3   4   >