Re: [Qemu-devel] [PATCH v4 2/4] monitor: protect mon->fds with mon_lock

2018-05-02 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > mon->fds were protected by BQL. Now protect it by mon_lock so that it > can even be used in monitor iothread. > > Signed-off-by: Peter Xu > --- > monitor.c | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/monitor.c b/m

Re: [Qemu-devel] [PATCH v4 2/4] monitor: protect mon->fds with mon_lock

2018-05-02 Thread Peter Xu
On Wed, May 02, 2018 at 12:15:07PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > mon->fds were protected by BQL. Now protect it by mon_lock so that it > > can even be used in monitor iothread. > > > > Signed-off-by: Peter Xu > > --- > > monitor.c | 11

Re: [Qemu-devel] Expand ECAM region in machvirt 2_13?

2018-05-02 Thread Laszlo Ersek
On 05/01/18 17:59, Auger Eric wrote: > Hi, > > I would like to resume the discussion on extending the number of PCI > buses to 256 (as in Q35) as a follow-up of past discussions: > https://lists.gnu.org/archive/html/qemu-devel/2018-01/msg03631.html. > > With the current 16MB ECAM region we are li

Re: [Qemu-devel] release retrospective, next release timing, numbering

2018-05-02 Thread Peter Maydell
On 2 May 2018 at 11:41, Laszlo Ersek wrote: > What about guest RAM size (more precisely, guest-phys address space)? > > The x86_64 target might want to use tens of GBs of guest-phys address > space, e.g. for cold-plugged RAM, for DIMM hotplug, for 64-bit PCI MMIO > aperture. To my understanding, a

Re: [Qemu-devel] [PATCH v8 5/8] tests: Migration ppc now inlines its program

2018-05-02 Thread Laurent Vivier
On 25/04/2018 13:19, Juan Quintela wrote: > No need to write it to a file. Just need a proper firmware O:-) > > Signed-off-by: Juan Quintela > CC: Laurent Vivier > --- > tests/migration-test.c | 41 + > 1 file changed, 5 insertions(+), 36 deletions(-) R

Re: [Qemu-devel] release retrospective, next release timing, numbering

2018-05-02 Thread Daniel P . Berrangé
On Fri, Apr 27, 2018 at 06:42:07PM +0200, Thomas Huth wrote: > On 27.04.2018 18:24, Peter Maydell wrote: > > On 27 April 2018 at 17:17, Thomas Huth wrote: > >> By the way, just another crazy idea for v3.0 (i.e. feel free to turn it > >> down immediately ;-)): Since compilation and testing time for

Re: [Qemu-devel] [PATCH] Migration+TLS: Fix crash due to double cleanup

2018-05-02 Thread Peter Krempa
On Mon, Apr 30, 2018 at 19:59:43 +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > During a TLS connect we see: > migration_channel_connect calls > migration_tls_channel_connect > (calls after TLS setup) > migration_channel_connect > > My previous error hand

Re: [Qemu-devel] release retrospective, next release timing, numbering

2018-05-02 Thread Peter Maydell
On 2 May 2018 at 12:58, Daniel P. Berrangé wrote: > I'm curious what is the compelling benefit of having a single fat QEMU > binary that included all archiectures at once ? The motivation is "I want to model a board with an SoC that has both Arm cores and Microblaze cores". One binary seems the m

Re: [Qemu-devel] [PATCH] Migration+TLS: Fix crash due to double cleanup

2018-05-02 Thread Daniel P . Berrangé
On Mon, Apr 30, 2018 at 07:59:43PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > During a TLS connect we see: > migration_channel_connect calls > migration_tls_channel_connect > (calls after TLS setup) > migration_channel_connect > > My previous error ha

Re: [Qemu-devel] Expand ECAM region in machvirt 2_13?

2018-05-02 Thread Ard Biesheuvel
On 2 May 2018 at 13:31, Laszlo Ersek wrote: > On 05/01/18 17:59, Auger Eric wrote: >> Hi, >> >> I would like to resume the discussion on extending the number of PCI >> buses to 256 (as in Q35) as a follow-up of past discussions: >> https://lists.gnu.org/archive/html/qemu-devel/2018-01/msg03631.htm

Re: [Qemu-devel] [PATCH 1/2] block/mirror: Make cancel always cancel pre-READY

2018-05-02 Thread Max Reitz
On 2018-05-02 01:31, Eric Blake wrote: > On 05/01/2018 05:05 PM, Max Reitz wrote: >> Commit b76e4458b1eb3c32e9824fe6aa51f67d2b251748 made the mirror block >> job respect block-job-cancel's @force flag: With that flag set, it would >> now always really cancel, even post-READY. >> >> Unfortunately, i

Re: [Qemu-devel] [PATCH qemu] qom: Document qom/device-list-properties implementation specific

2018-05-02 Thread Markus Armbruster
Paolo Bonzini writes: > On 02/05/2018 11:38, Markus Armbruster wrote: > It probably is not unless someone adds properties in realize() callback, Now work that into the doc comment, please :) >>> Are there any examples? >> There must be examples where instances of the same type have diffe

Re: [Qemu-devel] [PATCH qemu] qom: Document qom/device-list-properties implementation specific

2018-05-02 Thread Paolo Bonzini
On 02/05/2018 14:36, Markus Armbruster wrote: >> The purpose of this command is to tell people/tools what they can pass >> to -device/-object/device_add/object_add, so the real question is >> whether there are cases where it falls short of that purpose. >> >> If not, > > Do we have to be certain?

[Qemu-devel] [PATCH] s390-ccw: force diag 308 subcode to unsigned long

2018-05-02 Thread Cornelia Huck
We currently pass an integer as the subcode parameter. However, the upper bits of the register containing the subcode need to be 0, which is not guaranteed unless we explicitly specify the subcode to be an unsigned long value. Fixes: d046c51dad3 ("pc-bios/s390-ccw: Get device address via diag 308/

Re: [Qemu-devel] [PATCH] s390-ccw: force diag 308 subcode to unsigned long

2018-05-02 Thread Christian Borntraeger
On 05/02/2018 02:52 PM, Cornelia Huck wrote: > We currently pass an integer as the subcode parameter. However, > the upper bits of the register containing the subcode need to > be 0, which is not guaranteed unless we explicitly specify the > subcode to be an unsigned long value. > > Fixes: d046c

Re: [Qemu-devel] [RFC PATCH 02/12] tests/tcg/tricore: Add build infrastructure

2018-05-02 Thread Alex Bennée
Bastian Koppelmann writes: > On 05/01/2018 06:48 PM, Bastian Koppelmann wrote: >> Hi Alex, >> >> On 05/01/2018 05:40 PM, Alex Bennée wrote: >>> Bastian Koppelmann writes: >>> this includes the Makefile and linker script to build all the tests. Signed-off-by: Bastian Koppelmann >

Re: [Qemu-devel] [RFC] Intermediate block mirroring

2018-05-02 Thread Alberto Garcia
On Wed 25 Apr 2018 04:03:22 PM CEST, Max Reitz wrote: >>> But the question stands whether we need simple node replacement when >>> we want bdrv_reopen() anyway. In addition, we don't need just >>> replacement, we also need addition and removal (e.g. for backing >>> files or quorum children) -- and

Re: [Qemu-devel] [PATCH v6 4/5] qobject: modify qobject_ref() to return obj

2018-05-02 Thread Eric Blake
On 04/27/2018 06:42 AM, Markus Armbruster wrote: +++ b/include/qapi/qmp/qobject.h @@ -72,11 +72,12 @@ static inline void qobject_init(QObject *obj, QType type) obj->base.type = type; } -static inline void qobject_ref_impl(QObject *obj) +static inline void *qobject_ref_impl(QObject *o

[Qemu-devel] ping Re: [PATCH v6 0/3] target/arm: Add a dynamic XML-description of the cp-registers to GDB

2018-05-02 Thread Abdallah Bouassida
ping Le 4/19/2018 à 4:56 PM, Abdallah Bouassida a écrit : > The previous version: > http://patchwork.ozlabs.org/project/qemu-devel/list/?series=33714 > > Abdallah Bouassida (3): > target/arm: Add "ARM_CP_NO_GDB" as a new bit field for ARMCPRegInfo > type > target/arm: Add "_S" suffix to th

Re: [Qemu-devel] [PATCH qemu] qom: Document qom/device-list-properties implementation specific

2018-05-02 Thread Markus Armbruster
Paolo Bonzini writes: > On 02/05/2018 14:36, Markus Armbruster wrote: >>> The purpose of this command is to tell people/tools what they can pass >>> to -device/-object/device_add/object_add, so the real question is >>> whether there are cases where it falls short of that purpose. >>> >>> If not,

Re: [Qemu-devel] [PATCH qemu] qom: Document qom/device-list-properties implementation specific

2018-05-02 Thread Paolo Bonzini
On 02/05/2018 15:31, Markus Armbruster wrote: >> We do have infrastructure for class properties, we just don't use it much. > ... the sane thing to do would be to limit this command to class > properties, and use class properties for anything that doesn't *have* to > be dynamic. The second half of

Re: [Qemu-devel] [PATCH] s390-ccw: force diag 308 subcode to unsigned long

2018-05-02 Thread Thomas Huth
On 02.05.2018 14:52, Cornelia Huck wrote: > We currently pass an integer as the subcode parameter. However, > the upper bits of the register containing the subcode need to > be 0, which is not guaranteed unless we explicitly specify the > subcode to be an unsigned long value. > > Fixes: d046c51dad

[Qemu-devel] [PATCH] qemu-img: return allocated size for block device with qcow2 format

2018-05-02 Thread Ivan Ren
qemu-img info with a block device which has a qcow2 format always return 0 for disk size, and this can not reflect the qcow2 size and the used space of the block device. This patch return the allocated size of qcow2 as the disk size. Signed-off-by: Ivan Ren --- block/qcow2-bitmap.c | 69 +++

Re: [Qemu-devel] [PATCH v8 5/8] tests: Migration ppc now inlines its program

2018-05-02 Thread Thomas Huth
On 25.04.2018 13:19, Juan Quintela wrote: > No need to write it to a file. Just need a proper firmware O:-) > > Signed-off-by: Juan Quintela > CC: Laurent Vivier > --- > tests/migration-test.c | 41 + > 1 file changed, 5 insertions(+), 36 deletions(-) R

Re: [Qemu-devel] Expand ECAM region in machvirt 2_13?

2018-05-02 Thread Laszlo Ersek
On 05/02/18 14:34, Ard Biesheuvel wrote: > On 2 May 2018 at 13:31, Laszlo Ersek wrote: >> On 05/01/18 17:59, Auger Eric wrote: >>> Hi, >>> >>> I would like to resume the discussion on extending the number of PCI >>> buses to 256 (as in Q35) as a follow-up of past discussions: >>> https://lists.gnu

Re: [Qemu-devel] [PATCH v2] timer/aspeed: fix vmstate version id

2018-05-02 Thread Cédric Le Goater
> for a romulus-bmc machine, which uses a ARM1176 CPU, you can download this > image : > > > https://openpower.xyz/job/openbmc-build/distro=ubuntu,target=romulus/lastSuccessfulBuild/artifact/deploy/images/romulus/flash-romulus > > but migration fails : > > qemu-system-arm: error while load

Re: [Qemu-devel] [PATCH] qemu-img: return allocated size for block device with qcow2 format

2018-05-02 Thread Eric Blake
On 05/02/2018 08:34 AM, Ivan Ren wrote: qemu-img info with a block device which has a qcow2 format always return 0 for disk size, and this can not reflect the qcow2 size and the used space of the block device. This patch return the allocated size of qcow2 as the disk size. How does this differ

[Qemu-devel] [PATCH] block: Document BDRV_REQ_WRITE_UNCHANGED support

2018-05-02 Thread Max Reitz
Add BDRV_REQ_WRITE_UNCHANGED to the list of flags honored during pwrite and pwrite_zeroes, and also add a note on when you absolutely need to support it. Signed-off-by: Max Reitz --- I did not include a note on how this might be useful to protocol drivers, because BDRV_REQ_WRITE_UNCHANGED request

Re: [Qemu-devel] [RFC] Intermediate block mirroring

2018-05-02 Thread Max Reitz
On 2018-05-02 15:07, Alberto Garcia wrote: > On Wed 25 Apr 2018 04:03:22 PM CEST, Max Reitz wrote: But the question stands whether we need simple node replacement when we want bdrv_reopen() anyway. In addition, we don't need just replacement, we also need addition and removal (e.g.

Re: [Qemu-devel] [PATCH v6 4/5] qobject: modify qobject_ref() to return obj

2018-05-02 Thread Markus Armbruster
Eric Blake writes: > On 04/27/2018 06:42 AM, Markus Armbruster wrote: > +++ b/include/qapi/qmp/qobject.h @@ -72,11 +72,12 @@ static inline void qobject_init(QObject *obj, QType type) obj->base.type = type; } -static inline void qobject_ref_impl(QObject *ob

Re: [Qemu-devel] [PATCH] block: Document BDRV_REQ_WRITE_UNCHANGED support

2018-05-02 Thread Eric Blake
On 05/02/2018 09:03 AM, Max Reitz wrote: Add BDRV_REQ_WRITE_UNCHANGED to the list of flags honored during pwrite and pwrite_zeroes, and also add a note on when you absolutely need to support it. Signed-off-by: Max Reitz --- Thanks, that helps. Reviewed-by: Eric Blake I did not include a n

Re: [Qemu-devel] Expand ECAM region in machvirt 2_13?

2018-05-02 Thread Ard Biesheuvel
On 2 May 2018 at 15:54, Laszlo Ersek wrote: > On 05/02/18 14:34, Ard Biesheuvel wrote: >> On 2 May 2018 at 13:31, Laszlo Ersek wrote: >>> On 05/01/18 17:59, Auger Eric wrote: Hi, I would like to resume the discussion on extending the number of PCI buses to 256 (as in Q35) as a

Re: [Qemu-devel] [PATCH 2/2] iotests: Add test for cancelling a mirror job

2018-05-02 Thread Jeff Cody
On Wed, May 02, 2018 at 12:05:09AM +0200, Max Reitz wrote: > We already have an extensive mirror test (041) which does cover > cancelling a mirror job, especially after it has emitted the READY > event. However, it does not check what exact events are emitted after > block-job-cancel is executed.

[Qemu-devel] [PULL SUBSYSTEM s390x 01/10] pc-bios/s390-ccw: size_t should be unsigned

2018-05-02 Thread Thomas Huth
"size_t" should be an unsigned type according to the C standard. Thus we should also use this convention in the s390-ccw firmware to avoid confusion. I checked the sources, and apart from one spot in libc.c, the code should all be fine with this change. Buglink: https://bugs.launchpad.net/qemu/+bu

[Qemu-devel] [PULL SUBSYSTEM s390x 03/10] pc-bios/s390-ccw: fix loadparm initialization and int conversion

2018-05-02 Thread Thomas Huth
From: Collin Walling Rename the loadparm char array in main.c to loadparm_str and increased the size by one byte to account for a null termination when converting the loadparm string to an int via atoui. We also allow the boot menu to be enabled when loadparm is set to an empty string or a serie

[Qemu-devel] [PULL SUBSYSTEM s390x 05/10] pc-bios/s390-ccw: fix non-sequential boot entries (enum)

2018-05-02 Thread Thomas Huth
From: Collin Walling zIPL boot menu entries can be non-sequential. Let's account for this issue for the s390 enumerated boot menu. Since we can no longer print a range of available entries to the user, we have to present a list of each available entry. An example of this menu: s390-ccw Enumer

Re: [Qemu-devel] [PATCH 0/2] block/mirror: Make cancel always cancel pre-READY

2018-05-02 Thread Jeff Cody
On Wed, May 02, 2018 at 12:05:07AM +0200, Max Reitz wrote: > Currently, you cannot cancel a mirror job without the @force flag set. > This is intentional once source and target are in sync, but probably not > so much before that happens. The main reason for me thinking this is > because it is an u

[Qemu-devel] [PULL SUBSYSTEM s390x 06/10] pc-bios/s390-ccw/net: Split up net_load() into init, load and release parts

2018-05-02 Thread Thomas Huth
When we want to support pxelinux-style network booting later, we've got to do several TFTP transfers - and we do not want to apply for a new IP address via DHCP each time. So split up net_load into three parts: 1. net_init(), which initializes virtio-net, gets an IP address via DHCP and prints

[Qemu-devel] [PULL SUBSYSTEM s390x 00/10] s390-ccw firmware update - not for master

2018-05-02 Thread Thomas Huth
This PULL request is not for master. Hi Cornelia, the following changes since commit 052888f043bacb18231046045b1f9cd946703170: hw/s390x: Allow to configure the consoles with the "-serial" parameter (2018-04-30 10:48:29 +0200) are available in the git repository at: https://github.com/hu

[Qemu-devel] [PULL SUBSYSTEM s390x 09/10] s390-ccw: force diag 308 subcode to unsigned long

2018-05-02 Thread Thomas Huth
From: Cornelia Huck We currently pass an integer as the subcode parameter. However, the upper bits of the register containing the subcode need to be 0, which is not guaranteed unless we explicitly specify the subcode to be an unsigned long value. Fixes: d046c51dad3 ("pc-bios/s390-ccw: Get device

[Qemu-devel] [PULL SUBSYSTEM s390x 08/10] pc-bios/s390-ccw/net: Add support for .INS config files

2018-05-02 Thread Thomas Huth
The .INS config files can normally be found on CD-ROM ISO images, so by supporting these files, it is now possible to boot directly when the TFTP server is set up with the contents of such an CD-ROM image. Acked-by: Christian Borntraeger Signed-off-by: Thomas Huth --- pc-bios/s390-ccw/netmain.c

Re: [Qemu-devel] Expand ECAM region in machvirt 2_13?

2018-05-02 Thread Auger Eric
Hi Laszlo, Ard, On 05/02/2018 04:23 PM, Ard Biesheuvel wrote: > On 2 May 2018 at 15:54, Laszlo Ersek wrote: >> On 05/02/18 14:34, Ard Biesheuvel wrote: >>> On 2 May 2018 at 13:31, Laszlo Ersek wrote: On 05/01/18 17:59, Auger Eric wrote: > Hi, > > I would like to resume the discu

[Qemu-devel] [PULL SUBSYSTEM s390x 07/10] pc-bios/s390-ccw/net: Use diag308 to reset machine before jumping to the OS

2018-05-02 Thread Thomas Huth
The netboot firmware so far simply jumped directly into the OS kernel after the download has been completed. This, however, bears the risk that the virtio-net device still might be active in the background and incoming packets are still placed into the buffers - which could destroy memory of the no

[Qemu-devel] [PULL SUBSYSTEM s390x 02/10] pc-bios/s390-ccw: rename MAX_TABLE_ENTRIES to MAX_BOOT_ENTRIES

2018-05-02 Thread Thomas Huth
From: Collin Walling The MAX_TABLE_ENTRIES constant has a name that is too generic. As we want to declare a limit for boot menu entries, let's rename it to a more fitting MAX_BOOT_ENTRIES and set its value to 31 (30 boot entries and 1 default entry). Also we move it from bootmap.h to s390-ccw.h t

[Qemu-devel] [PULL SUBSYSTEM s390x 10/10] pc-bios/s390: Update firmware images

2018-05-02 Thread Thomas Huth
s390-ccw.img contains fixes for the boot menu, and s390-netboot.img contains the support for .INS files and the patch for resetting the machine with diag308. Signed-off-by: Thomas Huth --- pc-bios/s390-ccw.img | Bin 30520 -> 34568 bytes pc-bios/s390-netboot.img | Bin 83856 -> 87872 bytes 2

[Qemu-devel] [PULL SUBSYSTEM s390x 04/10] pc-bios/s390-ccw: fix non-sequential boot entries (eckd)

2018-05-02 Thread Thomas Huth
From: Collin Walling zIPL boot menu entries can be non-sequential. Let's account for this issue for the s390 zIPL boot menu. Since this boot menu is actually an imitation and is not completely capable of everything the real zIPL menu can do, let's also print a different banner to the user. Signe

Re: [Qemu-devel] [PATCH] qemu-img: return allocated size for block device with qcow2 format

2018-05-02 Thread Max Reitz
Hi, [replying to this version because the previous mail doesn't seem to have made it to the mailing lists for whatever reason] On 2018-05-02 15:34, Ivan Ren wrote: > qemu-img info with a block device which has a qcow2 format always > return 0 for disk size, and this can not reflect the qcow2 size

Re: [Qemu-devel] [PATCH] linux-user: remove useless padding in flock64 structure

2018-05-02 Thread Laurent Vivier
Le 02/05/2018 à 01:53, Laurent Vivier a écrit : > Since commit 8efb2ed5ec ("linux-user: Correct signedness of > target_flock l_start and l_len fields"), flock64 structure uses > abi_llong for l_start and l_len in place of "unsigned long long" > this should force them to be aligned accordingly to th

Re: [Qemu-devel] [PATCH] migration: introduce decompress-error-check

2018-05-02 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Fri, Apr 27, 2018 at 06:40:09PM +0800, Xiao Guangrong wrote: > > > > > > On 04/27/2018 05:31 PM, Peter Xu wrote: > > > On Fri, Apr 27, 2018 at 11:15:37AM +0800, Xiao Guangrong wrote: > > > > > > > > > > > > On 04/26/2018 10:01 PM, Eric Blake wrote: > >

Re: [Qemu-devel] [PATCH] qemu-img: return allocated size for block device with qcow2 format

2018-05-02 Thread Eric Blake
On 05/02/2018 09:37 AM, Max Reitz wrote: On 2018-05-02 15:34, Ivan Ren wrote: qemu-img info with a block device which has a qcow2 format always return 0 for disk size, and this can not reflect the qcow2 size and the used space of the block device. This patch return the allocated size of qcow2 as

Re: [Qemu-devel] [PATCH v4 1/5] target/ppc: return a nil HPT base address on sPAPR machines

2018-05-02 Thread David Gibson
On Tue, Apr 24, 2018 at 01:30:41PM +0200, Cédric Le Goater wrote: > commit e57ca75ce3b2 ("target/ppc: Manage external HPT via virtual > hypervisor") exported a set of methods to manipulate the HPT from the > core hash MMU. But SPR_SDR1 is still used under some circumstances to > get the base addres

Re: [Qemu-devel] [PATCH v4 2/5] target/ppc: add basic support for PTCR on POWER9

2018-05-02 Thread David Gibson
On Tue, Apr 24, 2018 at 01:30:42PM +0200, Cédric Le Goater wrote: > The Partition Table Control Register (PTCR) is a hypervisor privileged > SPR. It contains the host real address of the Partition Table and its > size. > > Signed-off-by: Cédric Le Goater > Reviewed-by: David Gibson Applied, tha

Re: [Qemu-devel] [PATCH] qemu-img: return allocated size for block device with qcow2 format

2018-05-02 Thread Max Reitz
On 2018-05-02 17:01, Eric Blake wrote: > On 05/02/2018 09:37 AM, Max Reitz wrote: >> On 2018-05-02 15:34, Ivan Ren wrote: >>> qemu-img info with a block device which has a qcow2 format always >>> return 0 for disk size, and this can not reflect the qcow2 size >>> and the used space of the block dev

Re: [Qemu-devel] [PATCH] qemu-img: return allocated size for block device with qcow2 format

2018-05-02 Thread Eric Blake
On 05/02/2018 10:13 AM, Max Reitz wrote: We also recently added 'qemu-img measure', which DOES report how many clusters are in use.  Is any of that reusable here? It only tells you that information for a hypothetical new image, though, doesn't it? It has two uses: with just a size, estimate

Re: [Qemu-devel] [PATCH v3 03/35] ppc/xive: introduce the XiveFabric interface

2018-05-02 Thread Cédric Le Goater
On 04/27/2018 08:32 AM, David Gibson wrote: > On Thu, Apr 26, 2018 at 12:30:42PM +0200, Cédric Le Goater wrote: >> On 04/26/2018 05:54 AM, David Gibson wrote: >>> On Tue, Apr 24, 2018 at 11:33:11AM +0200, Cédric Le Goater wrote: On 04/24/2018 08:46 AM, David Gibson wrote: > On Mon, Apr 23,

Re: [Qemu-devel] Expand ECAM region in machvirt 2_13?

2018-05-02 Thread Laszlo Ersek
On 05/02/18 16:38, Auger Eric wrote: > Hi Laszlo, Ard, > > On 05/02/2018 04:23 PM, Ard Biesheuvel wrote: >> On 2 May 2018 at 15:54, Laszlo Ersek wrote: >>> On 05/02/18 14:34, Ard Biesheuvel wrote: On 2 May 2018 at 13:31, Laszlo Ersek wrote: > On 05/01/18 17:59, Auger Eric wrote: >>

Re: [Qemu-devel] [PATCH] migration: fix saving normal page even if it's been compressed

2018-05-02 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Sat, Apr 28, 2018 at 04:10:45PM +0800, guangrong.x...@gmail.com wrote: > > From: Xiao Guangrong > > > > Fix the bug introduced by da3f56cb2e767016 (migration: remove > > ram_save_compressed_page()), It should be 'return' rather than > > 'res' > > > > So

Re: [Qemu-devel] [PATCH] qemu-img: return allocated size for block device with qcow2 format

2018-05-02 Thread Max Reitz
On 2018-05-02 17:19, Eric Blake wrote: > On 05/02/2018 10:13 AM, Max Reitz wrote: > >>> We also recently added 'qemu-img measure', which DOES report how many >>> clusters are in use.  Is any of that reusable here? >> >> It only tells you that information for a hypothetical new image, though, >> do

[Qemu-devel] [PATCH v2 0/3] refactor float-to-float conversions and fix AHP

2018-05-02 Thread Alex Bennée
Hi, This is a more polished version of the re-factoring of the softfloat fcvt code. I've split apart the fixes for ARM alternative half-precision format for easier review. Rather than rely on some questionable hacks it introduces a new FloatFmt to allow cleaner handling of the differences in the c

[Qemu-devel] [PATCH v2 1/3] fpu/softfloat: re-factor float to float conversions

2018-05-02 Thread Alex Bennée
This allows us to delete a lot of additional boilerplate code which is no longer needed. Currently the ieee flag is ignored (everything is assumed to be ieee). Handling for ARM AHP will be in the next patch. Signed-off-by: Alex Bennée --- v2 - pass FloatFmt to float_to_float instead of sizes

[Qemu-devel] [PATCH v2 2/3] fpu/softfloat: support ARM Alternative half-precision

2018-05-02 Thread Alex Bennée
For float16 ARM supports an alternative half-precision format which sacrifices the ability to represent NaN/Inf in return for a higher dynamic range. To support this I've added an additional FloatFmt (float16_params_ahp). The new FloatFmt flag (arm_althp) is then used to modify the behaviour of ca

[Qemu-devel] [PATCH v2 3/3] tests/tcg/aarch64: add fcvt test cases for AArch64 (!UPSTREAM)

2018-05-02 Thread Alex Bennée
This runs through the usual float to float conversions and crucially also runs with ARM Alternative Half Precision Format. [!UPSTREAM: will be in next revision of tcg-tests-revival] Signed-off-by: Alex Bennée --- v4 - add fcvt.ref and check results against it - fix single_to_half, single_to

Re: [Qemu-devel] [PATCH] xen/hvm: correct reporting of modified memory under physmap during migration

2018-05-02 Thread Anthony PERARD
On Wed, Apr 25, 2018 at 02:46:47PM +0100, Igor Druzhinin wrote: > When global_log_dirty is enabled VRAM modification tracking never > worked correctly. The address that is passed to xen_hvm_modified_memory() > is not the effective PFN but RAM block address which is not the same > for VRAM. > > We

Re: [Qemu-devel] [PATCH v12 01/21] migration: Set error state in case of error

2018-05-02 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela > --- > migration/ram.c | 24 ++-- > 1 file changed, 22 insertions(+), 2 deletions(-) > > diff --git a/migration/ram.c b/migration/ram.c > index 0e90efa092..2ae560ea80 100644 > --- a/migration/ram.c >

Re: [Qemu-devel] [PATCH 0/4] block/xen_disk: legacy code removal and cleanup

2018-05-02 Thread Anthony PERARD
On Mon, Apr 30, 2018 at 01:01:35PM +0100, Paul Durrant wrote: > The grant copy operation was added to libxengnttab in Xen 4.8.0 (released > nearly 18 months ago) but the xen_disk PV backend QEMU is still carrying > a significant amount of code purely to remain compatible with older > versions of Xe

[Qemu-devel] [Bug 1751422] Re: some instructions translate error in x86

2018-05-02 Thread Richard Henderson
I believe this to be fixed by cfcca361d77, which is present in 2.12 but not 2.11. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1751422 Title: some instructions translate error in x86 Status in QE

Re: [Qemu-devel] [PATCH 0/4] block/xen_disk: legacy code removal and cleanup

2018-05-02 Thread Paul Durrant
> -Original Message- > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > Sent: 02 May 2018 16:58 > To: Paul Durrant > Cc: xen-de...@lists.xenproject.org; qemu-bl...@nongnu.org; qemu- > de...@nongnu.org; Stefano Stabellini ; Kevin Wolf > ; Max Reitz > Subject: Re: [PATCH 0/4] block

Re: [Qemu-devel] [PATCH v8 1/8] qemu-sockets: Export SocketAddress_to_str

2018-05-02 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Migration code needs that function in hmp.c (so we need to export it), > and it needs it on tests/migration-test.c, so we need to move it to a > place where it is compiled into the test framework. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. Da

Re: [Qemu-devel] [PATCH v8 1/8] qemu-sockets: Export SocketAddress_to_str

2018-05-02 Thread Daniel P . Berrangé
On Wed, Apr 25, 2018 at 01:19:33PM +0200, Juan Quintela wrote: > Migration code needs that function in hmp.c (so we need to export it), > and it needs it on tests/migration-test.c, so we need to move it to a > place where it is compiled into the test framework. > > Signed-off-by: Juan Quintela >

Re: [Qemu-devel] [RFC PATCH 0/7] avocado: Add acceptance tests parsing the Linux boot console

2018-05-02 Thread Cleber Rosa
On 04/20/2018 12:17 AM, Philippe Mathieu-Daudé wrote: > Cross-posting qemu-devel + avocado-devel. > >> While previously working on a Super I/O refactor, I encountered some problems >> at runtime, after building the codebase successfully and running qtests. >> I had to manually start to boot diff

Re: [Qemu-devel] [PATCH v2 1/3] fpu/softfloat: re-factor float to float conversions

2018-05-02 Thread Richard Henderson
On 05/02/2018 08:43 AM, Alex Bennée wrote: > +if (is_nan(a.cls)) { > + > +if (is_snan(a.cls)) { Watch your whitespace. r~

Re: [Qemu-devel] [PATCH v2 0/3] refactor float-to-float conversions and fix AHP

2018-05-02 Thread Richard Henderson
On 05/02/2018 08:43 AM, Alex Bennée wrote: > This is a more polished version of the re-factoring of the softfloat > fcvt code. I've split apart the fixes for ARM alternative > half-precision format for easier review. Rather than rely on some > questionable hacks it introduces a new FloatFmt to allo

Re: [Qemu-devel] [PATCH v2 0/3] refactor float-to-float conversions and fix AHP

2018-05-02 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180502154344.10585-1-alex.ben...@linaro.org Subject: [Qemu-devel] [PATCH v2 0/3] refactor float-to-float conversions and fix AHP === TEST SCRIPT BEGIN === #!/bin/bash BAS

Re: [Qemu-devel] [PATCH v2 0/5] checkpatch: backport UTF-8 fixes and MAINTAINERS check

2018-05-02 Thread Markus Armbruster
Stefan Hajnoczi writes: > v2: > * Resolve missing CHK() [Thomas] > * Drop first argument to WARN() to match QEMU function arguments > > This series cherry picks checkpatch UTF-8 fixes and the MAINTAINERS file check > from Linux. Thomas Huth original did the backport in January 2017 but the > s

[Qemu-devel] [PATCH v2] linux-user: remove useless padding in flock64 structure

2018-05-02 Thread Laurent Vivier
Since commit 8efb2ed5ec ("linux-user: Correct signedness of target_flock l_start and l_len fields"), flock64 structure uses abi_llong for l_start and l_len in place of "unsigned long long" this should force them to be aligned accordingly to the target rules. So we can remove the padding field and t

Re: [Qemu-devel] [PATCH v12 08/21] migration: Transmit initial package through the multifd channels

2018-05-02 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela > Reviewed-by: Daniel P. Berrangé > > -- > > Be network agnostic. > Add error checking for all values. > --- > migration/ram.c | 101 +--- > 1 file changed, 96 insertions(+),

[Qemu-devel] [PATCH 0/4] Removal of deprecated -no-kvm* options

2018-05-02 Thread Thomas Huth
The -no-kvm* options are a remainder of the ancient "qemu-kvm" fork. They have never been officially documented in our qemu-doc, they have been marked as deprecated in the sources since a very long time, and we've marked them as deprecated in our qemu-doc since QEMU v2.10. So far I haven't seen any

[Qemu-devel] [PATCH 4/4] qemu-options: Remove deprecated -no-kvm

2018-05-02 Thread Thomas Huth
We've never documented this option in our qemu-doc, so unless the users used qemu-kvm before, they never should never have been aware of this option. It's been marked as deprecated in the source code since a long time already, and officially marked as deprecated in the documentation since QEMU v2.1

[Qemu-devel] [PATCH 1/4] qemu-options: Remove remainders of the -tdf option

2018-05-02 Thread Thomas Huth
The -tdf options has been removed with d07aa197c5a1556449361a0cbb5108e2, but apparently I forgot to remove the corresponding two lines from qemu-options.hx. Signed-off-by: Thomas Huth --- qemu-options.hx | 3 --- 1 file changed, 3 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx inde

[Qemu-devel] [PATCH 2/4] qemu-options: Remove deprecated -no-kvm-pit-reinjection

2018-05-02 Thread Thomas Huth
Deprecated since the beginning when it was added for compatibility with the ancient qemu-kvm fork of QEMU, and it even printed out the deprecation warning since right from the start (i.e. QEMU v1.3.0), so it's really time to remove this now. Signed-off-by: Thomas Huth --- qemu-doc.texi | 5 --

[Qemu-devel] [PATCH 3/4] qemu-options: Remove deprecated -no-kvm-irqchip

2018-05-02 Thread Thomas Huth
We've never documented this option in our qemu-doc, so unless the users used qemu-kvm before, they never should never have been aware of this option. It's been marked as deprecated in the source code since a long time already, and officially marked as deprecated in the documentation since QEMU v2.1

Re: [Qemu-devel] [PATCH v12 09/21] migration: Define MultifdRecvParams sooner

2018-05-02 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Once there, we don't need the struct names anywhere, just the > typedefs. And now also document all fields. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > migration/ram.c | 46 +++

Re: [Qemu-devel] [PATCH v2] linux-user: remove useless padding in flock64 structure

2018-05-02 Thread Richard Henderson
On 05/02/2018 10:18 AM, Laurent Vivier wrote: > +#if defined(TARGET_ARM) && defined(TARGET_ABI32) > +struct target_oabi_flock64 { > +abi_short l_type; > +abi_short l_whence; > abi_llong l_start; > abi_llong l_len; > -int l_pid; > +abi_int l_pid; > } QEMU_PACKED; > #en

Re: [Qemu-devel] [PATCH 1/7] qemu-img: Amendment support implies create_opts

2018-05-02 Thread Eric Blake
On 04/21/2018 11:54 AM, Max Reitz wrote: Instead of checking whether a driver has a non-NULL create_opts we should check whether it supports image amendment in the first place. If it does, it must have create_opts. On the other hand, if it does not have create_opts (so it does not support amend

Re: [Qemu-devel] [PATCH 0/2] block/mirror: Make cancel always cancel pre-READY

2018-05-02 Thread John Snow
On 05/01/2018 06:05 PM, Max Reitz wrote: > Currently, you cannot cancel a mirror job without the @force flag set. > This is intentional once source and target are in sync, but probably not > so much before that happens. The main reason for me thinking this is > because it is an undocumented chan

Re: [Qemu-devel] [Qemu-block] [PATCH 5/7] qemu-img: Recognize no creation support in -o help

2018-05-02 Thread John Snow
On 04/21/2018 12:54 PM, Max Reitz wrote: > The only users of print_block_option_help() are qemu-img create and > qemu-img convert for the output image, so this function is always used > for image creation (it used to be used for amendment also, but that is > no longer the case). > > So if image

Re: [Qemu-devel] [PATCH 0/3] Update linux-headers to v4.17-rc3

2018-05-02 Thread Alex Williamson
On Wed, 2 May 2018 06:25:16 +1000 David Airlie wrote: > On Wed, May 2, 2018 at 2:25 AM, Alex Williamson > wrote: > > > This series is based on Michael's series moving kvm_para.h out to > > standard headers, which resolves the conflict in definitions of > > KVM_HINTS_DEDICATED between QEMU and k

[Qemu-devel] [PULL 1/5] tcg: Document INDEX_mul[us]h_*

2018-05-02 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/README | 8 1 file changed, 8 insertions(+) diff --git a/tcg/README b/tcg/README index bb2ea5121b..a5237a9edb 100644 --- a/tcg/README +++ b/tcg/README @@ -431,6 +431,14 @@ double-word product T0. The later is returned in two single-word outputs

[Qemu-devel] [PULL 0/5] TCG queued patches

2018-05-02 Thread Richard Henderson
1 15:26:06 +0100) are available in the Git repository at: git://github.com/rth7680/qemu.git tags/pull-tcg-20180502 for you to fetch changes up to 6001f7729e12dd1d810291e4cbf83cee8e07441d: tcg: workaround branch instruction overflow in tcg_out_qemu_ld/st (2018-05-01 11:5

[Qemu-devel] [PULL 4/5] tcg: Improve TCGv_ptr support

2018-05-02 Thread Richard Henderson
Drop TCGV_PTR_TO_NAT and TCGV_NAT_TO_PTR internal macros. Add tcg_temp_local_new_ptr, tcg_gen_brcondi_ptr, tcg_gen_ext_i32_ptr, tcg_gen_trunc_i64_ptr, tcg_gen_extu_ptr_i64, tcg_gen_trunc_ptr_i32. Use inlines instead of macros where possible. Reviewed-by: Peter Maydell Signed-off-by: Richard Hen

[Qemu-devel] [PULL 3/5] tcg: Allow wider vectors for cmp and mul

2018-05-02 Thread Richard Henderson
In db432672, we allow wide inputs for operations such as add. However, in 212be173 and 3774030a we didn't do the same for compare and multiply. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/tcg-op-vec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --

[Qemu-devel] [PULL 2/5] tcg/arm: Fix memory barrier encoding

2018-05-02 Thread Richard Henderson
From: Henry Wertz I found with qemu 2.11.x or newer that I would get an illegal instruction error running some Intel binaries on my ARM chromebook. On investigation, I found it was quitting on memory barriers. qemu instruction: mb $0x31 was translating as: 0x604050cc: 5bf07ff5 blpl #0x600

Re: [Qemu-devel] [PATCH 2/7] block: Add Error parameter to bdrv_amend_options

2018-05-02 Thread Eric Blake
On 04/21/2018 11:54 AM, Max Reitz wrote: Looking at the qcow2 code that is riddled with error_report() calls, this is really how it should have been from the start. Signed-off-by: Max Reitz --- +++ b/block/qcow2.c @@ -4049,7 +4049,8 @@ static int qcow2_load_vmstate(BlockDriverState *bs, QEM

[Qemu-devel] [PULL 5/5] tcg: workaround branch instruction overflow in tcg_out_qemu_ld/st

2018-05-02 Thread Richard Henderson
From: Laurent Vivier ppc64 uses a BC instruction to call the tcg_out_qemu_ld/st slow path. BC instruction uses a relative address encoded on 14 bits. The slow path functions are added at the end of the generated instructions buffer, in the reverse order of the callers. So more we have slow path

Re: [Qemu-devel] [PATCH v12 10/21] migration: Create multipage support

2018-05-02 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > We only create/destry the page list here. We will use it later. > > Signed-off-by: Juan Quintela > --- > migration/ram.c | 56 + > 1 file changed, 56 insertions(+) > > diff --git a/migration/ram.c b/

Re: [Qemu-devel] [Qemu-block] [PATCH 6/7] iotests: Test help option for unsupporting formats

2018-05-02 Thread John Snow
On 04/21/2018 12:54 PM, Max Reitz wrote: > This adds test cases to 082 for qemu-img create/convert/amend "-o help" > on formats that do not support creation or amendment, respectively. > > Signed-off-by: Max Reitz Reviewed-by: John Snow

Re: [Qemu-devel] [Qemu-block] [PATCH 7/7] iotests: Rework 113

2018-05-02 Thread John Snow
On 04/21/2018 12:54 PM, Max Reitz wrote: > This test case has been broken since 398e6ad014df261d (roughly half a > year). qemu-img amend requires its output image to be R/W, so it opens > it as such; the node is then turned into an read-only node automatically > which is now accompanied by a war

Re: [Qemu-devel] [PATCH v12 11/21] migration: Create multifd packet

2018-05-02 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > We still don't put anything there. > > Signed-off-by: Juan Quintela > --- > migration/ram.c | 137 +++- > 1 file changed, 136 insertions(+), 1 deletion(-) > > diff --git a/migration/ram.c b/migration/ram.

Re: [Qemu-devel] [PATCH 3/7] qemu-option: Pull out "Supported options" print

2018-05-02 Thread Eric Blake
On 04/21/2018 11:54 AM, Max Reitz wrote: It really is up to the caller to decide what this list of options means. Signed-off-by: Max Reitz --- qemu-img.c | 1 + util/qemu-option.c | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake -- Eric Blake, Princ

Re: [Qemu-devel] [PATCH 2/7] block: Add Error parameter to bdrv_amend_options

2018-05-02 Thread Max Reitz
On 2018-05-02 19:52, Eric Blake wrote: > On 04/21/2018 11:54 AM, Max Reitz wrote: >> Looking at the qcow2 code that is riddled with error_report() calls, >> this is really how it should have been from the start. >> >> Signed-off-by: Max Reitz >> --- > >> +++ b/block/qcow2.c >> @@ -4049,7 +4049,8

<    1   2   3   4   >