Re: [Qemu-devel] [PATCH 17/19] uninorth: create new uninorth device

2018-04-25 Thread Mark Cave-Ayland
On 25/04/18 07:34, David Gibson wrote: On Wed, Apr 25, 2018 at 07:06:03AM +0100, Mark Cave-Ayland wrote: On 06/04/18 06:33, Mark Cave-Ayland wrote: On 25/03/18 22:11, Mark Cave-Ayland wrote: Just to follow up on this, I spent a bit looking at what this register is trying to do and from the

[Qemu-devel] [PATCH v2] checkpatch.pl: add common glib defines to typelist

2018-04-25 Thread Peter Xu
Otherwise it can warn this: ERROR: space prohibited between function name and open parenthesis '(' When with things like this: typedef gboolean (*it_tree_iterator)(ITValue start, ITValue end); CC: Paolo Bonzini CC: Stefan Hajnoczi CC: "Daniel P. Berrangé" CC: Markus Armbruster CC: Vladi

Re: [Qemu-devel] [PATCH v3 00/46] fix building of tests/tcg

2018-04-25 Thread Samuel Thibault
Philippe Mathieu-Daudé, le mar. 24 avril 2018 22:25:18 -0300, a ecrit: > > This is starting to shape up pretty nicely. I was able to add a whole > > bunch of additional architectures thanks to cross compilers in Debian > > Sid which are there to support the Debian "ports". These may not be > > arou

Re: [Qemu-devel] [PATCH 5/6] qapi: extract CpuInfoCommon to mitigate schema duplication

2018-04-25 Thread Markus Armbruster
Laszlo Ersek writes: > @CpuInfo and @CpuInfoFast duplicate the following four fields: @qom-path, > @thread-id, @props and @arch. From these, extract the first three to a > common structure called @CpuInfoCommon. (More on @arch later.) > > Introduce two new mid-layer structures, @CpuInfoBase and @

[Qemu-devel] [PATCH v3 0/1] migration: calculate expected_downtime with ram_bytes_remaining()

2018-04-25 Thread Balamuruhan S
V3: * commit message to be updated with the changes done by the patch since v1, review comment by David Gibson. * Included Michael Roth as ``Reported-by:`` for bringing up the concern. v2: There is some difference in expected_downtime value due to following reason, 1. bandwidth and expected_do

[Qemu-devel] [PATCH v3 1/1] migration: calculate expected_downtime with ram_bytes_remaining()

2018-04-25 Thread Balamuruhan S
expected_downtime value is not accurate with dirty_pages_rate * page_size, using ram_bytes_remaining would yeild it correct. It will initially be a gross over-estimate, but for for non-converging migrations it should approach a reasonable estimate later on. currently bandwidth and expected_downtim

Re: [Qemu-devel] [PATCH 2/2] ui: introduce vfio_display_reset

2018-04-25 Thread Zhang, Tina
> -Original Message- > From: intel-gvt-dev [mailto:intel-gvt-dev-boun...@lists.freedesktop.org] On > Behalf Of Gerd Hoffmann > Sent: Tuesday, April 24, 2018 4:16 PM > To: Zhang, Tina > Cc: alex.william...@redhat.com; intel-gvt-...@lists.freedesktop.org; qemu- > de...@nongnu.org; zhen...@

Re: [Qemu-devel] [PATCH 1/6] qapi: fill in CpuInfoFast.arch in query-cpus-fast

2018-04-25 Thread Cornelia Huck
On Tue, 24 Apr 2018 23:45:45 +0200 Laszlo Ersek wrote: > Commit ca230ff33f89 added added the @arch field to @CpuInfoFast, but it > failed to set the new field in qmp_query_cpus_fast(), when TARGET_S390X > was not defined. The updated @query-cpus-fast example in > "qapi-schema.json" showed "arch":

Re: [Qemu-devel] [PATCH] migration/fd: abort migration if receive POLLHUP event

2018-04-25 Thread wangxin (U)
> -Original Message- > From: Peter Xu [mailto:pet...@redhat.com] > Sent: Wednesday, April 25, 2018 11:32 AM > To: Daniel P. Berrangé > Cc: Dr. David Alan Gilbert ; wangxin (U) > ; qemu-devel@nongnu.org; > quint...@redhat.com; Gonglei (Arei) > Subject: Re: [PATCH] migration/fd: abort migr

Re: [Qemu-devel] [PATCH 6/6] qapi: discriminate CpuInfo[Fast] on SysEmuTarget, not CpuInfoArch

2018-04-25 Thread Markus Armbruster
Laszlo Ersek writes: > Add a new field @target (of type @SysEmuTarget) to the outputs of the > @query-cpus and @query-cpus-fast commands, which provides more information > about the emulation target than the field @arch (of type @CpuInfoArch). > Keep @arch for compatibility. > > Make @target the

Re: [Qemu-devel] [PATCH 2/6] qapi: handle the riscv CpuInfoArch in query-cpus-fast

2018-04-25 Thread Cornelia Huck
On Wed, 25 Apr 2018 08:44:15 +0200 Markus Armbruster wrote: > Laszlo Ersek writes: > > > Commit 25fa194b7b11 added the @riscv enum constant to @CpuInfoArch (used > > in both @CpuInfo and @CpuInfoFast -- the return types of the @query-cpus > > and @query-cpus-fast commands, respectively), and as

Re: [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-25 Thread Kevin Wolf
Am 24.04.2018 um 20:26 hat Jeff Cody geschrieben: > On Fri, Apr 20, 2018 at 04:39:02PM +0200, Markus Armbruster wrote: > > >> Ways to avoid the troublesome auth-cephx: {}: > > >> > > >> (A) Make auth-cephx a bool, rely on the other ways to provide the key > > >> > > >> (B) Make auth-cephx a bool

Re: [Qemu-devel] [PATCH] migration/fd: abort migration if receive POLLHUP event

2018-04-25 Thread Daniel P . Berrangé
On Wed, Apr 25, 2018 at 07:29:05AM +, wangxin (U) wrote: > > > -Original Message- > > From: Peter Xu [mailto:pet...@redhat.com] > > Sent: Wednesday, April 25, 2018 11:32 AM > > To: Daniel P. Berrangé > > Cc: Dr. David Alan Gilbert ; wangxin (U) > > ; qemu-devel@nongnu.org; > > quint..

Re: [Qemu-devel] [PATCH] block: Merge .bdrv_co_writev{, _flags} in drivers

2018-04-25 Thread Daniel P . Berrangé
On Tue, Apr 24, 2018 at 05:01:57PM -0500, Eric Blake wrote: > We have too many driver callback interfaces; simplify the mess > somewhat by merging the flags parameter of .bdrv_co_writev_flags() > into .bdrv_co_writev_flags(). Note that as long as a driver doesn't Typo - this should be just .bdrv

[Qemu-devel] [PATCH v2 1/2] console: introduce dpy_gfx_update_full

2018-04-25 Thread Tina Zhang
dpy_gfx_update_full is used to do the whole display surface update. This function is proposed by Gerd Hoffmann. Signed-off-by: Tina Zhang --- include/ui/console.h | 1 + ui/console.c | 10 ++ 2 files changed, 11 insertions(+) diff --git a/include/ui/console.h b/include/ui/cons

[Qemu-devel] [PATCH v2 0/2] Add vfio display reset handling

2018-04-25 Thread Tina Zhang
vfio display needs to release the invalid display resource and disable the scanout mode during guest OS reboot, otherwise bugs come out. Thanks hang.y...@intel.com for helping root cause the issue. v1->v2: - remove dpy_gfx_switch_surface. (Gerd) - add dpy_gfx_update_full. (Gerd) Tina Zhang (2)

[Qemu-devel] [PATCH v2 2/2] ui: introduce vfio_display_reset

2018-04-25 Thread Tina Zhang
During guest OS reboot, guest framebuffer is invalid. It will cause bugs, if the invalid guest framebuffer is still used by host. This patch is to introduce vfio_display_reset which is invoked during vfio display reset. This vfio_display_reset function is used to release the invalid display resour

Re: [Qemu-devel] [PATCH v3 00/46] fix building of tests/tcg

2018-04-25 Thread Alex Bennée
Samuel Thibault writes: > Philippe Mathieu-Daudé, le mar. 24 avril 2018 22:25:18 -0300, a ecrit: >> > This is starting to shape up pretty nicely. I was able to add a whole >> > bunch of additional architectures thanks to cross compilers in Debian >> > Sid which are there to support the Debian "p

Re: [Qemu-devel] [PATCH 5/9] target/arm: Implement FMOV (general) for fp16

2018-04-25 Thread Richard Henderson
On 04/24/2018 03:31 PM, Philippe Mathieu-Daudé wrote: >> @@ -5431,10 +5446,15 @@ static void disas_fp_int_conv(DisasContext *s, >> uint32_t insn) >> case 0xa: /* 64 bit */ >> case 0xd: /* 64 bit to top half of quad */ >> break; >> +case 0x6: /* 16-bit */ >> +

Re: [Qemu-devel] [PATCH v3 23/46] tests/tcg/x86_64: add Makefile.target

2018-04-25 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 04/24/2018 12:23 PM, Alex Bennée wrote: >> The sources for x86_64 are shared in the i386 directory which will be >> included thanks to TARGET_BASE_ARCH. However not all sources build so >> we need to filter out the ones we can't build in the 64 bit world. >> >

Re: [Qemu-devel] [PATCH v3 28/46] tests/tcg/aarch64: add Makefile.target

2018-04-25 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 04/24/2018 12:23 PM, Alex Bennée wrote: >> Nothing much here yet. >> >> Signed-off-by: Alex Bennée >> --- >> tests/tcg/aarch64/Makefile.target | 5 + >> 1 file changed, 5 insertions(+) >> create mode 100644 tests/tcg/aarch64/Makefile.target >> >> diff -

Re: [Qemu-devel] [PATCH v3 21/46] tests/tcg/i386: fix test-i386-fprem

2018-04-25 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 04/24/2018 12:23 PM, Alex Bennée wrote: >> Remove dependencies on QEMU's source tree and build directly. >> >> Signed-off-by: Alex Bennée >> --- >> tests/tcg/i386/test-i386-fprem.c | 12 +--- >> 1 file changed, 9 insertions(+), 3 deletions(-) >> >> d

Re: [Qemu-devel] [PATCH v3 21/46] tests/tcg/i386: fix test-i386-fprem

2018-04-25 Thread Alex Bennée
Thomas Huth writes: > On 24.04.2018 17:23, Alex Bennée wrote: >> Remove dependencies on QEMU's source tree and build directly. >> >> Signed-off-by: Alex Bennée >> --- >> tests/tcg/i386/test-i386-fprem.c | 12 +--- >> 1 file changed, 9 insertions(+), 3 deletions(-) >> >> diff --git a/te

[Qemu-devel] [PATCH v3 0/3] pc-bios/s390-ccw: Some few network boot improvements

2018-04-25 Thread Thomas Huth
Note: I've decided to removed the pxelinux.cfg patches from this series for now, since full pxelinux support requires to parse some additional DHCP options (see https://tools.ietf.org/html/rfc5071), and for this, the SLOF libnet code needs to be changed first. So I guess I first have to implement p

[Qemu-devel] [PATCH v3 2/3] pc-bios/s390-ccw/net: Use diag308 to reset machine before jumping to the OS

2018-04-25 Thread Thomas Huth
The netboot firmware so far simply jumped directly into the OS kernel after the download has been completed. This, however, bears the risk that the virtio-net device still might be active in the background and incoming packets are still placed into the buffers - which could destroy memory of the no

Re: [Qemu-devel] [PATCH v3 16/46] tests/tcg: move i386 specific tests into subdir

2018-04-25 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 04/24/2018 12:23 PM, Alex Bennée wrote: >> These only need to be built for i386 guests. This includes a stub >> tests/tcg/i386/Makfile.target which absorbs some of what was in >> tests/tcg/Makefile. >> >> Signed-off-by: Alex Bennée >> Reviewed-by: Thomas Huth

[Qemu-devel] [PATCH v3 1/3] pc-bios/s390-ccw/net: Split up net_load() into init, load and uninit parts

2018-04-25 Thread Thomas Huth
When we want to support pxelinux-style network booting later, we've got to do several TFTP transfers - and we do not want to apply for a new IP address via DHCP each time. So split up net_load into three parts: 1. net_init(), which initializes virtio-net, gets an IP address via DHCP and prints

[Qemu-devel] [PATCH v3 3/3] pc-bios/s390-ccw/net: Add support for .INS config files

2018-04-25 Thread Thomas Huth
The .INS config files can normally be found on CD-ROM ISO images, so by supporting these files, it is now possible to boot directly when the TFTP server is set up with the contents of such an CD-ROM image. Signed-off-by: Thomas Huth --- pc-bios/s390-ccw/netmain.c | 100 ++

Re: [Qemu-devel] [PATCH v3 03/46] configure: add support for --cross-cc-FOO

2018-04-25 Thread Alex Bennée
Richard Henderson writes: > On 04/24/2018 05:23 AM, Alex Bennée wrote: >> @@ -675,10 +687,12 @@ case "$cpu" in >>i386|i486|i586|i686|i86pc|BePC) >> cpu="i386" >> supported_cpu="yes" >> +cross_cc_i386=gcc >>;; >>x86_64|amd64) >> cpu="x86_64" >> supported_cpu="y

Re: [Qemu-devel] [PATCH v3 36/46] tests/tcg/alpha: add Alpha specific tests

2018-04-25 Thread Alex Bennée
Richard Henderson writes: > On 04/24/2018 05:23 AM, Alex Bennée wrote: >> These tests are a little strange as they use their own crt.o stub >> instead of the system supplied one. We also disable the multiarch >> testthread test as that requires a dynamically linked build. >> >> Signed-off-by: Al

Re: [Qemu-devel] [PATCH 0/9] target/arm: Fixups for ARM_FEATURE_V8_FP16

2018-04-25 Thread Alex Bennée
Richard Henderson writes: > When running the gcc testsuite with current aarch64-linux-user, > the testsuite detects the presence of the fp16 extension and > enables lots of extra tests for builtins. > > Quite a few of these new tests fail because we missed implementing > some instructions. We r

[Qemu-devel] [PATCH] hw/pci-host/q35: Replace hardcoded value with macro

2018-04-25 Thread Zihan Yang
Currently part of mch_realize uses hardcoded value when initializing smram regions. Use macro to be more clear to code readers Signed-off-by: Zihan Yang --- hw/pci-host/q35.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c in

Re: [Qemu-devel] [PATCH v2] checkpatch.pl: add common glib defines to typelist

2018-04-25 Thread Markus Armbruster
Peter Xu writes: > Otherwise it can warn this: > > ERROR: space prohibited between function name and open parenthesis '(' > > When with things like this: > > typedef gboolean (*it_tree_iterator)(ITValue start, ITValue end); > > CC: Paolo Bonzini > CC: Stefan Hajnoczi > CC: "Daniel P. Berran

[Qemu-devel] [PATCH] spapr: fix entry point for secondary CPUs

2018-04-25 Thread Cédric Le Goater
Secondary CPUs do not start at SPAPR_ENTRY_POINT but at an address given by the guest OS. Fixes commit c79128c14c20 ("spapr: Make a helper to set up cpu entry point state") Signed-off-by: Cédric Le Goater --- hw/ppc/spapr_cpu_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

Re: [Qemu-devel] [PATCH v1] hw/s390x: Allow to configure the consoles with the "-serial" parameter

2018-04-25 Thread David Hildenbrand
On 25.04.2018 07:21, Thomas Huth wrote: > The consoles ("sclpconsole" and "sclplmconsole") can only be configured > with "-device" and "-chardev" so far. Other machines use the convenience > option "-serial" to configure the default consoles, even for virtual > consoles like spapr-vty on the pserie

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-2.13 03/10] target/ppc: Remove unnecessary initialization of LPCR_UPRT

2018-04-25 Thread Cédric Le Goater
On 04/17/2018 09:17 AM, David Gibson wrote: > In cpu_ppc_set_papr() the UPRT and GTSE bits of the LPCR are initialized > based on on ppc64_radix_guest(). Which seems reasonable, except that > ppc64_radix_guest() is based on spapr->patb_entry which is only set up > in spapr_machine_reset, called mu

Re: [Qemu-devel] [PATCH] migration: update docs

2018-04-25 Thread Balamuruhan S
On Fri, Apr 20, 2018 at 06:57:21PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Update the migration docs: > > Among other changes: > * Added a general list of advice for device authors > * Reordered the section on conditional state (subsections etc) >

[Qemu-devel] [PATCH v2] hw/pci-host/q35: Replace hardcoded value with macro

2018-04-25 Thread Zihan Yang
During smram region initialization some addresses are hardcoded, replace them with macro to be more clear to readers. Previous patch forgets about one value and exceeds the line limit of 90 characters. The v2 breaks a few long lines Signed-off-by: Zihan Yang --- hw/pci-host/q35.c | 17 +

Re: [Qemu-devel] Filtering files passing through MTP devices

2018-04-25 Thread Daniel P . Berrangé
On Mon, Apr 23, 2018 at 03:10:32PM +, Omer Katz wrote: > Hi everyone, > > We have a use case that requires us to only allow certain files to pass > through to the guest machine from USB storage devices. > > I was told on IRC that such a feature does not exist but the easiest way to > achieve

[Qemu-devel] [PATCH v2] linux-user: set minimum uname for RISC-V

2018-04-25 Thread Alex Bennée
As support for RISC-V was only merged into the mainline kernel at 4.15 it is unlikely that glibc will be happy with a reported kernel version of 3.8.0. Indeed when I testing binaries created by the current Debian Sid compiler the tests failed with: FATAL: kernel too old Bump the version to the

Re: [Qemu-devel] QEMU monitor banner printed multiple times

2018-04-25 Thread Marc-André Lureau
Hi On Wed, Apr 25, 2018 at 7:36 AM, Thomas Huth wrote: > Hi, > > I just noticed that sometimes, the QEMU monitor banner is printed > multiple times when you press "CTRL-a c" to enter the monitor: > > $ x86_64-softmmu/qemu-system-x86_64 -no-shutdown -nographic \ > -nodefaults - mon:stdio > QE

Re: [Qemu-devel] [PATCH V5] migration: add capability to bypass the shared memory

2018-04-25 Thread Lai Jiangshan
On Fri, Apr 20, 2018 at 12:38 AM, Dr. David Alan Gilbert wrote: >> -static void ram_list_init_bitmaps(void) >> +static void ram_list_init_bitmaps(RAMState *rs) >> { >> RAMBlock *block; >> unsigned long pages; >> @@ -2151,9 +2152,17 @@ static void ram_list_init_bitmaps(void) >> /*

Re: [Qemu-devel] [PATCH v1] hw/s390x: Allow to configure the consoles with the "-serial" parameter

2018-04-25 Thread Thomas Huth
On 25.04.2018 11:50, David Hildenbrand wrote: > On 25.04.2018 07:21, Thomas Huth wrote: >> The consoles ("sclpconsole" and "sclplmconsole") can only be configured >> with "-device" and "-chardev" so far. Other machines use the convenience >> option "-serial" to configure the default consoles, even

[Qemu-devel] [Bug 1766841] [NEW] QEMU 2.12 Running Problem in Windows 7 Installation

2018-04-25 Thread Justin
Public bug reported: QEMU Version: 2.12 (Binary installer qemu-w64-setup-20180424.exe from Stefan Weil's website so I am not sure I should report it to Weil by email or by this bug report system.) Host System: Windows 7 64bit Guest System: 9front 6350 (Codename“CONTENTS, MAINTAINED, STABLE”, Re

Re: [Qemu-devel] Filtering files passing through MTP devices

2018-04-25 Thread Omer Katz
We're connecting USB drives that we want the guests to copy files from. The user should only be allowed to copy certain files into the system. The same thing goes for copying files to the USB drive. We only allow certain files to be exported from the guest. On Wed, Apr 25, 2018, 12:57 PM Daniel P.

Re: [Qemu-devel] [PATCH v2 2/6] file-win32: Switch to byte-based callbacks

2018-04-25 Thread Kevin Wolf
Am 24.04.2018 um 21:25 hat Eric Blake geschrieben: > We are gradually moving away from sector-based interfaces, towards > byte-based. Make the change for the last few sector-based callbacks > in the file-win32 driver. > > Note that the driver was already using byte-based calls for > performing ac

Re: [Qemu-devel] [Qemu-block] [PATCH v2 4/6] rbd: Switch to byte-based callbacks

2018-04-25 Thread Kevin Wolf
Am 24.04.2018 um 21:53 hat Jason Dillaman geschrieben: > On Tue, Apr 24, 2018 at 3:25 PM, Eric Blake wrote: > > We are gradually moving away from sector-based interfaces, towards > > byte-based. Make the change for the last few sector-based callbacks > > in the rbd driver. > > > > Note that the d

Re: [Qemu-devel] [PATCH v2 0/6] block: byte-based AIO read/write

2018-04-25 Thread Kevin Wolf
Am 24.04.2018 um 21:25 hat Eric Blake geschrieben: > While we would prefer that block drivers use coroutines instead > of aio callbacks, it is a fairly easy exercise to prove that > all existing drivers with aio callbacks are merely scaling > from bytes into sectors and back to bytes. So, even tho

Re: [Qemu-devel] [PATCH] hw/pci-host/q35: Replace hardcoded value with macro

2018-04-25 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1524648037-5010-1-git-send-email-whois.zihan.y...@gmail.com Subject: [Qemu-devel] [PATCH] hw/pci-host/q35: Replace hardcoded value with macro === TEST SCRIPT BEGIN === #!/bi

Re: [Qemu-devel] [PATCH] block: Merge .bdrv_co_writev{, _flags} in drivers

2018-04-25 Thread Kevin Wolf
Am 25.04.2018 um 10:06 hat Daniel P. Berrangé geschrieben: > On Tue, Apr 24, 2018 at 05:01:57PM -0500, Eric Blake wrote: > > We have too many driver callback interfaces; simplify the mess > > somewhat by merging the flags parameter of .bdrv_co_writev_flags() > > into .bdrv_co_writev_flags(). Note

Re: [Qemu-devel] [PATCH v2 1/9] block: Add COR filter driver

2018-04-25 Thread Max Reitz
On 2018-04-24 17:08, Alberto Garcia wrote: > On Sat 21 Apr 2018 03:29:21 PM CEST, Max Reitz wrote: >> This adds a simple copy-on-read filter driver. It relies on the already >> existing COR functionality in the central block layer code, which may be >> moved here once we no longer need it there. >

[Qemu-devel] [PATCH v8 0/8] Add make check tests for Migration

2018-04-25 Thread Juan Quintela
Hi v8: - just rebase to make things continue to wonk New in the other v7: - SocketAddress is now a list (a.k.a make happy danp) - Rebase on top of upstream network listener is *interesting* - *HACK* to make SocketAddress list in common see patch: create-socket-paramenter Please review, Jua

[Qemu-devel] [PATCH v8 6/8] tests: Add basic migration precopy tcp test

2018-04-25 Thread Juan Quintela
Not sharing code from precopy/unix because we have to read back the tcp parameter. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- tests/migration-test.c | 83 -- 1 file changed, 80 insertions(+), 3 deletions(-)

[Qemu-devel] [PATCH v8 3/8] tests: Add migration xbzrle test

2018-04-25 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Peter Xu --- tests/migration-test.c | 64 ++ 1 file changed, 64 insertions(+) diff --git a/tests/migration-test.c b/tests/migration-test.c index 834cdf50f2..fd885ba909 100644 --- a/tests/migration-test.c +++ b/tes

[Qemu-devel] [PATCH v8 1/8] qemu-sockets: Export SocketAddress_to_str

2018-04-25 Thread Juan Quintela
Migration code needs that function in hmp.c (so we need to export it), and it needs it on tests/migration-test.c, so we need to move it to a place where it is compiled into the test framework. Signed-off-by: Juan Quintela --- chardev/char-socket.c | 29 - include/qem

[Qemu-devel] [PATCH v8 4/8] migration: Create socket-address parameter

2018-04-25 Thread Juan Quintela
It will be used to store the uri parameters. We want this only for tcp, so we don't set it for other uris. We need it to know what port is migration running. Signed-off-by: Juan Quintela -- This used to be uri parameter, but it has so many troubles to reproduce that it don't just make sense.

[Qemu-devel] [PATCH v8 8/8] [RFH] tests: Add migration compress threads tests

2018-04-25 Thread Juan Quintela
Yeap, it is still not working. trying to learn how to debug threads for guests running from the testt hardness. For some reason, compression is not working at the moment, test is disabled until I found why. Signed-off-by: Juan Quintela --- tests/migration-test.c | 52 +++

[Qemu-devel] [PATCH v8 2/8] tests: Add migration precopy test

2018-04-25 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- tests/migration-test.c | 44 -- 1 file changed, 42 insertions(+), 2 deletions(-) diff --git a/tests/migration-test.c b/tests/migration-test.c index 422bf1afdf..834

[Qemu-devel] [PATCH v8 5/8] tests: Migration ppc now inlines its program

2018-04-25 Thread Juan Quintela
No need to write it to a file. Just need a proper firmware O:-) Signed-off-by: Juan Quintela CC: Laurent Vivier --- tests/migration-test.c | 41 + 1 file changed, 5 insertions(+), 36 deletions(-) diff --git a/tests/migration-test.c b/tests/migration-tes

[Qemu-devel] [PATCH v8 7/8] migration: Add multifd test

2018-04-25 Thread Juan Quintela
We set the x-multifd-page-count and x-multifd-channels. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- tests/migration-test.c | 48 ++ 1 file changed, 48 insertions(+) diff --git a/tests/migration-test.c b/tests/migration-test.c ind

[Qemu-devel] [RFC v2 1/2] virtio: add pmem driver

2018-04-25 Thread Pankaj Gupta
This patch adds virtio-pmem driver for KVM guest. Guest reads the persistent memory range information from Qemu over VIRTIO and registers it on nvdimm_bus. It also creates a nd_region object with the persistent memory range information so that existing 'nvdimm/pmem' driver can reserve this

[Qemu-devel] [RFC v2 0/2] kvm "fake DAX" device flushing

2018-04-25 Thread Pankaj Gupta
This is RFC V2 for 'fake DAX' flushing interface sharing for review. This patchset has two main parts: - Guest virtio-pmem driver Guest driver reads persistent memory range from paravirt device and registers with 'nvdimm_bus'. 'nvdimm/pmem' driver uses this information to allocate persiste

[Qemu-devel] [PATCH v12 01/21] migration: Set error state in case of error

2018-04-25 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/ram.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 0e90efa092..2ae560ea80 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -415,10 +415,20 @@ struct { int

[Qemu-devel] [RFC v2] qemu: Add virtio pmem device

2018-04-25 Thread Pankaj Gupta
This patch adds virtio-pmem Qemu device. This device presents memory address range information to guest which is backed by file backend type. It acts like persistent memory device for KVM guest. Guest can perform read and persistent write operations on this memory range with the help of DAX c

[Qemu-devel] [PATCH v12 05/21] migration: Export functions to create send channels

2018-04-25 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Daniel P. Berrangé --- migration/socket.c | 28 +++- migration/socket.h | 7 +++ 2 files changed, 34 insertions(+), 1 deletion(-) diff --git a/migration/socket.c b/migration/socket.c index edf33c70cf..893a04f4cc 100644 --- a

[Qemu-devel] [RFC v2 2/2] pmem: device flush over VIRTIO

2018-04-25 Thread Pankaj Gupta
This patch adds functionality to perform flush from guest to hosy over VIRTIO when 'ND_REGION_VIRTIO'flag is set on nd_negion. Flag is set by 'virtio-pmem' driver. Signed-off-by: Pankaj Gupta --- drivers/nvdimm/region_devs.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/n

[Qemu-devel] [PATCH v12 00/21] Multifd

2018-04-25 Thread Juan Quintela
Hi [v12] Big news, it is not RFC anymore, it works reliabely for me. Changes: - Locknig changed completely (several times) - We now send all pages through the channels. In a 2GB guest with 1 disk and a network card, the amount of data send for RAM was 80KB. - This is not optimized yet, but

[Qemu-devel] [PATCH v12 03/21] migration: terminate_* can be called for other threads

2018-04-25 Thread Juan Quintela
Once there, make count field to always be accessed with atomic operations. To make blocking operations, we need to know that the thread is running, so create a bool to indicate that. Signed-off-by: Juan Quintela Reviewed-by: Daniel P. Berrangé -- Once here, s/terminate_multifd_*-threads/mult

[Qemu-devel] [PATCH v12 09/21] migration: Define MultifdRecvParams sooner

2018-04-25 Thread Juan Quintela
Once there, we don't need the struct names anywhere, just the typedefs. And now also document all fields. Signed-off-by: Juan Quintela --- migration/ram.c | 46 +++--- 1 file changed, 31 insertions(+), 15 deletions(-) diff --git a/migration/ram.c b/migra

[Qemu-devel] [PATCH v12 02/21] migration: Introduce multifd_recv_new_channel()

2018-04-25 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Daniel P. Berrangé --- migration/migration.c | 3 ++- migration/ram.c | 6 ++ migration/ram.h | 2 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/migration/migration.c b/migration/migration.c index 7eca65d1f0..604722cec

[Qemu-devel] [PATCH v12 06/21] migration: Create multifd channels

2018-04-25 Thread Juan Quintela
In both sides. We still don't transmit anything through them. Signed-off-by: Juan Quintela Reviewed-by: Daniel P. Berrangé --- migration/ram.c | 52 +++-- 1 file changed, 42 insertions(+), 10 deletions(-) diff --git a/migration/ram.c b/migration/ram

[Qemu-devel] [PATCH v12 10/21] migration: Create multipage support

2018-04-25 Thread Juan Quintela
We only create/destry the page list here. We will use it later. Signed-off-by: Juan Quintela --- migration/ram.c | 56 + 1 file changed, 56 insertions(+) diff --git a/migration/ram.c b/migration/ram.c index ffefa73099..b19300992e 100644 --- a/mig

[Qemu-devel] [PATCH v12 16/21] migration: Synchronize multifd threads with main thread

2018-04-25 Thread Juan Quintela
We synchronize all threads each RAM_SAVE_FLAG_EOS. Bitmap synchronizations don't happen inside a ram section, so we are safe about two channels trying to overwrite the same memory. Signed-off-by: Juan Quintela --- migration/ram.c| 118 + migratio

[Qemu-devel] [PATCH v12 04/21] migration: Be sure all recv channels are created

2018-04-25 Thread Juan Quintela
We need them before we start migration. Signed-off-by: Juan Quintela Reviewed-by: Daniel P. Berrangé --- migration/migration.c | 6 +- migration/ram.c | 11 +++ migration/ram.h | 1 + 3 files changed, 17 insertions(+), 1 deletion(-) diff --git a/migration/migration.c

[Qemu-devel] [PATCH v12 07/21] migration: Delay start of migration main routines

2018-04-25 Thread Juan Quintela
We need to make sure that we have started all the multifd threads. Signed-off-by: Juan Quintela Reviewed-by: Daniel P. Berrangé --- migration/migration.c | 4 ++-- migration/migration.h | 1 + migration/ram.c | 3 +++ migration/socket.c| 4 4 files changed, 10 insertions(+), 2 de

[Qemu-devel] [PATCH v12 11/21] migration: Create multifd packet

2018-04-25 Thread Juan Quintela
We still don't put anything there. Signed-off-by: Juan Quintela --- migration/ram.c | 137 +++- 1 file changed, 136 insertions(+), 1 deletion(-) diff --git a/migration/ram.c b/migration/ram.c index b19300992e..804c83ed89 100644 --- a/migration/ram.c +

[Qemu-devel] [PATCH v12 19/21] migration: Wait for blocking IO

2018-04-25 Thread Juan Quintela
We have three conditions here: - channel fails -> error - we have to quit: we close the channel and reads fails - normal read that success, we are in bussiness So forget the complications of waiting in a semaphore. Signed-off-by: Juan Quintela --- migration/ram.c | 81 ++

[Qemu-devel] [PATCH v12 08/21] migration: Transmit initial package through the multifd channels

2018-04-25 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Daniel P. Berrangé -- Be network agnostic. Add error checking for all values. --- migration/ram.c | 101 +--- 1 file changed, 96 insertions(+), 5 deletions(-) diff --git a/migration/ram.c b/migration/ram.c i

[Qemu-devel] [PATCH v12 14/21] migration: Multifd channels always wait on the sem

2018-04-25 Thread Juan Quintela
Either for quit, sync or packet, we first wake them. Signed-off-by: Juan Quintela --- migration/ram.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 0f1340b4e3..21b448c4ed 100644 --- a/migration/ram.c +++ b/migration/ram

[Qemu-devel] [PATCH v12 12/21] migration: Add multifd traces for start/end thread

2018-04-25 Thread Juan Quintela
We want to know how many pages/packets each channel has sent. Add counters for those. Signed-off-by: Juan Quintela --- migration/ram.c| 20 migration/trace-events | 4 2 files changed, 24 insertions(+) diff --git a/migration/ram.c b/migration/ram.c index 804c

[Qemu-devel] [PATCH v12 13/21] migration: Calculate transferred ram correctly

2018-04-25 Thread Juan Quintela
On multifd we send data from more places that main channel. Signed-off-by: Juan Quintela --- migration/migration.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 9b510a809a..75d30661e9 100644 --- a/migration/mig

[Qemu-devel] [PATCH v12 20/21] migration: Remove not needed semaphore and quit

2018-04-25 Thread Juan Quintela
We know quit closing the QIO. Signed-off-by: Juan Quintela --- migration/ram.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 2734f91ded..23203756b7 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -488,14 +488,10 @@ t

[Qemu-devel] [PATCH v12 15/21] migration: Add block where to send/receive packets

2018-04-25 Thread Juan Quintela
Once there add tracepoints. Signed-off-by: Juan Quintela --- migration/ram.c| 49 +- migration/trace-events | 2 ++ 2 files changed, 46 insertions(+), 5 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 21b448c4ed..c4c185cc4c 1006

[Qemu-devel] [PATCH v12 18/21] migration: Start sending messages

2018-04-25 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/ram.c | 30 -- 1 file changed, 24 insertions(+), 6 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 862ec53d32..9adbaa81f9 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -625,9 +625,6 @@ static int mul

[Qemu-devel] [PATCH v12 21/21] migration: Stop sending whole pages through main channel

2018-04-25 Thread Juan Quintela
We have to flush() the QEMUFile because now we sent really few data through that channel. Signed-off-by: Juan Quintela --- migration/ram.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 23203756b7..f5cff2eb59 100644 --- a/m

Re: [Qemu-devel] [PATCH v2 1/9] block: Add COR filter driver

2018-04-25 Thread Alberto Garcia
On Wed 25 Apr 2018 01:18:03 PM CEST, Max Reitz wrote: >>> +#define PERM_PASSTHROUGH (BLK_PERM_CONSISTENT_READ \ >>> + | BLK_PERM_WRITE \ >>> + | BLK_PERM_RESIZE) >>> +#define PERM_UNCHANGED (BLK_PERM_ALL & ~PERM_PASSTHROUGH) >>> + >>> +static void

[Qemu-devel] [PATCH v12 17/21] migration: Create ram_multifd_page

2018-04-25 Thread Juan Quintela
The function still don't use multifd, but we have simplified ram_save_page, xbzrle and RDMA stuff is gone. We have added a new counter. Signed-off-by: Juan Quintela -- Add last_page parameter Add commets for done and address Remove multifd field, it is the same than normal pages Merge next patc

Re: [Qemu-devel] [PATCH for 2.13 v4 00/20] linux-user: move arch specific parts to arch directories

2018-04-25 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180424192635.6027-1-laur...@vivier.eu Subject: [Qemu-devel] [PATCH for 2.13 v4 00/20] linux-user: move arch specific parts to arch directories === TEST SCRIPT BEGIN === #!

Re: [Qemu-devel] [PATCH v12 00/21] Multifd

2018-04-25 Thread Juan Quintela
Juan Quintela wrote: > Hi > > > [v12] > > Big news, it is not RFC anymore, it works reliabely for me. > > Changes: > - Locknig changed completely (several times) > - We now send all pages through the channels. In a 2GB guest with 1 disk > and a network card, the amount of data send for RAM was

Re: [Qemu-devel] [PATCH v2 2/2] ui: introduce vfio_display_reset

2018-04-25 Thread Gerd Hoffmann
> /* -- */ > +void vfio_display_reset(VFIOPCIDevice *vdev) > +{ > +if (!vdev || !vdev->dpy || !vdev->dpy->con) { > +return; > +} > + > +dpy_gl_scanout_disable(vdev->dpy->con); This should not be called with a

Re: [Qemu-devel] [RFC v2] qemu: Add virtio pmem device

2018-04-25 Thread Pankaj Gupta
Hi, Compile failures are because Qemu 'Memory-Device changes' are not yet in qemu master. As mentioned in Qemu patch message patch is dependent on 'Memeory-device' patches by 'David Hildenbrand'. Already picked up by maintainer. > Hi, > > This series failed build test on s390x host. Please find

Re: [Qemu-devel] [PATCH v1] hw/s390x: Allow to configure the consoles with the "-serial" parameter

2018-04-25 Thread Christian Borntraeger
On 04/25/2018 07:21 AM, Thomas Huth wrote: > The consoles ("sclpconsole" and "sclplmconsole") can only be configured > with "-device" and "-chardev" so far. Other machines use the convenience > option "-serial" to configure the default consoles, even for virtual > consoles like spapr-vty on the p

Re: [Qemu-devel] [PATCH v3 0/3] pc-dimm: factor out MemoryDevice

2018-04-25 Thread Igor Mammedov
On Tue, 24 Apr 2018 17:42:44 +0200 David Hildenbrand wrote: > On 24.04.2018 16:00, Igor Mammedov wrote: > > On Mon, 23 Apr 2018 11:32:25 -0400 (EDT) > > Pankaj Gupta wrote: > > > >> Hi Igor, > >> > >>> > Right now we can only map PCDIMM/NVDIMM into guest address space. In the > >>

Re: [Qemu-devel] [PATCH v2 0/9] block: Add COR filter driver

2018-04-25 Thread Max Reitz
On 2018-04-21 15:29, Max Reitz wrote: > This series adds a copy-on-read block filter driver which works by > simply setting the BDRV_REQ_COPY_ON_READ flag on write requests (and > otherwise just passing everything through). > > Cover letter of v1: > http://lists.nongnu.org/archive/html/qemu-block/

Re: [Qemu-devel] [PATCH v3 2/3] pc-bios/s390-ccw/net: Use diag308 to reset machine before jumping to the OS

2018-04-25 Thread Christian Borntraeger
On 04/25/2018 11:08 AM, Thomas Huth wrote: > --- a/pc-bios/s390-ccw/netmain.c > +++ b/pc-bios/s390-ccw/netmain.c > @@ -283,6 +283,15 @@ void panic(const char *string) > } > } > > +void write_subsystem_identification(void) > +{ > +uint32_t *schid = (uint32_t *) 184; > +uint32_t *z

Re: [Qemu-devel] [PATCH 0/6] qapi: introduce the SysEmuTarget enumeration

2018-04-25 Thread Laszlo Ersek
On 04/25/18 00:03, no-re...@patchew.org wrote: > Hi, > > This series failed docker-mingw@fedora build test. Please find the testing > commands and > their output below. If you have Docker installed, you can probably reproduce > it > locally. [snip] > qapi/qapi-types-misc.h:654:20: error: expec

Re: [Qemu-devel] [PATCH 1/6] qapi: fill in CpuInfoFast.arch in query-cpus-fast

2018-04-25 Thread Laszlo Ersek
On 04/25/18 08:39, Markus Armbruster wrote: > Laszlo Ersek writes: > >> Commit ca230ff33f89 added added the @arch field to @CpuInfoFast, but it >> failed to set the new field in qmp_query_cpus_fast(), when TARGET_S390X >> was not defined. The updated @query-cpus-fast example in >> "qapi-schema.js

Re: [Qemu-devel] [PATCH 1/6] qapi: fill in CpuInfoFast.arch in query-cpus-fast

2018-04-25 Thread Laszlo Ersek
On 04/25/18 00:30, Eric Blake wrote: > On 04/24/2018 04:45 PM, Laszlo Ersek wrote: >> Commit ca230ff33f89 added added the @arch field to @CpuInfoFast, but it > > s/added added/added/ The more I edit commit messages, the more I mess them up :) Thanks! Laszlo

Re: [Qemu-devel] [PATCH v1] hw/s390x: Allow to configure the consoles with the "-serial" parameter

2018-04-25 Thread Peter Maydell
On 25 April 2018 at 11:17, Thomas Huth wrote: > On 25.04.2018 11:50, David Hildenbrand wrote: >> On 25.04.2018 07:21, Thomas Huth wrote: >>> The consoles ("sclpconsole" and "sclplmconsole") can only be configured >>> with "-device" and "-chardev" so far. Other machines use the convenience >>> opti

Re: [Qemu-devel] [PATCH 2/6] qapi: handle the riscv CpuInfoArch in query-cpus-fast

2018-04-25 Thread Laszlo Ersek
On 04/25/18 00:32, Eric Blake wrote: > On 04/24/2018 04:45 PM, Laszlo Ersek wrote: >> Commit 25fa194b7b11 added the @riscv enum constant to @CpuInfoArch (used >> in both @CpuInfo and @CpuInfoFast -- the return types of the @query-cpus >> and @query-cpus-fast commands, respectively), and assigned, i

  1   2   3   4   >