Re: [Qemu-devel] [PULL v2 21/50] Makefile: add target to print generated files

2018-04-13 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > This is helpful for automatic code analysis. Out of curiosity: how? > Signed-off-by: Michael S. Tsirkin > --- > Makefile | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Makefile b/Makefile > index 677a54b..f799390 100644 > --- a/Makefile > +++ b/Make

Re: [Qemu-devel] [PATCH] cpu: skip unpluged cpu when querying cpus

2018-04-13 Thread xuyandong
Yes, we should add it at qmp_query_cpus_fast() . In this case, qmp_query_cpus() may kick a vcpu thread that has stopped causing the qemu process to exit, qmp_query_cpus_fast() does not interrupt vCPU threads, but may return invalid vCPU information. > -Original Message- > From: Igor Mamm

[Qemu-devel] [PATCH v2] migration: discard non-migratable RAMBlocks

2018-04-13 Thread Cédric Le Goater
On the POWER9 processor, the XIVE interrupt controller can control interrupt sources using MMIO to trigger events, to EOI or to turn off the sources. Priority management and interrupt acknowledgment is also controlled by MMIO in the presenter sub-engine. These MMIO regions are exposed to guests in

[Qemu-devel] Hot add vcpu not working in Windows server 2012r2

2018-04-13 Thread Wuzongyong (Euler Dept)
Hi, I try to hot add vcpus to a windows server 2012r2 virtual machine on RHEL 7.4 platform. But Task Manager didn't show extra processors I hot added though they appeared in Device Manager. Actually, I need to require reboot the vm to make processors hot Added appear in Task Manager. Is there so

Re: [Qemu-devel] [PATCH 4/4] pc-bios/s390-ccw: fix non-sequential boot entries (enum)

2018-04-13 Thread Thomas Huth
On 10.04.2018 17:01, Collin Walling wrote: > zIPL boot menu entries can be non-sequential. Let's account > for this issue for the s390 enumerated boot menu. Since we > can no longer print a range of available entries to the > user, we have to present a list of each available entry. > > An example

Re: [Qemu-devel] [PATCH for 2.13 v3 1/2] spapr: Add ibm, max-associativity-domains property

2018-04-13 Thread Bharata B Rao
On Wed, Apr 11, 2018 at 02:41:59PM -0400, Serhii Popovych wrote: > Now recent kernels (i.e. since linux-stable commit a346137e9142 > ("powerpc/numa: Use ibm,max-associativity-domains to discover possible nodes") > support this property to mark initially memory-less NUMA nodes as "possible" > to all

Re: [Qemu-devel] [PATCH 07/19] block: Really pause block jobs on drain

2018-04-13 Thread Kevin Wolf
Am 12.04.2018 um 22:44 hat Paolo Bonzini geschrieben: > On 12/04/2018 16:25, Kevin Wolf wrote: > > This is already the order we have there. What is probably different from > > what you envision is that after the parents have concluded, we still > > check that they are still quiescent in every itera

Re: [Qemu-devel] [PATCH v2] migration: discard non-migratable RAMBlocks

2018-04-13 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180413075200.15217-1-...@kaod.org Subject: [Qemu-devel] [PATCH v2] migration: discard non-migratable RAMBlocks === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(

Re: [Qemu-devel] [PULL v2 21/50] Makefile: add target to print generated files

2018-04-13 Thread Marc-André Lureau
Hi On Fri, Apr 13, 2018 at 9:21 AM, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > >> This is helpful for automatic code analysis. > > Out of curiosity: how? > >> Signed-off-by: Michael S. Tsirkin >> --- >> Makefile | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Make

Re: [Qemu-devel] [qemu-s390x] [PATCH v1] cpus: track calls to resume/pause_all_vcpus()

2018-04-13 Thread David Hildenbrand
On 09.04.2018 15:07, David Hildenbrand wrote: > If we have parallel calls to resume/pause_all_vcpus() we can get > into trouble because the qemu mutex is temporarily dropped while > waiting for all threads to stop. This can happen e.g. for s390x, where > resume/pause_all_vcpus() can be triggered by

Re: [Qemu-devel] [PATCH v2 1/2 for-2.12?] qapi: Parameter gl of DisplayType now accept an enum

2018-04-13 Thread Elie Tournier
On Fri, Apr 13, 2018 at 08:15:29AM +0200, Gerd Hoffmann wrote: > On Thu, Apr 12, 2018 at 03:11:53PM +0100, Elie Tournier wrote: > > Hello, > > > > On Tue, Apr 10, 2018 at 03:33:35PM +0200, Gerd Hoffmann wrote: > > > > # @off: Disable OpenGL (default). > > > > Just to be sure, I have to add @ in f

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2018-04-13 Thread TJ
** Also affects: qemu (Ubuntu) Importance: Undecided Status: New ** Changed in: qemu (Ubuntu) Status: New => Confirmed ** Changed in: qemu (Ubuntu) Milestone: None => ubuntu-16.04.5 -- You received this bug notification because you are a member of qemu- devel-ml, which is s

Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread

2018-04-13 Thread Marc-André Lureau
On Thu, Apr 12, 2018 at 8:11 AM, Peter Xu wrote: > In the future the monitor iothread may be accessing the cur_mon as > well (via monitor_qmp_dispatch_one()). Before we introduce a real > Out-Of-Band command, let's convert the cur_mon variable to be a > per-thread variable to make sure there won'

[Qemu-devel] [Bug 1754372] Re: Set MIPS MSA in ELF Auxiliary Vectors

2018-04-13 Thread Peter Maydell
Fix now in master as commit 46a1ee4f397ff and will be in 2.12. ** Changed in: qemu Status: In Progress => Fix Committed ** Tags added: linux-user -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bug

[Qemu-devel] [Bug 1754372] Re: Set MIPS MSA in ELF Auxiliary Vectors

2018-04-13 Thread Gonzalo
Thanks ! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1754372 Title: Set MIPS MSA in ELF Auxiliary Vectors Status in QEMU: Fix Committed Bug description: The MIPS MSA feature is currently no

[Qemu-devel] [Bug 1714538] Re: Support for Raspberry Pi 3 Model B

2018-04-13 Thread Peter Maydell
We have a raspi3 model in QEMU now, it will be available in the upcoming 2.12 release. ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1714538

[Qemu-devel] [Bug 902720] Re: TIME_MAX not set correctly for OpenBSD in qemu-common.h

2018-04-13 Thread Peter Maydell
This was fixed in commit e7b47c22e2df14d, which was in the 2.11.0 release. ** Changed in: qemu Status: Triaged => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/902720 Title: T

Re: [Qemu-devel] [Qemu-block] [PATCH 07/19] block: Really pause block jobs on drain

2018-04-13 Thread Paolo Bonzini
On 13/04/2018 10:01, Kevin Wolf wrote: >> Or bs->quiescent, for the sake of bikeshedding. > Yes, that sounds better. > > The only problem with the proposal as I made it is that it's wrong. We > can't keep bs->quiescent until bdrv_do_drained_end() because the caller > can issue new requests and the

[Qemu-devel] [Bug 1583775] Re: Feature Request: qemu 2.6.0

2018-04-13 Thread Peter Maydell
Hi; I'm going to close this because it isn't a bug in upstream QEMU (which only does source releases). ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs

[Qemu-devel] [PATCH] m68: fix exception stack frame for 68000

2018-04-13 Thread Pavel Dovgalyuk
68000 CPUs do not save format in the exception stack frame. This patch adds feature checking to prevent format saving for 68000. m68k_ret() already includes this modification, this patch fixes the exception processing function too. Signed-off-by: Pavel Dovgalyuk --- target/m68k/op_helper.c |

[Qemu-devel] [Bug 1714538] Re: Support for Raspberry Pi 3 Model B

2018-04-13 Thread Taylor Holberton
I saw that in the mailing list! Can't wait to try it out! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1714538 Title: Support for Raspberry Pi 3 Model B Status in QEMU: Fix Committed Bug descr

Re: [Qemu-devel] [PATCH v2] migration: discard non-migratable RAMBlocks

2018-04-13 Thread Juan Quintela
no-re...@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series > Message-id: 20180413075200.15217-1-...@kaod.org > Subject: [Qemu-devel] [PATCH v2] migration: discard non-migratable RAMBlocks > > === OUTPUT BEGI

Re: [Qemu-devel] [PULL, 08/36] qapi: Remove qobject_to_X() functions

2018-04-13 Thread Yuval Shaia
On Thu, Apr 12, 2018 at 03:52:50PM -0500, Eric Blake wrote: > On 04/12/2018 12:51 PM, Yuval Shaia wrote: > > Hi Eric, > > > > On Mon, Mar 12, 2018 at 01:35:59PM -0500, Eric Blake wrote: > >> From: Max Reitz > >> > >> They are no longer needed now. > > > > I'm doing some off-list development whic

[Qemu-devel] QEMU fails to build on MIPS

2018-04-13 Thread Peter Maydell
mst pointed this out, and I can reproduce it. (I don't have MIPS in my set of build targets for pull requests because I don't have access to any sufficiently fast MIPS hosts.) In file included from /home/pm215/qemu/include/qemu/osdep.h:36:0, from /home/pm215/qemu/tcg/tcg.c:28: /ho

Re: [Qemu-devel] [PATCH v2] migration: discard non-migratable RAMBlocks

2018-04-13 Thread Peter Maydell
On 13 April 2018 at 12:18, Juan Quintela wrote: > no-re...@patchew.org wrote: >> === OUTPUT BEGIN === >> Checking PATCH 1/1: migration: discard non-migratable RAMBlocks... >> ERROR: Macros with multiple statements should be enclosed in a do - while >> loop >> #96: FILE: migration/ram.c:191: >> +#

Re: [Qemu-devel] [PATCH v7 1/8] qemu-sockets: Export SocketAddress_to_str

2018-04-13 Thread Daniel P . Berrangé
On Wed, Apr 04, 2018 at 01:27:24PM +0200, Juan Quintela wrote: > Migration code needs that function in hmp.c (so we need to export it), > and it needs it on tests/migration-test.c, so we need to move it to a > place where it is compiled into the test framework. > > Signed-off-by: Juan Quintela >

Re: [Qemu-devel] [PATCH v7 4/8] migration: Create socket-address parameter

2018-04-13 Thread Daniel P . Berrangé
On Wed, Apr 04, 2018 at 01:27:27PM +0200, Juan Quintela wrote: > It will be used to store the uri parameters. We want this only for > tcp, so we don't set it for other uris. We need it to know what port > is migration running. > > Signed-off-by: Juan Quintela > > -- > > This used to be uri par

Re: [Qemu-devel] [PATCH v7 4/8] migration: Create socket-address parameter

2018-04-13 Thread Daniel P . Berrangé
On Thu, Apr 12, 2018 at 02:09:33PM +0100, Dr. David Alan Gilbert wrote: > * Juan Quintela (quint...@redhat.com) wrote: > > It will be used to store the uri parameters. We want this only for > > tcp, so we don't set it for other uris. We need it to know what port > > is migration running. > > > >

Re: [Qemu-devel] [Qemu-block] [PATCH 07/19] block: Really pause block jobs on drain

2018-04-13 Thread Kevin Wolf
Am 13.04.2018 um 13:05 hat Paolo Bonzini geschrieben: > On 13/04/2018 10:01, Kevin Wolf wrote: > >> Or bs->quiescent, for the sake of bikeshedding. > > Yes, that sounds better. > > > > The only problem with the proposal as I made it is that it's wrong. We > > can't keep bs->quiescent until bdrv_do

Re: [Qemu-devel] [PATCH] m68: fix exception stack frame for 68000

2018-04-13 Thread Laurent Vivier
Le 13/04/2018 à 13:12, Pavel Dovgalyuk a écrit : > 68000 CPUs do not save format in the exception stack frame. > This patch adds feature checking to prevent format saving for 68000. > m68k_ret() already includes this modification, this patch fixes > the exception processing function too. > > Signe

Re: [Qemu-devel] [PATCH 05/14] timer: ds1338 change write handling

2018-04-13 Thread Peter Maydell
On 24 March 2018 at 19:24, Michael Davidsaver wrote: > instead of a read-modify-write, do direct translation > of device registers to struct tm members. > > This new ds1338_update() is the reverse of > the existing capture_current_time(). > > Simplifies later handling of CENTURY bit in > similar D

Re: [Qemu-devel] [PATCH 07/14] timer: ds1338 fix wday_offset handling

2018-04-13 Thread Peter Maydell
On 24 March 2018 at 19:24, Michael Davidsaver wrote: > Correctly handle different real weekday in > guest and host timezones. > Allow guest to use any day as start of week > (day 1). eg. Monday instead of Sunday. > > Signed-off-by: Michael Davidsaver > --- > hw/timer/ds1338.c | 24 +

[Qemu-devel] [PATCH] Show values and description when using "qom-list"

2018-04-13 Thread Perez Blanco, Ricardo (Nokia - BE/Antwerp)
Dear all, Here you can find my first contribution to qemu. Please, do not hesitate to do any kind of remark. Based on ac4ba87ae0738d7a77708f8ce31ae2378ab99654 Kind regards, Ricardo Perez Blanco >From 65df20cef2846d764a8a821574f5f3643391aac5 Mon Sep 17 00:00:00 2001 From: Ricardo Perez Blanco

Re: [Qemu-devel] [PATCH v2 07/29] qapi: Turn generators into modules

2018-04-13 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, Feb 27, 2018 at 09:53:22AM -0600, Eric Blake wrote: >> On 02/11/2018 03:35 AM, Markus Armbruster wrote: >> > The next commit will introduce a common driver program for all >> > generators. The generators need to be modules for that. qapi2texi.py >> > already

Re: [Qemu-devel] [PATCH 10/14] timer: rename file ds1338.c -> ds-rtc.c

2018-04-13 Thread Peter Maydell
2018-03-24 19:24 GMT+00:00 Michael Davidsaver : > Signed-off-by: Michael Davidsaver > --- > default-configs/arm-softmmu.mak | 2 +- > hw/timer/Makefile.objs | 2 +- > hw/timer/{ds1338.c => ds-rtc.c} | 0 > 3 files changed, 2 insertions(+), 2 deletions(-) > rename hw/timer/{ds1338.c => d

Re: [Qemu-devel] [PATCH 09/14] timer: rename ds1338 -> dsrtc

2018-04-13 Thread Peter Maydell
On 24 March 2018 at 19:24, Michael Davidsaver wrote: > Prepare to generalize with a more generic > name. > > Keep device name and vmstate name "ds1338" > for compatibility. > > Signed-off-by: Michael Davidsaver > --- > hw/timer/ds1338.c | 74 > +++

Re: [Qemu-devel] [PULL v2 21/50] Makefile: add target to print generated files

2018-04-13 Thread Michael S. Tsirkin
On Fri, Apr 13, 2018 at 12:04:20PM +0200, Marc-André Lureau wrote: > Hi > > On Fri, Apr 13, 2018 at 9:21 AM, Markus Armbruster wrote: > > "Michael S. Tsirkin" writes: > > > >> This is helpful for automatic code analysis. > > > > Out of curiosity: how? > > > >> Signed-off-by: Michael S. Tsirkin

Re: [Qemu-devel] [PATCH] Show values and description when using "qom-list"

2018-04-13 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: am3pr07mb273186aefa49a506bfc2d28b3...@am3pr07mb273.eurprd07.prod.outlook.com Subject: [Qe

Re: [Qemu-devel] [PATCH 11/14] timer: generalize ds1338

2018-04-13 Thread Peter Maydell
On 24 March 2018 at 19:24, Michael Davidsaver wrote: > Add class level handling for address space size > and control register. > > Signed-off-by: Michael Davidsaver > --- > @@ -206,22 +216,15 @@ static void dsrtc_update(DSRTCState *s) > static int dsrtc_send(I2CSlave *i2c, uint8_t data) > { >

Re: [Qemu-devel] [PATCH 12/14] timer: ds-rtc handle CENTURY bit

2018-04-13 Thread Peter Maydell
On 24 March 2018 at 19:24, Michael Davidsaver wrote: > Signed-off-by: Michael Davidsaver > --- > hw/timer/ds-rtc.c | 22 ++ > 1 file changed, 14 insertions(+), 8 deletions(-) > > diff --git a/hw/timer/ds-rtc.c b/hw/timer/ds-rtc.c > index 2df1bce3f8..5a4df1b115 100644 > --- a/

Re: [Qemu-devel] [PATCH 13/14] timer: ds-rtc model ds1375

2018-04-13 Thread Peter Maydell
On 24 March 2018 at 19:24, Michael Davidsaver wrote: > differences from ds1338 > > * Has alarms (not modeled) > * different control register (not modeled) > * smaller address space (0x20 vs. 0x40) > > Signed-off-by: Michael Davidsaver > --- > hw/timer/ds-rtc.c | 30 --

Re: [Qemu-devel] [PATCH 00/14] Generalize Dallas/Maxim I2C RTC devices v2

2018-04-13 Thread Peter Maydell
On 24 March 2018 at 19:24, Michael Davidsaver wrote: > This series generalizes the ds1338 model to also support the ds1375. > As previously, only the time of day registers are modeled. This > series is largely a do-over wrt. my previous series. This time I > started with incremental changes from

Re: [Qemu-devel] [PATCH v2 1/2 for-2.12?] qapi: Parameter gl of DisplayType now accept an enum

2018-04-13 Thread Gerd Hoffmann
> > No need to hurry with this. QMP doesn't see the structs, so no > > compatibility problem here. gl=on cmd line option was present in 2.11 + > > older already, so that must continue to work no matter whenever this > > makes 2.12 or not. > > Alright, thanks. > Well, to be fair, I just want to s

Re: [Qemu-devel] [PATCH] m68: fix exception stack frame for 68000

2018-04-13 Thread Pavel Dovgalyuk
> From: Laurent Vivier [mailto:laur...@vivier.eu] > Le 13/04/2018 à 13:12, Pavel Dovgalyuk a écrit : > > 68000 CPUs do not save format in the exception stack frame. > > This patch adds feature checking to prevent format saving for 68000. > > m68k_ret() already includes this modification, this patch

Re: [Qemu-devel] [RFC 2/8] hw/intc/arm_gicv3: Use an array of redistributor regions

2018-04-13 Thread Peter Maydell
On 27 March 2018 at 15:15, Eric Auger wrote: > In the prospect to support multiple redistributor regions, > let's introduce a GICv3RDISTRegion struct datatype and a > statically sized array of those. For the time being, only > one redistributor region is used. > > Signed-off-by: Eric Auger > ---

[Qemu-devel] [PATCH v2] m68: fix exception stack frame for 68000

2018-04-13 Thread Pavel Dovgalyuk
68000 CPUs do not save format in the exception stack frame. This patch adds feature checking to prevent format saving for 68000. m68k_ret() already includes this modification, this patch fixes the exception processing function too. Signed-off-by: Pavel Dovgalyuk -- v2: - moved switch under the

Re: [Qemu-devel] [RFC 4/8] hw/intc/arm_gicv3: Implement register_redist_region API

2018-04-13 Thread Peter Maydell
On 27 March 2018 at 15:15, Eric Auger wrote: > This patch defines and implements the register_redist_region() API > for both arm_gicv3 and arm_gicv3_kvm. Virt machine now directly calls > the function to set the single redistributor region. The associated > memory region init is removed from gicv3

Re: [Qemu-devel] [RFC 6/8] hw/arm/virt: Allow GICv3 DT node with multiple redistributor regions

2018-04-13 Thread Peter Maydell
On 27 March 2018 at 15:15, Eric Auger wrote: > This patch adds the GICState handle in the virtual machine state and > allows to create a GIC device tree node advertising multiple redistributor > regions. > > There is one range per distributor region following the GIC distributor. > Please refer to

Re: [Qemu-devel] [PATCH] iotests: fix 169

2018-04-13 Thread Max Reitz
On 2018-04-12 11:09, Vladimir Sementsov-Ogievskiy wrote: > 12.04.2018 11:34, Vladimir Sementsov-Ogievskiy wrote: >> 11.04.2018 19:11, Max Reitz wrote: >>> On 2018-04-11 15:05, Vladimir Sementsov-Ogievskiy wrote: >>> >>> [...] >>> Hmm, first type? I'm now not sure about, did I really see sha256

Re: [Qemu-devel] [RFC 2/8] hw/intc/arm_gicv3: Use an array of redistributor regions

2018-04-13 Thread Auger Eric
Hi Peter, On 13/04/18 15:27, Peter Maydell wrote: > On 27 March 2018 at 15:15, Eric Auger wrote: >> In the prospect to support multiple redistributor regions, >> let's introduce a GICv3RDISTRegion struct datatype and a >> statically sized array of those. For the time being, only >> one redistribu

Re: [Qemu-devel] Hot add vcpu not working in Windows server 2012r2

2018-04-13 Thread Igor Mammedov
On Fri, 13 Apr 2018 03:14:44 + "Wuzongyong (Euler Dept)" wrote: > Hi, > > I try to hot add vcpus to a windows server 2012r2 virtual machine on RHEL 7.4 > platform. > But Task Manager didn't show extra processors I hot added though they > appeared in > Device Manager. Actually, I need to re

Re: [Qemu-devel] [PATCH for-2.13 1/4] arm: reuse arm_boot_address_space() in armv7m_load_kernel()

2018-04-13 Thread Igor Mammedov
On Thu, 12 Apr 2018 19:22:13 +0100 Peter Maydell wrote: > On 12 April 2018 at 17:40, Igor Mammedov wrote: > > reduce code duplication by resusing arm_boot_address_space() > > > > Signed-off-by: Igor Mammedov > > --- > > include/hw/arm/arm.h | 2 ++ > > hw/arm/armv7m.c | 10 +- > >

Re: [Qemu-devel] [RFC 8/8] hw/arm/virt: Allow up to 512 vcpus along with KVM VGICv3

2018-04-13 Thread Peter Maydell
On 27 March 2018 at 15:15, Eric Auger wrote: > With KVM acceleration and if KVM VGICV3 supports to set multiple > redistributor regions, we now allow up to 512 vcpus. > > Signed-off-by: Eric Auger > --- > hw/arm/virt.c | 17 - > include/hw/arm/virt.h | 1 + > 2 files cha

Re: [Qemu-devel] [RFC 4/8] hw/intc/arm_gicv3: Implement register_redist_region API

2018-04-13 Thread Auger Eric
Hi Peter, On 13/04/18 15:34, Peter Maydell wrote: > On 27 March 2018 at 15:15, Eric Auger wrote: >> This patch defines and implements the register_redist_region() API >> for both arm_gicv3 and arm_gicv3_kvm. Virt machine now directly calls >> the function to set the single redistributor region. Th

Re: [Qemu-devel] [RFC 6/8] hw/arm/virt: Allow GICv3 DT node with multiple redistributor regions

2018-04-13 Thread Auger Eric
Hi Peter, On 13/04/18 15:36, Peter Maydell wrote: > On 27 March 2018 at 15:15, Eric Auger wrote: >> This patch adds the GICState handle in the virtual machine state and >> allows to create a GIC device tree node advertising multiple redistributor >> regions. >> >> There is one range per distribut

Re: [Qemu-devel] [RFC 4/8] hw/intc/arm_gicv3: Implement register_redist_region API

2018-04-13 Thread Peter Maydell
On 13 April 2018 at 14:44, Auger Eric wrote: > Actually this is an API provided to the machine and not the device > itself directly playing with the mapping. > > If not acceptable, I need to match the existing notifier framework and > do something similar taking into account the new GROUP/ATTR add

Re: [Qemu-devel] [RFC 7/8] hw/arm/virt-acpi-build: Handle multiple GICR structures

2018-04-13 Thread Andrew Jones
On Tue, Mar 27, 2018 at 04:15:21PM +0200, Eric Auger wrote: > In case multiple redistributor regions were registered, > let's add the corresponding GICR structures in the MADT > ACPI table. > > Signed-off-by: Eric Auger > --- > hw/arm/virt-acpi-build.c | 21 +++-- > 1 file change

Re: [Qemu-devel] [PATCH v3 05/22] target/arm: Reorganize PMCCNTR read, write, sync

2018-04-13 Thread Aaron Lindsay
On Apr 12 17:18, Peter Maydell wrote: > On 16 March 2018 at 20:31, Aaron Lindsay wrote: > > pmccntr_read and pmccntr_write contained duplicate code that was already > > being handled by pmccntr_sync. Split pmccntr_sync into pmccntr_op_start > > and pmccntr_op_finish, passing the clock value betwee

Re: [Qemu-devel] [RFC 7/8] hw/arm/virt-acpi-build: Handle multiple GICR structures

2018-04-13 Thread Auger Eric
Hi Drew, On 13/04/18 15:47, Andrew Jones wrote: > On Tue, Mar 27, 2018 at 04:15:21PM +0200, Eric Auger wrote: >> In case multiple redistributor regions were registered, >> let's add the corresponding GICR structures in the MADT >> ACPI table. >> >> Signed-off-by: Eric Auger >> --- >> hw/arm/virt

Re: [Qemu-devel] [RFC 4/8] hw/intc/arm_gicv3: Implement register_redist_region API

2018-04-13 Thread Auger Eric
Hi Peter, On 13/04/18 15:46, Peter Maydell wrote: > On 13 April 2018 at 14:44, Auger Eric wrote: >> Actually this is an API provided to the machine and not the device >> itself directly playing with the mapping. >> >> If not acceptable, I need to match the existing notifier framework and >> do so

Re: [Qemu-devel] [PATCH v2] m68: fix exception stack frame for 68000

2018-04-13 Thread Laurent Vivier
Le 13/04/2018 à 15:30, Pavel Dovgalyuk a écrit : > 68000 CPUs do not save format in the exception stack frame. > This patch adds feature checking to prevent format saving for 68000. > m68k_ret() already includes this modification, this patch fixes > the exception processing function too. > > Signe

Re: [Qemu-devel] [Qemu-arm] [PATCH for-2.13 3/4] arm: always start from first_cpu when registering loader cpu reset callback

2018-04-13 Thread Igor Mammedov
On Thu, 12 Apr 2018 19:29:28 +0100 Peter Maydell wrote: > On 12 April 2018 at 17:40, Igor Mammedov wrote: > > if arm_load_kernel() were passed non first_cpu, QEMU would end up > > with partially set do_cpu_reset() callback leaving some CPUs without it. > > > > Make sure that do_cpu_reset() is re

Re: [Qemu-devel] [RFC 8/8] hw/arm/virt: Allow up to 512 vcpus along with KVM VGICv3

2018-04-13 Thread Auger Eric
Hi Peter, On 13/04/18 15:41, Peter Maydell wrote: > On 27 March 2018 at 15:15, Eric Auger wrote: >> With KVM acceleration and if KVM VGICV3 supports to set multiple >> redistributor regions, we now allow up to 512 vcpus. >> >> Signed-off-by: Eric Auger >> --- >> hw/arm/virt.c | 17 +

[Qemu-devel] [PATCH v2 2/2] fpu/softfloat: raise float_invalid for NaN/Inf in round_to_int_and_pack

2018-04-13 Thread Alex Bennée
The re-factor broke the raising of INVALID when NaN/Inf is passed to the float_to_int conversion functions. round_to_uint_and_pack got this right for NaN but also missed out the Inf handling. Fixes https://bugs.launchpad.net/qemu/+bug/1759264 Signed-off-by: Alex Bennée Cc: Bastian Koppelmann --

[Qemu-devel] [PATCH v2 1/2] softfloat: fix {min, max}nummag for same-abs-value inputs

2018-04-13 Thread Alex Bennée
From: "Emilio G. Cota" Before 8936006 ("fpu/softfloat: re-factor minmax", 2018-02-21), we used to return +Zero for maxnummag(-Zero,+Zero); after that commit, we return -Zero. Fix it by making {min,max}nummag consistent with {min,max}num, deferring to the latter when the absolute value of the ope

[Qemu-devel] [PATCH v3 2/3] sdl: Move DisplayOptions global to sdl2_console

2018-04-13 Thread Elie Tournier
Suggested-by: Gerd Hoffmann Signed-off-by: Elie Tournier --- include/ui/sdl2.h | 1 + ui/sdl2.c | 10 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/include/ui/sdl2.h b/include/ui/sdl2.h index 51084e6320..f43eecdbd6 100644 --- a/include/ui/sdl2.h +++ b/include

[Qemu-devel] [PATCH v2 0/2] Softfloat Fixes for 2.12

2018-04-13 Thread Alex Bennée
Hi, The float_invalid patch now handles the Inf case as well and includes the fix to round_to_uint_and_pack. Alex Bennée (1): fpu/softfloat: raise float_invalid for NaN/Inf in round_to_int_and_pack Emilio G. Cota (1): softfloat: fix {min,max}nummag for same-abs-value inputs fpu/softflo

Re: [Qemu-devel] [RFC 8/8] hw/arm/virt: Allow up to 512 vcpus along with KVM VGICv3

2018-04-13 Thread Peter Maydell
On 13 April 2018 at 15:01, Auger Eric wrote: > On 13/04/18 15:41, Peter Maydell wrote: >> I think it would be better to explicitly check "do we have >> support for split redistributors" rather than looking at >> KVM_MAX_VCPUS. It's not impossible that a distro kernel >> might have chosen to backpo

[Qemu-devel] [PATCH v3 3/3] sdl: Allow OpenGL ES context creation

2018-04-13 Thread Elie Tournier
Signed-off-by: Elie Tournier --- qemu-options.hx | 2 +- ui/sdl2-gl.c| 19 +-- vl.c| 4 3 files changed, 22 insertions(+), 3 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index ca4e412f2f..333dd1f1c8 100644 --- a/qemu-options.hx +++ b/qemu-opt

[Qemu-devel] [PATCH v3 0/3] Use SDL to create an OpenGL ES context for virglrenderer.

2018-04-13 Thread Elie Tournier
Hi, v2: Rebase on top of master v3: Fix the json format (Eric Blake) Move DisplayOptions from ui/sdl2.c to include/ui/sdl2.h (Gerd Hoffmann) Fix a comparison issue (Gerd Hoffmann) Currently, virglrenderer [1] support OpenGL ES 2.0 on the guest side and OpenGL ES 3.0 on the host side. Than

Re: [Qemu-devel] [PATCH v2 2/2] fpu/softfloat: raise float_invalid for NaN/Inf in round_to_int_and_pack

2018-04-13 Thread Peter Maydell
On 13 April 2018 at 15:06, Bastian Koppelmann wrote: > On 04/13/2018 04:03 PM, Alex Bennée wrote: >> The re-factor broke the raising of INVALID when NaN/Inf is passed to >> the float_to_int conversion functions. round_to_uint_and_pack got this >> right for NaN but also missed out the Inf handling.

Re: [Qemu-devel] [PATCH v5 0/2] qmp: 'wakeup-suspend-support' in query-target

2018-04-13 Thread Markus Armbruster
Daniel Henrique Barboza writes: > Ping Michael, you reviewed v4 (at least in part), can you have a look?

[Qemu-devel] [PATCH v3 1/3] qapi: Parameter gl of DisplayType now accept an enum

2018-04-13 Thread Elie Tournier
v2: Rebase on top of master v3: Fix the json format (Eric Blake) Fix a comparison issue (Gerd Hoffmann) Signed-off-by: Elie Tournier --- qapi/ui.json | 20 +++- vl.c | 10 +- 2 files changed, 24 insertions(+), 6 deletions(-) diff --git a/qapi/ui.json b/qapi/u

Re: [Qemu-devel] [RFC 8/8] hw/arm/virt: Allow up to 512 vcpus along with KVM VGICv3

2018-04-13 Thread Auger Eric
Hi Peter, On 13/04/18 16:06, Peter Maydell wrote: > On 13 April 2018 at 15:01, Auger Eric wrote: >> On 13/04/18 15:41, Peter Maydell wrote: >>> I think it would be better to explicitly check "do we have >>> support for split redistributors" rather than looking at >>> KVM_MAX_VCPUS. It's not impos

Re: [Qemu-devel] [PATCH v2 2/2] fpu/softfloat: raise float_invalid for NaN/Inf in round_to_int_and_pack

2018-04-13 Thread Bastian Koppelmann
On 04/13/2018 04:03 PM, Alex Bennée wrote: > The re-factor broke the raising of INVALID when NaN/Inf is passed to > the float_to_int conversion functions. round_to_uint_and_pack got this > right for NaN but also missed out the Inf handling. > > Fixes https://bugs.launchpad.net/qemu/+bug/1759264 >

Re: [Qemu-devel] [PATCH qemu v4 2/2] qmp: Add qom-list-properties to list QOM object properties

2018-04-13 Thread Markus Armbruster
Alexey Kardashevskiy writes: > There is already 'device-list-properties' which does most of the job, > however it does not handle everything returned by qom-list-types such > as machines as they inherit directly from TYPE_OBJECT and not TYPE_DEVICE. > It does not handle abstract classes either. >

Re: [Qemu-devel] [PATCH v2 2/2] fpu/softfloat: raise float_invalid for NaN/Inf in round_to_int_and_pack

2018-04-13 Thread Peter Maydell
On 13 April 2018 at 15:03, Alex Bennée wrote: > The re-factor broke the raising of INVALID when NaN/Inf is passed to > the float_to_int conversion functions. round_to_uint_and_pack got this > right for NaN but also missed out the Inf handling. > > Fixes https://bugs.launchpad.net/qemu/+bug/1759264

Re: [Qemu-devel] [PATCH for-2.12] linux-user/signal.c: Put AArch64 frame record in the right place

2018-04-13 Thread Laurent Vivier
Le 12/04/2018 à 16:02, Peter Maydell a écrit : > AArch64 stack frames include a 'frame record' which holds a pointer > to the next frame record in the chain and the LR on entry to the > function. The procedure calling standard doesn't mandate where > exactly this frame record is in the stack frame,

Re: [Qemu-devel] [PATCH for-2.12] linux-user/signal.c: Put AArch64 frame record in the right place

2018-04-13 Thread Peter Maydell
On 13 April 2018 at 15:18, Laurent Vivier wrote: > Le 12/04/2018 à 16:02, Peter Maydell a écrit : >> @@ -1850,12 +1856,6 @@ static void target_setup_frame(int usig, struct >> target_sigaction *ka, >> fr_ofs = layout.total_size; >> layout.total_size += sizeof(struct target_rt_frame_recor

Re: [Qemu-devel] [Bug 1759264] Re: fpu/softfloat: round_to_int_and_pack refactor broke TriCore ftoi insns

2018-04-13 Thread Bastian Koppelmann
On 04/12/2018 03:41 PM, Alex Bennée wrote: > Bastian Koppelmann writes: > >> On 04/11/2018 01:01 PM, Alex Bennée wrote: >>> Bastian Koppelmann writes: >>> On 04/10/2018 10:07 PM, Alex Bennée wrote: > Yeah it looks like it was missed, the round_to_uint code does it. > > Do you ha

Re: [Qemu-devel] [RFC] Intermediate block mirroring

2018-04-13 Thread Max Reitz
On 2018-04-12 19:07, Alberto Garcia wrote: > Hello, > > I mentioned this some time ago, but I'd like to retake it now: I'm > checking how to copy arbitrary nodes on a backing chain, so if I have > e.g. > >[A] <- [B] <- [C] <- [D] > > I'd like to end up with > >[A] <- [E] <- [C] <- [D] >

[Qemu-devel] [PATCH for-2.12] tcg/mips: Handle large offsets from target env to tlb_table

2018-04-13 Thread Peter Maydell
The MIPS TCG target makes the assumption that the offset from the target env pointer to the tlb_table is less than about 64K. This used to be true, but gradual addition of features to the Arm target means that it's no longer true there. This results in the build-time assertion failing: In file inc

[Qemu-devel] [PATCH for-2.13] pc-bios/s390-ccw: size_t should be unsigned

2018-04-13 Thread Thomas Huth
"size_t" should be an unsigned type - the signed counterpart is called "ssize_t" in the C standard instead. Thus we should also use this convention in the s390-ccw firmware to avoid confusion. I checked the sources, and apart from one spot in libc.c (which now uses ssize_t with this patch), the cod

[Qemu-devel] [PATCH] nbd/server: introduce NBD_CMD_CACHE

2018-04-13 Thread Vladimir Sementsov-Ogievskiy
Handle nbd CACHE command. Just do read, without sending read data back. Cache mechanism should be done by exported node driver chain. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/nbd.h | 3 ++- nbd/server.c| 10 ++ 2 files changed, 8 insertions(+), 5 deletions(-

[Qemu-devel] [PATCH] update-linux-headers: drop hyperv.h

2018-04-13 Thread Roman Kagan
As of mainline linux commit 5a485803221777013944cbd1a7cd5c62efba3ffa "x86/hyper-v: move hyperv.h out of uapi" by Vitaly Kuznetsov, no linux uapi header includes it, so we no longer need to create a stub for it. Cc: Vitaly Kuznetsov Signed-off-by: Roman Kagan --- scripts/update-linux-headers.sh

Re: [Qemu-devel] [PATCH] update-linux-headers: drop hyperv.h

2018-04-13 Thread Paolo Bonzini
On 13/04/2018 16:33, Roman Kagan wrote: > As of mainline linux commit 5a485803221777013944cbd1a7cd5c62efba3ffa > "x86/hyper-v: move hyperv.h out of uapi" by Vitaly Kuznetsov, no linux > uapi header includes it, so we no longer need to create a stub for it. > > Cc: Vitaly Kuznetsov > Signed-off-by

Re: [Qemu-devel] [PATCH 0/2] Minor fixes about compressed clusters with OFLAG_COPIED

2018-04-13 Thread Max Reitz
On 2018-04-10 18:05, Alberto Garcia wrote: > Hi, > > while reviewing one previous patch about data corruption and > compressed clusters we discussed that the documentation doesn't > clarify that L2 entries for compressed clusters are not supposed to > have the OFLAG_COPIED bit set. > > Here's a p

Re: [Qemu-devel] [PATCH for-2.13] pc-bios/s390-ccw: size_t should be unsigned

2018-04-13 Thread Philippe Mathieu-Daudé
On 04/13/2018 11:30 AM, Thomas Huth wrote: > "size_t" should be an unsigned type - the signed counterpart is called > "ssize_t" in the C standard instead. Thus we should also use this > convention in the s390-ccw firmware to avoid confusion. I checked the > sources, and apart from one spot in libc.

Re: [Qemu-devel] [PATCH] nbd/server: introduce NBD_CMD_CACHE

2018-04-13 Thread Vladimir Sementsov-Ogievskiy
13.04.2018 17:31, Vladimir Sementsov-Ogievskiy wrote: Handle nbd CACHE command. Just do read, without sending read data back. Cache mechanism should be done by exported node driver chain. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/nbd.h | 3 ++- nbd/server.c| 10 +

[Qemu-devel] [Bug 1126369] Re: qemu-img snapshot -c is unreasonably slow

2018-04-13 Thread Thomas Huth
Looking through old bug tickets... have this issue been fixed, i.e. could we close this ticket nowadays? Or is there still something left to do? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscri

Re: [Qemu-devel] [PATCH] scripts/dump-qcow2.pl: Script to dump qcow2 metadata

2018-04-13 Thread Max Reitz
On 2018-03-28 15:38, Alberto Garcia wrote: > This script takes a qcow2 image and dumps its metadata: header, > snapshot table and some extensions (although not all qcow2 features > are supported yet). > > It can also display a list of all host clusters and the guest -> host > address mappings, so

Re: [Qemu-devel] [PATCH for-2.13] pc-bios/s390-ccw: size_t should be unsigned

2018-04-13 Thread Collin Walling
On 04/13/2018 10:30 AM, Thomas Huth wrote: > "size_t" should be an unsigned type - the signed counterpart is called > "ssize_t" in the C standard instead. Thus we should also use this > convention in the s390-ccw firmware to avoid confusion. I checked the > sources, and apart from one spot in libc.

Re: [Qemu-devel] [qemu-s390x] [PATCH 3/4] pc-bios/s390-ccw: fix non-sequential boot entries (eckd)

2018-04-13 Thread Collin Walling
On 04/13/2018 02:14 AM, Thomas Huth wrote: > On 10.04.2018 17:01, Collin Walling wrote: >> zIPL boot menu entries can be non-sequential. Let's account >> for this issue for the s390 zIPL boot menu. Since this boot >> menu is actually an imitation and is not completely capable >> of everything the r

Re: [Qemu-devel] [PATCH v2 1/2] qcow2: Give the refcount cache the minimum possible size by default

2018-04-13 Thread Max Reitz
On 2018-03-14 09:29, Alberto Garcia wrote: > The L2 and refcount caches have default sizes that can be overridden > using the l2-cache-size and refcount-cache-size (an additional > parameter named cache-size sets the combined size of both caches). > > Unless forced by one of the aforementioned par

Re: [Qemu-devel] [PATCH] scripts/dump-qcow2.pl: Script to dump qcow2 metadata

2018-04-13 Thread Alberto Garcia
On Fri 13 Apr 2018 04:45:15 PM CEST, Max Reitz wrote: > OK, now that that's out of the way... I'm wondering why you want to > add this to the qemu tree? If you'd written an iotest that would make > use of it, sure. But if it's just for debugging, then I'd personally > think it would be better t

Re: [Qemu-devel] [ARM/FDPIC 4/4] linux-user: ARM-FDPIC: Add arm get tls syscall support

2018-04-13 Thread Peter Maydell
On 6 April 2018 at 16:17, Christophe Lyon wrote: > Co-Authored-By: Mickaël Guêné > Signed-off-by: Christophe Lyon > > diff --git a/linux-user/arm/target_syscall.h b/linux-user/arm/target_syscall.h > index 94e2a42..afc0772 100644 > --- a/linux-user/arm/target_syscall.h > +++ b/linux-user/arm/targ

Re: [Qemu-devel] [ARM/FDPIC 1/4] linux-user: ARM-FDPIC: Add configure option to support loading of FDPIC binaries

2018-04-13 Thread Peter Maydell
On 6 April 2018 at 16:17, Christophe Lyon wrote: > Adds --enable-fdpic and --disable-fdpic configure options. This > feature is disabled by default, that's why it is not described in the > "Optional features" help section (which are enabled by default if > possible). > > FDPIC ELF objects are ide

Re: [Qemu-devel] [ARM/FDPIC 2/4] linux-user: ARM-FDPIC: Add support of FDPIC for ARM.

2018-04-13 Thread Peter Maydell
On 6 April 2018 at 16:17, Christophe Lyon wrote: > Add FDPIC info into image_info structure since interpreter info is on > stack and needs to be saved to be accessed later on. > > Co-Authored-By: Mickaël Guêné > Signed-off-by: Christophe Lyon > > diff --git a/linux-user/elfload.c b/linux-user/e

Re: [Qemu-devel] [PATCH for-2.12] tcg/mips: Handle large offsets from target env to tlb_table

2018-04-13 Thread Michael S. Tsirkin
On Fri, Apr 13, 2018 at 03:23:36PM +0100, Peter Maydell wrote: > The MIPS TCG target makes the assumption that the offset from the > target env pointer to the tlb_table is less than about 64K. This > used to be true, but gradual addition of features to the Arm > target means that it's no longer tru

Re: [Qemu-devel] [ARM/FDPIC 3/4] linux-user: ARM-FDPIC: Add support for signals for FDPIC targets

2018-04-13 Thread Peter Maydell
On 6 April 2018 at 16:17, Christophe Lyon wrote: > The FDPIC restorer needs to deal with a function descriptor, hence we > have to extend 'retcode' such that it can hold the instructions needed > to perform this. > > The restorer sequence uses the same thumbness as the exception > handler (mainly

  1   2   >