[Qemu-devel] [PATCH for 2.13 v2 00/20] linux-user: move arch specific parts to arch directories

2018-03-23 Thread Laurent Vivier
Some files like signal.c are really hard to read because all architectures are mixed in the same file. This series moves from signal.c these parts to the architecture dedicated directories in linux-user. Moreover, this allows to compare easier functions between architectures (it helps to debug pro

[Qemu-devel] [PATCH for 2.13 v2 14/20] linux-user: move hppa signal.c parts to hppa directory

2018-03-23 Thread Laurent Vivier
No code change, only move code from signal.c to hppa/signal.c, except adding includes and exporting setup_rt_frame(). Signed-off-by: Laurent Vivier --- linux-user/hppa/signal.c| 192 linux-user/hppa/target_signal.h | 3 + linux-user/signal.c

[Qemu-devel] [PATCH for 2.13 v2 06/20] linux-user: move cris signal.c parts to cris directory

2018-03-23 Thread Laurent Vivier
No code change, only move code from signal.c to cris/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). Signed-off-by: Laurent Vivier --- linux-user/cris/signal.c| 171 linux-user/cris/target_signal.h | 6 +- linu

[Qemu-devel] [PATCH for 2.13 v2 05/20] linux-user: move microblaze signal.c parts to microblaze directory

2018-03-23 Thread Laurent Vivier
No code change, only move code from signal.c to microblaze/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). Signed-off-by: Laurent Vivier --- linux-user/microblaze/signal.c| 230 ++ linux-user/microblaze/target_signal.h |

[Qemu-devel] [PATCH for 2.13 v2 12/20] linux-user: move tilegx signal.c parts to tilegx directory

2018-03-23 Thread Laurent Vivier
No code change, only move code from signal.c to tilegx/signal.c, except adding includes and exporting setup_rt_frame(). Signed-off-by: Laurent Vivier --- linux-user/signal.c | 165 - linux-user/tilegx/signal.c| 168 +++

[Qemu-devel] [PATCH for 2.13 v2 02/20] linux-user: move aarch64 signal.c parts to aarch64 directory

2018-03-23 Thread Laurent Vivier
No code change, only move code from signal.c to aarch64/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). Signed-off-by: Laurent Vivier --- linux-user/aarch64/signal.c| 561 + linux-user/aarch64/target_signal.h | 5 +

[Qemu-devel] [PATCH for 2.13 v2 07/20] linux-user: move nios2 signal.c parts to nios2 directory

2018-03-23 Thread Laurent Vivier
No code change, only move code from signal.c to nios2/signal.c, except adding includes and exporting setup_rt_frame(). Signed-off-by: Laurent Vivier --- linux-user/nios2/signal.c| 236 +++ linux-user/nios2/target_signal.h | 4 + linux-user/signal.c

[Qemu-devel] [PATCH for 2.13 v2 01/20] linux-user: create a dummy per arch signal.c

2018-03-23 Thread Laurent Vivier
Create a signal-common.h for future use by these new files and use it in the existing signal.c Signed-off-by: Laurent Vivier --- linux-user/Makefile.objs | 2 +- linux-user/aarch64/signal.c| 18 +++ linux-user/alpha/signal.c | 18 +++ linux-user/arm/signal

[Qemu-devel] [PATCH for 2.13 v2 09/20] linux-user: move s390x signal.c parts to s390x directory

2018-03-23 Thread Laurent Vivier
No code change, only move code from signal.c to s390x/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). Signed-off-by: Laurent Vivier --- linux-user/s390x/signal.c| 309 +++ linux-user/s390x/target_signal.h | 6 +- li

[Qemu-devel] [PATCH for 2.13 v2 10/20] linux-user: move m68k signal.c parts to m68k directory

2018-03-23 Thread Laurent Vivier
No code change, only move code from signal.c to m68k/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). Signed-off-by: Laurent Vivier --- linux-user/m68k/signal.c| 410 linux-user/m68k/target_signal.h | 6 +- linu

[Qemu-devel] [PATCH for 2.13 v2 11/20] linux-user: move alpha signal.c parts to alpha directory

2018-03-23 Thread Laurent Vivier
No code change, only move code from signal.c to alpha/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). Signed-off-by: Laurent Vivier --- linux-user/alpha/signal.c| 262 +++ linux-user/alpha/target_signal.h | 5 + lin

[Qemu-devel] [PATCH for 2.13 v2 15/20] linux-user: move xtensa signal.c parts to xtensa directory

2018-03-23 Thread Laurent Vivier
No code change, only move code from signal.c to xtensa/signal.c, except adding includes and exporting setup_rt_frame(). Signed-off-by: Laurent Vivier --- linux-user/signal.c | 253 - linux-user/xtensa/signal.c| 257 +++

[Qemu-devel] [PATCH for 2.13 v2 17/20] linux-user: move sparc/sparc64 signal.c parts to sparc directory

2018-03-23 Thread Laurent Vivier
No code change, only move code from signal.c to sparc/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). sparc64/signal.c includes sparc/signal.c Signed-off-by: Laurent Vivier --- linux-user/signal.c| 604 +--- linu

[Qemu-devel] [PATCH for 2.13 v2 08/20] linux-user: move openrisc signal.c parts to openrisc directory

2018-03-23 Thread Laurent Vivier
No code change, only move code from signal.c to openrisc/signal.c, except adding includes and exporting setup_rt_frame(). Signed-off-by: Laurent Vivier --- linux-user/openrisc/signal.c| 213 linux-user/openrisc/target_signal.h | 4 +- linux-user/sig

[Qemu-devel] [PATCH for 2.13 v2 16/20] linux-user: move i386/x86_64 signal.c parts to i386 directory

2018-03-23 Thread Laurent Vivier
No code change, only move code from signal.c to i386/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). x86_64/signal.c includes i386/signal.c Signed-off-by: Laurent Vivier --- linux-user/i386/signal.c | 584 ++ linux-

[Qemu-devel] [PATCH for 2.13 v2 20/20] linux-user: define TARGET_ARCH_HAS_SETUP_FRAME

2018-03-23 Thread Laurent Vivier
Instead of calling setup_frame() conditionally to a list of known targets, define TARGET_ARCH_HAS_SETUP_FRAME if the target provides the function and call it only if the macro is defined. Signed-off-by: Laurent Vivier --- linux-user/aarch64/target_signal.h| 1 + linux-user/alpha/target_sign

[Qemu-devel] [PATCH for 2.13 v2 19/20] linux-user: move ppc/ppc64 signal.c parts to ppc directory

2018-03-23 Thread Laurent Vivier
No code change, only move code from signal.c to ppc/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). Signed-off-by: Laurent Vivier --- linux-user/ppc/signal.c| 671 + linux-user/ppc/target_signal.h | 8 +- linux-

[Qemu-devel] [PATCH for 2.13 v2 13/20] linux-user: move riscv signal.c parts to riscv directory

2018-03-23 Thread Laurent Vivier
No code change, only move code from signal.c to riscv/signal.c, except adding includes and exporting setup_rt_frame(). Signed-off-by: Laurent Vivier --- linux-user/riscv/signal.c| 200 +++ linux-user/riscv/target_signal.h | 3 + linux-user/signal.c

[Qemu-devel] [PATCH for 2.13 v2 18/20] linux-user: move mips/mips64 signal.c parts to mips directory

2018-03-23 Thread Laurent Vivier
No code change, only move code from signal.c to mips/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). mips64/signal.c includes mips/signal.c Signed-off-by: Laurent Vivier --- linux-user/mips/signal.c | 382 ++ linux-

[Qemu-devel] [PATCH for 2.13 v2 03/20] linux-user: move arm signal.c parts to arm directory

2018-03-23 Thread Laurent Vivier
No code change, only move code from signal.c to arm/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). Signed-off-by: Laurent Vivier --- linux-user/arm/signal.c| 754 + linux-user/arm/target_signal.h | 6 +- linux-

Re: [Qemu-devel] [PATCH v2 5/5] Remove unnecessary variables for function return value

2018-03-23 Thread David Gibson
On Fri, Mar 23, 2018 at 03:32:02PM +0100, Laurent Vivier wrote: > Re-run Coccinelle script scripts/coccinelle/return_directly.cocci > > Signed-off-by: Laurent Vivier ppc part Acked-by: David Gibson > --- > accel/tcg/translate-all.c | 5 +- > block/quorum.c

Re: [Qemu-devel] [PATCH for-2.12 0/4] Turn OOB off for 2.12-rc1, revert OOB tests

2018-03-23 Thread Peter Xu
On Fri, Mar 23, 2018 at 01:36:28PM -0500, Eric Blake wrote: > On 03/23/2018 01:30 PM, Christian Borntraeger wrote: > > > > Even that didn't work - 'make check' fails with either 1/4 or 4/4 applied > > > in isolation, so I'm squashing them into a single patch. > > > > Yes, "qmp: introduce QMPCapa

Re: [Qemu-devel] [PATCH for 2.13 v2 18/20] linux-user: move mips/mips64 signal.c parts to mips directory

2018-03-23 Thread Philippe Mathieu-Daudé
On 03/23/2018 07:57 PM, Laurent Vivier wrote: > No code change, only move code from signal.c to > mips/signal.c, except adding includes and > exporting setup_frame() and setup_rt_frame(). > > mips64/signal.c includes mips/signal.c > > Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-

Re: [Qemu-devel] [PATCH for 2.13 v2 11/20] linux-user: move alpha signal.c parts to alpha directory

2018-03-23 Thread Philippe Mathieu-Daudé
On 03/23/2018 07:57 PM, Laurent Vivier wrote: > No code change, only move code from signal.c to > alpha/signal.c, except adding includes and > exporting setup_frame() and setup_rt_frame(). > > Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé > --- > linux-user/alpha/signal.c

Re: [Qemu-devel] [PATCH for-2.12 1/4] Revert "monitor: enable IO thread for (qmp & !mux) typed"

2018-03-23 Thread Peter Xu
On Fri, Mar 23, 2018 at 10:49:31AM -0500, Eric Blake wrote: > On 03/23/2018 09:08 AM, Peter Xu wrote: > > This reverts commit 3fd2457d18edf5736f713dfe1ada9c87a9badab1. > > > > Signed-off-by: Peter Xu > > Not fatal to taking this patch as-is, but it's always nice to include a > rationale when rev

Re: [Qemu-devel] [PATCH for 2.13 v2 13/20] linux-user: move riscv signal.c parts to riscv directory

2018-03-23 Thread Philippe Mathieu-Daudé
On 03/23/2018 07:57 PM, Laurent Vivier wrote: > No code change, only move code from signal.c to > riscv/signal.c, except adding includes and > exporting setup_rt_frame(). > > Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé > --- > linux-user/riscv/signal.c| 200 > ++

Re: [Qemu-devel] [PATCH for 2.13 v2 14/20] linux-user: move hppa signal.c parts to hppa directory

2018-03-23 Thread Philippe Mathieu-Daudé
On 03/23/2018 07:57 PM, Laurent Vivier wrote: > No code change, only move code from signal.c to > hppa/signal.c, except adding includes and > exporting setup_rt_frame(). > > Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé > --- > linux-user/hppa/signal.c| 192 >

Re: [Qemu-devel] [PATCH] monitor: fix expected qmp_capabilities error description regression

2018-03-23 Thread Peter Xu
On Fri, Mar 23, 2018 at 04:56:34PM -0500, Eric Blake wrote: [...] > > > > > > > Works for me (fwiw, I'll probably need the replace "hack" again, > > because in the RFC series I am about to send, the code is factored out > > / generalized in qmp-dispatch), but that works in the meantime, please

Re: [Qemu-devel] [PATCH for 2.13 v2 00/20] linux-user: move arch specific parts to arch directories

2018-03-23 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180323225739.17329-1-laur...@vivier.eu Subject: [Qemu-devel] [PATCH for 2.13 v2 00/20] linux-user: move arch specific parts to arch directories === TEST SCRIPT BEGIN === #

Re: [Qemu-devel] [PATCH v2 0/7] ramfb: simple boot framebuffer, no legacy vga

2018-03-23 Thread Ard Biesheuvel
Hi all, On 23 March 2018 at 13:27, Laszlo Ersek wrote: > Adding Ard and Marc, and keeping the context undisturbed for his sake. > Comments at the bottom. > > On 03/23/18 13:25, Gerd Hoffmann wrote: >> Hi, >> >> Ok folks, here is a experimental patch series for a legacy free boot >> framebuffer.

Re: [Qemu-devel] [PATCH v3] RISC-V: Fix riscv_isa_string memory size bug

2018-03-23 Thread Richard Henderson
On 03/21/2018 02:06 AM, Michael Clark wrote: > Okay, so this would move byte swapping into TCG generic code instead of the > TCG > backend, unless the backend explicitly supports load/store with byte swap?  Yes. r~

[Qemu-devel] [PATCH] ccid-card: include libcacard.h only

2018-03-23 Thread Michal Privoznik
When trying to build with latest libcacard-2.5.1, I hit the following error: In file included from hw/usb/ccid-card-passthru.c:12:0: /usr/include/cacard/vscard_common.h:26:2: error: #warning "Only can be included directly" [-Werror=cpp] #warning "Only can be included directly" Signed-off-by:

[Qemu-devel] [PATCH] qemu-pr-helper: Actually allow users to specify pidfile

2018-03-23 Thread Michal Privoznik
Due to wrong specification of arguments to getopt_long() any attempt to set pidfile resulted in: 1) the default to be leaked 2) the @pidfile variable to be set to NULL (because optarg is NULL without this patch). Signed-off-by: Michal Privoznik --- scsi/qemu-pr-helper.c | 7 --- 1 file chan

Re: [Qemu-devel] [PATCH] ppc: Fix size of ppc64 xer register (fwd)

2018-03-23 Thread David Gibson
On Fri, Feb 23, 2018 at 05:29:56PM +, Michael Matz wrote: > The normal gdb definition of the XER registers is only 32 bit, > and that's what the current version of power64-core.xml also > says (seems copied from gdb's). But qemu's idea of the XER register > is target_ulong (in CPUPPCState, ppc

<    1   2   3