Am 21.03.2018 um 15:46 hat Michael S. Tsirkin geschrieben:
> Our current scheme is to use
> #include ""
> for internal headers, and
> #include <>
> for external ones.
>
> Unfortunately this is not based on compiler support: from C point of
> view, the "" form merely looks up headers in the curre
On Wed, Mar 21, 2018 at 03:31:24PM +, Daniel P. Berrangé wrote:
> The sheepdog mailing list is setup to stop and queue messages from
> non-subscribers, pending moderator approval. Unfortunately it seems
> that the moderation queue is not actively dealt with. Even when messages
> are approved, t
On 03/21/2018 09:51 AM, Marc-André Lureau wrote:
On Wed, Mar 21, 2018 at 3:28 PM, Eric Blake wrote:
On 03/21/2018 08:40 AM, Marc-André Lureau wrote:
Now that we can safely call QOBJECT() on QObject * and children types,
we can have a single macro to ref/unref the object.
Change the incref/de
On Wed, Mar 21, 2018 at 05:22:07PM +0200, Michael S. Tsirkin wrote:
> Our rule right now is to use <> for external headers,
> "" for internal ones. The idea was to avoid conflicts
> between e.g. a system file named and an
> internal one by the same name.
>
> Unfortunately we use -I compiler flag
Am 21.03.2018 um 16:32 hat Alberto Garcia geschrieben:
> On Wed 21 Mar 2018 04:07:28 PM CET, Kevin Wolf wrote:
> > I just remembered that when I looked at an image recently, I noticed
> > that the refcount block wasn't in the first cluster and I disliked it,
> > though mostly because it felt untidy
On Wed, Mar 21, 2018 at 05:22:07PM +0200, Michael S. Tsirkin wrote:
> Our rule right now is to use <> for external headers only.
> RDMA code violates that, fix it up.
>
> Signed-off-by: Michael S. Tsirkin
> ---
> hw/rdma/rdma_backend.h| 2 +-
> hw/rdma/rdma_backend_defs.h | 2 +-
> h
On Wed, Mar 21, 2018 at 03:19:22PM +, Daniel P. Berrangé wrote:
> On Wed, Mar 21, 2018 at 04:46:32PM +0200, Michael S. Tsirkin wrote:
> > Our current scheme is to use
> > #include ""
> > for internal headers, and
> > #include <>
> > for external ones.
> >
> > Unfortunately this is not based
On Wed, Mar 21, 2018 at 10:42:57AM -0500, Eric Blake wrote:
> On 03/21/2018 10:31 AM, Daniel P. Berrangé wrote:
> > The sheepdog mailing list is setup to stop and queue messages from
> > non-subscribers, pending moderator approval. Unfortunately it seems
> > that the moderation queue is not activel
On 03/21/2018 10:31 AM, Daniel P. Berrangé wrote:
The sheepdog mailing list is setup to stop and queue messages from
non-subscribers, pending moderator approval. Unfortunately it seems
that the moderation queue is not actively dealt with. Even when messages
are approved, the sender is never added
On Wed, Mar 21, 2018 at 05:39:48PM +0200, Michael S. Tsirkin wrote:
> On Wed, Mar 21, 2018 at 03:19:22PM +, Daniel P. Berrangé wrote:
> > On Wed, Mar 21, 2018 at 04:46:32PM +0200, Michael S. Tsirkin wrote:
> > > Our current scheme is to use
> > > #include ""
> > > for internal headers, and
> >
Hi
On Wed, Mar 21, 2018 at 3:01 PM, Paolo Bonzini wrote:
> On 21/03/2018 14:40, Marc-André Lureau wrote:
>> +/* A typecast, checking for the type of arguments */
>> +/* QObject is at offset 0, for all QObject-derived types */
>> +#define QOBJECT(x) QEMU_GENERIC(x, \
>> +(QNull *,
Hi Eduardo,
> -Original Message-
> From: Eduardo Habkost
> Sent: Tuesday, March 20, 2018 12:54 PM
> To: Moger, Babu
> Cc: pbonz...@redhat.com; r...@twiddle.net; rkrc...@redhat.com;
> Lendacky, Thomas ; Singh, Brijesh
> ; k...@vger.kernel.org; k...@tripleback.net;
> mtosa...@redhat.com; H
On 21/03/2018 16:55, Marc-André Lureau wrote:
> That would work with an anonymous union though:
>
> struct QObject {
> union {
> QType type;
> QType base;
> };
> size_t refcnt;
> };
>
> If it's acceptable, I think I'll take this approach.
You don't need QEMU_GENERIC a
Hi all!
If you are receiving this email, you have sent a pull request for QEMU
2.12! That's awesome, and some of you have also updated the ChangeLog
for the upcoming release, which is doubly awesome! I'm sure Santa will
put you on the nice list and you can stop reading this email. :)
Even if yo
On Wed, Mar 21, 2018 at 04:34:39PM +0100, Kevin Wolf wrote:
> Am 21.03.2018 um 15:46 hat Michael S. Tsirkin geschrieben:
> > Our current scheme is to use
> > #include ""
> > for internal headers, and
> > #include <>
> > for external ones.
> >
> > Unfortunately this is not based on compiler suppo
** Tags added: mips
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1757363
Title:
infinite loop due to improper deal with "eret" on mips32
Status in QEMU:
New
Bug description:
1.qemu 2.9.1 rel
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180321115211.17937-1-marcandre.lur...@redhat.com
Subject: [Qemu-devel] [PATCH v3 00/49] qapi: add #if pre-processor conditions
to generated code
=== TEST SCRIPT BEGIN ===
On Wed, Mar 21, 2018 at 03:36:51PM +, Daniel P. Berrangé wrote:
> On Wed, Mar 21, 2018 at 05:22:07PM +0200, Michael S. Tsirkin wrote:
> > Our rule right now is to use <> for external headers,
> > "" for internal ones. The idea was to avoid conflicts
> > between e.g. a system file named and an
Hi
On Wed, Mar 21, 2018 at 5:00 PM, Paolo Bonzini wrote:
> On 21/03/2018 16:55, Marc-André Lureau wrote:
>> That would work with an anonymous union though:
>>
>> struct QObject {
>> union {
>> QType type;
>> QType base;
>> };
>> size_t refcnt;
>> };
>>
>> If it's accep
Paolo Bonzini writes:
> On 20/03/2018 18:35, Vitaly Kuznetsov wrote:
>> +if (has_msr_hv_frequencies && env->tsc_khz) {
>> env->features[FEAT_HYPERV_EAX] |= HV_ACCESS_FREQUENCY_MSRS;
>> env->features[FEAT_HYPERV_EDX] |= HV_FREQUENCY_MSRS_AVAILABLE;
>> }
>
Am 21.03.2018 um 16:58 hat Michael S. Tsirkin geschrieben:
> On Wed, Mar 21, 2018 at 04:34:39PM +0100, Kevin Wolf wrote:
> > Am 21.03.2018 um 15:46 hat Michael S. Tsirkin geschrieben:
> > > Our current scheme is to use
> > > #include ""
> > > for internal headers, and
> > > #include <>
> > > for
> You need to "r"un the program here. :)
>
> Also probably "b aio_context_set_poll_params" is useful before you run
> the program, to trap the moment in which the function is called.
>
Hi, that got me here:
(gdb) run
Starting program: c:\qemu-master\qemu-system-ppc.exe -L
c:\qemu-master\pc-bios -
On 21/03/2018 17:11, Marc-André Lureau wrote:
> Hi
>
> On Wed, Mar 21, 2018 at 5:00 PM, Paolo Bonzini wrote:
>> On 21/03/2018 16:55, Marc-André Lureau wrote:
>>> That would work with an anonymous union though:
>>>
>>> struct QObject {
>>> union {
>>> QType type;
>>> QType base
On 21/03/2018 17:23, Howard Spoelstra wrote:
> warning: FTH: (10844): *** Fault tolerant heap shim applied to current
> process. This is usually due to previous crashes. ***
> [New Thread 10844.0x1224]
> [New Thread 10844.0x2a30]
> [New Thread 10844.0x2594]
> [New Thread 10844.0x32a8]
>
> Thread 1
On Wed, Mar 21, 2018 at 5:25 PM, Paolo Bonzini wrote:
> On 21/03/2018 17:23, Howard Spoelstra wrote:
>> warning: FTH: (10844): *** Fault tolerant heap shim applied to current
>> process. This is usually due to previous crashes. ***
>> [New Thread 10844.0x1224]
>> [New Thread 10844.0x2a30]
>> [New
On 21 March 2018 at 13:55, Paolo Bonzini wrote:
> On 19/03/2018 22:07, Michael Clark wrote:
>> We need to use atomic_cmpxchg
>> in the PTE update to detect the case where the PTE has changed between
>> reading it and updating the accessed dirty bits.
>
> Yes, this makes sense. In fact having such
On 21/03/2018 17:22, Michael S. Tsirkin wrote:
> Our rule right now is to use <> for external headers only.
> RDMA code violates that, fix it up.
>
> Signed-off-by: Michael S. Tsirkin
Reviewed-by: Marcel Apfelbaum
Thanks,
Marcel
> ---
> hw/rdma/rdma_backend.h| 2 +-
> hw/rdma/rdma_b
On 21/03/2018 17:31, Howard Spoelstra wrote:
> On Wed, Mar 21, 2018 at 5:25 PM, Paolo Bonzini wrote:
>> On 21/03/2018 17:23, Howard Spoelstra wrote:
>>> warning: FTH: (10844): *** Fault tolerant heap shim applied to current
>>> process. This is usually due to previous crashes. ***
>>> [New Thread
On 21/03/2018 18:02, Michael S. Tsirkin wrote:
> On Wed, Mar 21, 2018 at 03:36:51PM +, Daniel P. Berrangé wrote:
>> On Wed, Mar 21, 2018 at 05:22:07PM +0200, Michael S. Tsirkin wrote:
>>> Our rule right now is to use <> for external headers,
>>> "" for internal ones. The idea was to avoid confl
On Wed, Mar 21, 2018 at 04:33:33PM +0100, Paolo Bonzini wrote:
> On 20/03/2018 18:35, Vitaly Kuznetsov wrote:
> > +if (has_msr_hv_frequencies && env->tsc_khz) {
> > env->features[FEAT_HYPERV_EAX] |= HV_ACCESS_FREQUENCY_MSRS;
> > env->features[FEAT_HYPERV_EDX] |= HV
On 20/03/2018 12:43, Yuval Shaia wrote:
> On Mon, Mar 19, 2018 at 04:53:35PM -0500, Eric Blake wrote:
>> Use the correct printf formats, so that a 32-bit compile doesn't
>> spit out lots of warnings about %lx being incompatible with uint64_t.
>> Broken since initial commit ef6d4ccd.
>>
>> Signed-of
On Wed, Mar 21, 2018 at 02:18:54PM +0100, Vitaly Kuznetsov wrote:
> Roman Kagan writes:
>
> > On Tue, Mar 20, 2018 at 06:35:00PM +0100, Vitaly Kuznetsov wrote:
> >> Requiring tsc_is_stable_and_known() is too restrictive: even without INVTCS
> >> nested Hyper-V-on-KVM enables TSC pages for its gue
Hi
On Wed, Mar 21, 2018 at 5:23 PM, Paolo Bonzini wrote:
> On 21/03/2018 17:11, Marc-André Lureau wrote:
>> Hi
>>
>> On Wed, Mar 21, 2018 at 5:00 PM, Paolo Bonzini wrote:
>>> On 21/03/2018 16:55, Marc-André Lureau wrote:
That would work with an anonymous union though:
struct QObje
On 03/21/2018 07:19 AM, Vladimir Sementsov-Ogievskiy wrote:
Signed-off-by: Vladimir Sementsov-Ogievskiy
Rather sparse on the details in the commit message; I had to read the
patch to even learn what the new namespace is.
---
include/block/nbd.h | 2 +
nbd/server.c| 207 +++
On 03/21/2018 11:59 AM, Marc-André Lureau wrote:
Hmm, perhaps by making it "struct {} base"?
Or even:
struct QObjectCommon {
QType type;
size_t refcnt;
}
struct QObject {
QObjectCommon base;
}
struct QString {
QObjectCommon base;
...
}
I fail to see what that solves
On Wed, Mar 21, 2018 at 03:58:41PM +, Moger, Babu wrote:
> Hi Eduardo,
>
> > -Original Message-
> > From: Eduardo Habkost
> > Sent: Tuesday, March 20, 2018 12:54 PM
> > To: Moger, Babu
> > Cc: pbonz...@redhat.com; r...@twiddle.net; rkrc...@redhat.com;
> > Lendacky, Thomas ; Singh, Br
On 03/21/2018 07:37 AM, Max Reitz wrote:
On 2018-03-12 19:36, Eric Blake wrote:
From: Peter Xu
Start to use dedicate IO thread for QMP monitors that are not using
MUXed chardev.
Reviewed-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Peter Xu
Message-Id: <20180309090006.10018-21
On 2018-03-21 01:09 PM, Eduardo Habkost wrote:
> This makes sense if you want to change a CPU model to enable
> topoext by default. But I suggest setting it for
> ("EPYC" "-" TYPE_X86_CPU) only, not TYPE_X86_CPU, as EPYC is the
> only CPU model affected by patch 4/5.
AIUI, all 17h CPUs have TOPO
* Stefan Berger (stef...@linux.vnet.ibm.com) wrote:
> Extend the TPM emulator backend device with state migration support.
>
> The external TPM emulator 'swtpm' provides a protocol over
> its control channel to retrieve its state blobs. We implement
> functions for getting and setting the differen
* Eric Blake (ebl...@redhat.com) wrote:
> On 03/21/2018 07:37 AM, Max Reitz wrote:
> > On 2018-03-12 19:36, Eric Blake wrote:
> > > From: Peter Xu
> > >
> > > Start to use dedicate IO thread for QMP monitors that are not using
> > > MUXed chardev.
> > >
> > > Reviewed-by: Fam Zheng
> > > Review
On Wed, Mar 21, 2018 at 05:17:38PM +0100, Vitaly Kuznetsov wrote:
> (What I'm worried about with all our hv_* knobs is that more of them we
> have easier it is to assemble some frankenstien which won't look like
> any existing Hyper-V version; we're probably not doing a very good job
> tesing all p
On 03/21/2018 10:58 AM, Paolo Bonzini wrote:
Hi all!
If you are receiving this email, you have sent a pull request for QEMU
2.12! That's awesome, and some of you have also updated the ChangeLog
for the upcoming release, which is doubly awesome! I'm sure Santa will
put you on the nice list and
On Wed, Mar 21, 2018 at 09:56:36AM -0500, Eric Blake wrote:
> no further qemu patches are submitted. Is it worth me proposing a doc
> change to demonstrate what the difference would look like, along with
> corresponding qemu changes to match, to decide if including it in 2.12 is
> worth it?
If yo
Am 20.03.2018 um 19:42 hat Eric Blake geschrieben:
> On 03/20/2018 12:36 PM, Kevin Wolf wrote:
> > Signed-off-by: Kevin Wolf
> > ---
> > tests/qemu-iotests/212 | 326
> > +
> > tests/qemu-iotests/212.out | 111 +++
> > tests/qemu-iot
Am 20.03.2018 um 19:33 hat Eric Blake geschrieben:
> On 03/20/2018 12:36 PM, Kevin Wolf wrote:
> > This tests that the .bdrv_truncate implementation for luks doesn't crash
> > for invalid image sizes.
> >
> > Signed-off-by: Kevin Wolf
> > ---
> > tests/qemu-iotests/210 | 37
On Wed, Mar 21, 2018 at 6:08 PM, Eric Blake wrote:
> On 03/21/2018 11:59 AM, Marc-André Lureau wrote:
>>>
>>> Hmm, perhaps by making it "struct {} base"?
>>>
>>> Or even:
>>>
>>> struct QObjectCommon {
>>> QType type;
>>> size_t refcnt;
>>> }
>>>
>>> struct QObject {
>>> QObjectComm
Hello,
On Wed, 21 Mar 2018, Gerd Hoffmann wrote:
On Tue, Mar 20, 2018 at 11:43:08PM +0100, BALATON Zoltan wrote:
1. Scrollback does not work. With SDL1.2 it is possible to scroll the
monitor (and maybe other output windows as well, I'm not sure about that)
with Ctrl+PgUp/PgDn but this does not
Am 20.03.2018 um 19:53 hat Eric Blake geschrieben:
> On 03/20/2018 12:36 PM, Kevin Wolf wrote:
> > Signed-off-by: Kevin Wolf
> > ---
> > tests/qemu-iotests/213 | 349
> > +
> > tests/qemu-iotests/213.out | 121
> > tests/qemu-io
On 03/21/2018 07:19 AM, Vladimir Sementsov-Ogievskiy wrote:
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
qapi/block.json | 27 +++
blockdev-nbd.c | 23 +++
2 files changed, 50 insertions(+)
diff --git a/qapi/block.json b/qapi/block.json
index
What static=on really does is what we call metadata preallocation for
other block drivers. While we can still change the QMP interface, make
it more consistent by using 'preallocation' for VDI, too.
This doesn't implement any new functionality, so the only supported
preallocation modes are 'off' a
Use qemu_uuid_unparse() instead of uuid_unparse() to make vdi.c compile
again when CONFIG_VDI_DEBUG is set. In order to prevent future bitrot,
replace '#ifdef CONFIG_VDI_DEBUG' by 'if (VDI_DEBUG)' so that the
compiler always sees the code.
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
---
b
This series adds qemu-iotests for a few more block drivers (yet more to
come in another series) and fixes a few things that previous review and
these tests brought up.
The only major design change is that I converted the vdi block driver
from a boolean 'static' create option to the standard 'preal
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/212 | 326 +
tests/qemu-iotests/212.out | 111 +++
tests/qemu-iotests/group | 1 +
3 files changed, 438 insertions(+)
create mode 100755 tests/qemu-iotests/212
create mode 100644 tes
It's unclear what the real maximum is, but we use an uint32_t to store
the log size in vhdx_co_create(), so we should check that the given
value fits in 32 bits.
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
Reviewed-by: Jeff Cody
---
block/vhdx.c | 4
1 file changed, 4 insertions(+)
We want to test resizing even for luks. The only change that is needed
is to explicitly zero out new space for luks because it's undefined.
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
Reviewed-by: Daniel P. Berrangé
---
tests/qemu-iotests/025 | 9 -
1 file changed, 8 insertions(+
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/211 | 246 +
tests/qemu-iotests/211.out | 97 ++
tests/qemu-iotests/group | 1 +
3 files changed, 344 insertions(+)
create mode 100755 tests/qemu-iotests/211
create mode 100644
Ping
Can this one be able to hit 2.12?
Thanks,
Daniel
On 03/13/2018 01:43 PM, Daniel Henrique Barboza wrote:
QEMU SCSI code makes assumptions about how the PROTECT and BYTCHK
works in the protocol, denying support for PI (Protection
Information) in case the guest OS requests it. However, in
Commit e39e959e fixed an invalid assertion in the .bdrv_length
implementation, but left a similar assertion in place for
.bdrv_truncate. Instead of crashing when the user requests a too large
image size, fail gracefully.
A file size of exactly INT64_MAX caused failure before, but is actually
legal
On 03/21/2018 12:37 PM, Kevin Wolf wrote:
What static=on really does is what we call metadata preallocation for
other block drivers. While we can still change the QMP interface, make
it more consistent by using 'preallocation' for VDI, too.
This doesn't implement any new functionality, so the on
It's unclear what the real maximum cluster size is for the Parallels
format, but let's at least make sure that we don't get integer
overflows in our .bdrv_co_create implementation.
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
---
block/parallels.c | 5 +
1 file changed, 5 insertions(+)
On 21/03/2018 18:23, Marc-André Lureau wrote:
>>
>> Here, QObjectCommon is never used outside of qobject.h; all existing code
>> continues to uwe QObject *. But the conversion from QString* or QObject *
>> to QObjectCommon * is trivial (&obj->base), and the conversion from
>> QObjectCommon * to th
This tests that the .bdrv_truncate implementation for luks doesn't crash
for invalid image sizes.
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/210 | 37 +
tests/qemu-iotests/210.out | 16
2 files changed, 53 insertions(+)
diff --git a
> -Original Message-
> From: Eduardo Habkost
> Sent: Wednesday, March 21, 2018 12:10 PM
> To: Moger, Babu
> Cc: pbonz...@redhat.com; r...@twiddle.net; rkrc...@redhat.com;
> Lendacky, Thomas ; Singh, Brijesh
> ; k...@vger.kernel.org; k...@tripleback.net;
> mtosa...@redhat.com; Hook, Gary
Images with a non-power-of-two block size are invalid and cannot be
opened. Reject such block sizes when creating an image.
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
Reviewed-by: Jeff Cody
---
block/vhdx.c | 4
1 file changed, 4 insertions(+)
diff --git a/block/vhdx.c b/block/vhd
error_setg_errno() is meant for cases where we got an errno from the OS
that can add useful extra information to an error message. It's
pointless if we pass a constant errno, these cases should use plain
error_setg().
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
Reviewed-by: Jeff Cody
---
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/213 | 349 +
tests/qemu-iotests/213.out | 121
tests/qemu-iotests/group | 1 +
3 files changed, 471 insertions(+)
create mode 100755 tests/qemu-iotests/213
create mode 100644 te
On 03/21/2018 12:23 PM, Marc-André Lureau wrote:
struct QObjectCommon {
QType type;
size_t refcnt;
}
struct QObject {
QObjectCommon base;
}
struct QString {
QObjectCommon base;
...
}
What is the QOJECT() macro you proposed with that?
Here's what you can do wh
On Wed, 21 Mar 2018 12:21:40 -0500
Eric Blake wrote:
> On 03/21/2018 10:58 AM, Paolo Bonzini wrote:
> > Hi all!
> >
> > If you are receiving this email, you have sent a pull request for QEMU
> > 2.12! That's awesome, and some of you have also updated the ChangeLog
> > for the upcoming release,
Am 21.03.2018 um 14:38 hat Alberto Garcia geschrieben:
> When we try to allocate new clusters we first look for available ones
> starting from s->free_cluster_index and once we find them we increase
> their reference counts. Before we get to call update_refcount() to do
> this last step s->free_clu
Hi
On Fri, Mar 9, 2018 at 9:59 AM, Peter Xu wrote:
> Originally QMP goes through these steps:
>
> JSON Parser --> QMP Dispatcher --> Respond
> /|\(2)(3) |
>(1) | \|/ (4)
>+- main thread +
>
> This patch do
On Wed, Mar 21, 2018 at 4:09 AM, Paolo Bonzini wrote:
> On 21/03/2018 08:05, Thomas Huth wrote:
> > On 20.03.2018 23:25, Michael Clark wrote:
> >> The following changes since commit f1a63fcfcd92c88be8942b5ae71aef
> 9749a4f135:
> >>
> >> Update version for v2.12.0-rc0 release (2018-03-20 19:04:2
On 03/21/2018 01:39 AM, Paolo Bonzini wrote:
> On 20/03/2018 23:11, John Snow wrote:
>> Seems sane, with some lingering questions about what the PIO Setup FIS
>> is supposed to do to begin with still remaining.
>
> I agree here too. Smashing the ATA and controller in the same device
> makes thi
On Wed, 21 Mar 2018, Paolo Bonzini wrote:
Even if you haven't updated the ChangeLog, don't worry, I have done it
for you. Please double check because QEMU is too big for one person to
understand all the changes that were made.
Thanks for updating the ChangeLog. Best sources of info for the sam
On Wed, Mar 21, 2018 at 05:47:28PM +, Moger, Babu wrote:
>
>
> > -Original Message-
> > From: Eduardo Habkost
> > Sent: Wednesday, March 21, 2018 12:10 PM
> > To: Moger, Babu
> > Cc: pbonz...@redhat.com; r...@twiddle.net; rkrc...@redhat.com;
> > Lendacky, Thomas ; Singh, Brijesh
> >
* Stefan Berger (stef...@linux.vnet.ibm.com) wrote:
> Extend the TPM TIS interface with state migration support.
>
> We need to synchronize with the backend thread to make sure that a command
> being processed by the external TPM emulator has completed and its
> response been received.
>
> Signed
On Wed, Mar 21, 2018 at 12:05 AM, Thomas Huth wrote:
> On 20.03.2018 23:25, Michael Clark wrote:
> > The following changes since commit f1a63fcfcd92c88be8942b5ae71aef
> 9749a4f135:
> >
> > Update version for v2.12.0-rc0 release (2018-03-20 19:04:22 +)
> >
> > are available in the git reposi
On 03/21/2018 01:27 PM, Michael Clark wrote:
for future PULL request, could you please send out all patches again
that should be pulled, and not send the cover letter alone? I.e. do a
"git format-patch --subject-prefix PULL ..." and then replace the
contents of the cover letter with the output o
* Stefan Berger (stef...@linux.vnet.ibm.com) wrote:
> Extend the docs related to TPM with specs related to VM save and
> restore and a troubleshooting guide for TPM migration.
>
> Signed-off-by: Stefan Berger
This seems ok, so:
Reviewed-by: Dr. David Alan Gilbert
but comments below:
> ---
>
On Wed, Mar 21, 2018 at 06:40:23PM +0200, Marcel Apfelbaum wrote:
> On 21/03/2018 18:02, Michael S. Tsirkin wrote:
> > On Wed, Mar 21, 2018 at 03:36:51PM +, Daniel P. Berrangé wrote:
> >> On Wed, Mar 21, 2018 at 05:22:07PM +0200, Michael S. Tsirkin wrote:
> >>> Our rule right now is to use <> f
Could someone create a wiki account for me so I can update the changlog?
Thanks
-corey
* Stefan Berger (stef...@linux.vnet.ibm.com) wrote:
> Add a test program for testing the CRB with the external swtpm.
>
> The 1st test case extends a PCR and reads back the value and compares
> it against an expected return packet.
>
> The 2nd test case repeats the 1st test case and then migrates
Adjust each caller of raw_open_common to specify if they are expecting
host and character devices or not. Tighten expectations of file types upon
open in the common code and refuse types that are not expected.
This has two effects:
(1) Character and block devices are now considered deprecated for
* Stefan Berger (stef...@linux.vnet.ibm.com) wrote:
> This series of patches implements support for migrating the state of the
> external 'swtpm' TPM emulator as well as that of the TIS interface.
>
> For testing of TPM 2 (migration) please use the following git repos and
> branches:
>
> libtpms
On 03/02/2018 12:08 PM, Anton Nefedov wrote:
> commit 947858b0 "ide: abort TRIM operation for invalid range"
> is incorrect for macio; just ide_dma_error() without doing a callback
> is not enough for that errorpath.
>
> Instead, pass -EINVAL to the callback and handle it there
> (see related mo
On Wed, Mar 21, 2018 at 08:17:55PM +0300, Roman Kagan wrote:
> On Wed, Mar 21, 2018 at 05:17:38PM +0100, Vitaly Kuznetsov wrote:
> > (What I'm worried about with all our hv_* knobs is that more of them we
> > have easier it is to assemble some frankenstien which won't look like
> > any existing Hyp
> -Original Message-
> From: Eduardo Habkost
> Sent: Wednesday, March 21, 2018 1:15 PM
> To: Moger, Babu
> Cc: pbonz...@redhat.com; r...@twiddle.net; rkrc...@redhat.com;
> Lendacky, Thomas ; Singh, Brijesh
> ; k...@vger.kernel.org; k...@tripleback.net;
> mtosa...@redhat.com; Hook, Gary ;
* Marc-André Lureau (marcandre.lur...@gmail.com) wrote:
> Hi
>
> On Fri, Mar 9, 2018 at 9:59 AM, Peter Xu wrote:
> > Originally QMP goes through these steps:
> >
> > JSON Parser --> QMP Dispatcher --> Respond
> > /|\(2)(3) |
> >(1) |
Note that special-casing "a_is_zero || b_is_zero" pays off--see
the last patch in this series for performance numbers on that.
Performance results for fp-bench run under aarch64-linux-user
on an Intel(R) Core(TM) i7-4790K CPU @ 4.00GHz host:
- before:
mul-single: 86.17 MFlops
mul-double: 87.74 MF
This paves the way for upcoming work.
Signed-off-by: Emilio G. Cota
---
include/fpu/softfloat.h | 10 ++
1 file changed, 10 insertions(+)
diff --git a/include/fpu/softfloat.h b/include/fpu/softfloat.h
index 7b9d31c..8fb44a8 100644
--- a/include/fpu/softfloat.h
+++ b/include/fpu/softfloa
Before 8936006 ("fpu/softfloat: re-factor minmax", 2018-02-21),
we used to return +Zero for maxnummag(-Zero,+Zero); after that
commit, we return -Zero.
Fix it by making {min,max}nummag consistent with {min,max}num,
deferring to the latter when the absolute value of the operands
is the same.
With
Performance results (single and double precision) for
fp-bench run under aarch64-linux-user on an Intel(R)
Core(TM) i7-4790K CPU @ 4.00GHz host:
- before:
add-single: 86.74 MFlops
add-double: 86.46 MFlops
sub-single: 83.33 MFlops
sub-double: 84.57 MFlops
- after:
add-single: 188.26 MFlops
add-dou
Performance results included in the following commit's log.
Signed-off-by: Emilio G. Cota
---
include/fpu/hostfloat.h | 4
include/fpu/softfloat.h | 6 ++
fpu/hostfloat.c | 36
fpu/softfloat.c | 34 --
This series is a first stab at (1) having a test suite for our floating
point (FP) implementation, and (2) leveraging the host FPU to speed up
guest FP operations whenever possible.
- Patch 1 is a set of simple microbenchmarks to isolate the performance
of particular FP operations.
- Patch 2 ad
This will allow us to measure the performance impact of FP
emulation optimizations.
Signed-off-by: Emilio G. Cota
---
tests/fp-bench.c | 290 +
tests/.gitignore | 1 +
tests/Makefile.include | 3 +-
3 files changed, 293 insertions(+
This will allow us to run correctness tests against our
FP implementation. The test can be run in two modes (called
"testers"): host and soft. With the former we check the results
and FP flags on the host machine against the model.
With the latter we check QEMU's fpu primitives against the
model. N
This paves the way for upcoming work.
Signed-off-by: Emilio G. Cota
---
include/fpu/softfloat.h | 10 ++
1 file changed, 10 insertions(+)
diff --git a/include/fpu/softfloat.h b/include/fpu/softfloat.h
index 36626a5..7b9d31c 100644
--- a/include/fpu/softfloat.h
+++ b/include/fpu/softfloa
These are a few muladd-related operations that the original IBM syntax
does not specify; model files for these are in muladd.fptest.
Signed-off-by: Emilio G. Cota
---
tests/fp-test/fp-test.c | 24 +
tests/fp-test/muladd.fptest | 51
On Tue, Feb 20, 2018 at 21:01:37 +, Alex Bennée wrote:
> This is an attempt to save some of the cost of sqrt by using the
> inbuilt support of the host hardware. The idea is assuming we start
> with a valid input we can use the hardware. If any tininess issues
> occur this will trip and FPU exc
Note that special-casing "a_is_zero || b_is_zero" pays off--see
the last patch in this series for performance numbers on that.
Performance results for fp-bench run under aarch64-linux-user
on an aarch64 host:
- before:
fma-single: 53.05 MFlops
fma-double: 51.89 MFlops
- after:
fma-single: 113.93
Performance results for fp-bench run under aarch64-linux-user
on an Intel(R) Core(TM) i7-4790K CPU @ 4.00GHz host:
- before:
div-single: 29.77 MFlops
div-double: 29.85 MFlops
- after:
div-single: 85.90 MFlops
div-double: 86.10 MFlops
Signed-off-by: Emilio G. Cota
---
include/fpu/hostfloat.h |
201 - 300 of 384 matches
Mail list logo
