Not sharing code from precopy/unix because we have to read back the
tcp parameter.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
---
tests/migration-test.c | 79 --
1 file changed, 76 insertions(+), 3 dele
We set the x-multifd-page-count and x-multifd-channels.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
tests/migration-test.c | 48
1 file changed, 48 insertions(+)
diff --git a/tests/migration-test.c b/tests/migration-test
Migration code needs that function in hmp.c (so we need to export it),
and it needs it on tests/migration-test.c, so we need to move it to a
place where it is compiled into the test framework.
Signed-off-by: Juan Quintela
---
chardev/char-socket.c | 29 -
include/qem
No need to write it to a file. Just need a proper firmware O:-)
Signed-off-by: Juan Quintela
CC: Laurent Vivier
---
tests/migration-test.c | 41 +
1 file changed, 5 insertions(+), 36 deletions(-)
diff --git a/tests/migration-test.c b/tests/migration-tes
Yeap, it is still not working. trying to learn how to debug threads
for guests running from the testt hardness.
For some reason, compression is not working at the moment, test is
disabled until I found why.
Signed-off-by: Juan Quintela
---
tests/migration-test.c | 52 +++
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180314142018.13612-1-james.cowg...@mips.com
Subject: [Qemu-devel] [PATCH] linux-user: implement HWCAP bits on MIPS
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
tota
Am 21.12.2017 um 18:25 hat Jack Schwartz geschrieben:
> Properly account for the possibility of multiboot kernels with a zero
> bss_end_addr. The Multiboot Specification, section 3.1.3 allows for
> kernels without a bss section, by allowing a zeroed bss_end_addr multiboot
> header field.
>
> Do s
I couldn't find a case where this prevents something bad from happening
that isn't already caught by other checks, but let's err on the safe
side and check that mh_header_addr is as expected.
Signed-off-by: Kevin Wolf
---
hw/i386/multiboot.c | 4
1 file changed, 4 insertions(+)
diff --git
Patch 1 fixes another Multiboot kernel validation bug that could cause
QEMU to load the kernel image file into a too small buffer. Patch 2 adds
another check to harden the code. The rest of the series adds Multiboot
test cases for kernels using the a.out kludge, which is where the recent
bugs were
Testing the exit code only once after a whole group of tests has
completed is not enough, it catches errors only in the very last qemu
invocation. We need to have the check after each qemu run.
The logging and diff with the reference output is still done once per
group to keep things more managabl
The code path with a manually set mh_load_addr in the Multiboot header
checks that load_end_addr <= load_addr, but the path where load_end_addr
is automatically detected if 0 is given in the header misses the
corresponding check. If the kernel binary size is larger than can fit in
the address space
Signed-off-by: Kevin Wolf
---
tests/multiboot/Makefile| 22 +--
tests/multiboot/aout_kludge.S | 138
tests/multiboot/aout_kludge.out | 42
tests/multiboot/run_test.sh | 10 ++-
4 files changed, 204 insertions(+), 8 deletio
On March 14, 2018 1:23:51 PM EDT, Kevin Wolf wrote:
>Am 21.12.2017 um 18:25 hat Jack Schwartz geschrieben:
>> Properly account for the possibility of multiboot kernels with a zero
>> bss_end_addr. The Multiboot Specification, section 3.1.3 allows for
>> kernels without a bss section, by allowing
Signed-off-by: Kevin Wolf
---
tests/multiboot/.gitignore | 3 +++
1 file changed, 3 insertions(+)
create mode 100644 tests/multiboot/.gitignore
diff --git a/tests/multiboot/.gitignore b/tests/multiboot/.gitignore
new file mode 100644
index 00..93ef99800b
--- /dev/null
+++ b/tests/multib
tlbsync also needs to check the Guest Translation Shootdown Enable
(GTSE) bit in the Logical Partition Control Register (LPCR) to
determine at which privilege level it is running.
See commit c6fd28fd573d ("target/ppc: Update tlbie to check privilege
level based on GTSE")
Signed-off-by: Cédric Le
On 03/14/2018 12:32 PM, Kevin Wolf wrote:
Signed-off-by: Kevin Wolf
---
tests/multiboot/.gitignore | 3 +++
1 file changed, 3 insertions(+)
create mode 100644 tests/multiboot/.gitignore
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301
On 03/14/2018 12:43 PM, Eric Blake wrote:
On 03/14/2018 12:32 PM, Kevin Wolf wrote:
Signed-off-by: Kevin Wolf
---
tests/multiboot/.gitignore | 3 +++
1 file changed, 3 insertions(+)
create mode 100644 tests/multiboot/.gitignore
Reviewed-by: Eric Blake
Huh - and I even proposed somethi
Am 14.03.2018 um 18:35 hat Konrad Rzeszutek Wilk geschrieben:
> On March 14, 2018 1:23:51 PM EDT, Kevin Wolf wrote:
> >Am 21.12.2017 um 18:25 hat Jack Schwartz geschrieben:
> >> Properly account for the possibility of multiboot kernels with a zero
> >> bss_end_addr. The Multiboot Specification, s
Daniel P. Berrangé writes:
> With the huge number of QEMU targets, a default configuration will take
> a very long time to rebuild. When developing most code changes, it is
> sufficient to test compilation with a single target - rebuilding all
> targets just extends compile times while not detec
* Wei Wang (wei.w.w...@intel.com) wrote:
> This patch adds an API to clear bits corresponding to guest free pages
> from the dirty bitmap. Spilt the free page block if it crosses the QEMU
> RAMBlock boundary.
>
> Signed-off-by: Wei Wang
> CC: Dr. David Alan Gilbert
> CC: Juan Quintela
> CC: Mic
On 14 March 2018 at 12:09, Daniel P. Berrangé wrote:
> With the huge number of QEMU targets, a default configuration will take
> a very long time to rebuild. When developing most code changes, it is
> sufficient to test compilation with a single target - rebuilding all
> targets just extends compi
* Wei Wang (wei.w.w...@intel.com) wrote:
> The new feature enables the virtio-balloon device to receive hints of
> guest free pages from the free page vq.
>
> balloon_free_page_start - start guest free page hint reporting.
> balloon_free_page_stop - stop guest free page hint reporting.
>
> Note:
Am Donnerstag, den 08.03.2018, 14:21 -0600 schrieb Eric Blake:
> On 03/08/2018 02:07 PM, Benjamin Drung wrote:
> > Am Donnerstag, den 08.03.2018, 13:46 -0600 schrieb Eric Blake:
> > > On 03/08/2018 12:57 PM, Benjamin Drung wrote:
> > > >'*dnssearch': ['String'],
> > > >'*domainname'
This patch will allow the user to specify classless static routes for
the replies from the built-in DHCP server, for example:
qemu --net user,route=10.0.2.0/24,route=192.168.0.0/16 [...]
The QMP schema for the "route" option is ['str'], because the opts
visitor code only supports lists with a s
On Wed, Mar 14, 2018 at 06:11:37PM +, Dr. David Alan Gilbert wrote:
> > +used_len = block->used_length - offset;
> > +addr += used_len;
> > +}
> > +
> > +start = offset >> TARGET_PAGE_BITS;
> > +npages = used_len >> TARGET_PAGE_BITS;
> > +
* Michael S. Tsirkin (m...@redhat.com) wrote:
> On Wed, Mar 14, 2018 at 06:11:37PM +, Dr. David Alan Gilbert wrote:
> > > +used_len = block->used_length - offset;
> > > +addr += used_len;
> > > +}
> > > +
> > > +start = offset >> TARGET_PAGE_BITS;
> > > +
* Wei Wang (wei.w.w...@intel.com) wrote:
> Start the free page optimization after the migration bitmap is
> synchronized. This can't be used in the stop© phase since the guest
> is paused. Make sure the guest reporting has stopped before
> synchronizing the migration dirty bitmap. Currently, the op
* Lidong Chen (jemmy858...@gmail.com) wrote:
> RDMA migration implement save_page function for QEMUFile, but
> ram_control_save_page do not increase bytes_xfer. So when doing
> RDMA migration, it will use whole bandwidth.
Hi,
Thanks for this,
> Signed-off-by: Lidong Chen
> ---
> migration/qem
On 03/13/2018 02:47 PM, Eric Blake wrote:
> On 03/13/2018 11:17 AM, Kevin Wolf wrote:
>> From: John Snow
>>
>> Instead of automatically transitioning from PENDING to CONCLUDED, gate
>> the .prepare() and .commit() phases behind an explicit acknowledgement
>> provided by the QMP monitor if auto_f
On Wed, Mar 14, 2018 at 07:42:59PM +, Dr. David Alan Gilbert wrote:
> * Michael S. Tsirkin (m...@redhat.com) wrote:
> > On Wed, Mar 14, 2018 at 06:11:37PM +, Dr. David Alan Gilbert wrote:
> > > > +used_len = block->used_length - offset;
> > > > +addr += used_len;
> >
On Wed, 2018-03-14 at 18:33 +0100, Cédric Le Goater wrote:
> tlbsync also needs to check the Guest Translation Shootdown Enable
> (GTSE) bit in the Logical Partition Control Register (LPCR) to
> determine at which privilege level it is running.
>
> See commit c6fd28fd573d ("target/ppc: Update tlbi
On Wed, Mar 14, 2018 at 06:33:36PM +0100, Cédric Le Goater wrote:
> tlbsync also needs to check the Guest Translation Shootdown Enable
> (GTSE) bit in the Logical Partition Control Register (LPCR) to
> determine at which privilege level it is running.
>
> See commit c6fd28fd573d ("target/ppc: Upda
On 03/14/2018 10:12 PM, Michael S. Tsirkin wrote:
On Wed, Mar 14, 2018 at 02:03:19PM +0800, Wei Wang wrote:
On 03/14/2018 10:53 AM, Michael S. Tsirkin wrote:
On Wed, Mar 14, 2018 at 10:43:01AM +0800, Wei Wang wrote:
On 03/14/2018 12:49 AM, Michael S. Tsirkin wrote:
On Wed, Mar 07, 2018 at 08:
From: Chen Hanxiao
If we set mountpoints to qmp_guest_fsfreeze_freeze_list,
we may got nothing to freeze as all mountpoints are
not valid.
So call ga_unset_frozen in this senario.
Also, if we return 0 frozen fs, there is no need to call
guest-fsfreeze-thaw.
Cc: Michael Roth
Signed-off-by: Chen
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180314142133.14166-1-drjo...@redhat.com
Subject: [Qemu-devel] [PATCH] dump-guest-memory: more descriptive lookup_type
failure
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=b
On Wed, 14 Mar 2018 13:40:21 +1100
Alexey Kardashevskiy wrote:
> On 14/3/18 3:56 am, Alex Williamson wrote:
> > Actually making sure it compiles would have been nice:
> >
> > qemu.git/hw/vfio/common.c: In function ‘vfio_listener_region_add’:
> > qemu.git/hw/vfio/common.c:550:40: error: invalid o
On Thu, Mar 15, 2018 at 09:15:48AM +0800, Wei Wang wrote:
> On 03/14/2018 10:12 PM, Michael S. Tsirkin wrote:
> > On Wed, Mar 14, 2018 at 02:03:19PM +0800, Wei Wang wrote:
> > > On 03/14/2018 10:53 AM, Michael S. Tsirkin wrote:
> > > > On Wed, Mar 14, 2018 at 10:43:01AM +0800, Wei Wang wrote:
> > >
Overriding flags violates the precedence rules of
bdrv_reopen_queue_child. Just like the read-only option, no-flush should
be put into the options. The same is done in bdrv_temp_snapshot_options.
Reported-by: Stefan Hajnoczi
---
block/vvfat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reported-by: Max Reitz
Signed-off-by: Fam Zheng
---
block.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block.c b/block.c
index 75a9fd49de..c1fda9fd57 100644
--- a/block.c
+++ b/block.c
@@ -3671,12 +3671,12 @@ int bdrv_drop_intermediate(BlockDriverState *top,
BlockDriver
From: Thomas Huth
The global hack for creating SCSI devices has recently been removed,
but this apparently broke SCSI devices on some boards that were not
ready for this change yet. For the 40p machine you now get:
$ ppc64-softmmu/qemu-system-ppc64 -M 40p -cdrom x.iso
qemu-system-ppc64: -cdrom x
From: Thomas Huth
The "40p" machine is using the Open Hack'Ware BIOS, just like the "prep"
machine, so we can test it accordingly with the boot-serial tester, too.
While we're at it, also change the strings that we are using for the
"prep" machine, so that this test now also checks some CLI param
The following changes since commit 026aaf47c02b79036feb830206cfebb2a726510d:
Merge remote-tracking branch 'remotes/ehabkost/tags/python-next-pull-request'
into staging (2018-03-13 16:26:44 +)
are available in the Git repository at:
git://github.com/dgibson/qemu.git tags/ppc-for-2.12-201
From: Thomas Huth
We've got a U-Boot firmware for this board in our repository, and
the firmware prints some output to the serial console, so we can
check this board in the boot-serial tester, too.
Signed-off-by: Thomas Huth
Signed-off-by: David Gibson
---
tests/boot-serial-test.c | 2 ++
1 f
From: Cédric Le Goater
tlbsync also needs to check the Guest Translation Shootdown Enable
(GTSE) bit in the Logical Partition Control Register (LPCR) to
determine at which privilege level it is running.
See commit c6fd28fd573d ("target/ppc: Update tlbie to check privilege
level based on GTSE")
From: BALATON Zoltan
Using log unimp is more appropriate for these messages and this also
silences them by default so they won't clobber make check output when
tests are added for this board.
Signed-off-by: BALATON Zoltan
Reviewed-by: Thomas Huth
Signed-off-by: David Gibson
---
hw/ppc/ppc440
From: David Engraf
This patch moves the gap between u-boot and kernel at the correct location.
Signed-off-by: David Engraf
Signed-off-by: David Gibson
---
hw/ppc/e500.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c
index 43c15d18c4.
From: Thomas Huth
With the new "--nic" command line parameter option, the "old" way of
specifying a NIC model via the nd_table[] is becoming more prominent
again. But for the pseries "spapr-vlan" device, there is a confusing
discrepancy between the model name that is used for "--device" (i.e.
"sp
From: BALATON Zoltan
An exit function was mistakenly left here but it's not needed because
the PCI bars are organised differently in this device. Calling this
exit function during device_del was causing an abort with
memory_region_del_subregion: `Assertion subregion->container == mr' failed.
Rep
From: Thomas Huth
The macio devices currently cause a crash when the user tries to
instantiate them on a different machine:
$ ppc64-softmmu/qemu-system-ppc64 -device macio-newworld
Unexpected error in qemu_chr_fe_init() at chardev/char-fe.c:222:
qemu-system-ppc64: -device macio-newworld: Device
Hi Kevin.
I see an issue with the commit message of patch 1; please see my reply
to that patch for details. I fully understand patches 1,2,3, patch 4
except for some of the Makefile black magic, and patch 5 looks
reasonable to me.
So, for patches 2,3,4,5:
Reviewed-by: Jack Schwartz
Hi Kevin.
My comments are inline...
On 2018-03-14 10:32, Kevin Wolf wrote:
The code path with a manually set mh_load_addr in the Multiboot header
checks that load_end_addr <= load_addr, but the path where load_end_addr
is automatically detected if 0 is given in the header misses the
correspondi
On Thu, Mar 15, 2018 at 4:19 AM, Dr. David Alan Gilbert
wrote:
> * Lidong Chen (jemmy858...@gmail.com) wrote:
>> RDMA migration implement save_page function for QEMUFile, but
>> ram_control_save_page do not increase bytes_xfer. So when doing
>> RDMA migration, it will use whole bandwidth.
>
> Hi,
Hi David,
>
> Hi Pankaj,
>
> I have a prototype (new one for virtio-mem I was working on over the last
> weeks) for exactly what you need. I basically factored out the notion of a
> memory device. So also virtio devices can be memory devices and get
> recognized e.g. in formerly known pc_dimm_g
> From: Max Filippov [mailto:jcmvb...@gmail.com]
> On Wed, Mar 14, 2018 at 2:53 AM, Pavel Dovgalyuk wrote:
> > icount is adjusted by icount_warp_rt when CPU sleeps.
> > These adjustments may be different in different runs.
> > And the first adjustment is performed at the start of the machine.
> >
+-- On Wed, 14 Mar 2018, Kevin Wolf wrote --+
| Well, it seems to me that this patch was created for a different
| purpose, but it happens to fix the bug for which this CVE was assigned
| now.
Right. I had sent another patch to fix it, there Jack mentioned about his
series from before.
| I th
I am booting up a custom kernel on QEMU ARM64, upon completion of its
initial boot up it looks like it enters the arch_idle() state
I enabled the -d int logging to understand what is going on, I see the
following repeated many times continuosly here after
Taking exception 5 [IRQ]
...from EL1 to E
On Tue, 03/13 17:38, sochin.jiang wrote:
>
> Hi, guys,
>
> Recently, I encountered an IO hang problem in occasion which I cannot
> reproduce it now.
>
> I analyzed this problem carefully, the critical stack is as following:
>
>
> After reading the codes in linux-aio.c(see ioq_submit() func
101 - 157 of 157 matches
Mail list logo