Re: [Qemu-devel] [PATCH qemu v2] slirp/debug: Print IP addresses in human readable form

2018-03-13 Thread Samuel Thibault
Alexey Kardashevskiy, on mar. 13 mars 2018 15:49:44 +1100, wrote: > Signed-off-by: Alexey Kardashevskiy Applied to my tree, thanks! > --- > > checkpatch.pl complains on every single changed line as it keeps > using tabs - do I need to post 's/\t//g'? > > --- > Changes: > v2: > * replaced s

Re: [Qemu-devel] [PATCH v10 05/12] migration: introduce postcopy-only pending

2018-03-13 Thread Vladimir Sementsov-Ogievskiy
12.03.2018 18:30, Dr. David Alan Gilbert wrote: * Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: There would be savevm states (dirty-bitmap) which can migrate only in postcopy stage. The corresponding pending is introduced here. Signed-off-by: Vladimir Sementsov-Ogievskiy ---

[Qemu-devel] [PATCH 0/8] migration: improve and cleanup compression

2018-03-13 Thread guangrong . xiao
From: Xiao Guangrong This is the first part of our work to improve compression to make it be more useful in the production. The first patch resolves the problem that the migration thread spends too much CPU resource to compression memory if it jumps to a new block that causes the network is used

[Qemu-devel] [PATCH 1/8] migration: stop compressing page in migration thread

2018-03-13 Thread guangrong . xiao
From: Xiao Guangrong As compression is a heavy work, do not do it in migration thread, instead, we post it out as a normal page Signed-off-by: Xiao Guangrong --- migration/ram.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/migration/ram

[Qemu-devel] [PATCH 4/8] migration: introduce control_save_page()

2018-03-13 Thread guangrong . xiao
From: Xiao Guangrong Abstract the common function control_save_page() to cleanup the code, no logic is changed Signed-off-by: Xiao Guangrong --- migration/ram.c | 174 +--- 1 file changed, 89 insertions(+), 85 deletions(-) diff --git a/migra

[Qemu-devel] [PATCH 2/8] migration: stop allocating and freeing memory frequently

2018-03-13 Thread guangrong . xiao
From: Xiao Guangrong Current code uses compress2()/uncompress() to compress/decompress memory, these two function manager memory allocation and release internally, that causes huge memory is allocated and freed very frequently More worse, frequently returning memory to kernel will flush TLBs and

[Qemu-devel] [PATCH 3/8] migration: support to detect compression and decompression errors

2018-03-13 Thread guangrong . xiao
From: Xiao Guangrong Currently the page being compressed is allowed to be updated by the VM on the source QEMU, correspondingly the destination QEMU just ignores the decompression error. However, we completely miss the chance to catch real errors, then the VM is corrupted silently To make the mi

[Qemu-devel] [PATCH 6/8] migration: move calling save_zero_page to the common place

2018-03-13 Thread guangrong . xiao
From: Xiao Guangrong save_zero_page() is always our first approach to try, move it to the common place before calling ram_save_compressed_page and ram_save_page Signed-off-by: Xiao Guangrong --- migration/ram.c | 106 1 file changed, 60

[Qemu-devel] [PATCH 5/8] migration: move calling control_save_page to the common place

2018-03-13 Thread guangrong . xiao
From: Xiao Guangrong The function is called by both ram_save_page and ram_save_target_page, so move it to the common caller to cleanup the code Signed-off-by: Xiao Guangrong --- migration/ram.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/migration/ram.c

[Qemu-devel] [PATCH 7/8] migration: introduce save_normal_page()

2018-03-13 Thread guangrong . xiao
From: Xiao Guangrong It directly sends the page to the stream neither checking zero nor using xbzrle or compression Signed-off-by: Xiao Guangrong --- migration/ram.c | 50 ++ 1 file changed, 30 insertions(+), 20 deletions(-) diff --git a/migrati

[Qemu-devel] [PATCH 8/8] migration: remove ram_save_compressed_page()

2018-03-13 Thread guangrong . xiao
From: Xiao Guangrong Now, we can reuse the path in ram_save_page() to post the page out as normal, then the only thing remained in ram_save_compressed_page() is compression that we can move it out to the caller Signed-off-by: Xiao Guangrong --- migration/ram.c | 45

Re: [Qemu-devel] [PATCH v2 0/8] nbd block status base:allocation

2018-03-13 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180312152126.286890-1-vsement...@virtuozzo.com Subject: [Qemu-devel] [PATCH v2 0/8] nbd

Re: [Qemu-devel] [PATCH qemu v2] slirp/debug: Print IP addresses in human readable form

2018-03-13 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180313044944.21058-1-...@ozlabs.ru Subject: [Qemu-devel] [PATCH qemu v2] slirp/debug: Print IP addresses in human readable form === TEST SCRIPT BEGIN === #!/bin/bash BASE

Re: [Qemu-devel] [PATCH V3 0/4] vfio: Introduce Live migration capability to vfio_mdev device

2018-03-13 Thread Zhang, Yulei
> -Original Message- > From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Tuesday, March 13, 2018 6:22 AM > To: Zhang, Yulei > Cc: qemu-devel@nongnu.org; Tian, Kevin ; > zhen...@linux.intel.com; kwankh...@nvidia.com; Juan Quintela > > Subject: Re: [PATCH V3 0/4] vfio: Int

Re: [Qemu-devel] [PATCH] KVM: x86: Add support for save/load MSR_SMI_COUNT

2018-03-13 Thread Paolo Bonzini
On 13/03/2018 01:22, Liran Alon wrote: > > Another gentle ping. > > (Just following "If your patch seems to have been ignored" section in QEMU's > submitting patches guidelines...) > > - liran.a...@oracle.com wrote: > >> Gentle ping. >> (https://urldefense.proofpoint.com/v2/url?u=http-3A__

Re: [Qemu-devel] [PATCH V3 1/4] vfio: introduce a new VFIO subregion for mdev device migration support

2018-03-13 Thread Zhang, Yulei
> -Original Message- > From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com] > Sent: Friday, March 9, 2018 7:43 PM > To: Zhang, Yulei > Cc: qemu-devel@nongnu.org; Tian, Kevin ; > alex.william...@redhat.com; kwankh...@nvidia.com; > zhen...@linux.intel.com > Subject: Re: [Qemu-devel] [

Re: [Qemu-devel] [PATCH v4 14/29] libvhost-user+postcopy: Register new regions with the ufd

2018-03-13 Thread Peter Xu
On Mon, Mar 12, 2018 at 01:23:21PM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Thu, Mar 08, 2018 at 07:57:56PM +, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > When new regions are sent to the client using SET

Re: [Qemu-devel] [PATCH v7 17/23] migration: setup ramstate for resume

2018-03-13 Thread Peter Xu
On Mon, Mar 12, 2018 at 05:30:12PM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > After we updated the dirty bitmaps of ramblocks, we also need to update > > the critical fields in RAMState to make sure it is ready for a resume. > > > > Signed-off-by: Peter Xu >

Re: [Qemu-devel] [PATCH v12 08/28] target/i386: add Secure Encrypted Virtulization (SEV) object

2018-03-13 Thread Paolo Bonzini
On 08/03/2018 23:44, Eduardo Habkost wrote: >> I think doing so will be an issue for the migration. Consider your above >> use case, a SEV guest is running on EPYC with cbitpos=47 and if we >> migrate to some $NEXT AMD CPU which uses need to use cbitpos=48 and we >> will fail to resume the guest on

Re: [Qemu-devel] [PATCH v7 22/23] migration/qmp: add command migrate-pause

2018-03-13 Thread Peter Xu
On Mon, Mar 12, 2018 at 05:36:09PM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > It pauses an ongoing migration. Currently it only supports postcopy. > > Note that this command will work on either side of the migration. > > Basically when we trigger this on one s

Re: [Qemu-devel] [PATCH v12 28/28] tests/qmp-test: blacklist sev specific qmp commands

2018-03-13 Thread Paolo Bonzini
On 09/03/2018 11:12, Dr. David Alan Gilbert wrote: > * Eduardo Habkost (ehabk...@redhat.com) wrote: >> On Thu, Mar 08, 2018 at 02:18:55PM -0600, Brijesh Singh wrote: >>> >>> >>> On 3/8/18 11:08 AM, Daniel P. Berrangé wrote: On Thu, Mar 08, 2018 at 06:49:01AM -0600, Brijesh Singh wrote: > B

Re: [Qemu-devel] [PATCH v6 27/28] migration/qmp: add command migrate-pause

2018-03-13 Thread Peter Xu
On Wed, Feb 28, 2018 at 08:14:19PM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Wed, Feb 14, 2018 at 06:56:59PM +, Dr. David Alan Gilbert wrote: > > > * Peter Xu (pet...@redhat.com) wrote: > > > > On Tue, Feb 13, 2018 at 08:11:00PM +, Dr. David Alan Gi

Re: [Qemu-devel] [PATCH for-2.12 REPOST] migration: convert socket server to QIONetListener

2018-03-13 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > From: "Daniel P. Berrange" > > Instead of creating a QIOChannelSocket directly for the migration > server socket, use a QIONetListener. This provides the ability > to listen on multiple sockets at the same time, so enables > full support for IPv

Re: [Qemu-devel] [RFC PATCH 00/30] Xen Q35 Bringup patches + support for PCIe Extended Capabilities for passed through devices

2018-03-13 Thread Daniel P . Berrangé
The subject line says to expect 30 patches, but you've only sent 18 to the list here. I eventually figured out that the first 12 patches were in Xen code and so not sent to qemu-devel. For future if you have changes that affect multiple completely separate projects, send them as separate series. i

Re: [Qemu-devel] [RFC PATCH 16/30] q35/xen: Add Xen platform device support for Q35

2018-03-13 Thread Daniel P . Berrangé
On Tue, Mar 13, 2018 at 04:34:01AM +1000, Alexey Gerasimenko wrote: > Current Xen/QEMU method to control Xen Platform device on i440 is a bit > odd -- enabling/disabling Xen platform device actually modifies the QEMU > emulated machine type, namely xenfv <--> pc. > > In order to avoid multiplying

Re: [Qemu-devel] [PATCH v12 24/28] sev/i386: add migration blocker

2018-03-13 Thread Paolo Bonzini
On 08/03/2018 13:48, Brijesh Singh wrote: > sev_set_guest_state(SEV_STATE_RUNNING); > + > +/* add migration blocker */ > +error_setg(&sev_mig_blocker, > + "SEV: Migration is not implemented"); > +ret = migrate_add_blocker(sev_mig_blocker, &local_err); > +if (local

Re: [Qemu-devel] [PATCH v4 0/8] nvdimm: guarantee persistence of QEMU writes to persistent memory

2018-03-13 Thread Dr. David Alan Gilbert
* Haozhong Zhang (haozhong.zh...@intel.com) wrote: > On 03/12/18 15:39 +, Stefan Hajnoczi wrote: > > On Wed, Feb 28, 2018 at 03:25:50PM +0800, Haozhong Zhang wrote: > > > QEMU writes to vNVDIMM backends in the vNVDIMM label emulation and > > > live migration. If the backend is on the persistent

[Qemu-devel] Question: an IO hang problem

2018-03-13 Thread sochin . jiang
Hi, guys, Recently, I encountered an IO hang problem in occasion which I cannot reproduce it now. I analyzed this problem carefully, the critical stack is as following: After reading the codes in linux-aio.c(see ioq_submit() function), I found two situations could lead us here. 1) no AIO

Re: [Qemu-devel] [PULL 0/1] Usb 20180312 patches

2018-03-13 Thread Peter Maydell
On 12 March 2018 at 11:05, Gerd Hoffmann wrote: > The following changes since commit e4ae62b802cec437f877f2cadc4ef059cc0eca76: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2018-03-09 17:28:16 +) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH 0/3] vdi: Implement .bdrv_co_create

2018-03-13 Thread Kevin Wolf
Am 12.03.2018 um 17:55 hat Max Reitz geschrieben: > I think cluster-size should not be exposed in QAPI (yet), but Kevin's > patch does that, while I had these patches lying around, so here is my > proposal. Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH] MAINTAINERS: add include/block/aio-wait.h

2018-03-13 Thread Stefan Hajnoczi
On Mon, Mar 12, 2018 at 01:22:04PM +, Stefan Hajnoczi wrote: > The include/block/aio-wait.h header file was added by commit > 7719f3c968c59e1bcda7e177679dc765b59e578f ("block: extract > AIO_WAIT_WHILE() from BlockDriverState") without updating MAINTAINERS. > > Signed-off-by: Stefan Hajnoczi >

Re: [Qemu-devel] [PATCH v10 05/12] migration: introduce postcopy-only pending

2018-03-13 Thread Dr. David Alan Gilbert
* Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > 12.03.2018 18:30, Dr. David Alan Gilbert wrote: > > * Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > > > There would be savevm states (dirty-bitmap) which can migrate only in > > > postcopy stage. The corresponding

Re: [Qemu-devel] [PATCH] checkpatch: warn about missing MAINTAINERS file changes

2018-03-13 Thread Stefan Hajnoczi
On Mon, Mar 12, 2018 at 02:46:20PM +0100, Thomas Huth wrote: > On 12.03.2018 14:18, Stefan Hajnoczi wrote: > > Warn if files are added/renamed/deleted without MAINTAINERS file > > changes. This has helped me in Linux and we could benefit from this > > check in QEMU. > > > > This patch is a manual

[Qemu-devel] [PATCH] update Linux headers to 4.15

2018-03-13 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- include/standard-headers/linux/input-event-codes.h | 1 + include/standard-headers/linux/pci_regs.h | 30 +- include/standard-headers/linux/virtio_gpu.h| 1 - include/standard-headers/linux/virtio_net.h| 13 + include/standard-header

[Qemu-devel] [PATCH] ui: fix keymap detection under Xwayland

2018-03-13 Thread Daniel P . Berrangé
The X11 code currently detects the keymap by looking for the keycode name property. Unfortunately due to the way Xwayland handles keyboards, this property gets unset almost immediately after the first application starts using Xwayland resulting in ** (qemu-system-x86_64:19644): WARNING **: Unkno

Re: [Qemu-devel] [PATCH v4 0/8] nvdimm: guarantee persistence of QEMU writes to persistent memory

2018-03-13 Thread Stefan Hajnoczi
On Tue, Mar 13, 2018 at 08:11:50AM +0800, Haozhong Zhang wrote: > On 03/12/18 15:39 +, Stefan Hajnoczi wrote: > > On Wed, Feb 28, 2018 at 03:25:50PM +0800, Haozhong Zhang wrote: > > > QEMU writes to vNVDIMM backends in the vNVDIMM label emulation and > > > live migration. If the backend is on t

Re: [Qemu-devel] [PATCH] iotests: Fix stuck NBD process on 33

2018-03-13 Thread Anton Nefedov
On 13/3/2018 12:12 AM, Max Reitz wrote: On 2018-03-12 22:11, Eric Blake wrote: Commit afe35cde6 added additional actions to test 33, but forgot to reset the image between tests. As a result, './check -nbd 33' fails because the qemu-nbd process from the first half is still occupying the port, pr

Re: [Qemu-devel] [PULL 0/5] Tracing patches

2018-03-13 Thread Peter Maydell
On 12 March 2018 at 16:00, Stefan Hajnoczi wrote: > The following changes since commit e4ae62b802cec437f877f2cadc4ef059cc0eca76: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2018-03-09 17:28:16 +) > > are available in the Git repository at: > >

Re: [Qemu-devel] [PATCH] checkpatch: warn about missing MAINTAINERS file changes

2018-03-13 Thread Thomas Huth
On 13.03.2018 11:37, Stefan Hajnoczi wrote: > On Mon, Mar 12, 2018 at 02:46:20PM +0100, Thomas Huth wrote: >> On 12.03.2018 14:18, Stefan Hajnoczi wrote: >>> Warn if files are added/renamed/deleted without MAINTAINERS file >>> changes. This has helped me in Linux and we could benefit from this >>>

Re: [Qemu-devel] [PATCH 3/3] nvram: at24c: use a sane default for "rom-size"

2018-03-13 Thread Philippe Mathieu-Daudé
Hi Wolfram, On 03/12/2018 10:42 PM, Wolfram Sang wrote: > 0 as "rom-size" doesn't make much sense, let's use the smallest 24cXX > which has 128 byte. > > Signed-off-by: Wolfram Sang > --- > hw/nvram/eeprom_at24c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/nvra

Re: [Qemu-devel] [PATCH for-2.12 REPOST] migration: convert socket server to QIONetListener

2018-03-13 Thread Paolo Bonzini
On 13/03/2018 10:20, Dr. David Alan Gilbert wrote: >> static void socket_start_incoming_migration(SocketAddress *saddr, >> Error **errp) >> { >> -QIOChannelSocket *listen_ioc = qio_channel_socket_new(); >> +QIONetListener *listener = qio_net_li

Re: [Qemu-devel] [PATCH 1/3] nvram: at24c: remove doubled prefix for ERR

2018-03-13 Thread Philippe Mathieu-Daudé
Hi Wolfram, On 03/12/2018 10:42 PM, Wolfram Sang wrote: > The ERR macro already has the TYPE_AT24C_EE prefix, no need to repeat in > the error message. > > Signed-off-by: Wolfram Sang > --- > hw/nvram/eeprom_at24c.c | 11 --- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff -

Re: [Qemu-devel] [PATCH 2/3] nvram: at24c: prevent segfault by checking "rom-size"

2018-03-13 Thread Philippe Mathieu-Daudé
On 03/12/2018 10:42 PM, Wolfram Sang wrote: > The value for "rom-size" is used as a divisor, so it must not be 0 or it > will segfault. A size of 0 wouldn't make sense as well. > > Signed-off-by: Wolfram Sang > --- > hw/nvram/eeprom_at24c.c | 5 + > 1 file changed, 5 insertions(+) > > diff

Re: [Qemu-devel] [PATCH for-2.12 REPOST] migration: convert socket server to QIONetListener

2018-03-13 Thread Daniel P . Berrangé
On Tue, Mar 13, 2018 at 11:57:17AM +0100, Paolo Bonzini wrote: > On 13/03/2018 10:20, Dr. David Alan Gilbert wrote: > >> static void socket_start_incoming_migration(SocketAddress *saddr, > >> Error **errp) > >> { > >> -QIOChannelSocket *listen_ioc

Re: [Qemu-devel] [PATCH v4 1/2] i386: Add Intel Processor Trace feature support

2018-03-13 Thread Kang, Luwei
> > > > +if (!eax_0 || > > > > + ((ebx_0 & INTEL_PT_MINIMAL_EBX) != INTEL_PT_MINIMAL_EBX) || > > > > + ((ecx_0 & INTEL_PT_MINIMAL_ECX) != INTEL_PT_MINIMAL_ECX) || > > > > + ((eax_1 & INTEL_PT_MTC_BITMAP) != INTEL_PT_MTC_BITMAP) || > > > > + ((eax_1 &

Re: [Qemu-devel] [PATCH for-2.12 REPOST] migration: convert socket server to QIONetListener

2018-03-13 Thread Paolo Bonzini
On 13/03/2018 12:06, Daniel P. Berrangé wrote: > On Tue, Mar 13, 2018 at 11:57:17AM +0100, Paolo Bonzini wrote: >> On 13/03/2018 10:20, Dr. David Alan Gilbert wrote: static void socket_start_incoming_migration(SocketAddress *saddr, Error **err

Re: [Qemu-devel] [PATCH v12 28/28] tests/qmp-test: blacklist sev specific qmp commands

2018-03-13 Thread Brijesh Singh
On 3/13/18 4:07 AM, Paolo Bonzini wrote: > On 09/03/2018 11:12, Dr. David Alan Gilbert wrote: >> * Eduardo Habkost (ehabk...@redhat.com) wrote: >>> On Thu, Mar 08, 2018 at 02:18:55PM -0600, Brijesh Singh wrote: On 3/8/18 11:08 AM, Daniel P. Berrangé wrote: > On Thu, Mar 08, 2018 at

Re: [Qemu-devel] [PATCH for-2.12 REPOST] migration: convert socket server to QIONetListener

2018-03-13 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > On 13/03/2018 12:06, Daniel P. Berrangé wrote: > > On Tue, Mar 13, 2018 at 11:57:17AM +0100, Paolo Bonzini wrote: > >> On 13/03/2018 10:20, Dr. David Alan Gilbert wrote: > static void socket_start_incoming_migration(SocketAddress *saddr, >

Re: [Qemu-devel] [PATCH v12 24/28] sev/i386: add migration blocker

2018-03-13 Thread Brijesh Singh
On 3/13/18 4:33 AM, Paolo Bonzini wrote: > On 08/03/2018 13:48, Brijesh Singh wrote: >> sev_set_guest_state(SEV_STATE_RUNNING); >> + >> +/* add migration blocker */ >> +error_setg(&sev_mig_blocker, >> + "SEV: Migration is not implemented"); >> +ret = migrate_add_blo

[Qemu-devel] [PATCH v3] ppc440_pcix: Change some error_report to qemu_log_mask(LOG_UNIMP, ...)

2018-03-13 Thread BALATON Zoltan
Using log unimp is more appropriate for these messages and this also silences them by default so they won't clobber make check output when tests are added for this board. Signed-off-by: BALATON Zoltan Reviewed-by: Thomas Huth --- v3: Include qemu/log.h to avoid undeclared function warning v2: Us

Re: [Qemu-devel] [PATCH 7/7] vpc: Support .bdrv_co_create

2018-03-13 Thread Kevin Wolf
Am 12.03.2018 um 22:49 hat Max Reitz geschrieben: > On 2018-03-09 22:46, Kevin Wolf wrote: > > This adds the .bdrv_co_create driver callback to vpc, which > > enables image creation over QMP. > > > > Signed-off-by: Kevin Wolf > > --- > > qapi/block-core.json | 33 ++- > > block/vpc.c

Re: [Qemu-devel] [PATCH v12 28/28] tests/qmp-test: blacklist sev specific qmp commands

2018-03-13 Thread Paolo Bonzini
On 13/03/2018 12:21, Brijesh Singh wrote: >> The KVM side is a pretty linear use of the kernel API. I'm not very >> happy with the debug API for MemoryRegions (but it's not really >> Brijesh's fault), so my plan would be to merge it without debug support. > > Thanks Paolo, I am working to drop th

Re: [Qemu-devel] [PATCH v12 24/28] sev/i386: add migration blocker

2018-03-13 Thread Paolo Bonzini
On 13/03/2018 12:28, Brijesh Singh wrote: > > > On 3/13/18 4:33 AM, Paolo Bonzini wrote: >> On 08/03/2018 13:48, Brijesh Singh wrote: >>> sev_set_guest_state(SEV_STATE_RUNNING); >>> + >>> +/* add migration blocker */ >>> +error_setg(&sev_mig_blocker, >>> + "SEV: Migrati

Re: [Qemu-devel] [RFC PATCH 00/30] Xen Q35 Bringup patches + support for PCIe Extended Capabilities for passed through devices

2018-03-13 Thread Alexey G
On Tue, 13 Mar 2018 09:21:54 + Daniel P. Berrangé wrote: >The subject line says to expect 30 patches, but you've only sent 18 to >the list here. I eventually figured out that the first 12 patches were >in Xen code and so not sent to qemu-devel. > >For future if you have changes that affect mu

Re: [Qemu-devel] [PULL 0/1] Block patches

2018-03-13 Thread Peter Maydell
On 12 March 2018 at 16:01, Stefan Hajnoczi wrote: > The following changes since commit e4ae62b802cec437f877f2cadc4ef059cc0eca76: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2018-03-09 17:28:16 +) > > are available in the Git repository at: > >

Re: [Qemu-devel] [RFC PATCH 00/30] Xen Q35 Bringup patches + support for PCIe Extended Capabilities for passed through devices

2018-03-13 Thread Daniel P . Berrangé
On Tue, Mar 13, 2018 at 09:37:55PM +1000, Alexey G wrote: > On Tue, 13 Mar 2018 09:21:54 + > Daniel P. Berrangé wrote: > > >The subject line says to expect 30 patches, but you've only sent 18 to > >the list here. I eventually figured out that the first 12 patches were > >in Xen code and so no

Re: [Qemu-devel] [PATCH] update Linux headers to 4.15

2018-03-13 Thread Christian Borntraeger
On 03/13/2018 11:39 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > include/standard-headers/linux/input-event-codes.h | 1 + > include/standard-headers/linux/pci_regs.h | 30 +- > include/standard-headers/linux/virtio_gpu.h| 1 - > include/standard-headers

Re: [Qemu-devel] [PATCH] update Linux headers to 4.15

2018-03-13 Thread Peter Maydell
On 13 March 2018 at 11:45, Christian Borntraeger wrote: > > > On 03/13/2018 11:39 AM, Paolo Bonzini wrote: >> Signed-off-by: Paolo Bonzini >> --- >> include/standard-headers/linux/input-event-codes.h | 1 + >> include/standard-headers/linux/pci_regs.h | 30 +- >> include/standard-hea

[Qemu-devel] [PATCH v2 0/2] block: Fix permission during reopen

2018-03-13 Thread Fam Zheng
v2: Use update_flags_from_options. [Kevin] We write open the whole backing chain during reopen. It is not necessary and will cause image locking problems if the backing image is shared. Fam Zheng (2): block: Fix flags in reopen queue iotests: Add regression test for commit base locking bloc

[Qemu-devel] [PATCH v2 2/2] iotests: Add regression test for commit base locking

2018-03-13 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/qemu-iotests/153 | 8 tests/qemu-iotests/153.out | 4 2 files changed, 12 insertions(+) diff --git a/tests/qemu-iotests/153 b/tests/qemu-iotests/153 index adfd02695b..a7875e6899 100755 --- a/tests/qemu-iotests/153 +++ b/tests/qemu-iotests/153

[Qemu-devel] [PATCH v2 1/2] block: Fix flags in reopen queue

2018-03-13 Thread Fam Zheng
Reopen flags are not synchronized according to the bdrv_reopen_queue_child precedence until bdrv_reopen_prepare. It is a bit too late: we already check the consistency in bdrv_check_perm before that. This fixes the bug that when bdrv_reopen a RO node as RW, the flags for backing child are wrong. B

Re: [Qemu-devel] [PATCH] update Linux headers to 4.15

2018-03-13 Thread Paolo Bonzini
On 13/03/2018 12:57, Peter Maydell wrote: > On 13 March 2018 at 11:45, Christian Borntraeger > wrote: >> >> >> On 03/13/2018 11:39 AM, Paolo Bonzini wrote: >>> Signed-off-by: Paolo Bonzini >>> --- >>> include/standard-headers/linux/input-event-codes.h | 1 + >>> include/standard-headers/linux

[Qemu-devel] [PATCH] docker: fedora: test more components

2018-03-13 Thread Paolo Bonzini
Install optional dependencies of QEMU to get better coverage. Signed-off-by: Paolo Bonzini --- tests/docker/dockerfiles/fedora.docker | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docke

[Qemu-devel] [PATCH v3 1/1] block/mirror: change the semantic of 'force' of block-job-cancel

2018-03-13 Thread Jeff Cody
From: Liang Li When doing drive mirror to a low speed shared storage, if there was heavy BLK IO write workload in VM after the 'ready' event, drive mirror block job can't be canceled immediately, it would keep running until the heavy BLK IO workload stopped in the VM. Libvirt depends on the curr

Re: [Qemu-devel] [PATCH v10 05/12] migration: introduce postcopy-only pending

2018-03-13 Thread Dr. David Alan Gilbert
* John Snow (js...@redhat.com) wrote: > > > On 03/12/2018 11:30 AM, Dr. David Alan Gilbert wrote: > > * Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > >> There would be savevm states (dirty-bitmap) which can migrate only in > >> postcopy stage. The corresponding pending is intro

Re: [Qemu-devel] [PATCH 1/3] vfio/pci: Pull BAR mapping setup from read-write path

2018-03-13 Thread Auger Eric
Hi Alex, On 28/02/18 21:14, Alex Williamson wrote: > This creates a common helper that we'll use for ioeventfd setup. > > Signed-off-by: Alex Williamson Reviewed-by: Eric Auger Thanks Eric > --- > drivers/vfio/pci/vfio_pci_rdwr.c | 39 > ++ > 1 file cha

Re: [Qemu-devel] [PATCH 7/7] vpc: Support .bdrv_co_create

2018-03-13 Thread Max Reitz
On 2018-03-13 12:32, Kevin Wolf wrote: > Am 12.03.2018 um 22:49 hat Max Reitz geschrieben: >> On 2018-03-09 22:46, Kevin Wolf wrote: >>> This adds the .bdrv_co_create driver callback to vpc, which >>> enables image creation over QMP. >>> >>> Signed-off-by: Kevin Wolf >>> --- >>> qapi/block-core.j

[Qemu-devel] [PULL 0/1] Block patches

2018-03-13 Thread Jeff Cody
The following changes since commit 834eddf22ec762839b724538c7be1d1d3b2d9d3b: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2018-03-13 10:49:02 +) are available in the git repository at: git://github.com/codyprime/qemu-kvm-jtc.git tags/block-pull-r

[Qemu-devel] [PULL 1/1] block: include original filename when reporting invalid URIs

2018-03-13 Thread Jeff Cody
From: Daniel P. Berrangé Consider passing a JSON based block driver to "qemu-img commit" $ qemu-img commit 'json:{"driver":"qcow2","file":{"driver":"gluster",\ "volume":"gv0","path":"sn1.qcow2", "server":[{"type":\ "tcp","host":"10.73.199.197

[Qemu-devel] [PATCH v2] update Linux headers to 4.16-rc5

2018-03-13 Thread Paolo Bonzini
Note that VIRTIO_GPU_CAPSET_VIRGL2 was added manually so it has to be added manually after re-running scripts/update-linux-headers.sh. Signed-off-by: Paolo Bonzini --- include/standard-headers/linux/input-event-codes.h | 1 + include/standard-headers/linux/input.h | 11 + include/

Re: [Qemu-devel] [PATCH] docker: fedora: test more components

2018-03-13 Thread Fam Zheng
On Tue, 03/13 13:05, Paolo Bonzini wrote: > Install optional dependencies of QEMU to get better coverage. > > Signed-off-by: Paolo Bonzini > --- > tests/docker/dockerfiles/fedora.docker | 13 ++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/tests/docker/dockerfi

Re: [Qemu-devel] [PATCH v6 27/28] migration/qmp: add command migrate-pause

2018-03-13 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Wed, Feb 28, 2018 at 08:14:19PM +, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > On Wed, Feb 14, 2018 at 06:56:59PM +, Dr. David Alan Gilbert wrote: > > > > * Peter Xu (pet...@redhat.com) wrote: > > > > > On Tue, Feb

Re: [Qemu-devel] [RFC PATCH] vfio/pci: Add ioeventfd support

2018-03-13 Thread Auger Eric
Hi, On 08/02/18 02:22, Alexey Kardashevskiy wrote: > On 08/02/18 01:12, Alex Williamson wrote: >> On Wed, 7 Feb 2018 15:48:26 +1100 >> Alexey Kardashevskiy wrote: >> >>> On 07/02/18 15:25, Alex Williamson wrote: On Wed, 7 Feb 2018 15:09:22 +1100 Alexey Kardashevskiy wrote: > On 0

Re: [Qemu-devel] [PULL 0/1] Docker patches

2018-03-13 Thread Peter Maydell
On 12 March 2018 at 17:26, Fam Zheng wrote: > The following changes since commit b16a54da0696efc5d91b6c3597a37a317abb5de7: > > Merge remote-tracking branch 'remotes/kraxel/tags/ui-20180312-pull-request' > into staging (2018-03-12 14:06:23 +) > > are available in the Git repository at: > >

Re: [Qemu-devel] [PATCH] migration: Fix rate limiting issue on RDMA migration

2018-03-13 Thread 858585 jemmy
Ping. On Sat, Mar 10, 2018 at 10:32 PM, Lidong Chen wrote: > RDMA migration implement save_page function for QEMUFile, but > ram_control_save_page do not increase bytes_xfer. So when doing > RDMA migration, it will use whole bandwidth. > > Signed-off-by: Lidong Chen > --- > migration/qemu-file.

[Qemu-devel] [PULL 04/22] docs: add AMD Secure Encrypted Virtualization (SEV)

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh Create a documentation entry to describe the AMD Secure Encrypted Virtualization (SEV) feature. Cc: Paolo Bonzini Signed-off-by: Brijesh Singh Signed-off-by: Paolo Bonzini --- docs/amd-memory-encryption.txt | 92 ++ 1 file changed,

[Qemu-devel] [PULL 02/22] KVM: x86: Add support for save/load MSR_SMI_COUNT

2018-03-13 Thread Paolo Bonzini
From: Liran Alon This MSR returns the number of #SMIs that occurred on CPU since boot. KVM commit 52797bf9a875 ("KVM: x86: Add emulation of MSR_SMI_COUNT") introduced support for emulating this MSR. This commit adds support for QEMU to save/load this MSR for migration purposes. Signed-off-by:

[Qemu-devel] [PULL 00/22] KVM patches for QEMU 2.12 soft freeze

2018-03-13 Thread Paolo Bonzini
The following changes since commit fb5fff15881ba7a002924b967eb211c002897983: Merge remote-tracking branch 'remotes/kraxel/tags/vga-20180312-pull-request' into staging (2018-03-12 18:35:37 +) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream-sev

[Qemu-devel] [PULL 03/22] machine: add memory-encryption option

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh When CPU supports memory encryption feature, the property can be used to specify the encryption object to use when launching an encrypted guest. Cc: Paolo Bonzini Cc: Eduardo Habkost Cc: Marcel Apfelbaum Cc: Stefan Hajnoczi Signed-off-by: Brijesh Singh Signed-off-by: Pao

[Qemu-devel] [PULL 01/22] update Linux headers to 4.16-rc5

2018-03-13 Thread Paolo Bonzini
Note that VIRTIO_GPU_CAPSET_VIRGL2 was added manually so it has to be added manually after re-running scripts/update-linux-headers.sh. Signed-off-by: Paolo Bonzini --- include/standard-headers/linux/input-event-codes.h | 1 + include/standard-headers/linux/input.h | 11 + include/

[Qemu-devel] [PULL 05/22] kvm: add memory encryption context

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh Split from a patch by Brijesh Singh (brijesh.si...@amd.com). Signed-off-by: Paolo Bonzini Signed-off-by: Brijesh Singh --- accel/Makefile.objs | 2 +- accel/kvm/Makefile.objs | 3 ++- accel/kvm/kvm-all.c | 25 + accel/kvm/sev-stub.c| 2

[Qemu-devel] [PULL 06/22] kvm: introduce memory encryption APIs

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh Inorder to integerate the Secure Encryption Virtualization (SEV) support add few high-level memory encryption APIs which can be used for encrypting the guest memory region. Cc: Paolo Bonzini Cc: k...@vger.kernel.org Signed-off-by: Brijesh Singh Signed-off-by: Paolo Bonzini

[Qemu-devel] [PULL 09/22] include: add psp-sev.h header file

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh The header file provide the ioctl command and structure to communicate with /dev/sev device. Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Signed-off-by: Brijesh Singh Signed-off-by: Brijesh Singh --- linux-headers/linux/psp-sev.h | 142

[Qemu-devel] [PULL 13/22] sev/i386: add command to encrypt guest memory region

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh The KVM_SEV_LAUNCH_UPDATE_DATA command is used to encrypt a guest memory region using the VM Encryption Key created using LAUNCH_START. Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Signed-off-by: Brijesh Singh Signed-off-by: Paolo Bonzini --- target/i386/

[Qemu-devel] [PULL 11/22] sev/i386: register the guest memory range which may contain encrypted data

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh When SEV is enabled, the hardware encryption engine uses a tweak such that the two identical plaintext at different location will have a different ciphertexts. So swapping or moving a ciphertexts of two guest pages will not result in plaintexts being swapped. Hence relocating

[Qemu-devel] [PULL 10/22] sev/i386: add command to initialize the memory encryption context

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh When memory encryption is enabled, KVM_SEV_INIT command is used to initialize the platform. The command loads the SEV related persistent data from non-volatile storage and initializes the platform context. This command should be first issued before invoking any other guest com

[Qemu-devel] [PULL 08/22] sev/i386: qmp: add query-sev command

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh The QMP query command can used to retrieve the SEV information when memory encryption is enabled on AMD platform. Cc: Eric Blake Cc: "Daniel P. Berrangé" Cc: "Dr. David Alan Gilbert" Cc: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Brijesh Singh Signed-off-b

[Qemu-devel] [PULL 17/22] sev/i386: add migration blocker

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh SEV guest migration is not implemented yet. Signed-off-by: Brijesh Singh Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Paolo Bonzini --- target/i386/sev.c | 13 + 1 file changed, 13 insertions(+) diff --git a/target/i386/sev.c b/target/i386/sev.c index b

[Qemu-devel] [PULL 21/22] sev/i386: qmp: add query-sev-capabilities command

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh The command can be used by libvirt to query the SEV capabilities. Cc: "Daniel P. Berrangé" Cc: "Dr. David Alan Gilbert" Cc: Markus Armbruster Signed-off-by: Brijesh Singh Signed-off-by: Paolo Bonzini --- monitor.c | 7 +++ qapi/misc.json| 42 +++

Re: [Qemu-devel] [PATCH v2 2/2] iotests: Add regression test for commit base locking

2018-03-13 Thread Max Reitz
On 2018-03-13 12:58, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/153 | 8 > tests/qemu-iotests/153.out | 4 > 2 files changed, 12 insertions(+) > > diff --git a/tests/qemu-iotests/153 b/tests/qemu-iotests/153 > index adfd02695b..a7875e6899 100755 > --

[Qemu-devel] [PULL 07/22] target/i386: add Secure Encrypted Virtualization (SEV) object

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh Add a new memory encryption object 'sev-guest'. The object will be used to create encrypted VMs on AMD EPYC CPU. The object provides the properties to pass guest owner's public Diffie-hellman key, guest policy and session information required to create the memory encryption co

[Qemu-devel] [PULL 19/22] sev/i386: hmp: add 'info sev' command

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh The command can be used to show the SEV information when memory encryption is enabled on AMD platform. Cc: Eric Blake Cc: "Daniel P. Berrangé" Cc: "Dr. David Alan Gilbert" Cc: Markus Armbruster Reviewed-by: "Dr. David Alan Gilbert" Signed-off-by: Brijesh Singh Signed-of

[Qemu-devel] [PULL 20/22] sev/i386: qmp: add query-sev-launch-measure command

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh The command can be used by libvirt to retrieve the measurement of SEV guest. This measurement is a signature of the memory contents that was encrypted through the LAUNCH_UPDATE_DATA. Cc: "Daniel P. Berrangé" Cc: "Dr. David Alan Gilbert" Cc: Markus Armbruster Reviewed-by: E

[Qemu-devel] [PULL 12/22] sev/i386: add command to create launch memory encryption context

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh The KVM_SEV_LAUNCH_START command creates a new VM encryption key (VEK). The encryption key created with the command will be used for encrypting the bootstrap images (such as guest bios). Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Signed-off-by: Brijesh Sin

[Qemu-devel] [PULL 22/22] sev/i386: add sev_get_capabilities()

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh The function can be used to get the current SEV capabilities. The capabilities include platform diffie-hellman key (pdh) and certificate chain. The key can be provided to the external entities which wants to establish a trusted channel between SEV firmware and guest owner. Cc

[Qemu-devel] [PULL 14/22] target/i386: encrypt bios rom

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh SEV requires that guest bios must be encrypted before booting the guest. Cc: "Michael S. Tsirkin" Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Signed-off-by: Brijesh Singh Signed-off-by: Paolo Bonzini --- hw/i386/pc_sysfw.c | 13 + 1 file cha

Re: [Qemu-devel] [PATCH v2 1/2] block: Fix flags in reopen queue

2018-03-13 Thread Max Reitz
On 2018-03-13 12:58, Fam Zheng wrote: > Reopen flags are not synchronized according to the > bdrv_reopen_queue_child precedence until bdrv_reopen_prepare. It is a > bit too late: we already check the consistency in bdrv_check_perm before > that. > > This fixes the bug that when bdrv_reopen a RO no

[Qemu-devel] [PULL 15/22] sev/i386: add support to LAUNCH_MEASURE command

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh During machine creation we encrypted the guest bios image, the LAUNCH_MEASURE command can be used to retrieve the measurement of the encrypted memory region. This measurement is a signature of the memory contents that can be sent to the guest owner as an attestation that the m

[Qemu-devel] [PULL 16/22] sev/i386: finalize the SEV guest launch flow

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh SEV launch flow requires us to issue LAUNCH_FINISH command before guest is ready to run. Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Signed-off-by: Brijesh Singh Signed-off-by: Paolo Bonzini --- target/i386/sev.c| 29 +

[Qemu-devel] [PULL 18/22] cpu/i386: populate CPUID 0x8000_001F when SEV is active

2018-03-13 Thread Paolo Bonzini
From: Brijesh Singh When SEV is enabled, CPUID 0x8000_001F should provide additional information regarding the feature (such as which page table bit is used to mark the pages as encrypted etc). The details for memory encryption CPUID is available in AMD APM (https://support.amd.com/TechDocs/2459

  1   2   3   4   5   6   >