[Qemu-devel] block migration and dirty bitmap reset

2018-03-07 Thread Peter Lieven
Hi, while looking at the code I wonder if the blk_aio_preadv and the bdrv_reset_dirty_bitmap order must be swapped in mig_save_device_bulk: qemu_mutex_lock_iothread(); aio_context_acquire(blk_get_aio_context(bmds->blk)); blk->aiocb = blk_aio_preadv(bb, cur_sector * BDRV_SECTOR_SIZE,

[Qemu-devel] [PATCH v2] iotests: Update 051 and 186 after commit 1454509726719e0933c

2018-03-07 Thread Alberto Garcia
SCSI controllers are no longer created automatically for -drive if=scsi, so this patch updates the tests that relied on that. Signed-off-by: Alberto Garcia --- tests/qemu-iotests/051.pc.out | 20 tests/qemu-iotests/186| 4 tests/qemu-iotests/186.out| 28 ---

[Qemu-devel] [Bug 1658120] Re: building with gcc-aarch64-linux-gnu

2018-03-07 Thread Cao Van Dong
Hello everyone!! I am having a issue when build qemu using gcc aarch64-linux-gnu-* on ubuntu 16.04: dong02@dong:~/qemu$ ./configure \ > --prefix=/usr --cross-prefix=/usr/bin/aarch64-linux-gnu- \ > --target-list=aarch64-softmmu

[Qemu-devel] [PATCH] hw/ppc/prep: Fix implicit creation of "-drive if=scsi" devices

2018-03-07 Thread Thomas Huth
The global hack for creating SCSI devices has recently been removed, but this apparently broke SCSI devices on some boards that were not ready for this change yet. For the 40p machine you now get: $ ppc64-softmmu/qemu-system-ppc64 -M 40p -cdrom x.iso qemu-system-ppc64: -cdrom x.iso: machine type d

Re: [Qemu-devel] [PATCH] slirp: disable Nagle in outgoing connections

2018-03-07 Thread Kamil Rytarowski
This patch is correct. LLDB expects 1sec for reply, GDB by default 2. Debuggers use this option to disable Nagle algorithm in order to quickly transfer messages between gdb-server and gdb-client. It's also fairy portable across systems. On 04.01.2018 18:56, Andreas Gustafsson wrote: > slirp: disa

[Qemu-devel] [PATCH] hw/mips/jazz: Fix implicit creation of "-drive if=scsi" devices

2018-03-07 Thread Thomas Huth
The global hack for creating SCSI devices has recently been removed, but this apparently broke SCSI devices on some boards that were not ready for this change yet. For the pica61 machine you now get: $ mips64-softmmu/qemu-system-mips64 -M pica61 -cdrom x.iso qemu-system-mips64: -cdrom x.iso: machi

Re: [Qemu-devel] [PATCH] slirp: disable Nagle in outgoing connections

2018-03-07 Thread Philippe Mathieu-Daudé
On 03/07/2018 06:13 AM, Kamil Rytarowski wrote: > This patch is correct. LLDB expects 1sec for reply, GDB by default 2. > > Debuggers use this option to disable Nagle algorithm in order to quickly > transfer messages between gdb-server and gdb-client. It's also fairy > portable across systems. >

[Qemu-devel] [PATCH] hw/sparc/sun4m: Fix implicit creation of "-drive if=scsi" devices

2018-03-07 Thread Thomas Huth
The global hack for creating SCSI devices has recently been removed, but this apparently broke SCSI devices on some boards that were not ready for this change yet. For the sun4m machines you now get: $ sparc-softmmu/qemu-system-sparc -boot d -cdrom x.iso qemu-system-sparc: -cdrom x.iso: machine ty

Re: [Qemu-devel] [PATCH] slirp: disable Nagle in outgoing connections

2018-03-07 Thread Kamil Rytarowski
On 07.03.2018 10:38, Philippe Mathieu-Daudé wrote: > On 03/07/2018 06:13 AM, Kamil Rytarowski wrote: >> This patch is correct. LLDB expects 1sec for reply, GDB by default 2. >> >> Debuggers use this option to disable Nagle algorithm in order to quickly >> transfer messages between gdb-server and gd

Re: [Qemu-devel] [PATCH v4 0/3] s390x/sclp: 64 bit event masks

2018-03-07 Thread Cornelia Huck
On Fri, 23 Feb 2018 18:42:55 +0100 Claudio Imbrenda wrote: > Until 67915de9f0383ccf4a ("s390x/event-facility: variable-length event masks") > we only supported 32bit sclp event masks, even though the archiecture > allows the guests to set up sclp event masks up to 1021 bytes in length. > With tha

Re: [Qemu-devel] [Qemu-block] block migration and MAX_IN_FLIGHT_IO

2018-03-07 Thread Stefan Hajnoczi
On Wed, Mar 7, 2018 at 7:55 AM, Peter Lieven wrote: > Am 06.03.2018 um 17:35 schrieb Peter Lieven: >> Am 06.03.2018 um 17:07 schrieb Stefan Hajnoczi: >>> On Mon, Mar 05, 2018 at 02:52:16PM +, Dr. David Alan Gilbert wrote: * Peter Lieven (p...@kamp.de) wrote: > Am 05.03.2018 um 12:45 s

[Qemu-devel] [Bug 1658120] Re: building with gcc-aarch64-linux-gnu

2018-03-07 Thread philmd
Hi Cao Van Dong, you need to install zlib1g-dev:arm64, see: https://github.com/qemu/qemu/blob/master/tests/docker/dockerfiles /debian-arm64-cross.docker Regards, Phil. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.l

Re: [Qemu-devel] [Bug 1658120] Re: building with gcc-aarch64-linux-gnu

2018-03-07 Thread Alex Bennée
Cao Van Dong <1658...@bugs.launchpad.net> writes: > Hello everyone!! > > I am having a issue when build qemu using gcc aarch64-linux-gnu-* on > ubuntu 16.04: > > dong02@dong:~/qemu$ ./configure >\ >> --prefix=/usr --cross-prefix=/usr/bin/aarc

Re: [Qemu-devel] [PATCH] HMP: Initialize err before using

2018-03-07 Thread Dr. David Alan Gilbert
* Zhangjixiang (jixiang_zh...@h3c.com) wrote: > When bdrv_snapshot_delete return fail, the errp will not be > assigned a valid value in error_propagate as errp didn't be > initialized in hmp_delvm, then error_reportf_err will use an > uninitialized value(call by hmp_delvm), and qemu crash. > > Sig

Re: [Qemu-devel] [PATCH] hw: Do not include "sysemu/block-backend.h" if it is not necessary

2018-03-07 Thread Thomas Huth
On 15.02.2018 09:55, Thomas Huth wrote: > After reviewing a patch from Philippe that removes block-backend.h > from hw/lm32/milkymist.c, I noticed that this header is included > unnecessarily in a lot of other files, too. Remove those unneeded > includes to speed up the compilation process a little

[Qemu-devel] Using new TCG Vector infrastructure in PowerPC

2018-03-07 Thread Nikunj A Dadhania
Hi Richard, I was working to get TCG vector support for PowerPC[1]. Started with converting logical operations like vector AND/OR/XOR and compare instructions. Found some inconsistency during my testing on x86 laptop emulating PowerPC: zero = max = f

Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] block/ssh: Implement .bdrv_refresh_filename()

2018-03-07 Thread Kevin Wolf
Am 06.03.2018 um 22:51 hat John Snow geschrieben: > On 02/05/2018 03:22 PM, Max Reitz wrote: > > This series implements .bdrv_refresh_filename() for the ssh block > > driver, along with an appropriate .bdrv_dirname() so we don't chop off > > query strings for backing files with relative filenames.

Re: [Qemu-devel] [PATCH v3 11/29] vhost+postcopy: Transmit 'listen' to client

2018-03-07 Thread Peter Xu
On Tue, Mar 06, 2018 at 11:20:56AM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Mon, Mar 05, 2018 at 05:42:42PM +, Dr. David Alan Gilbert wrote: > > > * Peter Xu (pet...@redhat.com) wrote: > > > > On Fri, Feb 16, 2018 at 01:16:07PM +, Dr. David Alan Gi

Re: [Qemu-devel] [PATCH v5 05/11] linux-user: fix mmap/munmap/mprotect/mremap/shmat

2018-03-07 Thread Laurent Vivier
Le 07/03/2018 à 07:36, Max Filippov a écrit : > In linux-user QEMU that runs for a target with TARGET_ABI_BITS bigger > than L1_MAP_ADDR_SPACE_BITS an assertion in page_set_flags fires when > mmap, munmap, mprotect, mremap or shmat is called for an address outside > the guest address space. mmap an

Re: [Qemu-devel] [PATCH v2 5/5] s390x/cpumodel: Set up CPU model for AP device support

2018-03-07 Thread Pierre Morel
On 06/03/2018 18:15, David Hildenbrand wrote: 1) ap=on is a guest ABI feature saying to the guest you can use AP instructions Indeed, that's what belongs into the CPU model. 2) How we provide AP instructions to the guest can be done in three different ways: - SIE Interpretation AP instruc

Re: [Qemu-devel] [PATCH v3 1/5] pc-dimm: refactor qmp_pc_dimm_device_list

2018-03-07 Thread Igor Mammedov
On Mon, 5 Mar 2018 14:57:06 +0800 Haozhong Zhang wrote: I'd suggest following commit subj/msg: - pc-dimm: make qmp_pc_dimm_device_list() sort devices by address Make qmp_pc_dimm_device_list() return sorted by start address list of devices so that it could be reused in places that would

Re: [Qemu-devel] [PULL] RISC-V QEMU Port Submission v8.2

2018-03-07 Thread Richard W.M. Jones
On Wed, Mar 07, 2018 at 01:09:29PM +1300, Michael Clark wrote: > Hopefully, this PR gets merged... I hope so too. We've been testing v8 (substantially the same as v8.2) extensively, including SMP. It's building hundreds of packages a day in the autobuilder, and being used for manual builds by se

Re: [Qemu-devel] [PATCH v3 20/29] postcopy: postcopy_notify_shared_wake

2018-03-07 Thread Peter Xu
On Tue, Mar 06, 2018 at 10:54:18AM +, Dr. David Alan Gilbert wrote: [...] > > Basically above was what I thought - to record the faulted addresses > > with specific PostcopyFD when page fault happened, then we may know > > which page(s) will a PostcopyFD need. But when with that, we'll > > p

Re: [Qemu-devel] [PATCH] trace: only permit standard C types and fixed size integer types

2018-03-07 Thread Daniel P . Berrangé
On Wed, Mar 07, 2018 at 09:24:30AM +0800, Fam Zheng wrote: > On Tue, 03/06 16:22, Daniel P. Berrangé wrote: > > RFE for patchew... > > > > Now we're sending separate email alerts for each build job, can we > > make patchew include the job name in the subject line, so it is > > immediately obvious

Re: [Qemu-devel] [PATCH v3 2/5] qmp: distinguish PC-DIMM and NVDIMM in MemoryDeviceInfoList

2018-03-07 Thread Igor Mammedov
On Mon, 5 Mar 2018 14:57:07 +0800 Haozhong Zhang wrote: > It may need to treat PC-DIMM and NVDIMM differently, e.g., when > deciding the necessity of non-volatile flag bit in SRAT memory > affinity structures. > > NVDIMMDeviceInfo, which inherits from PCDIMMDeviceInfo, is added to > union type

Re: [Qemu-devel] [PATCH v2 0/5] s390x: vfio-ap: guest dedicated crypto adapters

2018-03-07 Thread Pierre Morel
On 06/03/2018 18:10, David Hildenbrand wrote: If L2 forward devices to L3 through SIE ECA.28 but no bit is set is in the CRYCB of L2, L3 will not see any device. Exactly and this is the problem: How should L2 know that these devices are special and cannot be forwarded. This is what we call the

Re: [Qemu-devel] [PULL 00/30] ppc-for-2.12 queue 20180306

2018-03-07 Thread Daniel P . Berrangé
On Tue, Mar 06, 2018 at 05:56:03PM +, Mark Cave-Ayland wrote: > On 06/03/18 17:47, Thomas Huth wrote: > > > > It seems that the error is being raised when setting the property rather > > > than during realize so I'm not sure what I can do to handle this. Any > > > thoughts? > > > > Does the d

Re: [Qemu-devel] [PATCH v3 3/5] hw/acpi-build: build SRAT memory affinity structures for DIMM devices

2018-03-07 Thread Igor Mammedov
On Mon, 5 Mar 2018 14:57:08 +0800 Haozhong Zhang wrote: > ACPI 6.2A Table 5-129 "SPA Range Structure" requires the proximity > domain of a NVDIMM SPA range must match with corresponding entry in > SRAT table. > > The address ranges of vNVDIMM in QEMU are allocated from the > hot-pluggable addre

Re: [Qemu-devel] [PATCH v3 4/5] tests/bios-tables-test: allow setting extra machine options

2018-03-07 Thread Igor Mammedov
On Mon, 5 Mar 2018 14:57:09 +0800 Haozhong Zhang wrote: > Some test cases may require extra machine options than those used in > the current test_acpi_ones(), e.g., nvdimm test cases require the > machine option 'nvdimm=on'. > > Signed-off-by: Haozhong Zhang > --- > tests/bios-tables-test.c |

Re: [Qemu-devel] [PATCH v2] pc-bios/s390-ccw: Move string arrays from bootmap header to .c file

2018-03-07 Thread Cornelia Huck
On Tue, 6 Mar 2018 07:18:01 +0100 Thomas Huth wrote: > bootmap.h can currently only be included once - otherwise the linker > complains about multiple definitions of the "magic" strings. It's a > bad style to define string arrays in header files, so let's better > move these to the bootmap.c fil

[Qemu-devel] BUG? Using memory after freeing

2018-03-07 Thread Aleksey Kuleshov
Hello! Explanation of what I saw is follows. In hw/pci/pci_bridge.c function pci_bridge_update_mappings does follows: ``` void pci_bridge_update_mappings(PCIBridge *br) { PCIBridgeWindows *w = br->windows; /* Make updates atomic to: handle the case of one VCPU updating the bridge *

Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] iotests: add 208 nbd-server + blockdev-snapshot-sync test case

2018-03-07 Thread Stefan Hajnoczi
On Tue, Mar 6, 2018 at 11:25 PM, Stefano Panella wrote: > I have applied this patch and when I run the following qmp commands I I do > not see the crash anymore but there is still something wrong because only > /root/a is opened from qemu. It looks like nbd-server-stop is also getting > rid of the

Re: [Qemu-devel] [PATCH v1 1/1] iotests: bypass s390x for case 200

2018-03-07 Thread QingFeng Hao
在 2018/3/6 15:56, Christian Borntraeger 写道: Nack. This will be fixed by s390/ipl: only print boot menu error if -boot menu=on was specified You are right. After I applied that patch, the case is passed. Please ignore this patch. Thanks On 03/06/2018 08:54 AM, QingFeng Hao wrote: In s390x,

[Qemu-devel] [PATCH v10 04/24] migration: Set the migration tcp port

2018-03-07 Thread Juan Quintela
We can set the port parameter as zero. This patch lets us know what port the system was choosen for us. Now we can migrate to this place. Signed-off-by: Juan Quintela -- This was migrate_set_uri(), but as we only need the tcp_port, change to that one. --- migration/migration.c | 10 +

[Qemu-devel] [PATCH v10 09/24] migration: Set error state in case of error

2018-03-07 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/ram.c | 20 1 file changed, 20 insertions(+) diff --git a/migration/ram.c b/migration/ram.c index 3b6c077964..4a56a85d53 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -414,6 +414,16 @@ static void terminate_multifd_send_thre

[Qemu-devel] [PATCH v10 12/24] migration: Reference counting recv channels correctly

2018-03-07 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/socket.c | 11 +++ migration/socket.h | 7 +++ 2 files changed, 18 insertions(+) diff --git a/migration/socket.c b/migration/socket.c index b12b0a462e..26110739cf 100644 --- a/migration/socket.c +++ b/migration/socket.c @@ -27,6 +27,17 @@

[Qemu-devel] [PATCH v10 06/24] tests: Add basic migration precopy tcp test

2018-03-07 Thread Juan Quintela
Not sharing code from precopy/unix because we have to read back the tcp parameter. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- tests/migration-test.c | 58 +++--- 1 file changed, 55 insertions(+), 3 dele

[Qemu-devel] [PATCH v10 05/24] tests: Migration ppc now inlines its program

2018-03-07 Thread Juan Quintela
No need to write it to a file. Just need a proper firmware O:-) Signed-off-by: Juan Quintela CC: Laurent Vivier --- tests/migration-test.c | 41 + 1 file changed, 5 insertions(+), 36 deletions(-) diff --git a/tests/migration-test.c b/tests/migration-tes

[Qemu-devel] [RFC v10 00/24] Multifd

2018-03-07 Thread Juan Quintela
Hi this is the v10 version of the multifd patches, Lots of changes from previous versions: a - everything is sent now through the multifd channels, nothing is sent through main channel b - locking is band new, I was getting into a hole with the previous approach, right now, there is a single w

[Qemu-devel] [PATCH v10 03/24] migration: Create tcp_port parameter

2018-03-07 Thread Juan Quintela
It will be used to store the uri tcp_port parameter. This is the only parameter than can change and we can need to be able to connect to it. Signed-off-by: Juan Quintela -- This used to be uri parameter, but it has so many troubles to reproduce that it don't just make sense. --- hmp.c

[Qemu-devel] [PATCH v10 14/24] migration: Be sure all recv channels are created

2018-03-07 Thread Juan Quintela
We need them before we start migration. Signed-off-by: Juan Quintela --- migration/migration.c | 6 +- migration/ram.c | 11 +++ migration/ram.h | 1 + 3 files changed, 17 insertions(+), 1 deletion(-) diff --git a/migration/migration.c b/migration/migration.c index 919

[Qemu-devel] [PATCH v10 07/24] [RFH] tests: Add migration compress threads tests

2018-03-07 Thread Juan Quintela
Yeap, it is still not working. trying to learn how to debug threads for guests running from the testt hardness. For some reason, compression is not working at the moment, test is disabled until I found why. Signed-off-by: Juan Quintela --- tests/migration-test.c | 52 +++

[Qemu-devel] [PATCH v10 20/24] migration: Delay start of migration main routines

2018-03-07 Thread Juan Quintela
We need to make sure that we have started all the multifd threads. Signed-off-by: Juan Quintela --- migration/migration.c | 4 ++-- migration/migration.h | 1 + migration/ram.c | 3 +++ migration/socket.c| 3 +++ 4 files changed, 9 insertions(+), 2 deletions(-) diff --git a/migration/

[Qemu-devel] [PATCH v10 08/24] migration: Add multifd test

2018-03-07 Thread Juan Quintela
We set the x-multifd-page-count and x-multifd-channels. Signed-off-by: Juan Quintela --- tests/migration-test.c | 50 ++ 1 file changed, 50 insertions(+) diff --git a/tests/migration-test.c b/tests/migration-test.c index 6f9b4c8d7a..97d35f979d 100

[Qemu-devel] [PATCH v10 16/24] migration: Synchronize recv threads

2018-03-07 Thread Juan Quintela
We synchronize all threads each RAM_SAVE_FLAG_EOS. Bitmap synchronizations don't happen inside a ram section, so we are safe about two channels trying to overwrite the same memory. Signed-off-by: Juan Quintela --- migration/ram.c| 37 - migration/tra

[Qemu-devel] [PATCH v10 10/24] migration: In case of error just end the migration

2018-03-07 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/socket.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/migration/socket.c b/migration/socket.c index 08606c665d..b12b0a462e 100644 --- a/migration/socket.c +++ b/migration/socket.c @@ -139,9 +139,8 @@ static gboolean socket_ac

[Qemu-devel] [PATCH v10 23/24] migration: Create pages structure for reception

2018-03-07 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/ram.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/migration/ram.c b/migration/ram.c index df9646ed2e..264d2e462a 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -698,6 +698,7 @@ static void multifd_send_page(RAMBlock *block

[Qemu-devel] [PATCH v10 11/24] migration: terminate_* can be called for other threads

2018-03-07 Thread Juan Quintela
Once there, make count field to always be accessed with atomic operations. To make blocking operations, we need to know that the thread is running, so create a bool to indicate that. Signed-off-by: Juan Quintela --- migration/ram.c | 30 -- 1 file changed, 20 insert

[Qemu-devel] [PATCH v10 13/24] migration: Introduce multifd_recv_new_channel()

2018-03-07 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/migration.c | 3 ++- migration/ram.c | 6 ++ migration/ram.h | 2 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/migration/migration.c b/migration/migration.c index c398665de7..919343232e 100644 --- a/migration/migratio

[Qemu-devel] [PATCH v10 01/24] tests: Add migration precopy test

2018-03-07 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- tests/migration-test.c | 44 ++-- 1 file changed, 42 insertions(+), 2 deletions(-) diff --git a/tests/migration-test.c b/tests/migration-test.c index 74f9361bdd..6

[Qemu-devel] [PATCH v10 19/24] migration: Create multifd channels

2018-03-07 Thread Juan Quintela
In both sides. We still don't transmit anything through them. Signed-off-by: Juan Quintela --- migration/ram.c | 52 ++-- 1 file changed, 42 insertions(+), 10 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index b57d9fd667..7ef0c2b7e

[Qemu-devel] [PATCH v10 18/24] migration: Add multifd traces for start/end thread

2018-03-07 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/ram.c| 6 ++ migration/trace-events | 4 2 files changed, 10 insertions(+) diff --git a/migration/ram.c b/migration/ram.c index 0266bd200c..b57d9fd667 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -492,6 +492,8 @@ static void *m

[Qemu-devel] [PATCH v10 02/24] tests: Add migration xbzrle test

2018-03-07 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Peter Xu --- tests/migration-test.c | 64 ++ 1 file changed, 64 insertions(+) diff --git a/tests/migration-test.c b/tests/migration-test.c index 65ce3ea4ab..fb67a88353 100644 --- a/tests/migration-test.c +

[Qemu-devel] [PATCH v10 21/24] migration: Transmit initial package through the multifd channels

2018-03-07 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/ram.c | 50 +- 1 file changed, 45 insertions(+), 5 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 1aab96bd5e..4efac0c20c 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -52,6 +52,8

[Qemu-devel] [PATCH v10 15/24] migration: Synchronize send threads

2018-03-07 Thread Juan Quintela
We synchronize all threads each RAM_SAVE_FLAG_EOS. Bitmap synchronizations don't happen inside a ram section, so we are safe about two channels trying to overwrite the same memory. Signed-off-by: Juan Quintela --- migration/ram.c| 38 +- migration/tr

Re: [Qemu-devel] [PATCH QEMU v1 0/4] multiboot: bss_end_addr can be zero / cleanup

2018-03-07 Thread Kevin Wolf
Am 21.12.2017 um 18:25 hat Jack Schwartz geschrieben: > Properly account for the possibility of multiboot kernels with a zero > bss_end_addr. The Multiboot Specification, section 3.1.3 allows for > kernels without a bss section, by allowing a zeroed bss_end_addr multiboot > header field. > > Do s

[Qemu-devel] [PATCH v10 22/24] migration: Create ram_multifd_page

2018-03-07 Thread Juan Quintela
The function still don't use multifd, but we have simplified ram_save_page, xbzrle and RDMA stuff is gone. We have added a new counter. Signed-off-by: Juan Quintela -- Add last_page parameter Add commets for done and address Remove multifd field, it is the same than normal pages Merge next patc

[Qemu-devel] [PULL 2/4] multiboot: Remove unused variables from multiboot.c

2018-03-07 Thread Kevin Wolf
From: Jack Schwartz Remove unused variables: mh_mode_type, mh_width, mh_height, mh_depth Signed-off-by: Jack Schwartz Reviewed-by: Daniel Kiper Reviewed-by: Prasad J Pandit Signed-off-by: Kevin Wolf --- hw/i386/multiboot.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/hw/i386/mul

[Qemu-devel] [PATCH v10 17/24] migration: Export functions to create send channels

2018-03-07 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/socket.c | 28 +++- migration/socket.h | 3 +++ 2 files changed, 30 insertions(+), 1 deletion(-) diff --git a/migration/socket.c b/migration/socket.c index 26110739cf..b3b5571ebb 100644 --- a/migration/socket.c +++ b/migration/s

[Qemu-devel] [PULL 4/4] multiboot: fprintf(stderr...) -> error_report()

2018-03-07 Thread Kevin Wolf
From: Jack Schwartz Change all fprintf(stderr...) calls in hw/i386/multiboot.c to call error_report() instead, including the mb_debug macro. Remove the "\n" from strings passed to all modified calls, since error_report() appends one. Signed-off-by: Jack Schwartz Reviewed-by: Daniel Kiper Sign

[Qemu-devel] [PULL 0/4] Multiboot patches

2018-03-07 Thread Kevin Wolf
The following changes since commit f32408f3b472a088467474ab152be3b6285b2d7b: misc: don't use hwaddr as a type in trace events (2018-03-06 14:24:30 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to fetch changes up to 4b9006a41ea8818f

[Qemu-devel] [PULL 3/4] multiboot: Use header names when displaying fields

2018-03-07 Thread Kevin Wolf
From: Jack Schwartz Refer to field names when displaying fields in printf and debug statements. Signed-off-by: Jack Schwartz Reviewed-by: Daniel Kiper Signed-off-by: Kevin Wolf --- hw/i386/multiboot.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/i38

[Qemu-devel] [PULL 1/4] multiboot: bss_end_addr can be zero

2018-03-07 Thread Kevin Wolf
From: Jack Schwartz The multiboot spec (https://www.gnu.org/software/grub/manual/multiboot/), section 3.1.3, allows for bss_end_addr to be zero. A zero bss_end_addr signifies there is no .bss section. Suggested-by: Daniel Kiper Signed-off-by: Jack Schwartz Reviewed-by: Daniel Kiper Reviewed-

[Qemu-devel] [PATCH v10 24/24] [RFC] migration: Send pages through the multifd channels

2018-03-07 Thread Juan Quintela
Migration ends correctly, but there is still a race between clean up and last synchronization. Signed-off-by: Juan Quintela --- migration/ram.c| 132 ++--- migration/trace-events | 3 +- 2 files changed, 126 insertions(+), 9 deletions(-) dif

Re: [Qemu-devel] Outreachy 2017-DecemberMarch Aspirant for Vulkan-ize_virgl Project

2018-03-07 Thread Marc-André Lureau
Hi Anusha On Wed, Mar 7, 2018 at 4:54 AM, Anusha Srivastava wrote: > Hi Stefan, > > I have not been able to contact with Marc-Andre. > > Could you suggest someone else who could help with this ? Both Dave Airlie and I have discussed with you a few months ago, but you didn't reply. Did you receiv

[Qemu-devel] [PULL 6/6] qio: non-default context for TLS handshake

2018-03-07 Thread Daniel P . Berrangé
From: Peter Xu A new parameter "context" is added to qio_channel_tls_handshake() is to allow the TLS to be run on a non-default context. Still, no functional change. Signed-off-by: Peter Xu Signed-off-by: Daniel P. Berrangé --- chardev/char-socket.c | 1 + include/io/channel-tls.h

[Qemu-devel] [PULL 2/6] qio: introduce qio_channel_add_watch_{full|source}

2018-03-07 Thread Daniel P . Berrangé
From: Peter Xu Firstly, introduce an internal qio_channel_add_watch_full(), which enhances qio_channel_add_watch() that context can be specified. Then add a new API wrapper qio_channel_add_watch_source() to return a GSource pointer rather than a tag ID. Note that the _source() call will keep a

[Qemu-devel] [PULL 5/6] qio: non-default context for async conn

2018-03-07 Thread Daniel P . Berrangé
From: Peter Xu We have worked on qio_task_run_in_thread() already. Further, let all the qio channel APIs use that context. Signed-off-by: Peter Xu Signed-off-by: Daniel P. Berrangé --- chardev/char-socket.c | 4 ++-- include/io/channel-socket.h| 15 --- io/channel-s

[Qemu-devel] [PULL 4/6] qio: non-default context for threaded qtask

2018-03-07 Thread Daniel P . Berrangé
From: Peter Xu qio_task_run_in_thread() allows main thread to run blocking operations in the background. However it has an assumption on that it's always working with the default context. This patch tries to allow the threaded QIO task framework to run with non-default gcontext. Currently no fun

[Qemu-devel] [PULL 3/6] qio: store gsources for net listeners

2018-03-07 Thread Daniel P . Berrangé
From: Peter Xu Originally we were storing the GSources tag IDs. That'll be not enough if we are going to support non-default gcontext for QIO code. Switch to GSources without changing anything real. Now we still always pass in NULL, which means the default gcontext. Signed-off-by: Peter Xu S

Re: [Qemu-devel] [PATCH v2 0/9] chardev: qio related non-default context support

2018-03-07 Thread Stefan Hajnoczi
On Tue, Mar 06, 2018 at 01:33:11PM +0800, Peter Xu wrote: > Based-on: <20180305064324.9238-1-pet...@redhat.com> > > This series is based on the QIO part: > [PATCH v3 0/6] qio: general non-default GMainContext support > > v2: > - fix the reported problem by patchew in patch 5 > - added some r-bs

[Qemu-devel] [PULL 0/6] Qio next patches

2018-03-07 Thread Daniel P . Berrangé
The following changes since commit f2bb2d14c2958f3f5aef456bd2cdb1ff99f4a562: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2018-03-05 16:41:20 +) are available in the Git repository at: https://github.com/berrange/qemu tags/qio-next-pull-request

[Qemu-devel] [PULL 1/6] qio: rename qio_task_thread_result

2018-03-07 Thread Daniel P . Berrangé
From: Peter Xu It is strange that it was called gio_task_thread_result. Rename it to follow the naming rule of the file. Reviewed-by: Daniel P. Berrange Signed-off-by: Peter Xu Signed-off-by: Daniel P. Berrangé --- io/task.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --

Re: [Qemu-devel] [PATCH] block: make BDRV_POLL_WHILE() re-entrancy safe

2018-03-07 Thread Stefan Hajnoczi
On Tue, Mar 06, 2018 at 12:08:44PM +0100, Kevin Wolf wrote: > Am 06.03.2018 um 11:53 hat Stefan Hajnoczi geschrieben: > > Nested BDRV_POLL_WHILE() calls can occur. Currently > > assert(!bs_->wakeup) will fail when this happens. > > > > This patch converts bs->wakeup from bool to a counter. > > >

Re: [Qemu-devel] [PATCH v10 03/24] migration: Create tcp_port parameter

2018-03-07 Thread Daniel P . Berrangé
On Wed, Mar 07, 2018 at 11:59:49AM +0100, Juan Quintela wrote: > It will be used to store the uri tcp_port parameter. This is the only > parameter than can change and we can need to be able to connect to it. > > Signed-off-by: Juan Quintela > > -- > > This used to be uri parameter, but it has

Re: [Qemu-devel] [PULL 00/34] Misc patches for 2018-03-06

2018-03-07 Thread Thomas Huth
On 06.03.2018 14:18, Paolo Bonzini wrote: > The following changes since commit 58e2e17dba49b43f4ac9de19468aeae1c787dcc2: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2018-03-06 11:20:44 +) > > are available in the git repository at: > > > git://git

Re: [Qemu-devel] [PATCH V4 4/7] CAN bus Kvaser PCI CAN-S (single SJA1000 channel) emulation added.

2018-03-07 Thread Paolo Bonzini
On 06/03/2018 21:52, Pavel Pisa wrote: > Hello Thomas, > > thanks for report but I at this time I am and > can be some time in condition which does not allow > me to access e-mail and normal work > > On Tuesday 06 of March 2018 16:29:19 Thomas Huth wrote: >> On 14.01.2018 21:14, p...@cmp.felk.cvu

Re: [Qemu-devel] [PATCH v10 04/24] migration: Set the migration tcp port

2018-03-07 Thread Daniel P . Berrangé
On Wed, Mar 07, 2018 at 11:59:50AM +0100, Juan Quintela wrote: > We can set the port parameter as zero. This patch lets us know what > port the system was choosen for us. Now we can migrate to this place. > > Signed-off-by: Juan Quintela > > -- > > This was migrate_set_uri(), but as we only n

[Qemu-devel] [PATCH] virtio-blk: dataplane: Don't batch notifications if EVENT_IDX is present

2018-03-07 Thread Sergio Lopez
Commit 5b2ffbe4d99843fd8305c573a100047a8c962327 ("virtio-blk: dataplane: notify guest as a batch") deferred guest notification to a BH in order batch notifications, with purpose of avoiding flooding the guest with interruptions. This optimization came with a cost. The average latency perceived in

Re: [Qemu-devel] [PATCH v10 10/24] migration: In case of error just end the migration

2018-03-07 Thread Daniel P . Berrangé
On Wed, Mar 07, 2018 at 11:59:56AM +0100, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > migration/socket.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) Reviewed-by: Daniel P. Berrangé > diff --git a/migration/socket.c b/migration/socket.c > index 08606c665d..b12b

Re: [Qemu-devel] [PATCH v10 12/24] migration: Reference counting recv channels correctly

2018-03-07 Thread Daniel P . Berrangé
On Wed, Mar 07, 2018 at 11:59:58AM +0100, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > migration/socket.c | 11 +++ > migration/socket.h | 7 +++ > 2 files changed, 18 insertions(+) > > diff --git a/migration/socket.c b/migration/socket.c > index b12b0a462e..26110739c

Re: [Qemu-devel] [PATCH v10 17/24] migration: Export functions to create send channels

2018-03-07 Thread Daniel P . Berrangé
On Wed, Mar 07, 2018 at 12:00:03PM +0100, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > migration/socket.c | 28 +++- > migration/socket.h | 3 +++ > 2 files changed, 30 insertions(+), 1 deletion(-) > > diff --git a/migration/socket.c b/migration/socket.c >

Re: [Qemu-devel] [PATCH v10 18/24] migration: Add multifd traces for start/end thread

2018-03-07 Thread Daniel P . Berrangé
On Wed, Mar 07, 2018 at 12:00:04PM +0100, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > migration/ram.c| 6 ++ > migration/trace-events | 4 > 2 files changed, 10 insertions(+) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-

Re: [Qemu-devel] [PATCH v3 5/5] tests/bios-tables-test: add test cases for DIMM proximity

2018-03-07 Thread Igor Mammedov
On Mon, 5 Mar 2018 14:57:10 +0800 Haozhong Zhang wrote: > QEMU now builds one SRAT memory affinity structure for each > static-plugged PC-DIMM and NVDIMM device with the proximity domain > specified in the device option 'node', rather than only one SRAT > memory affinity structure covering the e

Re: [Qemu-devel] [PATCH v10 21/24] migration: Transmit initial package through the multifd channels

2018-03-07 Thread Daniel P . Berrangé
On Wed, Mar 07, 2018 at 12:00:07PM +0100, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > migration/ram.c | 50 +- > 1 file changed, 45 insertions(+), 5 deletions(-) > > diff --git a/migration/ram.c b/migration/ram.c > index 1aab96bd5e.

Re: [Qemu-devel] [PATCH v10 18/24] migration: Add multifd traces for start/end thread

2018-03-07 Thread Daniel P . Berrangé
On Wed, Mar 07, 2018 at 12:00:04PM +0100, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > migration/ram.c| 6 ++ > migration/trace-events | 4 > 2 files changed, 10 insertions(+) > > diff --git a/migration/trace-events b/migration/trace-events > index 76075c26bc..db

Re: [Qemu-devel] [PATCH v10 22/24] migration: Create ram_multifd_page

2018-03-07 Thread Daniel P . Berrangé
On Wed, Mar 07, 2018 at 12:00:08PM +0100, Juan Quintela wrote: > The function still don't use multifd, but we have simplified > ram_save_page, xbzrle and RDMA stuff is gone. We have added a new > counter. > > Signed-off-by: Juan Quintela > > -- > Add last_page parameter > Add commets for done a

Re: [Qemu-devel] [PATCH v10 24/24] [RFC] migration: Send pages through the multifd channels

2018-03-07 Thread Daniel P . Berrangé
On Wed, Mar 07, 2018 at 12:00:10PM +0100, Juan Quintela wrote: > Migration ends correctly, but there is still a race between clean up > and last synchronization. > > Signed-off-by: Juan Quintela > --- > migration/ram.c| 132 > ++--- > migratio

[Qemu-devel] [PATCH] tests/boot-serial: Check the 40p machine, too

2018-03-07 Thread Thomas Huth
The "40p" machine is using the Open Hack'Ware BIOS, just like the "prep" machine, so we can test it accordingly with the boot-serial tester, too. While we're at it, also change the strings that we are using for the "prep" machine, so that this test now also checks some CLI parameters. Signed-off-b

Re: [Qemu-devel] [PULL] RISC-V QEMU Port Submission v8.2

2018-03-07 Thread Michael Clark
On Wed, 7 Mar 2018 at 11:11 PM, Richard W.M. Jones wrote: > On Wed, Mar 07, 2018 at 01:09:29PM +1300, Michael Clark wrote: > > Hopefully, this PR gets merged... > > I hope so too. We've been testing v8 (substantially the same as v8.2) > extensively, including SMP. It's building hundreds of pack

Re: [Qemu-devel] [Qemu-ppc] [PULL 00/30] ppc-for-2.12 queue 20180306

2018-03-07 Thread luigi burdo
HI, i had test last git with Zoltan sam emultation but at start i recive this ./qemu-system-ppc -M sam460ex qemu-system-ppc: /home/gigi/src/tags/ppc-for-2.12-20180306/include/qemu/rcu.h:89: rcu_read_unlock: asserzione "p_rcu_reader->depth != 0" non riuscita. Annullato (core dump creato) My m

Re: [Qemu-devel] [Qemu-ppc] [PULL 00/30] ppc-for-2.12 queue 20180306

2018-03-07 Thread Thomas Huth
On 07.03.2018 13:16, luigi burdo wrote: > HI, > > i had test last git with Zoltan sam emultation but at start i recive this > > ./qemu-system-ppc -M sam460ex > qemu-system-ppc: > /home/gigi/src/tags/ppc-for-2.12-20180306/include/qemu/rcu.h:89: > rcu_read_unlock: asserzione "p_rcu_reader->depth !=

Re: [Qemu-devel] [PATCH v2 1/9] vl: export machine_init_done

2018-03-07 Thread Daniel P . Berrangé
On Tue, Mar 06, 2018 at 01:33:12PM +0800, Peter Xu wrote: > We have that variable but not exported. Export that so modules can have > a way to poke on whether machine init has finished. > > Meanwhile, set that up even before calling the notifiers, so that > notifiers who may depend on this field

Re: [Qemu-devel] [PATCH v3 1/3] migration: API to clear bits of guest free pages from the dirty bitmap

2018-03-07 Thread Dr. David Alan Gilbert
* Wei Wang (wei.w.w...@intel.com) wrote: > This patch adds an API to clear bits corresponding to guest free pages > from the dirty bitmap. Spilt the free page block if it crosses the QEMU > RAMBlock boundary. > > Signed-off-by: Wei Wang > CC: Dr. David Alan Gilbert > CC: Juan Quintela > CC: Mic

Re: [Qemu-devel] [PATCH v2 3/9] chardev: update net listener gcontext

2018-03-07 Thread Daniel P . Berrangé
On Tue, Mar 06, 2018 at 01:33:14PM +0800, Peter Xu wrote: > TCP chardevs can be using QIO network listeners working in the > background when in listening mode. However the network listeners are > always running in main context. This can race with chardevs that are > running in non-main contexts.

Re: [Qemu-devel] [PATCH v2 4/9] chardev: allow telnet gsource to switch gcontext

2018-03-07 Thread Daniel P . Berrangé
On Tue, Mar 06, 2018 at 01:33:15PM +0800, Peter Xu wrote: > It was originally created by qio_channel_add_watch() so it's always > assigning the task to main context. Now we use the new API called > qio_channel_add_watch_source() so that we get the GSource handle rather > than the tag ID. > > Mean

Re: [Qemu-devel] [PATCH v2 5/9] chardev: introduce chr_machine_done hook

2018-03-07 Thread Daniel P . Berrangé
On Tue, Mar 06, 2018 at 01:33:16PM +0800, Peter Xu wrote: > Introduce ChardevClass.chr_machine_done() hook so that chardevs can run > customized procedures after machine init. > > There was an existing mux user already that did similar thing but used a > raw machine done notifier. Generalize it i

Re: [Qemu-devel] [PATCH v3 3/3] migration: use the free page hint feature from balloon

2018-03-07 Thread Dr. David Alan Gilbert
* Wei Wang (wei.w.w...@intel.com) wrote: > Start the free page optimization when the bulk stage starts. In case the > guest is slow in reporting, actively stops it when the bulk stage ends. > The optimization avoids sending guest free pages during the bulk stage. > Currently, the optimization is ad

Re: [Qemu-devel] [PATCH v2 6/9] chardev: use chardev's gcontext for async connect

2018-03-07 Thread Daniel P . Berrangé
On Tue, Mar 06, 2018 at 01:33:17PM +0800, Peter Xu wrote: > Generalize the function to create the async QIO task connection. Also, > fix the context pointer to use the chardev's gcontext. > > Reviewed-by: Paolo Bonzini > Signed-off-by: Peter Xu > --- > chardev/char-socket.c | 25 ++

Re: [Qemu-devel] [PATCH v2 8/9] chardev: tcp: let TLS run on chardev context

2018-03-07 Thread Daniel P . Berrangé
On Tue, Mar 06, 2018 at 01:33:19PM +0800, Peter Xu wrote: > Now qio_channel_tls_handshake() is ready to receive the context. Let > socket chardev use it, then the TLS handshake of chardev will always be > with the chardev's context. > > Signed-off-by: Peter Xu > --- > chardev/char-socket.c | 2

  1   2   3   4   >