On Sun, Mar 04, 2018 at 11:43:39PM -0800, no-re...@patchew.org wrote:
[...]
> TESTdecodetree.py
> LINKtests/check-qdict
> LINKtests/test-char
> LINKtests/check-qnum
> LINKtests/check-qstring
> LINKtests/check-qlist
> LINKtests/check-qnull
> tests/test-cha
On 03/04/2018 02:45 PM, Nia Alarie wrote:
> These functions always return 0. By changing their return type to
> void, some dead code can be removed.
the event facility part looks ok, but I am asking myself if we should
go a step further.
Do we need the exit callback at all? We can certainly keep i
Am 02.03.2018 um 20:32 hat Jack Schwartz geschrieben:
> Hi Kevin.
>
> On 2018-01-15 07:54, Kevin Wolf wrote:
> > Am 21.12.2017 um 18:25 hat Jack Schwartz geschrieben:
> > > Properly account for the possibility of multiboot kernels with a zero
> > > bss_end_addr. The Multiboot Specification, secti
On Mon, Mar 05, 2018 at 03:45:55PM +0800, Peter Xu wrote:
> On Thu, Mar 01, 2018 at 06:33:27PM +0800, Liu, Yi L wrote:
> > This patch introduces a notify framework for IOMMUSVAContext.sva_notifiers.
> >
> > Signed-off-by: Liu, Yi L
> > ---
> > hw/vfio/common.c | 1 +
> > include/hw/
On Thu, Mar 01, 2018 at 03:32:22PM +0200, Michael S. Tsirkin wrote:
> On Thu, Mar 01, 2018 at 06:31:50PM +0800, Liu, Yi L wrote:
> > This patchset is to introduce a notifier framework for virt-SVA.
> > You may find virt-SVA design details from the link below.
> >
> > https://lists.gnu.org/archive/
On Fri, Mar 02, 2018 at 04:13:17PM +0100, Paolo Bonzini wrote:
> On 01/03/2018 11:33, Liu, Yi L wrote:
> > +void iommu_sva_notifier_unregister(IOMMUSVAContext *sva_ctx,
> > + IOMMUSVANotifier *notifier)
> > +{
> > +IOMMUSVANotifier *cur, *next;
> > +
> > +Q
On Thu, Mar 01, 2018 at 06:33:31PM +0800, Liu, Yi L wrote:
[...]
> -void pci_setup_iommu(PCIBus *bus, PCIIOMMUFunc fn, void *opaque)
> +void pci_device_notify_iommu(PCIDevice *dev, PCIDevNotifyType type)
> {
> -bus->iommu_fn = fn;
> +PCIBus *bus = PCI_BUS(pci_get_bus(dev));
> +PCIBus
On Mon, 5 Mar 2018 09:07:17 +0100
Christian Borntraeger wrote:
> On 03/04/2018 02:45 PM, Nia Alarie wrote:
> > These functions always return 0. By changing their return type to
> > void, some dead code can be removed.
>
> the event facility part looks ok, but I am asking myself if we should
>
On Fri, Mar 02, 2018 at 04:10:48PM +0100, Paolo Bonzini wrote:
> On 01/03/2018 11:33, Liu, Yi L wrote:
> > +void pci_setup_sva_ops(PCIDevice *dev, PCISVAOps *ops)
> > +{
> > +if (dev) {
> > +dev->sva_ops = ops;
> > +}
> > +return;
> > +}
> > +
>
> Better:
>
> {
> assert(op
The MemoryListener is registered on address_space_memory, there is
not much to assert. This currently works because the callback
is invoked only once when the listener is registered, but section->fv
is the _new_ FlatView, not the old one on later calls and that
would break.
This confines address_
address_space_access_valid is calling address_space_to_flatview but it can
be called outside the RCU lock. To fix it, push the rcu_read_lock/unlock
pair up from flatview_access_valid to address_space_access_valid.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Paolo Bonzini
---
exec.c | 12 -
I noticed that the introduction of flatview_{read,write} placed
address_space_to_flatview outside the RCU lock. This is wrong and has
to be fixed, because address_space_to_flatview does an atomic_rcu_read.
These patches fix this one function at a time.
Paolo Bonzini (7):
openpic_kvm: drop addre
address_space_read is calling address_space_to_flatview but it can
be called outside the RCU lock. To fix it, push the rcu_read_lock/unlock
pair up from flatview_read_full to address_space_read's constant size
fast path and address_space_read_full.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Paolo
These accessors are called from inlined functions, and the call sequence
is much more expensive than just inlining the access. Move the
struct declaration to memory-internal.h so that exec.c and memory.c
can both use an inline function.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Paolo Bonzini
---
address_space_write is calling address_space_to_flatview but it can
be called outside the RCU lock. To fix it, push the rcu_read_lock/unlock
pair up from flatview_write to address_space_write.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Paolo Bonzini
---
exec.c | 37 ++
The attached patch is also needed to avoid crashes during various
math-heavy test suites.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual
address_space_map is calling address_space_to_flatview but it can
be called outside the RCU lock. The function itself is calling
rcu_read_lock/rcu_read_unlock, just in the wrong place, so the
fix is easy.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Paolo Bonzini
---
exec.c | 3 ++-
1 file changed
address_space_rw is calling address_space_to_flatview but it can
be called outside the RCU lock. To fix it, transform flatview_rw
into address_space_rw, since flatview_rw is otherwise unused.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Paolo Bonzini
---
exec.c | 28 ++--
1
Signed-off-by: Gerd Hoffmann
Message-id: 20180301100547.18962-4-kra...@redhat.com
---
include/ui/console.h | 12
vl.c | 3 ---
ui/cocoa.m | 14 +-
3 files changed, 13 insertions(+), 16 deletions(-)
diff --git a/include/ui/console.h b/include/ui
This avoids a name clash for CONFIG_SDL, which is used by both sdl video
support and sdl audio support. It also more clear that this is a audio
driver configuration.
Signed-off-by: Gerd Hoffmann
Message-id: 20180301100547.18962-13-kra...@redhat.com
---
configure | 2 +-
audio/audio_i
Signed-off-by: Gerd Hoffmann
Message-id: 20180301100547.18962-14-kra...@redhat.com
---
configure| 2 +-
ui/Makefile.objs | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index 269add1187..cb4fdb3573 100755
--- a/configure
+++ b/configure
@@ -60
Simplifies handling the X11 dependency,
also makes ui/Makefile.objs more readable.
Signed-off-by: Gerd Hoffmann
Message-id: 20180301100547.18962-9-kra...@redhat.com
---
configure| 10 --
ui/Makefile.objs | 5 -
2 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/
Signed-off-by: Gerd Hoffmann
Message-id: 20180301100547.18962-3-kra...@redhat.com
---
include/ui/console.h | 19 ---
ui/sdl.c | 24 +---
ui/sdl2.c| 17 +++--
vl.c | 15 +--
4 files changed, 29 inse
Signed-off-by: Gerd Hoffmann
Message-id: 20180301100547.18962-5-kra...@redhat.com
---
include/ui/console.h | 12
ui/curses.c | 14 +-
vl.c | 17 ++---
3 files changed, 15 insertions(+), 28 deletions(-)
diff --git a/include/ui/console.
Also drop curses libs from libs_softmmu. Add CURSES_{CFLAGS,LIBS}
variables so we can use them for linking the curses module.
Also make target/unicore32/helper.o depend on curses which uses curses
directly for some reason ...
Signed-off-by: Gerd Hoffmann
Message-id: 20180301100547.18962-12-kra.
Also drop gtk and vte libs from libs_softmmu, so the libs are not
pulled in unless the gtk module actually gets loaded.
Signed-off-by: Gerd Hoffmann
Message-id: 20180301100547.18962-11-kra...@redhat.com
---
configure| 5 ++---
ui/Makefile.objs | 17 +
2 files changed, 11
Add a registry for user interfaces. Add qemu_display_init and
qemu_display_early_init helper functions for display initialization.
Hook up gtk ui as first user.
Signed-off-by: Gerd Hoffmann
Message-id: 20180301100547.18962-2-kra...@redhat.com
---
include/ui/console.h | 32 -
Signed-off-by: Gerd Hoffmann
Message-id: 20180301100547.18962-6-kra...@redhat.com
---
include/ui/console.h | 3 ---
ui/egl-headless.c| 20 +++-
vl.c | 12
3 files changed, 19 insertions(+), 16 deletions(-)
diff --git a/include/ui/console.h b/incl
If a requested user interface is not available, try loading it as
module, simliar to block layer modules. Needed to keep things working
when followup patches start to build user interfaces as modules.
Signed-off-by: Gerd Hoffmann
Message-id: 20180301100547.18962-8-kra...@redhat.com
---
Makefile
Using the new display registry instead of #ifdefs in vl.c.
Signed-off-by: Gerd Hoffmann
Message-id: 20180301100547.18962-7-kra...@redhat.com
---
include/ui/console.h | 1 +
ui/console.c | 19 +++
vl.c | 15 +--
3 files changed, 25 insertions(+
So remove x11 from pkg-config check and don't
add x11 cflags/libs to opengl cflags/libs.
Signed-off-by: Gerd Hoffmann
Message-id: 20180301100547.18962-10-kra...@redhat.com
---
configure | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/configure b/configure
index 3d2aef95
> diff --git a/hw/vfio/display.c b/hw/vfio/display.c
> new file mode 100644
> index 00..3e997f8a44
> --- /dev/null
> +++ b/hw/vfio/display.c
> @@ -0,0 +1,56 @@
> +/*
> + * display support for mdev based vgpu devices
> + *
> + * Copyright Red Hat, Inc. 2017
Just curious here since I don't r
The following changes since commit 136c67e07869227b21b3f627316e03679ce7b738:
Merge remote-tracking branch
'remotes/bkoppelmann/tags/pull-tricore-2018-03-02' into staging (2018-03-02
16:56:20 +)
are available in the git repository at:
git://git.kraxel.org/qemu tags/ui-201
On Fri, Mar 02, 2018 at 04:12:01PM +0100, Paolo Bonzini wrote:
> On 01/03/2018 11:33, Liu, Yi L wrote:
> > This patch adds pci_device_notify_iommu() for notify virtual IOMMU
> > emulator when assigned device is added. And adds a new notify_func
> > in PCIBus. vIOMMU emulator provides the instance o
On Fri, Mar 02, 2018 at 05:06:56PM +0100, Paolo Bonzini wrote:
> On 01/03/2018 11:33, Liu, Yi L wrote:
> > +pci_device_notify_iommu(pdev, PCI_NTY_DEV_ADD);
> > +
> > pci_setup_sva_ops(pdev, &vfio_pci_sva_ops);
> >
> > return;
> > @@ -3134,6 +3136,7 @@ static void vfio_exitfn(PCIDevi
On Mon, Mar 05, 2018 at 04:27:43PM +0800, Peter Xu wrote:
> On Thu, Mar 01, 2018 at 06:33:31PM +0800, Liu, Yi L wrote:
>
> [...]
>
> > -void pci_setup_iommu(PCIBus *bus, PCIIOMMUFunc fn, void *opaque)
> > +void pci_device_notify_iommu(PCIDevice *dev, PCIDevNotifyType type)
> > {
> > -bus->io
On Tue, Feb 27, 2018 at 08:54:11PM -0300, Philippe Mathieu-Daudé wrote:
> On 02/14/2018 04:00 PM, Alistair Francis wrote:
> > On Mon, Jan 15, 2018 at 4:59 AM, Stefan Hajnoczi wrote:
> >> On Thu, Jan 11, 2018 at 03:25:56PM -0800, Alistair Francis wrote:
> >>> On Wed, Jan 10, 2018 at 4:52 AM, Stefan
Used_memslots is shared by vhost kernel and user, it is equal to
dev->mem->nregions, which is correct for vhost kernel, but not for
vhost user, the latter one uses memory regions that have file
descriptor. E.g. a VM has a vhost-user NIC and 8(vhost user memslot
upper limit) memory slots, it will be
On 03/02/2018 08:04 PM, Richard Henderson wrote:
On 03/02/2018 01:59 AM, KONRAD Frederic wrote:
From: KONRAD Frederic
Since the commit af7a06bac7d3abb2da48ef3277d2a415772d2ae8:
`casa [..](10), .., ..` (and probably others alternate space instructions)
triggers a data access exception when th
> -Original Message-
> From: Michael S. Tsirkin [mailto:m...@redhat.com]
> Sent: Friday, March 02, 2018 12:17 AM
> To: Zhoujian (jay)
> Cc: qemu-devel@nongnu.org; imamm...@redhat.com; Huangweidong (C)
> ; wangxin (U) ; Gonglei
> (Arei) ; Liuzhe (Ahriy, Euler)
> Subject: Re: [PATCH v8 2/
On Fri, Mar 02, 2018 at 04:00:23PM +0100, Paolo Bonzini wrote:
> On 01/03/2018 11:33, Liu, Yi L wrote:
> > +struct VTDDeviceNode {
> > +PCIBus *bus;
> > +uint8_t devfn;
> > +QLIST_ENTRY(VTDDeviceNode) next;
> > +};
>
> Do you really need VTDDeviceNode? I think can you simply put the
>
On Fri, Mar 02, 2018 at 03:52:44PM +0100, Paolo Bonzini wrote:
> On 01/03/2018 11:33, Liu, Yi L wrote:
>
> Please merge this patch with the next one, since they are basically the
> .h and .c sides of the same thing.
yes, would do it in next version.
Thanks,
Yi Liu
Hi
On Sun, Mar 4, 2018 at 10:56 PM, Stefan Berger
wrote:
> This series of patches converts the TPM code to use tracing rather
> than the #define DEBUG_XYZ type of debugging.
>
> Regards,
>Stefan
>
> Stefan Berger (5):
> tpm: convert tpm_crb.c to use trace-events
> tpm: convert tpm_passthr
The following changes since commit 136c67e07869227b21b3f627316e03679ce7b738:
Merge remote-tracking branch
'remotes/bkoppelmann/tags/pull-tricore-2018-03-02' into staging (2018-03-02
16:56:20 +)
are available in the Git repository at:
git://github.com/stefanha/qemu.git tags/block-pull-r
From: Su Hang
only remove brackets that wrap `return` statements' content.
use `perl -pi -e "s/return \((.*?)\);/return \1;/g" util/uri.c`
to remove pattern like this: "return (1);"
Signed-off-by: Su Hang
Reviewed-by: Thomas Huth
Message-id: 1519533358-13759-3-git-send-email-suhan...@mails.uc
From: Fam Zheng
Signed-off-by: Fam Zheng
Message-id: 20180226030326.20219-3-f...@redhat.com
Signed-off-by: Stefan Hajnoczi
---
README | 31 ++-
1 file changed, 30 insertions(+), 1 deletion(-)
diff --git a/README b/README
index 2c8e1c8cc4..7833b97365 100644
--- a/RE
From: Su Hang
Using `clang-format -i util/uri.c` first, then change back few code
manually, to make sure only whitespace involved.
Signed-off-by: Su Hang
Reviewed-by: Thomas Huth
Message-id: 1519533358-13759-2-git-send-email-suhan...@mails.ucas.ac.cn
Signed-off-by: Stefan Hajnoczi
---
util/u
From: Thomas Huth
dev could be NULL if the PCI device can not be found due to some
reasons, so we must not dereference the pointer in this case.
Signed-off-by: Thomas Huth
Message-id: 1519713884-2346-1-git-send-email-th...@redhat.com
Signed-off-by: Stefan Hajnoczi
---
tests/libqos/virtio-pci.
From: Fam Zheng
git-publish [1] is a convenient tool to send patches and has been
popular among QEMU developers. Recently it has been made available in
Fedora/Debian official repo.
One nice feature of the tool is a per-project configuration with
profiles, especially in which the cccmd option is
From: Su Hang
For this patch, using curly braces to wrap `if` `while` `else` statements,
which only hold single statement. For example:
'''
if (cond)
statement;
'''
to
'''
if (cond) {
statement;
}
'''
And using tricks that compare the disassemblies before and after
code changes, to make
On Sat, 3 Mar 2018 02:51:31 +1300
Michael Clark wrote:
> Add CPU state header, CPU definitions and initialization routines
>
> Reviewed-by: Richard Henderson
> Signed-off-by: Sagar Karandikar
> Signed-off-by: Michael Clark
> ---
> target/riscv/cpu.c | 432
> +++
On 2 March 2018 at 17:22, Peter Maydell wrote:
> On 9 February 2018 at 19:03, Marc-André Lureau
> wrote:
>> Fixes the following ASAN warnings:
>>
>> /home/elmarco/src/qemu/hw/net/net_tx_pkt.c:201:27: runtime error: member
>> access within misaligned address 0x63128846 for type 'struct ip_hea
QEMU's screendump command can only take dumps from the primary display.
When using multiple VGA cards, there is no way to get a dump from a
secondary card or other display heads yet. So let's add an 'device' and
a 'head' parameter to the HMP and QMP commands to be able to specify
alternative device
* Stefan Berger (stef...@linux.vnet.ibm.com) wrote:
> Signed-off-by: Stefan Berger
> ---
> Makefile.objs | 1 +
> hw/tpm/tpm_crb.c| 17 +
> hw/tpm/trace-events | 5 +
> 3 files changed, 11 insertions(+), 12 deletions(-)
> create mode 100644 hw/tpm/trace-events
>
When setting migration capabilities via QMP/HMP, we'll apply them even
if the capability check failed. Fix it.
Fixes: 4a84214ebe ("migration: provide migrate_caps_check()", 2017-07-18)
Signed-off-by: Peter Xu
---
migration/migration.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
di
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180305094006.21446-1-stefa...@redhat.com
Subject: [Qemu-devel] [PULL 0/6] Block patches
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE
On Fri, Mar 02, 2018 at 04:08:47PM +0100, Paolo Bonzini wrote:
> On 01/03/2018 11:33, Liu, Yi L wrote:
> >
> > +struct IntelIOMMUAssignedDeviceNode {
> > +VTDAddressSpace *vtd_as;
> > +QLIST_ENTRY(IntelIOMMUAssignedDeviceNode) next;
> > +};
> > +
>
> This QLIST_ENTRY can also be placed d
On Mon, Mar 05, 2018 at 10:47:56AM +0100, Thomas Huth wrote:
> QEMU's screendump command can only take dumps from the primary display.
> When using multiple VGA cards, there is no way to get a dump from a
> secondary card or other display heads yet. So let's add an 'device' and
> a 'head' parameter
Richard W.M. Jones writes:
> The attached patch is also needed to avoid crashes during various
> math-heavy test suites.
>
> Rich.
>
> --
> From: Stef O'Rear
> Date: Sat, 3 Mar 2018 03:46:00 -0800
> Subject: [PATCH] softfloat: fix crash on int conversion of SNaN
>
> Signed-off-by: Stef O'Rear
On Thu, 15 Feb 2018 01:28:41 -0300
Philippe Mathieu-Daudé wrote:
> It ease code review, unit is explicit.
s/ease/eases/
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/s390x/sclp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/s390x/sclp.c b/hw/s390x/s
> -void qmp_screendump(const char *filename, Error **errp)
> +void qmp_screendump(const char *filename, bool has_device, const char
> *device,
> +bool has_head, int64_t head, Error **errp)
> {
> QemuConsole *con = qemu_console_lookup_by_index(0);
This initialization can
On Fri, Mar 02, 2018 at 03:51:53PM +0100, Paolo Bonzini wrote:
> On 01/03/2018 11:33, Liu, Yi L wrote:
> > +IntelPASIDNode *node;
> > +char name[128];
> > +
> > +QLIST_FOREACH(node, &(s->pasid_as_list), next) {
> > +vtd_pasid_as = node->pasid_as;
> > +if (pasid == vtd_pa
On 08.12.2017 22:29, John Snow wrote:
>
> On 11/21/2017 09:48 PM, Alexey Kardashevskiy wrote:
>> On 07/11/17 11:58, John Snow wrote:
>>>
>>>
>>> On 10/26/2017 02:46 AM, Alexey Kardashevskiy wrote:
A "powernv" machine type defines an ISA bus but it does not add any DMA
controller to it so
On Wed, 28 Feb 2018 13:24:35 +0100
Thomas Huth wrote:
> On 28.02.2018 12:02, David Hildenbrand wrote:
> > On 27.02.2018 12:32, Thomas Huth wrote:
> >> The file name of the netboot binary is currently hard-coded to
> >> "s390-netboot.img", without a possibility for the user to select
> >> an alt
On Tue, 27 Feb 2018 12:32:34 +0100
Thomas Huth wrote:
> The file name of the netboot binary is currently hard-coded to
> "s390-netboot.img", without a possibility for the user to select
> an alternative firmware image here. That's unfortunate, especially
> since the basics are already there: The
On non-x86 hosts with SDL2 2.0.8, configure fails:
config-host.mak is out-of-date, running configure
ERROR: configure test passed without -Werror but failed with -Werror.
This is probably a bug in the configure script. The failing command
will be at the bottom of config.log.
On Fri, Mar 02, 2018 at 04:01:11PM +0100, Paolo Bonzini wrote:
> On 01/03/2018 11:33, Liu, Yi L wrote:
> > From: Peter Xu
> >
> > IOMMU notifiers before are mostly used for [dev-]IOTLB stuffs. It is not
> > suitable for other kind of notifiers (one example would be the future
> > virt-svm support
On 10/26/2017 03:46 AM, Alexey Kardashevskiy wrote:
> A "powernv" machine type defines an ISA bus but it does not add any
> DMA
> controller to it so it is possible to hit assert(fdctrl->dma) by
> adding "-machine powernv -device isa-fdc".
The same happens with the Alpha machine.
On 12/13/2017 03
On Mon, Mar 05, 2018 at 10:24:41AM +, Peter Maydell wrote:
> On non-x86 hosts with SDL2 2.0.8, configure fails:
>
>
> config-host.mak is out-of-date, running configure
>
> ERROR: configure test passed without -Werror but failed with -Werror.
>This is probably a bug in the configure s
Public bug reported:
qemu/pc-bios/s390-ccw/libc.c:82]: (style) Unsigned variable 'num_idx'
can't be negative so it is unnecessary to test it.
Source code is
while (num_idx >= 0) {
but
size_t num_idx = 1; /* account for NUL */
So there is no escape from the while loop.
** Affects: qe
On Mon, Mar 05, 2018 at 04:43:09PM +0800, Liu, Yi L wrote:
> On Fri, Mar 02, 2018 at 05:06:56PM +0100, Paolo Bonzini wrote:
> > On 01/03/2018 11:33, Liu, Yi L wrote:
> > > +pci_device_notify_iommu(pdev, PCI_NTY_DEV_ADD);
> > > +
> > > pci_setup_sva_ops(pdev, &vfio_pci_sva_ops);
> > >
> >
* Thomas Huth (th...@redhat.com) wrote:
> QEMU's screendump command can only take dumps from the primary display.
> When using multiple VGA cards, there is no way to get a dump from a
> secondary card or other display heads yet. So let's add an 'device' and
> a 'head' parameter to the HMP and QMP c
On 05.03.2018 06:16, Thomas Huth wrote:
> We should not use leading underscores followed by a capital letter
> in #defines since such identifiers are reserved by the C standard.
>
Didn't know about that but seems to be true.
> For ASCE_ORIGIN, REGION_ENTRY_ORIGIN and SEGMENT_ENTRY_ORIGIN I also
Hi Thomas,
On 02/15/2018 03:10 AM, Thomas Huth wrote:
> On 15.02.2018 05:28, Philippe Mathieu-Daudé wrote:
>> These files were including "qemu/cutils.h" to use the byte-based size
>> definitions, now available in "qemu/cunits.h".
>>
>> Signed-off-by: Philippe Mathieu-Daudé
>> ---
>> include/hw/h
On Mon 05 Mar 2018 10:40:06 AM CET, Stefan Hajnoczi wrote:
> +A 'git-profile' utility was created to make above process less
> +cumbersome, and is highly recommended for making regular
> contributions,
A 'git-profile' utility ? Did you want to say 'git-publish' there?
Berto
On 05.03.2018 11:09, Gerd Hoffmann wrote:
>> -void qmp_screendump(const char *filename, Error **errp)
>> +void qmp_screendump(const char *filename, bool has_device, const char
>> *device,
>> +bool has_head, int64_t head, Error **errp)
>> {
>> QemuConsole *con = qemu_conso
Hi
On Mon, Mar 5, 2018 at 7:50 AM, Peter Xu wrote:
> Introduce ChardevClass.chr_machine_done() hook so that chardevs can run
> customized procedures after machine init.
>
> There was an existing mux user already that did similar thing but used a
> raw machine done notifier. Generalize it into a
> > +qmp_screendump(filename, id != NULL, id, id != NULL, head, &err);
> > hmp_handle_error(mon, &err);
> > }
>
> Looks ok from HMP; one question, is there a way to give an ID to the
> default VGA or only to extra devices?
It'll be whatever id you give to your video device. For libvirt
From: Simon Guo
During migration, after MSR bits is synced, cpu_post_load() will use
msr_mask to determine which PPC MSR bits will be applied into the target
side. Hardware Transaction Memory(HTM) has been supported since Power8,
but TS0/TS1 bit was not in msr_mask yet. That will prevent target K
* Laurent Vivier (lviv...@redhat.com) wrote:
> On 28/02/2018 19:02, Wei Huang wrote:
> > This patch moves the auto detection functions for cross compilation from
> > roms/Makefile to rules.mak. So the functions can be shared among Makefiles
> > in QEMU.
> >
> > Signed-off-by: Wei Huang
> > Review
Hi David,
On Mon, Mar 05, 2018 at 05:22:33PM +1100, David Gibson wrote:
> On Wed, Feb 28, 2018 at 09:51:37AM +0800, wei.guo.si...@gmail.com wrote:
> > From: Simon Guo
> >
> > During migration, cpu_post_load() will use msr_mask to determine which
> > PPC MSR bits will be sync to the target side. H
On Fri, Mar 02, 2018 at 10:30:57AM -0500, Farhan Ali wrote:
>
>
> On 03/02/2018 04:23 AM, Stefan Hajnoczi wrote:
> > On Thu, Mar 01, 2018 at 09:33:35AM -0500, Farhan Ali wrote:
> > > Hi,
> > >
> > > I have been noticing some segfaults for QEMU on s390x, and I have been
> > > hitting this issue q
* Gerd Hoffmann (kra...@redhat.com) wrote:
> > > +qmp_screendump(filename, id != NULL, id, id != NULL, head, &err);
> > > hmp_handle_error(mon, &err);
> > > }
> >
> > Looks ok from HMP; one question, is there a way to give an ID to the
> > default VGA or only to extra devices?
>
> It'll
QEMU's screendump command can only take dumps from the primary display.
When using multiple VGA cards, there is no way to get a dump from a
secondary card or other display heads yet. So let's add an 'device' and
a 'head' parameter to the HMP and QMP commands to be able to specify
alternative device
On Mon, 5 Mar 2018 06:16:58 +0100
Thomas Huth wrote:
> We should not use leading underscores followed by a capital letter
> in #defines since such identifiers are reserved by the C standard.
>
> For ASCE_ORIGIN, REGION_ENTRY_ORIGIN and SEGMENT_ENTRY_ORIGIN I also
> added parentheses around the
On 03/05/2018 11:23 AM, Cornelia Huck wrote:
> On Tue, 27 Feb 2018 12:32:34 +0100
> Thomas Huth wrote:
>
>> The file name of the netboot binary is currently hard-coded to
>> "s390-netboot.img", without a possibility for the user to select
>> an alternative firmware image here. That's unfortunat
Adding qemu-s390x.
On 03/05/2018 11:31 AM, dcb wrote:
> Public bug reported:
>
> qemu/pc-bios/s390-ccw/libc.c:82]: (style) Unsigned variable 'num_idx'
> can't be negative so it is unnecessary to test it.
>
> Source code is
>
>
> while (num_idx >= 0) {
>
> but
>
> size_t num_idx = 1;
(added in 076b35b5a56)
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Marc-André Lureau
---
include/qemu/cunits.h | 11 +++
include/qemu/cutils.h | 8 +---
2 files changed, 12 insertions(+), 7 deletions(-)
create mode 100644 include/qemu/cunits.h
diff --git a/include/qemu/cun
It eases code review, unit is explicit.
Patch generated using:
$ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/
and modified manually.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/sparc/leon3.c | 8
hw/sparc/sun4m.c | 7 +++
hw/sparc64/niagara.c
Hi,
This series:
- split the byte-based definitions from "qemu/cutils.h" to "qemu/cunits.h"
and let them available for all hw/ files (via "hw/hw.h");
- clean hw/ includes;
- replace different constants used for byte size with their corresponding
BYTE-based definitions.
Since v1:
- corrected
It eases code review, unit is explicit.
Patch generated using:
$ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/
and modified manually.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/alpha/typhoon.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
Signed-off-by: Philippe Mathieu-Daudé
Tested-by: Thomas Huth
---
hw/lm32/milkymist.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/lm32/milkymist.c b/hw/lm32/milkymist.c
index 471a74eaa1..c28379399f 100644
--- a/hw/lm32/milkymist.c
+++ b/hw/lm32/milkymist.c
@@ -30,7 +30,6 @@
#include "h
where it is used.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
---
hw/block/nvme.h | 1 -
hw/block/nvme.c | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/block/nvme.h b/hw/block/nvme.h
index 8f3981121d..cabcf20c32 100644
--- a/hw/block/nvme.h
+++ b/hw/bl
It eases code review, unit is explicit.
Patch generated using:
$ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/
and modified manually.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
---
include/hw/arm/stm32f205_soc.h | 4 ++--
hw/arm/boot.c
It eases code review, unit is explicit.
Patch generated using:
$ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/
and modified manually.
Signed-off-by: Philippe Mathieu-Daudé
Acked-by: Bastian Koppelmann
---
hw/tricore/tricore_testboard.c | 12 ++--
1 file ch
These files were including "qemu/cutils.h" to use the byte-based size
definitions, now available in "qemu/cunits.h".
Signed-off-by: Philippe Mathieu-Daudé
---
Thomas suggested:
Instead of adding this to a header and creating yet another possible
recompile-the-world dependency this way,
Signed-off-by: Philippe Mathieu-Daudé
---
hw/mips/mips_r4k.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/mips/mips_r4k.c b/hw/mips/mips_r4k.c
index 830ee7732c..2556786def 100644
--- a/hw/mips/mips_r4k.c
+++ b/hw/mips/mips_r4k.c
@@ -79,8 +79,9 @@ typedef struct Res
It eases code review, unit is explicit.
Patch generated using:
$ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/
and modified manually.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Acked-by: Cornelia Huck
---
hw/s390x/sclp.c | 4 ++--
1 file chang
It eases code review, unit is explicit.
Patch generated using:
$ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/
and modified manually.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/cris/axis_dev88.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/
It eases code review, unit is explicit.
Patch generated using:
$ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/
and modified manually.
Signed-off-by: Philippe Mathieu-Daudé
Acked-by: David Gibson
---
include/hw/ppc/spapr.h | 2 +-
hw/pci-host/prep.c | 2 +-
h
1 - 100 of 383 matches
Mail list logo
