Re: [Qemu-devel] [PATCH v2 05/10] acpi: move ACPI_PORT_SMI_CMD define to header it belongs to

2018-03-01 Thread Auger Eric
Hi, On 28/02/18 15:23, Igor Mammedov wrote: > ACPI_PORT_SMI_CMD is alias for APM_CNT_IOPORT, > so make it really one instead of duplicating its value. > > Signed-off-by: Igor Mammedov Reviewed-by: Eric Auger Eric > --- > include/hw/isa/apm.h | 3 +++ > hw/i386/acpi-build.c | 2 -- > hw/isa/ap

Re: [Qemu-devel] [PATCH v2 06/10] pc: acpi: isolate FADT specific data into AcpiFadtData structure

2018-03-01 Thread Auger Eric
Hi Igor, On 28/02/18 15:23, Igor Mammedov wrote: > move FADT data initialization out of fadt_setup() into dedicated > init_fadt_data() that will set common for pc/q35 values in > AcpiFadtData structure and acpi_get_pm_info() will complement > it with pc/q35 specific values initialization. > > Tha

Re: [Qemu-devel] [PATCH 1/1] s390/kvm: implement clearing part of IPL clear

2018-03-01 Thread Paolo Bonzini
On 01/03/2018 04:58, Thomas Huth wrote: >> When a guests reboots with diagnose 308 subcode 3 it requests the memory >> to be cleared. We did not do it so far. This does not only violate the >> architecture, it also misses the chance to free up that memory on >> reboot, which would help on host memo

[Qemu-devel] [PATCH v2 01/15] chardev: fix leak in tcp_chr_telnet_init_io()

2018-03-01 Thread Peter Xu
Need to free TCPChardevTelnetInit when session established. Since at it, switch to use G_SOURCE_* macros. Reviewed-by: Daniel P. Berrange Signed-off-by: Peter Xu --- chardev/char-socket.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/chardev/char-socket.c b/cha

[Qemu-devel] [PATCH v2 04/15] migration: let incoming side use thread context

2018-03-01 Thread Peter Xu
The old incoming migration is running in main thread and default gcontext. With the new qio_channel_add_watch_full() we can now let it run in the thread's own gcontext (if there is one). Currently this patch does nothing alone. But when any of the incoming migration is run in another iothread (e

[Qemu-devel] [PATCH v2 11/15] qio: non-default context for TLS handshake

2018-03-01 Thread Peter Xu
qio_channel_tls_handshake_full() is introduced to allow the TLS to be run on a non-default context. Still, no functional change. Signed-off-by: Peter Xu --- include/io/channel-tls.h | 17 io/channel-tls.c | 51 +++- 2 files ch

[Qemu-devel] [PATCH v2 00/15] qio: general non-default GMainContext support

2018-03-01 Thread Peter Xu
This is another preparation work for monitor OOB seires. V1: http://lists.nongnu.org/archive/html/qemu-devel/2018-02/msg06972.html V2 rewrote the bottom half of the code. The first 8 patches are mostly the same, but I rewrote the last patches to solve both TLS and reconnect use cases by introduc

[Qemu-devel] [PATCH v2 06/15] qio: store gsources for net listeners

2018-03-01 Thread Peter Xu
Originally we were storing the GSources tag IDs. That'll be not enough if we are going to support non-default gcontext for QIO code. Switch to GSources without changing anything real. Now we still always pass in NULL, which means the default gcontext. Signed-off-by: Peter Xu --- include/io/ne

[Qemu-devel] [PATCH v2 05/15] qio: refactor net listener source operations

2018-03-01 Thread Peter Xu
Three functions are abstracted from the old code: - qio_net_listener_source_add(): create one source for listener - qio_net_listener_sources_clear(): unset existing net lister sources - qio_net_listener_sources_update(): setup all sources for listener Use them where possible. Signed-off-by: Pete

[Qemu-devel] [PATCH v2 12/15] chardev: introduce chr_machine_done hook

2018-03-01 Thread Peter Xu
Introduce ChardevClass.chr_machine_done() hook so that chardevs can run customized procedures after machine init. There was an existing mux user already that did similar thing but used a raw machine done notifier. Generalize it into a framework, and let the mux chardevs provide such a class-speci

[Qemu-devel] [PATCH v2 02/15] qio: rename qio_task_thread_result

2018-03-01 Thread Peter Xu
It is strange that it was called gio_task_thread_result. Rename it to follow the naming rule of the file. Reviewed-by: Daniel P. Berrange Signed-off-by: Peter Xu --- io/task.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/io/task.c b/io/task.c index 3ce556017c..1a0a1c

[Qemu-devel] [PATCH v2 07/15] qio/chardev: update net listener gcontext

2018-03-01 Thread Peter Xu
TCP chardevs can be using QIO network listeners working in the background when in listening mode. However the network listeners are always running in main context. This can race with chardevs that are running in non-main contexts. To solve this, we need to re-setup the net listeners in tcp_chr_u

[Qemu-devel] [PATCH v2 09/15] qio: non-default context for threaded qtask

2018-03-01 Thread Peter Xu
qio_task_run_in_thread() allows main thread to run blocking operations in the background. However it has an assumption on that it's always working with the default context. This patch tries to allow the threaded QIO task framework to run with non-default gcontext. Currently no functional change so

Re: [Qemu-devel] [PATCH 13/14] qio: allow threaded qiotask to switch contexts

2018-03-01 Thread Peter Xu
On Wed, Feb 28, 2018 at 01:20:24PM +, Daniel P. Berrangé wrote: > On Wed, Feb 28, 2018 at 09:05:26PM +0800, Peter Xu wrote: > > On Wed, Feb 28, 2018 at 09:23:56AM +, Daniel P. Berrangé wrote: > > > On Wed, Feb 28, 2018 at 01:06:32PM +0800, Peter Xu wrote: > > > > This is the part of work to

[Qemu-devel] [PATCH v2 03/15] qio: introduce qio_channel_add_watch_{full|source}

2018-03-01 Thread Peter Xu
Firstly, introduce an internal qio_channel_add_watch_full(), which enhances qio_channel_add_watch() that context can be specified. Then add a new API wrapper qio_channel_add_watch_source() to return a GSource pointer rather than a tag ID. Note that the _source() call will keep a reference of GSou

[Qemu-devel] [PATCH v2 10/15] qio: non-default context for async conn

2018-03-01 Thread Peter Xu
We have worked on qio_task_run_in_thread() already. Further, let qio_channel_socket_connect_async() pass that context to it. Signed-off-by: Peter Xu --- chardev/char-socket.c | 4 ++-- include/io/channel-socket.h| 4 +++- io/channel-socket.c| 5 +++-- migration/socket.c

[Qemu-devel] [PATCH v2 08/15] chardev: allow telnet gsource to switch gcontext

2018-03-01 Thread Peter Xu
It was originally created by qio_channel_add_watch() so it's always assigning the task to main context. Now we use the new API called qio_channel_add_watch_source() so that we get the GSource handle rather than the tag ID. Meanwhile, caching the gsource in SocketChardev.telnet_source so that we c

[Qemu-devel] [PATCH v2 15/15] chardev: tcp: postpone TLS work until machine done

2018-03-01 Thread Peter Xu
TLS handshake may create background GSource tasks, while we won't know the correct GMainContext until the whole chardev (including frontend) inited. Let's postpone the initial TLS handshake until machine done. If we dynamically add tcp chardev, it won't be affected since we have a new tcp_chr_mac

[Qemu-devel] [PATCH v2 14/15] chardev: tcp: postpone async connection setup

2018-03-01 Thread Peter Xu
This patch allows the socket chardev async connection be setup with non-default gcontext. We do it by postponing the setup to machine done, since until then we can know which context we should run the async operation on. Signed-off-by: Peter Xu --- chardev/char-socket.c | 17 ++---

[Qemu-devel] [PATCH v2 13/15] char: use chardev's gcontext for async connect

2018-03-01 Thread Peter Xu
Generalize the function to create the async QIO task connection. Also, fix the context pointer to use the chardev's gcontext. Signed-off-by: Peter Xu --- chardev/char-socket.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/chardev/char-socket.c b

Re: [Qemu-devel] [PATCH v2 00/10] generalize build_fadt()

2018-03-01 Thread Auger Eric
Hi, On 28/02/18 15:23, Igor Mammedov wrote: > > v2: > * fix typo in "acpi: remove unused acpi-dsdt.aml" > * split ACPI_PORT_SMI_CMD into separate cleanup patch > * s/pm1_/pm1a_/, s/c2_latency/plvl2_lat/, s/c3_latency/plvl3_lat/ > and fix conflicts in followup patches caused by renaming

Re: [Qemu-devel] [PATCH v2 09/10] virt_arm: acpi: reuse common build_fadt()

2018-03-01 Thread Auger Eric
Hi, On 28/02/18 15:23, Igor Mammedov wrote: > Extend generic build_fadt() to support rev5.1 FADT > and reuse it for 'virt' board, it would allow to > phase out usage of AcpiFadtDescriptorRev5_1 and > later ACPI_FADT_COMMON_DEF. > > Signed-off-by: Igor Mammedov > --- > v2: > - update comment to

Re: [Qemu-devel] [PATCH v2 10/10] tests: acpi: don't read all fields in test_acpi_fadt_table()

2018-03-01 Thread Auger Eric
Hi Igor, On 28/02/18 15:23, Igor Mammedov wrote: > there is no point to read fields here but not actually > checking them so drop it and read only header + dsdt/facs > addresses since it's needed later to fetch that tables. > > With this cleanup we can get rid of AcpiFadtDescriptorRev3/ > ACPI_FA

Re: [Qemu-devel] [PATCH v6 9/9] vfio/display: adding dmabuf support

2018-03-01 Thread Zhang, Tina
> -Original Message- > From: intel-gvt-dev [mailto:intel-gvt-dev-boun...@lists.freedesktop.org] On > Behalf Of Gerd Hoffmann > Sent: Wednesday, February 28, 2018 8:31 PM > To: qemu-devel@nongnu.org > Cc: Alex Williamson ; Gerd Hoffmann > ; intel-gvt-...@lists.freedesktop.org; Kirti Wankhe

Re: [Qemu-devel] [PATCH 1/1] s390/kvm: implement clearing part of IPL clear

2018-03-01 Thread David Hildenbrand
On 28.02.2018 20:53, Christian Borntraeger wrote: > When a guests reboots with diagnose 308 subcode 3 it requests the memory > to be cleared. We did not do it so far. This does not only violate the > architecture, it also misses the chance to free up that memory on > reboot, which would help on hos

Re: [Qemu-devel] [PATCH v2 09/10] virt_arm: acpi: reuse common build_fadt()

2018-03-01 Thread Igor Mammedov
On Thu, 1 Mar 2018 09:51:14 +0100 Auger Eric wrote: > Hi, > On 28/02/18 15:23, Igor Mammedov wrote: > > Extend generic build_fadt() to support rev5.1 FADT > > and reuse it for 'virt' board, it would allow to > > phase out usage of AcpiFadtDescriptorRev5_1 and > > later ACPI_FADT_COMMON_DEF. > >

Re: [Qemu-devel] [PATCH 1/1] s390/kvm: implement clearing part of IPL clear

2018-03-01 Thread Dr. David Alan Gilbert
* Thomas Huth (th...@redhat.com) wrote: > On 28.02.2018 20:53, Christian Borntraeger wrote: > > When a guests reboots with diagnose 308 subcode 3 it requests the memory > > to be cleared. We did not do it so far. This does not only violate the > > architecture, it also misses the chance to free up

Re: [Qemu-devel] [PATCH v2 08/11] linux-user: drop unused target_msync function

2018-03-01 Thread Laurent Vivier
Le 28/02/2018 à 23:16, Max Filippov a écrit : > target_msync is not used, remove its declaration and implementation. > > Cc: Riku Voipio > Cc: Laurent Vivier > Signed-off-by: Max Filippov > --- > linux-user/mmap.c | 17 - > linux-user/qemu.h | 1 - > 2 files changed, 18 deleti

Re: [Qemu-devel] [PATCH v2 09/10] virt_arm: acpi: reuse common build_fadt()

2018-03-01 Thread Auger Eric
On 01/03/18 10:21, Igor Mammedov wrote: > On Thu, 1 Mar 2018 09:51:14 +0100 > Auger Eric wrote: > >> Hi, >> On 28/02/18 15:23, Igor Mammedov wrote: >>> Extend generic build_fadt() to support rev5.1 FADT >>> and reuse it for 'virt' board, it would allow to >>> phase out usage of AcpiFadtDescript

Re: [Qemu-devel] [PATCH v2 06/10] pc: acpi: isolate FADT specific data into AcpiFadtData structure

2018-03-01 Thread Igor Mammedov
On Thu, 1 Mar 2018 09:43:35 +0100 Auger Eric wrote: > Hi Igor, > > On 28/02/18 15:23, Igor Mammedov wrote: > > move FADT data initialization out of fadt_setup() into dedicated > > init_fadt_data() that will set common for pc/q35 values in > > AcpiFadtData structure and acpi_get_pm_info() will co

Re: [Qemu-devel] [PATCH v2 07/11] linux-user: fix target_mprotect/target_munmap error return values

2018-03-01 Thread Laurent Vivier
Le 28/02/2018 à 23:16, Max Filippov a écrit : > target_mprotect/target_munmap return value goes through get_errno at the > call site, thus the functions must either set errno to host error code > and return -1 or return negative guest error code. Do the latter. > > Cc: qemu-sta...@nongnu.org > Cc:

Re: [Qemu-devel] [PATCH V7 4/4] tests: Add migration test for aarch64

2018-03-01 Thread Andrew Jones
On Wed, Feb 28, 2018 at 12:02:15PM -0600, Wei Huang wrote: > This patch adds migration test support for aarch64. The test code, which > implements the same functionality as x86, is booted as a kernel in qemu. > Here are the design choices we make for aarch64: > > * We choose this -kernel approach

Re: [Qemu-devel] [PATCH] use g_path_get_basename instead of basename

2018-03-01 Thread Marc-André Lureau
Hi On Thu, Mar 1, 2018 at 8:08 AM, Julia Suvorova via Qemu-devel wrote: > basename(3) and dirname(3) modify their argument and may return > pointers to statically allocated memory which may be overwritten by > subsequent calls. > g_path_get_basename and g_path_get_dirname have no such issues, and

Re: [Qemu-devel] [PATCH v8 09/21] null: Switch to .bdrv_co_block_status()

2018-03-01 Thread Kevin Wolf
Am 01.03.2018 um 08:25 hat Vladimir Sementsov-Ogievskiy geschrieben: > 26.02.2018 17:05, Kevin Wolf wrote: > > Essentially, assuming a simple backing chain 'base <- overlay', we got > > these combinations to represent in NBD (with my suggestion of the flags > > to use): > > > > 1. Cluster allocate

Re: [Qemu-devel] [PATCH V7 3/4] tests/migration: Add migration-test header file

2018-03-01 Thread Andrew Jones
On Wed, Feb 28, 2018 at 12:02:14PM -0600, Wei Huang wrote: > This patch moves the settings related migration-test from the > migration-test.c file to a seperate header file. It also renames the > x86-a-b-bootblock.s file extension from .s to .S, allowing gcc > pre-processor to include the C-style h

Re: [Qemu-devel] VCPU hotplug on KVM/ARM

2018-03-01 Thread Igor Mammedov
On Tue, 27 Feb 2018 14:21:31 +0100 Andrew Jones wrote: > On Tue, Feb 27, 2018 at 01:46:04PM +0100, Christoffer Dall wrote: > > On Tue, Feb 27, 2018 at 05:34:28PM +0530, btha...@codeaurora.org wrote: > > > Hi Christoffer, > > > > > > Thanks for your reply. > > > > > > On 2018-02-27 16:17, Chri

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

2018-03-01 Thread Vladimir Sementsov-Ogievskiy
Hi, Sorry too for long delay. 28.02.2018 16:08, Wouter Verhelst wrote: Hi, Sorry, I forgot to reply to this earlier. On Fri, Feb 16, 2018 at 10:10:59AM -0600, Eric Blake wrote: On 02/16/2018 07:53 AM, Vladimir Sementsov-Ogievskiy wrote: Good idea. But it would be tricky thing to maintain ba

Re: [Qemu-devel] [PATCH v8 09/21] null: Switch to .bdrv_co_block_status()

2018-03-01 Thread Vladimir Sementsov-Ogievskiy
01.03.2018 12:48, Kevin Wolf wrote: Am 01.03.2018 um 08:25 hat Vladimir Sementsov-Ogievskiy geschrieben: 26.02.2018 17:05, Kevin Wolf wrote: Essentially, assuming a simple backing chain 'base <- overlay', we got these combinations to represent in NBD (with my suggestion of the flags to use): 1

Re: [Qemu-devel] [PATCH 04/14] migration: let incoming side use thread context

2018-03-01 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Wed, Feb 28, 2018 at 05:43:50PM +, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > The old incoming migration is running in main thread and default > > > gcontext. With the new qio_channel_add_watch_full() we can now let

Re: [Qemu-devel] [RFC v4 18/21] blockjobs: add block-job-finalize

2018-03-01 Thread Kevin Wolf
Am 28.02.2018 um 20:14 hat John Snow geschrieben: > > > On 02/28/2018 01:15 PM, Kevin Wolf wrote: > > Is it because you want to avoid that the user picks an automatic job for > > completing the mixed transaction? > > I wanted to avoid the case that a job without the manual property would > be st

Re: [Qemu-devel] [qemu-s390x] [PATCH v2] s390/ipl: only print boot menu error if -boot menu=on was specified

2018-03-01 Thread Thomas Huth
On 27.02.2018 20:35, Collin L. Walling wrote: > It is possible that certain QEMU configurations may not > create an IPLB (such as when -kernel is provided). In > this case, a misleading error message will be printed > stating that the "boot menu is not supported for this > device type". > > To ame

[Qemu-devel] [PATCH v2 00/13] ui: build sdl, gtk and curses as modules

2018-03-01 Thread Gerd Hoffmann
This patch series adds a registry for user interfaces (aka displays), adds support for user interface modules and allows to build sdl, gtk and curses as modules. Especially gtk cuts down the number of shared libraries qemu links against by a significant amount. Note one: Modules are disabled by d

[Qemu-devel] [PATCH v2 01/13] console: add qemu display registry, add gtk

2018-03-01 Thread Gerd Hoffmann
Add a registry for user interfaces. Add qemu_display_init and qemu_display_early_init helper functions for display initialization. Hook up gtk ui as first user. Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 32 ui/console.c | 34 ++

[Qemu-devel] [PATCH] grlib_apbuart: always enable tx and rx

2018-03-01 Thread KONRAD Frederic
We often use a bootloader for this board. So lets set the uart in a state which it can emit characters as if we were using a bootloader. Signed-off-by: KONRAD Frederic --- hw/char/grlib_apbuart.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/char/grlib_apbuart.c b/hw

Re: [Qemu-devel] [Qemu-arm] VCPU hotplug on KVM/ARM

2018-03-01 Thread Peter Maydell
On 1 March 2018 at 09:50, Igor Mammedov wrote: > In QEMU on x86 (and I think ppc, s390 as well), we create vCPUs on demand. > > It would be nice if ARM would be able to do that too, > so that it could take advantage of the same code. It's not clear to me how that would work, given that for instan

[Qemu-devel] [PATCH v2 03/13] cocoa: switch over to new display registry

2018-03-01 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 12 vl.c | 3 --- ui/cocoa.m | 14 +- 3 files changed, 13 insertions(+), 16 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index cb86e6a0dd..f8c462106a 100644 --- a/

[Qemu-devel] [PATCH v2 09/13] configure: opengl doesn't depend on x11

2018-03-01 Thread Gerd Hoffmann
So remove x11 from pkg-config check and don't add x11 cflags/libs to opengl cflags/libs. Signed-off-by: Gerd Hoffmann --- configure | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure b/configure index f6dc1c92b3..ab1ba9c47d 100755 --- a/configure +++ b/configure

[Qemu-devel] [PATCH v2 05/13] egl-headless: switch over to new display registry

2018-03-01 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 3 --- ui/egl-headless.c| 20 +++- vl.c | 12 3 files changed, 19 insertions(+), 16 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index 3ea6cf0870..94726cf190 100644

[Qemu-devel] [PATCH v2 06/13] console: add and use qemu_display_find_default

2018-03-01 Thread Gerd Hoffmann
Using the new display registry instead of #ifdefs in vl.c. Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 1 + ui/console.c | 19 +++ vl.c | 15 +-- 3 files changed, 25 insertions(+), 10 deletions(-) diff --git a/include/ui/console.h

[Qemu-devel] [PATCH v2 11/13] ui/curses: build as module

2018-03-01 Thread Gerd Hoffmann
Also drop curses libs from libs_softmmu. Add CURSES_{CFLAGS,LIBS} variables so we can use them for linking the curses module. Also make target/unicore32/helper.o depend on curses which uses curses directly for some reason ... Signed-off-by: Gerd Hoffmann --- configure | 6

[Qemu-devel] [PATCH v2 07/13] console: add ui module loading support

2018-03-01 Thread Gerd Hoffmann
If a requested user interface is not available, try loading it as module, simliar to block layer modules. Needed to keep things working when followup patches start to build user interfaces as modules. Signed-off-by: Gerd Hoffmann --- Makefile.objs | 1 + include/qemu/module.h | 1 + ui/

Re: [Qemu-devel] [PULL 00/11] Ui 20180228 patches

2018-03-01 Thread Gerd Hoffmann
On Wed, Feb 28, 2018 at 04:57:24AM -0800, no-re...@patchew.org wrote: > Hi, > > This series failed build test on s390x host. Please find the details below. Self-nack this pull. New patch series posted for review with build issues fixed (hopefully). cheers, Gerd

[Qemu-devel] [PATCH v2 08/13] configure: add X11 vars to config-host.mak

2018-03-01 Thread Gerd Hoffmann
Simplifies handling the X11 dependency, also makes ui/Makefile.objs more readable. Signed-off-by: Gerd Hoffmann --- configure| 10 -- ui/Makefile.objs | 5 - 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 39f3a43001..f6dc1c92b3 10

[Qemu-devel] [PATCH v2 04/13] curses: switch over to new display registry

2018-03-01 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 12 ui/curses.c | 14 +- vl.c | 17 ++--- 3 files changed, 15 insertions(+), 28 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index f8c462106a..3ea6cf0870

Re: [Qemu-devel] [PULL 00/26] s390x updates (and friends)

2018-03-01 Thread Peter Maydell
On 27 February 2018 at 13:21, Cornelia Huck wrote: > The following changes since commit 0a773d55ac76c5aa89ed9187a3bc5af8c5c2a6d0: > > maintainers: Add myself as a OpenBSD maintainer (2018-02-23 12:05:07 +) > > are available in the git repository at: > > git://github.com/cohuck/qemu tags/s3

[Qemu-devel] [PATCH v2 02/13] sdl: switch over to new display registry

2018-03-01 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 19 --- ui/sdl.c | 24 +--- ui/sdl2.c| 17 +++-- vl.c | 15 +-- 4 files changed, 29 insertions(+), 46 deletions(-) diff --git a/include/ui/c

[Qemu-devel] [PATCH v2 13/13] ui/sdl: build as module

2018-03-01 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- configure| 2 +- ui/Makefile.objs | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 105f79ef3d..4b0bdef154 100755 --- a/configure +++ b/configure @@ -6027,7 +6027,7 @@ if test "$have_x11" = "yes" -a "$need_

Re: [Qemu-devel] [RFC v4 21/21] blockjobs: add manual_mgmt option to transactions

2018-03-01 Thread Kevin Wolf
Am 28.02.2018 um 20:24 hat John Snow geschrieben: > > > On 02/28/2018 01:29 PM, Kevin Wolf wrote: > > Am 27.02.2018 um 21:24 hat Eric Blake geschrieben: > >> On 02/23/2018 05:51 PM, John Snow wrote: > >>> This allows us to easily force the option for all jobs belonging > >>> to a transaction to e

[Qemu-devel] [PATCH v2 12/13] audio: rename CONFIG_* to CONFIG_AUDIO_*

2018-03-01 Thread Gerd Hoffmann
This avoids a name clash for CONFIG_SDL, which is used by both sdl video support and sdl audio support. It also more clear that this is a audio driver configuration. Signed-off-by: Gerd Hoffmann --- configure | 2 +- audio/audio_int.h | 2 +- audio/Makefile.objs | 12 ++--

Re: [Qemu-devel] [PATCH v8 09/21] null: Switch to .bdrv_co_block_status()

2018-03-01 Thread Kevin Wolf
Am 01.03.2018 um 10:57 hat Vladimir Sementsov-Ogievskiy geschrieben: > 01.03.2018 12:48, Kevin Wolf wrote: > > Am 01.03.2018 um 08:25 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > 26.02.2018 17:05, Kevin Wolf wrote: > > > > Essentially, assuming a simple backing chain 'base <- overlay', we go

Re: [Qemu-devel] [PATCH v2 06/11] linux-user: fix assertion in shmdt

2018-03-01 Thread Laurent Vivier
Le 28/02/2018 à 23:16, Max Filippov a écrit : > shmdt fails to call mmap_lock/mmap_unlock around page_set_flags, > resulting in the following assertion: > page_set_flags: Assertion `have_mmap_lock()' failed. > > Wrap shmdt internals into mmap_lock/mmap_unlock. > > Cc: qemu-sta...@nongnu.org > C

[Qemu-devel] [PATCH v2 10/13] ui/gtk: build as module

2018-03-01 Thread Gerd Hoffmann
Also drop gtk and vte libs from libs_softmmu, so the libs are not pulled in unless the gtk module actually gets loaded. Signed-off-by: Gerd Hoffmann --- configure| 5 ++--- ui/Makefile.objs | 17 + 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/configur

Re: [Qemu-devel] [PULL 00/26] s390x updates (and friends)

2018-03-01 Thread Cornelia Huck
On Thu, 1 Mar 2018 10:12:53 + Peter Maydell wrote: > On 27 February 2018 at 13:21, Cornelia Huck wrote: > > The following changes since commit 0a773d55ac76c5aa89ed9187a3bc5af8c5c2a6d0: > > > > maintainers: Add myself as a OpenBSD maintainer (2018-02-23 12:05:07 > > +) > > > > are avai

Re: [Qemu-devel] [PATCH v2 1/3] hw/acpi-build: build SRAT memory affinity structures for DIMM devices

2018-03-01 Thread Igor Mammedov
On Wed, 28 Feb 2018 12:02:58 +0800 Haozhong Zhang wrote: > ACPI 6.2A Table 5-129 "SPA Range Structure" requires the proximity > domain of a NVDIMM SPA range must match with corresponding entry in > SRAT table. > > The address ranges of vNVDIMM in QEMU are allocated from the > hot-pluggable addre

Re: [Qemu-devel] [PATCH v2 05/15] qio: refactor net listener source operations

2018-03-01 Thread Daniel P . Berrangé
On Thu, Mar 01, 2018 at 04:44:28PM +0800, Peter Xu wrote: > Three functions are abstracted from the old code: > > - qio_net_listener_source_add(): create one source for listener > - qio_net_listener_sources_clear(): unset existing net lister sources > - qio_net_listener_sources_update(): setup all

[Qemu-devel] [PATCH v3 00/12] Introduce new iommu notifier framework for virt-SVA

2018-03-01 Thread Liu, Yi L
This patchset is to introduce a notifier framework for virt-SVA. You may find virt-SVA design details from the link below. https://lists.gnu.org/archive/html/qemu-devel/2017-04/msg04925.html SVA is short for Shared Virtual Addressing. This is also called Shared Virtual Memory in previous patchset

[Qemu-devel] [PATCH v3 03/12] hw/core: introduce IOMMUSVAContext for virt-SVA

2018-03-01 Thread Liu, Yi L
From: Peter Xu This patch adds IOMMUSVAContext as an abstract for virt-SVA in Qemu. IOMMUSVAContext is per-PASID(Process Address Space Identity). A PASID Tagged AddressSpace should have an IOMMUSVAContext created for it. virt-SVA emulation for emulated SVA capable devices would use IOMMUSVAConte

[Qemu-devel] [PATCH v3 05/12] hw/pci: introduce PCISVAOps to PCIDevice

2018-03-01 Thread Liu, Yi L
This patch intoduces PCISVAOps for virt-SVA. So far, to setup virt-SVA for assigned SVA capable device, needs to config host translation structures. e.g. for VT-d, needs to set the guest pasid table to host and enable nested translation. Besides, vIOMMU emulator needs to forward guest's cache inva

[Qemu-devel] [PATCH v3 00/12] Introduce new iommu notifier framework for virt-SVA

2018-03-01 Thread Liu, Yi L
This patchset is to introduce a notifier framework for virt-SVA. You may find virt-SVA design details from the link below. https://lists.gnu.org/archive/html/qemu-devel/2017-04/msg04925.html SVA is short for Shared Virtual Addressing. This is also called Shared Virtual Memory in previous patchset

[Qemu-devel] [PATCH v3 06/12] vfio/pci: provide vfio_pci_sva_ops instance

2018-03-01 Thread Liu, Yi L
VFIO is the bridge for vIOMMU and host IOMMU. Needs to provide API for vIOMMU emulator to set configs to host IOMMU. In this patchset, such API is exposed in hw/pci. Signed-off-by: Liu, Yi L --- hw/vfio/pci.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/hw/

[Qemu-devel] [PATCH v3 02/12] vfio: rename GuestIOMMU to be GuestIOMMUMR

2018-03-01 Thread Liu, Yi L
This patch renames GuestIOMMU to GuestIOMMUMR as the existing GuestIOMMU is for MemoryRegion related notifiers. Signed-off-by: Liu, Yi L --- hw/vfio/common.c | 17 + include/hw/vfio/vfio-common.h | 8 2 files changed, 13 insertions(+), 12 deletions(-) diff

[Qemu-devel] [PATCH v3 01/12] memory: rename existing iommu notifier to be iommu mr notifier

2018-03-01 Thread Liu, Yi L
From: Peter Xu IOMMU notifiers before are mostly used for [dev-]IOTLB stuffs. It is not suitable for other kind of notifiers (one example would be the future virt-svm support). Considering that current notifiers are targeted for per memory region, renaming the iommu notifier definitions. This pa

[Qemu-devel] [PATCH v3 10/12] intel_iommu: bind guest pasid table to host

2018-03-01 Thread Liu, Yi L
For assigned SVA capable devices, needs to bind guest pasid table to host. Intel vIOMMU emulator captures device selective context cache flush, and propagate the guest pasid table pointer to host, in host iommu driver configs the guest pasid table pointer in its translation structure. Signed-off-b

[Qemu-devel] [PATCH v3 07/12] vfio/pci: register sva notifier

2018-03-01 Thread Liu, Yi L
This patch shows how sva notifier is registered. And provided an example by registering notify func for tlb flush propagation. Signed-off-by: Liu, Yi L --- hw/vfio/pci.c | 55 +-- 1 file changed, 53 insertions(+), 2 deletions(-) diff --git a/h

[Qemu-devel] [PATCH v3 09/12] intel_iommu: record assigned devices in a list

2018-03-01 Thread Liu, Yi L
This patch records assigned devices in a list within Intel vIOMMU emulator. The recorded info can be used to filter out affect assigned devices when Qemu captured guest's cache invalidate request. Signed-off-by: Liu, Yi L --- hw/i386/intel_iommu.c | 31 ++- in

[Qemu-devel] [PATCH v3 04/12] vfio/pci: add notify framework based on IOMMUSVAContext

2018-03-01 Thread Liu, Yi L
This patch introduces a notify framework for IOMMUSVAContext.sva_notifiers. Signed-off-by: Liu, Yi L --- hw/vfio/common.c | 1 + include/hw/vfio/vfio-common.h | 9 + 2 files changed, 10 insertions(+) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index 06277d2..1cc96df 10

[Qemu-devel] [PATCH v3 12/12] intel_iommu: bind device to PASID tagged AddressSpace

2018-03-01 Thread Liu, Yi L
This patch shows the idea of how a device is binded to a PASID tagged AddressSpace. when Intel vIOMMU emulator detected a pasid table entry programming from guest. Intel vIOMMU emulator firstly finds a VTDPASIDAddressSpace with the pasid field of pasid cache invalidate request. * If it is to bind

[Qemu-devel] [PATCH v3 02/12] vfio: rename GuestIOMMU to be GuestIOMMUMR

2018-03-01 Thread Liu, Yi L
This patch renames GuestIOMMU to GuestIOMMUMR as the existing GuestIOMMU is for MemoryRegion related notifiers. Signed-off-by: Liu, Yi L --- hw/vfio/common.c | 17 + include/hw/vfio/vfio-common.h | 8 2 files changed, 13 insertions(+), 12 deletions(-) diff

[Qemu-devel] [PATCH v3 10/12] intel_iommu: bind guest pasid table to host

2018-03-01 Thread Liu, Yi L
For assigned SVA capable devices, needs to bind guest pasid table to host. Intel vIOMMU emulator captures device selective context cache flush, and propagate the guest pasid table pointer to host, in host iommu driver configs the guest pasid table pointer in its translation structure. Signed-off-b

[Qemu-devel] [PATCH v3 08/12] hw/pci: introduce pci_device_notify_iommu()

2018-03-01 Thread Liu, Yi L
This patch adds pci_device_notify_iommu() for notify virtual IOMMU emulator when assigned device is added. And adds a new notify_func in PCIBus. vIOMMU emulator provides the instance of this notify_func. Reason: When virtual IOMMU is exposed to guest, vIOMMU emulator needs to programm host IOMMU t

[Qemu-devel] [PATCH v3 03/12] hw/core: introduce IOMMUSVAContext for virt-SVA

2018-03-01 Thread Liu, Yi L
From: Peter Xu This patch adds IOMMUSVAContext as an abstract for virt-SVA in Qemu. IOMMUSVAContext is per-PASID(Process Address Space Identity). A PASID Tagged AddressSpace should have an IOMMUSVAContext created for it. virt-SVA emulation for emulated SVA capable devices would use IOMMUSVAConte

[Qemu-devel] [PATCH v3 04/12] vfio/pci: add notify framework based on IOMMUSVAContext

2018-03-01 Thread Liu, Yi L
This patch introduces a notify framework for IOMMUSVAContext.sva_notifiers. Signed-off-by: Liu, Yi L --- hw/vfio/common.c | 1 + include/hw/vfio/vfio-common.h | 9 + 2 files changed, 10 insertions(+) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index 06277d2..1cc96df 10

[Qemu-devel] [PATCH v3 11/12] intel_iommu: add framework for PASID AddressSpace management

2018-03-01 Thread Liu, Yi L
This patch introduces a framework to manage PASID tagged AddressSpace in Intel vIOMMU emulator. PASID tagged AddressSpace is an address sapce which is an abstract of guest process address space in Qemu. The management framework is as below: s->pasid_as_list /|\ \

Re: [Qemu-devel] [PATCH] use g_path_get_basename instead of basename

2018-03-01 Thread Cornelia Huck
On Thu, 1 Mar 2018 10:47:42 +0100 Marc-André Lureau wrote: > Hi > > On Thu, Mar 1, 2018 at 8:08 AM, Julia Suvorova via Qemu-devel > wrote: > > basename(3) and dirname(3) modify their argument and may return > > pointers to statically allocated memory which may be overwritten by > > subsequent c

[Qemu-devel] [PATCH v3 12/12] intel_iommu: bind device to PASID tagged AddressSpace

2018-03-01 Thread Liu, Yi L
This patch shows the idea of how a device is binded to a PASID tagged AddressSpace. when Intel vIOMMU emulator detected a pasid table entry programming from guest. Intel vIOMMU emulator firstly finds a VTDPASIDAddressSpace with the pasid field of pasid cache invalidate request. * If it is to bind

[Qemu-devel] [PATCH v3 06/12] vfio/pci: provide vfio_pci_sva_ops instance

2018-03-01 Thread Liu, Yi L
VFIO is the bridge for vIOMMU and host IOMMU. Needs to provide API for vIOMMU emulator to set configs to host IOMMU. In this patchset, such API is exposed in hw/pci. Signed-off-by: Liu, Yi L --- hw/vfio/pci.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/hw/

[Qemu-devel] [PATCH v3 07/12] vfio/pci: register sva notifier

2018-03-01 Thread Liu, Yi L
This patch shows how sva notifier is registered. And provided an example by registering notify func for tlb flush propagation. Signed-off-by: Liu, Yi L --- hw/vfio/pci.c | 55 +-- 1 file changed, 53 insertions(+), 2 deletions(-) diff --git a/h

Re: [Qemu-devel] [Qemu-trivial] [PATCH] grlib_apbuart: always enable tx and rx

2018-03-01 Thread Philippe Mathieu-Daudé
Hi Frederic, On 03/01/2018 07:02 AM, KONRAD Frederic wrote: > We often use a bootloader for this board. So lets set the uart in a state > which it can emit characters as if we were using a bootloader. > > Signed-off-by: KONRAD Frederic > --- > hw/char/grlib_apbuart.c | 4 ++-- > 1 file changed,

[Qemu-devel] [PATCH v3 09/12] intel_iommu: record assigned devices in a list

2018-03-01 Thread Liu, Yi L
This patch records assigned devices in a list within Intel vIOMMU emulator. The recorded info can be used to filter out affect assigned devices when Qemu captured guest's cache invalidate request. Signed-off-by: Liu, Yi L --- hw/i386/intel_iommu.c | 31 ++- in

[Qemu-devel] [PATCH v3 01/12] memory: rename existing iommu notifier to be iommu mr notifier

2018-03-01 Thread Liu, Yi L
From: Peter Xu IOMMU notifiers before are mostly used for [dev-]IOTLB stuffs. It is not suitable for other kind of notifiers (one example would be the future virt-svm support). Considering that current notifiers are targeted for per memory region, renaming the iommu notifier definitions. This pa

[Qemu-devel] [PATCH v3 08/12] hw/pci: introduce pci_device_notify_iommu()

2018-03-01 Thread Liu, Yi L
This patch adds pci_device_notify_iommu() for notify virtual IOMMU emulator when assigned device is added. And adds a new notify_func in PCIBus. vIOMMU emulator provides the instance of this notify_func. Reason: When virtual IOMMU is exposed to guest, vIOMMU emulator needs to programm host IOMMU t

[Qemu-devel] [PATCH v3 05/12] hw/pci: introduce PCISVAOps to PCIDevice

2018-03-01 Thread Liu, Yi L
This patch intoduces PCISVAOps for virt-SVA. So far, to setup virt-SVA for assigned SVA capable device, needs to config host translation structures. e.g. for VT-d, needs to set the guest pasid table to host and enable nested translation. Besides, vIOMMU emulator needs to forward guest's cache inva

[Qemu-devel] [PATCH v3 11/12] intel_iommu: add framework for PASID AddressSpace management

2018-03-01 Thread Liu, Yi L
This patch introduces a framework to manage PASID tagged AddressSpace in Intel vIOMMU emulator. PASID tagged AddressSpace is an address sapce which is an abstract of guest process address space in Qemu. The management framework is as below: s->pasid_as_list /|\ \

Re: [Qemu-devel] [PATCH 1/1] s390/kvm: implement clearing part of IPL clear

2018-03-01 Thread Christian Borntraeger
On 03/01/2018 10:24 AM, Dr. David Alan Gilbert wrote: > * Thomas Huth (th...@redhat.com) wrote: >> On 28.02.2018 20:53, Christian Borntraeger wrote: >>> When a guests reboots with diagnose 308 subcode 3 it requests the memory >>> to be cleared. We did not do it so far. This does not only violate

[Qemu-devel] [PATCH v4] linux-user: Support f_flags in statfs when available.

2018-03-01 Thread Shea Levy
Signed-off-by: Shea Levy --- linux-user/syscall.c | 5 + linux-user/syscall_defs.h | 41 +++-- 2 files changed, 24 insertions(+), 22 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 82b35a6bdf..03dca7ea77 100644 --- a/linux

Re: [Qemu-devel] [PULL 00/26] s390x updates (and friends)

2018-03-01 Thread Thomas Huth
On 01.03.2018 11:27, Cornelia Huck wrote: > On Thu, 1 Mar 2018 10:12:53 + > Peter Maydell wrote: > >> On 27 February 2018 at 13:21, Cornelia Huck wrote: >>> The following changes since commit 0a773d55ac76c5aa89ed9187a3bc5af8c5c2a6d0: >>> >>> maintainers: Add myself as a OpenBSD maintainer

Re: [Qemu-devel] [PATCH v4] linux-user: Support f_flags in statfs when available.

2018-03-01 Thread Laurent Vivier
Le 01/03/2018 à 12:15, Shea Levy a écrit : > Signed-off-by: Shea Levy > --- > linux-user/syscall.c | 5 + > linux-user/syscall_defs.h | 41 +++-- > 2 files changed, 24 insertions(+), 22 deletions(-) > Reviewed-by: Laurent Vivier

Re: [Qemu-devel] [PATCH] use g_path_get_basename instead of basename

2018-03-01 Thread Paolo Bonzini
On 01/03/2018 08:08, Julia Suvorova wrote: > +static void free_progname(void) > +{ > +g_free(progname); > +} > + > static void GCC_FMT_ATTR(2, 3) readline_printf_func(void *opaque, > const char *fmt, ...) > { > @@ -504,7 +509,8 @@ int main(

Re: [Qemu-devel] [PATCH] use g_path_get_basename instead of basename

2018-03-01 Thread Paolo Bonzini
On 01/03/2018 11:59, Cornelia Huck wrote: >>> >>> Signed-off-by: Julia Suvorova >> What about adding a warning for basename()/dirname() usage in >> scripts/checkpatch.pl ? > +1 to that. > Good idea indeed. Julia, would you like to send a second patch that adds the warning? There are already

[Qemu-devel] [PULL 15/42] arm/translate-a64: handle_3same_64 comment fix

2018-03-01 Thread Peter Maydell
From: Alex Bennée We do implement all the opcodes. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-id: 20180227143852.11175-8-alex.ben...@linaro.org Signed-off-by: Peter Maydell --- target/arm/translate-a64.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --g

  1   2   3   4   5   6   >