Re: [Qemu-devel] [RFC v4 07/21] blockjobs: add block_job_verb permission table

2018-02-27 Thread Kevin Wolf
Am 24.02.2018 um 00:51 hat John Snow geschrieben: > Which commands ("verbs") are appropriate for jobs in which state is > also somewhat burdensome to keep track of. > > As of this commit, it looks rather useless, but begins to look more > interesting the more states we add to the STM table. > > A

Re: [Qemu-devel] [PATCH v6 2/3] xlnx-zynqmp-rtc: Add basic time support

2018-02-27 Thread Alistair Francis
On Tue, Feb 27, 2018 at 8:36 AM, Peter Maydell wrote: > On 23 February 2018 at 17:21, Alistair Francis > wrote: >> Allow the guest to determine the time set from the QEMU command line. >> >> This includes adding a trace event to debug the new time. >> >> Signed-off-by: Alistair Francis > > Thank

Re: [Qemu-devel] [PATCH] hw/s390x/ipl: Bail out if the network bootloader can not be found

2018-02-27 Thread Farhan Ali
On 02/27/2018 05:16 AM, Viktor Mihajlovski wrote: On 27.02.2018 11:05, Thomas Huth wrote: If QEMU fails to load 's390-netboot.img', the guest firmware currently loops forever and just floods the console with "Network boot device detected" messages. The code in ipl.c apparently already tried to

Re: [Qemu-devel] [PATCH 0/5] Versatile Express SiI9022 emulation

2018-02-27 Thread Peter Maydell
On 27 February 2018 at 10:48, Linus Walleij wrote: > This series adds proper display bridge/connector emulation > for the Versatile Express, implementing a simple Silicon > Image 9022 emulation spawning a DDC I2C child. > > After the series the Versatile Express is successfully > presented the "QE

Re: [Qemu-devel] [PATCH v2 RFC] scripts/checkpatch.pl: add check for `while` and `for`

2018-02-27 Thread Stefan Hajnoczi
On Mon, Feb 26, 2018 at 10:53:18AM +0800, Su Hang wrote: > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 1b4b812e28fa..10c138344fa9 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -2353,7 +2353,8 @@ sub process { > } > > # check for miss

[Qemu-devel] [PATCH] vfio-ccw: license text should indicate GPL v2 or later

2018-02-27 Thread Cornelia Huck
The license text currently specifies "any version" of the GPL. It is unlikely that GPL v1 was ever intended; change this to the standard "or any later version" text. Cc: Dong Jia Shi Cc: Xiao Feng Ren Cc: Pierre Morel Signed-off-by: Cornelia Huck --- hw/vfio/ccw.c | 4 ++-- 1 file changed, 2

Re: [Qemu-devel] [PATCH v4 0/2] Add git-publish config file

2018-02-27 Thread Stefan Hajnoczi
On Mon, Feb 26, 2018 at 11:03:24AM +0800, Fam Zheng wrote: > v4: Fix prefixes. [Stefan] > Keep rich profiles. [Paolo] > > v3: Fix trivial hunk placement. [Michael] > Fix PPC sub-list. [Michael] > > v2: Add README paragraph [Marc-André, Stefan] > Fix 'trivial' profile [Marc-André] >

Re: [Qemu-devel] [PATCH] simpletrace: fix timestamp argument type

2018-02-27 Thread Stefan Hajnoczi
On Thu, Feb 22, 2018 at 04:39:01PM +, Stefan Hajnoczi wrote: > The timestamp argument to a trace event method is documented as follows: > > The method can also take a timestamp argument before the trace event > arguments: > > def runstate_set(self, timestamp, new_state): > ...

Re: [Qemu-devel] [PATCH v2 RFC] scripts/checkpatch.pl: add check for `while` and `for`

2018-02-27 Thread Peter Maydell
On 27 February 2018 at 17:32, Stefan Hajnoczi wrote: > On Mon, Feb 26, 2018 at 10:53:18AM +0800, Su Hang wrote: >> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl >> index 1b4b812e28fa..10c138344fa9 100755 >> --- a/scripts/checkpatch.pl >> +++ b/scripts/checkpatch.pl >> @@ -2353,7 +2353

Re: [Qemu-devel] [PULL 00/12] Ui 20180227 patches

2018-02-27 Thread Peter Maydell
axel.org/qemu tags/ui-20180227-pull-request > > for you to fetch changes up to 8742dcaf7bcfa1ef8720f34dab984f153c87c9f3: > > curses: build as ui module (2018-02-26 15:10:12 +0100) > > > ui: add &

Re: [Qemu-devel] [patches] Re: [PULL] RISC-V QEMU Port Submission

2018-02-27 Thread Peter Maydell
On 27 February 2018 at 15:50, Stef O'Rear wrote: > On Tue, Feb 27, 2018 at 6:01 AM, Peter Maydell > wrote: >> On 27 February 2018 at 00:15, Michael Clark wrote: >>> The spike_v1.9 >>> machine has been renamed to spike_v1.9.1 to match the privileged ISA >>> version and spike_v1.10 has been made

Re: [Qemu-devel] [PATCH v4 14/31] arm/translate-a64: add FP16 FMULX/MLS/FMLA to simd_indexed

2018-02-27 Thread Alex Bennée
Richard Henderson writes: > On 02/27/2018 06:38 AM, Alex Bennée wrote: >> @@ -11244,7 +11245,7 @@ static void disas_simd_indexed(DisasContext *s, >> uint32_t insn) >> } >> /* fall through */ >> case 0x9: /* FMUL, FMULX */ >> -if (!extract32(size, 1, 1)) { >> +

Re: [Qemu-devel] [PATCH v2 5/5] s390x/cpumodel: Set up CPU model for AP device support

2018-02-27 Thread David Hildenbrand
> vfio_group = vfio_ap_get_group(vapdev, &local_err); > if (!vfio_group) { > goto out_err; > diff --git a/linux-headers/asm-s390/kvm.h b/linux-headers/asm-s390/kvm.h > index 11def14..35a6d04 100644 > --- a/linux-headers/asm-s390/kvm.h > +++ b/linux-headers/asm-s390/kvm.h > @@ -13

Re: [Qemu-devel] [PATCH v2 5/5] s390x/cpumodel: Set up CPU model for AP device support

2018-02-27 Thread David Hildenbrand
>> Hm, do you need this twice? > > In my opinion this has only value if we assume that HW and/or KVM is buggy and > we are running host model (or it's expansion). > The "sanity" checks in KVM sensing code don't really hurt. But I agree, sane KVM should not produce this. > And even the we would

Re: [Qemu-devel] [PULL-for-s390x 00/14] s390-ccw firmware update

2018-02-27 Thread Peter Maydell
On 26 February 2018 at 10:42, Thomas Huth wrote: > > Hi Cornelia! > > The following changes since commit 0a773d55ac76c5aa89ed9187a3bc5af8c5c2a6d0: > > maintainers: Add myself as a OpenBSD maintainer (2018-02-23 12:05:07 +) > > are available in the git repository at: > > https://github.com

Re: [Qemu-devel] [PATCH v4 14/31] arm/translate-a64: add FP16 FMULX/MLS/FMLA to simd_indexed

2018-02-27 Thread Peter Maydell
On 27 February 2018 at 17:52, Alex Bennée wrote: > > Richard Henderson writes: > >> On 02/27/2018 06:38 AM, Alex Bennée wrote: >>> @@ -11244,7 +11245,7 @@ static void disas_simd_indexed(DisasContext *s, >>> uint32_t insn) >>> } >>> /* fall through */ >>> case 0x9: /* FMUL,

Re: [Qemu-devel] [PATCH v4 02/31] target/arm/cpu64: introduce ARM_V8_FP16 feature bit

2018-02-27 Thread Peter Maydell
On 27 February 2018 at 14:38, Alex Bennée wrote: > Signed-off-by: Alex Bennée > Reviewed-by: Richard Henderson > --- > target/arm/cpu.h | 1 + > target/arm/cpu64.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/target/arm/cpu.h b/target/arm/cpu.h > index 8c839faa8f..267a9d7e2f 100

Re: [Qemu-devel] [Qemu-arm] [PATCH v4 00/31] Add ARMv8.2 half-precision functions

2018-02-27 Thread Peter Maydell
On 27 February 2018 at 14:38, Alex Bennée wrote: > A few minor fixes and a chunk of Richard's r-b tags. Now all that is > left is: > > patch 0014/arm translate a64 add FP16 FMULX MLS FMLA to simd.patch needs > review > > Otherwise see comments bellow --- for other changes > Thanks -- applied t

Re: [Qemu-devel] [PATCH v2 5/5] s390x/cpumodel: Set up CPU model for AP device support

2018-02-27 Thread Halil Pasic
On 02/27/2018 06:52 PM, David Hildenbrand wrote: >> vfio_group = vfio_ap_get_group(vapdev, &local_err); >> if (!vfio_group) { >> goto out_err; >> diff --git a/linux-headers/asm-s390/kvm.h b/linux-headers/asm-s390/kvm.h >> index 11def14..35a6d04 100644 >> --- a/linux-headers/asm

Re: [Qemu-devel] [PATCH v2 5/5] s390x/cpumodel: Set up CPU model for AP device support

2018-02-27 Thread Tony Krowiak
On 02/27/2018 11:27 AM, Cornelia Huck wrote: On Tue, 27 Feb 2018 10:44:19 -0500 Tony Krowiak wrote: A new CPU model feature and two new CPU model facilities are introduced to support AP devices for a KVM guest. CPU model features: 1. The KVM_S390_VM_CPU_FEAT_AP CPU model feature indicates tha

Re: [Qemu-devel] [PATCH v4 14/31] arm/translate-a64: add FP16 FMULX/MLS/FMLA to simd_indexed

2018-02-27 Thread Alex Bennée
Peter Maydell writes: > On 27 February 2018 at 17:52, Alex Bennée wrote: >> >> Richard Henderson writes: >> >>> On 02/27/2018 06:38 AM, Alex Bennée wrote: @@ -11244,7 +11245,7 @@ static void disas_simd_indexed(DisasContext *s, uint32_t insn) } /* fall thr

Re: [Qemu-devel] [PATCH v2 5/5] s390x/cpumodel: Set up CPU model for AP device support

2018-02-27 Thread Tony Krowiak
On 02/27/2018 11:49 AM, Halil Pasic wrote: On 02/27/2018 05:27 PM, Cornelia Huck wrote: On Tue, 27 Feb 2018 10:44:19 -0500 Tony Krowiak wrote: A new CPU model feature and two new CPU model facilities are introduced to support AP devices for a KVM guest. CPU model features: 1. The KVM_S390_V

Re: [Qemu-devel] [PATCH v5 0/7] vfio: add display support

2018-02-27 Thread Alex Williamson
[CC +libvirt] On Tue, 27 Feb 2018 09:52:02 +0100 Gerd Hoffmann wrote: > This series adds support for a vgpu display to the qemu vfio code. > > v5: > - rebase to latest master > - drop DeviceState->hotpluggable patch, use separate vfio-pci-display >device instead so we can use DeviceClass-

[Qemu-devel] [PATCH] linux-user: Report AArch64 FP16 support via hwcap bits

2018-02-27 Thread Peter Maydell
Set the appropriate Linux hwcap bits to tell the guest binary if we have implemented half-precision floating point support. Signed-off-by: Peter Maydell --- This is intended to go after Alex's FP16 stuff since it uses the ARM_FEATURE_V8_FP16 bit that defines. There is as yet no kernel definition

Re: [Qemu-devel] [PATCH v1 1/1] MAINTAINERS: Update my email address

2018-02-27 Thread Peter Maydell
On 27 February 2018 at 16:47, Alistair Francis wrote: > I am leaving Xilinx, so to avoid having an email address that bouunces > update my maintainer address to point to my personal email address. > > Signed-off-by: Alistair Francis > Signed-off-by: Alistair Francis > --- Thanks -- I'll take th

Re: [Qemu-devel] proposed release schedule for QEMU 2.12

2018-02-27 Thread Peter Maydell
On 23 February 2018 at 16:04, Peter Maydell wrote: > On 30 January 2018 at 16:25, Peter Maydell wrote: >> It seems like it's about time we settled on the dates for the >> 2.12 release. I've sketched in a suggestion at: >> https://wiki.qemu.org/Planning/2.12 >> >> which puts softfreeze on the 13

Re: [Qemu-devel] [PULL-for-s390x 00/14] s390-ccw firmware update

2018-02-27 Thread Cornelia Huck
On Tue, 27 Feb 2018 17:56:48 + Peter Maydell wrote: > On 26 February 2018 at 10:42, Thomas Huth wrote: > > > > Hi Cornelia! > > > > The following changes since commit 0a773d55ac76c5aa89ed9187a3bc5af8c5c2a6d0: > > > > maintainers: Add myself as a OpenBSD maintainer (2018-02-23 12:05:07 >

Re: [Qemu-devel] [PATCH v2 5/5] s390x/cpumodel: Set up CPU model for AP device support

2018-02-27 Thread Tony Krowiak
On 02/27/2018 12:52 PM, David Hildenbrand wrote: vfio_group = vfio_ap_get_group(vapdev, &local_err); if (!vfio_group) { goto out_err; diff --git a/linux-headers/asm-s390/kvm.h b/linux-headers/asm-s390/kvm.h index 11def14..35a6d04 100644 --- a/linux-headers/asm-s390/kvm.h +++

[Qemu-devel] [PATCH v7 0/3] Add and connect the ZynqMP RTC

2018-02-27 Thread Alistair Francis
V7: - Move the current_tm to the init() function V6: - Migrate tick_offset and add a pre_save call V5: - Recalculate tick_offset after migration V4: - Use the RegisterAccessInfo .unimp functionality V3: - Store an offset value - Use mktimegm() - Log unimplemented writes V2: - Delete un

[Qemu-devel] [PATCH v7 1/3] xlnx-zynqmp-rtc: Initial commit

2018-02-27 Thread Alistair Francis
Initial commit of the ZynqMP RTC device. Signed-off-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé --- v5: - Don't use intermediate val V2: - Delete unused realise function - Remove DB_PRINT() include/hw/timer/xlnx-zynqmp-rtc.h | 84 +++ hw/timer/xlnx-zynqmp-rtc.c

[Qemu-devel] [PATCH v7 2/3] xlnx-zynqmp-rtc: Add basic time support

2018-02-27 Thread Alistair Francis
Allow the guest to determine the time set from the QEMU command line. This includes adding a trace event to debug the new time. Signed-off-by: Alistair Francis --- V7: - Make the current_tm local to init V6: - Migrate tick_offset and add a pre_save call V5: - Recalculate tick_offset after mig

Re: [Qemu-devel] [PATCH] linux-user: Report AArch64 FP16 support via hwcap bits

2018-02-27 Thread Richard Henderson
On 02/27/2018 10:39 AM, Peter Maydell wrote: > Set the appropriate Linux hwcap bits to tell the guest binary if we > have implemented half-precision floating point support. > > Signed-off-by: Peter Maydell > --- > This is intended to go after Alex's FP16 stuff since it > uses the ARM_FEATURE_V8_F

Re: [Qemu-devel] [RFC v4 05/21] blockjobs: add state transition table

2018-02-27 Thread Eric Blake
On 02/23/2018 05:51 PM, John Snow wrote: The state transition table has mostly been implied. We're about to make it a bit more complex, so let's make the STM explicit instead. Perform state transitions with a function that for now just asserts the transition is appropriate. Transitions: Undefin

Re: [Qemu-devel] [RFC v4 05/21] blockjobs: add state transition table

2018-02-27 Thread John Snow
On 02/27/2018 12:08 PM, Kevin Wolf wrote: > Am 27.02.2018 um 17:45 hat John Snow geschrieben: >> >> >> On 02/27/2018 11:27 AM, Kevin Wolf wrote: >>> Am 24.02.2018 um 00:51 hat John Snow geschrieben: The state transition table has mostly been implied. We're about to make it a bit more co

Re: [Qemu-devel] [RFC v4 06/21] iotests: add pause_wait

2018-02-27 Thread Eric Blake
On 02/23/2018 05:51 PM, John Snow wrote: Split out the pause command into the actual pause and the wait. Not every usage presently needs to resubmit a pause request. The intent with the next commit will be to explicitly disallow redundant or meaningless pause/resume requests, so the tests need t

Re: [Qemu-devel] [PATCH v9 00/14] ARM SMMUv3 Emulation Support

2018-02-27 Thread Peter Maydell
On 17 February 2018 at 18:46, Eric Auger wrote: > This series implements the emulation code for ARM SMMUv3. > > SMMUv3 gets instantiated by adding ",iommu=smmuv3" to the virt > machine option. > > VHOST integration will be handled in a separate series. VFIO > integration is not targeted at the mom

Re: [Qemu-devel] [PATCH] hw/s390x: Add the possibility to specify the netboot image on the command line

2018-02-27 Thread Thomas Huth
On 27.02.2018 14:27, Viktor Mihajlovski wrote: > On 27.02.2018 12:32, Thomas Huth wrote: >> The file name of the netboot binary is currently hard-coded to >> "s390-netboot.img", without a possibility for the user to select >> an alternative firmware image here. That's unfortunate, especially >> sin

Re: [Qemu-devel] [RFC v4 05/21] blockjobs: add state transition table

2018-02-27 Thread John Snow
On 02/27/2018 01:58 PM, Eric Blake wrote: > The ascii-art tables help in this and other patches.  Thanks for > producing them. Funny story: the original version of the STM present in these patches was too complex and I was not able to draw a chart for them. Kevin's insistence that I do draw a c

Re: [Qemu-devel] [PATCHv5 4/5] qemu-doc: deprecate query-cpus

2018-02-27 Thread Cornelia Huck
On Tue, 27 Feb 2018 14:41:38 +0100 Viktor Mihajlovski wrote: > On 19.02.2018 15:57, Cornelia Huck wrote: > > On Fri, 16 Feb 2018 17:08:40 +0100 > > Viktor Mihajlovski wrote: > > > >> Start the deprecation period for QAPI query-cpus (replaced by > >> query-cpus-fast) beginning with 2.12.0. > >

Re: [Qemu-devel] [PATCH] hw/s390x/ipl: Bail out if the network bootloader can not be found

2018-02-27 Thread Thomas Huth
On 27.02.2018 18:26, Farhan Ali wrote: > > > On 02/27/2018 05:16 AM, Viktor Mihajlovski wrote: >> On 27.02.2018 11:05, Thomas Huth wrote: >>> If QEMU fails to load 's390-netboot.img', the guest firmware currently >>> loops forever and just floods the console with "Network boot device >>> detected

[Qemu-devel] [PATCHv2] loader: don't perform overlapping address check for memory region ROM images

2018-02-27 Thread Mark Cave-Ayland
All memory region ROM images have a base address of 0 which causes the overlapping address check to fail if more than one memory region ROM image is present, or an existing ROM image is loaded at address 0. Make sure that we ignore the overlapping address check in rom_check_and_register_reset() i

[Qemu-devel] [PULL] qemu-sparc updates

2018-02-27 Thread Mark Cave-Ayland
Hi Peter, Here is a pull request containing the loader fix which enables qemu-system-sparc to work when used with -kernel again. ATB, Mark. The following changes since commit 3ec7b5d819da9245dd37a6f7e7d150f064cf584c: Merge remote-tracking branch 'remotes/kraxel/tags/vga-20180227

Re: [Qemu-devel] [PATCH] s390-ccw: only print boot menu error if -boot menu=on was specified

2018-02-27 Thread Cornelia Huck
On Tue, 27 Feb 2018 10:19:20 -0500 "Collin L. Walling" wrote: Nit: make the prefix s390x/ipl:, as this is not directly in the bios. > It is possible that certain QEMU configurations may not > create an IPLB (such as when -kernel is provided). In > this case, a misleading error message will be pr

Re: [Qemu-devel] [PATCH] loader: don't perform overlapping address check for memory region ROM images

2018-02-27 Thread Mark Cave-Ayland
On 23/02/18 18:53, Peter Maydell wrote: I can do, although I don't have any outstanding SPARC patches (just PPC ones for the moment) so it would just be a single commit PR. Is that okay? Yeah, it's less effort for me to apply a pull than a patch in some ways... Done. I've also sent a v2 with

Re: [Qemu-devel] [RFC v4 05/21] blockjobs: add state transition table

2018-02-27 Thread John Snow
On 02/27/2018 01:58 PM, Eric Blake wrote: > On 02/23/2018 05:51 PM, John Snow wrote: >> The state transition table has mostly been implied. We're about to make >> it a bit more complex, so let's make the STM explicit instead. >> >> Perform state transitions with a function that for now just asser

Re: [Qemu-devel] [RFC v4 07/21] blockjobs: add block_job_verb permission table

2018-02-27 Thread Eric Blake
On 02/23/2018 05:51 PM, John Snow wrote: Which commands ("verbs") are appropriate for jobs in which state is also somewhat burdensome to keep track of. As of this commit, it looks rather useless, but begins to look more interesting the more states we add to the STM table. A recurring theme is t

Re: [Qemu-devel] [PULL 0/5] Usb 20180227 patches

2018-02-27 Thread Peter Maydell
xel.org/qemu tags/usb-20180227-pull-request > > for you to fetch changes up to 53735bef108c5ccddf0f8a65cde4da53a48dbd47: > > usb-mtp: Advertise SendObjectInfo for write support (2018-02-26 12:18:36 > +0100) > > ---

Re: [Qemu-devel] [PATCH] s390-ccw: only print boot menu error if -boot menu=on was specified

2018-02-27 Thread Collin L. Walling
On 02/27/2018 02:18 PM, Cornelia Huck wrote: On Tue, 27 Feb 2018 10:19:20 -0500 "Collin L. Walling" wrote: Nit: make the prefix s390x/ipl:, as this is not directly in the bios. It is possible that certain QEMU configurations may not create an IPLB (such as when -kernel is provided). In this c

Re: [Qemu-devel] [PATCH 04/19] target/arm: Define an IDAU interface

2018-02-27 Thread Richard Henderson
On 02/20/2018 10:03 AM, Peter Maydell wrote: > In v8M, the Implementation Defined Attribution Unit (IDAU) is > a small piece of hardware typically implemented in the SoC > which provides board or SoC specific security attribution > information for each address that the CPU performs MPU/SAU > checks

Re: [Qemu-devel] [RFC v4 08/21] blockjobs: add ABORTING state

2018-02-27 Thread Eric Blake
On 02/23/2018 05:51 PM, John Snow wrote: Add a new state ABORTING. This makes transitions from normative states to error states explicit in the STM, and serves as a disambiguation for which states may complete normally when normal end-states (CONCLUDED) are added in future commits. Notably, Pau

[Qemu-devel] [PATCH v2] s390/ipl: only print boot menu error if -boot menu=on was specified

2018-02-27 Thread Collin L. Walling
It is possible that certain QEMU configurations may not create an IPLB (such as when -kernel is provided). In this case, a misleading error message will be printed stating that the "boot menu is not supported for this device type". To amend this, only print this message iff boot menu=on was provid

Re: [Qemu-devel] [PATCH v1 1/1] MAINTAINERS: Update my email address

2018-02-27 Thread Alistair Francis
On Tue, Feb 27, 2018 at 10:42 AM, Peter Maydell wrote: > On 27 February 2018 at 16:47, Alistair Francis > wrote: >> I am leaving Xilinx, so to avoid having an email address that bouunces >> update my maintainer address to point to my personal email address. >> >> Signed-off-by: Alistair Francis

Re: [Qemu-devel] [RFC v4 09/21] blockjobs: add CONCLUDED state

2018-02-27 Thread Eric Blake
On 02/23/2018 05:51 PM, John Snow wrote: add a new state "CONCLUDED" that identifies a job that has ceased all operations. The wording was chosen to avoid any phrasing that might imply success, error, or cancellation. The task has simply ceased all operation and can never again perform any work.

Re: [Qemu-devel] [RFC v4 07/21] blockjobs: add block_job_verb permission table

2018-02-27 Thread John Snow
On 02/27/2018 02:25 PM, Eric Blake wrote: > On 02/23/2018 05:51 PM, John Snow wrote: >> Which commands ("verbs") are appropriate for jobs in which state is >> also somewhat burdensome to keep track of. >> >> As of this commit, it looks rather useless, but begins to look more >> interesting the mo

Re: [Qemu-devel] [PATCHv5 5/5] hmp: change hmp_info_cpus to use query-cpus-fast

2018-02-27 Thread Dr. David Alan Gilbert
* Viktor Mihajlovski (mihaj...@linux.vnet.ibm.com) wrote: > Changing the implementation of hmp_info_cpus() to call > qmp_query_cpus_fast() instead of qmp_query_cpus. This has the > following consequences: > > o No further code change required for qmp_query_cpus deprecation > > o HMP profits f

Re: [Qemu-devel] [RFC v4 10/21] blockjobs: add NULL state

2018-02-27 Thread Eric Blake
On 02/23/2018 05:51 PM, John Snow wrote: Add a new state that specifically demarcates when we begin to permanently demolish a job after it has performed all work. This makes the transition explicit in the STM table and highlights conditions under which a job may be demolished. Reviewed-by: Eri

Re: [Qemu-devel] [RFC v4 09/21] blockjobs: add CONCLUDED state

2018-02-27 Thread John Snow
On 02/27/2018 02:38 PM, Eric Blake wrote: > On 02/23/2018 05:51 PM, John Snow wrote: >> add a new state "CONCLUDED" that identifies a job that has ceased all >> operations. The wording was chosen to avoid any phrasing that might >> imply success, error, or cancellation. The task has simply ceased

Re: [Qemu-devel] [RFC v4 11/21] blockjobs: add block_job_dismiss

2018-02-27 Thread Eric Blake
On 02/23/2018 05:51 PM, John Snow wrote: For jobs that have reached their CONCLUDED state, prior to having their last reference put down (meaning jobs that have completed successfully, unsuccessfully, or have been canceled), allow the user to dismiss the job's lingering status report via block-jo

[Qemu-devel] [PATCH] multiboot: check mh_load_end_addr address field

2018-02-27 Thread P J P
From: Prasad J Pandit While loading kernel via multiboot-v1 image, (flags & 0x0001) indicates that multiboot header contains valid addresses to load the kernel image. In that, end of the data segment address 'mh_load_end_addr' should be less than the bss segment address 'mh_bss_end_addr'. Add

Re: [Qemu-devel] [RFC v4 12/21] blockjobs: ensure abort is called for cancelled jobs

2018-02-27 Thread Eric Blake
On 02/23/2018 05:51 PM, John Snow wrote: Presently, even if a job is canceled post-completion as a result of a failing peer in a transaction, it will still call .commit because nothing has updated or changed its return code. The reason why this does not cause problems currently is because backup

Re: [Qemu-devel] [RFC v4 13/21] blockjobs: add commit, abort, clean helpers

2018-02-27 Thread Eric Blake
On 02/23/2018 05:51 PM, John Snow wrote: The completed_single function is getting a little mucked up with checking to see which callbacks exist, so let's factor them out. Signed-off-by: John Snow --- blockjob.c | 35 ++- 1 file changed, 26 insertions(+), 9 del

Re: [Qemu-devel] [RFC v4 14/21] blockjobs: add block_job_txn_apply function

2018-02-27 Thread Eric Blake
On 02/23/2018 05:51 PM, John Snow wrote: Simply apply a function transaction-wide. A few more uses of this in forthcoming patches. Signed-off-by: John Snow --- blockjob.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) @@ -565,13 +577,7 @@ static void bloc

Re: [Qemu-devel] [PATCH 05/19] armv7m: Forward idau property to CPU object

2018-02-27 Thread Richard Henderson
On 02/20/2018 10:03 AM, Peter Maydell wrote: > Create an "idau" property on the armv7m container object which > we can forward to the CPU object. Annoyingly, we can't use > object_property_add_alias() because the CPU object we want to > forward to doesn't exist until the armv7m container is realize

Re: [Qemu-devel] [PATCH v3 15/29] vhost+postcopy: Send address back to qemu

2018-02-27 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Fri, Feb 16, 2018 at 01:16:11PM +, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > We need a better way, but at the moment we need the address of the > > mappings sent back to qemu so it can interpret the messag

Re: [Qemu-devel] [RFC v4 15/21] blockjobs: add prepare callback

2018-02-27 Thread Eric Blake
On 02/23/2018 05:51 PM, John Snow wrote: Some jobs upon finalization may need to perform some work that can still fail. If these jobs are part of a transaction, it's important that these callbacks fail the entire transaction. We allow for a new callback in addition to commit/abort/clean that all

Re: [Qemu-devel] [PATCH v2 4/5] s390x/vfio: ap: Introduce VFIO AP device

2018-02-27 Thread Tony Krowiak
On 02/27/2018 12:04 PM, Cornelia Huck wrote: On Tue, 27 Feb 2018 10:44:18 -0500 Tony Krowiak wrote: Introduces a VFIO based AP device. The device is defined via the QEMU command line by specifying: -device vfio-ap,sysfsdev= The mediated matrix device is created by the VFIO AP device dri

Re: [Qemu-devel] [RFC v4 16/21] blockjobs: add waiting status

2018-02-27 Thread Eric Blake
On 02/23/2018 05:51 PM, John Snow wrote: For jobs that are stuck waiting on others in a transaction, it would be nice to know that they are no longer "running" in that sense, but instead are waiting on other jobs in the transaction. Jobs that are "waiting" in this sense cannot be meaningfully al

Re: [Qemu-devel] [RFC v4 17/21] blockjobs: add PENDING status and event

2018-02-27 Thread Eric Blake
On 02/23/2018 05:51 PM, John Snow wrote: For jobs utilizing the new manual workflow, we intend to prohibit them from modifying the block graph until the management layer provides an explicit ACK via block-job-finalize to move the process forward. To distinguish this runstate from "ready" or "wai

Re: [Qemu-devel] [PATCH v3 00/29] postcopy+vhost-user/shared ram

2018-02-27 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Fri, Feb 16, 2018 at 01:15:56PM +, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Hi, > > This is the first non-RFC version of this patch set that > > enables postcopy migration with shared memory to a vhost

Re: [Qemu-devel] [RFC v4 18/21] blockjobs: add block-job-finalize

2018-02-27 Thread Eric Blake
On 02/23/2018 05:51 PM, John Snow wrote: Instead of automatically transitioning from PENDING to CONCLUDED, gate the .prepare() and .commit() phases behind an explicit acknowledgement provided by the QMP monitor if manual completion mode has been requested. This allows us to perform graph changes

Re: [Qemu-devel] [RFC v4 19/21] blockjobs: Expose manual property

2018-02-27 Thread Eric Blake
On 02/23/2018 05:51 PM, John Snow wrote: Expose the "manual" property via QAPI for the backup-related jobs. As of this commit, this allows the management API to request the "concluded" and "dismiss" semantics for backup jobs. Signed-off-by: John Snow --- blockdev.c | 19

[Qemu-devel] [Bug 1673976] Re: linux-user clone() can't handle glibc posix_spawn() (causes locale-gen to assert)

2018-02-27 Thread Éric Hoffman
This should probably be put under 'glibc', since this is really an issue with that package, which is fixed by the way since Oct 2017. https://sourceware.org/git/?p=glibc.git;a=commit;h=fe05e1cb6d64dba6172249c79526f1e9af8f2bfd This should also be backported to 17.10 -- You received this bug noti

Re: [Qemu-devel] [PATCH 06/19] target/arm: Define init-svtor property for the reset secure VTOR value

2018-02-27 Thread Richard Henderson
On 02/20/2018 10:03 AM, Peter Maydell wrote: > +env->v7m.vecbase[M_REG_S] = cpu->init_svtor; Perhaps & ~0x3f here; that part of the field is RES0. That said, if the only setter of this property is within qemu code, and not from the command line, then I suppose it doesn't matter in practic

Re: [Qemu-devel] [RFC v4 20/21] iotests: test manual job dismissal

2018-02-27 Thread Eric Blake
On 02/23/2018 05:51 PM, John Snow wrote: Signed-off-by: John Snow --- tests/qemu-iotests/056 | 195 + tests/qemu-iotests/056.out | 4 +- 2 files changed, 197 insertions(+), 2 deletions(-) I'm not sure if this covers everything in the serie

Re: [Qemu-devel] [PATCH v3 00/29] postcopy+vhost-user/shared ram

2018-02-27 Thread Michael S. Tsirkin
On Tue, Feb 27, 2018 at 08:05:25PM +, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: > > On Fri, Feb 16, 2018 at 01:15:56PM +, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > Hi, > > > This is the first non-RFC ver

Re: [Qemu-devel] [RFC v4 21/21] blockjobs: add manual_mgmt option to transactions

2018-02-27 Thread Eric Blake
On 02/23/2018 05:51 PM, John Snow wrote: This allows us to easily force the option for all jobs belonging to a transaction to ensure consistency with how all those jobs will be handled. This is purely a convenience. Signed-off-by: John Snow --- +++ b/qapi/transaction.json @@ -79,7 +79,8 @@

Re: [Qemu-devel] [PATCH v3 15/29] vhost+postcopy: Send address back to qemu

2018-02-27 Thread Michael S. Tsirkin
On Tue, Feb 27, 2018 at 07:54:18PM +, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: > > On Fri, Feb 16, 2018 at 01:16:11PM +, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > We need a better way, but at the moment w

Re: [Qemu-devel] [PATCH 07/19] armv7m: Forward init-svtor property to CPU object

2018-02-27 Thread Richard Henderson
On 02/20/2018 10:03 AM, Peter Maydell wrote: > Create an "init-svtor" property on the armv7m container > object which we can forward to the CPU object. > > Signed-off-by: Peter Maydell > --- > include/hw/arm/armv7m.h | 2 ++ > hw/arm/armv7m.c | 6 ++ > 2 files changed, 8 insertions(+

Re: [Qemu-devel] [PATCH v3 0/9] enable numa configuration before machine_init() from QMP

2018-02-27 Thread Eric Blake
On 02/27/2018 10:36 AM, Igor Mammedov wrote: On Fri, 16 Feb 2018 13:37:12 +0100 Igor Mammedov wrote: Eric, Adding you to CC list (git send-mail somehow haven't noticed you in cover letter). Actually, I did get CC'd on the original cover letter, but you are reading the copy that hit the lis

Re: [Qemu-devel] [PATCH v3 3/9] CLI: add -preconfig option

2018-02-27 Thread Eric Blake
On 02/16/2018 06:37 AM, Igor Mammedov wrote: Option allows to pause QEMU at new RUN_STATE_PRECONFIG time, which would allow to configure QEMU from QMP before machine jumps into board initialization code machine_run_board_init(). Grammar suggestion: This option allows pausing QEMU in the new RU

Re: [Qemu-devel] [RFC v4 19/21] blockjobs: Expose manual property

2018-02-27 Thread John Snow
On 02/27/2018 03:16 PM, Eric Blake wrote: > On 02/23/2018 05:51 PM, John Snow wrote: >> Expose the "manual" property via QAPI for the backup-related jobs. >> As of this commit, this allows the management API to request the >> "concluded" and "dismiss" semantics for backup jobs. >> >> Signed-off-b

Re: [Qemu-devel] [RFC v4 20/21] iotests: test manual job dismissal

2018-02-27 Thread John Snow
On 02/27/2018 03:21 PM, Eric Blake wrote: > On 02/23/2018 05:51 PM, John Snow wrote: >> Signed-off-by: John Snow >> --- >>   tests/qemu-iotests/056 | 195 >> + >>   tests/qemu-iotests/056.out |   4 +- >>   2 files changed, 197 insertions(+), 2 delet

Re: [Qemu-devel] [RFC v4 15/21] blockjobs: add prepare callback

2018-02-27 Thread John Snow
On 02/27/2018 02:56 PM, Eric Blake wrote: > On 02/23/2018 05:51 PM, John Snow wrote: >> Some jobs upon finalization may need to perform some work that can >> still fail. If these jobs are part of a transaction, it's important >> that these callbacks fail the entire transaction. >> >> We allow for

Re: [Qemu-devel] [RFC v4 12/21] blockjobs: ensure abort is called for cancelled jobs

2018-02-27 Thread John Snow
On 02/27/2018 02:49 PM, Eric Blake wrote: > On 02/23/2018 05:51 PM, John Snow wrote: >> Presently, even if a job is canceled post-completion as a result of >> a failing peer in a transaction, it will still call .commit because >> nothing has updated or changed its return code. >> >> The reason wh

Re: [Qemu-devel] [PATCH 08/19] target/arm: Add Cortex-M33

2018-02-27 Thread Richard Henderson
On 02/20/2018 10:03 AM, Peter Maydell wrote: > Add a Cortex-M33 definition. The M33 is an M profile CPU > which implements the ARM v8M architecture, including the > M profile Security Extension. > > Signed-off-by: Peter Maydell > --- > target/arm/cpu.c | 31 +++ > 1 f

Re: [Qemu-devel] [RFC v4 16/21] blockjobs: add waiting status

2018-02-27 Thread John Snow
On 02/27/2018 03:00 PM, Eric Blake wrote: > On 02/23/2018 05:51 PM, John Snow wrote: >> For jobs that are stuck waiting on others in a transaction, it would >> be nice to know that they are no longer "running" in that sense, but >> instead are waiting on other jobs in the transaction. >> >> Jobs

Re: [Qemu-devel] [PATCH 10/19] include/hw/or-irq.h: Add missing include guard

2018-02-27 Thread Richard Henderson
On 02/20/2018 10:03 AM, Peter Maydell wrote: > The or-irq.h header file is missing the customary guard against > multiple inclusion, which means compilation fails if it gets > included twice. Fix the omission. > > Signed-off-by: Peter Maydell > --- > include/hw/or-irq.h | 5 + > 1 file chang

Re: [Qemu-devel] [PATCH 09/19] hw/misc/unimp: Move struct to header file

2018-02-27 Thread Richard Henderson
On 02/20/2018 10:03 AM, Peter Maydell wrote: > Move the definition of the struct for the unimplemented-device > from unimp.c to unimp.h, so that users can embed the struct > in their own device structs if they prefer. > > Signed-off-by: Peter Maydell > --- > include/hw/misc/unimp.h | 10

Re: [Qemu-devel] [PATCH 11/19] qdev: Add new qdev_init_gpio_in_named_with_opaque()

2018-02-27 Thread Richard Henderson
On 02/20/2018 10:03 AM, Peter Maydell wrote: > The function qdev_init_gpio_in_named() passes the DeviceState pointer > as the opaque data pointor for the irq handler function. Usually > this is what you want, but in some cases it would be helpful to use > some other data pointer. > > Add a new fu

Re: [Qemu-devel] [RFC v4 17/21] blockjobs: add PENDING status and event

2018-02-27 Thread John Snow
On 02/27/2018 03:05 PM, Eric Blake wrote: > On 02/23/2018 05:51 PM, John Snow wrote: >> For jobs utilizing the new manual workflow, we intend to prohibit >> them from modifying the block graph until the management layer provides >> an explicit ACK via block-job-finalize to move the process forwar

Re: [Qemu-devel] [PATCH 12/19] hw/core/split-irq: Device that splits IRQ lines

2018-02-27 Thread Richard Henderson
On 02/20/2018 10:03 AM, Peter Maydell wrote: > In some board or SoC models it is necessary to split a qemu_irq line > so that one input can feed multiple outputs. We currently have > qemu_irq_split() for this, but that has several deficiencies: > * it can only handle splitting a line into two >

Re: [Qemu-devel] [RFC v4 00/21] blockjobs: add explicit job management

2018-02-27 Thread John Snow
On 02/25/2018 06:25 PM, no-re...@patchew.org wrote: > CC scsi/qemu-pr-helper.o > /var/tmp/patchew-tester-tmp-9ukz0kme/src/blockjob.c: In function > ‘block_job_txn_apply.isra.8’: > /var/tmp/patchew-tester-tmp-9ukz0kme/src/blockjob.c:511:5: error: ‘rc’ may be > used uninitialized in this f

Re: [Qemu-devel] [RFC v4 00/21] blockjobs: add explicit job management

2018-02-27 Thread John Snow
On 02/24/2018 09:31 AM, no-re...@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series > Message-id: 20180223235142.21501-1-js...@redhat.com > Subject: [Qemu-devel] [RFC v4 00/21] blockjobs: add explicit job

Re: [Qemu-devel] [PATCH 13/19] hw/misc/mps2-fpgaio: FPGA control block for MPS2 AN505

2018-02-27 Thread Richard Henderson
On 02/20/2018 10:03 AM, Peter Maydell wrote: > The MPS2 AN505 FPGA image includes a "FPGA control block" > which is a small set of registers handling LEDs, buttons > and some counters. > > Signed-off-by: Peter Maydell > --- > hw/misc/Makefile.objs | 1 + > include/hw/misc/mps2-fpgaio

[Qemu-devel] [Bug 1673976] Re: linux-user clone() can't handle glibc posix_spawn() (causes locale-gen to assert)

2018-02-27 Thread Peter Maydell
That glibc change has caused the assert to go away, but QEMU's spawn(CLONE_VFORK) still does not have the "always waits for child" semantics that glibc has assumed since glibc commit 4b4d4056bb154. The child and the parent will end up racing each other, and the child will never be able to write to

Re: [Qemu-devel] [PATCH 14/19] hw/misc/tz-ppc: Model TrustZone peripheral protection controller

2018-02-27 Thread Richard Henderson
On 02/20/2018 10:03 AM, Peter Maydell wrote: > Add a model of the TrustZone peripheral protection controller (PPC), > which is used to gate transactions to non-TZ-aware peripherals so > that secure software can configure them to not be accessible to > non-secure software. > > Signed-off-by: Peter

Re: [Qemu-devel] [PATCH 15/19] hw/misc/iotkit-secctl: Arm IoT Kit security controller initial skeleton

2018-02-27 Thread Richard Henderson
On 02/20/2018 10:03 AM, Peter Maydell wrote: > +r >>= 8 * (addr & 3); > +r &= (1 << (size * 8)) - 1; extract32(r, (addr & 3) * 8, size * 8) ? Otherwise, Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 16/19] hw/misc/iotkit-secctl: Add handling for PPCs

2018-02-27 Thread Richard Henderson
On 02/20/2018 10:03 AM, Peter Maydell wrote: > The IoTKit Security Controller includes various registers > that expose to software the controls for the Peripheral > Protection Controllers in the system. Implement these. > > Signed-off-by: Peter Maydell > --- > include/hw/misc/iotkit-secctl.h |

Re: [Qemu-devel] [RFC v4 19/21] blockjobs: Expose manual property

2018-02-27 Thread John Snow
On 02/27/2018 03:16 PM, Eric Blake wrote: > On 02/23/2018 05:51 PM, John Snow wrote: >> Expose the "manual" property via QAPI for the backup-related jobs. >> As of this commit, this allows the management API to request the >> "concluded" and "dismiss" semantics for backup jobs. >> >> Signed-off-b

Re: [Qemu-devel] [PATCH] hw/s390x/ipl: Bail out if the network bootloader can not be found

2018-02-27 Thread Farhan Ali
On 02/27/2018 02:11 PM, Thomas Huth wrote: On 27.02.2018 18:26, Farhan Ali wrote: On 02/27/2018 05:16 AM, Viktor Mihajlovski wrote: On 27.02.2018 11:05, Thomas Huth wrote: If QEMU fails to load 's390-netboot.img', the guest firmware currently loops forever and just floods the console with

<    1   2   3   4   5   >