Re: [Qemu-devel] [PATCH] net: Move the toeplitz functions from checksum.h to net_rx_pkt.c

2018-02-27 Thread Thomas Huth
On 27.02.2018 08:55, Jason Wang wrote: > > > On 2018年02月22日 17:04, Thomas Huth wrote: >> The functions are only used in this single .c file, so there is >> no need to put all this code in a header that is included from >> multiple places. >> >> Signed-off-by: Thomas Huth >> --- >>   hw/net/net_rx

[Qemu-devel] [PULL 12/12] curses: build as ui module

2018-02-27 Thread Gerd Hoffmann
Also drop curses libs from libs_softmmu. Add CURSES_{CFLAGS,LIBS} variables so we can use them for linking the curses module. Shared library dependencies dropped from qemu-system-*: libncursesw.so.5 => /lib64/libncursesw.so.5 libtinfo.so.5 => /lib64/libtinfo.so.5 Signed-off-by: Gerd Hoffmann M

[Qemu-devel] [PULL 10/12] sdl: build as ui module

2018-02-27 Thread Gerd Hoffmann
Shared library dependencies dropped from qemu-system-*: libSDL2-2.0.so.0 => /lib64/libSDL2-2.0.so.0 Signed-off-by: Gerd Hoffmann Message-id: 20180221131537.31341-11-kra...@redhat.com --- configure| 2 +- Makefile.objs| 1 + ui/Makefile.objs | 3 ++- 3 files changed, 4 insertions(+),

[Qemu-devel] [PULL 03/12] cocoa: switch over to new display registry

2018-02-27 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Message-id: 20180221131537.31341-4-kra...@redhat.com --- include/ui/console.h | 12 vl.c | 3 --- ui/cocoa.m | 14 +- 3 files changed, 13 insertions(+), 16 deletions(-) diff --git a/include/ui/console.h b/include/ui

[Qemu-devel] [PULL 01/12] console: add qemu display registry, add gtk

2018-02-27 Thread Gerd Hoffmann
Add a registry for user interfaces. Add qemu_display_init and qemu_display_early_init helper functions for display initialization. Hook up gtk ui as first user. Signed-off-by: Gerd Hoffmann Message-id: 20180221131537.31341-2-kra...@redhat.com --- include/ui/console.h | 32 -

[Qemu-devel] [PULL 09/12] configure: opengl doesn't depend on x11

2018-02-27 Thread Gerd Hoffmann
So remove x11 from pkg-config check and don't add x11 cflags/libs to opengl cflags/libs. Signed-off-by: Gerd Hoffmann Message-id: 20180221131537.31341-10-kra...@redhat.com --- configure | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure b/configure index f6dc1c92

[Qemu-devel] [PULL 00/12] Ui 20180227 patches

2018-02-27 Thread Gerd Hoffmann
The following changes since commit 0a773d55ac76c5aa89ed9187a3bc5af8c5c2a6d0: maintainers: Add myself as a OpenBSD maintainer (2018-02-23 12:05:07 +) are available in the git repository at: git://git.kraxel.org/qemu tags/ui-20180227-pull-request for you to fetch changes up to

[Qemu-devel] [PULL 08/12] configure: add X11 vars to config-host.mak

2018-02-27 Thread Gerd Hoffmann
Simplifies handling the X11 dependency, also makes ui/Makefile.objs more readable. Signed-off-by: Gerd Hoffmann Message-id: 20180221131537.31341-9-kra...@redhat.com --- configure| 10 -- ui/Makefile.objs | 5 - 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/

[Qemu-devel] [PULL 05/12] egl-headless: switch over to new display registry

2018-02-27 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Message-id: 20180221131537.31341-6-kra...@redhat.com --- include/ui/console.h | 3 --- ui/egl-headless.c| 20 +++- vl.c | 12 3 files changed, 19 insertions(+), 16 deletions(-) diff --git a/include/ui/console.h b/incl

[Qemu-devel] [PULL 04/12] curses: switch over to new display registry

2018-02-27 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Message-id: 20180221131537.31341-5-kra...@redhat.com --- include/ui/console.h | 12 ui/curses.c | 14 +- vl.c | 17 ++--- 3 files changed, 15 insertions(+), 28 deletions(-) diff --git a/include/ui/console.

[Qemu-devel] [PULL 06/12] console: add and use qemu_display_find_default

2018-02-27 Thread Gerd Hoffmann
Using the new display registry instead of #ifdefs in vl.c. Signed-off-by: Gerd Hoffmann Message-id: 20180221131537.31341-7-kra...@redhat.com --- include/ui/console.h | 1 + ui/console.c | 19 +++ vl.c | 15 +-- 3 files changed, 25 insertions(+

[Qemu-devel] [PULL 02/12] sdl: switch over to new display registry

2018-02-27 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Message-id: 20180221131537.31341-3-kra...@redhat.com --- include/ui/console.h | 19 --- ui/sdl.c | 24 +--- ui/sdl2.c| 17 +++-- vl.c | 15 +-- 4 files changed, 29 inse

[Qemu-devel] [PULL 11/12] gtk: build as ui module

2018-02-27 Thread Gerd Hoffmann
Also drop gtk and vte libs from libs_softmmu, so the libs are not pulled in unless the gtk module actually gets loaded. Shared library dependencies dropped from qemu-system-*: libEGL.so.1 => /lib64/libEGL.so.1 libGL.so.1 => /lib64/libGL.so.1 libXcomposite.so.1 => /lib64/libXcomposite.so.1 libXcur

[Qemu-devel] [PULL 07/12] console: add ui module loading support

2018-02-27 Thread Gerd Hoffmann
If a requested user interface is not available, try loading it as module, simliar to block layer modules. Needed to keep things working when followup patches start to build user interfaces as modules. Signed-off-by: Gerd Hoffmann Message-id: 20180221131537.31341-8-kra...@redhat.com --- include/

Re: [Qemu-devel] [PATCH v2 06/16] block/mirror: Use CoQueue to wait on in-flight ops

2018-02-27 Thread Fam Zheng
On Mon, 01/22 23:07, Max Reitz wrote: > qemu_iovec_destroy(&op->qiov); > -g_free(op); > > -if (s->waiting_for_io) { > -qemu_coroutine_enter(s->common.co); > -} > +qemu_co_queue_restart_all(&op->waiting_requests); > +g_free(op); OK, this answers my question to pat

Re: [Qemu-devel] [PATCH V6 4/4] tests: Add migration test for aarch64

2018-02-27 Thread Andrew Jones
On Mon, Feb 26, 2018 at 12:17:58PM -0600, Wei Huang wrote: > This patch adds migration test support for aarch64. The test code, which > implements the same functionality as x86, is booted as a kernel in qemu. > Here are the design choices we make for aarch64: > > * We choose this -kernel approach

[Qemu-devel] [PULL 5/5] usb-mtp: Advertise SendObjectInfo for write support

2018-02-27 Thread Gerd Hoffmann
From: Bandan Das This patch implements a dummy ObjectInfo structure so that it's easy to typecast the incoming data. If the metadata is valid, write_pending is set. Also, the incoming filename is utf-16, so, instead of depending on external libraries, just implement a simple function to get the f

[Qemu-devel] [PULL 4/5] usb-mtp: Introduce write support for MTP objects

2018-02-27 Thread Gerd Hoffmann
From: Bandan Das Allow write operations on behalf of the initiator. The precursor to write is the sending of the write metadata that consists of the ObjectInfo dataset. This patch introduces a flag that is set when the responder is ready to receive write data based on a previous SendObjectInfo op

[Qemu-devel] [PULL 0/5] Usb 20180227 patches

2018-02-27 Thread Gerd Hoffmann
The following changes since commit 0a773d55ac76c5aa89ed9187a3bc5af8c5c2a6d0: maintainers: Add myself as a OpenBSD maintainer (2018-02-23 12:05:07 +) are available in the git repository at: git://git.kraxel.org/qemu tags/usb-20180227-pull-request for you to fetch changes up to

[Qemu-devel] [PULL 3/5] usb-mtp: Support delete of mtp objects

2018-02-27 Thread Gerd Hoffmann
From: Bandan Das Write of existing objects by the initiator is acheived by making a temporary buffer with the new changes, deleting the old file and then writing a new file with the same name. Also, add a "readonly" property which needs to be set to false for deletion to work. Signed-off-by: Ba

[Qemu-devel] [PULL 2/5] usb-mtp: print parent path in IN_IGNORED trace fn

2018-02-27 Thread Gerd Hoffmann
From: Bandan Das Fix a possible null dereference when deleting a folder and its contents. An ignored event might be received for its contents after the parent folder is deleted which will return a null object. Signed-off-by: Bandan Das Message-id: 20180223164829.29683-3-...@redhat.com Signed-of

[Qemu-devel] [PULL 1/5] usb-mtp: Add one more argument when building results

2018-02-27 Thread Gerd Hoffmann
From: Bandan Das The response to a SendObjectInfo consists of the storageid, parent obejct handle and the handle reserved for the new incoming object Signed-off-by: Bandan Das Message-id: 20180223164829.29683-2-...@redhat.com Signed-off-by: Gerd Hoffmann --- hw/usb/dev-mtp.c | 50

Re: [Qemu-devel] [PATCH v2 1/2] xilinx_spips: Enable only two slaves when reading/writing with stripe

2018-02-27 Thread francisco iglesias
On Tuesday, 27 February 2018, Alistair Francis wrote: > On Fri, Feb 23, 2018 at 3:22 PM, Francisco Iglesias > wrote: > > Assert only the lower cs on bus 0 and upper cs on bus 1 when both buses > and > > chip selects are enabled (e.g reading/writing with stripe). > > > > Signed-off-by: Francisco

[Qemu-devel] [PATCH v5 4/7] vfio/common: cleanup in vfio_region_finalize

2018-02-27 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/vfio/common.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index f895e3c335..6a8203a532 100644 --- a/hw/vfio/common.c +++ b/hw/vfio/common.c @@ -858,6 +858,13 @@ void vfio_region_finalize(VFIORegion *region)

[Qemu-devel] [PATCH v5 0/7] vfio: add display support

2018-02-27 Thread Gerd Hoffmann
This series adds support for a vgpu display to the qemu vfio code. v5: - rebase to latest master - drop DeviceState->hotpluggable patch, use separate vfio-pci-display device instead so we can use DeviceClass->hotpluggable. - add vfio dma-buf patch. Right now this can be tested with '-displa

[Qemu-devel] [PATCH v5 3/7] ui/pixman: add qemu_drm_format_to_pixman()

2018-02-27 Thread Gerd Hoffmann
Map drm fourcc codes to pixman formats. Signed-off-by: Gerd Hoffmann --- include/ui/qemu-pixman.h | 5 + ui/qemu-pixman.c | 22 ++ 2 files changed, 27 insertions(+) diff --git a/include/ui/qemu-pixman.h b/include/ui/qemu-pixman.h index 4a67e01232..b7c82d17fc 100

[Qemu-devel] [PATCH v5 2/7] standard-headers: add drm/drm_fourcc.h

2018-02-27 Thread Gerd Hoffmann
So we can use the drm fourcc codes without a dependency on libdrm-devel. Signed-off-by: Gerd Hoffmann --- include/standard-headers/drm/drm_fourcc.h | 411 ++ scripts/update-linux-headers.sh | 4 + 2 files changed, 415 insertions(+) create mode 100644 incl

[Qemu-devel] [PATCH v5 7/7] vfio/display: adding dmabuf support

2018-02-27 Thread Gerd Hoffmann
Wire up dmabuf-based display. Signed-off-by: Gerd Hoffmann --- include/hw/vfio/vfio-common.h | 14 hw/vfio/display.c | 147 +- 2 files changed, 159 insertions(+), 2 deletions(-) diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfi

[Qemu-devel] [PATCH v5 6/7] vfio/display: adding region support

2018-02-27 Thread Gerd Hoffmann
Wire up region-based display. Signed-off-by: Gerd Hoffmann --- hw/vfio/pci.h | 1 + include/hw/vfio/vfio-common.h | 8 hw/vfio/display.c | 100 +- 3 files changed, 107 insertions(+), 2 deletions(-) diff --git a/hw/vfio

[Qemu-devel] [PATCH v5 1/7] linux-headers: update to 4.16-rc1

2018-02-27 Thread Gerd Hoffmann
s390 has splitted syscall numbers into unistd_{32,64}.h files, so update scripts/update-linux-headers.sh accordingly. Also add a rewrite from __BITS_PER_LONG to HOST_LONG_BITS for linux/input.h Signed-off-by: Gerd Hoffmann --- include/standard-headers/linux/input-event-codes.h | 1 + include/

[Qemu-devel] [PATCH v5 5/7] vfio/display: core & wireup

2018-02-27 Thread Gerd Hoffmann
Infrastructure for display support. Adds a new vfio-pci-display device, which will export a display and is not hotpluggable. Signed-off-by: Gerd Hoffmann --- hw/vfio/pci.h | 3 +++ hw/vfio/display.c | 47 +++ hw/vfio/pci.c | 30 ++

Re: [Qemu-devel] [PATCH v2 10/16] hbitmap: Add @advance param to hbitmap_iter_next()

2018-02-27 Thread Fam Zheng
On Mon, 01/22 23:08, Max Reitz wrote: > diff --git a/tests/test-hbitmap.c b/tests/test-hbitmap.c > index 9091c639b3..2a2aa5bd43 100644 > --- a/tests/test-hbitmap.c > +++ b/tests/test-hbitmap.c > @@ -46,7 +46,7 @@ static void hbitmap_test_check(TestHBitmapData *data, > > i = first; > for

Re: [Qemu-devel] QEMU GSoC 2018 Project Idea (Apply polling to QEMU NVMe)

2018-02-27 Thread Huaicheng Li
Hi Paolo, Slightly rephrased: > (1) add shadow doorbell buffer and ioeventfd support into QEMU NVMe > emulation, which will reduce # of VM-exits and make them less expensive > (reduce VCPU latency. > (2) add iothread support to QEMU NVMe emulation. This can also be used > to eliminate VM-exits be

Re: [Qemu-devel] [PATCH v2 11/16] block/dirty-bitmap: Add bdrv_dirty_iter_next_area

2018-02-27 Thread Fam Zheng
On Mon, 01/22 23:08, Max Reitz wrote: > This new function allows to look for a consecutively dirty area in a > dirty bitmap. > > Signed-off-by: Max Reitz > --- > include/block/dirty-bitmap.h | 2 ++ > block/dirty-bitmap.c | 51 > > 2 files c

Re: [Qemu-devel] [qemu-s390x] [PULL-for-s390x 06/14] s390-ccw: parse and set boot menu options

2018-02-27 Thread Cornelia Huck
On Mon, 26 Feb 2018 14:44:45 -0500 "Collin L. Walling" wrote: > On 02/26/2018 02:29 PM, Collin L. Walling wrote: > > On 02/26/2018 01:48 PM, Cornelia Huck wrote: > >> On Mon, 26 Feb 2018 11:42:29 +0100 > >> Thomas Huth wrote: > >> > >> [...] > >> > >>>   3 files changed, 66 insertions(+), 4

Re: [Qemu-devel] [PATCH v2 12/16] block/mirror: Distinguish active from passive ops

2018-02-27 Thread Fam Zheng
On Mon, 01/22 23:08, Max Reitz wrote: > Currently, the mirror block job only knows passive operations. But once > we introduce active writes, we need to distinguish between the two; for > example, mirror_wait_for_free_in_flight_slot() should wait for a passive > operation because active writes wil

[Qemu-devel] [Bug 1752026] Re: Ubuntu18.04:POWER9:DD2.2 - Unable to start a KVM guest with default machine type(pseries-bionic) complaining "KVM implementation does not support Transactional Memory, t

2018-02-27 Thread Andrew Cloke
** Also affects: qemu Importance: Undecided Status: New ** No longer affects: qemu ** Also affects: qemu Importance: Undecided Status: New ** No longer affects: qemu ** Also affects: ubuntu-power-systems Importance: Undecided Status: New ** Changed in: ubuntu-powe

Re: [Qemu-devel] [qemu-s390x] [PULL-for-s390x 06/14] s390-ccw: parse and set boot menu options

2018-02-27 Thread Thomas Huth
On 27.02.2018 10:12, Cornelia Huck wrote: > On Mon, 26 Feb 2018 14:44:45 -0500 > "Collin L. Walling" wrote: > >> On 02/26/2018 02:29 PM, Collin L. Walling wrote: >>> On 02/26/2018 01:48 PM, Cornelia Huck wrote: On Mon, 26 Feb 2018 11:42:29 +0100 Thomas Huth wrote: [...] > +    sw

Re: [Qemu-devel] [PULL-for-s390x 00/14] s390-ccw firmware update

2018-02-27 Thread Cornelia Huck
On Mon, 26 Feb 2018 11:42:23 +0100 Thomas Huth wrote: > Hi Cornelia! > > The following changes since commit 0a773d55ac76c5aa89ed9187a3bc5af8c5c2a6d0: > > maintainers: Add myself as a OpenBSD maintainer (2018-02-23 12:05:07 +) > > are available in the git repository at: > > https://gi

Re: [Qemu-devel] [PATCH v2 14/16] block/mirror: Add active mirroring

2018-02-27 Thread Fam Zheng
On Mon, 01/22 23:08, Max Reitz wrote: > @@ -1151,7 +1285,48 @@ static int coroutine_fn > bdrv_mirror_top_preadv(BlockDriverState *bs, > static int coroutine_fn bdrv_mirror_top_pwritev(BlockDriverState *bs, > uint64_t offset, uint64_t bytes, QEMUIOVector *qiov, int flags) > { > -return b

Re: [Qemu-devel] [PATCH v2 15/16] block/mirror: Add copy mode QAPI interface

2018-02-27 Thread Fam Zheng
On Mon, 01/22 23:08, Max Reitz wrote: > This patch allows the user to specify whether to use active or only > passive mode for mirror block jobs. Currently, this setting will remain I think you want s/passive/background/ in the whole patch. > constant for the duration of the entire block job. >

[Qemu-devel] [PATCH v7 01/22] cpu-exec: fix exception_index handling

2018-02-27 Thread Pavel Dovgalyuk
Function cpu_handle_interrupt calls cc->cpu_exec_interrupt to process pending hardware interrupts. Under the hood cpu_exec_interrupt uses cpu->exception_index to pass information to the internal function which is usually common for exception and interrupt processing. But this value is not reset aft

[Qemu-devel] [PATCH v7 03/22] blkreplay: create temporary overlay for underlaying devices

2018-02-27 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch allows using '-snapshot' behavior in record/replay mode. blkreplay layer creates temporary overlays on top of underlaying disk images. It is needed, because creating an overlay over blkreplay breaks the determinism. This patch creates similar temporary overlay (wh

[Qemu-devel] [PATCH v7 05/22] replay: fix processing async events

2018-02-27 Thread Pavel Dovgalyuk
Asynchronous events saved at checkpoints may invoke callbacks when processed. These callbacks may also generate/read new events (e.g. clock reads). Therefore event processing flag must be reset before callback invocation. Signed-off-by: Pavel Dovgalyuk Acked-by: Paolo Bonzini --- replay/replay-

[Qemu-devel] [ PATCH v7 00/22] replay additions

2018-02-27 Thread Pavel Dovgalyuk
This set of patches moves replay lock upper in the function call tree. Now replay lock functions similar to BQL in older version and allows deterministic execution of the threads in icount mode. It is also fixes some vmstate creation (and loading) issues in record/replay modes: - VM start/stop fix

[Qemu-devel] [PATCH v7 11/22] replay/replay-internal.c: track holding of replay_lock

2018-02-27 Thread Pavel Dovgalyuk
From: Alex Bennée This is modelled after the iothread mutex lock. We keep a TLS flag to indicate when that thread has acquired the lock and assert we don't double-lock or release when we shouldn't have. Signed-off-by: Alex Bennée Tested-by: Pavel Dovgalyuk --- replay/replay-internal.c | 11

[Qemu-devel] [PATCH v7 06/22] replay: fixed replay_enable_events

2018-02-27 Thread Pavel Dovgalyuk
This patch fixes assignment to internal events_enabled variable. Now it is set only in record/replay mode. This affects the behavior of the external functions that check this flag. Signed-off-by: Pavel Dovgalyuk Acked-by: Paolo Bonzini --- replay/replay-events.c |8 +--- 1 file changed,

[Qemu-devel] [PATCH v7 04/22] replay: disable default snapshot for record/replay

2018-02-27 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch disables setting '-snapshot' option on by default in record/replay mode. This is needed for creating vmstates in record and replay modes. Signed-off-by: Pavel Dovgalyuk --- vl.c |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/vl.c

[Qemu-devel] [PATCH v7 02/22] block: implement bdrv_snapshot_goto for blkreplay

2018-02-27 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch enables making snapshots with blkreplay used in block devices. This function is required to make bdrv_snapshot_goto without calling .bdrv_open which is not implemented. Signed-off-by: Pavel Dovgalyuk --- block/blkreplay.c |8 1 file changed, 8 inse

[Qemu-devel] [PATCH v7 17/22] scripts/replay-dump.py: replay log dumper

2018-02-27 Thread Pavel Dovgalyuk
From: Alex Bennée This script is a debugging tool for looking through the contents of a replay log file. It is incomplete but should fail gracefully at events it doesn't understand. It currently understands two different log formats as the audio record/replay support was merged during since MTTC

[Qemu-devel] [PATCH v7 07/22] replay: fix save/load vm for non-empty queue

2018-02-27 Thread Pavel Dovgalyuk
This patch does not allows saving/loading vmstate when replay events queue is not empty. There is no reliable way to save events queue, because it describes internal coroutine state. Therefore saving and loading operations should be deferred to another record/replay step. Signed-off-by: Pavel Dovg

[Qemu-devel] [PATCH v7 08/22] replay: added replay log format description

2018-02-27 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch adds description of the replay log file format into the docs/replay.txt. Signed-off-by: Pavel Dovgalyuk Acked-by: Paolo Bonzini --- docs/replay.txt | 69 +++ 1 file changed, 69 insertions(+) diff --git a/d

Re: [Qemu-devel] [PATCH v2 00/16] block/mirror: Add active-sync mirroring

2018-02-27 Thread Fam Zheng
On Sat, 02/24 16:42, Max Reitz wrote: > Pïng Looks good in general. I've left some small questions though. Fam

[Qemu-devel] [PATCH v7 09/22] replay: save prior value of the host clock

2018-02-27 Thread Pavel Dovgalyuk
This patch adds saving/restoring of the host clock field 'last'. It is used in host clock calculation and therefore clock may become incorrect when using restored vmstate. Signed-off-by: Pavel Dovgalyuk Acked-by: Paolo Bonzini --- include/qemu/timer.h | 14 ++ replay/replay-in

[Qemu-devel] [PATCH v7 13/22] replay: push replay_mutex_lock up the call tree

2018-02-27 Thread Pavel Dovgalyuk
From: Alex Bennée Now instead of using the replay_lock to guard the output of the log we now use it to protect the whole execution section. This replaces what the BQL used to do when it was held during TCG execution. We also introduce some rules for locking order - mainly that you cannot take th

[Qemu-devel] [PATCH v7 18/22] replay: don't process async events when warping the clock

2018-02-27 Thread Pavel Dovgalyuk
Virtual clock is warped from iothread and vcpu thread. When the hardware events associated with warp checkpoint, then interrupt delivering may be non-deterministic if checkpoint is processed in different threads in record and replay. This patch disables event processing for clock warp checkpoint an

[Qemu-devel] [PATCH v7 14/22] replay: don't destroy mutex at exit

2018-02-27 Thread Pavel Dovgalyuk
Replay mutex is held by vCPU thread and destroy function is called from atexit of the main thread. Therefore we cannot destroy it safely. Signed-off-by: Pavel Dovgalyuk Acked-by: Paolo Bonzini --- replay/replay.c |1 - 1 file changed, 1 deletion(-) diff --git a/replay/replay.c b/replay/rep

[Qemu-devel] [PATCH v7 22/22] tcg: fix cpu_io_recompile

2018-02-27 Thread Pavel Dovgalyuk
cpu_io_recompile() function was broken by the commit 9b990ee5a3cc6aa38f81266fb0c6ef37a36c45b9. Instead of regenerating the block starting from PC of the original block, it just set the instruction counter for TCG. In most cases this was unnoticed, but in icount mode there was an exception for incor

[Qemu-devel] [PATCH v7 10/22] replay/replay.c: bump REPLAY_VERSION again

2018-02-27 Thread Pavel Dovgalyuk
From: Alex Bennée This time commit 802f045a5f61b781df55e4492d896b4d20503ba7 broke the replay file format. Also add a comment about this to replay-internal.h. Signed-off-by: Alex Bennée Reviewed-off-by: Pavel Dovgalyuk Acked-by: Paolo Bonzini --- replay/replay-internal.h |2 +- replay/rep

[Qemu-devel] [PATCH v7 12/22] replay: make locking visible outside replay code

2018-02-27 Thread Pavel Dovgalyuk
From: Alex Bennée The replay_mutex_lock/unlock/locked functions are now going to be used for ensuring lock-step behaviour between the two threads. Make them public API functions and also provide stubs for non-QEMU builds on common paths. Signed-off-by: Alex Bennée Signed-off-by: Pavel Dovgalyuk

[Qemu-devel] [PATCH v7 20/22] replay: don't drain/flush bdrv queue while RR is working

2018-02-27 Thread Pavel Dovgalyuk
In record/replay mode bdrv queue is controlled by replay mechanism. It does not allow saving or loading the snapshots when bdrv queue is not empty. Stopping the VM is not blocked by nonempty queue, but flushing the queue is still impossible there, because it may cause deadlocks in replay mode. This

[Qemu-devel] [PATCH] hw/s390x/ipl: Bail out if the network bootloader can not be found

2018-02-27 Thread Thomas Huth
If QEMU fails to load 's390-netboot.img', the guest firmware currently loops forever and just floods the console with "Network boot device detected" messages. The code in ipl.c apparently already tried to stop the VM with vm_stop() in this case, but this is in vain since the run state is later rese

Re: [Qemu-devel] [PATCH v2 3/3] virtio-balloon: add a timer to limit the free page report waiting time

2018-02-27 Thread Wei Wang
On 02/27/2018 08:50 AM, Michael S. Tsirkin wrote: On Mon, Feb 26, 2018 at 12:35:31PM +0800, Wei Wang wrote: On 02/09/2018 08:15 PM, Dr. David Alan Gilbert wrote: * Wei Wang (wei.w.w...@intel.com) wrote: I think all this is premature optimization. It is not at all clear that anything is gained

[Qemu-devel] [PATCH v7 15/22] replay: check return values of fwrite

2018-02-27 Thread Pavel Dovgalyuk
This patch adds error reporting when fwrite cannot completely save the buffer to the file. Signed-off-by: Pavel Dovgalyuk -- v3: also check putc() return value --- replay/replay-internal.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/replay/replay-in

[Qemu-devel] [PATCH v7 21/22] replay: update documentation

2018-02-27 Thread Pavel Dovgalyuk
This patch clarifies the description of the record/replay feature in docs/replay.txt Signed-off-by: Pavel Dovgalyuk --- docs/replay.txt | 72 --- 1 file changed, 52 insertions(+), 20 deletions(-) diff --git a/docs/replay.txt b/docs/replay.tx

Re: [Qemu-devel] [PATCH v3 24/29] vhost-user: Add VHOST_USER_POSTCOPY_END message

2018-02-27 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Fri, Feb 16, 2018 at 01:16:20PM +, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > This message is sent just before the end of postcopy to get the > > client to stop using userfault since we wont respond to any

[Qemu-devel] [PATCH v7 16/22] replay: avoid recursive call of checkpoints

2018-02-27 Thread Pavel Dovgalyuk
This patch adds a flag which denies recursive call of replay_checkpoint function. Checkpoints may be accompanied by the hardware events. When event is processed, virtual device may invoke timer modification functions that also invoke the checkpoint function. This leads to infinite loop. Signed-off

Re: [Qemu-devel] [Qemu-arm] [PATCH 2/3] hw/sii9022: Add support for Silicon Image SII9022

2018-02-27 Thread Peter Maydell
On 27 February 2018 at 07:41, Linus Walleij wrote: > On Sat, Feb 17, 2018 at 7:32 PM, Philippe Mathieu-Daudé > wrote: > >> [Me] >>> +#define DEBUG_SII9022 0 >>> + >>> +#define DPRINTF(fmt, ...) \ >>> +do { \ >>> +if (DEBUG_SII9022) { \ >>> +printf("sii9022: " fmt, ## __VA

[Qemu-devel] [PATCH v7 19/22] replay: save vmstate of the asynchronous events

2018-02-27 Thread Pavel Dovgalyuk
This patch fixes saving and loading the snapshots in the replay mode. It is required for the snapshots created in the moment when the header of the asynchronous event is read. This information was not saved in the snapshot. After loading the vmstate replay continued with the file offset passed the

Re: [Qemu-devel] [PATCH] i386: Allow monitor / mwait cpuid override

2018-02-27 Thread Gonglei (Arei)
Hi all, Guests could achive good performance in 'Message Passing Workloads' scenarios when knowing the X86_FEATURE_MWAIT feature which is presented by qemu. the reason is that after knowing that feature, the guest could use mwait method, which saves VMEXIT, to do idle, and achives high perfor

Re: [Qemu-devel] [PULL v1 0/2] Merge tpm 2018/02/21 v1

2018-02-27 Thread Peter Maydell
On 23 February 2018 at 21:39, Stefan Berger wrote: > This patch series adds a test case for the TPM TIS interface. > >Stefan > > The following changes since commit a6e0344fa0e09413324835ae122c4cadd7890231: > > Merge remote-tracking branch 'remotes/kraxel/tags/ui-20180220-pull-request' > int

[Qemu-devel] [PATCH v2] numa: we don't implement NUMA for s390x

2018-02-27 Thread David Hildenbrand
Right now it is possible to crash QEMU for s390x by providing e.g. -numa node,nodeid=0,cpus=0-1 Problem is, that numa.c uses mc->cpu_index_to_instance_props as an indicator whether NUMA is supported by a machine type. We don't implement NUMA for s390x ("topology") yet. However we need mc->cpu_

Re: [Qemu-devel] [PATCH] hw/s390x/ipl: Bail out if the network bootloader can not be found

2018-02-27 Thread David Hildenbrand
On 27.02.2018 11:05, Thomas Huth wrote: > If QEMU fails to load 's390-netboot.img', the guest firmware currently > loops forever and just floods the console with "Network boot device > detected" messages. The code in ipl.c apparently already tried to stop > the VM with vm_stop() in this case, but t

Re: [Qemu-devel] [PATCH] hw/s390x/ipl: Bail out if the network bootloader can not be found

2018-02-27 Thread Viktor Mihajlovski
On 27.02.2018 11:05, Thomas Huth wrote: > If QEMU fails to load 's390-netboot.img', the guest firmware currently > loops forever and just floods the console with "Network boot device > detected" messages. The code in ipl.c apparently already tried to stop > the VM with vm_stop() in this case, but t

Re: [Qemu-devel] [Qemu-arm] [PATCH 2/3] hw/sii9022: Add support for Silicon Image SII9022

2018-02-27 Thread Linus Walleij
On Tue, Feb 27, 2018 at 11:09 AM, Peter Maydell wrote: > On 27 February 2018 at 07:41, Linus Walleij wrote: >> On Sat, Feb 17, 2018 at 7:32 PM, Philippe Mathieu-Daudé >> wrote: >> >>> [Me] +#define DEBUG_SII9022 0 + +#define DPRINTF(fmt, ...) \ +do { \ +if (

Re: [Qemu-devel] [Qemu-arm] [PATCH 2/3] hw/sii9022: Add support for Silicon Image SII9022

2018-02-27 Thread Peter Maydell
On 27 February 2018 at 10:21, Linus Walleij wrote: > On Tue, Feb 27, 2018 at 11:09 AM, Peter Maydell > wrote: >> On 27 February 2018 at 07:41, Linus Walleij wrote: >>> On Sat, Feb 17, 2018 at 7:32 PM, Philippe Mathieu-Daudé >>> wrote: >>> [Me] > +#define DEBUG_SII9022 0 > + >

Re: [Qemu-devel] [PATCH] hw/s390x/ipl: Bail out if the network bootloader can not be found

2018-02-27 Thread Thomas Huth
On 27.02.2018 11:16, Viktor Mihajlovski wrote: > On 27.02.2018 11:05, Thomas Huth wrote: >> If QEMU fails to load 's390-netboot.img', the guest firmware currently >> loops forever and just floods the console with "Network boot device >> detected" messages. The code in ipl.c apparently already tried

Re: [Qemu-devel] [Qemu-arm] [PATCH 2/3] hw/sii9022: Add support for Silicon Image SII9022

2018-02-27 Thread Peter Maydell
On 27 February 2018 at 10:24, Peter Maydell wrote: > docs/devel/tracing.txt describes them, but basically: > * include "trace.h" > * define trace events with a line for each in the trace-events >file for the subdirectory (basically a function prototype-ish >thing followed by a printf-sty

Re: [Qemu-devel] [PATCH v2 3/3] virtio-balloon: add a timer to limit the free page report waiting time

2018-02-27 Thread Dr. David Alan Gilbert
* Wei Wang (wei.w.w...@intel.com) wrote: > On 02/09/2018 08:15 PM, Dr. David Alan Gilbert wrote: > > * Wei Wang (wei.w.w...@intel.com) wrote: > > > This patch adds a timer to limit the time that host waits for the free > > > page hints reported by the guest. Users can specify the time in ms via > >

[Qemu-devel] [PATCH 2/5] i2c: Move the bus class to i2c.h

2018-02-27 Thread Linus Walleij
From: Corey Minyard Some devices need access to it. Signed-off-by: Corey Minyard Reviewed-by: Peter Maydell Signed-off-by: Linus Walleij --- hw/i2c/core.c| 17 - include/hw/i2c/i2c.h | 17 + 2 files changed, 17 insertions(+), 17 deletions(-) diff --gi

[Qemu-devel] [PATCH 4/5] hw/sii9022: Add support for Silicon Image SII9022

2018-02-27 Thread Linus Walleij
This adds support for emulating the Silicon Image SII9022 DVI/HDMI bridge. It's not very clever right now, it just acknowledges the switch into DDC I2C mode and back. Combining this with the existing DDC I2C emulation gives the right behavior on the Versatile Express emulation passing through the Q

[Qemu-devel] [PATCH 1/5] i2c: Fix some brace style issues

2018-02-27 Thread Linus Walleij
From: Corey Minyard Signed-off-by: Corey Minyard Reviewed-by: Peter Maydell Signed-off-by: Linus Walleij --- hw/i2c/core.c| 3 +-- include/hw/i2c/i2c.h | 6 ++ 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/i2c/core.c b/hw/i2c/core.c index 59068f157eb5..9a54b61c

[Qemu-devel] [PATCH 0/5] Versatile Express SiI9022 emulation

2018-02-27 Thread Linus Walleij
This series adds proper display bridge/connector emulation for the Versatile Express, implementing a simple Silicon Image 9022 emulation spawning a DDC I2C child. After the series the Versatile Express is successfully presented the "QEMU monitor" through DDC I2C. The series includes two refactori

[Qemu-devel] [PATCH 3/5] hw/i2c-ddc: Do not fail writes

2018-02-27 Thread Linus Walleij
The tx function of the DDC I2C slave emulation was returning 1 on all writes resulting in NACK in the I2C bus. Changing it to 0 makes the DDC I2C work fine with bit-banged I2C such as the versatile I2C. I guess it was not affecting whatever I2C controller this was used with until now, but with the

[Qemu-devel] [PATCH 5/5] arm/vexpress: Add proper display connector emulation

2018-02-27 Thread Linus Walleij
This adds the SiI9022 and EDID I2C devices to the ARM Versatile Express machine, and selects the two I2C devices necessary in the arm-softmmy.mak configuration so everything will build smoothly. I am implementing proper handling of the graphics in the Linux kernel and adding proper emulation of Si

[Qemu-devel] [PATCH v3] numa: we don't implement NUMA for s390x

2018-02-27 Thread David Hildenbrand
Right now it is possible to crash QEMU for s390x by providing e.g. -numa node,nodeid=0,cpus=0-1 Problem is, that numa.c uses mc->cpu_index_to_instance_props as an indicator whether NUMA is supported by a machine type. We don't implement NUMA for s390x ("topology") yet. However we need mc->cpu_

Re: [Qemu-devel] QEMU GSoC 2018 Project Idea (Apply polling to QEMU NVMe)

2018-02-27 Thread Paolo Bonzini
On 27/02/2018 10:05, Huaicheng Li wrote: > Including a RAM disk backend in QEMU would be nice too, and it may > interest you as it would reduce the delta between upstream QEMU and > FEMU.  So this could be another idea. > > Glad you're also interested in this part. This can definitely

[Qemu-devel] [PATCH] hw/s390x: Add the possibility to specify the netboot image on the command line

2018-02-27 Thread Thomas Huth
The file name of the netboot binary is currently hard-coded to "s390-netboot.img", without a possibility for the user to select an alternative firmware image here. That's unfortunate, especially since the basics are already there: The filename is a property of the s390-ipl device. So we just have t

Re: [Qemu-devel] [PATCH 13/16] translate-all: protect TB jumps with a per-destination-TB lock

2018-02-27 Thread Paolo Bonzini
On 27/02/2018 06:39, Emilio G. Cota wrote: > Using a hash table or a binary tree to keep track of the jumps > doesn't really pay off, not only due to the increased memory usage, > but also because most TBs have only 0 or 1 jumps to them. The maximum > number of jumps when booting debian-arm that I

Re: [Qemu-devel] [PATCH V5 2/4] tests/migration: Convert the boot block compilation script into Makefile

2018-02-27 Thread Dr. David Alan Gilbert
* Wei Huang (w...@redhat.com) wrote: > > > On 02/26/2018 12:01 PM, Dr. David Alan Gilbert wrote: > > * Wei Huang (w...@redhat.com) wrote: > >> The x86 boot block header currently is generated with a shell script. > >> To better support other CPUs (e.g. aarch64), we convert the script > >> into Ma

[Qemu-devel] [PATCH 1/4] gtk: make GtkGlArea usage a runtime option

2018-02-27 Thread Gerd Hoffmann
Compile in both gtk-egl and gtk-gl-area, then allow to choose at runtime instead of compile time which opengl variant we want use. Signed-off-by: Gerd Hoffmann --- include/ui/gtk.h | 2 ++ ui/gtk.c | 53 + ui/Makefile.objs | 3 +-- 3

[Qemu-devel] [PATCH 2/4] gtk: use GtkGlArea on wayland only

2018-02-27 Thread Gerd Hoffmann
For dma-buf support we need a egl context. The gtk x11 backend uses glx contexts though. We can't use the GtkGlArea widget on x11 because of that, so use our own gtk-egl code instead. wayland continues to use the GtkGlArea widget. Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 13 -

[Qemu-devel] [PATCH 1/3] spice: drop dprint() debug logging

2018-02-27 Thread Gerd Hoffmann
Some calls are deleted, some are converted into tracepoints. Signed-off-by: Gerd Hoffmann --- ui/spice-display.c | 75 -- ui/trace-events| 9 +++ 2 files changed, 31 insertions(+), 53 deletions(-) diff --git a/ui/spice-display.c b/ui/

[Qemu-devel] [PATCH 3/4] gtk-egl: add scanout_dmabuf support

2018-02-27 Thread Gerd Hoffmann
Add support for dmabuf scanouts to gtk-egl. Signed-off-by: Gerd Hoffmann --- include/ui/gtk.h | 4 ui/gtk-egl.c | 23 +++ ui/gtk.c | 2 ++ 3 files changed, 29 insertions(+) diff --git a/include/ui/gtk.h b/include/ui/gtk.h index f6dafc5961..84c992c227 10064

[Qemu-devel] [PATCH 0/4] gtk: add support for dmabufs

2018-02-27 Thread Gerd Hoffmann
Gerd Hoffmann (4): gtk: make GtkGlArea usage a runtime option gtk: use GtkGlArea on wayland only gtk-egl: add scanout_dmabuf support gtk-egl: add cursor_dmabuf support include/ui/gtk.h | 14 ui/gtk-egl.c | 63 ++- ui/gtk.c

[Qemu-devel] [PATCH 4/4] gtk-egl: add cursor_dmabuf support

2018-02-27 Thread Gerd Hoffmann
Add support for cursor dmabufs to gtk-egl. Just blend in the cursor (if we have one) when rendering the dmabuf. Signed-off-by: Gerd Hoffmann --- include/ui/gtk.h | 8 ui/gtk-egl.c | 40 +++- ui/gtk.c | 2 ++ 3 files changed, 49 insertio

[Qemu-devel] [PATCH 0/3] spice: add support for dmabufs

2018-02-27 Thread Gerd Hoffmann
Gerd Hoffmann (3): spice: drop dprint() debug logging spice: add scanout_dmabuf support spice: add cursor_dmabuf support include/ui/spice-display.h | 9 +++ ui/spice-display.c | 192 - ui/trace-events| 12 +++ 3 files chan

Re: [Qemu-devel] [PATCH v3] numa: we don't implement NUMA for s390x

2018-02-27 Thread Christian Borntraeger
On 02/27/2018 12:02 PM, David Hildenbrand wrote: > Right now it is possible to crash QEMU for s390x by providing e.g. > -numa node,nodeid=0,cpus=0-1 > > Problem is, that numa.c uses mc->cpu_index_to_instance_props as an > indicator whether NUMA is supported by a machine type. We don't > impl

[Qemu-devel] [PATCH 3/3] spice: add cursor_dmabuf support

2018-02-27 Thread Gerd Hoffmann
Add support for cursor dmabufs. qemu has to render the cursor for that, so in case a cursor is present qemu allocates a new dmabuf, blits the scanout, blends in the pointer and passes on the new dmabuf to spice-server. Without cursor qemu continues to simply pass on the scanout dmabuf as-is. Sig

[Qemu-devel] [PATCH 2/3] spice: add scanout_dmabuf support

2018-02-27 Thread Gerd Hoffmann
Add support for scanout dmabufs. Just pass them through to spice-server. Signed-off-by: Gerd Hoffmann --- ui/spice-display.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/ui/spice-display.c b/ui/spice-display.c index f3ae6beb3d..a494db1196 100644 --- a/ui/spice-display.c

  1   2   3   4   5   >