Re: [Qemu-devel] [PATCH v2 10/36] test-qemu-opts: Test qemu_opts_to_qdict_filtered()

2018-02-22 Thread Eric Blake
On 02/22/2018 03:50 AM, Kevin Wolf wrote: +opts = qemu_opts_parse(&opts_list_01, "str1=foo,str2=,str3=bar,number1=42", + false, &error_abort); Worth any additional craziness in regards to our QemuOpts parsing, like str1=foo,,bar,str2... for an option containing co

Re: [Qemu-devel] [PATCH v4 19/20] sdcard: add a 'uhs' property, update the OCR register ACCEPT_SWITCH_1V8 bit

2018-02-22 Thread Peter Maydell
On 15 February 2018 at 22:13, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/sd/sd.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/hw/sd/sd.c b/hw/sd/sd.c > index ada96f5574..b9429b06ca 100644 > --- a/hw/sd/sd.c > +++ b/hw/sd/sd.c > @@ -93,6 +93,7

Re: [Qemu-devel] [PATCH 1/9] acpi: remove unused acpi-dsdt.aml

2018-02-22 Thread Gerd Hoffmann
On Thu, Feb 22, 2018 at 01:42:48PM +0100, Igor Mammedov wrote: > SeaBIOS blob which is currently shipped with QEMU > doesn't need acpi-dsdt.aml nor is able to use it > and code that loaded it QEMU was removed by > (commit 9fb7aaaf4c "pc: drop external DSDT loading") > in 2013. > > Signed-off-by: I

Re: [Qemu-devel] [PATCH v4 20/20] sdcard: add an enum for the SD PHY Spec version

2018-02-22 Thread Peter Maydell
On 15 February 2018 at 22:13, Philippe Mathieu-Daudé wrote: > So far this device intends to model the Spec v1.10 > > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Alistair Francis > --- > hw/sd/sd.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/hw/sd/sd.c b/hw/sd/sd.c >

Re: [Qemu-devel] [PATCH v4 00/20] SDCard: bugfixes, support UHS-I (part 5)

2018-02-22 Thread Peter Maydell
On 15 February 2018 at 22:13, Philippe Mathieu-Daudé wrote: > Some refactors, few bugfixes, better SD/SPI support. > > With this series apply, machines can use SD cards in UHS-I mode. > (mostly imported from Alistair Francis work) > > MMC mode split out for another series, > so UHS enabled MMC car

Re: [Qemu-devel] [PATCH v8 04/26] iotests: Drop explicit base blockdev in 191

2018-02-22 Thread Kevin Wolf
Am 05.02.2018 um 16:18 hat Max Reitz geschrieben: > Overriding the backing image should result in a json:{} pseudo-filename. > Then, you can no longer use the commit block job with filename > parameters. Therefore, do not explicitly add the base and override the > middle image in iotest 191, since

Re: [Qemu-devel] [Qemu-arm] [PATCH 1/3] hw/i2c-ddc: Do not fail writes

2018-02-22 Thread Peter Maydell
On 17 February 2018 at 14:00, Linus Walleij wrote: > The tx function of the DDC I2C slave emulation was returning 1 > on all writes resulting in NACK in the I2C bus. Changing it to > 0 makes the DDC I2C work fine with bit-banged I2C such as the > versatile I2C. > > I guess it was not affecting wha

Re: [Qemu-devel] [Qemu-arm] [PATCH 2/3] hw/sii9022: Add support for Silicon Image SII9022

2018-02-22 Thread Peter Maydell
On 17 February 2018 at 14:00, Linus Walleij wrote: > This adds support for emulating the Silicon Image SII9022 DVI/HDMI > bridge. It's not very clever right now, it just acknowledges > the switch into DDC I2C mode and back. Combining this with the > existing DDC I2C emulation gives the right behav

Re: [Qemu-devel] [PATCH v8 01/26] block/mirror: Small absolute-paths simplification

2018-02-22 Thread Max Reitz
On 2018-02-22 13:27, Kevin Wolf wrote: > Am 05.02.2018 um 16:18 hat Max Reitz geschrieben: >> When invoking drive-mirror in absolute-paths mode, the target's backing >> BDS is assigned to it in mirror_exit(). The current logic only does so >> if the target does not have that backing BDS already; bu

Re: [Qemu-devel] [PULL] Update OpenBIOS images

2018-02-22 Thread Peter Maydell
On 22 February 2018 at 08:23, Mark Cave-Ayland wrote: > Hi Peter, > > This update for OpenBIOS contains a single fix which allows yaboot 1.3.17 to > boot > under qemu-system-ppc. Please pull. > > > ATB, > > Mark. > > > The following changes since commit a6e0344fa0e09413324835ae122c4cadd7890231: >

Re: [Qemu-devel] [PATCH 1/2] tcg: Fold unspecified opcode test into tcg_can_emit_vec_op

2018-02-22 Thread Peter Maydell
On 17 February 2018 at 16:40, Richard Henderson wrote: > This releases the callers from having to check themselves, > which tidies up the code a bit. > > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.inc.c | 4 > tcg/i386/tcg-target.inc.c| 4 > tcg/tcg-op-gvec.c

Re: [Qemu-devel] [PATCH v8 03/26] block: Add BDS.backing_overridden

2018-02-22 Thread Max Reitz
On 2018-02-22 14:39, Kevin Wolf wrote: > Am 05.02.2018 um 16:18 hat Max Reitz geschrieben: >> If the backing file is overridden, this most probably does change the >> guest-visible data of a BDS. Therefore, we will need to consider this in >> bdrv_refresh_filename(). >> >> Adding a new field to the

Re: [Qemu-devel] [PATCH v8 06/26] block: Make path_combine() return the path

2018-02-22 Thread Kevin Wolf
Am 05.02.2018 um 16:18 hat Max Reitz geschrieben: > Besides being safe for arbitrary path lengths, after some follow-up > patches all callers will want a freshly allocated buffer anyway. > > In the meantime, path_combine_deprecated() is added which has the same > interface as path_combine() had be

Re: [Qemu-devel] [PATCH 2/2] tcg: Add missing tcg_can_emit_vec_op check in tcg_gen_gvec_2s

2018-02-22 Thread Peter Maydell
On 17 February 2018 at 16:40, Richard Henderson wrote: > This lead to an assertion failure for 64-bit vector multiply, > which is not available in the AVX instruction set. > > Signed-off-by: Richard Henderson > --- > tcg/tcg-op-gvec.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions

Re: [Qemu-devel] [PATCH v8 04/26] iotests: Drop explicit base blockdev in 191

2018-02-22 Thread Max Reitz
On 2018-02-22 15:34, Kevin Wolf wrote: > Am 05.02.2018 um 16:18 hat Max Reitz geschrieben: >> Overriding the backing image should result in a json:{} pseudo-filename. >> Then, you can no longer use the commit block job with filename >> parameters. Therefore, do not explicitly add the base and over

Re: [Qemu-devel] [PATCH v4 1/1] scripts: Add decodetree.py

2018-02-22 Thread Peter Maydell
On 17 February 2018 at 18:07, Richard Henderson wrote: > To be used to decode ARM SVE, but could be used for any fixed-width ISA. > > Signed-off-by: Richard Henderson > > --- > Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v8 03/26] block: Add BDS.backing_overridden

2018-02-22 Thread Kevin Wolf
Am 22.02.2018 um 15:55 hat Max Reitz geschrieben: > On 2018-02-22 14:39, Kevin Wolf wrote: > > Am 05.02.2018 um 16:18 hat Max Reitz geschrieben: > >> If the backing file is overridden, this most probably does change the > >> guest-visible data of a BDS. Therefore, we will need to consider this in >

Re: [Qemu-devel] [PATCH v8 03/26] block: Add BDS.backing_overridden

2018-02-22 Thread Max Reitz
On 2018-02-22 16:12, Kevin Wolf wrote: > Am 22.02.2018 um 15:55 hat Max Reitz geschrieben: >> On 2018-02-22 14:39, Kevin Wolf wrote: >>> Am 05.02.2018 um 16:18 hat Max Reitz geschrieben: If the backing file is overridden, this most probably does change the guest-visible data of a BDS. The

Re: [Qemu-devel] [PATCH v2] linux-user: Support f_flags in statfs when available.

2018-02-22 Thread Shea Levy
Hello, These tabs match the existing style of linux-user/syscall.h, should I remove them? Also, there doesn't appear to be a maintainer for checkpatch in the current MAINTAINERS file, whom should I CC on this? Thanks, Shea no-re...@patchew.org writes: > Hi, > > This series seems to have some c

Re: [Qemu-devel] [PATCH v8 18/26] block: Add sgfnt_runtime_opts to BlockDriver

2018-02-22 Thread Max Reitz
On 2018-02-06 16:23, Alberto Garcia wrote: > On Mon 05 Feb 2018 04:18:27 PM CET, Max Reitz wrote: >> --- a/block/blkdebug.c >> +++ b/block/blkdebug.c >> @@ -886,6 +886,21 @@ static int blkdebug_reopen_prepare(BDRVReopenState >> *reopen_state, >> return 0; >> } >> >> +static const char *con

[Qemu-devel] [PULL 00/32] target-arm queue

2018-02-22 Thread Peter Maydell
27;remotes/mcayland/tags/qemu-openbios-signed' into staging (2018-02-22 11:37:05 +) are available in the Git repository at: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20180222 for you to fetch changes up to 4e5cc6756586e967993187657dfcdde4e00288d9: s

[Qemu-devel] [PULL 03/32] hw/char/stm32f2xx_usart: fix TXE/TC bit handling

2018-02-22 Thread Peter Maydell
From: Richard Braun I/O currently being synchronous, there is no reason to ever clear the SR_TXE bit. However the SR_TC bit may be cleared by software writing to the SR register, so set it on each write. In addition, fix the reset value of the USART status register. Signed-off-by: Richard Braun

[Qemu-devel] [PULL 05/32] hw/sd/milkymist-memcard: use qemu_log_mask()

2018-02-22 Thread Peter Maydell
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Acked-by: Michael Walle Message-id: 20180216022933.10945-2-f4...@amsat.org Signed-off-by: Peter Maydell --- hw/sd/milkymist-memcard.c | 17 ++--- 1 file changed, 10 insertions(+), 7 d

[Qemu-devel] [PULL 11/32] sdcard: add a trace event for command responses

2018-02-22 Thread Peter Maydell
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-id: 20180215220540.6556-4-f4...@amsat.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- hw/sd/sd.c | 27 --- hw/sd/trace-events | 1 + 2 files changed, 25 insertions(+), 3

[Qemu-devel] [PULL 01/32] target/arm: Fix register definitions for VMIDR and VMPIDR

2018-02-22 Thread Peter Maydell
The register definitions for VMIDR and VMPIDR have separate reginfo structs for the AArch32 and AArch64 registers. However the 32-bit versions are wrong: * they use offsetof instead of offsetoflow32 to mark where the 32-bit value lives in the uint64_t CPU state field * they don't mark themselv

[Qemu-devel] [PULL 04/32] Fix ast2500 protection register emulation

2018-02-22 Thread Peter Maydell
From: Hugo Landau Some register blocks of the ast2500 are protected by protection key registers which require the right magic value to be written to those registers to allow those registers to be mutated. Register manuals indicate that writing the correct magic value to these registers should ca

[Qemu-devel] [PULL 02/32] raspi: Add "raspi3" machine type

2018-02-22 Thread Peter Maydell
From: Pekka Enberg This patch adds a "raspi3" machine type, which can now be selected as the machine to run on by users via the "-M" command line option to QEMU. The machine type does *not* ignore memory transaction failures so we likely need to add some dummy devices later when people run somet

[Qemu-devel] [PULL 21/32] sdcard: remove commands from unsupported old MMC specification

2018-02-22 Thread Peter Maydell
From: Philippe Mathieu-Daudé This device does not model MMCA Specification previous to v4.2 Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-id: 20180215221325.7611-6-f4...@amsat.org Signed-off-by: Peter Maydell --- hw/sd/sd.c | 33 -

[Qemu-devel] [PULL 07/32] hw/sd/milkymist-memcard: expose a SDBus and connect the SDCard to it

2018-02-22 Thread Peter Maydell
From: Philippe Mathieu-Daudé using the sdbus_*() API. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Acked-by: Michael Walle Message-id: 20180216022933.10945-4-f4...@amsat.org Signed-off-by: Peter Maydell --- hw/sd/milkymist-memcard.c | 38 +-

[Qemu-devel] [PULL 06/32] hw/sd/milkymist-memcard: split realize() out of SysBusDevice init()

2018-02-22 Thread Peter Maydell
From: Philippe Mathieu-Daudé Create the SDCard in the realize() function. Suggested-by: Michael Walle Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Acked-by: Michael Walle Message-id: 20180216022933.10945-3-f4...@amsat.org Signed-off-by: Peter Maydell --- hw/sd/milkym

[Qemu-devel] [PULL 14/32] sdcard: define SDMMC_CMD_MAX instead of using the magic '64'

2018-02-22 Thread Peter Maydell
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-id: 20180215220540.6556-8-f4...@amsat.org Signed-off-by: Peter Maydell --- hw/sd/sdmmc-internal.h | 15 +++ hw/sd/sd.c | 22 -- 2 files changed,

[Qemu-devel] [PULL 22/32] sdcard: simplify using the ldst API

2018-02-22 Thread Peter Maydell
From: Philippe Mathieu-Daudé the code is easier to review/refactor. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-id: 20180215221325.7611-7-f4...@amsat.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- hw/sd/sd.c | 38 +

[Qemu-devel] [PULL 10/32] sdcard: replace DPRINTF() by trace events

2018-02-22 Thread Peter Maydell
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-id: 20180215220540.6556-3-f4...@amsat.org Signed-off-by: Peter Maydell --- hw/sd/sd.c | 32 ++-- hw/sd/trace-events | 6 ++ 2 files changed, 32 ins

[Qemu-devel] [PULL 20/32] sdcard: clean the SCR register and add few comments

2018-02-22 Thread Peter Maydell
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-id: 20180215221325.7611-5-f4...@amsat.org Signed-off-by: Peter Maydell --- hw/sd/sd.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c i

[Qemu-devel] [PULL 08/32] hw/sd/ssi-sd: use the SDBus API, connect the SDCard to the bus

2018-02-22 Thread Peter Maydell
From: Philippe Mathieu-Daudé On reset the bus will reset the card, we can now drop the device_reset() call. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-id: 20180216022933.10945-5-f4...@amsat.org Signed-off-by: Peter Maydell --- hw/sd/ssi-sd.c | 32

[Qemu-devel] [PULL 24/32] sdcard: use the registerfields API for the CARD_STATUS register masks

2018-02-22 Thread Peter Maydell
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Acked-by: Alistair Francis Message-id: 20180215221325.7611-9-f4...@amsat.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- hw/sd/sd.c | 48 +--- 1 file changed, 45 ins

[Qemu-devel] [PULL 09/32] sdcard: reorder SDState struct members

2018-02-22 Thread Peter Maydell
From: Philippe Mathieu-Daudé place card registers first, this will ease further code movements. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-id: 20180215220540.6556-2-f4...@amsat.org Signed-off-by: Peter Maydell --- hw/sd/sd.c | 16 +--- 1 file chan

[Qemu-devel] [PULL 19/32] sdcard: fix the 'maximum data transfer rate' to 25MHz

2018-02-22 Thread Peter Maydell
From: Philippe Mathieu-Daudé To comply with Spec v1.10 (and 2.00, 3.01): . TRAN_SPEED for current SD Memory Cards that field must be always 0_0110_010b (032h) which is equal to 25MHz - the mandatory maximum operating frequency of SD Memory Card. Signed-off-by: Philippe Mathieu-Daudé Reviewed

[Qemu-devel] [PULL 23/32] sdcard: use the correct masked OCR in the R3 reply

2018-02-22 Thread Peter Maydell
From: Philippe Mathieu-Daudé use the registerfields API to access the OCR register Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-id: 20180215221325.7611-8-f4...@amsat.org Signed-off-by: Peter Maydell --- hw/sd/sd.c | 21 - 1 file changed, 16

[Qemu-devel] [PULL 25/32] sdcard: handle CMD54 (SDIO)

2018-02-22 Thread Peter Maydell
From: Philippe Mathieu-Daudé Linux uses it to poll the bus before polling for a card. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-id: 20180215221325.7611-10-f4...@amsat.org Signed-off-by: Peter Maydell --- hw/sd/sd.c | 5 ++--- 1 file changed, 2 insertions(+),

[Qemu-devel] [PULL 16/32] sdcard: use the registerfields API to access the OCR register

2018-02-22 Thread Peter Maydell
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-id: 20180215220540.6556-12-f4...@amsat.org Signed-off-by: Peter Maydell --- include/hw/sd/sd.h | 1 - hw/sd/sd.c | 21 + 2 files changed, 13 insertions(+), 9 d

[Qemu-devel] [PULL 13/32] sdcard: add more trace events

2018-02-22 Thread Peter Maydell
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Acked-by: Alistair Francis Message-id: 20180215220540.6556-6-f4...@amsat.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- hw/sd/sd.c | 32 ++-- hw/sd/trace-events | 13 ++

[Qemu-devel] [PULL 26/32] sdcard: handle the Security Specification commands

2018-02-22 Thread Peter Maydell
From: Philippe Mathieu-Daudé returning sd_illegal, since they are not implemented. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-id: 20180215221325.7611-11-f4...@amsat.org [PMM: tweak multiline comment format] Signed-off-by: Peter Maydell --- hw/sd/sd.c | 12 +++

[Qemu-devel] [PULL 28/32] sdcard: handles more commands in SPI mode

2018-02-22 Thread Peter Maydell
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-id: 20180215221325.7611-13-f4...@amsat.org Signed-off-by: Peter Maydell --- hw/sd/sd.c | 29 ++--- 1 file changed, 26 insertions(+), 3 deletions(-) diff --git a/hw

[Qemu-devel] [PULL 17/32] sdcard: Don't always set the high capacity bit

2018-02-22 Thread Peter Maydell
From: Philippe Mathieu-Daudé Don't set the high capacity bit by default as it will be set if required in the sd_set_csd() function. [based on a patch from Alistair Francis and Peter Ogden from qemu/xilinx tag xilinx-v2015.4] Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis

[Qemu-devel] [PULL 29/32] sdcard: check the card is in correct state for APP CMD (CMD55)

2018-02-22 Thread Peter Maydell
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-id: 20180215221325.7611-14-f4...@amsat.org Signed-off-by: Peter Maydell --- hw/sd/sd.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index ff7ace3491.

[Qemu-devel] [PULL 31/32] sdcard: simplify SEND_IF_COND (CMD8)

2018-02-22 Thread Peter Maydell
From: Philippe Mathieu-Daudé replace switch(single case) -> if() Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-id: 20180215221325.7611-16-f4...@amsat.org Signed-off-by: Peter Maydell --- hw/sd/sd.c | 26 +++--- 1 file changed, 11 insertions(+

Re: [Qemu-devel] [PATCH 2/2] tcg: Add missing tcg_can_emit_vec_op check in tcg_gen_gvec_2s

2018-02-22 Thread Richard Henderson
On 02/22/2018 06:58 AM, Peter Maydell wrote: > Incidentally, I notice that the condition checks > (TCG_TARGET_HAS_v256 && check_size_impl(oprsz, 32) > && tcg_can_emit_vec_op(g->opc, TCG_TYPE_V256, g->vece)) > > (TCG_TARGET_HAS_v128 && check_size_impl(oprsz, 16) > && tcg_can_e

[Qemu-devel] [PULL 12/32] sdcard: replace fprintf() by qemu_hexdump()

2018-02-22 Thread Peter Maydell
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-id: 20180215220540.6556-5-f4...@amsat.org Signed-off-by: Peter Maydell --- hw/sd/sd.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/hw/sd/sd.c b/hw/s

[Qemu-devel] [PULL 30/32] sdcard: warn if host uses an incorrect address for APP CMD (CMD55)

2018-02-22 Thread Peter Maydell
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-id: 20180215221325.7611-15-f4...@amsat.org Signed-off-by: Peter Maydell --- hw/sd/sd.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index d6dd2b9a15..c8

[Qemu-devel] [PULL 27/32] sdcard: use a more descriptive label 'unimplemented_spi_cmd'

2018-02-22 Thread Peter Maydell
From: Philippe Mathieu-Daudé Suggested-by: Alistair Francis Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-id: 20180215221325.7611-12-f4...@amsat.org Signed-off-by: Peter Maydell --- hw/sd/sd.c | 22 +- 1 file changed, 13 insertions(+), 9 dele

Re: [Qemu-devel] [PATCH 1/2] i2c: Fix some brace style issues

2018-02-22 Thread Linus Walleij
On Mon, Feb 19, 2018 at 4:20 PM, wrote: > From: Corey Minyard > > Signed-off-by: Corey Minyard Reviewed-by: Linus Walleij Yours, Linus Walleij

[Qemu-devel] [PULL 15/32] sdcard: use G_BYTE from cutils

2018-02-22 Thread Peter Maydell
From: Philippe Mathieu-Daudé code is now easier to read. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-id: 20180215220540.6556-11-f4...@amsat.org Signed-off-by: Peter Maydell --- hw/sd/sd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw

Re: [Qemu-devel] [PATCH v8 18/26] block: Add sgfnt_runtime_opts to BlockDriver

2018-02-22 Thread Alberto Garcia
On Thu 22 Feb 2018 04:19:45 PM CET, Max Reitz wrote: > On 2018-02-06 16:23, Alberto Garcia wrote: >> On Mon 05 Feb 2018 04:18:27 PM CET, Max Reitz wrote: >>> --- a/block/blkdebug.c >>> +++ b/block/blkdebug.c >>> @@ -886,6 +886,21 @@ static int blkdebug_reopen_prepare(BDRVReopenState >>> *reopen_st

Re: [Qemu-devel] [PATCH 2/2] i2c: Move the bus class to i2c.h

2018-02-22 Thread Linus Walleij
On Tue, Feb 20, 2018 at 2:06 PM, Corey Minyard wrote: > On 02/19/2018 09:25 AM, Peter Maydell wrote: >> >> On 19 February 2018 at 15:20, wrote: >>> >>> From: Corey Minyard >>> >>> Some devices need access to it. >>> >>> Signed-off-by: Corey Minyard >>> --- >>> hw/i2c/core.c| 17 -

Re: [Qemu-devel] [qemu-s390x] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-22 Thread Collin L. Walling
On 02/22/2018 07:23 AM, Viktor Mihajlovski wrote: On 22.02.2018 12:51, Christian Borntraeger wrote: Series Acked-by: Christian Borntraeger Thanks!!! menu on scsi and dasd bootmaps tested successfully. There is one thing that we might want to fix (can be an addon patch since this is a no

[Qemu-devel] [PULL 18/32] sdcard: update the CSD CRC register regardless the CSD structure version

2018-02-22 Thread Peter Maydell
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-id: 20180215221325.7611-3-f4...@amsat.org Signed-off-by: Peter Maydell --- hw/sd/sd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index cc

Re: [Qemu-devel] [PATCH v4 4/7] qdev: add hotpluggable to DeviceState

2018-02-22 Thread Gerd Hoffmann
On Mon, Feb 19, 2018 at 12:14:55PM +0100, Gerd Hoffmann wrote: > vfio display support wants disable hotplug for certain devices, because > qemu doesn't support hotplugging display devices and qemu consoles. > > Add a hotpluggable bool to DeviceState, initialize it from > DeviceClass->hotpluggable,

[Qemu-devel] [PULL 32/32] sdcard: simplify SD_SEND_OP_COND (ACMD41)

2018-02-22 Thread Peter Maydell
From: Philippe Mathieu-Daudé replace switch(single case) -> if() Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-id: 20180215221325.7611-17-f4...@amsat.org Signed-off-by: Peter Maydell --- hw/sd/sd.c | 56 ++-- 1

Re: [Qemu-devel] [PULL 0/9] Ui 20180222 patches

2018-02-22 Thread Peter Maydell
ilable in the git repository at: > > git://git.kraxel.org/qemu tags/ui-20180222-pull-request > > for you to fetch changes up to abb4f2c9655503f14dc55064f29c4f59b07e96ff: > > keymap: consider modifier state when p

Re: [Qemu-devel] [PATCH v7 09/23] monitor: allow using IO thread for parsing

2018-02-22 Thread Stefan Hajnoczi
On Thu, Feb 22, 2018 at 06:01:19PM +0800, Peter Xu wrote: > On Wed, Feb 21, 2018 at 04:00:07PM +, Stefan Hajnoczi wrote: > > On Wed, Jan 24, 2018 at 01:39:43PM +0800, Peter Xu wrote: > > > @@ -4099,24 +4156,55 @@ void monitor_init(Chardev *chr, int flags) > > > } > > > > > > if (mon

Re: [Qemu-devel] [qemu-s390x] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-22 Thread Christian Borntraeger
On 02/22/2018 04:40 PM, Collin L. Walling wrote: > On 02/22/2018 07:23 AM, Viktor Mihajlovski wrote: >> On 22.02.2018 12:51, Christian Borntraeger wrote: >>> Series >>> Acked-by: Christian Borntraeger > > Thanks!!! > >>> >>> >>> menu on scsi and dasd bootmaps tested successfully. >>> >>> There

Re: [Qemu-devel] [PATCH v4 4/7] qdev: add hotpluggable to DeviceState

2018-02-22 Thread Peter Maydell
On 22 February 2018 at 15:37, Gerd Hoffmann wrote: > On Mon, Feb 19, 2018 at 12:14:55PM +0100, Gerd Hoffmann wrote: >> vfio display support wants disable hotplug for certain devices, because >> qemu doesn't support hotplugging display devices and qemu consoles. >> >> Add a hotpluggable bool to Dev

Re: [Qemu-devel] [PATCH 2/2] i2c: Move the bus class to i2c.h

2018-02-22 Thread Peter Maydell
On 22 February 2018 at 15:39, Linus Walleij wrote: > On Tue, Feb 20, 2018 at 2:06 PM, Corey Minyard wrote: >> Linus, Philippe, do you want me to submit this, or do you want >> to take it? You can pull it from: >> >> https://github.com/cminyard/qemu.git tags/i2c-bus-move > > I don't have any comm

Re: [Qemu-devel] [PATCH 2/2] i2c: Move the bus class to i2c.h

2018-02-22 Thread Linus Walleij
On Thu, Feb 22, 2018 at 4:44 PM, Peter Maydell wrote: > On 22 February 2018 at 15:39, Linus Walleij wrote: >> On Tue, Feb 20, 2018 at 2:06 PM, Corey Minyard wrote: >>> Linus, Philippe, do you want me to submit this, or do you want >>> to take it? You can pull it from: >>> >>> https://github.com

Re: [Qemu-devel] [PATCH 2/2] i2c: Move the bus class to i2c.h

2018-02-22 Thread Linus Walleij
On Mon, Feb 19, 2018 at 4:20 PM, wrote: > From: Corey Minyard > > Some devices need access to it. > > Signed-off-by: Corey Minyard Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [Qemu-devel] [PATCH v7 09/23] monitor: allow using IO thread for parsing

2018-02-22 Thread Daniel P . Berrangé
On Thu, Feb 22, 2018 at 06:01:19PM +0800, Peter Xu wrote: > On Wed, Feb 21, 2018 at 04:00:07PM +, Stefan Hajnoczi wrote: > > On Wed, Jan 24, 2018 at 01:39:43PM +0800, Peter Xu wrote: > > > @@ -4034,12 +4044,29 @@ static void sortcmdlist(void) > > > qsort((void *)info_cmds, array_num, elem_

[Qemu-devel] [PATCH v3 0/4] qcow2: minor compression improvements

2018-02-22 Thread Eric Blake
Since v2: - new patch 2, spec changes based on list followup - tweak patch 3 to use MIN() and stop open-coding a calculation [Berto] - tweak patch 4 to stop overallocating by a sector [Berto] Eric Blake (4): qcow2: Prefer byte-based calls into bs->file qcow2: Document some maximum size constra

[Qemu-devel] [PATCH v3 1/4] qcow2: Prefer byte-based calls into bs->file

2018-02-22 Thread Eric Blake
We had only three sector-based stragglers left; convert them to use our preferred byte-based accesses. Signed-off-by: Eric Blake Reviewed-by: Alberto Garcia --- v2: indentation fix --- block/qcow2-cluster.c | 5 ++--- block/qcow2-refcount.c | 6 +++--- 2 files changed, 5 insertions(+), 6 dele

[Qemu-devel] [PATCH v3 2/4] qcow2: Document some maximum size constraints

2018-02-22 Thread Eric Blake
Although off_t permits up to 63 bits (8EB) of file offsets, in practice, we're going to hit other limits first. Document some of those limits in the qcow2 spec, and how choice of cluster size can influence some of the limits. While at it, notice that since we cannot map any virtual cluster to any

[Qemu-devel] [PATCH v3 4/4] qcow2: Avoid memory over-allocation on compressed images

2018-02-22 Thread Eric Blake
When reading a compressed image, we were allocating s->cluster_data to 32*cluster_size + 512 (possibly over 64 megabytes, for an image with 2M clusters). Let's check out the history: Back when qcow2 was first written, we used s->cluster_data for everything, including copy_sectors() and encryption

[Qemu-devel] [PATCH v3 3/4] qcow2: Don't allow overflow during cluster allocation

2018-02-22 Thread Eric Blake
Our code was already checking that we did not attempt to allocate more clusters than what would fit in an INT64 (the physical maximimum if we can access a full off_t's worth of data). But this does not catch smaller limits enforced by various spots in the qcow2 image description: L1 and normal clu

[Qemu-devel] [PATCH] iotests: Test abnormally large size in compressed cluster descriptor

2018-02-22 Thread Alberto Garcia
L2 entries for compressed clusters have a field that indicates the number of sectors used to store the data in the image. That's however not the size of the compressed data itself, just the number of sectors where that data is located. The actual data size is usually not a multiple of the sector s

Re: [Qemu-devel] [PATCH v8 03/26] block: Add BDS.backing_overridden

2018-02-22 Thread Kevin Wolf
Am 22.02.2018 um 16:17 hat Max Reitz geschrieben: > On 2018-02-22 16:12, Kevin Wolf wrote: > > Am 22.02.2018 um 15:55 hat Max Reitz geschrieben: > >> On 2018-02-22 14:39, Kevin Wolf wrote: > >>> Am 05.02.2018 um 16:18 hat Max Reitz geschrieben: > If the backing file is overridden, this most pr

[Qemu-devel] [PATCH v2 1/3] s390x/sclp: proper support of larger send and receive masks

2018-02-22 Thread Claudio Imbrenda
Until 67915de9f0383ccf4a ("s390x/event-facility: variable-length event masks") we only supported sclp event masks of size exactly 4 bytes, even though the archiecture allows the guests to set up sclp event masks from 1 to 1021 bytes in length. After that patch, the behaviour was almost compliant, b

[Qemu-devel] [PATCH v2 3/3] s390x/sclp: extend SCLP event masks to 64 bits

2018-02-22 Thread Claudio Imbrenda
Extend the SCLP event masks to 64 bits. Notice that using any of the new bits results in a state that cannot be migrated to an older version. Signed-off-by: Claudio Imbrenda --- hw/s390x/event-facility.c | 43 +-- include/hw/s390x/event-facility.h |

[Qemu-devel] [PATCH v2 2/3] s390x/sclp: clean up sclp masks

2018-02-22 Thread Claudio Imbrenda
Introduce an sccb_mask_t to be used for SCLP event masks instead of just unsigned int or uint32_t. This will allow later to extend the mask with more ease. Signed-off-by: Claudio Imbrenda --- hw/char/sclpconsole-lm.c | 4 ++-- hw/char/sclpconsole.c | 4 ++-- hw/s390x/event

Re: [Qemu-devel] [PATCH v3 4/5] aarch64-linux-user: Add support for EXTRA signal frame records

2018-02-22 Thread Peter Maydell
On 16 February 2018 at 21:56, Richard Henderson wrote: > The EXTRA record allows for additional space to be allocated > beyon what is currently reserved. Add code to emit and read > this record type. > > Nothing uses extra space yet. > > Signed-off-by: Richard Henderson > --- > @@ -1554,14 +157

[Qemu-devel] [PATCH v2 0/3] s390x/sclp: 64 bit event masks

2018-02-22 Thread Claudio Imbrenda
Until 67915de9f0383ccf4a ("s390x/event-facility: variable-length event masks") we only supported 32bit sclp event masks, even though the archiecture allows the guests to set up sclp event masks up to 1021 bytes in length. With that patch the behaviour was almost compliant, but some issues were stil

Re: [Qemu-devel] [PATCH v3 4/4] qcow2: Avoid memory over-allocation on compressed images

2018-02-22 Thread Alberto Garcia
On Thu 22 Feb 2018 04:59:22 PM CET, Eric Blake wrote: > sector_offset = coffset & 511; > csize = nb_csectors * 512 - sector_offset; [...] > +assert(csize < 2 * s->cluster_size); I think it should be <= If sector_offset is 0 and nb_csector is the maximum allowe

Re: [Qemu-devel] [PATCH v3 3/5] aarch64-linux-user: Remove struct target_aux_context

2018-02-22 Thread Peter Maydell
On 16 February 2018 at 21:56, Richard Henderson wrote: > This changes the qemu signal frame layout to be more like the kernel's, > in that the various records are dynamically allocated rather than fixed > in place by a structure. > > For now, all of the allocation is out of uc.tuc_mcontext.__reser

Re: [Qemu-devel] [PATCH v4 0/7] vfio: add display support

2018-02-22 Thread Alex Williamson
On Tue, 20 Feb 2018 11:28:14 +0100 Gerd Hoffmann wrote: > On Mon, Feb 19, 2018 at 03:16:49PM -0700, Alex Williamson wrote: > > On Mon, 19 Feb 2018 12:14:51 +0100 > > Gerd Hoffmann wrote: > > > > > This series adds support for a vgpu display to the qemu vfio code. > > > For now only regions ar

Re: [Qemu-devel] [PATCH v3 2/5] aarch64-linux-user: Split out helpers for guest signal handling

2018-02-22 Thread Peter Maydell
On 16 February 2018 at 21:56, Richard Henderson wrote: > Split out helpers from target_setup_frame and target_restore_sigframe > for dealing with general registers, fpsimd registers, and the end record. > > When we add support for sve registers, the relative positions of > these will change. > > S

Re: [Qemu-devel] [PATCH v3 1/5] linux-user: Implement aarch64 PR_SVE_SET/GET_VL

2018-02-22 Thread Peter Maydell
On 16 February 2018 at 21:56, Richard Henderson wrote: > As an implementation choice, widening VL has zeroed the > previously inaccessible portion of the sve registers. > > Signed-off-by: Richard Henderson > --- > linux-user/aarch64/target_syscall.h | 3 +++ > target/arm/cpu.h

Re: [Qemu-devel] [PATCH] docs: document how to use the l2-cache-entry-size parameter

2018-02-22 Thread Alberto Garcia
On Thu 22 Feb 2018 03:17:57 PM CET, Kevin Wolf wrote: >> > While we're at it, would l2-cache-entry-size = MIN(cluster_size, >> > 64k) make sense as a default? >> >> Any reason why you choose 64k, or is it because it's the default >> cluster size? >> >> In general I'd be cautious to reduce the def

[Qemu-devel] [PATCH] simpletrace: fix timestamp argument type

2018-02-22 Thread Stefan Hajnoczi
The timestamp argument to a trace event method is documented as follows: The method can also take a timestamp argument before the trace event arguments: def runstate_set(self, timestamp, new_state): ... Timestamps have the uint64_t type and are in nanoseconds. In reality metho

Re: [Qemu-devel] [PATCH v3 5/5] aarch64-linux-user: Add support for SVE signal frame records

2018-02-22 Thread Peter Maydell
On 16 February 2018 at 21:56, Richard Henderson wrote: > Depending on the currently selected size of the SVE vector registers, > we can either store the data within the "standard" allocation, or we > may beedn to allocate additional space with an EXTRA record. > > Signed-off-by: Richard Henderson

Re: [Qemu-devel] [qemu-s390x] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-22 Thread Collin L. Walling
On 02/22/2018 10:44 AM, Christian Borntraeger wrote: On 02/22/2018 04:40 PM, Collin L. Walling wrote: On 02/22/2018 07:23 AM, Viktor Mihajlovski wrote: On 22.02.2018 12:51, Christian Borntraeger wrote: Series Acked-by: Christian Borntraeger Thanks!!! menu on scsi and dasd bootmaps tested

Re: [Qemu-devel] [PATCH v4 4/7] qdev: add hotpluggable to DeviceState

2018-02-22 Thread Alex Williamson
On Thu, 22 Feb 2018 15:46:17 + Peter Maydell wrote: > On 22 February 2018 at 15:37, Gerd Hoffmann wrote: > > On Mon, Feb 19, 2018 at 12:14:55PM +0100, Gerd Hoffmann wrote: > >> vfio display support wants disable hotplug for certain devices, because > >> qemu doesn't support hotplugging dis

Re: [Qemu-devel] [RFC, PATCH, v1] hw/audio/opl2lpt: add support for OPL2LPT

2018-02-22 Thread no-reply
Hi, This series failed build test on ppcle host. Please find the details below. Type: series Subject: [Qemu-devel] [RFC, PATCH, v1] hw/audio/opl2lpt: add support for OPL2LPT Message-id: 20180218144021.11641-1-vinc...@bernat.im === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoke

Re: [Qemu-devel] [Qemu-block] Limiting coroutine stack usage

2018-02-22 Thread John Snow
On 02/22/2018 05:57 AM, Kevin Wolf wrote: > Am 20.02.2018 um 22:54 hat Paolo Bonzini geschrieben: >> On 20/02/2018 18:04, Peter Lieven wrote: >>> Hi, >>> >>> I remember we discussed a long time ago to limit the stack usage of all >>> functions that are executed in a coroutine >>> context to a ver

Re: [Qemu-devel] [PATCH 3/5] timer: generalize Dallas/Maxim RTC i2c devices

2018-02-22 Thread Peter Maydell
On 19 February 2018 at 04:03, Michael Davidsaver wrote: > Support for: ds1307, ds1337, ds1338, ds1339, > ds1340, ds1375, ds1388, and ds3231. > > Tested with ds1338 and ds1375. > > The existing ds1338 model has two bugs > with almost no practical impact. > > 1. Trying to set time in 12-hour mode wo

Re: [Qemu-devel] [PATCH v4 4/7] qdev: add hotpluggable to DeviceState

2018-02-22 Thread Peter Maydell
On 22 February 2018 at 16:59, Alex Williamson wrote: > On Thu, 22 Feb 2018 15:46:17 + > Peter Maydell wrote: >> What type of device is only sometimes hotpluggable ? >> The commit message says "display devices" and "consoles", >> but I would expect those to both be types of device which >> hav

Re: [Qemu-devel] [PATCH v2 20/32] arm/translate-a64: add FP16 FCMxx (zero) to simd_two_reg_misc_fp16

2018-02-22 Thread Alex Bennée
Richard Henderson writes: > On 02/08/2018 09:31 AM, Alex Bennée wrote: >> +maxpasses = hp ? (is_q ? 8 : 4) : (is_q ? 4 : 2); > > (8 << is_q) >> size > > ? Hmm I'm not so sure about this. While mine is longer form at least the intent is clear. What about: maxpasses = (is_q ? 4

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 01/67] target/arm: Enable SVE for aarch64-linux-user

2018-02-22 Thread Peter Maydell
On 17 February 2018 at 18:22, Richard Henderson wrote: > Enable ARM_FEATURE_SVE for the generic "any" cpu. > > Signed-off-by: Richard Henderson > --- > target/arm/cpu.c | 7 +++ > target/arm/cpu64.c | 1 + > 2 files changed, 8 insertions(+) Reviewed-by: Peter Maydell though this should

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 02/67] target/arm: Introduce translate-a64.h

2018-02-22 Thread Peter Maydell
On 17 February 2018 at 18:22, Richard Henderson wrote: > Move some stuff that will be common to both translate-a64.c > and translate-sve.c. > > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v8 03/26] block: Add BDS.backing_overridden

2018-02-22 Thread Max Reitz
On 2018-02-22 17:21, Kevin Wolf wrote: > Am 22.02.2018 um 16:17 hat Max Reitz geschrieben: >> On 2018-02-22 16:12, Kevin Wolf wrote: >>> Am 22.02.2018 um 15:55 hat Max Reitz geschrieben: On 2018-02-22 14:39, Kevin Wolf wrote: > Am 05.02.2018 um 16:18 hat Max Reitz geschrieben: >> If th

Re: [Qemu-devel] [RFC PATCH v6 00/20] replay additions

2018-02-22 Thread Ciro Santilli
On Thu, Feb 22, 2018 at 7:10 AM, Pavel Dovgalyuk wrote: >> From: Pavel Dovgalyuk [mailto:dovga...@ispras.ru] >> > From: Ciro Santilli [mailto:ciro.santi...@gmail.com] >> > On Wed, Feb 21, 2018 at 6:41 AM, Pavel Dovgalyuk >> > wrote: >> > >> From: Ciro Santilli [mailto:ciro.santi...@gmail.com] >>

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 03/67] target/arm: Add SVE decode skeleton

2018-02-22 Thread Peter Maydell
On 17 February 2018 at 18:22, Richard Henderson wrote: > Including only 4, as-yet unimplemented, instruction patterns > so that the whole thing compiles. > > Signed-off-by: Richard Henderson > --- > target/arm/translate-a64.c | 11 +++- > target/arm/translate-sve.c | 63 > ++

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 04/67] target/arm: Implement SVE Bitwise Logical - Unpredicated Group

2018-02-22 Thread Peter Maydell
On 17 February 2018 at 18:22, Richard Henderson wrote: > These were the instructions that were stubbed out when > introducing the decode skeleton. > > Signed-off-by: Richard Henderson > --- > target/arm/translate-sve.c | 50 > +++--- > 1 file changed, 43

<    1   2   3   4   >