Re: [Qemu-devel] [PATCH qemu v7 2/4] vfio/pci: Relax DMA map errors for MMIO regions

2018-02-14 Thread Alexey Kardashevskiy
On 14/02/18 12:33, David Gibson wrote: > On Tue, Feb 13, 2018 at 07:20:56PM +1100, Alexey Kardashevskiy wrote: >> On 13/02/18 16:41, David Gibson wrote: >>> On Tue, Feb 13, 2018 at 04:36:30PM +1100, David Gibson wrote: On Tue, Feb 13, 2018 at 12:15:52PM +1100, Alexey Kardashevskiy wrote: >

[Qemu-devel] [Bug 1254786] Re: qemu-m68k-static: illegal instruction ebc0 during debootstrap second stage

2018-02-14 Thread Laurent Vivier
0xebc0 is "bfexts" with register and is implemented since: ac815f46a3 target-m68k: Implement bitfield ops for registers Available since qemu v2.9.0 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/

Re: [Qemu-devel] QEMU leaves pidfile behind on exit

2018-02-14 Thread Daniel P . Berrangé
On Tue, Feb 13, 2018 at 08:35:23PM +0100, Laszlo Ersek wrote: > On 02/13/18 17:28, Daniel P. Berrangé wrote: > > On Fri, Feb 09, 2018 at 07:12:59PM +, Shaun Reitan wrote: > >> QEMU leaves the pidfile behind on a clean exit when using the option > >> -pidfile /var/run/qemu.pid. > >> > >> Should

[Qemu-devel] [PATCH] RAMList: replace QemuMutex with CompatGMutex

2018-02-14 Thread Zihan Yang
change the mutex member in RAMList structure from QemuMutex to CompatGMutex. qemu_mutex_init() is just deleted instead of being replaced with g_mutex_init() because there is no need to do initialize a mutex that is statically allocated. Signed-off-by: Zihan Yang --- exec.c | 5 ++

Re: [Qemu-devel] [qemu-web PATCH] Add a blog post documenting Spectre/Meltdown options for QEMU 2.11.1

2018-02-14 Thread Daniel P . Berrangé
On Tue, Feb 13, 2018 at 06:11:05PM -0600, Michael Roth wrote: > This blog entry is intended as a follow-up to the original entry in > January regarding Spectre/Meltdown and the proposed changes to address > them in the upcoming 2.11.1 release. > > This entry is meant to accompany the 2.11.1 releas

[Qemu-devel] drive-mirroring to nbd is failing with multiple parallel jobs (qemu 2.9 -> 2.11)

2018-02-14 Thread Alexandre DERUMIER
Hi, I currently have failing mirroring jobs to nbd, when multiple jobs are running in parallel. step to reproduce, with 2 disks: 1) launch mirroring job of first disk to remote target nbd.(to qemu running target) 2) wait until is reach ready = 1 , do not complete 3) launch mirroring job of

Re: [Qemu-devel] [qemu-web PATCH] Add a blog post documenting Spectre/Meltdown options for QEMU 2.11.1

2018-02-14 Thread Thomas Huth
On 14.02.2018 01:11, Michael Roth wrote: > This blog entry is intended as a follow-up to the original entry in > January regarding Spectre/Meltdown and the proposed changes to address > them in the upcoming 2.11.1 release. > > This entry is meant to accompany the 2.11.1 release (planned for > 2018

Re: [Qemu-devel] [qemu-web PATCH] Add a blog post documenting Spectre/Meltdown options for QEMU 2.11.1

2018-02-14 Thread Cornelia Huck
On Tue, 13 Feb 2018 18:11:05 -0600 Michael Roth wrote: > This blog entry is intended as a follow-up to the original entry in > January regarding Spectre/Meltdown and the proposed changes to address > them in the upcoming 2.11.1 release. > > This entry is meant to accompany the 2.11.1 release (pl

Re: [Qemu-devel] block_status automatically added flags

2018-02-14 Thread Vladimir Sementsov-Ogievskiy
13.02.2018 21:48, Eric Blake wrote: On 02/13/2018 11:36 AM, Vladimir Sementsov-Ogievskiy wrote: Hi Eric! I'm now testing my nbd block status realization (block_status part, not about dirty bitmaps), and faced into the following effect. I created empty qcow2 image and wrote to the first secto

Re: [Qemu-devel] [qemu-web PATCH] Add a blog post documenting Spectre/Meltdown options for QEMU 2.11.1

2018-02-14 Thread Christian Borntraeger
On 02/14/2018 10:11 AM, Cornelia Huck wrote: > On Tue, 13 Feb 2018 18:11:05 -0600 > Michael Roth wrote: > >> This blog entry is intended as a follow-up to the original entry in >> January regarding Spectre/Meltdown and the proposed changes to address >> them in the upcoming 2.11.1 release. >> >

Re: [Qemu-devel] [RFC PATCH v6 00/20] replay additions

2018-02-14 Thread Pavel Dovgalyuk
> From: Ciro Santilli [mailto:ciro.santi...@gmail.com] > The patch 23bdb6f7ce73c33f96449e43b4cae01e55f79ae1 appears to be > segfaulting `qemu-img` at `replay_mutex_lock`. Thanks, fixed. > > The problem does not happen on the patch base > bc2943d6caf787e1c9a5f3109cdb98f37630b89e > > The command

Re: [Qemu-devel] [qemu-web PATCH] Add a blog post documenting Spectre/Meltdown options for QEMU 2.11.1

2018-02-14 Thread Cornelia Huck
On Wed, 14 Feb 2018 10:05:24 +0100 Thomas Huth wrote: > On 14.02.2018 01:11, Michael Roth wrote: > > +## enabling mitigations for s390 KVM guests > > + > > +For s390 guests there are 2 CPU options relating to Spectre/Meltdown: > > + > > +* bpb: Branch prediction blocking > > +* ppa15: PPA15 is i

Re: [Qemu-devel] [PATCHv2 1/3] qmp: expose s390-specific CPU info

2018-02-14 Thread Christian Borntraeger
On 02/13/2018 06:18 PM, Viktor Mihajlovski wrote: > Presently s390x is the only architecture not exposing specific > CPU information via QMP query-cpus. Upstream discussion has shown > that it could make sense to report the architecture specific CPU > state, e.g. to detect that a CPU has been sto

Re: [Qemu-devel] [PATCH] migration: improve documentation of postcopy-ram

2018-02-14 Thread Greg Kurz
On Wed, 7 Feb 2018 15:55:01 + "Dr. David Alan Gilbert" wrote: > * Greg Kurz (gr...@kaod.org) wrote: > > This capability must have the same value on both source and destination, > > otherwise migration fails (commit 875fcd013ab6 "migration: incoming > > postcopy advise sanity checks"). > > >

[Qemu-devel] [Bug 1254786] Re: qemu-m68k-static: illegal instruction ebc0 during debootstrap second stage

2018-02-14 Thread Thomas Huth
** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1254786 Title: qemu-m68k-static: illegal instruction ebc0 during debootstrap second sta

Re: [Qemu-devel] drive-mirroring to nbd is failing with multiple parallel jobs (qemu 2.9 -> 2.11)

2018-02-14 Thread Alexandre DERUMIER
Sorry, I just find that the problem is in our proxmox implementation, as we use a socat tunnel for the nbd mirroring, with a timeout of 30s in case of inactivity. So, not a qemu bug. Regards, Alexandre - Mail original - De: "aderumier" À: "qemu-devel" Envoyé: Mercredi 14 Février 201

Re: [Qemu-devel] [PATCHv2 1/3] qmp: expose s390-specific CPU info

2018-02-14 Thread David Hildenbrand
On 13.02.2018 18:18, Viktor Mihajlovski wrote: > Presently s390x is the only architecture not exposing specific > CPU information via QMP query-cpus. Upstream discussion has shown > that it could make sense to report the architecture specific CPU > state, e.g. to detect that a CPU has been stopped.

Re: [Qemu-devel] [qemu-web PATCH] Add a blog post documenting Spectre/Meltdown options for QEMU 2.11.1

2018-02-14 Thread David Hildenbrand
On 14.02.2018 10:18, Christian Borntraeger wrote: > > > On 02/14/2018 10:11 AM, Cornelia Huck wrote: >> On Tue, 13 Feb 2018 18:11:05 -0600 >> Michael Roth wrote: >> >>> This blog entry is intended as a follow-up to the original entry in >>> January regarding Spectre/Meltdown and the proposed cha

Re: [Qemu-devel] [PATCH] migration: improve documentation of postcopy-ram

2018-02-14 Thread Dr. David Alan Gilbert
* Greg Kurz (gr...@kaod.org) wrote: > On Wed, 7 Feb 2018 15:55:01 + > "Dr. David Alan Gilbert" wrote: > > > * Greg Kurz (gr...@kaod.org) wrote: > > > This capability must have the same value on both source and destination, > > > otherwise migration fails (commit 875fcd013ab6 "migration: incom

Re: [Qemu-devel] [PATCHv2 2/3] qmp: add query-cpus-fast

2018-02-14 Thread Cornelia Huck
On Tue, 13 Feb 2018 18:18:47 +0100 Viktor Mihajlovski wrote: > From: Luiz Capitulino > > The query-cpus command has an extremely serious side effect: > it always interrupts all running vCPUs so that they can run > ioctl calls. This can cause a huge performance degradation for > some workloads.

Re: [Qemu-devel] [PATCH] RAMList: replace QemuMutex with CompatGMutex

2018-02-14 Thread Paolo Bonzini
On 14/02/2018 09:49, Zihan Yang wrote: > change the mutex member in RAMList structure from QemuMutex to CompatGMutex. > qemu_mutex_init() is just deleted instead of being replaced with > g_mutex_init() > because there is no need to do initialize a mutex that is statically > allocated. > > Signed

Re: [Qemu-devel] [PATCHv2 3/3] qmp: add architecture specific cpu data for query-cpus-fast

2018-02-14 Thread Cornelia Huck
On Tue, 13 Feb 2018 18:18:48 +0100 Viktor Mihajlovski wrote: > The s390 CPU state can be retrieved without interrupting the > VM execution. Extendend the CpuInfoFast union with architecture > specific data and an implementation for s390. > > Return data looks like this: > [ >{"thread-id":64

Re: [Qemu-devel] [PATCH] migration/xen: Check return value of qemu_fclose

2018-02-14 Thread Dr. David Alan Gilbert
* Ross Lagerwall (ross.lagerw...@citrix.com) wrote: > QEMUFile uses buffered IO so when writing small amounts (such as the Xen > device state file), the actual write call and any errors that may occur > only happen as part of qemu_fclose(). Therefore, report IO errors when > saving the device state

Re: [Qemu-devel] [PATCH] migration: improve documentation of postcopy-ram

2018-02-14 Thread Greg Kurz
On Wed, 14 Feb 2018 09:45:50 + "Dr. David Alan Gilbert" wrote: > * Greg Kurz (gr...@kaod.org) wrote: > > On Wed, 7 Feb 2018 15:55:01 + > > "Dr. David Alan Gilbert" wrote: > > > > > * Greg Kurz (gr...@kaod.org) wrote: > > > > This capability must have the same value on both source an

Re: [Qemu-devel] [qemu-web PATCH] Add a blog post documenting Spectre/Meltdown options for QEMU 2.11.1

2018-02-14 Thread Paolo Bonzini
On 14/02/2018 09:51, Daniel P. Berrangé wrote: >> +Please note that, as mentioned in the previous blog post, QEMU/KVM generally >> +has the same requirements as other unpriviledged processes running on the >> +host WRT Spectre/Meltdown mitigation. > > Is this actually still considered accurate wrt

Re: [Qemu-devel] [PATCH/RFC 3/5] hw/arm/virt: Allow dynamic sysbus devices again

2018-02-14 Thread Auger Eric
Hi Geert, On 09/02/18 16:17, Geert Uytterhoeven wrote: > Allow the instantation of generic dynamic sysbus devices again, without > the need to create a new device-specific vfio type. > > This is a partial revert of commit 6f2062b9758ebc64 ("hw/arm/virt: > Allow only supported dynamic sysbus devic

[Qemu-devel] [PULL 1/1] m68k: implement movep instruction

2018-02-14 Thread Laurent Vivier
From: Pavel Dovgalyuk This patch implements movep instruction. It moves data between a data register and alternate bytes within the address space starting at the location specified and incrementing by two. It was designed for the original 68000 and used in firmwares for interfacing the 8-bit per

[Qemu-devel] [PULL 0/1] M68k for 2.12 patches

2018-02-14 Thread Laurent Vivier
The following changes since commit bec9c64ef7be8063f1192608b83877bc5c9ea217: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2018-02-13 18:24:08 +) are available in the Git repository at: git://github.com/vivier/qemu-m68k.git tags/m68k-for-2.12-pull-reques

Re: [Qemu-devel] [PATCH/RFC 5/5] hw/arm/sysbus-fdt: Enable rcar-gen3-gpio dynamic instantiation

2018-02-14 Thread Auger Eric
Hi Geert, On 09/02/18 16:17, Geert Uytterhoeven wrote: > Allow the instantiation of a Renesas R-Car Gen3 GPIO controller device > from the QEMU command line: > > -device vfio-platform,host=,manufacturer=renesas,model=rcar-gen3-gpio > -device > vfio-platform,sysfsdev=,manufacturer=renesas,model=r

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 11/12] s390-ccw: clear pending irqs

2018-02-14 Thread David Hildenbrand
On 05.02.2018 21:57, Collin L. Walling wrote: > It is possible while waiting for multiple types of external > interrupts that we might have pending irqs remaining between > irq consumption and irq disabling. Those interrupts could > propagate to the guest after IPL completes and cause unwanted > be

Re: [Qemu-devel] [PATCHv2 0/3] add query-cpu-fast and related s390 changes

2018-02-14 Thread Cornelia Huck
On Tue, 13 Feb 2018 18:18:45 +0100 Viktor Mihajlovski wrote: > This series consolidates patches around a performance issue > caused by the usage of QMP query-cpus. > > A performance issue was found in an OpenStack environment, where > ceilometer was collecting domain statistics with libvirt. The

[Qemu-devel] [PULL 05/18] libqos: Use explicit QTestState for rtas operations

2018-02-14 Thread Thomas Huth
From: Eric Blake Drop one more client of global_qtest by teaching all rtas test functionality to pass in an explicit QTestState, adjusting all callers. Signed-off-by: Eric Blake Reviewed-by: Thomas Huth [thuth: Use nicer indentation in rtas.h] Signed-off-by: Thomas Huth --- tests/libqos/pci-

[Qemu-devel] [PULL 02/18] libqtest: Use qemu_strtoul()

2018-02-14 Thread Thomas Huth
From: Eric Blake This will keep checkpatch happy when the next patch does code motion. Fix the include order to match HACKING when adding the needed header. Signed-off-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Signed-off-by: Thomas Huth --- tests/libqtest.c

[Qemu-devel] [PULL 04/18] libqos: Use explicit QTestState for fw_cfg operations

2018-02-14 Thread Thomas Huth
From: Eric Blake Drop one more client of global_qtest by teaching all fw_cfg test functionality (invoked through alloc-pc) to pass in an explicit QTestState, adjusting all callers. In particular, fw_cfg-test had to reorder things to create the test state prior to creating the fw_cfg (and drop a

[Qemu-devel] [PULL 01/18] tests: Clean up wait for event

2018-02-14 Thread Thomas Huth
From: Markus Armbruster We still use hacks like qmp("") to wait for an event, even though we have qmp_eventwait() since commit 8fe941f, and qmp_eventwait_ref() since commit 7ffe312. Both commits neglected to convert all the existing hacks. Make up what they missed. Bonus: gets rid of empty for

[Qemu-devel] [PULL 08/18] libqos: Use explicit QTestState for remaining libqos operations

2018-02-14 Thread Thomas Huth
From: Eric Blake Drop one more client of global_qtest by teaching all remaining libqos stragglers to pass in an explicit QTestState. Change the setting of global_qtest from being implicit in libqos' call to qtest_start() to instead be explicit in all clients that are still relying on global_qtes

[Qemu-devel] [PULL 00/18] qtest patches

2018-02-14 Thread Thomas Huth
The following changes since commit bec9c64ef7be8063f1192608b83877bc5c9ea217: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2018-02-13 18:24:08 +) are available in the git repository at: https://github.com/huth/qemu.git tags/pull-request-2018-02-14 for y

[Qemu-devel] [PULL 03/18] libqos: Track QTestState with QPCIBus

2018-02-14 Thread Thomas Huth
From: Eric Blake When initializing a QPCIBus, track which QTestState the bus is associated with (so that a later patch can then explicitly use that test state for all communication on the bus, rather than blindly relying on global_qtest). Update the initialization functions to take another param

[Qemu-devel] [PULL 07/18] libqos: Use explicit QTestState for ahci operations

2018-02-14 Thread Thomas Huth
From: Eric Blake Drop one more client of global_qtest by teaching all ahci test functionality to pass in an explicit QTestState. The state was already available, so no callers had to be adjusted. Signed-off-by: Eric Blake Reviewed-by: John Snow Reviewed-by: Thomas Huth Signed-off-by: Thomas

[Qemu-devel] [PULL 06/18] libqos: Use explicit QTestState for i2c operations

2018-02-14 Thread Thomas Huth
From: Eric Blake Drop one more client of global_qtest by teaching all i2c test functionality to pass in an explicit QTestState, adjusting all callers. Signed-off-by: Eric Blake Reviewed-by: Thomas Huth Signed-off-by: Thomas Huth --- tests/ds1338-test.c | 6 ++--- tests/libqos/i2c-imx.c

[Qemu-devel] [PULL 10/18] tests/boot-sector: Drop dependence on global_qtest

2018-02-14 Thread Thomas Huth
From: Eric Blake As a general rule, we prefer avoiding implicit global state because it makes code harder to safely copy and paste without thinking about the global state. Adjust the helper code to use explicit state instead, and update all callers. Fix some trailing whitespace while touching t

[Qemu-devel] [PULL 13/18] tests/boot-serial: Add tests for PowerPC Mac machines

2018-02-14 Thread Thomas Huth
OpenBIOS prints out the CPU type on these machine types, so we can use this string to test whether the CPU detection is working correctly. Acked-by: Mark Cave-Ayland Reviewed-by: Eric Blake Signed-off-by: Thomas Huth --- tests/boot-serial-test.c | 3 +++ 1 file changed, 3 insertions(+) diff -

[Qemu-devel] [PULL 09/18] qmp-test: Drop dependence on global_qtest

2018-02-14 Thread Thomas Huth
From: Eric Blake As a general rule, we prefer avoiding implicit global state because it makes code harder to safely copy and paste without thinking about the global state. Although qmp-test does not maintain parallel qtest connections, it was the last test assigning to global_qtest. It's just a

[Qemu-devel] [PULL 14/18] tests/boot-serial-test: Add support for the aarch64 virt machine

2018-02-14 Thread Thomas Huth
From: Wei Huang This patch adds a small binary kernel to test aarch64 virt machine's UART. Signed-off-by: Wei Huang Reviewed-by: Eric Blake [thuth: Fixed contextual conflicts with the hppa and sdhci patches] Signed-off-by: Thomas Huth --- tests/Makefile.include | 1 + tests/boot-serial-tes

[Qemu-devel] [PULL 18/18] tests/m48t59: Use the m48t59 test on ppc, too

2018-02-14 Thread Thomas Huth
The ref405ep machine has a memory-mapped m48t59 device, so we can run the m48t59 test on this machine, too. Signed-off-by: Thomas Huth --- tests/Makefile.include | 2 ++ tests/m48t59-test.c| 9 - 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/tests/Makefile.include b/

[Qemu-devel] [PULL 12/18] tests/boot-serial: Enable the boot-serial test on SPARC machines, too

2018-02-14 Thread Thomas Huth
OpenBIOS prints out the name of the detected CPU here, so looking for this string is a nice test to verify that the CPU detection is still working correctly. Acked-by: Mark Cave-Ayland Reviewed-by: Eric Blake Signed-off-by: Thomas Huth --- tests/Makefile.include | 2 ++ tests/boot-serial-tes

[Qemu-devel] [PULL 15/18] tests/m48t59: Fix and re-enable the test for sparc

2018-02-14 Thread Thomas Huth
The m48t59 test has been disabled in commit baeddded5fe6fa37d13fb94bf8d ("sparc: disable qtest in make check"), likely due to some timing issues in the bcd_check_time tests which might fail if it gets interrupted for too long. It should be OK to re-enable this test if we make sure that we do not ru

[Qemu-devel] [PULL 11/18] wdt_ib700-test: Drop dependence on global_qtest

2018-02-14 Thread Thomas Huth
From: Eric Blake As a general rule, we prefer avoiding implicit global state because it makes code harder to safely copy and paste without thinking about the global state. Improve this test to be explicit about the state. Signed-off-by: Eric Blake Reviewed-by: Thomas Huth Signed-off-by: Thoma

[Qemu-devel] [PULL 17/18] tests/Makefile: Derive check-qtest-ppc64-y from check-qtest-ppc-y

2018-02-14 Thread Thomas Huth
ppc64 is a superset of ppc, so the ppc64 tests should include all the ppc tests. Signed-off-by: Thomas Huth --- tests/Makefile.include | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index c27a9a5..95ce99e 100644 ---

[Qemu-devel] [PULL 16/18] tests/m48t59: Make the test independent of global_qtest

2018-02-14 Thread Thomas Huth
Stop using the functions that require global_qtest here and pass around the QTestState instead (global_qtest should finally get removed since this causes problems with tests running in parallel). Reviewed-by: Eric Blake Signed-off-by: Thomas Huth --- tests/m48t59-test.c | 60 +++

Re: [Qemu-devel] [PATCH] RAMList: replace QemuMutex with CompatGMutex

2018-02-14 Thread Zihan Yang
> I'm not sure what is the advantage of this change. QEMU is more or less > uniformly using QemuMutex and QemuCond. I see. QEMU uses some glib functions, like g_new, g_free, g_hash_table , g_assert and g_poll, so I thought there was a trend for making more use of glib. I get the point now. 2018

Re: [Qemu-devel] [PATCH v8 08/21] iscsi: Switch to .bdrv_co_block_status()

2018-02-14 Thread Kevin Wolf
Am 13.02.2018 um 21:26 hat Eric Blake geschrieben: > We are gradually moving away from sector-based interfaces, towards > byte-based. Update the iscsi driver accordingly. In this case, > it is handy to teach iscsi_co_block_status() to handle a NULL map > and file parameter, even though the block

Re: [Qemu-devel] [PATCH v8 09/21] null: Switch to .bdrv_co_block_status()

2018-02-14 Thread Kevin Wolf
Am 13.02.2018 um 21:26 hat Eric Blake geschrieben: > We are gradually moving away from sector-based interfaces, towards > byte-based. Update the null driver accordingly. > > Signed-off-by: Eric Blake > Reviewed-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Fam Zheng > > --- > v6-v7: no chan

Re: [Qemu-devel] [PATCH] RAMList: replace QemuMutex with CompatGMutex

2018-02-14 Thread Paolo Bonzini
On 14/02/2018 12:43, Zihan Yang wrote: > >> I'm not sure what is the advantage of this change.  QEMU is more or less >> uniformly using QemuMutex and QemuCond. > > I see. QEMU uses some glib functions, like g_new, g_free, g_hash_table , > g_assert and g_poll, so I thought there was a trend for ma

Re: [Qemu-devel] [RFC PATCH v6 00/20] replay additions

2018-02-14 Thread Pavel Dovgalyuk
> From: Peter Maydell [mailto:peter.mayd...@linaro.org] > On 13 February 2018 at 10:26, Pavel Dovgalyuk wrote: > > Then I added SCSI adapter with the option –device lsi,id=scsi0 and QEMU > > failed with the following error: > > > > qemu: fatal: IO on conditional branch instruction > > > Seems, th

Re: [Qemu-devel] [PATCH v8 19/21] vpc: Switch to .bdrv_co_block_status()

2018-02-14 Thread Kevin Wolf
Am 13.02.2018 um 21:26 hat Eric Blake geschrieben: > We are gradually moving away from sector-based interfaces, towards > byte-based. Update the vpc driver accordingly. > > Signed-off-by: Eric Blake > Reviewed-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Fam Zheng > > --- > v7: tweak commi

Re: [Qemu-devel] [PATCH v8 20/21] vvfat: Switch to .bdrv_co_block_status()

2018-02-14 Thread Kevin Wolf
Am 13.02.2018 um 21:27 hat Eric Blake geschrieben: > We are gradually moving away from sector-based interfaces, towards > byte-based. Update the vvfat driver accordingly. Note that we > can rely on the block driver having already clamped limits to our > block size, and simplify accordingly. > >

[Qemu-devel] [PATCH v2] device_tree: Increase FDT_MAX_SIZE to 1 MiB

2018-02-14 Thread Geert Uytterhoeven
It is not uncommon for a contemporary FDT to be larger than 64 KiB, leading to failures loading the device tree from sysfs: qemu-system-aarch64: qemu_fdt_setprop: Couldn't set ...: FDT_ERR_NOSPACE Hence increase the limit to 1 MiB, like on PPC. For reference, the largest arm64 DTB created fr

Re: [Qemu-devel] [PATCH 0/5] Block patches

2018-02-14 Thread Stefan Hajnoczi
On Wed, Feb 14, 2018 at 08:48:20AM +0800, Fam Zheng wrote: > On Tue, 02/13 17:34, Stefan Hajnoczi wrote: > > The following changes since commit fb68096da3d35e64c88cd610c1fa42766c58e92a: > > > > Revert "tests: use memfd in vhost-user-test" (2018-02-13 09:51:52 +) > > > > are available in the

Re: [Qemu-devel] [PATCH 1/5] Add a git-publish configuration file

2018-02-14 Thread Stefan Hajnoczi
On Wed, Feb 14, 2018 at 09:01:11AM +0800, Fam Zheng wrote: > On Tue, 02/13 18:09, Daniel P. Berrangé wrote: > > On Tue, Feb 13, 2018 at 05:34:25PM +, Stefan Hajnoczi wrote: > > > +[gitpublishprofile "block"] > > > +base = master > > > +prefix = PATCH > > > +to = qemu-devel@nongnu.org > > > +cc

[Qemu-devel] bus= and host= documentation missing virtio-net-pci

2018-02-14 Thread Robert White
I need to hook up a net device via virtio-net-pci such as 03:10.1 and there is documentation for addr=10.1 but there is no information on how to provide the 03 part. There's clearly a bus= item but nothing seems to work. I've tried bus=3 bus=03 bus=pcie.3 and a good number of other things. The su

[Qemu-devel] [Bug 1749393] [NEW] sbrk() not working under qemu-user with a PIE-compiled binary?

2018-02-14 Thread Raphaël Hertzog
Public bug reported: In Debian unstable, we recently switched bash to be a PIE-compiled binary (for hardening). Unfortunately this resulted in bash being broken when run under qemu-user (for all target architectures, host being amd64 for me). $ sudo chroot /srv/chroots/sid-i386/ qemu-i386-static

Re: [Qemu-devel] [Qemu-ppc] [QEMU-PPC] [PATCH V2 1/3] ppc/spapr-caps: Change migration macro to take full spapr-cap name

2018-02-14 Thread Greg Kurz
On Wed, 14 Feb 2018 17:51:33 +1100 Suraj Jitindar Singh wrote: > Change the macro that generates the vmstate migration field and the needed > function for the spapr-caps to take the full spapr-cap name. This has > the benefit of meaning this instance will be picked up when greping > for the spapr

Re: [Qemu-devel] [PATCH 1/5] Add a git-publish configuration file

2018-02-14 Thread Fam Zheng
On Wed, Feb 14, 2018 at 9:34 PM, Stefan Hajnoczi wrote: > On Wed, Feb 14, 2018 at 09:01:11AM +0800, Fam Zheng wrote: > Fam, if you want it dropped, let me know. Otherwise, we can leave it > in if there is no further discussion. Yeah, I think we can drop block/arm/s390/ppc and rely on get_maintai

Re: [Qemu-devel] Assigning network devices to nested VMs results in driver errors in nested VMs

2018-02-14 Thread Jintack Lim
On Wed, Feb 14, 2018 at 12:36 AM, Peter Xu wrote: > On Tue, Feb 13, 2018 at 11:44:09PM -0500, Jintack Lim wrote: >> Hi, >> >> I'm trying to assign network devices to nested VMs on x86 using KVM, >> but I got network device driver errors in the nested VMs. (I've tried >> this about an year ago when

Re: [Qemu-devel] [PATCHv2 0/3] add query-cpu-fast and related s390 changes

2018-02-14 Thread Viktor Mihajlovski
On 14.02.2018 11:57, Cornelia Huck wrote: [...] > > How shall we proceed with this series? Patch 3 depends upon patch 1, so > I think it makes sense to merge this in one go. > > I can give my R-b on patch 1 and Someone(tm) can merge this, or I can > take the whole series through the s390 tree (wi

Re: [Qemu-devel] [PATCH v2 1/4] block: extract AIO_WAIT_WHILE() from BlockDriverState

2018-02-14 Thread Stefan Hajnoczi
On Tue, Feb 13, 2018 at 10:01:06AM -0600, Eric Blake wrote: > Trying to understand here: > > > > +#define AIO_WAIT_WHILE(wait, ctx, cond) ({ \ > > +bool waited_ = false; \ > > +bool busy_ = true; \ > >

Re: [Qemu-devel] [PATCH 1/5] Add a git-publish configuration file

2018-02-14 Thread Paolo Bonzini
On 13/02/2018 19:09, Daniel P. Berrangé wrote: > Why is a custom entry needed for block here (and other things > below). Won't running get_maintainer.pl already correctly > report when a patch needs cc'ing to qemu-bl...@nongnu.org > based on MAINTAINER rules ? Sometimes you want to CC block peop

Re: [Qemu-devel] [PATCH 0/5] Block patches

2018-02-14 Thread Fam Zheng
On Wed, Feb 14, 2018 at 9:25 PM, Stefan Hajnoczi wrote: > On Wed, Feb 14, 2018 at 08:48:20AM +0800, Fam Zheng wrote: >> On Tue, 02/13 17:34, Stefan Hajnoczi wrote: >> > The following changes since commit >> > fb68096da3d35e64c88cd610c1fa42766c58e92a: >> > >> > Revert "tests: use memfd in vhost-

Re: [Qemu-devel] [Qemu-ppc] [QEMU-PPC] [PATCH V2 2/3] ppc/spapr-caps: Convert spapr-cap-ibs to be a boolean

2018-02-14 Thread Greg Kurz
On Wed, 14 Feb 2018 17:51:34 +1100 Suraj Jitindar Singh wrote: > The spapr-cap cap-ibs can only have values broken or fixed as there is > no workaround. Currently setting the value workaround will hit an assert > if the guest makes the hcall h_get_cpu_characteristics. > > Thus this capability is

Re: [Qemu-devel] [PATCH V10 3/9] include/standard-headers: add pvrdma related headers

2018-02-14 Thread Gal Hammer
Hi, I'm not familiar with the pvrdma device itself, but I reviewed the changes to the update-linux-headers.sh script. Reviewed-by: Gal Hammer Gal. On Mon, Feb 12, 2018 at 8:08 PM, Marcel Apfelbaum wrote: > Also modify update-linux-headers.sh script to manage > the headers needed by the p

Re: [Qemu-devel] [Qemu-ppc] [QEMU-PPC] [PATCH V2 3/3] ppc/spapr-caps: For pseries-2.12 change spapr-cap defaults

2018-02-14 Thread Greg Kurz
On Wed, 14 Feb 2018 17:51:35 +1100 Suraj Jitindar Singh wrote: > For the pseries-2.12 machine type, make the spapr-caps SPAPR_CAP_CFPC > and SPAPR_CAP_SBBC default to workaround. Thus if the host is capable > the guest will be able to take advantage of these workarounds by default. > Otherwise if

Re: [Qemu-devel] [PATCH 1/5] Add a git-publish configuration file

2018-02-14 Thread Paolo Bonzini
On 14/02/2018 15:08, Paolo Bonzini wrote: > On 13/02/2018 19:09, Daniel P. Berrangé wrote: >> Why is a custom entry needed for block here (and other things >> below). Won't running get_maintainer.pl already correctly >> report when a patch needs cc'ing to qemu-bl...@nongnu.org >> based on MAINTAI

Re: [Qemu-devel] [PATCH v8 08/21] iscsi: Switch to .bdrv_co_block_status()

2018-02-14 Thread Eric Blake
On 02/14/2018 05:53 AM, Kevin Wolf wrote: Am 13.02.2018 um 21:26 hat Eric Blake geschrieben: We are gradually moving away from sector-based interfaces, towards byte-based. Update the iscsi driver accordingly. In this case, it is handy to teach iscsi_co_block_status() to handle a NULL map and f

[Qemu-devel] BLOCK_STATUS extension

2018-02-14 Thread Vladimir Sementsov-Ogievskiy
Hi all. Just note: looks like we allow zero-sized metadata context name. Is it ok? * |NBD_REP_META_CONTEXT| (4) A description of a metadata context. Data: o 32 bits, NBD metadata context ID. o String, name of the metadata context. This is not required to be a human-rea

Re: [Qemu-devel] [PATCH v3] vnc: fix segfault in closed connection handling

2018-02-14 Thread Klim Kireev
ping On 02/07/2018 12:48 PM, Klim Kireev wrote: On one of our client's node, due to trying to read from closed ioc, a segmentation fault occured. Corresponding backtrace: 0 object_get_class (obj=obj@entry=0x0) 1 qio_channel_readv_full (ioc=0x0, iov=0x7ffe55277180 ... 2 qio_channel_read (ioc=

Re: [Qemu-devel] [PATCH v8 09/21] null: Switch to .bdrv_co_block_status()

2018-02-14 Thread Eric Blake
On 02/14/2018 06:05 AM, Kevin Wolf wrote: Am 13.02.2018 um 21:26 hat Eric Blake geschrieben: We are gradually moving away from sector-based interfaces, towards byte-based. Update the null driver accordingly. Signed-off-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Fam

Re: [Qemu-devel] [PATCH v8 20/21] vvfat: Switch to .bdrv_co_block_status()

2018-02-14 Thread Eric Blake
On 02/14/2018 07:12 AM, Kevin Wolf wrote: Am 13.02.2018 um 21:27 hat Eric Blake geschrieben: We are gradually moving away from sector-based interfaces, towards byte-based. Update the vvfat driver accordingly. Note that we can rely on the block driver having already clamped limits to our block

Re: [Qemu-devel] [PATCH v8 19/21] vpc: Switch to .bdrv_co_block_status()

2018-02-14 Thread Eric Blake
On 02/14/2018 07:08 AM, Kevin Wolf wrote: Am 13.02.2018 um 21:26 hat Eric Blake geschrieben: We are gradually moving away from sector-based interfaces, towards byte-based. Update the vpc driver accordingly. Signed-off-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Fam

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 05/12] s390-ccw: move auxiliary IPL data to separate location

2018-02-14 Thread Collin L. Walling
On 02/06/2018 05:13 AM, Viktor Mihajlovski wrote: On 06.02.2018 10:23, Thomas Huth wrote: On 05.02.2018 21:57, Collin L. Walling wrote: [...] diff --git a/pc-bios/s390-ccw/main.c b/pc-bios/s390-ccw/main.c index e857ce4..825a1a3 100644 --- a/pc-bios/s390-ccw/main.c +++ b/pc-bios/s390-ccw/main.c

Re: [Qemu-devel] [PATCH v8 09/21] null: Switch to .bdrv_co_block_status()

2018-02-14 Thread Kevin Wolf
Am 14.02.2018 um 15:44 hat Eric Blake geschrieben: > On 02/14/2018 06:05 AM, Kevin Wolf wrote: > > Am 13.02.2018 um 21:26 hat Eric Blake geschrieben: > > > We are gradually moving away from sector-based interfaces, towards > > > byte-based. Update the null driver accordingly. > > > > > > Signed-o

Re: [Qemu-devel] BLOCK_STATUS extension

2018-02-14 Thread Eric Blake
[using the updated nbd list email] On 02/14/2018 08:35 AM, Vladimir Sementsov-Ogievskiy wrote: Hi all. Just note: looks like we allow zero-sized metadata context name. Is it ok?  *    |NBD_REP_META_CONTEXT| (4)    A description of a metadata context. Data: o 32 bits, NBD metadata c

Re: [Qemu-devel] [qemu-web PATCH] Add a blog post documenting Spectre/Meltdown options for QEMU 2.11.1

2018-02-14 Thread Michael Roth
Quoting Paolo Bonzini (2018-02-14 04:33:29) > On 14/02/2018 09:51, Daniel P. Berrangé wrote: > >> +Please note that, as mentioned in the previous blog post, QEMU/KVM > >> generally > >> +has the same requirements as other unpriviledged processes running on the > >> +host WRT Spectre/Meltdown mitig

Re: [Qemu-devel] [PATCH v8 20/21] vvfat: Switch to .bdrv_co_block_status()

2018-02-14 Thread Kevin Wolf
Am 14.02.2018 um 15:50 hat Eric Blake geschrieben: > On 02/14/2018 07:12 AM, Kevin Wolf wrote: > > Am 13.02.2018 um 21:27 hat Eric Blake geschrieben: > > > We are gradually moving away from sector-based interfaces, towards > > > byte-based. Update the vvfat driver accordingly. Note that we > > >

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 05/12] s390-ccw: move auxiliary IPL data to separate location

2018-02-14 Thread Christian Borntraeger
On 02/14/2018 03:51 PM, Collin L. Walling wrote: > On 02/06/2018 05:13 AM, Viktor Mihajlovski wrote: >> On 06.02.2018 10:23, Thomas Huth wrote: >>> On 05.02.2018 21:57, Collin L. Walling wrote: >>> [...] diff --git a/pc-bios/s390-ccw/main.c b/pc-bios/s390-ccw/main.c index e857ce4..825a1

Re: [Qemu-devel] drive-mirroring to nbd is failing with multiple parallel jobs (qemu 2.9 -> 2.11)

2018-02-14 Thread Eric Blake
[adding nbd list] On 02/14/2018 03:45 AM, Alexandre DERUMIER wrote: Sorry, I just find that the problem is in our proxmox implementation, as we use a socat tunnel for the nbd mirroring, with a timeout of 30s in case of inactivity. So, not a qemu bug. Good to hear. Still, it makes me wonder

[Qemu-devel] [PULL 04/10] migration: Fix early failure cleanup

2018-02-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Avoid crash in cleanup after a very early migration failure (possibly due to my 688a3dcba980bf01344a 'Route errors down ...') Signed-off-by: Dr. David Alan Gilbert Message-Id: <20180212160340.15333-2-dgilb...@redhat.com> Signed-off-by: Dr. David Alan Gilbert Rev

[Qemu-devel] [PULL 07/10] migration: reuse mis->userfault_quit_fd

2018-02-14 Thread Dr. David Alan Gilbert (git)
From: Peter Xu It was only used for quitting the page fault thread before. Let it be something more useful - now we can use it to notify a "wake" for the page fault thread (for any reason), and it only means "quit" if the fault_thread_quit is set. Since we changed what it does, renaming it to us

[Qemu-devel] [PULL 01/10] migration/xen: Check return value of qemu_fclose

2018-02-14 Thread Dr. David Alan Gilbert (git)
From: Ross Lagerwall QEMUFile uses buffered IO so when writing small amounts (such as the Xen device state file), the actual write call and any errors that may occur only happen as part of qemu_fclose(). Therefore, report IO errors when saving the device state under Xen by checking the return val

[Qemu-devel] [PULL 05/10] tests/migration: Add test for migration to bad destination

2018-02-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Check the source survives. Signed-off-by: Dr. David Alan Gilbert Message-Id: <20180212160340.15333-3-dgilb...@redhat.com> Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- tests/migration-test.c | 65 ++-

[Qemu-devel] [PULL 02/10] migration: improve documentation of postcopy-ram

2018-02-14 Thread Dr. David Alan Gilbert (git)
From: Greg Kurz This capability must have the same value on both source and destination, otherwise migration fails (commit 875fcd013ab6 "migration: incoming postcopy advise sanity checks"). Let's write it down in various places where postcopy-ram is documented. Signed-off-by: Greg Kurz Message

[Qemu-devel] [PULL 00/10] migration queue

2018-02-14 Thread Dr. David Alan Gilbert (git)
b.com/dagrh/qemu.git tags/pull-migration-20180214a for you to fetch changes up to 3e0c8050ebba3f55dc2d92b3790a3cfb80786d07: migration: pass MigrationState to migrate_init() (2018-02-14 10:37:09 +) Migration pull 20180214 Note th

[Qemu-devel] [PULL 10/10] migration: pass MigrationState to migrate_init()

2018-02-14 Thread Dr. David Alan Gilbert (git)
From: Peter Xu Let the callers take the object, then pass it to migrate_init(). Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu Message-Id: <20180208103132.28452-12-pet...@redhat.com> Signed-off-by: Dr. David Alan Gilbert --- migration/migration.c | 7 ++- migration/migration

[Qemu-devel] [PULL 06/10] migration: better error handling with QEMUFile

2018-02-14 Thread Dr. David Alan Gilbert (git)
From: Peter Xu If the postcopy down due to some reason, we can always see this on dst: qemu-system-x86_64: RP: Received invalid message 0x length 0x However in most cases that's not the real issue. The problem is that qemu_get_be16() has no way to show whether the returned data is val

[Qemu-devel] [PULL 03/10] tests/migration: Add source to PC boot block

2018-02-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The boot block used in the migration test is currently only shipped as a hex (with the source in the git commit message of ea0c6d62), change this to actually include the source. A script is added to rebuild the header but the expectation is that the generated hex i

[Qemu-devel] [PULL 09/10] migration: allow send_rq to fail

2018-02-14 Thread Dr. David Alan Gilbert (git)
From: Peter Xu We will not allow failures to happen when sending data from destination to source via the return path. However it is possible that there can be errors along the way. This patch allows the migrate_send_rp_message() to return error when it happens, and further extended it to migrate

Re: [Qemu-devel] [PATCH] vnc: fix segfault in closed connection handling

2018-02-14 Thread Daniel P . Berrangé
On Wed, Feb 07, 2018 at 12:48:44PM +0300, Klim Kireev wrote: > On one of our client's node, due to trying to read from closed ioc, > a segmentation fault occured. Corresponding backtrace: > > 0 object_get_class (obj=obj@entry=0x0) > 1 qio_channel_readv_full (ioc=0x0, iov=0x7ffe55277180 ... > 2

[Qemu-devel] [PULL 08/10] migration: provide postcopy_fault_thread_notify()

2018-02-14 Thread Dr. David Alan Gilbert (git)
From: Peter Xu A general helper to notify the fault thread. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu Message-Id: <20180208103132.28452-4-pet...@redhat.com> Signed-off-by: Dr. David Alan Gilbert --- migration/postcopy-ram.c | 35 --- migratio

Re: [Qemu-devel] [PATCH 1/5] Add a git-publish configuration file

2018-02-14 Thread Eric Blake
On 02/14/2018 07:34 AM, Stefan Hajnoczi wrote: On Wed, Feb 14, 2018 at 09:01:11AM +0800, Fam Zheng wrote: On Tue, 02/13 18:09, Daniel P. Berrangé wrote: On Tue, Feb 13, 2018 at 05:34:25PM +, Stefan Hajnoczi wrote: +[gitpublishprofile "block"] +base = master +prefix = PATCH +to = qemu-devel

Re: [Qemu-devel] [PATCHv2 0/3] add query-cpu-fast and related s390 changes

2018-02-14 Thread Eric Blake
On 02/14/2018 04:57 AM, Cornelia Huck wrote: On Tue, 13 Feb 2018 18:18:45 +0100 Viktor Mihajlovski wrote: Patch 1/3: Adds architecture specific data to the QMP CpuInfo type, exposing the existing s390 cpu-state in QMP. The cpu-state is a representation more adequate than the ambiguo

  1   2   3   >