Re: [Qemu-devel] [PATCH v6] s390x/cpu: expose the guest crash information

2018-02-08 Thread Cornelia Huck
On Wed, 7 Feb 2018 19:15:22 +0100 Christian Borntraeger wrote: > On 02/07/2018 05:58 PM, Cornelia Huck wrote: > > > > >> +## > >> +# @S390CrashReason: > >> +# > >> +# Reason why the CPU is in a crashed state. > >> +# > >> +# @unknown: no crash reason was set > >> +# > >> +# @disabledwait: the

[Qemu-devel] [RESEND PATCH] PPC: e500: Fix duplicate kernel load and device tree overlap

2018-02-08 Thread David Engraf
This patch fixes an incorrect behavior when the -kernel argument has been specified without -bios. In this case the kernel was loaded twice. At address 32M as a raw image and afterwards by load_elf/load_uimage at the corresponding load address. In this case the region for the device tree and the ra

Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr: check smp_threads < vsmt

2018-02-08 Thread Laurent Vivier
On 07/02/2018 21:21, Greg Kurz wrote: > On Wed, 7 Feb 2018 17:17:30 +0100 > Laurent Vivier wrote: > >> We ignore silently the value of smp_threads when we set >> the VSMT value, and if smp_threads is greater than VSMT >> kernel is going into trouble later. >> >> Fixes: 8904e5a750 >> ("spapr: Adj

Re: [Qemu-devel] [PATCH 2/2] qmp: document query-cpus performance issue

2018-02-08 Thread Daniel P . Berrangé
On Wed, Feb 07, 2018 at 12:50:14PM -0500, Luiz Capitulino wrote: > Signed-off-by: Luiz Capitulino > --- > qapi-schema.json | 4 > 1 file changed, 4 insertions(+) > > diff --git a/qapi-schema.json b/qapi-schema.json > index 82d6f12b53..0665a14dba 100644 > --- a/qapi-schema.json > +++ b/qapi-

[Qemu-devel] [PATCH v2] spapr: check smp_threads <= vsmt

2018-02-08 Thread Laurent Vivier
We ignore silently the value of smp_threads when we set the default VSMT value, and if smp_threads is greater than VSMT kernel is going into trouble later. Fixes: 8904e5a750 ("spapr: Adjust default VSMT value for better migration compatibility") Signed-off-by: Laurent Vivier --- Notes: v2:

[Qemu-devel] [PATCH] target-i386: adds PV_DEDICATED hint CPUID feature bit

2018-02-08 Thread Wanpeng Li
From: Wanpeng Li Add PV_DEDICATED hint cpuid feature bit. Cc: Paolo Bonzini Cc: Radim Krčmář Cc: Eduardo Habkost Signed-off-by: Wanpeng Li --- target/i386/cpu.c | 4 target/i386/cpu.h | 3 +++ 2 files changed, 7 insertions(+) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index d7

[Qemu-devel] [PATCH] S390: Expose s390-specific CPU info

2018-02-08 Thread Viktor Mihajlovski
Presently s390x is the only architecture not exposing specific CPU information via QMP query-cpus. Upstream discussion has shown that it could make sense to report the architecture specific CPU state, e.g. to detect that a CPU has been stopped. With this change the output of query-cpus will look l

Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration

2018-02-08 Thread Igor Mammedov
On Thu, 8 Feb 2018 09:20:45 +0800 "Tan, Jianfeng" wrote: > On 2/7/2018 8:06 PM, Igor Mammedov wrote: > > On Wed, 7 Feb 2018 07:49:58 + > > "Tan, Jianfeng" wrote: > > > >>> -Original Message- > >>> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > >>> Sent: Tuesday, February 6, 201

Re: [Qemu-devel] [patch] linux-user/syscall.c: Fix missing break for host_to_target_cmsg

2018-02-08 Thread Nageswara R Sastry
On 2018-02-07 19:27, Laurent Vivier wrote: Le 07/02/2018 à 10:49, no-re...@patchew.org a écrit : Hi, This series failed build test on s390x host. Please find the details below. ... CC aarch64_be-linux-user/linux-user/syscall.o In file included from /var/tmp/patchew-tester-tmp-ewjgn08

Re: [Qemu-devel] [PATCH RFC 06/21] qapi-gen: New common driver for code and doc generators

2018-02-08 Thread Markus Armbruster
Markus Armbruster writes: > Marc-Andre Lureau writes: > >> On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster wrote: [...] >>> diff --git a/scripts/qapi2texi.py b/scripts/qapi/doc.py >>> old mode 100755 >>> new mode 100644 >>> similarity index 92% >>> rename from scripts/qapi2texi.py >>> rename

[Qemu-devel] [PATCH v7] s390x/cpu: expose the guest crash information

2018-02-08 Thread Christian Borntraeger
This patch is the s390 implementation of guest crash information, similar to commit d187e08dc4 ("i386/cpu: add crash-information QOM property") and the related commits. We will detect several crash reasons, with the "disabled wait" being the most important one, since this is used by all s390 guests

[Qemu-devel] Questions regarding how QEMU initializes virtual peripherals

2018-02-08 Thread Ramy Sameh
Hello all, I am working with QEMU to simulate VersatilePB board. I am trying to understand how QEMU initialize the virtual peripherals (e.g. UART, vectored Interrupt controller .. etc). When I traced the code, I found a function called "object_init_with_type" in object.c, in which the function p

Re: [Qemu-devel] [Qemu-block] [PATCH] block: early check for blockers on drive-mirror

2018-02-08 Thread Alberto Garcia
On Wed 07 Feb 2018 05:29:20 PM CET, Paolo Bonzini wrote: > Even if an op blocker is present for BLOCK_OP_TYPE_MIRROR_SOURCE, > it is checked a bit late and the result is that the target is > created even if drive-mirror subsequently fails. Add an early > check to avoid this. > > Signed-off-by: Pao

Re: [Qemu-devel] [PATCH 1/2] qmp: add query-cpus-fast

2018-02-08 Thread Viktor Mihajlovski
On 08.02.2018 08:41, Viktor Mihajlovski wrote: > On 07.02.2018 18:50, Luiz Capitulino wrote: >> The query-cpus command has an extremely serious side effect: >> it always interrupt all running vCPUs so that they can run >> ioctl calls. This can cause a huge performance degradation for >> some worklo

Re: [Qemu-devel] [PATCH] S390: Expose s390-specific CPU info

2018-02-08 Thread Cornelia Huck
On Thu, 8 Feb 2018 10:48:08 +0100 Viktor Mihajlovski wrote: [added some cc:s] > Presently s390x is the only architecture not exposing specific > CPU information via QMP query-cpus. Upstream discussion has shown > that it could make sense to report the architecture specific CPU > state, e.g. to

Re: [Qemu-devel] [PULL 0/1] Ide patches

2018-02-08 Thread Peter Maydell
On 7 February 2018 at 16:33, John Snow wrote: > The following changes since commit 0833df03f4206a6cf416fbb3d380fa95c8e61fba: > > Merge remote-tracking branch > 'remotes/dgilbert/tags/pull-migration-20180206a' into staging (2018-02-07 > 12:07:23 +) > > are available in the Git repository at

Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration

2018-02-08 Thread Tan, Jianfeng
On 2/8/2018 5:51 PM, Igor Mammedov wrote: On Thu, 8 Feb 2018 09:20:45 +0800 "Tan, Jianfeng" wrote: On 2/7/2018 8:06 PM, Igor Mammedov wrote: On Wed, 7 Feb 2018 07:49:58 + "Tan, Jianfeng" wrote: -Original Message- From: Paolo Bonzini [mailto:pbonz...@redhat.com] Sent: Tuesda

Re: [Qemu-devel] [PATCH] S390: Expose s390-specific CPU info

2018-02-08 Thread Christian Borntraeger
On 02/08/2018 11:16 AM, Cornelia Huck wrote: > On Thu, 8 Feb 2018 10:48:08 +0100 > Viktor Mihajlovski wrote: > > [added some cc:s] > >> Presently s390x is the only architecture not exposing specific >> CPU information via QMP query-cpus. Upstream discussion has shown >> that it could make sen

Re: [Qemu-devel] [PATCH v4 03/22] RISC-V CPU Core Definition

2018-02-08 Thread Igor Mammedov
On Thu, 8 Feb 2018 15:19:13 +1300 Michael Clark wrote: > On Wed, Feb 7, 2018 at 4:03 AM, Igor Mammedov wrote: > > > On Tue, 6 Feb 2018 11:09:56 +1300 > > Michael Clark wrote: > > > > > On Tue, Feb 6, 2018 at 4:04 AM, Igor Mammedov > > wrote: > > > > > > > On Mon, 5 Feb 2018 19:22:28

[Qemu-devel] [PATCH v6 01/28] migration: better error handling with QEMUFile

2018-02-08 Thread Peter Xu
If the postcopy down due to some reason, we can always see this on dst: qemu-system-x86_64: RP: Received invalid message 0x length 0x However in most cases that's not the real issue. The problem is that qemu_get_be16() has no way to show whether the returned data is valid or not, and we

[Qemu-devel] [PATCH v6 03/28] migration: provide postcopy_fault_thread_notify()

2018-02-08 Thread Peter Xu
A general helper to notify the fault thread. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu --- migration/postcopy-ram.c | 35 --- migration/postcopy-ram.h | 2 ++ 2 files changed, 22 insertions(+), 15 deletions(-) diff --git a/migration/postcopy-r

[Qemu-devel] [PATCH v6 07/28] migration: allow src return path to pause

2018-02-08 Thread Peter Xu
Let the thread pause for network issues. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu --- migration/migration.c | 35 +-- migration/migration.h | 1 + migration/trace-events | 2 ++ 3 files changed, 36 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH v6 08/28] migration: allow send_rq to fail

2018-02-08 Thread Peter Xu
We will not allow failures to happen when sending data from destination to source via the return path. However it is possible that there can be errors along the way. This patch allows the migrate_send_rp_message() to return error when it happens, and further extended it to migrate_send_rp_req_page

[Qemu-devel] [PATCH v6 02/28] migration: reuse mis->userfault_quit_fd

2018-02-08 Thread Peter Xu
It was only used for quitting the page fault thread before. Let it be something more useful - now we can use it to notify a "wake" for the page fault thread (for any reason), and it only means "quit" if the fault_thread_quit is set. Since we changed what it does, renaming it to userfault_event_fd.

[Qemu-devel] [PATCH v6 00/28] Migration: postcopy failure recovery

2018-02-08 Thread Peter Xu
Tree is pushed here for better reference and testing (online tree includes monitor OOB series): https://github.com/xzpeter/qemu/tree/postcopy-recovery-support This version added back the migrate-pause command, and let it to be run on either side of migration. Meanwhile, fixed a tricky error on

[Qemu-devel] [PATCH v6 13/28] migration: new state "postcopy-recover"

2018-02-08 Thread Peter Xu
Introducing new migration state "postcopy-recover". If a migration procedure is paused and the connection is rebuilt afterward successfully, we'll switch the source VM state from "postcopy-paused" to the new state "postcopy-recover", then we'll do the resume logic in the migration thread (along wit

[Qemu-devel] [PATCH v6 10/28] qmp: hmp: add migrate "resume" option

2018-02-08 Thread Peter Xu
It will be used when we want to resume one paused migration. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu --- hmp-commands.hx | 7 --- hmp.c | 4 +++- migration/migration.c | 2 +- qapi/migration.json | 5 - 4 files changed, 12 insertions(+), 6 del

[Qemu-devel] [PATCH v6 05/28] migration: implement "postcopy-pause" src logic

2018-02-08 Thread Peter Xu
Now when network down for postcopy, the source side will not fail the migration. Instead we convert the status into this new paused state, and we will try to wait for a rescue in the future. If a recovery is detected, migration_thread() will reset its local variables to prepare for that. Reviewed

[Qemu-devel] [PATCH v6 15/28] migration: new cmd MIG_CMD_RECV_BITMAP

2018-02-08 Thread Peter Xu
Add a new vm command MIG_CMD_RECV_BITMAP to request received bitmap for one ramblock. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu --- migration/savevm.c | 61 ++ migration/savevm.h | 1 + migration/trace-events | 2 ++ 3

[Qemu-devel] [PATCH v6 04/28] migration: new postcopy-pause state

2018-02-08 Thread Peter Xu
Introducing a new state "postcopy-paused", which can be used when the postcopy migration is paused. It is targeted for postcopy network failure recovery. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu --- migration/migration.c | 2 ++ qapi/migration.json | 5 - 2 files change

[Qemu-devel] [PATCH v6 19/28] migration: introduce SaveVMHandlers.resume_prepare

2018-02-08 Thread Peter Xu
This is hook function to be called when a postcopy migration wants to resume from a failure. For each module, it should provide its own recovery logic before we switch to the postcopy-active state. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu --- include/migration/register.h | 2

[Qemu-devel] [PATCH v6 06/28] migration: allow dst vm pause on postcopy

2018-02-08 Thread Peter Xu
When there is IO error on the incoming channel (e.g., network down), instead of bailing out immediately, we allow the dst vm to switch to the new POSTCOPY_PAUSE state. Currently it is still simple - it waits the new semaphore, until someone poke it for another attempt. One note is that here on ram

[Qemu-devel] [PATCH v6 11/28] migration: pass MigrationState to migrate_init()

2018-02-08 Thread Peter Xu
Let the callers take the object, then pass it to migrate_init(). Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu --- migration/migration.c | 7 ++- migration/migration.h | 2 +- migration/savevm.c| 5 - 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/migra

[Qemu-devel] [PATCH v6 16/28] migration: new message MIG_RP_MSG_RECV_BITMAP

2018-02-08 Thread Peter Xu
Introducing new return path message MIG_RP_MSG_RECV_BITMAP to send received bitmap of ramblock back to source. This is the reply message of MIG_CMD_RECV_BITMAP, it contains not only the header (including the ramblock name), and it was appended with the whole ramblock received bitmap on the destina

[Qemu-devel] [PATCH v6 20/28] migration: synchronize dirty bitmap for resume

2018-02-08 Thread Peter Xu
This patch implements the first part of core RAM resume logic for postcopy. ram_resume_prepare() is provided for the work. When the migration is interrupted by network failure, the dirty bitmap on the source side will be meaningless, because even the dirty bit is cleared, it is still possible that

[Qemu-devel] [PATCH v6 09/28] migration: allow fault thread to pause

2018-02-08 Thread Peter Xu
Allows the fault thread to stop handling page faults temporarily. When network failure happened (and if we expect a recovery afterwards), we should not allow the fault thread to continue sending things to source, instead, it should halt for a while until the connection is rebuilt. When the dest ma

[Qemu-devel] [PATCH v6 25/28] qmp/migration: new command migrate-recover

2018-02-08 Thread Peter Xu
The first allow-oob=true command. It's used on destination side when the postcopy migration is paused and ready for a recovery. After execution, a new migration channel will be established for postcopy to continue. Signed-off-by: Peter Xu --- migration/migration.c | 26

[Qemu-devel] [PATCH v6 23/28] migration: init dst in migration_object_init too

2018-02-08 Thread Peter Xu
Though we may not need it, now we init both the src/dst migration objects in migration_object_init() so that even incoming migration object would be thread safe (it was not). Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu --- migration/migration.c | 28 +++-

[Qemu-devel] [PATCH v6 22/28] migration: final handshake for the resume

2018-02-08 Thread Peter Xu
Finish the last step to do the final handshake for the recovery. First source sends one MIG_CMD_RESUME to dst, telling that source is ready to resume. Then, dest replies with MIG_RP_MSG_RESUME_ACK to source, telling that dest is ready to resume (after switch to postcopy-active state). When sourc

[Qemu-devel] [PATCH v6 12/28] migration: rebuild channel on source

2018-02-08 Thread Peter Xu
This patch detects the "resume" flag of migration command, rebuild the channels only if the flag is set. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu --- migration/migration.c | 91 +++ 1 file changed, 70 insertions(+), 21 deletions

Re: [Qemu-devel] [PATCH v6 00/28] Migration: postcopy failure recovery

2018-02-08 Thread Peter Xu
On Thu, Feb 08, 2018 at 06:31:04PM +0800, Peter Xu wrote: [...] > 6. On source, manually trigger a "fake network down" using >"migrate-cancel" command: > > {"execute": "migrate_cancel"} > {"return": {}} > > During postcopy, it'll not really cancel the migration, but pause > it. On

[Qemu-devel] [PATCH v6 26/28] hmp/migration: add migrate_recover command

2018-02-08 Thread Peter Xu
Sister command to migrate-recover in QMP. Signed-off-by: Peter Xu --- hmp-commands.hx | 13 + hmp.c | 10 ++ hmp.h | 1 + 3 files changed, 24 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index 28ed5a7a13..7563f3eaa0 100644 --- a/hmp-comma

[Qemu-devel] [PATCH v6 14/28] migration: wakeup dst ram-load-thread for recover

2018-02-08 Thread Peter Xu
On the destination side, we cannot wake up all the threads when we got reconnected. The first thing to do is to wake up the main load thread, so that we can continue to receive valid messages from source again and reply when needed. At this point, we switch the destination VM state from postcopy-p

Re: [Qemu-devel] [PATCH 2/2] scsi: add block job opblockers for scsi-block

2018-02-08 Thread Paolo Bonzini
On 08/02/2018 02:35, Fam Zheng wrote: > On Wed, 02/07 17:36, Paolo Bonzini wrote: >> @@ -2626,6 +2656,36 @@ static void scsi_block_realize(SCSIDevice *dev, Error >> **errp) >> >> scsi_realize(&s->qdev, errp); >> scsi_generic_read_device_identification(&s->qdev); >> + >> +/* For op

[Qemu-devel] [PATCH v6 27/28] migration/qmp: add command migrate-pause

2018-02-08 Thread Peter Xu
It pauses an ongoing migration. Currently it only supports postcopy. Note that this command will work on either side of the migration. Basically when we trigger this on one side, it'll interrupt the other side as well since the other side will get notified on the disconnect event. However, it's s

[Qemu-devel] [PATCH v6 17/28] migration: new cmd MIG_CMD_POSTCOPY_RESUME

2018-02-08 Thread Peter Xu
Introducing this new command to be sent when the source VM is ready to resume the paused migration. What the destination does here is basically release the fault thread to continue service page faults. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu --- migration/savevm.c | 35

[Qemu-devel] [PATCH v6 18/28] migration: new message MIG_RP_MSG_RESUME_ACK

2018-02-08 Thread Peter Xu
Creating new message to reply for MIG_CMD_POSTCOPY_RESUME. One uint32_t is used as payload to let the source know whether destination is ready to continue the migration. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu --- migration/migration.c | 37 +

[Qemu-devel] [PATCH v6 28/28] migration/hmp: add migrate_pause command

2018-02-08 Thread Peter Xu
Wrapper for QMP command "migrate-pause". Signed-off-by: Peter Xu --- hmp-commands.hx | 14 ++ hmp.c | 9 + hmp.h | 1 + 3 files changed, 24 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index 7563f3eaa0..32549702ee 100644 --- a/hmp-comman

[Qemu-devel] [PATCH v6 21/28] migration: setup ramstate for resume

2018-02-08 Thread Peter Xu
After we updated the dirty bitmaps of ramblocks, we also need to update the critical fields in RAMState to make sure it is ready for a resume. Signed-off-by: Peter Xu --- migration/ram.c| 40 +++- migration/trace-events | 1 + 2 files changed, 40 inse

Re: [Qemu-devel] [PATCH v5 17/23] RISC-V VirtIO Machine

2018-02-08 Thread Igor Mammedov
On Thu, 8 Feb 2018 14:28:42 +1300 Michael Clark wrote: > RISC-V machine with device-tree, 16550a UART and VirtIO MMIO. > The following machine is implemented: > > - 'virt'; CLINT, PLIC, 16550A UART, VirtIO MMIO, device-tree > > Signed-off-by: Michael Clark > --- > hw/riscv/virt.c | 3

Re: [Qemu-devel] [PULL 2/2] hw/audio/sb16.c: change dolog() to qemu_log_mask()

2018-02-08 Thread Peter Maydell
On 2 February 2018 at 07:50, Gerd Hoffmann wrote: > From: John Arbuckle > > Changes all the occurrances of dolog() to qemu_log_mask(). > > Signed-off-by: John Arbuckle > Message-id: 20180201172744.7504-1-programmingk...@gmail.com > Signed-off-by: Gerd Hoffmann > --- > @@ -735,9 +742,8 @@ stati

[Qemu-devel] [PATCH v6 24/28] io: let watcher of the channel run in same ctx

2018-02-08 Thread Peter Xu
Per-thread gcontext is only used in IOThread (please refer to callers of g_main_context_push_thread_default), so this patch only affects anything that will be run in an IOThread. It lets the watcher object be run in the same context as the caller that added the watcher. This patch is critical to

Re: [Qemu-devel] Questions regarding how QEMU initializes virtual peripherals

2018-02-08 Thread Igor Mammedov
On Thu, 8 Feb 2018 12:06:44 +0200 Ramy Sameh wrote: > Hello all, > > I am working with QEMU to simulate VersatilePB board. > > I am trying to understand how QEMU initialize the virtual peripherals (e.g. > UART, vectored Interrupt controller .. etc). > > When I traced the code, I found a functi

Re: [Qemu-devel] [PATCH] S390: Expose s390-specific CPU info

2018-02-08 Thread Cornelia Huck
On Thu, 8 Feb 2018 11:24:48 +0100 Christian Borntraeger wrote: > On 02/08/2018 11:16 AM, Cornelia Huck wrote: > > On Thu, 8 Feb 2018 10:48:08 +0100 > > Viktor Mihajlovski wrote: > >> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c > >> index 3807dcb..3e6360e 100644 > >> --

Re: [Qemu-devel] [Qemu-block] [PATCH] block: early check for blockers on drive-mirror

2018-02-08 Thread Paolo Bonzini
On 08/02/2018 11:10, Alberto Garcia wrote: > On Wed 07 Feb 2018 05:29:20 PM CET, Paolo Bonzini wrote: >> Even if an op blocker is present for BLOCK_OP_TYPE_MIRROR_SOURCE, >> it is checked a bit late and the result is that the target is >> created even if drive-mirror subsequently fails. Add an ear

Re: [Qemu-devel] [RFC PATCH 1/5] vfio/quirks: Add common quirk alloc helper

2018-02-08 Thread Auger Eric
Hi Alex, On 07/02/18 01:26, Alex Williamson wrote: > This will later be used to include list initialization > > Signed-off-by: Alex Williamson > --- > hw/vfio/pci-quirks.c | 48 +--- > 1 file changed, 21 insertions(+), 27 deletions(-) > > diff --git

Re: [Qemu-devel] [RFC PATCH 3/5] vfio/quirks: Automatic ioeventfd enabling for NVIDIA BAR0 quirks

2018-02-08 Thread Auger Eric
Hi Alex, On 07/02/18 01:26, Alex Williamson wrote: > Record data writes that come through the NVIDIA BAR0 quirk, if we get > enough in a row that we're only passing through, automatically enable > an ioeventfd for it. The primary target for this is the MSI-ACK > that NVIDIA uses to allow the MSI

Re: [Qemu-devel] [RFC PATCH 2/5] vfio/quirks: Add generic support for ioveventfds

2018-02-08 Thread Auger Eric
Hi Alex, On 07/02/18 01:26, Alex Williamson wrote: > We might wish to handle some quirks via ioeventfds, add a list of > ioeventfds to the quirk. The commit title is a bit misleading as we only add the data type and deletion function. > > Signed-off-by: Alex Williamson > --- > hw/vfio/pci-quirk

[Qemu-devel] [PATCH 1/1] hw/audio/sb16.c: missing break statement

2018-02-08 Thread Daniel Henrique Barboza
This patch adds a break in the switch() statement of complete(), value 0x42: case 0x42: /* FT2 sets output freq with this, go figure */ qemu_log_mask(LOG_UNIMP, "cmd 0x42 might not do what it think it" " should\n"); break; <--- case 0x

Re: [Qemu-devel] [PULL 0/1] Bitmaps patches

2018-02-08 Thread Peter Maydell
On 7 February 2018 at 17:01, John Snow wrote: > The following changes since commit 0833df03f4206a6cf416fbb3d380fa95c8e61fba: > > Merge remote-tracking branch > 'remotes/dgilbert/tags/pull-migration-20180206a' into staging (2018-02-07 > 12:07:23 +) > > are available in the Git repository at

Re: [Qemu-devel] [PATCH v6 00/28] Migration: postcopy failure recovery

2018-02-08 Thread no-reply
Hi, This series failed docker-quick@centos6 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180208103132.28452-1-pet...@redhat.com Subject: [Qemu-devel] [PATCH v6 00/28] Migration

Re: [Qemu-devel] [PATCH v6 00/28] Migration: postcopy failure recovery

2018-02-08 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 20180208103132.28452-1-pet...@redhat.com Subject: [Qemu-devel] [PATCH v6 00/28] Migration: postcopy failure recovery === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked und

Re: [Qemu-devel] [PATCH v6 00/28] Migration: postcopy failure recovery

2018-02-08 Thread no-reply
Hi, This series failed docker-build@min-glib build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180208103132.28452-1-pet...@redhat.com Subject: [Qemu-devel] [PATCH v6 00/28] Migratio

Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration

2018-02-08 Thread Igor Mammedov
On Thu, 8 Feb 2018 18:18:20 +0800 "Tan, Jianfeng" wrote: > On 2/8/2018 5:51 PM, Igor Mammedov wrote: > > On Thu, 8 Feb 2018 09:20:45 +0800 > > "Tan, Jianfeng" wrote: > > > >> On 2/7/2018 8:06 PM, Igor Mammedov wrote: > >>> On Wed, 7 Feb 2018 07:49:58 + > >>> "Tan, Jianfeng" wrote: > >>>

Re: [Qemu-devel] [PATCH] s390x/sclp: fix event mask handling --> stable 2.11.1?

2018-02-08 Thread Christian Borntraeger
On 02/02/2018 11:35 AM, Cornelia Huck wrote: > On Fri, 2 Feb 2018 11:33:01 +0100 > Cornelia Huck wrote: > >> On Fri, 2 Feb 2018 10:43:18 +0100 >> Christian Borntraeger wrote: >> >>> On 02/02/2018 10:42 AM, Christian Borntraeger wrote: commit 67915de9f038 ("s390x/event-facility: variable

Re: [Qemu-devel] [RFC PATCH 3/5] vfio/quirks: Automatic ioeventfd enabling for NVIDIA BAR0 quirks

2018-02-08 Thread Auger Eric
Hi Alex, On 08/02/18 12:10, Auger Eric wrote: > Hi Alex, > > On 07/02/18 01:26, Alex Williamson wrote: >> Record data writes that come through the NVIDIA BAR0 quirk, if we get >> enough in a row that we're only passing through, automatically enable >> an ioeventfd for it. The primary target for

Re: [Qemu-devel] [PATCH v6 00/28] Migration: postcopy failure recovery

2018-02-08 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180208103132.28452-1-pet...@redhat.com Subject: [Qemu-devel] [PATCH v6 00/28] Migration:

Re: [Qemu-devel] [RFC PATCH 5/5] vfio/quirks: Enable ioeventfd quirks to be handled by vfio directly

2018-02-08 Thread Auger Eric
Hi Alex, On 07/02/18 01:26, Alex Williamson wrote: > With vfio ioeventfd support, we can program vfio-pci to perform a > specified BAR write when an eventfd is triggered. This allows the > KVM ioeventfd to be wired directly to vfio-pci, entirely avoiding > userspace handling for these events. On

Re: [Qemu-devel] [PATCH] s390x/sclp: fix event mask handling --> stable 2.11.1?

2018-02-08 Thread Cornelia Huck
On Thu, 8 Feb 2018 12:30:28 +0100 Christian Borntraeger wrote: > On 02/02/2018 11:35 AM, Cornelia Huck wrote: > > On Fri, 2 Feb 2018 11:33:01 +0100 > > Cornelia Huck wrote: > > > >> On Fri, 2 Feb 2018 10:43:18 +0100 > >> Christian Borntraeger wrote: > >> > >>> On 02/02/2018 10:42 AM, Chris

Re: [Qemu-devel] [PATCH v6 0/5] target-arm: add SHA-3, SM3 and SHA512 instruction support

2018-02-08 Thread Peter Maydell
On 7 February 2018 at 11:17, Ard Biesheuvel wrote: > Changes since v5: > - fix use of same register for destination and source in SHA-512 code > - use correct free() function in SHA-3 code > - drop helper for sm3ss1 in SM3 code > - include fixed version of SM4 (correct # of iterations) > - enable

Re: [Qemu-devel] [PATCH 3/3] MAINTAINERS: add David as additional tcg/s390 maintainer

2018-02-08 Thread David Hildenbrand
On 07.02.2018 16:55, Cornelia Huck wrote: > Signed-off-by: Cornelia Huck > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index bd2dc7ed7c..b30d2ca23a 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -236,6 +236,7 @@ F: disas/ppc.c > S3

Re: [Qemu-devel] [PATCH 1/1] hw/audio/sb16.c: missing break statement

2018-02-08 Thread Philippe Mathieu-Daudé
Hi Daniel, On 02/08/2018 07:57 AM, Daniel Henrique Barboza wrote: > This patch adds a break in the switch() statement of complete(), > value 0x42: > > case 0x42: /* FT2 sets output freq with this, go figure */ > qemu_log_mask(LOG_UNIMP, "cmd 0x42 might not do what it thin

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] spapr: check smp_threads <= vsmt

2018-02-08 Thread Greg Kurz
On Thu, 8 Feb 2018 10:42:41 +0100 Laurent Vivier wrote: > We ignore silently the value of smp_threads when we set > the default VSMT value, and if smp_threads is greater than VSMT > kernel is going into trouble later. > > Fixes: 8904e5a750 > ("spapr: Adjust default VSMT value for better migrati

Re: [Qemu-devel] [PATCH 1/3] MAINTAINERS: add myself as overall s390x maintainer

2018-02-08 Thread David Hildenbrand
On 07.02.2018 16:55, Cornelia Huck wrote: > All your mainframes are belong to me. This looks like an easy way to get a lot of expensive hardware :) > > Signed-off-by: Cornelia Huck > --- > MAINTAINERS | 23 +++ > 1 file changed, 23 insertions(+) > > diff --git a/MAINTAINER

[Qemu-devel] [Bug 1663287] Re: Illegal delay slot code causes abort on mips64

2018-02-08 Thread Brian Campbell
** Changed in: qemu Status: Fix Released => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1663287 Title: Illegal delay slot code causes abort on mips64 Status in QEMU: New Bug descri

Re: [Qemu-devel] [Qemu-block] [PATCH] block: early check for blockers on drive-mirror

2018-02-08 Thread Alberto Garcia
On Wed 07 Feb 2018 05:29:20 PM CET, Paolo Bonzini wrote: > Even if an op blocker is present for BLOCK_OP_TYPE_MIRROR_SOURCE, > it is checked a bit late and the result is that the target is > created even if drive-mirror subsequently fails. Add an early > check to avoid this. > > Signed-off-by: Pao

Re: [Qemu-devel] [Qemu-stable] [PATCH 00/54] Patch Round-up for stable 2.11.1, freeze on 2018-02-12

2018-02-08 Thread Peter Lieven
Am 06.02.2018 um 20:14 schrieb Michael Roth: Hi everyone, The following new patches are queued for QEMU stable v2.11.1: https://github.com/mdroth/qemu/commits/stable-2.11-staging The release is planned for 2017-02-14: https://wiki.qemu.org/Planning/2.11 Please respond here or CC qemu-s

Re: [Qemu-devel] [PULL 0/4] RDMA patches

2018-02-08 Thread Peter Maydell
On 5 February 2018 at 10:26, Marcel Apfelbaum wrote: > The following changes since commit f24ee107a07f093bd7ed475dd48d7ba57ea3d8fe: > > Merge remote-tracking branch 'remotes/kraxel/tags/ui-20180202-pull-request' > into staging (2018-02-02 18:54:11 +) > > are available in the git repository

Re: [Qemu-devel] [PATCH 1/1] hw/audio/sb16.c: missing break statement

2018-02-08 Thread Peter Maydell
On 8 February 2018 at 12:15, Philippe Mathieu-Daudé wrote: > Hi Daniel, > > On 02/08/2018 07:57 AM, Daniel Henrique Barboza wrote: >> This patch adds a break in the switch() statement of complete(), >> value 0x42: >> >> case 0x42: /* FT2 sets output freq with this, go figure */ >>

Re: [Qemu-devel] [PATCH 1/1] hw/audio/sb16.c: missing break statement

2018-02-08 Thread Daniel P . Berrangé
On Thu, Feb 08, 2018 at 09:15:10AM -0300, Philippe Mathieu-Daudé wrote: > Hi Daniel, > > On 02/08/2018 07:57 AM, Daniel Henrique Barboza wrote: > > This patch adds a break in the switch() statement of complete(), > > value 0x42: > > > > case 0x42: /* FT2 sets output freq with thi

Re: [Qemu-devel] [PATCH 1/1] hw/audio/sb16.c: missing break statement

2018-02-08 Thread Philippe Mathieu-Daudé
On 02/08/2018 10:01 AM, Peter Maydell wrote: > On 8 February 2018 at 12:15, Philippe Mathieu-Daudé wrote: >> Hi Daniel, >> >> On 02/08/2018 07:57 AM, Daniel Henrique Barboza wrote: >>> This patch adds a break in the switch() statement of complete(), >>> value 0x42: >>> >>> case 0x42:

[Qemu-devel] [PATCH 1/1] nbd: increase maximum size of the PWRITE_ZERO request

2018-02-08 Thread Edgar Kaziakhmedov
Upstream NBD protocol implementation supports an efficient zero out mechanism over the wire, along with the ability to check whether a client allows using a hole. Accordingly, since PWRITE_ZERO doesn't involve any payload on the wire, increase a maximum size of the PWRITE_ZERO request up to 1Gb (a

[Qemu-devel] [Bug 1484990] Re: fsfreeze-hook script should also ignored dpkg generated files

2018-02-08 Thread ChristianEhrhardt
qemu 2.11 is in proposed ** Changed in: qemu (Ubuntu) Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1484990 Title: fsfreeze-hook script should also ignored dpkg

[Qemu-devel] [Bug 1350435] Re: tcg.c:1693: tcg fatal error

2018-02-08 Thread ChristianEhrhardt
per former comments, in context qemu 2.11 is in proposed ** Changed in: qemu (Ubuntu) Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1350435 Title: tcg.c:1

Re: [Qemu-devel] [PATCH 00/54] Patch Round-up for stable 2.11.1, freeze on 2018-02-12

2018-02-08 Thread Philippe Mathieu-Daudé
Hi Michael, On 02/06/2018 04:14 PM, Michael Roth wrote: > The release is planned for 2017-02-14: > > https://wiki.qemu.org/Planning/2.11 > > Please respond here or CC qemu-sta...@nongnu.org on any patches you > think should be included in the release. > > -

Re: [Qemu-devel] [PATCH v5 12/14] i.MX: Add i.MX7 SOC implementation.

2018-02-08 Thread Peter Maydell
On 7 February 2018 at 04:24, Andrey Smirnov wrote: > The following interfaces are partially or fully emulated: Hi Andrey. I was just going through this series to apply to target-arm.next, and I noticed that fsl-imx7.c is GPL-2-or-later, but fsl-imx7.h is GPL-2-only. Is that intentional? If this

Re: [Qemu-devel] [PATCH 1/1] hw/audio/sb16.c: missing break statement

2018-02-08 Thread Philippe Mathieu-Daudé
On 02/08/2018 10:16 AM, Philippe Mathieu-Daudé wrote: > On 02/08/2018 10:01 AM, Peter Maydell wrote: >> On 8 February 2018 at 12:15, Philippe Mathieu-Daudé wrote: >>> Hi Daniel, >>> >>> On 02/08/2018 07:57 AM, Daniel Henrique Barboza wrote: This patch adds a break in the switch() statement of

Re: [Qemu-devel] [PULL 0/4] RDMA patches

2018-02-08 Thread Marcel Apfelbaum
Hi Peter, On 08/02/2018 14:59, Peter Maydell wrote: > On 5 February 2018 at 10:26, Marcel Apfelbaum wrote: >> The following changes since commit f24ee107a07f093bd7ed475dd48d7ba57ea3d8fe: >> >> Merge remote-tracking branch >> 'remotes/kraxel/tags/ui-20180202-pull-request' into staging (2018-02-

Re: [Qemu-devel] [RFC PATCH] vfio/pci: Add ioeventfd support

2018-02-08 Thread Auger Eric
Hi Alex, On 07/02/18 17:57, Alex Williamson wrote: > On Wed, 7 Feb 2018 16:46:19 +0100 > Auger Eric wrote: > >> Hi Alex, >> >> On 07/02/18 01:08, Alex Williamson wrote: >>> The ioeventfd here is actually irqfd handling of an ioeventfd such as >>> supported in KVM. A user is able to pre-program

Re: [Qemu-devel] [PATCH v5 00/14] Initial i.MX7 support

2018-02-08 Thread Peter Maydell
On 7 February 2018 at 04:24, Andrey Smirnov wrote: > Hi everyone, > > This v5 of the patch series containing the work that I've done in > order to enable support for i.MX7 emulation in QEMU. Thanks; I'm applying this to target-arm.next. There are a few minor tweaks I'm going to make in the proces

[Qemu-devel] [Bug 1738767] Re: Cannot build QEMU on RHEL6 because of MAP_HUGETLB

2018-02-08 Thread Alex Bennée
This was fixed by the distro updating their glibc-headers pakcage: * Tue Jul 23 2013 Alexandre Oliva - 2.12-1.119 - Add MAP_HUGETLB and MAP_STACK support (#916986). - Update translation for stale file handle error (#970776). The build works in the current centos6 docker image and has been confir

[Qemu-devel] [Bug 1738767] Re: Cannot build QEMU on RHEL6 because of MAP_HUGETLB

2018-02-08 Thread Christophe Lyon
I think we can close this bug: the build fails on RHEL6.4, but succeeded on RHEL6.7. Probably related to: https://access.redhat.com/solutions/320613 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1738

Re: [Qemu-devel] [PATCH 1/1] hw/audio/sb16.c: missing break statement

2018-02-08 Thread Peter Maydell
On 8 February 2018 at 13:34, Philippe Mathieu-Daudé wrote: > Now I see Fabrice comment "FT2 sets output freq with this, go figure" > and agree with him. > > I like to think this is a bug in Fast Tracker 2, so Peter suggestion > about using LOG_GUEST_ERROR here might be clever. > >> >> So imho the

Re: [Qemu-devel] [patch] linux-user/syscall.c: Fix missing break for host_to_target_cmsg

2018-02-08 Thread Nageswara Sastry
On 07-Feb-2018, at 7:27 PM, Laurent Vivier wrote: Le 07/02/2018 à 10:49, no-re...@patchew.org a écrit : Hi, This series failed build test on s390x host. Please find the details below. ... CC aarch64_be-linux-user/linux-user/syscall.o In file i

[Qemu-devel] [Bug 1738767] Re: Cannot build QEMU on RHEL6 because of MAP_HUGETLB

2018-02-08 Thread Peter Maydell
OK, since we work on more recent RHEL6 and the submitter is happy with that, let's close this bug as WONTFIX. ** Changed in: qemu Status: New => Won't Fix -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad

Re: [Qemu-devel] [PATCH 1/2] qmp: add query-cpus-fast

2018-02-08 Thread Luiz Capitulino
On Thu, 8 Feb 2018 08:41:31 +0100 Viktor Mihajlovski wrote: > On 07.02.2018 18:50, Luiz Capitulino wrote: > > The query-cpus command has an extremely serious side effect: > > it always interrupt all running vCPUs so that they can run > > ioctl calls. This can cause a huge performance degradation

[Qemu-devel] [PATCH] block: unify blocksize types

2018-02-08 Thread Piotr Sarna
BlockSizes structure used in block size probing has uint32_t types for logical and physical sizes. These fields are wrongfully assigned to uint16_t in BlockConf, which results, among other errors, in assigning 0 instead of 65536 (which will be the case in at least future LizardFS block device drive

Re: [Qemu-devel] [PULL 0/4] RDMA patches

2018-02-08 Thread Michael S. Tsirkin
On Thu, Feb 08, 2018 at 12:59:02PM +, Peter Maydell wrote: > On 5 February 2018 at 10:26, Marcel Apfelbaum wrote: > > The following changes since commit f24ee107a07f093bd7ed475dd48d7ba57ea3d8fe: > > > > Merge remote-tracking branch > > 'remotes/kraxel/tags/ui-20180202-pull-request' into sta

Re: [Qemu-devel] [PATCH 2/2] qmp: document query-cpus performance issue

2018-02-08 Thread Luiz Capitulino
On Thu, 8 Feb 2018 09:29:28 + Daniel P. Berrangé wrote: > On Wed, Feb 07, 2018 at 12:50:14PM -0500, Luiz Capitulino wrote: > > Signed-off-by: Luiz Capitulino > > --- > > qapi-schema.json | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/qapi-schema.json b/qapi-schema.json

Re: [Qemu-devel] [PULL 0/4] RDMA patches

2018-02-08 Thread Peter Maydell
On 8 February 2018 at 13:38, Marcel Apfelbaum wrote: > Hi Peter, > > On 08/02/2018 14:59, Peter Maydell wrote: >> (3) Some of the new headers use kernel-internals __u32 etc types. >> This isn't portable. ('HACKING' has some suggestions for types you >> might want instead.) >> > > We do not "use" t

  1   2   3   4   5   >