Re: [Qemu-devel] [PATCH V4 10/16] qmp event: Add COLO_EXIT event to notify users while exited COLO

2018-02-06 Thread Zhang Chen
On Tue, Feb 6, 2018 at 3:27 PM, Markus Armbruster wrote: > Zhang Chen writes: > > > On Sat, Feb 3, 2018 at 3:49 PM, Markus Armbruster > wrote: > > > >> Zhang Chen writes: > >> > >> > From: zhanghailiang > >> > > >> > If some errors happen during VM's COLO FT stage, it's important to > >> > no

Re: [Qemu-devel] [PATCH] migration: Recover block devices if failure in device state

2018-02-06 Thread Peter Xu
On Mon, Feb 05, 2018 at 09:39:41AM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > In e91d895 I added the new pause-before-switchover mechanism > to allow migration completion to be delayed; this changes the > last state prior to completion to MIGRATE_STATUS_DEVICE

Re: [Qemu-devel] [PATCH v8 14/14] target: Use qemu_log() instead of fprintf(stderr, ...)

2018-02-06 Thread Thomas Huth
On 05.02.2018 19:07, Alistair Francis wrote: > On Mon, Feb 5, 2018 at 6:31 AM, Markus Armbruster wrote: >> Thomas Huth writes: >> >>> On 05.02.2018 07:33, Markus Armbruster wrote: Thomas Huth writes: > On 03.02.2018 09:43, Markus Armbruster wrote: >> From: Alistair Francis >>>

Re: [Qemu-devel] [PATCH] migration: incoming postcopy advise sanity checks

2018-02-06 Thread Greg Kurz
On Tue, 6 Feb 2018 10:49:47 +0300 Vladimir Sementsov-Ogievskiy wrote: > 06.02.2018 10:26, Greg Kurz wrote: > > If postcopy-ram was set on the source but not on the destination, > > migration doesn't occur, the destination prints an error and boots > > the guest: > > > > qemu-system-ppc64: Expecte

Re: [Qemu-devel] [PATCH v11 01/20] tcg: Allow multiple word entries into the constant pool

2018-02-06 Thread Alex Bennée
Richard Henderson writes: > This will be required for storing vector constants. > > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > tcg/tcg-pool.inc.c | 115 > +++-- > 1 file changed, 93 inserti

Re: [Qemu-devel] [PATCH v11 02/20] tcg: Add types and basic operations for host vectors

2018-02-06 Thread Alex Bennée
Richard Henderson writes: > Nothing uses or enables them yet. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > Makefile.target | 4 +- > tcg/tcg-op.h | 27 + > tcg/tcg-opc.h| 25 + > tcg/tcg.h| 56 +++ > tcg/tcg-op-vec.c | 292 > ++

Re: [Qemu-devel] [PATCH v11 03/20] tcg: Standardize integral arguments to expanders

2018-02-06 Thread Alex Bennée
Richard Henderson writes: > Some functions use intN_t arguments, some use uintN_t, some just > used "unsigned". To aid putting function pointers in tables, we > need consistency. > > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson I was a bit confused by converting unsigned int

Re: [Qemu-devel] [PATCH] target/arm/kvm: gic: Prevent creating userspace GICv3 with KVM

2018-02-06 Thread Christoffer Dall
Hi Philippe, On Mon, Feb 05, 2018 at 09:10:48PM -0300, Philippe Mathieu-Daudé wrote: > > On 02/01/2018 05:53 PM, Christoffer Dall wrote: > > KVM doesn't support emulating a GICv3 in userspace, only GICv2. We > > currently attempt this anyway, and as a result a KVM guest doesn't > > receive inter

Re: [Qemu-devel] [PATCH] rtc: placing RTC memory region outside BQL

2018-02-06 Thread Gonglei (Arei)
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Monday, February 05, 2018 10:04 PM > To: Peter Maydell > Cc: Gonglei (Arei); QEMU Developers; Huangweidong (C) > Subject: Re: [Qemu-devel] [PATCH] rtc: placing RTC memory region outside BQL > > On 04/02/2018 1

Re: [Qemu-devel] [PATCH v4 7/9] sockets: allow SocketAddress 'fd' to reference numeric file descriptors

2018-02-06 Thread Daniel P . Berrangé
On Mon, Feb 05, 2018 at 01:42:50PM -0600, Eric Blake wrote: > On 02/05/2018 09:24 AM, Daniel P. Berrangé wrote: > > From: "Daniel P. Berrange" > > > > The SocketAddress 'fd' kind accepts the name of a file descriptor passed > > to the monitor with the 'getfd' command. This makes it impossible to

Re: [Qemu-devel] Qemu Trace

2018-02-06 Thread Stefan Hajnoczi
On Mon, Feb 05, 2018 at 03:55:01PM +, Peter Maydell wrote: > On 5 February 2018 at 15:51, Stefan Hajnoczi wrote: > > The point of the instrumentation plugin API is for online analysis > > (stuff that cannot be post-processed offline) with the ability for the > > plugin to control QEMU (e.g. af

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 05/12] s390-ccw: move auxiliary IPL data to separate location

2018-02-06 Thread Thomas Huth
On 05.02.2018 21:57, Collin L. Walling wrote: > The s390-ccw firmware needs some information in support of the > boot process which is not available on the native machine. > Examples are the netboot firmware load address and now the > boot menu parameters. > > While storing that data in unused fie

Re: [Qemu-devel] [PATCH] migration: incoming postcopy advise sanity checks

2018-02-06 Thread Vladimir Sementsov-Ogievskiy
06.02.2018 11:43, Greg Kurz wrote: On Tue, 6 Feb 2018 10:49:47 +0300 Vladimir Sementsov-Ogievskiy wrote: 06.02.2018 10:26, Greg Kurz wrote: If postcopy-ram was set on the source but not on the destination, migration doesn't occur, the destination prints an error and boots the guest: qemu-sys

Re: [Qemu-devel] [PATCH v3] tap: close fd conditionally when error occured

2018-02-06 Thread Jason Wang
On 2018年02月02日 17:50, Jay Zhou wrote: If netdev_add tap,id=net0,...,vhost=on failed in net_init_tap_one(), the followed up device_add virtio-net-pci,netdev=net0 will fail too, prints: TUNSETOFFLOAD ioctl() failed: Bad file descriptor TUNSETOFFLOAD ioctl() failed: Bad file descriptor T

[Qemu-devel] [Bug 1746943] Re: qemu-aarch64-static: qemu: uncaught target signal 11 for ps/top cmd

2018-02-06 Thread cee1
I tried psproc-ng from https://launchpad.net/ubuntu/+source/procps/2:3.3.12-1ubuntu2/+build/10452812 No SEGV, I guess it may be a CRASH-PATH which is triggered in this specific scenario I've did update in redhat bugzilla #1541252, and wait for confirming above. BTW, "uncaught target signal 11" m

Re: [Qemu-devel] [RFC 0/2] virtio-vhost-user: add virtio-vhost-user device

2018-02-06 Thread Stefan Hajnoczi
On Tue, Feb 06, 2018 at 01:28:25AM +, Wang, Wei W wrote: > On Tuesday, February 6, 2018 12:26 AM, Stefan Hajnoczi wrote: > > On Fri, Feb 02, 2018 at 09:08:44PM +0800, Wei Wang wrote: > > > On 02/02/2018 01:08 AM, Michael S. Tsirkin wrote: > > > > On Tue, Jan 30, 2018 at 08:09:19PM +0800, Wei Wa

Re: [Qemu-devel] [Qemu-arm] [PATCH 2/7] target/arm: Split "get pending exception info" from "acknowledge it"

2018-02-06 Thread Peter Maydell
On 5 February 2018 at 23:44, Philippe Mathieu-Daudé wrote: > maybe: > > assert(ptargets_secure && pirq); This is one of those areas where people have different opinions, but personally I think the point of assertions is to turn bugs that manifest later and in confusing ways into bugs that manifes

Re: [Qemu-devel] [PATCH v5 05/12] s390-ccw: move auxiliary IPL data to separate location

2018-02-06 Thread Christian Borntraeger
On 02/05/2018 09:57 PM, Collin L. Walling wrote: > The s390-ccw firmware needs some information in support of the > boot process which is not available on the native machine. > Examples are the netboot firmware load address and now the > boot menu parameters. > > While storing that data in unused

Re: [Qemu-devel] [Qemu-arm] [PATCH 5/8] hw/intc/armv7m_nvic: Implement cache ID registers

2018-02-06 Thread Peter Maydell
On 5 February 2018 at 23:53, Philippe Mathieu-Daudé wrote: > Hi Peter, > > On 02/05/2018 07:57 AM, Peter Maydell wrote: >> M profile cores have a similar setup for cache ID registers >> to A profile: >> * Cache Level ID Register (CLIDR) is a fixed value >> * Cache Type Register (CTR) is a fixed

Re: [Qemu-devel] [PATCH] migration: incoming postcopy advise sanity checks

2018-02-06 Thread Dr. David Alan Gilbert
* Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > 06.02.2018 11:43, Greg Kurz wrote: > > On Tue, 6 Feb 2018 10:49:47 +0300 > > Vladimir Sementsov-Ogievskiy wrote: > > > > > 06.02.2018 10:26, Greg Kurz wrote: > > > > If postcopy-ram was set on the source but not on the destination

Re: [Qemu-devel] [PATCH] rtc: placing RTC memory region outside BQL

2018-02-06 Thread Peter Maydell
On 6 February 2018 at 08:24, Gonglei (Arei) wrote: > So, taking BQL is necessary, and what we can do is trying our best to narrow > down the process of locking ? For example, do the following wrapping: > > static void rtc_rasie_irq(RTCState *s) > { > qemu_mutex_lock_iothread(); > qemu_irq_

[Qemu-devel] [ PATCH ] replay additions

2018-02-06 Thread Pavel Dovgalyuk
This set of patches includex fixes from Alex Bennée for fixing BQL and replay locks after inventing the MTTCG. It also includes some additional replay patches that makes this set of fixes working. It is also fixes some vmstate creation (and loading) issues in record/replay modes: - VM start/stop f

[Qemu-devel] [PATCH] m68k: implement movep instruction

2018-02-06 Thread Pavel Dovgalyuk
This patch implements movep instruction. It moves data between a data register and alternate bytes within the address space starting at the location specified and incrementing by two. It was designed for the original 68000 and used in firmwares for interfacing the 8-bit peripherals through the 16-

Re: [Qemu-devel] [PATCH v5 05/12] s390-ccw: move auxiliary IPL data to separate location

2018-02-06 Thread Viktor Mihajlovski
On 06.02.2018 10:45, Christian Borntraeger wrote: > On 02/05/2018 09:57 PM, Collin L. Walling wrote: >> The s390-ccw firmware needs some information in support of the >> boot process which is not available on the native machine. >> Examples are the netboot firmware load address and now the >> boot

[Qemu-devel] [Bug 1416246] Re: create guest fail when compile qemu with parameter "--disable-gtk"

2018-02-06 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QE

Re: [Qemu-devel] [PATCH v5 06/12] s390-ccw: parse and set boot menu options

2018-02-06 Thread Viktor Mihajlovski
On 05.02.2018 21:57, Collin L. Walling wrote: > Set boot menu options for an s390 guest and store them in > the iplb. These options are set via the QEMU command line > option: > > -boot menu=on|off[,splash-time=X] > > or via the libvirt domain xml: > > > > > > Where X repre

Re: [Qemu-devel] [PATCH V4 10/16] qmp event: Add COLO_EXIT event to notify users while exited COLO

2018-02-06 Thread Markus Armbruster
Zhang Chen writes: > On Tue, Feb 6, 2018 at 3:27 PM, Markus Armbruster wrote: > >> Zhang Chen writes: >> >> > On Sat, Feb 3, 2018 at 3:49 PM, Markus Armbruster >> > wrote: >> >> Standard question when I see a new event: is there a way to poll for the >> >> event's information? If not, why do

Re: [Qemu-devel] [ PATCH ] replay additions

2018-02-06 Thread Peter Maydell
On 6 February 2018 at 09:55, Pavel Dovgalyuk wrote: > This set of patches includex fixes from Alex Bennée for fixing > BQL and replay locks after inventing the MTTCG. It also includes some > additional replay patches that makes this set of fixes working. > It is also fixes some vmstate creation (a

Re: [Qemu-devel] [PATCH v4 03/51] qapi: generate a literal qobject for introspection

2018-02-06 Thread Markus Armbruster
Marc-André Lureau writes: > Replace the generated json string with a literal qobject. The later is > easier to deal with, at run time as well as compile time: adding #if > conditionals will be easier than in a json string. > > Signed-off-by: Marc-André Lureau > Reviewed-by: Markus Armbruster I

Re: [Qemu-devel] [ PATCH ] replay additions

2018-02-06 Thread Pavel Dovgalyuk
> From: Peter Maydell [mailto:peter.mayd...@linaro.org] > On 6 February 2018 at 09:55, Pavel Dovgalyuk wrote: > > This set of patches includex fixes from Alex Bennée for fixing > > BQL and replay locks after inventing the MTTCG. It also includes some > > additional replay patches that makes this s

[Qemu-devel] [PATCH v2] migration: incoming postcopy advise sanity checks

2018-02-06 Thread Greg Kurz
If postcopy-ram was set on the source but not on the destination, migration doesn't occur, the destination prints an error and boots the guest: qemu-system-ppc64: Expected vmdescription section, but got 0 We end up with two running instances. This behaviour was introduced in 2.11 by commit 58110

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 11/12] s390-ccw: clear pending irqs

2018-02-06 Thread Thomas Huth
On 05.02.2018 21:57, Collin L. Walling wrote: > It is possible while waiting for multiple types of external > interrupts that we might have pending irqs remaining between > irq consumption and irq disabling. Those interrupts could > propagate to the guest after IPL completes and cause unwanted > be

Re: [Qemu-devel] [PATCH v4 06/51] qapi: pass 'if' condition into QAPISchemaEntity objects

2018-02-06 Thread Markus Armbruster
Marc-André Lureau writes: > Built-in objects remain unconditional. Explicitly defined objects > use the condition specified in the schema. Implicitly defined > objects inherit their condition from their users. For most of them, > there is exactly one user, so the condition to use is obvious.

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 05/12] s390-ccw: move auxiliary IPL data to separate location

2018-02-06 Thread Viktor Mihajlovski
On 06.02.2018 10:23, Thomas Huth wrote: > On 05.02.2018 21:57, Collin L. Walling wrote: >> The s390-ccw firmware needs some information in support of the >> boot process which is not available on the native machine. >> Examples are the netboot firmware load address and now the >> boot menu paramete

Re: [Qemu-devel] [PATCH] m68k: implement movep instruction

2018-02-06 Thread Thomas Huth
On 06.02.2018 10:56, Pavel Dovgalyuk wrote: > This patch implements movep instruction. It moves data between a data register > and alternate bytes within the address space starting at the location > specified and incrementing by two. > > It was designed for the original 68000 and used in firmwares

Re: [Qemu-devel] [PATCH] m68k: implement movep instruction

2018-02-06 Thread Laurent Vivier
Le 06/02/2018 à 11:06, no-re...@patchew.org a écrit : ... > CC m68k-softmmu/target/m68k/translate.o > /var/tmp/patchew-tester-tmp-87qny0g5/src/target/m68k/translate.c: In function > ‘disas_movep’: > /var/tmp/patchew-tester-tmp-87qny0g5/src/target/m68k/translate.c:2110:13: > error: too few

Re: [Qemu-devel] [PATCH v2] pci/bus: let it has higher migration priority

2018-02-06 Thread Marcel Apfelbaum
On 06/02/2018 9:39, Peter Xu wrote: > In the past, we prioritized IOMMU migration so that we have such a > priority order: > > IOMMU > PCI Devices > > When migrating a guest with both vIOMMU and a pcie-root-port, we'll > always migrate vIOMMU first, since pci buses will be seen to have the >

Re: [Qemu-devel] [PATCH v2 0/3] s390x/pci: fixup and optimize IOTLB code

2018-02-06 Thread Cornelia Huck
On Mon, 5 Feb 2018 15:22:55 +0800 Yi Min Zhao wrote: > This series contains three patches, > 1) optimizes the code including walking DMA tables and rpcit handler > 2) fixes the issue caused by IOTLB global refresh > 3) uses the right pal and pba when registering ioat > > The issue mentioned abo

[Qemu-devel] [PATCH v2] linux-user: Implement copy_file_range

2018-02-06 Thread Andreas Schwab
No attempt is made to emulate it on the host. Signed-off-by: Andreas Schwab --- v2: fix spacing --- linux-user/syscall.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index bed154139e..92b4f59c05 100644 --

Re: [Qemu-devel] [PATCH RFC 14/21] qapi: Generate in source order

2018-02-06 Thread Markus Armbruster
Markus Armbruster writes: > Marc-Andre Lureau writes: > >> On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster wrote: >>> The generators' conversion to visitors (merge commit 9e72681d16) >>> changed the processing order of entities from source order to >>> alphabetical order. The next commit nee

[Qemu-devel] [PATCH] target/arm/translate.c: Fix missing 'break' for TT insns

2018-02-06 Thread Peter Maydell
The code where we added the TT instruction was accidentally missing a 'break', which meant that after generating the code to execute the TT we would fall through to 'goto illegal_op' and generate code to take an UNDEF insn. Signed-off-by: Peter Maydell --- Doh... target/arm/translate.c | 1 + 1

Re: [Qemu-devel] [PULL 0/4] Merge tpm 2018/02/03

2018-02-06 Thread Peter Maydell
On 3 February 2018 at 14:09, Stefan Berger wrote: > The following patches do some cleanups and fix the resetting of the TPM > CRB device and add my tpm-next git tree reference to MAINTAINERS. > > The following changes since commit e486b528229ed4ed5dfdac790c8152bfb2a265c9: > > Merge remote-tracki

[Qemu-devel] [PATCH] block: include original filename when reporting invalid URIs

2018-02-06 Thread Daniel P . Berrangé
Consider passing a JSON based block driver to "qemu-img commit" $ qemu-img commit 'json:{"driver":"qcow2","file":{"driver":"gluster",\ "volume":"gv0","path":"sn1.qcow2", "server":[{"type":\ "tcp","host":"10.73.199.197","port":"24007"}]},}' Cur

Re: [Qemu-devel] rate limiting issues

2018-02-06 Thread Wolfgang Bumiller
On Mon, Feb 05, 2018 at 03:31:40PM +, Stefan Hajnoczi wrote: > On Fri, Feb 02, 2018 at 12:10:22PM +0100, Wolfgang Bumiller wrote: (...) > > Explanation: > > The ratelimiting code in include/qemu/ratelimit.h currently uses slices with > > quotas. Finishing up the quota for one slice means it'll

Re: [Qemu-devel] Qemu Trace

2018-02-06 Thread Peter Maydell
On 6 February 2018 at 09:17, Stefan Hajnoczi wrote: > On Mon, Feb 05, 2018 at 03:55:01PM +, Peter Maydell wrote: >> ...and "online processing of traces" is pretty much exactly >> what an instrumentation plugin API is for. > > There are two cases for online processing: > > 1. Synchronous - this

Re: [Qemu-devel] [PATCH v11 04/20] tcg: Add generic vector expanders

2018-02-06 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > Makefile.target |2 +- > accel/tcg/tcg-runtime.h | 29 + > tcg/tcg-gvec-desc.h | 49 ++ > tcg/tcg-op-gvec.h| 198 +++ > tcg/tcg-op.h

Re: [Qemu-devel] [PATCH v4 03/51] qapi: generate a literal qobject for introspection

2018-02-06 Thread Marc-André Lureau
On Tue, Feb 6, 2018 at 11:04 AM, Markus Armbruster wrote: > Marc-André Lureau writes: > >> Replace the generated json string with a literal qobject. The later is >> easier to deal with, at run time as well as compile time: adding #if >> conditionals will be easier than in a json string. >> >> Sig

Re: [Qemu-devel] [PATCH v11 05/20] tcg: Add generic vector ops for constant shifts

2018-02-06 Thread Alex Bennée
Richard Henderson writes: > Opcodes are added for scalar and vector shifts, but considering the > varied semantics of these do not expose them to the front ends. Do > go ahead and provide them in case they are needed for backend expansion. > > Signed-off-by: Richard Henderson Reviewed-by: Ale

Re: [Qemu-devel] [PATCH v11 07/20] tcg: Add generic vector ops for multiplication

2018-02-06 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > accel/tcg/tcg-runtime.h | 5 + > tcg/tcg-op-gvec.h| 2 ++ > tcg/tcg-op.h | 1 + > tcg/tcg-opc.h| 1 + > tcg/tcg.h| 1 +

Re: [Qemu-devel] [PATCH v11 08/20] tcg: Add generic helpers for saturating arithmetic

2018-02-06 Thread Alex Bennée
Richard Henderson writes: > No vector ops as yet. SSE only has direct support for 8- and 16-bit > saturation; handling 32- and 64-bit saturation is much more expensive. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > accel/tcg/tcg-runtime.h | 20 > tcg/tcg-

Re: [Qemu-devel] [PATCH v11 09/20] tcg: Add generic vector helpers with a scalar operand

2018-02-06 Thread Alex Bennée
Richard Henderson writes: > Use dup to convert a non-constant scalar to a third vector. > > Add addition, multiplication, and logical operations with an immediate. > Add addition, subtraction, multiplication, and logical operations with > a non-constant scalar. Allow for the front-end to build

Re: [Qemu-devel] [PATCH v4 42/51] qapi: add a 'unit' pragma

2018-02-06 Thread Marc-André Lureau
On Mon, Feb 5, 2018 at 7:13 PM, Markus Armbruster wrote: > Marc-André Lureau writes: > >> Hi >> >> On Thu, Jan 11, 2018 at 10:32 PM, Marc-André Lureau >> wrote: >>> Add a pragma that allows to tag the following expressions in the >>> schema with a unit name. By default, an expression has no unit

Re: [Qemu-devel] [PATCH v11 06/20] tcg: Add generic vector ops for comparisons

2018-02-06 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > accel/tcg/tcg-runtime.h | 30 + > tcg/tcg-op-gvec.h| 4 ++ > tcg/tcg-op.h | 3 + > tcg/tcg-opc.h| 2 + > accel/tcg/tcg-runtime-gvec.c

Re: [Qemu-devel] [PATCH v4 06/51] qapi: pass 'if' condition into QAPISchemaEntity objects

2018-02-06 Thread Marc-André Lureau
Hi On Tue, Feb 6, 2018 at 11:12 AM, Markus Armbruster wrote: > Marc-André Lureau writes: > >> Built-in objects remain unconditional. Explicitly defined objects >> use the condition specified in the schema. Implicitly defined >> objects inherit their condition from their users. For most of the

Re: [Qemu-devel] [PATCH v11 13/20] target/arm: Use vector infrastructure for aa64 mov/not/neg

2018-02-06 Thread Alex Bennée
Richard Henderson writes: > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/arm/translate-a64.c | 42 -- > 1 file changed, 36 insertions(+), 6 deletions(-) > > diff --git a/target/arm/translate-a6

Re: [Qemu-devel] [PATCH v11 14/20] target/arm: Use vector infrastructure for aa64 dup/movi

2018-02-06 Thread Alex Bennée
Richard Henderson writes: > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/arm/translate-a64.c | 81 > +++--- > 1 file changed, 33 insertions(+), 48 deletions(-) > > diff --git a/target/arm/tran

Re: [Qemu-devel] [PATCH v2] migration: incoming postcopy advise sanity checks

2018-02-06 Thread Daniel Henrique Barboza
On 02/06/2018 08:05 AM, Greg Kurz wrote: If postcopy-ram was set on the source but not on the destination, migration doesn't occur, the destination prints an error and boots the guest: qemu-system-ppc64: Expected vmdescription section, but got 0 We end up with two running instances. This beh

Re: [Qemu-devel] [PATCH v11 10/20] tcg/optimize: Handle vector opcodes during optimize

2018-02-06 Thread Alex Bennée
Richard Henderson writes: > Trivial move and constant propagation. Some identity and constant > function folding, but nothing that requires knowledge of the size > of the vector element. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > tcg/optimize.c | 150 > +

Re: [Qemu-devel] [PATCH v11 18/20] target/arm: Use vector infrastructure for aa64 orr/bic immediate

2018-02-06 Thread Alex Bennée
Richard Henderson writes: > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/arm/translate-a64.c | 28 +--- > 1 file changed, 5 insertions(+), 23 deletions(-) > > diff --git a/target/arm/translate-a64.c b/target/a

Re: [Qemu-devel] [PATCH v11 16/20] target/arm: Use vector infrastructure for aa64 compares

2018-02-06 Thread Alex Bennée
Richard Henderson writes: > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/arm/translate-a64.c | 93 > +- > 1 file changed, 59 insertions(+), 34 deletions(-) > > diff --git a/target/arm/tran

Re: [Qemu-devel] [PATCH v11 20/20] tcg/aarch64: Add vector operations

2018-02-06 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > tcg/aarch64/tcg-target.h | 25 +- > tcg/aarch64/tcg-target.opc.h | 3 + > tcg/aarch64/tcg-target.inc.c | 588 > +++ > 3 files changed, 569 insertions

[Qemu-devel] [Bug 1155677] Re: snapshot=on fails with non file-based storage

2018-02-06 Thread Thomas Huth
Triaging old bug tickets... I think this has likely been fixed in 2013 ... or can you still reproduce this issue with the latest version of QEMU? Could we close this ticket nowadays? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. htt

Re: [Qemu-devel] [PATCH v11 17/20] target/arm: Use vector infrastructure for aa64 multiplies

2018-02-06 Thread Alex Bennée
Richard Henderson writes: > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/arm/translate-a64.c | 154 > + > 1 file changed, 129 insertions(+), 25 deletions(-) > > diff --git a/target/arm/tra

Re: [Qemu-devel] [PATCH v2 1/4] migration: Don't leak IO channels

2018-02-06 Thread Dr. David Alan Gilbert
* Ross Lagerwall (ross.lagerw...@citrix.com) wrote: > Since qemu_fopen_channel_{in,out}put take references on the underlying > IO channels, make sure to release our references to them. > > Signed-off-by: Ross Lagerwall Queued for migration. Dave > --- > New in v2. > > migration/savevm.c | 2

Re: [Qemu-devel] [PATCH v4 07/51] qapi: leave the ifcond attribute undefined until check()

2018-02-06 Thread Markus Armbruster
Second thoughts... Marc-André Lureau writes: > We commonly initialize attributes to None in .init(), then set their > real value in .check(). Accessing the attribute before .check() > yields None. If we're lucky, the code that accesses the attribute > prematurely chokes on None. > > It won't f

[Qemu-devel] [PATCH v2] m68k: implement movep instruction

2018-02-06 Thread Pavel Dovgalyuk
This patch implements movep instruction. It moves data between a data register and alternate bytes within the address space starting at the location specified and incrementing by two. It was designed for the original 68000 and used in firmwares for interfacing the 8-bit peripherals through the 16-

Re: [Qemu-devel] [PATCH v2] migration: incoming postcopy advise sanity checks

2018-02-06 Thread Vladimir Sementsov-Ogievskiy
06.02.2018 13:05, Greg Kurz wrote: If postcopy-ram was set on the source but not on the destination, migration doesn't occur, the destination prints an error and boots the guest: qemu-system-ppc64: Expected vmdescription section, but got 0 We end up with two running instances. This behaviour w

Re: [Qemu-devel] [PATCH] m68k: implement movep instruction

2018-02-06 Thread Laurent Vivier
Le 06/02/2018 à 10:56, Pavel Dovgalyuk a écrit : > This patch implements movep instruction. It moves data between a data register > and alternate bytes within the address space starting at the location > specified and incrementing by two. > > It was designed for the original 68000 and used in firm

Re: [Qemu-devel] [PATCH v2] migration: incoming postcopy advise sanity checks

2018-02-06 Thread Dr. David Alan Gilbert
* Greg Kurz (gr...@kaod.org) wrote: > If postcopy-ram was set on the source but not on the destination, > migration doesn't occur, the destination prints an error and boots > the guest: > > qemu-system-ppc64: Expected vmdescription section, but got 0 > > We end up with two running instances. > >

[Qemu-devel] [PATCH v3] migration: incoming postcopy advise sanity checks

2018-02-06 Thread Greg Kurz
If postcopy-ram was set on the source but not on the destination, migration doesn't occur, the destination prints an error and boots the guest: qemu-system-ppc64: Expected vmdescription section, but got 0 We end up with two running instances. This behaviour was introduced in 2.11 by commit 58110

Re: [Qemu-devel] [PATCH v11 00/20] tcg: generic vector operations

2018-02-06 Thread Alex Bennée
Richard Henderson writes: > Changes since v11: > * Use dup_const more. > * Cleanup some gvec 2i and 2s routines. > * Use more helpers and less gotos in target/arm/translate-a64.c. I think this series is good to go. A quick word on performance. I saw a slight dip for the string sort in Em

Re: [Qemu-devel] [PATCH v2] m68k: implement movep instruction

2018-02-06 Thread Laurent Vivier
Le 06/02/2018 à 12:19, Pavel Dovgalyuk a écrit : > This patch implements movep instruction. It moves data between a data register > and alternate bytes within the address space starting at the location > specified and incrementing by two. > > It was designed for the original 68000 and used in firm

Re: [Qemu-devel] [PATCH v3] tap: close fd conditionally when error occured

2018-02-06 Thread Zhoujian (jay)
Hi Jason, > -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Tuesday, February 06, 2018 5:29 PM > To: Zhoujian (jay) ; qemu-devel@nongnu.org > Cc: m...@redhat.com; imamm...@redhat.com; Huangweidong (C) > ; wangxin (U) ; Gonglei > (Arei) > Subject: Re: [PATCH v3]

[Qemu-devel] [PATCH v2 1/3] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-02-06 Thread Wei Wang
The new feature enables the virtio-balloon device to receive the hint of guest free pages from the free page vq, and clears the corresponding bits of the free page from the dirty bitmap, so that those free pages are not transferred by the migration thread. Signed-off-by: Wei Wang Signed-off-by: L

[Qemu-devel] [PATCH v2 2/3] migration: use the free page reporting feature from balloon

2018-02-06 Thread Wei Wang
Use the free page reporting feature from the balloon device to clear the bits corresponding to guest free pages from the dirty bitmap, so that the free memory are not sent. Signed-off-by: Wei Wang CC: Michael S. Tsirkin CC: Juan Quintela --- migration/ram.c | 24 1 fil

[Qemu-devel] [PATCH v2 0/3] virtio-balloon: free page hint reporting support

2018-02-06 Thread Wei Wang
This is the deivce part implementation to add a new feature, VIRTIO_BALLOON_F_FREE_PAGE_HINT to the virtio-balloon device. The device receives the guest free page hints from the driver and clears the corresponding bits in the dirty bitmap, so that those free pages are not transferred by the migrati

[Qemu-devel] [PATCH v2 3/3] virtio-balloon: add a timer to limit the free page report waiting time

2018-02-06 Thread Wei Wang
This patch adds a timer to limit the time that host waits for the free page hints reported by the guest. Users can specify the time in ms via "free-page-wait-time" command line option. If a user doesn't specify a time, host waits till the guest finishes reporting all the free page hints. The policy

Re: [Qemu-devel] [PATCH v3] migration: incoming postcopy advise sanity checks

2018-02-06 Thread Dr. David Alan Gilbert
* Greg Kurz (gr...@kaod.org) wrote: > If postcopy-ram was set on the source but not on the destination, > migration doesn't occur, the destination prints an error and boots > the guest: > > qemu-system-ppc64: Expected vmdescription section, but got 0 > > We end up with two running instances. > >

[Qemu-devel] [PATCH v3] m68k: implement movep instruction

2018-02-06 Thread Pavel Dovgalyuk
This patch implements movep instruction. It moves data between a data register and alternate bytes within the address space starting at the location specified and incrementing by two. It was designed for the original 68000 and used in firmwares for interfacing the 8-bit peripherals through the 16-

Re: [Qemu-devel] Block Migration and CPU throttling

2018-02-06 Thread Peter Lieven
Am 12.12.2017 um 18:05 schrieb Dr. David Alan Gilbert: * Peter Lieven (p...@kamp.de) wrote: Am 21.09.2017 um 14:36 schrieb Dr. David Alan Gilbert: * Peter Lieven (p...@kamp.de) wrote: Am 19.09.2017 um 16:41 schrieb Dr. David Alan Gilbert: * Peter Lieven (p...@kamp.de) wrote: Am 19.09.2017 um

[Qemu-devel] [Bug 1155677] Re: snapshot=on fails with non file-based storage

2018-02-06 Thread Richard Jones
Let's close this. libguestfs doesn't use snapshot=on any longer. ** Changed in: qemu Status: In Progress => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1155677 Title: snapshot

Re: [Qemu-devel] [Qemu-arm] [PATCH] target/arm/translate.c: Fix missing 'break' for TT insns

2018-02-06 Thread Philippe Mathieu-Daudé
On 02/06/2018 07:39 AM, Peter Maydell wrote: > The code where we added the TT instruction was accidentally "In 5158de241b0 ..." > missing a 'break', which meant that after generating the code > to execute the TT we would fall through to 'goto illegal_op' > and generate code to take an UNDEF insn.

Re: [Qemu-devel] [PATCH v11 00/20] tcg: generic vector operations

2018-02-06 Thread Philippe Mathieu-Daudé
On 02/06/2018 08:24 AM, Alex Bennée wrote: > > I think this series is good to go. The x86 patch still require a volunteer to review ;) signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH v3] m68k: implement movep instruction

2018-02-06 Thread Laurent Vivier
Le 06/02/2018 à 12:43, Pavel Dovgalyuk a écrit : > This patch implements movep instruction. It moves data between a data register > and alternate bytes within the address space starting at the location > specified and incrementing by two. > > It was designed for the original 68000 and used in firm

Re: [Qemu-devel] [PATCH v4 06/51] qapi: pass 'if' condition into QAPISchemaEntity objects

2018-02-06 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Tue, Feb 6, 2018 at 11:12 AM, Markus Armbruster wrote: >> Marc-André Lureau writes: >> >>> Built-in objects remain unconditional. Explicitly defined objects >>> use the condition specified in the schema. Implicitly defined >>> objects inherit their condit

Re: [Qemu-devel] [PATCH v7 10/20] hw/arm/smmuv3: Implement translate callback

2018-02-06 Thread Auger Eric
Hi Peter, On 09/10/17 19:45, Peter Maydell wrote: > On 1 September 2017 at 18:21, Eric Auger wrote: >> This patch implements the IOMMU Memory Region translate() >> callback. Most of the code relates to the translation >> configuration decoding and check (STE, CD). >> >> Signed-off-by: Eric Auger

Re: [Qemu-devel] [PATCH v9 00/16] SDHCI: clean v1/v2 Specs (part 2)

2018-02-06 Thread Philippe Mathieu-Daudé
On 01/31/2018 01:26 PM, Alistair Francis wrote: > On Wed, Jan 31, 2018 at 6:09 AM, Philippe Mathieu-Daudé > wrote: >> ping? >> >> Patches missing review: 2 (PCI qtesting),11,13,15 > > Sorry about the slowness. Besides 2 they should be all reviewed now, > let me know if anything else needs to be

Re: [Qemu-devel] [PATCH v8 00/14] ARM SMMUv3 Emulation Support

2018-02-06 Thread Auger Eric
Hi, On 05/02/18 15:53, no-re...@patchew.org wrote: > Hi, > > This series failed docker-mingw@fedora build test. Please find the testing > commands and > their output below. If you have Docker installed, you can probably reproduce > it > locally. > > Type: series > Message-id: 1517837972-1904-1

Re: [Qemu-devel] [PATCH v4 42/51] qapi: add a 'unit' pragma

2018-02-06 Thread Markus Armbruster
Marc-André Lureau writes: > On Mon, Feb 5, 2018 at 7:13 PM, Markus Armbruster wrote: >> Marc-André Lureau writes: >> >>> Hi >>> >>> On Thu, Jan 11, 2018 at 10:32 PM, Marc-André Lureau >>> wrote: Add a pragma that allows to tag the following expressions in the schema with a unit name.

Re: [Qemu-devel] [PATCH v11 00/20] tcg: generic vector operations

2018-02-06 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 02/06/2018 08:24 AM, Alex Bennée wrote: >> >> I think this series is good to go. > > The x86 patch still require a volunteer to review ;) It looks good enough for me although I'm only a casual observer of x86 ;-) Reviewed-by: Alex Bennée -- Alex Bennée

Re: [Qemu-devel] [RFC 0/2] virtio-vhost-user: add virtio-vhost-user device

2018-02-06 Thread Wang, Wei W
On Tuesday, February 6, 2018 5:32 PM, Stefan Hajnoczi wrote: > On Tue, Feb 06, 2018 at 01:28:25AM +, Wang, Wei W wrote: > > On Tuesday, February 6, 2018 12:26 AM, Stefan Hajnoczi wrote: > > > On Fri, Feb 02, 2018 at 09:08:44PM +0800, Wei Wang wrote: > > > > On 02/02/2018 01:08 AM, Michael S. Ts

Re: [Qemu-devel] [PATCH v7 10/20] hw/arm/smmuv3: Implement translate callback

2018-02-06 Thread Peter Maydell
On 6 February 2018 at 12:19, Auger Eric wrote: > On 09/10/17 19:45, Peter Maydell wrote: >> Incidentally, the spec requires us to perform memory accesses as >> at least 64-bit single-copy atomic (see 3.21.3) -- does this do that? >> (This gets important with SMP when the guest on another CPU might

Re: [Qemu-devel] [PATCH v2 4/6] hw/sd/pl181: expose a SDBus and connect the SDCard to it

2018-02-06 Thread Philippe Mathieu-Daudé
Hi Alistair, On 01/31/2018 01:41 PM, Alistair Francis wrote: > On Mon, Jan 22, 2018 at 7:58 PM, Philippe Mathieu-Daudé > wrote: >> using the sdbus_*() API. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> hw/sd/pl181.c | 31 --- >> 1 file changed, 20 insertions

Re: [Qemu-devel] [PATCH V4 10/16] qmp event: Add COLO_EXIT event to notify users while exited COLO

2018-02-06 Thread Zhang Chen
On Tue, Feb 6, 2018 at 5:53 PM, Markus Armbruster wrote: > Zhang Chen writes: > > > On Tue, Feb 6, 2018 at 3:27 PM, Markus Armbruster > wrote: > > > >> Zhang Chen writes: > >> > >> > On Sat, Feb 3, 2018 at 3:49 PM, Markus Armbruster > wrote: > >> >> Standard question when I see a new event: i

Re: [Qemu-devel] [PATCH v8 00/14] ARM SMMUv3 Emulation Support

2018-02-06 Thread Peter Maydell
On 6 February 2018 at 12:22, Auger Eric wrote: > I will add > #include "qemu/log.h" in smmuv3-internal.h in next release, to fix this > mingw compilation issue. It's an issue with configs that don't use the 'log' trace backend, rather than mingw specifically. (It just happens that patchew's mingw

[Qemu-devel] [PATCH v4] m68k: implement movep instruction

2018-02-06 Thread Pavel Dovgalyuk
This patch implements movep instruction. It moves data between a data register and alternate bytes within the address space starting at the location specified and incrementing by two. It was designed for the original 68000 and used in firmwares for interfacing the 8-bit peripherals through the 16-

Re: [Qemu-devel] [PATCH v5 1/1] s390x/cpu: expose the guest crash information

2018-02-06 Thread Cornelia Huck
On Tue, 6 Feb 2018 07:46:22 + Christian Borntraeger wrote: > This patch is the s390 implementation of guest crash information, > similar to commit d187e08dc4 ("i386/cpu: add crash-information QOM > property") and the related commits. We will detect several crash > reasons, with the "disabled

[Qemu-devel] [PATCH v4] tap: setting error appropriately when calling net_init_tap_one()

2018-02-06 Thread Jay Zhou
If netdev_add tap,id=net0,...,vhost=on failed in net_init_tap_one(), the followed up device_add virtio-net-pci,netdev=net0 will fail too, prints: TUNSETOFFLOAD ioctl() failed: Bad file descriptor TUNSETOFFLOAD ioctl() failed: Bad file descriptor The reason is that the fd of tap is closed wh

Re: [Qemu-devel] [PATCH v7 10/20] hw/arm/smmuv3: Implement translate callback

2018-02-06 Thread Auger Eric
Hi Peter, On 06/02/18 13:43, Peter Maydell wrote: > On 6 February 2018 at 12:19, Auger Eric wrote: >> On 09/10/17 19:45, Peter Maydell wrote: >>> Incidentally, the spec requires us to perform memory accesses as >>> at least 64-bit single-copy atomic (see 3.21.3) -- does this do that? >>> (This get

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 1/1] s390x/cpu: expose the guest crash information

2018-02-06 Thread Christian Borntraeger
On 02/06/2018 01:49 PM, Cornelia Huck wrote: > On Tue, 6 Feb 2018 07:46:22 + > Christian Borntraeger wrote: > >> This patch is the s390 implementation of guest crash information, >> similar to commit d187e08dc4 ("i386/cpu: add crash-information QOM >> property") and the related commits. We

  1   2   3   4   5   >