Re: [Qemu-devel] [qemu-s390x] [PATCH] s390x/sclp: fix event mask handling

2018-02-05 Thread David Hildenbrand
On 02.02.2018 10:42, Christian Borntraeger wrote: > commit 67915de9f038 ("s390x/event-facility: variable-length event > masks") switches the sclp receive/send mask. This broke the sclp > lm console. > > Signed-off-by: Christian Borntraeger > Fixes: commit 67915de9f038 ("s390x/event-facility: vari

Re: [Qemu-devel] [PATCH v3 1/1] s390x/cpu: expose the guest crash information

2018-02-05 Thread Christian Borntraeger
patchew complained, so something like this on top diff --git a/qapi/run-state.json b/qapi/run-state.json index a93f6fea5c..a148088252 100644 --- a/qapi/run-state.json +++ b/qapi/run-state.json @@ -328,21 +328,19 @@ ## { 'enum': 'GuestPanicInformationType', 'data': [ 'hyper-v', 's390' ] }

Re: [Qemu-devel] [PATCH] s390x/sclp: fix event mask handling

2018-02-05 Thread Christian Borntraeger
On 02/02/2018 10:42 AM, Christian Borntraeger wrote: > commit 67915de9f038 ("s390x/event-facility: variable-length event > masks") switches the sclp receive/send mask. This broke the sclp switched > lm console. > > Signed-off-by: Christian Borntraeger > Fixes: commit 67915de9f038 ("s

Re: [Qemu-devel] [PATCH v3 02/12] vl: deprecate -alt-grab and -ctrl-grab

2018-02-05 Thread Gerd Hoffmann
Hi, > > +@subsection -alt-grab and -ctrl-grab (since 2.12.0) > > + > > +The ``-alt-grab'' and ``-ctrl-grab'' arguments are deprecated. They > > +work with SDL only. They will eventually replaced with a new way to > > +configure hotkeys which works consistently across all user interfaces. > >

[Qemu-devel] [PATCH] s390x/cpumodel: model PTFF subfunctions for Multiple-epoch facility

2018-02-05 Thread David Hildenbrand
For now, the kernel does not properly indicate configured CPU subfunctions to the guest, but simply uses the host values (as support in KVM is still missing). That's why we missed to model the PTFF subfunctions that come with Multiple-epoch facility. Let's properly add these, along with a new feat

Re: [Qemu-devel] [PULL 6/8] iotest 205: new test for qmp nbd-server-remove

2018-02-05 Thread Kevin Wolf
Am 26.01.2018 um 17:04 hat Eric Blake geschrieben: > From: Vladimir Sementsov-Ogievskiy > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Message-Id: <20180119135719.24745-6-vsement...@virtuozzo.com> > [eblake: adjust to next available test number] > Signed-off-by: Eric Blake > --- > tests/qem

Re: [Qemu-devel] [PATCH V6] pci: removed the is_express field since a uniform interface was inserted

2018-02-05 Thread Yoni Bettan
On 01/16/2018 02:34 PM, Yoni Bettan wrote: according to Eduardo Habkost's commit fd3b02c889 all PCIEs now implement INTERFACE_PCIE_DEVICE so we don't need is_express field anymore. Devices that implements only INTERFACE_PCIE_DEVICE (is_express == 1) or devices that implements only INTERFACE_CO

Re: [Qemu-devel] [PATCH] s390x/cpumodel: model PTFF subfunctions for Multiple-epoch facility

2018-02-05 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180205090912.6110-1-da...@redhat.com Subject: [Qemu-devel] [PATCH] s390x/cpumodel: model PTFF subfunctions for Multiple-epoch facility === TEST SCRIPT BEGIN === #!/bin/bas

Re: [Qemu-devel] [PULL 0/3] Ui 20180202 patches

2018-02-05 Thread Peter Maydell
On 2 February 2018 at 07:17, Gerd Hoffmann wrote: > The following changes since commit 11ed801d3df3c6e46b2f1f97dcfbf4ca3a2a2f4f: > > Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' > into staging (2018-01-30 09:47:51 +) > > are available in the git repository at: >

Re: [Qemu-devel] [PATCH] s390x/cpumodel: model PTFF subfunctions for Multiple-epoch facility

2018-02-05 Thread David Hildenbrand
On 05.02.2018 10:09, David Hildenbrand wrote: > For now, the kernel does not properly indicate configured CPU subfunctions > to the guest, but simply uses the host values (as support in KVM is still > missing). That's why we missed to model the PTFF subfunctions that come > with Multiple-epoch faci

[Qemu-devel] can not post bugs, launchpad error

2018-02-05 Thread Toomas Soome
hi! the bugtracker is quite unusable (has been for over an week), thats the error from login: Oops! Sorry, something just went wrong in Launchpad. We’ve recorded what happened, and we’ll fix it as soon as possible. Apologies for the inconvenience. (Error ID: OOPS-034f5b0a9d04aa045371d78c3e6d056

[Qemu-devel] [PATCH] migration: Recover block devices if failure in device state

2018-02-05 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" In e91d895 I added the new pause-before-switchover mechanism to allow migration completion to be delayed; this changes the last state prior to completion to MIGRATE_STATUS_DEVICE rather than MIGRATE_STATUS_ACTIVE. Fix the failure path in migration_completion to rec

Re: [Qemu-devel] can not post bugs, launchpad error

2018-02-05 Thread Peter Maydell
On 5 February 2018 at 09:36, Toomas Soome wrote: > the bugtracker is quite unusable (has been for over an week), thats the error > from login: > > Oops! > Sorry, something just went wrong in Launchpad. > We’ve recorded what happened, and we’ll fix it as soon as possible. Apologies > for the inco

Re: [Qemu-devel] can not post bugs, launchpad error

2018-02-05 Thread Dr. David Alan Gilbert
* Toomas Soome (tso...@me.com) wrote: > hi! > > the bugtracker is quite unusable (has been for over an week), thats the error > from login: > > Oops! > Sorry, something just went wrong in Launchpad. > We’ve recorded what happened, and we’ll fix it as soon as possible. Apologies > for the inconv

Re: [Qemu-devel] [PULL 15/18] migration: split common postcopy out of ram postcopy

2018-02-05 Thread Greg Kurz
On Fri, 22 Sep 2017 14:25:02 +0200 Juan Quintela wrote: > From: Vladimir Sementsov-Ogievskiy > > Split common postcopy staff from ram postcopy staff. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Dr. David Alan Gilbert > Reviewed-by: Juan Quintela > Signed-off-by: Juan Quin

Re: [Qemu-devel] [PATCH v3 06/12] vl: drop no_quit variable

2018-02-05 Thread Gerd Hoffmann
On Fri, Feb 02, 2018 at 09:35:52AM -0600, Eric Blake wrote: > On 02/02/2018 05:10 AM, Gerd Hoffmann wrote: > > Not used any more, delete it. > > > > Signed-off-by: Gerd Hoffmann > > --- > > vl.c | 7 ++- > > 1 file changed, 2 insertions(+), 5 deletions(-) > > > > diff --git a/vl.c b/vl.c >

Re: [Qemu-devel] [RFC 0/2] virtio-vhost-user: add virtio-vhost-user device

2018-02-05 Thread Wang, Wei W
On Friday, February 2, 2018 11:26 PM, Stefan Hajnoczi wrote: > On Tue, Jan 30, 2018 at 08:09:19PM +0800, Wei Wang wrote: > > Background: > > The vhost-user negotiation is split into 2 phases currently. The 1st > > phase happens when the connection is established, and we can find > > what's done in

Re: [Qemu-devel] [PATCH] s390x/cpumodel: model PTFF subfunctions for Multiple-epoch facility

2018-02-05 Thread Christian Borntraeger
On 02/05/2018 10:34 AM, David Hildenbrand wrote: > On 05.02.2018 10:09, David Hildenbrand wrote: >> For now, the kernel does not properly indicate configured CPU subfunctions >> to the guest, but simply uses the host values (as support in KVM is still >> missing). That's why we missed to model th

Re: [Qemu-devel] [PATCH v3 2/2] README: Document 'git-publish' workflow

2018-02-05 Thread Marc-André Lureau
On Mon, Feb 5, 2018 at 6:47 AM, Fam Zheng wrote: > Signed-off-by: Fam Zheng Looks good, thanks, Reviewed-by: Marc-André Lureau > --- > README | 30 +- > 1 file changed, 29 insertions(+), 1 deletion(-) > > diff --git a/README b/README > index b92a07a61a..d1a944ce20

Re: [Qemu-devel] [PATCH v3 1/2] Add a git-publish configuration file

2018-02-05 Thread Marc-André Lureau
Hi On Mon, Feb 5, 2018 at 6:47 AM, Fam Zheng wrote: > git-publish [1] is a convenient tool to send patches and has been > popular among QEMU developers. Recently it has been made available in > Fedora official repo thanks to Stefan's work. > > One nice feature of the tool is a per-project config

[Qemu-devel] [PULL 0/4] RDMA patches

2018-02-05 Thread Marcel Apfelbaum
The following changes since commit f24ee107a07f093bd7ed475dd48d7ba57ea3d8fe: Merge remote-tracking branch 'remotes/kraxel/tags/ui-20180202-pull-request' into staging (2018-02-02 18:54:11 +) are available in the git repository at: https://github.com/marcel-apf/qemu tags/rdma-pull-request

[Qemu-devel] [PULL 4/4] MAINTAINERS: add entry for hw/rdma

2018-02-05 Thread Marcel Apfelbaum
Signed-off-by: Marcel Apfelbaum Signed-off-by: Yuval Shaia --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0f952d46ce..3e34ae25ea 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1995,6 +1995,14 @@ F: block/replication.c F: tests/test-re

[Qemu-devel] [PULL 2/4] docs: add pvrdma device documentation.

2018-02-05 Thread Marcel Apfelbaum
Signed-off-by: Marcel Apfelbaum Signed-off-by: Yuval Shaia Reviewed-by: Shamir Rabinovitch --- docs/pvrdma.txt | 255 1 file changed, 255 insertions(+) create mode 100644 docs/pvrdma.txt diff --git a/docs/pvrdma.txt b/docs/pvrdma.txt ne

[Qemu-devel] [PULL 1/4] mem: add share parameter to memory-backend-ram

2018-02-05 Thread Marcel Apfelbaum
Currently only file backed memory backend can be created with a "share" flag in order to allow sharing guest RAM with other processes in the host. Add the "share" flag also to RAM Memory Backend in order to allow remapping parts of the guest RAM to different host virtual addresses. This is needed

[Qemu-devel] [PATCH v2] s390x/cpumodel: model PTFF subfunctions for Multiple-epoch facility

2018-02-05 Thread David Hildenbrand
For now, the kernel does not properly indicate configured CPU subfunctions to the guest, but simply uses the host values (as support in KVM is still missing). That's why we missed to model the PTFF subfunctions that come with Multiple-epoch facility. Let's properly add these, along with a new feat

Re: [Qemu-devel] [PATCH 4/6] target/arm: Add "-cpu max" support

2018-02-05 Thread Igor Mammedov
On Fri, 2 Feb 2018 17:54:43 + Peter Maydell wrote: > On 26 January 2018 at 15:44, Philippe Mathieu-Daudé wrote: > > On 01/26/2018 11:33 AM, Peter Maydell wrote: > >> On 26 January 2018 at 14:29, Philippe Mathieu-Daudé > >> wrote: > >>> Why not use arm_any_initfn() here? > >> > >> Tha

[Qemu-devel] [Bug 1747393] [NEW] nvme is missing support for NVME_ADM_CMD_ASYNC_EV_REQ

2018-02-05 Thread Toomas Soome
Public bug reported: NVME_ADM_CMD_ASYNC_EV_REQ is required by specification but apparently we will be responded by error when this command is used. ** Affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml,

Re: [Qemu-devel] [PATCH v2] s390x/cpumodel: model PTFF subfunctions for Multiple-epoch facility

2018-02-05 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180205102935.14736-1-da...@redhat.com Subject: [Qemu-devel] [PATCH v2] s390x/cpumodel: model PTFF subfunctions for Multiple-epoch facility === TEST SCRIPT BEGIN === #!/bin

[Qemu-devel] [PATCH 0/8] v8m: minor missing regs and bugfixes

2018-02-05 Thread Peter Maydell
This patchset is the result of comparing the registers listed in the v8M Arm ARM against what QEMU was implementing. It adds a collection of generally unexciting missing registers (most of which we can simply NOP or make reads-as-written). There are also a couple of bug fixes in there, of which the

[Qemu-devel] [PATCH 6/8] hw/intc/armv7m_nvic: Implement SCR

2018-02-05 Thread Peter Maydell
We were previously making the system control register (SCR) just RAZ/WI. Although we don't implement the functionality this register controls, we should at least provide the state, including the banked state for v8M. Signed-off-by: Peter Maydell --- target/arm/cpu.h | 7 +++ hw/intc/ar

[Qemu-devel] [PATCH 8/8] hw/intc/armv7m_nvic: Fix byte-to-interrupt number conversions

2018-02-05 Thread Peter Maydell
In many of the NVIC registers relating to interrupts, we have to convert from a byte offset within a register set into the number of the first interrupt which is affected. We were getting this wrong for: * reads of NVIC_ISPR, NVIC_ISER, NVIC_ICPR, NVIC_ICER, NVIC_IABR -- in all these cases we w

[Qemu-devel] [PATCH 1/8] hw/intc/armv7m_nvic: Don't hardcode M profile ID registers in NVIC

2018-02-05 Thread Peter Maydell
Instead of hardcoding the values of M profile ID registers in the NVIC, use the fields in the CPU struct. This will allow us to give different M profile CPU types different ID register values. This commit includes the addition of the missing ID_ISAR5, which exists as RES0 in both v7M and v8M. (Th

[Qemu-devel] [PATCH 5/8] hw/intc/armv7m_nvic: Implement cache ID registers

2018-02-05 Thread Peter Maydell
M profile cores have a similar setup for cache ID registers to A profile: * Cache Level ID Register (CLIDR) is a fixed value * Cache Type Register (CTR) is a fixed value * Cache Size ID Registers (CCSIDR) are a bank of registers; which one you see is selected by the Cache Size Selection Re

[Qemu-devel] [PATCH 7/8] target/arm: Implement writing to CONTROL_NS for v8M

2018-02-05 Thread Peter Maydell
In commit 50f11062d4c896 we added support for MSR/MRS access to the NS banked special registers, but we forgot to implement the support for writing to CONTROL_NS. Correct the omission. Signed-off-by: Peter Maydell --- target/arm/helper.c | 10 ++ 1 file changed, 10 insertions(+) diff --

[Qemu-devel] [PATCH 4/8] hw/intc/armv7m_nvic: Implement v8M CPPWR register

2018-02-05 Thread Peter Maydell
The Coprocessor Power Control Register (CPPWR) is new in v8M. It allows software to control whether coprocessors are allowed to power down and lose their state. QEMU doesn't have any notion of power control, so we choose the IMPDEF option of making the whole register RAZ/WI (indicating that no copr

[Qemu-devel] [PATCH 2/8] hw/intc/armv7m_nvic: Fix ICSR PENDNMISET/CLR handling

2018-02-05 Thread Peter Maydell
The PENDNMISET/CLR bits in the ICSR should be RAZ/WI from NonSecure state if the AIRCR.BFHFNMINS bit is zero. We had misimplemented this as making the bits RAZ/WI from both Secure and NonSecure states. Fix this bug by checking attrs.secure so that Secure code can pend and unpend NMIs. Signed-off-b

[Qemu-devel] [PATCH 3/8] hw/intc/armv7m_nvic: Implement M profile cache maintenance ops

2018-02-05 Thread Peter Maydell
For M profile cores, cache maintenance operations are done by writing to special registers in the system register space. For QEMU, cache operations are always NOPs, since we don't implement the cache. Implementing these explicitly avoids a spurious LOG_GUEST_ERROR when the guest uses them. Signed-

Re: [Qemu-devel] [PATCH v11 15/20] target/arm: Use vector infrastructure for aa64 constant shifts

2018-02-05 Thread Peter Maydell
On 26 January 2018 at 04:57, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/translate-a64.c | 423 > + > 1 file changed, 350 insertions(+), 73 deletions(-) Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v2] s390x/cpumodel: model PTFF subfunctions for Multiple-epoch facility

2018-02-05 Thread Christian Borntraeger
Looks sane on a z14. Tested-by: Christian Borntraeger On 02/05/2018 11:29 AM, David Hildenbrand wrote: > --- a/target/s390x/kvm.c > +++ b/target/s390x/kvm.c > @@ -2221,6 +2221,14 @@ void kvm_s390_get_host_cpu_model(S390CPUModel *model, > Error **errp) > return; > } > > +/* PT

Re: [Qemu-devel] [PATCH v5 1/6] machine: Convert the valid cpu types to use cpu_model

2018-02-05 Thread Igor Mammedov
On Fri, 2 Feb 2018 16:23:26 -0200 Eduardo Habkost wrote: > On Thu, Feb 01, 2018 at 04:42:05PM -0800, Alistair Francis wrote: > > As cpu_type is not a user visible string let's convert the > > valid_cpu_types to compare against cpu_model instead. This way we have a > > user friendly string to repo

Re: [Qemu-devel] [PATCH v2] s390x/cpumodel: model PTFF subfunctions for Multiple-epoch facility

2018-02-05 Thread David Hildenbrand
On 05.02.2018 12:22, Christian Borntraeger wrote: > Looks sane on a z14. > Tested-by: Christian Borntraeger > > > On 02/05/2018 11:29 AM, David Hildenbrand wrote: >> --- a/target/s390x/kvm.c >> +++ b/target/s390x/kvm.c >> @@ -2221,6 +2221,14 @@ void kvm_s390_get_host_cpu_model(S390CPUModel *mode

Re: [Qemu-devel] [PATCH v4 10/22] RISC-V Linux User Emulation

2018-02-05 Thread Andreas Schwab
On Feb 05 2018, Michael Clark wrote: > diff --git a/linux-user/riscv/syscall_nr.h b/linux-user/riscv/syscall_nr.h > new file mode 100644 > index 000..bd164ef > --- /dev/null > +++ b/linux-user/riscv/syscall_nr.h > @@ -0,0 +1,275 @@ > +/* > + * Syscall numbers from asm-generic, common for most

[Qemu-devel] [PATCH] linux-user: Implement setsockopt SOL_SOCKET/SO_LINGER

2018-02-05 Thread Andreas Schwab
Signed-off-by: Andreas Schwab --- linux-user/syscall.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index ff89016adc..82848fd97d 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -3130,6 +3130,29 @@ set_time

[Qemu-devel] [PATCH] linux-user: Implement copy_file_range

2018-02-05 Thread Andreas Schwab
No attempt is made to emulate it on the host. Signed-off-by: Andreas Schwab --- linux-user/syscall.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 07fb8de921..ff89016adc 100644 --- a/linux-user/sysca

[Qemu-devel] [PATCH 0/4] Misc VNC fixes / sanity checks

2018-02-05 Thread Daniel P . Berrangé
A few VNC changes suggested by Laszlo when reviewing my recent VNC patches Daniel P. Berrangé (4): ui: avoid risk of 32-bit int overflow in VNC buffer check ui: avoid 'local_err' variable shadowing in VNC SASL auth ui: check VNC audio frequency limit at time of reading from client ui: exte

[Qemu-devel] [PATCH 1/4] ui: avoid risk of 32-bit int overflow in VNC buffer check

2018-02-05 Thread Daniel P . Berrangé
For very large framebuffers, it is theoretically possible for the result of 'vs->throttle_output_offset * VNC_THROTTLE_OUTPUT_LIMIT_SCALE' to exceed the size of a 32-bit int. For this to happen in practice, the video RAM would have to be set to a large enough value, which is not likely today. None

[Qemu-devel] [PATCH 4/4] ui: extend VNC trottling tracing to SASL codepaths

2018-02-05 Thread Daniel P . Berrangé
In previous commit: commit 6aa22a29187e1908f5db738d27c64a9efc8d0bfa Author: Daniel P. Berrange Date: Mon Dec 18 19:12:27 2017 + ui: add trace events related to VNC client throttling trace points related to unthrottling client I/O were missed from the SASL codepaths. Reported-by

[Qemu-devel] [PATCH 3/4] ui: check VNC audio frequency limit at time of reading from client

2018-02-05 Thread Daniel P . Berrangé
The 'vs->as.freq' value is a signed integer, which is read from an unsigned 32-bit int field on the wire. There is thus a risk of overflow on 32-bit platforms. Move the frequency limit checking to be done at time of read before casting to a signed integer. Reported-by: Laszlo Ersek Signed-off-by:

[Qemu-devel] [PATCH 2/4] ui: avoid 'local_err' variable shadowing in VNC SASL auth

2018-02-05 Thread Daniel P . Berrangé
The start_auth_sasl() method declares a 'Error *local_err' variable in an inner if () {...} scope, which shadows a variable of the same name declared at the start of the method. This is confusing for reviewers and may trigger compiler warnings. Reported-by: Laszlo Ersek Signed-off-by: Daniel P. B

Re: [Qemu-devel] [PATCH v2 3/6] qapi: add block-dirty-bitmap-enable/disable

2018-02-05 Thread Vladimir Sementsov-Ogievskiy
03.02.2018 19:09, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 42 ++ blockdev.c | 42 ++ 2 files changed, 84 i

Re: [Qemu-devel] [PATCH v2 5/6] qapi: add block-dirty-bitmap-merge

2018-02-05 Thread Vladimir Sementsov-Ogievskiy
03.02.2018 19:06, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 38 ++ include/block/dirty-bitmap.h | 2 ++ block/dirty-bitmap.c | 18 +++

Re: [Qemu-devel] [PATCH v3 1/1] s390x/cpu: expose the guest crash information

2018-02-05 Thread Cornelia Huck
On Fri, 2 Feb 2018 14:37:46 + Christian Borntraeger wrote: > This patch is the s390 implementation of guest crash information, > similar to commit d187e08dc4 ("i386/cpu: add crash-information QOM > property") and the related commits. We will detect several crash > reasons, with the "disabled

Re: [Qemu-devel] [PATCH v3 0/1] respin of s390 crash information

2018-02-05 Thread Cornelia Huck
On Fri, 2 Feb 2018 14:37:45 + Christian Borntraeger wrote: > This patch - originally from Jing Liu - was still on my disk and > somehow dropped of my attention. Here is a fixed up version. > It probably still needs some review and polish. > One open aspect is migration. Right now QEMU switc

Re: [Qemu-devel] [PATCH v2 1/1] virtio-balloon: include statistics of disk/file caches

2018-02-05 Thread Tomáš Golembiovský
ping On Tue, 5 Dec 2017 13:14:46 +0100 Tomáš Golembiovský wrote: > Signed-off-by: Tomáš Golembiovský > --- > hw/virtio/virtio-balloon.c | 1 + > include/standard-headers/linux/virtio_balloon.h | 3 ++- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw

Re: [Qemu-devel] [PULL 15/18] migration: split common postcopy out of ram postcopy

2018-02-05 Thread Vladimir Sementsov-Ogievskiy
05.02.2018 12:49, Greg Kurz wrote: On Fri, 22 Sep 2017 14:25:02 +0200 Juan Quintela wrote: From: Vladimir Sementsov-Ogievskiy Split common postcopy staff from ram postcopy staff. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela Si

Re: [Qemu-devel] [PATCH v2] s390x/cpumodel: model PTFF subfunctions for Multiple-epoch facility

2018-02-05 Thread Cornelia Huck
On Mon, 5 Feb 2018 12:27:33 +0100 David Hildenbrand wrote: > On 05.02.2018 12:22, Christian Borntraeger wrote: > > Looks sane on a z14. > > Tested-by: Christian Borntraeger > > > > > > On 02/05/2018 11:29 AM, David Hildenbrand wrote: > >> --- a/target/s390x/kvm.c > >> +++ b/target/s390x/kvm.

Re: [Qemu-devel] [PATCH v2] s390x/cpumodel: model PTFF subfunctions for Multiple-epoch facility

2018-02-05 Thread David Hildenbrand
On 05.02.2018 13:22, Cornelia Huck wrote: > On Mon, 5 Feb 2018 12:27:33 +0100 > David Hildenbrand wrote: > >> On 05.02.2018 12:22, Christian Borntraeger wrote: >>> Looks sane on a z14. >>> Tested-by: Christian Borntraeger >>> >>> >>> On 02/05/2018 11:29 AM, David Hildenbrand wrote: --- a/

[Qemu-devel] [Bug 1747056] Re: FreeDOS / MS-Dos / Windows 3.11 cannot perform reboot with 'isapc' machine

2018-02-05 Thread Daniel Berrange
I bisected seabios and found this seabios change to be the cause of the problem commit b837e68d5a6c1a5945513f1995875445a1594c8a (refs/bisect/bad) Author: Kevin O'Connor Date: Mon Nov 9 15:00:19 2015 -0500 resume: Make KVM soft reboot loop detection more flexible Move the check for

Re: [Qemu-devel] [PATCH 1/8] hw/intc/armv7m_nvic: Don't hardcode M profile ID registers in NVIC

2018-02-05 Thread Philippe Mathieu-Daudé
On 02/05/2018 07:57 AM, Peter Maydell wrote: > Instead of hardcoding the values of M profile ID registers in the > NVIC, use the fields in the CPU struct. This will allow us to > give different M profile CPU types different ID register values. > This commit includes the addition of the missing ID_I

Re: [Qemu-devel] [PULL 6/8] iotest 205: new test for qmp nbd-server-remove

2018-02-05 Thread Vladimir Sementsov-Ogievskiy
05.02.2018 12:24, Kevin Wolf wrote: Am 26.01.2018 um 17:04 hat Eric Blake geschrieben: From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20180119135719.24745-6-vsement...@virtuozzo.com> [eblake: adjust to next available test number] Signed-off-by: Eri

[Qemu-devel] [PATCH] iotests: 205: support only raw format

2018-02-05 Thread Vladimir Sementsov-Ogievskiy
The test is about qmp interface to NBD server, so there no reasons to run it for various disk formats. Also it actually do not support luks format, so, disable all format except raw. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/205 | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Qemu-devel] [PATCH 1/4] ui: avoid risk of 32-bit int overflow in VNC buffer check

2018-02-05 Thread Laszlo Ersek
On 02/05/18 12:49, Daniel P. Berrangé wrote: > For very large framebuffers, it is theoretically possible for the result > of 'vs->throttle_output_offset * VNC_THROTTLE_OUTPUT_LIMIT_SCALE' to > exceed the size of a 32-bit int. For this to happen in practice, the > video RAM would have to be set to a

Re: [Qemu-devel] [PATCH 2/4] ui: avoid 'local_err' variable shadowing in VNC SASL auth

2018-02-05 Thread Laszlo Ersek
On 02/05/18 12:49, Daniel P. Berrangé wrote: > The start_auth_sasl() method declares a 'Error *local_err' variable in > an inner if () {...} scope, which shadows a variable of the same name > declared at the start of the method. This is confusing for reviewers and > may trigger compiler warnings. >

Re: [Qemu-devel] [PATCH 3/4] ui: check VNC audio frequency limit at time of reading from client

2018-02-05 Thread Laszlo Ersek
On 02/05/18 12:49, Daniel P. Berrangé wrote: > The 'vs->as.freq' value is a signed integer, which is read from an > unsigned 32-bit int field on the wire. There is thus a risk of overflow > on 32-bit platforms. Move the frequency limit checking to be done at > time of read before casting to a signe

Re: [Qemu-devel] [PATCH 4/4] ui: extend VNC trottling tracing to SASL codepaths

2018-02-05 Thread Laszlo Ersek
On 02/05/18 12:49, Daniel P. Berrangé wrote: > In previous commit: > > commit 6aa22a29187e1908f5db738d27c64a9efc8d0bfa > Author: Daniel P. Berrange > Date: Mon Dec 18 19:12:27 2017 + > > ui: add trace events related to VNC client throttling > > trace points related to unthrottli

Re: [Qemu-devel] [PULL 15/18] migration: split common postcopy out of ram postcopy

2018-02-05 Thread Dr. David Alan Gilbert
* Greg Kurz (gr...@kaod.org) wrote: > On Fri, 22 Sep 2017 14:25:02 +0200 > Juan Quintela wrote: > > > From: Vladimir Sementsov-Ogievskiy > > > > /* Sent prior to starting the destination running in postcopy, discard > > pages > > @@ -1354,6 +1376,10 @@ static int > > loadvm_postcopy_handl

[Qemu-devel] [PATCH] sdl: restore optimized redraw

2018-02-05 Thread Anatoly Trosinenko
The documentation on SDL_RenderPresent function states that "the backbuffer should be considered invalidated after each present", so copy the entire texture on each redraw. On the other hand, SDL_UpdateTexture function is described as "fairly slow function", so restrict it to just the changed pixe

[Qemu-devel] [PATCH v8 00/14] ARM SMMUv3 Emulation Support

2018-02-05 Thread Eric Auger
This series implements the emulation code for ARM SMMUv3. SMMUv3 gets instantiated by adding ",iommu=smmuv3" to the virt machine option. VHOST integration will be handled in a separate series. VFIO integration is not targeted at the moment. Only stage 1 and AArch64 page table walk are supported.

[Qemu-devel] [PATCH v8 01/14] hw/arm/smmu-common: smmu base device and datatypes

2018-02-05 Thread Eric Auger
The patch introduces the smmu base device and class for the ARM smmu. Devices for specific versions will be derived from this base device. We also introduce some important datatypes. Signed-off-by: Eric Auger Signed-off-by: Prem Mallappa --- v7 -> v8: - add bus_num property - add primary-bus p

[Qemu-devel] [PATCH v8 05/14] hw/arm/smmuv3: Wired IRQ and GERROR helpers

2018-02-05 Thread Eric Auger
We introduce some helpers to handle wired IRQs and especially GERROR interrupt. SMMU writes GERROR register on GERROR event and SW acks GERROR interrupts by setting GERRORn. The Wired interrupts are edge sensitive hence the pulse usage. Signed-off-by: Eric Auger --- v7 -> v8: - remove SMMU_PEN

[Qemu-devel] [PATCH v8 02/14] hw/arm/smmu-common: IOMMU memory region and address space setup

2018-02-05 Thread Eric Auger
We enumerate all the PCI devices attached to the SMMU and initialize an associated IOMMU memory region and address space. This happens on SMMU base instance init. Those info are stored in SMMUDevice objects. The devices are grouped according to the PCIBus they belong to. A hash table indexed by th

[Qemu-devel] [PATCH v8 06/14] hw/arm/smmuv3: Queue helpers

2018-02-05 Thread Eric Auger
We introduce helpers to read/write into the command and event circular queues. smmuv3_write_eventq and smmuv3_cmq_consume will become static in subsequent patches. Invalidation commands are not yet dealt with. We do not cache data that need to be invalidated. This will change with vhost integrati

[Qemu-devel] [PATCH v8 07/14] hw/arm/smmuv3: Implement MMIO write operations

2018-02-05 Thread Eric Auger
Now we have relevant helpers for queue and irq management, let's implement MMIO write operations. Signed-off-by: Eric Auger --- v7 -> v8: - precise in the commit message invalidation commands are not yet treated. - use new queue helpers - do not decode unhandled commands at this stage --- hw

Re: [Qemu-devel] [PATCH RFC 10/21] qapi/common: Eliminate QAPISchema.exprs

2018-02-05 Thread Marc-Andre Lureau
On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau > --- > scripts/qapi/common.py | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py > index 6

[Qemu-devel] [PATCH v8 03/14] hw/arm/smmu-common: VMSAv8-64 page table walk

2018-02-05 Thread Eric Auger
This patch implements the page table walk for VMSAv8-64. Signed-off-by: Eric Auger --- v7 -> v8: - rework get_pte - use LOG_LEVEL_ERROR - remove error checking in get_block_pte_address - page table walk simplified (no VFIO replay anymore) - handle PTW error events - use dma_memory_read v6 -> v7

[Qemu-devel] [PATCH v8 08/14] hw/arm/smmuv3: Event queue recording helper

2018-02-05 Thread Eric Auger
Let's introduce a helper function aiming at recording an event in the event queue. Signed-off-by: Eric Auger --- v7 -> v8: - use dma_addr_t instead of hwaddr in smmuv3_record_event() - introduce struct SMMUEventInfo - add event_stringify + helpers for all fields --- hw/arm/smmuv3-internal.h |

Re: [Qemu-devel] [PATCH RFC 11/21] qapi: Lift error reporting from QAPISchema.__init__() to callers

2018-02-05 Thread Marc-Andre Lureau
On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau > --- > scripts/qapi-gen.py| 8 ++-- > scripts/qapi/common.py | 23 +-- > tests/qapi-schema/test-qapi.py | 8 +++- > 3

[Qemu-devel] [PATCH v8 10/14] hw/arm/smmuv3: Abort on vfio or vhost case

2018-02-05 Thread Eric Auger
At the moment, the SMMUv3 does not support notification on TLB invalidation. So let's abort as soon as such notifier gets enabled. Signed-off-by: Eric Auger --- hw/arm/smmuv3.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c index da05d47..07532

[Qemu-devel] [PATCH v8 04/14] hw/arm/smmuv3: Skeleton

2018-02-05 Thread Eric Auger
From: Prem Mallappa This patch implements a skeleton for the smmuv3 device. Datatypes and register definitions are introduced. The MMIO region, the interrupts and the queue are initialized. Only the MMIO read operation is implemented here. Signed-off-by: Prem Mallappa Signed-off-by: Eric Auger

Re: [Qemu-devel] [PATCH v3 1/1] s390x/cpu: expose the guest crash information

2018-02-05 Thread Christian Borntraeger
On 02/05/2018 01:04 PM, Cornelia Huck wrote: > You're doing the crash_reason -> reason mapping here and also below. > Maybe introduce a helper for it? > [] >> diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c >> index 8736001156..c6a23262a8 100644 >> --- a/target/s390x/kvm.c >> +++ b/tar

Re: [Qemu-devel] [PATCH RFC 12/21] qapi: Concentrate QAPISchemaParser.exprs updates in .__init__()

2018-02-05 Thread Marc-Andre Lureau
On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster It's not obvious the motivation behind this change (beside behind more elegant), but Reviewed-by: Marc-André Lureau > --- > scripts/qapi/common.py | 15 +-- > 1 file changed, 9 insertions(

[Qemu-devel] [PATCH v8 12/14] hw/arm/virt: Add SMMUv3 to the virt board

2018-02-05 Thread Eric Auger
From: Prem Mallappa Add code to instantiate an smmuv3 in virt machine. A new iommu integer member is introduced in VirtMachineState to store the type of the iommu in use. Signed-off-by: Prem Mallappa Signed-off-by: Eric Auger --- v7 -> v8: - integer iommu member - add primary-bus property v4

[Qemu-devel] [PATCH v8 09/14] hw/arm/smmuv3: Implement translate callback

2018-02-05 Thread Eric Auger
This patch implements the IOMMU Memory Region translate() callback. Most of the code relates to the translation configuration decoding and check (STE, CD). Signed-off-by: Eric Auger --- v7 -> v8: - use address_space_rw - s/Ste/STE, s/Cd/CD - use dma_memory_read - remove everything related to st

Re: [Qemu-devel] [PATCH RFC 05/21] qapi: Turn generators into modules

2018-02-05 Thread Marc-Andre Lureau
On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster wrote: > The next commit will introduce a common driver program for all > generators. The generators need to be modules for that. qapi2texi.py > already is. Make the other generators follow suit. > > The changes are actually trivial. Obvious in

Re: [Qemu-devel] [PATCH RFC 09/21] qapi: Don't absolutize include file name in error messages

2018-02-05 Thread Marc-Andre Lureau
On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster wrote: > Error messages print absolute filenames of included files even gave a > relative one on the command line: > > PYTHONPATH=scripts python -B tests/qapi-schema/test-qapi.py > tests/qapi-schema/include-cycle.json > In file included f

[Qemu-devel] [PATCH v8 13/14] hw/arm/virt-acpi-build: Add smmuv3 node in IORT table

2018-02-05 Thread Eric Auger
From: Prem Mallappa This patch builds the smmuv3 node in the ACPI IORT table. The RID space of the root complex, which spans 0x0-0x1 maps to streamid space 0x0-0x1 in smmuv3, which in turn maps to deviceid space 0x0-0x1 in the ITS group. The guest must feature the IOMMU probe deferr

Re: [Qemu-devel] [PATCH RFC 14/21] qapi: Generate in source order

2018-02-05 Thread Marc-Andre Lureau
On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster wrote: > The generators' conversion to visitors (merge commit 9e72681d16) > changed the processing order of entities from source order to > alphabetical order. The next commit needs source order, so change it > back. > > Signed-off-by: Markus Armb

[Qemu-devel] [PATCH v8 11/14] target/arm/kvm: Translate the MSI doorbell in kvm_arch_fixup_msi_route

2018-02-05 Thread Eric Auger
In case the MSI is translated by an IOMMU we need to fixup the MSI route with the translated address. Signed-off-by: Eric Auger --- v5 -> v6: - use IOMMUMemoryRegionClass API It is still unclear to me if we need to register an IOMMUNotifier to handle any change in the MSI doorbell which would

Re: [Qemu-devel] [PATCH v3 1/1] s390x/cpu: expose the guest crash information

2018-02-05 Thread Cornelia Huck
On Mon, 5 Feb 2018 14:44:36 +0100 Christian Borntraeger wrote: > On 02/05/2018 01:04 PM, Cornelia Huck wrote: > > > You're doing the crash_reason -> reason mapping here and also below. > > Maybe introduce a helper for it? > > > [] > >> diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c

[Qemu-devel] [PATCH v8 14/14] hw/arm/virt: Handle iommu in 2.12 machine type

2018-02-05 Thread Eric Auger
The new machine type exposes a new "iommu" virt machine option. The SMMUv3 IOMMU is instantiated using -machine virt,iommu=smmuv3. Signed-off-by: Eric Auger --- v7 -> v8: - Revert to machine option, now dubbed "iommu", preparing for virtio instantiation. v5 -> v6: machine 2_11 Another altern

Re: [Qemu-devel] [PATCH RFC 20/21] Include less of qapi-types.h

2018-02-05 Thread Marc-Andre Lureau
On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster wrote: > In my "build everything" tree, a change to the types in > qapi-schema.json triggers a recompile of about 4500 out of 4800 > objects. > > The previous commit split up the generated qapi-types.h. Replace > includes of qapi-types.h (i.e. all

Re: [Qemu-devel] [PATCH RFC 07/21] qapi: Move parse_command_line() next to its only use

2018-02-05 Thread Marc-Andre Lureau
On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau > --- > scripts/qapi-gen.py| 52 +++- > scripts/qapi/common.py | 54 > --

Re: [Qemu-devel] [PATCH RFC 01/21] qapi: Streamline boilerplate comment generation

2018-02-05 Thread Marc-Andre Lureau
On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster wrote: > Every generator has separate boilerplate for .h and .c, and their > differences are boring. All of them repeat the license note. > > Reduce the repetition as follows. Move common text like the license > note to common open_output(), next

Re: [Qemu-devel] [PATCH v5 1/6] machine: Convert the valid cpu types to use cpu_model

2018-02-05 Thread Eduardo Habkost
On Mon, Feb 05, 2018 at 12:22:35PM +0100, Igor Mammedov wrote: > On Fri, 2 Feb 2018 16:23:26 -0200 > Eduardo Habkost wrote: > > > On Thu, Feb 01, 2018 at 04:42:05PM -0800, Alistair Francis wrote: > > > As cpu_type is not a user visible string let's convert the > > > valid_cpu_types to compare aga

Re: [Qemu-devel] [PATCH RFC 16/21] qapi/types qapi/visit: Make visitors use QAPIGen more

2018-02-05 Thread Marc-Andre Lureau
On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster wrote: > The conversion is rather shallow so far: most of the output > accumulation is not converted. Take the next step: convert output > accumulation in QAPISchemaGenTypeVisitor and > QAPISchemaGenVisitVisitor. Helper functions outside these cl

Re: [Qemu-devel] [PATCH RFC 06/21] qapi-gen: New common driver for code and doc generators

2018-02-05 Thread Marc-Andre Lureau
On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster wrote: > Whenever qapi-schema.json changes, we run six programs eleven times to > update eleven files. This is silly. Replace the six programs by a > single program that spits out all eleven files. > Now we will need documentation update. Also

Re: [Qemu-devel] [PATCH RFC 02/21] qapi: Generate up-to-date copyright notice

2018-02-05 Thread Marc-Andre Lureau
Hi On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster wrote: > Each generator carries a copyright notice for the generator itself, > and another one for the files it generates. Only the former have been > updated along the way, the latter have not, and are all out of date. > > Fix by copying the

Re: [Qemu-devel] [PATCH v4 06/22] RISC-V FPU Support

2018-02-05 Thread Richard Henderson
On 02/04/2018 10:22 PM, Michael Clark wrote: > +uint64_t helper_fmsub_s(CPURISCVState *env, uint64_t frs1, uint64_t frs2, > +uint64_t frs3) > +{ > +return float32_muladd(frs1, frs2, frs3 ^ (uint32_t)INT32_MIN, 0, > + &env->fp_status); Missing th

Re: [Qemu-devel] [PATCH 0/1] Fix unaligned reads in the tcg/tci.c

2018-02-05 Thread Anatoly Trosinenko
Ping. Patchwork link: http://patchwork.ozlabs.org/patch/866732/ Patchew link: http://patchew.org/QEMU/20180127134908.24095-1-anatoly.trosine...@gmail.com/ (Initially forgot to add Richard Henderson to CC.) 2018-01-27 16:49 GMT+03:00 Anatoly Trosinenko : > The code in tcg/tci.c reads some data f

Re: [Qemu-devel] [PATCH RFC 13/21] qapi: Record 'include' directives in parse tree

2018-02-05 Thread Marc-Andre Lureau
On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster wrote: > The parse tree is a list of expressions. Except include expressions > currently get replaced by the included file's parse tree. > > Instead of throwing away the include expression, keep it with the file > name expanded so you don't have t

  1   2   3   4   5   >