Eric Blake writes:
> On 01/30/2018 04:21 AM, Markus Armbruster wrote:
>> The macro expansions of qdict_put_TYPE() and qlist_append_TYPE() need
>> qbool.h, qnull.h, qnum.h and qstring.h to compile. We include qnull.h
>> and qnum.h in the headers, but not qbool.h and qstring.h. Works,
>> because
Eric Blake writes:
> On 01/30/2018 04:22 AM, Markus Armbruster wrote:
>> qemu-common.h includes qemu/option.h, but most places that include the
>> former don't actually need the latter. Drop the include, and add it
>> to the places that actually need it.
>>
>> While there, drop superfluous incl
On Tue, Jan 30, 2018 at 5:25 PM, Peter Maydell wrote:
> It seems like it's about time we settled on the dates for the
> 2.12 release. I've sketched in a suggestion at:
> https://wiki.qemu.org/Planning/2.12
>
> which puts softfreeze on the 13th March, hardfreeze a
> week later on the 20th, and fi
The Partition Table Control Register (PTCR) is a hypervisor privileged
SPR. It contains the host real address of the Partition Table and its
size.
Signed-off-by: Cédric Le Goater
---
target/ppc/cpu.h| 2 ++
target/ppc/helper.h | 1 +
target/ppc/misc_helper.c| 12 +++
Hello,
This adds support for the Hash Page Table MMU mode on POWER9 PowerNV
machines. The Radix Tree mode support for the host is still to be done
but we are getting close.
The full tree can be found here :
https://github.com/legoater/qemu powernv-2.12
Thanks,
C.
Cédric Le Goater (3):
t
The HPTE bits definitions are slightly modified in ISA v3.0. Let's add
some helpers to hide the differences in the hash MMU code.
On a POWER9 processor, the Partition Table is composed of a pair of
doublewords per partition. The first doubleword indicates whether the
partition uses HPT or Radix Tr
On a POWER9 processor, the first doubleword of the PTCR indicates
whether the partition uses HPT or Radix Trees translation. Use that
bit to check for radix mode on powernv QEMU machines.
Signed-off-by: Cédric Le Goater
---
target/ppc/mmu-book3s-v3.c | 17 -
target/ppc/mmu-book3
Philippe Mathieu-Daudé writes:
> On 01/30/2018 07:21 AM, Markus Armbruster wrote:
>> We have awfully many "touch it, recompile the world" headers. Right
>> now, I count about fifty that are prerequisites of more than half the
>> objects in my "build everything" tree.
>>
>> Some of them are that
I wanted to update the list on my progress and a follow-up of the "ppc and
icount" thread.
The issue I was seeing is the case where an io memory write triggers a timer
value to be set. In single-thread TCG, timers are run in
handle_icount_deadline() and once that's done, TBs are executed. Since
在 2018/1/31 下午3:42, Thomas Huth 写道:
On 30.01.2018 10:47, Yi Min Zhao wrote:
Current s390x PCI IOMMU code is lack of flags' checking, including:
1) protection bit
2) table length
3) table offset
4) intermediate tables' invalid bit
5) format control bit
This patch introduces a new struct named
> > What about the other hotkeys?
> >
> > There is fullscreen. Ctrl-Alt-F for SDL and GTK. Cmd-F for cocoa, but
> > it works only if the grab is not active.
>
> If has to be that way because the meta (command) key is sent to the
> guest when the mouse grab is in effect. I actually suggest the S
On 23/01/18 23:49, David Gibson wrote:
> On Tue, Jan 23, 2018 at 01:03:39PM +0100, Andrea Bolognani wrote:
>> On Tue, 2018-01-23 at 22:20 +1100, David Gibson wrote:
David, I know you're busy with linux.conf.au, but it would be
really helpful if you could carve out five minutes to look ove
Am 31.01.2018 um 00:15 hat Jack Schwartz geschrieben:
> Hi Anatol and Kevin.
>
> Even though I am new to Qemu, I have a patch to deliver for
> multiboot.c (as you know) and so I feel familiar enough to do a review
> of this patch. One comment is probably more for maintainers.
The Multiboot code
On Tue, Jan 30, 2018 at 10:30:46AM -0500, Programmingkid wrote:
>
> > On Jan 30, 2018, at 4:41 AM, Gerd Hoffmann wrote:
> >
> >> @@ -148,15 +142,16 @@ static int irq_of_magic (int magic)
> >> #if 0
> >> static void log_dsp (SB16State *dsp)
> >> {
> >> -ldebug ("%s:%s:%d:%s:dmasize=%d:freq=%d
Hi, Michael and the list,
I observed this on windows 8 enterprise guests, when doing memory ballooning:
23892@1517298572.328354:virtio_balloon_to_target balloon target: 0x8000
num_pages: 524288
23892@1517298638.542819:virtio_balloon_get_config num_pages: 524288 actual: 0
23892@1517298638.542
On 31 January 2018 at 08:19, Christian Ehrhardt
wrote:
> On Tue, Jan 30, 2018 at 5:25 PM, Peter Maydell
> wrote:
>> It seems like it's about time we settled on the dates for the
>> 2.12 release. I've sketched in a suggestion at:
>> https://wiki.qemu.org/Planning/2.12
>>
>> which puts softfreez
On Tue, Jan 30, 2018 at 03:13:41AM +0800, Zihan Yang wrote:
> Currently, socket_listen does not allow caller to set custom
> socket options, which is inconvenient when the caller wants
> a non-blocking socket or wants to set TCP_NODELAY. Therefore,
> two new structs are added and an extra parameter
On Tue, Jan 30, 2018 at 03:13:42AM +0800, Zihan Yang wrote:
> Currently, socket_connect doesn't allow custom socket options,
> which is inconvenient when the caller wants a different kind of
> socket from that the socket_connect provides. This patch allows
> custom config in socket_connect by provi
On Mon, Jan 29, 2018 at 10:32:12AM +, Marc Zyngier wrote:
> On 29/01/18 10:04, Peter Maydell wrote:
> > On 29 January 2018 at 09:53, Dr. David Alan Gilbert
> > wrote:
> >> * Peter Maydell (peter.mayd...@linaro.org) wrote:
> >>> On 26 January 2018 at 19:46, Dr. David Alan Gilbert
> >>> wrote
* Brijesh Singh (brijesh.si...@amd.com) wrote:
>
>
> On 1/30/18 11:49 AM, Dr. David Alan Gilbert wrote:
> > * Brijesh Singh (brijesh.si...@amd.com) wrote:
> >> AMD EPYC processors support memory encryption feature. The feature
> >> is reported through CPUID 8000_001F[EAX].
> >>
> >> Fn8000_001F [
Hi
On Wed, Jan 31, 2018 at 6:33 AM, Fam Zheng wrote:
> git-publish [1] is a convenient tool to send patches and has been
> popular among QEMU developers. Recently it has been made available in
> Fedora official repo thanks to Stefan's work.
>
> One nice feature of the tool is a per-project confi
On 30 January 2018 at 17:39, Greg Kurz wrote:
> The following changes since commit 30d9fefe1aca1e92c785214aa9201fd7c2287d56:
>
> Merge remote-tracking branch
> 'remotes/kraxel/tags/input-20180129-v2-pull-request' into staging (2018-01-29
> 15:52:27 +)
>
> are available in the git repositor
The align_offset() function is equivalent to the ROUND_UP() macro so
there's no need to use the former. The ROUND_UP() name is also a bit
more explicit.
This patch uses ROUND_UP() instead of the slower QEMU_ALIGN_UP()
because align_offset() already requires that the second parameter is a
power of
On some architectures, qemu doesn't support vmcoreinfo device,
and dump-guest-memory fails:
(gdb) dump-guest-memory /tmp/vmcore ppc64-le
guest RAM blocks:
target_start target_end host_addrmessage count
--- -
On 01/31/18 11:41, Marc-André Lureau wrote:
> On some architectures, qemu doesn't support vmcoreinfo device,
> and dump-guest-memory fails:
>
> (gdb) dump-guest-memory /tmp/vmcore ppc64-le
> guest RAM blocks:
> target_start target_end host_addrmessage count
> --
On Tue 30 Jan 2018 05:17:47 PM CET, Eric Blake wrote:
-virtual_size = align_offset(qemu_opt_get_size_del(opts,
BLOCK_OPT_SIZE, 0),
+virtual_size = ROUND_UP(qemu_opt_get_size_del(opts, BLOCK_OPT_SIZE,
0),
cluster_size);
>>
>> I ju
On Tue, 30 Jan 2018 10:47:13 +0100
Yi Min Zhao wrote:
> Current s390x PCI IOMMU code is lack of flags' checking, including:
> 1) protection bit
> 2) table length
> 3) table offset
> 4) intermediate tables' invalid bit
> 5) format control bit
>
> This patch introduces a new struct named S390IOTLB
On Tue, 30 Jan 2018 10:47:14 +0100
Yi Min Zhao wrote:
> The VFIO common code doesn't provide the possibility to modify a
> previous mapping entry in another way than unmapping and mapping again
> with new properties.
I'm wondering why other architectures don't need that. Is this
refreshing an un
hello,I am confused when I read vhost-user source code in qemu.I know
vhost-user app shared memory with qemu by mmap,but why it can use fd which
is belong to qemu?
relative code:
qemu code in function vhost_user_set_mem_table
fd = memory_region_get_fd(mr);
if (fd > 0) {
msg.pay
On Tue, 30 Jan 2018 10:47:15 +0100
Yi Min Zhao wrote:
> When registering ioat, pba should be comprised of leftmost 52 bits and
> rightmost 12 binary zeros, and pal should be comprised of leftmost 52
> bits and right most 12 binary ones. Let's fixup this.
>
> Reviewed-by: Pierre Morel
> Signed-o
Have the same proble: qemu-img: Check failed: Cannot allocate memory
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1332297
Title:
qemu-img: crash on check of an image with large value in the 'size'
On Mon, Jan 29, 2018 at 01:17:51PM +0100, Juan Quintela wrote:
> We can set the port parameter as zero. This patch lets us know what
> port the system was choosen for us. Now we can migrate to this place.
>
> Signed-off-by: Juan Quintela
>
> --
>
> This was migrate_set_uri(), but as we only n
Map drm fourcc codes to pixman formats.
Signed-off-by: Gerd Hoffmann
---
include/ui/qemu-pixman.h | 5 +
ui/qemu-pixman.c | 22 ++
2 files changed, 27 insertions(+)
diff --git a/include/ui/qemu-pixman.h b/include/ui/qemu-pixman.h
index 4a67e01232..b7c82d17fc 100
So we can use the drm fourcc codes without a dependency on libdrm-devel.
Signed-off-by: Gerd Hoffmann
---
include/standard-headers/drm/drm_fourcc.h | 382 ++
scripts/update-linux-headers.sh | 4 +
2 files changed, 386 insertions(+)
create mode 100644 incl
This series adds support for a vgpu display to the qemu vfio code.
For now only regions are supported, dmabufs will follow later.
The vfio API update is done, queued in drm-next, should land in the
upstream kernel during the 4.16 merge window. So the 4.16-rc1 kernel
header sync should bring the h
On 01/30/2018 04:41 PM, Eric Blake wrote:
> On 01/30/2018 07:38 AM, Christian Borntraeger wrote:
>> From: Alice Frosi
>>
>> In alpine docker image the qemu-system-s390x build is broken and
>> it throws this error:
>> qemu-system-s390x: Initialization of device s390-ipl failed: could not
>> load
Infrastructure for display support. Must be enabled
using 'display' property.
Signed-off-by: Gerd Hoffmann
---
hw/vfio/pci.h | 3 +++
hw/vfio/display.c | 51 +++
hw/vfio/pci.c | 9 +
hw/vfio/Makefile.objs | 2 +-
4 f
Signed-off-by: Gerd Hoffmann
---
linux-headers/linux/vfio.h | 64 ++
1 file changed, 64 insertions(+)
diff --git a/linux-headers/linux/vfio.h b/linux-headers/linux/vfio.h
index 4312e961ff..c433d6542b 100644
--- a/linux-headers/linux/vfio.h
+++ b/linux-
Wire up region-based display.
Signed-off-by: Gerd Hoffmann
---
hw/vfio/pci.h | 1 +
include/hw/vfio/vfio-common.h | 8
hw/vfio/display.c | 102 +-
3 files changed, 109 insertions(+), 2 deletions(-)
diff --git a/hw/vfio
On 30/01/2018 19:49, Andrey Smirnov wrote:
> On Tue, Jan 30, 2018 at 5:18 AM, Marcel Apfelbaum
> wrote:
>> Hi Andrei,
>>
>> Sorry for letting you wait,
>> I have some comments/questions below.
>>
>>
>> On 16/01/2018 3:37, Andrey Smirnov wrote:
>>>
>>> Add code needed to get a functional PCI subsyt
Peter Xu wrote:
> On Mon, Jan 29, 2018 at 01:17:51PM +0100, Juan Quintela wrote:
>> We can set the port parameter as zero. This patch lets us know what
>> port the system was choosen for us. Now we can migrate to this place.
>>
>> Signed-off-by: Juan Quintela
>>
>> --
>>
>> This was migrate_
On 31 January 2018 at 12:14, Christian Borntraeger
wrote:
> On 01/30/2018 04:41 PM, Eric Blake wrote:
>> On 01/30/2018 07:38 AM, Christian Borntraeger wrote:
>>> +++ b/configure
>>> @@ -1906,9 +1906,9 @@ int main(int argc, char *argv[]) {
>>> EOF
>>>
>>> if compile_object ; then
>>> -if grep
On one of our client's node, due to trying to read from closed ioc,
a segmentation fault occured. Corresponding backtrace:
Having analyzed the coredump, I understood that the reason is that
ioc_tag is reset on vnc_disconnect_start and ioc is cleaned
in vnc_disconnect_finish. Between these two even
On one of our client's node, due to trying to read from closed ioc,
a segmentation fault occured. Corresponding backtrace:
0 object_get_class (obj=obj@entry=0x0)
1 qio_channel_readv_full (ioc=0x0, iov=0x7ffe55277180 ...
2 qio_channel_read (ioc= ...
3 vnc_client_read_buf (vs=vs@entry=0x55625f3c
Hi
On Wed, Jan 31, 2018 at 2:06 PM, Klim Kireev wrote:
> On one of our client's node, due to trying to read from closed ioc,
> a segmentation fault occured. Corresponding backtrace:
>
Oops, you probably forgot an extra space before the # interpreted as comment.
Do you have a reproducer?
> Havi
On 01/31/2018 04:16 PM, Marc-André Lureau wrote:
Hi
On Wed, Jan 31, 2018 at 2:06 PM, Klim Kireev wrote:
On one of our client's node, due to trying to read from closed ioc,
a segmentation fault occured. Corresponding backtrace:
Oops, you probably forgot an extra space before the # interpreted
On Wed, Jan 31, 2018 at 04:15:37PM +0300, Klim Kireev wrote:
> On one of our client's node, due to trying to read from closed ioc,
> a segmentation fault occured. Corresponding backtrace:
>
> 0 object_get_class (obj=obj@entry=0x0)
> 1 qio_channel_readv_full (ioc=0x0, iov=0x7ffe55277180 ...
> 2
Alex Williamson writes:
> Add an option which allows the user to specify a PCI BAR number,
> including an 'off' and 'auto' selection.
>
> Cc: Markus Armbruster
> Cc: Eric Blake
> Signed-off-by: Alex Williamson
Reviewed-by: Markus Armbruster
On 01/31/2018 01:51 PM, Peter Maydell wrote:
> On 31 January 2018 at 12:14, Christian Borntraeger
> wrote:
>> On 01/30/2018 04:41 PM, Eric Blake wrote:
>>> On 01/30/2018 07:38 AM, Christian Borntraeger wrote:
+++ b/configure
@@ -1906,9 +1906,9 @@ int main(int argc, char *argv[]) {
On Tue, Jan 30, 2018 at 03:46:45PM -0600, Brijesh Singh wrote:
>
>
> On 1/30/18 11:49 AM, Dr. David Alan Gilbert wrote:
> > * Brijesh Singh (brijesh.si...@amd.com) wrote:
> >> AMD EPYC processors support memory encryption feature. The feature
> >> is reported through CPUID 8000_001F[EAX].
> >>
>
Philippe Mathieu-Daudé writes:
> since v1:
> - fix format string on 32-bit host (patchew)
> - do not add smbus_eeprom_reset() (Eduardo)
> - directly use DeviceClass::realize (Eduardo)
> - squashed 2 patches (Eduardo)
>
> Hi,
>
> This series finalize the qdev QOMification.
Awesome!
It's
Philippe Mathieu-Daudé writes:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/usb/ccid.h | 9 +--
> hw/usb/ccid-card-emulated.c | 45 ++
> hw/usb/ccid-card-passthru.c | 10
> hw/usb/dev-smartcard-reader.c | 57
>
On Wed, Jan 31, 2018 at 11:28:00AM +0800, Fam Zheng wrote:
> To make our efforts on QEMU testing easier to consume by contributors,
> let's add a document. For example, Patchew reports build errors on
> patches that should be relatively easy to reproduce with a few steps, and
> it is much nicer if
On Wed, 31 Jan 2018 14:40:00 +0100
Christian Borntraeger wrote:
> On 01/31/2018 01:51 PM, Peter Maydell wrote:
> > On 31 January 2018 at 12:14, Christian Borntraeger
> > wrote:
> >> On 01/30/2018 04:41 PM, Eric Blake wrote:
> >>> On 01/30/2018 07:38 AM, Christian Borntraeger wrote:
>
On Wed, Jan 31, 2018 at 11:28:00AM +0800, Fam Zheng wrote:
> To make our efforts on QEMU testing easier to consume by contributors,
> let's add a document. For example, Patchew reports build errors on
> patches that should be relatively easy to reproduce with a few steps, and
> it is much nicer if
On Tue, Jan 30, 2018 at 05:54:56PM +0100, Kevin Wolf wrote:
> Am 30.01.2018 um 16:38 hat Stefan Hajnoczi geschrieben:
> > Commit dce8921b2baaf95974af8176406881872067adfa ("iothread: Stop threads
> > before main() quits") introduced iothread_stop_all() to avoid the
> > following virtio-scsi assertio
Thomas Huth writes:
> On 30.01.2018 11:21, Markus Armbruster wrote:
>> We have awfully many "touch it, recompile the world" headers. Right
>> now, I count about fifty that are prerequisites of more than half the
>> objects in my "build everything" tree.
>
> Could you maybe share the list of thes
On Wed, Jan 31, 2018 at 11:01:08AM +0800, Wang Xin wrote:
> Signed-off-by: Wang Xin
Acked-by: Michael S. Tsirkin
Eduardo, will you take this?
> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> index bb49165..635c8b2 100644
> --- a/include/hw/i386/pc.h
> +++ b/include/hw/i386/pc.h
>
On Wed, Jan 31, 2018 at 05:28:35PM +0800, Peter Xu wrote:
> Hi, Michael and the list,
>
> I observed this on windows 8 enterprise guests, when doing memory ballooning:
>
> 23892@1517298572.328354:virtio_balloon_to_target balloon target: 0x8000
> num_pages: 524288
> 23892@1517298638.542819:vi
Hi,
On 01/23/2018 12:58 AM, Philippe Mathieu-Daudé wrote:
> Since v1:
> - rebased on /master (Peter sdcard reset() patches)
> - fix milkymist-mmc from previous seris using instance_init (Michael Walle)
>
> This series convert 3 devices using the legacy SDCard API to the SDBus API:
> - milkymist-m
ping?
Patches missing review: 2 (PCI qtesting),11,13,15
On 01/22/2018 11:08 PM, Philippe Mathieu-Daudé wrote:
> Since v8:
> - we keep the 'capareg' property, this simplify a lot the series
> - the Zynq 7000 uses the datasheet CAPAREG
> - reset R-b/A-b
>
> Since v7:
> - use error_propagate()
>
>
On 01/31/2018 04:21 AM, Alberto Garcia wrote:
> The align_offset() function is equivalent to the ROUND_UP() macro so
> there's no need to use the former. The ROUND_UP() name is also a bit
> more explicit.
>
> This patch uses ROUND_UP() instead of the slower QEMU_ALIGN_UP()
> because align_offset()
On Tue, Jan 30, 2018 at 05:38:20PM +0100, Kevin Wolf wrote:
> Am 30.01.2018 um 15:23 hat Eric Blake geschrieben:
> > On 01/30/2018 12:34 AM, Fam Zheng wrote:
> > > Signed-off-by: Fam Zheng
> > > Signed-off-by: Kevin Wolf
> > > ---
> > > qemu-img.texi | 7 +++
> > > 1 file changed, 7 insertio
ository at:
git://github.com/rth7680/qemu.git tags/pull-hppa-20180131
for you to fetch changes up to eed142195c95a6c50545fa7a28e725d780ab9636:
target/hppa: Implement PROBE for system mode (2018-01-31 05:30:50 -0800)
Implement hp
On 01/30/2018 09:28 PM, Fam Zheng wrote:
> To make our efforts on QEMU testing easier to consume by contributors,
> let's add a document. For example, Patchew reports build errors on
> patches that should be relatively easy to reproduce with a few steps, and
> it is much nicer if there is such a do
Am 31.01.2018 um 15:12 hat Stefan Hajnoczi geschrieben:
> On Tue, Jan 30, 2018 at 05:38:20PM +0100, Kevin Wolf wrote:
> > Am 30.01.2018 um 15:23 hat Eric Blake geschrieben:
> > > On 01/30/2018 12:34 AM, Fam Zheng wrote:
> > > > Signed-off-by: Fam Zheng
> > > > Signed-off-by: Kevin Wolf
> > > > --
Am 31.01.2018 um 14:56 hat Stefan Hajnoczi geschrieben:
> On Tue, Jan 30, 2018 at 05:54:56PM +0100, Kevin Wolf wrote:
> > Am 30.01.2018 um 16:38 hat Stefan Hajnoczi geschrieben:
> > > Commit dce8921b2baaf95974af8176406881872067adfa ("iothread: Stop threads
> > > before main() quits") introduced iot
On Wed, Jan 31, 2018 at 04:01:35PM +0200, Michael S. Tsirkin wrote:
> On Wed, Jan 31, 2018 at 11:01:08AM +0800, Wang Xin wrote:
> > Signed-off-by: Wang Xin
>
>
> Acked-by: Michael S. Tsirkin
>
> Eduardo, will you take this?
Queued, thanks.
--
Eduardo
System headers should be included with <...>, our own headers with
"...". Offenders tracked down with an ugly, brittle and probably
buggy Perl script. Previous iteration was commit a9c94277f0.
Put the cleaned up system header includes first, except for the ones
the next commit will delete.
Whil
This cleanup makes the number of objects depending on qapi/qmp/qdict.h
drop from 4550 (out of 4743) to 368 in my "build everything" tree.
For qapi/qmp/qobject.h, the number drops from 4552 to 390.
While there, separate #include from file comment with a blank line.
Reviewed-by: Eric Blake
Reviewe
Reviewed-by: Eric Blake
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Markus Armbruster
---
include/block/block.h | 1 -
include/qapi/qmp/dispatch.h | 1 -
include/qapi/qmp/qjson.h | 1 -
include/qapi/qobject-input-visitor.h | 1 -
include/qapi/qobje
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Markus Armbruster
---
backends/cryptodev.c | 1 -
backends/hostmem.c | 1 -
hmp.h| 1 -
include/block/block.h| 1 -
include/block/block_int.h| 1 -
inc
Reviewed-by: Eric Blake
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Markus Armbruster
---
block.c| 1 -
blockjob.c | 1 -
hw/acpi/acpi-stub.c| 1 -
hw/ppc/spapr.c | 1 -
hw/s390x/s390-stattrib.c | 1 -
hw/smbios/smbios-stub.c|
Reviewed-by: Eric Blake
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Markus Armbruster
---
target/ppc/translate.c | 1 -
target/ppc/translate_init.c | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/ppc/translate.c b/target/ppc/translate.c
index eeaad9e91f..4
Reviewed-by: Eric Blake
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Markus Armbruster
---
monitor.c | 1 -
qga/main.c| 1 -
tests/test-qmp-commands.c | 1 -
3 files changed, 3 deletions(-)
diff --git a/monitor.c b/monitor.c
index 02d9dd8708..6f70c8db9a 10
Reviewed-by: Eric Blake
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Markus Armbruster
---
block.c| 1 -
block/blkdebug.c | 1 -
block/curl.c | 1 -
block/qcow2.c | 1 -
block/quorum.c | 1 -
block/vv
We have awfully many "touch it, recompile the world" headers. Right
now, I count about fifty that are prerequisites of more than half the
objects in my "build everything" tree.
Some of them are that way by necessity. Many of them are not. This
series takes care of six I happen to touch, because
Clean up includes so that osdep.h is included first and headers
which it implies are not included manually.
This commit was created with scripts/clean-includes, with the change
to target/s390x/gen-features.c manually reverted, and blank lines
around deletions collapsed.
Signed-off-by: Markus Armb
Reviewed-by: Eric Blake
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Markus Armbruster
---
balloon.c | 1 -
block/nbd.c | 1 -
block/quorum.c | 1 -
blockjob.c | 1 -
hw/core/qdev.c
This renders many inclusions of qapi/qmp/q*.h superfluous. They'll be
dropped in the next few commits.
Reviewed-by: Eric Blake
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Markus Armbruster
---
include/qapi/qmp/qbool.h | 4 ++--
include/qapi/qmp/qdict.h | 4 ++--
include/qapi/qmp/ql
Reviewed-by: Eric Blake
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Markus Armbruster
---
tests/check-qlit.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/check-qlit.c b/tests/check-qlit.c
index f012885534..5d0f65b9c7 100644
--- a/tests/check-qlit.c
+++ b/tests/check-qlit.c
@@
Reviewed-by: Eric Blake
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Markus Armbruster
---
block.c | 1 +
include/qapi/qmp/qjson.h| 2 --
monitor.c | 1 +
qapi/qobject-input-visitor.c| 1 +
qemu-img.c
This cleanup makes the number of objects depending on qapi/error.h
drop from 1910 (out of 4743) to 1612 in my "build everything" tree.
While there, separate #include from file comment with a blank line,
and drop a useless comment on why qemu/osdep.h is included first.
Signed-off-by: Markus Armbru
Reviewed-by: Eric Blake
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Markus Armbruster
---
backends/tpm.c | 1 -
block/qcow.c | 1 -
block/qed.c| 1 -
blockdev-nbd.c | 1 -
hw/s390x/s390-virtio-ccw.c | 1 -
net/colo-compare.c |
qapi/qmp/types.h is a convenience header to include a number of
qapi/qmp/ headers. Since we rarely need all of the headers
qapi/qmp/types.h includes, we bypass it most of the time. Most of the
places that use it don't need all the headers, either.
Include the necessary headers directly, and drop
The macro expansions of qdict_put_TYPE() and qlist_append_TYPE() need
qbool.h, qnull.h, qnum.h and qstring.h to compile. We include qnull.h
and qnum.h in the headers, but not qbool.h and qstring.h. Works,
because we include those wherever the macros get used.
Open-coding these helpers is of dubi
Marc-André Lureau writes:
> tpm_crb is a device for TPM 2.0 Command Response Buffer (CRB)
> Interface as defined in TCG PC Client Platform TPM Profile (PTP)
> Specification Family “2.0” Level 00 Revision 01.03 v22.
>
> The PTP allows device implementation to switch between TIS and CRB
> model at
This cleanup makes the number of objects depending on qapi/qmp/qlist.h
drop from 4551 (out of 4743) to 16 in my "build everything" tree.
While there, separate #include from file comment with a blank line.
Reviewed-by: Eric Blake
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Markus Armbrust
On 01/31/2018 08:48 AM, Markus Armbruster wrote:
> Clean up includes so that osdep.h is included first and headers
> which it implies are not included manually.
>
> This commit was created with scripts/clean-includes, with the change
> to target/s390x/gen-features.c manually reverted, and blank li
On 01/31/2018 08:48 AM, Markus Armbruster wrote:
> Reviewed-by: Philippe Mathieu-Daudé
> Signed-off-by: Markus Armbruster
> ---
> 35 files changed, 36 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qem
qemu-common.h includes qemu/option.h, but most places that include the
former don't actually need the latter. Drop the include, and add it
to the places that actually need it.
While there, drop superfluous includes of both headers, and
separate #include from file comment with a blank line.
This
On 01/31/2018 08:48 AM, Markus Armbruster wrote:
> System headers should be included with <...>, our own headers with
> "...". Offenders tracked down with an ugly, brittle and probably
> buggy Perl script. Previous iteration was commit a9c94277f0.
>
> Put the cleaned up system header includes fi
On Thu 18 Jan 2018 06:49:02 PM CET, Anton Nefedov wrote:
> -static bool coroutine_fn wait_serialising_requests(BdrvTrackedRequest *self)
> +static bool coroutine_fn wait_serialising_requests(BdrvTrackedRequest *self,
> + bool nowait)
It's a bit co
On 01/31/2018 08:48 AM, Markus Armbruster wrote:
> This cleanup makes the number of objects depending on qapi/error.h
> drop from 1910 (out of 4743) to 1612 in my "build everything" tree.
>
> While there, separate #include from file comment with a blank line,
> and drop a useless comment on why qe
On 31 January 2018 at 09:53, Christoffer Dall
wrote:
> On Mon, Jan 29, 2018 at 10:32:12AM +, Marc Zyngier wrote:
>> On 29/01/18 10:04, Peter Maydell wrote:
>> > On 29 January 2018 at 09:53, Dr. David Alan Gilbert
>> > wrote:
>> >> * Peter Maydell (peter.mayd...@linaro.org) wrote:
>> >>> On 2
Hi, Daniel
>You've added all this extra functionality to pass arbitrary
>options, but then not used it in any of the later patches.
>We've been trying to remove complexity from this code, so
>I'm not in favour of adding new functionality that is not
>even used.
You are right, unused functionality
* Ard Biesheuvel (ard.biesheu...@linaro.org) wrote:
> On 31 January 2018 at 09:53, Christoffer Dall
> wrote:
> > On Mon, Jan 29, 2018 at 10:32:12AM +, Marc Zyngier wrote:
> >> On 29/01/18 10:04, Peter Maydell wrote:
> >> > On 29 January 2018 at 09:53, Dr. David Alan Gilbert
> >> > wrote:
> >
On Wed, Jan 31, 2018 at 11:20:16PM +0800, Zihan Yang wrote:
> Hi, Daniel
>
> >You've added all this extra functionality to pass arbitrary
> >options, but then not used it in any of the later patches.
> >We've been trying to remove complexity from this code, so
> >I'm not in favour of adding new fu
On 31.01.2018 15:48, Markus Armbruster wrote:
> System headers should be included with <...>, our own headers with
> "...". Offenders tracked down with an ugly, brittle and probably
> buggy Perl script. Previous iteration was commit a9c94277f0.
>
> Put the cleaned up system header includes first,
Hi,
This series failed docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 20180131144846.31697-1-arm...@redhat.com
Subject: [Qemu-devel] [PATCH v2 00/19] Clean up i
1 - 100 of 267 matches
Mail list logo
