Re: [Qemu-devel] [PATCH v1] ps2: check PS2Queue pointers in post_load routine

2018-01-30 Thread P J P
+-- On Thu, 25 Jan 2018, Gerd Hoffmann wrote --+ | Ok, finally queueed up v1 for merge. Okay, cool. Thank you. -- Prasad J Pandit / Red Hat Product Security Team 47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F

[Qemu-devel] [RFC PATCH qemu v6] vfio-pci: Allow mmap of MSIX BAR

2018-01-30 Thread Alexey Kardashevskiy
This makes use of a new VFIO_REGION_INFO_CAP_MSIX_MAPPABLE capability which tells that a region with MSIX data can be mapped entirely, i.e. the VFIO PCI driver won't prevent MSIX vectors area from being mapped. With this change, all BARs are mapped in a single chunk and MSIX vectors are emulated o

Re: [Qemu-devel] [RFC PATCH qemu v6] vfio-pci: Allow mmap of MSIX BAR

2018-01-30 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180131072445.22783-1-...@ozlabs.ru Subject: [Qemu-devel] [RFC PATCH qemu v6] vfio-pci: Allow mmap of MSIX BAR === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(g

Re: [Qemu-devel] [PATCH 1/3] s390x/pci: fixup the code walking IOMMU tables

2018-01-30 Thread Thomas Huth
On 30.01.2018 10:47, Yi Min Zhao wrote: > Current s390x PCI IOMMU code is lack of flags' checking, including: > 1) protection bit > 2) table length > 3) table offset > 4) intermediate tables' invalid bit > 5) format control bit > > This patch introduces a new struct named S390IOTLBEntry, and makes

Re: [Qemu-devel] [PATCH 01/18] Clean up includes

2018-01-30 Thread Markus Armbruster
BALATON Zoltan writes: > On Tue, 30 Jan 2018, Markus Armbruster wrote: >> Clean up includes so that osdep.h is included first and headers >> which it implies are not included manually. >> >> This commit was created with scripts/clean-includes, with the change >> to target/s390x/gen-features.c man

Re: [Qemu-devel] [PATCH 02/18] Drop superfluous includes of qapi-types.h

2018-01-30 Thread Markus Armbruster
Eric Blake writes: > On 01/30/2018 04:21 AM, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster >> --- > >> +++ b/tests/test-clone-visitor.c >> @@ -11,7 +11,6 @@ >> >> #include "qemu-common.h" >> #include "qapi/clone-visitor.h" >> -#include "test-qapi-types.h" > > Overactive sed pa

Re: [Qemu-devel] [PATCH 03/18] Include qapi/error.h exactly where needed

2018-01-30 Thread Markus Armbruster
Eric Blake writes: > On 01/30/2018 04:21 AM, Markus Armbruster wrote: >> This cleanup makes the number of objects depending on qapi/error.h >> drop from 1910 (out of 4739) to 1612 in my "build everything" tree. >> >> Signed-off-by: Markus Armbruster >> --- >> arch_init.c

<    1   2   3