Re: [Qemu-devel] [PATCH 5/7] tests: virtio-9p: add WRITE operation test

2018-01-30 Thread Greg Kurz
On Mon, 29 Jan 2018 21:14:31 + Stefan Hajnoczi wrote: > On Wed, Jan 24, 2018 at 12:39:23AM +0100, Greg Kurz wrote: > > +/* size[4] Twrite tag[2] fid[4] offset[8] count[4] data[count] */ > > +static P9Req *v9fs_twrite(QVirtIO9P *v9p, uint32_t fid, uint64_t offset, > > +

[Qemu-devel] [PATCH] tests/virtio-9p: explicitely handle potential integer overflows

2018-01-30 Thread Greg Kurz
Signed-off-by: Greg Kurz --- tests/virtio-9p-test.c | 31 +-- 1 file changed, 21 insertions(+), 10 deletions(-) This is based on SHA1 2eab02aa260ac5405e1e51c9cc1b4c3aa23fc45a from my 9p-next branch: https://github.com/gkurz/qemu/commits/9p-next diff --git a/tests/

Re: [Qemu-devel] [PATCH v3 0/2] virtio: improve virtio devices initialization time

2018-01-30 Thread Gal Hammer
Hi Greg, On Mon, Jan 29, 2018 at 7:47 PM, Greg Kurz wrote: > On Mon, 29 Jan 2018 16:20:55 +0200 > Gal Hammer wrote: > >> Using a cleanup callback function (Version 2 of this patches) in order to >> support transactions fails when the same event notifier fd was used by more >> than one Memory Reg

Re: [Qemu-devel] [PATCH v3] tpm: add CRB device

2018-01-30 Thread Igor Mammedov
On Mon, 29 Jan 2018 11:50:04 -0500 Stefan Berger wrote: > On 01/29/2018 11:24 AM, Igor Mammedov wrote: > > On Fri, 26 Jan 2018 13:03:06 +0100 > > Marc-André Lureau wrote: > > > >> tpm_crb is a device for TPM 2.0 Command Response Buffer (CRB) > >> Interface as defined in TCG PC Client Platform

[Qemu-devel] [PATCH] block/mirror: change the semantic of 'force' of block-job-cancel

2018-01-30 Thread Liang Li
When doing drive mirror to a low speed shared storage, if there was heavy BLK IO write workload in VM after the 'ready' event, drive mirror block job can't be canceled immediately, it would keep running until the heavy BLK IO workload stopped in the VM. Because libvirt depends on block-job-cancel

Re: [Qemu-devel] SDL2 UI behavior of switching views

2018-01-30 Thread Gerd Hoffmann
On Mon, Jan 29, 2018 at 07:21:02PM +0100, BALATON Zoltan wrote: > On Mon, 29 Jan 2018, Gerd Hoffmann wrote: > > On Sun, Jan 28, 2018 at 06:43:44PM +0300, Anatoly Trosinenko wrote: > > > When QEMU is run with GTK UI, it changes what is drawn on its single > > > window > > > when I press Ctrl-Alt-{1

[Qemu-devel] [PATCH] qemu-options.hx: Remove confusing spaces in parameter listings

2018-01-30 Thread Thomas Huth
The spaces between the parameters in the chardev and tpmdev sections are rather confusing than helpful, and prevent that the lists can be copy-n-pasted easily for real usage. We also don't use such spaces in other sections in the documentation, e.g. with the -netdev option, so let's be consistent a

Re: [Qemu-devel] [PATCH] hw/audio/sb16.c: Convert file to new logging API

2018-01-30 Thread Gerd Hoffmann
> @@ -148,15 +142,16 @@ static int irq_of_magic (int magic) > #if 0 > static void log_dsp (SB16State *dsp) > { > -ldebug ("%s:%s:%d:%s:dmasize=%d:freq=%d:const=%d:speaker=%d\n", > -dsp->fmt_stereo ? "Stereo" : "Mono", > -dsp->fmt_signed ? "Signed" : "Unsigned", > -

[Qemu-devel] [PATCH 2/3] s390x/pci: fixup global refresh

2018-01-30 Thread Yi Min Zhao
The VFIO common code doesn't provide the possibility to modify a previous mapping entry in another way than unmapping and mapping again with new properties. To avoid -EEXIST DMA mapping error, this we introduce a GHashTable to store S390IOTLBEntry instances in order to cache the mapped entries. Wh

[Qemu-devel] [PATCH 3/3] s390x/pci: use the right pal and pba in reg_ioat()

2018-01-30 Thread Yi Min Zhao
When registering ioat, pba should be comprised of leftmost 52 bits and rightmost 12 binary zeros, and pal should be comprised of leftmost 52 bits and right most 12 binary ones. Let's fixup this. Reviewed-by: Pierre Morel Signed-off-by: Yi Min Zhao --- hw/s390x/s390-pci-inst.c | 2 ++ 1 file cha

[Qemu-devel] [PATCH 1/3] s390x/pci: fixup the code walking IOMMU tables

2018-01-30 Thread Yi Min Zhao
Current s390x PCI IOMMU code is lack of flags' checking, including: 1) protection bit 2) table length 3) table offset 4) intermediate tables' invalid bit 5) format control bit This patch introduces a new struct named S390IOTLBEntry, and makes up these missed checkings. At the same time, inform the

[Qemu-devel] [PATCH 0/3] s390x/pci: fixup and optimize IOTLB code

2018-01-30 Thread Yi Min Zhao
This series contains three patches, 1) optimizes the code including walking DMA tables and rpcit handler 2) fixes the issue caused by IOTLB global refresh 3) uses the right pal and pba when registering ioat The issue mentioned above was found when we tested SMC-r tools. This behavior has been int

[Qemu-devel] [PATCH 10/18] Include qapi/qmp/qlist.h exactly where needed

2018-01-30 Thread Markus Armbruster
This cleanup makes the number of objects depending on qapi/qmp/qlist.h drop from 4548 (out of 4739) to 16 in my "build everything" tree. Signed-off-by: Markus Armbruster --- block/qapi.c| 1 + block/rbd.c | 1 + blockdev.c

[Qemu-devel] [PATCH 05/18] Include qmp-commands.h exactly where needed

2018-01-30 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- block.c| 1 - blockjob.c | 1 - hw/acpi/acpi-stub.c| 1 - hw/ppc/spapr.c | 1 - hw/s390x/s390-stattrib.c | 1 - hw/smbios/smbios-stub.c| 1 - hw/xen/xen-common.c| 1 - include/sysemu/arch_in

[Qemu-devel] [PATCH 12/18] Include qapi/qmp/qstring.h exactly where needed

2018-01-30 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- block.c | 1 + include/qapi/qmp/qjson.h| 2 -- monitor.c | 1 + qapi/qobject-input-visitor.c| 1 + qemu-img.c | 1 + qga/main.c | 1 + q

[Qemu-devel] [PATCH 01/18] Clean up includes

2018-01-30 Thread Markus Armbruster
Clean up includes so that osdep.h is included first and headers which it implies are not included manually. This commit was created with scripts/clean-includes, with the change to target/s390x/gen-features.c manually reverted, and blank lines around deletions collapsed. Signed-off-by: Markus Armb

[Qemu-devel] [PATCH 04/18] Drop superfluous includes of qapi/qmp/qerror.h

2018-01-30 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- backends/tpm.c | 1 - block/qcow.c | 1 - block/qed.c| 1 - blockdev-nbd.c | 1 - hw/s390x/s390-virtio-ccw.c | 1 - net/colo-compare.c | 1 - net/filter-mirror.c| 1 - net/filter-rewriter.c

[Qemu-devel] [PATCH 15/18] Include qapi/qmp/qnull.h exactly where needed

2018-01-30 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- target/ppc/translate.c | 1 - target/ppc/translate_init.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index eeaad9e91f..4132f67bb1 100644 --- a/target/ppc/translate.c +++ b/target/ppc

[Qemu-devel] [PATCH 17/18] Drop superfluous includes of qapi/qmp/qjson.h

2018-01-30 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- balloon.c | 1 - block/nbd.c | 1 - block/quorum.c | 1 - blockjob.c | 1 - hw/core/qdev.c | 1 - hw/net/virtio-net.c | 1 - hw

[Qemu-devel] [PATCH 13/18] Include qapi/qmp/qbool.h exactly where needed

2018-01-30 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- block.c| 1 - block/blkdebug.c | 1 - block/curl.c | 1 - block/qcow2.c | 1 - block/quorum.c | 1 - block/vvfat.c | 1 - hw/usb/xen-usb.c |

[Qemu-devel] [PATCH 07/18] Eliminate qapi/qmp/types.h

2018-01-30 Thread Markus Armbruster
qapi/qmp/types.h is a convenience header to include a number of qapi/qmp/ headers. Since we rarely need all of the headers qapi/qmp/types.h includes, we bypass it most of the time. Most of the places that use it don't need all the headers, either. Include the necessary headers directly, and drop

[Qemu-devel] [PATCH 00/18] Clean up includes to reduce compile time

2018-01-30 Thread Markus Armbruster
We have awfully many "touch it, recompile the world" headers. Right now, I count about fifty that are prerequisites of more than half the objects in my "build everything" tree. Some of them are that way by necessity. Many of them are not. This series takes care of six I happen to touch, because

[Qemu-devel] [PATCH 08/18] qdict qlist: Make most helper macros functions

2018-01-30 Thread Markus Armbruster
The macro expansions of qdict_put_TYPE() and qlist_append_TYPE() need qbool.h, qnull.h, qnum.h and qstring.h to compile. We include qnull.h and qnum.h in the headers, but not qbool.h and qstring.h. Works, because we include those wherever the macros get used. Open-coding these helpers is of dubi

[Qemu-devel] [PATCH 14/18] Include qapi/qmp/qnum.h exactly where needed

2018-01-30 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- tests/check-qlit.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/check-qlit.c b/tests/check-qlit.c index f012885534..5d0f65b9c7 100644 --- a/tests/check-qlit.c +++ b/tests/check-qlit.c @@ -12,7 +12,6 @@ #include "qapi/qmp/qdict.h" #include "qapi/q

[Qemu-devel] [PATCH 06/18] Typedef the subtypes of QObject in qemu/typedefs.h, too

2018-01-30 Thread Markus Armbruster
This renders many inclusions of qapi/qmp/q*.h superfluous. They'll be dropped in the next few commits. Signed-off-by: Markus Armbruster --- include/qapi/qmp/qbool.h | 4 ++-- include/qapi/qmp/qdict.h | 4 ++-- include/qapi/qmp/qlist.h | 4 ++-- include/qapi/qmp/qnum.h| 4 ++-- include

[Qemu-devel] [PATCH 18/18] Move include qemu/option.h from qemu-common.h to actual users

2018-01-30 Thread Markus Armbruster
qemu-common.h includes qemu/option.h, but most places that include the former don't actually need the latter. Drop the include, and add it to the places that actually need it. While there, drop superfluous includes of both headers. This cleanup makes the number of objects depending on qemu/optio

[Qemu-devel] [PATCH 16/18] Drop superfluous includes of qapi/qmp/dispatch.h

2018-01-30 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- monitor.c | 1 - qga/main.c| 1 - tests/test-qmp-commands.c | 1 - 3 files changed, 3 deletions(-) diff --git a/monitor.c b/monitor.c index 02d9dd8708..6f70c8db9a 100644 --- a/monitor.c +++ b/monitor.c @@ -79,7 +79,6 @@ #inclu

[Qemu-devel] [PATCH 09/18] Include qapi/qmp/qobject.h exactly where needed

2018-01-30 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- include/block/block.h | 1 - include/qapi/qmp/dispatch.h | 1 - include/qapi/qmp/qjson.h | 1 - include/qapi/qobject-input-visitor.h | 1 - include/qapi/qobject-output-visitor.h | 1 - include/qapi/visitor.h

[Qemu-devel] [PATCH 02/18] Drop superfluous includes of qapi-types.h

2018-01-30 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- backends/cryptodev.c | 1 - backends/hostmem.c | 1 - hmp.h| 1 - include/block/block.h| 1 - include/block/block_int.h| 1 - include/block/qapi.h | 1

[Qemu-devel] [PATCH 11/18] Include qapi/qmp/qdict.h exactly where needed

2018-01-30 Thread Markus Armbruster
This cleanup makes the number of objects depending on qapi/qmp/qdict.h drop from 4547 (out of 4739) to 368 in my "build everything" tree. For qapi/qmp/qobject.h, the number drops from 4549 to 390. Signed-off-by: Markus Armbruster --- block/crypto.c | 1 + block/curl.c

[Qemu-devel] [PATCH 03/18] Include qapi/error.h exactly where needed

2018-01-30 Thread Markus Armbruster
This cleanup makes the number of objects depending on qapi/error.h drop from 1910 (out of 4739) to 1612 in my "build everything" tree. Signed-off-by: Markus Armbruster --- arch_init.c | 1 + audio/wavcapture.c | 1 + balloon.c

[Qemu-devel] Savevm and loadvm not working

2018-01-30 Thread sridhar kulkarni via Qemu-devel
Hi, I am new bee to snapshot feature and how to use it correctly. My requirement is simple, in that I want to snapshot the running VM and save the snapshot file. Using the snapshot file, I want to boot the VM directly to snapshot state.I came across the qemu monitors "savevm" and "loadvm" comman

Re: [Qemu-devel] [PULL 0/3] Tracing patches

2018-01-30 Thread Peter Maydell
On 29 January 2018 at 16:07, Stefan Hajnoczi wrote: > The following changes since commit 6233b4a8c2a32ef6955a921246fa08705bbb3676: > > Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2018-01-26' into > staging (2018-01-26 17:29:14 +) > > are available in the Git repository at: > >

[Qemu-devel] [PATCH V2] target-arm:Add a dynamic XML-description of the cp-registers to GDB

2018-01-30 Thread Abdallah Bouassida
[PATCH V2] target-arm:Add a dynamic XML-description of the cp-registers to GDB This patch offers to GDB the ability to read/write all the coprocessor registers for ARM and ARM64 by generating dynamically an XML-description for these registers. Signed-off-by: Abdallah Bouassida --- Hello Peter

Re: [Qemu-devel] Savevm and loadvm not working

2018-01-30 Thread Peter Xu
On Tue, Jan 30, 2018 at 10:34:31AM +, sridhar kulkarni via Qemu-devel wrote: > Hi, > I am new bee to snapshot feature and how to use it correctly. My requirement > is simple, in that I want to snapshot the running VM and save the snapshot > file. Using the snapshot file, I want to boot the VM

Re: [Qemu-devel] [PATCH qemu v5 0/2] vfio-pci: Allow mmap of MSIX BAR

2018-01-30 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180130035527.47336-1-...@ozlabs.ru Subject: [Qemu-devel] [PATCH qemu v5 0/2] vfio-pci: Allow mmap of MSIX BAR === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(g

[Qemu-devel] [Bug 1636217] Re: qemu-kvm 2.7 does not boot kvm VMs with virtio on top of VMware ESX

2018-01-30 Thread Adrien
Hi, I have exactly the same problem. My stack: - macOS Sierra 10.12.6 - VMware Fusion 10.1.1 (tried with 10.0.1 too) - Linux 4.9.78 (tried with 4.9.65 too) - Qemu 2.11.0 (tried with 2.10.1 too) All is working great with i440fx (or q35) <= 2.6 but it doesn't boot on >= 2.7 and QEMU takes all the

Re: [Qemu-devel] [RFC 0/2] virtio-vhost-user: add virtio-vhost-user device

2018-01-30 Thread Wei Wang
On 01/26/2018 10:44 PM, Stefan Hajnoczi wrote: On Thu, Jan 25, 2018 at 06:19:13PM +0800, Wei Wang wrote: On 01/24/2018 07:40 PM, Stefan Hajnoczi wrote: On Tue, Jan 23, 2018 at 09:06:49PM +0800, Wei Wang wrote: On 01/23/2018 07:12 PM, Stefan Hajnoczi wrote: On Mon, Jan 22, 2018 at 07:09:06PM +

Re: [Qemu-devel] [PATCH v7 1/9] mirror: inherit supported write/zero flags

2018-01-30 Thread Anton Nefedov
On 29/1/2018 10:26 PM, Eric Blake wrote: On 01/29/2018 01:21 PM, Max Reitz wrote: On 2018-01-18 18:48, Anton Nefedov wrote: Signed-off-by: Anton Nefedov Reviewed-by: Eric Blake Reviewed-by: Alberto Garcia --- block/mirror.c | 5 + 1 file changed, 5 insertions(+) diff --git a/block/

Re: [Qemu-devel] [PATCH v5] cocoa.m: Add ability for user to specify mouse ungrab key

2018-01-30 Thread Gerd Hoffmann
On Fri, Jan 26, 2018 at 04:47:31PM -0500, John Arbuckle wrote: > Currently the ungrab keys for the Cocoa and GTK interface are Control-Alt-g. SDL is the same now, for consistency. > This combination may not be very fun for the user to have to enter, so we > now enable the user to specify their ow

Re: [Qemu-devel] [PATCH v7 3/9] block: introduce BDRV_REQ_ALLOCATE flag

2018-01-30 Thread Anton Nefedov
On 29/1/2018 10:37 PM, Max Reitz wrote: On 2018-01-18 18:49, Anton Nefedov wrote: The flag is supposed to indicate that the region of the disk image has to be sufficiently allocated so it reads as zeroes. The call with the flag set must return -ENOTSUP if allocation cannot be done efficiently

Re: [Qemu-devel] [PATCH v7 4/9] block: treat BDRV_REQ_ALLOCATE as serialising

2018-01-30 Thread Anton Nefedov
On 29/1/2018 10:48 PM, Max Reitz wrote: On 2018-01-18 18:49, Anton Nefedov wrote: The idea is that ALLOCATE requests may overlap with other requests. Reuse the existing block layer infrastructure for serialising requests. Use the following approach: - mark ALLOCATE serialising, so subsequen

Re: [Qemu-devel] [PATCH v2] tests: acpi: fix FADT not being compared to reference table

2018-01-30 Thread Igor Mammedov
On Tue, 16 Jan 2018 16:30:26 +0100 Igor Mammedov wrote: > It turns out that FADT isn't actually tested for changes > against reference table, since it happens to be the 1st > table in RSDT which is currently ignored. > Fix it by making sure that all tables from RSDT are added > to test list. > >

Re: [Qemu-devel] [PATCH RFC 1/2] s390x/tcg: wire up pci instructions

2018-01-30 Thread David Hildenbrand
On 29.01.2018 17:52, Cornelia Huck wrote: > On s390x, pci support is implemented via a set of instructions > (no mmio). Unfortunately, none of them are documented in the > PoP; the code is based upon the existing implementation for KVM > and the Linux zpci driver. > > Signed-off-by: Cornelia Huck

Re: [Qemu-devel] [PATCH v7 9/9] iotest 134: test cluster-misaligned encrypted write

2018-01-30 Thread Alberto Garcia
On Thu 18 Jan 2018 06:49:07 PM CET, Anton Nefedov wrote: > COW (even empty/zero) areas require encryption too > > Signed-off-by: Anton Nefedov > Reviewed-by: Eric Blake Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PATCH RFC 2/2] s390x/cpumodel: allow zpci features in qemu model

2018-01-30 Thread David Hildenbrand
On 29.01.2018 17:52, Cornelia Huck wrote: > AEN can be provided unconditionally, ZPCI has to be turned on > manually (it should really depend on CONFIG_PCI). > > With -cpu qemu,zpci=on, a 4.15 guest kernel can now successfully > detect virtio-pci devices under tcg. > > Signed-off-by: Cornelia Huc

[Qemu-devel] [PATCH] sii3112: Change angle brackets to quotes in #include lines

2018-01-30 Thread BALATON Zoltan
This matches what other files do for qemu includes Signed-off-by: BALATON Zoltan --- hw/ide/sii3112.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ide/sii3112.c b/hw/ide/sii3112.c index 17aa930..e3896c6 100644 --- a/hw/ide/sii3112.c +++ b/hw/ide/sii3112.c @@ -12,8 +

[Qemu-devel] [PATCH] linux-user/signal.c: Rename MC_* defines

2018-01-30 Thread Peter Maydell
The SPARC code in linux-user/signal.c defines a set of MC_* constants. On some SPARC hosts these are also defined by sys/ucontext.h, resulting in build failures: linux-user/signal.c:2786:0: error: "MC_NGREG" redefined [-Werror] #define MC_NGREG 19 In file included from /usr/include/signal.h:302:

Re: [Qemu-devel] [PATCH v4 09/14] pci: Add support for Designware IP block

2018-01-30 Thread Marcel Apfelbaum
Hi Andrei, Sorry for letting you wait, I have some comments/questions below. On 16/01/2018 3:37, Andrey Smirnov wrote: Add code needed to get a functional PCI subsytem when using in conjunction with upstream Linux guest (4.13+). Tested to work against "e1000e" (network adapter, using MSI interr

Re: [Qemu-devel] [PATCH] sii3112: Change angle brackets to quotes in #include lines

2018-01-30 Thread Peter Maydell
On 30 January 2018 at 13:10, BALATON Zoltan wrote: > This matches what other files do for qemu includes > > Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH 01/18] Clean up includes

2018-01-30 Thread BALATON Zoltan
On Tue, 30 Jan 2018, Markus Armbruster wrote: Clean up includes so that osdep.h is included first and headers which it implies are not included manually. This commit was created with scripts/clean-includes, with the change to target/s390x/gen-features.c manually reverted, and blank lines around

Re: [Qemu-devel] SDL2 UI behavior of switching views

2018-01-30 Thread BALATON Zoltan
On Tue, 30 Jan 2018, Gerd Hoffmann wrote: On Mon, Jan 29, 2018 at 07:21:02PM +0100, BALATON Zoltan wrote: Is there an option also to get back the old SDL1 behaviour with SDL2? Could that be made the default to make the transition easier? Well, that kind of flexibility is alot harder to do with

Re: [Qemu-devel] [PATCH] linux-user/signal.c: Rename MC_* defines

2018-01-30 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1517318239-15764-1-git-send-email-peter.mayd...@linaro.org Subject: [Qemu-devel] [PATCH] linux-user/signal.c: Rename MC_* defines === TEST SCRIPT BEGIN === #!/bin/bash BASE=

[Qemu-devel] [PATCH v2 1/1] Fix configure for s390 qemu on alpine and other busybox environments

2018-01-30 Thread Christian Borntraeger
From: Alice Frosi In alpine docker image the qemu-system-s390x build is broken and it throws this error: qemu-system-s390x: Initialization of device s390-ipl failed: could not load bootloader 's390-ccw.img' The grep command of busybox uses regex. This fails on binary data (e.g. stops on every \0

[Qemu-devel] [PATCH v2 0/1] Fix binary build of qemu-system-s390x on alpine

2018-01-30 Thread Christian Borntraeger
Peter, Paolo, sending this to you as you have the most commits on configure. If you are ok with it, we can also carry that via the s390 tree. Alice Frosi (1): Fix configure for s390 qemu on alpine and other busybox environments configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(

Re: [Qemu-devel] [PATCH] iotests: Fix CID for VMDK afl image

2018-01-30 Thread Eric Blake
On 01/30/2018 12:25 AM, Fam Zheng wrote: > This reverts commit 76bf133c4 which updated the reference output, and > fixed the reference image, because the code path we want to exercise is > actually the invalid image size. > > The descriptor block in the image, which includes the CID to verify, has

Re: [Qemu-devel] [PATCH v6 1/2] qemu-img.texi: Clean up parameter list

2018-01-30 Thread Eric Blake
On 01/30/2018 12:34 AM, Fam Zheng wrote: > Split options out of the "@table @var" section and create a "@table > @option", then use whitespaces and blank lines consistently. > > Suggested-by: Kevin Wolf > Signed-off-by: Fam Zheng > --- > qemu-img.texi | 66 > +++

Re: [Qemu-devel] [PATCH v6 2/2] qemu-img: Document --force-share / -U

2018-01-30 Thread Eric Blake
On 01/30/2018 12:34 AM, Fam Zheng wrote: > Signed-off-by: Fam Zheng > Signed-off-by: Kevin Wolf > --- > qemu-img.texi | 7 +++ > 1 file changed, 7 insertions(+) > Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization:

Re: [Qemu-devel] [PATCH] tests/virtio-9p: explicitely handle potential integer overflows

2018-01-30 Thread Eric Blake
On 01/30/2018 02:32 AM, Greg Kurz wrote: > Signed-off-by: Greg Kurz In the subject: s/explicitely/explicitly/ > --- > tests/virtio-9p-test.c | 31 +-- > 1 file changed, 21 insertions(+), 10 deletions(-) > > This is based on SHA1 2eab02aa260ac5405e1e51c9cc1b4c3aa23

Re: [Qemu-devel] [PATCH] iotests: Fix CID for VMDK afl image

2018-01-30 Thread Fam Zheng
On Tue, Jan 30, 2018 at 9:48 PM, Eric Blake wrote: > On 01/30/2018 12:25 AM, Fam Zheng wrote: >> This reverts commit 76bf133c4 which updated the reference output, and >> fixed the reference image, because the code path we want to exercise is >> actually the invalid image size. >> >> The descriptor

Re: [Qemu-devel] [PATCH V4 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

2018-01-30 Thread Paolo Bonzini
On 25/01/2018 22:33, Pavel Pisa wrote: > Hello Paolo, > > thanks for suggestions. I understand and fully agree with your > request to switch to QOM. I have succeed with that for CAN devices > some time ago. It worth to be done for the rest of the objects > but I fear that I do not find time to com

Re: [Qemu-devel] [PATCH] block/mirror: change the semantic of 'force' of block-job-cancel

2018-01-30 Thread Eric Blake
On 01/30/2018 02:38 AM, Liang Li wrote: > When doing drive mirror to a low speed shared storage, if there was heavy > BLK IO write workload in VM after the 'ready' event, drive mirror block job > can't be canceled immediately, it would keep running until the heavy BLK IO > workload stopped in the V

Re: [Qemu-devel] [PATCH v7 8/9] qcow2: skip writing zero buffers to empty COW areas

2018-01-30 Thread Anton Nefedov
On 29/1/2018 11:28 PM, Max Reitz wrote: On 2018-01-18 18:49, Anton Nefedov wrote: If COW areas of the newly allocated clusters are zeroes on the backing image, efficient bdrv_write_zeroes(flags=BDRV_REQ_ALLOCATE) can be used on the whole cluster instead of writing explicit zero buffers later i

Re: [Qemu-devel] [PATCH v6 2/2] qemu-img: Document --force-share / -U

2018-01-30 Thread Eric Blake
On 01/30/2018 12:34 AM, Fam Zheng wrote: > Signed-off-by: Fam Zheng > Signed-off-by: Kevin Wolf > --- > qemu-img.texi | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/qemu-img.texi b/qemu-img.texi > index 60a0e080c6..ec7e2f5d1e 100644 > --- a/qemu-img.texi > +++ b/qemu-img.texi >

Re: [Qemu-devel] [PATCH v6 2/2] qemu-img: Document --force-share / -U

2018-01-30 Thread Kashyap Chamarthy
On Tue, Jan 30, 2018 at 08:23:50AM -0600, Eric Blake wrote: > On 01/30/2018 12:34 AM, Fam Zheng wrote: [...] > > +If specified, @code{qemu-img} will open the image in shared mode, allowing > > +concurrent writers. For example, this can be used to get the image > > information > > Actually, we o

Re: [Qemu-devel] [RFC 0/2] Use SDL to create an OpenGL ES context for virglrenderer.

2018-01-30 Thread Elie Tournier
On Mon, Jan 29, 2018 at 07:08:30PM +0100, Gerd Hoffmann wrote: Hello, First, thanks for your reply. I added some comments and questions below. Cheers, Elie > Hi, > > > > In order to use this feature, we need to create a gles context. > > > This series add an option (`-display sdl,gles=on`) in

Re: [Qemu-devel] SDL2 UI behavior of switching views

2018-01-30 Thread Gerd Hoffmann
On Tue, Jan 30, 2018 at 02:35:02PM +0100, BALATON Zoltan wrote: > On Tue, 30 Jan 2018, Gerd Hoffmann wrote: > > On Mon, Jan 29, 2018 at 07:21:02PM +0100, BALATON Zoltan wrote: > > > Is there an option also to get back the old SDL1 behaviour with SDL2? > > > Could > > > that be made the default to

[Qemu-devel] [PATCH 0/7] target/arm: Implement M profile derived exceptions

2018-01-30 Thread Peter Maydell
In the Arm M-profile architecture, the process of taking or returning from an exception can itself cause an exception (for instance if there is an MPU permissions fault when writing or reading the exception stack frame). This is called a derived exception. Currently we don't implement this at all i

[Qemu-devel] [PATCH 3/7] target/arm: Add ignore_stackfaults argument to v7m_exception_taken()

2018-01-30 Thread Peter Maydell
In the v8M architecture, if the process of taking an exception results in a further exception this is called a derived exception (for example, an MPU exception when writing the exception frame to memory). If the derived exception happens while pushing the initial stack frame, we must ignore any sub

[Qemu-devel] [PATCH 2/7] target/arm: Split "get pending exception info" from "acknowledge it"

2018-01-30 Thread Peter Maydell
Currently armv7m_nvic_acknowledge_irq() does three things: * make the current highest priority pending interrupt active * return a bool indicating whether that interrupt is targeting Secure or NonSecure state * implicitly tell the caller which is the highest priority pending interrupt by s

[Qemu-devel] [PATCH 7/7] target/arm: Handle exceptions during exception stack pop

2018-01-30 Thread Peter Maydell
Handle possible MPU faults, SAU faults or bus errors when popping register state off the stack during exception return. Signed-off-by: Peter Maydell --- target/arm/helper.c | 115 ++-- 1 file changed, 94 insertions(+), 21 deletions(-) diff --git a

[Qemu-devel] [PATCH 1/7] target/arm: Add armv7m_nvic_set_pending_derived()

2018-01-30 Thread Peter Maydell
In order to support derived exceptions (exceptions generated in the course of trying to take an exception), we need to be able to handle prioritizing whether to take the original exception or the derived exception. We do this by introducing a new function armv7m_nvic_set_pending_derived() which th

[Qemu-devel] [PATCH 5/7] target/arm: Make v7m_push_callee_stack() honour MPU

2018-01-30 Thread Peter Maydell
Make v7m_push_callee_stack() honour the MPU by using the new v7m_stack_write() function. We return a flag to indicate whether the pushes failed, which we can then use in v7m_exception_taken() to cause us to handle the derived exception correctly. Signed-off-by: Peter Maydell --- target/arm/helpe

[Qemu-devel] [PATCH 6/7] target/arm: Make exception vector loads honour the SAU

2018-01-30 Thread Peter Maydell
Make the load of the exception vector from the vector table honour the SAU and any bus error on the load (possibly provoking a derived exception), rather than simply aborting if the load fails. Signed-off-by: Peter Maydell --- target/arm/helper.c | 71 +---

[Qemu-devel] [PATCH 4/7] target/arm: Make v7M exception entry stack push check MPU

2018-01-30 Thread Peter Maydell
The memory writes done to push registers on the stack on exception entry in M profile CPUs are supposed to go via MPU permissions checks, which may cause us to take a derived exception instead of the original one of the MPU lookup fails. We were implementing these as always-succeeds direct writes t

[Qemu-devel] [PATCH] qcow2: Replace align_offset() with ROUND_UP()

2018-01-30 Thread Alberto Garcia
The align_offset() function is equivalent to the ROUND_UP() macro so there's no need to use the former. The ROUND_UP() name is also a bit more explicit. This patch uses ROUND_UP() instead of the slower QEMU_ALIGN_UP() because align_offset() already requires that the second parameter is a power of

Re: [Qemu-devel] [PATCH] linux-user/signal.c: Rename MC_* defines

2018-01-30 Thread Peter Maydell
On 30 January 2018 at 13:17, Peter Maydell wrote: > The SPARC code in linux-user/signal.c defines a set of > MC_* constants. On some SPARC hosts these are also defined > by sys/ucontext.h, resulting in build failures: > > linux-user/signal.c:2786:0: error: "MC_NGREG" redefined [-Werror] > #define

Re: [Qemu-devel] [RFC 0/2] Use SDL to create an OpenGL ES context for virglrenderer.

2018-01-30 Thread Gerd Hoffmann
Hi, > > Well, display configuration is going to be rewritten, and while that is > > in flight adding new config options isn't a good idea b/c things will > > conflict ... > I'm wondering how extensive this rewrite is going to be. Did you plan to > modify the qemu interface? > If someone already

Re: [Qemu-devel] [PATCH 01/18] Clean up includes

2018-01-30 Thread Eric Blake
On 01/30/2018 04:21 AM, Markus Armbruster wrote: > Clean up includes so that osdep.h is included first and headers > which it implies are not included manually. > > This commit was created with scripts/clean-includes, with the change > to target/s390x/gen-features.c manually reverted, and blank li

Re: [Qemu-devel] [PATCH 0/3] Sanitizers configuration

2018-01-30 Thread Marc-André Lureau
ping On Tue, Jan 16, 2018 at 4:11 PM, Marc-André Lureau wrote: > Hi, > > This is a few reworked patches from "[PATCH v3 00/18] Various > build-sys and sanitizer related fixes" series. > > It enables sanitizers by default with --enable-debug. But sanitizers > can be also enabled/disabled independe

Re: [Qemu-devel] [PATCH] hw/audio/sb16.c: Convert file to new logging API

2018-01-30 Thread Programmingkid
> On Jan 30, 2018, at 4:41 AM, Gerd Hoffmann wrote: > >> @@ -148,15 +142,16 @@ static int irq_of_magic (int magic) >> #if 0 >> static void log_dsp (SB16State *dsp) >> { >> -ldebug ("%s:%s:%d:%s:dmasize=%d:freq=%d:const=%d:speaker=%d\n", >> -dsp->fmt_stereo ? "Stereo" : "Mono", >>

Re: [Qemu-devel] [PULL 0/3] Tracing patches

2018-01-30 Thread Stefan Hajnoczi
On Mon, Jan 29, 2018 at 08:14:46AM -0800, no-re...@patchew.org wrote: > === OUTPUT BEGIN === > Checking PATCH 1/3: tracetool: prefix parse errors with line numbers... > Checking PATCH 2/3: tracetool: clarify that "formats" means "format > strings"... > ERROR: line over 90 characters > #39: FILE: s

Re: [Qemu-devel] [PATCH] tests/virtio-9p: explicitely handle potential integer overflows

2018-01-30 Thread Stefan Hajnoczi
On Tue, Jan 30, 2018 at 09:32:48AM +0100, Greg Kurz wrote: > Signed-off-by: Greg Kurz > --- > tests/virtio-9p-test.c | 31 +-- > 1 file changed, 21 insertions(+), 10 deletions(-) > > This is based on SHA1 2eab02aa260ac5405e1e51c9cc1b4c3aa23fc45a from my > 9p-next br

Re: [Qemu-devel] [PATCH v6 2/2] qemu-img: Document --force-share / -U

2018-01-30 Thread Stefan Hajnoczi
On Tue, Jan 30, 2018 at 02:34:33PM +0800, Fam Zheng wrote: > Signed-off-by: Fam Zheng > Signed-off-by: Kevin Wolf > --- > qemu-img.texi | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/qemu-img.texi b/qemu-img.texi > index 60a0e080c6..ec7e2f5d1e 100644 > --- a/qemu-img.texi > +++

Re: [Qemu-devel] [Qemu-block] [PATCH] virtio-blk: check for NULL BlockDriverState

2018-01-30 Thread Stefan Hajnoczi
On Mon, Jan 29, 2018 at 04:41:07PM +0100, Kevin Wolf wrote: > Am 24.01.2018 um 12:31 hat Stefan Hajnoczi geschrieben: > > On Mon, Jan 22, 2018 at 09:01:49AM -0600, Mark Kanda wrote: > > > Add a BlockDriverState NULL check to virtio_blk_handle_request() > > > to prevent a segfault if the drive is fo

[Qemu-devel] [PATCH] vl: pause vcpus before stopping iothreads

2018-01-30 Thread Stefan Hajnoczi
Commit dce8921b2baaf95974af8176406881872067adfa ("iothread: Stop threads before main() quits") introduced iothread_stop_all() to avoid the following virtio-scsi assertion failure: assert(blk_get_aio_context(d->conf.blk) == s->ctx); Back then the assertion failed because when bdrv_close_all() ma

Re: [Qemu-devel] [PATCH v2 1/1] Fix configure for s390 qemu on alpine and other busybox environments

2018-01-30 Thread Eric Blake
On 01/30/2018 07:38 AM, Christian Borntraeger wrote: > From: Alice Frosi > > In alpine docker image the qemu-system-s390x build is broken and > it throws this error: > qemu-system-s390x: Initialization of device s390-ipl failed: could not > load bootloader 's390-ccw.img' > > The grep command of

Re: [Qemu-devel] [PATCH 02/18] Drop superfluous includes of qapi-types.h

2018-01-30 Thread Eric Blake
On 01/30/2018 04:21 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > +++ b/tests/test-clone-visitor.c > @@ -11,7 +11,6 @@ > > #include "qemu-common.h" > #include "qapi/clone-visitor.h" > -#include "test-qapi-types.h" Overactive sed pattern? This is a different header.

Re: [Qemu-devel] [Qemu-block] [PATCH] virtio-blk: check for NULL BlockDriverState

2018-01-30 Thread Kevin Wolf
Am 30.01.2018 um 13:38 hat Stefan Hajnoczi geschrieben: > On Mon, Jan 29, 2018 at 04:41:07PM +0100, Kevin Wolf wrote: > > Am 24.01.2018 um 12:31 hat Stefan Hajnoczi geschrieben: > > > On Mon, Jan 22, 2018 at 09:01:49AM -0600, Mark Kanda wrote: > > > > Add a BlockDriverState NULL check to virtio_blk

Re: [Qemu-devel] [PATCH v7 1/9] mirror: inherit supported write/zero flags

2018-01-30 Thread Eric Blake
On 01/30/2018 06:15 AM, Anton Nefedov wrote: @@ -1064,6 +1064,11 @@ static void bdrv_mirror_top_refresh_filename(BlockDriverState *bs, QDict *opts)   bdrv_refresh_filename(bs->backing->bs);   pstrcpy(bs->exact_filename, sizeof(bs->exact_filename),   bs-

Re: [Qemu-devel] [PATCH] qcow2: Replace align_offset() with ROUND_UP()

2018-01-30 Thread Eric Blake
On 01/30/2018 09:04 AM, Alberto Garcia wrote: > The align_offset() function is equivalent to the ROUND_UP() macro so > there's no need to use the former. The ROUND_UP() name is also a bit > more explicit. > > This patch uses ROUND_UP() instead of the slower QEMU_ALIGN_UP() > because align_offset()

Re: [Qemu-devel] [PATCH] qcow2: Replace align_offset() with ROUND_UP()

2018-01-30 Thread Alberto Garcia
On Tue 30 Jan 2018 05:03:16 PM CET, Eric Blake wrote: >> -virtual_size = align_offset(qemu_opt_get_size_del(opts, BLOCK_OPT_SIZE, >> 0), >> +virtual_size = ROUND_UP(qemu_opt_get_size_del(opts, BLOCK_OPT_SIZE, 0), >> cluster_size); I just realized that the

Re: [Qemu-devel] [PATCH 03/18] Include qapi/error.h exactly where needed

2018-01-30 Thread Eric Blake
On 01/30/2018 04:21 AM, Markus Armbruster wrote: > This cleanup makes the number of objects depending on qapi/error.h > drop from 1910 (out of 4739) to 1612 in my "build everything" tree. > > Signed-off-by: Markus Armbruster > --- > arch_init.c | 1 + > audio/wavcaptu

[Qemu-devel] [Bug 1703506] Re: SMT not supported by QEMU on AMD Ryzen CPU

2018-01-30 Thread Babu Moger
Posted few patches to support this feature on AMD EPYC processors. Feel free to test and review. 1. Kernel kvm patch https://patchwork.kernel.org/patch/10190107/ 2. qemu patches https://patchwork.kernel.org/project/qemu-devel/list/?submitter=178527 Thanks -- You received this bug notificat

Re: [Qemu-devel] [PATCH] qcow2: Replace align_offset() with ROUND_UP()

2018-01-30 Thread Eric Blake
On 01/30/2018 10:08 AM, Alberto Garcia wrote: > On Tue 30 Jan 2018 05:03:16 PM CET, Eric Blake wrote: > >>> -virtual_size = align_offset(qemu_opt_get_size_del(opts, >>> BLOCK_OPT_SIZE, 0), >>> +virtual_size = ROUND_UP(qemu_opt_get_size_del(opts, BLOCK_OPT_SIZE, 0), >>>

Re: [Qemu-devel] [PATCH 04/18] Drop superfluous includes of qapi/qmp/qerror.h

2018-01-30 Thread Eric Blake
On 01/30/2018 04:21 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > backends/tpm.c | 1 - > block/qcow.c | 1 - > block/qed.c| 1 - > blockdev-nbd.c | 1 - > hw/s390x/s390-virtio-ccw.c | 1 - > net/colo-compare.c

Re: [Qemu-devel] [PATCH] qcow2: Replace align_offset() with ROUND_UP()

2018-01-30 Thread Alberto Garcia
On Tue 30 Jan 2018 05:17:47 PM CET, Eric Blake wrote: > On 01/30/2018 10:08 AM, Alberto Garcia wrote: >> On Tue 30 Jan 2018 05:03:16 PM CET, Eric Blake wrote: >> -virtual_size = align_offset(qemu_opt_get_size_del(opts, BLOCK_OPT_SIZE, 0), +virtual_size = ROUND_UP(qemu_opt_g

[Qemu-devel] [Bug 1703506] Re: SMT not supported by QEMU on AMD Ryzen CPU

2018-01-30 Thread Babu Moger
just to be clear.. The kernel kvm patch is rebased on linux-next. If you are on older kernel then try this kernel patch. https://patchwork.kernel.org/patch/10031775/ plus qemu patch. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. ht

Re: [Qemu-devel] [PATCH] iotests: Fix CID for VMDK afl image

2018-01-30 Thread Kevin Wolf
Am 30.01.2018 um 07:25 hat Fam Zheng geschrieben: > This reverts commit 76bf133c4 which updated the reference output, and > fixed the reference image, because the code path we want to exercise is > actually the invalid image size. > > The descriptor block in the image, which includes the CID to ve

[Qemu-devel] proposed release schedule for QEMU 2.12

2018-01-30 Thread Peter Maydell
It seems like it's about time we settled on the dates for the 2.12 release. I've sketched in a suggestion at: https://wiki.qemu.org/Planning/2.12 which puts softfreeze on the 13th March, hardfreeze a week later on the 20th, and final release on the 17th April. (I basically just took last year's

  1   2   3   >