[Qemu-devel] Can not hotplug device to pci-to-pci bridge using machine type older than 1.7

2018-01-25 Thread Fei Li
Hi, After I hotplug a pci device to a pci2pci bridge (I use "pci.1") with machine type 1.7 or older, I can not see the pci device via `lspci` in the guest, but can see it via `info qtree` in the hmp. What's more, after I reboot the guest or hotplug another pci device to pci.0, I can see the p

Re: [Qemu-devel] [PATCH V4 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

2018-01-25 Thread Pavel Pisa
Hello Philippe, On Wednesday 24 of January 2018 22:41:16 Philippe Mathieu-Daudé wrote: > Hi Pavel, > > I have seen that a few other type_init-s do more > > than simple sequence of type_register_static(). > > Is it acceptable to use type_init for registration > > to CAN core by function call for no

[Qemu-devel] [Bug 1187334] Re: crash on hot-unplug of vmxnet3

2018-01-25 Thread Thomas Huth
Looks like this assertion does not trigger with the current version anymore, so I think we could close this bug. Or can you still reproduce it? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscrib

Re: [Qemu-devel] [PATCH v2] usb-storage: Fix share-rw option parsing

2018-01-25 Thread Gerd Hoffmann
On Wed, Jan 17, 2018 at 08:52:22AM +0800, Fam Zheng wrote: > Because usb-storage creates an internal scsi device, we should propagate > options. We already do so for bootindex etc, but failed to take care of > share-rw. Fix it in an apparent way: add a new parameter to > scsi_bus_legacy_add_drive a

Re: [Qemu-devel] [PULL 10/14] ui: fix VNC client throttling when audio capture is active

2018-01-25 Thread Gerd Hoffmann
Hi, > > VNC is protocol limited to uint16 for width/height size, and so is X11 > > so I imagine some exploding behavour would follow :-) > > Indeed, and even 2^16 x 2^16 * 32bpp is already 34 bits. So perhaps we > should limit VNC to 16384 pixels on each axis (maximum fra

[Qemu-devel] [PULL 2/3] hw/usb/ccid: Make ccid_card_init() take an error parameter

2018-01-25 Thread Gerd Hoffmann
From: Mao Zhongyi Replace init() of CCIDCardClass with realize, then convert ccid_card_init(), ccid_card_initfn() and it's callbacks to take an Error** in ordor to report the error more clearly. Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Cao jin Signed-off-by: Mao Zhongyi Signed-off-by: Ca

[Qemu-devel] [PULL 0/3] Usb 20180125 patches

2018-01-25 Thread Gerd Hoffmann
The following changes since commit 834a336eb911db8a8ca00e760ee6a85faca19414: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2018-01-24 19:24:26 +) are available in the git repository at: git://git.kraxel.org/qemu tags/usb-20180125-pull-request

[Qemu-devel] [PULL 3/3] usb-storage: Fix share-rw option parsing

2018-01-25 Thread Gerd Hoffmann
From: Fam Zheng Because usb-storage creates an internal scsi device, we should propagate options. We already do so for bootindex etc, but failed to take care of share-rw. Fix it in an apparent way: add a new parameter to scsi_bus_legacy_add_drive and pass in s->conf.share_rw. Cc: qemu-sta...@non

[Qemu-devel] [PULL 1/3] usb: Remove legacy -usbdevice options (host, serial, disk and net)

2018-01-25 Thread Gerd Hoffmann
From: Thomas Huth The option have been marked as deprecated since QEMU 2.10, and so far nobody complained that the host, serial, disk and net options are urgently required anymore. So let's now get rid at least of this legacy pile, to simplify the usb code quite a bit. This patch removes the usb

[Qemu-devel] [PULL 1/1] vga: check the validation of memory addr when draw text

2018-01-25 Thread Gerd Hoffmann
From: linzhecheng Start a vm with qemu-kvm -enable-kvm -vnc :66 -smp 1 -m 1024 -hda redhat_5.11.qcow2 -device pcnet -vga cirrus, then use VNC client to connect to VM, and excute the code below in guest OS will lead to qemu crash: int main() { iopl(3); srand(time(NULL)); int a,b;

[Qemu-devel] [PULL 0/1] Vga 20180125 patches

2018-01-25 Thread Gerd Hoffmann
The following changes since commit 834a336eb911db8a8ca00e760ee6a85faca19414: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2018-01-24 19:24:26 +) are available in the git repository at: git://git.kraxel.org/qemu tags/vga-20180125-pull-request

Re: [Qemu-devel] [PULL 00/29] Block layer patches

2018-01-25 Thread Peter Maydell
On 23 January 2018 at 14:01, Kevin Wolf wrote: > The following changes since commit ee86981bda9ecd40c8daf81b7307b1d2aff68174: > > migration: Revert postcopy-blocktime commit set (2018-01-23 10:08:05 +) > > are available in the git repository at: > > git://repo.or.cz/qemu/kevin.git tags/for

Re: [Qemu-devel] [PATCH] vcpu: create vcpu thread with QEMU_THREAD_DETACHED mode

2018-01-25 Thread Paolo Bonzini
On 20/01/2018 08:54, linzhecheng wrote: > 1. If we create vcpu thread with QEMU_THREAD_JOINABLE mode, > we will get memory leak when vcpu thread exits, which will happen > when hot-unplug vcpus. > 2. We should use QLIST_FOREACH_SAFE instead of QLIST_FOREACH > if we need to remove the entry in QLIST

Re: [Qemu-devel] [PATCH v7 00/23] QMP: out-of-band (OOB) execution support

2018-01-25 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Wed, Jan 24, 2018 at 01:39:34PM +0800, Peter Xu wrote: > > This version should have addressed all comments in previous one, also > > fixed another race condition after I addressed all the comments (a new > > race condition introduced by addressing the comm

Re: [Qemu-devel] [PATCH v4 01/10] s390-ccw: refactor boot map table code

2018-01-25 Thread Thomas Huth
On 23.01.2018 19:26, Collin L. Walling wrote: > - replace ScsiMbr in ECKD code with BootMapTable > - fix read_block messages to reflect BMT > - reduce ipl_scsi code with BMT struct > > Signed-off-by: Collin L. Walling > --- > pc-bios/s390-ccw/bootmap.c | 58 > ---

Re: [Qemu-devel] [PATCH] sdhci: fix a NULL pointer dereference due to uninitialized AddresSpace object

2018-01-25 Thread Peter Maydell
On 23 January 2018 at 13:20, Philippe Mathieu-Daudé wrote: > missed in 60765b6ceeb4. > > Thread 1 "qemu-system-aarch64" received signal SIGSEGV, Segmentation fault. > address_space_init (as=0x0, root=0x5726e410, > name=name@entry=0x55e3f0a7 "sdhci-dma") at memory.c:3050 > 3050

Re: [Qemu-devel] [RFC 0/2] virtio-vhost-user: add virtio-vhost-user device

2018-01-25 Thread Wei Wang
On 01/24/2018 07:40 PM, Stefan Hajnoczi wrote: On Tue, Jan 23, 2018 at 09:06:49PM +0800, Wei Wang wrote: On 01/23/2018 07:12 PM, Stefan Hajnoczi wrote: On Mon, Jan 22, 2018 at 07:09:06PM +0800, Wei Wang wrote: On 01/19/2018 09:06 PM, Stefan Hajnoczi wrote: - Suppose in the future there is

Re: [Qemu-devel] [PATCH v3] xilinx_spips: Correct usage of an uninitialized local variable

2018-01-25 Thread Peter Maydell
On 24 January 2018 at 21:57, Francisco Iglesias wrote: > Coverity found that the variable tx_rx in the function > xilinx_spips_flush_txfifo was being used uninitialized (CID 1383841). This > patch corrects this by always initializing tx_rx to zeros. > > Signed-off-by: Francisco Iglesias > > --- >

Re: [Qemu-devel] [PATCH v2 07/18] s390x/tcg: tolerate wrong wakeups due to floating interrupts

2018-01-25 Thread Cornelia Huck
On Wed, 17 Jan 2018 18:40:36 +0100 David Hildenbrand wrote: > This is a prparation for floating interrupt support and only applies to s/prparation/preparation/ (can fix while applying) > MTTCG, single threaded TCG works just fine. If a floating interrupt wakes > up a VCPU and the CPU thinks it

Re: [Qemu-devel] [PATCH v2 12/18] s390x: fix size + content of STSI blocks

2018-01-25 Thread Cornelia Huck
On Wed, 17 Jan 2018 18:40:41 +0100 David Hildenbrand wrote: > All blocks are 4k in size, which is only true for two of them right now. > Also some reserved fields were wrong, fix it and convert all reserved > fields to u8. > > This also fixes the LPAR part output in /proc/sysinfo under TCG. (for

Re: [Qemu-devel] [PATCH v2 00/18] s390x: flic rework, tcg flic support and STSI

2018-01-25 Thread Cornelia Huck
On Wed, 17 Jan 2018 18:40:29 +0100 David Hildenbrand wrote: > This patch series implements floating interrupt support for TCG and fixes > STSI so we can remove warnings related to s390x SMP and MTTCG. > > KVM code has to be touched in order to factor out the injection routines > into the flic ("

Re: [Qemu-devel] [PATCH v3 16/18] sdcard: add a 'uhs' property, update the OCR register ACCEPT_SWITCH_1V8 bit

2018-01-25 Thread Philippe Mathieu-Daudé
On 01/23/2018 12:30 AM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/sd/sd.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/hw/sd/sd.c b/hw/sd/sd.c > index 27176ba33e..b3b6859bc4 100644 > --- a/hw/sd/sd.c > +++ b/hw/sd/sd.c > @@ -93,6 +93,7 @@ st

Re: [Qemu-devel] [PATCH v3 16/18] sdcard: add a 'uhs' property, update the OCR register ACCEPT_SWITCH_1V8 bit

2018-01-25 Thread Philippe Mathieu-Daudé
On 01/25/2018 07:30 AM, Philippe Mathieu-Daudé wrote: > On 01/23/2018 12:30 AM, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> hw/sd/sd.c | 4 >> 1 file changed, 4 insertions(+) >> >> diff --git a/hw/sd/sd.c b/hw/sd/sd.c >> index 27176ba33e..b3b6859bc4 10064

Re: [Qemu-devel] Prevent overriding the input file with the output file when using qemu-img

2018-01-25 Thread Stefan Hajnoczi
On Tue, Jan 23, 2018 at 08:48:15AM -0600, Eric Blake wrote: > On 01/22/2018 10:40 PM, River Chiang wrote: > > Signed-off-by: River Chiang > > > > -- qemu-img.c > > -- > > index 68b375f998..5ce594ea00 100644 > > @@ -2098,6 +2098,9

Re: [Qemu-devel] [PATCH v2 0/4] Updates based on feedback.

2018-01-25 Thread Stefan Hajnoczi
On Mon, Jan 22, 2018 at 01:07:45PM -0800, Justin Terry (VM) via Qemu-devel wrote: > Updates based on review feedback. > > 1. Fixes style issues and properly ran the scripts/checkpatch pre submission. > 2. Added migration blockers for CPUID, dirty memory tracking, and > XSAVE/XRSTOR. > 3. Fixed s

Re: [Qemu-devel] Prevent overriding the input file with the output file when using qemu-img

2018-01-25 Thread Daniel P . Berrangé
On Thu, Jan 25, 2018 at 10:52:57AM +, Stefan Hajnoczi wrote: > On Tue, Jan 23, 2018 at 08:48:15AM -0600, Eric Blake wrote: > > On 01/22/2018 10:40 PM, River Chiang wrote: > > > Signed-off-by: River Chiang > > > > > > -- qemu-img.c > > >

Re: [Qemu-devel] [PATCH v2 17/18] s390x/kvm: cache the kvm flic in a central function

2018-01-25 Thread Christian Borntraeger
On 01/17/2018 06:40 PM, David Hildenbrand wrote: > This avoids tons of conversions when handling interrupts. > > Signed-off-by: David Hildenbrand Acked-by: Christian Borntraeger > --- > hw/intc/s390_flic_kvm.c | 21 - > 1 file changed, 16 insertions(+), 5 deletions(-) >

Re: [Qemu-devel] [GSoC?] Board autoconfiguration based on DTB info

2018-01-25 Thread Stefan Hajnoczi
On Mon, Jan 22, 2018 at 05:59:00PM +, Peter Maydell wrote: > On 22 January 2018 at 17:52, Alexander Monakov wrote: > > Is it feasible to consume a DTB file in Qemu itself to make the board match > > the > > DeviceTree hardware description? For example on Arm there are quite a few > > .dts >

Re: [Qemu-devel] [PATCH v4 02/10] s390-ccw: refactor eckd_block_num to use CHS

2018-01-25 Thread Thomas Huth
On 23.01.2018 19:26, Collin L. Walling wrote: > Add new cylinder/head/sector struct. Use it to calculate > eckd block numbers instead of a BootMapPointer (which used > eckd chs anyway). > > Signed-off-by: Collin L. Walling > --- > pc-bios/s390-ccw/bootmap.c | 28 ++-- > p

Re: [Qemu-devel] [RFC PATCH 0/3] vfio: ccw: basic channel path event handling

2018-01-25 Thread Cornelia Huck
On Tue, 23 Jan 2018 14:23:56 +0800 Dong Jia Shi wrote: > * Halil Pasic [2018-01-16 16:57:13 +0100]: > > To give you a feeling of what I mean here some bullet points: > > * Channel paths are css level resources (simplified). > Yes, and it's the means for the machine to talk to the device. > >

Re: [Qemu-devel] [PATCH v4 02/10] s390-ccw: refactor eckd_block_num to use CHS

2018-01-25 Thread Cornelia Huck
On Thu, 25 Jan 2018 12:06:50 +0100 Thomas Huth wrote: > On 23.01.2018 19:26, Collin L. Walling wrote: > > Add new cylinder/head/sector struct. Use it to calculate > > eckd block numbers instead of a BootMapPointer (which used > > eckd chs anyway). > > > > Signed-off-by: Collin L. Walling > > --

Re: [Qemu-devel] [PATCH v3 41/45] hw/hppa: Implement DINO system board

2018-01-25 Thread Philippe Mathieu-Daudé
Hi Richard, Helge, On 01/24/2018 08:26 PM, Richard Henderson wrote: > From: Helge Deller > > Now that we have the prerequisites in target/hppa/, > implement the hardware for a PA7100LC. > > This also enables build for hppa-softmmu. > > Signed-off-by: Helge Deller > [rth: Since it is all new c

[Qemu-devel] [Bug 1745316] Re: SDL1.x>SDL2 regressions: non-usbtablet mouse position reporting is broken, and VGA/compatmonitor/serial/etc view switching is unusable

2018-01-25 Thread i336_
** Attachment added: "[File 1/2] SLS-based mouse tester (root HDD image) (see report for details)" https://bugs.launchpad.net/qemu/+bug/1745316/+attachment/5042704/+files/sls-mousetest.img.xz -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribe

[Qemu-devel] [Bug 1745312] [NEW] Regression report: Disk subsystem I/O failures/issues surfacing in DOS/early Windows [two separate issues: one bisected, one root-caused]

2018-01-25 Thread i336_
Public bug reported: [Headsup: This report is long-ish due to the amount of detail I've stumbled on along the way that I think is relevant to include. I can't speak as to the complexity of the actual bugs, but the size of this report should not suggest that the reproduction process is particularly

[Qemu-devel] [Bug 1745316] Re: SDL1.x>SDL2 regressions: non-usbtablet mouse position reporting is broken, and VGA/compatmonitor/serial/etc view switching is unusable

2018-01-25 Thread i336_
** Attachment added: "[File 2/2] SLS-based mouse tester (boot floppy image) (see report for details)" https://bugs.launchpad.net/qemu/+bug/1745316/+attachment/5042705/+files/sls-boot.img.xz -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

[Qemu-devel] [Bug 1737194] Re: Windows NT 4.0 fails to boot from qcow2 installation

2018-01-25 Thread i336_
Hi, I've been experiencing various disk I/O issues with Windows NT too, as well as with Windows 3.1. I think `-M isapc` may be to blame somehow. I've documented my experiences over at https://bugs.launchpad.net/qemu/+bug/1745312. That report contains information on how to lift out and build the

[Qemu-devel] [Bug 1745316] [NEW] SDL1.x>SDL2 regressions: non-usbtablet mouse position reporting is broken, and VGA/compatmonitor/serial/etc view switching is unusable

2018-01-25 Thread i336_
Public bug reported: Hi, I almost exclusively use -sdl when I use QEMU. The GTK UI (I'm on Linux) distinctly takes a few extra seconds to start on every boot, and I don't really ever use the extra controls it provides. I hope the SDL-based UI never goes away :) The SDL 1.2 > SDL 2.0 update (comm

Re: [Qemu-devel] [PATCH v5 2/3] xlnx-zynqmp-rtc: Add basic time support

2018-01-25 Thread Peter Maydell
On 23 January 2018 at 22:24, Alistair Francis wrote: > Allow the guest to determine the time set from the QEMU command line. > > This includes adding a trace event to debug the new time. > > Signed-off-by: Alistair Francis > --- > static const VMStateDescription vmstate_rtc = { > .name = TY

Re: [Qemu-devel] [PATCH] pl110: Implement vertical compare/next base interrupts

2018-01-25 Thread Peter Maydell
On 23 January 2018 at 22:56, Linus Walleij wrote: > This implements rudimentary support for interrupt generation on the > PL110. I am working on a new DRI/KMS driver for Linux and since that > uses the blanking interrupt, we need something to fire here. Without > any interrupt support Linux waits

Re: [Qemu-devel] [PULL 00/13] Linux user for 2.12 patches

2018-01-25 Thread Peter Maydell
On 23 January 2018 at 14:47, Laurent Vivier wrote: > The following changes since commit 52483b067cce4a88ffbf8fbeea26de7549d2ad23: > > Merge remote-tracking branch 'remotes/huth/tags/pull-request-2018-01-22' > into staging (2018-01-23 10:15:09 +) > > are available in the Git repository at: >

[Qemu-devel] [Bug 1745354] [NEW] CDOS ps/2 mouse problem

2018-01-25 Thread FARJON
Public bug reported: Qemu v2.10.2 (also tested with 2.11.0) Host OS : CentOS 7 x86_64 (1708) Guest OS : Concurrent DOS 386 3.0 (with GEM) There is my launch command : /usr/local/bin/qemu-system-i386 -m 4m -cpu 486 -hda /home/my_user/HDD.img -vga std When I'm launching the guest, it is not resp

Re: [Qemu-devel] [PATCH v4 03/10] s390-ccw: refactor IPL structs

2018-01-25 Thread Thomas Huth
On 23.01.2018 19:26, Collin L. Walling wrote: > ECKD DASDs have different IPL structures for CDL and LDL > formats. The current Ipl1 and Ipl2 structs follow the CDL > format, so we prepend "EckdCdl" to them. Boot info for LDL > has been moved to a new struct: EckdLdlIpl1. > > Also introduce struct

Re: [Qemu-devel] [Qemu-block] [RFC] block-backend: fix double inc/dec inflight requests number

2018-01-25 Thread Stefan Hajnoczi
On Mon, Jan 22, 2018 at 05:45:49PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Is it a bug or a feature? Why do we call inc/dec twice for read/write? > We don't do this for flush and discard.. It's non-obvious and I asked Paolo the same question previously. > -bdrv_inc_in_flight(bs); > - >

Re: [Qemu-devel] [Qemu-block] (v2. forward to qemu )-Panic with ext4, nbd, qemu-img, block

2018-01-25 Thread Stefan Hajnoczi
On Mon, Jan 22, 2018 at 10:06:26AM +0800, Hongzhi, Song wrote: > Hello, > > I create a virtual disk-image using qemu-img. > > And then I use /dev/nbd to map the image. > > I mount the /dev/nbd to a local dir with ext4-format > > Finally, I have some trouble about ext4-filesystem and block devic

Re: [Qemu-devel] [qemu-s390x] [PATCH v4 04/10] s390-ccw: update libc

2018-01-25 Thread Thomas Huth
On 23.01.2018 23:33, Collin L. Walling wrote: > On 01/23/2018 02:23 PM, Eric Blake wrote: >> On 01/23/2018 12:26 PM, Collin L. Walling wrote: >>> [...] >>> +/** >>> + * atoi: >>> + * @str: the string to be converted. >>> + * >>> + * Given a string @str, convert it to an integer. Leading whitespace

[Qemu-devel] [PATCH v4] chardev/char-socket: add POLLHUP handler

2018-01-25 Thread Klim Kireev
The following behavior was observed for QEMU configured by libvirt to use guest agent as usual for the guests without virtio-serial driver (Windows or the guest remaining in BIOS stage). In QEMU on first connect to listen character device socket the listen socket is removed from poll just after th

Re: [Qemu-devel] [PATCH v2 00/18] s390x: flic rework, tcg flic support and STSI

2018-01-25 Thread Cornelia Huck
On Wed, 17 Jan 2018 18:40:29 +0100 David Hildenbrand wrote: > This patch series implements floating interrupt support for TCG and fixes > STSI so we can remove warnings related to s390x SMP and MTTCG. > > KVM code has to be touched in order to factor out the injection routines > into the flic ("

Re: [Qemu-devel] [PATCH v4] chardev/char-socket: add POLLHUP handler

2018-01-25 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180125123955.4919-1-klim.kir...@virtuozzo.com Subject: [Qemu-devel] [PATCH v4] chardev/char-socket: add POLLHUP handler === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH v4] chardev/char-socket: add POLLHUP handler

2018-01-25 Thread Daniel P . Berrangé
On Thu, Jan 25, 2018 at 03:39:55PM +0300, Klim Kireev wrote: > The following behavior was observed for QEMU configured by libvirt > to use guest agent as usual for the guests without virtio-serial > driver (Windows or the guest remaining in BIOS stage). > > In QEMU on first connect to listen chara

Re: [Qemu-devel] [PATCH v2 00/18] s390x: flic rework, tcg flic support and STSI

2018-01-25 Thread Cornelia Huck
On Thu, 25 Jan 2018 13:42:41 +0100 Cornelia Huck wrote: > On Wed, 17 Jan 2018 18:40:29 +0100 > David Hildenbrand wrote: > > > This patch series implements floating interrupt support for TCG and fixes > > STSI so we can remove warnings related to s390x SMP and MTTCG. > > > > KVM code has to be

Re: [Qemu-devel] [PATCH v4] chardev/char-socket: add POLLHUP handler

2018-01-25 Thread Marc-André Lureau
Hi On Thu, Jan 25, 2018 at 1:39 PM, Klim Kireev wrote: > The following behavior was observed for QEMU configured by libvirt > to use guest agent as usual for the guests without virtio-serial > driver (Windows or the guest remaining in BIOS stage). > > In QEMU on first connect to listen character

Re: [Qemu-devel] [PULL] qemu-sparc updates

2018-01-25 Thread Peter Maydell
On 24 January 2018 at 19:58, Mark Cave-Ayland wrote: > Hi Peter, > > Here are the latest updates for SPARC. Please pull. > > > ATB, > > Mark. > > > The following changes since commit 52483b067cce4a88ffbf8fbeea26de7549d2ad23: > > Merge remote-tracking branch 'remotes/huth/tags/pull-request-2018-0

Re: [Qemu-devel] [RFC PATCH 0/3] vfio: ccw: basic channel path event handling

2018-01-25 Thread Halil Pasic
On 01/23/2018 07:23 AM, Dong Jia Shi wrote: > * Halil Pasic [2018-01-16 16:57:13 +0100]: > >> >> >> On 01/15/2018 09:59 AM, Dong Jia Shi wrote: >>> * Halil Pasic [2018-01-12 19:10:20 +0100]: >>> On 01/11/2018 04:04 AM, Dong Jia Shi wrote: > What are still missing, thus need

Re: [Qemu-devel] [PATCH v3 00/22] re-factor softfloat and add fp16 functions

2018-01-25 Thread Alex Bennée
Howard Spoelstra writes: > Hi, > > I built qemu-system-ppc for OSX and Windows from > https://github.com/stsquad/qemu/tree/softfloat-refactor-and-fp16-v3 > and noticed a considerable drop in floating point performance on both > hosts. > Running Mac OS 9.2 in OSX, using MacBench 3.0, the score fo

Re: [Qemu-devel] [PATCH v2 00/18] s390x: flic rework, tcg flic support and STSI

2018-01-25 Thread David Hildenbrand
On 25.01.2018 13:47, Cornelia Huck wrote: > On Thu, 25 Jan 2018 13:42:41 +0100 > Cornelia Huck wrote: > >> On Wed, 17 Jan 2018 18:40:29 +0100 >> David Hildenbrand wrote: >> >>> This patch series implements floating interrupt support for TCG and fixes >>> STSI so we can remove warnings related to

Re: [Qemu-devel] [PATCH v4 06/10] s390-ccw: set up interactive boot menu parameters

2018-01-25 Thread Thomas Huth
On 23.01.2018 19:26, Collin L. Walling wrote: > Reads boot menu flag and timeout values from the iplb and > sets the respective fields for the menu. > > Signed-off-by: Collin L. Walling > --- > pc-bios/s390-ccw/Makefile | 2 +- > pc-bios/s390-ccw/iplb.h | 3 +++ > pc-bios/s390-ccw/main.c |

Re: [Qemu-devel] [PATCH v2 00/18] s390x: flic rework, tcg flic support and STSI

2018-01-25 Thread Thomas Huth
On 25.01.2018 14:11, David Hildenbrand wrote: > On 25.01.2018 13:47, Cornelia Huck wrote: >> On Thu, 25 Jan 2018 13:42:41 +0100 >> Cornelia Huck wrote: >> >>> On Wed, 17 Jan 2018 18:40:29 +0100 >>> David Hildenbrand wrote: >>> This patch series implements floating interrupt support for TCG a

Re: [Qemu-devel] [PATCH v2 12/18] s390x: fix size + content of STSI blocks

2018-01-25 Thread David Hildenbrand
On 25.01.2018 11:26, Cornelia Huck wrote: > On Wed, 17 Jan 2018 18:40:41 +0100 > David Hildenbrand wrote: > >> All blocks are 4k in size, which is only true for two of them right now. >> Also some reserved fields were wrong, fix it and convert all reserved >> fields to u8. >> >> This also fixes t

[Qemu-devel] [PATCH v2] linux-user: Implement ioctl cmd TIOCGPTPEER

2018-01-25 Thread Andreas Schwab
With glibc 2.27 the openpty function will prefer the TIOCGPTPEER ioctl. Signed-off-by: Andreas Schwab --- v2: handle host with old kernel headers --- linux-user/aarch64/termbits.h| 2 ++ linux-user/alpha/termbits.h | 1 + linux-user/arm/termbits.h| 1 + linux-user/cris/termbits.

Re: [Qemu-devel] [PATCH v4] chardev/char-socket: add POLLHUP handler

2018-01-25 Thread Paolo Bonzini
On 25/01/2018 13:45, Daniel P. Berrangé wrote: >> index e54388015a..558cd81bdd 16 >> --- a/dtc >> +++ b/dtc >> @@ -1 +1 @@ >> -Subproject commit e54388015af1fb4bf04d0bca99caba1074d9cc42 >> +Subproject commit 558cd81bdd432769b59bff01240c44f82cfb1a9d > Presumably accidental. You can fix this by d

[Qemu-devel] [PULL 09/21] vmstate: Add VMSTATE_UINT64_SUB_ARRAY

2018-01-25 Thread Peter Maydell
From: Richard Henderson At the same time, move VMSTATE_UINT32_SUB_ARRAY beside the other UINT32 definitions. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20180119045438.28582-8-richard.hender...@linaro.org Reviewed-by: Alex Bennée

[Qemu-devel] [PULL 06/21] target/arm: Use pointers in neon tbl helper

2018-01-25 Thread Peter Maydell
From: Richard Henderson Rather than passing a regno to the helper, pass pointers to the vector register directly. This eliminates the need to pass in the environment pointer and reduces the number of places that directly access env->vfp.regs[]. Reviewed-by: Peter Maydell Signed-off-by: Richard

[Qemu-devel] [PULL 10/21] target/arm: Add ARM_FEATURE_SVE

2018-01-25 Thread Peter Maydell
From: Richard Henderson Not enabled anywhere so far. Signed-off-by: Richard Henderson Message-id: 20180119045438.28582-11-richard.hender...@linaro.org Reviewed-by: Peter Maydell Reviewed-by: Alex Bennée Signed-off-by: Peter Maydell --- target/arm/cpu.h | 1 + 1 file changed, 1 insertion(+)

[Qemu-devel] [PULL 08/21] target/arm: Add aa{32, 64}_vfp_{dreg, qreg} helpers

2018-01-25 Thread Peter Maydell
From: Richard Henderson Helpers that return a pointer into env->vfp.regs so that we isolate the logic of how to index the regs array for different cpu modes. Signed-off-by: Richard Henderson Message-id: 20180119045438.28582-7-richard.hender...@linaro.org Reviewed-by: Alex Bennée Signed-off-by:

[Qemu-devel] [PULL 07/21] target/arm: Change the type of vfp.regs

2018-01-25 Thread Peter Maydell
From: Richard Henderson All direct users of this field want an integral value. Drop all of the extra casting between uint64_t and float64. Signed-off-by: Richard Henderson Message-id: 20180119045438.28582-6-richard.hender...@linaro.org Reviewed-by: Alex Bennée Signed-off-by: Peter Maydell --

[Qemu-devel] [PULL 13/21] target/arm: Simplify fp_exception_el for user-only

2018-01-25 Thread Peter Maydell
From: Richard Henderson Signed-off-by: Richard Henderson Message-id: 20180119045438.28582-16-richard.hender...@linaro.org Reviewed-by: Peter Maydell Reviewed-by: Alex Bennée Signed-off-by: Peter Maydell --- target/arm/helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --g

[Qemu-devel] [PULL 18/21] hw/arm/virt: Check that the CPU realize method succeeded

2018-01-25 Thread Peter Maydell
We were passing a NULL error pointer to the object_property_set_bool() call that realizes the CPU object. This meant that we wouldn't detect failure, and would plough blindly on to crash later trying to use a NULL CPU object pointer. Detect errors and fail instead. In particular, this will be nece

[Qemu-devel] [PULL 19/21] sdhci: fix a NULL pointer dereference due to uninitialized AddresSpace object

2018-01-25 Thread Peter Maydell
From: Philippe Mathieu-Daudé missed in 60765b6ceeb4. Thread 1 "qemu-system-aarch64" received signal SIGSEGV, Segmentation fault. address_space_init (as=0x0, root=0x5726e410, name=name@entry=0x55e3f0a7 "sdhci-dma") at memory.c:3050 3050 as->root = root; (gdb) bt #0 addres

[Qemu-devel] [PULL 00/21] target-arm queue

2018-01-25 Thread Peter Maydell
r-for-2.12-pull-request' into staging (2018-01-25 09:53:53 +) are available in the git repository at: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20180125 for you to fetch changes up to 24da047af0e99a83fcc0d50b86c0f2627f7418b3: pl110: Implement vertic

[Qemu-devel] [PULL 01/21] target/arm: Fix 32-bit address truncation

2018-01-25 Thread Peter Maydell
From: Ard Biesheuvel Commit ("3b39d734141a target/arm: Handle page table walk load failures correctly") modified both versions of the page table walking code (i.e., arm_ldl_ptw and arm_ldq_ptw) to record the result of the translation in a temporary 'data' variable so that it can be inspected befo

[Qemu-devel] [PULL 21/21] pl110: Implement vertical compare/next base interrupts

2018-01-25 Thread Peter Maydell
From: Linus Walleij This implements rudimentary support for interrupt generation on the PL110. I am working on a new DRI/KMS driver for Linux and since that uses the blanking interrupt, we need something to fire here. Without any interrupt support Linux waits for a while and then gives ugly messa

[Qemu-devel] [PULL 11/21] target/arm: Move cpu_get_tb_cpu_state out of line

2018-01-25 Thread Peter Maydell
From: Richard Henderson Signed-off-by: Richard Henderson Message-id: 20180119045438.28582-14-richard.hender...@linaro.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- target/arm/cpu.h| 127 +--- target/arm/helper.c | 126 +

[Qemu-devel] [PULL 02/21] i.MX: Fix FEC/ENET receive funtions

2018-01-25 Thread Peter Maydell
From: Jean-Christophe Dubois The actual imx_eth_enable_rx() function is buggy. It updates s->regs[ENET_RDAR] after calling qemu_flush_queued_packets(). qemu_flush_queued_packets() is going to call imx_XXX_receive() which itself is going to call imx_eth_enable_rx(). By updating s->regs[ENET_RDA

Re: [Qemu-devel] [PULL] qemu-sparc updates

2018-01-25 Thread Mark Cave-Ayland
On 25/01/18 12:51, Peter Maydell wrote: On 24 January 2018 at 19:58, Mark Cave-Ayland wrote: Hi Peter, Here are the latest updates for SPARC. Please pull. ATB, Mark. The following changes since commit 52483b067cce4a88ffbf8fbeea26de7549d2ad23: Merge remote-tracking branch 'remotes/hut

Re: [Qemu-devel] [PATCH qemu] vfio/common: Remove redundand copy of local variable

2018-01-25 Thread Auger Eric
Hi,On 25/01/18 05:14, Alexey Kardashevskiy wrote: > There is already @hostwin in vfio_listener_region_add() so there is no > point in having the other one. > > Fixes: 2e4109de "vfio/spapr: Create DMA window dynamically (SPAPR IOMMU v2)" > Signed-off-by: Alexey Kardashevskiy Reviewed-by: Eric Auge

[Qemu-devel] [PULL 16/21] hw/intc/arm_gic: Fix group priority computation for group 1 IRQs

2018-01-25 Thread Peter Maydell
From: Luc MICHEL When determining the group priority of a group 1 IRQ, if C_CTRL.CBPR is 0, the non-secure BPR value is used. However, this value must be incremented by one so that it matches the secure world number of implemented priority bits (NS world has one less priority bit compared to the

[Qemu-devel] [PULL 12/21] target/arm: Hoist store to flags output in cpu_get_tb_cpu_state

2018-01-25 Thread Peter Maydell
From: Richard Henderson Signed-off-by: Richard Henderson Message-id: 20180119045438.28582-15-richard.hender...@linaro.org Reviewed-by: Peter Maydell Reviewed-by: Alex Bennée Signed-off-by: Peter Maydell --- target/arm/helper.c | 35 +++ 1 file changed, 19 inse

[Qemu-devel] [PATCH v5] chardev/char-socket: add POLLHUP handler

2018-01-25 Thread Klim Kireev
The following behavior was observed for QEMU configured by libvirt to use guest agent as usual for the guests without virtio-serial driver (Windows or the guest remaining in BIOS stage). In QEMU on first connect to listen character device socket the listen socket is removed from poll just after th

Re: [Qemu-devel] [PATCH qemu v4] RFC: vfio-pci: Allow mmap of MSIX BAR

2018-01-25 Thread Auger Eric
Hi Alexey, On 25/01/18 05:22, Alexey Kardashevskiy wrote: > This makes use of a new VFIO_REGION_INFO_CAP_MSIX_MAPPABLE capability > which tells that a region with MSIX data can be mapped entirely, i.e. > the VFIO PCI driver won't prevent MSIX vectors area from being mapped. > > With this change,

[Qemu-devel] [PULL 03/21] target/arm: Mark disas_set_insn_syndrome inline

2018-01-25 Thread Peter Maydell
From: Richard Henderson If it isn't used when translate.h is included, we'll get a compiler Werror. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée Message-id: 20180119045438.28582-2-richard.hender...@linaro.org Signed-

[Qemu-devel] [PULL 05/21] target/arm: Use pointers in neon zip/uzp helpers

2018-01-25 Thread Peter Maydell
From: Richard Henderson Rather than passing regnos to the helpers, pass pointers to the vector registers directly. This eliminates the need to pass in the environment pointer and reduces the number of places that directly access env->vfp.regs[]. Reviewed-by: Peter Maydell Signed-off-by: Richar

[Qemu-devel] [PULL 15/21] hw/intc/arm_gic: Fix C_RPR value on idle priority

2018-01-25 Thread Peter Maydell
From: Luc MICHEL When there is no active interrupts in the GIC, a read to the C_RPR register should return the value of the "Idle priority", which is either the maximum value an IRQ priority field can be set to, or 0xff. Since the QEMU GIC model implements all the 8 priority bits, the Idle prior

[Qemu-devel] [PULL 17/21] hw/intc/arm_gic: Fix the NS view of C_BPR when C_CTRL.CBPR is 1

2018-01-25 Thread Peter Maydell
From: Luc MICHEL When C_CTRL.CBPR is 1, the Non-Secure view of C_BPR is altered: - A Non-Secure read of C_BPR should return the BPR value plus 1, saturated to 7, - A Non-Secure write should be ignored. Signed-off-by: Luc MICHEL Message-id: 20180119145756.7629-6-luc.mic...@greensocs.com Re

[Qemu-devel] [PULL 04/21] target/arm: Use pointers in crypto helpers

2018-01-25 Thread Peter Maydell
From: Richard Henderson Rather than passing regnos to the helpers, pass pointers to the vector registers directly. This eliminates the need to pass in the environment pointer and reduces the number of places that directly access env->vfp.regs[]. Reviewed-by: Peter Maydell Signed-off-by: Richar

Re: [Qemu-devel] [PATCH V4 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

2018-01-25 Thread Deniz Eren
Hi Pavel, Philippe, I’m happy with whatever way is best for the project. However I would personally think merging the different drivers into one C file would not be a very modular way of handling the problem. As you can see from the Advantech drivers for example, the card supplier end can pose

[Qemu-devel] [PULL 14/21] hw/intc/arm_gic: Prevent the GIC from signaling an IRQ when it's "active and pending"

2018-01-25 Thread Peter Maydell
From: Luc MICHEL In the GIC, when an IRQ is acknowledged, its state goes from "pending" to: - "active" if the corresponding IRQ pin has been de-asserted - "active and pending" otherwise. The GICv2 manual states that when a IRQ becomes active (or active and pending), the GIC should either si

Re: [Qemu-devel] [PULL 00/14] Block and docker patches

2018-01-25 Thread Peter Maydell
On 25 January 2018 at 05:46, Fam Zheng wrote: > The following changes since commit 834a336eb911db8a8ca00e760ee6a85faca19414: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2018-01-24 19:24:26 +) > > are available in the Git repository at: > > git://github

[Qemu-devel] [PULL 20/21] xilinx_spips: Correct usage of an uninitialized local variable

2018-01-25 Thread Peter Maydell
From: Francisco Iglesias Coverity found that the variable tx_rx in the function xilinx_spips_flush_txfifo was being used uninitialized (CID 1383841). This patch corrects this by always initializing tx_rx to zeros. Signed-off-by: Francisco Iglesias Message-id: 20180124215708.30400-1-frasse.igles

Re: [Qemu-devel] [PATCH V4 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

2018-01-25 Thread Paolo Bonzini
On 23/01/2018 22:42, Pavel Pisa wrote: > Do you think QOM based? I would like it to be implemented > that way but I need some assistance where to look how this > object kind should be implemented and from which base object > inherit from. But I prefer to left that for later work. > > I would defin

Re: [Qemu-devel] Functional tests (AKA Avocado-based tests)

2018-01-25 Thread Stefan Hajnoczi
On Wed, Jan 17, 2018 at 03:05:54AM -0500, Cleber Rosa wrote: > This is about how QEMU developers can get started with functional > tests that are built on top of the Avocado libraries (and meant to be > run with the Avocado test runner). Here is my guess at where this fits into QEMU's testing land

Re: [Qemu-devel] [RFC 0/2] virtio-vhost-user: add virtio-vhost-user device

2018-01-25 Thread Paolo Bonzini
On 23/01/2018 17:07, Michael S. Tsirkin wrote: >> It's not clear to me how to do this. E.g need a way to report failure to VM2 >> or #PF? > > Why would there be a failure? qemu running vm1 would be responsible for > preventing access to vm2's memory not mapped through an IOMMU. > Basically munmap

Re: [Qemu-devel] [PULL 00/14] Block and docker patches

2018-01-25 Thread Fam Zheng
On Thu, Jan 25, 2018 at 9:51 PM, Peter Maydell wrote: > On 25 January 2018 at 05:46, Fam Zheng wrote: >> The following changes since commit 834a336eb911db8a8ca00e760ee6a85faca19414: >> >> Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging >> (2018-01-24 19:24:26 +) >

Re: [Qemu-devel] [PATCH v2 12/18] s390x: fix size + content of STSI blocks

2018-01-25 Thread Cornelia Huck
On Thu, 25 Jan 2018 14:15:45 +0100 David Hildenbrand wrote: > On 25.01.2018 11:26, Cornelia Huck wrote: > > On Wed, 17 Jan 2018 18:40:41 +0100 > > David Hildenbrand wrote: > > > >> All blocks are 4k in size, which is only true for two of them right now. > >> Also some reserved fields were wro

Re: [Qemu-devel] [PULL 00/21] target-arm queue

2018-01-25 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1516887809-6265-1-git-send-email-peter.mayd...@linaro.org Subject: [Qemu-devel] [PULL 00/21] target-arm queue === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git

Re: [Qemu-devel] [PATCH v1 0/6] Extend vhost-user to support VFIO based accelerators

2018-01-25 Thread Stefan Hajnoczi
On Thu, Jan 25, 2018 at 12:03:22PM +0800, Tiwei Bie wrote: > Why extend vhost-user for vDPA > == > > We have already implemented various virtual switches (e.g. OVS-DPDK) > based on vhost-user for VMs in the Cloud. They are purely software > running on CPU cores. When we

Re: [Qemu-devel] [PATCH v3] xilinx_spips: Correct usage of an uninitialized local variable

2018-01-25 Thread francisco iglesias
On Thursday, 25 January 2018, Peter Maydell wrote: > On 24 January 2018 at 21:57, Francisco Iglesias > wrote: > > Coverity found that the variable tx_rx in the function > > xilinx_spips_flush_txfifo was being used uninitialized (CID 1383841). > This > > patch corrects this by always initializing

[Qemu-devel] [PULL 7/8] sdl: use ctrl-alt-g as grab hotkey

2018-01-25 Thread Gerd Hoffmann
Be consistent with gtk and cocoa. Signed-off-by: Gerd Hoffmann Message-id: 20180115154855.30850-2-kra...@redhat.com --- ui/sdl.c | 30 +- ui/sdl2.c | 27 +++ 2 files changed, 24 insertions(+), 33 deletions(-) diff --git a/ui/sdl.c b/ui/sdl.c

[Qemu-devel] [PULL 8/8] sdl: reorganize -no-frame support

2018-01-25 Thread Gerd Hoffmann
Drop no_frame flag from sdl_display_init argument list, use a global variable instead. This is temporary until -no-frame support is dropped altogether when we remove sdl1 support. Remove any traces of noframe from sdl2 code. It is just dead code as sdl2 doesn't support the SDL_NOFRAME window fla

Re: [Qemu-devel] [RFC] qid path collision issues in 9pfs

2018-01-25 Thread Veaceslav Falico
Hi, sorry for the late reply, we're acutally working on it internally... On 1/19/2018 7:05 PM, Greg Kurz wrote: > On Fri, 19 Jan 2018 17:37:58 +0100 > Veaceslav Falico wrote: > >> On 1/19/2018 4:52 PM, Eduard Shishkin wrote: >>> >>> >>> On 1/19/2018 11:27 AM, Greg Kurz wrote: On Mon, 15

[Qemu-devel] [PULL 2/8] ui: convert the SDL2 frontend to keycodemapdb

2018-01-25 Thread Gerd Hoffmann
From: "Daniel P. Berrange" The SDL2 scancodes are conveniently identical to the USB scancodes. Replace the sdl2_scancode_to_qcode table with an automatically generated table. Missing entries in sdl2_scancode_to_qcode now fixed: - 0x32 -> Q_KEY_CODE_BACKSLASH - 0x66 -> Q_KEY_CODE_POWER - 0

  1   2   3   >