Re: [Qemu-devel] [Qemu-ppc] [QEMU-PPC] [PATCH V3 6/6] target/ppc/spapr: Add H-Call H_GET_CPU_CHARACTERISTICS

2018-01-18 Thread Alexey Kardashevskiy
On 18/01/18 16:53, David Gibson wrote: > On Thu, Jan 18, 2018 at 04:44:28PM +1100, Alexey Kardashevskiy wrote: >> On 18/01/18 16:20, David Gibson wrote: >>> On Mon, Jan 15, 2018 at 05:32:35PM +1100, Suraj Jitindar Singh wrote: The new H-Call H_GET_CPU_CHARACTERISTICS is used by the guest to qu

Re: [Qemu-devel] [PATCH 3/3] target/ppc: add support for hypervisor doorbells on book3s CPUs

2018-01-18 Thread Cédric Le Goater
On 01/18/2018 05:15 AM, David Gibson wrote: > On Tue, Jan 16, 2018 at 08:41:57AM +0100, Cédric Le Goater wrote: >> The hypervisor doorbells are used by skiboot and Linux on POWER9 >> processors to wake up secondaries. >> >> This adds processor control support to the Server architecture by >> reusin

Re: [Qemu-devel] [PATCH qemu 0/3] spapr/iommu: Enable in-kernel TCE acceleration via VFIO KVM device

2018-01-18 Thread Paolo Bonzini
On 16/01/2018 21:46, Alex Williamson wrote: > On Mon, 15 Jan 2018 15:12:07 +1100 > Alexey Kardashevskiy wrote: > >> On 03/01/18 04:51, Paolo Bonzini wrote: >>> On 02/01/2018 06:28, Alexey Kardashevskiy wrote: This is my current queue of the in-kernel TCE acceleration enablement.

Re: [Qemu-devel] [PATCH 0/4] Implements the Windows Hypervisor Platform accelerator

2018-01-18 Thread Paolo Bonzini
On 18/01/2018 00:41, Justin Terry (VM) wrote: > > Thanks for all the feedback. After talking with various members of > the team around these scenarios I think its best we add the migration > blockers for all of your comments unfortunately. The answers to your > question are below: > > 1. For CPUI

Re: [Qemu-devel] [PATCH] scsi-generic: Simplify error handling code

2018-01-18 Thread Paolo Bonzini
On 18/01/2018 03:52, Fam Zheng wrote: > Coverity doesn't like the ignored return value introduced in > 9d3b155186c278 (hw/block: Fix the return type), and other callers are > converted already in ceff3e1f01. > > This one was added lately in d9bcd6f7f23a and missed the train. Do it > now. > > Sign

Re: [Qemu-devel] [PATCH] chardev: fix incorrect unref of source

2018-01-18 Thread Paolo Bonzini
On 18/01/2018 06:20, Peter Xu wrote: > glib reported error when pty chardev used: > > $ ./qemu-system-x86_64 -chardev pty,id=foo -device isa-serial,chardev=foo > qemu-system-x86_64: -chardev pty,id=foo: char device redirected to /dev/pts/2 > (label foo) > (qemu-system-x86_64:27885): GLib-CRITICAL

Re: [Qemu-devel] [PATCH v9 03/13] block/dirty-bitmap: add _locked version of bdrv_reclaim_dirty_bitmap

2018-01-18 Thread Paolo Bonzini
On 29/12/2017 02:31, Fam Zheng wrote: >> we have the following comment: >> >>     /* Writing to the list requires the BQL _and_ the dirty_bitmap_mutex. >> * Reading from the list can be done with either the BQL or the >> * dirty_bitmap_mutex.  Modifying a bitmap only requires >> * di

[Qemu-devel] [PATCH] hw/char: remove legacy interface escc_init()

2018-01-18 Thread Laurent Vivier
Move necessary stuff in escc.h and update type names. Remove slavio_serial_ms_kbd_init(). Fix code style problems reported by checkpatch.pl Update mac_newworld, mac_oldworld and sun4m to use directly the QDEV interface. Signed-off-by: Laurent Vivier --- hw/char/escc.c | 208 +

[Qemu-devel] [PATCH v3 3/3] s390x/kvm: provide stfle.81

2018-01-18 Thread Christian Borntraeger
stfle.81 (ppa15) is a transparent facility that can be passed to the guest without the need to implement hypervisor support. As this feature can be provided by firmware we add it to all full models. Signed-off-by: Christian Borntraeger --- target/s390x/cpu_features.c | 1 + target/s390x/cpu_

[Qemu-devel] [PATCH v3 1/3] header sync

2018-01-18 Thread Christian Borntraeger
replace with proper header sync Signed-off-by: Christian Borntraeger --- linux-headers/asm-s390/kvm.h | 9 - linux-headers/linux/kvm.h| 5 +++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/linux-headers/asm-s390/kvm.h b/linux-headers/asm-s390/kvm.h index 32d372e..1

[Qemu-devel] [PATCH v3 0/3] s390x/kvm: implement new hardware/firmware features

2018-01-18 Thread Christian Borntraeger
We want to provide more hw features to guests, namely the new bpb control as well as other transparent facilities that might be introduced by firmware updates (e.g. the stfle facility 81). See the kernel discussion for the KVM side https://www.spinics.net/lists/kernel/msg2700551.html v2->v3: - us

[Qemu-devel] [PATCH v3 2/3] s390x/kvm: Handle bpb feature

2018-01-18 Thread Christian Borntraeger
We need to handle the bpb control on reset and migration. Normally stfle.82 is transparent (and the normal guest part works without hypervisor activity). To prevent any issues we require full host kernel support for this feature. Signed-off-by: Christian Borntraeger --- target/s390x/cpu.c

Re: [Qemu-devel] Functional tests (AKA Avocado-based tests)

2018-01-18 Thread Amador Pahim
On Thu, Jan 18, 2018 at 1:47 AM, Cleber Rosa wrote: > > > On 01/17/2018 06:41 PM, Alistair Francis wrote: >> On Wed, Jan 17, 2018 at 12:05 AM, Cleber Rosa wrote: >>> TL;DR >>> = >>> >>> This is about how QEMU developers can get started with functional >>> tests that are built on top of the Av

Re: [Qemu-devel] Functional tests (AKA Avocado-based tests)

2018-01-18 Thread Lukáš Doktor
Dne 18.1.2018 v 00:41 Alistair Francis napsal(a): > On Wed, Jan 17, 2018 at 12:05 AM, Cleber Rosa wrote: >> TL;DR >> = >> >> This is about how QEMU developers can get started with functional >> tests that are built on top of the Avocado libraries (and meant to be >> run with the Avocado test r

Re: [Qemu-devel] [PATCH for-2.11] vfio: Fix vfio-kvm group registration

2018-01-18 Thread Alexey Kardashevskiy
On 06/12/17 12:30, Alex Williamson wrote: > On Wed, 6 Dec 2017 12:02:01 +1100 > Alexey Kardashevskiy wrote: > >> On 06/12/17 08:09, Alex Williamson wrote: >>> Commit 8c37faa475f3 ("vfio-pci, ppc64/spapr: Reorder group-to-container >>> attaching") moved registration of groups with the vfio-kvm dev

[Qemu-devel] [Bug 1744009] [NEW] qemu for windows fails to use multicast socket as netdev

2018-01-18 Thread qihaimou
Public bug reported: My host OS is Windows 7 x64 SP1. I installed qemu for windows from https://qemu.weilnetz.de/w64/.The version is 2.10.1, qemu-w64-setup-20171006.exe. I run qemu with the following command: qemu-system-x86_64.exe -net nic -net socket,mcast=234.5.5.5:6000 disk1.qcow2 It stopped

Re: [Qemu-devel] [PATCH] chardev/char-socket: add POLLHUP handler

2018-01-18 Thread klim
On 01/16/2018 08:25 PM, Paolo Bonzini wrote: On 10/01/2018 14:18, Klim Kireev wrote: The following behavior was observed for QEMU configured by libvirt to use guest agent as usual for the guests without virtio-serial driver (Windows or the guest remaining in BIOS stage). In QEMU on first connec

Re: [Qemu-devel] [PATCH] chardev/char-socket: add POLLHUP handler

2018-01-18 Thread Paolo Bonzini
On 18/01/2018 10:41, klim wrote: >>> >>> I propose to install a separate pullhup watcher regardless of >>> whether the device waits for data or not. After closing the connection, >>> the guest has a capability to read the data within timeout. >> I don't understand the timeout part. > The timeout is

[Qemu-devel] [Bug 1744009] Re: qemu for windows fails to use multicast socket as netdev

2018-01-18 Thread qihaimou
When I checked the source code, I think the problem is that on Microsoft Windows bind() can not use a multicast address. MSDN bind() reference https://msdn.microsoft.com/en-us/library/windows/desktop/ms737550(v=vs.85).aspx seems to have indicated the point. I changed the net_socket_mcast_create()

Re: [Qemu-devel] [PATCH] chardev/char-socket: add POLLHUP handler

2018-01-18 Thread klim
On 01/18/2018 12:44 PM, Paolo Bonzini wrote: On 18/01/2018 10:41, klim wrote: I propose to install a separate pullhup watcher regardless of whether the device waits for data or not. After closing the connection, the guest has a capability to read the data within timeout. I don't understand the

Re: [Qemu-devel] [PATCH v9 03/13] block/dirty-bitmap: add _locked version of bdrv_reclaim_dirty_bitmap

2018-01-18 Thread Vladimir Sementsov-Ogievskiy
18.01.2018 11:43, Paolo Bonzini wrote: On 29/12/2017 02:31, Fam Zheng wrote: we have the following comment:     /* Writing to the list requires the BQL _and_ the dirty_bitmap_mutex. * Reading from the list can be done with either the BQL or the * dirty_bitmap_mutex.  Modifying a bi

Re: [Qemu-devel] [PATCH v9 13/13] iotests: add dirty bitmap postcopy test

2018-01-18 Thread Vladimir Sementsov-Ogievskiy
17.01.2018 21:30, John Snow wrote: On 12/28/2017 06:49 AM, Vladimir Sementsov-Ogievskiy wrote: Thank you for reviewing my code! Time for the re-spin? There's pretty good pressure to get this into 2.12 and say the non-nbd workflow model is feature complete. Yes, you are right. Hope to do it

Re: [Qemu-devel] [PATCH] chardev/char-socket: add POLLHUP handler

2018-01-18 Thread Daniel P. Berrange
On Thu, Jan 18, 2018 at 12:41:08PM +0300, klim wrote: > On 01/16/2018 08:25 PM, Paolo Bonzini wrote: > > On 10/01/2018 14:18, Klim Kireev wrote: > > > The following behavior was observed for QEMU configured by libvirt > > > to use guest agent as usual for the guests without virtio-serial > > > driv

Re: [Qemu-devel] [PULL v2 00/34] pc, pci, virtio: features, fixes, cleanups

2018-01-18 Thread Peter Maydell
On 16 January 2018 at 17:46, Michael S. Tsirkin wrote: > > Changes from v1: > 32 build fix > vhost-user-blk build fix > s390 qom fix > include mem slot limit fix > > The following changes since commit f5213bd060b460c99e605472b7e03967db43: > > Merge remote-tracking branch 'rem

Re: [Qemu-devel] [PATCH v9 03/13] block/dirty-bitmap: add _locked version of bdrv_reclaim_dirty_bitmap

2018-01-18 Thread Paolo Bonzini
On 18/01/2018 10:55, Vladimir Sementsov-Ogievskiy wrote: >> >> Most functions that looks at the list are "called with BQL taken". >> Functions that write to the list are "called with BQL taken" and call >> bdrv_dirty_bitmaps_lock/bdrv_dirty_bitmaps_unlock themselves. > > Paolo, could you please ex

Re: [Qemu-devel] [PATCH 20/24] machine: drop MachineState::cpu_model

2018-01-18 Thread Igor Mammedov
On Wed, 17 Jan 2018 23:48:46 -0200 Eduardo Habkost wrote: > On Wed, Jan 17, 2018 at 04:43:32PM +0100, Igor Mammedov wrote: > > The last user of it was machine type 'none', which used field > > to create CPU id user requested it on CLI with -cpu option. > > > > We could compare pointers of Machin

[Qemu-devel] [PATCH] block: implement the bdrv_reopen_prepare helper for LUKS driver

2018-01-18 Thread Daniel P. Berrange
If the bdrv_reopen_prepare helper isn't provided, the qemu-img commit command fails to re-open the base layer after committing changes into it. Provide a no-op implementation for the LUKS driver, since there is not any custom work that needs doing to re-open it. Signed-off-by: Daniel P. Berrange

Re: [Qemu-devel] [PATCH] block: add block_set_io_throttle virtio-blk-pci QMP example

2018-01-18 Thread Stefan Hajnoczi
On Wed, Jan 17, 2018 at 09:07:00AM +, Stefan Hajnoczi wrote: > The block_set_io_throttle command can look up BlockBackends by the > attached qdev device ID. virtio-blk-pci is a special case because the > actual VirtIOBlock device is the "/virtio-backend" child of the PCI > adapter device. > >

[Qemu-devel] Do I need update the microcode of virtual machine

2018-01-18 Thread Li Qiang
Hi Paolo, all, I have a question about the intel microcode update for spectre variant#2. >From my understanding, there is no need to update the microcode of VMs because the kvm has expose the SPEC_CTL and PRED_CMD to the guest. Also, if we need to update the micorcode in guest, who is the vendor f

[Qemu-devel] [PATCH] readline: don't free completions in readline_free()

2018-01-18 Thread Greg Kurz
Since commit e5dc1a6c6c43, QEMU aborts on exit if completion was used in the monitor: *** Error in `obj/ppc64-softmmu/qemu-system-ppc64': double free or corruption (fasttop): 0x0100331069d0 *** #0 0x7267eff0 in raise () from /lib64/libc.so.6 #1 0x7268136c in abort () from /

Re: [Qemu-devel] Do I need update the microcode of virtual machine

2018-01-18 Thread Paolo Bonzini
On 18/01/2018 11:38, Li Qiang wrote: > Hi Paolo, all, > > I have a question about the intel microcode update for spectre variant#2. > From my understanding, there is no need to update the microcode of VMs > because the kvm has expose the SPEC_CTL and PRED_CMD to the guest. > Also, if we need to up

Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4)

2018-01-18 Thread Igor Mammedov
On Wed, 17 Jan 2018 20:30:14 + Peter Maydell wrote: > On 17 January 2018 at 19:15, Igor Mammedov wrote: > > On Wed, 17 Jan 2018 16:12:09 + > > Peter Maydell wrote: > >> I like moving this from being an ifdef ladder into per-cpu > >> code, but I don't think the definition belongs in ta

Re: [Qemu-devel] [PATCH] readline: don't free completions in readline_free()

2018-01-18 Thread Paolo Bonzini
On 18/01/2018 11:41, Greg Kurz wrote: > Since commit e5dc1a6c6c43, QEMU aborts on exit if completion was used > in the monitor: > > *** Error in `obj/ppc64-softmmu/qemu-system-ppc64': double free or > corruption (fasttop): 0x0100331069d0 *** > > #0 0x7267eff0 in raise () from /lib64

Re: [Qemu-devel] Do I need update the microcode of virtual machine

2018-01-18 Thread Li Qiang
2018-01-18 18:43 GMT+08:00 Paolo Bonzini : > On 18/01/2018 11:38, Li Qiang wrote: > > Hi Paolo, all, > > > > I have a question about the intel microcode update for spectre variant#2. > > From my understanding, there is no need to update the microcode of VMs > > because the kvm has expose the SPEC_

Re: [Qemu-devel] Do I need update the microcode of virtual machine

2018-01-18 Thread Daniel P. Berrange
On Thu, Jan 18, 2018 at 06:38:57PM +0800, Li Qiang wrote: > Hi Paolo, all, > > I have a question about the intel microcode update for spectre variant#2. > From my understanding, there is no need to update the microcode of VMs > because the kvm has expose the SPEC_CTL and PRED_CMD to the guest. > A

Re: [Qemu-devel] Do I need update the microcode of virtual machine

2018-01-18 Thread Paolo Bonzini
On 18/01/2018 11:48, Li Qiang wrote: > > > But upon I update the centos guest, the host kvm/qemu has been updated. > > The IBPB_ENABLED and IBRS_ENABLED are both zero if I don't update the > > microcode in the guest. If I update the guest micorcode, the are both 1. > > What do you

Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4)

2018-01-18 Thread Peter Maydell
On 18 January 2018 at 10:43, Igor Mammedov wrote: > Peter Maydell wrote: >> That usage must want a different name, though, surely? >> For Arm the default CPU for linux-user is 'any' but that >> is usermode only and won't work for system emulation so >> null-machine.c will need to pick something e

Re: [Qemu-devel] vhost-pci and virtio-vhost-user

2018-01-18 Thread Stefan Hajnoczi
On Tue, Jan 16, 2018 at 01:41:37PM +0800, Jason Wang wrote: > > > On 2018年01月15日 21:56, Stefan Hajnoczi wrote: > > On Mon, Jan 15, 2018 at 02:56:31PM +0800, Jason Wang wrote: > > > On 2018年01月12日 18:18, Stefan Hajnoczi wrote: > > > > > And what's more important, according to the kvm 2016 slides o

Re: [Qemu-devel] [PATCH v3 3/3] s390x/kvm: provide stfle.81

2018-01-18 Thread Halil Pasic
On 01/18/2018 09:56 AM, Christian Borntraeger wrote: > stfle.81 (ppa15) is a transparent facility that can be passed to the > guest without the need to implement hypervisor support. As this feature > can be provided by firmware we add it to all full models. > > Signed-off-by: Christian Borntraeg

Re: [Qemu-devel] [PATCH] readline: don't free completions in readline_free()

2018-01-18 Thread Philippe Mathieu-Daudé
On 01/18/2018 07:45 AM, Paolo Bonzini wrote: > On 18/01/2018 11:41, Greg Kurz wrote: >> Since commit e5dc1a6c6c43, QEMU aborts on exit if completion was used >> in the monitor: >> >> *** Error in `obj/ppc64-softmmu/qemu-system-ppc64': double free or >> corruption (fasttop): 0x0100331069d0 ***

Re: [Qemu-devel] [PATCH] scsi-generic: Simplify error handling code

2018-01-18 Thread Philippe Mathieu-Daudé
On 01/18/2018 05:20 AM, Paolo Bonzini wrote: > On 18/01/2018 03:52, Fam Zheng wrote: >> Coverity doesn't like the ignored return value introduced in >> 9d3b155186c278 (hw/block: Fix the return type), and other callers are >> converted already in ceff3e1f01. >> >> This one was added lately in d9bcd6

Re: [Qemu-devel] Do I need update the microcode of virtual machine

2018-01-18 Thread Li Qiang
2018-01-18 18:49 GMT+08:00 Daniel P. Berrange : > On Thu, Jan 18, 2018 at 06:38:57PM +0800, Li Qiang wrote: > > Hi Paolo, all, > > > > I have a question about the intel microcode update for spectre variant#2. > > From my understanding, there is no need to update the microcode of VMs > > because th

Re: [Qemu-devel] [PATCH QEMU v1 0/4] multiboot: bss_end_addr can be zero / cleanup

2018-01-18 Thread Kevin Wolf
Am 17.01.2018 um 21:06 hat Jack Schwartz geschrieben: > Before I proceed with adding my multiboot test file, I'll clarify here that > I started with a version from the grub2 tree.  In that file I expanded a > header file, also from the same tree.  Neither file had any license header, > though the t

Re: [Qemu-devel] [PATCH] hbitmap: fix missing restore count when finish deserialization

2018-01-18 Thread Vladimir Sementsov-Ogievskiy
18.01.2018 13:58, Liang Li wrote: The .count of HBitmap is forgot to set in function hbitmap_deserialize_finish, let's set it to the right value. Cc: Vladimir Sementsov-Ogievskiy Cc: Fam Zheng Cc: Max Reitz Cc: John Snow Signed-off-by: weiping zhang Signed-off-by: Liang Li --- util/hbitm

Re: [Qemu-devel] [PATCH v3 1/3] header sync

2018-01-18 Thread David Hildenbrand
On 18.01.2018 09:56, Christian Borntraeger wrote: > replace with proper header sync > > Signed-off-by: Christian Borntraeger > --- > linux-headers/asm-s390/kvm.h | 9 - > linux-headers/linux/kvm.h| 5 +++-- > 2 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/linux-he

Re: [Qemu-devel] [PATCH v3 2/3] s390x/kvm: Handle bpb feature

2018-01-18 Thread Thomas Huth
On 18.01.2018 09:56, Christian Borntraeger wrote: > We need to handle the bpb control on reset and migration. Normally > stfle.82 is transparent (and the normal guest part works without > hypervisor activity). To prevent any issues we require full > host kernel support for this feature. > > Signed

Re: [Qemu-devel] [PATCH v3 2/3] s390x/kvm: Handle bpb feature

2018-01-18 Thread David Hildenbrand
On 18.01.2018 09:56, Christian Borntraeger wrote: > We need to handle the bpb control on reset and migration. Normally > stfle.82 is transparent (and the normal guest part works without > hypervisor activity). To prevent any issues we require full > host kernel support for this feature. > > Signed

Re: [Qemu-devel] [PATCH v2] cocoa.m: Fix scroll wheel support

2018-01-18 Thread Peter Maydell
On 8 January 2018 at 18:07, John Arbuckle wrote: > When using a mouse's scroll wheel in a guest with > the cocoa front-end, the mouse pointer moves up > and down instead of scrolling the window. This > patch fixes this problem. > > Signed-off-by: John Arbuckle Applied to master, thanks. -- PMM

Re: [Qemu-devel] [PATCH v3 3/3] s390x/kvm: provide stfle.81

2018-01-18 Thread David Hildenbrand
On 18.01.2018 09:56, Christian Borntraeger wrote: > stfle.81 (ppa15) is a transparent facility that can be passed to the > guest without the need to implement hypervisor support. As this feature > can be provided by firmware we add it to all full models. > > Signed-off-by: Christian Borntraeger >

Re: [Qemu-devel] [PATCH v3 3/3] s390x/kvm: provide stfle.81

2018-01-18 Thread Thomas Huth
On 18.01.2018 09:56, Christian Borntraeger wrote: > stfle.81 (ppa15) is a transparent facility that can be passed to the > guest without the need to implement hypervisor support. As this feature > can be provided by firmware we add it to all full models. > > Signed-off-by: Christian Borntraeger >

Re: [Qemu-devel] vhost-pci and virtio-vhost-user

2018-01-18 Thread Jason Wang
On 2018年01月18日 18:51, Stefan Hajnoczi wrote: On Tue, Jan 16, 2018 at 01:41:37PM +0800, Jason Wang wrote: On 2018年01月15日 21:56, Stefan Hajnoczi wrote: On Mon, Jan 15, 2018 at 02:56:31PM +0800, Jason Wang wrote: On 2018年01月12日 18:18, Stefan Hajnoczi wrote: And what's more important, accordin

[Qemu-devel] [PATCH 1/1] nbd: implement bdrv_get_info callback

2018-01-18 Thread Edgar Kaziakhmedov
Since mirror job supports efficient zero out target mechanism (see in mirror_dirty_init()), implement bdrv_get_info to make it work over NBD. Such improvement will allow using the largest chunk possible and will decrease the number of NBD_CMD_WRITE_ZEROES requests on the wire. Signed-off-by: Edgar

Re: [Qemu-devel] [PATCH v3 0/3] s390x/kvm: implement new hardware/firmware features

2018-01-18 Thread Cornelia Huck
On Thu, 18 Jan 2018 09:56:25 +0100 Christian Borntraeger wrote: > We want to provide more hw features to guests, namely the new bpb > control as well as other transparent facilities that might be > introduced by firmware updates (e.g. the stfle facility 81). > > See the kernel discussion for the

Re: [Qemu-devel] [PATCH] Add ability to provide ifname when using netdev bridge or tap helper

2018-01-18 Thread Jason Wang
On 2018年01月18日 02:11, Shaun Reitan wrote: Ok, how should i proceed with this?  I can attempt to write a whitelist/blacklist check if that is what's needed. -- Shaun Reitan NDCHost.com I think you can try. Thanks

Re: [Qemu-devel] [PATCH v3 2/3] s390x/kvm: Handle bpb feature

2018-01-18 Thread Halil Pasic
On 01/18/2018 09:56 AM, Christian Borntraeger wrote: > We need to handle the bpb control on reset and migration. Normally > stfle.82 is transparent (and the normal guest part works without > hypervisor activity). To prevent any issues we require full > host kernel support for this feature. > > S

Re: [Qemu-devel] [PULL 03/11] sm501: Add some more unimplemented registers

2018-01-18 Thread Peter Maydell
On 11 January 2018 at 04:59, David Gibson wrote: > From: BALATON Zoltan > > These are not really implemented (just return zero or default values) > but add these so guests accessing them can run. > > Signed-off-by: BALATON Zoltan > Signed-off-by: David Gibson > --- > hw/display/sm501.c | 17 ++

Re: [Qemu-devel] [PATCH] scsi-generic: Simplify error handling code

2018-01-18 Thread Paolo Bonzini
On 18/01/2018 12:21, Philippe Mathieu-Daudé wrote: >> I'm not a fan of bool return types, in general (because "!" is often >> success while "< 0" is failure) and especially when there is an Error**; >> I disagree with commit 9d3b155186. But the function is not in an area I >> maintain so I'm queui

Re: [Qemu-devel] [PATCH v3 2/3] s390x/kvm: Handle bpb feature

2018-01-18 Thread Christian Borntraeger
On 01/18/2018 01:01 PM, Halil Pasic wrote: > > > On 01/18/2018 09:56 AM, Christian Borntraeger wrote: >> We need to handle the bpb control on reset and migration. Normally >> stfle.82 is transparent (and the normal guest part works without >> hypervisor activity). To prevent any issues we requi

Re: [Qemu-devel] [PULL 06/11] hw/ide: Emulate SiI3112 SATA controller

2018-01-18 Thread Peter Maydell
On 11 January 2018 at 04:59, David Gibson wrote: > From: BALATON Zoltan > > This is a common generic PCI SATA controller that is also used in PCs > but more importantly guests running on the Sam460ex board prefer this > card and have a driver for it (unlike for other SATA controllers > already em

Re: [Qemu-devel] [PATCH 1/1] nbd: implement bdrv_get_info callback

2018-01-18 Thread Paolo Bonzini
On 18/01/2018 12:51, Edgar Kaziakhmedov wrote: > > +static int nbd_get_info(BlockDriverState *bs, BlockDriverInfo *bdi) > +{ > +if (bs->supported_zero_flags & BDRV_REQ_MAY_UNMAP) { > +bdi->can_write_zeroes_with_unmap = true; > +} > +return 0; > +} > + Other drivers set the fla

Re: [Qemu-devel] [PULL 06/11] hw/ide: Emulate SiI3112 SATA controller

2018-01-18 Thread Peter Maydell
On 11 January 2018 at 04:59, David Gibson wrote: > From: BALATON Zoltan > > This is a common generic PCI SATA controller that is also used in PCs > but more importantly guests running on the Sam460ex board prefer this > card and have a driver for it (unlike for other SATA controllers > already em

Re: [Qemu-devel] [PATCH v4] target/xtensa: use libisa for instruction decoding

2018-01-18 Thread Peter Maydell
On 9 January 2018 at 18:03, Max Filippov wrote: > Replace manual opcode analysis with libisa-based code. This makes it > possible to support variable-encoding instructions of the core ISA, like > const16, and will allow to support advanced Xtensa features, like FLIX > and TIE. > > Signed-off-by: M

[Qemu-devel] [PATCH v4 2/5] cryptodev: add vhost support

2018-01-18 Thread Jay Zhou
From: Gonglei Impliment the vhost-crypto's funtions, such as startup, stop and notification etc. Introduce an enum QCryptoCryptoDevBackendOptionsType in order to identify the cryptodev vhost backend is vhost-user or vhost-kernel-module (If exist). At this point, the cryptdoev-vhost-user works.

[Qemu-devel] [PATCH v4 1/5] cryptodev: add vhost-user as a new cryptodev backend

2018-01-18 Thread Jay Zhou
From: Gonglei Usage: -chardev socket,id=charcrypto0,path=/path/to/your/socket -object cryptodev-vhost-user,id=cryptodev0,chardev=charcrypto0 -device virtio-crypto-pci,id=crypto0,cryptodev=cryptodev0 Signed-off-by: Gonglei Signed-off-by: Longpeng(Mike) Signed-off-by: Jay Zhou --- backends/

[Qemu-devel] [PATCH v4 4/5] cryptodev-vhost-user: set the key length

2018-01-18 Thread Jay Zhou
From: Gonglei Signed-off-by: Gonglei --- backends/cryptodev-vhost-user.c | 4 include/sysemu/cryptodev-vhost-user.h | 3 +++ 2 files changed, 7 insertions(+) diff --git a/backends/cryptodev-vhost-user.c b/backends/cryptodev-vhost-user.c index 061c0e5..c7a9848 100644 --- a/backends/c

[Qemu-devel] [PATCH v4 5/5] cryptodev-vhost-user: depend on CONFIG_VHOST_CRYPTO and CONFIG_VHOST_USER

2018-01-18 Thread Jay Zhou
From: Gonglei Signed-off-by: Jay Zhou --- backends/Makefile.objs | 4 +++- backends/cryptodev-vhost.c | 57 +++--- configure | 15 vl.c | 2 ++ 4 files changed, 74 insertions(+), 4 deletions(-) di

[Qemu-devel] [PATCH v4 0/5] cryptodev: add vhost support

2018-01-18 Thread Jay Zhou
From: Gonglei I posted the RFC verion a few months ago for DPDK vhost-crypto implmention, and now it's time to send the formal version. Because we need an user space scheme for better performance. The vhost user crypto server side patches had been sent to DPDK community, pls see [RFC PATCH 0/6]

[Qemu-devel] [PATCH v7 01/16] sdhci: add qtest to check the SD capabilities register

2018-01-18 Thread Philippe Mathieu-Daudé
The PCI model is tested with the pc/x86_64 machine, the SysBus model with the smdkc210/arm machine. Signed-off-by: Philippe Mathieu-Daudé --- tests/sdhci-test.c | 134 + tests/Makefile.include | 3 ++ 2 files changed, 137 insertions(+) creat

[Qemu-devel] [PATCH v7 04/16] sdhci: add a check_capab_sdma() qtest

2018-01-18 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi --- tests/sdhci-test.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tests/sdhci-test.c b/tests/sdhci-test.c index bd5090162f..3f6377474c 100644 --- a/tests/sdhci-test.c +++ b/tests/sdhci-test.c @@ -15,6 +15,7

[Qemu-devel] [PATCH v4 3/5] cryptodev-vhost-user: add crypto session handler

2018-01-18 Thread Jay Zhou
From: Gonglei Introduce two vhost-user meassges: VHOST_USER_CREATE_CRYPTO_SESSION and VHOST_USER_CLOSE_CRYPTO_SESSION. At this point, the QEMU side support crypto operation in cryptodev host-user backend. Signed-off-by: Gonglei Signed-off-by: Longpeng(Mike) Signed-off-by: Jay Zhou --- backen

[Qemu-devel] [PATCH v7 03/16] sdhci: add a check_capab_baseclock() qtest

2018-01-18 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi --- tests/sdhci-test.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/tests/sdhci-test.c b/tests/sdhci-test.c index 645f61dc48..bd5090162f 100644 --- a/tests/sdhci-test.c +++ b/tests/sdhci-test.c @@ -14,6 +14

[Qemu-devel] [PATCH v7 00/16] SDHCI: clean v1/v2 Specs (part 2)

2018-01-18 Thread Philippe Mathieu-Daudé
Since v6: - rebased on upstream to use DEFINE_SDHCI_COMMON_PROPERTIES - included qtests back - add PCI qtests - series was getting big, splitting again; next one is "implement Spec v3" - following Alistair advice, new properties default to current SDHC_CAPAB_REG_DEFAULT (probably 'default' for hi

[Qemu-devel] [PATCH v7 06/16] sdhci: add init_readonly_registers() to initialize the CAPAB register

2018-01-18 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sdhci.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index f9264d3be5..08b85558f1 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhci.c @@ -1174,12 +1174,19 @@ static inline unsigned i

[Qemu-devel] [PATCH v7 02/16] sdhci: add check_capab_readonly() qtest

2018-01-18 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi --- tests/sdhci-test.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/tests/sdhci-test.c b/tests/sdhci-test.c index 0db6b81545..645f61dc48 100644 --- a/tests/sdhci-test.c +++ b/tests/sdhci-test.c

[Qemu-devel] [PATCH v7 05/16] sdhci: add qtest to check the SD Spec version

2018-01-18 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi --- tests/sdhci-test.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/tests/sdhci-test.c b/tests/sdhci-test.c index 3f6377474c..37ada0e1c5 100644 --- a/tests/sdhci-test.c +++ b/tests/sdhci-test.c

[Qemu-devel] [PATCH v7 09/16] sdhci: add max-block-length capability (Spec v1)

2018-01-18 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- hw/sd/sdhci-internal.h | 1 - include/hw/sd/sdhci.h | 2 ++ hw/sd/sdhci.c | 36 +++- 3 files changed, 13 insertions(+), 26 deletions(-) diff --git a/hw/sd/sdhci-internal.h b/hw/sd

[Qemu-devel] [PATCH v7 08/16] sdhci: add basic Spec v1 capabilities

2018-01-18 Thread Philippe Mathieu-Daudé
(Note than Spec v2 is supported by default) we emit a warning for missing capabilities bits. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sdhci-internal.h | 24 ++- include/hw/sd/sdhci.h | 11 + hw/sd/sdhci.c | 63 ++--

[Qemu-devel] [PATCH v7 07/16] sdhci: add a 'spec_version property' (default to v2)

2018-01-18 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- hw/sd/sdhci-internal.h | 4 ++-- include/hw/sd/sdhci.h | 2 ++ hw/sd/sdhci.c | 13 +++-- 3 files changed, 15 insertions(+), 4 deletions(-) diff --git a/hw/sd/sdhci-internal.h b/hw/sd/sdhci-internal.h ind

[Qemu-devel] [PATCH v7 14/16] hw/arm/xilinx_zynq: implement SDHCI Spec v2

2018-01-18 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- hw/arm/xilinx_zynq.c | 70 ++-- tests/sdhci-test.c | 4 +++ 2 files changed, 50 insertions(+), 24 deletions(-) diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c inde

[Qemu-devel] [PATCH v7 15/16] hw/arm/exynos4210: implement SDHCI Spec v2

2018-01-18 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Acked-by: Alistair Francis --- Krzysztof kindly checked those values with Manaul, the Samsung datasheet :) hw/arm/exynos4210.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/hw/arm/exynos4210.c b/hw/arm/exynos4210

[Qemu-devel] [PATCH v7 12/16] sdhci: Fix 64-bit ADMA2

2018-01-18 Thread Philippe Mathieu-Daudé
From: Sai Pavan Boddu The 64-bit ADMA address is not converted to the cpu endianes correctly. This patch fixes the issue and uses a valid mask for the attribute data. Signed-off-by: Sai Pavan Boddu [AF: Re-write commit message] Reviewed-by: Alistair Francis --- hw/sd/sdhci.c | 4 ++-- 1 file

[Qemu-devel] [PATCH 3/7] qcow2: make qcow2_do_open a coroutine_fn

2018-01-18 Thread Paolo Bonzini
It is called from qcow2_invalidate_cache in coroutine context (incoming migration runs in a coroutine), so it's cleaner if metadata is always loaded from a coroutine. Signed-off-by: Paolo Bonzini --- block/qcow2.c | 46 +- 1 file changed, 41 insertions

[Qemu-devel] [PATCH v7 16/16] sdhci: throw an error if capabilities are incorrectly configured

2018-01-18 Thread Philippe Mathieu-Daudé
now than the Exynos4210 uses the 'capareg-reserved' property, we can safely report missing capabilities as error, since capabilities will only get changed once new SDHCI models are added. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sdhci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletio

[Qemu-devel] [PATCH v3 0/7] Call check and invalidate_cache from coroutine context

2018-01-18 Thread Paolo Bonzini
Check and invalidate_cache share some parts of the implementation with the regular I/O path. This is sometimes complicated because the I/O path wants to use a CoMutex but that is not possible outside coroutine context. By moving things to coroutine context, we can remove special cases. In fact,

[Qemu-devel] [PATCH 7/7] block: convert bdrv_check callback to coroutine_fn

2018-01-18 Thread Paolo Bonzini
Suggested-by: Kevin Wolf Signed-off-by: Paolo Bonzini --- block.c | 43 --- block/parallels.c | 17 +++-- block/qcow2.c | 23 +++ block/qed-check.c | 1 + block/qed-table.c

[Qemu-devel] [PATCH 4/7] qed: make bdrv_qed_do_open a coroutine_fn

2018-01-18 Thread Paolo Bonzini
It is called from qcow2_invalidate_cache in coroutine context (incoming migration runs in a coroutine), so it's cleaner if metadata is always loaded from a coroutine. Signed-off-by: Paolo Bonzini --- block/qed.c | 40 +--- 1 file changed, 37 insertions(+), 3 d

[Qemu-devel] [PATCH 2/7] qcow2: make qcow2_co_create2() a coroutine_fn

2018-01-18 Thread Paolo Bonzini
From: Stefan Hajnoczi qcow2_create2() calls qemu_co_mutex_lock(). Only a coroutine_fn may call another coroutine_fn. In fact, qcow2_create2 is always called from coroutine context. Rename the function to add the "co" moniker and add coroutine_fn. Reported-by: Marc-André Lureau Signed-off-by:

[Qemu-devel] [PATCH 5/7] block: convert bdrv_invalidate_cache callback to coroutine_fn

2018-01-18 Thread Paolo Bonzini
QED's bdrv_invalidate_cache implementation would like to reuse functions that acquire/release the metadata locks. Call it from coroutine context to simplify the logic. Signed-off-by: Paolo Bonzini --- block.c | 41 + block/iscsi.c

[Qemu-devel] [PATCH 1/7] block: rename .bdrv_create() to .bdrv_co_create_opts()

2018-01-18 Thread Paolo Bonzini
From: Stefan Hajnoczi BlockDriver->bdrv_create() has been called from coroutine context since commit 5b7e1542cfa41a281af9629d31cef03704d976e6 ("block: make bdrv_create adopt coroutine"). Make this explicit by renaming to .bdrv_co_create_opts() and add the coroutine_fn annotation. This makes it

[Qemu-devel] [PATCH 6/7] qcow2: introduce qcow2_write_caches and qcow2_flush_caches

2018-01-18 Thread Paolo Bonzini
Avoid recursively taking s->lock during bdrv_check. Signed-off-by: Paolo Bonzini --- block/qcow2-refcount.c | 28 block/qcow2.c | 20 block/qcow2.h | 2 ++ 3 files changed, 34 insertions(+), 16 deletions(-) diff --git a/block/

Re: [Qemu-devel] [PATCH v3 0/3] s390x/kvm: implement new hardware/firmware features

2018-01-18 Thread Christian Borntraeger
On 01/18/2018 12:53 PM, Cornelia Huck wrote: > On Thu, 18 Jan 2018 09:56:25 +0100 > Christian Borntraeger wrote: > >> We want to provide more hw features to guests, namely the new bpb >> control as well as other transparent facilities that might be >> introduced by firmware updates (e.g. the st

Re: [Qemu-devel] [PATCH v4 0/5] cryptodev: add vhost support

2018-01-18 Thread no-reply
Hi, This series failed docker-build@min-glib build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: cover.1516277913.git.arei.gong...@huawei.com Subject: [Qemu-devel] [PATCH v4 0/5] crypto

Re: [Qemu-devel] [PATCH] s390x/tcg: fixup TEST PROTECTION

2018-01-18 Thread Cornelia Huck
On Wed, 17 Jan 2018 16:37:37 +0100 David Hildenbrand wrote: > On 12.01.2018 13:54, David Hildenbrand wrote: > > CC == 2 can only happen due to a protection exception, not if memory is > > not available (PGM_ADDRESSING). So all PGM_ADDRESSING exceptions have to > > be forwarded to the guest. > >

Re: [Qemu-devel] [PULL 00/22] ppc-for-2.12 queue 20180117

2018-01-18 Thread Peter Maydell
On 17 January 2018 at 02:25, David Gibson wrote: > The following changes since commit 8e5dc9ba49743b46d955ec7dacb04e42ae7ada7c: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20180116' into > staging (2018-01-16 17:36:39 +) > > are available in the Git repository at: > > git:

Re: [Qemu-devel] [PATCH QEMU v1 0/4] multiboot: bss_end_addr can be zero / cleanup

2018-01-18 Thread Daniel P. Berrange
On Thu, Jan 18, 2018 at 12:35:00PM +0100, Kevin Wolf wrote: > Am 17.01.2018 um 21:06 hat Jack Schwartz geschrieben: > > Before I proceed with adding my multiboot test file, I'll clarify here that > > I started with a version from the grub2 tree.  In that file I expanded a > > header file, also from

Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4)

2018-01-18 Thread Igor Mammedov
On Thu, 18 Jan 2018 10:50:19 + Peter Maydell wrote: > On 18 January 2018 at 10:43, Igor Mammedov wrote: > > Peter Maydell wrote: > >> That usage must want a different name, though, surely? > >> For Arm the default CPU for linux-user is 'any' but that > >> is usermode only and won't work f

Re: [Qemu-devel] [PATCH v2 10/20] fpu/softfloat: define decompose structures

2018-01-18 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Hi Alex, Richard, > > On 01/09/2018 09:22 AM, Alex Bennée wrote: >> These structures pave the way for generic softfloat helper routines >> that will operate on fully decomposed numbers. >> >> Signed-off-by: Alex Bennée >> Signed-off-by: Richard Henderson >> ---

Re: [Qemu-devel] [PATCH 00/24] generalize parsing of cpu_model (part 4)

2018-01-18 Thread Peter Maydell
On 18 January 2018 at 13:06, Igor Mammedov wrote: > I've looked and such case is rather an exception, > I can fix it up in 2 ways: > 1st: > target/arm/cpu.h > +#if !defined(CONFIG_USER_ONLY) > +#define TARGET_DEFAULT_CPU_TYPE TYPE_ARM_CPU > +else > +#define TARGET_DEFAULT_CPU_TYPE ARM_CP

Re: [Qemu-devel] [PATCH v3 0/3] s390x/kvm: implement new hardware/firmware features

2018-01-18 Thread Cornelia Huck
On Thu, 18 Jan 2018 13:47:54 +0100 Christian Borntraeger wrote: > Have the x86 features been marked as stable? If the answer is yes, > shall we mark these patches for stable as well? Doesn't look like it. TBH, I'm not quite sure whether this should go into stable as I'm a bit unclear what our u

Re: [Qemu-devel] [PATCH v3 0/4] linux-user: select CPU type according ELF header values

2018-01-18 Thread Igor Mammedov
On Wed, 17 Jan 2018 17:15:38 +0100 Laurent Vivier wrote: > Le 17/01/2018 à 16:49, Igor Mammedov a écrit : > > On Tue, 16 Jan 2018 23:22:08 +0100 > > Laurent Vivier wrote: > > > >> This idea has been suggested to me before by Philippe > >> Mathieu-Daudé, and recently YunQiang Su has proposed a

  1   2   3   4   5   >