Re: [Qemu-devel] vhost-pci and virtio-vhost-user

2018-01-15 Thread Jason Wang
On 2018年01月15日 15:59, Wei Wang wrote: On 01/15/2018 02:56 PM, Jason Wang wrote: On 2018年01月12日 18:18, Stefan Hajnoczi wrote: I just fail understand why we can't do software defined network or storage with exist virtio device/drivers (or are there any shortcomings that force us to inven

Re: [Qemu-devel] [PATCH 1/2] target/ppc: Clarify compat mode max_threads value

2018-01-15 Thread Greg Kurz
On Mon, 15 Jan 2018 18:27:14 +1100 David Gibson wrote: > We recently had some discussions that were sidetracked for a while, because > nearly everyone misapprehended the purpose of the 'max_threads' field in > the compatiblity modes table. It's all about guest expectations, not host > expectatio

[Qemu-devel] [PATCH] fw_cfg: don't use DMA mapping for fw_cfg device

2018-01-15 Thread Peter Xu
fw_cfg device does not need IOMMU protection, so use physical addresses always. That's how QEMU implements fw_cfg. Otherwise we'll see call traces during boot when vIOMMU is enabled in guest: [1.018306] [ cut here ] [1.018314] WARNING: CPU: 1 PID: 1 at drivers/fir

Re: [Qemu-devel] [RFC PATCH 0/3] vfio: ccw: basic channel path event handling

2018-01-15 Thread Dong Jia Shi
* Cornelia Huck [2018-01-11 11:54:22 +0100]: > On Thu, 11 Jan 2018 04:04:18 +0100 > Dong Jia Shi wrote: > > > Hi Folks, > > > > Background > > == > > > > Some days ago, we had a discussion on the topic of channel path > > virtualization. > > Ref: > > Subject: [PATCH 0/3] Channel Path

Re: [Qemu-devel] [RFC PATCH 0/3] vfio: ccw: basic channel path event handling

2018-01-15 Thread Dong Jia Shi
* Halil Pasic [2018-01-12 19:10:20 +0100]: > > > On 01/11/2018 04:04 AM, Dong Jia Shi wrote: > > What are still missing, thus need to be offered in the next version are: > > - I/O termination and FSM state handling if currently we have I/O on the > > status > > switched path. > > - Vary on/o

Re: [Qemu-devel] [qemu-s390x] [RFC PATCH 3/3] qdev: use device_class_set_parent_realize/unrealize/reset()

2018-01-15 Thread Cornelia Huck
On Sat, 13 Jan 2018 23:04:12 -0300 Philippe Mathieu-Daudé wrote: > changes generated using the following Coccinelle patch: > > @@ > type DeviceParentClass; > DeviceParentClass *pc; > DeviceClass *dc; > identifier parent_fn; > identifier child_fn; > @@ > ( > +device_class_set_pa

[Qemu-devel] [Bug 1654137] Re: Ctrl-A b not working in 2.8.0

2018-01-15 Thread Paul Goyette
** Changed in: qemu Status: In Progress => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1654137 Title: Ctrl-A b not working in 2.8.0 Status in QEMU: Confirmed Bug description:

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 1/7] accel/tcg: add size paremeter in tlb_fill()

2018-01-15 Thread David Hildenbrand
On 13.01.2018 12:14, Laurent Vivier wrote: > The MC68040 MMU provides the size of the access that > triggers the page fault. > > This size is set in the Special Status Word which > is written in the stack frame of the access fault > exception. > > So we need the size in m68k_cpu_unassigned_access

Re: [Qemu-devel] question about share flatviews

2018-01-15 Thread Paolo Bonzini
On 14/01/2018 13:20, CheneyLin wrote: > I'm wondering why we have to shares flatviews between different ASes. In > my opinion, arch like x86 only have two ASes(memory AS and io AS), each > AS is related with only one flatview. Their ASes are definitely different. Every PCI device has its own Addre

Re: [Qemu-devel] [PATCH] scsi: handle the special parameters

2018-01-15 Thread Paolo Bonzini
On 15/01/2018 05:16, linzhecheng wrote: > scsi_disk_emulate_command calls > scsi_build_sense(NULL, 0, outbuf, r->buflen, > (req->cmd.buf[1] & 1) == 0); > But scsi_convert_sense doesn't handle the case when in_buf is NULL > or in_len is 0, which will lead to segfaul

[Qemu-devel] [PATCH 1/2] default-configs/ppc64-softmmu: Include 32-bit configs instead of copying them

2018-01-15 Thread Thomas Huth
qemu-softmmu-ppc64 is supposed to be a superset of qemu-softmmu-ppc. However, instead of simply including the 32-bit config file, we've duplicated all CONFIG_xxx settings there instead. This way, we've missed some CONFIG switches in ppc64-softmmu.mak which were only added to the 32-bit config file

[Qemu-devel] [PATCH v2 0/1] target-ppc: Fix booke206 tlbwe TLB instruction

2018-01-15 Thread Luc MICHEL
v1 is here: https://lists.gnu.org/archive/html/qemu-devel/2017-11/msg00140.html v2: - Add a comment with a cite from the "PowerPC e500 Core Family Reference Manual, Rev. 1", as advised by David. Thanks. Luc MICHEL (1): target-ppc: Fix booke206 tlbwe TLB instruction target/ppc/mmu_

[Qemu-devel] [PATCH 2/2] default-configs/ppc-softmmu: Restructure the switches according to the machines

2018-01-15 Thread Thomas Huth
Order the CONFIG switches in ppc-softmmu.mak according to the machine classes where they are used (embedded, Mac or PReP), so that it is easier for the users to disable a set of switches completely if they are not needed. For the embedded part, we now also include ppcemb-softmmu.mak instead of dup

[Qemu-devel] [PATCH v2 1/1] target-ppc: Fix booke206 tlbwe TLB instruction

2018-01-15 Thread Luc MICHEL
When overwritting a valid TLB entry with a new one, the previous page were not flushed in QEMU TLB, leading to incoherent mapping. This commit fixes this. Signed-off-by: Luc MICHEL --- target/ppc/mmu_helper.c | 32 +++- 1 file changed, 27 insertions(+), 5 deletions(-)

[Qemu-devel] [PATCH 0/2] Clean up the ppc default configs

2018-01-15 Thread Thomas Huth
ppc64-softmmu is a superset of ppc-softmmu which in turn is a superset of ppcemb-softmmu. But since the config files are currently independent from each other, we missed to define some CONFIG switches in the super- sets: CONFIG_SUNGEM is missing from the ppc64-softmmu config, and the CONFIG_IDE_SII

Re: [Qemu-devel] [PULL 0/9] Ui 20180112 patches

2018-01-15 Thread Peter Maydell
On 12 January 2018 at 14:52, Gerd Hoffmann wrote: > The following changes since commit 997eba28a3ed5400a80f754bf3a1c8044b75b9ff: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20180111' into staging (2018-01-11 > 14:34:41 +) > > are available in the git repositor

Re: [Qemu-devel] [RFC PATCH 3/3] qdev: use device_class_set_parent_realize/unrealize/reset()

2018-01-15 Thread Laurent Vivier
Le 14/01/2018 à 03:04, Philippe Mathieu-Daudé a écrit : > changes generated using the following Coccinelle patch: > > @@ > type DeviceParentClass; > DeviceParentClass *pc; > DeviceClass *dc; > identifier parent_fn; > identifier child_fn; > @@ > ( > +device_class_set_parent_realiz

Re: [Qemu-devel] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

2018-01-15 Thread Paolo Bonzini
On 15/01/2018 08:19, Kang, Luwei wrote: >> If you are forwarding host info directly to the guest, the feature >> is not migration-safe. The new feature needs to be added to >> feature_word_info[FEAT_7_0_EBX].unmigratable_flags. >> > Hi, Thanks for you review. I want to support Intel PT live migr

Re: [Qemu-devel] [RFC PATCH 2/3] qdev: add helpers to be more explicit when using abstract QOM parent functions

2018-01-15 Thread Laurent Vivier
Le 14/01/2018 à 03:04, Philippe Mathieu-Daudé a écrit : > QOM API learning curve is quite hard, in particular when devices inherit from > abstract parent. > To be more explicit about when a device class change the parent hooks, add few > helpers hoping a device class_init() will be easier to unders

Re: [Qemu-devel] [Qemu-arm] [PATCH] hw/intc/armv7m: Support byte and halfword accesses to CFSR

2018-01-15 Thread Peter Maydell
On 15 January 2018 at 02:34, Philippe Mathieu-Daudé wrote: > Hi Peter, > > On 12/08/2017 11:12 AM, Peter Maydell wrote: >> The Configurable Fault Status Register for ARMv7M and v8M is >> supposed to be byte and halfword accessible, but we were only > > "aligned halfword" "halfword" is the phrasin

Re: [Qemu-devel] [RFC PATCH 1/3] qdev: rename typedef qdev_resetfn() -> DeviceReset()

2018-01-15 Thread Laurent Vivier
Le 14/01/2018 à 03:04, Philippe Mathieu-Daudé a écrit : > following the DeviceRealize and DeviceUnrealize typedefs, > this unify a bit the new QOM API. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/qdev-core.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff -

Re: [Qemu-devel] [PATCH] memory: set ioeventfd_update_pending after address_space_update_ioeventfds

2018-01-15 Thread Paolo Bonzini
On 14/01/2018 13:55, linzhecheng wrote: > We should set ioeventfd_update_pending same as memory_region_update_pending. > > Signed-off-by: linzhecheng Thanks. This indeed fixes a bug introduced by commit ade9c1aac5292ff698fa550adebe794c37d86cc9. Paolo > --- > memory.c | 1 + > 1 file changed,

Re: [Qemu-devel] [PATCH v5 0/1] savevm/loadvm with postcopy flag qemu-iotest

2018-01-15 Thread Daniel Henrique Barboza
Ping On 01/02/2018 11:04 AM, Daniel Henrique Barboza wrote: Hi there, I saw that new iotests were added upstream and decided to re-sent this patch, but then I noticed that the files being created by this patch (201 and 201.out) weren't created upstream - we have 200 and then 202 and 203. Is

Re: [Qemu-devel] [PATCH 2/2] spapr: Adjust default VSMT value for better migration compatibility

2018-01-15 Thread Greg Kurz
On Mon, 15 Jan 2018 18:27:15 +1100 David Gibson wrote: > fa98fbfc "PC: KVM: Support machine option to set VSMT mode" introduced the > "vsmt" parameter for the pseries machine type, which controls the spacing > of the vcpu ids of thread 0 for each virtual core. This was done to bring > some consi

Re: [Qemu-devel] [RFC PATCH 3/3] qdev: use device_class_set_parent_realize/unrealize/reset()

2018-01-15 Thread Marcel Apfelbaum
On 14/01/2018 4:04, Philippe Mathieu-Daudé wrote: changes generated using the following Coccinelle patch: @@ type DeviceParentClass; DeviceParentClass *pc; DeviceClass *dc; identifier parent_fn; identifier child_fn; @@ ( +device_class_set_parent_realize(dc, child_fn, &

Re: [Qemu-devel] [RFC PATCH 1/3] vfio: ccw: introduce schib region

2018-01-15 Thread Pierre Morel
On 11/01/2018 04:04, Dong Jia Shi wrote: This introduces a new region for vfio-ccw to provide subchannel information for user space. Signed-off-by: Dong Jia Shi --- drivers/s390/cio/vfio_ccw_fsm.c | 21 ++ drivers/s390/cio/vfio_ccw_ops.c | 79 +++--

[Qemu-devel] [Bug 1743337] [NEW] OS/2 Warp 4 HPFS corruption

2018-01-15 Thread MVoloshin
Public bug reported: How to reproduce: Install OS/2 Warp 4 onto HPFS-formatted partition. After reboot there will be messages about "missing" files and OS2.INI not found. Chkdsk C: complains about FS corruption. Nothing changes even after fixing errors and next reboot. If you install OS/2 onto

Re: [Qemu-devel] [PATCH v4] Add ability for user to specify mouse ungrab key

2018-01-15 Thread Daniel P. Berrange
On Fri, Jan 12, 2018 at 10:15:24PM -0500, Programmingkid wrote: > > > On Jan 10, 2018, at 11:14 AM, Daniel P. Berrange > > wrote: > > > > On Tue, Dec 26, 2017 at 08:14:28PM -0500, John Arbuckle wrote: > >> Currently the ungrab keys for the Cocoa and GTK interface are > >> Control-Alt-g. > >> T

Re: [Qemu-devel] [PATCH 8/9] target/arm: Add ZCR.LEN to tb->flags

2018-01-15 Thread Peter Maydell
On 12 January 2018 at 18:49, Peter Maydell wrote: > For purposes of not having to mess with migration state too frequently, > I think this patch should define zcr_el[4] (and add that to the > migration subsection for 'has SVE'). I realized over the weekend that this suggestion isn't right -- ZCR_

Re: [Qemu-devel] [PULL 0/4] TCG queued patches

2018-01-15 Thread Peter Maydell
On 12 January 2018 at 21:06, Richard Henderson wrote: > This includes a fix for the tcg/arm bug exposed by the ppc64 code change > for comparisons. > > It also includes improvements to tcg/arm and tcg/ppc to allow for larger > CPUFooState structures, as exposed by expanding CPUARMState for 2048-bi

Re: [Qemu-devel] [RFC PATCH 0/3] vfio: ccw: basic channel path event handling

2018-01-15 Thread Pierre Morel
On 15/01/2018 09:57, Dong Jia Shi wrote: * Cornelia Huck [2018-01-11 11:54:22 +0100]: On Thu, 11 Jan 2018 04:04:18 +0100 Dong Jia Shi wrote: Hi Folks, Background == Some days ago, we had a discussion on the topic of channel path virtualization. Ref: Subject: [PATCH 0/3] Channel Pa

Re: [Qemu-devel] [RFC PATCH 1/3] vfio: ccw: introduce schib region

2018-01-15 Thread Cornelia Huck
On Mon, 15 Jan 2018 14:43:09 +0800 Dong Jia Shi wrote: > * Cornelia Huck [2018-01-11 15:16:59 +0100]: > > Hi Conny, > > > On Thu, 11 Jan 2018 04:04:19 +0100 > > Dong Jia Shi wrote: > > > > > This introduces a new region for vfio-ccw to provide subchannel > > > information for user space. >

[Qemu-devel] [Bug 1708462] Re: Support Python 3 to build

2018-01-15 Thread Daniel Berrange
> Python 2 EOL is in 2020 so there is a fair amount of time. Not as much time as you might think. Even well before that time, any new releases of long life and/or enterprise distros are likely to choose to skip py2 by default, as it will be EOL long before the distro itself EOLs. -- You received

[Qemu-devel] [PATCH v3 01/13] qapi: convert to use python print function instead of statement

2018-01-15 Thread Daniel P. Berrange
Get Py2 + 3 compatibility by using the print function instead of print statement. This works for 2.6 onwards. Signed-off-by: Daniel P. Berrange --- scripts/qapi.py| 12 ++-- scripts/qapi2texi.py | 9 + tests/qapi-schema/test-qapi.py | 41 +++

[Qemu-devel] [PATCH v3 03/13] qapi: Use OrderedDict from standard library if available

2018-01-15 Thread Daniel P. Berrange
The OrderedDict class appeared in the 'collections' module from python 2.7 onwards, so use that in preference to our local backport if available. Signed-off-by: Daniel P. Berrange --- scripts/qapi.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/qapi.py b/script

[Qemu-devel] [PATCH v3 02/13] qapi: use items()/values() intead of iteritems()/itervalues()

2018-01-15 Thread Daniel P. Berrange
The iteritems()/itervalues() methods are gone in py3, but the items()/values() methods are still around. The latter are less efficient than the former in py2, but this has unmeasurably small impact on QEMU build time, so taking portability over efficiency is a net win Signed-off-by: Daniel P. Berr

[Qemu-devel] [PATCH v3 00/13] Support building with py2 or py3

2018-01-15 Thread Daniel P. Berrange
This is an update for my previously posted series: v2: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg06528.html This series enables some level of CI testing for py3 so that our CI jobs will get coverage of both py2 and py3 builds to avoid bitrot. I did a test travis build with py 3.0

[Qemu-devel] [PATCH v3 04/13] qapi: adapt to moved location of StringIO module in py3

2018-01-15 Thread Daniel P. Berrange
Signed-off-by: Daniel P. Berrange --- scripts/qapi.py | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index 7ec2e00b2c..eaa63a58be 100644 --- a/scripts/qapi.py +++ b/scripts/qapi.py @@ -22,6 +22,10 @@ try: from collections import O

[Qemu-devel] [PATCH v3 10/13] input: add missing JIS keys to virtio input

2018-01-15 Thread Daniel P. Berrange
From: Miika S keycodemapdb updated to add the QKeyCodes muhenkan and katakanahiragana Signed-off-by: Miika S --- hw/input/virtio-input-hid.c | 7 +++ qapi/ui.json| 5 - ui/keycodemapdb | 2 +- 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/h

[Qemu-devel] [PATCH v3 07/13] qapi: ensure stable sort ordering when checking QAPI entities

2018-01-15 Thread Daniel P. Berrange
Some early python 3.x versions will have different default ordering when calling the 'values()' method on a dict, compared to python 2.x and later 3.x versions. Explicitly sort the items to get a stable ordering. Signed-off-by: Daniel P. Berrange --- scripts/qapi.py | 2 +- 1 file changed, 1 ins

[Qemu-devel] [PATCH v3 06/13] qapi: remove '-q' arg to diff when comparing QAPI output

2018-01-15 Thread Daniel P. Berrange
When the qapi schema tests fail they merely print that the expected output didn't match the actual output. This is largely useless when trying diagnose what went wrong. Removing the '-q' arg to diff means that it is still silent on successful tests, but when it fails we'll see details of the incorr

[Qemu-devel] [PATCH v3 05/13] qapi: Adapt to moved location of 'maketrans' function in py3

2018-01-15 Thread Daniel P. Berrange
Signed-off-by: Daniel P. Berrange --- scripts/qapi.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index eaa63a58be..b6a7b5139f 100644 --- a/scripts/qapi.py +++ b/scripts/qapi.py @@ -1734,7 +1734,10 @@ def c_enum_const(type_name, const_

[Qemu-devel] [PATCH v3 12/13] travis: improve python version test coverage

2018-01-15 Thread Daniel P. Berrange
Currently travis declares ancient python 2.4 is desired. Update that to 2.6 which is the oldest version any targetted distros still needs. If we just list a python 3 version at the top level this will double the number of travis jobs we run which is unreasonable. So arbitrarily pick the clang test

[Qemu-devel] [PATCH v3 13/13] docker: change Fedora images to run with python3

2018-01-15 Thread Daniel P. Berrange
Fedora has switched to Python 3 by default, so it makes sense to use that for testing QEMU builds, so we get testing of Python 3 compatibility. Signed-off-by: Daniel P. Berrange --- tests/docker/dockerfiles/fedora.docker | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests

[Qemu-devel] [PATCH v3 08/13] scripts: ensure signrom treats data as bytes

2018-01-15 Thread Daniel P. Berrange
Signed-off-by: Daniel P. Berrange --- scripts/signrom.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/signrom.py b/scripts/signrom.py index d1dabe0240..0497a1c32e 100644 --- a/scripts/signrom.py +++ b/scripts/signrom.py @@ -18,7 +18,7 @@ fin = open(sys.argv[1],

[Qemu-devel] [PATCH v3 09/13] configure: allow use of python 3

2018-01-15 Thread Daniel P. Berrange
Signed-off-by: Daniel P. Berrange --- configure | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/configure b/configure index b272a0336b..60b99f45f6 100755 --- a/configure +++ b/configure @@ -1598,9 +1598,8 @@ fi # Note that if the Python conditional here evaluates True

Re: [Qemu-devel] [PATCH v3 01/13] qapi: convert to use python print function instead of statement

2018-01-15 Thread Philippe Mathieu-Daudé
Hi Daniel, On 01/15/2018 07:26 AM, Daniel P. Berrange wrote: > Get Py2 + 3 compatibility by using the print function > instead of print statement. This works for 2.6 onwards. > > Signed-off-by: Daniel P. Berrange > --- > scripts/qapi.py| 12 ++-- > scripts/qapi2texi.py

[Qemu-devel] [PATCH v3 11/13] ui: update keycodemapdb to get py3 fixes

2018-01-15 Thread Daniel P. Berrange
Signed-off-by: Daniel P. Berrange --- ui/keycodemapdb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/keycodemapdb b/ui/keycodemapdb index 05dad417e9..6b3d716e2b 16 --- a/ui/keycodemapdb +++ b/ui/keycodemapdb @@ -1 +1 @@ -Subproject commit 05dad417e9d0b37ee1fba33056d91a

Re: [Qemu-devel] [PATCH v3 02/13] qapi: use items()/values() intead of iteritems()/itervalues()

2018-01-15 Thread Philippe Mathieu-Daudé
On 01/15/2018 07:26 AM, Daniel P. Berrange wrote: > The iteritems()/itervalues() methods are gone in py3, but the > items()/values() methods are still around. The latter are less > efficient than the former in py2, but this has unmeasurably > small impact on QEMU build time, so taking portability o

Re: [Qemu-devel] [PATCH 2/2] spapr: Adjust default VSMT value for better migration compatibility

2018-01-15 Thread joserz
On Mon, Jan 15, 2018 at 06:27:15PM +1100, David Gibson wrote: > fa98fbfc "PC: KVM: Support machine option to set VSMT mode" introduced the > "vsmt" parameter for the pseries machine type, which controls the spacing > of the vcpu ids of thread 0 for each virtual core. This was done to bring > some

Re: [Qemu-devel] [PATCH v3 03/13] qapi: Use OrderedDict from standard library if available

2018-01-15 Thread Philippe Mathieu-Daudé
On 01/15/2018 07:26 AM, Daniel P. Berrange wrote: > The OrderedDict class appeared in the 'collections' module > from python 2.7 onwards, so use that in preference to our > local backport if available. > > Signed-off-by: Daniel P. Berrange Reviewed-by: Philippe Mathieu-Daudé > --- > scripts/q

Re: [Qemu-devel] [PULL v2 00/52] Misc patches for 2017-01-12

2018-01-15 Thread Peter Maydell
On 12 January 2018 at 13:42, Paolo Bonzini wrote: > I'll drop that patch. I'm assuming you'll send a new pull req cover letter email when you've done that (so this one is leaving my queue of things to do). thanks -- PMM

Re: [Qemu-devel] [PATCH 1/3] input: add missing JIS keys to virtio input

2018-01-15 Thread Daniel P. Berrange
On Fri, Dec 22, 2017 at 05:25:29PM +0200, Miika S wrote: > keycodemapdb updated to add the QKeyCodes muhenkan and katakanahiragana > > Signed-off-by: Miika S > --- > hw/input/virtio-input-hid.c | 7 +++ > qapi/ui.json| 5 - > ui/keycodemapdb | 2 +- > 3 files

Re: [Qemu-devel] [PATCH v3 07/13] qapi: ensure stable sort ordering when checking QAPI entities

2018-01-15 Thread Philippe Mathieu-Daudé
On 01/15/2018 07:26 AM, Daniel P. Berrange wrote: > Some early python 3.x versions will have different default > ordering when calling the 'values()' method on a dict, compared > to python 2.x and later 3.x versions. Explicitly sort the items > to get a stable ordering. > > Signed-off-by: Daniel P

Re: [Qemu-devel] [PATCH v3 04/13] qapi: adapt to moved location of StringIO module in py3

2018-01-15 Thread Philippe Mathieu-Daudé
On 01/15/2018 07:26 AM, Daniel P. Berrange wrote: > Signed-off-by: Daniel P. Berrange Reviewed-by: Philippe Mathieu-Daudé > --- > scripts/qapi.py | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/scripts/qapi.py b/scripts/qapi.py > index 7ec2e00b2c..eaa63a58be 10

Re: [Qemu-devel] [PATCH 1/2] target/ppc: Clarify compat mode max_threads value

2018-01-15 Thread joserz
On Mon, Jan 15, 2018 at 06:27:14PM +1100, David Gibson wrote: > We recently had some discussions that were sidetracked for a while, because > nearly everyone misapprehended the purpose of the 'max_threads' field in > the compatiblity modes table. It's all about guest expectations, not host > expec

Re: [Qemu-devel] vhost-pci and virtio-vhost-user

2018-01-15 Thread Wei Wang
On 01/15/2018 04:34 PM, Jason Wang wrote: On 2018年01月15日 15:59, Wei Wang wrote: On 01/15/2018 02:56 PM, Jason Wang wrote: On 2018年01月12日 18:18, Stefan Hajnoczi wrote: I just fail understand why we can't do software defined network or storage with exist virtio device/drivers (or are the

Re: [Qemu-devel] [PATCH v3 08/13] scripts: ensure signrom treats data as bytes

2018-01-15 Thread Philippe Mathieu-Daudé
On 01/15/2018 07:26 AM, Daniel P. Berrange wrote: > Signed-off-by: Daniel P. Berrange Reviewed-by: Philippe Mathieu-Daudé > --- > scripts/signrom.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/scripts/signrom.py b/scripts/signrom.py > index d1dabe0240..0497a1c

Re: [Qemu-devel] [PATCH v3 13/13] docker: change Fedora images to run with python3

2018-01-15 Thread Philippe Mathieu-Daudé
Hi Daniel, On 01/15/2018 07:26 AM, Daniel P. Berrange wrote: > Fedora has switched to Python 3 by default, so it makes sense to use that > for testing QEMU builds, so we get testing of Python 3 compatibility. I'd rather keep Fedora 25 with Python 2, and use Python 3 in Fedora 27. If you agree, I

Re: [Qemu-devel] [PULL v2 00/52] Misc patches for 2017-01-12

2018-01-15 Thread Philippe Mathieu-Daudé
Hi Paolo, On 01/15/2018 07:37 AM, Peter Maydell wrote: > On 12 January 2018 at 13:42, Paolo Bonzini wrote: >> I'll drop that patch. > > I'm assuming you'll send a new pull req cover letter email > when you've done that (so this one is leaving my queue of > things to do). If you send an new PR c

Re: [Qemu-devel] [PATCH v3 13/13] docker: change Fedora images to run with python3

2018-01-15 Thread Daniel P. Berrange
On Mon, Jan 15, 2018 at 07:47:29AM -0300, Philippe Mathieu-Daudé wrote: > Hi Daniel, > > On 01/15/2018 07:26 AM, Daniel P. Berrange wrote: > > Fedora has switched to Python 3 by default, so it makes sense to use that > > for testing QEMU builds, so we get testing of Python 3 compatibility. > > I'

Re: [Qemu-devel] [PATCH v4 00/46] Windbg supporting

2018-01-15 Thread Mihail Abakumov
Paolo Bonzini писал 2018-01-12 11:27: On 11/12/2017 14:21, Mihail Abakumov wrote: How it works: The WinDbg debugger has the possibility of connecting to a remote debug service (Kdsrv.exe) in the Windows kernel. Therefore, it is possible to connect to the guest system running in the QEMU emulat

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/2] Clean up the ppc default configs

2018-01-15 Thread Greg Kurz
On Mon, 15 Jan 2018 10:30:53 +0100 Thomas Huth wrote: > ppc64-softmmu is a superset of ppc-softmmu which in turn is a superset Hi Thomas, Per curiosity. I understand that a 64-bit ppc CPU is expected to support 32-bit ppc code, but does QEMU really need to emulate setups that likely never exist

Re: [Qemu-devel] [RFC PATCH 0/3] add helpers to be more explicit when using QOM abstract parent hooks

2018-01-15 Thread Paolo Bonzini
On 14/01/2018 03:04, Philippe Mathieu-Daudé wrote: > Hi, > > Learning how to implement QOM devices I found the pattern changing parent > hooks > when the parent is abstract not trivial to understand. > > This series add few helpers to have this pattern more explicit. > > Those functions deserve

Re: [Qemu-devel] [PATCH] LEON3 IRQMP: Fix IRQ software ack

2018-01-15 Thread Fabien Chouteau
On 12/01/2018 15:10, Jean-Christophe Dubois wrote: > Le 2018-01-12 11:55, Fabien Chouteau a écrit : >> On 11/01/2018 13:35, Jean-Christophe Dubois wrote: >>> Thanks Fabien, >>> >>> Now, as a side question, could you tell me which reference LEON3 platform >>> is implemented by Qemu in leon3_generic

Re: [Qemu-devel] [PATCH] fw_cfg: don't use DMA mapping for fw_cfg device

2018-01-15 Thread Marc-Andre Lureau
Hi On Mon, Jan 15, 2018 at 9:55 AM, Peter Xu wrote: > fw_cfg device does not need IOMMU protection, so use physical addresses > always. That's how QEMU implements fw_cfg. Otherwise we'll see call > traces during boot when vIOMMU is enabled in guest: > > [1.018306] [ cut here ]--

Re: [Qemu-devel] [PULL 0/5] slirp updates

2018-01-15 Thread Peter Maydell
On 14 January 2018 at 17:20, Samuel Thibault wrote: > warning: redirection vers https://people.debian.org/~sthibault/qemu.git/ > The following changes since commit 7398166ddf7c6dbbc9cae6ac69bb2feda14b40ac: > > Merge remote-tracking branch > 'remotes/kraxel/tags/vnc-20180112-pull-request' into s

[Qemu-devel] RFE for patchew docker result reporting

2018-01-15 Thread Daniel P. Berrange
Currently if I look at the patchew website for build logs, the 'docker' job results are listed as a single expandable item. Patchew runs 3 separate docker builds, however, and there's a tonne of output to scroll through to find which one actually failed. Thus, my RFE is to split the build log up

[Qemu-devel] [Bug 1708462] Re: Support Python 3 to build

2018-01-15 Thread Daniel Berrange
Two patches series posted in Aug last year: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg03642.html https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg06528.html An updated series covering both of those, and also turning on tests https://lists.gnu.org/archive/html/qemu-devel/20

[Qemu-devel] [PULL 02/27] migration: print features as on off

2018-01-15 Thread Juan Quintela
Once there, do one thing for line Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/migration.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 8d2372394c..1

[Qemu-devel] [PULL 01/27] migration: Use proper types in json

2018-01-15 Thread Juan Quintela
We use int for everything (int64_t), and then we check that value is between 0 and 255. Change it to the valid types. This change only happens for HMP. QMP always use bytes and similar. Signed-off-by: Juan Quintela Reviewed-by: Eric Blake --- hmp.c | 22 +++---

[Qemu-devel] [PULL 00/27] Migration pull

2018-01-15 Thread Juan Quintela
9:29 +) are available in the Git repository at: git://github.com/juanquintela/qemu.git tags/migration/20180115 for you to fetch changes up to 816306826a45f4d15352e32d157172af3a35899f: migration: remove notify in fd_error (2018-01-15 12:4

[Qemu-devel] [PULL 05/27] migration: free result string

2018-01-15 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reported-by: Peter Xu --- tests/migration-test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/migration-test.c b/tests/migration-test.c index be598d3257..799e24ebc6 100644 --- a/tests/migration-test.

[Qemu-devel] [PULL 07/27] migration: introduce postcopy-blocktime capability

2018-01-15 Thread Juan Quintela
From: Alexey Perevalov Right now it could be used on destination side to enable vCPU blocktime calculation for postcopy live migration. vCPU blocktime - it's time since vCPU thread was put into interruptible sleep, till memory page was copied and thread awake. Reviewed-by: Dr. David Alan Gilbert

[Qemu-devel] [PULL 08/27] migration: add postcopy blocktime ctx into MigrationIncomingState

2018-01-15 Thread Juan Quintela
From: Alexey Perevalov This patch adds request to kernel space for UFFD_FEATURE_THREAD_ID, in case this feature is provided by kernel. PostcopyBlocktimeContext is encapsulated inside postcopy-ram.c, due to it being a postcopy-only feature. Also it defines PostcopyBlocktimeContext's instance live

[Qemu-devel] [PULL 03/27] migration: free addr in the same function that we created it

2018-01-15 Thread Juan Quintela
Otherwise, we can't use it after calling socket_start_incoming_migration Signed-off-by: Juan Quintela Reviewed-by: Peter Xu --- migration/socket.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/socket.c b/migration/socket.c index dee869044a..3a8232dd2d 100644

[Qemu-devel] [PULL 10/27] migration: postcopy_blocktime documentation

2018-01-15 Thread Juan Quintela
From: Alexey Perevalov Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Alexey Perevalov Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- docs/devel/migration.rst | 14 ++ 1 file changed, 14 insertions(+) diff --git a/docs/devel/migration.rst b/docs/devel/migration.

[Qemu-devel] [PULL 17/27] migration: remove "enable_colo" var

2018-01-15 Thread Juan Quintela
From: Peter Xu It's only used once, clean it up a bit. Signed-off-by: Peter Xu Signed-off-by: Juan Quintela --- migration/migration.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 02d8bc07b1..0b513c2020 100644 --- a/m

[Qemu-devel] [PULL 09/27] migration: calculate vCPU blocktime on dst side

2018-01-15 Thread Juan Quintela
From: Alexey Perevalov This patch provides blocktime calculation per vCPU, as a summary and as a overlapped value for all vCPUs. This approach was suggested by Peter Xu, as an improvements of previous approch where QEMU kept tree with faulted page address and cpus bitmask in it. Now QEMU is keep

[Qemu-devel] [PULL 04/27] docs: Convert migration.txt to rst

2018-01-15 Thread Juan Quintela
From: "Dr. David Alan Gilbert" Mostly just manual conversion with very minor fixes. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Daniel P. Berrange Reviewed-by: Kashyap Chamarthy Reviewed-by: Peter Xu Signed-off-by: Juan Quintela --- docs/devel/{migration.txt => migration.rst} | 470

[Qemu-devel] [PULL 11/27] migration: add blocktime calculation into migration-test

2018-01-15 Thread Juan Quintela
From: Alexey Perevalov This patch just requests blocktime calculation, and check it in case when UFFD_FEATURE_THREAD_ID feature is set on the host. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Alexey Perevalov Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- tests/migration

[Qemu-devel] [PULL 12/27] migration: add postcopy total blocktime into query-migrate

2018-01-15 Thread Juan Quintela
From: Alexey Perevalov Postcopy total blocktime is available on destination side only. But query-migrate was possible only for source. This patch adds ability to call query-migrate on destination. To be able to see postcopy blocktime, need to request postcopy-blocktime capability. The query-migr

[Qemu-devel] [PULL 19/27] migration: move vm_old_running into global state

2018-01-15 Thread Juan Quintela
From: Peter Xu Firstly, it was passed around. Let's just move it into MigrationState just like many other variables as state of migration, renaming it to vm_was_running. One thing to mention is that for postcopy, we actually don't need this knowledge at all since postcopy can't resume a VM even

[Qemu-devel] [PULL 06/27] migration: fix analyze-migration.py script with radix table

2018-01-15 Thread Juan Quintela
From: Laurent Vivier Since commit 3a38429748 ("Add a "no HPT" encoding to HTAB migration stream") the HTAB migration stream contains a header set to "-1", meaning there is no HPT. Teach analyze-migration.py to ignore the section in this case. Without this fix, the script fails with a dump from a

[Qemu-devel] [PULL 13/27] migration: Guard ram_bytes_remaining against early call

2018-01-15 Thread Juan Quintela
From: "Dr. David Alan Gilbert" Calling ram_bytes_remaining during the early part of setup is unsafe because the ram_state isn't yet initialised. This can happen in the sequence: migrate migrate_cancel info migrate if the migrate sticks trying to connect (e.g. to an unresponsive destina

[Qemu-devel] [PULL 14/27] migration: finalize current_migration object

2018-01-15 Thread Juan Quintela
From: Vladimir Sementsov-Ogievskiy current_migration has .instance_finalize callback, but it is not called, because nobody unrefs current_migration. Fix that. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Peter Xu Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- includ

Re: [Qemu-devel] [PATCH qemu v2] kvm: Add kvm_set_user_memory tracepoint

2018-01-15 Thread Paolo Bonzini
On 15/12/2017 06:23, Alexey Kardashevskiy wrote: > This adds a tracepoint to trace the KVM_SET_USER_MEMORY_REGION ioctl > parameters which is quite useful for debugging VFIO memory regions > being actually registered with KVM. > > Signed-off-by: Alexey Kardashevskiy > --- > Changes: > v2: > * add

[Qemu-devel] [PULL 18/27] migration: split use of MigrationState.total_time

2018-01-15 Thread Juan Quintela
From: Peter Xu It was used either to: 1. store initial timestamp of migration start, and 2. store total time used by last migration Let's provide two parameters for each of them. Mix use of the two is slightly misleading. Signed-off-by: Peter Xu Reviewed-by: Juan Quintela Signed-off-by: Jua

[Qemu-devel] [PULL 15/27] migration: assert colo instead of check

2018-01-15 Thread Juan Quintela
From: Peter Xu When reaching here if we are still "active" it means we must be in colo state. After a quick discussion offlist, we decided to use the safer error_report(). Finally I want to use "switch" here rather than lots of complicated if clauses. Signed-off-by: Peter Xu Reviewed-by: Juan

[Qemu-devel] [PULL 16/27] migration: qemu_savevm_state_cleanup() in cleanup

2018-01-15 Thread Juan Quintela
From: Peter Xu Moving existing callers all into migrate_fd_cleanup(). It simplifies migration_thread() a bit. Reviewed-by: Juan Quintela Signed-off-by: Peter Xu Signed-off-by: Juan Quintela --- migration/migration.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --gi

[Qemu-devel] [PULL 21/27] migration: introduce migrate_calculate_complete

2018-01-15 Thread Juan Quintela
From: Peter Xu Generalize the calculation part when migration complete into a function to simplify migration_thread(). Signed-off-by: Peter Xu Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/migration.c | 31 --- 1 file changed, 20 insertions

[Qemu-devel] [PULL 24/27] migration: major cleanup for migrate iterations

2018-01-15 Thread Juan Quintela
From: Peter Xu The major work for migration iterations are to move RAM/block/... data via qemu_savevm_state_iterate(). Generalize those part into a single function. Reviewed-by: Juan Quintela Signed-off-by: Peter Xu Signed-off-by: Juan Quintela --- migration/migration.c | 90 +++

[Qemu-devel] [PULL 20/27] migration: introduce downtime_start

2018-01-15 Thread Juan Quintela
From: Peter Xu Introduce MigrationState.downtime_start to replace the local variable "start_time" in migration_thread to avoid passing things around. Reviewed-by: Juan Quintela Signed-off-by: Peter Xu Signed-off-by: Juan Quintela --- migration/migration.c | 12 migration/migrati

[Qemu-devel] [PULL 23/27] migration: cleanup stats update into function

2018-01-15 Thread Juan Quintela
From: Peter Xu We have quite a few lines in migration_thread() that calculates some statistics for the migration interations. Isolate it into a single function to improve readability. Signed-off-by: Peter Xu Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/migration.c |

[Qemu-devel] [PULL 25/27] migration: put the finish part into a new function

2018-01-15 Thread Juan Quintela
From: Peter Xu This patch only moved the last part of migration_thread() into a new function migration_iteration_finish() to make it much shorter. With previous works to remove some local variables, now it's fairly easy to do that. Reviewed-by: Juan Quintela Signed-off-by: Peter Xu Signed-off

[Qemu-devel] [PULL 27/27] migration: remove notify in fd_error

2018-01-15 Thread Juan Quintela
From: Peter Xu It is already called in migrate_fd_cleanup. Signed-off-by: Peter Xu Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/migration.c | 1 - 1 file changed, 1 deletion(-) diff --git a/migration/migration.c b/migration/migration.c index 47367cffae..d3a1c494c0 1

[Qemu-devel] [PULL 22/27] migration: use switch at the end of migration

2018-01-15 Thread Juan Quintela
From: Peter Xu It converts the old if clauses into switch, explicitly mentions the possible migration states. The old nested "if"s are not clear on what we do on different states. Signed-off-by: Peter Xu Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/migration.c | 44

Re: [Qemu-devel] [PATCH] ppc/pnv: Update skiboot firmware image

2018-01-15 Thread Cédric Le Goater
On 01/15/2018 01:07 PM, Cédric Le Goater wrote: > This is skiboot 5.9 (commit e0ee24c2). It brings improved POWER9 > support among many other things. Built from submodule. I just noticed that unit test ppc64/boot-serial/powernv needs a change to take into account the first output line. I will sen

[Qemu-devel] [PULL 26/27] migration: remove some block_cleanup_parameters()

2018-01-15 Thread Juan Quintela
From: Peter Xu Keep the one in migrate_fd_cleanup() would be enough. Removing the other two. Signed-off-by: Peter Xu Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/migration.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/migration/migration.c b/migration/migra

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/2] Clean up the ppc default configs

2018-01-15 Thread BALATON Zoltan
On Mon, 15 Jan 2018, Thomas Huth wrote: ppc64-softmmu is a superset of ppc-softmmu which in turn is a superset of ppcemb-softmmu. But since the config files are currently independent from each other, we missed to define some CONFIG switches in the super- sets: CONFIG_SUNGEM is missing from the pp

  1   2   3   4   5   >