Re: [Qemu-devel] [RFC v6 07/27] monitor: unify global init

2018-01-10 Thread Peter Xu
On Tue, Jan 09, 2018 at 05:13:40PM -0600, Eric Blake wrote: > On 12/19/2017 02:45 AM, Peter Xu wrote: > > There are many places for monitor init its globals, at least: > > Reads awkwardly; maybe: > > ...many places where the monitor initializes its globals,... Fixed. > > > > > - monitor_init_

Re: [Qemu-devel] [RFC v6 09/27] monitor: create monitor dedicate iothread

2018-01-10 Thread Peter Xu
On Tue, Jan 09, 2018 at 05:31:18PM -0600, Eric Blake wrote: > On 12/19/2017 02:45 AM, Peter Xu wrote: > > Grammar in the subject: > > s/monitor dedicate/a dedicated monitor/ > > > Create one IOThread for the monitors, prepared to handle all the > > input/output IOs using existing iothread framew

Re: [Qemu-devel] [PATCH v4 00/46] Windbg supporting

2018-01-10 Thread Pavel Dovgalyuk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 22/12/2017 14:21, Pavel Dovgalyuk wrote: > > Paolo, Ladi finished the review. > > What about merging these into upstream? > > Sure, in the new year though. Now? Pavel Dovgalyuk > > > >> -Original Message- > >> From: Ladi Prosek [mai

Re: [Qemu-devel] [qemu-s390x] [PATCH 1/6] accel/tcg: add size paremeter in tlb_fill()

2018-01-10 Thread David Hildenbrand
On 09.01.2018 00:10, Laurent Vivier wrote: > The MC68040 MMU provides the size of the access that > triggers the page fault. > > This size is set in the Special Status Word which > is written in the stack frame of the access fault > exception. > > So we need the size in m68k_cpu_unassigned_access

Re: [Qemu-devel] [PATCH v4 04/11] tests: Use consistent names and sizes for migration

2018-01-10 Thread Juan Quintela
Peter Xu wrote: > On Fri, Jan 05, 2018 at 10:52:39PM +0100, Juan Quintela wrote: >> Signed-off-by: Juan Quintela >> --- >> tests/migration-test.c | 12 ++-- >> 1 file changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/tests/migration-test.c b/tests/migration-test.c >> index d81

Re: [Qemu-devel] [PATCH v4 05/11] tests: Add deprecated commands migration test

2018-01-10 Thread Juan Quintela
Peter Xu wrote: > On Fri, Jan 05, 2018 at 10:52:40PM +0100, Juan Quintela wrote: >> We add deprecated commands on a new test, so we don't have to add it >> on normal tests. >> >> Signed-off-by: Juan Quintela >> --- >> tests/migration-test.c | 59 >> +

Re: [Qemu-devel] [PATCH v4 02/11] tests: Migration ppc test was missing arguments

2018-01-10 Thread Juan Quintela
Peter Xu wrote: > On Fri, Jan 05, 2018 at 10:52:37PM +0100, Juan Quintela wrote: >> Argument file is also needed there. >> >> Signed-off-by: Juan Quintela > > Reviewed-by: Peter Xu > > Does it also mean this? > > Fixes: aaf89c8a49a8c ("test: port postcopy test to ppc64") Dunno. I was trying t

Re: [Qemu-devel] [PATCH v4 04/11] tests: Use consistent names and sizes for migration

2018-01-10 Thread Peter Xu
On Wed, Jan 10, 2018 at 09:43:48AM +0100, Juan Quintela wrote: > Peter Xu wrote: > > On Fri, Jan 05, 2018 at 10:52:39PM +0100, Juan Quintela wrote: > >> Signed-off-by: Juan Quintela > >> --- > >> tests/migration-test.c | 12 ++-- > >> 1 file changed, 6 insertions(+), 6 deletions(-) > >>

Re: [Qemu-devel] [PATCH v4 05/11] tests: Add deprecated commands migration test

2018-01-10 Thread Peter Xu
On Wed, Jan 10, 2018 at 09:46:49AM +0100, Juan Quintela wrote: > Peter Xu wrote: > > On Fri, Jan 05, 2018 at 10:52:40PM +0100, Juan Quintela wrote: > >> We add deprecated commands on a new test, so we don't have to add it > >> on normal tests. > >> > >> Signed-off-by: Juan Quintela > >> --- > >>

Re: [Qemu-devel] [PATCH qemu v3] RFC: ppc/spapr: Receive and store device tree blob from SLOF

2018-01-10 Thread David Gibson
On Mon, Jan 08, 2018 at 07:35:43PM +1100, Alexey Kardashevskiy wrote: > On 03/01/18 11:09, David Gibson wrote: > > On Tue, Jan 02, 2018 at 05:13:09PM +1100, Alexey Kardashevskiy wrote: > >> On 11/12/17 17:20, Alexey Kardashevskiy wrote: > >>> On 09/11/17 17:38, David Gibson wrote: > On Tue, No

Re: [Qemu-devel] [PATCH V6 4/5] pvrdma: initial implementation

2018-01-10 Thread Marcel Apfelbaum
Hi Cornelia, On 09/01/2018 12:39, Cornelia Huck wrote: On Sun, 7 Jan 2018 14:32:23 +0200 Marcel Apfelbaum wrote: From: Yuval Shaia PVRDMA is the QEMU implementation of VMware's paravirtualized RDMA device. It works with its Linux Kernel driver AS IS, no need for any special guest modificat

Re: [Qemu-devel] [PATCH v4 00/11] Add make check tests for Migration

2018-01-10 Thread Peter Xu
On Wed, Jan 10, 2018 at 02:42:52PM +0800, Peter Xu wrote: > On Fri, Jan 05, 2018 at 10:52:35PM +0100, Juan Quintela wrote: > > > > Hi > > > > In v4: > > > > Based-on: 20180105205109.683-1-quint...@redhat.com > > > > Changes: > > - rebase on top on v4 info_migrate patches > > - Tune sleeps to ma

[Qemu-devel] [PATCH v4 5/9] block/nvme: Implement .bdrv_(un)register_buf

2018-01-10 Thread Fam Zheng
Forward these two calls to the IOVA manager. Signed-off-by: Fam Zheng --- block/nvme.c | 24 1 file changed, 24 insertions(+) diff --git a/block/nvme.c b/block/nvme.c index 5162272e5b..7042743929 100644 --- a/block/nvme.c +++ b/block/nvme.c @@ -1089,6 +1089,27 @@ static

[Qemu-devel] [PATCH v4 1/9] stubs: Add stubs for ram block API

2018-01-10 Thread Fam Zheng
These functions will be wanted by block-obj-y but the actual definition is in obj-y, so stub them to keep the linker happy. Signed-off-by: Fam Zheng Acked-by: Paolo Bonzini --- stubs/Makefile.objs | 1 + stubs/ram-block.c | 16 2 files changed, 17 insertions(+) create mode

[Qemu-devel] [PATCH v4 4/9] block: Introduce buf register API

2018-01-10 Thread Fam Zheng
Allow block driver to map and unmap a buffer for later I/O, as a performance hint. Signed-off-by: Fam Zheng --- block/block-backend.c | 10 ++ block/io.c | 24 include/block/block.h | 11 ++- include/block/block_int.h

[Qemu-devel] [PATCH v4 0/9] block: Add VFIO based driver for NVMe device

2018-01-10 Thread Fam Zheng
v4: - Rebase, address Stefan's comments. - Add QAPI and doc patches. v3: Rebase, small tweaks/fixes and add locks to provide basic thread safety (basic because it is not really tested). v2: - Implement "split vfio addr space" appraoch. [Paolo] - Add back 'device reset' in nvme_clo

[Qemu-devel] [PATCH v4 2/9] util: Introduce vfio helpers

2018-01-10 Thread Fam Zheng
This is a library to manage the host vfio interface, which could be used to implement userspace device driver code in QEMU such as NVMe or net controllers. Signed-off-by: Fam Zheng --- include/qemu/vfio-helpers.h | 30 ++ util/Makefile.objs | 1 + util/trace-events | 11 +

Re: [Qemu-devel] [PATCH v4 02/11] tests: Migration ppc test was missing arguments

2018-01-10 Thread Laurent Vivier
On 10/01/2018 09:47, Juan Quintela wrote: > Peter Xu wrote: >> On Fri, Jan 05, 2018 at 10:52:37PM +0100, Juan Quintela wrote: >>> Argument file is also needed there. >>> >>> Signed-off-by: Juan Quintela >> >> Reviewed-by: Peter Xu >> >> Does it also mean this? >> >> Fixes: aaf89c8a49a8c ("test:

[Qemu-devel] [PATCH v4 8/9] docs: Add section for NVMe VFIO driver

2018-01-10 Thread Fam Zheng
Signed-off-by: Fam Zheng --- docs/qemu-block-drivers.texi | 32 1 file changed, 32 insertions(+) diff --git a/docs/qemu-block-drivers.texi b/docs/qemu-block-drivers.texi index 503c1847aa..66b27cc4f7 100644 --- a/docs/qemu-block-drivers.texi +++ b/docs/qemu-block-

[Qemu-devel] [PATCH v4 6/9] qemu-img: Map bench buffer

2018-01-10 Thread Fam Zheng
Signed-off-by: Fam Zheng --- qemu-img.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index 68b375f998..28d0e4e9f8 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -3862,6 +3862,7 @@ static int img_bench(int argc, char **argv) struct timeval t

[Qemu-devel] [PATCH v4 3/9] block: Add VFIO based NVMe driver

2018-01-10 Thread Fam Zheng
This is a new protocol driver that exclusively opens a host NVMe controller through VFIO. It achieves better latency than linux-aio by completely bypassing host kernel vfs/block layer. $rw-$bs-$iodepth linux-aio nvme:// randread-4k-1 10

[Qemu-devel] [PATCH v4 7/9] block: Move NVMe constants to a separate header

2018-01-10 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block/nvme.c | 7 +- hw/block/nvme.h | 698 +- include/block/nvme.h | 700 +++ 3 files changed, 702 insertions(+), 703 deletions(-) create mode 100644 inclu

[Qemu-devel] [PATCH v4 9/9] qapi: Add NVMe driver options to the schema

2018-01-10 Thread Fam Zheng
Signed-off-by: Fam Zheng --- qapi/block-core.json | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index e94a6881b2..fd6c94454d 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -2237,7 +2237,7 @@ 'da

Re: [Qemu-devel] [PATCH V6 4/5] pvrdma: initial implementation

2018-01-10 Thread Marcel Apfelbaum
On 09/01/2018 14:51, Cornelia Huck wrote: On Tue, 9 Jan 2018 13:08:33 +0200 Yuval Shaia wrote: On Tue, Jan 09, 2018 at 11:39:11AM +0100, Cornelia Huck wrote: On Sun, 7 Jan 2018 14:32:23 +0200 Marcel Apfelbaum wrote: diff --git a/hw/rdma/vmw/pvrdma_dev_api.h b/hw/rdma/vmw/pvrdma_dev_api.h

Re: [Qemu-devel] [PATCH v2] hpet: recover timer offset correctly

2018-01-10 Thread Pavel Dovgalyuk
> From: Juan Quintela [mailto:quint...@redhat.com] > "Pavel Dovgalyuk" wrote: > >> From: Juan Quintela [mailto:quint...@redhat.com] > If you *don't* use a needed function then please just increase the > version. You are just breaking compatibility anyways. The whole point > of subsections is tha

Re: [Qemu-devel] [PATCH V6 4/5] pvrdma: initial implementation

2018-01-10 Thread Cornelia Huck
On Wed, 10 Jan 2018 11:28:59 +0200 Marcel Apfelbaum wrote: > On 09/01/2018 14:51, Cornelia Huck wrote: > > On Tue, 9 Jan 2018 13:08:33 +0200 > > Yuval Shaia wrote: > > > >> On Tue, Jan 09, 2018 at 11:39:11AM +0100, Cornelia Huck wrote: > >>> On Sun, 7 Jan 2018 14:32:23 +0200 > >>> Marcel A

Re: [Qemu-devel] [PATCH 2/6] hw/sd/milkymist-memcard: split realize() out of SysBusDevice init()

2018-01-10 Thread Michael Walle
Hi Philippe, Am 2018-01-09 19:16, schrieb Philippe Mathieu-Daudé: Hi Michael, Am 2018-01-03 17:23, schrieb Philippe Mathieu-Daudé: Create the SDCard in the realize() function. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/milkymist-memcard.c | 24 +++- 1 file changed

Re: [Qemu-devel] [PATCH v2] hpet: recover timer offset correctly

2018-01-10 Thread Juan Quintela
"Pavel Dovgalyuk" wrote: >> From: Juan Quintela [mailto:quint...@redhat.com] >> "Pavel Dovgalyuk" wrote: >> >> From: Juan Quintela [mailto:quint...@redhat.com] >> If you *don't* use a needed function then please just increase the >> version. You are just breaking compatibility anyways. The whol

Re: [Qemu-devel] [PATCH 1/1] io/channel-websock: handle continuous reads without any data

2018-01-10 Thread Edgar Kaziakhmedov
ping On 12/28/2017 12:36 PM, Denis V. Lunev wrote: From: Edgar Kaziakhmedov According to the current implementation of websocket protocol in QEMU, qio_channel_websock_handshake_io tries to read handshake from the channel to start communication over tcp socket. But this subroutine doesn't cove

[Qemu-devel] [PATCH v3] hpet: recover timer offset correctly

2018-01-10 Thread Pavel Dovgalyuk
HPET saves its state by calculating the current time and recovers timer offset using this calculated value. But these calculations include divisions and multiplications. Therefore the timer state cannot be recovered precise enough. This patch introduces saving of the original value of the offset to

Re: [Qemu-devel] [PATCH v2] hpet: recover timer offset correctly

2018-01-10 Thread Pavel Dovgalyuk
> -Original Message- > From: Juan Quintela [mailto:quint...@redhat.com] > Sent: Wednesday, January 10, 2018 12:51 PM > To: Pavel Dovgalyuk > Cc: 'Pavel Dovgalyuk'; qemu-devel@nongnu.org; m...@redhat.com; > dgilb...@redhat.com; > maria.klimushenk...@ispras.ru; pbonz...@redhat.com > Subjec

Re: [Qemu-devel] [PATCH 0/2] target/arm: split out vfp_expand_imm

2018-01-10 Thread Alex Bennée
Richard Henderson writes: > One more piece of target/arm prep work from my SVE branch. > > I saw that Alex was touching the same bit of code in his ARMv8.2 > fp16 patch set and thought we should coordinate on this. Thanks, I'll roll them into my series. > > > r~ > > > Richard Henderson (2): >

Re: [Qemu-devel] [PATCH v4 02/11] tests: Migration ppc test was missing arguments

2018-01-10 Thread Laurent Vivier
On 10/01/2018 10:21, Laurent Vivier wrote: > On 10/01/2018 09:47, Juan Quintela wrote: >> Peter Xu wrote: >>> On Fri, Jan 05, 2018 at 10:52:37PM +0100, Juan Quintela wrote: Argument file is also needed there. Signed-off-by: Juan Quintela >>> >>> Reviewed-by: Peter Xu >>> >>> Does

Re: [Qemu-devel] [PATCH v5 3/7] vhost: Simplify ring verification checks

2018-01-10 Thread Igor Mammedov
On Mon, 8 Jan 2018 17:54:50 + "Dr. David Alan Gilbert" wrote: > * Igor Mammedov (imamm...@redhat.com) wrote: > > On Mon, 18 Dec 2017 20:13:36 + > > "Dr. David Alan Gilbert (git)" wrote: > > > > > From: "Dr. David Alan Gilbert" > > > > > > vhost_verify_ring_mappings() were used to ve

Re: [Qemu-devel] [PULL 07/11] cpu-exec: don't overwrite exception_index

2018-01-10 Thread Peter Maydell
On 10 January 2018 at 07:04, Pavel Dovgalyuk wrote: > The failure cause is in incorrect interrupt processing. > When ARM processes hardware interrupt in arm_cpu_exec_interrupt(), > it executes cs->exception_index = excp_idx; > > This assumes, that the exception will be processed later. > But it is

Re: [Qemu-devel] [PATCH v21 2/5 RESEND] virtio-balloon: VIRTIO_BALLOON_F_SG

2018-01-10 Thread Wei Wang
On 01/09/2018 10:42 PM, Tetsuo Handa wrote: Wei Wang wrote: - enable OOM to free inflated pages maintained in the local temporary list. I do want to see it before applying this patch. Fine, then what do you think of the method I shared in your post here: https://patchwork.kernel.org/patc

Re: [Qemu-devel] [Qemu-discuss] ppc and icount

2018-01-10 Thread Peter Maydell
On 10 January 2018 at 08:57, Steven Seeger wrote: > Sorry for another post. I did a bisect and found what is the bad commit for > me: > > 044897ef4a22af89aecb8df509477beba0a2e0ce is the first bad commit > commit 044897ef4a22af89aecb8df509477beba0a2e0ce > Author: Richard Purdie > Date: Mon Dec 4

Re: [Qemu-devel] [PATCH v1 05/21] RISC-V CPU Helpers

2018-01-10 Thread Stefan O'Rear
On Tue, Jan 2, 2018 at 11:12 PM, Richard Henderson wrote: >> +case CSR_MISA: { >> +if (!(val_to_write & (1L << ('F' - 'A' { >> +val_to_write &= ~(1L << ('D' - 'A')); >> +} >> + >> +/* allow MAFDC bits in MISA to be modified */ >> +target_ulong ma

Re: [Qemu-devel] [Qemu-ppc] [PULL 00/12] ppc-for-2.12 queue 20180108

2018-01-10 Thread luigi burdo
Hi devs sorry if i enter in the discussion about. gcc gave errors in building this queue. here i paste my build log. https://pastebin.com/fXw2Whrq This is my machine infos and so and so Architecture:ppc64 CPU op-mode(s): 32-bit, 64-bit Byte Order: Big Endian CPU(s):

Re: [Qemu-devel] [Qemu-ppc] [PULL 00/12] ppc-for-2.12 queue 20180108

2018-01-10 Thread Peter Maydell
On 10 January 2018 at 10:37, luigi burdo wrote: > Hi devs sorry if i enter in the discussion about. > > gcc gave errors in building this queue. > > here i paste my build log. > > https://pastebin.com/fXw2Whrq Thanks. This is the relevant bit of the log: /home/amigaone/src/new/tags/ppc-for-2.12-2

Re: [Qemu-devel] [PULL 07/11] cpu-exec: don't overwrite exception_index

2018-01-10 Thread Pavel Dovgalyuk
> From: Peter Maydell [mailto:peter.mayd...@linaro.org] > On 10 January 2018 at 07:04, Pavel Dovgalyuk wrote: > > The failure cause is in incorrect interrupt processing. > > When ARM processes hardware interrupt in arm_cpu_exec_interrupt(), > > it executes cs->exception_index = excp_idx; > > > > T

Re: [Qemu-devel] [PATCH v4 02/11] tests: Migration ppc test was missing arguments

2018-01-10 Thread Juan Quintela
Laurent Vivier wrote: > On 10/01/2018 10:21, Laurent Vivier wrote: >> On 10/01/2018 09:47, Juan Quintela wrote: >>> Peter Xu wrote: On Fri, Jan 05, 2018 at 10:52:37PM +0100, Juan Quintela wrote: > Argument file is also needed there. > > Signed-off-by: Juan Quintela Rev

Re: [Qemu-devel] [PATCH v3] hpet: recover timer offset correctly

2018-01-10 Thread Juan Quintela
Pavel Dovgalyuk wrote: > HPET saves its state by calculating the current time and recovers timer > offset using this calculated value. But these calculations include > divisions and multiplications. Therefore the timer state cannot be recovered > precise enough. > This patch introduces saving of t

Re: [Qemu-devel] [PATCH v4 02/11] tests: Migration ppc test was missing arguments

2018-01-10 Thread Laurent Vivier
On 10/01/2018 11:43, Juan Quintela wrote: > Laurent Vivier wrote: >> On 10/01/2018 10:21, Laurent Vivier wrote: >>> On 10/01/2018 09:47, Juan Quintela wrote: Peter Xu wrote: > On Fri, Jan 05, 2018 at 10:52:37PM +0100, Juan Quintela wrote: >> Argument file is also needed there. >>

Re: [Qemu-devel] [PATCH] acpi: switch to a dummy SSDT

2018-01-10 Thread Igor Mammedov
On Tue, 9 Jan 2018 15:58:11 +0200 "Michael S. Tsirkin" wrote: > We prefer not changing table sizes depending on parameters, > that's why we create a dummy table rather than just drop > the MCFG table. > > However, a table named "QEMU" could be put to a better > use than just a stub, e.g. we coul

Re: [Qemu-devel] [PATCH] acpi: switch to a dummy SSDT

2018-01-10 Thread Michael S. Tsirkin
On Wed, Jan 10, 2018 at 12:25:34PM +0100, Igor Mammedov wrote: > On Tue, 9 Jan 2018 15:58:11 +0200 > "Michael S. Tsirkin" wrote: > > > We prefer not changing table sizes depending on parameters, > > that's why we create a dummy table rather than just drop > > the MCFG table. > > > > However, a t

Re: [Qemu-devel] [PATCH] acpi: switch to a dummy SSDT

2018-01-10 Thread Igor Mammedov
On Wed, 10 Jan 2018 13:29:09 +0200 "Michael S. Tsirkin" wrote: > On Wed, Jan 10, 2018 at 12:25:34PM +0100, Igor Mammedov wrote: > > On Tue, 9 Jan 2018 15:58:11 +0200 > > "Michael S. Tsirkin" wrote: > > > > > We prefer not changing table sizes depending on parameters, > > > that's why we create

Re: [Qemu-devel] [PATCH v4 04/11] tests: Use consistent names and sizes for migration

2018-01-10 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela > --- > tests/migration-test.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/tests/migration-test.c b/tests/migration-test.c > index d81f22118b..f469235d0b 100644 > --- a/tests/mig

Re: [Qemu-devel] [PATCH v4 04/11] tests: Use consistent names and sizes for migration

2018-01-10 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Wed, Jan 10, 2018 at 09:43:48AM +0100, Juan Quintela wrote: > > Peter Xu wrote: > > > On Fri, Jan 05, 2018 at 10:52:39PM +0100, Juan Quintela wrote: > > >> Signed-off-by: Juan Quintela > > >> --- > > >> tests/migration-test.c | 12 ++-- > > >> 1

Re: [Qemu-devel] [PATCH] acpi: switch to a dummy SSDT

2018-01-10 Thread Michael S. Tsirkin
On Wed, Jan 10, 2018 at 12:41:52PM +0100, Igor Mammedov wrote: > On Wed, 10 Jan 2018 13:29:09 +0200 > "Michael S. Tsirkin" wrote: > > > On Wed, Jan 10, 2018 at 12:25:34PM +0100, Igor Mammedov wrote: > > > On Tue, 9 Jan 2018 15:58:11 +0200 > > > "Michael S. Tsirkin" wrote: > > > > > > > We prefe

Re: [Qemu-devel] [PATCH v14 9/9] target-arm: kvm64: handle SIGBUS signal from kernel or KVM

2018-01-10 Thread gengdongjiu
Hi Peter, Thanks for the mail and comments. On 2018/1/10 1:14, Peter Maydell wrote: > On 28 December 2017 at 05:54, Dongjiu Geng wrote: >> Add SIGBUS signal handler. In this handler, it checks the SIGBUS type, >> translates the host VA which is delivered by host to guest PA, then fill >> this P

Re: [Qemu-devel] [PATCH v14 4/9] ACPI: enable APEI GHES in the configure file

2018-01-10 Thread gengdongjiu
On 2018/1/10 1:16, Peter Maydell wrote: > On 28 December 2017 at 05:54, Dongjiu Geng wrote: >> Add CONFIG_ACPI_APEI configuration in the arm-softmmu.mak >> and add build choice in the Makefile.objs. >> >> Signed-off-by: Dongjiu Geng >> --- >> default-configs/arm-softmmu.mak | 1 + >> hw/acpi/Mak

Re: [Qemu-devel] [PATCH] acpi: switch to a dummy SSDT

2018-01-10 Thread Igor Mammedov
On Wed, 10 Jan 2018 13:55:37 +0200 "Michael S. Tsirkin" wrote: > On Wed, Jan 10, 2018 at 12:41:52PM +0100, Igor Mammedov wrote: > > On Wed, 10 Jan 2018 13:29:09 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, Jan 10, 2018 at 12:25:34PM +0100, Igor Mammedov wrote: > > > > On Tue, 9 J

Re: [Qemu-devel] [PATCH 1/1] io/channel-websock: handle continuous reads without any data

2018-01-10 Thread Daniel P. Berrange
On Thu, Dec 28, 2017 at 12:36:18PM +0300, Denis V. Lunev wrote: > From: Edgar Kaziakhmedov > > According to the current implementation of websocket protocol in QEMU, > qio_channel_websock_handshake_io tries to read handshake from the > channel to start communication over tcp socket. But this subr

Re: [Qemu-devel] [PATCH] crypto/ivgen-essiv: Fix problem with address sanitizer of Clang

2018-01-10 Thread Daniel P. Berrange
On Tue, Jan 02, 2018 at 04:37:45PM +0100, Thomas Huth wrote: > When compiling QEMU with clang and -fsanitize=address, I get the > following error: > > ==9185==ERROR: AddressSanitizer: stack-buffer-overflow on address > 0x7ffc7e9adf2f at pc 0x564cba001d88 bp 0x7ffc7e9adeb0 sp 0x7ffc7e9adea8 > READ

[Qemu-devel] [PATCH v10 02/14] migration: Rename initial_bytes

2018-01-10 Thread Juan Quintela
Now it is called qemu_file_bytes that reflects better what it does, and we create qemu_file_bytes_now to not have to call qemu_ftell() twice. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/migration.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-)

[Qemu-devel] [PATCH v10 03/14] migration: Drop current address parameter from save_zero_page()

2018-01-10 Thread Juan Quintela
It already has RAMBlock and offset, it can calculate it itself. Signed-off-by: Juan Quintela --- migration/ram.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index cb1950f3eb..5a109efeda 100644 --- a/migration/ram.c +++ b/migra

[Qemu-devel] [PATCH v10 05/14] migration: Create ram_multifd_page

2018-01-10 Thread Juan Quintela
The function still don't use multifd, but we have simplified ram_save_page, xbzrle and RDMA stuff is gone. We have added a new counter and a new flag for this type of pages. Signed-off-by: Juan Quintela -- Add last_page parameter Add commets for done and address Remove multifd field, it is the

[Qemu-devel] [PATCH v10 01/14] migration: Make migrate_fd_error() the owner of the Error

2018-01-10 Thread Juan Quintela
So far, we had to free the error after each caller, so just do it here. Once there, tls.c was leaking the error. Signed-off-by: Juan Quintela --- migration/channel.c | 1 - migration/migration.c | 10 -- migration/migration.h | 4 ++-- migration/socket.c| 1 - 4 files changed,

[Qemu-devel] [PATCH v10 08/14] migration: Transfer pages over new channels

2018-01-10 Thread Juan Quintela
We switch for sending the page number to send real pages. Signed-off-by: Juan Quintela -- Remove the HACK bit, now we have the function that calculates the size of a page exported. Rename multifd_pages{_now}, to sent pages Remove multifd pages field, it is the same than normal pages Merge test

[Qemu-devel] [RFC 00/14] Multifd

2018-01-10 Thread Juan Quintela
Hi For V10: - It is a request for comments - I changed as suggested from Paolo on KVM forum to send page metadata over the channels - I simplified lots of things - Added reviews - it is not finished, in no-particular order: * old code is not removed for comparison for the people that looked

[Qemu-devel] [PATCH v10 07/14] migration: Create thread infrastructure for multifd recv side

2018-01-10 Thread Juan Quintela
We make the locking and the transfer of information specific, even if we are still receiving things through the main thread. Signed-off-by: Juan Quintela -- We split when we create the main channel and where we start the main migration thread, so we wait for the creation of the other threads.

[Qemu-devel] [PATCH v10 06/14] migration: Send the fd number which we are going to use for this page

2018-01-10 Thread Juan Quintela
We are still sending the page through the main channel, that would change later in the series Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/migration/ram.c b/migration/ram.c i

[Qemu-devel] [PATCH v10 11/14] LOCAL: use trace events for migration-test

2018-01-10 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/migration-test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/migration-test.c b/tests/migration-test.c index 488ae89f34..d0b0c1b64b 100644 --- a/tests/migration-test.c +++ b/tests/migration-test.c @@ -457,11 +457,13 @@ static void test_migrat

[Qemu-devel] [PATCH v10 04/14] migration: Start of multiple fd work

2018-01-10 Thread Juan Quintela
We create new channels for each new thread created. We send through them in a packed struct. This way we can check we connect the right channels in both sides. Signed-off-by: Juan Quintela -- Split SocketArgs into incoming and outgoing args Use UUID's on the initial message, so we are sure we

Re: [Qemu-devel] [RFC v6 07/27] monitor: unify global init

2018-01-10 Thread Eric Blake
On 01/10/2018 02:26 AM, Peter Xu wrote: >> The later initialization of the monitor_lock mutex is a potential >> semantic change. Please beef up the commit message to document why it >> is safe. In fact, I requested this back on my review of v1, but it >> still hasn't been done. :( >> >> https://

[Qemu-devel] [PATCH v10 09/14] migration: Flush receive queue

2018-01-10 Thread Juan Quintela
Each time that we sync the bitmap, it is a possiblity that we receive a page that is being processed by a different thread. We fix this problem just making sure that we wait for all receiving threads to finish its work before we procedeed with the next stage. We are low on page flags, so we use a

[Qemu-devel] [PATCH v10 10/14] migration: Add multifd test

2018-01-10 Thread Juan Quintela
We set the x-multifd-page-count and x-multifd-channels. Signed-off-by: Juan Quintela --- tests/migration-test.c | 50 ++ 1 file changed, 50 insertions(+) diff --git a/tests/migration-test.c b/tests/migration-test.c index eb44a95aa9..488ae89f34 100

[Qemu-devel] [PATCH v10 12/14] migration: Sent the page list over the normal thread

2018-01-10 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/ram.c | 69 + 1 file changed, 60 insertions(+), 9 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index b1ad7b2730..f636c7da0a 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -411

Re: [Qemu-devel] [PATCH v4 1/2] migration: Create tcp_port parameter

2018-01-10 Thread Daniel P. Berrange
On Fri, Jan 05, 2018 at 09:51:08PM +0100, Juan Quintela wrote: > It will be used to store the uri tcp_port parameter. This is the only > parameter than can change and we can need to be able to connect to it. > > Signed-off-by: Juan Quintela > > -- > > This used to be uri parameter, but it has

[Qemu-devel] [PATCH v10 14/14] all works

2018-01-10 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/ram.c | 69 - 1 file changed, 34 insertions(+), 35 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 6e45f668d1..a689d4a218 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -67

[Qemu-devel] [PATCH v10 13/14] migration: Add multifd_send_packet trace

2018-01-10 Thread Juan Quintela
I need the block name, so I can't do that sooner. Signed-off-by: Juan Quintela --- migration/ram.c| 2 ++ migration/trace-events | 1 + 2 files changed, 3 insertions(+) diff --git a/migration/ram.c b/migration/ram.c index f636c7da0a..6e45f668d1 100644 --- a/migration/ram.c +++ b/migrati

Re: [Qemu-devel] [PATCH v2 2/3] qcow2: handle reopening bitmaps on bdrv_invalidate_cache

2018-01-10 Thread Vladimir Sementsov-Ogievskiy
22.12.2017 19:28, Kevin Wolf wrote: Am 22.12.2017 um 17:12 hat Vladimir Sementsov-Ogievskiy geschrieben: 22.12.2017 18:43, Kevin Wolf wrote: Am 22.12.2017 um 15:25 hat Vladimir Sementsov-Ogievskiy geschrieben: 22.12.2017 16:39, Kevin Wolf wrote: Am 12.12.2017 um 17:04 hat Vladimir Sementsov-O

Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U

2018-01-10 Thread Daniel P. Berrange
On Mon, Jan 08, 2018 at 06:57:29PM +0100, Kevin Wolf wrote: > Am 08.01.2018 um 18:07 hat Nir Soffer geschrieben: > > On Mon, Jan 8, 2018 at 4:48 PM Kevin Wolf wrote: > > > > > Am 05.01.2018 um 07:55 hat Fam Zheng geschrieben: > > > > Management and users are accustomed to "qemu-img info" to query

Re: [Qemu-devel] [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U

2018-01-10 Thread Daniel P. Berrange
On Mon, Jan 08, 2018 at 03:41:36PM +0100, Kevin Wolf wrote: > Am 05.01.2018 um 07:55 hat Fam Zheng geschrieben: > > Management and users are accustomed to "qemu-img info" to query status of > > images even when they are used by guests. Since image locking was added, > > the -U > > (--force-share)

Re: [Qemu-devel] Call for GSoC & Outreachy 2018 mentors & project ideas

2018-01-10 Thread Stefan Hajnoczi
On Tue, Jan 9, 2018 at 9:45 PM, Alistair Francis wrote: > Can anyone who has done this before chime in. > > What do you think about getting someone to cleanup and improve the GDB > support in QEMU? Would that be the right difficulty of task for a GSoC > project? There is not enough information to

Re: [Qemu-devel] how to pass pcid to guest?

2018-01-10 Thread Daniel P. Berrange
On Mon, Jan 08, 2018 at 04:07:53PM -0600, Eric Blake wrote: > On 01/08/2018 02:03 PM, Stefan Priebe - Profihost AG wrote: > > Hello, > > > > for meltdown mitigation and performance it's important to have the pcid > > flag passed down to the guest (f.e. > > https://groups.google.com/forum/m/#!topic

Re: [Qemu-devel] [RFC v6 04/27] qobject: let object_property_get_str() use new API

2018-01-10 Thread Eric Blake
On 01/10/2018 01:57 AM, Peter Xu wrote: > On Tue, Jan 09, 2018 at 04:53:40PM -0600, Eric Blake wrote: >> On 12/19/2017 02:45 AM, Peter Xu wrote: >>> We can simplify object_property_get_str() using the new >>> qobject_get_try_str(). >>> >>> Reviewed-by: Fam Zheng >>> Reviewed-by: Stefan Hajnoczi >

Re: [Qemu-devel] [PATCH v4 00/46] Windbg supporting

2018-01-10 Thread Paolo Bonzini
On 10/01/2018 09:40, Pavel Dovgalyuk wrote: >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] >> On 22/12/2017 14:21, Pavel Dovgalyuk wrote: >>> Paolo, Ladi finished the review. >>> What about merging these into upstream? >> Sure, in the new year though. > Now? Ok, will do. Paolo

Re: [Qemu-devel] [PATCH v5 3/4] vhost: fix memslot limit check

2018-01-10 Thread Igor Mammedov
On Wed, 10 Jan 2018 00:40:12 +0800 Jay Zhou wrote: > Since used_memslots will be updated to the actual value after > registering memory listener for the first time, move the > memslots limit checking to the right place. > > Signed-off-by: Jay Zhou Reviewed-by: Igor Mammedov > --- > hw/virtio

[Qemu-devel] [PATCH] chardev/char-socket: add POLLHUP handler

2018-01-10 Thread Klim Kireev
The following behavior was observed for QEMU configured by libvirt to use guest agent as usual for the guests without virtio-serial driver (Windows or the guest remaining in BIOS stage). In QEMU on first connect to listen character device socket the listen socket is removed from poll just after th

Re: [Qemu-devel] [PATCH v4 00/46] Windbg supporting

2018-01-10 Thread Peter Maydell
On 10 January 2018 at 13:08, Paolo Bonzini wrote: > On 10/01/2018 09:40, Pavel Dovgalyuk wrote: >>> From: Paolo Bonzini [mailto:pbonz...@redhat.com] >>> On 22/12/2017 14:21, Pavel Dovgalyuk wrote: Paolo, Ladi finished the review. What about merging these into upstream? >>> Sure, in the n

Re: [Qemu-devel] [PATCH] target/i386: hax: Move hax_setup_qemu_emulator.

2018-01-10 Thread Paolo Bonzini
On 10/01/2018 07:47, Tao Wu wrote: > hax_setup_qemu_emulator reference env->efer which is updated in > hax_get_msrs, so it has to be called after hax_get_msrs. This fix > the bug that sometimes dump_state show 32 bits regs even in 64 bits > mode. > > Signed-off-by: Tao Wu > --- > target/i386/hax

Re: [Qemu-devel] [PATCH 1/1] io/channel-websock: handle continuous reads without any data

2018-01-10 Thread Edgar Kaziakhmedov
On 01/10/2018 03:33 PM, Daniel P. Berrange wrote: On Thu, Dec 28, 2017 at 12:36:18PM +0300, Denis V. Lunev wrote: From: Edgar Kaziakhmedov According to the current implementation of websocket protocol in QEMU, qio_channel_websock_handshake_io tries to read handshake from the channel to start

Re: [Qemu-devel] [PULL 00/12] ppc-for-2.12 queue 20180108

2018-01-10 Thread Paolo Bonzini
On 10/01/2018 02:55, David Gibson wrote: > On Tue, Jan 09, 2018 at 03:15:25PM +, Peter Maydell wrote: >> On 9 January 2018 at 12:16, David Gibson wrote: >>> Thanks. Even if you can identify which patch it is and we can >>> postpone that one would be a bug help. >> >> Bisection blames this one

Re: [Qemu-devel] [PATCH 1/1] io/channel-websock: handle continuous reads without any data

2018-01-10 Thread Daniel P. Berrange
On Wed, Jan 10, 2018 at 04:31:21PM +0300, Edgar Kaziakhmedov wrote: > > > On 01/10/2018 03:33 PM, Daniel P. Berrange wrote: > > On Thu, Dec 28, 2017 at 12:36:18PM +0300, Denis V. Lunev wrote: > > > From: Edgar Kaziakhmedov > > > > > > According to the current implementation of websocket protoco

Re: [Qemu-devel] [PATCH v5 1/4] vhost: remove assertion to prevent crash

2018-01-10 Thread Igor Mammedov
On Wed, 10 Jan 2018 00:39:35 +0800 Jay Zhou wrote: > Start QEMU with more DIMM devices than limit but without any > vhost backends and then hotplug a vhost user backend, the VM > will be crashed. > Instead of asserting in vhost_user_set_mem_table(), error number > is used to gracefully prevent de

Re: [Qemu-devel] [qemu-s390x] [PATCH 1/6] accel/tcg: add size paremeter in tlb_fill()

2018-01-10 Thread Laurent Vivier
Le 10/01/2018 à 09:43, David Hildenbrand a écrit : > On 09.01.2018 00:10, Laurent Vivier wrote: >> The MC68040 MMU provides the size of the access that >> triggers the page fault. >> >> This size is set in the Special Status Word which >> is written in the stack frame of the access fault >> excepti

Re: [Qemu-devel] [PATCH] acpi: switch to a dummy SSDT

2018-01-10 Thread Michael S. Tsirkin
On Wed, Jan 10, 2018 at 01:31:09PM +0100, Igor Mammedov wrote: > On Wed, 10 Jan 2018 13:55:37 +0200 > "Michael S. Tsirkin" wrote: > > > On Wed, Jan 10, 2018 at 12:41:52PM +0100, Igor Mammedov wrote: > > > On Wed, 10 Jan 2018 13:29:09 +0200 > > > "Michael S. Tsirkin" wrote: > > > > > > > On We

[Qemu-devel] [PATCH] cpu: flush TB cache when loading VMState

2018-01-10 Thread Pavel Dovgalyuk
Flushing TB cache is required because TBs key in the cache may match different code which existed in the previous state. Signed-off-by: Pavel Dovgalyuk Signed-off-by: Maria Klimushenkova --- exec.c |1 + 1 file changed, 1 insertion(+) diff --git a/exec.c b/exec.c index 4722e52..ff31e71 100

Re: [Qemu-devel] [PATCH] cpu: flush TB cache when loading VMState

2018-01-10 Thread Paolo Bonzini
On 10/01/2018 14:48, Pavel Dovgalyuk wrote: > Flushing TB cache is required because TBs key in the cache may match > different code which existed in the previous state. > > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Maria Klimushenkova > --- > exec.c |1 + > 1 file changed, 1 insertion

Re: [Qemu-devel] [PATCH v2 0/7] macro do/while (0) cleanup

2018-01-10 Thread Paolo Bonzini
On 09/01/2018 21:52, Eric Blake wrote: > ping Hmm, the actual posting of the patches wasn't CCed to qemu-trivial. Queued now, thanks. Paolo > On 12/01/2017 05:24 PM, Eric Blake wrote: >> Noticed this by chance in the tests/ directory, so I broadened >> it to a grep of the entire code base. I s

Re: [Qemu-devel] [PATCH v1 01/13] ui: remove 'sync' parametr from vnc_update_client

2018-01-10 Thread Daniel P. Berrange
On Mon, Jan 08, 2018 at 12:08:49PM +0100, Gerd Hoffmann wrote: > On Mon, Dec 18, 2017 at 07:12:16PM +, Daniel P. Berrange wrote: > > There is only one caller of vnc_update_client and that always passes false > > for the 'sync' parameter. > > Unused since commit 50628d3479e4f9aa97e323506856e394

Re: [Qemu-devel] [PATCH 2/2] find_ram_offset: Align ram_addr_t allocation on long boundaries

2018-01-10 Thread Paolo Bonzini
On 05/01/2018 18:01, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The dirty bitmaps are built from 'long'sand there is fast-path code > for synchronising the case where the RAMBlock is aligned to the start > of a long boundary. Align the allocation to this boundary >

Re: [Qemu-devel] [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U

2018-01-10 Thread Kashyap Chamarthy
On Mon, Jan 08, 2018 at 03:41:36PM +0100, Kevin Wolf wrote: > Am 05.01.2018 um 07:55 hat Fam Zheng geschrieben: > > Management and users are accustomed to "qemu-img info" to query status of > > images even when they are used by guests. Since image locking was added, > > the -U > > (--force-share)

Re: [Qemu-devel] [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U

2018-01-10 Thread Kevin Wolf
Am 10.01.2018 um 13:49 hat Daniel P. Berrange geschrieben: > On Mon, Jan 08, 2018 at 03:41:36PM +0100, Kevin Wolf wrote: > > Am 05.01.2018 um 07:55 hat Fam Zheng geschrieben: > > > Management and users are accustomed to "qemu-img info" to query status of > > > images even when they are used by gues

Re: [Qemu-devel] [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U

2018-01-10 Thread Daniel P. Berrange
On Wed, Jan 10, 2018 at 03:07:12PM +0100, Kevin Wolf wrote: > Am 10.01.2018 um 13:49 hat Daniel P. Berrange geschrieben: > > On Mon, Jan 08, 2018 at 03:41:36PM +0100, Kevin Wolf wrote: > > > Am 05.01.2018 um 07:55 hat Fam Zheng geschrieben: > > > > Management and users are accustomed to "qemu-img i

[Qemu-devel] [PATCH v2 0/2] find_ram_offset cleanups and alignment

2018-01-10 Thread Paolo Bonzini
These are basically David's patches, with a couple changes for clarity and robustness. Dr. David Alan Gilbert (2): find_ram_offset: Add comments and tracing find_ram_offset: Align ram_addr_t allocation on long boundaries exec.c | 33 ++--- trace-events | 4

[Qemu-devel] [PATCH 1/2] find_ram_offset: Add comments and tracing

2018-01-10 Thread Paolo Bonzini
From: "Dr. David Alan Gilbert" Add some comments and rename the "end" variable so I can understand the various nested loops. Add some tracing so I can see what they're doing. Signed-off-by: Dr. David Alan Gilbert Message-Id: <20180105170138.23357-2-dgilb...@redhat.com> Signed-off-by: Paolo Bon

Re: [Qemu-devel] [PATCH] block/iscsi: fix initialization of iTask in iscsi_co_get_block_status

2018-01-10 Thread Paolo Bonzini
On 08/01/2018 16:27, Peter Lieven wrote: > in case of unaligned requests or on a target that does not support > block provisioning we leave iTask uninitialized and check iTask.task > for NULL later. > > Fixes: e38bc23454ef763deb4405ebdee6a1081aa00bc8 > Cc: qemu-sta...@nongnu.org > Signed-off-by: P

  1   2   3   4   >