Re: [Qemu-devel] [PATCH v2] hpet: recover timer offset correctly

2018-01-09 Thread Pavel Dovgalyuk
Ping? Pavel Dovgalyuk > -Original Message- > From: Pavel Dovgalyuk [mailto:pavel.dovga...@ispras.ru] > Sent: Wednesday, December 20, 2017 1:02 PM > To: qemu-devel@nongnu.org > Cc: quint...@redhat.com; m...@redhat.com; dgilb...@redhat.com; > maria.klimushenk...@ispras.ru; > dovga...@ispra

[Qemu-devel] [qemu-web PATCH] spectre blog post: I accidentally a verb

2018-01-09 Thread Paolo Bonzini
Reported-by: Fam Zheng --- _posts/2018-01-04-spectre.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/_posts/2018-01-04-spectre.md b/_posts/2018-01-04-spectre.md index 353ac7c..aa0f5e4 100644 --- a/_posts/2018-01-04-spectre.md +++ b/_posts/2018-01-04-spectre.md @@ -60,7 +60,

Re: [Qemu-devel] [qemu-web PATCH] add a blog post about "Spectre"

2018-01-09 Thread Paolo Bonzini
On 09/01/2018 03:13, Fam Zheng wrote: > On Thu, 01/04 18:56, Paolo Bonzini wrote: >> +be required for non-x86 processors. If so, they will also posted to the > > Hi Paolo, they will also "be" posted? Thanks! Pushed the small fix. Paolo

Re: [Qemu-devel] [PATCH V6 3/5] docs: add pvrdma device documentation.

2018-01-09 Thread Cornelia Huck
On Sun, 7 Jan 2018 14:32:22 +0200 Marcel Apfelbaum wrote: > Signed-off-by: Marcel Apfelbaum > Signed-off-by: Yuval Shaia > Reviewed-by: Shamir Rabinovitch > --- > docs/pvrdma.txt | 254 > > 1 file changed, 254 insertions(+) > create

[Qemu-devel] [QEMU-PPC] [RFC 0/3] target/ppc: Rework spapr_caps

2018-01-09 Thread Suraj Jitindar Singh
The following patch series reworks the implementation of spapr_caps to allow for a increased number of possible values in the internal representation. It also adds 3 new tristate capabilities. A new H-Call is implemented which a guest will use to query the requirement for and availability of wor

[Qemu-devel] [QEMU-PPC] [RFC 2/3] hw/spapr/spapr_caps: Add new caps safe_[cache/bounds_check/indirect_branch]

2018-01-09 Thread Suraj Jitindar Singh
This patch adds three new capabilities: cap-cfpc -> safe_cache cap-sbbc -> safe_bounds_check cap-ibs -> safe_indirect_branch Each capability is tristate with the possible values "broken", "workaround" or "fixed". Add generic getter and setter functions for this new capability type. Add these new

[Qemu-devel] [QEMU-PPC] [RFC 3/3] target/ppc: Add H-Call H_GET_CPU_CHARACTERISTICS

2018-01-09 Thread Suraj Jitindar Singh
The new H-Call H_GET_CPU_CHARACTERISTICS is used by the guest to query behaviours and available characteristics of the cpu. Implement the handler for this new H-Call which formulates its response based on the setting of the new capabilities added in the previous patch. Note: Currently we return H

[Qemu-devel] [QEMU-PPC] [RFC 1/3] hw/ppc/spapr_caps: Rework spapr_caps to use uint8 internal representation

2018-01-09 Thread Suraj Jitindar Singh
Currently spapr_caps are tied to boolean values (on or off). This patch reworks the caps so that they can have any value between 0 and 127, inclusive. This allows more capabilities with various values to be represented in the same way internally. Capabilities are numbered in ascending order. The in

Re: [Qemu-devel] [PULL 00/14] 9p patches for 2.12 20180108

2018-01-09 Thread Peter Maydell
On 8 January 2018 at 14:28, Greg Kurz wrote: > The following changes since commit 8671016261cd5dfba1042aef0a632a77b0d387a2: > > Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into > staging (2018-01-08 09:15:42 +) > > are available in the git repository at: > > http

Re: [Qemu-devel] [RFC PATCH v2 9/9] hw/arm/xlnx-zynqmp: use Linux FDT names

2018-01-09 Thread Peter Maydell
On 9 January 2018 at 02:00, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/xlnx-zynqmp.c | 14 ++ > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c > index 325642058b..fdcd6801b6 10064

Re: [Qemu-devel] [RFC PATCH 12/12] slirp: use HOST_SUPPORTS_UNALIGNED_ACCESS

2018-01-09 Thread Paolo Bonzini
On 08/01/2018 18:29, Philippe Mathieu-Daudé wrote: > Access struct in6_addr with 'void *', then cast to 'u8 *' to avoid alignment > issues. > > Signed-off-by: Philippe Mathieu-Daudé > --- > ugly... > > slirp/ip6.h | 58 ++ > 1 file changed

Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U

2018-01-09 Thread Kevin Wolf
Am 09.01.2018 um 07:24 hat Fam Zheng geschrieben: > On Mon, 01/08 18:57, Kevin Wolf wrote: > > I'm not sure if going back to the old behaviour for a while now would be > > helpful, you'd just end up with an even more confusing set of qemu > > versions, for example: > > > > <= 2.9 - wo

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-09 Thread Paolo Bonzini
On 08/01/2018 08:43, Thomas Huth wrote: > On 04.01.2018 18:57, Paolo Bonzini wrote: >> On 04/01/2018 18:45, Samuel Thibault wrote: >>> Paolo Bonzini, on jeu. 04 janv. 2018 18:11:00 +0100, wrote: On 04/01/2018 16:56, Samuel Thibault wrote: >> However, adding magic to "-device usb-braille" t

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-09 Thread Paolo Bonzini
On 08/01/2018 08:23, Thomas Huth wrote: >>> But instead of introducing a new "-braille" parameter, maybe we should >>> rather keep some of the convenience "-usbdevice" possibilities around? >>> E.g. keep "-usbdevice braille", "-usbdevice mouse", etc. but remove >>> things like "-usbdevice serial" a

Re: [Qemu-devel] [PATCH V6 3/5] docs: add pvrdma device documentation.

2018-01-09 Thread Marcel Apfelbaum
On 09/01/2018 11:17, Cornelia Huck wrote: On Sun, 7 Jan 2018 14:32:22 +0200 Marcel Apfelbaum wrote: Signed-off-by: Marcel Apfelbaum Signed-off-by: Yuval Shaia Reviewed-by: Shamir Rabinovitch --- docs/pvrdma.txt | 254 1 file chang

[Qemu-devel] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

2018-01-09 Thread Luwei Kang
From: Chao Peng Expose Intel Processor Trace feature to guest. Signed-off-by: Chao Peng Signed-off-by: Luwei Kang --- target/i386/cpu.c | 19 ++- target/i386/cpu.h | 1 + target/i386/kvm.c | 23 +++ 3 files changed, 42 insertions(+), 1 deletion(-) diff --

[Qemu-devel] [PATCH RESEND v1 2/2] i386: Add support to get/set/migrate Intel Processor Trace feature

2018-01-09 Thread Luwei Kang
From: Chao Peng Add Intel Processor Trace related definition. It also add corresponding part to kvm_get/set_msr and vmstate. Signed-off-by: Chao Peng Signed-off-by: Luwei Kang --- target/i386/cpu.h | 22 ++ target/i386/kvm.c | 51 +++

Re: [Qemu-devel] [PATCH v1 1/1] block: Add numeric errno field to BLOCK_IO_ERROR events

2018-01-09 Thread Kevin Wolf
Am 08.01.2018 um 20:57 hat Jack Schwartz geschrieben: > Hi Kevin. > > On 2017-12-22 05:52, Kevin Wolf wrote: > > Am 22.12.2017 um 01:11 hat Jack Schwartz geschrieben: > > > BLOCK_IO_ERROR events currently contain a "reason" string which is > > > strerror(errno) of the error. This enhancement prov

Re: [Qemu-devel] [PATCH V6 4/5] pvrdma: initial implementation

2018-01-09 Thread Cornelia Huck
On Sun, 7 Jan 2018 14:32:23 +0200 Marcel Apfelbaum wrote: > From: Yuval Shaia > > PVRDMA is the QEMU implementation of VMware's paravirtualized RDMA device. > It works with its Linux Kernel driver AS IS, no need for any special guest > modifications. > > While it complies with the VMware devi

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-09 Thread Thomas Huth
On 09.01.2018 10:58, Paolo Bonzini wrote: > On 08/01/2018 08:23, Thomas Huth wrote: But instead of introducing a new "-braille" parameter, maybe we should rather keep some of the convenience "-usbdevice" possibilities around? E.g. keep "-usbdevice braille", "-usbdevice mouse", etc. b

Re: [Qemu-devel] [PATCH V6 4/5] pvrdma: initial implementation

2018-01-09 Thread Yuval Shaia
On Tue, Jan 09, 2018 at 11:39:11AM +0100, Cornelia Huck wrote: > On Sun, 7 Jan 2018 14:32:23 +0200 > Marcel Apfelbaum wrote: > > > From: Yuval Shaia > > > > PVRDMA is the QEMU implementation of VMware's paravirtualized RDMA device. > > It works with its Linux Kernel driver AS IS, no need for a

Re: [Qemu-devel] [PATCH v3 15/18] ucontext: annotate coroutine stack for ASAN

2018-01-09 Thread Philippe Mathieu-Daudé
Hi Marc-André, On 01/04/2018 01:05 PM, Marc-André Lureau wrote: > It helps ASAN to detect more leaks on coroutine stacks, as found in > the following patch. > > A similar work would need to be done for sigaltstack & windows fibers > to have similar coverage. Since ucontext is preferred, I didn't

Re: [Qemu-devel] [PATCH v3 15/18] ucontext: annotate coroutine stack for ASAN

2018-01-09 Thread Philippe Mathieu-Daudé
> On 01/04/2018 01:05 PM, Marc-André Lureau wrote: >> It helps ASAN to detect more leaks on coroutine stacks, as found in >> the following patch. >> >> A similar work would need to be done for sigaltstack & windows fibers >> to have similar coverage. Since ucontext is preferred, I didn't bother >>

Re: [Qemu-devel] [Qemu-ppc] [QEMU-PPC] [RFC 1/3] hw/ppc/spapr_caps: Rework spapr_caps to use uint8 internal representation

2018-01-09 Thread Murilo Opsfelder Araújo
On 01/09/2018 07:21 AM, Suraj Jitindar Singh wrote: > Currently spapr_caps are tied to boolean values (on or off). This patch > reworks the caps so that they can have any value between 0 and 127, > inclusive. This allows more capabilities with various values to be > represented in the same way inte

Re: [Qemu-devel] [PATCH] fw_cfg: fix memory corruption when all fw_cfg slots are used

2018-01-09 Thread Marc-André Lureau
Hi On Mon, Jan 8, 2018 at 10:50 PM, Marcel Apfelbaum wrote: > When all the fw_cfg slots are used, a write is made outside the > bounds of the fw_cfg files array as part of the sort algorithm. > > Fix it by avoiding an unnecessary array element move. > Fix also an assert while at it. > > Signed-of

Re: [Qemu-devel] [Qemu-ppc] [QEMU-PPC] [RFC 2/3] hw/spapr/spapr_caps: Add new caps safe_[cache/bounds_check/indirect_branch]

2018-01-09 Thread Murilo Opsfelder Araújo
On 01/09/2018 07:21 AM, Suraj Jitindar Singh wrote: > This patch adds three new capabilities: > cap-cfpc -> safe_cache > cap-sbbc -> safe_bounds_check > cap-ibs -> safe_indirect_branch Hi, Suraj. What about splitting this into smaller patches, one per capability? > Each capability is tristate w

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-09 Thread Paolo Bonzini
On 09/01/2018 12:00, Thomas Huth wrote: > On 09.01.2018 10:58, Paolo Bonzini wrote: >> On 08/01/2018 08:23, Thomas Huth wrote: > But instead of introducing a new "-braille" parameter, maybe we should > rather keep some of the convenience "-usbdevice" possibilities around? > E.g. keep "-

Re: [Qemu-devel] [Qemu-ppc] [QEMU-PPC] [RFC 3/3] target/ppc: Add H-Call H_GET_CPU_CHARACTERISTICS

2018-01-09 Thread Murilo Opsfelder Araújo
On 01/09/2018 07:21 AM, Suraj Jitindar Singh wrote: > The new H-Call H_GET_CPU_CHARACTERISTICS is used by the guest to query > behaviours and available characteristics of the cpu. > > Implement the handler for this new H-Call which formulates its response > based on the setting of the new capabili

Re: [Qemu-devel] [PATCH v3 15/18] ucontext: annotate coroutine stack for ASAN

2018-01-09 Thread Marc-André Lureau
Hi On Tue, Jan 9, 2018 at 12:09 PM, Philippe Mathieu-Daudé wrote: > Hi Marc-André, > > On 01/04/2018 01:05 PM, Marc-André Lureau wrote: >> It helps ASAN to detect more leaks on coroutine stacks, as found in >> the following patch. >> >> A similar work would need to be done for sigaltstack & windo

Re: [Qemu-devel] [PATCH v2] hpet: recover timer offset correctly

2018-01-09 Thread Juan Quintela
"Pavel Dovgalyuk" wrote: > Ping? > > Pavel Dovgalyuk > >> -Original Message- >> From: Pavel Dovgalyuk [mailto:pavel.dovga...@ispras.ru] >> Sent: Wednesday, December 20, 2017 1:02 PM >> To: qemu-devel@nongnu.org >> Cc: quint...@redhat.com; m...@redhat.com; dgilb...@redhat.com; >> maria.kli

[Qemu-devel] [PATCH v21 0/5] Virtio-balloon Enhancement

2018-01-09 Thread Wei Wang
This patch series enhances the existing virtio-balloon with the following new features: 1) fast ballooning: transfer ballooned pages between the guest and host in chunks using sgs, instead of one array each time; and 2) free page block reporting: a new virtqueue to report guest free pages to the ho

[Qemu-devel] [PATCH v21 1/5] xbitmap: Introduce xbitmap

2018-01-09 Thread Wei Wang
From: Matthew Wilcox The eXtensible Bitmap is a sparse bitmap representation which is efficient for set bits which tend to cluster. It supports up to 'unsigned long' worth of bits. Signed-off-by: Matthew Wilcox Signed-off-by: Wei Wang Cc: Andrew Morton Cc: Michal Hocko Cc: Michael S. Tsirkin

[Qemu-devel] [PATCH v21 5/5] virtio-balloon: don't report free pages when page poisoning is enabled

2018-01-09 Thread Wei Wang
The guest free pages should not be discarded by the live migration thread when page poisoning is enabled with PAGE_POISONING_NO_SANITY=n, because skipping the transfer of such poisoned free pages will trigger false positive when new pages are allocated and checked on the destination. This patch add

[Qemu-devel] [PATCH v21 3/5] mm: support reporting free page blocks

2018-01-09 Thread Wei Wang
This patch adds support to walk through the free page blocks in the system and report them via a callback function. Some page blocks may leave the free list after zone->lock is released, so it is the caller's responsibility to either detect or prevent the use of such pages. One use example of this

[Qemu-devel] [PATCH v21 4/5] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ

2018-01-09 Thread Wei Wang
Negotiation of the VIRTIO_BALLOON_F_FREE_PAGE_VQ feature indicates the support of reporting hints of guest free pages to host via virtio-balloon. Host requests the guest to report free pages by sending a new cmd id to the guest via the free_page_report_cmd_id configuration register. When the gues

[Qemu-devel] [PATCH v21 2/5] virtio-balloon: VIRTIO_BALLOON_F_SG

2018-01-09 Thread Wei Wang
Add a new feature, VIRTIO_BALLOON_F_SG, which enables the transfer of balloon (i.e. inflated/deflated) pages using scatter-gather lists to the host. The implementation of the previous virtio-balloon is not very efficient, because the balloon pages are transferred to the host by one array each time

Re: [Qemu-devel] [PULL 00/12] ppc-for-2.12 queue 20180108

2018-01-09 Thread Peter Maydell
On 8 January 2018 at 05:53, David Gibson wrote: > The following changes since commit 281f327487c9c9b1599f93c589a408bbf4a651b8: > > Merge remote-tracking branch > 'remotes/vivier/tags/m68k-for-2.12-pull-request' into staging (2017-12-22 > 00:11:36 +) > > are available in the Git repository

Re: [Qemu-devel] [PATCH v2] hpet: recover timer offset correctly

2018-01-09 Thread Pavel Dovgalyuk
> From: Juan Quintela [mailto:quint...@redhat.com] > >> Signed-off-by: Maria Klimushenkova > >> Signed-off-by: Pavel Dovgalyuk > >> --- > >> hw/timer/hpet.c | 32 ++-- > >> 1 file changed, 30 insertions(+), 2 deletions(-) > >> > >> diff --git a/hw/timer/hpet.c b/hw/

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-09 Thread Thomas Huth
On 09.01.2018 12:17, Paolo Bonzini wrote: > On 09/01/2018 12:00, Thomas Huth wrote: >> On 09.01.2018 10:58, Paolo Bonzini wrote: >>> On 08/01/2018 08:23, Thomas Huth wrote: >> But instead of introducing a new "-braille" parameter, maybe we should >> rather keep some of the convenience "-usb

Re: [Qemu-devel] New documentation for the LatticeMicro32 target

2018-01-09 Thread Peter Maydell
On 18 July 2017 at 12:44, Michael Walle wrote: > Am 2017-07-17 17:18, schrieb Programmingkid: >> I just tried qemu-system-lm32 and it crashed. >> >> Command-line: qemu-system-lm32 -M milkymist -kernel flickernoise >> >> Error message: audio: Failed to create voice `mm_ac97.in' >> ** >> ERROR: /acc

Re: [Qemu-devel] [QEMU-PPC] [RFC 2/3] hw/spapr/spapr_caps: Add new caps safe_[cache/bounds_check/indirect_branch]

2018-01-09 Thread joserz
On Tue, Jan 09, 2018 at 08:21:02PM +1100, Suraj Jitindar Singh wrote: > This patch adds three new capabilities: > cap-cfpc -> safe_cache > cap-sbbc -> safe_bounds_check > cap-ibs -> safe_indirect_branch > > Each capability is tristate with the possible values "broken", > "workaround" or "fixed".

Re: [Qemu-devel] [Qemu-ppc] [QEMU-PPC] [RFC 1/3] hw/ppc/spapr_caps: Rework spapr_caps to use uint8 internal representation

2018-01-09 Thread Andrea Bolognani
On Tue, 2018-01-09 at 20:21 +1100, Suraj Jitindar Singh wrote: [...] > +static void cap_htm_allow(sPAPRMachineState *spapr, uint8_t val, Error > **errp) > +{ > +if (!val) { > +/* TODO: We don't support disabling htm yet */ > +return; > +} > if (tcg_enabled()) { >

[Qemu-devel] [PATCH v2 02/20] include/fpu/softfloat: remove USE_SOFTFLOAT_STRUCT_TYPES

2018-01-09 Thread Alex Bennée
It's not actively built and when enabled things fail to compile. I'm not sure the type-checking is really helping here. Seeing as we "own" our softfloat now lets remove the cruft. Signed-off-by: Alex Bennée --- include/fpu/softfloat.h | 27 --- 1 file changed, 27 deletion

[Qemu-devel] [PATCH v2 00/20] re-factor softfloat and add fp16 functions

2018-01-09 Thread Alex Bennée
Hi, Here is version two of the softfloat re-factoring. See the previous posting for details of the approach: https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg01708.html There is only one new patch to remove USE_SOFTFLOAT_STRUCT_TYPES which had bit-rotted to irrelevance. I did run into

[Qemu-devel] [PATCH v2 03/20] include/fpu/softfloat: implement float16_abs helper

2018-01-09 Thread Alex Bennée
This will be required when expanding the MINMAX() macro for 16 bit/half-precision operations. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- include/fpu/softfloat.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/fpu/softflo

[Qemu-devel] [PATCH v2 06/20] include/fpu/softfloat: add some float16 constants

2018-01-09 Thread Alex Bennée
This defines the same set of common constants for float 16 as defined for 32 and 64 bit floats. These are often used by target helper functions. I've also removed constants that are not used by anybody. Signed-off-by: Alex Bennée --- v2 - fixup constants, remove unused onces --- include/fpu/s

[Qemu-devel] [PATCH v2 01/20] fpu/softfloat: implement float16_squash_input_denormal

2018-01-09 Thread Alex Bennée
This will be required when expanding the MINMAX() macro for 16 bit/half-precision operations. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- fpu/softfloat.c | 15 +++ include/fpu/softfloat.h | 1 + 2 files changed, 16 insertions(+) diff --git a/fpu/softfloat

[Qemu-devel] [PATCH v2 05/20] include/fpu/softfloat: implement float16_set_sign helper

2018-01-09 Thread Alex Bennée
Signed-off-by: Alex Bennée --- include/fpu/softfloat.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/fpu/softfloat.h b/include/fpu/softfloat.h index dc71b01dba..8ab5d0df47 100644 --- a/include/fpu/softfloat.h +++ b/include/fpu/softfloat.h @@ -363,6 +363,11 @@ static inline floa

[Qemu-devel] [PATCH v2 12/20] fpu/softfloat: re-factor mul

2018-01-09 Thread Alex Bennée
We can now add float16_mul and use the common decompose and canonicalize functions to have a single implementation for float16/32/64 versions. Signed-off-by: Alex Bennée Signed-off-by: Richard Henderson Signed-off-by: Richard Henderson --- fpu/softfloat.c | 207 ++--

[Qemu-devel] [PATCH v2 04/20] include/fpu/softfloat: implement float16_chs helper

2018-01-09 Thread Alex Bennée
Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- include/fpu/softfloat.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/fpu/softfloat.h b/include/fpu/softfloat.h index cfc615008d..dc71b01dba 100644 --- a/include/fpu/softfloat.h +++ b/include/fpu/softfloat.h @@

[Qemu-devel] [PATCH v2 07/20] fpu/softfloat: propagate signalling NaNs in MINMAX

2018-01-09 Thread Alex Bennée
While a comparison between a QNaN and a number will return the number it is not the same with a signaling NaN. In this case the SNaN will "win" and after potentially raising an exception it will be quietened. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v2 - added return for p

[Qemu-devel] [PATCH v2 19/20] fpu/softfloat: re-factor minmax

2018-01-09 Thread Alex Bennée
Let's do the same re-factor treatment for minmax functions. I still use the MACRO trick to expand but now all the checking code is common. Signed-off-by: Alex Bennée --- v2 - minor indentation fix --- fpu/softfloat.c | 239 ++-- include/fpu/

[Qemu-devel] [PATCH v2 13/20] fpu/softfloat: re-factor div

2018-01-09 Thread Alex Bennée
We can now add float16_div and use the common decompose and canonicalize functions to have a single implementation for float16/32/64 versions. Signed-off-by: Alex Bennée Signed-off-by: Richard Henderson --- fpu/softfloat-macros.h | 44 + fpu/softfloat.c | 235 +

[Qemu-devel] [PATCH v2 10/20] fpu/softfloat: define decompose structures

2018-01-09 Thread Alex Bennée
These structures pave the way for generic softfloat helper routines that will operate on fully decomposed numbers. Signed-off-by: Alex Bennée Signed-off-by: Richard Henderson --- fpu/softfloat.c | 70 - 1 file changed, 69 insertions(+), 1

[Qemu-devel] [PATCH v2 09/20] fpu/softfloat: move the extract functions to the top of the file

2018-01-09 Thread Alex Bennée
This is pure code-motion during re-factoring as the helpers will be needed earlier. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v2 - fix minor white space nit --- fpu/softfloat.c | 120 +--- 1 file changed, 54 insertions(+

[Qemu-devel] [PATCH v2 16/20] fpu/softfloat: re-factor float to int/uint

2018-01-09 Thread Alex Bennée
We share the common int64/uint64_pack_decomposed function across all the helpers and simply limit the final result depending on the final size. Signed-off-by: Alex Bennée -- v2 - apply float_flg_invalid fixes next patch --- fpu/softfloat.c | 1011 +++---

[Qemu-devel] [PATCH v2 11/20] fpu/softfloat: re-factor add/sub

2018-01-09 Thread Alex Bennée
We can now add float16_add/sub and use the common decompose and canonicalize functions to have a single implementation for float16/32/64 add and sub functions. Signed-off-by: Alex Bennée Signed-off-by: Richard Henderson --- fpu/softfloat.c | 904 +

[Qemu-devel] [PATCH v2 20/20] fpu/softfloat: re-factor compare

2018-01-09 Thread Alex Bennée
The compare function was already expanded from a macro. I keep the macro expansion but move most of the logic into a compare_decomposed. Signed-off-by: Alex Bennée --- v2 - minor re-factor for better inf handling --- fpu/softfloat.c | 134 +-

[Qemu-devel] [PATCH v2 08/20] fpu/softfloat: improve comments on ARM NaN propagation

2018-01-09 Thread Alex Bennée
Mention the pseudo-code fragment from which this is based and correct the spelling of signalling. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- fpu/softfloat-specialize.h | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/fpu/softfloat-specialize.h b

[Qemu-devel] [PATCH v2 14/20] fpu/softfloat: re-factor muladd

2018-01-09 Thread Alex Bennée
We can now add float16_muladd and use the common decompose and canonicalize functions to have a single implementation for float16/32/64 muladd functions. Signed-off-by: Alex Bennée Signed-off-by: Richard Henderson --- fpu/softfloat-specialize.h | 104 --- fpu/softfloat.c| 756 ++

Re: [Qemu-devel] [PATCH v2 02/20] include/fpu/softfloat: remove USE_SOFTFLOAT_STRUCT_TYPES

2018-01-09 Thread Laurent Vivier
Le 09/01/2018 à 13:22, Alex Bennée a écrit : > It's not actively built and when enabled things fail to compile. I'm > not sure the type-checking is really helping here. Seeing as we "own" > our softfloat now lets remove the cruft. I think it would be better to fix the build break than to remove th

[Qemu-devel] [PATCH v2 18/20] fpu/softfloat: re-factor scalbn

2018-01-09 Thread Alex Bennée
This is one of the simpler manipulations you could make to a floating point number. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- fpu/softfloat.c | 104 +++- include/fpu/softfloat.h | 1 + 2 files changed, 32 insertions(+), 7

Re: [Qemu-devel] [PATCH] fw_cfg: fix memory corruption when all fw_cfg slots are used

2018-01-09 Thread Marcel Apfelbaum
On 09/01/2018 13:15, Marc-André Lureau wrote: Hi Hi Marc-André, On Mon, Jan 8, 2018 at 10:50 PM, Marcel Apfelbaum wrote: When all the fw_cfg slots are used, a write is made outside the bounds of the fw_cfg files array as part of the sort algorithm. Fix it by avoiding an unnecessary array

[Qemu-devel] [PATCH v2 17/20] fpu/softfloat: re-factor int/uint to float

2018-01-09 Thread Alex Bennée
These are considerably simpler as the lower order integers can just use the higher order conversion function. As the decomposed fractional part is a full 64 bit rounding and inexact handling comes from the pack functions. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v2 - expli

[Qemu-devel] [PATCH v2 15/20] fpu/softfloat: re-factor round_to_int

2018-01-09 Thread Alex Bennée
We can now add float16_round_to_int and use the common round_decomposed and canonicalize functions to have a single implementation for float16/32/64 round_to_int functions. Signed-off-by: Alex Bennée Signed-off-by: Richard Henderson --- fpu/softfloat.c | 304

Re: [Qemu-devel] [PATCH v2 12/20] fpu/softfloat: re-factor mul

2018-01-09 Thread Philippe Mathieu-Daudé
On 01/09/2018 09:22 AM, Alex Bennée wrote: > We can now add float16_mul and use the common decompose and > canonicalize functions to have a single implementation for > float16/32/64 versions. > > Signed-off-by: Alex Bennée > Signed-off-by: Richard Henderson > Signed-off-by: Richard Henderson b

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/1] spapr: Check SMT based on KVM_CAP_PPC_SMT_POSSIBLE

2018-01-09 Thread Greg Kurz
On Fri, 5 Jan 2018 22:47:22 -0200 Jose Ricardo Ziviani wrote: > Power9 supports 4 HW threads/core but it's possible to emulate > doorbells to implement virtual SMT. KVM has the KVM_CAP_PPC_SMT_POSSIBLE > which returns a bitmap with all SMT modes supported by the host. > > Today, QEMU forces the

Re: [Qemu-devel] [PULL 00/12] ppc-for-2.12 queue 20180108

2018-01-09 Thread David Gibson
On Tue, Jan 09, 2018 at 11:46:41AM +, Peter Maydell wrote: > On 8 January 2018 at 05:53, David Gibson wrote: > > The following changes since commit 281f327487c9c9b1599f93c589a408bbf4a651b8: > > > > Merge remote-tracking branch > > 'remotes/vivier/tags/m68k-for-2.12-pull-request' into stagin

Re: [Qemu-devel] [PATCH V6 4/5] pvrdma: initial implementation

2018-01-09 Thread Cornelia Huck
On Tue, 9 Jan 2018 13:08:33 +0200 Yuval Shaia wrote: > On Tue, Jan 09, 2018 at 11:39:11AM +0100, Cornelia Huck wrote: > > On Sun, 7 Jan 2018 14:32:23 +0200 > > Marcel Apfelbaum wrote: > > > diff --git a/hw/rdma/vmw/pvrdma_dev_api.h b/hw/rdma/vmw/pvrdma_dev_api.h > > > new file mode 100644 > >

Re: [Qemu-devel] [PATCH] fw_cfg: fix memory corruption when all fw_cfg slots are used

2018-01-09 Thread Laszlo Ersek
On 01/08/18 22:50, Marcel Apfelbaum wrote: > When all the fw_cfg slots are used, a write is made outside the > bounds of the fw_cfg files array as part of the sort algorithm. > > Fix it by avoiding an unnecessary array element move. > Fix also an assert while at it. > > Signed-off-by: Marcel Apfe

Re: [Qemu-devel] [PATCH] fw_cfg: fix memory corruption when all fw_cfg slots are used

2018-01-09 Thread Laszlo Ersek
On 01/09/18 13:36, Marcel Apfelbaum wrote: > On 09/01/2018 13:15, Marc-André Lureau wrote: >> Hi >> > > Hi Marc-André, > >> On Mon, Jan 8, 2018 at 10:50 PM, Marcel Apfelbaum >> wrote: >>> When all the fw_cfg slots are used, a write is made outside the >>> bounds of the fw_cfg files array as part

[Qemu-devel] [PATCH v21 2/5 RESEND] virtio-balloon: VIRTIO_BALLOON_F_SG

2018-01-09 Thread Wei Wang
Add a new feature, VIRTIO_BALLOON_F_SG, which enables the transfer of balloon (i.e. inflated/deflated) pages using scatter-gather lists to the host. The implementation of the previous virtio-balloon is not very efficient, because the balloon pages are transferred to the host by one array each time

Re: [Qemu-devel] [PATCH v2 00/20] re-factor softfloat and add fp16 functions

2018-01-09 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180109122252.17670-1-alex.ben...@linaro.org Subject: [Qemu-devel] [PATCH v2 00/20] re-factor softfloat and add fp16 functions === TEST SCRIPT BEGIN === #!/bin/bash BASE=b

Re: [Qemu-devel] [PATCH v2] hpet: recover timer offset correctly

2018-01-09 Thread Juan Quintela
"Pavel Dovgalyuk" wrote: >> From: Juan Quintela [mailto:quint...@redhat.com] >> >> return 0; >> >> } >> >> >> >> @@ -252,7 +257,10 @@ static int hpet_post_load(void *opaque, int >> >> version_id) >> >> HPETState *s = opaque; >> >> >> >> /* Recalculate the offset between the main

Re: [Qemu-devel] [PATCH] fw_cfg: fix memory corruption when all fw_cfg slots are used

2018-01-09 Thread Laszlo Ersek
On 01/08/18 22:50, Marcel Apfelbaum wrote: > When all the fw_cfg slots are used, a write is made outside the > bounds of the fw_cfg files array as part of the sort algorithm. > > Fix it by avoiding an unnecessary array element move. > Fix also an assert while at it. > > Signed-off-by: Marcel Apfe

Re: [Qemu-devel] how to pass pcid to guest?

2018-01-09 Thread Stefan Priebe - Profihost AG
Am 08.01.2018 um 23:07 schrieb Eric Blake: > On 01/08/2018 02:03 PM, Stefan Priebe - Profihost AG wrote: >> Hello, >> >> for meltdown mitigation and performance it's important to have the pcid >> flag passed down to the guest (f.e. >> https://groups.google.com/forum/m/#!topic/mechanical-sympathy/L

Re: [Qemu-devel] [PATCH] fw_cfg: fix memory corruption when all fw_cfg slots are used

2018-01-09 Thread Marcel Apfelbaum
On 09/01/2018 15:09, Laszlo Ersek wrote: Hi Laszlo, I'll respond first to this mail' I'll take my time with the rest :) On 01/08/18 22:50, Marcel Apfelbaum wrote: When all the fw_cfg slots are used, a write is made outside the bounds of the fw_cfg files array as part of the sort algorithm. F

Re: [Qemu-devel] [RFC v6 17/27] qmp: add new event "command-dropped"

2018-01-09 Thread Stefan Hajnoczi
On Tue, Dec 19, 2017 at 04:45:47PM +0800, Peter Xu wrote: > This event will be emitted if one QMP command is dropped. Along, > declare an enum for the reasons. > > Signed-off-by: Peter Xu > --- > qapi-schema.json | 37 + > 1 file changed, 37 insertions(+) >

Re: [Qemu-devel] [PULL 07/11] cpu-exec: don't overwrite exception_index

2018-01-09 Thread Pavel Dovgalyuk
> From: Peter Maydell [mailto:peter.mayd...@linaro.org] > On 20 November 2017 at 11:06, Peter Maydell wrote: > > On 20 November 2017 at 10:25, Pavel Dovgalyuk wrote: > >>> From: Peter Maydell [mailto:peter.mayd...@linaro.org] > >>> On 17 November 2017 at 20:26, Paolo Bonzini wrote: > >>> > On 17

Re: [Qemu-devel] [PATCH v2 06/20] include/fpu/softfloat: add some float16 constants

2018-01-09 Thread Philippe Mathieu-Daudé
Hi Alex, On 01/09/2018 09:22 AM, Alex Bennée wrote: > This defines the same set of common constants for float 16 as defined > for 32 and 64 bit floats. These are often used by target helper > functions. I've also removed constants that are not used by anybody. > > Signed-off-by: Alex Bennée > >

Re: [Qemu-devel] [RFC v6 18/27] monitor: send event when command queue full

2018-01-09 Thread Stefan Hajnoczi
On Mon, Dec 25, 2017 at 03:22:24PM +0800, Peter Xu wrote: > On Mon, Dec 25, 2017 at 03:13:49PM +0800, Fam Zheng wrote: > > On Mon, 12/25 14:18, Peter Xu wrote: > > > On Mon, Dec 25, 2017 at 01:55:56PM +0800, Fam Zheng wrote: > > > > On Mon, 12/25 13:18, Peter Xu wrote: > > > > > On Thu, Dec 21, 201

Re: [Qemu-devel] [PATCH] fw_cfg: fix memory corruption when all fw_cfg slots are used

2018-01-09 Thread Laszlo Ersek
On 01/09/18 14:18, Marcel Apfelbaum wrote: > On 09/01/2018 15:09, Laszlo Ersek wrote: > > Hi Laszlo, > > I'll respond first to this mail' I'll take my time with the rest :) > >> On 01/08/18 22:50, Marcel Apfelbaum wrote: >>> When all the fw_cfg slots are used, a write is made outside the >>> bou

Re: [Qemu-devel] [PATCH] fw_cfg: fix memory corruption when all fw_cfg slots are used

2018-01-09 Thread Laszlo Ersek
On 01/09/18 14:33, Laszlo Ersek wrote: > On 01/09/18 14:18, Marcel Apfelbaum wrote: >> On 09/01/2018 15:09, Laszlo Ersek wrote: >> >> Hi Laszlo, >> >> I'll respond first to this mail' I'll take my time with the rest :) >> >>> On 01/08/18 22:50, Marcel Apfelbaum wrote: When all the fw_cfg slots

Re: [Qemu-devel] [PATCH] fw_cfg: fix memory corruption when all fw_cfg slots are used

2018-01-09 Thread Laszlo Ersek
On 01/09/18 14:35, Laszlo Ersek wrote: > On 01/09/18 14:33, Laszlo Ersek wrote: >> On 01/09/18 14:18, Marcel Apfelbaum wrote: >>> On 09/01/2018 15:09, Laszlo Ersek wrote: >>> >>> Hi Laszlo, >>> >>> I'll respond first to this mail' I'll take my time with the rest :) >>> On 01/08/18 22:50, Marce

Re: [Qemu-devel] [PATCH] fw_cfg: fix memory corruption when all fw_cfg slots are used

2018-01-09 Thread Marcel Apfelbaum
On 09/01/2018 15:36, Laszlo Ersek wrote: On 01/09/18 14:35, Laszlo Ersek wrote: On 01/09/18 14:33, Laszlo Ersek wrote: On 01/09/18 14:18, Marcel Apfelbaum wrote: On 09/01/2018 15:09, Laszlo Ersek wrote: Hi Laszlo, I'll respond first to this mail' I'll take my time with the rest :) On 01/08

Re: [Qemu-devel] [RFC v6 18/27] monitor: send event when command queue full

2018-01-09 Thread Stefan Hajnoczi
On Tue, Dec 19, 2017 at 04:45:48PM +0800, Peter Xu wrote: > @@ -4071,6 +4073,9 @@ static void handle_qmp_command(JSONMessageParser > *parser, GQueue *tokens) > req_obj->req = req; > req_obj->need_resume = false; > > +/* Protect qmp_requests and fetching its length. */ > +qemu_m

Re: [Qemu-devel] [PULL 07/11] cpu-exec: don't overwrite exception_index

2018-01-09 Thread Peter Maydell
On 9 January 2018 at 13:21, Pavel Dovgalyuk wrote: > I tried to get some logs with the following code. > It prints that there was an exception 5 and it was overwritten by the > standard code. > Fixed code prevents this overwrite. > > I guess that one of the following is true: > - unfixed version

Re: [Qemu-devel] [PATCH v2] usb: Remove legacy -usbdevice option

2018-01-09 Thread Gerd Hoffmann
Hi, > > We can and should say no. Sometimes we can also say yes though. :) > > > > I just think that Braille is worth a special case because a subset of > > our user base (blind people) will use it 100% of the time, plus it is > > not supported by libvirt and hence virt-manager. > > OK, then

Re: [Qemu-devel] [RFC v6 20/27] qmp: export qmp_dispatch_check_obj and allow "id"

2018-01-09 Thread Stefan Hajnoczi
On Tue, Dec 19, 2017 at 04:45:50PM +0800, Peter Xu wrote: > We need this for earlier check for OOB, before reaching > do_qmp_dispatch(). Meanwhile, a small touch-up to allow "id" field, > after all we allow that for sure in the spec (in any form). This change would be better as part of the patch

Re: [Qemu-devel] [PATCH] fw_cfg: fix memory corruption when all fw_cfg slots are used

2018-01-09 Thread Marcel Apfelbaum
Hi Laszlo, On 09/01/2018 14:51, Laszlo Ersek wrote: On 01/08/18 22:50, Marcel Apfelbaum wrote: When all the fw_cfg slots are used, a write is made outside the bounds of the fw_cfg files array as part of the sort algorithm. Fix it by avoiding an unnecessary array element move. Fix also an asse

[Qemu-devel] [PATCH] acpi: switch to a dummy SSDT

2018-01-09 Thread Michael S. Tsirkin
We prefer not changing table sizes depending on parameters, that's why we create a dummy table rather than just drop the MCFG table. However, a table named "QEMU" could be put to a better use than just a stub, e.g. we could use it to pass some QEMU specific info to guests. Replace with an SSDT an

[Qemu-devel] [PATCH 2/4] hw/sd/milkymist-memcard: Reset SD card on controller reset

2018-01-09 Thread Peter Maydell
Since pl181 is still using the legacy SD card API, the SD card created by sd_init() is not plugged into any bus. This means that the controller has to reset it manually. Failing to do this mostly didn't affect the guest since the guest typically does a programmed SD card reset as part of its SD co

[Qemu-devel] [PATCH 0/4] Reset SD cards attached to legacy-API controllers

2018-01-09 Thread Peter Maydell
It turns out that we don't reset the SD card model if it's attached to a legacy-API controller. For new-style controllers where the SD card object is attached to an SD_BUS, the generic qbus infrastructure takes care of ensuring that the card's DeviceState::reset method gets called. But for the lega

[Qemu-devel] [PATCH 3/4] hw/sd/ssi-sd: Reset SD card on controller reset

2018-01-09 Thread Peter Maydell
Since ssi-sd is still using the legacy SD card API, the SD card created by sd_init() is not plugged into any bus. This means that the controller has to reset it manually. Failing to do this mostly didn't affect the guest since the guest typically does a programmed SD card reset as part of its SD c

[Qemu-devel] [PATCH 4/4] hw/sd/omap_mmc: Reset SD card on controller reset

2018-01-09 Thread Peter Maydell
Since omap_mmc is still using the legacy SD card API, the SD card created by sd_init() is not plugged into any bus. This means that the controller has to reset it manually. Failing to do this mostly didn't affect the guest since the guest typically does a programmed SD card reset as part of its SD

Re: [Qemu-devel] [RFC v6 21/27] qmp: support out-of-band (oob) execution

2018-01-09 Thread Stefan Hajnoczi
On Tue, Dec 19, 2017 at 04:45:51PM +0800, Peter Xu wrote: > diff --git a/monitor.c b/monitor.c > index b571866659..505db439d8 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -1090,6 +1090,44 @@ static void qmp_caps_apply(Monitor *mon, > QMPCapabilityList *list) > } > } > > +/* > + * Return

Re: [Qemu-devel] [PATCH v2 02/20] include/fpu/softfloat: remove USE_SOFTFLOAT_STRUCT_TYPES

2018-01-09 Thread Aurelien Jarno
On 2018-01-09 13:27, Laurent Vivier wrote: > Le 09/01/2018 à 13:22, Alex Bennée a écrit : > > It's not actively built and when enabled things fail to compile. I'm > > not sure the type-checking is really helping here. Seeing as we "own" > > our softfloat now lets remove the cruft. > > I think it w

Re: [Qemu-devel] [PATCH v2 02/20] include/fpu/softfloat: remove USE_SOFTFLOAT_STRUCT_TYPES

2018-01-09 Thread Peter Maydell
On 9 January 2018 at 14:12, Aurelien Jarno wrote: > On 2018-01-09 13:27, Laurent Vivier wrote: >> Le 09/01/2018 à 13:22, Alex Bennée a écrit : >> > It's not actively built and when enabled things fail to compile. I'm >> > not sure the type-checking is really helping here. Seeing as we "own" >> > o

Re: [Qemu-devel] [PATCH] linux-user/arm/nwfpe: Check coprocessor number for FPA emulation

2018-01-09 Thread Peter Maydell
On 29 November 2017 at 09:30, Richard Henderson wrote: > On 11/28/2017 05:34 PM, Peter Maydell wrote: >> Our copy of the nwfpe code for emulating of the old FPA11 floating >> point unit doesn't check the coprocessor number in the instruction >> when it emulates it. This means that we might treat

Re: [Qemu-devel] [Qemu-arm] [PATCH] hw/intc/armv7m: Support byte and halfword accesses to CFSR

2018-01-09 Thread Peter Maydell
Ping for code review? thanks -- PMM On 8 December 2017 at 14:12, Peter Maydell wrote: > The Configurable Fault Status Register for ARMv7M and v8M is > supposed to be byte and halfword accessible, but we were only > implementing word accesses. Add support for the other access > sizes, which are u

  1   2   3   >