Re: [Qemu-devel] [PATCH v1] hmp: 'info snapshots' not showing the id

2018-01-02 Thread Markus Armbruster
seeteena writes: > On 12/22/2017 01:07 PM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> On 12/19/2017 08:20 AM, Max Reitz wrote: >>> So there are three things: (1) We probably should not allow snapshot names that could be IDs. Easiest way to solve this: Names have to

Re: [Qemu-devel] [PATCH] hw/input/hid: Add support for several keys.

2018-01-02 Thread 吴涛@Eng
Ping? On Thu, Dec 14, 2017 at 1:25 PM, Tao Wu(吴涛@Eng) wrote: > Anybody can merge this? > > It's a simple change: actually it only changed 4 bytes in hid usage > table to enable 4 keys: audiomute volumeup volumedown and power. > > It's easy to verify what the patch is doing: > > Boot some guest o

[Qemu-devel] About the patch for Memory: use memory address space for cpu-memory!

2018-01-02 Thread Yang Zhong
Hello Paolo, Happy New Years! Did you have plan to implement below your patch into latest Qemu? http://lists.nongnu.org/archive/html/qemu-devel/2017-05/msg04438.html Maybe this patch is still valuable for reducing memory footprint and the bootup time. thanks! Regards, Yang

Re: [Qemu-devel] About the patch for Memory: use memory address space for cpu-memory!

2018-01-02 Thread Paolo Bonzini
On 02/01/2018 10:23, Yang Zhong wrote: > Hello Paolo, > > Happy New Years! > > Did you have plan to implement below your patch into latest Qemu? > http://lists.nongnu.org/archive/html/qemu-devel/2017-05/msg04438.html > > Maybe this patch is still valuable for reducing memory footprint and the >

Re: [Qemu-devel] [GPU and VFIO] qemu hang at startup, VFIO_IOMMU_MAP_DMA is extremely slow

2018-01-02 Thread Liu, Yi L
On Tue, Jan 02, 2018 at 03:04:37PM +0800, Bob Chen wrote: > Ping... > > Was it because VFIO_IOMMU_MAP_DMA needs contiguous memory and my host was > not able to provide them immediately? VFIO_IOMMU_MAP_DMA pins the page and setup mapping in iommu page table. How much meory you have set for guest a

[Qemu-devel] [SPARC] question on LEON IRQMP interrupt controller.

2018-01-02 Thread Jean-Christophe DUBOIS
Hi Mark, Artyom, I am wondering if the IRQMP code in hw/intc/grlib_irqmp.c is correct when it comes to acknowledging interrupts. With the actual code an interrupt can be lowered/acked only by an "ack" from the processor which means that the trap handler related to this external interrupt nee

[Qemu-devel] dropped pkts with Qemu on tap interace (RX)

2018-01-02 Thread Stefan Priebe - Profihost AG
Hello, currently i'm trying to fix a problem where we have "random" missing packets. We're doing an ssh connect from machine a to machine b every 5 minutes via rsync and ssh. Sometimes it happens that we get this cron message: "Connection to 192.168.0.2 closed by remote host. rsync: connection u

Re: [Qemu-devel] [PATCH v6 04/29] hw/arm: Replace fprintf(stderr, "*\n" with error_report()

2018-01-02 Thread Markus Armbruster
Alistair Francis writes: > On Fri, Dec 22, 2017 at 12:30 PM, Markus Armbruster wrote: >> Alistair Francis writes: >> >>> On Fri, Dec 22, 2017 at 9:17 AM, Thomas Huth wrote: On 22.12.2017 16:37, Markus Armbruster wrote: > Second thoughts... > > Alistair Francis writes: [.

Re: [Qemu-devel] [PATCH v5 0/1] savevm/loadvm with postcopy flag qemu-iotest

2018-01-02 Thread Daniel Henrique Barboza
Hi there, I saw that new iotests were added upstream and decided to re-sent this patch, but then I noticed that the files being created by this patch (201 and 201.out) weren't created upstream - we have 200 and then 202 and 203. Is this patch queued somewhere to be added or should I re-send i

Re: [Qemu-devel] [PATCH v20 4/7] virtio-balloon: VIRTIO_BALLOON_F_SG

2018-01-02 Thread Matthew Wilcox
On Sun, Dec 24, 2017 at 03:42:02PM +0800, Wei Wang wrote: > On 12/24/2017 12:45 PM, Tetsuo Handa wrote: > > Matthew Wilcox wrote: > > > If you can't preload with anything better than that, I think that > > > xb_set_bit() should attempt an allocation with GFP_NOWAIT | __GFP_NOWARN, > > > and then yo

Re: [Qemu-devel] [PATCH] hw/input/hid: Add support for several keys.

2018-01-02 Thread Laurent Vivier
Le 02/01/2018 à 10:03, Tao Wu(吴涛@Eng) a écrit : > Ping? Your patch has been Merged by michael with his pull request of 17/12/2017. Thanks, Laurent > On Thu, Dec 14, 2017 at 1:25 PM, Tao Wu(吴涛@Eng) wrote: >> Anybody can merge this? >> >> It's a simple change: actually it only changed 4 bytes in

Re: [Qemu-devel] dropped pkts with Qemu on tap interace (RX)

2018-01-02 Thread Wei Xu
On Tue, Jan 02, 2018 at 12:17:29PM +0100, Stefan Priebe - Profihost AG wrote: > Hello, > > currently i'm trying to fix a problem where we have "random" missing > packets. > > We're doing an ssh connect from machine a to machine b every 5 minutes > via rsync and ssh. > > Sometimes it happens that

[Qemu-devel] [PULL 1/2] dump: fix note_name_equal()

2018-01-02 Thread Marc-André Lureau
Use the function argument "name" instead of hardcoded "VMCOREINFO". All callers use "VMCOREINFO" as argument, so this isn't an exposed bug, thankfully. Simplify a little bit the code while touching this. Suggested-by: Andrew Jones Reported-by: Laszlo Ersek Signed-off-by: Marc-André Lureau ---

[Qemu-devel] [PULL 2/2] dump-guest-memory.py: fix "You can't do that without a process to debug"

2018-01-02 Thread Marc-André Lureau
If the script is run with a core (no running process), it produces an error: (gdb) dump-guest-memory /tmp/vmcore X86_64 guest RAM blocks: target_start target_end host_addrmessage count --- - 000a

[Qemu-devel] [PULL 0/2] Dump patches

2018-01-02 Thread Marc-André Lureau
The following changes since commit 281f327487c9c9b1599f93c589a408bbf4a651b8: Merge remote-tracking branch 'remotes/vivier/tags/m68k-for-2.12-pull-request' into staging (2017-12-22 00:11:36 +) are available in the Git repository at: https://github.com/elmarco/qemu.git tags/dump-pull-requ

Re: [Qemu-devel] [PATCH v20 3/7 RESEND] xbitmap: add more operations

2018-01-02 Thread Matthew Wilcox
On Fri, Dec 22, 2017 at 04:49:11PM +0800, Wei Wang wrote: > Thanks for the improvement. I also found a small bug in xb_zero. With the > following changes, it has passed the current test cases and tested with the > virtio-balloon usage without any issue. Thanks; I applied the change. Can you suppl

Re: [Qemu-devel] [PATCH] migration: fix small leaks

2018-01-02 Thread Dr. David Alan Gilbert
* Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > 28.12.2017 05:19, Peter Xu wrote: > > On Wed, Dec 27, 2017 at 03:25:23PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > Hi all! > > > > > > Hmm, looks like leak is not fixed here: I've checked it while running > > > iotest

Re: [Qemu-devel] [PATCH v8 1/4] vhost-user: add new vhost user messages to support virtio config space

2018-01-02 Thread Marc-André Lureau
Hi On Tue, Jan 2, 2018 at 4:55 AM, Changpeng Liu wrote: > Add VHOST_USER_GET_CONFIG/VHOST_USER_SET_CONFIG messages which can be > used for live migration of vhost user devices, also vhost user devices > can benefit from the messages to get/set virtio config space from/to the > I/O target. For th

Re: [Qemu-devel] [PATCH v8 2/4] vhost-user-blk: introduce a new vhost-user-blk host device

2018-01-02 Thread Marc-André Lureau
On Tue, Jan 2, 2018 at 4:55 AM, Changpeng Liu wrote: > This commit introduces a new vhost-user device for block, it uses a > chardev to connect with the backend, same with Qemu virito-blk device, > Guest OS still uses the virtio-blk frontend driver. > > To use it, start QEMU with command line like

Re: [Qemu-devel] dropped pkts with Qemu on tap interace (RX)

2018-01-02 Thread Stefan Priebe - Profihost AG
Hi, Am 02.01.2018 um 15:20 schrieb Wei Xu: > On Tue, Jan 02, 2018 at 12:17:29PM +0100, Stefan Priebe - Profihost AG wrote: >> Hello, >> >> currently i'm trying to fix a problem where we have "random" missing >> packets. >> >> We're doing an ssh connect from machine a to machine b every 5 minutes >>

Re: [Qemu-devel] [PATCH v8 3/4] contrib/libvhost-user: enable virtio config space messages

2018-01-02 Thread Marc-André Lureau
Hi On Tue, Jan 2, 2018 at 4:55 AM, Changpeng Liu wrote: > Enable VHOST_USER_GET_CONFIG/VHOST_USER_SET_CONFIG messages in > libvhost-user library, users can implement their own I/O target > based on the library. This enable the virtio config space delivered > between QEMU host device and the I/O t

[Qemu-devel] [PATCH] crypto/ivgen-essiv: Fix problem with address sanitizer of Clang

2018-01-02 Thread Thomas Huth
When compiling QEMU with clang and -fsanitize=address, I get the following error: ==9185==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7ffc7e9adf2f at pc 0x564cba001d88 bp 0x7ffc7e9adeb0 sp 0x7ffc7e9adea8 READ of size 16 at 0x7ffc7e9adf2f thread T0 #0 0x564cba001d87 in qcrypto_

Re: [Qemu-devel] [PATCH v8 4/4] contrib/vhost-user-blk: introduce a vhost-user-blk sample application

2018-01-02 Thread Marc-André Lureau
On Tue, Jan 2, 2018 at 4:55 AM, Changpeng Liu wrote: > This commit introcudes a vhost-user-blk backend device, it uses UNIX' introcudes -> introduces > domain socket to communicate with QEMU. The vhost-user-blk sample > application should be used with QEMU vhost-user-blk-pci device. > > To use i

Re: [Qemu-devel] [PATCH RESEND v4] vhost: set used memslots for vhost-user and vhost-kernel respectively

2018-01-02 Thread Igor Mammedov
On Sat, 30 Dec 2017 14:36:51 +0800 Jay Zhou wrote: > Used_memslots is equal to dev->mem->nregions now, it is true for > vhost kernel, but not for vhost user, which uses the memory regions > that have file descriptor. In fact, not all of the memory regions > have file descriptor. > It is usefully

Re: [Qemu-devel] [PATCH v2 02/13] build-sys: silence make by default or V=0

2018-01-02 Thread Marc-André Lureau
Hi On Tue, Dec 19, 2017 at 5:35 PM, Eric Blake wrote: > On 12/15/2017 09:06 AM, Marc-André Lureau wrote: >> >> Move generic make flags in MAKEFLAGS (SUBDIR_MAKEFLAGS is more qemu >> specific). >> >> Use --quiet to silence make 'is up to date' message. >> >> Signed-off-by: Marc-André Lureau >> --

Re: [Qemu-devel] [PATCH v2 04/13] build-sys: add AddressSanitizer when --enable-debug if possible

2018-01-02 Thread Marc-André Lureau
On Tue, Dec 19, 2017 at 4:48 PM, Marc-André Lureau wrote: > Hi > > On Fri, Dec 15, 2017 at 4:06 PM, Marc-André Lureau > wrote: >> Enable ASAN by default if the compiler supports it. >> >> If necessary, we could consider a seperate configure option, although >> I like the idea to have it enabled b

Re: [Qemu-devel] [PATCH v5 01/17] target-m68k: sync CC_OP before gen_jmp_tb()

2018-01-02 Thread Richard Henderson
On 01/01/2018 05:10 PM, Laurent Vivier wrote: > And remove update_cc_op() from gen_exception() because there is > one in gen_jmp_im(). > > Signed-off-by: Laurent Vivier > --- > target/m68k/translate.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

2018-01-02 Thread Michael S. Tsirkin
On Wed, Dec 27, 2017 at 02:56:20PM +0800, Haozhong Zhang wrote: > When a file supporting DAX is used as vNVDIMM backend, mmap it with > MAP_SYNC flag in addition can guarantee the persistence of guest write > to the backend file without other QEMU actions (e.g., periodic fsync() > by QEMU). > > By

Re: [Qemu-devel] [PATCH 2/3] chardev: let g_idle_add() be with chardev gcontext

2018-01-02 Thread Marc-André Lureau
On Thu, Dec 28, 2017 at 8:29 AM, Peter Xu wrote: > The idle task will be attached to main gcontext even if the chardev > backend is running in another gcontext. Fix the only caller by > extending the g_idle_add() logic into the more powerful > g_source_attach(). It's basically g_idle_add_full()

Re: [Qemu-devel] [PATCH 1/3] chardev: use backend chr context when watch for fe

2018-01-02 Thread Marc-André Lureau
On Thu, Dec 28, 2017 at 8:29 AM, Peter Xu wrote: > In commit 6bbb6c0644 ("chardev: use per-dev context for > io_add_watch_poll", 2017-09-22) all the chardev watches are converted to > use per-chardev gcontext to support chardev to be run outside default > main thread. However that's still missing

Re: [Qemu-devel] [PATCH v5 02/17] target/m68k: fix gen_get_ccr()

2018-01-02 Thread Richard Henderson
On 01/01/2018 05:10 PM, Laurent Vivier wrote: > As gen_helper_get_ccr() is able to compute CCR from cc_op and > flags, we don't need to flush flags before to call it. > flush_flags() and get_ccr() use COMPUTE_CCR() to compute > flags. get_ccr() computes CCR value, > whereas flush_flags update live

Re: [Qemu-devel] [PATCH v5 04/17] target-m68k: use insn_pc to generate instruction fault address

2018-01-02 Thread Richard Henderson
On 01/01/2018 05:10 PM, Laurent Vivier wrote: > Signed-off-by: Laurent Vivier > --- > target/m68k/translate.c | 40 > 1 file changed, 20 insertions(+), 20 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v5 03/17] linux-user, m68k: correctly manage SR in context

2018-01-02 Thread Richard Henderson
On 01/01/2018 05:10 PM, Laurent Vivier wrote: > Use cpu_m68k_get_ccr()/cpu_m68k_set_ccr() to setup and restore correctly > the value of SR in the context structure. Fix target_rt_setup_ucontext(). > > Fixes: 3219de458c ("linux-user: correctly manage SR in ucontext") > Signed-off-by: Laurent Vivier

Re: [Qemu-devel] [PATCH 3/3] chardev: introduce qemu_chr_timeout_add() and use

2018-01-02 Thread Marc-André Lureau
Hi On Thu, Dec 28, 2017 at 8:29 AM, Peter Xu wrote: > It's a replacement of g_timeout_add[_seconds]() for chardevs. Chardevs > now can have dedicated gcontext, we should always bind chardev tasks > onto those gcontext rather than the default main context. Since there > are quite a few of g_time

Re: [Qemu-devel] [PATCH v5 05/17] target/m68k: add CPU_LOG_INT trace

2018-01-02 Thread Richard Henderson
On 01/01/2018 05:10 PM, Laurent Vivier wrote: > Display the interrupts/exceptions information > in QEMU logs (-d int) > > Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson > +if (qemu_loglevel_mask(CPU_LOG_INT)) { > +static int count; > +qemu_log("INT %6d: %s(%#

[Qemu-devel] [Bug 1740887] [NEW] qemu-system-arm & qemu-system-aarch64 for windows crash at start

2018-01-02 Thread charlet franck
Public bug reported: In Windows 7 64 bit (both 32 & 64 bit QEMU emulator version 2.11.0 (v2.11.0-11693-g21057c841e-dirty)). With arguments: qemu-system-arm.exe -M raspi2 It crashes and reports: ERROR:/home/stefan/src/qemu/repo.or.cz/qemu/ar7/qom/object.c:176:type_get_parent: assertion failed:

Re: [Qemu-devel] [PATCH v5 06/17] target/m68k: manage 680x0 stack frames

2018-01-02 Thread Richard Henderson
On 01/01/2018 05:10 PM, Laurent Vivier wrote: > 680x0 manages several stack frame formats: > - format 0: four-word stack frame > - format 1: four-word throwaway stack frame > - format 2: six-word stack frame > - format 3: Floating-Point post-instruction stack frame > - format 4: eight-wor

[Qemu-devel] [Bug 1158912] Re: QEMU Version 1.4.0 - SLIRP hangs VM

2018-01-02 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QE

[Qemu-devel] [PATCH] MAINTAINERS: Add qemu-binfmt-conf.sh script

2018-01-02 Thread Thomas Huth
qemu-binfmt-conf.sh is used for the Linux usermode emulation, so let's add this file to that section in the MAINTAINERS file. Signed-off-by: Thomas Huth --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 73a..e92618f 100644 --- a/MAINTAINERS +

Re: [Qemu-devel] [PATCH v5 07/17] target/m68k: add chk and chk2

2018-01-02 Thread Richard Henderson
On 01/01/2018 05:10 PM, Laurent Vivier wrote: > +SRC_EA(env, tsrc, opsize, 1, NULL); > +src = tcg_temp_local_new(); > +tcg_gen_mov_i32(src, tsrc); > + > +reg = tcg_temp_local_new(); > +gen_ext(reg, DREG(insn, 9), opsize, 1); > +gen_flush_flags(s); > +update_cc_op(s); > +

Re: [Qemu-devel] [PATCH 00/26] SDCard housekeeping

2018-01-02 Thread Philippe Mathieu-Daudé
I'll try to give a status on this series. First, let me collect few subthreads here to recapitulate: >> On 14/12/2017 10:06, Kevin Wolf wrote: > [...] >> Doing this kind of thing over QMP doesn't look right to me. qtests >> should access hardware the same way as real guests access the hardware >>

Re: [Qemu-devel] dropped pkts with Qemu on tap interace (RX)

2018-01-02 Thread Wei Xu
On Tue, Jan 02, 2018 at 04:24:33PM +0100, Stefan Priebe - Profihost AG wrote: > Hi, > Am 02.01.2018 um 15:20 schrieb Wei Xu: > > On Tue, Jan 02, 2018 at 12:17:29PM +0100, Stefan Priebe - Profihost AG > > wrote: > >> Hello, > >> > >> currently i'm trying to fix a problem where we have "random" miss

Re: [Qemu-devel] [PATCH v5 08/17] target/m68k: add move16

2018-01-02 Thread Richard Henderson
On 01/01/2018 05:10 PM, Laurent Vivier wrote: > +mode = (insn >> 3) & 7; > + > +if (mode & 4) { Looks like mode should equal 4 as well. r~

Re: [Qemu-devel] [PATCH v5 09/17] target/m68k: softmmu cleanup

2018-01-02 Thread Richard Henderson
On 01/01/2018 05:10 PM, Laurent Vivier wrote: > don't compile supervisor only instructions in linux-user mode > > Signed-off-by: Laurent Vivier > --- > target/m68k/translate.c | 37 - > 1 file changed, 32 insertions(+), 5 deletions(-) Reviewed-by: Richard Hen

Re: [Qemu-devel] [PATCH v5 10/17] target/m68k: add cpush/cinv

2018-01-02 Thread Richard Henderson
On 01/01/2018 05:10 PM, Laurent Vivier wrote: > Add cache lines invalidate and cache lines push > as no-op operations, as we don't have cache. > > These instructions are 68040 only. > > Signed-off-by: Laurent Vivier > --- > target/m68k/translate.c | 20 > 1 file changed, 20

Re: [Qemu-devel] [PATCH v5 11/17] target/m68k: add reset

2018-01-02 Thread Richard Henderson
On 01/01/2018 05:10 PM, Laurent Vivier wrote: > The instruction traps if the CPU is not in > Supervisor state but the helper is empty because > there is no easy way to reset all the peripherals > without resetting the CPU itself. > > Signed-off-by: Laurent Vivier > --- > target/m68k/helper.c

Re: [Qemu-devel] out of bounds in set_cc_op()

2018-01-02 Thread Thomas Huth
On 21.12.2017 20:30, Paolo Bonzini wrote: > On 21/12/2017 20:20, Laurent Vivier wrote: Yes, this is good too. After my pull request is in, feel free to take Thomas's m68k boot-serial-test patch in your tree. >> And what about: >> >> tests/boot-serial-test: Add tests for microblaze

Re: [Qemu-devel] [PATCH v5 12/17] target/m68k: implement fsave/frestore

2018-01-02 Thread Richard Henderson
On 01/01/2018 05:10 PM, Laurent Vivier wrote: > Signed-off-by: Laurent Vivier > --- > target/m68k/translate.c | 23 +++ > 1 file changed, 15 insertions(+), 8 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v5 13/17] target/m68k: move CCR/SR functions

2018-01-02 Thread Richard Henderson
On 01/01/2018 05:10 PM, Laurent Vivier wrote: > The following patches will be clearer if we move > functions before adding new ones. > > Signed-off-by: Laurent Vivier > --- > target/m68k/translate.c | 111 > > 1 file changed, 55 insertions(+), 56

Re: [Qemu-devel] [PATCH v5 14/17] target/m68k: add 680x0 "move to SR" instruction

2018-01-02 Thread Richard Henderson
On 01/01/2018 05:10 PM, Laurent Vivier wrote: > Some cleanup, and allows SR to be moved from any addressing mode. > Previous code was wrong for coldfire: coldfire also allows to > use addressing mode to set SR/CCR. It only supports Data register > to get SR/CCR (move from) > > Signed-off-by: Laure

Re: [Qemu-devel] [PATCH v5 15/17] target/m68k: add andi/ori/eori to SR/CCR

2018-01-02 Thread Richard Henderson
On 01/01/2018 05:10 PM, Laurent Vivier wrote: > Signed-off-by: Laurent Vivier > --- > target/m68k/translate.c | 53 > ++--- > 1 file changed, 46 insertions(+), 7 deletions(-) Reviewed-by: Richard Henderson r~

[Qemu-devel] [PATCH RESEND 1/1] qmp.c: system_wakeup: adding RUN_STATE_SUSPENDED check before proceeding

2018-01-02 Thread Daniel Henrique Barboza
The qmp/hmp command 'system_wakeup' is simply a direct call to 'qemu_system_wakeup_request' from vl.c. This function verifies if runstate is SUSPENDED and if the wake up reason is valid before proceeding. However, no error or warning is thrown if any of those pre-requirements isn't met. This leads

[Qemu-devel] [PATH v2 0/2] qmp: 'wakeup-suspend-support' in query-target

2018-01-02 Thread Daniel Henrique Barboza
v2: - changed the approach based on v1 discussions: instead of a new API, add the required flag in QMP query-target - dropped patch 2 since query-target does not have an HMP counterpart - previous version link: https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg00889.html Daniel Henrique Ba

[Qemu-devel] [PATCH v2 2/2] qga: update guest-suspend-ram and guest-suspend-hybrid descriptions

2018-01-02 Thread Daniel Henrique Barboza
This patch updates the descriptions of 'guest-suspend-ram' and 'guest-suspend-hybrid' to mention that both commands relies now on the existence of 'system_wakeup' and also on the proper support for wake up from suspend, retrieved by the 'wakeup-suspend-support' attribute of the 'query-target' QMP c

[Qemu-devel] [PATCH v2 1/2] qmp: adding 'wakeup-suspend-support' in query-target

2018-01-02 Thread Daniel Henrique Barboza
When issuing the qmp/hmp 'system_wakeup' command, what happens in a nutshell is: - qmp_system_wakeup_request set runstate to RUNNING, sets a wakeup_reason and notify the event - in the main_loop, all vcpus are paused, a system reset is issued, all subscribers of wakeup_notifiers receives a notific

Re: [Qemu-devel] [PATCH v5 16/17] target/m68k: add the Interrupt Stack Pointer

2018-01-02 Thread Richard Henderson
On 01/01/2018 05:10 PM, Laurent Vivier wrote: > env->sr = tmp; > +m68k_switch_sp(env); I would much prefer a cpu_m68k_set_sr here, akin to cpu_m68k_set_ccr. r~

Re: [Qemu-devel] [PATCH v5 17/17] target/m68k: fix m68k_cpu_dump_state()

2018-01-02 Thread Richard Henderson
On 01/01/2018 05:10 PM, Laurent Vivier wrote: > Display correctly the Trace bits for 680x0 > (2 bits instead of 1 for Coldfire). > > Signed-off-by: Laurent Vivier > --- > target/m68k/cpu.h | 3 ++- > target/m68k/translate.c | 9 ++--- > 2 files changed, 8 insertions(+), 4 deletions(-)

Re: [Qemu-devel] [PATCH v2 04/13] build-sys: add AddressSanitizer when --enable-debug if possible

2018-01-02 Thread Paolo Bonzini
On 02/01/2018 16:49, Marc-André Lureau wrote: >>> If necessary, we could consider a seperate configure option, although >>> I like the idea to have it enabled by default with --enable-debug. >> Peter, Paolo, Fam, any thoughts about having ASAN enabled by default >> with --enable-debug? (when availa

Re: [Qemu-devel] [PATCH v2 02/13] build-sys: silence make by default or V=0

2018-01-02 Thread Paolo Bonzini
On 02/01/2018 16:49, Marc-André Lureau wrote: > Hi > > On Tue, Dec 19, 2017 at 5:35 PM, Eric Blake wrote: >> On 12/15/2017 09:06 AM, Marc-André Lureau wrote: >>> >>> Move generic make flags in MAKEFLAGS (SUBDIR_MAKEFLAGS is more qemu >>> specific). >>> >>> Use --quiet to silence make 'is up to da

Re: [Qemu-devel] [PATCH qemu 0/3] spapr/iommu: Enable in-kernel TCE acceleration via VFIO KVM device

2018-01-02 Thread Paolo Bonzini
On 02/01/2018 06:28, Alexey Kardashevskiy wrote: > This is my current queue of the in-kernel TCE acceleration > enablement. > > Changes since > https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg01918.html : > * 3 patches instead of one, one per maintainership area; > * added memory_region_

Re: [Qemu-devel] [PATCH v2 02/13] build-sys: silence make by default or V=0

2018-01-02 Thread Marc-André Lureau
On Tue, Jan 2, 2018 at 6:33 PM, Paolo Bonzini wrote: > On 02/01/2018 16:49, Marc-André Lureau wrote: >> Hi >> >> On Tue, Dec 19, 2017 at 5:35 PM, Eric Blake wrote: >>> On 12/15/2017 09:06 AM, Marc-André Lureau wrote: Move generic make flags in MAKEFLAGS (SUBDIR_MAKEFLAGS is more qemu >>

Re: [Qemu-devel] [PATCH v2 02/13] build-sys: silence make by default or V=0

2018-01-02 Thread Paolo Bonzini
On 02/01/2018 18:58, Marc-André Lureau wrote: > On Tue, Jan 2, 2018 at 6:33 PM, Paolo Bonzini wrote: >> On 02/01/2018 16:49, Marc-André Lureau wrote: >>> Hi >>> >>> On Tue, Dec 19, 2017 at 5:35 PM, Eric Blake wrote: On 12/15/2017 09:06 AM, Marc-André Lureau wrote: > > Move generic ma

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add qemu-binfmt-conf.sh script

2018-01-02 Thread Laurent Vivier
Le 02/01/2018 à 17:25, Thomas Huth a écrit : > qemu-binfmt-conf.sh is used for the Linux usermode emulation, so > let's add this file to that section in the MAINTAINERS file. > > Signed-off-by: Thomas Huth > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS

[Qemu-devel] [PATCH] escc: introduce a selector for the register bit

2018-01-02 Thread Laurent Vivier
From: Laurent Vivier On Sparc and PowerMac, the bit 0 of the address selects the register type (control or data) and bit 1 selects the channel (B or A). On m68k Macintosh, the bit 0 selects the channel and bit 1 the register type. This patch introduces a new parameter (reg_bit) to the device in

Re: [Qemu-devel] [PATCH v5 05/17] target/m68k: add CPU_LOG_INT trace

2018-01-02 Thread Laurent Vivier
Le 02/01/2018 à 17:10, Richard Henderson a écrit : > On 01/01/2018 05:10 PM, Laurent Vivier wrote: >> Display the interrupts/exceptions information >> in QEMU logs (-d int) >> >> Signed-off-by: Laurent Vivier > > > Reviewed-by: Richard Henderson > >> +if (qemu_loglevel_mask(CPU_LOG_INT)) {

Re: [Qemu-devel] [PATCH v5 08/17] target/m68k: add move16

2018-01-02 Thread Laurent Vivier
Le 02/01/2018 à 17:50, Richard Henderson a écrit : > On 01/01/2018 05:10 PM, Laurent Vivier wrote: >> +mode = (insn >> 3) & 7; >> + >> +if (mode & 4) { > > Looks like mode should equal 4 as well. > Yes, you're right. I will replace the line by: +if (mode == 4) { Thanks, Laurent

Re: [Qemu-devel] [PATCH v5 16/17] target/m68k: add the Interrupt Stack Pointer

2018-01-02 Thread Laurent Vivier
Le 02/01/2018 à 18:13, Richard Henderson a écrit : > On 01/01/2018 05:10 PM, Laurent Vivier wrote: >> env->sr = tmp; >> +m68k_switch_sp(env); > > I would much prefer a cpu_m68k_set_sr here, akin to cpu_m68k_set_ccr. Yes, it's a good idea, I also use several times helper_s

Re: [Qemu-devel] [SPARC] question on LEON IRQMP interrupt controller.

2018-01-02 Thread Fabien Chouteau
Hello Jean-Christophe, I'm the original author of this patch and I add in copy my colleague Frederic. On 02/01/2018 12:13, Jean-Christophe DUBOIS wrote: > I am wondering if the IRQMP code in hw/intc/grlib_irqmp.c is correct > when it comes to acknowledging interrupts. > > With the actual code an

Re: [Qemu-devel] [PATCH v2] target/arm: Fix stlxp for aarch64_be

2018-01-02 Thread Michael Weiser
Hi Richard, On Mon, Jan 01, 2018 at 03:06:21PM -0800, Richard Henderson wrote: > > v2: > > - make it work for MTTCG as well by catering to the 128bit expectation > Reviewed-by: Richard Henderson > > + * 128bit store but two doulbewords stored consecutively */ >

[Qemu-devel] [PATCH v3 02/11] imx_fec: Refactor imx_eth_enable_rx()

2018-01-02 Thread Andrey Smirnov
Refactor imx_eth_enable_rx() to have more meaningfull variable name than 'tmp' and to reduce number of logical negations done. Cc: Peter Maydell Cc: Jason Wang Cc: Philippe Mathieu-Daudé Cc: qemu-devel@nongnu.org Cc: qemu-...@nongnu.org Cc: yurov...@gmail.com Reviewed-by: Philippe Mathieu-Daudé

[Qemu-devel] [PATCH v3 04/11] imx_fec: Move Tx frame buffer away from the stack

2018-01-02 Thread Andrey Smirnov
Make Tx frame assembly buffer to be a paort of IMXFECState structure to avoid a concern about having large data buffer on the stack. Cc: Peter Maydell Cc: Jason Wang Cc: Philippe Mathieu-Daudé Cc: qemu-devel@nongnu.org Cc: qemu-...@nongnu.org Cc: yurov...@gmail.com Signed-off-by: Andrey Smirnov

[Qemu-devel] [PATCH v3 03/11] imx_fec: Change queue flushing heuristics

2018-01-02 Thread Andrey Smirnov
In current implementation, packet queue flushing logic seem to suffer from a deadlock like scenario if a packet is received by the interface before before Rx ring is initialized by Guest's driver. Consider the following sequence of events: 1. A QEMU instance is started against a TAP device

[Qemu-devel] [PATCH v3 06/11] imx_fec: Use MIN instead of explicit ternary operator

2018-01-02 Thread Andrey Smirnov
Cc: Peter Maydell Cc: Jason Wang Cc: Philippe Mathieu-Daudé Cc: qemu-devel@nongnu.org Cc: qemu-...@nongnu.org Cc: yurov...@gmail.com Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Andrey Smirnov --- hw/net/imx_fec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ne

[Qemu-devel] [PATCH v3 01/11] imx_fec: Do not link to netdev

2018-01-02 Thread Andrey Smirnov
Binding to a particular netdev doesn't seem to belong to this layer and should probably be done as a part of board or SoC specific code. Convert all of the users of this IP block to use qdev_set_nic_properties() instead. Cc: Peter Maydell Cc: Jason Wang Cc: Philippe Mathieu-Daudé Cc: qemu-deve

[Qemu-devel] [PATCH v3 00/11] i.MX FEC changes

2018-01-02 Thread Andrey Smirnov
Hi everyone, This patchset is v3 of a spin-off from original i.MX7 support submission found here [1], containing all of the patchest that are more or less agreed upon and are ready (hopefully!) for inclusion. Changes since [v2]: - All SD related patches are dropped from this series (to b

[Qemu-devel] [PATCH v3 05/11] imx_fec: Use ENET_FTRL to determine truncation length

2018-01-02 Thread Andrey Smirnov
Frame truncation length, TRUNC_FL, is determined by the contents of ENET_FTRL register, so convert the code to use it instead of a hardcoded constant. To avoid the case where TRUNC_FL is greater that ENET_MAX_FRAME_SIZE, increase the value of the latter to its theoretical maximum of 16K. Cc: Pete

[Qemu-devel] [PATCH v3 09/11] imx_fec: Use correct length for packet size

2018-01-02 Thread Andrey Smirnov
Use 'frame_size' instead of 'len' when calling qemu_send_packet(), failing to do so results in malformed packets send in case when that packed is fragmented into multiple DMA transactions. Cc: Peter Maydell Cc: Jason Wang Cc: Philippe Mathieu-Daudé Cc: qemu-devel@nongnu.org Cc: qemu-...@nongnu.

[Qemu-devel] [PATCH v3 10/11] imx_fec: Fix a typo in imx_enet_receive()

2018-01-02 Thread Andrey Smirnov
Cc: Peter Maydell Cc: Jason Wang Cc: Philippe Mathieu-Daudé Cc: qemu-devel@nongnu.org Cc: qemu-...@nongnu.org Cc: yurov...@gmail.com Reviewed-by: Peter Maydell Signed-off-by: Andrey Smirnov --- hw/net/imx_fec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/imx_fec

[Qemu-devel] [PATCH v3 07/11] imx_fec: Emulate SHIFT16 in ENETx_RACC

2018-01-02 Thread Andrey Smirnov
Needed to support latest Linux kernel driver which relies on that functionality. Cc: Peter Maydell Cc: Jason Wang Cc: Philippe Mathieu-Daudé Cc: qemu-devel@nongnu.org Cc: qemu-...@nongnu.org Cc: yurov...@gmail.com Reviewed-by: Peter Maydell Signed-off-by: Andrey Smirnov --- hw/net/imx_fec.c

[Qemu-devel] [PATCH v3 11/11] imx_fec: Reserve full FSL_IMX25_FEC_SIZE page for the register file

2018-01-02 Thread Andrey Smirnov
Some i.MX SoCs (e.g. i.MX7) have FEC registers going as far as offset 0x614, so to avoid getting aborts when accessing those on QEMU, extend the register file to cover FSL_IMX25_FEC_SIZE(16K) of address space instead of just 1K. Cc: Peter Maydell Cc: Jason Wang Cc: Philippe Mathieu-Daudé Cc: qe

[Qemu-devel] [PATCH v3 08/11] imx_fec: Add support for multiple Tx DMA rings

2018-01-02 Thread Andrey Smirnov
More recent version of the IP block support more than one Tx DMA ring, so add the code implementing that feature. Cc: Peter Maydell Cc: Jason Wang Cc: Philippe Mathieu-Daudé Cc: qemu-devel@nongnu.org Cc: qemu-...@nongnu.org Cc: yurov...@gmail.com Reviewed-by: Peter Maydell Signed-off-by: Andre

[Qemu-devel] Problem to start VM with libiscsi + qemu upstream

2018-01-02 Thread Roy Shterman
Hi all, I'm trying to get VM started with libiscsi (iSCSI initiator) device. Every thing seems good from iSCSI point of view, but I'm stuck in VM boot, "Booting from Hard Disk". Any idea what can get wrong? how I can assure that the boot itself is from the wanted disk. Also will be helpful if some

Re: [Qemu-devel] [PATCH RESEND 1/1] qmp.c: system_wakeup: adding RUN_STATE_SUSPENDED check before proceeding

2018-01-02 Thread Eric Blake
On 01/02/2018 11:06 AM, Daniel Henrique Barboza wrote: > The qmp/hmp command 'system_wakeup' is simply a direct call to > 'qemu_system_wakeup_request' from vl.c. This function verifies if > runstate is SUSPENDED and if the wake up reason is valid before > proceeding. However, no error or warning is

Re: [Qemu-devel] [PATCH v2 1/2] qmp: adding 'wakeup-suspend-support' in query-target

2018-01-02 Thread Eric Blake
On 01/02/2018 11:09 AM, Daniel Henrique Barboza wrote: > When issuing the qmp/hmp 'system_wakeup' command, what happens in a > nutshell is: > > - qmp_system_wakeup_request set runstate to RUNNING, sets a wakeup_reason > and notify the event > - in the main_loop, all vcpus are paused, a system rese

[Qemu-devel] Call for GSoC & Outreachy 2018 mentors & project ideas

2018-01-02 Thread Stefan Hajnoczi
QEMU will apply to the Google Summer of Code (https://summerofcode.withgoogle.com/) and Outreachy (https://www.outreachy.org/) open source internship programs again this year. Do you want to mentor newcomers beginning open source development in our community? Please post your project ideas on the

Re: [Qemu-devel] [PATCH v2 1/2] qmp: adding 'wakeup-suspend-support' in query-target

2018-01-02 Thread Daniel Henrique Barboza
On 01/02/2018 06:06 PM, Eric Blake wrote: On 01/02/2018 11:09 AM, Daniel Henrique Barboza wrote: When issuing the qmp/hmp 'system_wakeup' command, what happens in a nutshell is: - qmp_system_wakeup_request set runstate to RUNNING, sets a wakeup_reason and notify the event - in the main_loop,

Re: [Qemu-devel] [PATCH 2/7] blockjob: consolidate SLICE_TIME definition

2018-01-02 Thread Jeff Cody
On Wed, Dec 13, 2017 at 07:59:48PM -0500, John Snow wrote: > They're all the same. If it actually becomes important to configure it, > it can become a job or driver property. > > Signed-off-by: John Snow > --- > block/backup.c | 1 - > block/commit.c | 2 -- > block/m

Re: [Qemu-devel] [PATCH v6 18/20] vpc: Switch to .bdrv_co_block_status()

2018-01-02 Thread Eric Blake
On 12/28/2017 08:55 PM, Fam Zheng wrote: > On Thu, 12/07 14:30, Eric Blake wrote: >> We are gradually moving away from sector-based interfaces, towards >> byte-based. Update the vpc driver accordingly. Drop the now-unused >> get_sector_offset(). > > No get_sector_offset change in the patch any m

Re: [Qemu-devel] [PATCH RESEND 1/1] qmp.c: system_wakeup: adding RUN_STATE_SUSPENDED check before proceeding

2018-01-02 Thread Daniel Henrique Barboza
On 01/02/2018 06:03 PM, Eric Blake wrote: On 01/02/2018 11:06 AM, Daniel Henrique Barboza wrote: The qmp/hmp command 'system_wakeup' is simply a direct call to 'qemu_system_wakeup_request' from vl.c. This function verifies if runstate is SUSPENDED and if the wake up reason is valid before proc

Re: [Qemu-devel] [PATCH v12 1/6] migration: introduce postcopy-blocktime capability

2018-01-02 Thread Juan Quintela
Alexey Perevalov wrote: > Right now it could be used on destination side to > enable vCPU blocktime calculation for postcopy live migration. > vCPU blocktime - it's time since vCPU thread was put into > interruptible sleep, till memory page was copied and thread awake. > > Reviewed-by: Dr. David A

Re: [Qemu-devel] [PATCH v12 2/6] migration: add postcopy blocktime ctx into MigrationIncomingState

2018-01-02 Thread Juan Quintela
Alexey Perevalov wrote: > This patch adds request to kernel space for UFFD_FEATURE_THREAD_ID, > in case when this feature is provided by kernel. > > PostcopyBlocktimeContext is incapsulated inside postcopy-ram.c, > due to it's postcopy only feature. > Also it defines PostcopyBlocktimeContext's ins

Re: [Qemu-devel] [PATCH v3 0/6] Add make check tests for Migration

2018-01-02 Thread Eric Blake
On 12/01/2017 12:44 PM, Eric Blake wrote: > On 12/01/2017 12:38 PM, Laurent Vivier wrote: >> On 01/12/2017 19:30, Eric Blake wrote: >>> On 12/01/2017 06:58 AM, Juan Quintela wrote: Hi This is on top of my info_migrate series. >>> >>> Let patchew know about it: >>> >>> Based-on: <2017

Re: [Qemu-devel] [PATCH v12 3/6] migration: calculate vCPU blocktime on dst side

2018-01-02 Thread Juan Quintela
Alexey Perevalov wrote: > This patch provides blocktime calculation per vCPU, > as a summary and as a overlapped value for all vCPUs. > > This approach was suggested by Peter Xu, as an improvements of > previous approch where QEMU kept tree with faulted page address and cpus > bitmask > in it. No

Re: [Qemu-devel] [PATCH v5 1/2] qemu-img.texi: Clean up parameter list

2018-01-02 Thread Eric Blake
On 12/25/2017 08:52 PM, Fam Zheng wrote: > Split options out of the "@table @var" section and create a "@table > @option", then use whitespaces and blank lines consistently. > > Suggested-by: Kevin Wolf > Signed-off-by: Fam Zheng > --- > qemu-img.texi | 66 > +++

Re: [Qemu-devel] [PATCH v2 1/2] qmp: adding 'wakeup-suspend-support' in query-target

2018-01-02 Thread Eric Blake
On 01/02/2018 02:28 PM, Daniel Henrique Barboza wrote: >>> With this extra tool, management can avoid situations where a guest >>> that does not have proper suspend/wake capabilities ends up in >>> inconsistent state (e.g. >>> https://github.com/open-power-host-os/qemu/issues/31). >>> >>> Signed-o

Re: [Qemu-devel] dropped pkts with Qemu on tap interace (RX)

2018-01-02 Thread Stefan Priebe - Profihost AG
Am 02.01.2018 um 18:04 schrieb Wei Xu: > On Tue, Jan 02, 2018 at 04:24:33PM +0100, Stefan Priebe - Profihost AG wrote: >> Hi, >> Am 02.01.2018 um 15:20 schrieb Wei Xu: >>> On Tue, Jan 02, 2018 at 12:17:29PM +0100, Stefan Priebe - Profihost AG >>> wrote: Hello, currently i'm trying

Re: [Qemu-devel] [PATCH v12 1/6] migration: introduce postcopy-blocktime capability

2018-01-02 Thread Eric Blake
On 10/30/2017 08:16 AM, Alexey Perevalov wrote: > Right now it could be used on destination side to > enable vCPU blocktime calculation for postcopy live migration. > vCPU blocktime - it's time since vCPU thread was put into > interruptible sleep, till memory page was copied and thread awake. > >

Re: [Qemu-devel] [PATCH 3/7] blockjob: create block_job_throttle

2018-01-02 Thread Jeff Cody
On Wed, Dec 13, 2017 at 07:59:49PM -0500, John Snow wrote: > This will replace mirror_throttle, for reuse in other jobs. > > Signed-off-by: John Snow > --- > block/mirror.c | 15 ++- > blockjob.c | 11 +++ > include/block/blockjob_int.h | 9 ++

Re: [Qemu-devel] [PATCH v12 2/6] migration: add postcopy blocktime ctx into MigrationIncomingState

2018-01-02 Thread Eric Blake
On 10/30/2017 08:16 AM, Alexey Perevalov wrote: > This patch adds request to kernel space for UFFD_FEATURE_THREAD_ID, > in case when this feature is provided by kernel. Either 'in the case when this feature' or 'in case this feature'. > > PostcopyBlocktimeContext is incapsulated inside postcopy-

Re: [Qemu-devel] [PATCH v12 6/6] migration: add postcopy total blocktime into query-migrate

2018-01-02 Thread Eric Blake
On 10/30/2017 08:16 AM, Alexey Perevalov wrote: > Postcopy total blocktime is available on destination side only. > But query-migrate was possible only for source. This patch > adds ability to call query-migrate on destination. > To be able to see postcopy blocktime, need to request postcopy-blockt

  1   2   3   >