Re: [Qemu-devel] [PATCH 0/8] sparc: IOMMU tidy-up and reorganisation

2017-12-19 Thread Artyom Tarasenko
On Sun, Nov 26, 2017 at 2:35 PM, Mark Cave-Ayland wrote: > Following on from the previous sun4u patchset, here is the next step of > IOMMU-related updates for 2.12. > > This patchset does 2 main things: firstly it moves the sun4m IOMMU > device out of hw/dma and into hw/sparc to match existing arc

Re: [Qemu-devel] [PATCH v1 00/13] Fix VNC server unbounded memory usage

2017-12-19 Thread Darren Kenny
Hi Daniel, For the series: Reviewed-by: Darren Kenny With one small nit on patch 1. Thanks, Darren. On Mon, Dec 18, 2017 at 07:12:15PM +, Daniel P. Berrange wrote: In the 2.11 release we fixed CVE-2017-15268, which allowed the VNC websockets server to consume arbitrary memory when a sl

Re: [Qemu-devel] [PATCH V5] pci: removed the is_express field since a uniform interface was inserted

2017-12-19 Thread Yoni Bettan
On 12/18/2017 05:21 PM, Yoni Bettan wrote: according to Eduardo Habkost's commit fd3b02c889 all PCIEs now implement INTERFACE_PCIE_DEVICE so we don't need is_express field anymore. Devices that implements only INTERFACE_PCIE_DEVICE (is_express == 1) or devices that implements only INTERFACE_CO

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 1/2] s390x/tcg: implement TEST PROTECTION

2017-12-19 Thread Thomas Huth
On 18.12.2017 23:46, David Hildenbrand wrote: > Linux uses TEST PROTECTION to sense for available memory locations. > > Let's implement what we can for now (just as for the other instructions, > excluding AR mode and special protection mechanisms). > > Signed-off-by: David Hildenbrand > --- > t

[Qemu-devel] [PATCH] build: Fix typo in scripts/git-submodule.sh

2017-12-19 Thread Lin Ma
Signed-off-by: Lin Ma --- scripts/git-submodule.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/git-submodule.sh b/scripts/git-submodule.sh index bc7224a..807ca0b 100755 --- a/scripts/git-submodule.sh +++ b/scripts/git-submodule.sh @@ -28,7 +28,7 @@ error() { e

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 2/2] s390x/sclp: fix missing be conversion

2017-12-19 Thread Thomas Huth
On 18.12.2017 23:46, David Hildenbrand wrote: > Linux crashes right now if maxmem > mem is specified on the command line. > > On s390x, the guest can hotplug memory itself right now - very weird - > and e.g. Fedora 27 will simply add all memory it can when booting. > > So now, we have at least th

[Qemu-devel] [PATCH] s390x/sclp: fixup highest CPU address

2017-12-19 Thread Christian Borntraeger
the highest cpu address is not the same as max_cpus. max_cpus counts from 1 while the cpu address starts at 0. Signed-off-by: Christian Borntraeger Reviewed-by: Jason J. Herne --- hw/s390x/sclp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp

Re: [Qemu-devel] [RFC/RFT PATCH 5/5] vfio/pci: Allow relocating MSI-X MMIO

2017-12-19 Thread Alexey Kardashevskiy
On 19/12/17 17:56, Alex Williamson wrote: > On Tue, 19 Dec 2017 17:02:59 +1100 > Alexey Kardashevskiy wrote: > >> On 19/12/17 14:40, Alex Williamson wrote: >>> On Tue, 19 Dec 2017 14:07:13 +1100 >>> Alexey Kardashevskiy wrote: >>> On 18/12/17 16:02, Alex Williamson wrote: > With re

[Qemu-devel] [RFC v6 01/27] chardev: use backend chr context when watch for fe

2017-12-19 Thread Peter Xu
In commit 6bbb6c0644 ("chardev: use per-dev context for io_add_watch_poll", 2017-09-22) all the chardev watches are converted to use per-chardev gcontext to support chardev to be run outside default main thread. However that's still missing one call from the frontend code. Touch that up. Signed-

[Qemu-devel] [RFC v6 02/27] qobject: introduce qstring_get_try_str()

2017-12-19 Thread Peter Xu
The only difference from qstring_get_str() is that it allows the qstring to be NULL. If so, NULL is returned. CC: Eric Blake CC: Markus Armbruster Reviewed-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Signed-off-by: Peter Xu --- include/qapi/qmp/qstring.h | 1 + qobject/qstring.c |

[Qemu-devel] [RFC v6 04/27] qobject: let object_property_get_str() use new API

2017-12-19 Thread Peter Xu
We can simplify object_property_get_str() using the new qobject_get_try_str(). Reviewed-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Signed-off-by: Peter Xu --- qom/object.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/qom/object.c b/qom/object.c index c58c52d518.

[Qemu-devel] [RFC v6 06/27] monitor: move the cur_mon hack deeper for QMP

2017-12-19 Thread Peter Xu
In monitor_qmp_read(), we have the hack to temporarily replace the cur_mon pointer. Now we move this hack deeper inside the QMP dispatcher routine since the Monitor pointer can be actually obtained using container_of() upon the parser object, just like most of the other JSON parser users do. This

[Qemu-devel] [RFC v6 00/27] QMP: out-of-band (OOB) execution support

2017-12-19 Thread Peter Xu
This v6 kept most of the high level design untouched, however there are quite a few of changes that try to make the series more robust and safe. My sincere thank to the reviewers (especially Stefan!) on all review comments to previous one. Let's see how this version goes. v6: - add r-bs - s/nego

[Qemu-devel] [RFC v6 03/27] qobject: introduce qobject_get_try_str()

2017-12-19 Thread Peter Xu
A quick way to fetch string from qobject when it's a QString. Reviewed-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Signed-off-by: Peter Xu --- include/qapi/qmp/qstring.h | 1 + qobject/qstring.c | 11 +++ 2 files changed, 12 insertions(+) diff --git a/include/qapi/qmp/qstring

[Qemu-devel] [RFC v6 05/27] monitor: move skip_flush into monitor_data_init

2017-12-19 Thread Peter Xu
It's part of the data init. Collect it. Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Signed-off-by: Peter Xu --- monitor.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index d682eee2d8..0030ded8f1

[Qemu-devel] [RFC v6 07/27] monitor: unify global init

2017-12-19 Thread Peter Xu
There are many places for monitor init its globals, at least: - monitor_init_qmp_commands() at the very beginning - single function to init monitor_lock - in the first entry of monitor_init() using "is_first_init" Unify them a bit. Reviewed-by: Fam Zheng Signed-off-by: Peter Xu --- include/mo

[Qemu-devel] [RFC v6 10/27] monitor: allow to use IO thread for parsing

2017-12-19 Thread Peter Xu
For each Monitor, add one field "use_io_thr" to show whether it will be using the dedicated monitor IO thread to handle input/output. When set, monitor IO parsing work will be offloaded to dedicated monitor IO thread, rather than the original main loop thread. This only works for QMP. HMP will a

[Qemu-devel] [RFC v6 08/27] monitor: let mon_list be tail queue

2017-12-19 Thread Peter Xu
It was QLIST. I want to use this list to do monitor priority job later, which need tail insertion ability. So switching to a tail queue. Reviewed-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Signed-off-by: Peter Xu --- monitor.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-)

[Qemu-devel] [RFC v6 09/27] monitor: create monitor dedicate iothread

2017-12-19 Thread Peter Xu
Create one IOThread for the monitors, prepared to handle all the input/output IOs using existing iothread framework. Signed-off-by: Peter Xu --- monitor.c | 29 + 1 file changed, 29 insertions(+) diff --git a/monitor.c b/monitor.c index 95fc54d97f..4ebd83fd94 100644

[Qemu-devel] [RFC v6 18/27] monitor: send event when command queue full

2017-12-19 Thread Peter Xu
Set maximum QMP command queue length to 8. If queue full, instead of queue the command, we directly return a "command-dropped" event, telling client that specific command is dropped. Note that this flow control mechanism is only valid if OOB is enabled. If it's not, the effective queue length wil

[Qemu-devel] [RFC v6 14/27] monitor: let suspend_cnt be thread safe

2017-12-19 Thread Peter Xu
Monitor code now can be run in more than one thread. Let it be thread safe when accessing suspend_cnt counter. Signed-off-by: Peter Xu --- monitor.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/monitor.c b/monitor.c index cf1e5d881c..844508d134 100644 --- a/

[Qemu-devel] [RFC v6 11/27] qmp: introduce QMPCapability

2017-12-19 Thread Peter Xu
There was no QMP capabilities defined. Define the first "oob" as capability to allow out-of-band messages. Also, touch up qmp-test.c to test the new bits. Signed-off-by: Peter Xu --- monitor.c| 10 -- qapi-schema.json | 13 + tests/qmp-test.c | 10 +- 3 file

[Qemu-devel] [RFC v6 16/27] monitor: separate QMP parser and dispatcher

2017-12-19 Thread Peter Xu
Originally QMP goes throw these steps: JSON Parser --> QMP Dispatcher --> Respond /|\(2)(3) | (1) | \|/ (4) +- main thread + This patch does this: JSON Parser QMP Dispatcher --> Respond /|\ |

[Qemu-devel] [RFC v6 19/27] qapi: introduce new cmd option "allow-oob"

2017-12-19 Thread Peter Xu
Here "oob" stands for "Out-Of-Band". When "allow-oob" is set, it means the command allows out-of-band execution. The "oob" idea is proposed by Markus Armbruster in following thread: https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg02057.html This new "allow-oob" boolean will be expose

[Qemu-devel] [RFC v6 15/27] monitor: let suspend/resume work even with QMPs

2017-12-19 Thread Peter Xu
One thing to mention is that for QMPs that are using IOThreads, we need an explicit kick for the IOThread in case it is sleeping. Since at it, add traces for the operations. Signed-off-by: Peter Xu --- monitor.c| 26 +- trace-events | 1 + 2 files changed, 22 insert

[Qemu-devel] [RFC v6 12/27] qmp: negotiate QMP capabilities

2017-12-19 Thread Peter Xu
After this patch, we will allow QMP clients to enable QMP capabilities when sending the first "qmp_capabilities" command. Originally we are starting QMP session with no arguments like: { "execute": "qmp_capabilities" } Now we can enable some QMP capabilities using (take OOB as example, which i

[Qemu-devel] [RFC v6 17/27] qmp: add new event "command-dropped"

2017-12-19 Thread Peter Xu
This event will be emitted if one QMP command is dropped. Along, declare an enum for the reasons. Signed-off-by: Peter Xu --- qapi-schema.json | 37 + 1 file changed, 37 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json index 531fd4c0db..447ab25

[Qemu-devel] [RFC v6 23/27] monitor: enable IO thread for (qmp & !mux) typed

2017-12-19 Thread Peter Xu
Start to use dedicate IO thread for QMP monitors that are not using MUXed chardev. Signed-off-by: Peter Xu --- monitor.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/monitor.c b/monitor.c index 0c6403bc65..7183061c2b 100644 --- a/monitor.c +++ b/monitor.c @@ -35,6 +35,

[Qemu-devel] [RFC v6 20/27] qmp: export qmp_dispatch_check_obj and allow "id"

2017-12-19 Thread Peter Xu
We need this for earlier check for OOB, before reaching do_qmp_dispatch(). Meanwhile, a small touch-up to allow "id" field, after all we allow that for sure in the spec (in any form). Signed-off-by: Peter Xu --- include/qapi/qmp/dispatch.h | 1 + qapi/qmp-dispatch.c | 4 +++- 2 files ch

[Qemu-devel] [RFC v6 21/27] qmp: support out-of-band (oob) execution

2017-12-19 Thread Peter Xu
Having "allow-oob" to true for a command does not mean that this command will always be run in out-of-band mode. The out-of-band quick path will only be executed if we specify the extra "run-oob" flag when sending the QMP request: { "execute": "command-that-allows-oob", "arguments": {

[Qemu-devel] [RFC v6 13/27] monitor: introduce monitor_qmp_respond()

2017-12-19 Thread Peter Xu
A tiny refactoring, preparing to split the QMP dispatcher away. Reviewed-by: Fam Zheng Signed-off-by: Peter Xu --- monitor.c | 50 +- 1 file changed, 33 insertions(+), 17 deletions(-) diff --git a/monitor.c b/monitor.c index c88a11cd69..cf1e5d881

[Qemu-devel] [RFC v6 22/27] qmp: isolate responses into io thread

2017-12-19 Thread Peter Xu
For those monitors who has enabled IO thread, we'll offload the responding procedure into IO thread. The main reason is that chardev is not thread safe, and we need to do all the read/write IOs in the same thread. For use_io_thr=true monitors, that thread is the IO thread. We do this isolation i

Re: [Qemu-devel] [PATCH 2/2] virtio: fix IO request length in virtio SCSI/block

2017-12-19 Thread Roman Kagan
On Mon, Dec 18, 2017 at 10:42:35PM +0300, Denis V. Lunev wrote: > On 12/18/2017 10:35 PM, Felipe Franciosi wrote: > >> On 18 Dec 2017, at 16:16, Harris, James R wrote: > >>> On Dec 18, 2017, at 6:38 AM, Stefan Hajnoczi wrote: > >>> On Fri, Dec 15, 2017 at 06:02:50PM +0300, Denis V. Lunev wrote: >

Re: [Qemu-devel] [virtio-dev] Re: [RFC virtio-dev] vhost-user-slave: add vhost-user slave device type

2017-12-19 Thread Stefan Hajnoczi
On Tue, Dec 19, 2017 at 04:00:13PM +0800, Wei Wang wrote: > On 12/16/2017 01:05 AM, Stefan Hajnoczi wrote: > > The vhost-user slave device facilitates vhost-user device emulation > > through vhost-user protocol exchanges and access to shared memory. > > Software-defined networking, storage, and oth

[Qemu-devel] [RFC v6 25/27] docs: update QMP documents for OOB commands

2017-12-19 Thread Peter Xu
Update both the developer and spec for the new QMP OOB (Out-Of-Band) command. Signed-off-by: Peter Xu --- docs/devel/qapi-code-gen.txt | 70 docs/interop/qmp-spec.txt| 30 --- 2 files changed, 91 insertions(+), 9 deletions(-) diff

[Qemu-devel] [RFC v6 24/27] qmp: add command "x-oob-test"

2017-12-19 Thread Peter Xu
This command is only used to test OOB functionality. It should not be used for any other purposes. Reviewed-by: Stefan Hajnoczi Signed-off-by: Peter Xu --- qapi-schema.json | 18 ++ qmp.c| 16 2 files changed, 34 insertions(+) diff --git a/qapi-sch

Re: [Qemu-devel] [PATCH v2 1/1] chardev: convert the socket server to QIONetListener

2017-12-19 Thread Paolo Bonzini
On 18/12/2017 14:54, Daniel P. Berrange wrote: > Instead of creating a QIOChannelSocket directly for the chardev > server socket, use a QIONetListener. This provides the ability > to listen on multiple sockets at the same time, so enables > full support for IPv4/IPv6 dual stack. > > Signed-off-by:

[Qemu-devel] [RFC v6 27/27] tests: qmp-test: add oob test

2017-12-19 Thread Peter Xu
Test the new OOB capability. Here we used the new "x-oob-test" command. Firstly, we send a lock=true and oob=false command to hang the main thread. Then send another lock=false and oob=true command (which will be run inside parser this time) to free that hanged command. Reviewed-by: Stefan Hajno

[Qemu-devel] [RFC v6 26/27] tests: qmp-test: verify command batching

2017-12-19 Thread Peter Xu
OOB introduced DROP event for flow control. This should not affect old QMP clients. Add a command batching check to make sure of it. Reviewed-by: Stefan Hajnoczi Signed-off-by: Peter Xu --- tests/qmp-test.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/tests/qmp-

Re: [Qemu-devel] [PULL 00/23] Block patches

2017-12-19 Thread Stefan Hajnoczi
On Tue, Dec 19, 2017 at 12:15:18AM +, Peter Maydell wrote: > On 18 December 2017 at 14:35, Stefan Hajnoczi wrote: > > The following changes since commit 411ad78115ebeb3411cf4b7622784b93dfabe259: > > > > Merge remote-tracking branch > > 'remotes/stefanberger/tags/pull-tpm-2017-12-15-1' into

Re: [Qemu-devel] [PATCH 2/2] qemu: add linkspeed and duplex setting to virtio-net

2017-12-19 Thread Yan Vugenfirer
> On 18 Dec 2017, at 18:04, Jason Baron via Qemu-devel > wrote: > > > > On 12/18/2017 06:34 AM, Yan Vugenfirer wrote: >> >>> On 14 Dec 2017, at 21:33, Jason Baron via Qemu-devel >>> wrote: >>> >>> Although they can be currently set in linux via 'ethtool -s', this requires >>> guest change

Re: [Qemu-devel] [RFC PATCH] vhost-user: quit infinite loop while used memslots is more than the backend limit

2017-12-19 Thread Jason Wang
On 2017年12月13日 15:04, Jay Zhou wrote: Steps to 100% reproduce: (1) start a VM with two VFIO 82599 PCI NICs successfully (2) hot plug a RAM, which is attached successfully (3) hot plug another RAM, which is attached successfully (4) hot plug a vhost-user NIC, which is attached successfully (5) h

Re: [Qemu-devel] [PATCH 11/15] apb: split pci_pbm_map_irq() into separate functions for bus A and bus B

2017-12-19 Thread Mark Cave-Ayland
On 19/12/17 07:56, Artyom Tarasenko wrote: On Sun, Dec 17, 2017 at 12:09 PM, Mark Cave-Ayland wrote: On 19/11/17 11:06, Mark Cave-Ayland wrote: On 17/11/17 14:33, Artyom Tarasenko wrote: On Fri, Nov 17, 2017 at 2:42 PM, Mark Cave-Ayland wrote: After the previous refactoring it is now pos

Re: [Qemu-devel] [PATCH 11/15] apb: split pci_pbm_map_irq() into separate functions for bus A and bus B

2017-12-19 Thread Artyom Tarasenko
On Tue, Dec 19, 2017 at 10:27 AM, Mark Cave-Ayland wrote: > On 19/12/17 07:56, Artyom Tarasenko wrote: >> >> On Sun, Dec 17, 2017 at 12:09 PM, Mark Cave-Ayland >> wrote: >>> >>> On 19/11/17 11:06, Mark Cave-Ayland wrote: >>> On 17/11/17 14:33, Artyom Tarasenko wrote: > On Fri, Nov 1

Re: [Qemu-devel] [PATCH 0/3] block: Deprecated options

2017-12-19 Thread Markus Armbruster
Thomas Huth writes: > Remove the deprecated "-drive boot" and "-hdachs" options and properly > mark some other deprecated options in the deprecation chapter. Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH 2/2] virtio: fix IO request length in virtio SCSI/block

2017-12-19 Thread Liu, Changpeng
> -Original Message- > From: Roman Kagan [mailto:rka...@virtuozzo.com] > Sent: Tuesday, December 19, 2017 4:58 PM > To: Denis V. Lunev > Cc: Felipe Franciosi ; Harris, James R > ; Stefan Hajnoczi ; Kevin Wolf > ; Eduardo Habkost ; Michael S. > Tsirkin ; qemu-devel@nongnu.org; Max Reitz >

[Qemu-devel] [PATCH V3] vl.c && linux-user/main.c : removed **envp from main() arguments

2017-12-19 Thread Yoni Bettan
it was added on 2008 902b3d5c39 when introduced cache-utils.[ch] since then cache-utils.[ch] were removed but **envp was left behind. By the way "to be portable it is best to write main to take two arguments, and use the value of environ" according to https://www.gnu.org/software/libc/manual/html

Re: [Qemu-devel] [PATCH v2 1/1] qmp: marking qmp_cpu as deprecated

2017-12-19 Thread Markus Armbruster
Daniel Henrique Barboza writes: > qmp_cpu is a nop that was created a while ago in commit 755f196898 > ("qapi: Convert the cpu command") for the sake of compatibility, > due to the existence of hmp_cpu. The compatibility argument makes no sense to me, but it's the reason the commit documented.

Re: [Qemu-devel] [PATCH 0/2] migration/channel errors and cancelling

2017-12-19 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Fri, Dec 15, 2017 at 05:16:53PM +, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Hi, > > Where a channel fails asynchronously during connect, call > > back through the migration code so it can clean up. > > In par

Re: [Qemu-devel] [PATCH V3] vl.c && linux-user/main.c : removed **envp from main() arguments

2017-12-19 Thread Yoni Bettan
On 12/19/2017 12:11 PM, Yoni Bettan wrote: it was added on 2008 902b3d5c39 when introduced cache-utils.[ch] since then cache-utils.[ch] were removed but **envp was left behind. By the way "to be portable it is best to write main to take two arguments, and use the value of environ" according t

Re: [Qemu-devel] [PATCH V3] vl.c && linux-user/main.c : removed **envp from main() arguments

2017-12-19 Thread Laurent Vivier
Le 19/12/2017 à 11:11, Yoni Bettan a écrit : > it was added on 2008 902b3d5c39 when introduced cache-utils.[ch] > > since then cache-utils.[ch] were removed but **envp was left > behind. > > By the way "to be portable it is best to write main to take two > arguments, and use the value of environ"

Re: [Qemu-devel] [RFC PATCH] vhost-user: quit infinite loop while used memslots is more than the backend limit

2017-12-19 Thread Zhoujian (jay)
> -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Tuesday, December 19, 2017 5:24 PM > To: Zhoujian (jay) ; qemu-devel@nongnu.org > Cc: m...@redhat.com; Gonglei (Arei) ; > marcandre.lur...@redhat.com; Huangweidong (C) ; > wangxin (U) > Subject: Re: [RFC PATCH]

Re: [Qemu-devel] [PATCH] build: Fix typo in scripts/git-submodule.sh

2017-12-19 Thread Marc-André Lureau
On Tue, Dec 19, 2017 at 9:25 AM, Lin Ma wrote: > Signed-off-by: Lin Ma > --- > scripts/git-submodule.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/git-submodule.sh b/scripts/git-submodule.sh > index bc7224a..807ca0b 100755 > --- a/scripts/git-submodule.sh >

[Qemu-devel] [Bug 1738840] Re: qemu-img convert qcow2 to raw fails on OS X

2017-12-19 Thread Robert Marklund
I gave it a try here: http://termbin.com/ufv4 Its only the first 4096 bytes. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1738840 Title: qemu-img convert qcow2 to raw fails on OS X Status in QEM

Re: [Qemu-devel] [PATCH] s390x/sclp: fixup highest CPU address

2017-12-19 Thread David Hildenbrand
On 19.12.2017 09:28, Christian Borntraeger wrote: > the highest cpu address is not the same as max_cpus. max_cpus > counts from 1 while the cpu address starts at 0. > > Signed-off-by: Christian Borntraeger > Reviewed-by: Jason J. Herne > --- > hw/s390x/sclp.c | 2 +- > 1 file changed, 1 inserti

Re: [Qemu-devel] [PATCH] sockets: Fix test for DragonFly BSD

2017-12-19 Thread Daniel P. Berrange
On Tue, Dec 19, 2017 at 12:21:05AM +, Antonio Huete Jiménez wrote: > From f57cdc7ec2d5a5e906fa8b795eeede2d7b66aa56 Mon Sep 17 00:00:00 2001 > From: Antonio Huete Jimenez > Date: Fri, 15 Dec 2017 01:08:10 +0100 > Subject: [PATCH] sockets: Fix test for DragonFly BSD > > DragonFly BSD does not i

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 1/2] s390x/tcg: implement TEST PROTECTION

2017-12-19 Thread David Hildenbrand
On 19.12.2017 09:20, Thomas Huth wrote: > On 18.12.2017 23:46, David Hildenbrand wrote: >> Linux uses TEST PROTECTION to sense for available memory locations. >> >> Let's implement what we can for now (just as for the other instructions, >> excluding AR mode and special protection mechanisms). >> >

Re: [Qemu-devel] [PATCH v1 01/13] ui: remove 'sync' parametr from vnc_update_client

2017-12-19 Thread Daniel P. Berrange
Just cc'ing qemu-devel back on the mail since it was accidentally dropped. On Tue, Dec 19, 2017 at 07:26:29AM +, Darren Kenny wrote: > Small nit on the subject s/parametr/parameter/ > > Otherwise, looks good. > > Reviewed-by: Darren Kenny > > Thanks, > > Darren. > > On Mon, Dec 18, 2017

Re: [Qemu-devel] [PATCH] travis: add no-TPM build

2017-12-19 Thread Cornelia Huck
On Mon, 18 Dec 2017 12:35:52 -0300 Philippe Mathieu-Daudé wrote: > Use CI to avoid TPM bitrot: > hw/core/qdev-properties-system.o: In function `release_tpm': > hw/core/qdev-properties-system.c:291: undefined reference to > `tpm_backend_reset' > > Reported-by: Cornelia Huck > Signed-off-by:

Re: [Qemu-devel] [PATCH] Remove legacy -no-kvm-pit option

2017-12-19 Thread Paolo Bonzini
On 18/12/2017 18:44, Thomas Huth wrote: > It's only printing a warning since QEMU v1.3.0, so nobody should use > this anymore today. Let's get rid of this now. > > Signed-off-by: Thomas Huth > --- > qemu-doc.texi | 5 - > qemu-options.hx | 3 --- > vl.c| 4 > 3 files chang

Re: [Qemu-devel] [PATCH v5 26/28] migration: allow migrate_cancel to pause postcopy

2017-12-19 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > It was allowed in the past to even cancel a postcopy migration, but it > does not really make sense, and no one should be using it, since > cancelling a migration during postcopy means crashing the VM at no time. > > Let's just use re-use this command as a w

Re: [Qemu-devel] [PATCH] scripts/make-release: More .git removal

2017-12-19 Thread Daniel P. Berrange
On Mon, Dec 18, 2017 at 05:33:54PM -0500, Cole Robinson wrote: > As was last done in 379e21c25, we want to remove .git files for > submodules here, which we aren't presently doing for capstone and > keycodemapdb. > > Rather than a whitelist use 'find' to future proof this > > Signed-off-by: Cole

Re: [Qemu-devel] [PATCH qemu] RFC: spapr/iommu: Enable in-kernel TCE acceleration via VFIO KVM device

2017-12-19 Thread Paolo Bonzini
On 12/12/2017 06:46, Alex Williamson wrote: >> +enum IOMMUMemoryRegionAttr { >> +IOMMU_ATTR_KVM_FD > > You're generalizing the wrong thing here, this is specifically a > SPAPR_TCE_FD, call it that. ... and you're not even implementing set_attr, so let's drop it. My suggestion is to add a fun

Re: [Qemu-devel] [PATCH 1/4] spice: remove QXLWorker interface field

2017-12-19 Thread Frediano Ziglio
ping > > ping the series > > > > > This fields points to an old interface that is no more > > used in the current code. > > > > Signed-off-by: Frediano Ziglio > > --- > > hw/display/qxl.c | 1 - > > include/ui/spice-display.h | 1 - > > ui/spice-display.c | 2 -- > > 3 file

Re: [Qemu-devel] [PATCH 0/2] migration/channel errors and cancelling

2017-12-19 Thread Peter Xu
On Tue, Dec 19, 2017 at 10:14:08AM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Fri, Dec 15, 2017 at 05:16:53PM +, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > Hi, > > > Where a channel fails asynchronously

[Qemu-devel] [Bug 1670175] Re: qemu-system-sparc64 with tribblix-sparc-0m16.iso ends with "panic - kernel: no nucleus hblk8 to allocate"

2017-12-19 Thread Michal Nowak
With QEMU 2.11 there are two new warnings I haven't seen before (execution was still the same): ... unix-tte:interpret: exception -13 caught interpret ' unix-tte is va>tte-data failed with error ffed WARNING: consconfig: cannot find driver for screen device /pci@1fe,0/pci@1,1/QEMU,VGA

Re: [Qemu-devel] [PATCH 0/2] migration/channel errors and cancelling

2017-12-19 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Tue, Dec 19, 2017 at 10:14:08AM +, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > On Fri, Dec 15, 2017 at 05:16:53PM +, Dr. David Alan Gilbert (git) > > > wrote: > > > > From: "Dr. David Alan Gilbert" > > > > > > >

Re: [Qemu-devel] [virtio-dev] [PATCH v3 0/7] Vhost-pci for inter-VM communication

2017-12-19 Thread Stefan Hajnoczi
On Tue, Dec 05, 2017 at 11:33:09AM +0800, Wei Wang wrote: > Vhost-pci is a point-to-point based inter-VM communication solution. This > patch series implements the vhost-pci-net device setup and emulation. The > device is implemented as a virtio device, and it is set up via the > vhost-user protoco

[Qemu-devel] [PATCH] Split adb.c into adb.c, adb-mouse.c and adb-kbd.c

2017-12-19 Thread Laurent Vivier
It makes the code clearer to separate the bus implementation from the devices one. Remove ADB_DPRINTF() from adb.c instead of adding it to new files. Some minor changes to make checkpatch.pl happy. Signed-off-by: Laurent Vivier --- hw/input/Makefile.objs | 2 +- hw/input/adb-kbd.c | 395 +

[Qemu-devel] [PULL v1] tpm: move qdev_prop_tpm to hw/tpm/

2017-12-19 Thread Stefan Berger
From: Cornelia Huck Building with --disable-tpm yields ../hw/core/qdev-properties-system.o: In function `set_tpm': /home/cohuck/git/qemu/hw/core/qdev-properties-system.c:274: undefined reference to `qemu_find_tpm_be' /home/cohuck/git/qemu/hw/core/qdev-properties-system.c:278: undefined referenc

[Qemu-devel] [PULL v1] Merge tpm 2017/12/19

2017-12-19 Thread Stefan Berger
The patch in this pull request fixes a linker error when --disable-tpm is used. Stefan The following changes since commit eaefea537b476cb853e2edbdc68e969ec777e4bb: Merge remote-tracking branch 'remotes/mjt/tags/trivial-patches-fetch' into staging (2017-12-18 14:17:42 +) are available

Re: [Qemu-devel] [PATCH v2 1/1] qmp: marking qmp_cpu as deprecated

2017-12-19 Thread Daniel Henrique Barboza
On 12/19/2017 08:12 AM, Markus Armbruster wrote: Daniel Henrique Barboza writes: qmp_cpu is a nop that was created a while ago in commit 755f196898 ("qapi: Convert the cpu command") for the sake of compatibility, due to the existence of hmp_cpu. The compatibility argument makes no sense to

[Qemu-devel] [PATCH v20 0/7] Virtio-balloon Enhancement

2017-12-19 Thread Wei Wang
This patch series enhances the existing virtio-balloon with the following new features: 1) fast ballooning: transfer ballooned pages between the guest and host in chunks using sgs, instead of one array each time; and 2) free page block reporting: a new virtqueue to report guest free pages to the ho

[Qemu-devel] [PATCH v20 6/7] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ

2017-12-19 Thread Wei Wang
Negotiation of the VIRTIO_BALLOON_F_FREE_PAGE_VQ feature indicates the support of reporting hints of guest free pages to host via virtio-balloon. Host requests the guest to report free pages by sending a new cmd id to the guest via the free_page_report_cmd_id configuration register. When the gues

[Qemu-devel] [PATCH v20 1/7] xbitmap: Introduce xbitmap

2017-12-19 Thread Wei Wang
From: Matthew Wilcox The eXtensible Bitmap is a sparse bitmap representation which is efficient for set bits which tend to cluster. It supports up to 'unsigned long' worth of bits, and this commit adds the bare bones -- xb_set_bit(), xb_clear_bit() and xb_test_bit(). Signed-off-by: Wei Wang Cc

[Qemu-devel] [PATCH v20 3/7] xbitmap: add more operations

2017-12-19 Thread Wei Wang
This patch adds support to find next 1 or 0 bit in a xbmitmap range and clear a range of bits. More possible optimizations to add in the future: 1) xb_set_bit_range: set a range of bits. 2) when searching a bit, if the bit is not found in the slot, move on to the next slot directly. 3) add tags to

[Qemu-devel] [PATCH v20 2/7] xbitmap: potential improvement

2017-12-19 Thread Wei Wang
This patch made some changes to the original xbitmap implementation from the linux-dax tree: - xb_set_bit: delete the new inserted radix_tree_node when failing to get the per cpu ida bitmap, this avoids the kind of memory leak of the unused radix tree node left in the tree. - xb_preload: with

[Qemu-devel] [PATCH v20 4/7] virtio-balloon: VIRTIO_BALLOON_F_SG

2017-12-19 Thread Wei Wang
Add a new feature, VIRTIO_BALLOON_F_SG, which enables the transfer of balloon (i.e. inflated/deflated) pages using scatter-gather lists to the host. The implementation of the previous virtio-balloon is not very efficient, because the balloon pages are transferred to the host by one array each time

[Qemu-devel] [PATCH v20 5/7] mm: support reporting free page blocks

2017-12-19 Thread Wei Wang
This patch adds support to walk through the free page blocks in the system and report them via a callback function. Some page blocks may leave the free list after zone->lock is released, so it is the caller's responsibility to either detect or prevent the use of such pages. One use example of this

[Qemu-devel] [PATCH v20 7/7] virtio-balloon: don't report free pages when page poisoning is enabled

2017-12-19 Thread Wei Wang
The guest free pages should not be discarded by the live migration thread when page poisoning is enabled with PAGE_POISONING_NO_SANITY=n, because skipping the transfer of such poisoned free pages will trigger false positive when new pages are allocated and checked on the destination. This patch add

Re: [Qemu-devel] [PATCH 2/2] vhost-user: document memory accesses

2017-12-19 Thread Maxime Coquelin
On 12/14/2017 09:22 PM, Stefan Hajnoczi wrote: The vhost-user protocol specification does not define "guest address" and "user address". It does not explain how to access memory given such addresses. This patch explains how memory access works, including the IOTLB. Cc: Michael S. Tsirkin Cc:

Re: [Qemu-devel] [PATCH v3 0/2] virtio: fix IO request length in virtio SCSI/block

2017-12-19 Thread Denis V. Lunev
On 12/15/2017 06:02 PM, Denis V. Lunev wrote: > v2->v3 > - added 2.12 machine types > - added compat properties for 2.11 machine type > > v1->v2: > - added max_segments property for virtblock device > > Signed-off-by: Denis V. Lunev > CC: "Michael S. Tsirkin" > CC: Stefan Hajnoczi > CC: Kevin Wo

Re: [Qemu-devel] [PULL 0/4] Tracing patches

2017-12-19 Thread Peter Maydell
On 18 December 2017 at 14:47, Stefan Hajnoczi wrote: > The following changes since commit 411ad78115ebeb3411cf4b7622784b93dfabe259: > > Merge remote-tracking branch > 'remotes/stefanberger/tags/pull-tpm-2017-12-15-1' into staging (2017-12-17 > 15:27:41 +) > > are available in the Git repos

Re: [Qemu-devel] [PATCH] Remove legacy -no-kvm-pit option

2017-12-19 Thread Thomas Huth
On 19.12.2017 11:56, Paolo Bonzini wrote: > On 18/12/2017 18:44, Thomas Huth wrote: >> It's only printing a warning since QEMU v1.3.0, so nobody should use >> this anymore today. Let's get rid of this now. >> >> Signed-off-by: Thomas Huth >> --- >> qemu-doc.texi | 5 - >> qemu-options.hx |

Re: [Qemu-devel] [PATCH v2 1/1] qmp: marking qmp_cpu as deprecated

2017-12-19 Thread Eric Blake
On 12/19/2017 06:19 AM, Daniel Henrique Barboza wrote: Let's compare behavior: 0. Status quo   do nothing and succeed 1. Your patch   fail with GenericError 2. Your patch less error_setg() do nothing and succeed 3. Immediate removal    fai

Re: [Qemu-devel] [PATCH v3] rcu: reduce more than 7MB heap memory by malloc_trim()

2017-12-19 Thread Paolo Bonzini
On 18/12/2017 08:51, Yang Zhong wrote: > On Mon, Dec 18, 2017 at 03:17:33PM +0800, Shannon Zhao wrote: >> >> >> On 2017/12/12 14:54, Yang Zhong wrote: > 2) what effect it has on boot time in Shannon's case. >>> Hello Shannon, >>> >>> It's hard for me to reproduce your commands in my x86 env

Re: [Qemu-devel] [PATCH 0/5] i8259: cleanups and enhancements

2017-12-19 Thread Paolo Bonzini
On 10/12/2017 07:38, Peter Xu wrote: > It's mostly a cleanup, but patch 4 allows kvm-i8259 to support "info > pic" and "info irq" too. > > I'm thinking whether it'll be good to move on this work to spread > these commands to IOAPICs too, by removing "info ioapic" command and > let "info pic" dump

Re: [Qemu-devel] [PATCH V3] vl.c && linux-user/main.c : removed **envp from main() arguments

2017-12-19 Thread Yoni Bettan
On 12/19/2017 12:21 PM, Laurent Vivier wrote: Le 19/12/2017 à 11:11, Yoni Bettan a écrit : it was added on 2008 902b3d5c39 when introduced cache-utils.[ch] since then cache-utils.[ch] were removed but **envp was left behind. By the way "to be portable it is best to write main to take two arg

Re: [Qemu-devel] [PATCH] scripts/make-release: More .git removal

2017-12-19 Thread Markus Armbruster
Cole Robinson writes: > As was last done in 379e21c25, we want to remove .git files for > submodules here, which we aren't presently doing for capstone and > keycodemapdb. > > Rather than a whitelist use 'find' to future proof this > > Signed-off-by: Cole Robinson > --- > scripts/make-release |

Re: [Qemu-devel] [PATCH V3] vl.c && linux-user/main.c : removed **envp from main() arguments

2017-12-19 Thread Laurent Vivier
Le 19/12/2017 à 14:05, Yoni Bettan a écrit : > > > On 12/19/2017 12:21 PM, Laurent Vivier wrote: >> Le 19/12/2017 à 11:11, Yoni Bettan a écrit : >>> it was added on 2008 902b3d5c39 when introduced cache-utils.[ch] >>> >>> since then cache-utils.[ch] were removed but **envp was left >>> behind. >>

[Qemu-devel] [PATCH] virtio-blk: notify guest directly

2017-12-19 Thread sochin . jiang
From: "sochin.jiang" Till now, we've already notify guest as a batch mostly, an extra BH won't decrease guest interrupts much, but cause a significant notification loss. Generally, we could have 15% or so performance lost in single queue IO models, as I tested. Signed-off-by: sochin.jiang -

Re: [Qemu-devel] [PATCH v20 0/7] Virtio-balloon Enhancement

2017-12-19 Thread Tetsuo Handa
Wei Wang wrote: > ChangeLog: > v19->v20: > 1) patch 1: xbitmap > - add __rcu to "void **slot"; > - remove the exceptional path. > 2) patch 3: xbitmap > - DeveloperNotes: add an item to comment that the current bit range > related APIs operating on extremely large ranges (e

Re: [Qemu-devel] [PATCH qemu] RFC: spapr/iommu: Enable in-kernel TCE acceleration via VFIO KVM device

2017-12-19 Thread Alex Williamson
On Tue, 19 Dec 2017 12:12:35 +0100 Paolo Bonzini wrote: > On 12/12/2017 06:46, Alex Williamson wrote: > >> +enum IOMMUMemoryRegionAttr { > >> +IOMMU_ATTR_KVM_FD > > > > You're generalizing the wrong thing here, this is specifically a > > SPAPR_TCE_FD, call it that. > > ... and you're no

Re: [Qemu-devel] [PATCH v1] hmp: 'info snapshots' not showing the id

2017-12-19 Thread Max Reitz
On 2017-12-18 10:24, seeteena wrote: > > > On 12/15/2017 02:48 PM, Max Reitz wrote: >> On 2017-12-13 05:50, seeteena wrote: >>> Hi David, >>> >>> While creating snapshots when tag name '0' used in the very first and >>> followed by tag name '1' then snapshot created with tag name '0' is getting

Re: [Qemu-devel] [PATCH RFC] error: Include hint everywhere

2017-12-19 Thread Markus Armbruster
Adding Eric for additonal QMP design expertise. Fam Zheng writes: > Previously we only print hint lines if we are in a command line context > or HMP. However QMP errors are also eventually consumed by human and the > hint could help. > > Append hint lines already in error_get_pretty() and do as

Re: [Qemu-devel] [PATCH v20 0/7] Virtio-balloon Enhancement

2017-12-19 Thread Matthew Wilcox
On Tue, Dec 19, 2017 at 11:05:11PM +0900, Tetsuo Handa wrote: > Removing exceptional path made this patch easier to read. > But what I meant is > > Can you eliminate exception path and fold all xbitmap patches into one, and > post only one xbitmap patch without virtio-balloon changes? > > .

Re: [Qemu-devel] [virtio-dev] [PATCH v3 0/7] Vhost-pci for inter-VM communication

2017-12-19 Thread Michael S. Tsirkin
> * Please handle short reads/writes and EAGAIN with the UNIX domain socket. > Do >not use read/write_all() functions because they hang QEMU until I/O >completes. I'm not sure I agree with this one. vhost-user uses this extensively right now. It might be a worth-while goal to drop this

Re: [Qemu-devel] [RFC v6 1/2] virtio: introduce `query-virtio' QMP command

2017-12-19 Thread Markus Armbruster
QAPI/QMP interface review only. You neglected to cc: the maintainers of qapi-schema.json, so I'm doing that for you. Jan Dakinevich writes: > The command is intended for gathering virtio information such as status, > feature bits, negotiation status. It is convenient and useful for debug > purp

Re: [Qemu-devel] [PATCH v1 00/13] Fix VNC server unbounded memory usage

2017-12-19 Thread Marc-André Lureau
Hi - Original Message - > In the 2.11 release we fixed CVE-2017-15268, which allowed the VNC websockets > server to consume arbitrary memory when a slow client was connected. I have > since discovered that this same type of problem can be triggered in several > other ways in the regular (n

Re: [Qemu-devel] [PATCH qemu] RFC: spapr/iommu: Enable in-kernel TCE acceleration via VFIO KVM device

2017-12-19 Thread Paolo Bonzini
On 19/12/2017 15:09, Alex Williamson wrote: > On Tue, 19 Dec 2017 12:12:35 +0100 > Paolo Bonzini wrote: > >> On 12/12/2017 06:46, Alex Williamson wrote: +enum IOMMUMemoryRegionAttr { +IOMMU_ATTR_KVM_FD >>> >>> You're generalizing the wrong thing here, this is specifically a >>> SP

  1   2   3   >