[Qemu-devel] [PATCH v4 35/46] windbg: implemented kd_api_continue

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |1 + windbgstub-utils.c | 15 +++ windbgstub.c|5 + 3 files changed, 21 insertions(+) diff --git a/inclu

[Qemu-devel] [PATCH v4 37/46] windbg: implemented kd_api_read_physical_memory and kd_api_write_physical_memory

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |2 ++ windbgstub-utils.c | 29 + windbgstub.c|8 3 files changed, 39 insertions(+)

[Qemu-devel] [PATCH v4 33/46] windbg: implemented kd_api_write_breakpoint and kd_api_restore_breakpoint

2017-12-11 Thread Mihail Abakumov
Added supporting of windbg breakpoints. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |2 + windbgstub-utils.c | 62 +++ windbgstub.c|

[Qemu-devel] [PATCH v4 38/46] windbg: implemented kd_api_get_version

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |1 + windbgstub-utils.c | 22 ++ windbgstub.c|4 3 files changed, 27 insertions(+) diff --git a

[Qemu-devel] [PATCH v4 40/46] windbg: implemented kd_api_search_memory

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |1 + windbgstub-utils.c | 33 + windbgstub.c|4 3 files changed, 38 insertions(+) d

[Qemu-devel] [PATCH v4 43/46] windbg: added new api functions

2017-12-11 Thread Mihail Abakumov
Added some definitions for new windbg. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgkd.h | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/include/exec/windbgkd.h b/include/exec/wi

[Qemu-devel] [PATCH v4 39/46] windbg: implemented kd_api_read_msr and kd_api_write_msr

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |2 target/i386/windbgstub.c| 328 +++ windbgstub.c|8 + 3 files changed, 338 insertions(+)

[Qemu-devel] [PATCH v4 45/46] windbg: changed kd_api_read_msr and kd_api_write_msr

2017-12-11 Thread Mihail Abakumov
Added sub functions for helper_wrmsr and helper_rdmsr: cpu_x86_write_msr and cpu_x86_read_msr. Also they are used in packet handlers, i.e. duplication of code is removed. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- target/i386/cpu.h

[Qemu-devel] [PATCH v4 42/46] windbg: implemented kd_api_query_memory

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |1 + windbgstub-utils.c |9 + windbgstub.c|4 3 files changed, 14 insertions(+) diff --git a/include/exec

[Qemu-devel] [PATCH v4 41/46] windbg: implemented kd_api_fill_memory

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |1 + windbgstub-utils.c | 39 +++ windbgstub.c|4 3 files changed, 44 insertions

[Qemu-devel] [PATCH v1 for-2-12 09/15] s390x/tcg: implement TEST PENDING INTERRUPTION

2017-12-11 Thread David Hildenbrand
Use s390_cpu_virt_mem_write() so we can actually revert what we did (re-inject the dequeued IO interrupt). Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 1 + target/s390x/misc_helper.c | 53 ++ ta

[Qemu-devel] [PATCH v4 46/46] windbg: maintainers

2017-12-11 Thread Mihail Abakumov
Added WinDbg stub to the MAINTAINERS. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- MAINTAINERS | 12 1 file changed, 12 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index ccee28b12d..8ee2c780e3 100644 --- a/MAINTAINER

[Qemu-devel] [PATCH v1 for-2-12 10/15] s390x/flic: implement qemu_s390_clear_io_flic()

2017-12-11 Thread David Hildenbrand
Now that we have access to the io interrupts, we can implement clear_io_irq() for TCG. Signed-off-by: David Hildenbrand --- hw/intc/s390_flic.c | 31 +-- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git a/hw/intc/s390_flic.c b/hw/intc/s390_flic.c index 3a2

[Qemu-devel] [PATCH v4 44/46] windbg: implemented kd_api_get_context_ex and kd_api_set_context_ex

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |2 + target/i386/windbgstub.c| 130 --- windbgstub.c| 14 +++- 3 files changed, 106 insertion

qemu-devel@nongnu.org

2017-12-11 Thread Fernando Casas Schössow
Hello Stefan, Thanks for your reply. Fortunately I didn’t have the problem again and it’s not clear how it can be consistently reproduced. Daily backups are running as usual at the moment. If there is anything I can do from my side or if you have any ideas to try to reproduce it let me know. T

Re: [Qemu-devel] [PATCH v6 1/4] vhost-user: add new vhost user messages to support virtio config space

2017-12-11 Thread Stefan Hajnoczi
On Tue, Dec 05, 2017 at 02:27:16PM +0800, Changpeng Liu wrote: > +* VHOST_USER_SET_CONFIG > + Id: 25 > + Equivalent ioctl: N/A > + Master payload: virtio device config space > + > + Submitted by the vhost-user master when the Guest changes the virtio > + device configuratio

Re: [Qemu-devel] [PATCH v13 00/12] Add ARMv8 RAS virtualization support in QEMU

2017-12-11 Thread Igor Mammedov
On Mon, 11 Dec 2017 19:31:14 +0800 gengdongjiu wrote: > Hi maintainer, > > This patch set seems pending about one month, could you help review for > them? Thanks. I'm going to look at ACPI side of it this week. > In this series, except the three patches in [1] are dependent on KVM > imple

[Qemu-devel] [PATCH v1 for-2-12 03/15] s390x/tcg: deliver multiple interrupts in a row

2017-12-11 Thread David Hildenbrand
We have to consider all deliverable interrupts. We now have to take care of the special scenario, where we first inject an interrupt with a WAIT PSW, followed by a !WAIT PSW. (very unlikely but possible) Signed-off-by: David Hildenbrand --- target/s390x/excp_helper.c | 20

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 1/1] s390-ccw-virtio: allow for systems larger that 7.999TB

2017-12-11 Thread David Hildenbrand
On 11.12.2017 13:21, Christian Borntraeger wrote: > KVM does not allow memory regions > KVM_MEM_MAX_NR_PAGES, basically > limiting the memory per slot to 8TB-4k. As memory slots on s390/kvm must > be a multiple of 1MB we need start a new memory region if we cross > 8TB-1M. > > With that (and optim

[Qemu-devel] [PATCH v1 for-2-12 04/15] s390x/flic: simplify flic initialization

2017-12-11 Thread David Hildenbrand
This makes it clearer, which device is used for which accelerator. Signed-off-by: David Hildenbrand --- hw/intc/s390_flic.c | 9 +++-- hw/intc/s390_flic_kvm.c | 12 include/hw/s390x/s390_flic.h | 9 - 3 files changed, 7 insertions(+), 23 deletions(-) dif

Re: [Qemu-devel] [RFC] vhost: check if ring mapping is still valid when building memmap

2017-12-11 Thread Igor Mammedov
On Mon, 11 Dec 2017 11:03:00 + "Dr. David Alan Gilbert" wrote: > * Igor Mammedov (imamm...@redhat.com) wrote: > > On Fri, 8 Dec 2017 17:51:56 + > > "Dr. David Alan Gilbert" wrote: > > > > > * Igor Mammedov (imamm...@redhat.com) wrote: > > > > On Thu, 7 Dec 2017 18:17:51 + > > >

[Qemu-devel] [PATCH v1 for-2-12 07/15] s390x/tcg: tolerate wrong wakeups due to floating interrupts

2017-12-11 Thread David Hildenbrand
This is a preparation for floating interrupt support and only applies to MTTCG, single threaded TCG works just fine. If a floating interrupt wakes up a VCPU and the CPU thinks it can run (clearing cs->halted), at the point where the interrupt would be delivered, already another VCPU might have pick

[Qemu-devel] [PATCH v1 for-2-12 05/15] s390x/tcg: simplify machine check handling

2017-12-11 Thread David Hildenbrand
We currently only support CRW machine checks. This is a preparation for real floating interrupt support. Get rid of the queue and handle it via the bit INTERRUPT_MCHK. We don't rename it for now, as it will be soon gone (when moving crw machine checks into the flic). Please note that this is the

[Qemu-devel] [PATCH v1 for-2-12 00/15] s390x: flic rework, tcg flic support and tcg

2017-12-11 Thread David Hildenbrand
This patch series implements floating interrupt support for TCG and fixes STSI so we can remove warnings related to s390x SMP and MTTCG. KVM code has to be touched in order to factor out the injection routines into the flic ("s390x/flic: factor out injection of floating interrupts"). Basic testing

[Qemu-devel] [PATCH v1 for-2-12 08/15] s390x/flic: make floating interrupts on TCG actually floating

2017-12-11 Thread David Hildenbrand
Move floating interrupt handling into the flic. Floating interrupts will now be considered by all CPUs, not just CPU #0. While at it, convert I/O interrupts to use a list and make sure we properly consider I/O sub-classes in s390_cpu_has_io_int(). Signed-off-by: David Hildenbrand --- hw/intc/s39

[Qemu-devel] [PATCH v1 for-2-12 01/15] cpus: make pause_all_cpus() play with SMP on single threaded TCG

2017-12-11 Thread David Hildenbrand
pause_all_cpus() is sometimes called from a VCPU thread (e.g. s390x during special reset). It cannot deal with multiple VCPUs per Thread (single threaded TCG) yet. Booting an s390x guest with -smp 2 and single threaded TCG from disk currently fails. The DIAG 308 will issue a pause_all_cpus() and w

[Qemu-devel] [PATCH v1 for-2-12 06/15] s390x/flic: factor out injection of floating interrupts

2017-12-11 Thread David Hildenbrand
Let the flic device handle it internally. This will allow us to later on store floating interrupts in the flic for the TCG case. This now also simplifies kvm.c. All that's left is the fallback interface for floating interrupts, which is no triggered directly via the flic in case anything goes wron

[Qemu-devel] [PATCH v1 for-2-12 11/15] s390x/flic: optimize CPU wakeup for TCG

2017-12-11 Thread David Hildenbrand
Kicking all CPUs on every floating interrupt is far from efficient. Let's optimize it at least a little bit. Signed-off-by: David Hildenbrand --- hw/intc/s390_flic.c | 31 +-- target/s390x/cpu.h | 4 target/s390x/internal.h | 5 - 3 files changed,

[Qemu-devel] [PATCH v1 for-2-12 02/15] cpu-exec: fix missed CPU kick during interrupt injection

2017-12-11 Thread David Hildenbrand
The conditional memory barrier not only looks strange but actually is wrong. On s390x, I can reproduce interrupts via cpu_interrupt() not leading to a proper kick out of emulation every now and then. cpu_interrupt() is especially used for inter CPU communication via SIGP (esp. external calls and e

[Qemu-devel] [PATCH v1 for-2-12 14/15] s390x/tcg: remove SMP warning

2017-12-11 Thread David Hildenbrand
We should be pretty good in shape now. Floating interrupts are working and atomic instructions should be atomic. Signed-off-by: David Hildenbrand --- hw/s390x/s390-virtio-ccw.c | 4 1 file changed, 4 deletions(-) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index c1

[Qemu-devel] [PATCH v1 for-2-12 12/15] s390x/tcg: fix size + content of STSI blocks

2017-12-11 Thread David Hildenbrand
All blocks are 4k in size, which is only true for two of them right now. Also some reserved fields were wrong, fix it and convert all reserved fields to u8. This also fixes the LPAR part output in /proc/sysinfo under TCG. (for now, everything was indicated as 0) Signed-off-by: David Hildenbrand

[Qemu-devel] [PATCH v1 for-2-12 13/15] s390x/tcg: STSI overhaul

2017-12-11 Thread David Hildenbrand
Current STSI implementation is a mess, so let's rewrite it. Problems fixed by this patch: 1) The order of exceptions/when recognized is wrong. 2) We have to store to virtual address space, not absolute. 3) Alignment check of the block is missing. 3) The SMP information is not indicated. While at

Re: [Qemu-devel] [v22 1/2] virtio-crypto: Add virtio crypto device specification

2017-12-11 Thread Michael S. Tsirkin
On Mon, Dec 11, 2017 at 02:54:25PM +0100, Halil Pasic wrote: > * I assume one request is supposed to correspond to one descriptor chain. > Right? If yes, could you tell me, where is this expressed in the spec. > > Halil That's always the default for all virtio devices, exceptions have to be noted

Re: [Qemu-devel] [PATCH v6 3/4] contrib/libvhost-user: enable virtio config space messages

2017-12-11 Thread Stefan Hajnoczi
On Tue, Dec 05, 2017 at 02:27:18PM +0800, Changpeng Liu wrote: > @@ -798,6 +801,70 @@ vu_set_slave_req_fd(VuDev *dev, VhostUserMsg *vmsg) > } > > static bool > +vu_get_config(VuDev *dev, VhostUserMsg *vmsg) > +{ > +int ret = -1; > + > +if (dev->iface->get_config) { > +ret = dev-

Re: [Qemu-devel] [RFC PATCH 0/5] Scoped locks using attribute((cleanup))

2017-12-11 Thread Eric Blake
On 12/11/2017 03:38 AM, Peter Maydell wrote: > On 8 December 2017 at 19:40, Eric Blake wrote: >> On 12/08/2017 04:55 AM, Paolo Bonzini wrote: >>> Likewise, >>> >>> QEMU_WITH_LOCK(QemuMutex, guard_name, &some_mutex) { >>> ... >>> } >>> >>> is the same as >>> >>> qemu_mutex_lock(

[Qemu-devel] [PATCH v1 for-2-12 15/15] configure: s390x supports mttcg now

2017-12-11 Thread David Hildenbrand
s390x is ready. Most likely we are missing some pieces, but it should already be in pretty good shape now. Signed-off-by: David Hildenbrand --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 0c6e7572db..1e593b6fab 100755 --- a/configure +++ b/configure

Re: [Qemu-devel] [PATCH v1 for-2-12 04/15] s390x/flic: simplify flic initialization

2017-12-11 Thread Christian Borntraeger
On 12/11/2017 02:47 PM, David Hildenbrand wrote: > This makes it clearer, which device is used for which accelerator. > > Signed-off-by: David Hildenbrand nice. Reviewed-by: Christian Borntraeger > --- > hw/intc/s390_flic.c | 9 +++-- > hw/intc/s390_flic_kvm.c | 12 ---

Re: [Qemu-devel] [PATCH V3] pci: removed the is_express field since a uniform interface was inserted

2017-12-11 Thread Eduardo Habkost
On Mon, Dec 11, 2017 at 03:11:39PM +0200, Yoni Bettan wrote: > > > On 12/07/2017 10:58 PM, Eduardo Habkost wrote: > > On Tue, Dec 05, 2017 at 07:17:06PM +0200, Yoni Bettan wrote: > > > * according to Eduardo Habkost's commit > > >fd3b02c8896d597dd8b9e053dec579cf0386aee1 > > >

Re: [Qemu-devel] [PATCH 2/5] lock-guard: add scoped lock implementation

2017-12-11 Thread Eric Blake
On 12/11/2017 04:16 AM, Stefan Hajnoczi wrote: >>> I don't understand the need for the qemu_lock_guard_is_taken(&name) >>> condition, why not do the following? >>> >>> for (QEMU_LOCK_GUARD(type, name, lock); >>>; >>>qemu_lock_guard_unlock(&name)) >> >> Because that would be an in

Re: [Qemu-devel] [virtio-dev] [PATCH v3 0/7] Vhost-pci for inter-VM communication

2017-12-11 Thread Wang, Wei W
On Monday, December 11, 2017 7:12 PM, Stefan Hajnoczi wrote: > On Sat, Dec 09, 2017 at 04:23:17PM +, Wang, Wei W wrote: > > On Friday, December 8, 2017 4:34 PM, Stefan Hajnoczi wrote: > > > On Fri, Dec 8, 2017 at 6:43 AM, Wei Wang > wrote: > > > > On 12/08/2017 07:54 AM, Michael S. Tsirkin wro

Re: [Qemu-devel] [PATCH v6 2/4] vhost-user-blk: introduce a new vhost-user-blk host device

2017-12-11 Thread Stefan Hajnoczi
On Tue, Dec 05, 2017 at 02:27:17PM +0800, Changpeng Liu wrote: > This commit introduces a new vhost-user device for block, it uses a > chardev to connect with the backend, same with Qemu virito-blk device, > Guest OS still uses the virtio-blk frontend driver. > > To use it, start QEMU with command

Re: [Qemu-devel] [v22 1/2] virtio-crypto: Add virtio crypto device specification

2017-12-11 Thread Halil Pasic
On 12/11/2017 01:56 PM, Longpeng (Mike) wrote: > > > On 2017/12/6 19:01, Halil Pasic wrote: > >> >> >> On 12/06/2017 08:37 AM, Longpeng(Mike) wrote: >>> +\field{outcome_len} is the size of struct virtio_crypto_session_input or >>> +ZERO for the session-destroy operation. >> >> This ain't corre

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 1/1] s390-ccw-virtio: allow for systems larger that 7.999TB

2017-12-11 Thread Christian Borntraeger
On 12/11/2017 02:55 PM, David Hildenbrand wrote: > On 11.12.2017 13:21, Christian Borntraeger wrote: >> KVM does not allow memory regions > KVM_MEM_MAX_NR_PAGES, basically >> limiting the memory per slot to 8TB-4k. As memory slots on s390/kvm must >> be a multiple of 1MB we need start a new memor

Re: [Qemu-devel] [PATCH] baum: Truncate braille device size to 84x1

2017-12-11 Thread Eric Blake
On 12/10/2017 06:19 PM, Samuel Thibault wrote: > Baum device bigger than 84 do not actually exist, some guest drivers > would be upset by such sizes. > > Signed-off-by: Samuel Thibault > --- > chardev/baum.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > @@ -239,6 +239,12 @

Re: [Qemu-devel] [PATCH v6 4/4] contrib/vhost-user-blk: introduce a vhost-user-blk sample application

2017-12-11 Thread Stefan Hajnoczi
> +static int vub_virtio_process_req(VubDev *vdev_blk, > + VuVirtq *vq) > +{ > +VugDev *gdev = &vdev_blk->parent; > +VuDev *vu_dev = &gdev->parent; > +VuVirtqElement *elem; > +uint32_t type; > +unsigned in_num; > +unsigned out_num; > +

Re: [Qemu-devel] [PATCH] baum: Truncate braille device size to 84x1

2017-12-11 Thread Samuel Thibault
Eric Blake, on lun. 11 déc. 2017 08:30:39 -0600, wrote: > On 12/10/2017 06:19 PM, Samuel Thibault wrote: > > Baum device bigger than 84 do not actually exist, some guest drivers > > would be upset by such sizes. > > > > Signed-off-by: Samuel Thibault > > --- > > chardev/baum.c | 8 +++- > >

Re: [Qemu-devel] [PATCH v7 for-2.12 05/25] block: Respect backing bs in bdrv_refresh_filename

2017-12-11 Thread Alberto Garcia
On Mon 20 Nov 2017 09:09:44 PM CET, Max Reitz wrote: > Basically, bdrv_refresh_filename() should respect all children of a > BlockDriverState. However, generally those children are driver-specific, > so this function cannot handle the general case. On the other hand, > there are only few drivers wh

Re: [Qemu-devel] It told me to report this...

2017-12-11 Thread Warner Losh
On Mon, Dec 11, 2017 at 5:33 AM, Daniel P. Berrange wrote: > On Mon, Dec 11, 2017 at 12:29:36PM +, Dr. David Alan Gilbert wrote: > > * Warner Losh (i...@bsdimp.com) wrote: > > > unknown keycodes `empty+aliases(qwerty)', please report to > > > qemu-devel@nongnu.org > > > > > > My X server is M

Re: [Qemu-devel] It told me to report this...

2017-12-11 Thread Warner Losh
On Mon, Dec 11, 2017 at 5:29 AM, Dr. David Alan Gilbert wrote: > * Warner Losh (i...@bsdimp.com) wrote: > > unknown keycodes `empty+aliases(qwerty)', please report to > > qemu-devel@nongnu.org > > > > My X server is Mac XQuartz 2.7.11. I saw this question raised several > years > > ago in the arc

Re: [Qemu-devel] It told me to report this...

2017-12-11 Thread Daniel P. Berrange
On Mon, Dec 11, 2017 at 08:05:29AM -0700, Warner Losh wrote: > On Mon, Dec 11, 2017 at 5:33 AM, Daniel P. Berrange > wrote: > > > On Mon, Dec 11, 2017 at 12:29:36PM +, Dr. David Alan Gilbert wrote: > > > * Warner Losh (i...@bsdimp.com) wrote: > > > > unknown keycodes `empty+aliases(qwerty)',

Re: [Qemu-devel] It told me to report this...

2017-12-11 Thread Daniel P. Berrange
On Mon, Dec 11, 2017 at 08:06:47AM -0700, Warner Losh wrote: > On Mon, Dec 11, 2017 at 5:29 AM, Dr. David Alan Gilbert > wrote: > > > * Warner Losh (i...@bsdimp.com) wrote: > > > unknown keycodes `empty+aliases(qwerty)', please report to > > > qemu-devel@nongnu.org > > > > > > My X server is Mac

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 1/1] s390-ccw-virtio: allow for systems larger that 7.999TB

2017-12-11 Thread Cornelia Huck
On Mon, 11 Dec 2017 15:04:13 +0100 Christian Borntraeger wrote: > On 12/11/2017 02:55 PM, David Hildenbrand wrote: > > On 11.12.2017 13:21, Christian Borntraeger wrote: > >> KVM does not allow memory regions > KVM_MEM_MAX_NR_PAGES, basically > >> limiting the memory per slot to 8TB-4k. As memor

Re: [Qemu-devel] [Qemu-block] [PATCH 3/7] scsi: store unmap offset and nb_sectors in request struct

2017-12-11 Thread Alberto Garcia
On Mon 20 Nov 2017 05:51:00 PM CET, Anton Nefedov wrote: > it allows to report it in the error handler > > Signed-off-by: Anton Nefedov > Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia Berto

[Qemu-devel] [PATCH v2 2/2] virtio-blk: reject configs with logical block size > physical block size

2017-12-11 Thread Mark Kanda
virtio-blk logical block size should never be larger than physical block size because it doesn't make sense to have such configurations. QEMU doesn't have a way to effectively express this condition; the best it can do is report the physical block exponent as 0 - indicating the logical block size e

[Qemu-devel] [PATCH v2 1/2] virtio-blk: make queue size configurable

2017-12-11 Thread Mark Kanda
Depending on the configuration, it can be beneficial to adjust the virtio-blk queue size to something other than the current default of 128. Add a new property to make the queue size configurable. Signed-off-by: Mark Kanda Reviewed-by: Karl Heubaum Reviewed-by: Martin K. Petersen Reviewed-by: A

[Qemu-devel] [PATCH v2 0/2] virtio-blk: miscellaneous changes

2017-12-11 Thread Mark Kanda
v2: add check for maximum queue size [Stefan] This series is for two minor virtio-blk changes. The first patch makes the virtio-blk queue size user configurable. The second patch rejects logical block size > physical block configurations (similar to a recent change in virtio-scsi). Mark Kanda (2)

Re: [Qemu-devel] [PATCH v2 0/2] virtio-blk: miscellaneous changes

2017-12-11 Thread Mark Kanda
On 12/11/2017 4:30 AM, Stefan Hajnoczi wrote: Hi Mark, Please resend as a top level email thread so the continuous integration and patch management tools will detect your patch series. Apologies. I've just resent the series. Thanks, -Mark

Re: [Qemu-devel] [PATCH v6 09/20] parallels: Switch to .bdrv_co_block_status()

2017-12-11 Thread Vladimir Sementsov-Ogievskiy
09.12.2017 19:39, Eric Blake wrote: On 12/09/2017 06:31 AM, Vladimir Sementsov-Ogievskiy wrote: 07.12.2017 23:30, Eric Blake wrote: We are gradually moving away from sector-based interfaces, towards byte-based.  Update the parallels driver accordingly.  Note that the internal function block_sta

Re: [Qemu-devel] [PATCH V3] pci: removed the is_express field since a uniform interface was inserted

2017-12-11 Thread Yoni Bettan
On 12/11/2017 04:19 PM, Eduardo Habkost wrote: On Mon, Dec 11, 2017 at 03:11:39PM +0200, Yoni Bettan wrote: On 12/07/2017 10:58 PM, Eduardo Habkost wrote: On Tue, Dec 05, 2017 at 07:17:06PM +0200, Yoni Bettan wrote: * according to Eduardo Habkost's commit fd3b02c8896d5

Re: [Qemu-devel] [PULL 08/13] target/arm: Pull Thumb insn word loads up to top level

2017-12-11 Thread Peter Maydell
On 10 December 2017 at 18:24, Peter Maydell wrote: > On 8 December 2017 at 23:09, Emilio G. Cota wrote: >> On Thu, Oct 12, 2017 at 17:03:31 +0100, Peter Maydell wrote: >>> Refactor the Thumb decode to do the loads of the instruction words at >>> the top level rather than only loading the second h

Re: [Qemu-devel] [PATCH v1 00/19] re-factor softfloat and add fp16 functions

2017-12-11 Thread Alex Bennée
no-re...@patchew.org writes: > Hi, > > This series seems to have some coding style problems. See output below for > more information: FWIW these are either: - misidentified "spaces prohibited around that ':' (ctx:WxW)" for bitfields - existing softfloat code that has moved - two lines tha

[Qemu-devel] [Bug 1719196] Re: [arm64 ocata] newly created instances are unable to raise network interfaces

2017-12-11 Thread Corey Bryant
Regression testing has passed successfully. zesty-ocata-proposed with stable charms: == Totals == Ran: 102 tests in 1897.0150 sec. - Passed: 93 - Skipped: 9 - Expected Fail: 0 - Unexpected Success: 0 - Failed: 0 Sum of execute time for each test: 1011.5607 sec. zesty-ocata-proposed

[Qemu-devel] [PATCH for-2.11?] target/arm: Generate UNDEF for 32-bit Thumb2 insns

2017-12-11 Thread Peter Maydell
The refactoring of commit 296e5a0a6c3935 has a nasty bug: it accidentally dropped the generation of code to raise the UNDEF exception when disas_thumb2_insn() returns nonzero. This means that 32-bit Thumb2 instruction patterns that ought to UNDEF just act like nops instead. This is likely to break

Re: [Qemu-devel] [v22 1/2] virtio-crypto: Add virtio crypto device specification

2017-12-11 Thread Halil Pasic
On 12/11/2017 03:09 PM, Michael S. Tsirkin wrote: > On Mon, Dec 11, 2017 at 02:54:25PM +0100, Halil Pasic wrote: >> * I assume one request is supposed to correspond to one descriptor chain. >> Right? If yes, could you tell me, where is this expressed in the spec. >> >> Halil > > That's always th

Re: [Qemu-devel] [RFC] vhost: check if ring mapping is still valid when building memmap

2017-12-11 Thread Dr. David Alan Gilbert
* Igor Mammedov (imamm...@redhat.com) wrote: > On Mon, 11 Dec 2017 11:03:00 + > "Dr. David Alan Gilbert" wrote: > > > * Igor Mammedov (imamm...@redhat.com) wrote: > > > On Fri, 8 Dec 2017 17:51:56 + > > > "Dr. David Alan Gilbert" wrote: > > > > > > > * Igor Mammedov (imamm...@redhat.c

Re: [Qemu-devel] [PATCH] scsi: check current request object before use

2017-12-11 Thread Paolo Bonzini
On 06/12/2017 12:34, Darren Kenny wrote: > Are both tests for NULL necessary, the second one would seem to > suffice - but also the first check changes whether esp_dma_done() > would get called or not here: > >  276 if (s->async_len == 0) { >  277 scsi_req_continue(s->current_req); >  

Re: [Qemu-devel] [PATCH] target/i386: add CPU model "Skylake-Server-clflushopt"

2017-12-11 Thread Paolo Bonzini
On 11/12/2017 09:33, Haozhong Zhang wrote: > The only difference from the existing CPU model "Skylake-Server" is > the add of CPUID_7_0_EBX_CLFLUSHOPT, which is missed in "Skylake-Server". > > Signed-off-by: Haozhong Zhang If all Skylake-Server CPUs have it, maybe we can remove it on old machine

Re: [Qemu-devel] [PATCH 00/12] Various build-sys and ASAN related fixes

2017-12-11 Thread no-reply
Hi, This series failed build test on ppc host. Please find the details below. Type: series Message-id: 20171208005825.14587-1-marcandre.lur...@redhat.com Subject: [Qemu-devel] [PATCH 00/12] Various build-sys and ASAN related fixes === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be in

Re: [Qemu-devel] [PATCH] x86/cpu: Enable new SSE/AVX/AVX512 cpu features

2017-12-11 Thread Paolo Bonzini
On 22/11/2017 08:27, Yang Zhong wrote: > Intel IceLake cpu has added new cpu features,AVX512_VBMI2/GFNI/ > VAES/VPCLMULQDQ/AVX512_VNNI/AVX512_BITALG. Those new cpu features > need expose to guest VM. > > The bit definition: > CPUID.(EAX=7,ECX=0):ECX[bit 06] AVX512_VBMI2 > CPUID.(EAX=7,ECX=0):ECX[b

Re: [Qemu-devel] [PATCH 0/3] hyperv: hv msr initialization fixes

2017-12-11 Thread Paolo Bonzini
On 22/11/2017 19:14, Roman Kagan wrote: > These patches fix problems with hyperv msr initialization. > > Evgeny Yakovlev (1): > hyperv: set partition-wide MSRs only on first vcpu > > Roman Kagan (2): > hyperv: ensure SINTx msrs are reset properly > hyperv: make SynIC version msr constant >

Re: [Qemu-devel] [PATCH v1] cpus: make pause_all_cpus() play with SMP on single threaded TCG

2017-12-11 Thread Paolo Bonzini
On 29/11/2017 20:12, David Hildenbrand wrote: > pause_all_cpus() is sometimes called from a VCPU thread (e.g. s390x > during special reset). It cannot deal with multiple VCPUs per Thread > (single threaded TCG) yet. > > Booting an s390x guest with -smp 2 and single threaded TCG from disk > current

Re: [Qemu-devel] [PATCH v1] cpu-exec: fix missed CPU kick during interrupt injection

2017-12-11 Thread Paolo Bonzini
On 29/11/2017 20:13, David Hildenbrand wrote: > The conditional memory barrier not only looks strange but actually is > wrong. > > On s390x, I can reproduce interrupts via cpu_interrupt() not leading to > a proper kick out of emulation every now and then. cpu_interrupt() is > especially used for i

Re: [Qemu-devel] [Qemu-block] [PATCH] blockdev-backup: enable non-root nodes for backup

2017-12-11 Thread Max Reitz
On 2017-12-08 18:09, John Snow wrote: > > > On 12/08/2017 09:30 AM, Max Reitz wrote: >> On 2017-12-05 01:48, John Snow wrote: >>> >>> >>> On 12/04/2017 05:21 PM, Max Reitz wrote: On 2017-12-04 23:15, John Snow wrote: > > > On 12/01/2017 02:41 PM, Max Reitz wrote: >> ((By the

Re: [Qemu-devel] [PATCH v3] rcu: reduce more than 7MB heap memory by malloc_trim()

2017-12-11 Thread Paolo Bonzini
On 07/12/2017 16:06, Yang Zhong wrote: > Which show trim cost time less than 1ms and call_rcu_thread() do 10 times > batch free, the trim also 10 times. > > I also did below changes: > delta=1000, and > next_trim_time = qemu_clock_get_ns(QEMU_CLOCK_HOST) + delta * > last_trim_time >

Re: [Qemu-devel] [PATCH for 2.12] target/i386: Fix compiler warnings

2017-12-11 Thread Paolo Bonzini
On 13/11/2017 07:48, Stefan Weil wrote: > These gcc warnings are fixed: > > target/i386/translate.c:4461:12: warning: > variable ‘prefixes’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Wclobbered] > target/i386/translate.c:4466:9: warning: > variable ‘rex_w’ might be clobbered by ‘longjmp’ or ‘v

Re: [Qemu-devel] [PATCH v1] cpus: make pause_all_cpus() play with SMP on single threaded TCG

2017-12-11 Thread David Hildenbrand
> int vm_stop(RunState state) > { > if (qemu_in_vcpu_thread()) { > @@ -1818,7 +1809,8 @@ int vm_stop(RunState state) > * FIXME: should not return to device code in case > * vm_stop() has been requested. > */ > -cpu_stop_current(); > +qemu_cpu_st

Re: [Qemu-devel] [PATCH v1] cpus: make pause_all_cpus() play with SMP on single threaded TCG

2017-12-11 Thread David Hildenbrand
> -void cpu_stop_current(void) > -{ > -if (current_cpu) { > -qemu_cpu_stop(current_cpu, true); > -} > -} Btw. this does not compile as this is used also in vl.c > - > int vm_stop(RunState state) > { > if (qemu_in_vcpu_thread()) { > @@ -1818,7 +1809,8 @@ int vm_stop(RunStat

[Qemu-devel] [Qemu-trivial] [PATCH] lsi_scsi: add support for PPR Extended Message

2017-12-11 Thread George Kennedy
The LSI 53c895a code does not handle the PPR Extended Message. Add support to handle PPR Extended Message like SDTR and WDTR are handled. That is, to skip past the message bytes and ignore the message. --- hw/scsi/lsi53c895a.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/scsi/lsi

Re: [Qemu-devel] [Qemu-block] [PATCH] blockdev-backup: enable non-root nodes for backup

2017-12-11 Thread John Snow
On 12/11/2017 11:31 AM, Max Reitz wrote: > On 2017-12-08 18:09, John Snow wrote: >> >> >> On 12/08/2017 09:30 AM, Max Reitz wrote: >>> On 2017-12-05 01:48, John Snow wrote: On 12/04/2017 05:21 PM, Max Reitz wrote: > On 2017-12-04 23:15, John Snow wrote: >> >> >> On

Re: [Qemu-devel] [PATCH v1] cpu-exec: fix missed CPU kick during interrupt injection

2017-12-11 Thread David Hildenbrand
> atomic_mb_set can be a little faster on x86, so: > > diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c > index dfba5ebd29..4452cd9856 100644 > --- a/accel/tcg/cpu-exec.c > +++ b/accel/tcg/cpu-exec.c > @@ -528,12 +528,10 @@ static inline bool cpu_handle_interrupt(CPUState *cpu, > >

Re: [Qemu-devel] [PATCH v1] cpus: make pause_all_cpus() play with SMP on single threaded TCG

2017-12-11 Thread Paolo Bonzini
On 11/12/2017 17:44, David Hildenbrand wrote: >> -void cpu_stop_current(void) >> -{ >> -if (current_cpu) { >> -qemu_cpu_stop(current_cpu, true); >> -} >> -} > Btw. this does not compile as this is used also in vl.c > Doh, then I'm applying your patch untouched. Paolo

Re: [Qemu-devel] [PATCH] configure: Fix curses probe for older ncurses

2017-12-11 Thread Peter Maydell
On 26 November 2017 at 21:13, Brad Smith wrote: > Fix the curses probe with older ncurses (.e.g. 5.7, as used by OpenBSD). > > ncurses 5.7 requires _XOPEN_SOURCE_EXTENDED to be defined for WACS_* > constants. > > Signed-off-by: Brad Smith > > > diff --git a/configure b/configure > index 0c6e7572

Re: [Qemu-devel] [Qemu-trivial] [PATCH] lsi_scsi: add support for PPR Extended Message

2017-12-11 Thread Paolo Bonzini
On 11/12/2017 17:45, George Kennedy wrote: > The LSI 53c895a code does not handle the PPR Extended Message. Add > support to handle PPR Extended Message like SDTR and WDTR are handled. > That is, to skip past the message bytes and ignore the message. > > --- >  hw/scsi/lsi53c895a.c | 4 >  1 f

Re: [Qemu-devel] [PATCH v5 0/4] xenfb: Enablement for Windows PV HID frontend

2017-12-11 Thread Anthony PERARD
On Fri, Nov 03, 2017 at 11:56:27AM +, Owen Smith wrote: > Improve the input device model in xenfb, by updating the > Qemu input handlers and adding a feature to allow for > raw (unscaled) absolute coordinates to be represented. > > Changes: > * use keycodedb to generate qcode to linux input

Re: [Qemu-devel] [PATCH for-2.11?] target/arm: Generate UNDEF for 32-bit Thumb2 insns

2017-12-11 Thread Richard Henderson
On 12/11/2017 07:42 AM, Peter Maydell wrote: > The refactoring of commit 296e5a0a6c3935 has a nasty bug: > it accidentally dropped the generation of code to raise > the UNDEF exception when disas_thumb2_insn() returns nonzero. > This means that 32-bit Thumb2 instruction patterns that > ought to UND

Re: [Qemu-devel] [Qemu-block] [PATCH] blockdev-backup: enable non-root nodes for backup

2017-12-11 Thread Max Reitz
On 2017-12-11 17:47, John Snow wrote: > > > On 12/11/2017 11:31 AM, Max Reitz wrote: >> On 2017-12-08 18:09, John Snow wrote: >>> >>> >>> On 12/08/2017 09:30 AM, Max Reitz wrote: On 2017-12-05 01:48, John Snow wrote: > > > On 12/04/2017 05:21 PM, Max Reitz wrote: >> On 2017-1

Re: [Qemu-devel] [Qemu-trivial] [PATCH] lsi_scsi: add support for PPR Extended Message

2017-12-11 Thread George Kennedy
Thank you Paolo, "Signed-off-by: George Kennedy" George On 12/11/2017 11:55 AM, Paolo Bonzini wrote: On 11/12/2017 17:45, George Kennedy wrote: The LSI 53c895a code does not handle the PPR Extended Message. Add support to handle PPR Extended Message like SDTR and WDTR are handled. That is, to

Re: [Qemu-devel] [PATCH 08/17] iotests: Skip 103 for refcount_bits=1

2017-12-11 Thread Max Reitz
On 2017-12-09 02:36, John Snow wrote: > > > On 11/30/2017 08:23 AM, Max Reitz wrote: >> On 2017-11-30 04:18, Fam Zheng wrote: >>> On Thu, 11/23 03:08, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/103 | 2 ++ 1 file changed, 2 insertions(+) diff

Re: [Qemu-devel] [PATCH v1 for-2-12 04/15] s390x/flic: simplify flic initialization

2017-12-11 Thread Cornelia Huck
On Mon, 11 Dec 2017 14:47:29 +0100 David Hildenbrand wrote: > This makes it clearer, which device is used for which accelerator. > > Signed-off-by: David Hildenbrand > --- > hw/intc/s390_flic.c | 9 +++-- > hw/intc/s390_flic_kvm.c | 12 > include/hw/s390x/s390_f

Re: [Qemu-devel] [Qemu-block] [PATCH] blockdev-backup: enable non-root nodes for backup

2017-12-11 Thread John Snow
On 12/11/2017 12:05 PM, Max Reitz wrote: > On 2017-12-11 17:47, John Snow wrote: >> On 12/11/2017 11:31 AM, Max Reitz wrote: >>> On 2017-12-08 18:09, John Snow wrote: On 12/08/2017 09:30 AM, Max Reitz wrote: > On 2017-12-05 01:48, John Snow wrote: >> >> I would say that a bitmap

Re: [Qemu-devel] [PATCH-2.12 v2 2/3] xilinx_spips: Set all of the reset values

2017-12-11 Thread Alistair Francis
On Wed, Dec 6, 2017 at 3:39 PM, francisco iglesias wrote: > Hi Alistair, > > On 6 December 2017 at 23:22, Alistair Francis > wrote: >> >> Following the ZynqMP register spec let's ensure that all reset values >> are set. >> >> Signed-off-by: Alistair Francis >> --- >> V2: >> - Don't bother doubl

Re: [Qemu-devel] [PATCH for-2.11?] target/arm: Generate UNDEF for 32-bit Thumb2 insns

2017-12-11 Thread Peter Maydell
On 11 December 2017 at 17:00, Richard Henderson wrote: > On 12/11/2017 07:42 AM, Peter Maydell wrote: >> The refactoring of commit 296e5a0a6c3935 has a nasty bug: >> it accidentally dropped the generation of code to raise >> the UNDEF exception when disas_thumb2_insn() returns nonzero. >> This mea

Re: [Qemu-devel] [PATCH 08/17] iotests: Skip 103 for refcount_bits=1

2017-12-11 Thread John Snow
On 12/11/2017 12:17 PM, Max Reitz wrote: > On 2017-12-09 02:36, John Snow wrote: >> >> >> On 11/30/2017 08:23 AM, Max Reitz wrote: >>> On 2017-11-30 04:18, Fam Zheng wrote: On Thu, 11/23 03:08, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/103 | 2 ++ >>

Re: [Qemu-devel] [PATCH v3 2/3] xen/pt: Pass the whole msi addr/data to Xen

2017-12-11 Thread Anthony PERARD
On Fri, Nov 17, 2017 at 02:24:24PM +0800, Chao Gao wrote: > Previously, some fields (reserved or unalterable) are filtered by > Qemu. This fields are useless for the legacy interrupt format. > However, these fields are may meaningful (for intel platform) > for the interrupt of remapping format. It

Re: [Qemu-devel] [PATCH v1 for-2-12 09/15] s390x/tcg: implement TEST PENDING INTERRUPTION

2017-12-11 Thread Cornelia Huck
On Mon, 11 Dec 2017 14:47:34 +0100 David Hildenbrand wrote: > Use s390_cpu_virt_mem_write() so we can actually revert what we did > (re-inject the dequeued IO interrupt). > > Signed-off-by: David Hildenbrand > --- > target/s390x/helper.h | 1 + > target/s390x/insn-data.def | 1 + > targ

Re: [Qemu-devel] [PATCH v3 3/3] msi: Handle remappable format interrupt request

2017-12-11 Thread Anthony PERARD
On Fri, Nov 17, 2017 at 02:24:25PM +0800, Chao Gao wrote: > According to VT-d spec Interrupt Remapping and Interrupt Posting -> > Interrupt Remapping -> Interrupt Request Formats On Intel 64 > Platforms, fields of MSI data register have changed. This patch > avoids wrongly regarding a remappable fo

Re: [Qemu-devel] [PATCH for 2.11 0/2] QEMU crashes with CD device without media

2017-12-11 Thread John Snow
On 12/11/2017 05:24 AM, Denis V. Lunev wrote: > On 11/28/2017 03:10 PM, Denis V. Lunev wrote: >> There are 2 cases I have spotted so far: >> 1) IDE ATAPI read processing. Actually this was reported from field >> 2) QEMU IO hmp command (found during evaluation of (1)) >> >> SCSI code checks during

[Qemu-devel] [ANNOUNCE] QEMU 2.11.0-rc5 is now available

2017-12-11 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the sixth release candidate for the QEMU 2.11 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-2.11.0-rc5.tar.xz http://dow

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-12-11 Thread John Snow
On 12/11/2017 06:15 AM, Kevin Wolf wrote: > Am 09.12.2017 um 01:57 hat John Snow geschrieben: >> Here's an idea of what this API might look like without revealing >> explicit merge/split primitives. >> >> A new bitmap property that lets us set retention: >> >> :: block-dirty-bitmap-set-retention

Re: [Qemu-devel] [PATCH v4 4/4] ivshmem: Disable irqfd on device reset

2017-12-11 Thread Markus Armbruster
Ladi Prosek writes: > The effects of ivshmem_enable_irqfd() was not undone on device reset. > > This manifested as: > ivshmem_add_kvm_msi_virq: Assertion `!s->msi_vectors[vector].pdev' failed. > > when irqfd was enabled before reset and then enabled again after reset, making > ivshmem_enable_irqf

<    1   2   3   >